[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 49225
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49225
Bug 15532: Add ability to allow only items whose home/holding branch matches
the hold's pickup branch to fill a given hold

Review of attachment 49225:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15532&attachment=49225)
-----------------------------------------------------------------

::: t/db_dependent/Holds/HoldFulfillmentPolicy.t
@@ +9,5 @@
> +use t::lib::TestBuilder;
> +
> +BEGIN {
> +    use FindBin;
> +    use lib $FindBin::Bin;

Is this useful?

@@ +49,5 @@
> +$dbh->do("DELETE FROM reserves");
> +$dbh->do("DELETE FROM issues");
> +$dbh->do("DELETE FROM items");
> +$dbh->do("DELETE FROM biblio");
> +$dbh->do("DELETE FROM biblioitems");

Why do you delete the entries from these 5 tables?

::: t/db_dependent/HoldsQueue.t
@@ +443,4 @@
>  is( @$holds_queue, 0, "Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled");
>  # End Bug 15062
>  
> +# Test hold_fulfillment_policy

This looks a c/p of t/db_dependent/Holds/HoldFulfillmentPolicy.t

-- 
You are receiving this mail because:
You are watching all bug changes.