[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(I have squashed the patches for the review)

1/
C4/Circulation.pm
1868     my $biblio   = $item_level_itypes ? undef : GetBiblioData( $item->{
biblionumber } ); # don't get bib data unless we need it

Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins per
return?

2/
  prove t/db_dependent/Items.t t/db_dependent/Circulation/Returns.t
displays warnings like
  item-level_itypes set but no itemtype set for item
(Koha::Schema::Result::Item=HASH(0xce35808)->itemnumber) at
Koha/Schema/Result/Item.pm line 662.

-- 
You are receiving this mail because:
You are watching all bug changes.