[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #1)

NVM - error is below, we loop through each reasonforconfirmation, some of these
are borrower fields, when we hit those we print them as the screen message, we
should instead check for the presence of any of these reasons and then log
failed unknown if not equal and output and error to the screen_msg:


  74         foreach my $confirmation (keys %{$needsconfirmation}) {
  75             if ($confirmation eq 'RENEW_ISSUE'){
  76                 $self->screen_msg("Item already checked out to you:
renewing item.");
  77             } elsif ($confirmation eq 'RESERVED' or $confirmation eq
'RESERVE_WAITING') {
  78                 my $x = $self->{item}->available($patron_barcode);
  79                 if ($x) {
  80                     $self->screen_msg("Item was reserved for you.");
  81                 } else {
  82                     $self->screen_msg("Item is reserved for another patron
upon return.");
  83                     # $noerror = 0;
  84                 }
  85             } elsif ($confirmation eq 'ISSUED_TO_ANOTHER') {
  86                 $self->screen_msg("Item already checked out to another
patron.  Please return item for check-in.");
  87                 $noerror = 0;
  88             } elsif ($confirmation eq 'DEBT') {
  89                 $self->screen_msg('Outstanding Fines block issue');
  90                 $noerror = 0;
  91             } elsif ($confirmation eq 'HIGHHOLDS') {
  92                 $overridden_duedate =
$needsconfirmation->{$confirmation}->{returndate};
  93                 $self->screen_msg('Loan period reduced for high-demand
item');
  94             } elsif ($confirmation eq 'RENTALCHARGE') {
  95                 if ($self->{fee_ack} ne 'Y') {
  96                     $noerror = 0;
  97                 }
  98             } else {
  99                 $self->screen_msg($needsconfirmation->{$confirmation});
 100                 $noerror = 0;
 101                 syslog('LOG_DEBUG', "Blocking checkout
Reason:$confirmation");
 102             }
 103         }
 104     }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.