[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 50128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50128&action=edit
Bug 6906 - show 'Borrower has previously issued...

New feature: provide granular means to configure warnings about items
that have been issued to a particular borrower before, according to
their loan history.

- Global syspref ('CheckPrevIssue'), set to 'hardno' by default, allows
  users to enable this feature library wide.
- Per patron category pref allows libraries to create overrides per
  category, falling back on the global setting by default.
- Per patron pref allows switching the functionality on at the level
  of patron. Fall-back to category settings by default.

* Koha/Patron/CheckPrevIssue.pm: New file
* C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevIssue check.
* admin/categories.pl: Pass along checkprevissue.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose
  CheckPrevIssue per category setting.
* koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref:
  Expose CheckPrevIssue syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Expose per patron CheckPrevIssue preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose
  per patron CheckPrevIssue preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add
  'CHECKPREVISSUE' confirmation message.
* installer/data/mysql/kohastructure.sql: Modify structure of
  'categories', 'borrowers'.
* installer/data/mysql/sysprefs.sql: Add 'CheckPrevIssue'.
* installer/data/mysql/atomicupdate/checkPrevIssue.sql: New file.
* t/db_dependent/Patron/CheckPrevIssue.t: New file with unit tests.

Test plan:
- Apply patch.
- Run updatedatabase.
- Regenerate Koha Schema files.
- Run the unit tests.
- Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be
  switched to 'hardyes', 'softyes', 'softno' and 'hardno'.
  + Check out previously issued items to a patron, checking the message
    appears as expected.
- Verify no 'Check previous loans' setting appears on the borrower
  category pages if the syspref is set to a 'hard' option.
- Verify 'Check previous loans' setting appears on the borrower
  category pages and can be modified per borrower category.
  + Issue previously issued items to a borrower, checking the message
    appears as expected (This setting should override the default
    setting if that is set to a 'soft' option).
- Verify no 'Check previous loans' setting appears on the individual
  borrower pages if the syspref is set to a 'hard' option.
- Verify 'Check previous loans' setting appears on individual borrower
  pages and can be modified.
  + Issue previously issued items to a borrower, checking the message
    appears as expected (This setting should override the category
    setting and the default setting if the latter is set to a 'soft'
    option).

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.