[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, testing this.
Export works Ok, all formats.

Import does not work. I created a new auth type, then 'imported' some
of the exported formats, auth_tag_structure and auth_subfield_structure are not
populated, instead auth_tag_structure.pl gives you the option to fill fields
using another auth_type (after some time).

Looking at the logs you find

DBD::mysql::st execute failed: Unknown column 'frameworkcode' in 'where clause'
[for Statement "DELETE FROM auth_tag_structure WHERE frameworkcode=? AND ...

and that's right because, unfortunately,  auth tables use authtypecode instead
of frameworkcode.

Also in the patch
         $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?';
         $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?';
         $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?';
         $query = 'SELECT ' . join(',', @fields) . ' FROM ' . $table . ' WHERE
frameworkcode=?';

Aditionally there are a few tabs that must be removed,
 FAIL   C4/ImportExportFramework.pm
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 234)
                forbidden pattern: tab char (line 285)
                forbidden pattern: tab char (line 236)
                forbidden pattern: tab char (line 235)
                forbidden pattern: tab char (line 237)
                forbidden pattern: tab char (line 232)
                forbidden pattern: tab char (line 233)

-- 
You are receiving this mail because:
You are watching all bug changes.