[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
QA comments:
On the whole, this patch is great. Tests are provided and the code is clean and
pleasant to read. Great job Alex!

1/ I am wondering if the 2 subroutines in Koha::Patron::CheckPrevIssue should
not be methods of Koha::Patron
2/ I think that "Loans"/"Loaned" should be replaced with checkouts/check out
(see http://wiki.koha-community.org/wiki/Terminology)
3/ Please provide test coverage for the changes you made in
C4::Circulation::CanBookBeIssued
4/ In the update DB entry, please add the "after" clause to make sure the
columns will be added at the same place than new installs (kohastructure).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.