[Koha-bugs] [Bug 16259] New: More: Replace CGI->param with CGI->multi_param in list context

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Apr 14 14:06:39 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

            Bug ID: 16259
           Summary: More: Replace CGI->param with CGI->multi_param in list
                    context
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: hblancoca at gmail.com,
                    jonathan.druart at bugs.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 15809, 16154

In my testing of Bug 16154 I found some scripts which are still leaving errors
in the log:

admin/branches.pl
admin/categories.pl
admin/patron-attr-types.pl
admin/preferences.pl
catalogue/itemsearch.pl
catalogue/image.pl
circ/circulation.pl
patroncards/add_user_search.pl
serials/add_user_search.pl
virtualshelves/shelves.pl


Copied from Bug 16154:

  my @foo = $cgi->param('foo');

must be replaced with

  my @foo = $cgi->multi_param('foo');

and

  $template->param( foo => $cgi->param('foo') );

must be replaced with

  $template->param( foo => scalar $cgi->param('foo') );


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809
[Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154
[Bug 16154] Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list