[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thanks for your patch, David.
BTW This is imo not a trivial patch or something to signoff for an academy
user, new to Koha.
[1] Although your changes in SimpleSearch are very small, it would probably
help if you would add a test case in t/db_dependent/Search.t. (It seems to fail
some tests currently, separate from your patch.)
[2] The source_normalizer or norms just lead me to two FIXMEs:
# FIXME normalize, substr
# FIXME - default normalizer
You introduce none and raw in the regex while this field actually does nothing
(and should not have been there in this stage). Your patch starts using this
field, while the only thing you want is not running _normalize for (mainly?)
URLs. If we do not really solve the problem of this unused field, I think we
should not touch it. BTW What would be the difference between raw and none? The
regex suggests more than what we offer.
[3] I have some doubts about this new condition:
    if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) {
Somehow you managed to bump in another unfinished area here too :) 
I would rather leave the condition as it was. In the QParser branch you could
choose to ignore/remove the second specifier word with a similar regex.

Changing status for now.

-- 
You are receiving this mail because:
You are watching all bug changes.