[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 18 11:58:09 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Suggestions:
What about moving all the cronjob prefs to a new "cronjob" tab?
What about a new pref to turn all of these prefs on/off?


Review:
1/ Change in the behavior if the script is called without parameter (help is
not displayed anymore).
I think we should add a confirm flag if the pref will be used and --days is not
given.
2/ +use English qw( -no_match_vars );
why that?
3/ It would have been good to use Pod2usage

Failing QA for 1.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list