[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

--- Comment #39 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Note that - apart from the new feature, various performance enhancements, code
clenups etc., - attachment in comment #30 introduces one pretty important
bugfix:

    - $marcrecord->delete_field($field);
    - $marcrecord->insert_grouped_field($field_to);

    + $field->replace_with($field_to);

Thanks to that, merge() does not mess up field order in biblio records anymore. 

This ("merge() messing up field order in biblio records") is a long standing
issue (since commit efc64f44241efcc8a02ee0a8549a5346cdd026b0, Sat Aug 9
10:53:14 2008 -0500, "Bug fix : use delete_field/insert_grouped_field rather
than replace_with") witch may cause severe data loss in some setups. Quite a
nasty one, not always easy to spot (unless everybody & their dog is using MARC
preview very often in a given setup). I was under the impression that it got
already fixed somewhere around 3.20, but nope, that particular
insert_grouped_field() call is still there in the current master.

I guess technically it's a critical bug (if not a blocker).

-- 
You are receiving this mail because:
You are watching all bug changes.