[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Apr 18 12:41:36 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221
Jacek Ablewicz <ablewicz at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50288|0 |1
is obsolete| |
--- Comment #12 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 50321
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50321&action=edit
Bug 16221: Use Storable::dclone() instead of Clone::clone() for L1 cache
deep-copying mode
Storable dclone() is over 3x faster then Clone::clone() when used for
creating a deep copies of the big, complex data structures like MARC
frameworks. See also Bug 16044 comments #18 & #20.
This is a trivial version of Bug 16166. Performance test
results (see Bug 16140 comment #23 for test setup description):
master
146.29 (14.64+14.53+14.51+14.57+14.72+14.56+14.53+15.06+14.56+14.61)
master + Bug 16221
96.5 (9.77+9.63+9.77+9.77+9.68+9.05+9.68+9.83+9.63+9.69)
master + Bug 16166
90.7 (9.15+9.10+9.16+8.41+9.19+9.19+9.11+9.19+9.02+9.18)
Bug 16166 is a bit faster and more comprehensive implementation, but
also more complex and harder to test/evaluate.
Test plan:
1) apply patch
2) profile GetMarcStructure() calls before / after patch, e.g. by
running some script which calls it often (like catalogue search
w/ XSLT processing turned on, etc.)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list