[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #46)
> (In reply to Kyle M Hall from comment #45)
> > Created attachment 49165 [details] [review] [review]
> > Bug 9805 [QA Followup] - Stop calling GetMember repeatedly
> 
> Kyle, This change looks safe, but it's very hard to say it won't introduce a
> regression. The $borrower var is passed from a sub to another without being
> "refreshed" like it was before this patch. This means we could use an
> outdated data.

I do not believe this is a valid concern. There is no reason to suspect there
could be any problems caused by this. If we force each subroutine in Koha to
fetch all db data with each call, we will continue to make Koha slower and
slower. If you have a specific scenario in mind where this will cause an issue,
I'm certainly open to amending my position. Otherwise I we should keep this
patch to improve speed and efficiency.

-- 
You are receiving this mail because:
You are watching all bug changes.