[Koha-bugs] [Bug 16313] Koha::Logger doesn't forward the Log::Log4perl::Logger return value

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16313

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 50473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50473&action=edit
Bug 16313 - Koha::Logger doesn't forward the Log::Log4perl::Logger return value

    Log::Log4perl::Logger->$method
returns undef if the log level is not logged or something bad happened and
true or something similar on success. This allows chaining different loggers
to trigger if Log4perl failed to log.

Koha::Logger is hardwired to return 1 if Log4perl is configured properly
regardless of whether the Log4perl actually succeeded in printing the log
message.

The following is a Log4perl best practice:

$Koha::Logger->debug() or syslog("LOG_DEBUG", ...);
which should revert to syslog() to log if Log4perl cannot for some reason do
the
logging. (eg. is disabled)

This patch makes the Koha::Logger work with Log4perl better in tandem and
return the proper return values.

See unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.