[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Marcel and Bernardo, I ran the following in kohadevbox:ansible:

$ sudo koha-shell kohadev ; cd kohaclone
$ git grep -l "use t::lib::TestBuilder" | grep -v -e 'pm$' -e Old | xargs prove

The results are:

* Current master
=> SUCCESS: All tests pass in current master

* master + 16155
=> FAIL:

 - t/db_dependent/ILSDI_Services.t fails:
#   Failed test 'Test GetPatronInfo - show_attributes parameter'
#   at t/db_dependent/ILSDI_Services.t line 197.
#     Structures begin differing at:
#          $got = undef
#     $expected = ARRAY(0x8d3b150)
# Looks like you failed 1 test of 16.

 - I see some new warnings, which I assume are related to the original tests
being buggy, so this is a good one for this patchset:

 t/db_dependent/ILSDI_Services.t
=> Violation of unique constraint in Branch
=> Null value for borrowernumber in BorrowerAttribute not allowed

 t/db_dependent/Holds.t
=> Violation of unique constraint in Category

 t/db_dependent/Accounts.t
=> Violation of unique constraint in Branch

That's what I found on a fresh environment (kohadevbox:ansible / jessie)

I fail it because of the failing tests. This patchset is not responsible for
the warnings. Will try to provide a followup and retest.

-- 
You are receiving this mail because:
You are watching all bug changes.