[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me. No errors from qa tools. Holds tests pass (Holds.t
reports two errors before this patch already.)

Still I am passing QA on this patch with some hesitation. I have no good reason
to block this patch, especially since not touching the circulation rules will
not change behavior.

Hesitation is based on:
[1] Simple test plan. We have so many prefs hooking into reserves/holds. How do
we make sure that everything still works? (Tests pass..)
[2] opac-reserve offers pickup locations that will (or may) not allow a hold to
be filled. Should we offer them in the first place in such cases? 
[3] Rules form: Hold pickup library match is rather cryptic. The text above the
rules should be made more clear (it pertains to Hold policy only). The new
field could use some text and additional documentation (online help).

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.