[Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, starting with code review and found a few things:

1) Please make this feature optional! I think not all libraries will want to
use it, while it's very useful for others. I'd suggest to add a preference
here, so it can't be circumvented like CSS would allow to.

2) Some smallish translation issues, easy to fix:
<i>Next available <b>[% ItemTypes.GetDescription( reserveloo.itemtype ) %]</b>
item</i> 
Pending for next available <i>[% ItemTypes.GetDescription( RESERVE.itemtype )
%]</i> item

Tests and QA script pass.

I will continue testing a bit more!

-- 
You are receiving this mail because:
You are watching all bug changes.