[Koha-bugs] [Bug 16389] Reports row limit should change upon option selection

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha,
The patch works as advertise, but I would prefer to see more descriptive/useful
name for the ids.
For instance, the id on the select is not needed.
I'd say we could change the jQuery selector instead to $('select.limit').
On the same way, we could search for the form using the parents() selector, but
I think it's better to select the form by id. But 'limitselect' is not a
correct description for the form element.

-- 
You are receiving this mail because:
You are watching all bug changes.