[Koha-bugs] [Bug 16401] New: System preference staffClientBaseURL hardcoded to 'http' in svc / import_bib

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

            Bug ID: 16401
           Summary: System preference staffClientBaseURL hardcoded to
                    'http' in svc / import_bib
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org

In many points now, in particular in CAS authentication, we use the system
preference staffClientBaseURL as  OPACBaseURL.

The preference should be a complete URL, starting with http:// or https://.

So we need to change svc/import_bib line 101.
From 
my $url = 'http://'. C4::Context->preference('staffClientBaseURL')
.'/cgi-bin/koha/catalogue/detail.pl?biblionumber='. $biblionumber;

To
my $url = C4::Context->preference('staffClientBaseURL')
.'/cgi-bin/koha/catalogue/detail.pl?biblionumber='. $biblionumber;

It is probably a good idea to change also
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref.
Like OPACBaseURL:
" . This should be a complete URL, starting with http:// or https://. Do not
include a trailing slash in the URL. (This must be filled in correctly for CAS,
svc, and load_testing to work.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.