[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Blou from comment #36)
> I understand the need for unit test, practically and philosophically.  But
> this is splitting hair.  It's just a string concat.  Creating a local
> function for a simple string concat simply to test it it just... ugly. 
> Practically and philosophically.  Testing the wellness of the whole
> function, I can dig.  Testing what equals to a perl keyword (I exagerate), I
> think that's just pain.

Splitting hair. Nice to learn some new expressions here (no native speaker,
sorry).
I would agree with you that is not necessary to test string concatenation. We
should be pragmatic in this regard.
I guess the point here is not if you can concatenate strings but if you add
this stuff to the query, will we still have results? Can you predict what will
happen in a test case?
This will be hard because we probably do not like to query external sources in
a unit test.
I once added some stuff in t/db_dependent/Breeding.t in order to start some
testing of this module.

-- 
You are receiving this mail because:
You are watching all bug changes.