[Koha-bugs] [Bug 16282] Usernames should be case sensitive

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 50443
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50443
Bug 16282 : Make check_pw_internal case sensitve for user names

Review of attachment 50443:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16282&attachment=50443)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +1793,5 @@
> +    my $sth;
> +    if ( C4::Context->preference('UsernamesCaseSensitive') ){
> +        # This query does a case sensitive query, but it first does a insensitive one so that the index can still be used
> +        # This will mean we don't get a nasty performance hit
> +        $sth = $dbh->prepare("SELECT * FROM (SELECT password,cardnumber,borrowernumber,userid,firstname,surname,borrowers.branchcode,branches.branchname,flags FROM borrowers JOIN branches ON borrowers.branchcode=branches.branchcode WHERE userid= ?) AS firstpass WHERE BINARY userid = ?");

WHERE BINARY? This is a MySQL-ism, is it not?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.