From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 02:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 00:12:41 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-WCeTcFYjcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Ji?? Kozlovsk? <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007
[Bug 17007] REST API: add route to get biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 02:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 00:12:41 +0000
Subject: [Koha-bugs] [Bug 17007] New: REST API: add route to get biblio
Message-ID: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

            Bug ID: 17007
           Summary: REST API: add route to get biblio
 Change sponsored?: Sponsored
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mail at jkozlovsky.cz
        QA Contact: testopia at bugs.koha-community.org
                CC: black23 at gmail.com, josef.moravec at gmail.com
            Blocks: 16652

Add API route for getting an biblio

GET /api/v1/biblios/{biblionumber} Gets one Biblio


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for
xnciptoolkit drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 02:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 00:12:41 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-AIjFiL1x9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Ji?? Kozlovsk? <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17007

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 04:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 02:34:17 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-P6MvmWuhth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #16 from Liz Rea <liz at catalyst.net.nz> ---
Hi, 

I think this deserves another look by QA.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 05:04:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 03:04:56 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-4keihkbhcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Ji?? Kozlovsk? <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 05:04:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 03:04:58 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-zQrx73R6kS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

--- Comment #1 from Ji?? Kozlovsk? <mail at jkozlovsky.cz> ---
Created attachment 53823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53823&action=edit
Bug 17007: REST API: add route to get biblio

This patch adds route to get one biblio from koha.biblios table. On top of this
biblio there is added key "items" with value being array of items belonging to
the requested biblio.

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/biblios/YYY
   where YYY is an existing biblionumber.
3. Make sure the returned data is correct.
4. Run unit tests in t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 05:17:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 03:17:05 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-TD6afrp8Pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Wasn't there some itype itemtype removal on something elsewhere recently?
Is the permissions check correct still?
Also, still stand by my question about the REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 05:29:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 03:29:57 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-y7BfXjrROq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Ji?? Kozlovsk? <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53823|0                           |1
        is obsolete|                            |

--- Comment #2 from Ji?? Kozlovsk? <mail at jkozlovsky.cz> ---
Created attachment 53824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53824&action=edit
Bug 17007: REST API: add route to get biblio

Since there could be performance problems with retrieving all the
details from all the items belonging to an biblio, there is now
returned only a list of itemnumbers within an "items" key instead of
all the item's properties.

To obtain specific item's properties, use the provided itemnumber to
query REST API for items done by Lari Taskula in bug 16825

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/biblios/YYY
   where YYY is an existing biblionumber.
3. Make sure the returned data is correct.
4. Run unit tests in t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 05:48:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 03:48:10 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-qf1ioil024@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Ji?? Kozlovsk? <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53824|0                           |1
        is obsolete|                            |

--- Comment #3 from Ji?? Kozlovsk? <mail at jkozlovsky.cz> ---
Created attachment 53825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53825&action=edit
Bug 17007: REST API: add route to get biblio

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 07:47:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 05:47:19 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-IWlotUcHQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #12 from Ji?? Kozlovsk? <mail at jkozlovsky.cz> ---
How about returning the due_date of current checkout so that user can create
better idea when it'll be available for him?

I know you already include "expected_available", which is nice, but when there
is also a hold on checkedout item, there is empty value in it.

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 08:04:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 06:04:24 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-SR4Kfiz8uo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #102 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Francois Charbonnier from comment #96)
> (In reply to Katrin Fischer from comment #59)
> 
> > - What is the definition of an "Active transaction"? (was not clear to me,
> > so asking :) )
> 
> The idea behind "Active transactions" is to help balance cash register
> transactions. In other words, how much goes in or how much goes out the cash
> register. The active transactions group what patrons paid or gave as credit
> to the library, which means what went IN the register.
> 
> The code works this way : it takes all transactions where account types  are
> NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L"
> (Lost).

Sorry, I still don't get it :( The list of excluded fine types looks a bit
arbitrary to me - what about custom MANUAL_INV values? And what is left by
excluding those?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 08:06:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 06:06:07 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Ml0FxqPNke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sad to see this stuck - any chance for a rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 09:19:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 07:19:39 +0000
Subject: [Koha-bugs] [Bug 17008] New: REST API: Correct data types in Swagger
Message-ID: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

            Bug ID: 17008
           Summary: REST API: Correct data types in Swagger
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

Currently some data types are oddly defined in Swagger. For example
borrowernumber is defined as a string, even though it and many other *numbers
should be integers/numbers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 09:29:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 07:29:50 +0000
Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in
 staff detail view
In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16427-70-8riEsF0XaA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Direct link to authority    |Direct link to authority
                   |records missing in record   |records missing in staff
                   |detail view                 |detail view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 10:34:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 08:34:33 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-SDrU3zEslY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #4 from Magnus Enger <magnus at libriotech.no> ---
Does this respect records that are hidden in the OPAC? 
http://manual.koha-community.org/16.05/en/administration.html#OpacHiddenItems

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:14:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:14:13 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-f81kd0WA4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #13 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Ji?? Kozlovsk? from comment #11)
> It works for me so far. Are you going to do any further changes to this bug
> or you are willing to mark it as Needs Signoff?
I could mark it as Needs Signoff, maybe it will initiate some more interest on
this :)

(In reply to Ji?? Kozlovsk? from comment #12)
> I know you already include "expected_available", which is nice, but when
> there is also a hold on checkedout item, there is empty value in it.
Thanks Ji??, good catch! Updating the patch to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:15:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:15:21 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-1msJ5iBepx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:15:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:15:24 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-zEsBfxzCUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53813|0                           |1
        is obsolete|                            |

--- Comment #14 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53826&action=edit
Bug 16826: Add API route for getting item availability

Fixes missing "expected_available" from checkout-availability if the item has
holds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:26:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:26:40 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-m481DAJkBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why do you want to unset KOHA_CONF?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:27:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:27:38 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-HNG4kMkCm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:27:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:27:42 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-nsOpOojmGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53826|0                           |1
        is obsolete|                            |

--- Comment #15 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53827&action=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
     "available": false,
     "description": ["onloan"],
     "expected_available": "2016-07-13"
  },
  "hold": {
     "available": true,
     "description": [],
     "expected_available": null
  },
  "local_use": {
     "available": false,
     "description": ["onloan"],
     "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
     "available": false,
     "description": ["onsite_checkouts_disabled"],
     "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Play around with an item. Place a hold on it, checkout, set it damaged etc.
2. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
3. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
4. Repeat steps 1-3 until you are confident the route works as expected.
5. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:28:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:28:39 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-qouk88yHtv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #16 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Lari Taskula from comment #14)
> Created attachment 53826 [details] [review]
> Bug 16826: Add API route for getting item availability
> 
> Fixes missing "expected_available" from checkout-availability if the item
> has holds.

Now it works as expected, nice job!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:45:14 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-qDzVNZa1BX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

--- Comment #5 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Magnus Enger from comment #4)
> Does this respect records that are hidden in the OPAC? 
> http://manual.koha-community.org/16.05/en/administration.html#OpacHiddenItems

Good catch! It doesn't respect the OpacHiddenItems syspref. The reason is that
Koha::Biblio object class doesn't respect it also. It performs a search in DB
given only the biblionumber.

I think we should file a new bug for this in order to preserve single
responsibility.

Btw there are some bugs creating new REST API for items, which should respect
the OpacHiddenItems, but again, to preserve the single responsibility statement
it should be handled from within the middleware - Koha::Items etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:51:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:51:08 +0000
Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from
	login timeout
In-Reply-To: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15006-70-vxPaP7wQKZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #84 from Fr?d?ric Demians <frederic at tamil.fr> ---
I'm about to push this patch on 16.05 branch (with 13807). But what about
'client_timeout' SIPconfig.xml new parameter. Isn't it necessary to display a
warning to admin upgrading the stable branch, in order to advice him/her to
tweak its SIP configuration?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 11:53:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 09:53:10 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-PmdtQaEIB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #26)
> (In reply to Jonathan Druart from comment #25)
> > I don't think I am ready to QA this one.
> > Julian has announced a new plugin system few weeks ago and this patch will
> > adds a precedent for the existing plugin system.
> > Do you have in mind other uses case? Did you plan to extend it to other
> > behaviors?
> > It would be great to ping koha-devel to get other dev opinions.
> 
> Please follow the trace in the see also bug and see that it is already three
> years under way.

I do not understand, are you talking about bug 9743? How this bug report can
answer my questions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:00:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:00:04 +0000
Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from
	login timeout
In-Reply-To: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15006-70-XC1vWenceJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #85 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fr?d?ric Demians from comment #84)
> I'm about to push this patch on 16.05 branch (with 13807). But what about
> 'client_timeout' SIPconfig.xml new parameter. Isn't it necessary to display
> a warning to admin upgrading the stable branch, in order to advice him/her
> to tweak its SIP configuration?

It falls back to the service timeout if it is not present. If you do not have
problems, there may be no direct need to add this parameter.
But printing a line to notify a sysadmin about this option would be fine of
course.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:02:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:02:08 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-CQzNwDGr9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #27)
> (In reply to Marcel de Rooy from comment #26)
> > (In reply to Jonathan Druart from comment #25)
> > > I don't think I am ready to QA this one.
> > > Julian has announced a new plugin system few weeks ago and this patch will
> > > adds a precedent for the existing plugin system.
> > > Do you have in mind other uses case? Did you plan to extend it to other
> > > behaviors?
> > > It would be great to ping koha-devel to get other dev opinions.
> > 
> > Please follow the trace in the see also bug and see that it is already three
> > years under way.
> 
> I do not understand, are you talking about bug 9743? How this bug report can
> answer my questions?

It didn't ? :)
My point is: why block something that I am waiting for over three years because
something else was created a few months ago?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:16:06 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-QTYfsKIoe1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:16:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:16:10 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-8LCfy1NCUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53829&action=edit
Bug 16715: Use Sereal::Decoder and Sereal::Encoder instead of Sereal

Sereal is not packaged for jessie, so let's use Sereal::Encoder and
Sereal::Decoder instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:16:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:16:40 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-E749p9PofE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Second patch is waiting for SO, QA then push!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:19:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:19:34 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-5zSVVtLanG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.11, thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:27:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:27:39 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-XSSlTgbkIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #29 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Jonathan Druart from comment #28)
> Second patch is waiting for SO, QA then push!

I did the exact same patch locally for the latest master package (and would
have sent it today). I'll send a signoff in a few minutes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:28:08 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-Gof9mY6CNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #6 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Jiri Kozlovsky from comment #5)
> (In reply to Magnus Enger from comment #4)
> > Does this respect records that are hidden in the OPAC? 
> > http://manual.koha-community.org/16.05/en/administration.html#OpacHiddenItems
> I think we should file a new bug for this in order to preserve single
> responsibility.

After thinking this through, I've came up with the idea, that Koha::Biblio's
single responsibility is to just retrieve biblios from the DB. So the solution
should probably be in the Koha::REST::V1::Biblios, which this patch creates.

After all, even though API is not OPAC & the syspref is described as "Define
custom rules to hide specific items from search and view on the OPAC. How to
write these rules is documented on the Koha wiki.", I agree with the idea it
should be hidden from borrowers, but not from staff. This is why I'm going to
implement showing OpacHiddenItems only to staff.

Changing the status to In Discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:30:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:30:48 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-DnGqBby2lz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53829|0                           |1
        is obsolete|                            |

--- Comment #30 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53830&action=edit
Bug 16715: Use Sereal::Decoder and Sereal::Encoder instead of Sereal

Sereal is not packaged for jessie, so let's use Sereal::Encoder and
Sereal::Decoder instead.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:31:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:31:05 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-qQkN4E2u9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:42:37 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-t4SWzfGW1D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 16985 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:42:37 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email
 already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-Efr1w5zlx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275
Bug 16275 depends on bug 16985, which changed state.

Bug 16985 Summary: Self registration verification e-mail is broken - no token at the end of the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:42:37 +0000
Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is
 broken - no token at the end of the URL
In-Reply-To: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16985-70-kkw4qk4C0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This seems a duplicate of bug 16960.

*** This bug has been marked as a duplicate of bug 16960 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:45:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:45:50 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email
 already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-WYe58BSdIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #7)
> It seems you can register as many patrons as you want with the same e-mail
> as long as they are not confirmed. I wanted to test to the second patron to
> use the confirmation link, but can't right now. Jonathan, can you describe
> what should happen?

Yes, it is the expected behavior. The test is only done on registered patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:49:43 +0000
Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button
 when a hold is found
In-Reply-To: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11360-70-0tlUC8fpD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #59)
> (In reply to Jonathan Druart from comment #58)
> > Created attachment 53686 [details] [review] [review]
> > Bug 11360 [QA Followup] - Fix styles and button order
> > 
> > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
> 
> Jonathan did you intend to pass qa on this patch set, or did you just add an
> additional sign-off?

I wanted to let Katrin to have another look, but she told me it's ok if I PQA
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:49:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:49:56 +0000
Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected
In-Reply-To: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15397-70-ZwtV2NNLNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.11!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:51:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:51:00 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-XNu4oahdmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #4)
> Kyle, the following test should fail without this patch:
>   is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
> );        
> 
> Could you please adapt it?

The test still passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:56:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:56:07 +0000
Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method
In-Reply-To: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16965-70-akAim1Mtzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #7)
> Jonathan: What do you think of the approach in the third patch?

I liked the idea to have the mappings in one place, it will be easier to know
which classes are already mapped.

Why did you make this change:
-        return $object_class->_wrap(@dbic_rows);
+        return _wrap( $object_class, @dbic_rows );
?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 12:57:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 10:57:07 +0000
Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method
In-Reply-To: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16965-70-J8jdxCFn4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ccing Tomas, Kyle and Martin to get their opinions on this last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:02:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:02:28 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-lBuvUpGHCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > (In reply to Marcel de Rooy from comment #26)
> > > (In reply to Jonathan Druart from comment #25)
> > > > I don't think I am ready to QA this one.
> > > > Julian has announced a new plugin system few weeks ago and this patch will
> > > > adds a precedent for the existing plugin system.
> > > > Do you have in mind other uses case? Did you plan to extend it to other
> > > > behaviors?
> > > > It would be great to ping koha-devel to get other dev opinions.
> > > 
> > > Please follow the trace in the see also bug and see that it is already three
> > > years under way.
> > 
> > I do not understand, are you talking about bug 9743? How this bug report can
> > answer my questions?
> 
> It didn't ? :)
> My point is: why block something that I am waiting for over three years
> because something else was created a few months ago?

The version of the patch on bug 9743 and the first version on this bug report
did not introduced a new way to modify behaviors using plugings. If they get
pushed, we will have a precedent and new patches/plugins will use it. That will
add more stuffs to modify if we decide the switch our plugin system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:05:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:05:45 +0000
Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method
In-Reply-To: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16965-70-4lILiS4tuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> Why did you make this change:
> -        return $object_class->_wrap(@dbic_rows);
> +        return _wrap( $object_class, @dbic_rows );
> ?

Hmm. Somewhere in the process of testing. But we can redo it? We should not
expect a Koha Object class to override a private underscored routine. So this
should be exactly the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:07:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:07:51 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-YO6gaduuEt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Signed Off                  |RESOLVED

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I'm kind of exhausted in finding new ways to get this simple change in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:08:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:08:18 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-sC3kQ1J3UQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:08:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:08:41 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-UeW3NxSXIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:08:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:08:49 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-TkD5N4eLKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:08:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:08:54 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-yqm3joWnZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:11:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:11:48 +0000
Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl
In-Reply-To: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5456-70-IjalxV648c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:11:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:11:51 +0000
Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl
In-Reply-To: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5456-70-0fgM6w6c2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53671|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53831&action=edit
Bug 5456 - Create a link to opac-ics.pl

opac-ics.pl was added to Koha back in 2007, but there has not been a link to it
from anywhere. This patch adds the link from the main view on
/cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself.

Changes to opac-ics.pl:
- Update the code to use date and time for when a loan is due
- Use dt_from_string to turn a MySQL time and date into a DateTime
- Add a timestamp and a UID (these were reported as necessary by a couple of
  iCal validators)
- Remove DTEND from events, since we now have time as well as date for when a
  loan is due
- For loans that are overdue, set the DTSTART to now(), to avoid creating
  calendar events in the past
- Use a template to generate text strings, to make them translatable

To test:
- Apply the patch
- Make sure you have at least a couple of loans, including one overdue
- Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as
  iCal/.ics file"
- Inspect the file in a text editor and/or view the result in a calendar
  appplication. Make sure the data makes sense.
- Sign off and go thee merrily on thine way.

Update 2016-07-25
- Force date_due to UTC to avoid problematic timezone info like this:
  DTSTART:TZID=Europe/Zurich:20160724T235900
- Remove quotes from summary and description

Followed test plan, koha.ics file successfully imported to Thunderbird calendar
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:12:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:12:37 +0000
Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl
In-Reply-To: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5456-70-DWpXiig9gQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |magnus at libriotech.no

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Magnus Enger from comment #8)

Ok, let's push it and we will see later if we need to adapt something :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:13:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:13:49 +0000
Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method
In-Reply-To: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16965-70-VrFxzf0oCZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #10)
> (In reply to Jonathan Druart from comment #8)
> > Why did you make this change:
> > -        return $object_class->_wrap(@dbic_rows);
> > +        return _wrap( $object_class, @dbic_rows );
> > ?
> 
> Hmm. Somewhere in the process of testing. But we can redo it? We should not
> expect a Koha Object class to override a private underscored routine. So
> this should be exactly the same.

Yes, that's the same, that's why I have asked why :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:18:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:18:26 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-8Ps9DGmhCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #30)
> I'm kind of exhausted in finding new ways to get this simple change in Koha.

My goal was not to exhaust you, but just to make sure it was the best thing to
do.
Sorry about that. My suggestion was to ask on koha-devel what others think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:25:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:25:36 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold ( via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-gEw6HQ33Kx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Marcel de Rooy from comment #30)
> > I'm kind of exhausted in finding new ways to get this simple change in Koha.
> 
> My goal was not to exhaust you, but just to make sure it was the best thing
> to do.
> Sorry about that. My suggestion was to ask on koha-devel what others think.

No problem. But I prefer not to keep this report pending for another longer
period of time. Moving it to custom :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:33:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:33:10 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14385-70-xWTx9Memuv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict with
bug 10589 and bug 16335.

Moreover you forgot the changes to sysprefs.sql and an atomic update file.

Mark, bug 10589 is failed QA, do you plan to work on it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:43:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:43:51 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-2SvZ6O3BDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Failed QA                   |RESOLVED

--- Comment #40 from M. Tompsett <mtompset at hotmail.com> ---
I'm working on a refactor in bug 16335, so I'll close this for bug 14385 to
move ahead.

*** This bug has been marked as a duplicate of bug 14385 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:43:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:43:51 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14385-70-nHAfOC4YSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
*** Bug 10589 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:45:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:45:13 +0000
Subject: [Koha-bugs] [Bug 16988] Suspending a hold with
 AutoResumeSuspendedHolds disabled results in error
In-Reply-To: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16988-70-NSc0US2DGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:45:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:45:15 +0000
Subject: [Koha-bugs] [Bug 16988] Suspending a hold with
 AutoResumeSuspendedHolds disabled results in error
In-Reply-To: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16988-70-AAmc1xfemA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53773|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53832&action=edit
Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in
error

iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a
hold from reserve/request.pl results in the following error:

The given date (undefined) does not match the date format (us) at
/home/vagrant/kohaclone/Koha/DateUtils.pm line 152.

Test Plan:
1) Enable SuspendHoldsIntranet
2) Disable AutoResumeSuspendedHolds
3) Attempt to suspend or unsuspend a hold
4) Note the error
5) Apply this patch
6) Repeat step 3
7) The hold should suspend or resume correctly

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Megan Wianecki <mwianecki at mtpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:46:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:46:58 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-fVWMLJ5iC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #33 from M. Tompsett <mtompset at hotmail.com> ---
This may still be applicable, at least conceptually, to bug 14385.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:47:23 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-CUfpHZgppo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14385

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:47:23 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14385-70-XqTrmkb2Cy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10895

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:48:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:48:52 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item ( depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-Oja2AsfOCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #35 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:49:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:49:11 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-Beq2mbsjRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:49:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:49:47 +0000
Subject: [Koha-bugs] [Bug 16680] Library name are not displayed for holds in
	transit
In-Reply-To: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16680-70-qWkXkoqD5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:50:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:50:03 +0000
Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery
 when leaving form fields empty
In-Reply-To: <bug-16707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16707-70-MCGCAjWgWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:50:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:50:19 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-NeqCXB8RaN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:50:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:50:34 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-OKg7Cm4nqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:50:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:50:54 +0000
Subject: [Koha-bugs] [Bug 16705] Status missing in Opac,
	serials subscription history
In-Reply-To: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16705-70-9YwEKbF1ek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16705

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:51:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:51:09 +0000
Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing
In-Reply-To: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16708-70-cNxsY5lwMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:51:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:51:24 +0000
Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as
 of version 16.05)
In-Reply-To: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16724-70-m8l8G3PW4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:51:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:51:39 +0000
Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref
In-Reply-To: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16731-70-LjwBxJ3Jt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:52:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:52:01 +0000
Subject: [Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
In-Reply-To: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16737-70-BX9Cwmj6Mw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:52:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:52:16 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-ar8cetW7Ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:52:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:52:35 +0000
Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about
 Plack::App:: CGIBin instance
In-Reply-To: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16644-70-XZvpWXRfGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:52:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:52:49 +0000
Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
In-Reply-To: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16736-70-CrXbUTtqbB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:53:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:53:04 +0000
Subject: [Koha-bugs] [Bug 16742] Remove unused template subject.tt
In-Reply-To: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16742-70-K1PkB0XOMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:53:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:53:22 +0000
Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated
 "'s"in request.tt
In-Reply-To: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16697-70-XTidaRHshB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:53:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:53:38 +0000
Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence
 splitting by < strong> in about.tt
In-Reply-To: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16718-70-0BDoWOd5Bu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:53:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:53:57 +0000
Subject: [Koha-bugs] [Bug 16751] Fix sitemaper typo
In-Reply-To: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16751-70-IdcXPzeSHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16751

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:54:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:54:12 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-FXGHwIhupN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #32 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:54:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:54:35 +0000
Subject: [Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC
 records template
In-Reply-To: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16468-70-e274YBcbhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:54:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:54:49 +0000
Subject: [Koha-bugs] [Bug 16469] Remove the use of "onclick" from some
	catalog pages
In-Reply-To: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16469-70-GLbVH6Pkwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:55:27 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-g5wLfPvO9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:56:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:56:15 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item ( depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-6ddOzEjS1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:57:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:57:03 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-NGUYYv8EEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail at jkozlovsky.cz
  Attachment #53820|Bug 16330: (followup) fix   |[SIGNED-OFF] Bug 16330:
        description|spelling and number of      |(followup) fix spelling and
                   |tests                       |number of tests

--- Comment #14 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Comment on attachment 53820
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53820
[SIGNED-OFF] Bug 16330: (followup) fix spelling and number of tests

Changed description to have SIGNED-OFF included

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:57:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:57:11 +0000
Subject: [Koha-bugs] [Bug 16680] Library name are not displayed for holds in
	transit
In-Reply-To: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16680-70-bYzkAy8Hj3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:59:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:59:13 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-LTyo5iqaJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 13:59:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 11:59:15 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-7beoiargvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53779|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53833&action=edit
Bug 14844: Corrupted storable string. When adding/editing an Item, cookie
LastCreatedItem might be corrupted.

No idea how to replicate this issue but we have been getting several reports
about the following error:

Software error:

Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line
417, at /home/koha/kohaclone/cataloguing/additem.pl line 375.

TEST PLAN:
1. Add or modify an Item.
2. No observed changes.
?. We don't know what causes this but we know that add/modify Item occasionally
   crashes due to failure of a cookie thawing.

This patch prevents the whole program from dying, because this error is not
critical enough to warrant dying.
Also there is no centralized mechanism in Koha for showing messages to the
user, so there is no easy and convenient way to warn the user that the:
'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is
malfunctioning.

So we instead just warn to the server logs with the malfunctioning cookie in
hopes of nailing down what causes the issues.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:02:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:02:33 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-Jed7NcYaql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:02:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:02:50 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-L2R2MGyWkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:03:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:03:23 +0000
Subject: [Koha-bugs] [Bug 16705] Status missing in Opac,
	serials subscription history
In-Reply-To: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16705-70-ZcjgLzKYjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16705

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:03:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:03:54 +0000
Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as
 of version 16.05)
In-Reply-To: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16724-70-g7REnDMrjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:04:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:04:26 +0000
Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing
In-Reply-To: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16708-70-b0MQmFlsGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:05:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:05:02 +0000
Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref
In-Reply-To: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16731-70-crgY8f5xpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:05:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:05:20 +0000
Subject: [Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
In-Reply-To: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16737-70-968MyZhq3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:05:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:05:35 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-wJpyGZJBqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:05:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:05:50 +0000
Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about
 Plack::App:: CGIBin instance
In-Reply-To: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16644-70-NjLm8yMQlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:03 +0000
Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
In-Reply-To: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16736-70-jgeZyhFotY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:17 +0000
Subject: [Koha-bugs] [Bug 16742] Remove unused template subject.tt
In-Reply-To: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16742-70-3CUrpMqQPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:23 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-4HFKXOwXNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11842
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Introduced by bug 11842.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842
[Bug 11842] MARC framework editing is broken when memcache is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:23 +0000
Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when
 memcache is enabled
In-Reply-To: <bug-11842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11842-70-LjSayyuKpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16955


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955
[Bug 16955] Internal Server Error while populating new framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:31 +0000
Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated
 "'s"in request.tt
In-Reply-To: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16697-70-naioWTAs28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:44 +0000
Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence
 splitting by < strong> in about.tt
In-Reply-To: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16718-70-LuguiQrqV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:06:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:06:59 +0000
Subject: [Koha-bugs] [Bug 16751] Fix sitemaper typo
In-Reply-To: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16751-70-bYI9b7Fvfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16751

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:07:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:07:32 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-LVTrMHzlXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:07:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:07:49 +0000
Subject: [Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC
 records template
In-Reply-To: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16468-70-LgGdGkMlXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:08:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:08:02 +0000
Subject: [Koha-bugs] [Bug 16469] Remove the use of "onclick" from some
	catalog pages
In-Reply-To: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16469-70-bx3Ai3aZsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:08:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:08:18 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-CLf4VoeOIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:18:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:18:54 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-vkTmhirYHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There was a wrong c/p here (you can blame me), the last 2 lines are using
$frameworkcode instead of $newframeworkcode.
Moreover the 4 clear_from_cache calls are inside the while loop, which means
that we are clearing the cache 4 times per subfield (!).
Finally these calls are actually not needed :) As we are creating a new
framework, the cache should be empty...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:20:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:20:15 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-DNT9rCA15r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #6)
> Moreover the 4 clear_from_cache calls are inside the while loop, which means
> that we are clearing the cache 4 times per subfield (!).

Ha, it is added by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:20:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:20:59 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-SAVvCwEnRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:39:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:39:26 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-TpUsK4jB5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:39:29 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-TpfeHkDOdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53825|0                           |1
        is obsolete|                            |

--- Comment #7 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53834&action=edit
Bug 17007: REST API: add route to get biblio

As Magnus Enger pointed out, we should hide all the items defined in the
OpacHiddenItems syspref from all but staff. This patch adds this functionality.

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/biblios/YYY
   where YYY is an existing biblionumber.
3. Make sure the returned data is correct.
4. Find items which are hidden in OPAC with OpacHiddenItems syspref, note their
record's biblionumber and repeat point 2 with it.
5. Check that if you are logged in as staff, you see all the items (even those
hidden from OPAC)
6. Check that if you are not logged in as staff, you see only the items which
are not hidden from OPAC
7. Run unit tests in t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:42:54 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-x61FTZtg8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:43:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:43:15 +0000
Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref
In-Reply-To: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16731-70-vQkm9E1Iqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:43:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:43:42 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-imDUjXzpXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:45:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:45:02 +0000
Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing
In-Reply-To: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16708-70-ldjO2WT4XM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:45:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:45:47 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-Rg2RBskA3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:46:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:46:24 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-V81HSMGBxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17009


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009
[Bug 17009] Duplicating frameworks is unnecessary slow
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:46:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:46:24 +0000
Subject: [Koha-bugs] [Bug 17009] New: Duplicating frameworks is unnecessary
	slow
Message-ID: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

            Bug ID: 17009
           Summary: Duplicating frameworks is unnecessary slow
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 16955

To duplicate frameworks, the code retrieve all the subfields, then execute 1
insert per subfield.
It's unnecessary slow, we can use the DBMS to do it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955
[Bug 16955] Internal Server Error while populating new framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:46:53 +0000
Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method
In-Reply-To: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16965-70-9Iabho7g9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:48:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:48:29 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-MwWZvfC0gM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 14:48:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 12:48:31 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-k3F7n19hnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53835&action=edit
Bug 17009: Speed up the framework duplication

To duplicate frameworks, the code retrieve all the subfields, then
execute 1 insert per subfield.
It's unnecessary slow, we can use the DBMS to do it.

Test plan:
Create a new framework and duplicate the structure of another framework.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:03:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:03:20 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-P5PNvh1Epf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53834|0                           |1
        is obsolete|                            |

--- Comment #8 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53836&action=edit
Bug 17007: REST API: add route to get biblio

Fixed error when user is not staff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:16:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:16:47 +0000
Subject: [Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and
	template
In-Reply-To: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16477-70-hYHxzRDUcl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:17:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:17:07 +0000
Subject: [Koha-bugs] [Bug 16490] Add an "add to cart" link for each search
 results in the staff client
In-Reply-To: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16490-70-u90YBwkfXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:17:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:17:22 +0000
Subject: [Koha-bugs] [Bug 16494] Remove the use of "onclick" from some
	patron pages
In-Reply-To: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16494-70-kdXBFvaH3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:17:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:17:41 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-jWsuAnOiVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:17:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:17:57 +0000
Subject: [Koha-bugs] [Bug 16549] Remove the use of "onclick" from header
	search forms
In-Reply-To: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16549-70-IUyxqSPZKk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:18:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:18:11 +0000
Subject: [Koha-bugs] [Bug 16557] Remove the use of "onclick" from several
	include files
In-Reply-To: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16557-70-ArmJkBZBj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:18:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:18:25 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-SipyA7noFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:18:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:18:40 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-HTvR5PT9ko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:18:58 +0000
Subject: [Koha-bugs] [Bug 16651] Notes field blank for 952$z in
	opac-course-details.pl
In-Reply-To: <bug-16651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16651-70-2ZwuItEBan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:19:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:19:15 +0000
Subject: [Koha-bugs] [Bug 16745] Add edit catalog and edit items links to
	serials toolbar
In-Reply-To: <bug-16745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16745-70-uz4zT5qqSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16745

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:19:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:19:30 +0000
Subject: [Koha-bugs] [Bug 16770] Remove wrong uses of Memoize::Memcached
In-Reply-To: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16770-70-kgnKiH20V0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:19:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:19:46 +0000
Subject: [Koha-bugs] [Bug 16772] Change label from 'For:' to 'Library:' to
 ease translation
In-Reply-To: <bug-16772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16772-70-IY43Bp8LIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16772

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:20:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:20:16 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-rrvkIgy9wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:20:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:20:33 +0000
Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when
	cancelling holds
In-Reply-To: <bug-14968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14968-70-LYiavPt5IA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:20:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:20:52 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-ishN22fvkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:21:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:21:09 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-8UPJA8vT52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:21:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:21:41 +0000
Subject: [Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t
In-Reply-To: <bug-16671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16671-70-aG5d9PzPq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:22:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:22:40 +0000
Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not
 populating itemtype correctly
In-Reply-To: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16760-70-yModGAa3VL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:23:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:23:56 +0000
Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM
 when using 12 hour time format
In-Reply-To: <bug-16780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16780-70-kp9frfgScM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:24:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:24:28 +0000
Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken
In-Reply-To: <bug-16854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16854-70-ywQH88inAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:24:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:24:52 +0000
Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of
 SQL call in export.pl
In-Reply-To: <bug-16855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16855-70-Ae0TX9D9fT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:25:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:25:10 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-B1ZYkuVMob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
The QueryParser configuration file has diverged and shouldn't be a blocker for
this one IMHO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:25:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:25:29 +0000
Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl
In-Reply-To: <bug-16859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16859-70-CZlO3cqxZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:25:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:25:47 +0000
Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown
 parameter from opac-detail.tt
In-Reply-To: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15636-70-AB3RVacKl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:26:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:26:13 +0000
Subject: [Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox
 in some templates
In-Reply-To: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16600-70-GnSkbOpWQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:26:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:26:30 +0000
Subject: [Koha-bugs] [Bug 16774] Format date on 'Transfers to receive' page
 to dateformat system preference
In-Reply-To: <bug-16774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16774-70-F5SpJNRfut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16774

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:27:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:27:02 +0000
Subject: [Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when
 adding/editing a biblio
In-Reply-To: <bug-16807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16807-70-ww53pCLL1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:27:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:27:39 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-6qHp6vVF4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:27:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:27:57 +0000
Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in
 t/db_dependent/ SuggestionEngine_ExplodedTerms.t
In-Reply-To: <bug-16869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16869-70-11ZPJPPfV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:28:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:28:18 +0000
Subject: [Koha-bugs] [Bug 15929] typo in explanation for
 MaxSearchResultsItemsPerRecordStatusCheck
In-Reply-To: <bug-15929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15929-70-2bD3hPDwFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:28:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:28:38 +0000
Subject: [Koha-bugs] [Bug 16779] Move road type after address in US style
 address formatting ( main address)
In-Reply-To: <bug-16779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16779-70-QeKGbvvqGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16779

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:28:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:28:55 +0000
Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of
 images in audio_alerts.tt
In-Reply-To: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16793-70-ybH3jLHmII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:29:14 +0000
Subject: [Koha-bugs] [Bug 16781] Add Font Awesome Icons to "Select/Clear
 all" links to modborrows.tt and result.tt
In-Reply-To: <bug-16781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16781-70-D1H9lgdZko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16781

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:29:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:29:32 +0000
Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron
	categories
In-Reply-To: <bug-16794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16794-70-tw7ny2ujTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:29:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:29:50 +0000
Subject: [Koha-bugs] [Bug 16795] Patron categories: Accept integers only for
 enrolment period and age limits
In-Reply-To: <bug-16795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16795-70-45xfVDFo23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:30:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:30:23 +0000
Subject: [Koha-bugs] [Bug 17010] New: Canceling a hold that has been waiting
 too long from Holds Awaiting Pickup no longer alerts librarian about next
 hold
Message-ID: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

            Bug ID: 17010
           Summary: Canceling a hold that has been waiting too long from
                    Holds Awaiting Pickup no longer alerts librarian about
                    next hold
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In previous versions of Koha, if a hold canceled from the "Holds over" tab had
other holds on it, the librarian would be alerted with the message "This item
is on hold for pick-up at your library" and directed to check it in to fill the
next hold. This no longer happens.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:30:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:30:30 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold that has been waiting too
 long from Holds Awaiting Pickup no longer alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-zETGgB8Wl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:31:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:31:25 +0000
Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear
 all" links to shelves.tt
In-Reply-To: <bug-16803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16803-70-YOlD2SmWXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:31:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:31:42 +0000
Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in
 debian/koha-common.cron.d
In-Reply-To: <bug-16823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16823-70-PvtGg9Rv78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:31:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:31:57 +0000
Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings
 "Argument "" isn' t numeric"
In-Reply-To: <bug-16857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16857-70-zrJo2sOyTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:32:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:32:16 +0000
Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t
In-Reply-To: <bug-16860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16860-70-3TbZwOg8nt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:32:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:32:30 +0000
Subject: [Koha-bugs] [Bug 9259] Delete marc batches from staged marc
	management
In-Reply-To: <bug-9259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9259-70-UPL3OfaWVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #18 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:32:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:32:52 +0000
Subject: [Koha-bugs] [Bug 10760] Use Street Number and Street type in
 Alternate Address section
In-Reply-To: <bug-10760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10760-70-sTVUkDx2ye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #18 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:33:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:33:03 +0000
Subject: [Koha-bugs] [Bug 10760] Use Street Number and Street type in
 Alternate Address section
In-Reply-To: <bug-10760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10760-70-NQp5IhkJOG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:33:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:33:24 +0000
Subject: [Koha-bugs] [Bug 14790] Link to OPAC view from within subscriptions,
 search and item editor
In-Reply-To: <bug-14790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14790-70-n1oYDbJ95W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #22 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:33:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:33:39 +0000
Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when
 returning/ checking in Items
In-Reply-To: <bug-15172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15172-70-HdZWozblCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #19 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:33:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:33:55 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-ha518seBf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:34:17 +0000
Subject: [Koha-bugs] [Bug 16324] Move item search into header
In-Reply-To: <bug-16324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16324-70-HGdwUVeKmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:34:38 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-oIJWXH42Gs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:34:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:34:53 +0000
Subject: [Koha-bugs] [Bug 16677] Use abbr for authorities linked headings
In-Reply-To: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16677-70-MeOHlvBz7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:35:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:35:00 +0000
Subject: [Koha-bugs] [Bug 16677] Use abbr for authorities linked headings
In-Reply-To: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16677-70-6cvUVZ3ZOo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:35:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:35:19 +0000
Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes
 in moremember-brief.tt
In-Reply-To: <bug-16730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16730-70-aCjuMxXLas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:35:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:35:36 +0000
Subject: [Koha-bugs] [Bug 16778] Use Bootstrap modal for card printing on
 patron lists page
In-Reply-To: <bug-16778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16778-70-75nYp2izj4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16778

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:35:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:35:48 +0000
Subject: [Koha-bugs] [Bug 16801] Include Font Awesome Icons to check/ unchek
 all in Administration > Library transfer limits
In-Reply-To: <bug-16801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16801-70-JgVtwbIisJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:36:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:36:05 +0000
Subject: [Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC
In-Reply-To: <bug-16805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16805-70-lUBCIZ7ZTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:36:23 +0000
Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use
 Koha::Holds to delete holds
In-Reply-To: <bug-16819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16819-70-qgjPukpxE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:36:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:36:41 +0000
Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t
In-Reply-To: <bug-16866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16866-70-ukG7SdZRGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:36:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:36:59 +0000
Subject: [Koha-bugs] [Bug 16917] Error when importing patrons,
 Column 'checkprevcheckout'   cannot be null
In-Reply-To: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16917-70-2NbugMXgJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:37:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:37:14 +0000
Subject: [Koha-bugs] [Bug 2735] Authority search in OPAC stops at 15 pages
In-Reply-To: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2735-70-pOsmrMeLq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:37:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:37:35 +0000
Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with
 the CSV profile doesn't set the issue claimed
In-Reply-To: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12178-70-3zp7SPPJoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #22 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:37:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:37:55 +0000
Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from
	login timeout
In-Reply-To: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15006-70-2bG5RxmIUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #86 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:38:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:38:17 +0000
Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification
 tool does not get any patrons
In-Reply-To: <bug-16682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16682-70-VHqCvY7j8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:38:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:38:36 +0000
Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout
In-Reply-To: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16810-70-xrySFhRSds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:38:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:38:51 +0000
Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used
In-Reply-To: <bug-16845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16845-70-7u8yWEXxvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:39:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:39:10 +0000
Subject: [Koha-bugs] [Bug 16890] TestBuilder always generate datetime for
	dates
In-Reply-To: <bug-16890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16890-70-dmkN9GHoIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:39:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:39:27 +0000
Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails
In-Reply-To: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14138-70-Eha0qxLBaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:39:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:39:42 +0000
Subject: [Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied
In-Reply-To: <bug-16813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16813-70-fLOxNw8Is0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:40:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:40:00 +0000
Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not
	been removed
In-Reply-To: <bug-16844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16844-70-ntsJy2mm3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:40:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:40:14 +0000
Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail
	page style
In-Reply-To: <bug-16893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16893-70-5KeLwUehyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:40:27 +0000
Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists
In-Reply-To: <bug-16897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16897-70-mkIJJcFZRc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:40:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:40:47 +0000
Subject: [Koha-bugs] [Bug 16900] Hold suspend button incorrectly styled in
 patron holds list
In-Reply-To: <bug-16900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16900-70-gyWNR7VPFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:41:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:41:08 +0000
Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt
 (sentence splitting)
In-Reply-To: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16621-70-uzYcDUKpsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:41:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:41:24 +0000
Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated
 ' in currency.tt
In-Reply-To: <bug-16701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16701-70-4mU02IdgIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:41:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:41:39 +0000
Subject: [Koha-bugs] [Bug 16777] Correct intranet search alias
In-Reply-To: <bug-16777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16777-70-dWME8vN1gG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16777

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:41:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:41:56 +0000
Subject: [Koha-bugs] [Bug 16812] Revise JS script for z3950_search.tts and
 remove onclick events
In-Reply-To: <bug-16812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16812-70-WoYz7nOnx7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:42:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:42:12 +0000
Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members
In-Reply-To: <bug-16888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16888-70-sipiqCx0cG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:42:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:42:16 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-TonWHGY4I3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #7 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53837&action=edit
Bug 16825: (followup) Add API route for getting an item

Added on top of last patch the OpacHiddenItems syspref restriction for
users who are not staff. They see "Item Not Found" when trying to view
item hidden from OPAC. Only staff can see those

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table
has
a column "itemnotes_nonpublic", which should not be returned if the user
has no
catalogue permission.

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
3. Make sure the returned data is correct.
4. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:42:27 +0000
Subject: [Koha-bugs] [Bug 15853] Add author and link columns to opac course
 reserves table
In-Reply-To: <bug-15853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15853-70-PrYhAnOaiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:42:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:42:50 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-LKz3E3mQ99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:43:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:43:05 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-5csPdWPgjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:43:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:43:21 +0000
Subject: [Koha-bugs] [Bug 16681] Allow update of opacnote via batch patron
 modification tool
In-Reply-To: <bug-16681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16681-70-WYJt8obHRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16681

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:43:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:43:38 +0000
Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC
	Authority search
In-Reply-To: <bug-16876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16876-70-v0RzzsLPpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:43:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:43:40 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-xCElC319dF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com,
                   |                            |mail at jkozlovsky.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:43:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:43:54 +0000
Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in
	the list.
In-Reply-To: <bug-15974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15974-70-zhkyJpsf61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:44:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:44:22 +0000
Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in
 GetborCatFromCatType and GetAuthorisedValues
In-Reply-To: <bug-16716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16716-70-3nA2zzOyG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:44:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:44:37 +0000
Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences
In-Reply-To: <bug-16947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16947-70-aREQuGckWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:44:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:44:58 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-Te3B6DshBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #10)
> Why do you want to unset KOHA_CONF?

You shouldn't. But the stranger question is... why is it only 2 tests that
fail? We should have tests or set of tests that purposefully fail in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:45:12 +0000
Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted
	order line
In-Reply-To: <bug-16934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16934-70-sZFaYZImVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:45:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:45:37 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-yAlUPsUnOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #327 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:45:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:45:54 +0000
Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles
In-Reply-To: <bug-16847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16847-70-PxpOGcUwtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:46:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:46:08 +0000
Subject: [Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top
 of saved SQL reports table
In-Reply-To: <bug-16906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16906-70-OlXQIUtRv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:46:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:46:22 +0000
Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note
 about setting PatronSelfRegistrationDefaultCategory
In-Reply-To: <bug-16945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16945-70-AXSsyRC3KL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:49:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:49:11 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-K2i6KPdJ3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|veron at veron.ch              |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:58:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:58:13 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-H5uBRFbAeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:58:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:58:16 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-qNUwLiHHXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53477|0                           |1
        is obsolete|                            |
  Attachment #53719|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53838&action=edit
Bug 16871: Translatability: Avoid [%%-problem and fix related sentence
splitting in catalogue/detail.tt

In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt,
fix line splitted TT directives and sentence splitting leading
to translatability problems. (See first comment).

To test:
- Apply patch
- Go to detail pages of biblios with waiting holds
- Verify that messages in column 'Status' are OK
- Examine code in patch to make sure that the simplification in logic
  makes sense and that no TT directive is splitted
- Bonus test:
  - Go to folder misc/translator. Run perl translate create xx-XX
  - Verify that monster mentioned in first comment no longer exists
    (in po/xx-XX-staff-prog.po)

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

Amended for wording (comment #5) 2016-07-26 mv

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 15:58:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 13:58:50 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-4S2LpfZiO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's ok for me. I let the RM takes care of the wording.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:02:06 +0000
Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial
 patron and vendor search templates
In-Reply-To: <bug-16968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16968-70-BsCtnN63GK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:02:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:02:09 +0000
Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial
 patron and vendor search templates
In-Reply-To: <bug-16968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16968-70-b8zqlYftzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53722|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53839&action=edit
Bug 16968 - Remove the use of "onclick" from serial patron and vendor search
templates

This patch removes instances of "onclick" from the serials templates for
patron and vendor search.

To test, go to Serials and click "New subscription."

- In the new subscription form, click the "Search for a vendor" link.
- In the popup, search for a vendor. Confirm that clicking "Choose"
  selects the correct vendor.

- From the detail page of an existing subscription, click "Create
  routing list."
- Search for a patron and test that the "Add" button in search results
  works correctly to add patrons to the routing list.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:07:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:07:58 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-rT4seAQ0W2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com
                   |                            |, kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:12:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:12:35 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-j6msAYzVbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 53725
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53725
Bug 16585: Update Italian installer sample files for 16.05

Review of attachment 53725:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16585&attachment=53725)
-----------------------------------------------------------------

::: installer/data/mysql/it-IT/necessari/notices.sql
@@ +7,5 @@
>  ('circulation','DUEDGST','Avviso restituzione (digest)','Avviso restituzione (digest)','Hai <<count>> prestiti da retituire', 'email'),
>  ('circulation','PREDUE','Preavviso scadenza prestito','Preavviso scadenza prestito','Salve <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nQuesti prestiti stanno per scadere:\r\n\r\n<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)', 'email'),
> +('circulation','PREDUEDGST','Preavviso scadenza prestiti (digest)','Avviso copie in scadenza','Gentile <<borrowers.firstname>> <<borrowers.surname>>,
> +Il prestito dei seguenti volumi sta per scadere:
> +

You should use \r\n to line breaks.

::: installer/data/mysql/it-IT/necessari/sample_frequencies.sql
@@ +1,2 @@
>  INSERT INTO subscription_frequencies
> +    (id, description, displayorder, unit, unitsperissue, issuesperunit)

Why do you force the id?

::: installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql
@@ +1,2 @@
>  INSERT INTO subscription_numberpatterns
> +    (id, label, displayorder, description, numberingmethod,

Same here.

::: installer/data/mysql/it-IT/necessari/system_preferences.sql
@@ +20,4 @@
>  UPDATE systempreferences SET value = '1' WHERE variable = 'AllowRenewalLimitOverride';
>  UPDATE systempreferences SET value = 'annual' WHERE variable = 'autoBarcode';
>  UPDATE systempreferences SET value = 'email' WHERE variable = 'AutoEmailPrimaryAddress';
> +UPDATE systempreferences SET value = '1' WHERE variable = 'BiblioAddsAuthorities';

The changes in this file seems very specific but nobody complain until now, so
that should be ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:18:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:18:55 +0000
Subject: [Koha-bugs] [Bug 17011] New: Remove "onblur" event attribute from
	some templates
Message-ID: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

            Bug ID: 17011
           Summary: Remove "onblur" event attribute from some templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Several templates have an inline "onblur" attribute. This event definition
should be moved to the JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:24:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:24:17 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-9o7OqO8zRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tomas, regarding the Koha::Hold->delete method, I think you must provide tests.
Have a look the first patch of bug 16907, I have overwritten
Koha::Patron->delete which log as well and provided relevant tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:25:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:25:05 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-nyR4th8kb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> Tomas, regarding the Koha::Hold->delete method, I think you must provide
> tests.
> Have a look the first patch of bug 16907, I have overwritten
> Koha::Patron->delete which log as well and provided relevant tests.

Will do!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:25:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:25:56 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold that has been waiting too
 long from Holds Awaiting Pickup no longer alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-SemeZUUVkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 53840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53840&action=edit
Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting
Pickup no longer alerts librarian about next hold

In previous versions of Koha, if a hold canceled from the "Holds over" tab had
other holds on it,
the librarian would be alerted with the message "This item is on hold for
pick-up at your library"
and directed to check it in to fill the next hold. This no longer happens.

Test Plan:
1) Apply this patch
2) Find a hold that has been waiting too long
3) Cancel that hold via waitingreserves.pl
4) Note you get the message "This item is on hold for pick-up at your library"
5) Confirm the ok button redirects you to the correct tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:25:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:25:54 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold that has been waiting too
 long from Holds Awaiting Pickup no longer alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-np57Pld0Ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:27:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:27:19 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-HjUQWRC94J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:27:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:27:21 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-JgCqRIz2bi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53841&action=edit
Bug 17011 - Remove "onblur" event attribute from some templates

Several templates have an "onblur" event attribute in the markup. This
patch moves the onblur event definition into the JavaScript.

To test, apply the patch and clear your browser cache if necessary.

In Administration -> Authority types:

  - Choose "New authority type."
  - Enter any text into the "Authority type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> MARC bibliographic framework:

  - Choose "New framework."
  - Enter any text into the "Framework code" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Currencies and exchange rates:

 - Choose "New currency."
  - Enter any text into the "Currency" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Item types

 - Choose "New item type."
  - Enter any text into the "Item type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:38:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:38:53 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-bEkjvsO4N6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Mark, you must provide a SQL query to update the permissions of patrons.
Actually everything should be ok for 95%, but if a patron has create_report but
execute_report (ok that sounds weird), after this patch he won't be able to
delete reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 16:39:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 14:39:08 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-Ruvm9T2m5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #7 from Zeno Tajoli <z.tajoli at cineca.it> ---
Hi,
I answer the request of Jonathan (#6):

>You should use \r\n to line breaks.
I insert "\r\n\r\n" because in Italy we want a empty line in the template.
It is a cosmetic request.
I used "\r\n\r\n" in older version of notices.sql

>Why do you force the id? [in sample_frequencies.sql and in
> sample_numberpatterns.sql]
In fact I insert ids only because I create file directly wirh mysql tools.
I think we can not insert them.

>The changes in this file [system_preferences.sql] seems very specific 
> but nobody complain until now, so that should be ok.
I try to guess the best default for italian users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:00:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:00:33 +0000
Subject: [Koha-bugs] [Bug 17012] New: Remove more event attributes from
 administration templates
Message-ID: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

            Bug ID: 17012
           Summary: Remove more event attributes from administration
                    templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are still some administration templates with event attributes. These
events should be defined in the JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:06:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:06:02 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-r8CQiLHfxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The import tool does not work for me under plack (master), could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:06:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:06:28 +0000
Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named
	Koha::Checkout(s)
In-Reply-To: <bug-16870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16870-70-CLe2pZuFIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:17:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:17:26 +0000
Subject: [Koha-bugs] [Bug 17013] New: build-git-snapshot: add basetgz
 parameter and update master version number
Message-ID: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

            Bug ID: 17013
           Summary: build-git-snapshot: add basetgz parameter and update
                    master version number
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

This adds a basetgz parameter to specify a pbuilder image. I use this to build
against different distributions.

This also updates the version number for master builds to 16.06.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:17:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:17:40 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-ZY5a11RfHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:19:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:19:19 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-wVrHzuSQmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53842&action=edit
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version
number

This adds a basetgz parameter to specify a pbuilder image.
I use this to build against different distributions.

This also updates the version number for master builds to 16.06.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:19:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:19:30 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-CZWXfoeoRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:24:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:24:06 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-RmzIoATP2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13895
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:24:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:24:06 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-R1YUJTYvtY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17005


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
[Bug 17005] REST API: add routes to list checkouts history
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:24:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:24:10 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-JxO1M0eNCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #1 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53843&action=edit
Bug 17005: REST API: add routes to list checkouts history

GET /checkouts/history                                 (get all old_issues'
issue_id)
GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's
old_issues)
GET /checkouts/history/{checkout_id}                   (get old_issue)

+ unit tests in t/db_dependent/api/v1/checkoutshistory.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX
(replace
   XXX with a borrowernumber that has some checkouts history) and check you
receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:25:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:25:36 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-4FByPDUDdM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #2 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Since this bug depends on bug 13895, you should do "git bz apply 13895" first &
then "git bz apply 17005"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:40:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:40:45 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-QXNfU3gpvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1/ Tests in t/db_dependent/Circulation/Returns.t does not pass with these
patches applied.

2/ "This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences."

Hum...

git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
28

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:46:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:46:58 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-gG8d4XpUVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Changes to sysprefs.sql are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:49:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:49:51 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-PVVeVe05sM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:49:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:49:54 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-DzCOvSLC97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53480|0                           |1
        is obsolete|                            |
  Attachment #53481|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53844&action=edit
Bug 16830: Remove -x usage on koha-indexer

This patch just does that, and removes it from the comment on
/etc/default/koha-common

To test:
- Apply the patch
- Run:
  $ vagrant ssh ; cd kohaclone
  $ sudo debian/scripts/koha-indexer --stop kohadev
  $ sudo debian/scripts/koha-indexer --start kohadev
=> SUCCESS: Verify no warning is shown on the indexer-output.log file
- Sign off

https://bugs.koha-community.org/show_bug.cgi?id=16830

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:49:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:49:57 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-LqiHCrdpmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53845&action=edit
Bug 16830: (followup) Remove weird character from warning in rebuild_zebra.pl

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:53:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:53:04 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-IFaoua6c57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 17:53:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 15:53:06 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-Dt1PV0taWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53846&action=edit
Bug 17012 - Remove more event attributes from administration templates

There are several administration templates which still contain event
attributes. This patch move event definition to the JavaScript.

To test you must have the SMSSendDriver system preference set to
"Email." Apply the patch and go to Administration.

- In Global system preferences, change the value of any input or select
  and then click the "Cancel" link for that section. After confirming
  your choice, the page should reload with your changes reset.

- In Circulation and fine rules, edit any existing rule. In the editing
  row, click the "Clear" button. The data for that rule should be
  cleared.

- In Transport cost matrix, make any change to the matrix. Submitting
  the form should work correctly.

- In MARC bibliographic framework, choose 'MARC structure' for any
  framework.
  - Checking or unchecking the 'Display only used tags/subfields'
    checkbox should reload the page and change the display according to
    your choice.

- In Did you mean?, make changes to the existing configuration.
  - Clicking "Cancel" should reload the page and discard your changes.
  - Clicking "Save configuration" should correcly save your changes.

- In SMS cellular providers, click to edit any existing provider.
  Clicking the "Cancel" link should cancel the editing process and
  return you to the list of providers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:05:34 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-ItDDOgL58E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:05:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:05:37 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-ZmIZLrqp5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53761|0                           |1
        is obsolete|                            |
  Attachment #53762|0                           |1
        is obsolete|                            |
  Attachment #53763|0                           |1
        is obsolete|                            |
  Attachment #53764|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53847&action=edit
Bug 16365: Selectively introduce GetMarcStructure() "unsafe" variant for better
performance

GetMarcStructure() currently uses Koha::Cache in the "safe" mode
(returning deep copy of the result data structure by default), which
causes numerous performance issues in many Koha scripts. Switching
it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves
those issues, but ensuring that it is regression-free (and that it
will stay that way in the future) is far from easy. This patch
proposes a bit more manageable solution, it introduces
a possibility to use "unsafe" variant selectively (only in those
places in the code where GetMarcStructure() is called repetitively).
That way, amount of the code that needs to be audited for possible
problems gets vastly reduced, without any performance trade-offs.

Test plan:
1) Have a look at the code and audit the parts affected by this patch
for possible regressions

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended the POD of GetMarcStructure, removing a TODO.

NOTE: GetAuthorisedValueDesc, as called in C4::XSLT::transformMARCXML4XSLT
and by GetISBDView, GetMarcAuthors in C4::Biblio, may autovivify some hash
entries in tagslib.
Same for Koha/Filter/MARC/ViewPolicy.pm, sub filter.

No reason however to worry; our use of this structure in Koha does not
depend on the existence of intermediate hash keys. (We seem to be safe as
long as $tagslib->{$tag}->{$subfield}->{tab} and/or hidden are not filled.)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:05:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:05:41 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-JAtaxo7ejz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53848&action=edit
Bug 16365 - GetMarcStructure() "unsafe" variant in PrepareItemrecordDisplay()

This sub is a good candidate for the "unsafe" treatment too, it doesn't
modify nor autovivify anything in the marc structure.

Added a warning in the code regarding the $tagslib usage by the
custom item plugins, plus a small change to prevent possible
"Use of uninitialized value" warnings in the future.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with neworderempty.pl and itemrecorddisplay.pl.
Amended slightly: Made warning less dramatic.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:05:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:05:46 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-JvV0Y9AC5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53849&action=edit
Bug 16365: Adding additional unsafe call-candidates from Acquisition

[1] Candidate 1 is FillWithDefaultValues.
This routine in Acquisition.pm does not autovivify the tagslib
structure but first collects the keys at tag and subfield level.
So, unsafe can be safely added here :)

[2] Candidate 2 is script acqui/neworderempty.pl.
It only (!) uses GetMarcStructure to know if there is a ACQ framework.
There should be cheaper ways to do it, but when we use the fast cache,
it does not matter that much anymore.

[3] Candidate 3 is script acqui/orderreceive.pl. Same reason as [2].

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with neworderempty.pl

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:05:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:05:50 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-BSFbzME6rQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53850&action=edit
Bug 16365: [QA Follow-up] Add some comment lines to Cache.pm

Resolve typo inifinite too.
Adds a few lines in order to stress that the thawed key of the L1
cache SHOULD ONLY be used for unsafe calls, and not be mixed with
regular (safe) calls.

Test plan:
Nothing to test, but verify the quality of the added comments.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:13:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:13:38 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-GPhI0MINm0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53843|0                           |1
        is obsolete|                            |

--- Comment #3 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53851&action=edit
Bug 17005: REST API: add routes to list checkouts history

GET /checkouts/history                                 (get all old_issues'
issue_id)
GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's
old_issues)
GET /checkouts/history/{checkout_id}                   (get old_issue)

+ unit tests in t/db_dependent/api/v1/checkoutshistory.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX
   (replace XXX with a borrowernumber that has some checkouts history)
   and check you receive correct data
3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY
   with an existing checkout id) and check you receive correct data
4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t

Added promised unit tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:32:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:32:58 +0000
Subject: [Koha-bugs] [Bug 17014] New: Remove more event attributes from
	patron templates
Message-ID: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

            Bug ID: 17014
           Summary: Remove more event attributes from patron templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are many patron-related templates which still use event attributes to
define events. These should be modified so that events are defined in
JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 18:41:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 16:41:45 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-TTYieucVnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53851|0                           |1
        is obsolete|                            |

--- Comment #4 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53852&action=edit
Bug 17005: REST API: add routes to list checkouts history

GET /checkouts/history                                 (get all old_issues'
issue_id)
GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's
old_issues' issue_id)
GET /checkouts/history/{checkout_id}                   (get old_issue)

+ unit tests in t/db_dependent/api/v1/checkoutshistory.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX
   (replace XXX with a borrowernumber that has some checkouts history)
   and check you receive all the issues from patron's history
3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY
   with an existing checkout id) and check you receive correct data
4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t

Now the endpoint with borrowernumber does not return all the details
from within the old issues, but only their issue_id. This is made in
order to enhance API performance. E.g. VuFind can retrieve all the
issue_ids & use AJAX to query details about those, so user sees how the
details come up one by one & does not have to wait for all of them at
once (could be very long with really old users)

In order to get issue details, use the endpoint with the checkout_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:03:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:03:23 +0000
Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements
In-Reply-To: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15108-70-lAPAx5Zfhz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

--- Comment #40 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53853&action=edit
Remove Koha::AtomicUpdater dependency

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:04:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:04:26 +0000
Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements
In-Reply-To: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15108-70-G41KD98OSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:04:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:04:29 +0000
Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements
In-Reply-To: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15108-70-FqSv1HTFrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52423|0                           |1
        is obsolete|                            |

--- Comment #41 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53854&action=edit
Bug 15108 - OAI-PMH provider improvements

- Fixed date handling to use UTC as specs require.

- Added support for second precision in time stamps.

- Added support for marc21 metadata prefix as recommended in the
  guidelines (synonym for marcxml).

- ListIdentifiers and ListRecords always return records in timestamp
  order (faster than biblionumber order with the new index).

- Improved performance of database queries especially for large
  collections.

- Unified functionality of ListRecords and ListIdentifiers to a common
  base class.

- If items are included in the records, their timestamps are taken into
  account everywhere so that whichever is the most recent (timestamp of
  biblioitem or any of its items) is considered the record's timestamp.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:13:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:13:01 +0000
Subject: [Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export
 doesn't reload the page
In-Reply-To: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16808-70-0dAylmF8tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:13:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:13:04 +0000
Subject: [Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export
 doesn't reload the page
In-Reply-To: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16808-70-ZEFlGx011C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52809|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53855&action=edit
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page

When using the CSV export for claiming serial issues, with bug 12178 the
claim counter is incremented and a claim date set, but this will only be
visible after reloading the page manually as the feature itself doesn't
reload the page.

To avoid confusion and errors using this feature,, the page should
reload when the claims data is changed.

Test Plan:
1) Claim some serials
2) Note the page does not reload, the status is not set to 'claimed'
3) Apply this patch
4) Claim some serials
5) Note the page reloads and verify that the status of the selected
   serials are "claimed"

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:29:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:29:03 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-FSMQp7gL5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> ---
There is something wrong (strange) in budget creation:

- Create a new budget

- Click on Save

- A warning is displayed after Start date input box: This field is required.
  And the date picker is displayed

- Pick a date. => The date is copied to the input box, but (1) it is red, and
  (2) the message 'This field is required' is still displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:50:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:50:51 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection and serial edit templates
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-QvztUJakjb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 19:50:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 17:50:54 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection and serial edit templates
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-nansxj4d4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53647|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53856&action=edit
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit
templates

This patch removes the use of event attributes like "onclick" from the
serial collection and serial edit templates. Events are now defined in
JavaScript.

Also changed: Converted "create routing list," "edit routing list," and
"Renew" links to Bootstrap buttons. The "select all" and "clear all"
links have Font Awesome icons added.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
    "Multi receiving" button works correctly.
- For any subscription, test that the "Generate next" button works
  correctly.
- In each tab, test that the "select all" and "clear all" links work
  correctly.
- On a subscription which has expired, test that the "Renew" button
  works correctly.
- On the serial collection page, select multiple issues and click the
  "Edit serials" button.
  - Testing with a subscription for which an item record is NOT created
    when receiving:
    - Changing the status to "Arrived" or "Claimed" should change the
      "Expected on" date to today's date. Selecting any other status
      should leave the "expected on" date as it was or return it to its
      original value.
    - Test that the "Multi receiving" button works correctly.
  - Testing with a subscription for which an item record IS created when
    receiving:
    - Changing the status of an issue should work as above but should
      also trigger the appearance of the item add form when the status
      is "Arrived" or "Claimed," and hide the form otherwise.
    - Cliking the "Item" link at the top of the item add form should
      hide it.
    - Clicking the "Add item" link under any issue should display the
      item add form.
    - In the item add form, test that repeatable fields are correctly
      duplicated when you click the "clone" button.
    - On the "Supplemental issue" line, changing the status to "Arrived"
      should work as described above. Changing the status on this line
      to "Claimed" should only change the "Expected on" date.
    - Adding regular and supplemental issues should work correctly.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Works as described.

https://bugs.koha-community.org/show_bug.cgi?id=16692

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:01:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:01:16 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-m3F6xjkqe8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:01:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:01:18 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-rySb2m4MVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53846|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53857&action=edit
Bug 17012 - Remove more event attributes from administration templates

There are several administration templates which still contain event
attributes. This patch move event definition to the JavaScript.

To test you must have the SMSSendDriver system preference set to
"Email." Apply the patch and go to Administration.

- In Global system preferences, change the value of any input or select
  and then click the "Cancel" link for that section. After confirming
  your choice, the page should reload with your changes reset.

- In Circulation and fine rules, edit any existing rule. In the editing
  row, click the "Clear" button. The data for that rule should be
  cleared.

- In Transport cost matrix, make any change to the matrix. Submitting
  the form should work correctly.

- In MARC bibliographic framework, choose 'MARC structure' for any
  framework.
  - Checking or unchecking the 'Display only used tags/subfields'
    checkbox should reload the page and change the display according to
    your choice.

- In Did you mean?, make changes to the existing configuration.
  - Clicking "Cancel" should reload the page and discard your changes.
  - Clicking "Save configuration" should correcly save your changes.

- In SMS cellular providers, click to edit any existing provider.
  Clicking the "Cancel" link should cancel the editing process and
  return you to the list of providers.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:03:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:03:53 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-3OrGL6WUAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53852|0                           |1
        is obsolete|                            |

--- Comment #5 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53858&action=edit
Bug 17005: REST API: add routes to list checkouts history

GET /checkouts/history                                 (get all old_issues'
issue_id)
GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's
old_issues' issue_id)
GET /checkouts/history/{checkout_id}                   (get old_issue)

+ unit tests in t/db_dependent/api/v1/checkoutshistory.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX
   (replace XXX with a borrowernumber that has some checkouts history)
   and check you receive all the issues from patron's history
3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY
   with an existing checkout id) and check you receive correct data
4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t

This patch on top of previous changes adds the condition that the old
issue included in any response must have itemnumber. Those which does
not have itemnumber does not count as such old issue is completely
useless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:07:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:07:25 +0000
Subject: [Koha-bugs] [Bug 17015] New: New Koha Calendar
Message-ID: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

            Bug ID: 17015
           Summary: New Koha Calendar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Holidays
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mehdi.hamidi at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

We are trying to create a new Koha calendar system. The one available right now
is way too slow. This is the first patch of the calendar, it doesn't affect the
functioning of the current calendar, but it works in parallel with it. Instead
of having multiple tables for the holidays, we created one table, called
discrete_calendar. This table contains the dates,branchcode, opening/closing
hours, a note about the holiday and whether the library is open or not. 

The script misc/generate_discrete_calendar.pl fills the table discrete_calendar
based on tables : repeatable_holidays, special_holidays, openinghours and
branches. The script, by default, will add 2 years from the past and 1 year in
the future in the table discrete_calendar. It also has an option to added more
than 1 year in the future.

The script misc/cronjobs/add_days_discrete_calendar.pl will add days in the
future in the table discrete calendar. A day's opening and closing hours will
be based on the same weekday from the week before. It will also check if the
same day from last year was a holiday, if so, this will be counted as a
holiday.
The script makes sur there's at least 1 year in the future. So if it hasn't ran
for 8 days, 8 days will be added in he future the next time the script is
executed.

There's also an atomic update to create the table.

The current options are not final and they can be changed for convenience.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:07:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:07:37 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-yGezdOH2iU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:26:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:26:18 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-9M32yaolHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #1 from Mehdi Hamidi <mehdi.hamidi at inlibro.com> ---
Created attachment 53859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53859&action=edit
Bug - 17015 New calendar

The new calendar is now in the table discreate_calendar.
All holidays will be indicated in this table.
Closing and opening hours will be available on this table as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:26:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:26:39 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-olc8M7PtvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mehdi.hamidi at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:40:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:40:20 +0000
Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using
 "global" action.
In-Reply-To: <bug-8016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8016-70-2oNTy8fNgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:44:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:44:57 +0000
Subject: [Koha-bugs] [Bug 17014] Remove more event attributes from patron
	templates
In-Reply-To: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17014-70-eF4UaKkwKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:44:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:44:59 +0000
Subject: [Koha-bugs] [Bug 17014] Remove more event attributes from patron
	templates
In-Reply-To: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17014-70-uQpBUP8Pgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53860&action=edit
Bug 17014 - Remove more event attributes from patron templates

There are many patron-related templates which still use event attributes
to define events. This patch updates these templates so that events are
defined in JavaScript.

To test apply the patch and check out to a patron.

- From the Print menu in the toolbar, choose "Print summary." The patron
  summary page should open and the print dialog should be automatically
  triggered.

- From the Print menu in the toolbar, choose "Print slip." The patron
  slip page should open and the print dialog should be automatically
  triggered.

- From the Print menu in the toolbar, choose "Print quick slip." The
  patron quick slip page should open and the print dialog should be
  automatically triggered.

- Click the patron's "Fines" tab in the left-hand sidebar and then
  choose the "Account" tab.
  -- Click the "Print" button for an account payment (the link should
     point to printfeercpt.pl). A print receipt page should open and
     the print dialog should be automatically triggered.
  -- Follow the same procedure for a transaction which is not an account
     payment (the link should point to printinvoice.pl).

- Click the "Create manual invoice" tab.
  -- Select one of the "type" choices. Doing so should automatically
     populate the "Description" field with the corresponding code.
  -- If necessary, define one or more values for the MANUAL_INV
     authorized value and confirm that those invoice types work as well.

- From the patron's "Pay fines" tab, click the "Pay amount" button. In
  the "collect from patron" field, enter any combination of letters,
  numbers, and symbols. When you tab away from that field your text
  should be reformatted to currency format.

- From the patrons home page, change the filter in the left-hand sidebar
  and submit it. The correct results should be returned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 20:51:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 18:51:44 +0000
Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to
	SMS::Send drivers
In-Reply-To: <bug-13029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13029-70-I1PSvGDBT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029

--- Comment #9 from Magnus Enger <magnus at libriotech.no> ---
Any chance of this patch getting some more attention?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:18:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:18:48 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-Ks9kgCs5dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Hi Jonathan,

Sorry, I have no time at the mmoment to fix this.

Can you provide an alternative patch?

Thanks
Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:26:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:26:28 +0000
Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is
 broken - no token at the end of the URL
In-Reply-To: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16985-70-CqaZ4Bd0yF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Jonathan, are you sure it's a duplicate?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:35:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:35:02 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-yIlbSNwrZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>It will also check if the
>same day from last year was a holiday, if so, this will be counted as a
>holiday.

This sounds like a wrong assumption. Most of the holidays here are not on the
same date every year - so this would create a horrible mess. It's the reason
why you can choose to have unique holidays and holidays that repeat every year
with the current system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:40:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:40:04 +0000
Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number,
	Identifier-standard
In-Reply-To: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16986-70-d8BkK9brNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6499

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Srdjan, I just saw that bug 6499 has passed QA - is this ok for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:40:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:40:04 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-6g4WuQgdQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16986

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:45:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:45:13 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-DigkcF0BIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Katrin Fischer from comment #2)
> >It will also check if the
> >same day from last year was a holiday, if so, this will be counted as a
> >holiday.
> 
> This sounds like a wrong assumption. Most of the holidays here are not on
> the same date every year - so this would create a horrible mess. It's the
> reason why you can choose to have unique holidays and holidays that repeat
> every year with the current system.

I agree this sounds like a big step backwards in functionality. The first step
of any rewrite/refactor should be to make sure all existing functionality is
not lost.
The calendar is vitally important, so many things depend on it, it is vital we
don't lose functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 22:51:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 20:51:43 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-oWnduupt5t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #6)
> Mark, you must provide a SQL query to update the permissions of patrons.
> Actually everything should be ok for 95%, but if a patron has create_report
> but execute_report (ok that sounds weird), after this patch he won't be able
> to delete reports.

DOH! Thanks for catching that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:28:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:28:26 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-ehCwSdraqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:28:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:28:30 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-yqLoro6lWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53830|0                           |1
        is obsolete|                            |

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 53861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53861&action=edit
[PASSED QA] Bug 16715: Use Sereal::Decoder and Sereal::Encoder instead of
Sereal

Sereal is not packaged for jessie, so let's use Sereal::Encoder and
Sereal::Decoder instead.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:33:25 +0000
Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button
 when a hold is found
In-Reply-To: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11360-70-6MHURMAXWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just took another look - agree with Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:42:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:42:47 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-KyJr1r01JQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like bouzid.fergani at inlibro.com's sign-off got lost along the way. 

I am not sure how much the patch set was changed after the initial sign off -
setting to Failed QA to get David's or Bouzid's attention.

Patches still apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:46:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:46:11 +0000
Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff
 client search results for lost , withdrawn, and damaged
In-Reply-To: <bug-15922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15922-70-t85jYIgR4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In my opinion dealing with the other pages in separate bugs sounds ok, but we
should file them now so the missing behaviour is better documented.

As we got libraries differentiating between lost and missing and sometimes
using the different status for 'odd' things they need, I can't say they are
always left unchanged :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  1 23:51:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 21:51:42 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-Gk8mvyTQvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, not sure - but couldn't you use a public SQL report to achieve the same?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:11:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:11:24 +0000
Subject: [Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export
 doesn't reload the page
In-Reply-To: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16808-70-jCziOmMmbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The way this patch works creates a warning about resending the page in Firefox
47 (mine is German, so copying the message here probably won't help much).
This might turn some users away thinking it's a bug, especially since the
message appears before the download with a warning sound. Is there a better way
to achieve that? Could we not just reload the page like other forms do?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:12:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:12:52 +0000
Subject: [Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export
 doesn't reload the page
In-Reply-To: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16808-70-U3DbGcJpeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The warning reads something like this: this will make firefox reload the page
and will cause all actions to be repeated (like a search or an ordering
process)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:13:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:13:58 +0000
Subject: [Koha-bugs] [Bug 16957] Fine amount does not display on patron
	checkout page
In-Reply-To: <bug-16957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16957-70-jjGxK2t3mV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16957

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16810 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:13:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:13:58 +0000
Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout
In-Reply-To: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16810-70-2P6pE4sruf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vimal0212 at gmail.com

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16957 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:18:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:18:20 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-4y7G8PxpXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Upping severity - appears to have bad side effects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:37:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:37:29 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-i0D9LdM99s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Prevent patron creation if  |Prevent patron self
                   |the email already filled in |registration if the email
                   |borrowers.email             |already filled in
                   |                            |borrowers.email

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:38:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:38:21 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-F2GLkBwzKH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:38:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:38:24 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-BWv2cwur6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51181|0                           |1
        is obsolete|                            |
  Attachment #51182|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 53862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53862&action=edit
[PASSED QA] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No errors

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:39:16 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-vtjIo4FbWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 53863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53863&action=edit
[PASSED QA] Bug 16275: Do not allow a self registration with an existing email
address

To avoid multiple registrations, it would be good to check the unicity
of the primary email address.
This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique.
If on, a patron will get "This email address already exists in our
database" if he try to register with an existing email address.

Test plan:
1/ Register a new patron with an email address
2/ Make an other registration using the same email address
=> With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be
allowed
=> With the pref off, no change should be noticed.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:39:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:39:59 +0000
Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is
 broken - no token at the end of the URL
In-Reply-To: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16985-70-9CKmtkEssA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16275                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275
[Bug 16275] Prevent patron self registration if the email already filled in
borrowers.email
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 00:39:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 22:39:59 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-bZ17EMIVkb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16985                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985
[Bug 16985] Self registration verification e-mail is broken - no token at the
end of the URL
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:13:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:13:58 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-ay7JXCWYlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #98 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #97)
> PerlDependencies issue.

Could you elaborate?

I've added the Perl dependency.

https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10662&attachment=53362

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:16:36 +0000
Subject: [Koha-bugs] [Bug 10816] Relational operators in Search
In-Reply-To: <bug-10816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10816-70-HzBuaA9oFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nicole C. Engard from comment #1)
> So, how should we edit this section? I didn't write this guide so I'm open
> to tips/suggestions.

That's a good question. Ideally, someone (e.g. me) would try everything from
the current guide to see if it works or not, then maybe fill in any gaps.

With the addition of ElasticSearch, that's going to become a lot more difficult
though, I think. 

Unfortunately, I'm not working much on Koha at the moment, so I don't have time
to do this myself :/.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:11:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:11:59 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-cMFpupl758@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
To be honest, I don't know what I'm supposed to do about this patch anymore.

I don't think Marcel liked my patch, but his suggestions weren't feasible,
so... I don't know. I'm not inclined to work on it, since I'm not sure what I
need to do to get it to an acceptable point.

It's essentially a duplicate of bug 14238 anyway, so perhaps Kyle can write his
own patch. I would be happy to add my sign off to that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:29:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:29:03 +0000
Subject: [Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper
	record
In-Reply-To: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16921-70-xEZnTo8UWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nicholas van Oudtshoorn from comment #4)
> Thanks Joy and Jacek,
> 
> Hmmm - I was on 2.0.58 of zebra - updated now, and things seem a lot better.

>     Theology, Doctrinal
>     Theology, Doctrinal-popular Works
>     Theology, Doctrinal.
> Not sure what that second one is doing being brought in...
> 

Nicholas, are you on 2.0.59? If so, that hyphen is what's causing the problem.
See bug 16581.

I've been warning the community for a long time that the version of Zebra in
Debian is bad when using ICU, but those warnings have mostly been ignored.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:30:09 +0000
Subject: [Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper
	record
In-Reply-To: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16921-70-FlsIn0VzLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Joy Nelson from comment #3)
> I also am not seeing any oddities in my search results of authorities, nor
> any mismatches in the linker script.  Normally the oddities with the linker
> script are due to setting in the system preferences.   I have heard of other
> sites with issues with the linker that appeared to be a result of their
> zebra config.  
> -joy
> 

If I recall correctly, I think Bywater has often shown a preference for using
IndexData's repositories for Zebra? So you might have a more up-to-date version
of Zebra than Nicholas, I think.

Of course, this comment and my last one are after skimming this bug report for
approximately 2 seconds, so I might be misreading :).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:37:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:37:00 +0000
Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple
In-Reply-To: <bug-7170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7170-70-ihZmTM4QOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #19)
> I was looking in the svc ones and came up with this hackiness.
> 
> You can see why XML::Simple with its XMLout method is desirable. :)

That does indeed appear very hacky. It doesn't need to be so hacky. I have
quite a bit of experience with XML::LibXML, and it wouldn't be hard to write a
solid predictable output function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:37:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:37:20 +0000
Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple
In-Reply-To: <bug-7170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7170-70-MgcrbkmMwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Chris Cormack from comment #20)
> > 
> > You can see why XML::Simple with its XMLout method is desirable. :)
> 
> Except I work with the Author of XML::Simple and as David has already
> pointed out, he recommends no one uses it.

But this more than anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:38:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:38:51 +0000
Subject: [Koha-bugs] [Bug 12268] Subject Broader Narrower Related terms and
 Query Parser and Exploded Terms issues
In-Reply-To: <bug-12268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12268-70-aCVdC6ppNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12268

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #2)
> What should happen with QueryParser in its current state?

That's a very good question. In my opinion, we should probably remove it from
the code, since its use is problematic and it doesn't really have anyone to
develop/maintain it. I would volunteer to work on it, but I don't have the
time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:40:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:40:02 +0000
Subject: [Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on
In-Reply-To: <bug-14238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14238-70-0SbJ9KkueK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Kyle, what do you need to move forward on this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 01:42:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Aug 2016 23:42:08 +0000
Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number,
	Identifier-standard
In-Reply-To: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16986-70-I5PapMBq3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986

--- Comment #10 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Totally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 02:03:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 00:03:33 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-CfFgAjJdk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 02:03:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 00:03:36 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-7NKoEbOE1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 53864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53864&action=edit
Bug 16978: Followup - Copy create_report permissions for delete_report

This patch should deal with comment #6's point of where a user who
has create, but not execute permissions, would lose delete ability.
Users with create and execute permissions would already have delete
as well.

TEST PLAN
---------
 1) Back up db
 2) drop database koha_library;
 3) create database koha_library;
 4) web install with all sample data with system user
 6) log into staff client as system user
 7) make sample koha admin user a superlibrarian
 8) set username and password for sample koha admin user
 9) log out and log in as koha admin
10) Create a user (USER_A) with permissions:
        create_reports   and execute_reports.
11) Create a user (USER_B) with permissions:
        create_reports,  but not execute_reports.
12) Create a user (USER_C) with permissions:
        execute_reports, but not create_reports.
13) Create a user (USER_D) with no report permissions.
14) Run the atomic update.
15) Check USER_A permissions
    -- should have delete_reports
16) Check USER_B
    -- should have delete_reports
17) Check USER_C
    -- should NOT have delete_reports
18) Check USER_D
    -- should NOT have delete_reports
19) run koha qa test tools
20) restore db

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:43:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:43:46 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-JxrHymi1At@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #19 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 53865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53865&action=edit
bug_7520 Added helper "syspref" to Mojolicious handlers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:43:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:43:47 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-to6yzAmkXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:43:50 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-quo7feh47U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

--- Comment #3 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53866&action=edit
Bug 16652: RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers

What this patch does is it takes current state of the following bugs:
bug 13903
bug 16330
bug 13895
bug 16497
bug 16825
bug 17007
bug 16826
bug 15165
bug 17005

And rebases them on master altogether on each other fixing the merge
conflicts.

Using this patch it can be easily tried out the currently implemented
functionality of REST API (even though in development for now) by
running 'git bz apply 16652' after installing Koha's git-bz as decribed
here: https://wiki.koha-community.org/wiki/Git_bz_configuration

Also, the project xcncip2toolkit from eXtensibleCatalog has currently
it's Koha connector implemented with respect to current state of these
included bugs. See
https://github.com/eXtensibleCatalog/xcncip2toolkit/blob/master/connectors/koha

If you wish to try the full end-to-end functionality of this, you can
run docker to install the xcncip2toolkit for you:
https://github.com/eXtensibleCatalog/xcncip2toolkit/tree/master/dockerfile

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:44:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:44:56 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-H7AJEin8r7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:44:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:44:59 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-m8f6QoG14d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7613|0                           |1
        is obsolete|                            |

--- Comment #20 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 53867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53867&action=edit
bug_7520 Added Meta handler to API v1 for metadata lists

Useful for building drop-downs etc.

Kick off with /meta/advanced-search-types

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:49:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:49:12 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-RNcHEkhIMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #21 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #18)
> Hm, not sure - but couldn't you use a public SQL report to achieve the same?

It would be a complex query that goes off two totally different tables
depending on a syspref.
If that's our policy I can certainly try.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 03:51:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 01:51:13 +0000
Subject: [Koha-bugs] [Bug 7520] json script to return advanced search types
In-Reply-To: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7520-70-x0p6lxs21m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #22 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Correction to the comment #14: url is now

/api/v1/meta/advanced-search-types

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 05:30:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 03:30:48 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14385-70-j8H0Oo52MZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #15 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #13)
> Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict
> with bug 10589 and bug 16335.

I see 10589 has been closed will this one goes ahead. Mark, should we wait for
you to finish your work with 16335 before finishing this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:02:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:02:55 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-Z5LM6Ook56@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:02:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:02:57 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-laVIGpLUOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53841|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53868&action=edit
Bug 17011 - Remove "onblur" event attribute from some templates

Several templates have an "onblur" event attribute in the markup. This
patch moves the onblur event definition into the JavaScript.

To test, apply the patch and clear your browser cache if necessary.

In Administration -> Authority types:

  - Choose "New authority type."
  - Enter any text into the "Authority type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> MARC bibliographic framework:

  - Choose "New framework."
  - Enter any text into the "Framework code" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Currencies and exchange rates:

 - Choose "New currency."
  - Enter any text into the "Currency" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Item types

 - Choose "New item type."
  - Enter any text into the "Item type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:05:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:05:19 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-jHZa9cxtGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:05:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:05:22 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-ZhzeMkY2CO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53842|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53869&action=edit
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version
number

This adds a basetgz parameter to specify a pbuilder image.
I use this to build against different distributions.

This also updates the version number for master builds to 16.06.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:07:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:07:50 +0000
Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no
 records have been passed in
In-Reply-To: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16949-70-pnsLo7cHwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53792|0                           |1
        is obsolete|                            |

--- Comment #8 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 53870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53870&action=edit
Bug 16949: Batch record deletion says success when no records have been passed
in

The reason this happens is because the page will say success when the total
number of records given equals the total number of successful deletions. If you
pass in no records, there are no successful deletions --> 0 = 0 --> it thinks
it has been successful. This patch adds a check that validates if any
checkboxes were selected before submitting the final form.
I have removed the check for if any records were selected AFTER the form
has been submitted because it seemed unnecessary if the form can't be
submitted without selection of records anyway.

To test:
1) Go to Tools -> Batch record deletion
2) Put in a record number and click Continue
3) Deselect the record so that it doesn't actually delete and click Delete
selected records
4) Page says 'All records have been deleted successfully!'
5) Apply patch. Go back and repeat step 3
6) Form should not submit and you should receive an alert saying that no
records have been selected.
7) If you try selecting and deleting a record after this alert, it
should still work

Note: Have also changed the wording of error in Step 1 when you are
entering record numbers to delete.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:30:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:30:10 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-J9tobrPb2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
I've just tried this patch in order to test bug 17005 depending patch. For me
4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this
error:

  Can't call method "borrowernumber" on unblessed reference at
  <base>Koha/REST/V1/Checkout.pm line 81

It may be due to my testing environment. Can someone confirm that tests are
still working on master?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:31:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:31:23 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-B14Fx7lUby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

--- Comment #6 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Claire Gravely from comment #5)
> Hi, I just tried again. Same result. I set the expiration date in the past,
> today and in the future and saw the same results each time with no renew
> button.

Actually, I just realised that this functionality kind of doesn't work without
the patch applied also. The way I describe what to expect in the test case is
exactly how it should work with and without the patch, but even without it it's
not acting as it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:48:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:48:57 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-HI7zcr99cQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 06:49:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 04:49:00 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-zjoXX52tob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53864|0                           |1
        is obsolete|                            |

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53871&action=edit
Bug 16978: Followup - Copy create_report permissions for delete_report

This patch should deal with comment #6's point of where a user who
has create, but not execute permissions, would lose delete ability.
Users with create and execute permissions would already have delete
as well.

TEST PLAN
---------
 1) Back up db
 2) drop database koha_library;
 3) create database koha_library;
 4) web install with all sample data with system user
 6) log into staff client as system user
 7) make sample koha admin user a superlibrarian
 8) set username and password for sample koha admin user
 9) log out and log in as koha admin
10) Create a user (USER_A) with permissions:
        create_reports   and execute_reports.
11) Create a user (USER_B) with permissions:
        create_reports,  but not execute_reports.
12) Create a user (USER_C) with permissions:
        execute_reports, but not create_reports.
13) Create a user (USER_D) with no report permissions.
14) Run the atomic update.
15) Check USER_A permissions
    -- should have delete_reports
16) Check USER_B
    -- should have delete_reports
17) Check USER_C
    -- should NOT have delete_reports
18) Check USER_D
    -- should NOT have delete_reports
19) run koha qa test tools
20) restore db

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:18:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:18:37 +0000
Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number,
	Identifier-standard
In-Reply-To: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16986-70-0XZdQSDOTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 6499 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:18:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:18:37 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-1pgsyihh8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16986 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:33:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:33:12 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-zpVonRzHd8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
How is the user informed about his/her login credentials when this preference
is turned on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:47:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:47:22 +0000
Subject: [Koha-bugs] [Bug 17016] New: Button to clear all fields in budget
	planning
Message-ID: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

            Bug ID: 17016
           Summary: Button to clear all fields in budget planning
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Currently there is an auto-fill button, but if you want to undo this, now all
fields are filled. There should be a clear option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:51:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:51:18 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
	planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-id3qAPETE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:51:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:51:21 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
	planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-JkZ45iqNi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 53872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53872&action=edit
Bug 17016: Button to clear all fields in budget planning

I have used the function from admin --> circ and fines rules

To test:
1) Go to Admin --> Budgets
2) Click a budget
3) Click Planning -> any option
4) Test the Auto-fill button to see what it does
5) Apply patch and refresh page
6) Should now be a Clear button. Both buttons should show as
font-awesome buttons with appropriate icons
7) Click Clear button. Confirm it clears all fields, which then refresh
to have 0.00 etc. (default values)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 07:51:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 05:51:49 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
	planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-pXMviw6L9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 09:11:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 07:11:53 +0000
Subject: [Koha-bugs] [Bug 16676] advance default version in
	build-git-snapshot
In-Reply-To: <bug-16676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16676-70-l4YH860Uji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16676

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---


*** This bug has been marked as a duplicate of bug 17013 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 09:11:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 07:11:53 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-3pvMqpOCqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
*** Bug 16676 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 09:56:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 07:56:52 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-dpY1Po5AYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #6)
> How is the user informed about his/her login credentials when this
> preference is turned on?

Since bug 15343, you can choose your password :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:10:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:10:41 +0000
Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is
 broken - no token at the end of the URL
In-Reply-To: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16985-70-WogkdgOYhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #2)
> Jonathan, are you sure it's a duplicate?

Not completely but it's about the same table (borrower_modifications, field
verification_token).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:19:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:19:47 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-UgeFmhSFD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #7 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Fr?d?ric Demians from comment #6)
> I've just tried this patch in order to test bug 17005 depending patch. For me
> 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this
> error:
> 
>   Can't call method "borrowernumber" on unblessed reference at
>   <base>Koha/REST/V1/Checkout.pm line 81
> 
> It may be due to my testing environment. Can someone confirm that tests are
> still working on master?

Oh, did you apply the bug 13895 first before testing? It is based on that bug,
which is not in master yet. Dependency is set already

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:23:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:23:45 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14385-70-ncRKAdVCzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Aleisha Amohia from comment #15)
> (In reply to Jonathan Druart from comment #13)
> > Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict
> > with bug 10589 and bug 16335.
> 
> I see 10589 has been closed will this one goes ahead. Mark, should we wait
> for you to finish your work with 16335 before finishing this one?

Go ahead with this. 16335 is going to take a long time before I get it
finished.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:33:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:33:33 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-OeqbFpLudn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:33:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:33:36 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-NQjgQndiL6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53731|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53873&action=edit
Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF

TEST PLAN
---------
1) unset KOHA_CONF
2) prove t
   -- 00-load.t dies miserably
3) prove t/Creators.t
   -- fails
4) apply patch
5) prove t
   -- noisy, but all tests successful
6) prove -v t/Creators.t
   -- 2 skipped tests
7) run koha qa test tools

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:35:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:35:13 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-bIjfm5CfF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #99 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to David Cook from comment #98)
> (In reply to M. Tompsett from comment #97)
> > PerlDependencies issue.
> 
> Could you elaborate?
> 
> I've added the Perl dependency.
> 
> https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.
> html&bug=10662&attachment=53362

I'm going to guess off the top of my head without checking... But I usually
state the file where the problem is. That's why it is marked as "Patch does not
apply".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:46:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:46:50 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-Syy5lxmlsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:46:54 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-B83y5a9idB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53815|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53874&action=edit
Bug 16955: Do not clear from cache when adding a new framework

There are several issues with these lines:
1/ $cache is not defined correctly and it not visible inside
duplicate_framework
2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode
3/ these calls are not needed. As we are creating a new framework, the cache
should be empty...

This patch will simply remove these calls

Test plan:
Duplicate a framework and confirm that you do not get any error in your
logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:47:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:47:14 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-Obe1ndcmU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|veron at veron.ch              |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|minor                       |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:49:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:49:45 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-fQ5IJlCVbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53835|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53875&action=edit
Bug 17009: Speed up the framework duplication

To duplicate frameworks, the code retrieve all the subfields, then
execute 1 insert per subfield.
It's unnecessary slow, we can use the DBMS to do it.

Test plan:
Create a new framework and duplicate the structure of another framework.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 10:57:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 08:57:44 +0000
Subject: [Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with
 UTF8 connection
In-Reply-To: <bug-15247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15247-70-wAQAzX9dw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:11:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:11:17 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-o3yLVoOlUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Jiri Kozlovsky from comment #7)

> Oh, did you apply the bug 13895 first before testing? It is based on that
> bug, which is not in master yet. Dependency is set already

Indeed, my comment was for bug 13895! I've mixed up my browser tabs. I will
recopy my comment on bug 13895 thread, and restore your patch status to 'Needs
Signoff'. Thks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:11:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:11:20 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-R807RWKv05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #77)
> > I am wondering if it would not be easier to use something like
> > items.$pref_value instead of the xsl:choose blocks which copy/paste code.
> 
> I'm not sure what you mean, but if you want to submit a followup to make
> that change I'd be happy to test and sign off on it!

Sorry but I really don't want to write xslt code.

Waiting for a unimarc signoff!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:11:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:11:44 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-I3kYhbqGfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #22 from Fr?d?ric Demians <frederic at tamil.fr> ---
I've just tried this patch in order to test bug 17005 depending patch. For me
4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this
error:

  Can't call method "borrowernumber" on unblessed reference at
  <base>Koha/REST/V1/Checkout.pm line 81

It may be due to my testing environment. Can someone confirm that tests are
still working on master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:15:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:15:59 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-qVWJQj7H0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What is the status of this?

IMO we should wait for bug 16735 before pushing this one. It won't make sense
to have 15707 without 16735.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:21:39 +0000
Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module,
 use Koha::Account::  pay internally for recordpayment
In-Reply-To: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15895-70-b2Kup5Rgt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
signed-off-by line missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:21:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:21:52 +0000
Subject: [Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
In-Reply-To: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15903-70-MEkTGQMDzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Needs Signoff

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
signed-off-by line missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:46:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:46:57 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-aZLbLw7Jlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:47:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:47:00 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-R7ND7uN00a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51938|0                           |1
        is obsolete|                            |
  Attachment #53126|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53876&action=edit
Bug 16436 - Allow action logs to be logged to the koha log file

Test Plan:
1) Ensure that your Koha::Logger configuration is in good working order
2) Apply this patch
3) Modify the first line of your log4perl.conf file from:
    log4perl.logger.intranet = WARN, INTRANET
   to
    log4perl.logger.intranet = INFO, INTRANET
4) Change a system preference setting
5) Note the new line in your log file!

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:47:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:47:03 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-PG3F8wBk2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53877&action=edit
Bug 16436 [QA Followup] - Use debug instead of info

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:51:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:51:27 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16449-70-l2HhofYhSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:52:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:52:03 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-XsmvISne5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53817|0                           |1
        is obsolete|                            |

--- Comment #23 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53878&action=edit
Bug 13895: Fixed QA demands

https://bugs.koha-community.org/show_bug.cgi?id=13895
Signed-off-by: Ji?? Kozlovsk? <mail at jkozlovsky.cz>

Test plan still working

Fixes Can't call method "borrowernumber" on unblessed reference at
<base>Koha/REST/V1/Checkout.pm line 81

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:57:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:57:56 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-nggqnfHDLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #24 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Fr?d?ric Demians from comment #22)
> I've just tried this patch in order to test bug 17005 depending patch. For me
> 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this
> error:
> 
>   Can't call method "borrowernumber" on unblessed reference at
>   <base>Koha/REST/V1/Checkout.pm line 81
> 
> It may be due to my testing environment. Can someone confirm that tests are
> still working on master?
It was a small issue in the code. Calling $checkout->borrowernumber on
unblessed reference $checkout, probably meant $checkout->{borrowernumber}
instead, or even don't unbless $checkout(?).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:58:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:58:56 +0000
Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack
In-Reply-To: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16818-70-bvnD5qbMw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 11:58:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 09:58:59 +0000
Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack
In-Reply-To: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16818-70-f3oBhpjsyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53721|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53879&action=edit
Bug 16818: External auth redirect broken under Plack

Test plan:

0) Have either CAS or Shibboleth authentication enabled under Plack.
1) Hover over the authentication link on the staff client or OPAC, and
   notice that it has either '.../opac/...' or '.../intranet/...' instead
   of '.../cgi-bin/koha/...'. (This will be a complete dealbreaker for CAS
   authentication.)
2) Apply patch.
3) Check links again; they should now have the correct paths.

Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Did not test CAS or Shibboleth, but no regression found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:03:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:03:31 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-qg4KCKxF8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #37)
> The import tool does not work for me under plack (master), could you confirm?

Did you test with plackup.sh ?
There is an essential difference: When you test with koha-plack, the apache
include file apache-shared-intranet-plack.conf comes into the picture. It
includes a bunch of ProxyPass directives for some problematic scripts, and yes
it includes stage-marc-import.pl.

This means that the import tool most probably does not work with plackup.sh too
without this patch. (Especially when you repeat the import?)
So your problem here is not the scope of this report.

I retested this patch by importing a marcxml twice with koha-plack enabled, and
I confirm that it still works as expected.

Btw I would like to work on resolving these issues making the ProxyPass
unneeded, but yes on another report :)

Thx for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:07:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:07:20 +0000
Subject: [Koha-bugs] [Bug 16868] Silence error
	t/db_dependent/Linker_FirstMatch.t
In-Reply-To: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16868-70-BiwG28aMsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:07:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:07:24 +0000
Subject: [Koha-bugs] [Bug 16868] Silence error
	t/db_dependent/Linker_FirstMatch.t
In-Reply-To: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16868-70-ExWA0r7GhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53729|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53880&action=edit
Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t

When the auth_header table has records which exclude 1xx and
2xx tags, the $bibfield doesn't match anything. This in turn
sets it to undef, which triggers an error on the next line
killing the test.

This was completely refactored to provide the data necessary
for the tests to pass, and to be more comprehensive (both MARC
and UNIMARC are tested). The tests are then run.

C4::Headings::authorities is mocked, so that this test is not
dependent on a search engine.

TEST PLAN
---------
1) back up DB
2) DELETE FROM auth_header;
3) SOURCE auth_header.sql;
   -- the provided file
4) prove t/db_dependent/Linker_FirstMatch.t
   -- should barf before running all the tests
5) apply all patches
6) prove t/db_dependent/Linker_FirstMatch.t
   -- should work happy
7) run koha qa test tools
8) restore your backup

Followed test plan, behaves as expected.
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:14:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:14:53 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-QlEzBEZ2IU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:14:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:14:55 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-98ooqH65SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53730|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53881&action=edit
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t

prove t/db_dependent/ILSDI_Services.t
generates noisy output as a result of the ambiguous context
of two $cgi->param() calls.

By storing into scalar variables, and then using the scalar
variables, the code maintains readability and fixes the problem.

TEST PLAN
---------
1) prove t/db_dependent/ILSDI_Services.t
   -- noisy.
2) apply patch
3) prove t/db_dependent/ILSDI_Services.t
   -- not noisy
4) run koha qa test tools

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:16:06 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-NQuIUM7581@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15809

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:16:06 +0000
Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have
	multi_param
In-Reply-To: <bug-15809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15809-70-nhkuHNraFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16864

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:18:16 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-OGbfw98dGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:18:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:18:20 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-BJ2N1CcR2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53725|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53882&action=edit
Bug 16585: Update Italian installer sample files for 16.05

With this patch all sample/defintions .sql files are updated and translated
into Italian
(if you select italian during web installation).

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:19:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:19:19 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-gO3UHks0EW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Zeno Tajoli from comment #7)
> Hi,
> I answer the request of Jonathan (#6):
> 
> >You should use \r\n to line breaks.
> I insert "\r\n\r\n" because in Italy we want a empty line in the template.
> It is a cosmetic request.
> I used "\r\n\r\n" in older version of notices.sql

No, look at:

  +Il prestito dei seguenti volumi sta per scadere:
  +
  +<<items.content>>
  +
  +<<branches.branchname>>', 'email'),

You did not use \r\n or whatever.
Anyway, it's fine by me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:21:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:21:03 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-yFWDabGal1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:22:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:22:54 +0000
Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module,
 use Koha::Account::  pay internally for recordpayment
In-Reply-To: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15895-70-t2TCGxKjdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:22:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:22:56 +0000
Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module,
 use Koha::Account::  pay internally for recordpayment
In-Reply-To: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15895-70-OOKTZyH0Y5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52138|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 53883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53883&action=edit
Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for
recordpayment

This is the first patch in a series to unify all payment functions into
a single method.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay amount" button

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:27:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:27:32 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection and serial edit templates
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-t9QY9S6Fbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:27:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:27:35 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection and serial edit templates
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-MQLQPAeGBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53856|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53884&action=edit
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit
templates

This patch removes the use of event attributes like "onclick" from the
serial collection and serial edit templates. Events are now defined in
JavaScript.

Also changed: Converted "create routing list," "edit routing list," and
"Renew" links to Bootstrap buttons. The "select all" and "clear all"
links have Font Awesome icons added.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
    "Multi receiving" button works correctly.
- For any subscription, test that the "Generate next" button works
  correctly.
- In each tab, test that the "select all" and "clear all" links work
  correctly.
- On a subscription which has expired, test that the "Renew" button
  works correctly.
- On the serial collection page, select multiple issues and click the
  "Edit serials" button.
  - Testing with a subscription for which an item record is NOT created
    when receiving:
    - Changing the status to "Arrived" or "Claimed" should change the
      "Expected on" date to today's date. Selecting any other status
      should leave the "expected on" date as it was or return it to its
      original value.
    - Test that the "Multi receiving" button works correctly.
  - Testing with a subscription for which an item record IS created when
    receiving:
    - Changing the status of an issue should work as above but should
      also trigger the appearance of the item add form when the status
      is "Arrived" or "Claimed," and hide the form otherwise.
    - Cliking the "Item" link at the top of the item add form should
      hide it.
    - Clicking the "Add item" link under any issue should display the
      item add form.
    - In the item add form, test that repeatable fields are correctly
      duplicated when you click the "clone" button.
    - On the "Supplemental issue" line, changing the status to "Arrived"
      should work as described above. Changing the status on this line
      to "Claimed" should only change the "Expected on" date.
    - Adding regular and supplemental issues should work correctly.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Works as described.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:31:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:31:56 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-YqICK4sOmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:31:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:31:59 +0000
Subject: [Koha-bugs] [Bug 17012] Remove more event attributes from
 administration templates
In-Reply-To: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17012-70-iEAhTwffGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53857|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53885&action=edit
Bug 17012 - Remove more event attributes from administration templates

There are several administration templates which still contain event
attributes. This patch move event definition to the JavaScript.

To test you must have the SMSSendDriver system preference set to
"Email." Apply the patch and go to Administration.

- In Global system preferences, change the value of any input or select
  and then click the "Cancel" link for that section. After confirming
  your choice, the page should reload with your changes reset.

- In Circulation and fine rules, edit any existing rule. In the editing
  row, click the "Clear" button. The data for that rule should be
  cleared.

- In Transport cost matrix, make any change to the matrix. Submitting
  the form should work correctly.

- In MARC bibliographic framework, choose 'MARC structure' for any
  framework.
  - Checking or unchecking the 'Display only used tags/subfields'
    checkbox should reload the page and change the display according to
    your choice.

- In Did you mean?, make changes to the existing configuration.
  - Clicking "Cancel" should reload the page and discard your changes.
  - Clicking "Save configuration" should correcly save your changes.

- In SMS cellular providers, click to edit any existing provider.
  Clicking the "Cancel" link should cancel the editing process and
  return you to the list of providers.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:35:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:35:11 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-mIWenoFggH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:35:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:35:14 +0000
Subject: [Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some
	templates
In-Reply-To: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17011-70-z3S2OOhSm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53868|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53886&action=edit
Bug 17011 - Remove "onblur" event attribute from some templates

Several templates have an "onblur" event attribute in the markup. This
patch moves the onblur event definition into the JavaScript.

To test, apply the patch and clear your browser cache if necessary.

In Administration -> Authority types:

  - Choose "New authority type."
  - Enter any text into the "Authority type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> MARC bibliographic framework:

  - Choose "New framework."
  - Enter any text into the "Framework code" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Currencies and exchange rates:

 - Choose "New currency."
  - Enter any text into the "Currency" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

In Administration -> Item types

 - Choose "New item type."
  - Enter any text into the "Item type" field.
  - Moving the cursor focus away from this field should convert your
    text to uppercase.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:41:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:41:49 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-udMAcst0dG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53741|0                           |1
        is obsolete|                            |
  Attachment #53871|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53887&action=edit
Bug 16978: Add delete reports user permission

This splits off the delete capability from the create reports permission.
>From a UI perspective there were CSS issues, that this patch set hackily
bypasses. Perhaps someone else can amend this enhancement with the required
changes so that the extra column at the beginning of the table can be
removed when the user does not have delete capability.

TEST PLAN
---------
1) back up db
2) apply patch
3) ./installer/data/mysql/updatedatabase.pl
   -- should run without issue.
4) in mysql:
   > drop database ...
   > create database ...
   -- totally blanks it for fresh web install
5) run web install
   -- installing should have no issues
6) go to a patron
7) set permissions
8) expand the reports permission
   -- should have delete reports now
9) click help and scroll down to
   'Granular Reports Permissions' right at the bottom.
   -- there should be a new delete_reports section
10) Head over to guided reports and build a few reports.
    -- as system account user, delete stuff should all be visible.
11) Find a patron, set all permissions, except delete reports.
12) log out and then log in as the modified patron
13) Head over the save reports
    -- none of the delete options should be available to the user.
14) run koha qa test tools
15) restore db

Followed test plan. Additionally tried to delete using params in URL
(not possible, OK)
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:41:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:41:46 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-8NjVQOYnbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:41:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:41:52 +0000
Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission
In-Reply-To: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16978-70-RpRcStTY7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53888&action=edit
Bug 16978: Followup - Copy create_report permissions for delete_report

This patch should deal with comment #6's point of where a user who
has create, but not execute permissions, would lose delete ability.
Users with create and execute permissions would already have delete
as well.

TEST PLAN
---------
 1) Back up db
 2) drop database koha_library;
 3) create database koha_library;
 4) web install with all sample data with system user
 6) log into staff client as system user
 7) make sample koha admin user a superlibrarian
 8) set username and password for sample koha admin user
 9) log out and log in as koha admin
10) Create a user (USER_A) with permissions:
        create_reports   and execute_reports.
11) Create a user (USER_B) with permissions:
        create_reports,  but not execute_reports.
12) Create a user (USER_C) with permissions:
        execute_reports, but not create_reports.
13) Create a user (USER_D) with no report permissions.
14) Run the atomic update.
15) Check USER_A permissions
    -- should have delete_reports
16) Check USER_B
    -- should have delete_reports
17) Check USER_C
    -- should NOT have delete_reports
18) Check USER_D
    -- should NOT have delete_reports
19) run koha qa test tools
20) restore db

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 12:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 10:46:34 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-qnaShb15gx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 53869
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53869
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version
number

Review of attachment 53869:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17013&attachment=53869)
-----------------------------------------------------------------

::: debian/build-git-snapshot
@@ +31,4 @@
>  my $buildresult;
>  my $distribution='squeeze-dev';
>  my $git_checks='all';
> +my $version='16.06~git';

Should not we create a subroutine to guess the version?
Otherwise we will have to update it every 6 months :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:12:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:12:40 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-vje5PrrHh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53878|0                           |1
        is obsolete|                            |

--- Comment #25 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53889&action=edit
Bug 13895: Fixed QA demands

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Fix QA, and fix tests failing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:18:32 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-pgHF8mDdMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51303|0                           |1
        is obsolete|                            |

--- Comment #26 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53890&action=edit
[SIGNED-OFF] Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bug 15126

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:19:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:19:00 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-cF646CM8SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53889|0                           |1
        is obsolete|                            |

--- Comment #27 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53891&action=edit
[SIGNED-OFF] Bug 13895: Fixed QA demands

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Fix QA, and fix tests failing

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:40:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:40:20 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-KV5wfCGYbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:43:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:43:33 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-576TcNbJfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #28 from Lari Taskula <larit at student.uef.fi> ---
What about user who does not have 'circulate_remaining_permissions' permission,
but wants to access his own checkouts or renew his own checkouts if
OpacRenewalAllowed is on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:47:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:47:37 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-gkYjNOYpDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #40)
> (In reply to Jonathan Druart from comment #38)
> > (In reply to Julian Maurice from comment #32)
> > > Created attachment 50142 [details] [review] [review] [review]
> > > Bug 15126: Update patron definition
> > 
> > Julian, I think we need tests to make sure the swagger file will be always
> > up-to-date with the DB structure. Any ideas how we could do that?
> 
> Maybe that should be a coding guideline/QA requisite, that every endpoint
> has a proper set of unit tests, including this check on the swagger files.
> I'd vote for discussing this on the next dev meeting to gather broader
> opinions.

This has never been done and the json file is not up-to-date: checkprevcheckout
and updated_on are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:50:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:50:54 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-bWfYybJuso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
items.new_status is missing in the swagger file.
Please have a look at bug 15126 comment 53.
We need a way to keep this file up-to-date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 13:53:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 11:53:24 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-OTsNq7ZSxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Jonathan Druart from comment #4)

> Should not we create a subroutine to guess the version?
> Otherwise we will have to update it every 6 months :)

I think we did something similar in some other place. Do you remember where?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:01:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:01:21 +0000
Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for
	Phone Notices
In-Reply-To: <bug-15969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15969-70-eT9yDRobud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
CONFLICT (content): Merge conflict in
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
CONFLICT (content): Merge conflict in C4/Letters.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:07:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:07:57 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-g03ATLG1PB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tom?s, don't you think we should try and fill the interface column for existing
values?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:22:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:22:20 +0000
Subject: [Koha-bugs] [Bug 17017] New: Dependency fixes for 16.05
Message-ID: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

            Bug ID: 17017
           Summary: Dependency fixes for 16.05
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Things I did for 16.05.02. Should go in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:22:28 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-tf0jvheu1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:23:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:23:42 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-5XXF2PLoMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:23:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:23:58 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-VB42NWUdaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:32:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:32:47 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-cpWHvMBn1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
I think Variant III is the best.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:39:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:39:45 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-OTVps5fYZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:39:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:39:50 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-6KdVT5JGPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53423|0                           |1
        is obsolete|                            |

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53892&action=edit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
    reports/bor_issues_top.pl
    reports/borrowers_out.pl
    reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:42:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:42:46 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-owmPfugrrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:42:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:42:50 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-IK9kQZg3Ez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52913|0                           |1
        is obsolete|                            |
  Attachment #52914|0                           |1
        is obsolete|                            |
  Attachment #52915|0                           |1
        is obsolete|                            |
  Attachment #52916|0                           |1
        is obsolete|                            |
  Attachment #52917|0                           |1
        is obsolete|                            |
  Attachment #52918|0                           |1
        is obsolete|                            |
  Attachment #52919|0                           |1
        is obsolete|                            |
  Attachment #52920|0                           |1
        is obsolete|                            |

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53893&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:42:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:42:56 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-5RCStkUx2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53894&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:00 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ShgNpUEK6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53895&action=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:06 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-yq4uloj4I7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53896&action=edit
Bug 15758: Koha::Libraries - Remove GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:09 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-YfAs9YKHvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53897&action=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:13 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-kI8zrQrM6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53898&action=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:18 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-59E7Mm0Riy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53899&action=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:43:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:43:21 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-q2y7pceFK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53900&action=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 14:58:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 12:58:33 +0000
Subject: [Koha-bugs] [Bug 17018] New: Split AdvancedSearchTypes for staff
	and OPAC
Message-ID: <bug-17018-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018

            Bug ID: 17018
           Summary: Split AdvancedSearchTypes for staff and OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

It would be nice if you could configure AdvancedSearchTypes differently for
staff and opac advanced search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:00:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:00:20 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-UACmGtuvXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #29 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53901&action=edit
Bug 13895: Allow user to access their own checkouts and renew them

Let user access their own checkouts and if OpacRenewalAllowed system preference
is on, also let user to renew their checkouts.

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie) with a Patron that has no permissions. This Patron will be
   referred as "your patron" or "your borrowernumber" below.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with your borrowernumber) and check you receive correct data
3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with someone else's borrowernumber) and check you get a permission
   error.
4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of your Patron) and check you receive correct data
5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of some other Patron) and check you get a permission
   error.
6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY
   with existing checkout id of some other Patron. You should get a permission
   error.
7. Set system preference OpacRenewalAllowed to 0.
8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be
   checkout id of checkout for your patron. You should get a permission error.
9. Set system preference OpacRenewalAllowed to 1.
10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
    the maximum number of renewals is reached (you should have a 403
    error). YYY should be checkout id of checkout for your patron.
11. Run unit tests in t/db_dependent/api/v1/checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:02:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:02:51 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-l7C2rrV3cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:25:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:25:58 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-Q378ryZl1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53902&action=edit
Bug 17017 Dependency fixes for 16.05

Things I did for 16.05.02. Should go in 16.05.03.

Adds to PerlDependencies.pm:

IO::Socket::IP
Readonly
Readonly::XS

Adds overrides to debian/list-deps:

IO::Socket::IP => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl'
Swagger2 => 'libswagger2-perl (>= 0.59)'

and an up to date debian/control based on that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:26:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:26:22 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-ONMdvZ0Ta8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:27:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:27:38 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-EQk58Zy5Gd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:41:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:41:52 +0000
Subject: [Koha-bugs] [Bug 17019] New: debian/changelog update
Message-ID: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

            Bug ID: 17019
           Summary: debian/changelog update
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:41:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:41:58 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-edsaKTQaSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:43:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:43:02 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-xM6UP843EF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53903&action=edit
Bug 17019 - debian/changelog update

This has not been updated for a while. I plan to add the stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 15:44:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 13:44:10 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-8E7cWnMX7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|NEW                         |Needs Signoff

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Should go in 16.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:02:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:02:38 +0000
Subject: [Koha-bugs] [Bug 17020] New: findborrower is not used in
	circulation.tt
Message-ID: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

            Bug ID: 17020
           Summary: findborrower is not used in circulation.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

It's passed to the template but never used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-9FKEX2FZNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14568                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 14416] Stored XSS flaw affects OPAC and Staff
	interface
In-Reply-To: <bug-14416-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14416-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14416-70-0DtkHts9gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14416

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14568

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 14423] Multiple XSS and XSRF issues in Staff Client
In-Reply-To: <bug-14423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14423-70-AWB2UHAmzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14423

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14568

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-dWqZueyrtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14568

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 16599] XSS found in opac-shareshelf.pl
In-Reply-To: <bug-16599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16599-70-bnsOdGUA9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14568

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:15:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:15:17 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-xidqrfUosj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14568                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:18:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:18:48 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-J6K6dkufw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #103 from Francois Charbonnier <francois.charbonnier at inlibro.com> ---
(In reply to Katrin Fischer from comment #102)
> (In reply to Francois Charbonnier from comment #96)
> > (In reply to Katrin Fischer from comment #59)
> > 
> > > - What is the definition of an "Active transaction"? (was not clear to me,
> > > so asking :) )
> > 
> > The idea behind "Active transactions" is to help balance cash register
> > transactions. In other words, how much goes in or how much goes out the cash
> > register. The active transactions group what patrons paid or gave as credit
> > to the library, which means what went IN the register.
> > 
> > The code works this way : it takes all transactions where account types  are
> > NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L"
> > (Lost).
> 
> Sorry, I still don't get it :( The list of excluded fine types looks a bit
> arbitrary to me - what about custom MANUAL_INV values? And what is left by
> excluding those?

Hey Katrin,

But you do get that "active transaction" groups all transactions where patrons
give money to the library, right ?

The logic should be different. What do you think of grouping the relevant
account types, "Pay" and "C" (are there other?) instead of excluding this list?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:24:02 +0000
Subject: [Koha-bugs] [Bug 17027] New: contril file update for 3.22
Message-ID: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

            Bug ID: 17027
           Summary: contril file update for 3.22
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

I updated the control file for 3.22.09. This should go in 3.22.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:25:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:25:07 +0000
Subject: [Koha-bugs] [Bug 17027] contril file update for 3.22
In-Reply-To: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17027-70-ifwCYgji73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53904&action=edit
Bug 17027

I updated the control file for 3.22.09.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:25:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:25:23 +0000
Subject: [Koha-bugs] [Bug 17027] control file update for 3.22
In-Reply-To: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17027-70-mr2XOHP9Qy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|contril file update for     |control file update for
                   |3.22                        |3.22

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:27:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:27:52 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-fLuU7WHtKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:27:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:27:54 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-N6UHKHctRI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53905&action=edit
Bug 17020: Do no pass findborrower to the template

Indeed, it's not used!

Test plan:
  git grep '\[% findborrower'
should not return any result.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:29:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:29:56 +0000
Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
In-Reply-To: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16715-70-HYdg2q0GLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Followup has been pushed to master for Koha 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:30:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:30:50 +0000
Subject: [Koha-bugs] [Bug 17027] control file update for 3.22
In-Reply-To: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17027-70-AkfoqtYXyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:41:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:41:46 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-iCuxIU3bHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #38 from Mehdi Hamidi <mehdi.hamidi at inlibro.com> ---
Created attachment 53913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53913&action=edit
Bug 12446 - QA Follow-up

- Added missing icon on add gurantee
- Removed category restriction when adding new guarentee
- Put back some deleted entries while fixing merging conflicts.
- Fixed some typing errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 16:45:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 14:45:25 +0000
Subject: [Koha-bugs] [Bug 17027] control file update for 3.22
In-Reply-To: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17027-70-dU2hLU1SYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:02:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:02:11 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-1OIosEeAXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From Philippe Blouin on the dev ml:
=== QUOTE
We've had this problem on 10% of our installations.  I solved it by 
 going nuclear with logrotate since that was really hurting the users to 
 not have zebra working (it would appear like working on our monitor, but 
 was actually just dying and restarting).

 Here is the postrotate I've end up with, after many iterations of Next 
 Level Apocalypse You :)

      postrotate
          service apache2 reload
          find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" stop' {} \;
          sleep 3
          find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" stop' {} \;
          sleep 3
          pkill -9 zebra
          sleep 2
          pkill -9 zebra
          sleep 2
          find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" start' {} \;
      endscript

 As you see, no subtlety, but I've had no problem for a year now...
== END QUOTE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:10:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:10:27 +0000
Subject: [Koha-bugs] [Bug 17030] New: Configure the REST api on packages
	install
Message-ID: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

            Bug ID: 17030
           Summary: Configure the REST api on packages install
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

This should've been implemented a while back, so we start taking advantage of
the REST api in the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:10:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:10:34 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-AG3ibvP6bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:13:29 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-a8deZCjV8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Mirko Tietgen from comment #0)
> Things I did for 16.05.02. Should go in 16.05.03.

Isn't it also required for master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:19:53 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-aTqHQNx7gw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:19:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:19:56 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-61WOePhkFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53902|0                           |1
        is obsolete|                            |

--- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53919&action=edit
Bug 17017 Dependency fixes for 16.05

Things I did for 16.05.02. Should go in 16.05.03.

Adds to PerlDependencies.pm:

IO::Socket::IP
Readonly
Readonly::XS

Adds overrides to debian/list-deps:

IO::Socket::IP => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl'
Swagger2 => 'libswagger2-perl (>= 0.59)'

and an up to date debian/control based on that.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:21:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:21:57 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-FXpaoWveSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> ---
Since this patch is directly related to the stable release process, including
Debian packaging, I'm really tempted to push it directly into 16.05.x branch
without QAing...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:25:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:25:28 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-0OCPbJh6pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #104 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think that sounds more logical! Also safer with the option of new types being
added - not so likely we change the types for paying and credit.

Maybe we could also think about a more 'speaking' name.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:32:34 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-4MVTF6LS5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16588

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Fr?d?ric Demians from comment #2)
> Isn't it also required for master?

Readonly will be removed from master, see bug 16588.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:32:34 +0000
Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl)
 need to be added as dependencies
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-a3M9OMM3Lk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17017

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:40:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:40:32 +0000
Subject: [Koha-bugs] [Bug 17031] New: Use delimeter system preference for
 Overdues report download
Message-ID: <bug-17031-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031

            Bug ID: 17031
           Summary: Use delimeter system preference for Overdues report
                    download
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The delimiter system preference should be used to choose the separator to be
used for the data exported from circulation > overdues (overdue.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:40:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:40:55 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-Ry7cfRAJrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #105 from Owen Leonard <oleonard at myacpl.org> ---
> But you do get that "active transaction" groups all transactions where
> patrons give money to the library, right ?

I don't think "active transaction" has any inherent meaning. What about
something like "All payments to the library" ?

Some other things I notice:

- The page is looking for datatables.js in the wrong place. It's now at
intranet-tmpl/prog/js/datatables.js.

- The table header "Patron cardnumber" should be "Patron card number."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:42:20 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-wvOZEnH4WS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Fr?d?ric Demians from comment #4)

> Since this patch is directly related to the stable release process,
> including Debian packaging, I'm really tempted to push it directly into
> 16.05.x branch without QAing...


Katrin says it's ok

> (17:39:15) drojf: cait: bug 17017
> (17:39:34) drojf: i used it in the packages without even a signoff. any objections to pushing it?
> (17:40:14) cait: nope - trusting you there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:54:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:54:19 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-i9iQ8gM7DW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Done. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:54:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:54:34 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-ZesCBmYslP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:54:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:54:40 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-laP8aUe2a6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:54:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:54:42 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-PBDLSkyyYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53657|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 53920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53920&action=edit
Bug 16960 - Patron::Modifications should be fixed

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Test Plan:
1) Apply this patch
2) Create some patron modification requests
3) Ensure you can approve and deny modifications
4) Ensure patron self registration works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 17:55:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 15:55:04 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-CyRQhiiSw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Marc V?ron from comment #4)
> Hi Kyle,
> 
> Sorry, after applying the patch, I get an "Internal server error" on Home >
> Patrons (members-home.pl)
> 
> plack-error.log says:
> Can't locate object method "GetPendingModificationsCount" via package
> "Koha::Patron::Modifications" at /home/marc/koha/members/members-home.pl
> line 91.
> 
> git grep GetPendingModifications
> 
> members/members-home.pl: 
> Koha::Patron::Modifications->GetPendingModificationsCount( $branch );
> ^ Leads to error. If I fix this line, members-home.pl displays as expected
> 
> 
> t/db_dependent/Koha_borrower_modifications.t:'Add a new pending modification
> and test GetPendingModificationsCount() again'
> t/db_dependent/Koha_borrower_modifications.t:## Check GetPendingModifications
> marc at debian8vm:~/koha$ 
> ^ Inside comments, but I think it would be fine to change them for
> readability
> 
> Otherwise, sending an update request from OPAC and applying it from Staff
> client works OK.

This should now be fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:26:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:26:16 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-BsNTFjhS5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:26:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:26:19 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-gungKKDCqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #9 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53921&action=edit
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:33:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:33:07 +0000
Subject: [Koha-bugs] [Bug 17032] New: REST API tests: Make sure Swagger
 object definition is up-to-date with database
Message-ID: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

            Bug ID: 17032
           Summary: REST API tests: Make sure Swagger object definition is
                    up-to-date with database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

If a Swagger object definition is based on some database table, the definition
should be covered by tests to ensure that it is up-to-date with database.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:34:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:34:43 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-rKatkBOYkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #10 from Lari Taskula <larit at student.uef.fi> ---
I created Bug 17032 to add similar tests for what's already in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:36:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:36:12 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-u1qv4uEYQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13799, 13903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:36:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:36:12 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-5EdciDbctR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:36:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:36:12 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete holds
In-Reply-To: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-JXi21Ummjh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 18:56:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 16:56:02 +0000
Subject: [Koha-bugs] [Bug 17033] New: Rotating Collection does not show on
	tools-home.pl
Message-ID: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

            Bug ID: 17033
           Summary: Rotating Collection does not show on tools-home.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 19:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 17:01:49 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-GVa8hUf70l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Owen Leonard from comment #1)
> I'm working on this, but I'm not sure what the message should say. "Your
> account has been discharged?" "You have been discharged?"

I vote for the former, if that's any help. It's not like the person is fired.
;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 19:10:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 17:10:19 +0000
Subject: [Koha-bugs] [Bug 17033] Rotating Collection does not show on
	tools-home.pl
In-Reply-To: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17033-70-EQxcJnyxIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
If you look at Home ? Tools (cgi-bin/koha/tools/tools-home.pl), 'Rotating
Collection' does not show among the available cataloging tools.

If you navigate to another tool, e.g. Home ? Tools ? Batch item deletion
(cgi-bin/koha/tools/batchMod.pl), you will see the link to Rotating collections
on the left bar, pointing to
cgi-bin/koha/rotating_collections/rotatingCollections.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 20:59:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 18:59:17 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-sKu0xb6j1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #17 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53922&action=edit
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 21:01:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 19:01:16 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-KIh45teMgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53922|0                           |1
        is obsolete|                            |

--- Comment #18 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Comment on attachment 53922
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53922
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Sorry about this patch, I've messed up bug id - had to be 16825 instead of
16826.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 21:04:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 19:04:58 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-KEQDDI8Tx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #11 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53923&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

Lari: You have probably changed in your comment bug ID for 16826
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825#c9

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 21:05:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 19:05:19 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-QpU0RT58nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 21:27:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 19:27:22 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-NqIiHxripz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 21:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 19:27:26 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-LtfRwicDlj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53901|0                           |1
        is obsolete|                            |

--- Comment #30 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53924&action=edit
[SIGNED-OFF] Bug 13895: Allow user to access their own checkouts and renew them

Let user access their own checkouts and if OpacRenewalAllowed system preference
is on, also let user to renew their checkouts.

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie) with a Patron that has no permissions. This Patron will be
   referred as "your patron" or "your borrowernumber" below.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with your borrowernumber) and check you receive correct data
3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with someone else's borrowernumber) and check you get a permission
   error.
4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of your Patron) and check you receive correct data
5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of some other Patron) and check you get a permission
   error.
6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY
   with existing checkout id of some other Patron. You should get a permission
   error.
7. Set system preference OpacRenewalAllowed to 0.
8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be
   checkout id of checkout for your patron. You should get a permission error.
9. Set system preference OpacRenewalAllowed to 1.
10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
    the maximum number of renewals is reached (you should have a 403
    error). YYY should be checkout id of checkout for your patron.
11. Run unit tests in t/db_dependent/api/v1/checkouts.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

Wow, works like magic! :) Nice job!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:00:21 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-ZbrKvMlYlL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #106 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please take a look at comment#103 - comment#105 for a hopefully last follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:42:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:42:50 +0000
Subject: [Koha-bugs] [Bug 17034] New: Creating a new patron fails due to DB
	error
Message-ID: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

            Bug ID: 17034
           Summary: Creating a new patron fails due to DB error
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: code at adamgoforth.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

After upgrading from Koha 16.05.01 to 16.05.02 with the Debian package,
creating a new patron via the web interface fails. After filling out and
submitting the form at
/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=OP this error is
displayed:

DBIx::Class::Row::store_column(): No such column 'checkprevcheckout' on
Koha::Schema::Result::Borrower at /usr/share/koha/lib/C4/Members.pm line 731

It seems that the problem is in line 727 of Members.pm:

$new_member->{checkprevcheckout} ||= 'inherit';

Commenting out this line allows the patron creation to finish normally.

The issue seems to be that the column "checkprevcheckout" does not exist in the
borrowers table and should not exist in this version of Koha. Apparently it was
added to master in bug 6906, and it shouldn't be in a public release until Koha
16.11.

Koha version: 16.05.02.000
OS: Debian 8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:44:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:44:53 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-S1uQOJNKqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Were you thinking about bug 16724?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:52:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:52:34 +0000
Subject: [Koha-bugs] [Bug 17033] Rotating Collection does not show on
	tools-home.pl
In-Reply-To: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17033-70-ghn5Butv8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It shows for me in both spots - the tools main page and the tools sitebar.
Maybe different permission checks?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:54:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:54:31 +0000
Subject: [Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error
In-Reply-To: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17034-70-TpULgGM8QS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
                   |                            |, katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It seems the column was introduced to the categories table by bug 6906 and
should not appear in 16.05 - maybe it slipped in somehow with another
patch/rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:56:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:56:03 +0000
Subject: [Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error
In-Reply-To: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17034-70-t2gkWUXocL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
This bug was caused by commit 878402689eb652b09bed0d4f2c7e458d5c5493f4

I think we need to revert this out on 16.05.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  2 23:56:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Aug 2016 21:56:16 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-swgpBsLfz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #79 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Jonathan, would you be ok with me testing with a UNIMARC sample database (from
the sandboxes I think)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 05:35:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 03:35:38 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-OuSputfvB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 05:35:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 03:35:40 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-K9901N5sSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 53925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53925&action=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch actually loops 10 tens to check, before giving up.

TEST PLAN
---------
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
      didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
    -- the process ids for the zebrasrv and daemon processes should
       be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 06:13:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 04:13:33 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-0eV2P6Ffu2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53925|0                           |1
        is obsolete|                            |

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 53926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53926&action=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch actually loops 10 tens to check, before giving up.

TEST PLAN
---------
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
      didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
    -- the process ids for the zebrasrv and daemon processes should
       be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

Sponsored-by: Tulong Aklatan

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 08:24:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 06:24:23 +0000
Subject: [Koha-bugs] [Bug 16917] Error when importing patrons,
 Column 'checkprevcheckout'   cannot be null
In-Reply-To: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16917-70-BH0bsQDmAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Reverted. Shouldn't be in 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 08:26:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 06:26:33 +0000
Subject: [Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error
In-Reply-To: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17034-70-eBVLkXBal2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16917
                 CC|                            |frederic at tamil.fr

--- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> ---
Bug 16917 reverted on 16.05 branch.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917
[Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be
null
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 08:26:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 06:26:33 +0000
Subject: [Koha-bugs] [Bug 16917] Error when importing patrons,
 Column 'checkprevcheckout'   cannot be null
In-Reply-To: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16917-70-8lHfJpI53O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17034


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034
[Bug 17034] Creating a new patron fails due to DB error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 08:35:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 06:35:24 +0000
Subject: [Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error
In-Reply-To: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17034-70-8Z7P9gOVG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 09:56:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 07:56:03 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-ybGJVvoNaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #79)
> Jonathan, would you be ok with me testing with a UNIMARC sample database
> (from the sandboxes I think)?

Yes, of course!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 10:03:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 08:03:35 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-oYwluUowKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Lari Taskula from comment #9)
> Also, to avoid forgotten columns in definitions, adds a test to
> compare item-definition to database's items-table.

Lari, thanks for that!
Do you think you could provide a global check?
It would look at the api/v1/definitions/*.json files and compare the columns
with Koha::Objects->columns (added by bug 16889).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 10:17:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 08:17:12 +0000
Subject: [Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error
In-Reply-To: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17034-70-dODAcAv1jU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
I already uploaded a new Debian package last night without the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 13:31:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 11:31:18 +0000
Subject: [Koha-bugs] [Bug 17037] New: 952 Field/Record Items not being
	accessed
Message-ID: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

            Bug ID: 17037
           Summary: 952 Field/Record Items not being accessed
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: m.kibble at sae.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 53935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53935&action=edit
Record Bibliography [item not indexed] and MARC record

Logged in to find biblio.item information is missing from all biblio records,
however the information within the items can still be referenced for search
functions (on both admin and public sites) and MARC data for items is still
accessible (see attachment).

I'm relatively new to Koha, and have been using it the last few days to upload
some MARC records, but I don't believe they could have caused this bug as
everything was working fine yesterday. Also did some keyword mapping to default
but only added 245b subtitle field.

Currently running on Koha 3.16.02 - Linux library 2.6.32
Any help would be greatly appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 13:38:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 11:38:09 +0000
Subject: [Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed
In-Reply-To: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17037-70-R6idS58V9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

--- Comment #1 from Matthew K <m.kibble at sae.edu> ---
Sorry, not 'biblio.items' -> 'items'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 13:54:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 11:54:09 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-CHGYJPNzzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:09:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:09:30 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-WnQJTGBIs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:09:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:09:32 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-BhUgD21Vtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53936&action=edit
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

If a definition in api/v1/definitions/*.json has a corresponding Koha-object by
filename, compare properties of the definition and columns of the Koha-object
and ensure that all columns are defined inside properties of the definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. See that all of the tests pass. (If not, file a bug report to fix missing
   properties in the Swagger definition.)
3. Remove a property from api/v1/swagger/definitions/patron.json
4. Repeat step 1
5. See that test fails and lets you know that the property you just removed
   is missing from the definition.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:23:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:23:57 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-TDJDSdxcAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:24:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:24:03 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-1DtrHgfFNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53765|0                           |1
        is obsolete|                            |
  Attachment #53766|0                           |1
        is obsolete|                            |
  Attachment #53767|0                           |1
        is obsolete|                            |
  Attachment #53768|0                           |1
        is obsolete|                            |
  Attachment #53769|0                           |1
        is obsolete|                            |

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53937&action=edit
Bug 10407: Allow MARCXML records to be imported via GUI (groundwork)

Patch from Olli, manual rebase by Marcel (July 7, 2016).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Needs follow-up. Test plan in the third patch.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:24:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:24:09 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-SQVbIKaa8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53938&action=edit
Bug 10407: Resolve warnings from child process

After the staging job finishes, the child tries to print results to
STDOUT (which is closed). This creates warnings like:

stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm
line 120.
stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at
/usr/lib/perl5/Template/Provider.pm line 964.

Resolving it is simple: the child should exit after marking the job
as finished.

Test plan:
Import a marc file.
Observe that you do no longer have such warnings.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:24:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:24:23 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-8MFKqUdLXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53939&action=edit
Bug 10407: Add marcxml import (follow-up)

This patch makes the following changes:

[1] Based on the groundwork of the former patch, add call to
    RecordsFromMARCXMLFile in stage-marc-import. Use format param.
[2] Add format to the template. Use file extension to determine.
    If you use .xml or .marcxml as extension, MARCXML is selected.
[3] In stage-marc-import.tt mark UTF-8 encoding as UTF-8 not as utf8.
[4] BatchStageMarcRecords: do not call plugin if you have no records.
[5] RecordsFromISO2709File: also return errors in an array.
[6] In misc/stage_file.pl also use UTF-8. Handling of errors from [5].

Test plan:
[1] Import an empty file as MARC or MARCXML (with Tools/Stage..import).
[2] Import an non-empty file with invalid contents as MARC or MARCXML.
[3] Export a few records with Tools/Export as MARC and MARCXML.
[4] Import these two files. Check selected format versus file extension.
[5] Import a MARCXML file with misc/stage_file.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:24:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:24:29 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-yFlo6UGjm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53940&action=edit
Bug 10407: Add two subtests to t/ImportBatch.t

Creates a few simple tests for the two new subroutines in ImportBatch.pm.

Test plan:
Run t/ImportBatch.t.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:24:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:24:38 +0000
Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with
 Tools/ Stage MARC records for import
In-Reply-To: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10407-70-Qr9twKFCAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53941&action=edit
Bug 10407: [QA Follow-up] Hashref process_batch params

As requested by Mark Tompsett. Hope this guarantees a signoff now..

Note: For consistency four additional parameters were needed to no longer
use file level vars in this subroutine.

Test plan:
Import a file with stage_file.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Imported a marc file and a marcxml file with stage_file.pl.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:28:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:28:52 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-lY5qVhSj4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53866|0                           |1
        is obsolete|                            |

--- Comment #4 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53942&action=edit
Bug 16652: RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers

What this patch does is it takes current state of the following bugs:
bug 13903
bug 16330
bug 13895
bug 16497
bug 16825
bug 17007
bug 16826
bug 15165
bug 17005

And rebases them on master altogether on each other fixing the merge
conflicts.

Using this patch it can be easily tried out the currently implemented
functionality of REST API (even though in development for now) by
running 'git bz apply 16652' after installing Koha's git-bz as decribed
here: https://wiki.koha-community.org/wiki/Git_bz_configuration

Also, the project xcncip2toolkit from eXtensibleCatalog has currently
it's Koha connector implemented with respect to current state of these
included bugs. See
https://github.com/eXtensibleCatalog/xcncip2toolkit/blob/master/connectors/koha

If you wish to try the full end-to-end functionality of this, you can
run docker to install the xcncip2toolkit for you:
https://github.com/eXtensibleCatalog/xcncip2toolkit/tree/master/dockerfile


This patch should be easier to apply than the previous.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 14:38:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 12:38:53 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-Hz8HCS2sbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53942|0                           |1
        is obsolete|                            |

--- Comment #5 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 53943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53943&action=edit
Bug 16652: RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers

Actualized included bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 15:31:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 13:31:02 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-CKDHkRHJti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 53926
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53926
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

Review of attachment 53926:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16885&attachment=53926)
-----------------------------------------------------------------

::: debian/scripts/koha-stop-zebra
@@ +35,5 @@
> +    # both daemon and zebrasrv processes for one instance
> +    # will go away, but there could be other processes
> +    # for other instances.
> +    expecting=`ps aux | grep zebra | wc -l`
> +    expecting=$((expecting-2))

zebrasrv forks a process for every active connection, so one can't count on
there being exactly two processes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 15:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 13:37:01 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-5CPRiXHbmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Per my previous comment, I don't think Mark's patch will be reliable.

I think a better approach would be to use start-stop-daemon, a la the init
script that ships with IndexData's own package of Zebra
(https://github.com/indexdata/idzebra/blob/master/debian/idzebra-2.0-utils.zebrasrv.init#L69):

  start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile $PIDFILE
--name $NAME

Unfortunately, daemon(1) doesn't appear to have any ability to specify using
SIGKILL.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 15:48:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 13:48:13 +0000
Subject: [Koha-bugs] [Bug 17039] New: No cancel/new item option when editing
	an item
Message-ID: <bug-17039-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17039

            Bug ID: 17039
           Summary: No cancel/new item option when editing an item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When you have started to edit an item, there is no 'cancel' link and no easy
way to catalog a new item instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 15:58:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 13:58:04 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-bRNMFMlYen@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Jacek and Srdjan!
Thanks for taking a look and sorry for the delay to get back to you.

(In reply to Jacek Ablewicz from comment #24)
> (In reply to Jonathan Druart from comment #21)
> > Could someone take a look at these patches?
> 
> Overall they look (mostly) fine to me, or at least a move in the right
> direction[s]. They are a bit hard to digest though, lots of collateral fixes
> included - if some of them could be (?) moved to the separate reports,
> signing off and Q&A will probably have a much better chance to occur in
> foreseeable future ;).

That's why I have prefixed the commit messages with Bug XXXXX_1|2|3.
Patches with "Bug XXXXX_1" should go on their own bug report, same with _2 and
_3.
I plan to move them, but I wanted to know if the different changes were
appreciated before splitting them.

> Not sure if I fully understand a concept of namespaces / sub-namespaces
> introduced with this patch set (and what are they needed for exactly,
> especially in such particular form). E.g. L1 storage hash still remains a
> shared singleton (sort of) - moving L1 storage to the cache objects instead
> (and ideally tying those objects to the Koha contexts in 1:1 relationship)
> seems to be much less headache-prone long term solution IMO.

Yes indeed, it was the easy and lazy approach. My first idea was to manage it
from Koha::Caches which makes more sense, but it was not so easy.
I'd be happy to improve that if you have a good idea on how to do it.

(In reply to Srdjan Jankovic from comment #25)
> (In reply to Jacek Ablewicz from comment #24)
> > By the look of it, in regards of cache architectural changes, there will be
> > some overlap with Bug 15562, which in parts does somehow similar things with
> > the cache (and a lot of other interesting things as well, but it's huge and
> > I don't really understand ~half of it). Are there any chances of coordinated
> > effort of some sort, so they both don't clash too badly with each other?
> 
> That's terrible. Next time I rebase I'll try to make it more readable.
> Apologies.
> 
> Changes presented here are almost identical to the changes 15562, except
> that they are a bit better:
> * I fell short of introducing Koha::Config which I should have (I chickened
> out)
> * Koha::Caches - maybe we need to mandate the namespace when instantiating
> Koha::Cache in order for this to be more robust?

Does that mean you would agree to let these patches make his own way then
rebase yours? :)

> One thing that might be worth thinking about is that the very same problem
> exists with the database connections. So maybe some ?ber class,
> Koha::Storage or something that would have a slot for everything we use, and
> then Koha::Storages collection keyed by the namespace?

I think we are dealing pretty well with our cache improvements: we improve it a
lot without breaking anything (so far!), using small steps.
So I'd suggest to continue like that and keep in mind these Koha::Storage[s]
classes

What's next? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:11:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:11:15 +0000
Subject: [Koha-bugs] [Bug 17040] New: Context menu when editing items is not
	translated
Message-ID: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

            Bug ID: 17040
           Summary: Context menu when editing items is not translated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

When editing items, you can click in any cell of the items table above the form
to get see a context menu (similar to the import options in the z39.50 search).
This menu's items appear to be not translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:16:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:16:03 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-Uco1zWnqWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:22:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:22:53 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-ssoUoZFp0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Galen Charlton from comment #7)
> Per my previous comment, I don't think Mark's patch will be reliable.
> 
> I think a better approach would be to use start-stop-daemon, a la the init
> script that ships with IndexData's own package of Zebra
> (https://github.com/indexdata/idzebra/blob/master/debian/idzebra-2.0-utils.
> zebrasrv.init#L69):
> 
>   start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile $PIDFILE
> --name $NAME
> 
> Unfortunately, daemon(1) doesn't appear to have any ability to specify using
> SIGKILL.

I agree, and we already use start-stop-daemon koha-plack.

Good catch, Galen!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:24:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:24:57 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-OqTfcW1fGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52705|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53945&action=edit
Bug XXXXX_1: Fix support of several memcached servers

There is a bug in the initialisation of memcached, the server string is
not correctly parsed.
If several memcached servers are defined, they are separated by commas
and so the string should be split accordingly

Test plan:
1/ Set MEMCACHED_SERVERS='localhost:11211,localhost:11222'
2/ Set DEBUG=1
3/ Reload plack, and check the log
=> Without this patch, you see
  Memcached server settings: localhost:11211,localhost:11222 with koha
  Selected caching system: Cache::Memory=HASH(0x9de2034)
i.e. Memcached has not been configured correctly and the default caching
system is used (Cache::Memory)
=> With this patch, you should see
Memcached server settings: localhost:11211, localhost:11222 with koha
Selected caching system: Cache::Memcached::Fast=SCALAR(0xa2a0c54)
i.e. Memcached has been configured correctly \o/

Note that the cache_servers attribute is never set and it not used. It's
better to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:25:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:25:08 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-indLTtPaLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52706|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53946&action=edit
Bug XXXXX_2: Add the ability to define several namespaces - tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:25:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:25:29 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-WYc4fr5qDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52707|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53947&action=edit
Bug XXXXX_2: Add the ability to define several namespaces - Koha::Caches

We need to define take into account several namespaces for our cache
system. For instance sysprefs, koha conf (koha-conf.xml) and unit tests
should be defined in a separate namespace. This will permit to
- launch the tests without interfering with other cache values
- and flush the sysprefs cache without flushing all other values

To do so, we need to store different Koha::Cache objects at a package
level. That's why this patch adds a new Koha::Caches module.

FIXME: There is an architecture problem here: the L1 cache should be
defined in Koha::Cache

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:25:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:25:43 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-0zqqnNQrYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52708|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53948&action=edit
Bug XXXXX_2: Add the ability to define several namespaces - replace existing
occurrences

s/Koha::Cache->get_instance/Koha::Caches->get_instance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:25:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:25:55 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-I8RUfLOGwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52709|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53949&action=edit
Bug XXXXX_3: Restore memcached infos to koha-conf

MEMCACHED_SERVERS and MEMCACHED_NAMESPACE should be moved back to
koha-conf instead of an ENV var to let command line scripts use
the cache mechanism.

TODO:
- Add the entries to koha-conf.xml
- Remove occurrences of MEMCACHED_SERVERS in package, apache and plack files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:26:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:26:03 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-JFLzp53Qkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52710|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53950&action=edit
Bug XXXXX_3: Restore memcached infos to koha-conf - Koha::Config

Move C4::Context->read_config_file to Koha::Config
That permits to reuse it from Koha::Cache without needing C4::Context
(and introduce a circular deps).

TODO: Add decent POD to Koha::Config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:26:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:26:11 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-piqsNT9JCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52711|0                           |1
        is obsolete|                            |

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53951&action=edit
Bug XXXXX_3: Update remaining occurrences of ->ismemcached

TODO: Would be better to provide a better way to know if memcache is correctly
set

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:32:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:32:02 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-p8EmaQctLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53947|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53952&action=edit
Bug XXXXX_2: Add the ability to define several namespaces - Koha::Caches

We need to define take into account several namespaces for our cache
system. For instance sysprefs, koha conf (koha-conf.xml) and unit tests
should be defined in a separate namespace. This will permit to
- launch the tests without interfering with other cache values
- and flush the sysprefs cache without flushing all other values

To do so, we need to store different Koha::Cache objects at a package
level. That's why this patch adds a new Koha::Caches module.

FIXME: There is an architecture problem here: the L1 cache should be
defined in Koha::Cache

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:32:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:32:12 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-rL5iHPgK09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53948|0                           |1
        is obsolete|                            |

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53953&action=edit
Bug XXXXX_2: Add the ability to define several namespaces - replace existing
occurrences

s/Koha::Cache->get_instance/Koha::Caches->get_instance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:32:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:32:18 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-mtVj8opq5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53949|0                           |1
        is obsolete|                            |

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53954&action=edit
Bug XXXXX_3: Restore memcached infos to koha-conf

MEMCACHED_SERVERS and MEMCACHED_NAMESPACE should be moved back to
koha-conf instead of an ENV var to let command line scripts use
the cache mechanism.

TODO:
- Add the entries to koha-conf.xml
- Remove occurrences of MEMCACHED_SERVERS in package, apache and plack files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:32:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:32:24 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-Ge3PdRMQTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53950|0                           |1
        is obsolete|                            |

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53955&action=edit
Bug XXXXX_3: Restore memcached infos to koha-conf - Koha::Config

Move C4::Context->read_config_file to Koha::Config
That permits to reuse it from Koha::Cache without needing C4::Context
(and introduce a circular deps).

TODO: Add decent POD to Koha::Config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:32:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:32:30 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-StyRJQNtrq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53951|0                           |1
        is obsolete|                            |

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53956&action=edit
Bug XXXXX_3: Update remaining occurrences of ->ismemcached

TODO: Would be better to provide a better way to know if memcache is correctly
set

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:50:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:50:34 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-qAjFPkvm9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:50:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:50:37 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-a1Y9iM4flY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53957&action=edit
Bug 17040: Fix translation on context menu when editing items

Test plan:
update and install translated language files
On the item list (cataloguing/additem.pl) the context menu should be
translated (Edit item/Delete item)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:50:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:50:49 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-Y9rHfrPxCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 16:58:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 14:58:46 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-GB7Wvavjyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
           Assignee|kyle at bywatersolutions.com   |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:11:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:11:48 +0000
Subject: [Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed
In-Reply-To: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17037-70-NN19pAuTJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Matthew,
Did you check the log files?
3.16 is old and no longer maintainable. Could you confirm the bug on a more
recent version (if possible the latest)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:27:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:27:18 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-DY1PfvdFiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:27:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:27:21 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-dMDqQQNtd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53926|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 53958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53958&action=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch follows Galen's suggestion in comment #7.

TEST PLAN
---------
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
      didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
    -- the process ids for the zebrasrv and daemon processes should
       be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

Sponsored-by: Tulong Aklatan

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:32:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:32:14 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-Fcsj3vvGfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:32:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:32:18 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-OhIwsABN6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53959&action=edit
Bug 16996: Do not explode if mandatory fields are missing

At the OPAC, if a patron modify his/her information and at least 1
mandatory field is missing, Koha will crash with
  Template process failed: undef error - Can't call method "description"

It is raised by Koha::Template::Plugin::Categories::GetName called with
an undefined categorycode.
The problem is that the values sent originaly are not sent back to the
template if the user missed something.
This patch makes that all info are resent to the template in order to
show the same form to the user.

Test plan:
1. Make sure that the categorycode is not hidden in the OPAC in:
     PatronSelfRegistrationBorrowerUnwantedField or
PatronSelfModificationBorrowerUnwantedField

2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for
example email.

3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave
blank the required field of point 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:32:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:32:30 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-gs4kbhKiBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.05                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:32:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:32:38 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-NplL0qJFsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:33:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:33:53 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-JDNE1zq1rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #13 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Jiri Kozlovsky from comment #11)
> Lari: You have probably changed in your comment bug ID for 16826
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825#c9

Indeed. Sorry about that!

(In reply to Jonathan Druart from comment #12)
> (In reply to Lari Taskula from comment #9)
> > Also, to avoid forgotten columns in definitions, adds a test to
> > compare item-definition to database's items-table.
> 
> Lari, thanks for that!
> Do you think you could provide a global check?
> It would look at the api/v1/definitions/*.json files and compare the columns
> with Koha::Objects->columns (added by bug 16889).

As discussed on IRC, I have provided a test that does this, in Bug 17032.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:43:50 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-x13Kt7N0wh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53960&action=edit
Bug 16894: Regression - Display email on patron search results

Bug 10318 added the email to the patron search results but it has been
removed later.
This patch reintroduced it where it was (no new column).

Test plan:
Search for patrons and confirm that the emails are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:43:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:43:47 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-vDy5S6b1eW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:44:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:44:00 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-Vy9XoQCLsE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:44:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:44:45 +0000
Subject: [Koha-bugs] [Bug 17041] New: Fix missing properties in Swagger
 definition for Patron
Message-ID: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

            Bug ID: 17041
           Summary: Fix missing properties in Swagger definition for
                    Patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

api/v1/definitions/patron.json is missing two properties checkprevcheckout and
updated_on. Add these properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:45:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:45:50 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-bQp2LdsFoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041
[Bug 17041] Fix missing properties in Swagger definition for Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:45:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:45:50 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-lY10kEEEMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13799
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:45:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:45:54 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-J1CcJmJ5Od@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53961&action=edit
Bug 17041: Fix missing properties in patron.json

Swagger definition for patron was missing two properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:46:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:46:38 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-Uwb6jpT0D3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041
[Bug 17041] Fix missing properties in Swagger definition for Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:46:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:46:38 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-jQNubGOZbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:47:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:47:46 +0000
Subject: [Koha-bugs] [Bug 17042] New: Fix missing properties in Swagger
 definition for Hold
Message-ID: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

            Bug ID: 17042
           Summary: Fix missing properties in Swagger definition for Hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

api/v1/definitions/hold.json is missing a property itemtype. Add this property.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:35 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete holds
In-Reply-To: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-U8qArTneH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17042


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042
[Bug 17042] Fix missing properties in Swagger definition for Hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:35 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-0PwJk6tLIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
         Depends on|                            |13903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:38 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-FfxrJQqQZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53962&action=edit
Bug 17042: Fix missing column in hold.json

Swagger definition for hold was missing a property.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:54 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-7v7ffVglp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17042


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042
[Bug 17042] Fix missing properties in Swagger definition for Hold
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:54 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-TzmGsD3i2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 17:48:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 15:48:55 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-MB5388RPkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 53936
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53936
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

Review of attachment 53936:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17032&attachment=53936)
-----------------------------------------------------------------

::: t/db_dependent/api/v1/swagger/definitions.t
@@ +72,5 @@
> +
> +    $name = "Koha::" . ucfirst $name;
> +
> +    return eval {
> +        Module::Load::load($name);

The correct way to do that is to use Module::Load::Conditional.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:05:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:05:24 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-YqLMhXb0c8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53936|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 53963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53963&action=edit
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:07:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:07:57 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-9QaXmomKXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #4 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Jonathan Druart from comment #2)
> The correct way to do that is to use Module::Load::Conditional.
As requested, patch above.

By the way, at the moment tests are failing, because patron.json is missing 2
properties and hold.json is missing one. Apply bugs Bug 17041 and Bug 17042 to
run this cleanly (also sign-off for them will be appreciated :).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:03 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-JJH3YyGgjy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17041                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041
[Bug 17041] Fix missing properties in Swagger definition for Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:03 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-5z4TwPlurm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17032                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:17 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-TtUP2BvKf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17042                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042
[Bug 17042] Fix missing properties in Swagger definition for Hold
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:17 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-nUzJmR9nt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17032                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:37 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-2Z6bDstnCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:37 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-7M0sAv5ijO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17041, 17042


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041
[Bug 17041] Fix missing properties in Swagger definition for Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042
[Bug 17042] Fix missing properties in Swagger definition for Hold
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:09:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:09:37 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-d0YHz8bf3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:15:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:15:25 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-MI2t3ZwID9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53921|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 18:45:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 16:45:10 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-Fv5QxM1cK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:16:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:16:05 +0000
Subject: [Koha-bugs] [Bug 17043] New: debian/list-deps fixes, master edition
Message-ID: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

            Bug ID: 17043
           Summary: debian/list-deps fixes, master edition
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

This makes debian/list-deps ready for Debian Jessie and adds small fixes I
already use for package releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:32:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:32:08 +0000
Subject: [Koha-bugs] [Bug 17044] New: Wrong destination for 'api' directory
Message-ID: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

            Bug ID: 17044
           Summary: Wrong destination for 'api' directory
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- Make a standard install (for example in /usr/share/koha
=> FAIL: check /usr/share/koha/api/api exists
- Make a single install (for example in /home/tcohen/koha-single)
=> FAIL: check /home/tcohen/koha-single/api/api exists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:32:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:32:55 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-ZWh8C8K04H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com
         Depends on|                            |13799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:32:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:32:55 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-5lMiYYnTMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17044


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044
[Bug 17044] Wrong destination for 'api' directory
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:40:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:40:41 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-PhMcSyNCfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:40:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:40:44 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-QoFePKeLcl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 53964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53964&action=edit
Bug 17044: Fix wrong destination for 'api' directory

The original Makefile.PL tweak missed to trim the directory name thus
repeating the 'api' directory like in 'api/api'.

To test:
- Make a standard install (for example in /usr/share/koha
=> FAIL: check /usr/share/koha/api/api exists
- Make a single install (for example in /home/tcohen/koha-single)
=> FAIL: check /home/tcohen/koha-single/api/api exists
- Apply the patch
- Make a standard install (for example in /usr/share/koha
=> SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api'
dir
- Make a single install (for example in /home/tcohen/koha-single)
=> SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a
nested 'api' dir
- Sign off :-D

Note: this affects the packages too, as the standard install is used as a
basis.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:41:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:41:19 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-ileLNDxzk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17044


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044
[Bug 17044] Wrong destination for 'api' directory
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:41:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:41:19 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-nClnEdDNzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030
[Bug 17030] Configure the REST api on packages install
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:46:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:46:00 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-GcRpkOeF4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53967&action=edit
Bug 17043 - master control file

latest control file update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:45:55 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-lthpoIFJIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53965&action=edit
Bug 17043 - debian/list-deps fixes, master edition

This makes debian/list-deps ready for Debian Jessie
and adds small fixes I already use for package releases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:45:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:45:57 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-QQXNFSjfTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 53966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53966&action=edit
Bug 17043 - Readonly deps

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 19:47:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 17:47:02 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-BJvATVZfxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:21:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:21:20 +0000
Subject: [Koha-bugs] [Bug 16476] CGI->param('foo') in list context allows
 XSS ( e.g. Javascript injection) in Koha
In-Reply-To: <bug-16476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16476-70-zizPoE2zrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16476

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |gmcharlt at gmail.com
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
              Group|Koha security               |
            Version|unspecified                 |master
            Product|Koha security               |Koha
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.20.x will be in 3.20.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:23:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:23:55 +0000
Subject: [Koha-bugs] [Bug 15111] Koha is vulnerable to Cross-Frame Scripting
 (XFS) attacks
In-Reply-To: <bug-15111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15111-70-6NBO51vCeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15111

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
         Resolution|---                         |FIXED
            Version|unspecified                 |master
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
            Product|Koha security               |Koha
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:23:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:23:56 +0000
Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is
	disabled
In-Reply-To: <bug-16210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16210-70-2BQwuLeEF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210
Bug 16210 depends on bug 15111, which changed state.

Bug 15111 Summary: Koha is vulnerable to Cross-Frame Scripting (XFS) attacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15111

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:54:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:54:39 +0000
Subject: [Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron
 who requested
In-Reply-To: <bug-1887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1887-70-hGfwR5UCIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:56:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:56:10 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-W3YkKwVdB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:56:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:56:28 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-TR0hfx47Bt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:56:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:56:51 +0000
Subject: [Koha-bugs] [Bug 9228] log of messages left
In-Reply-To: <bug-9228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9228-70-UWibma5eoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9228

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:57:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:57:14 +0000
Subject: [Koha-bugs] [Bug 9230] selectively delete reading history
In-Reply-To: <bug-9230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9230-70-xkbhchMK68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 22:57:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 20:57:44 +0000
Subject: [Koha-bugs] [Bug 9227] items in transit can be checked out without
	warning
In-Reply-To: <bug-9227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9227-70-wCSn7EzYPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9227

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:17:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:17:49 +0000
Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion
In-Reply-To: <bug-11450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11450-70-EzLXMK8ysW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:23:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:23:27 +0000
Subject: [Koha-bugs] [Bug 9567] favorite reports per user
In-Reply-To: <bug-9567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9567-70-FA4CAxnC6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:25:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:25:16 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-bgTwBMgVFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53964|0                           |1
        is obsolete|                            |

--- Comment #2 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 53974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53974&action=edit
Bug 17044: Fix wrong destination for 'api' directory

The original Makefile.PL tweak missed to trim the directory name thus
repeating the 'api' directory like in 'api/api'.

To test:
- Make a standard install (for example in /usr/share/koha
=> FAIL: check /usr/share/koha/api/api exists
- Make a single install (for example in /home/tcohen/koha-single)
=> FAIL: check /home/tcohen/koha-single/api/api exists
- Apply the patch
- Make a standard install (for example in /usr/share/koha
=> SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api'
dir
- Make a single install (for example in /home/tcohen/koha-single)
=> SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a
nested 'api' dir
- Sign off :-D

Note: this affects the packages too, as the standard install is used as a
basis.
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:26:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:26:46 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-rhxZzB6MVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Good catch Thomas!
Have been scratching my head on this one, and will remove my symlink as soon as
this is in master ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:28:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:28:42 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-6SN8hwtiuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Benjamin Rokseth from comment #3)
> Good catch Thomas!
> Have been scratching my head on this one, and will remove my symlink as soon
> as this is in master ;)

Hehehe.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:54:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:54:30 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-KuQmXlC0la@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53963|0                           |1
        is obsolete|                            |

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 53980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53980&action=edit
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

If a definition in api/v1/definitions/*.json has a corresponding Koha-object by
filename, compare properties of the definition and columns of the Koha-object
and ensure that all columns are defined inside properties of the definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. See that all of the tests pass. (If not, file a bug report to fix missing
   properties in the Swagger definition.)
3. Remove a property from api/v1/swagger/definitions/patron.json
4. Repeat step 1
5. See that test fails and lets you know that the property you just removed
   is missing from the definition.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:55:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:55:18 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-zW9PldTAmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Works as intended! Good work!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:57:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:57:15 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-umMSmeUQ4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53961|0                           |1
        is obsolete|                            |

--- Comment #2 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 53981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53981&action=edit
Bug 17041: Fix missing properties in patron.json

Swagger definition for patron was missing two properties.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:57:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:57:51 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-fFt67M9Xej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:58:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:58:52 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-5gtYuPkhaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53962|0                           |1
        is obsolete|                            |

--- Comment #2 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 53982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53982&action=edit
Bug 17042: Fix missing column in hold.json

Swagger definition for hold was missing a property.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug  3 23:59:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 21:59:10 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-IIch0fSX2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 00:33:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 22:33:21 +0000
Subject: [Koha-bugs] [Bug 17045] New: Write API to Allow instant use of
	reports library
Message-ID: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045

            Bug ID: 17045
           Summary: Write API to Allow instant use of reports library
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: lisetteslatah at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Write an API that would allow us to select and run reports directly from the
Koha Community Reports Library, as discussed at Koha US Conference 2016 during
the reports Round table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 00:35:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 22:35:39 +0000
Subject: [Koha-bugs] [Bug 17045] Write API to Allow instant use of reports
	library
In-Reply-To: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17045-70-gQG3MJUw4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 01:57:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 03 Aug 2016 23:57:32 +0000
Subject: [Koha-bugs] [Bug 17045] Write API to Allow instant use of reports
	library
In-Reply-To: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17045-70-SCNJpGepD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
I think doing something with mana that biblibre is working on is a much better
idea.

Running stuff directly from a wiki that anyone can edit, is a hugely insecure
idea. 
SELECT
  biblionumber, 
  CONCAT('<script>alert\(\"',title,'\"\)</script>') AS Title 
FROM biblio 
ORDER BY biblionumber

Is a safe but annoying one, it could easily be changed to run some much more
dangerous js, or dump the persons sessionid etc.

I would hope people are reading the sql they are cutting and pasting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 02:40:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 00:40:44 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-Z5Sert0P5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #39 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
> (In reply to Srdjan Jankovic from comment #25)
> Does that mean you would agree to let these patches make his own way then
> rebase yours? :)

Absolutely. It affects only one of my patches, and if lucky enough I may even
be able to throw it away. It is a pre-patch anyway, to prepare the grounds for
the real issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 08:45:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 06:45:50 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-LGBEKyujqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You forgot one call:

circ/circulation.pl
    modifications             =>
Koha::Patron::Modifications->GetModifications({ borrowernumber =>
$borrowernumber }),

And two typos :)
requrest
applys

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 08:54:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 06:54:22 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-k2nCrjkEzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 08:54:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 06:54:25 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-DJoVZvBpXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53957|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 53987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53987&action=edit
Bug 17040: Fix translation on context menu when editing items

Test plan:
update and install translated language files
On the item list (cataloguing/additem.pl) the context menu should be
translated (Edit item/Delete item)

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:10:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:10:37 +0000
Subject: [Koha-bugs] [Bug 17046] New: t/Creators.t kills master packages
Message-ID: <bug-17046-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17046

            Bug ID: 17046
           Summary: t/Creators.t kills master packages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mirko at abunchofthings.net
        QA Contact: gmcharlt at gmail.com

debian/build-git-snapshot on master dies because of t/Creators.t:

ERROR in koha-conf.xml -- missing <font type="H">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="H">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.

#   Failed test 'testing StrWidth() returns correct point width'
#   at t/Creators.t line 55.
#          got: '19.344'
#     expected: '23.044921875'

#   Failed test 'testing Text() writes to the correct x-value'
#   at t/Creators.t line 59.
#          got: '29.344'
#     expected: '33.044921875'
ERROR in koha-conf.xml -- missing <font type="TR">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="TB">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="TI">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="TBI">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="C">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="CB">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="CO">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="CBO">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="H">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="HO">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="HB">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
ERROR in koha-conf.xml -- missing <font type="HBO">/path/to/font.ttf</font> at
/build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm
line 120.
Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820.
# Looks like you planned 41 tests but ran 39.
# Looks like you failed 2 tests of 39 run.
# Looks like your test exited with 25 just after 39.
t/Creators.t ........................ 
Dubious, test returned 25 (wstat 6400, 0x1900)
Failed 4/41 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:20:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:20:44 +0000
Subject: [Koha-bugs] [Bug 17047] New: Mana webservice : share and use common
 information between Kohas
Message-ID: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

            Bug ID: 17047
           Summary: Mana webservice : share and use common information
                    between Kohas
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: morgane.alonso at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

RFC :
https://wiki.koha-community.org/wiki/SharingDatasBetweenKohas_rfc

Progress of the Mana features :
https://wiki.koha-community.org/wiki/Mana_central_database

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:22:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:22:42 +0000
Subject: [Koha-bugs] [Bug 17045] Write API to Allow instant use of reports
	library
In-Reply-To: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17045-70-sGtbDC6QLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Chris Cormack from comment #1)
> I think doing something with mana that biblibre is working on is a much
> better idea.

Agreed, this sounds like a good fit for Mana - see bug 17047

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:22:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:22:51 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-whXWQVYLak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #1 from alonso morgane <morgane.alonso at biblibre.com> ---
Code :

Server source code : 
http://git.biblibre.com/biblibre/koha-mana
Client source code integrated in Koha :
http://git.biblibre.com/biblibre/kohac/commits/koha-mana

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:22:55 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-f8T7gI7MJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17045

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:22:55 +0000
Subject: [Koha-bugs] [Bug 17045] Write API to Allow instant use of reports
	library
In-Reply-To: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17045-70-iAzvXwETG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17047

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:23:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:23:51 +0000
Subject: [Koha-bugs] [Bug 16994] Import and export MARC modification
	templates
In-Reply-To: <bug-16994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16994-70-BG2gQ5nAzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17047

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Maybe something for Mana? See bug 17047.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:23:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:23:51 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-gglY8Kl3Sh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16994

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 09:33:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 07:33:12 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-0NJgbAcRAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

alonso morgane <morgane.alonso at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |morgane.alonso at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 11:06:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 09:06:33 +0000
Subject: [Koha-bugs] [Bug 17048] New: Authority search result list page
 scrolling not working properly
Message-ID: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

            Bug ID: 17048
           Summary: Authority search result list page scrolling not
                    working properly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: imingchan at yahoo.com.au
        QA Contact: testopia at bugs.koha-community.org

Created attachment 53988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53988&action=edit
Record 1-20 (Page 1)

Authority search result list page scrolling not working properly.  The ">"
(single right arrow) doesn't start from the end of previous page.  

For example, after displayed record 1-20. Click ">", you should get record
21-40, but, it actually showing record 2-21!  See screen shots attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 11:07:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 09:07:55 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-BVwmGzE4ia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #1 from Iming Chan <imingchan at yahoo.com.au> ---
Created attachment 53989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53989&action=edit
Record 21-40 (Page 2) -- Actual: Record 2-21

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 11:09:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 09:09:11 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-Tlr9OxQFF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #2 from Iming Chan <imingchan at yahoo.com.au> ---
Created attachment 53990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53990&action=edit
Record 41 (Page 3) -- Actual: Record 3-22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 11:29:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 09:29:00 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-6DPzjXBrLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53217|0                           |1
        is obsolete|                            |

--- Comment #15 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Comment on attachment 53217
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53217
[SIGNED-OFF] Bug 16330: (followup) fix spelling and number of tests

same patch occurring twice

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 11:47:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 09:47:59 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-FDdhx9JRJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #29 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Benjamin Rokseth from comment #28)
> (In reply to Lari Taskula from comment #27)
> > Hey Benjamin, thanks for the interest! I'm glad we share a desire to split
> > our specification :)
> > 
> > (In reply to Benjamin Rokseth from comment #26)
> > > Also I'm not sure of the need to minify swagger at all. If the only reason
> > > is for the online validation, I would argue that the online validation is
> > > the problem. More important is `mojo swagger2 validate`.
> > Our spec in master is not a valid Swagger spec, even if `mojo swagger2
> > validate` says so. Swagger specification does not support a reference whole
> > Definitions-object in swagger.json like this:
> > 
> > "definitions": {
> >   "$ref": "./definitions/index.json"
> > }
> > 
> > That is super annoying, but I think we also want to validate against the
> > online validator because it spots this issue. `mojo swagger2 validate` works
> > (for now), but what if the plugin's validator is updated to consider this
> > type of $ref invalid (as Swagger specification says)? We would have to place
> > all definitions and paths in swagger.json, and at maximum $ref individual
> > paths and definitions to external files, not the whole Paths /
> > Definitions-object.
> > 
> > I think Olli-Antti also encountered some other issues that this minifier
> > fixes. Maybe he can comment more about it.
> > 
> > Btw, I have opened an issue to Swagger2 plugin's GitHub to initiate some
> > more discussion: https://github.com/jhthorsen/swagger2/issues/89
> 
> Lari, I engaged in your discussion at github, but to be sure, are we talking
> about the same thing? I test the swagger definitions at the online swagger
> validator and it obviously fails at relative and URI, as they are not
> resolvable to the validator. This is to be expected, but does not mean the
> definition is invalid. The only way to validate online in any case would be
> to first resolve all refs to one single json document.
> 
> You refer to invalid refs in swagger specifications, but I only find this
> discussion in the swagger-ui
I agree that the online swagger validator is unable to resolve relative
references, but the original issue still exists. You can also write a single
spec file with the problem in online validator, e.g.

{
  "swagger": "2.0",
  "info": { "version": "0.1", "title" : "ref all paths/definitions" },
  "paths": { "$ref": "#/x-def/paths" },
  "definitions": { "$ref": "#/x-def/definitions" },
  "x-def": {
    "definitions": {
      "patron": {
        "type": "object",
        "properties": {
          "borrowernumber": {
            "type": "string",
            "description": "internally assigned user identifier"
          }
        }
      }
    },
    "paths": {
      "/patrons": {
        "get": {
          "responses" : {
            "200": {
              "description": "A list of patrons",
              "schema": {
                "type": "array",
                "items": {
                  "$ref": "#/definitions/patron"
                }
              }
            }
          }
        }
      }
    }
  }
}
online.swagger.io validator will return:
"attribute paths.$ref is not of type `object`",
"attribute definitions.$ref is not of type `object`"

`mojo swagger2 validate` works because it resolves all $refs before validation.
The validation never sees a "$ref". When adjusted to not resolve $refs in our
own spec, I got
[JSON::Validator] type /paths _validate_type_object [/paths: Properties not
allowed: $ref.]
[JSON::Validator] type /definitions/$ref _validate_type_object
[/definitions/$ref: Expected object - got string.]

To make this spec pass validation (both online validator and adjusted case of
JSON::Validator), we need to $ref individual paths and definitions instead,
e.g.:
{
  "swagger": "2.0",
  "info": { "version": "0.1", "title" : "ref individual paths/definitions" },
  "paths": {
    "/patrons": { "$ref": "#/x-def/paths/patrons" }
  },
  "definitions": {
    "patron": { "$ref": "#/x-def/definitions/patron" }
  },
  "x-def": {
    "definitions": {
      "patron": {
        "type": "object",
        "properties": {
          "borrowernumber": {
            "type": "string",
            "description": "internally assigned user identifier"
          }
        }
      }
    },
    "paths": {
      "patrons": {
        "get": {
          "responses" : {
            "200": {
              "description": "A list of patrons",
              "schema": {
                "type": "array",
                "items": {
                  "$ref": "#/definitions/patron"
                }
              }
            }
          }
        }
      }
    }
  }
}

This issue is referred also elsewhere than swagger-ui, here are some links:
https://github.com/mission-liao/pyswagger/issues/53#issuecomment-168872441
(also points to OpenAPI Specification, "@webron: You can reference specific
http verb operations, not full sets of paths.")
swagger-parser comment on the article about splitting spec:
https://github.com/swagger-api/swagger-parser/issues/87#issuecomment-140280055

It's just some of the annoying features in Swagger. It also looks like the
author of Swagger2/OpenAPI plugin has commited this change in the new OpenAPI
plugin
https://github.com/jhthorsen/mojolicious-plugin-openapi/commit/7d804c58eae51b42b3506badd59d4123fb723e8c
and I guess this means that in the future our current spec will not validate
without first resolving all the $refs with (for example) this minifier script.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 12:22:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 10:22:49 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-xZjA1z6rk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
We have implemented userid/cardnumer & password CGISESSID-authentication. I
will rebase it on master and upload the patch here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 12:46:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 10:46:18 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-t6VfeG2Jwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hi Alonso,
Just glancing a little bit thru your Koha code, I see you introduce
Koha::Branch. Did you see Koha::Library already? Confusingly true :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 13:53:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 11:53:06 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-YOsc3GWcYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick code review:

1/ The default value for the new pref should be "off"

2/ Tabulation chars should be replaced with 4 tabs

3/ $tmp is rarely a correct variable name :)

4/ Additional fields are displayed (but not taken into account) on the mana
subscriptions search form

5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead

6/ Share> "Language of your sharing" is hidden on the right.

7/ "The export is done, thank you for your contribution." => It should not be
yellow (alert) but green (message)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 14:05:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 12:05:31 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-L9r1MMYyeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> 2/ Tabulation chars should be replaced with 4 tabs

Hope that this is not a recursive rule..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 14:42:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 12:42:01 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-JCiZMNJK5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marcel de Rooy from comment #4)
> > 2/ Tabulation chars should be replaced with 4 tabs
> 
> Hope that this is not a recursive rule..

It is a rule for all new files added to Koha and for all changed lines in
patches.

https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 15:17:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 13:17:56 +0000
Subject: [Koha-bugs] [Bug 17049] New: Plack: Handle multiple paths in
	PERL5LIB
Message-ID: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

            Bug ID: 17049
           Summary: Plack: Handle multiple paths in PERL5LIB
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 15:18:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 13:18:11 +0000
Subject: [Koha-bugs] [Bug 17049] Plack: Handle multiple paths in PERL5LIB
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-E7vyasq24I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 15:18:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 13:18:21 +0000
Subject: [Koha-bugs] [Bug 17049] Plack: Handle multiple paths in PERL5LIB
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-ENq9aaAtQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 15:19:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 13:19:01 +0000
Subject: [Koha-bugs] [Bug 17049] Plack: Handle multiple paths in PERL5LIB
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-nPucRRYBdT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16733


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733
[Bug 16733] More flexible paths in debian scripts (for dev installs)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 15:19:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 13:19:01 +0000
Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for
	dev installs)
In-Reply-To: <bug-16733-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16733-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16733-70-XZOGTAUSV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049
[Bug 17049] Plack: Handle multiple paths in PERL5LIB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:14:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:14:43 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
	planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-jCmTLp2MCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |c.gravely at arts.ac.uk

--- Comment #2 from Claire Gravely <c.gravely at arts.ac.uk> ---
Hi,
After applying the patch both buttons appear.
After clicking on the auto-fill button the fields briefly populate, but then
the page refeshes and they clear back to 0.00 again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:45:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:45:45 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Y4bGJ5nUUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #6 from alonso morgane <morgane.alonso at biblibre.com> ---
(In reply to Marcel de Rooy from comment #2)
> Hi Alonso,
> Just glancing a little bit thru your Koha code, I see you introduce
> Koha::Branch. Did you see Koha::Library already? Confusingly true :)

Hi Marcel de Rooy, I don't see it, sorry! I'll change that and use the right
Koha object.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:55:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:55:59 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-wVrgS4fsfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 53991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53991&action=edit
Bug 17030: Enable REST api on packages

This patch enables access to the REST API endpoint on packages setup.
It does so, by patching the shared apache-shared-intranet.conf and
apache-shared-opac.conf.

You can build your own master packages with this patch applied, or just:

- Grab
  debian/templates/apache-shared-intranet.conf
  debian/templates/apache-shared-opac.conf
and overwrite their counterparts in /etc/koha on a packages setup. For example
in kohadevbox.
- Have Koha loaded with all default data
- Create a superlibrarian user for you
- Login to the intranet and the OPAC
- Point your browser to:
  http://localhost:8080/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
  http://localhost:8081/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
- Sign off :-D

Note: I use the HTTPRequester addon for Firefox, re-using the CGISESSID value
from the
browser session cookie, in the headers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:56:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:56:04 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-d66dSVuHdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 53992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53992&action=edit
Bug 17030: Make REST api available on packages with plack enabled

This patch is the starting point for making the REST api available
on Plack.

What it does:
- It creates the /api/v1/app.pl mount point in plack.psgi
- It enables the ProxyPass and ProxyPassReverse directives so it
  is reached through Plack.

TODO: It is missing the rewrite part.

To test:
- Grab the following files, and put them in /etc/koha (overwrite the existing
ones)
  debian/templates/apache-shared-intranet-plack.conf
  debian/templates/apache-shared-opac-plack.conf
- Tweak your /etc/koha/sites/kohadev/plack.psgi file so the API-related stuff
  is present on your file.
- Make sure Plack is enabled for the instance:
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --restart kohadev
  $ sudo service apache2 restart
- Follow the previous patch test plan, but use this URLs (no pretty URL for
now):

  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
  http://localhost:8081/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Sign off :-D

Note: this patch made a bug visible (the session is lost when accessing the API
through
Plack) but it shouldn't prevent its inclusion because the API right now is not
even available
as default for developers to test or fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:56:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:56:45 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-NHFG24ifEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:56:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:56:57 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-aWMSWqiYDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:59:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:59:25 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-3jXhDp7dPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:59:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:59:22 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-lfIjhhsgDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #55 from Owen Leonard <oleonard at myacpl.org> ---
I've done a lot of testing now and have only run into small problems:

These pages have a sidebar filter which includes a library selector but no
libraries are listed:

-  acqui/invoices.pl
-  admin/aqbudgets.pl
-  opac/opac-topissues.pl
-  serials/serials-search.pl

These pages don't show the patron's library in the sidebar:

-  members/discharge.pl
-  members/member-flags.pl
-  members/member-password.pl

Other issues:

- In both the staff client and OPAC, library names don't appear in the facets.
Instead there is a list of asterisks.

-  admin/clone-rules.pl -- When you submit a library to clone rules to, the
next step asks you to select a library. Your original selection seems to be
getting lost.

- circ/returns.pl -- When a hold is found, the line at the bottom of the
dialog, "Hold at [library]" shows the library code instead of name.

- members/paycollect.pl -- Doesn't show patron category description in the
sidebar (maybe that's from Bug 15407?)

- reports/guided_reports.pl -- When running an SQL report which uses the
<<branches>> placeholder, the libraries are shown in order by code rather than
name.

- tools/holidays.pl -- The library name doesn't appear in the page heading.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 16:59:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 14:59:41 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-UxfNRnBxVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:03:18 +0000
Subject: [Koha-bugs] [Bug 17050] New: Accessing the REST API through Plack
 kicks the session out
Message-ID: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

            Bug ID: 17050
           Summary: Accessing the REST API through Plack kicks the session
                    out
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

While working on bug 17030 for integrating the REST API on the packages ot make
it finally available, I found that the session is lost when Plack is used to
access it.

To reproduce:
- Follow the steps for the Plack patch in bug 17030
=> FAIL: Notice no matter what permissions your user has you get:
{ "error": "You don't have the required permission" }
- On a separate tab, notice you've been kicked out from Koha.

This doesn't happen with Plack disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:03:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:03:53 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-y7Ooeb287e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |julian.maurice at biblibre.com
                   |                            |, kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:03:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:03:59 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-5F6myc8QVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030
[Bug 17030] Configure the REST api on packages install
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:03:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:03:59 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-VQMWmLvpQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17050


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050
[Bug 17050] Accessing the REST API through Plack kicks the session out
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:08:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:08:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-JZ2LJi4pWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #7 from alonso morgane <morgane.alonso at biblibre.com> ---
(In reply to Jonathan Druart from comment #3)
> Quick code review:
> 
> 1/ The default value for the new pref should be "off"
> 
> 2/ Tabulation chars should be replaced with 4 tabs
> 
> 3/ $tmp is rarely a correct variable name :)
> 
> 4/ Additional fields are displayed (but not taken into account) on the mana
> subscriptions search form
> 
> 5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead
> 
> 6/ Share> "Language of your sharing" is hidden on the right.
> 
> 7/ "The export is done, thank you for your contribution." => It should not
> be yellow (alert) but green (message)

1/ Paul says that it's better to have "on" in default value to promote the use
of Mana (he'll discuss about it later)

2/3/7/ I'll clean my code

4/ the flied "deprecated" is not used yet because I didn't have the time to
code the comment feature where librarians can say if a model is deprecated. I
can remove the flied if you prefer.

5/ I'll do that

6/ Fixed

Thanks for all your comments! I will do my best to apply them all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:15:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:15:25 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-vnKMkIheJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:15:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:15:28 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-HMeTSWlCoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53960|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53993&action=edit
[SIGNED-OFF] Bug 16894: Regression - Display email on patron search results

Bug 10318 added the email to the patron search results but it has been
removed later.
This patch reintroduced it where it was (no new column).

Test plan:
Search for patrons and confirm that the emails are displayed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:16:15 +0000
Subject: [Koha-bugs] [Bug 9594] order item subfields in framework
In-Reply-To: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9594-70-uW760NAhOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:31:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:31:20 +0000
Subject: [Koha-bugs] [Bug 17051] New: Default order biblio subfields in
	framework
Message-ID: <bug-17051-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17051

            Bug ID: 17051
           Summary: Default order biblio subfields in framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

It would be nice if subfields in framework editor could have subfields put in
any order.

With RDA, subfield "i" is often in first position.

It would be nice having a way to set by default an order of subfield for a
framework.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:41:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:41:37 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-3QE1R1wfJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:41:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:41:40 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-tS6DDPZEZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53905|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53994&action=edit
[SIGNED-OFF] Bug 17020: Do no pass findborrower to the template

Indeed, it's not used!

Test plan:
  git grep '\[% findborrower'
should not return any result.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 17:52:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 15:52:23 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-Zi9oRXav5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 53995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53995&action=edit
Bug 17030: (followup) Rewrite rule for Plack

This patch fixes the TODO from the previous one. It implements the rewrite
on the Plack-related files so pretty uRLs can be used.

To test:
- Follow the previous patches test steps (you should have a tweaked plack-psgi
file
  and Plack enabled)
- Grab
  debian/templates/apache-shared-opac-plack.conf
  debian/templates/apache-shared-intranet-plack.conf
and put them in /etc/koha
- Run:
  $ sudo service apache2 restart
- Point your browser to:
  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get the JSON output from the REST api
- Point your browser to the pretty URL:
  http://localhost:8080/api/v1/patrons/50
=> SUCCESS: You get the JSON output from the REST api
- Repeat for port 8081 (intranet)
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:01:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:01:57 +0000
Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to
	Koha::Patron->has_overdues
In-Reply-To: <bug-16851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16851-70-KCtYnQ6bLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53511|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 53996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53996&action=edit
[SIGNED-OFF] Bug 16851: Move HasOverdues to Koha::Patron->has_overdues

This patch just move C4::Members::HasOverdues to
Koha::Patron->has_overdues and updated callers

Test plan:
No change in behavior is expected.
1/ If a patron is debarred and does not have overdues and
AutoRemoveOverduesRestrictions is on, the debarment will be removed on
checkin
2/ Add overdues and make sure the patron cannot renew

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:01:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:01:55 +0000
Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to
	Koha::Patron->has_overdues
In-Reply-To: <bug-16851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16851-70-kedlFcZP7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:02:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:02:51 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-URamUJhsty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:14:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:14:50 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-j0vR3DxIwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53893|0                           |1
        is obsolete|                            |

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53997&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:14:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:14:56 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-iKqpDNghQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53894|0                           |1
        is obsolete|                            |

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53998&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:00 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-XLIBO4CBP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53895|0                           |1
        is obsolete|                            |

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53999&action=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:07 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-wodgHZhC0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53896|0                           |1
        is obsolete|                            |

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54000&action=edit
Bug 15758: Koha::Libraries - Remove GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:11 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-oTpNIBeTsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53897|0                           |1
        is obsolete|                            |

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54001&action=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:19 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-SsfiQi7EiF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53899|0                           |1
        is obsolete|                            |

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54003&action=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:15 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-RAvU2ZIKBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53898|0                           |1
        is obsolete|                            |

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54002&action=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:15:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:15:23 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-LwI1WFBrWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53900|0                           |1
        is obsolete|                            |

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54004&action=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:17:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:17:22 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-jp9OtprzeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #55)

Excellent testing session Owen :)

> I've done a lot of testing now and have only run into small problems:
> 
> These pages have a sidebar filter which includes a library selector but no
> libraries are listed:
> 
> -  acqui/invoices.pl
> -  admin/aqbudgets.pl
> -  opac/opac-topissues.pl
> -  serials/serials-search.pl
> 
> These pages don't show the patron's library in the sidebar:
> 
> -  members/discharge.pl
> -  members/member-flags.pl
> -  members/member-password.pl

Everything fixed.
members/discharge.pl was actually moremember.pl

> Other issues:
> 
> - In both the staff client and OPAC, library names don't appear in the
> facets. Instead there is a list of asterisks.

Erk, I missed something in one rebase. Fixed now.

> -  admin/clone-rules.pl -- When you submit a library to clone rules to, the
> next step asks you to select a library. Your original selection seems to be
> getting lost.
> 
> - circ/returns.pl -- When a hold is found, the line at the bottom of the
> dialog, "Hold at [library]" shows the library code instead of name.

Fixed!

> - members/paycollect.pl -- Doesn't show patron category description in the
> sidebar (maybe that's from Bug 15407?)

In master, will fix it separately.

> - reports/guided_reports.pl -- When running an SQL report which uses the
> <<branches>> placeholder, the libraries are shown in order by code rather
> than name.
> 
> - tools/holidays.pl -- The library name doesn't appear in the page heading.

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:18:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:18:06 +0000
Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron
In-Reply-To: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16850-70-WzWw83xiZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53512|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54005&action=edit
[SIGNED-OFF] Bug 16850: Add test coverage for CanBookBeIssued

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:18:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:18:14 +0000
Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron
In-Reply-To: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16850-70-zvahELPLsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53513|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54006&action=edit
[SIGNED-OFF] Bug 16850: Remove C4::Members::IsMemberBlocked

This subroutine is only called once and can be replaced with a call to
is_debarred and has_overdues.
Note that prior to this patch, IsMemberBlocked copy/paste code from
HasOverdues, which did not make sense.

Test plan:
Debar a patron and make sure he is not able to checkout (the librarian
is asked to overwrite if OverduesBlockCirc is set to 'confirmation')
Remove the debarment and add overdues to this patron, same as
previously, the checkout should be blocked

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:18:29 +0000
Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron
In-Reply-To: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16850-70-CMSkrGMWjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:19:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:19:34 +0000
Subject: [Koha-bugs] [Bug 17052] New: Patron category description not
 displayed in the sidebar of paycollect
Message-ID: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

            Bug ID: 17052
           Summary: Patron category description not displayed in the
                    sidebar of paycollect
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:22:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:22:31 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-7BrKgQ3FVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:22:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:22:33 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-9BAhBBgxmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54007&action=edit
Bug 17052: Display patron category description in the sidebar of paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:23:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:23:18 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-YWbm7AgJ0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #64)
> > - members/paycollect.pl -- Doesn't show patron category description in the
> > sidebar (maybe that's from Bug 15407?)
> 
> In master, will fix it separately.

See bug 17052.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 18:24:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 16:24:29 +0000
Subject: [Koha-bugs] [Bug 16334] Cannot sort checkout search by name
In-Reply-To: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16334-70-9BbxmEsz5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:30:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:30:07 +0000
Subject: [Koha-bugs] [Bug 17051] Default order biblio subfields in framework
In-Reply-To: <bug-17051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17051-70-7QK1QQCops@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17051

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:30:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:30:24 +0000
Subject: [Koha-bugs] [Bug 9594] order item subfields in framework
In-Reply-To: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9594-70-1QIpwKfliT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:40:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:40:13 +0000
Subject: [Koha-bugs] [Bug 7374] can't upload icon for auth values
In-Reply-To: <bug-7374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7374-70-xbrVM6uRN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:47:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:47:31 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-4RSSxBEsT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53992|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54008&action=edit
Bug 17030: Make REST api available on packages with plack enabled

This patch is the starting point for making the REST api available
on Plack.

What it does:
- It creates the /api/v1/app.pl mount point in plack.psgi
- It enables the ProxyPass and ProxyPassReverse directives so it
  is reached through Plack.
- It sets rewrite rules so we can use the 'pretty' urls (i.e.
  /api/v1/patrons instead of /api/v1/app.pl/api/v1/patrons).

To test:
- Grab the following files, and put them in /etc/koha (overwrite the existing
ones)
  debian/templates/apache-shared-intranet-plack.conf
  debian/templates/apache-shared-opac-plack.conf
- Tweak your /etc/koha/sites/kohadev/plack.psgi file so the API-related stuff
  is present on your file.
- Make sure Plack is enabled for the instance:
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --restart kohadev
  $ sudo service apache2 restart
- Follow the previous patch test plan, but use this URLs (no pretty URL):

  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
  http://localhost:8081/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Not use this URLs:
  http://localhost:8080/api/v1/patrons/50
  http://localhost:8081/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Sign off :-D

[1] this patch made a bug visible (the session is lost when accessing the API
through
Plack) but it shouldn't prevent its inclusion because the API right now is not
even available
as default for developers to test or fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:48:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:48:11 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-3AD71UNoK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:48:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:48:14 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-7WNeoRbTDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53995|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 19:50:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 17:50:26 +0000
Subject: [Koha-bugs] [Bug 17053] New: Clearing search term in Reports
Message-ID: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

            Bug ID: 17053
           Summary: Clearing search term in Reports
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: jesse at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If you click the clear button to clear the search term it does take the search
term away. However, the next time you click on "Saved reports" the search term
is still there.

1. Do a search for "series"
2. Click the clear button ("Series" is removed from the search box and the list
of reports populates with all reports)
3. Do anything (or nothing)
4. Click on "saved reports"
5. "Series" is in the search box and the list of reports are limited to reports
about series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 20:10:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 18:10:38 +0000
Subject: [Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences
	per library
In-Reply-To: <bug-11251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11251-70-GOQNeHbrdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 20:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 18:26:59 +0000
Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
In-Reply-To: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1993-70-88In7T6WkB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 20:29:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 18:29:35 +0000
Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576
 bytes) are not searchable.
In-Reply-To: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15399-70-1TIDdVdW2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 20:51:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 18:51:02 +0000
Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several
 serials templates
In-Reply-To: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16946-70-eLf0avKW9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 20:51:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 18:51:04 +0000
Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several
 serials templates
In-Reply-To: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16946-70-Hm8BkRaiNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53541|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54009&action=edit
[SIGNED-OFF] Bug 16946 [Revised] Remove the use of "onclick" from several
serials templates

This patch modifies several serials module templates to remove the use
of event attributes. Events will now be defined in JavaScript.

Also changed:

- In Serials -> Check expiration, custom form validation has been
  removed in favor of validation with the plugin.
- In Serials -> Claims, the "Clear filter" button has been replaced with
  a link. Error messages are now styled with the standard "alert" class.
- In Serials -> New subscription -> Search for record, the "choose" link
  is now a Bootstrap button. Pagination links are now styled like other
  similar links. The "Close" button is now styled as in other popup
  windows. The "no results found" messages is styled as an informational
  dialog.
- In Serials -> Subscription -> Edit routing list, the "add recipients"
  and "delete all" controls are now links with Font Awesome icons.

To test, apply the patch and:

- Go to Serials -> Check expiration.
  - Try to submit the form without filling in a date. The form
    validation plugin should warn you that the date field is required.
  - Submit the form using data which will return results.
  - Click the "Renew" button for any result. The subscription renewal
    popup should be triggered for the correct title.

- Go to Serials -> Claims.
  - Select a vendor with missing issues.
  - Confirm that the date filter works correctly, and that the "Clear
    filter" link works.
  - Select one or more result and click the "Send notification" button.
    The notification should be sent.

- Go to Serials -> New subscription.
  - Click the "Search for record" link to trigger the bibliographic
    search popup.
  - Perform a search. Confirm that the "Choose" button selects the
    correct record and populates the fields in the parent window.

- Go to Serials -> Subscription -> Edit routing list.
  - Confirm that the process of adding recipients to the list works
    correctly.
  - Confirm that changing the rank of any recipient works correctly.
  - Save the routing list and click the "Save and preview routing slip"
    button on the confirmation page. The slip preview should open.
  - In the slip preview window, test that the print button works
    correctly.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

QA revision: Removed stray '// -->' and corrected clear filter function

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:05:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:05:40 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-X24m41zUIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #107 from Bouzid <bouzid.fergani at inlibro.com> ---
Created attachment 54010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54010&action=edit
Bug6934: rename active transaction with  All payments to the library and
grouping in it the relevant account types 'Pay' 'C'

    rename Patron carnumber on Patron card number
    fix src databales.js

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:06:30 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-ElkRtIcbzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Bouzid <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:17:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:17:43 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-XTyvZVjzgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Just a sidenote: We experienced the same issue in our plack+REST setup, and
found out it was due to a syspref: SessionRestrictionByIP

When we disabled this (enabled by default) the problem went away.
Don't know if it is related, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:19:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:19:55 +0000
Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History
In-Reply-To: <bug-13685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13685-70-vmFQRzBUBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

Peggy Thrasher <p.thrasher at dover.nh.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.thrasher at dover.nh.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:20:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:20:06 +0000
Subject: [Koha-bugs] [Bug 6533] Enhancement: Printer Friendly Lists
In-Reply-To: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6533-70-P1cT8wZiGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6533

Peggy Thrasher <p.thrasher at dover.nh.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.thrasher at dover.nh.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:20:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:20:58 +0000
Subject: [Koha-bugs] [Bug 16988] Suspending a hold with
 AutoResumeSuspendedHolds disabled results in error
In-Reply-To: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16988-70-9BEswmwbuM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:42:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:42:21 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-gQfVbwds42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #7 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:43:12 +0000
Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack
In-Reply-To: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16818-70-Y2uiqtIuMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 21:43:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 19:43:40 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-CusHjCLxUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:01:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:01:55 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-bsAKdjzZXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Wording is good for me...  Pushed to master.  Should be in the November 2016
release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:04:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:04:51 +0000
Subject: [Koha-bugs] [Bug 16868] Silence error
	t/db_dependent/Linker_FirstMatch.t
In-Reply-To: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16868-70-r6gS9kLh8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #17 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to master.  Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:06:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:06:49 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-yqQqRHWw7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to master.  Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:25:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:25:21 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-0r44JBwvAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:25:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:25:24 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-0pJi1Sg28K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53959|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54011&action=edit
Bug 16996: Do not explode if mandatory fields are missing

At the OPAC, if a patron modify his/her information and at least 1
mandatory field is missing, Koha will crash with
  Template process failed: undef error - Can't call method "description"

It is raised by Koha::Template::Plugin::Categories::GetName called with
an undefined categorycode.
The problem is that the values sent originaly are not sent back to the
template if the user missed something.
This patch makes that all info are resent to the template in order to
show the same form to the user.

Test plan:
0. Apply patch

1. Make sure that the categorycode is not hidden in the OPAC in:
     PatronSelfRegistrationBorrowerUnwantedField or
PatronSelfModificationBorrowerUnwantedField

2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for
example email.

3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave
blank the required field of point 2

4. Press "Submit update request"

There should be no software error.

NOTE: The warns will be floody on the logs.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 22:59:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 20:59:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common
 information between Kohas
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-PPGPdCkAnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
For features like this that have you communicate with an external server should
definitely turned off by default in my opinion. You can promote in other ways.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:03:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:03:15 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-iVCquqfZ7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Treating the last as qa follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:04:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:04:13 +0000
Subject: [Koha-bugs] [Bug 9594] order item subfields in framework
In-Reply-To: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9594-70-ayC1e23DrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 - I also had libraries asking for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:27:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:27:32 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-DfKXMkKr73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53991|0                           |1
        is obsolete|                            |

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54012&action=edit
Bug 17030: Enable REST api on packages

This patch enables access to the REST API endpoint on packages setup.
It does so, by patching the shared apache-shared-intranet.conf and
apache-shared-opac.conf.

You can build your own master packages with this patch applied, or just:

- Grab
  debian/templates/apache-shared-intranet.conf
  debian/templates/apache-shared-opac.conf
and overwrite their counterparts in /etc/koha on a packages setup. For example
in kohadevbox.
- Have Koha loaded with all default data
- Create a superlibrarian user for you
- Login to the intranet and the OPAC
- Point your browser to:
  http://localhost:8080/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
  http://localhost:8081/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
- Sign off :-D

Note: I use the HTTPRequester addon for Firefox, re-using the CGISESSID value
from the
browser session cookie, in the headers.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:27:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:27:36 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-hiANDhQAyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54008|0                           |1
        is obsolete|                            |

--- Comment #6 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54013&action=edit
Bug 17030: Make REST api available on packages with plack enabled

This patch is the starting point for making the REST api available
on Plack.

What it does:
- It creates the /api/v1/app.pl mount point in plack.psgi
- It enables the ProxyPass and ProxyPassReverse directives so it
  is reached through Plack.
- It sets rewrite rules so we can use the 'pretty' urls (i.e.
  /api/v1/patrons instead of /api/v1/app.pl/api/v1/patrons).

To test:
- Grab the following files, and put them in /etc/koha (overwrite the existing
ones)
  debian/templates/apache-shared-intranet-plack.conf
  debian/templates/apache-shared-opac-plack.conf
- Tweak your /etc/koha/sites/kohadev/plack.psgi file so the API-related stuff
  is present on your file.
- Make sure Plack is enabled for the instance:
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --restart kohadev
  $ sudo service apache2 restart
- Follow the previous patch test plan, but use this URLs (no pretty URL):

  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
  http://localhost:8081/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Not use this URLs:
  http://localhost:8080/api/v1/patrons/50
  http://localhost:8081/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Sign off :-D

[1] this patch made a bug visible (the session is lost when accessing the API
through
Plack) but it shouldn't prevent its inclusion because the API right now is not
even available
as default for developers to test or fix it.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:28:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:28:43 +0000
Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in
	circulation.tt
In-Reply-To: <bug-16861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16861-70-QGEbvJhX2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #11 from Brendan Gallagher <brendan at bywatersolutions.com> ---
pushed to master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:29:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:29:40 +0000
Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning
In-Reply-To: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16727-70-A60NdldW4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
  Attachment #53750|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:31:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:31:36 +0000
Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning
In-Reply-To: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16727-70-MYHOxfbrd5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
pushed to master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:40:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:40:58 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-lAIANKvqmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Lovely work Tomas!

Just as we have implemented at OPL, but with a much better apache rewrite...

As for the session timeout, I tested by disabled the syspref
SessionRestrictionByIP and never suffered the session timeout issue again.

Relevant log error with :
Use of uninitialized value in string ne at /usr/share/koha/lib/C4/Auth.pm line
1674.

which points to the test:
C4::Context->preference('SessionRestrictionByIP') && $ip ne $ENV{'REMOTE_ADDR'}
)

my guess is that session worker translates localhost to 127.0.0.1 and then this
test will give false and delete session.

Anyway, this should be a separate bug and not prevent this important one to hit
master as soon as possible!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug  4 23:51:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 21:51:40 +0000
Subject: [Koha-bugs] [Bug 17054] New: indexer daemon breaks koha-remove
Message-ID: <bug-17054-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17054

            Bug ID: 17054
           Summary: indexer daemon breaks koha-remove
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

koha-remove is broken because the indexer daemon does not get disabled and the
koha debian user can't be deleted on remove.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 00:21:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 22:21:20 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-JaNo46fN26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53966|0                           |1
        is obsolete|                            |

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54014&action=edit
Bug 17043 - Readonly deps

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 00:51:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 04 Aug 2016 22:51:47 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-ya53D1uFOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54014|0                           |1
        is obsolete|                            |

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54015&action=edit
Bug 17043 - Readonly deps

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 04:54:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 02:54:50 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-HCzEtDUKkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |liz at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:05:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:05:33 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-LeU0ueS53i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #20 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:05:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:05:54 +0000
Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected
In-Reply-To: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15397-70-sSvWkyXe7w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:06:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:06:10 +0000
Subject: [Koha-bugs] [Bug 16310] Remove the use of "onclick" from audio
	alerts template
In-Reply-To: <bug-16310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16310-70-zUagSybyTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16310

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:06:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:06:29 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-AEed2gnjVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #14 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:16:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:16:20 +0000
Subject: [Koha-bugs] [Bug 16988] Suspending a hold with
 AutoResumeSuspendedHolds disabled results in error
In-Reply-To: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16988-70-QvMiXYR9SB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:24:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:24:46 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-xaI8n1DBQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Does it apply to 16.05 branch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:42:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:42:35 +0000
Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two
	new prefs
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-8Fkf6BJ0WQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:45:14 +0000
Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack
In-Reply-To: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16818-70-PWagjUqGRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:47:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:47:19 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-wXhEi01otk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:50:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:50:05 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-xRrOIGdohu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Mirko: Could you add libhtml-entities-perl to debian/control, in another patch
or in this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:51:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:51:49 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-JUEOAbx2Q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:54:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:54:00 +0000
Subject: [Koha-bugs] [Bug 16868] Silence error
	t/db_dependent/Linker_FirstMatch.t
In-Reply-To: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16868-70-O0n9MGBDKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #18 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:54:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:54:56 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-0XqkXI5jkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 08:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 06:56:54 +0000
Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning
In-Reply-To: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16727-70-sLyNAunDA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:04:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:04:24 +0000
Subject: [Koha-bugs] [Bug 16476] CGI->param('foo') in list context allows
 XSS ( e.g. Javascript injection) in Koha
In-Reply-To: <bug-16476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16476-70-JG0rPHXBET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16476

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16969

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:09:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:09:00 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-a7TIVKm7r6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34544|0                           |1
        is obsolete|                            |
  Attachment #34545|0                           |1
        is obsolete|                            |
  Attachment #34546|0                           |1
        is obsolete|                            |
  Attachment #34547|0                           |1
        is obsolete|                            |
  Attachment #35830|0                           |1
        is obsolete|                            |

--- Comment #31 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54016&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

This patch adds a configuration option which allows to define which
fields should be mandatory for a patron purchase suggestion form in OPAC.

Test plan:

1/ Apply patch.
2/ Play with the new OPACSuggestionMandatoryFields system preference
(select some fields as manadatory, select all, deselect all, try to
submit some suggestions with mandatory fields filled and/or not
filled etc.) to ensure that required fields (and only required fields)
are enforced in the browser to be filled.
3/ With all options deselected, 'Title' field should still be
mandatory (by default).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:10:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:10:30 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-j5A5LKzP2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:10:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:10:34 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-rqaZO1kwpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54016|0                           |1
        is obsolete|                            |

--- Comment #32 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54017&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

Add 'OPACSuggestionMandatoryFields' syspref definition plus
an atomic DB update for the new preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:11:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:11:28 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-sJyXePWqXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54017|0                           |1
        is obsolete|                            |

--- Comment #33 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54018&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

This patch adds a configuration option which allows to define which
fields should be mandatory for a patron purchase suggestion form in OPAC.

Test plan:

1/ Apply patch.
2/ Play with the new OPACSuggestionMandatoryFields system preference
(select some fields as manadatory, select all, deselect all, try to
submit some suggestions with mandatory fields filled and/or not
filled etc.) to ensure that required fields (and only required fields)
are enforced in the browser to be filled.
3/ With all options deselected, 'Title' field should still be
mandatory (by default).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:11:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:11:44 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-hrU2g11J1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #34 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54019&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

Add 'OPACSuggestionMandatoryFields' syspref definition plus
an atomic DB update for the new preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:13:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:13:36 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-JvyAILJOZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54018|0                           |1
        is obsolete|                            |
  Attachment #54019|0                           |1
        is obsolete|                            |

--- Comment #35 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54020&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

This patch adds a configuration option which allows to define which
fields should be mandatory for a patron purchase suggestion form in OPAC.

Test plan:

1/ Apply patch.
2/ Play with the new OPACSuggestionMandatoryFields system preference
(select some fields as manadatory, select all, deselect all, try to
submit some suggestions with mandatory fields filled and/or not
filled etc.) to ensure that required fields (and only required fields)
are enforced in the browser to be filled.
3/ With all options deselected, 'Title' field should still be
mandatory (by default).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:13:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:13:47 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-kyFhzGNrMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #36 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54021&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC - part 2

Add 'OPACSuggestionMandatoryFields' syspref definition plus
an atomic DB update for the new preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 11:27:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 09:27:58 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-87LKw6iGHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #37 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
In this revised version I dropped the old form validation handler entirely, in
favour of the "required" attributes as a sole method of enforcement. Not sure
if the special treatment for old / legacy / non-compliant browsers is still
needed? 

If deemed necessary, I may try to re-add such an event handler which will be
more on par with the current coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:18:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:18:46 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-Vt1xddtwsR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Fr?d?ric Demians from comment #8)
> Does it apply to 16.05 branch?

Yes, as long as bug 16506 has been pushed already.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:24:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:24:56 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-0xmJq04YU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:24:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:24:59 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-aALSR0kbHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53980|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54022&action=edit
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

If a definition in api/v1/definitions/*.json has a corresponding Koha-object by
filename, compare properties of the definition and columns of the Koha-object
and ensure that all columns are defined inside properties of the definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. See that all of the tests pass. (If not, file a bug report to fix missing
   properties in the Swagger definition.)
3. Remove a property from api/v1/swagger/definitions/patron.json
4. Repeat step 1
5. See that test fails and lets you know that the property you just removed
   is missing from the definition.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:25:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:25:03 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-5lYR7Ri8eD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54023&action=edit
Bug 17032: Remove warning "keys on reference is experimental"

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:25:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:25:25 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-yyWk4TZVsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:25:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:25:28 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-IqA8S4X63q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53981|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54024&action=edit
Bug 17041: Fix missing properties in patron.json

Swagger definition for patron was missing two properties.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:25:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:25:46 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-yh4Q9l4uG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:25:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:25:49 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-CxxTfjve1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53982|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54025&action=edit
Bug 17042: Fix missing column in hold.json

Swagger definition for hold was missing a property.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:20 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-BomwL9JhnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Lari!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:32 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-5uzx0LsBeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:43 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-IDMzGrC5K2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:48 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-kvYaciTpFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:54 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-qR1iK3iG2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:26:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:26:58 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-zMtRiuua2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:32:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:32:22 +0000
Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several
 serials templates
In-Reply-To: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16946-70-1iiy4DuQa9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:32:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:32:25 +0000
Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several
 serials templates
In-Reply-To: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16946-70-VBbqxuVb7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54009|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54026&action=edit
Bug 16946 [Revised] Remove the use of "onclick" from several serials templates

This patch modifies several serials module templates to remove the use
of event attributes. Events will now be defined in JavaScript.

Also changed:

- In Serials -> Check expiration, custom form validation has been
  removed in favor of validation with the plugin.
- In Serials -> Claims, the "Clear filter" button has been replaced with
  a link. Error messages are now styled with the standard "alert" class.
- In Serials -> New subscription -> Search for record, the "choose" link
  is now a Bootstrap button. Pagination links are now styled like other
  similar links. The "Close" button is now styled as in other popup
  windows. The "no results found" messages is styled as an informational
  dialog.
- In Serials -> Subscription -> Edit routing list, the "add recipients"
  and "delete all" controls are now links with Font Awesome icons.

To test, apply the patch and:

- Go to Serials -> Check expiration.
  - Try to submit the form without filling in a date. The form
    validation plugin should warn you that the date field is required.
  - Submit the form using data which will return results.
  - Click the "Renew" button for any result. The subscription renewal
    popup should be triggered for the correct title.

- Go to Serials -> Claims.
  - Select a vendor with missing issues.
  - Confirm that the date filter works correctly, and that the "Clear
    filter" link works.
  - Select one or more result and click the "Send notification" button.
    The notification should be sent.

- Go to Serials -> New subscription.
  - Click the "Search for record" link to trigger the bibliographic
    search popup.
  - Perform a search. Confirm that the "Choose" button selects the
    correct record and populates the fields in the parent window.

- Go to Serials -> Subscription -> Edit routing list.
  - Confirm that the process of adding recipients to the list works
    correctly.
  - Confirm that changing the rank of any recipient works correctly.
  - Save the routing list and click the "Save and preview routing slip"
    button on the confirmation page. The slip preview should open.
  - In the slip preview window, test that the print button works
    correctly.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

QA revision: Removed stray '// -->' and corrected clear filter function

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:50:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:50:46 +0000
Subject: [Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x
	option switch
In-Reply-To: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16830-70-jGDRrJmXvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:53:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:53:08 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-QS4yNaGwUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:53:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:53:11 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-Yhbu2ffBRc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54027&action=edit
Bug 16960: Update 1 missing occurrence of GetModifications

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:56:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:56:11 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-reccJ3YkrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
            Summary|REST API: add route to      |REST API: add route to
                   |authenticate patron         |authenticate patron (Single
                   |                            |Sign On - SSO)

--- Comment #2 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Lari Taskula from comment #1)
> We have implemented userid/cardnumer & password CGISESSID-authentication. I
> will rebase it on master and upload the patch here.

That's nice! So don't you mind me to put your solution here on bugzilla rebased
on master with current REST API conventions?

I've found your implementation here:
https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/api/v1/swagger/paths/auth.json
(the POST method)

I think it would go quiet quick if I omit your dependencies of the
PageObject-tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 12:58:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 10:58:23 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-YAg8yCK1Rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #3 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54028&action=edit
Bug 17004: Add API route to authenticate patron (CGISESSID)

This patch adds a username/cardnumber and password authentication that returns
a session.

POST /auth/session (login)

Required form data:
- "password"
- either "userid" or "cardnumber".

To test:
1. Make sure you are logged out from Koha.
2. Make a POST request to http://yourlibrary/api/v1/auth/session with form data
   "userid" => <your_user_id> and "password" => <your_password>.
3. If your userid and password is correct, you should be returned with most
   basic patron data and your CGISESSID.
4. Also attempt with invalid login to get an error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 13:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 11:03:55 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-mHikIT5pzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #4 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Jiri Kozlovsky from comment #2)
> (In reply to Lari Taskula from comment #1)
> > We have implemented userid/cardnumer & password CGISESSID-authentication. I
> > will rebase it on master and upload the patch here.
> 
> That's nice! So don't you mind me to put your solution here on bugzilla
> rebased on master with current REST API conventions?
> 
> I've found your implementation here:
> https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/api/v1/swagger/
> paths/auth.json (the POST method)
> 
> I think it would go quiet quick if I omit your dependencies of the
> PageObject-tests.
Since our authentication is based on Authentication rewrite (Bug 13920 and its
dependencies), it's a bit too much work for me to rebase here now, so instead I
decided to write a simple patch from scratch using session, that you can use
for testing if you wish. You can mark that patch obsolete if you wish to work
on this Bug more!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:35 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-3rLSUlM0T2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53997|0                           |1
        is obsolete|                            |

--- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54029&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:40 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-O9MQsEUbYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53998|0                           |1
        is obsolete|                            |

--- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54030&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:44 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ZruM1dDI5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53999|0                           |1
        is obsolete|                            |

--- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54031&action=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:49 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-LtgBnnGns1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54000|0                           |1
        is obsolete|                            |

--- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54032&action=edit
Bug 15758: Koha::Libraries - Remove GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:57 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-IWck6gMUPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54002|0                           |1
        is obsolete|                            |

--- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54034&action=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:00:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:00:53 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-I65MhEsLWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54001|0                           |1
        is obsolete|                            |

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54033&action=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:01:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:01:05 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-Dwk0XnlTO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54004|0                           |1
        is obsolete|                            |

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54036&action=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:01:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:01:01 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-XFHs89bkBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54003|0                           |1
        is obsolete|                            |

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54035&action=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:26:59 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-vMZ9OjYKvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Benjamin Rokseth from comment #1)
> Just a sidenote: We experienced the same issue in our plack+REST setup, and
> found out it was due to a syspref: SessionRestrictionByIP
> 
> When we disabled this (enabled by default) the problem went away.
> Don't know if it is related, though.

Confirmed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:06 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-DnOJDHBGoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54030|0                           |1
        is obsolete|                            |

--- Comment #75 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54038&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranchesLoop

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:43:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:43:58 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-N0trmaZT4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54029|0                           |1
        is obsolete|                            |

--- Comment #74 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54037&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:13 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-RkuPbXcS4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54031|0                           |1
        is obsolete|                            |

--- Comment #76 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54039&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Move mybranch to C4::Context

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:22 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-1Fug1GuZuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54032|0                           |1
        is obsolete|                            |

--- Comment #77 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54040&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranches

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:29 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-MY3PZzsKzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54033|0                           |1
        is obsolete|                            |

--- Comment #78 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54041&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Move onlymine to
C4::Context::only_my_library

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:37 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-PHmHnSleIU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54034|0                           |1
        is obsolete|                            |

--- Comment #79 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54042&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:43 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-IP4pwF9t20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54035|0                           |1
        is obsolete|                            |

--- Comment #80 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54043&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:44:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:44:50 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-RRdGMW5yak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54036|0                           |1
        is obsolete|                            |

--- Comment #81 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54044&action=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Do not select an option if selected
is defined

This will certainly need a few more tweaks.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:45:12 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ansowqvhe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:54:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:54:08 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-rsvyeuKdpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 14:54:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 12:54:10 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-iy5kb1v1pS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54007|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54045&action=edit
[SIGNED-OFF] Bug 17052: Display patron category description in the sidebar of
paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:19:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:19:29 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-CepTYHuRS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #38 from Owen Leonard <oleonard at myacpl.org> ---
I find that it's not possible to make the "library" selection mandatory. Is
there a reason for that?

Note that there is a JS validation plugin available in the OPAC if you want to
use it. See opac-memberentry.tt for an example. The plugin can be set up to
validate a form based on the markup (requiring fields which are , so it's not
necessary to dynamically configure the fields in the JS if you don't want to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:34:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:34:37 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
	planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-fh3eLRrHRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
> After clicking on the auto-fill button the fields briefly populate, but then
> the page refreshes and they clear back to 0.00 again.

I get this too.

Could you please try to rework the patch so that it doesn't use an inline event
attribute? We shouldn't be adding new code which uses things attributes
"onclick."

The "edit_row" ID on the <tr> is problematic because it is repeated for each
row in the table, thus it isn't unique. If you're looking for a hook to target
each individual row you could so something like <tr id="edit_row_[%
budget_line.budget_id %]">

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:47:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:47:04 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-3hc7j0TRlX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Fr?d?ric Demians from comment #4)

> - Pick a date. => The date is copied to the input box, but (1) it is red, and
>   (2) the message 'This field is required' is still displayed.

This is a problem not with this patch but with the way the validation plugin
works together with the datepicker widget. Now that I know of the problem I can
find it elsewhere too, for instance aqcontract.pl.

I can try to find a solution, but I would like to do so as a separate bug if
that's okay with everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:55:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:55:18 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-VMd3vDLTzQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |barton at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:56:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:56:43 +0000
Subject: [Koha-bugs] [Bug 17055] New: Add classes to different note types to
 allow for styling on checkins page
Message-ID: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

            Bug ID: 17055
           Summary: Add classes to different note types to allow for
                    styling on checkins page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to distinguish
which type we are seeing. It would be good to add classes for each of these
note types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:57:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:57:07 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-NnI1uujmp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:58:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:58:53 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-uIdVY2spEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 15:58:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 13:58:55 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-uTh7S8WYBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54046&action=edit
Bug 17055 - Add classes to different note types to allow for styling on
checkins page

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to
distinguish which type we are seeing. It would be good to add classes
for each of these note types.

Test Plan:
1) Check out an item to a patron
2) Add a patron note, a public item note, and a non-public item note
   to the patron and item you used
3) Check in the item and instead the html, note the each note span
   now has a class to distinguish which type of note is being displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:10:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:10:57 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-Jzh8eCLP69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:10:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:10:59 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-2i5gTtC4PN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54046|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54047&action=edit
[SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for
styling on checkins page

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to
distinguish which type we are seeing. It would be good to add classes
for each of these note types.

Test Plan:
1) Check out an item to a patron
2) Add a patron note, a public item note, and a non-public item note
   to the patron and item you used
3) Check in the item and instead the html, note the each note span
   now has a class to distinguish which type of note is being displayed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>



Current patch-complexity: Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:29:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:29:01 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-tni4edwQ1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:29:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:29:04 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-73SnIKgCDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53974|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54048&action=edit
Bug 17044: Fix wrong destination for 'api' directory

The original Makefile.PL tweak missed to trim the directory name thus
repeating the 'api' directory like in 'api/api'.

To test:
- Make a standard install (for example in /usr/share/koha
=> FAIL: check /usr/share/koha/api/api exists
- Make a single install (for example in /home/tcohen/koha-single)
=> FAIL: check /home/tcohen/koha-single/api/api exists
- Apply the patch
- Make a standard install (for example in /usr/share/koha
=> SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api'
dir
- Make a single install (for example in /home/tcohen/koha-single)
=> SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a
nested 'api' dir
- Sign off :-D

Note: this affects the packages too, as the standard install is used as a
basis.
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:29:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:29:43 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-L9FWodUGgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:29:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:29:46 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-wPb8oTBv5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54012|0                           |1
        is obsolete|                            |
  Attachment #54013|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54049&action=edit
Bug 17030: Enable REST api on packages

This patch enables access to the REST API endpoint on packages setup.
It does so, by patching the shared apache-shared-intranet.conf and
apache-shared-opac.conf.

You can build your own master packages with this patch applied, or just:

- Grab
  debian/templates/apache-shared-intranet.conf
  debian/templates/apache-shared-opac.conf
and overwrite their counterparts in /etc/koha on a packages setup. For example
in kohadevbox.
- Have Koha loaded with all default data
- Create a superlibrarian user for you
- Login to the intranet and the OPAC
- Point your browser to:
  http://localhost:8080/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
  http://localhost:8081/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
- Sign off :-D

Note: I use the HTTPRequester addon for Firefox, re-using the CGISESSID value
from the
browser session cookie, in the headers.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:29:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:29:50 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-A0GeTi8ZKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54050&action=edit
Bug 17030: Make REST api available on packages with plack enabled

This patch is the starting point for making the REST api available
on Plack.

What it does:
- It creates the /api/v1/app.pl mount point in plack.psgi
- It enables the ProxyPass and ProxyPassReverse directives so it
  is reached through Plack.
- It sets rewrite rules so we can use the 'pretty' urls (i.e.
  /api/v1/patrons instead of /api/v1/app.pl/api/v1/patrons).

To test:
- Grab the following files, and put them in /etc/koha (overwrite the existing
ones)
  debian/templates/apache-shared-intranet-plack.conf
  debian/templates/apache-shared-opac-plack.conf
- Tweak your /etc/koha/sites/kohadev/plack.psgi file so the API-related stuff
  is present on your file.
- Make sure Plack is enabled for the instance:
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --restart kohadev
  $ sudo service apache2 restart
- Follow the previous patch test plan, but use this URLs (no pretty URL):

  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
  http://localhost:8081/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Not use this URLs:
  http://localhost:8080/api/v1/patrons/50
  http://localhost:8081/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Sign off :-D

[1] this patch made a bug visible (the session is lost when accessing the API
through
Plack) but it shouldn't prevent its inclusion because the API right now is not
even available
as default for developers to test or fix it.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:42:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:42:22 +0000
Subject: [Koha-bugs] [Bug 17056] New: Remove event attributes from various
	templates
Message-ID: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

            Bug ID: 17056
           Summary: Remove event attributes from various templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I'm working on a patch which will remove event attributes from the following
templates:

catalogue/MARCdetail.tt
catalogue/labeledMARCdetail.tt
offline_circ/process_koc.tt
reports/guided_reports_start.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:44:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:44:37 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-197gP3L0aY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #9 from Lari Taskula <larit at student.uef.fi> ---
Good work with the patch, Ji??!

I will sign-off, but first I would like to present some thoughts:
- Should we also allow user to access his own checkout history even if he does
not have circulate_remaining_permissions? I think this would need to consider
syspref 'opacreadinghistory'. Similar to Bug 13895.

- If GET /checkouts/history returns only issue_ids, should we come up with a
way to GET multiple issue_id's in one request? Say a client wants to display
all old checkouts for a patron on with detailed information for each checkout;
He makes a GET to /checkouts/history?borrowernumber=123. 1000 issue_ids are
returned. The question is, is it better to individually GET
/checkouts/history/1 ... /checkouts/history/1000 or do one request GET
/checkouts/history?issue_id=1+2+3+...+999+1000 ? Same like availability has in
Bug 16826.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:45:44 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-YDPN8SEMkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:45:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:45:46 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-7OsR5t8tVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54051&action=edit
Bug 17056 - Remove event attributes from various templates

This patch removes event attributes from several templates, moving event
definitions into the JavaScript instead.

To test, apply the patch and:

- View the MARC detail page for any bibliographic record. Changing the
  framework selection should reload the display using the selected
  framework.

- Perform the same test on the labeled MARC view. (Set the
  viewLabeledMARC system preference to "Allow" if necessary).

- To test the changes to Reports you should have at least one report
  group and at least one report subgroup.
  - Create a new saved SQL report.
  - Select a report group. Doing so should trigger the display of report
    subgroups. Deselecting the report group should hide the subgroups.

- In Acquisitions -> Suggestions, create a new suggestion.
  - In the 'Acquisition information' section, changing values for
    copies, currency, and price should change the value in the total
    field.

- In Circulation -> Upload offline circulation file:
  - My patch for Bug 16602 added the required code but forgot to remove
    the corresponding onclick attributes.
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
    - After uploading a file, both the 'Add to offline circulation
      queue' and 'Apply directly' buttons should work to trigger their
      corresponding processes (keeping Bug 16603 in mind).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:51:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:51:55 +0000
Subject: [Koha-bugs] [Bug 17057] New: Remove event attributes from holds
	template
Message-ID: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

            Bug ID: 17057
           Summary: Remove event attributes from holds template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org

reserve/request.tt contains several event attributes like "onclick" which
should be removed in favor of defining events in JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:59:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:59:19 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-UXUaC3c0Zb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53923|0                           |1
        is obsolete|                            |

--- Comment #14 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54052&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

Removed test for missing properties. It should be done in a separate context.
See Bug 17032.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:59:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:59:42 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-AMVDUmIEfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17032

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 16:59:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 14:59:42 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-5azXlEdOeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16825

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:05:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:05:36 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-eYpvyoPXrI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53827|0                           |1
        is obsolete|                            |

--- Comment #19 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54053&action=edit
Bug 16826: Add API route for getting item availability

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

Fixed small mistakes in documentation and removed itemnumberPathParam from
Swagger;
it belongs to Bug 16825.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:09:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:09:05 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-CWFDP83IyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:09:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:09:08 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-oFtgu9a9yZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54054&action=edit
Bug 17050: Do not kicks the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (and $ENV{HTTP_*} neither) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:11:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:11:21 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-hXkgwryAek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:11:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:11:46 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-liaHnE8QsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Amended test plan:
0/ Switch SessionRestrictionByIP on!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:18:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:18:34 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-7iW2lQXiX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 17:45:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 15:45:36 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-gaFcdSvm0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 18:09:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 16:09:00 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-Nzv3VDuxPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 18:09:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 16:09:02 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-8wgfFCbKv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54055&action=edit
Bug 17057 - Remove event attributes from holds template

This patch removes event attributes from the holds template. Events
are defined instead in the JavaScript.

Also changed: Move formatting of hold date to the template; Corrected a
non-functional 'cancel hold' link.

To test apply the patch and:

- Start the process of placing a hold on a single title for a
  patron.
  - Uncheck 'Place a hold on the next available item' and try to
    submit the form without selecting an item. You should be prompted
    to select an item.
- Place a hold on multiple titles at the same time. Confirm that your
  hold is saved correctly.
- View the holds for a title which has multiple holds.
  - Confirm that clicking the "X" image triggers a confirmation. Test
    canceling and confirming.
  - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for
    any hold and confirm that the corresponding 'Clear date' link works
    correctly.
  - Confirm that suspending a hold with and without an expiration date
    works correctly.
- Place an item-level hold.
  - View the holds for that same title.
  - Submit another patron to place a new hold.
  - In the list of items which can be placed on hold, look for the item
    you place on hold previously. There should be a "Cancel hold" link
    in the information column. Confirm that this link correctly triggers
    a confirmation dialog and deletes the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 18:10:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 16:10:58 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-ycdmKKFeG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 18:11:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 16:11:00 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-lTSJucGQ2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53903|0                           |1
        is obsolete|                            |

--- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54056&action=edit
Bug 17019 - debian/changelog update

This has not been updated for a while. I plan to add the stable
releases.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:05:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:05:26 +0000
Subject: [Koha-bugs] [Bug 17014] Remove more event attributes from patron
	templates
In-Reply-To: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17014-70-nkFjIsnv1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
It works as described. Reading the code, and for the sake of discussion:

You have this:

    $("#searchform").on("submit",function(){
        return filter();
    });

Why not directly:

    $("#searchform").on("submit",filter);

Or, since filter() isn't used anywhere else, why not moving its code directly
above:

    $("#searchform").on("submit",function(){
      // filter() code

And this old code:

    var type_fees = new Array();
    type_fees['L'] = '';
    type_fees['F'] = '';
    type_fees['A'] = '';
    type_fees['N'] = '';
    type_fees['M'] = '';

could be cleaned up:

    var type_fees = {'L':'','F':'','A':'','N':'','M':''};

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:07:16 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-1v2rpB3wud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:07:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:07:18 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-DqtcC5MzSG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52476|0                           |1
        is obsolete|                            |

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54057&action=edit
Bug 16754 - Use validation plugin in budgets, planning, and contracts

This patch removes the custom javascript form validation from three
templates: Budgets, budget planning, and contracts. Validation via the
validation plugin is done instead.

This patch also removes use of event attributes like onclick and
onchange. Also changed: I added the "Required" text next to required
fields as necessary.

To test, apply the patch and go to Administration -> Budgets.

- Test the budget creation process for adding, editing, and duplicating
  budgets. In all cases:
  - The start date and end date should be required
  - You should be warned if you enter an end date which falls before the
    start date.
  - The description should be required
  - The budget amount should be required to be a number

To test the budget planning page:

Note that much of the JS removed from this template was unused. It
looked for inputs by the name 'est_total' which don't exist.

- When viewing the table of funds for a budget, select a choice from the
  'planning' toolbar menu.
  - Verify that after entering a numeric value in any cell, the
    'remaning' value at the end of the row is correctly updated.
  - Verify that after entering non-numeric data an error is displayed.
  - Verify that clicking the 'auto-fill' button at the end of the row

To test the vendor contracts page:

- Go to Acquisitions -> Vendor -> Contracts
- Add or edit a contract
  - Confirm that name, start date, and end date are required.
  - Confirm that you are warned if you enter an end date which falls
    before the start date.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:30:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:30:27 +0000
Subject: [Koha-bugs] [Bug 17058] New: Automatic renewals
Message-ID: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

            Bug ID: 17058
           Summary: Automatic renewals
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victoria.kemp at flower-mound.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Setting "BorrowerRenewalPeriodBase" to CURRENT DATE negates automatic renewal
for all items.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:32:34 +0000
Subject: [Koha-bugs] [Bug 17058] Automatic renewals
In-Reply-To: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17058-70-oswfLMYLZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 19:58:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 17:58:33 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-7bkuGZX6Ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #81 from Fr?d?ric Demians <frederic at tamil.fr> ---
When executing atomicupdate/bug_7441.sql, I get this error:

Bareword found where operator expected at
./installer/data/mysql/atomicupdate/bug_7441.sql line 1, near ") VALUES"
        (Missing operator before VALUES?)
syntax error at ./installer/data/mysql/atomicupdate/bug_7441.sql line 2, near
") VALUES
"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 20:12:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 18:12:10 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-1HnwxbLuDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 20:12:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 18:12:14 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-L4nHGPjsQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52811|0                           |1
        is obsolete|                            |

--- Comment #82 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54058&action=edit
Bug 7441 - Followup search results showing wrong branch [UNIMARC]

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Playing with OPACResultsLibrary syspref, biblio with items having different
  home/holding library are displayed properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 20:22:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 18:22:24 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-JWeilUT1ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #83 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Fr?d?ric Demians from comment #81)
> When executing atomicupdate/bug_7441.sql, I get this error:
> 
> Bareword found where operator expected at
> ./installer/data/mysql/atomicupdate/bug_7441.sql line 1, near ") VALUES"
>         (Missing operator before VALUES?)
> syntax error at ./installer/data/mysql/atomicupdate/bug_7441.sql line 2,
> near ") VALUES
> "

Forget this! The SQL statement works properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 21:10:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 19:10:23 +0000
Subject: [Koha-bugs] [Bug 17058] Automatic renewals broken when
 BorrowerRenewalPeriodBase is set to current day
In-Reply-To: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17058-70-yCjJDEMD3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Automatic renewals          |Automatic renewals broken
                   |                            |when
                   |                            |BorrowerRenewalPeriodBase
                   |                            |is set to current day

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I changed the bug title a bit to have a bit more information - those are also
used for printing the release notes later :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 22:53:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 20:53:50 +0000
Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications
 for all overdue actions
In-Reply-To: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16568-70-itBMT2fmeT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Chris Rohde <crohde at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crohde at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 22:53:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 20:53:52 +0000
Subject: [Koha-bugs] [Bug 16680] Library name are not displayed for holds in
	transit
In-Reply-To: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16680-70-3KOKvTC778@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:01:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:01:33 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-HAMBr1Fgj3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:17:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:17:47 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-zCNRphInpd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:40:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:40:56 +0000
Subject: [Koha-bugs] [Bug 15772] GetNormalizedISBN returns a 10 digit ISBN -
 should return 13
In-Reply-To: <bug-15772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15772-70-fI6VShRCRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15772

Patricia Brauer <triciab at roundrocktexas.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |triciab at roundrocktexas.gov

--- Comment #1 from Patricia Brauer <triciab at roundrocktexas.gov> ---
Nick -- Is this still open? There's no work, no test plan.

Tricia Brauer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:42:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:42:30 +0000
Subject: [Koha-bugs] [Bug 10102] don't show empty novelist tab if no data
In-Reply-To: <bug-10102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10102-70-Fydf4bm0K9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102

Patricia Brauer <triciab at roundrocktexas.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |triciab at roundrocktexas.gov

--- Comment #2 from Patricia Brauer <triciab at roundrocktexas.gov> ---
Nick-
Sorry ignore my comment. Having browser problems. Tricia B.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:52:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:52:28 +0000
Subject: [Koha-bugs] [Bug 17059] New: Toll Free-HP(((1~844~305~5565)))
 printer TECH support phone number Florida
Message-ID: <bug-17059-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17059

            Bug ID: 17059
           Summary: Toll Free-HP(((1~844~305~5565)))printer TECH support
                    phone number Florida
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: dilsan at yopmail.com
        QA Contact: testopia at bugs.koha-community.org

hp printer support number
hp printer support phone number
hp support
hp printer support chat
hp printers
koobface
canon printer support number
brother printer support number
hp printer troubleshooting
 hp printer support phone number
hp printer tech support phone number
hewlett packard printer support phone number
hp printer support telephone number
hp printer support center
dell printer support phone number
brother printer support phone number
hp printer support chat
canon printer support phone number
hp printer support telephone number
hp printer support center
canon printer support phone number
hp ink customer service number
hp printer support chat
dell printer support phone number
hewlett packard printer support phone number
epson printer support phone number
brother printer support phone number
hp ink customer service number
hp instant ink
hp instant ink customer service phone number
compaq warranty number
hp laptop customer service phone number
hp technical support number
hp support chat
hp printer support telephone number
hp customer support software and driver downloads
hp technical support number
hp technical support chat
hp customer service number
hp technical support number india
hp technical support number toll free
dell technical support number
compaq technical support number
sony technical support number
hp computer support number
hp customer service number
hp computer customer service number
hp support
hp laptop customer service number
hp printers
hewlett packard number
hp instant ink customer service number
hp customer service phone number get human
hp customer service number for printers
hp support
hp printer support
hp printers
hp support center
hp drivers
hp support chat
hp support parts
hp support forum
hp support assistant
 hp printer problems
hp wireless printer problems
hp inkjet printer problems
hp printer installation problems
hp printer driver problems
hp printers
hp printer problems with mac
hp laserjet printer problems
hp photo printer problems
 hp inkjet printer problems
hp laser printer problems
hp laserjet printer problems
hp mouse problems
hp inkjet printer problems and solutions
hp inkjet printer reviews
hp inkjet printer settlement
hp inkjet printer cartridge
hp large format inkjet printers
hp inkjet printer reviews
hp inkjet printers
hp inkjet printer reviews 2015
dell inkjet printer reviews
hp laser printer reviews
hp laserjet printer reviews
best inkjet printer
best color inkjet printer
best color inkjet printer 2015

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug  5 23:57:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 21:57:41 +0000
Subject: [Koha-bugs] [Bug 17061] New: Toll Free-HP(((
 =?UTF-8?Q?1=CB=9C8=CB=9C44=CB=9C305=CB=9C55=CB=9C65?=))) printer support
 phone number Florida
Message-ID: <bug-17061-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17061

            Bug ID: 17061
           Summary: Toll Free-HP(((1?8?44?305?55?65)))printer support
                    phone number Florida
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: dilsan at yopmail.com

usaHow @@cow Hp printer support phone number ((1844))-305-5565Hp printer
support phone number usa How @@@@how ((1844))-305-5565Hp printer support phone
number@@@!!!! Hp printer PrinTer call @@@@@ .1-844 305 5565.Support Phone
Number,Hp printer tech support number, Hp Printer Customer Care Phone Number
USA&&&!!!! Hp printer PrinTer call @@@@@ .1-844 305 5565.Support Phone
Number,Hp printer tech support number, Hp Printer Customer Care Phone Number
USA Testing ((1844))-305-5565Hp printer support phone number Hp printer phone
number status @PrinTer .1-844 305 5565 .Support Phone Number,Hp printer tech
support number, Hp Printer Customer Care Phone Number uSa $$$$
CALL%%%%%!!!!!!!!Hp Printer tech Support Number @1-844 305 5565@ Hp Printer
Tech Support Phone Number Call wireless 1-844 305 5565 1-844-305-5565 Hp Tech
Support Phone Number Canada Hp printer customer service number1-844 305 5565 Hp
support number, Hp support, Hp printer support, Hp tech support, Hp technical
support, Hp customer service number, Hp customer service, Hp tech support
number, Hp support center, Hp printer support number, hewlett packard support,
Hp contact number, Hp phone number, Hp help and support, Hp customer support,
Hp printer help, Hp technical support number, Hp support phone number, hewlett
packard customer service, Hp printers support, Hp customer service phone
number, Hp number, Hp customer care, Hp contact, Hp tech support phone number,
Hp support chat, Hp customer support number, Hp customer care number, contact
Hp support, Hp help, Hp phone, Hp printer support phone number, Hp customer
support phone number, Hp printer tech support, Hp phone support, Hp technical
support phone number, Hp pRINTER support number, hewlett packard printer
support, Hp helpline, Hp telephone support, Hp online support, Hp support
contact, Hp chat support, hewlett packard phone number, Hp printer customer
service, Hp printer tech support number, Hp product support, hewlett packard
customer service phone number, Hp computer support number, Hp support contact
number, Hp support printer, Hp computer support, Hp tech support chat, Hp
helpline number, Hp pRINTER support, hewlett packard tech support, Hp online
chat, hewlett packard technical support, Hp printer help line, phone number for
Hp support, hewlett packard support phone number, Hp printer technical support,
hewlett packard customer service number, Hp service number, hewlett packard
helpline, Hp customer care no, Hp printer customer service number, Hp help
number, Hp printer customer service phone number, Hp 1305 number, Hp support
phone, Hp support line, hewlett packard contact number, Hp printer tech support
phone number, Hp printer customer support phone number, Hp printers help, call
Hp support, Hp printer support chat, hewlett packard support number, hewlett
packard tech support number, Hp support telephone number, hewlett packard tech
support phone number, call Hp, Hp contact support, hewlett packard technical
support phone number, Hp support centre, hewlett packard customer support, Hp
desktop support, Hp pRINTER customer service, contact Hp printer support, Hp pc
support, Hp pRINTER customer care number, Hp support for printers, Hp printer
customer care, Hp customer care phone number, hewlett packard help, phone
number for Hp, Hp online help, Hp pRINTER customer care, Hp helpline phone
number, Hp printer customer support, Hp technical support chat, Hp computer
help, Hp support numbers, Hp technical support contact number, Hp telephone
number, Hp printer technical support phone number, Hp printer helpline, Hp
support printers, Hp support online, Hp printer contact number, Hp help phone
number, Hp printer customer care number, contact hewlett packard by phone, Hp
printer phone support, hewlett packard printers support, Hp tech support phone,
Hp technical help, Hp pRINTER tech support number, contact Hp by phone, Hp
support call, Hp computers support, hewlett packard customer service telephone
number, phone number for hewlett packard, Hp online support chat, Hp pRINTER
customer service number, Hp online chat support, Hp printers customer service,
hewlett packard customer service phone, Hp pRINTER tech support, Hp service
phone number, hewlett packard printer help, phone number for Hp printers, Hp
troubleshooting phone number, Hp 305 number, hewlett packard technical support
number, contact Hp support phone, phone number for Hp printer support, Hp
customer support chat, Hp help and support number, contact hewlett packard, Hp
pRINTER support phone number, Hp printers customer service phone number, Hp
pRINTER customer service phone number, Hp computer support phone number, Hp
pavilion support, Hp computer customer service, Hp customer services, hewlett
packard telephone number, Hp helpline no, Hp help desk number, contact Hp
support phone number, hewlett packard contact, Hp phone numbers, Hp printers
customer care number, Hp printer help and support, contact Hp technical
support, Hp contact numbers, contact Hp support chat, call Hp tech support, Hp
customer service phone, Hp help support, Hp computer tech support, Hp
assistance phone number, Hp customer service telephone number, hewlett packard
printer support phone number, Hp contact support number, Hp support center
phone number, Hp support phone numbers, tech support for Hp, Hp it support, Hp
pRINTER helpline, Hp technical, Hp pRINTER technical support number, Hp
printers tech support phone number, Hp printers support phone number, hewlett
packard help desk phone number, Hp computer tech support phone number, Hp
customer service number for pRINTER, Hp printer helpline number, contact Hp
support by phone, hewlett packard support center, Hp pRINTER customer care no,
Hp printer support telephone number, Hp support 1 844 305 5565 services, Hp
customer service number for printers, Hp product support number, Hp pRINTER
tech support phone number, Hp printer helpline phone number, contact Hp
customer support, hewlett packard customer support phone number, Hp printers
technical support, Hp customer care center, support for Hp printers, Hp printer
support center, phone number for Hp tech support, Hp desktop customer care
number, Hp pRINTERs support, Hp printer online support, Hp printer phone
number, hewlett packard printers support phone number, technical support for Hp
printers phone number, Hp help center phone number, contact Hp tech support,
call Hp printer support, Hp printers customer support, Hp computer customer
service number, Hp printers helpline, Hp customer care contact number, Hp
pRINTER help, Hp computer customer service phone number, phone number for
hewlett packard customer service, hewlett packard 305 number, Hp printer help
phone number, Hp printers help phone number, Hp printer phone number for
customer service, Hp computer technical support phone number, customer service
Hp, Hp support technical support number, contact number for Hp, Hp computers
support phone number, Hp printers support number, Hp printer technical support
number, contact Hp tech support by phone, Hp computer customer care number, Hp
printer 305 number, call Hp customer service, Hp printer help center, Hp
computers customer service, Hp printer help desk, hewlett packard computer
support, Hp printers technical support number, Hp help desk phone number, Hp
printer support phone, Hp contact help, contact Hp pRINTER support, Hp customer
service contact number, support for Hp printer, Hp printer customer care no, 1
844 305 5565 Hp computer phone number, Hp tech help, Hp pc support number, Hp
pRINTER customer support, Hp desktop support number, support Hp printer, Hp
support hours, number for Hp support, Hp support customer service number, Hp
contact phone number, customer service number for Hp printers, Hp computers
help, Hp tech support contact number, Hp phone support Tech vew sUpP0RT.... Hp
@PrinTer .1 844 305 5565- .Support Phone Number,HP printer tech support number,
HP Printer Customer Care Phone Number uSa. $UPP0RT.... Hp @PrinTer .1-844 305
5565- .Support Phone Number,Hp printer tech support number, Hp Printer Customer
Care Phone Number uSa. HppRintERTEchSuppORtphOnENumbER1-844 305
5565HppRintERSuppORtphOnENumbER,HppRintERSuppORtNumbER,HppRintERtEchSuppORtNumbER..HppRintERssuppORtphOnEnumbER?-Hp
Printers phone number) !!!UsA!!+++((!!!!(1-844 305 5565))))))+++Hp pRintER tEch
suppORt phOnE numbER usa canada !!!UsA!!+++++((!!!!(1-844 305 5565))))))+++Hp
pRintER tEch suppORt phOnE numbER usa canada Hp pRintER tEch suppORt phOnE
numbER usa!!+++++1-844 305 5565+++Hp pRintER tEch suppORt phOnE numbER
usa...pDF, Hp pRintER 1-844 305 5565 Hp pRintER custOmER sERvicE phOnE
numbER,Hp pRintER tEchnical suppORt numbER1-844 305 5565 Hp pRintER custOmER
sERvicE phOnE numbER,cannOn pRintER hElplinE, Hp pRintER tEchnical suppORt
phOnE numbER, Hp pRintER tEch suppORt numbER,Hp 1-844 305 5565Hp pRintER
hElplinE, Hp pRintER tEchnical suppORt phOnE numbER, Hp pRintER tEch suppORt
numbER 1-844 305 5565 Hp pRINTER tEch suppORt phOnE numbER USA !!Call aus 1-844
305 5565Hp TEch SuppORt phOnE NumbER UK-1 844 305 5565 Hp suppORt numbER, Hp
suppORt, Hp pRintER suppORt, Hp tEch suppORt, Hp tEchnical suppORt, Hp custOmER
sERvicE numbER, Hp custOmER sERvicE, Hp tEch suppORt numbER, Hp suppORt cEntER,
Hp pRintER suppORt numbER, Hp suppORt suppORt, 1-844 305 5565 Hp cOntact
numbER, Hp phOnE numbER, Hp hElp and suppORt, Hp custOmER suppORt, Hp pRintER
hElp, Hp tEchnical suppORt numbER, Hp suppORt phOnE numbER, Hp suppORt custOmER
sERvicE, Hp pRintERs suppORt, Hp custOmER sERvicE phOnE numbER, Hp numbER, Hp
custOmER caRE, Hp cOntact, Hp tEch suppORt phOnE numbER, Hp suppORt chat, Hp
custOmER suppORt numbER, Hp custOmER caRE numbER, cOntact Hp suppORt, Hp hElp,
Hp phOnE, Hp pRintER suppORt phOnE numbER, Hp custOmER suppORt phOnE numbER, Hp
pRintER tEch suppORt, Hp phOnE suppORt, Hp tEchnical suppORt phOnE numbER, Hp
pRINTER suppORt numbER, Hp suppORt pRintER suppORt, Hp hElplinE, Hp tElEphOnE
suppORt, Hp OnlinE suppORt, Hp suppORt cOntact, Hp chat suppORt, Hp suppORt
phOnE numbER, Hp pRintER custOmER sERvicE, Hp pRintER tEch suppORt numbER, Hp
pROduct suppORt 1-844 305 5565 , Hp suppORt custOmER sERvicE phOnE numbER, Hp
cOmputER suppORt numbER, Hp suppORt cOntact numbER, Hp suppORt pRintER, Hp
cOmputER suppORt, Hp tEch suppORt chat, Hp hElplinE numbER, Hp pRINTER
suppORt1-844 305 5565, Hp suppORt tEch suppORt, Hp OnlinE chat, Hp suppORt
tEchnical suppORt, Hp pRintER hElp linE, phOnE numbER fOR Hp suppORt, Hp
suppORt suppORt phOnE numbER 1-844 305 5565, Hp pRintER tEchnical suppORt, Hp
suppORt custOmER sERvicE numbER, Hp sERvicE numbER, Hp suppORt hElplinE, Hp
custOmER caRE nO, Hp pRintER custOmER sERvicE numbER, Hp hElp numbER, Hp
pRintER custOmER sERvicE phOnE numbER, Hp 1-844 305 5565 numbER, Hp suppORt
phOnE, Hp suppORt linE, Hp suppORt cOntact numbER, Hp pRintER tEch suppORt
phOnE numbER, Hp pRintER custOmER suppORt phOnE numbER, Hp pRintERs hElp, call
Hp suppORt, Hp pRintER suppORt chat, Hp suppORt suppORt numbER, Hp suppORt tEch
suppORt numbER, Hp suppORt tElEphOnE numbER, Hp suppORt tEch suppORt phOnE
numbER, call Hp, Hp cOntact suppORt, Hp suppORt tEchnical suppORt phOnE numbER,
Hp suppORt cEntRE, Hp suppORt custOmER suppORt, Hp dEsktOp suppORt, Hp pRINTER
custOmER sERvicE, cOntact Hp pRintER suppORt, Hp pc suppORt, Hp pRINTER
custOmER caRE numbER, Hp suppORt fOR pRintERs, Hp pRintER custOmER caRE, Hp
custOmER caRE phOnE numbER, Hp suppORt hElp, phOnE numbER fOR Hp, Hp OnlinE
hElp, Hp pRINTER custOmER caRE, Hp hElplinE phOnE numbER, Hp pRintER custOmER
suppORt, Hp tEchnical suppORt chat, Hp cOmputER hElp, Hp suppORt numbERs, Hp
tEchnical suppORt cOntact numbER, Hp tElEphOnE numbER, Hp pRintER tEchnical
suppORt phOnE numbER, Hp pRintER hElplinE, Hp suppORt pRintERs1-844 305 5565,
Hp suppORt OnlinE, Hp pRintER cOntact numbER, Hp hElp phOnE numbER, Hp pRintER
custOmER caRE numbER, cOntact Hp suppORt by phOnE, Hp pRintER phOnE suppORt, Hp
suppORt pRintERs suppORt, Hp tEch suppORt phOnE, Hp tEchnical hElp, Hp pRINTER
tEch suppORt numbER, cOntact Hp by phOnE, Hp suppORt call, Hp cOmputERs
suppORt, Hp suppORt custOmER sERvicE tElEphOnE numbER, phOnE numbER fOR Hp
suppORt, Hp OnlinE suppORt chat, Hp pRINTER custOmER sERvicE numbER, Hp OnlinE
chat suppORt, Hp pRintERs custOmER sERvicE, Hp suppORt custOmER sERvicE phOnE,
Hp pRINTER tEch suppORt, Hp sERvicE phOnE numbER, Hp suppORt pRintER hElp,
phOnE numbER fOR Hp pRintERs, Hp tROublEshOOting phOnE numbER, Hp 1-844 305
5565numbER, Hp suppORt tEchnical suppORt numbER, cOntact Hp suppORt phOnE,
phOnE numbER fOR Hp pRintER suppORt, Hp custOmER suppORt chat, Hp hElp and
suppORt numbER, cOntact Hp suppORt, Hp pRINTER suppORt phOnE numbER, Hp
pRintERs custOmER sERvicE phOnE numbER, Hp pRINTER custOmER sERvicE phOnE
numbER, Hp cOmputER suppORt phOnE numbER, Hp paviliOn suppORt, Hp cOmputER
custOmER sERvicE, Hp custOmER sERvicEs, Hp suppORt tElEphOnE numbER, Hp
hElplinE nO, Hp hElp dEsk numbER, cOntact Hp suppORt phOnE numbER, Hp suppORt
cOntact, Hp phOnE numbERs, Hp pRintERs custOmER caRE numbER, Hp pRintER hElp
and suppORt, cOntact Hp tEchnical suppORt, Hp cOntact numbERs, cOntact Hp
suppORt chat, call Hp tEch suppORt, Hp custOmER sERvicE phOnE, Hp hElp suppORt,
Hp cOmputER tEch suppORt, Hp assistancE phOnE numbER, Hp custOmER sERvicE
tElEphOnE numbER, Hp suppORt pRintER suppORt phOnE numbER, Hp cOntact suppORt
numbER, Hp suppORt cEntER phOnE numbER, Hp suppORt phOnE numbERs, tEch suppORt
fOR Hp, Hp it suppORt, Hp pRINTER hElplinE, Hp tEchnical, Hp pRINTER tEchnical
suppORt numbER, Hp pRintERs tEch suppORt phOnE numbER, Hp pRintERs suppORt
phOnE numbER, Hp suppORt hElp dEsk phOnE numbER, Hp cOmputER tEch suppORt phOnE
numbER, Hp custOmER sERvicE numbER fOR pRINTER, Hp pRintER hElplinE numbER,
cOntact Hp suppORt by phOnE, Hp suppORt suppORt cEntER, Hp pRINTER custOmER
caRE nO, Hp pRintER suppORt tElEphOnE numbER, Hp suppORt sERvicEs, Hp custOmER
sERvicE numbER fOR pRintERs, Hp pROduct suppORt numbER, Hp pRINTER tEch suppORt
phOnE numbER, Hp pRintER hElplinE phOnE numbER, cOntact Hp custOmER suppORt, Hp
suppORt custOmER suppORt phOnE numbER, Hp pRintERs tEchnical suppORt, Hp
custOmER caRE cEntER, suppORt fOR Hp pRintERs, Hp pRintER suppORt cEntER, phOnE
numbER fOR Hp tEch suppORt, Hp dEsktOp custOmER caRE numbER, Hp pRINTERs
suppORt, Hp pRintER OnlinE suppORt, Hp pRintER phOnE numbER, Hp suppORt
pRintERs suppORt phOnE numbER, tEchnical suppORt fOR Hp pRintERs phOnE numbER,
Hp hElp cEntER phOnE numbER, cOntact Hp tEch suppORt, call Hp pRintER suppORt,
Hp pRintERs custOmER suppORt, Hp cOmputER custOmER sERvicE numbER, Hp pRintERs
hElplinE, Hp custOmER caRE cOntact numbER, Hp pRINTER hElp, Hp cOmputER
custOmER sERvicE phOnE numbER, phOnE numbER fOR Hp suppORt custOmER sERvicE, Hp
suppORt 1-844 305 5565 numbER, Hp pRintER hElp phOnE numbER, Hp pRintERs hElp
phOnE numbER, Hp pRintER phOnE numbER fOR custOmER sERvicE, Hp cOmputER
tEchnical suppORt phOnE numbER, custOmER sERvicE Hp, Hp suppORt tEchnical
suppORt numbER, cOntact numbER fOR Hp, Hp cOmputERs suppORt phOnE numbER, Hp
pRintERs suppORt numbER, Hp pRintER tEchnical suppORt numbER, cOntact Hp tEch
suppORt by phOnE, Hp cOmputER custOmER caRE numbER, Hp pRintER 1-844 305 5565
numbER, call Hp custOmER sERvicE, Hp pRintER hElp cEntER, Hp cOmputERs custOmER
sERvicE, Hp pRintER hElp dEsk, Hp suppORt cOmputER suppORt, Hp pRintERs
tEchnical suppORt numbER, Hp hElp dEsk phOnE numbER, Hp pRintER suppORt phOnE,
Hp cOntact hElp, cOntact Hp pRINTER suppORt, Hp custOmER sERvicE cOntact
numbER, suppORt fOR Hp pRintER, Hp pRintER custOmER caRE nO, Hp cOmputER phOnE
numbER, Hp tEch hElp, Hp pc suppORt numbER, Hp pRINTER custOmER suppORt, Hp
dEsktOp suppORt numbER, suppORt Hp pRintER, Hp suppORt hOuRs, numbER fOR Hp
suppORt, Hp suppORt custOmER sERvicE numbER, Hp cOntact phOnE numbER, custOmER
sERvicE numbER fOR Hp pRintERs, Hp cOmputERs hElp, Hp tEch suppORt cOntact
numbER, Hp phOnE suppORt numbER Most Urgent ((1844))-305-5565Hp printer support
phone number Hp printer customer care phone number
HpPRinterTechSupportPhoneNumber1-305-424
6647HpPrinterSupportPhoneNumber,HpPrinterSupportNumber,HpPrintertechSupportNumber..HpPrinterssupportphonenumber?-Hp
Printers phone number) !!!UsA!!+++((!!!!(1-844 305 5565))))))+++Hp printer tech
support phone number usa canada !!!UsA!!+++++((!!!!(1-844 305 5565))))))+++Hp
printer tech support phone number usa canada Hp printer tech support phone
number usa!!+++++1-844 305 5565+++Hp printer tech support phone number
usa...PDF, Hp printer 1-844 305 5565 Hp printer customer service phone
number,Hp printer technical support number1-844 305 5565 Hp printer customer
service phone number,cannon printer helpline, Hp printer technical support
phone number, Hp printer tech support number,Hp 1-844 305 5565Hp printer
helpline, Hp printer technical support phone number, Hp printer tech support
number 1-844 305 5565 Hp PRINTER tech support phone number USA !!Call aus 1-844
305 5565Hp Tech Support Phone Number UK-1 844 305 5565 Hp support number, Hp
support, Hp printer support, Hp tech support, Hp technical support, Hp customer
service number, Hp customer service, Hp tech support number, Hp support center,
Hp printer support number, Hp support support, 1-844 305 5565 Hp contact
number, Hp phone number, Hp help and support, Hp customer support, Hp printer
help, Hp technical support number, Hp support phone number, Hp support customer
service, Hp printers support, Hp customer service phone number, Hp number, Hp
customer care, Hp contact, Hp tech support phone number, Hp support chat, Hp
customer support number, Hp customer care number, contact Hp support, Hp help,
Hp phone, Hp printer support phone number, Hp customer support phone number, Hp
printer tech support, Hp phone support, Hp technical support phone number, Hp
pRINTER support number, Hp support printer support, Hp helpline, Hp telephone
support, Hp online support, Hp support contact, Hp chat support, Hp support
phone number, Hp printer customer service, Hp printer tech support number, Hp
product support 1-844 305 5565 , Hp support customer service phone number, Hp
computer support number, Hp support contact number, Hp support printer, Hp
computer support, Hp tech support chat, Hp helpline number, Hp pRINTER
support1-844 305 5565, Hp support tech support, Hp online chat, Hp support
technical support, Hp printer help line, phone number for Hp support, Hp
support support phone number 1-844 305 5565, Hp printer technical support, Hp
support customer service number, Hp service number, Hp support helpline, Hp
customer care no, Hp printer customer service number, Hp help number, Hp
printer customer service phone number, Hp 1-844 305 5565 number, Hp support
phone, Hp support line, Hp support contact number, Hp printer tech support
phone number, Hp printer customer support phone number, Hp printers help, call
Hp support, Hp printer support chat, Hp support support number, Hp support tech
support number, Hp support telephone number, Hp support tech support phone
number, call Hp, Hp contact support, Hp support technical support phone number,
Hp support centre, Hp support customer support, Hp desktop support, Hp pRINTER
customer service, contact Hp printer support, Hp pc support, Hp pRINTER
customer care number, Hp support for printers, Hp printer customer care, Hp
customer care phone number, Hp support help, phone number for Hp, Hp online
help, Hp pRINTER customer care, Hp helpline phone number, Hp printer customer
support, Hp technical support chat, Hp computer help, Hp support numbers, Hp
technical support contact number, Hp telephone number, Hp printer technical
support phone number, Hp printer helpline, Hp support printers1-844 305 5565,
Hp support online, Hp printer contact number, Hp help phone number, Hp printer
customer care number, contact Hp support by phone, Hp printer phone support, Hp
support printers support, Hp tech support phone, Hp technical help, Hp pRINTER
tech support number, contact Hp by phone, Hp support call, Hp computers
support, Hp support customer service telephone number, phone number for Hp
support, Hp online support chat, Hp pRINTER customer service number, Hp online
chat support, Hp printers customer service, Hp support customer service phone,
Hp pRINTER tech support, Hp service phone number, Hp support printer help,
phone number for Hp printers, Hp troubleshooting phone number, Hp 1-844 305
5565number, Hp support technical support number, contact Hp support phone,
phone number for Hp printer support, Hp customer support chat, Hp help and
support number, contact Hp support, Hp pRINTER support phone number, Hp
printers customer service phone number, Hp pRINTER customer service phone
number, Hp computer support phone number, Hp pavilion support, Hp computer
customer service, Hp customer services, Hp support telephone number, Hp
helpline no, Hp help desk number, contact Hp support phone number, Hp support
contact, Hp phone numbers, Hp printers customer care number, Hp printer help
and support, contact Hp technical support, Hp contact numbers, contact Hp
support chat, call Hp tech support, Hp customer service phone, Hp help support,
Hp computer tech support, Hp assistance phone number, Hp customer service
telephone number, Hp support printer support phone number, Hp contact support
number, Hp support center phone number, Hp support phone numbers, tech support
for Hp, Hp it support, Hp pRINTER helpline, Hp technical, Hp pRINTER technical
support number, Hp printers tech support phone number, Hp printers support
phone number, Hp support help desk phone number, Hp computer tech support phone
number, Hp customer service number for pRINTER, Hp printer helpline number,
contact Hp support by phone, Hp support support center, Hp pRINTER customer
care no, Hp printer support telephone number, Hp support services, Hp customer
service number for printers, Hp product support number, Hp pRINTER tech support
phone number, Hp printer helpline phone number, contact Hp customer support, Hp
support customer support phone number, Hp printers technical support, Hp
customer care center, support for Hp printers, Hp printer support center, phone
number for Hp tech support, Hp desktop customer care number, Hp pRINTERs
support, Hp printer online support, Hp printer phone number, Hp support
printers support phone number, technical support for Hp printers phone number,
Hp help center phone number, contact Hp tech support, call Hp printer support,
Hp printers customer support, Hp computer customer service number, Hp printers
helpline, Hp customer care contact number, Hp pRINTER help, Hp computer
customer service phone number, phone number for Hp support customer service, Hp
support 1-844 305 5565 number, Hp printer help phone number, Hp printers help
phone number, Hp printer phone number for customer service, Hp computer
technical support phone number, customer service Hp, Hp support technical
support number, contact number for Hp, Hp computers support phone number, Hp
printers support number, Hp printer technical support number, contact Hp tech
support by phone, Hp computer customer care number, Hp printer 1-844 305 5565
number, call Hp customer service, Hp printer help center, Hp computers customer
service, Hp printer help desk, Hp support computer support, Hp printers
technical support number, Hp help desk phone number, Hp printer support phone,
Hp contact help,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 00:34:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 22:34:42 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item) number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-VfuZca1RtU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

Christopher Davis <mr.cataloger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mr.cataloger at gmail.com

--- Comment #4 from Christopher Davis <mr.cataloger at gmail.com> ---
Olli-Antti Kivilahti,

I was taking a look at this bug and I could not find any patch or test plan.
Will you please add these to this bug report?

Thank you,

Christopher Davis

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 01:12:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 23:12:34 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-7HDtwMyjxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

--- Comment #3 from Brendon Ford <brendon.ford at manhattan.edu> ---
Created attachment 54059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54059&action=edit
Bug 17052: Display patron category description in the sidebar of paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 01:39:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 23:39:28 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-g5oDJrhQmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford <brendon.ford at manhattan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54059|0                           |1
        is obsolete|                            |

--- Comment #4 from Brendon Ford <brendon.ford at manhattan.edu> ---
Created attachment 54060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54060&action=edit
Bug 17052: Display patron category description in the sidebar of paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 01:42:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 23:42:42 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-aunxXsrPsD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford <brendon.ford at manhattan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54045|0                           |1
        is obsolete|                            |
  Attachment #54060|0                           |1
        is obsolete|                            |

--- Comment #5 from Brendon Ford <brendon.ford at manhattan.edu> ---
Created attachment 54061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54061&action=edit
[SIGNED-OFF] Bug 17052: Display patron category description in the sidebar of
paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 01:43:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 05 Aug 2016 23:43:55 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-00BYVh0Wov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford <brendon.ford at manhattan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendon.ford at manhattan.edu

--- Comment #6 from Brendon Ford <brendon.ford at manhattan.edu> ---
Very sorry about all the sign off's. I'm still learning git-bz.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 10:14:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 08:14:01 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-NSGFVmvmHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 10:14:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 08:14:03 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-GgThKq6BWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

--- Comment #1 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54062&action=edit
Bug 17053 Clearing search term in Reports

If you click the clear button to clear the search term it does take the search
term away. However, the next time you click on "Saved reports" the search term
is still there.

TO TEST:

1. Reports > Use saved
2. Filter on anything (date/author/keyword). Let say "foo" in keyword.
3. Click the Clear link on the Filter form. You can see that "foo" is removed
   from keyword, and all the saved reports are displayed.
4. Click "Saved Reports" on the left. You can see that "foo" reappears in
   keyword filter.
5. Apply the patch, and repeat steps 2-4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 10:14:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 08:14:40 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-X32ZWkEHVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
            Version|16.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:00:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:00:01 +0000
Subject: [Koha-bugs] [Bug 7627] Editing of invoice number
In-Reply-To: <bug-7627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7627-70-ttVtB5dSdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:04:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:04:07 +0000
Subject: [Koha-bugs] [Bug 17062] New: debian/control.in update: change
	maintainer
Message-ID: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

            Bug ID: 17062
           Summary: debian/control.in update: change maintainer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:04:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:04:31 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-x0eQXRxjtm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16971


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971
[Bug 16971] Missing dependency for HTML::Entities
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:04:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:04:31 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-GMpYISeTTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:04:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:04:41 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-06NDU0ZPwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:05:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:05:28 +0000
Subject: [Koha-bugs] [Bug 1884] Managing Suggestions - way to archive/clean
 up approved/ rejected orders
In-Reply-To: <bug-1884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1884-70-dKIOOdtjrg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:06:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:06:26 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-khZE9jT8LI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54063&action=edit
Bug 17062 - debian/control.in update: change maintainer

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:06:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:06:46 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-vx1mRkdy8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:12:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:12:10 +0000
Subject: [Koha-bugs] [Bug 1966] Allow manual editing of Qty on receive
In-Reply-To: <bug-1966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1966-70-DJZfGN6Qig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1966

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:23:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:23:11 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-X9HViJ2z2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #62 from Sandre Cunha <cunha at monterey.org> ---
What is the current status of this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:23:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:23:59 +0000
Subject: [Koha-bugs] [Bug 10208] The ability to order multiple copies of the
	same title
In-Reply-To: <bug-10208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10208-70-PLElBeNGXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:31:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:31:49 +0000
Subject: [Koha-bugs] [Bug 17063] New: debian/control.in update: change
 maintainer & add libhtml-parser-perl for 16.05.x
Message-ID: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

            Bug ID: 17063
           Summary: debian/control.in update: change maintainer & add
                    libhtml-parser-perl for 16.05.x
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

This one is for 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:32:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:32:04 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-nz1ThW11d6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:32:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:32:25 +0000
Subject: [Koha-bugs] [Bug 14084] order date language in Koha inconsistent
In-Reply-To: <bug-14084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14084-70-8L1Ygfk9RU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:32:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:32:37 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-HuCxaIjISU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|debian/control.in update:   |debian/control.in update:
                   |change maintainer           |change maintainer & add
                   |                            |libhtml-parser-perl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:33:25 +0000
Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point
In-Reply-To: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10253-70-Rb1EUnlvX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:34:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:34:08 +0000
Subject: [Koha-bugs] [Bug 14857] shouldn't be allowed to receive from locked
	fund
In-Reply-To: <bug-14857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14857-70-S5iSnafiVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:34:17 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-BTgneXRxWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17043


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043
[Bug 17043] debian/list-deps fixes, master edition
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:34:17 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-DM8yjE3xe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer & add
libhtml-parser-perl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:35:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:35:17 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-DNWTZko64O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54064&action=edit
Bug 17063 - debian/control.in update: change maintainer & add
libhtml-parser-perl for 16.05.x

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

This one is for 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:36:39 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-BcUrvHeAqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16971,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17062

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:36:39 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-3DEi2x23CC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17063

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:36:39 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-uQI2ey7r50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17063

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:37:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:37:11 +0000
Subject: [Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't
 match order date
In-Reply-To: <bug-14086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14086-70-57gEubkh9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:37:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:37:37 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-Md1T3HKQNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16971


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971
[Bug 16971] Missing dependency for HTML::Entities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:37:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:37:37 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-NVcEKxWZW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17063


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063
[Bug 17063] debian/control.in update: change maintainer & add
libhtml-parser-perl for 16.05.x
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:39:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:39:51 +0000
Subject: [Koha-bugs] [Bug 12652] Acq: Wrong fund charged for orders created
 from staged marc records
In-Reply-To: <bug-12652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12652-70-Mu6Yxfnwh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12652

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:40:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:40:17 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-ifK0reHgYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Fr?d?ric Demians from comment #6)
> Mirko: Could you add libhtml-entities-perl to debian/control, in another
> patch or in this one?

Frederic: Yes, please see bug 17063 for the 16.05.x version. HTML::Entities is
in libhtml-parser-perl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:43:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:43:29 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-3fetvLrNCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588
[Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as
dependencies
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:43:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:43:29 +0000
Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl)
 need to be added as dependencies
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-lB3Ek8ZRAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17043


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043
[Bug 17043] debian/list-deps fixes, master edition
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:44:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:44:57 +0000
Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl)
 need to be added as dependencies
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-ZRvDwhQR17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17043                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043
[Bug 17043] debian/list-deps fixes, master edition
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:44:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:44:57 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-u5qqiEKtFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16588                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588
[Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as
dependencies
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:45:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:45:49 +0000
Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price
	= 0
In-Reply-To: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14535-70-AhYRKfdzzF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:51:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:51:00 +0000
Subject: [Koha-bugs] [Bug 12968] "Lock budget" doesn't seem to work as
	described
In-Reply-To: <bug-12968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12968-70-gMBpXb41O4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12968

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:51:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:51:28 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-jc7CtiaoBf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:51:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:51:30 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-XbAAaLwLBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54064|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54065&action=edit
Bug 17063 - debian/control.in update: change maintainer & add
libhtml-parser-perl for 16.05.x

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

This one is for 16.05.x

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:52:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:52:02 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-FxVPV4A6Ys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:52:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:52:10 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-8fokJYmlij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 11:53:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 09:53:24 +0000
Subject: [Koha-bugs] [Bug 3849] Acq Permissions unclear
In-Reply-To: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-tfyjY6dQoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:00:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:00:16 +0000
Subject: [Koha-bugs] [Bug 6729] block received order lines from editing
In-Reply-To: <bug-6729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6729-70-SorC7zT3tP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #4 from Sandre Cunha <cunha at monterey.org> ---
In addition to errors sometimes you may need to apply a partial refund which
the vendor issues after you have received the item. This is a common occurrence
with Amazon's "lowest price" guarantee.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:01:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:01:05 +0000
Subject: [Koha-bugs] [Bug 13060] number of holds on acq multiplying by
	copies ordered
In-Reply-To: <bug-13060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13060-70-XrgBcsb7PQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13060

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:04:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:04:07 +0000
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions,
 existing suggestions don'  t show after placing a suggestion
In-Reply-To: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16767-70-8GQmknH1bc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:05:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:05:18 +0000
Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq
In-Reply-To: <bug-14081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14081-70-PCfe52eDfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:11:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:11:10 +0000
Subject: [Koha-bugs] [Bug 6819] Don' t offer delete links for received order
 lines on basket summary
In-Reply-To: <bug-6819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6819-70-YZCcBeOtJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:14:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:14:00 +0000
Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across
 different parts of Koha
In-Reply-To: <bug-13944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13944-70-xlL08uYqq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:15:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:15:13 +0000
Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/invoice.pl
In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14850-70-UxJ6OjDaoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:16:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:16:37 +0000
Subject: [Koha-bugs] [Bug 12502] Add a column for note,
 order number ans ISBN in late order page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-MhB2RPAzPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 12:18:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 10:18:52 +0000
Subject: [Koha-bugs] [Bug 9664] additional fees tracking in acquisitions
In-Reply-To: <bug-9664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9664-70-vgy7ODcIvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9664

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:49:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:49:10 +0000
Subject: [Koha-bugs] [Bug 17064] New: Delete backup
	marc21_framework_DEFAULT.sql~ file
Message-ID: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

            Bug ID: 17064
           Summary: Delete backup marc21_framework_DEFAULT.sql~ file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

This .sql~ backup file should not have been committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:49:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:49:23 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-WymBpIT0QD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:50:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:50:31 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-xsqx1uzLDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54066&action=edit
Bug 17064 - Delete backup marc21_framework_DEFAULT.sql~ file

This .sql~ backup file should not have been committed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:50:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:50:41 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-gjLBIOSnZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:54:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:54:50 +0000
Subject: [Koha-bugs] [Bug 17065] New: Rename C4/Auth_cas_servers.yaml.orig
Message-ID: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

            Bug ID: 17065
           Summary: Rename C4/Auth_cas_servers.yaml.orig
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

C4/Auth_cas_servers.yaml.orig gets cleaned away after every package build
because of the .orig extension. This patch moves it.

It is only a sample file, there is no functionality to test. Just verify that
the file is there with the new name after you applied the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 13:55:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 11:55:07 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-69sRkOppH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:43:10 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-6HICgQzrD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:43:12 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-jTEai1TjWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54062|0                           |1
        is obsolete|                            |

--- Comment #2 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 54067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54067&action=edit
Bug 17053 Clearing search term in Reports

If you click the clear button to clear the search term it does take the search
term away. However, the next time you click on "Saved reports" the search term
is still there.

TO TEST:

1. Reports > Use saved
2. Filter on anything (date/author/keyword). Let say "foo" in keyword.
3. Click the Clear link on the Filter form. You can see that "foo" is removed
   from keyword, and all the saved reports are displayed.
4. Click "Saved Reports" on the left. You can see that "foo" reappears in
   keyword filter.
5. Apply the patch, and repeat steps 2-4.

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:44:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:44:56 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-Q7kBHCHXRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

--- Comment #3 from Jesse Maseto <jesse at bywatersolutions.com> ---
Thank you. This patch works perfectly.
-JesseM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:53:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:53:46 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-lcbVwRhI1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #5 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 54068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54068&action=edit
Bug 17004: Add API route to authenticate patron

This patch adds a username/cardnumber and password authentication that returns
a session.

POST /auth/session (login)

Required form data:
- "password"
- either "userid" or "cardnumber".

To test:
1. Make sure you are logged out from Koha.
2. Make a POST request to http://yourlibrary/api/v1/auth/session with form data
   "userid" => <your_user_id> and "password" => <your_password>.
3. If your userid and password is correct, you should be returned with most
   basic patron data and your CGISESSID.
4. Also attempt with invalid login to get an error.
5. Run tests at b/t/db_dependent/api/v1/auth.t

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

Wow, brilliant work! Thanks for that, it works as expected!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:56:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:56:49 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-SgeRaavJvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 14:57:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 12:57:46 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-1JQxPuiQlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54028|0                           |1
        is obsolete|                            |

--- Comment #6 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Comment on attachment 54028
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54028
Bug 17004: Add API route to authenticate patron (CGISESSID)

My Sign-Off failed to mark this attachment Obsolete, so I'm now doing it
manually

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:11:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:11:53 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-9tt5TNvJFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54069&action=edit
Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig

C4/Auth_cas_servers.yaml.orig gets cleaned away after every package build
because
of the .orig extension. This patch moves it.

It is only a sample file, there is no functionality to test. Just verify that
the
file is there with the new name after you applied the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:12:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:12:11 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-vJRRjbaWbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:17:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:17:53 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-ghXyenCYnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:17:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:17:56 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-gVFFiWP02C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54069|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <c.gravely at arts.ac.uk> ---
Created attachment 54070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54070&action=edit
Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig

C4/Auth_cas_servers.yaml.orig gets cleaned away after every package build
because
of the .orig extension. This patch moves it.

It is only a sample file, there is no functionality to test. Just verify that
the
file is there with the new name after you applied the patch.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:27:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:27:33 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-Nv5FVhjElL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:27:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:27:51 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-GG6Jx6cv2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:28:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:28:42 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-gTkmIgvr73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:28:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:28:45 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-WSrkJT5JQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54066|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <c.gravely at arts.ac.uk> ---
Created attachment 54071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54071&action=edit
Bug 17064 - Delete backup marc21_framework_DEFAULT.sql~ file

This .sql~ backup file should not have been committed.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 15:29:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 13:29:16 +0000
Subject: [Koha-bugs] [Bug 17027] control file update for 3.22
In-Reply-To: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17027-70-AUUOgylrz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 16:27:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 14:27:16 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-ZRixUm8xAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 16:27:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 14:27:19 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-CnNXfpzYy6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54055|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <c.gravely at arts.ac.uk> ---
Created attachment 54072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54072&action=edit
Bug 17057 - Remove event attributes from holds template

This patch removes event attributes from the holds template. Events
are defined instead in the JavaScript.

Also changed: Move formatting of hold date to the template; Corrected a
non-functional 'cancel hold' link.

To test apply the patch and:

- Start the process of placing a hold on a single title for a
  patron.
  - Uncheck 'Place a hold on the next available item' and try to
    submit the form without selecting an item. You should be prompted
    to select an item.
- Place a hold on multiple titles at the same time. Confirm that your
  hold is saved correctly.
- View the holds for a title which has multiple holds.
  - Confirm that clicking the "X" image triggers a confirmation. Test
    canceling and confirming.
  - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for
    any hold and confirm that the corresponding 'Clear date' link works
    correctly.
  - Confirm that suspending a hold with and without an expiration date
    works correctly.
- Place an item-level hold.
  - View the holds for that same title.
  - Submit another patron to place a new hold.
  - In the list of items which can be placed on hold, look for the item
    you place on hold previously. There should be a "Cancel hold" link
    in the information column. Confirm that this link correctly triggers
    a confirmation dialog and deletes the hold.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 17:29:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 15:29:43 +0000
Subject: [Koha-bugs] [Bug 17066] New: build-git-snapshot: add basetgz
 parameter and update master version number for 3.22.x
Message-ID: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

            Bug ID: 17066
           Summary: build-git-snapshot: add basetgz parameter and update
                    master version number for 3.22.x
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Needed for nightly oldstable packages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 17:29:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 15:29:58 +0000
Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter
 and update master version number for 3.22.x
In-Reply-To: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17066-70-eg7IC5NeNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17013

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 17:29:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 15:29:58 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-skI4TsK8g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17066

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 17:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 15:30:51 +0000
Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter
 and update master version number for 3.22.x
In-Reply-To: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17066-70-ukSsXpKrP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54073&action=edit
Bug 17066 - build-git-snapshot: add basetgz parameter and update master version
number 3.22

This adds a basetgz parameter to specify a pbuilder image.
I use this to build against different distributions.

This also updates the version number for master builds to 16.06.

Version for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 18:08:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 16:08:33 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-sWdSXbeSDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 18:11:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 16:11:28 +0000
Subject: [Koha-bugs] [Bug 5594] default sort order for items on bib records
In-Reply-To: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5594-70-8W23Tjlrby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 18:30:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 16:30:22 +0000
Subject: [Koha-bugs] [Bug 5594] default sort order for items on bib records
In-Reply-To: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5594-70-mk2YhADZBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594

--- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> ---
This is particularly a problem with serials with a large quantity of items
attached to a single bib record: the default sort is by item type, which isn't
too helpful, but also sorting on almost *any* column results in a pretty random
listing. For instance, sorting on the issues column results in a lexical sort
like this:

v. 1 1999
v. 10 2009
v. 11 2010

etc., the issue strings are ordered lexically. The more appropriate ordering
would be to sort by volume number first and then the issue number. Or?as Nicole
implied in her original comment?add an additional item record field for how
it's to be sorted in the holdings table, so we could at least manually add an
appropriate ordering.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 18:37:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 16:37:09 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-7r9syx1Tra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 19:08:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 17:08:28 +0000
Subject: [Koha-bugs] [Bug 17067] New: Missing field "sms_provider_id" in
	database schema
Message-ID: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

            Bug ID: 17067
           Summary: Missing field "sms_provider_id" in database schema
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: mik at adminkuhn.ch

With https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 the new
field "sms_provider_id" was created in Koha table "borrowers". It is actually
there in Koha 16.05.

But the field is not listed in
http://schema.koha-community.org/tables/borrowers.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 19:39:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 17:39:42 +0000
Subject: [Koha-bugs] [Bug 17068] New: empty list item in opac-reserves.tt
Message-ID: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

            Bug ID: 17068
           Summary: empty list item in opac-reserves.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org

There's an empty <li> in opac-reserves.tt around line 280:

</li>
                                                        [% END # / IF
OpacHoldNotes %]

                                                        <li>
                                                        </li>
                                                        [% IF
bibitemloo.itemholdable %]
                                                            <!-- ITEM HOLDS -->

etc...

I'll add a patch in a bit that just deletes this tag.

Testing plan:

- sign in as user, go to place a hold
- view source on the holds page, find empty <li> in between the "hold notes"
textarea and the <!-- ITEM HOLDS --> comment
- apply patch
- revisit holds page
- no more empty list item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 19:47:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 17:47:13 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-KBxiKAyZqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

--- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> ---
Created attachment 54074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54074&action=edit
patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 19:59:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 17:59:22 +0000
Subject: [Koha-bugs] [Bug 17069] New: Can't creat news patron category on
	the intranet
Message-ID: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

            Bug ID: 17069
           Summary: Can't creat news patron category on the intranet
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cyrille.duverne at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hello,

I get an error as soon as I try to create a new patrons category.
Which is blocking since it's my primary one. 

Page : "/cgi-bin/koha/admin/categories.pl"

Error message : "An error occurred when updating this patron category. Perhaps
it already exists."

Error in MySQL : 

[Sat Aug 06 19:53:54.455457 2016] [cgi:error] [pid 9145] [client
127.0.0.1:41044] AH01215: [Sat Aug  6 19:53:54 2016] categories.pl:
DBD::mysql::st execute failed: Incorrect integer value: '' for column
'dateofbirthrequired' at row 1 [for Statement "UPDATE `categories` SET
`dateofbirthrequired` = ?, `enrolmentfee` = ?, `enrolmentperiod` = ?,
`overduenoticerequired` = ?, `reservefee` = ?, `upperagelimit` = ? WHERE (
`categorycode` = ? )" with ParamValues: 0="", 1="", 2="", 3="0", 4="", 5="",
6="LIBRA"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.:
/usr/share/koha/intranet/cgi-bin/admin/categories.pl,

Looks like some mandatory values aren't passed.

See a working query on the DB : 

INSERT INTO categories
VALUES('LIBRA','Librarians','150','9999/12/31',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,'0',"S","-1","default");

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 19:59:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 17:59:46 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-WlB4Bue1Lj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Cyrille Duverne <cyrille.duverne at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't creat news patron     |Can't create new patron
                   |category on the intranet    |category on the intranet

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:11:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:11:01 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-fMFSDXWNLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
pushed to master - Should be in the November 2016 - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:12:03 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-1ra1Eknbqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
pushed to master - Should be in the November 2016 - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:14:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:14:07 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-5YL1vJr6xA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to master - Should be in the November 2016 - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:15:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:15:44 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-5Yo0PiBPmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #10 from Brendan Gallagher <brendan at bywatersolutions.com> ---
pushed to master - Should be in the November 2016 - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:34:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:34:40 +0000
Subject: [Koha-bugs] [Bug 17070] New: HELPCAREFORAOLmail @@@ 1.800.790.9186
 AOL TECH SUPPORT PHONE NUMBER@@18007909186..............
Message-ID: <bug-17070-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17070

            Bug ID: 17070
           Summary: HELPCAREFORAOLmail @@@ 1.800.790.9186 AOL TECH SUPPORT
                    PHONE NUMBER@@18007909186..............
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jakaijj at yopmail.com
        QA Contact: testopia at bugs.koha-community.org

HELPCAREFORAOLmail @@@ 1.800.790.9186 AOL TECH SUPPORT PHONE
NUMBER@@18007909186..............

HELPCARE FOR AOL @@@ 1.800.790.9186 AOL TECH SUPPORT PHONE
NUMBER@@18007909186..............

 AOL toll free number AOL mail helpline number  Helpline for AOL @@
1.800.790.9186 AOL technical support phone number AOL toll

Helpline for AOL @@ 1.800.790.9186 AOL technical support phone number AOL toll
free number AOL mail helpline number

Helpline for AOL @@ 1.800.790.9186 AOL technical support phone number AOL toll
free number AOL mail helpline number
AOL Phone Number CANADA:1.800.790.9186(Toll-free)
AOL Phone Number USA:1.800.790.9186(Toll-free)
AOL Phone Number USA:1.800.790.9186(Toll-free)

Latest Update AOL 1800 790 9186 AOL 360 support phone numbe

Latest Update AOL 360 1800 790 9186 AOL 360 support phone number
Free~* C at ll 1.800.790.9186 AOL 360 technical support phone number usa
1.800.790.9186 AOL 360 technical support phone number AOL free call

~* C at ll 1.800.790.9186 AOL 360 technical support phone number usa
1.800.790.9186 AOL 360 technical support phone number AOL free call

PHONE support USA @1.800.790.9186 AOL mail technical support phone number
AOL locations
AOL online support
AOL Support phone number 1.800.790.9186
AOL customer care AOL tech support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL locations
AOL Support phone number 1.800.790.9186
service AOL com
AOL login
AOL technical support phone number 1.800.790.9186
AOL customer service
AOL Support phone number 1.800.790.9186
AOL support telephone number 1.800.790.9186
AOL support phone number 1.800.790.9186
AOL mail support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL mail customer service phone number 1.800.790.9186
AOL 360 technical support phone number 1.800.790.9186
symantec technical support phone number 1.800.790.9186
AOL technical support phone number 1.800.790.9186
AOL customer service telephone number 1.800.790.9186
AOL mail phone number 1.800.790.9186
AOL mail customer service phone number 1.800.790.9186
AOL mail customer service Support
AOL mail phone number 1.800.790.9186
AOL phone number 1.800.790.9186 cancel subscription
AOL technical support phone number 1.800.790.9186
AOL 800 phone number 1.800.790.9186
snapdeal toll free customer care number 1.800.790.9186
sbi toll free customer care number 1.800.790.9186
airtel toll free customer care number 1.800.790.9186
AOL customer service number 1.800.790.9186
AOL call center
AOL customer service email address
AOL customer care no
AOL mail technical support phone number 1.800.790.9186
hdfc toll free customer care number 1.800.790.9186
bsnl toll free customer care number 1.800.790.9186
icici toll free customer care number 1.800.790.9186
flipkart toll free customer care number 1.800.790.9186
vodafone toll free customer care number 1.800.790.9186
AOL technical support phone number 1.800.790.9186
AOL technical support number 1.800.790.9186
AOL technical support number 1.800.790.9186
symantec technical support number 1.800.790.9186
AOL mail technical support number 1.800.790.9186
AOL support phone number 1.800.790.9186
AOL locations
AOL customer service
AOL mail customer care__AOL Support phone number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL mail customer support phone number 1.800.790.9186AOL mail customer service
phone number 1.800.790.9186
AOL mail technical support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL mail phone number 1.800.790.9186
AOL security center phone number 1.800.790.9186
AOL support telephone number 1.800.790.9186
AOL 360 technical support phone number 1.800.790.9186
symantec technical support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
apple technical support phone number 1.800.790.9186 usa
microsoft technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186 usa
lenovo technical support phone number 1.800.790.9186 usa
epson technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186
call AOL support
chat with AOL support
AOL customer support
AOL mail customer service number 1.800.790.9186
AOL address
AOL call center
AOL hq
AOL office locations
AOL support site
AOL telephone number 1.800.790.9186 for customer support
AOL customer service contact number 1.800.790.9186
AOL customer care
AOL toll free number 1.800.790.9186
AOL security contact number 1.800.790.9186
contact Vipre
AOL headquarters
AOL customer service chat
AOL customer service telephone number 1.800.790.9186
AOL Support phone number 1.800.790.9186
AOL customer support
AOL customer service refund
AOL login
AOL locations
AOL customer service number 1.800.790.9186 uk
AOL locations
AOL customer service email address
AOL support site
AOL technical support phone number 1.800.790.9186
AOL technical support live chat
AOL technical support email address
AOL technical support number 1.800.790.9186
AOL technical support number 1.800.790.9186
symantec technical support number 1.800.790.9186
AOL mail technical support number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL customer support number 1.800.790.9186
AOL customer support number 1.800.790.9186
AOL mail customer support number 1.800.790.9186
AOL locations
AOL Support phone number 1.800.790.9186
AOL corporate phone number 1.800.790.9186
AOL customer service Support
AOL technical support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
AOL tech support number 1.800.790.9186
AOL tech support number 1.800.790.9186 FREE


AOL,antivirus,technical,support,phone,number,helpline,`,Helpline for AOL @@
1.800.790.9186 AOL technical support phone number AOL toll free number AOL mail
helpline number

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:34:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:34:42 +0000
Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-v09xuJhzt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:34:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:34:45 +0000
Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-xPNkQpfKHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53118|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54075&action=edit
Bug 10148: Marc21 field 007 builder improper reload values

The more correct solution is fix that template file.
However, in the mean time, this works.

TEST PLAN
---------
 1) find a record
 2) edit record
 3) click value builder for 007
 4) change everything to pipes as much as possible.
    (use Motion Picture to get all 00-22 values)
 5) save
    -- should save just fine.
 6) click the value builder again
    -- OOPS! Bad reload.
 7) prove t/db_dependent/FrameworkPlugin.t
    -- NOISY 007 messages.
 8) apply patch
 9) click the value builder again
    -- good reload
10) prove t/db_dependent/FrameworkPlugin.t
    -- No noise related to 007.
11) run koha qa test tools.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:36:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:36:21 +0000
Subject: [Koha-bugs] [Bug 17071] New: contact@@aol@@mail@@@ 1.800.790.9186
 AOL TECHnical SUPPORT PHONE NUMBER@@18007909186..............
Message-ID: <bug-17071-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17071

            Bug ID: 17071
           Summary: contact@@aol@@mail@@@ 1.800.790.9186 AOL TECHnical
                    SUPPORT PHONE NUMBER@@18007909186..............
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jakaijj at yopmail.com
        QA Contact: testopia at bugs.koha-community.org

contact@@aol@@mail@@@ 1.800.790.9186 AOL TECHnical SUPPORT PHONE
NUMBER@@18007909186..............

HELPCARE FOR AOL @@@ 1.800.790.9186 AOL TECH SUPPORT PHONE
NUMBER@@18007909186..............

 AOL toll free number AOL mail helpline number  Helpline for AOL @@
1.800.790.9186 AOL technical support phone number AOL toll

Helpline for AOL @@ 1.800.790.9186 AOL technical support phone number AOL toll
free number AOL mail helpline number

Helpline for AOL @@ 1.800.790.9186 AOL technical support phone number AOL toll
free number AOL mail helpline number
AOL Phone Number CANADA:1.800.790.9186(Toll-free)
AOL Phone Number USA:1.800.790.9186(Toll-free)
AOL Phone Number USA:1.800.790.9186(Toll-free)

Latest Update AOL 1800 790 9186 AOL 360 support phone numbe

Latest Update AOL 360 1800 790 9186 AOL 360 support phone number
Free~* C at ll 1.800.790.9186 AOL 360 technical support phone number usa
1.800.790.9186 AOL 360 technical support phone number AOL free call

~* C at ll 1.800.790.9186 AOL 360 technical support phone number usa
1.800.790.9186 AOL 360 technical support phone number AOL free call

PHONE support USA @1.800.790.9186 AOL mail technical support phone number
AOL locations
AOL online support
AOL Support phone number 1.800.790.9186
AOL customer care AOL tech support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL locations
AOL Support phone number 1.800.790.9186
service AOL com
AOL login
AOL technical support phone number 1.800.790.9186
AOL customer service
AOL Support phone number 1.800.790.9186
AOL support telephone number 1.800.790.9186
AOL support phone number 1.800.790.9186
AOL mail support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL mail customer service phone number 1.800.790.9186
AOL 360 technical support phone number 1.800.790.9186
symantec technical support phone number 1.800.790.9186
AOL technical support phone number 1.800.790.9186
AOL customer service telephone number 1.800.790.9186
AOL mail phone number 1.800.790.9186
AOL mail customer service phone number 1.800.790.9186
AOL mail customer service Support
AOL mail phone number 1.800.790.9186
AOL phone number 1.800.790.9186 cancel subscription
AOL technical support phone number 1.800.790.9186
AOL 800 phone number 1.800.790.9186
snapdeal toll free customer care number 1.800.790.9186
sbi toll free customer care number 1.800.790.9186
airtel toll free customer care number 1.800.790.9186
AOL customer service number 1.800.790.9186
AOL call center
AOL customer service email address
AOL customer care no
AOL mail technical support phone number 1.800.790.9186
hdfc toll free customer care number 1.800.790.9186
bsnl toll free customer care number 1.800.790.9186
icici toll free customer care number 1.800.790.9186
flipkart toll free customer care number 1.800.790.9186
vodafone toll free customer care number 1.800.790.9186
AOL technical support phone number 1.800.790.9186
AOL technical support number 1.800.790.9186
AOL technical support number 1.800.790.9186
symantec technical support number 1.800.790.9186
AOL mail technical support number 1.800.790.9186
AOL support phone number 1.800.790.9186
AOL locations
AOL customer service
AOL mail customer care__AOL Support phone number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL mail customer support phone number 1.800.790.9186AOL mail customer service
phone number 1.800.790.9186
AOL mail technical support phone number 1.800.790.9186
AOL mail tech support phone number 1.800.790.9186
AOL mail phone number 1.800.790.9186
AOL security center phone number 1.800.790.9186
AOL support telephone number 1.800.790.9186
AOL 360 technical support phone number 1.800.790.9186
symantec technical support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
apple technical support phone number 1.800.790.9186 usa
microsoft technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186 usa
lenovo technical support phone number 1.800.790.9186 usa
epson technical support phone number 1.800.790.9186 usa
AOL technical support phone number 1.800.790.9186
call AOL support
chat with AOL support
AOL customer support
AOL mail customer service number 1.800.790.9186
AOL address
AOL call center
AOL hq
AOL office locations
AOL support site
AOL telephone number 1.800.790.9186 for customer support
AOL customer service contact number 1.800.790.9186
AOL customer care
AOL toll free number 1.800.790.9186
AOL security contact number 1.800.790.9186
contact Vipre
AOL headquarters
AOL customer service chat
AOL customer service telephone number 1.800.790.9186
AOL Support phone number 1.800.790.9186
AOL customer support
AOL customer service refund
AOL login
AOL locations
AOL customer service number 1.800.790.9186 uk
AOL locations
AOL customer service email address
AOL support site
AOL technical support phone number 1.800.790.9186
AOL technical support live chat
AOL technical support email address
AOL technical support number 1.800.790.9186
AOL technical support number 1.800.790.9186
symantec technical support number 1.800.790.9186
AOL mail technical support number 1.800.790.9186
AOL customer support phone number 1.800.790.9186
AOL customer support number 1.800.790.9186
AOL customer support number 1.800.790.9186
AOL mail customer support number 1.800.790.9186
AOL locations
AOL Support phone number 1.800.790.9186
AOL corporate phone number 1.800.790.9186
AOL customer service Support
AOL technical support phone number 1.800.790.9186
AOL tech support phone number 1.800.790.9186
AOL tech support number 1.800.790.9186
AOL tech support number 1.800.790.9186 FREE


AOL,antivirus,technical,support,phone,number,helpline,`,Helpline for AOL @@
1.800.790.9186 AOL technical support phone number AOL toll free number AOL mail
helpline number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:37:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:37:27 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-OCKNztpY3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:38:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:38:11 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-vPcrDrEhnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:39:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:39:19 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-yCdOOstWMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:55:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:55:10 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-ndp3rrZr47@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:55:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:55:12 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-avL7ANVrWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54076&action=edit
Bug 17068 - Empty li in holds request page

To test:
PLace ahold via the opadc with notes enables
Notice an empty li in the source
Applypatch
No kore emtpy li

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:56:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:56:29 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-39ykOoae9X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
  Attachment #54074|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:56:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:56:42 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-HP4FQkuDlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54076|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 20:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 18:56:54 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-VfNKP40vOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:00:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:00:08 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-IsfsYWWKoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:00:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:00:11 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-kfy3tXHFDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53814|0                           |1
        is obsolete|                            |

--- Comment #2 from Jason Robb <jrobb at sekls.org> ---
Created attachment 54077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54077&action=edit
Bug 17001: fix due date filter on the overdue report

When the TimeFormat system preference is set to "12 hour",
setting a filter on the due date can result in:

- no overdue loans being reported, even if there are some
  that meet the criteria

OR

- overdue loans being omitted from the report if they
  are due on the "until" date in the filter

This patch fixes this by replacing output_pref() with
DateTime::Format::MySQL to format the date filter values
to pass to the SQL query.

To test
-------
[1] Run the overdue report (circ/overdue.pl) and set a filter
    on due date, using values that should bring up one or
    more overdue loans.
[2] Note that zero overdue loans are returned (if using MySQL
    5.5, 5.6, or 5.7 or MariaDB 5) or that loans due on the
    "until" date are omitted (if using MarioDB 10).
[3] Apply the patch and repeat step 1. This time, the correct
    set of overdue loans should be reported.

Signed-off-by: Galen Charlton <gmcharlt at gmail.com>

Signed-off-by: Your Name <jrobb at sekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:17:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:17:35 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-h8zPum4zya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

--- Comment #3 from Eric Phetteplace <ephetteplace at cca.edu> ---
Created attachment 54078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54078&action=edit
fixed patch

patch with appropriate headers, should work with git-bz now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:30:51 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-4UE9GlYinp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

--- Comment #11 from Bob Birchall <bob at calyx.net.au> ---
(In reply to Kyle M Hall from comment #7)
> Created attachment 53920 [details] [review]
> Bug 16960 - Patron::Modifications should be fixed
> 
> The changes from opac-memberentry do not reach the table, since the
> Patron::Modifications object does not work well.
> 
> Test Plan:
> 1) Apply this patch
> 2) Create some patron modification requests
> 3) Ensure you can approve and deny modifications
> 4) Ensure patron self registration works

I wasn't completely sure what the test plan was asking for.  This is what I
did:
- logged in to OPAC and changed some personal details;
- logged in to staff client and accepted the changes; on searching for the
patron the changes are present;
- enabled self registration and registered in OPAC as a new patron; logged in
as that patron OK; checked in staff - all details present;
- logged in to OPAC again, made more changes to Personal Details; returned to
Staff client and Denied those changes - on searching none of the data is
amended.  OK.

I'll sign off on this.  I'm having an issue with git so but will get some help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:50:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:50:42 +0000
Subject: [Koha-bugs] [Bug 17070] SPAM
In-Reply-To: <bug-17070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17070-70-wWKkA8ivnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|HELPCAREFORAOLmail @@@      |SPAM
                   |1.800.790.9186 AOL TECH     |
                   |SUPPORT PHONE               |
                   |NUMBER@@18007909186........ |
                   |......                      |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 21:51:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 19:51:06 +0000
Subject: [Koha-bugs] [Bug 17071] SPAM
In-Reply-To: <bug-17071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17071-70-ZeVQn1x49W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17071

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|contact@@aol@@mail@@@       |SPAM
                   |1.800.790.9186 AOL          |
                   |TECHnical SUPPORT PHONE     |
                   |NUMBER@@18007909186........ |
                   |......                      |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:17:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:17:14 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-bsY31TZ2KL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #5 from Sandre Cunha <cunha at monterey.org> ---
I d't understand why this is under Acquisitions. Shouldn't it be under Patrons
or circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:18:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:18:20 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-DpssDtMC5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Acquisitions                |Architecture, internals,
                   |                            |and plumbing

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it was a mistake - well spotted!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:26:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:26:50 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-egjcLETqHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
Yes,it doesn't happen very often, but if the invoice number is incorrect, it
will be difficult to locate later, if needed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:30:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:30:22 +0000
Subject: [Koha-bugs] [Bug 7039] Link to existing record from result list in
 acquisition search
In-Reply-To: <bug-7039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7039-70-xf8MnB8jst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
I agree; that would be even more useful than being able to view the MARC
record.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:36:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:36:59 +0000
Subject: [Koha-bugs] [Bug 7039] Link to existing record from result list in
 acquisition search
In-Reply-To: <bug-7039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7039-70-DWPQBV8Yfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:53:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:53:59 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-BlCuTlJnNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |cunha at monterey.org

--- Comment #2 from Sandre Cunha <cunha at monterey.org> ---
Not only do we need to be alerted to the hold, but we need to be able to cancel
the hold from the same screen or from a link on that screen, and give the
patron a reason for cancelling (e.g., the publisher has cancelled the product,
the publication date has been extended to next year, the item is out of print
or no longer available, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 22:54:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 20:54:28 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-GpDEzQQpXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:06:35 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-rR6lX8jfRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |cunha at monterey.org
           Priority|P5 - low                    |P1 - high

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
This is a critical issue for any library with a trust account. Additions to the
budget may be made at any time, or funds may be transferred from one fund code
to another. These changes need to be documented and currently the only way to
do so is by capturing screen prints before and after, plus extensive use of
notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:08:05 +0000
Subject: [Koha-bugs] [Bug 16722] Display internal note for late orders
In-Reply-To: <bug-16722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16722-70-8tNYMkDRwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16722

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
           Priority|P5 - low                    |P3
                 CC|                            |cunha at monterey.org

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
This would also be useful if you track pre-publication orders via the notes
field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:14:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:14:26 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-XIISZlp1wJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:14:29 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-mZ8Y8CGce6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53920|0                           |1
        is obsolete|                            |

--- Comment #12 from Bob Birchall <bob at calyx.net.au> ---
Created attachment 54079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54079&action=edit
Bug 16960 - Patron::Modifications should be fixed

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Test Plan:
1) Apply this patch
2) Create some patron modification requests
3) Ensure you can approve and deny modifications
4) Ensure patron self registration works

Signed-off-by: Bob Birchall <bob at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:14:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:14:55 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-8B2ckv4xfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54027|0                           |1
        is obsolete|                            |

--- Comment #13 from Bob Birchall <bob at calyx.net.au> ---
Created attachment 54080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54080&action=edit
Bug 16960: Update 1 missing occurrence of GetModifications

Signed-off-by: Bob Birchall <bob at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:24:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:24:47 +0000
Subject: [Koha-bugs] [Bug 9851] way to get full records for purchase
	suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-hW0hchcUj0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |cunha at monterey.org
           Priority|P5 - low                    |P2

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
This is the very reason we do not order directly from purchase suggestions.
Perhaps if there were an option to link from the suggestion to the MARC/order
after it is downloaded(similar to the way an order is placed on an existing bib
record?) or via a duplicate search when the download is staged?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:29:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:29:07 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-PbXH66uHRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:29:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:29:29 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-PDQJxvPPnE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug  6 23:29:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 21:29:31 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-cbbM0HjmYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54078|0                           |1
        is obsolete|                            |

--- Comment #4 from Jason Robb <jrobb at sekls.org> ---
Created attachment 54081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54081&action=edit
Bug 17068: empty <li> in opac-reserve.tt

empty HTML list item on 'holds' page, to test:
- sign in as user
- attempt to place hold
- view source in between 'holds note' textarea & <!-- ITEM HOLDS --> comment
- note empty <li>
- apply patch
- repeat process above up until patch
- no more empty <li>

Signed-off-by: Jason Robb <jrobb at sekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:19:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:19:02 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-39aF7lYlWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Irma Birchall <irma at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irma at calyx.net.au

--- Comment #3 from Irma Birchall <irma at calyx.net.au> ---
(In reply to Jonathan Druart from comment #2)
> Created attachment 53875 [details] [review]
> Bug 17009: Speed up the framework duplication
> 
> To duplicate frameworks, the code retrieve all the subfields, then
> execute 1 insert per subfield.
> It's unnecessary slow, we can use the DBMS to do it.
> 
> Test plan:
> Create a new framework and duplicate the structure of another framework.

I applied the dependency 16995 then tried to apply this patch, it did not
apply. 

Message: 
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16995 - Remove event attributes from two include files
tester at debian:~/kohaclone$ git bz apply 17009
Bug 17009 - Duplicating frameworks is unnecessary slow

53875 - Bug 17009: Speed up the framework duplication

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17009: Speed up the framework duplication
fatal: sha1 information is lacking or useless (admin/marctagstructure.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17009: Speed up the framework duplication
The copy of the patch that failed is found in:
   /home/tester/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-17009-Speed-up-the-framework-duplication-FRLPWa.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:19:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:19:18 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-M6Ut8CVS0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Irma Birchall <irma at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irma at calyx.net.au
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:34:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:34:51 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-ofJxv1ScE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:34:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:34:53 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-g77E17Azbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54081|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54082&action=edit
Bug 17068: empty <li> in opac-reserve.tt

empty HTML list item on 'holds' page, to test:
- sign in as user
- attempt to place hold
- view source in between 'holds note' textarea & <!-- ITEM HOLDS --> comment
- note empty <li>
- apply patch
- repeat process above up until patch
- no more empty <li>

Signed-off-by: Jason Robb <jrobb at sekls.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:45:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:45:13 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-D1OL6tTc83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

barbara.johnson at bedfordtx.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:45:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:45:16 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-H0fpmFCRj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

barbara.johnson at bedfordtx.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54020|0                           |1
        is obsolete|                            |

--- Comment #39 from barbara.johnson at bedfordtx.gov ---
Created attachment 54083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54083&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC

This patch adds a configuration option which allows to define which
fields should be mandatory for a patron purchase suggestion form in OPAC.

Test plan:

1/ Apply patch.
2/ Play with the new OPACSuggestionMandatoryFields system preference
(select some fields as manadatory, select all, deselect all, try to
submit some suggestions with mandatory fields filled and/or not
filled etc.) to ensure that required fields (and only required fields)
are enforced in the browser to be filled.
3/ With all options deselected, 'Title' field should still be
mandatory (by default).

Signed-off-by: barbara johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:45:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:45:30 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-2g4izKSDgS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

barbara.johnson at bedfordtx.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54021|0                           |1
        is obsolete|                            |

--- Comment #40 from barbara.johnson at bedfordtx.gov ---
Created attachment 54084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54084&action=edit
Bug 10848 - Allow configuration of mandatory/required fields on the suggestion
form in OPAC - part 2

Add 'OPACSuggestionMandatoryFields' syspref definition plus
an atomic DB update for the new preference.

Signed-off-by: barbara johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:46:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:46:43 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-K4BiWO2Lvo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Brendon Ford <brendon.ford at manhattan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 00:46:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 22:46:45 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-DDEfyla6Sl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Brendon Ford <brendon.ford at manhattan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52774|0                           |1
        is obsolete|                            |

--- Comment #2 from Brendon Ford <brendon.ford at manhattan.edu> ---
Created attachment 54085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54085&action=edit
Bug 16806: no error message for 'too_soon' renewal

To test:
-  for a particular item type & patron category, configure a non-zero
"no renewal before" date so items can't be immediately renewed
- sign in as a patron in aforementioned patron category
- check out an item of aforementioned item type
- go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl
- an error messages appears in the div.alert.dialog up top

Sponsored-by: California College of the Arts
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 01:12:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 23:12:17 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-j7v7ZuywjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 01:12:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 23:12:20 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-LQ0PvkE4kG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53874|0                           |1
        is obsolete|                            |

--- Comment #10 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 54086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54086&action=edit
Bug 16955: Do not clear from cache when adding a new framework

There are several issues with these lines:
1/ $cache is not defined correctly and it not visible inside
duplicate_framework
2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode
3/ these calls are not needed. As we are creating a new framework, the cache
should be empty...

This patch will simply remove these calls

Test plan:
Duplicate a framework and confirm that you do not get any error in your
logs.

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 01:13:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 06 Aug 2016 23:13:25 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-Ydcu3b6fML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Irma Birchall <irma at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54085|0                           |1
        is obsolete|                            |

--- Comment #3 from Irma Birchall <irma at calyx.net.au> ---
Created attachment 54087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54087&action=edit
Bug 16806: no error message for 'too_soon' renewal

To test:
-  for a particular item type & patron category, configure a non-zero
"no renewal before" date so items can't be immediately renewed
- sign in as a patron in aforementioned patron category
- check out an item of aforementioned item type
- go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl
- an error messages appears in the div.alert.dialog up top

Sponsored-by: California College of the Arts
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

Signed-off-by: Irma Birchall <irma at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 04:46:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 02:46:13 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-JYY8FtFfMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release!  Thanks and welcome
to the community Eric!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 07:48:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 05:48:24 +0000
Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to
 additem.pl causes software error
In-Reply-To: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16750-70-WKbC6T6m7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #13 from Christopher Brannon <cbrannon at cdalibrary.org> ---
This looks like it is in discussion and not ready for sign off.  Please correct
the status change if I am incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:15:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:15:33 +0000
Subject: [Koha-bugs] [Bug 9851] way to get full records for purchase
	suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-luym3CtK9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sandre - thx for your comments! If you don't order from suggestions the
'ordered' and 'available' status can not be reached for the suggestion. Could
it be a workaround to overlay the record with z39.50 after creating the order
line?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:20:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:20:13 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
 circulation screen
In-Reply-To: <bug-14803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14803-70-tGltwK9Qo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org
             Status|Needs Signoff               |Failed QA

--- Comment #16 from Christopher Brannon <cbrannon at cdalibrary.org> ---
>From what I can tell, when the patches are applied, it breaks the form
#mainform, and is not displayed.  Cannot follow test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:22:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:22:36 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-6yxkmDnFRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:26:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:26:58 +0000
Subject: [Koha-bugs] [Bug 17042] Fix missing properties in Swagger
	definition for Hold
In-Reply-To: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17042-70-ELik4N42CV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:34:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:34:27 +0000
Subject: [Koha-bugs] [Bug 17041] Fix missing properties in Swagger
	definition for Patron
In-Reply-To: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17041-70-cPGO0DlE7I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
checkprevcheckout appears in master, and so isn't available in 16.05. If you
want this patch in 16.05, please provide a new patch adding just only
updated_on property.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:37:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:37:00 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-Cjp5lVv9XV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #14 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:38:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:38:02 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-hpbcYS6Evt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |Pushed to Master

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 09:40:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 07:40:43 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-QGwTIIRkOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:22:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:22:44 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-Ks1DmpXLkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #109 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54088&action=edit
[PASSED QA] Bug 6934: New report Cash Register Statistics

This patch creates a new report that outputs cash register stats for a specific
period.

Changes:

koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc               - Added
cash register report link
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt  - new
file
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt         - Added
cash register report link
reports/cash-register_stats.pl                                          - new
file

Testing:

I Apply the patch

0) Go to reports home page (Home ? Reports);
1) Validate link << Cash Register >> under Statistics wizards;
2) Click link;
3) Validate page with three fieldsets;
4) Chose a date interval, a transaction type, a library and an output;
5) Validade the result.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:22:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:22:50 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-RxcmAJbHkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #110 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54089&action=edit
[PASSED QA] Bug 6934: Fix code in CashRegisterStats (dataTables pagination,
more accurate descriptions, add a delimiter pull down, change C4::Dates to
Koha::DateUtils)

I cleaned up the code according to comment #23. I got rid of
DHTMLcalendar_dateformat,
beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated,
Koha::DateUtils is now used.
Some column names are changed and the pagination for the dataTables is fixed.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:22:55 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-Aog8Ss8Z03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #111 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54090&action=edit
[PASSED QA] Bug 6934: New features, note added to transaction information,
total caculated for negative types of transaction

To be more specific, the column note from accountlines is now displayed in the
table of the transactions.
The grand total is now calculated for neagtive types like Credit or Payment and
isn't counted for Write off types.
Credit (return item) 'CR' has been added to drop down of transaction type

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:00 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-jVFidbBncj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #112 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54091&action=edit
[PASSED QA] Bug 6934: QA Follow-up

Tried to address every single thing that QA mentioned :
1)Removed isNull function
2)Changed datepicker properly
3)We have to fill in two dates not to be flooded with old entries if we don't
want to.
4)The first two fieldsets are now in one bigger field set
5)Removed the use of $fullreportname variable
6)Removed the use of dt_from_string when it already recieved a DT.
7)Removed comments starting with "###" in cash_register_stats.pl
8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as
an example)
9)I am not sure if using C4::Reports::Guided is the right choice here. I
instead used the same column names as the one recieved by the query in
cash_register_stats because this report uses columns from 5 different tables in
addition of using both firstname and surname twice.

For the ninth point, I would like to know more about C4::Reports::Guided if you
still think using it would be a better solution. Thank you!

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:05 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-MKkhTDwXbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54092&action=edit
[PASSED QA] Bug 6934: Fixed Calendar and removed used of unexisting and unused
C4::Budgets getCurrency

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:10 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-XxfIkdNNlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #114 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54093&action=edit
[PASSED QA] Bug 6934: second fix to calendars

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:15 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-vwzt9Q2QVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #115 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54094&action=edit
[PASSED QA] Bug 6934: fixed encoding issue

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Encoding issue fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:19 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-SlNED1PQ9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #116 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54095&action=edit
[PASSED QA] Bug 6934: QA follow-up

- fixed tabs
- fixed capitalization on reports start page

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:24 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-0UwBo5NGO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54096&action=edit
[PASSED QA] Bug 6934: fix problem when export it open in LibreOffice - show
values of itype and use TT plugin

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:29 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-BxMcxLIOrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54097&action=edit
[PASSED QA] Bug 6934: Make CSV header column translatable and add total amounts
in csv file

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:34 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-JMHbOBmRDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #119 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54098&action=edit
[PASSED QA] Bug 6934: Fix the href for datables in link rel stylesheet

Fix the new path for 'datatables.css'

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:39 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-ZuEu1Q75J5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54099&action=edit
[PASSED QA] Bug 6934: fix errors pointed out by the QA script

Also fix forbidden patterns in
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:23:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:23:43 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-W4rpIBW26c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54100&action=edit
[PASSED QA] Bug 6934: rename active transaction with All payments to the
library and grouping in it the relevant account types 'Pay' 'C'

    rename Patron carnumber on Patron card number
    fix src databales.js

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:25:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:25:26 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-UnVUOg81v3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:34:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:34:49 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-2sxV7fgZZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We got MARC21 and UNIMARC - but we are missing NORMARC still.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:51:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:51:21 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-9cxCaQLs09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52810|0                           |1
        is obsolete|                            |
  Attachment #54058|0                           |1
        is obsolete|                            |

--- Comment #85 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54101&action=edit
[PASSED QA] Bug 7441 - search results showing wrong branch?

When you search in the OPAC it shows you the HOME branch on the location
in XSLT, but if you click through to the detail page it shows you the
CURRENT BRANCH in the holdings table which is very confusing to patrons.
I don't know what's the right solution - home or holding branch, but they
should be the same in both places for the patron's sake. If you do the same
search in the staff client you see the right branch info on the search results
and on the detail page.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Search the catalog, you search should include results with items
   that have different home and holding libraries.
4) The results should look the same as before the patch
5) Change the system preference OPACResultsLibrary to "current location"
6) Refresh your page of search results
7) The results show now show the holding library instead of the home library

Signed-off-by: Barbara Walters <bwalters at ncrl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:52:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:52:00 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-v4I0pNXabg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #86 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54102&action=edit
[PASSED QA] Bug 7441 - Followup search results showing wrong branch [UNIMARC]

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Playing with OPACResultsLibrary syspref, biblio with items having different
  home/holding library are displayed properly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 10:54:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 08:54:39 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-arBJmFGlEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #87 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This shouldn't break things for NORMARC, but I'd like Magnus to take a look. We
should support NORMARC or note that we don't (I'd prefer the former).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:11:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:11:48 +0000
Subject: [Koha-bugs] [Bug 17072] New: 007 not filling in with existing values
Message-ID: <bug-17072-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

            Bug ID: 17072
           Summary: 007 not filling in with existing values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Moved out from bug 10148:

When you use the 006 builder to view the existing values in the 006 tag, Koha
is not pulling these existing values into the builder window. Instead, Koha
appears to be using defaults.

For example:

1. Open a record in the editor
2. Switch from BKS to another material type.
3. Change as many settings as possible.
4. Close plugin.
5. Reopen plugin - notice your selections are not shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:12:25 +0000
Subject: [Koha-bugs] [Bug 10148] 007 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-7WXEeTRXoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|007/006 not filling in with |007 not filling in with
                   |existing values             |existing values
           Severity|normal                      |major
             Status|Signed Off                  |Passed QA
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17072

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is a bad bug in my eyes as it's easy to lose data this way. Patch fixes
007, we still need a fix for 006. 
I am splitting 006 out into a separate bug 17072 so this one can move on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:12:25 +0000
Subject: [Koha-bugs] [Bug 17072] 007 not filling in with existing values
In-Reply-To: <bug-17072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17072-70-mfMIN0TLkB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10148

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:15:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:15:35 +0000
Subject: [Koha-bugs] [Bug 10148] 007 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-frXInBwpf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54075|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54103&action=edit
[PASSED QA] Bug 10148: Marc21 field 007 builder improper reload values

The more correct solution is fix that template file.
However, in the mean time, this works.

TEST PLAN
---------
 1) find a record
 2) edit record
 3) click value builder for 007
 4) change everything to pipes as much as possible.
    (use Motion Picture to get all 00-22 values)
 5) save
    -- should save just fine.
 6) click the value builder again
    -- OOPS! Bad reload.
 7) prove t/db_dependent/FrameworkPlugin.t
    -- NOISY 007 messages.
 8) apply patch
 9) click the value builder again
    -- good reload
10) prove t/db_dependent/FrameworkPlugin.t
    -- No noise related to 007.
11) run koha qa test tools.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:21:39 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-OS5DOK1ca6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:21:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:21:42 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-0Ksx3S5831@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54061|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54104&action=edit
[PASSED QA] Bug 17052: Display patron category description in the sidebar of
paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:28:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:28:13 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-emCt5VYudz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:28:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:28:16 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-8ATJI3vxff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53987|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54105&action=edit
[PASSED QA] Bug 17040: Fix translation on context menu when editing items

Test plan:
update and install translated language files
On the item list (cataloguing/additem.pl) the context menu should be
translated (Edit item/Delete item)

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:36:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:36:24 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-WjO0LcH0gz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:36:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:36:26 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-dZitZqsqc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54070|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54106&action=edit
[PASSED QA] Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig

C4/Auth_cas_servers.yaml.orig gets cleaned away after every package build
because
of the .orig extension. This patch moves it.

It is only a sample file, there is no functionality to test. Just verify that
the
file is there with the new name after you applied the patch.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:39:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:39:06 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-Ys80mlzCOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:39:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:39:12 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-66vtmrr3YF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54071|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54107&action=edit
[PASSED QA] Bug 17064 - Delete backup marc21_framework_DEFAULT.sql~ file

This .sql~ backup file should not have been committed.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:42:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:42:52 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-3U60mp9s7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:42:55 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-5kjDKY57z9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54047|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54108&action=edit
[PASSED QA] Bug 17055 - Add classes to different note types to allow for
styling on checkins page

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to
distinguish which type we are seeing. It would be good to add classes
for each of these note types.

Test Plan:
1) Check out an item to a patron
2) Add a patron note, a public item note, and a non-public item note
   to the patron and item you used
3) Check in the item and instead the html, note the each note span
   now has a class to distinguish which type of note is being displayed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:48:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:48:45 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-YhRsrnMGme@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:48:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:48:48 +0000
Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template
In-Reply-To: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17057-70-JOAdNP8qSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54072|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54109&action=edit
[PASSED QA] Bug 17057 - Remove event attributes from holds template

This patch removes event attributes from the holds template. Events
are defined instead in the JavaScript.

Also changed: Move formatting of hold date to the template; Corrected a
non-functional 'cancel hold' link.

To test apply the patch and:

- Start the process of placing a hold on a single title for a
  patron.
  - Uncheck 'Place a hold on the next available item' and try to
    submit the form without selecting an item. You should be prompted
    to select an item.
- Place a hold on multiple titles at the same time. Confirm that your
  hold is saved correctly.
- View the holds for a title which has multiple holds.
  - Confirm that clicking the "X" image triggers a confirmation. Test
    canceling and confirming.
  - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for
    any hold and confirm that the corresponding 'Clear date' link works
    correctly.
  - Confirm that suspending a hold with and without an expiration date
    works correctly.
- Place an item-level hold.
  - View the holds for that same title.
  - Submit another patron to place a new hold.
  - In the list of items which can be placed on hold, look for the item
    you place on hold previously. There should be a "Cancel hold" link
    in the information column. Confirm that this link correctly triggers
    a confirmation dialog and deletes the hold.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:53:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:53:38 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-w5XevX5TBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 11:53:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 09:53:41 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-VgKKtcRFgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53994|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54110&action=edit
[PASSED QA] Bug 17020: Do no pass findborrower to the template

Indeed, it's not used!

Test plan:
  git grep '\[% findborrower'
should not return any result.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 12:23:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 10:23:28 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-edthZjqNYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Works ok, but I assume the warns should not be there?

+    use Data::Dumper;warn Dumper $borrower;
+    %borrower = ( %$borrower, %borrower );
+    use Data::Dumper;warn Dumper \%borrower;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 12:34:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 10:34:56 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-cAy4jE4t2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
We can confirm this issue.

Noticed that syspref setting CheckPrevCheckout needed to be set to 'softyes' or
'softno'. Then the setting 'Check for previous checkouts' turned up when
creating a new patron category, and saving now succeeded.

/cgi-bin/koha/admin/categories.pl seems to need an upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:12:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:12:23 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-ufkmAoHJf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this improves the situation, but there is still a problem with patron
self registration:

1) Ensure email verification is mandatory
2) Register a new patron from the OPAC
3) Copy the URL (token now is back!) from the message_queue entry 
4) Open the page, receive error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'address' cannot be null at
/home/katrin/kohaclone/C4/Members.pm line 696

I had filled out surname, firstname and email - the address fields were left
empty, but were also not set to be mandatory.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:18:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:18:12 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-7bTRr1dQZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:18:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:18:15 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-DA4RSW3EpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53993|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54115&action=edit
[PASSED QA] Bug 16894: Regression - Display email on patron search results

Bug 10318 added the email to the patron search results but it has been
removed later.
This patch reintroduced it where it was (no new column).

Test plan:
Search for patrons and confirm that the emails are displayed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:24:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:24:11 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-7voLoh0OSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:24:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:24:14 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-RwvD2JpPgF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54087|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54116&action=edit
[PASSED QA] Bug 16806: no error message for 'too_soon' renewal

To test:
-  for a particular item type & patron category, configure a non-zero
"no renewal before" date so items can't be immediately renewed
- sign in as a patron in aforementioned patron category
- check out an item of aforementioned item type
- go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl
- an error messages appears in the div.alert.dialog up top

Sponsored-by: California College of the Arts
Signed-off-by: Brendon Ford <brendon.ford at manhattan.edu>

Signed-off-by: Irma Birchall <irma at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:24:54 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-TjUIDsnYbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Eric, Brendon and Irma!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:35:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:35:09 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-yfcIOIRBld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:35:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:35:12 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-THEwBFVBNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53704|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54117&action=edit
[PASSED QA] Bug 16776: Do not forget external language choice in language
switcher

If language is set by external link language switcher does not work

To reproduce:

- Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT
- Create external links e.g. from your multilingual library website to each
language variant of OPAC:

...cgi-bin/koha/opac-main.pl?language=en
...cgi-bin/koha/opac-main.pl?language=de-CH
...cgi-bin/koha/opac-main.pl?language=fr-FR
...cgi-bin/koha/opac-main.pl?language=it-IT

Each link opens fine displaying the language as appropriate.

Now try to switch language on the page you just opened via the external link.

It won't work, it will always stay on the language defined by the external
link.

To test:
- Apply patch
- Repeat steps above
- Verify that the language switcher works
- Verify in browser address field that after switching language, the param
'language= 'has vanished from url string
- Try links with multiple params and with params containing 'language', e.g.
  ...cgi-bin/koha/opac-search.pl?language=fr-FR&q=language&mylanguage=test
- Verify that only the parameter 'language=' vanishes

Tested counter patch, works as well.
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:41:34 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-WXPoBbgCRa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:41:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:41:37 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-IXLx90buXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54067|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54118&action=edit
[PASSED QA] Bug 17053 Clearing search term in Reports

If you click the clear button to clear the search term it does take the search
term away. However, the next time you click on "Saved reports" the search term
is still there.

TO TEST:

1. Reports > Use saved
2. Filter on anything (date/author/keyword). Let say "foo" in keyword.
3. Click the Clear link on the Filter form. You can see that "foo" is removed
   from keyword, and all the saved reports are displayed.
4. Click "Saved Reports" on the left. You can see that "foo" reappears in
   keyword filter.
5. Apply the patch, and repeat steps 2-4.

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:54:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:54:24 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-zA7Qh8fQBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54119&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:55:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:55:28 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-7DUgYapfB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:55:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:55:31 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-eb14AWlTAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54077|0                           |1
        is obsolete|                            |
  Attachment #54119|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54120&action=edit
[PASSED QA] Bug 17001: fix due date filter on the overdue report

When the TimeFormat system preference is set to "12 hour",
setting a filter on the due date can result in:

- no overdue loans being reported, even if there are some
  that meet the criteria

OR

- overdue loans being omitted from the report if they
  are due on the "until" date in the filter

This patch fixes this by replacing output_pref() with
DateTime::Format::MySQL to format the date filter values
to pass to the SQL query.

To test
-------
[1] Run the overdue report (circ/overdue.pl) and set a filter
    on due date, using values that should bring up one or
    more overdue loans.
[2] Note that zero overdue loans are returned (if using MySQL
    5.5, 5.6, or 5.7 or MariaDB 5) or that loans due on the
    "until" date are omitted (if using MarioDB 10).
[3] Apply the patch and repeat step 1. This time, the correct
    set of overdue loans should be reported.

Signed-off-by: Galen Charlton <gmcharlt at gmail.com>

Signed-off-by: Jason Robb <jrobb at sekls.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 13:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 11:57:19 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-H4XqOHSHr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jason, fixed your sign-off line to have your name - you might want to fix
your git config :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:03:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:03:09 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-Rc3Iw6Vfpb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:03:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:03:12 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-Sjqqiep2se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53120|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54121&action=edit
[PASSED QA] Bug 16848: Prevent invalid warning to be carped from output_pref

>From Koha::DateUtils::output_pref:

   $dt = eval { dt_from_string( $str ) } if $str;
   carp "Invalid date '$str' passed to output_pref\n" if $@;

This second line is wrong: if $str does not exist, the first line is not
evaluated and $@ could be filled with previous error.

To reproduce:

Then:
  prove t/DateUtils.t
will display:
t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or
string at Koha/DateUtils.pm line 217.
Invalid date '' passed to output_pref
 at t/DateUtils.t line 233.
t/DateUtils.t .. ok
All tests successful.
Files=1, Tests=60,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.40 cusr  0.00
csys =  1.42 CPU)
Result: PASS

Test plan:
Without this patch, you should not see the carp

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:47:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:47:26 +0000
Subject: [Koha-bugs] [Bug 7234] koha-common Debian package should include
	koha-sites.conf
In-Reply-To: <bug-7234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7234-70-1FX0TG0sY5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7234

shukur <shukor2006 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shukor2006 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:51:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:51:08 +0000
Subject: [Koha-bugs] [Bug 17073] New: koha
Message-ID: <bug-17073-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17073

            Bug ID: 17073
           Summary: koha
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: shukor2006 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:53:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:53:20 +0000
Subject: [Koha-bugs] [Bug 17073] koha
In-Reply-To: <bug-17073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17073-70-WnY2EbyV3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17073

shukur <shukor2006 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |almutanabi.csh.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 14:55:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 12:55:32 +0000
Subject: [Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface
In-Reply-To: <bug-5362-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5362-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5362-70-8C1mKNgZ5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362

shukur <shukor2006 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shukor2006 at gmail.com
           Hardware|All                         |PC
            Version|master                      |3.22
                 OS|All                         |Linux

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 15:06:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 13:06:12 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-fypa2xSMPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Variant III by native speaker ;)

Marc, can you please adapt and resubmit? 
I have checked the patch itself - it works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 15:34:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 13:34:34 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-XidS7ajKyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems to work well, but I'd like to address Owen's comment#38

The visibility of the library selection depends on
AllowPurchaseSuggestionBranchChoice. It could be included in the mandatory
list, maybe with a note about the dependency on the other pref in the text?

I think it would be nice if the error messages were a bit more standard. If you
are missing multiple fields, only the first will be highlighted. If I enter a
wrong format into the year field, it says 'Please use the specified format'
(translated from German), but gives no clue about the format. 
Would this be improved by Owen's suggestion of using the existing JS validation
plugin?

Jacek, could you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 16:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 14:01:49 +0000
Subject: [Koha-bugs] [Bug 17074] New: Fix links in result list of 'scan
 indexes' search and keep search term
Message-ID: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

            Bug ID: 17074
           Summary: Fix links in result list of 'scan indexes' search and
                    keep search term
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The 'scan indexes' search that can be reached from the advanced search has 2
problems to begin with:

- The search term you searched for is not displayed in the input field.
- The links in the result list are missing the index and because of that, are
not giving the correct results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 16:01:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 14:01:59 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-SzfPWZHsU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 16:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 14:07:16 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-4hzMhkmxDI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 16:07:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 14:07:18 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-qSH7aqjEcZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54123&action=edit
Bug 17074: Fix links in result list of 'scan indexes' and keep search term
visible

The 'scan indexes' search that can be reached from the
advanced search has 2 problems to begin with:

- The search term you searched for is not displayed
  in the input field.
- The links in the result list are missing the index
  and because of that, are not giving the correct results.

To test:
- Go to the advanced search, select an index to search in
- Enter a search term and check 'scan indexes'
- Submit search
- Check if the search term is visible in the input box
- Check if the result links contain your selected index
  and give you correct results (count and the number of
  results should match)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 17:19:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 15:19:44 +0000
Subject: [Koha-bugs] [Bug 16809] Silence authority warnings
 C4::Biblio::TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-k2GJGi1Fsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
mtompset at debian:~/kohaclone$ echo > ~/koha-dev/var/log/koha-error_log
mtompset at debian:~/kohaclone$ cat ~/koha-dev/var/log/koha-error_log | cut -f12-
-d" " | sort -u

[Sun Aug  7 10:40:24 2016] authorities.pl: CGI::param called in list context
from package C4::Biblio line 2580, this can lead to vulnerabilities. See the
warning in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer:
http://library-admin.debiankoha.ca/cgi-bin/koha/authorities/authorities.pl?breedingid=115&authtypecode=PERSO_NAME&authid=0
[Sun Aug  7 10:40:24 2016] authorities.pl: CGI::param called in list context
from package C4::Biblio line 2588, this can lead to vulnerabilities. See the
warning in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer:
http://library-admin.debiankoha.ca/cgi-bin/koha/authorities/authorities.pl?breedingid=115&authtypecode=PERSO_NAME&authid=0
[Sun Aug  7 10:40:24 2016] authorities.pl: CGI::param called in list context
from package C4::Biblio line 2605, this can lead to vulnerabilities. See the
warning in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer:
http://library-admin.debiankoha.ca/cgi-bin/koha/authorities/authorities.pl?breedingid=115&authtypecode=PERSO_NAME&authid=0
[Sun Aug  7 10:40:24 2016] authorities.pl: CGI::param called in list context
from package C4::Biblio line 2608, this can lead to vulnerabilities. See the
warning in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer:
http://library-admin.debiankoha.ca/cgi-bin/koha/authorities/authorities.pl?breedingid=115&authtypecode=PERSO_NAME&authid=0

$ uname -a
Linux debian 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02)
x86_64 GNU/Linux
$ sudo apache2 -v
Server version: Apache/2.4.10 (Debian)
Server built:   Jul 20 2016 06:48:18

Yes, Liz. I do still get it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 19:44:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 17:44:15 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-6qmOkGbkGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 19:44:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 17:44:18 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-PQFXKyRLUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54056|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54124&action=edit
[PASSED QA] Bug 17019 - debian/changelog update

This has not been updated for a while. I plan to add the stable
releases.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 19:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 17:45:01 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-RzZfMqV0k2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Waiting for feedback from Mirko.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 19:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 17:46:39 +0000
Subject: [Koha-bugs] [Bug 17073] koha
In-Reply-To: <bug-17073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17073-70-Wyt6kDDbQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This bug has no content - closing invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 19:55:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 17:55:07 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-8XxZj3eEJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
Katrin: You're right, but it does not really appy here. Also I override the
version anyway. I think changing this to a more intelligent setting should be a
seperate patch, I need the basetgz part now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 20:04:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 18:04:37 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-tCo08Tm7em@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trusting Mirko here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 20:05:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 18:05:47 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-wZtft2mATK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 20:05:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 18:05:49 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-m32I7o9whb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53869|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54125&action=edit
[PASSED QA] Bug 17013 - build-git-snapshot: add basetgz parameter and update
master version number

This adds a basetgz parameter to specify a pbuilder image.
I use this to build against different distributions.

This also updates the version number for master builds to 16.06.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:24:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:24:24 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-PQ6kQF5fQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #16 from Marc V?ron <veron at veron.ch> ---
Created attachment 54126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54126&action=edit
Bug 13796: (followup) Change wording to variant III

See comments #13 - 15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:27:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:27:05 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-i2xHVM5KrO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #17 from Marc V?ron <veron at veron.ch> ---
I hope it's OK to switch back to 'Signed off'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:37:01 +0000
Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no
 records have been passed in
In-Reply-To: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16949-70-kRkNS5yRHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Created attachment 54127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54127&action=edit
Can not proceed even if items selected

Re-tested, I still can not proceed with items selected, see screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:37:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:37:24 +0000
Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no
 records have been passed in
In-Reply-To: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16949-70-Nq3otULaiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:50:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:50:29 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-7bgZTK6BvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #24 from Marc V?ron <veron at veron.ch> ---
Test passes now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:55:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:55:06 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-cUZcol4x4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53084|0                           |1
        is obsolete|                            |

--- Comment #25 from Marc V?ron <veron at veron.ch> ---
Created attachment 54128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54128&action=edit
Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

Alternative patch works for me.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:56:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:56:18 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-wNgNfnIrNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53190|0                           |1
        is obsolete|                            |

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
Created attachment 54129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54129&action=edit
Bug 16686: Rename the transfer method to get_transfer

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:57:19 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-QoKdU9zD6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53191|0                           |1
        is obsolete|                            |

--- Comment #27 from Marc V?ron <veron at veron.ch> ---
Created attachment 54130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54130&action=edit
Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s]

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:58:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:58:06 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-NTPlESS9jP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53227|0                           |1
        is obsolete|                            |

--- Comment #28 from Marc V?ron <veron at veron.ch> ---
Created attachment 54131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54131&action=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 21:58:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 19:58:22 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-KX57lPt9aP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 22:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 20:03:03 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-J9us8s1cUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53875|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 54132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54132&action=edit
Bug 17009: Speed up the framework duplication

To duplicate frameworks, the code retrieve all the subfields, then
execute 1 insert per subfield.
It's unnecessary slow, we can use the DBMS to do it.

Test plan:
Create a new framework and duplicate the structure of another framework.

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug  7 22:03:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 20:03:16 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-JOLjmxPKrp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 00:35:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 22:35:28 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-RsmPyOwE6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #1)
> Created attachment 54123 [details] [review]
> Bug 17074: Fix links in result list of 'scan indexes' and keep search term
> visible
> 
> The 'scan indexes' search that can be reached from the
> advanced search has 2 problems to begin with:
> 
> - The search term you searched for is not displayed
>   in the input field.
> - The links in the result list are missing the index
>   and because of that, are not giving the correct results.
> 
> To test:
> - Go to the advanced search, select an index to search in
> - Enter a search term and check 'scan indexes'
> - Submit search
> - Check if the search term is visible in the input box
> - Check if the result links contain your selected index
>   and give you correct results (count and the number of
>   results should match)

Katrin,
I would like to sign off on this, but as far as I can tell, the patch only
addresses the links.  I can't confirm an issue with the counts, most likely
because of the limited number of records I have at the moment, so for that,
someone else should test at this time.  Also, I see no change with the search
term in the input box, unless I am looking at the wrong thing.  To me, on this
page, the input box should be the textbox labeled "Scan Index for:".  If this
is the case, the box is still blank, and therefore does not pass your test
plan.  Please clarify.  Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 00:44:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 22:44:12 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-26SzEkutjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure what it could be, it works for me. Can please someone else take
another look to get a better picture?

The counts are correct, the problem is when you click on the link and it's
missing the index to search in - so it does a keyword search.

So say you did a search for Author, then the counts will show the counts in the
author index, but the link would start a keyword search which is likely to give
you a different number of results.

Best to test this not using the 'keyword' option

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 00:51:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 22:51:32 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-RoOUHqm79Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Christopher, I tried various searches - the "Scan Index for:" is always set for
me with the patch applied. I tried different indexes. I would be interested to
see your link to the page when it doesn't work. Also, could you check the patch
applied nicely?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 00:55:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 22:55:02 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-5EzdRVj6vd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, just found a little problem - if you enter 2 search terms, you will see
something like: all%20this - url encoded... I have to check on how to fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 01:17:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 23:17:13 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-3S3YryW68J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54123|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54133&action=edit
Bug 17028: Follow-up: fixing encoding issues with multiple search terms

If there was more than one search term you could see that that it
was url encoded. Also problems with search terms with umlauts and
other diacritics.

Patch should fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 01:17:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 23:17:11 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-GMI5HWgcdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 01:19:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 23:19:54 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-QE141Hkwgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54133|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54134&action=edit
Bug 17074: Fix links in result list of 'scan indexes' and keep search term
visible

The 'scan indexes' search that can be reached from the
advanced search has 2 problems to begin with:

- The search term you searched for is not displayed
  in the input field.
- The links in the result list are missing the index
  and because of that, are not giving the correct results.

To test:
- Go to the advanced search, select an index to search in
- Enter a search term and check 'scan indexes'
- Submit search
- Check if the search term is visible in the input box
- Check if the result links contain your selected index
  and give you correct results (count and the number of
  results should match)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 01:20:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 07 Aug 2016 23:20:24 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-IdE7dgApoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54135&action=edit
Bug 17074: Follow-up: fixing encoding issues with multiple search terms

If there was more than one search term you could see that that it
was url encoded. Also problems with search terms with umlauts and
other diacritics.

Patch should fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 02:27:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 00:27:56 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-qlt6nSZhyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51755|0                           |1
        is obsolete|                            |

--- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 54136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54136&action=edit
Bug 16554: rewrite mandatory and sample data - it-IT

More changes to it-IT files

Checked marc21 and unimarc files
unimarc_relatorterms.sql had bad encoding, others minor
errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 02:28:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 00:28:29 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-wITaagkBeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51752|0                           |1
        is obsolete|                            |

--- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 54137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54137&action=edit
Bug 16554: rewrite mandatory and sample data - de-DE

More changes to de-DE files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 02:34:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 00:34:05 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Cy1XDgZg7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
de-DE and it-IT rebased
prove -v t/db_dependent/Test_installer.t still works for all languages.

Download compressed files using
wget -O fr-FR.gz
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898
wget -O ru-RU.gz
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899
wget -O uk-UA.gz
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900

gunzip and apply using git am -3 xx-YY

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 05:43:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 03:43:01 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Uq1pcxZbzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #28 from M. Tompsett <mtompset at hotmail.com> ---
Finally got around to attempting to run it on my shiny new Ubuntu 16.04 LTS
server VM.
--- SNIP ---
loading kohastructure for it-IT | not unimarc
C4::Installer::load_sql returned the following errors while attempting to load
/home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql:
DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for
column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273.
loading kohastructure for nb-NO | not marc21
C4::Installer::load_sql returned the following errors while attempting to load
/home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql:
DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for
column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273.
--- END SNIP ---

So I added a note line...
#
/home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql
C4::Installer::load_sql returned the following errors while attempting to load
/home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql:
DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for
column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273.

Fix and I'll retest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 06:21:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 04:21:56 +0000
Subject: [Koha-bugs] [Bug 17075] New: Subfields of the items do not obey the
 mandatory flag
Message-ID: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

            Bug ID: 17075
           Summary: Subfields of the items do not obey the mandatory flag
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

1. Define subfield "p" (barcode) as mandatory in 952 tag (any framework)
2. Verify that the subfield is not in red in item editor
3. Add a new item with no 952p content
4. Item is accepted although 952p field is mandatory

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 07:25:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 05:25:30 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-IjzaYwJstf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #29 from M. Tompsett <mtompset at hotmail.com> ---
vi installer/.../subscription_numberpatterns.sql
-- notice the [converted]
:set fileencoding=utf-8
:wq

I believe that is all that is needed to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 08:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 06:09:42 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-p1rQq8bHIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 08:51:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 06:51:09 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-n2LruxhYR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54134|0                           |1
        is obsolete|                            |

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Created attachment 54138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54138&action=edit
Bug 17074: Fix links in result list of 'scan indexes' and keep search term
visible

The 'scan indexes' search that can be reached from the
advanced search has 2 problems to begin with:

- The search term you searched for is not displayed
  in the input field.
- The links in the result list are missing the index
  and because of that, are not giving the correct results.

To test:
- Go to the advanced search, select an index to search in
- Enter a search term and check 'scan indexes'
- Submit search
- Check if the search term is visible in the input box
- Check if the result links contain your selected index
  and give you correct results (count and the number of
  results should match)

Tested both patches together, works as expected.
Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 08:52:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 06:52:07 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-0l59PllEGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54135|0                           |1
        is obsolete|                            |

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 54139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54139&action=edit
Bug 17074: Follow-up: fixing encoding issues with multiple search terms

If there was more than one search term you could see that that it
was url encoded. Also problems with search terms with umlauts and
other diacritics.

Patch should fix that.

https://bugs.koha-community.org/show_bug.cgi?id=17074
Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 08:52:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 06:52:39 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-L7Xl5PHTZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 09:23:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 07:23:01 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-XpnlBxsKyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Confirmed.

That's what I get in plack-error.log when adding a new patron category:

DBD::mysql::st execute failed: Column 'checkprevcheckout' cannot be null [for
Statement "INSERT INTO `categories` ( `BlockExpiredPatronOpacActions`,
`category_type`, `categorycode`, `checkprevcheckout`, `dateofbirthrequired`,
`default_privacy`, `description`, `enrolmentfee`, `enrolmentperiod`,
`enrolmentperioddate`, `hidelostitems`, `overduenoticerequired`, `reservefee`,
`upperagelimit`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with
ParamValues: 0="-1", 1="A", 2="B17069A", 3=undef, 4="", 5="default", 6="Bug
17069 A", 7="0.00", 8="12", 9=undef, 10="0", 11="0", 12="0.00", 13=""] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT
`borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES
`categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) [for Statement
"INSERT INTO borrower_message_preferences
(borrower_message_preference_id, borrowernumber, categorycode,
message_attribute_id, days_in_advance, wants_digest)
VALUES
(NULL, ?, ?, ?, ?, ?)
" with ParamValues: 0=undef, 1="B17069A", 2=1, 3=undef, 4=0] at
/home/marc/koha/C4/Members/Messaging.pm line 164.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT
`borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES
`categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) [for Statement
"INSERT INTO borrower_message_preferences
(borrower_message_preference_id, borrowernumber, categorycode,
message_attribute_id, days_in_advance, wants_digest)
VALUES
(NULL, ?, ?, ?, ?, ?)
" with ParamValues: 0=undef, 1="B17069A", 2=2, 3="0", 4=0] at
/home/marc/koha/C4/Members/Messaging.pm line 164.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT
`borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES
`categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) [for Statement
"INSERT INTO borrower_message_preferences
(borrower_message_preference_id, borrowernumber, categorycode,
message_attribute_id, days_in_advance, wants_digest)
VALUES
(NULL, ?, ?, ?, ?, ?)
" with ParamValues: 0=undef, 1="B17069A", 2=4, 3=undef, 4=0] at
/home/marc/koha/C4/Members/Messaging.pm line 164.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT
`borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES
`categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) [for Statement
"INSERT INTO borrower_message_preferences
(borrower_message_preference_id, borrowernumber, categorycode,
message_attribute_id, days_in_advance, wants_digest)
VALUES
(NULL, ?, ?, ?, ?, ?)
" with ParamValues: 0=undef, 1="B17069A", 2=5, 3=undef, 4=0] at
/home/marc/koha/C4/Members/Messaging.pm line 164.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT
`borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES
`categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) [for Statement
"INSERT INTO borrower_message_preferences
(borrower_message_preference_id, borrowernumber, categorycode,
message_attribute_id, days_in_advance, wants_digest)
VALUES
(NULL, ?, ?, ?, ?, ?)
" with ParamValues: 0=undef, 1="B17069A", 2=6, 3=undef, 4=0] at
/home/marc/koha/C4/Members/Messaging.pm line 164.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 09:48:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 07:48:45 +0000
Subject: [Koha-bugs] [Bug 5594] default sort order for items on bib records
In-Reply-To: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5594-70-BfR5qOp0b6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:03:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:03:45 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-DucUiLL2ek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53487|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54140&action=edit
Bug 16929: Prevent opac-memberentry waiting for random chars

Move calls to WWW::CSRF to Koha::Token.
Send a safe random string to WWW::CSRF instead of letting CSRF make a
blocking call to Bytes::Random::Secure. If your server has not enough
entropy, opac-memberentry will hang waiting for more characters in
dev/random. Koha::Token uses Bytes::Random::Secure with the NonBlocking
flag.

Test plan:
[1] Do not yet apply this patch.
[2] If your server has not enough entropy, calling opac-memberentry may
    take a while. But this not may be the case for you (no worries).
[3] Apply this patch.
[4] Verify that opac-memberentry still works as expected.
[5] Run t/Token.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Yes, my server had entropy trouble (reason for finding the problem).
This patch resolves the delay.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:03:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:03:50 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-NET6PYQhrs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53552|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54141&action=edit
Bug 16929: [QA Follow-up] Shortcut methods and use statements

Resolves the following comments:

I'd prefer to see a generate_csrf method than a CSRF flag.
It'd be better to use instead of require the 2 modules.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:03:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:03:54 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-zyLjKjCxM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53809|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54142&action=edit
Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:08:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:08:37 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-x6JJdwbR9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased for opac-memberentry and Dependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:39:16 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-DVN4RRHEew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54140|0                           |1
        is obsolete|                            |

--- Comment #18 from Marc V?ron <veron at veron.ch> ---
Created attachment 54143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54143&action=edit
Bug 16929: Prevent opac-memberentry waiting for random chars

Move calls to WWW::CSRF to Koha::Token.
Send a safe random string to WWW::CSRF instead of letting CSRF make a
blocking call to Bytes::Random::Secure. If your server has not enough
entropy, opac-memberentry will hang waiting for more characters in
dev/random. Koha::Token uses Bytes::Random::Secure with the NonBlocking
flag.

Test plan:
[1] Do not yet apply this patch.
[2] If your server has not enough entropy, calling opac-memberentry may
    take a while. But this not may be the case for you (no worries).
[3] Apply this patch.
[4] Verify that opac-memberentry still works as expected.
[5] Run t/Token.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Yes, my server had entropy trouble (reason for finding the problem).
This patch resolves the delay.

Tested all 3 patches together, works as expected.
Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:40:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:40:14 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-E5PwWqaqjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54141|0                           |1
        is obsolete|                            |

--- Comment #19 from Marc V?ron <veron at veron.ch> ---
Created attachment 54144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54144&action=edit
Bug 16929: [QA Follow-up] Shortcut methods and use statements

Resolves the following comments:

I'd prefer to see a generate_csrf method than a CSRF flag.
It'd be better to use instead of require the 2 modules.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:41:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:41:00 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-RpaQd2rHKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54142|0                           |1
        is obsolete|                            |

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
Created attachment 54145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54145&action=edit
Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 10:41:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 08:41:30 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-YPRmvTpeFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:23:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:23:50 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-MIH9DSsmAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Sandre Cunha from comment #62)
> What is the current status of this issue?

The bug report is not assigned to anyone. A patch has been submitted few years
ago but need to be rebased and certainly adapted to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:24:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:24:32 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-TiquJQ687b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|libreadonly-perl (and       |Remove the Readonly
                   |libreadonly-xs-perl) need   |dependency (again)
                   |to be added as dependencies |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:26:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:26:49 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-NyyvDddMmx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16588

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Mirko Tietgen from comment #5)
> Created attachment 54015 [details] [review]
> Bug 17043 - Readonly deps

Mirko, actually bug 16588 removes this dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:26:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:26:49 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-Cfc0yPSxfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17043

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:32:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:32:33 +0000
Subject: [Koha-bugs] [Bug 17076] New: Format fines in patron search result
	table
Message-ID: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

            Bug ID: 17076
           Summary: Format fines in patron search result table
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Format the values in patron search results following syspref CurrencyFormat.

To verify:
- Search for patrons who have fines or credits
- In result table, column 'Fines' does not respect syspref CurrencyFormat 
  (e.g. for FR)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:33:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:33:01 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search result table
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-f391A4Ixnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:34:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:34:03 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-MhIsuTpYtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Format fines in patron      |Format fines in patron
                   |search result table         |search results table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:39:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:39:59 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-0XS8oQiQSi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54146&action=edit
Bug 17076 - Format fines in patron search results table

Format the values in patron search results following syspref CurrencyFormat.

To verify:
- Search for patrons who have fines or credits
- In result table, column 'Fines' does not respect syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above, verify that fines display as appropriate
- Change syspref Currencyformat, verify display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:40:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:40:23 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-40bNyMxv8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:44:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:44:39 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-3PToIdoE98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Format fines in patron      |Format fines in patron
                   |search results table        |search results table (staff
                   |                            |client)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 11:51:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 09:51:53 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-Z2t79SzXbk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Mirko Tietgen from comment #5)
> > Created attachment 54015 [details] [review] [review]
> > Bug 17043 - Readonly deps
> 
> Mirko, actually bug 16588 removes this dependency.

I know. That is why it is a seperate patch here. Until 16588 is in, I need this
patch for the nightly packages. I apply this and some other patches before I
build them. I will obsolete that part when the other bug is pushed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:01:06 +0000
Subject: [Koha-bugs] [Bug 17077] New: Write off all does not let you write a
	description
Message-ID: <bug-17077-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17077

            Bug ID: 17077
           Summary: Write off all does not let you write a description
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When writing off all patron's fines, librarian should be taken to a page where
they can write a description for the write-off. It works for individual
write-offs, but not for "Write off all".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:26:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:26:11 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-7xjh2EsDEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #42 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Owen Leonard from comment #38)
> I find that it's not possible to make the "library" selection mandatory. Is
> there a reason for that?

No, I just forgot about it. While it would not affect form submission itself
(there will be always some non-empty value submitted in case when
AllowPurchaseSuggestionBranchChoice is enabled), similar logic applies for
itemtype, and yet our librarians found it vitally important that this field too
could be marked as mandatory. And I agreed, good for consistency. Also still
useful as an optional remainder for the user that a given field is relatively
important and that they should pay a closer attention to set it accordingly.

> Note that there is a JS validation plugin available in the OPAC if you want
> to use it. See opac-memberentry.tt for an example. The plugin can be set up
> to validate a form based on the markup (requiring fields which are , so it's
> not necessary to dynamically configure the fields in the JS if you don't
> want to.

Hm, would it be as simple as adding jquery.validate.min.js include and one
jquery call

   $('#add_suggestion_form').validate();

to the template? Let me see how it works ( please do not adjust your set)..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:41:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:41:14 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-oEsJ6SNXFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:41:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:41:17 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-VXtuBiL5UW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54147&action=edit
Bug 17069: Koha::Patron::Category->store must default checkprevcheckout to
'inherit'

Creating a new patron category raises an error "An error occurred when updating
this patron category. Perhaps it already exists."
DBIx::Class does not default to the value defined at the DB devel if the
key checkprevcheckout has been passed to the constructor.
We may need to provide a global fix for this kind of issue: if a column
is defined as "not null" but has a default value, the constructor
(Koha::Object->new) should not pass it to the DBIx::Class constructor
(even if assuming that null means default is a terrible mysqlism).

Test plan:
Create a new patron category.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:42:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:42:39 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-MB0msoNfmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6906
            Version|16.05                       |unspecified
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906
[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:42:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:42:39 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-QgmdL4KW6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17069


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069
[Bug 17069] Can't create new patron category on the intranet
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:48:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:48:33 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-PiuhvbOHEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #87)
> This shouldn't break things for NORMARC, but I'd like Magnus to take a look.
> We should support NORMARC or note that we don't (I'd prefer the former).

I am not sure it's a valid to fail QA these patches, or we need someone taking
on NORMARC changes.
Especially when the patches are waiting for 4 years.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:53:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:53:47 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-ewxgfnUVZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #89 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Jonathan Druart from comment #88)
> I am not sure it's a valid to fail QA these patches, or we need someone
> taking on NORMARC changes.
> Especially when the patches are waiting for 4 years.

Please don't wait for me. :-) I'll have a look and do a followup later for
NORMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:54:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:54:20 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-Xy8svvOHqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:54:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:54:23 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-ei5YG2D4ko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54011|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54148&action=edit
Bug 16996: Do not explode if mandatory fields are missing

At the OPAC, if a patron modify his/her information and at least 1
mandatory field is missing, Koha will crash with
  Template process failed: undef error - Can't call method "description"

It is raised by Koha::Template::Plugin::Categories::GetName called with
an undefined categorycode.
The problem is that the values sent originaly are not sent back to the
template if the user missed something.
This patch makes that all info are resent to the template in order to
show the same form to the user.

Test plan:
0. Apply patch

1. Make sure that the categorycode is not hidden in the OPAC in:
     PatronSelfRegistrationBorrowerUnwantedField or
PatronSelfModificationBorrowerUnwantedField

2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for
example email.

3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave
blank the required field of point 2

4. Press "Submit update request"

There should be no software error.

NOTE: The warns will be floody on the logs.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 12:59:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 10:59:50 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-isKz3PPlxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

--- Comment #4 from Cyrille Duverne <cyrille.duverne at gmail.com> ---
Indeed Jonathan, it's the same with other DB insertions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:13:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:13:51 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-Y72WdArRO2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #90 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I didn't intend to block - just to look into it. Failed is to strong.. In
Discussion has a bad reputation :)

Can we just add a little note to the pref for documentation sakes? I can do so
in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:14:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:14:00 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-l9WA4tPahh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:20:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:20:15 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-zizMcpcjC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, why did you choose 0.29? 0.28 is packaged for jessie.

I also think that we need to fill debian/control for new deps.
Mirko, could you confirm that you expect from devs to update it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:24:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:24:45 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-x1QxOSGRie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #21)
> Marcel, why did you choose 0.29? 0.28 is packaged for jessie.
> 
> I also think that we need to fill debian/control for new deps.
> Mirko, could you confirm that you expect from devs to update it?

I would say that the PM edits debian/control, not individual devs ..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:26:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:26:06 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-NxsU4tKWlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:26:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:26:09 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-5YTZ6Srp0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54145|0                           |1
        is obsolete|                            |

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54151&action=edit
Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 13:29:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 11:29:29 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-UBv1kMIN9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

--- Comment #24 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Jonathan Druart from comment #21)
> Marcel, why did you choose 0.29? 0.28 is packaged for jessie.
> 
> I also think that we need to fill debian/control for new deps.
> Mirko, could you confirm that you expect from devs to update it?


In theory, yes. but since the file is supposed to be generated, not edited
manually, and it will clash with other bugs with dependencies, I think it's
easier if I do it once something got pushed. I'm working on automating that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:01:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:01:46 +0000
Subject: [Koha-bugs] [Bug 17078] New: Format fines on opac-account.pl
Message-ID: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

            Bug ID: 17078
           Summary: Format fines on opac-account.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

Format fines on page "your fines" (opac-account.pl) following syspref
CurrencyFormat

To verify:
- Log in to OPAC as a user who has fines or credits
- Go to page "your fines"
- Verify that values for "Fine amount", "Amount outstanding" 
  and "Total due" are not formatted as defined in syspref CurrencyFormat
  (e.g. for FR)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:03:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:03:13 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-LYR207u24S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17078

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:03:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:03:13 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-lD3epmDQAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17076
           Assignee|oleonard at myacpl.org         |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:09:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:09:20 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-0r5ghEQtAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54143|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54152&action=edit
Bug 16929: Prevent opac-memberentry waiting for random chars

Move calls to WWW::CSRF to Koha::Token.
Send a safe random string to WWW::CSRF instead of letting CSRF make a
blocking call to Bytes::Random::Secure. If your server has not enough
entropy, opac-memberentry will hang waiting for more characters in
dev/random. Koha::Token uses Bytes::Random::Secure with the NonBlocking
flag.

Test plan:
[1] Do not yet apply this patch.
[2] If your server has not enough entropy, calling opac-memberentry may
    take a while. But this not may be the case for you (no worries).
[3] Apply this patch.
[4] Verify that opac-memberentry still works as expected.
[5] Run t/Token.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Yes, my server had entropy trouble (reason for finding the problem).
This patch resolves the delay.

Tested all 3 patches together, works as expected.
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:09:17 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-dAy0KE8E98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:09:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:09:24 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-1VdhT5tDqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54144|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54153&action=edit
Bug 16929: [QA Follow-up] Shortcut methods and use statements

Resolves the following comments:

I'd prefer to see a generate_csrf method than a CSRF flag.
It'd be better to use instead of require the 2 modules.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:09:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:09:27 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-efqmOIZWyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54151|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54154&action=edit
Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:11:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:11:20 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-8WB9f3sMa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54155&action=edit
Bug 17078 - Format fines on opac-account.pl

To verify:
- Log in to OPAC as a user who has fines or credits
- Go to page "your fines"
- Verify that values for "Fine amount", "Amount outstanding"
  and "Total due" are not formatted as defined in syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above
- Verify that values are formatted as appropriate with different
  settings for syspref CurrencyFormat

Note: This patch does not force text alignment to the right.
      Text alignement can be done using syspref OPACUserCSS
      (td.sum, td.credit, td.debit)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:11:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:11:51 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-n8jldRJbfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:12:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:12:34 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-wW4ILiaclP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:16:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:16:19 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-pytvdqArDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Building packages should work without Koha installed anyway. And no other test
fails for that, just this one. This needs to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:16:36 +0000
Subject: [Koha-bugs] [Bug 17046] t/Creators.t kills master packages
In-Reply-To: <bug-17046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17046-70-Bx8hKYNsdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17046

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---


*** This bug has been marked as a duplicate of bug 15200 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:16:36 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-mNP0MNwhMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
*** Bug 17046 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:33:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:33:58 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-LloQVl1lCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #43 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #41)

> Would this be improved by Owen's suggestion of using the existing JS
> validation plugin?

JQuery validation plugin (instead of - or as an addition to - HTML5 attributes
alone) seems to be a better choice (more configurable, extensible, and probably
more predictable with old browsers as well). However so far I have zero
experience with this plugin (or any other jQuery plugins for that matter).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:35:26 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-qerIGL47mv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54147|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 54156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54156&action=edit
Bug 17069: Koha::Patron::Category->store must default checkprevcheckout to
'inherit'

Creating a new patron category raises an error "An error occurred when updating
this patron category. Perhaps it already exists."
DBIx::Class does not default to the value defined at the DB devel if the
key checkprevcheckout has been passed to the constructor.
We may need to provide a global fix for this kind of issue: if a column
is defined as "not null" but has a default value, the constructor
(Koha::Object->new) should not pass it to the DBIx::Class constructor
(even if assuming that null means default is a terrible mysqlism).

Test plan:
Create a new patron category.

Works as expected.
Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:37:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:37:30 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-JooE8qmbVn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:44:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:44:01 +0000
Subject: [Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface
In-Reply-To: <bug-5362-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5362-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5362-70-PS3IIsA4tV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
                 OS|Linux                       |All
           Hardware|PC                          |All

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:47:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:47:16 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-EIecUdHrkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 14:47:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 12:47:20 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-KTbTln2iii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54157&action=edit
Bug 16960: Fix error on validating the registration

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:00:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:00:45 +0000
Subject: [Koha-bugs] [Bug 17079] New: Umlauts(special chars) are displayed
 as One Latin-1 char per byte on the plugin-template
Message-ID: <bug-17079-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17079

            Bug ID: 17079
           Summary: Umlauts(special chars) are displayed as One Latin-1
                    char per byte on the plugin-template
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: elias.dehler at thulb.uni-jena.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 54158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54158&action=edit
Searchbar with bug visible

The Problem:
every character is shown as one latin-1 char per byte

Where:
On the page which is displayed after the "run tool" action on any plugin (which
loads a plugin specific template).

Steps to reproduce:
- install german language pack (or any language pack with non-standard chars)
- install https://github.com/bywatersolutions/koha-plugin-kitchen-sink
- pick the action "run tool"
- switch language to german (or any language pack with non-standard chars)

- The problem is now visible at the search bar (or any other special char
displayed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:02:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:02:32 +0000
Subject: [Koha-bugs] [Bug 17079] Umlauts(special chars) are displayed as One
 Latin-1 char per byte on the plugin-template
In-Reply-To: <bug-17079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17079-70-7tBj5OSmHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17079

Elias <elias.dehler at thulb.uni-jena.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:06:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:06:04 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-F9MD8j6kEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:06:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:06:07 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-vRPWbKUlwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54146|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54159&action=edit
[SIGNED-OFF] Bug 17076 - Format fines in patron search results table

Format the values in patron search results following syspref CurrencyFormat.

To verify:
- Search for patrons who have fines or credits
- In result table, column 'Fines' does not respect syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above, verify that fines display as appropriate
- Change syspref Currencyformat, verify display

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:07:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:07:06 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-qoAPHhVEYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:11:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:11:40 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-IW09Kftk6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:11:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:11:42 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-Eg5kggRG3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54155|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54160&action=edit
[SIGNED-OFF] Bug 17078 - Format fines on opac-account.pl

To verify:
- Log in to OPAC as a user who has fines or credits
- Go to page "your fines"
- Verify that values for "Fine amount", "Amount outstanding"
  and "Total due" are not formatted as defined in syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above
- Verify that values are formatted as appropriate with different
  settings for syspref CurrencyFormat

Note: This patch does not force text alignment to the right.
      Text alignement can be done using syspref OPACUserCSS
      (td.sum, td.credit, td.debit)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:14:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:14:15 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-SMeudXQdIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:15:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:15:56 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-ZxR8020n4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:16:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:16:58 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-D6BLpU6oNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:17:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:17:26 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item) number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-WgBfk16VhC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
> I was taking a look at this bug and I could not find any patch or test plan.
> Will you please add these to this bug report?

There is one attachment to this bug report and it is the patch. The patch's
commit message contains the test plan. See Comment 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:18:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:18:00 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-UTCwehDpTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:24:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:24:13 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-0MBlR3pIXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This was marked as "Patch doesn't apply" but it's working fine for me. Please
re-test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:26:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:26:15 +0000
Subject: [Koha-bugs] [Bug 9851] way to get full records for purchase
	suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-O8VIoI0k5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:26:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:26:20 +0000
Subject: [Koha-bugs] [Bug 9851] way to get full records for purchase
	suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-7MG48rOCZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:31:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:31:08 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-isOHY8qH6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
With patch, it works OK when updating an existing record.

However if I want to create a new patron using self registration, I still get
"Internal Server Error"

What I did:

- Mandatory fields: Surname, First name
- Category is visible
- If not yet done, log out from OPAC
- Follow Link "Register here"
- Fill in First name only
- Fill in Verification
- Submit
- Getting Message "You have not filled..."
- Do not change anything, submit
-> "Internal Server Error"

plack-error.log says:
Template process failed: undef Error - Can not call method "description" on an
undefined value at /usr/share/koha/lib/Koha/Template/Plugin/Categories.pm line
29.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:32:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:32:43 +0000
Subject: [Koha-bugs] [Bug 17080] New: Koha::Object-> new should handle
 default values for NOT NULL columns
Message-ID: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

            Bug ID: 17080
           Summary: Koha::Object->new should handle default values for NOT
                    NULL columns
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Recently we face the same issue on different modules after we moved them to the
Koha namespace using Koha::Object of using DBIx::Class directly.

1/ Koha::Patron::Modification on bug 16960 comment 14 and 15
2/ Koha::Patron::Category from bug 17069
3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917

If a DB column is defined as NOT NULL and has a default value, the DBIx::Class
$rs->update_or_insert method won't use the default value if the column name has
been passed to the constructor.

We do that almost everywhere as we retrieve the data from the HTML forms
without checking/cleaning them.

There are several ways to fix that:
1/ Continue to fix them case by case (what we did for the recent issues)
2/ Try to fix them globally (existing ones and the next ones)

This report will propose a global solution to avoid future issues of this kind.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:33:04 +0000
Subject: [Koha-bugs] [Bug 16917] Error when importing patrons,
 Column 'checkprevcheckout'   cannot be null
In-Reply-To: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16917-70-NoMWBU9who@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080
[Bug 17080] Koha::Object->new should handle default values for NOT NULL columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:33:04 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-wgGFG01sGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080
[Bug 17080] Koha::Object->new should handle default values for NOT NULL columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:33:04 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-9fNv4oA3uI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16960, 17069, 16917


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917
[Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be
null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960
[Bug 16960] Patron::Modifications should be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069
[Bug 17069] Can't create new patron category on the intranet
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:33:04 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-5tdagnGRwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080
[Bug 17080] Koha::Object->new should handle default values for NOT NULL columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:37:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:37:15 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-B0dKy4BvVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #12 from Mirko Tietgen <mirko at abunchofthings.net> ---
Thanks Kyle!

Frederic: Can you push this to 16.05 please? I need it for the nightly builds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:39:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:39:11 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-MBlkX3oo23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
Does it need to mock C4::Context maybe? That seems to be what other tests do.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:48:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:48:14 +0000
Subject: [Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
In-Reply-To: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15903-70-ZOQ96ySUCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:48:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:48:16 +0000
Subject: [Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
In-Reply-To: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15903-70-HoGBSit10z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52145|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54161&action=edit
[SIGNED-OFF] Bug 15903 - Remove use of recordpayment in paycollect.pl

Test Plan:
1) Apply this patch
2) Pay a fine via the "Pay amount" button
3) Payment should succeed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:26 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-r7lvH30anR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:28 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-hUNqlBJBB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54162&action=edit
Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new

Recently we face the same issue on different modules after we moved them to the
Koha namespace using Koha::Object of using DBIx::Class directly.

1/ Koha::Patron::Modification on bug 16960 comment 14 and 15
2/ Koha::Patron::Category from bug 17069
3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917

If a DB column is defined as NOT NULL and has a default value, the DBIx::Class
$rs->update_or_insert method won't use the default value if the column name
has been passed to the constructor.

We do that almost everywhere as we retrieve the data from the HTML forms
without
checking/cleaning them.

There are several ways to fix that:
1/ Continue to fix them case by case (what we did for the recent issues)
2/ Try to fix them globally (existing ones and the next ones)

This patch propose a global solution to avoid future issues of this kind.

The idea is not to pass the undefined values which cannot be nullable to the
DBIx::Class constructor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:31 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-nvvaOSnyW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54163&action=edit
Bug 17080: Make C4::Members::AddMember uses Koha::Patron->store

These calls have been added from commit e196f19 (Bug 12633: Remove SQLHelper
in C4::Members) which added a TODO:
"This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower."

This is now done by this patch: instead of calling DBIx::Class directly
we use Koha::Patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:39 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-USRwnAI9Jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54164&action=edit
Bug 17080: borrowers table - use default values defined in the DBIx::Class
schema

This patch basically just revert bug 16960 - Fix error on validating the
registration

This job is now done by the Koha::Object constructor, no need to clean
the hash before sending it to AddMember.

Test plan:
Make sure there is no regression on bug 16960 (validate a self registration).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:42 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-MdEqiOMG5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54165&action=edit
Bug 17080: borrowers.checkprevcheckout - use the default value defined in the
DBIx::Class schema

This line has been added by bug 16917 to define the default value of
borrowers.checkprevcheckout.
As this value is defined in the DBIx::Class schema, we should not have
to handle it here.

Test plan:
Confirm that this patch does not reintroduced the bug fixed by bug
16917.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 15:59:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 13:59:45 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-GJrvsVpntM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54166&action=edit
Bug 17080: categories.checkprevcheckout - use the default value defined in the
DBIx::Class schema

This patch reverts bug 17069

Test plan:
Create a new patron category

  prove t/db_dependent/Koha/Patron/Categories.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:14:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:14:01 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-IH3NazzNTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54167&action=edit
Bug 16996: (follow-up) Do not explode if mandatory fields are missing

When registering a new patron, if something went wrong, the form is
resent to the template but without the categorycode (not a dropdown list
anymore, but just displayed as a readonly value # TODO LATER).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:14:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:14:33 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-0V9QUUWmDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:18:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:18:09 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-4DU4OaemFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53965|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54168&action=edit
Bug 17043 - debian/list-deps fixes, master edition

This makes debian/list-deps ready for Debian Jessie
and adds small fixes I already use for package releases.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:18:16 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-bc6ibThoby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53967|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54169&action=edit
Bug 17043 - master control file

latest control file update

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:18:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:18:21 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-St4NXHpJ9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54015|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54170&action=edit
Bug 17043 - Readonly deps

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:18:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:18:44 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-M71ruPonKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:19:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:19:06 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-X7dr2XkeIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:19:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:19:11 +0000
Subject: [Koha-bugs] [Bug 17077] Write off all does not let you write a
	description
In-Reply-To: <bug-17077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17077-70-mvqpbhMTPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17077

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:19:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:19:27 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-m8qGr3UQyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:19:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:19:48 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-oU008E6z30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:19:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:19:59 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-emHlmzn4Qt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:21:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:21:36 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-NzGEt0XhMS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:21:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:21:40 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-GIffVEHlRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54063|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54171&action=edit
Bug 17062 - debian/control.in update: change maintainer

Changing the package maintainer and removing a whitespace in debian/control.in.
Regenerated debian/control from that, which also adds libhtml-parser-perl
because of bug 16971.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:25:22 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-C4dMr1rcPB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:27:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:27:43 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-JUl1yAtAOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:31:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:31:18 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-i6yP0TlrnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:33:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:33:11 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-cr74XyL9UT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:33:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:33:28 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-I4HqyRULfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Passed and pushed for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:34:50 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-PTCZfcXeZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:35:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:35:34 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-Ob9suQiUmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:36:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:36:40 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-PuoqSAygLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:39:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:39:37 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-GTQddoOVyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:46:53 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-fQ9itdSoqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Aleisha Amohia from comment #10)
> Edit: circ/reserveratios.tt updated so that the plus icon doesn't show
>       if there is no link

I'm still getting the plus sign when there is no link. I think the template
logic is off somewhere. If it helps, feel free to break up and re-indent that
section since right now it's all on one line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:49:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:49:00 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-zXsxkCXNA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Is it also targeted to 16.05?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:49:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:49:42 +0000
Subject: [Koha-bugs] [Bug 17019] debian/changelog update
In-Reply-To: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17019-70-ryqrcs9AyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:54:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:54:26 +0000
Subject: [Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl
In-Reply-To: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15906-70-6XMMW4UdU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 16:54:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 14:54:29 +0000
Subject: [Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl
In-Reply-To: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15906-70-AlBkou0dZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52148|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54172&action=edit
[SIGNED-OFF] Bug 15906 - Remove use of makepayment in paycollect.pl

Test plan:
1) Apply this patch
2) Make a payment in full using the "Pay" button
3) Note payment succeeds

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:00:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:00:36 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-Jlkkhg6yzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #9 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Would it not be preferable to add Readonly rather than replace usages of
Readonly by constant reintroducing exactly the problems with constant readonly
addresses (see the Readonly doc). I thought Readonly was in the dependencies
list previously.

It would be safer to replace the readonly vars with simple variables than using
the constant pragma

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:05:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:05:11 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-WOiqG8XIjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:06:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:06:37 +0000
Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments
In-Reply-To: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16899-70-RoKybgnOvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:07:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:07:52 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-0Z6xRElCYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mail at jkozlovsky.cz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:08:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:08:31 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-C3fUmT4MGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mail at jkozlovsky.cz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:08:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:08:59 +0000
Subject: [Koha-bugs] [Bug 17081] New: Incorrect comparison operator used in
 edifactmsgs.pl
Message-ID: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

            Bug ID: 17081
           Summary: Incorrect comparison operator used in edifactmsgs.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

numeric comparison operator used where string comparison required, results in
following warning in the log:
Argument "delete" isn't numeric in numeric eq (==) at
/usr/share/koha/intranet/cgi-bin/acqui/edifactmsgs.pl line 42

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:13:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:13:59 +0000
Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance
	Improvement
In-Reply-To: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15107-70-Ld7PIxva7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |cnorthcott.work at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:14:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:14:46 +0000
Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the
	same record
In-Reply-To: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15567-70-iSVtS4Yo0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:15:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:15:43 +0000
Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance
	Improvement
In-Reply-To: <bug-15106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15106-70-lomOxBkoUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |cnorthcott.work at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:17:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:17:32 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-HfjT8yZFuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 54173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54173&action=edit
Proposed patch

To test apply the patch and the warning should no longer appear in the error
log

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:41:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:41:32 +0000
Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance
	Improvement
In-Reply-To: <bug-15106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15106-70-UThBD2FYAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 17:46:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 15:46:02 +0000
Subject: [Koha-bugs] [Bug 17082] New: Translatability: Fix sentence
 splitting in member.tt
Message-ID: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

            Bug ID: 17082
           Summary: Translatability: Fix sentence splitting in member.tt
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Template file member.tt contains sentences splitted by tags leading to
difficulties while translating.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:02:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:02:45 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-gxXcqM4JiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:03:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:03:35 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-OcLffBnOnE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54174&action=edit
Bug 17082: Translatability: Fix sentence splitting in member.tt

This patch fixes sentences splitting in file
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

Fix is done with a new .inc file because the code is the same as in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

To test:
- Carefully review code changes
- Test on a fresh install without example data (or save database
  and test with empty tables 'branches' and 'categories')
- Go to Home > Patrons (members-home.pl)
- Verify that a warnings appears aubout missing libraries and patron
  categories
- Try to add a new patron (memberentry.pl)
- Verify that the same messages are triggered
- Verify that messages disappear as appropriate as soon as a library and
  a patron category are defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:04:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:04:17 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-aDSPYolHN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:17:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:17:11 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-yP76KFcLA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54148|0                           |1
        is obsolete|                            |

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 54175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54175&action=edit
Bug 16996: Do not explode if mandatory fields are missing

At the OPAC, if a patron modify his/her information and at least 1
mandatory field is missing, Koha will crash with
  Template process failed: undef error - Can't call method "description"

It is raised by Koha::Template::Plugin::Categories::GetName called with
an undefined categorycode.
The problem is that the values sent originaly are not sent back to the
template if the user missed something.
This patch makes that all info are resent to the template in order to
show the same form to the user.

Test plan:
0. Apply patch

1. Make sure that the categorycode is not hidden in the OPAC in:
     PatronSelfRegistrationBorrowerUnwantedField or
PatronSelfModificationBorrowerUnwantedField

2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for
example email.

3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave
blank the required field of point 2

4. Press "Submit update request"

There should be no software error.

NOTE: The warns will be floody on the logs.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:19:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:19:19 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-7EjMbNDuwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54167|0                           |1
        is obsolete|                            |

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 54176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54176&action=edit
Bug 16996: (follow-up) Do not explode if mandatory fields are missing

When registering a new patron, if something went wrong, the form is
resent to the template but without the categorycode (not a dropdown list
anymore, but just displayed as a readonly value # TODO LATER).

Signed-off-by: Marc <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:19:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:19:36 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-CwMs0z1Qvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:50:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:50:35 +0000
Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the
	same record
In-Reply-To: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15567-70-JV6NS2WPQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 18:52:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 16:52:53 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-XDAI6KPvUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #44 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
> > Note that there is a JS validation plugin available in the OPAC if you want
> > to use it. See opac-memberentry.tt for an example. The plugin can be set up
> > to validate a form based on the markup (requiring fields which are , so it's
> > not necessary to dynamically configure the fields in the JS if you don't
> > want to.
> 
> Hm, would it be as simple as adding jquery.validate.min.js include and one
> jquery call
> 
>    $('#add_suggestion_form').validate();
> 
> to the template? Let me see how it works ( please do not adjust your set)..

So far so good, it's working (almost) fine, apart from two small issues:

1) for 'pattern' rule to work I guess additional include (additional-methods.js
or pattern.js ?) may be needed, but neither seems to be anywhere in the code
tree yet (?) - or maybe there is some other bug report waiting in the queue
which includes one of them, that I can test and sign instead?
2) translateability - no matter what I try to add to the .po files etc., "This
field is required" still appears only in english (but so is the "Please enter a
valid email address." message in opac-memberentry.tt ?). Perhaps it's just my
test install which is missing something, or in order for this message to be
translateable some additional trickery may be needed..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 19:01:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 17:01:14 +0000
Subject: [Koha-bugs] [Bug 2559] Language limit on Spanish returns Russian
 records or is it English ...
In-Reply-To: <bug-2559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2559-70-3hmAirPtpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 19:02:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 17:02:17 +0000
Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec
In-Reply-To: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14678-70-9VtQbkBcJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 19:03:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 17:03:11 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-1wkZ4id5p7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 20:16:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 18:16:11 +0000
Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to
 Koha::Patron->move_to_deleted
In-Reply-To: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16891-70-dIF1Z81yUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #2)
> 3/ Same as previously but using the cronjob
> misc/cronjobs/delete_patrons.pl.

At this step I'm getting "No method move_to_deleted! at
misc/cronjobs/delete_patrons.pl line 77."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 20:34:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 18:34:49 +0000
Subject: [Koha-bugs] [Bug 17083] New: Remove more event attributes from
	tools templates
Message-ID: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

            Bug ID: 17083
           Summary: Remove more event attributes from tools templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

This patch will remove event attributes from some tools-related templates:

labels/label-edit-layout.tt
tools/cleanborrowers.tt
tools/inventory.tt
tools/letter.tt
tools/upload.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 22:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 20:43:52 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-bftjcb3dTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jacek, how do you add to the po files?
You should not need to change anything manually there. For a git installation
try:
- switch to misc/translator in your koha directory
- perl translate update <langcode>
- perl translate install <langcode>

The first updates the templates the second installs them from the po file for
testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug  8 23:59:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 21:59:53 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-yOQJrzEXwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #13 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Fr?d?ric Demians from comment #12)
> Is it also targeted to 16.05?

The first one should go in 16.05 if it applies (I will check), the second one
is not needed, I will check about the third.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 00:24:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 22:24:26 +0000
Subject: [Koha-bugs] [Bug 17084] New: Nightly build bot bug
Message-ID: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

            Bug ID: 17084
           Summary: Nightly build bot bug
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Things the nightly build bot says.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 00:24:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 22:24:50 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-OGqB6g1pO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 00:25:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 08 Aug 2016 22:25:16 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-Ipq19XHR0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 04:47:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 02:47:30 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-4rSjealfVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 04:47:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 02:47:33 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-dsdXcmzNdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54177&action=edit
Bug 14642: (QA followup) Add tests for Koha::Hold->delete

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 05:10:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 03:10:11 +0000
Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to
 Koha::Patron->move_to_deleted
In-Reply-To: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16891-70-p4RGWCQODz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 05:10:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 03:10:14 +0000
Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to
 Koha::Patron->move_to_deleted
In-Reply-To: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16891-70-V63w6jsHK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53522|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54178&action=edit
Bug 16891: Move C4::Members::MoveMemberToDeleted to
Koha::Patron->move_to_deleted

This patch removes the C4::Members::MoveMemberToDeleted subroutine in
order to replace it with the Koha::Patron->move_to_deleted method.
Next after this change, we will move C4::Members::HandleDelBorrower and
C4::Members::DelMember to the same module to simplify the code in
members/deletemem.pl and misc/cronjobs/delete_patrons.pl

Test plan:
1/ Delete a patron from the staff interface and make sure (s)he has been moved
to
the deletedborrowers table.
2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to
remove patron. Make sure the "Permanently delete these patrons" and "Move
these patrons to the trash" options work as before
3/ Same as previously but using the cronjob
misc/cronjobs/delete_patrons.pl.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Tested the delete_patrons.pl script and cleanborrowers.pl too.
Tests (are relevant and) pass and the qa scripts are happy too :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 07:20:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 05:20:14 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-hihyYPfxZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #46 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #45)
> Hi Jacek, how do you add to the po files?
> You should not need to change anything manually there. For a git
> installation try:
> - switch to misc/translator in your koha directory
> - perl translate update <langcode>
> - perl translate install <langcode>
> 
> The first updates the templates the second installs them from the po file
> for testing.

That's how I've been trying to test it. Well, manually adding a few odd extra
strings in the .po file and 'translate install' without 'translate update' is
not below my dignity too ;) - I know it's not a proper way, but it should work
just fine for testing purposes (usually does in similar circumstances).

Problem is that messages embedded in the .js file ("This field is required",
"Please enter a valid email address", ...) are not picked up for translation.
This is most likely normal, I just wasn't aware of that.

Looks like there are several ways to fix this issue, either globally for
OPAC/bootstrap - like it was done for intranet/prog in Bug 6209, or locally 
in the given OPAC templates, e.g. using a combination of 

    jQuery.extend(jQuery.validator.messages, {
        required: _("This field is required."),
        email: _("Please enter a valid email address."),
        ...

for the "regular" mandatory fields, and/or

    jQuery.validator.addMethod("year", function(value, element) {
        ...
    }, _("Please enter a year in the valid format (YYYY, YY--)"));


for a field with the pattern. I guess preferably it should be fixed globally
for the OPAC (opac-memberentry.tt is affected by this too), but I'm a bit out
of my depth here - I'll better open a separate bug report for that part.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 10:34:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 08:34:18 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-L1BaVygz8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Colin Campbell from comment #9)
> Would it not be preferable to add Readonly rather than replace usages of
> Readonly by constant reintroducing exactly the problems with constant
> readonly addresses (see the Readonly doc). I thought Readonly was in the
> dependencies list previously.
> 
> It would be safer to replace the readonly vars with simple variables than
> using the constant pragma

I asked for feedbacks on bug 14066 comment 2 and did not get any cons so
decided to continue on this way.
We only use constant with scalars so far, therefore the different problems with
the constant pragma should not impact us too much.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 10:45:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 08:45:46 +0000
Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to
 Koha::Patron->move_to_deleted
In-Reply-To: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16891-70-ef05XDHf0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > 3/ Same as previously but using the cronjob
> > misc/cronjobs/delete_patrons.pl.
> 
> At this step I'm getting "No method move_to_deleted! at
> misc/cronjobs/delete_patrons.pl line 77."

The patch has been signed off in the meanwhile.
Could you confirm that it correctly works please?
I have just retested and the cronjob script seems to work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 10:58:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 08:58:54 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-W1zYJuD8ns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do you have ttf-dejavu installed?
Does /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf exist?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:15:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:15:38 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-RltOWJ1UAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:15:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:15:42 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-bk82a0EAy3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52824|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54179&action=edit
Bug 14642: Add HoldsLog syspref

This patch introduces a new syspref 'HoldsLog' which is to be used for
controlling
holds actions logs.

Sponsored-by: NEKLS

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:15:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:15:45 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-qx2C9gXuqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54180&action=edit
Bug 14642: Add logging for Holds

This patch adds logging for several holds actions. Specifically for:

- CREATE
- CANCEL
- DELETE
- RESUME
- SUSPEND
- MODIFY

To test:
- Enable the HoldsLog syspref
- Add a hold on a record/item
=> SUCCESS: The log view shows the CREATE action
- Click on the <Suspend> button
=> SUCCESS: The log view shows the SUSPEND action
- Click on the <Unsuspend> button
=> SUCCESS: The log view shows the RESUME action
- Click on the red cross, to delete the hold
=> SUCCESS: The log view shows the CANCEL action

Note: The DELETE action is logged when DelMember is called, with bug 16819
patches applied.

Sponsored-by: NEKLS
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
I also wonder about this going in defaulted on, but since the other logs are as
well it seems ok to me.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:15:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:15:50 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-T9penXOUWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53734|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54181&action=edit
Bug 14642: (QA followup) Make HoldsLog default to 0

After a couple comments regarding the default value I picked for the
new syspref, I've decided to set it 0, as libraries interested on the
fetarue will just enable it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:15:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:15:56 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-meyvJKUC9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54177|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54182&action=edit
Bug 14642: (QA followup) Add tests for Koha::Hold->delete

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:16:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:16:00 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-1zWsrFgnPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54183&action=edit
Bug 14642: Make sure the log will be written only if the hold has been deleted

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:17:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:17:43 +0000
Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to
	Koha::Patron
In-Reply-To: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16907-70-4cbfdQB4Sv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54184&action=edit
Bug 16907: Make sure the log will be written only if the patron has been
deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:24:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:24:00 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-86ZglK5qmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:24:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:24:03 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-o30YdusS2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54185&action=edit
Bug 17078 - Format fines on opac-account.pl

To verify:
- Log in to OPAC as a user who has fines or credits
- Go to page "your fines"
- Verify that values for "Fine amount", "Amount outstanding"
  and "Total due" are not formatted as defined in syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above
- Verify that values are formatted as appropriate with different
  settings for syspref CurrencyFormat

Note: This patch does not force text alignment to the right.
      Text alignement can be done using syspref OPACUserCSS
      (td.sum, td.credit, td.debit)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:26:59 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-0ojqEV57E8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nightly at abunchofthings.net
             Status|NEW                         |ASSIGNED

--- Comment #8 from Nightly Build Bot <nightly at abunchofthings.net> ---
HA! ttf-dejavu is missing from builddeps. I will send a patch. Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:28:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:28:16 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-pbWq2ypi0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |mirko at abunchofthings.net
   Patch complexity|---                         |Trivial patch

--- Comment #9 from Mirko Tietgen <mirko at abunchofthings.net> ---
Errr, account fail. That was me. :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:28:34 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-ZK2VOftgiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:28:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:28:37 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-aKKJGgu3tG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54159|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54186&action=edit
Bug 17076 - Format fines in patron search results table

Format the values in patron search results following syspref CurrencyFormat.

To verify:
- Search for patrons who have fines or credits
- In result table, column 'Fines' does not respect syspref CurrencyFormat
  (e.g. for FR)

To test:
- Apply patch
- Repeat steps above, verify that fines display as appropriate
- Change syspref Currencyformat, verify display

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:35:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:35:02 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-pJFvR9RgZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:35:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:35:05 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-FXvqc6CQvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53836|0                           |1
        is obsolete|                            |

--- Comment #9 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54187&action=edit
Bug 17007: REST API: add route to get biblio

This patch adds route to get one biblio from koha.biblios table. On top of this
biblio there is added key "items" with value being array of items belonging to
the
requested biblio.

As Magnus Enger pointed out, we should hide all the items defined in the
OpacHiddenItems syspref from all but staff. This patch adds this functionality.

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/biblios/YYY
   where YYY is an existing biblionumber.
3. Make sure the returned data is correct.
4. Find items which are hidden in OPAC with OpacHiddenItems syspref, note their
record's biblionumber and repeat point 2 with it.
5. Check that if you are logged in as staff, you see all the items (even those
hidden from OPAC)
6. Check that if you are not logged in as staff, you see only the items which
are
not hidden from OPAC
7. Run unit tests in t/db_dependent/api/v1/biblios.t

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:37:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:37:00 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-mJUlSY55Hs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

--- Comment #10 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Jiri Kozlovsky from comment #7)
> Created attachment 53834 [details] [review]
This patch removed commit message from the patch. I added it back from your
comment field and merged it together with the original description. Hope it's
ok now?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:37:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:37:21 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-4uImfqVYXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:37:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:37:24 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-CQTlsZH8Zy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53476|0                           |1
        is obsolete|                            |
  Attachment #54126|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54188&action=edit
Bug 13796: OPAC: Display rental charge for renewing

This patch displays the rental fee that will be applied for
renewing (near "Renew" link on patron's summary page)

To test:
- Apply patch
- Verify that you have item types with and without rental fee
  for testing
- Issue items with an without rental fee to a patron
- In OPAC, display patron's summary page
- Verify in table 'Checked out', items with rental charge display an
information as
  appropriate (near the link 'Renew')

Signed-off-by: Sally Healey <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:37:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:37:28 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-Wcmoz7gwSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54189&action=edit
Bug 13796: (followup) Change wording to variant III

See comments #13 - 15

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:44:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:44:01 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-Vx24XJa6Ur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:44:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:44:04 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-F2CuJYyEux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54138|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54190&action=edit
Bug 17074: Fix links in result list of 'scan indexes' and keep search term
visible

The 'scan indexes' search that can be reached from the
advanced search has 2 problems to begin with:

- The search term you searched for is not displayed
  in the input field.
- The links in the result list are missing the index
  and because of that, are not giving the correct results.

To test:
- Go to the advanced search, select an index to search in
- Enter a search term and check 'scan indexes'
- Submit search
- Check if the search term is visible in the input box
- Check if the result links contain your selected index
  and give you correct results (count and the number of
  results should match)

Tested both patches together, works as expected.
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:44:07 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-Qnt72opkpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54139|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54191&action=edit
Bug 17074: Follow-up: fixing encoding issues with multiple search terms

If there was more than one search term you could see that that it
was url encoded. Also problems with search terms with umlauts and
other diacritics.

Patch should fix that.

https://bugs.koha-community.org/show_bug.cgi?id=17074
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:53:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:53:30 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-wEJWoZLRMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54192&action=edit
Bug 15200 - t/Creators.t fails when using build-git-snapshot

ttf-dejavu was missing from the build dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 11:58:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 09:58:11 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-vr63T7XPKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:02:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:02:42 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-UEnPGEvoA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:02:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:02:44 +0000
Subject: [Koha-bugs] [Bug 17007] REST API: add route to get biblio
In-Reply-To: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17007-70-HjzJbA3Ww2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17007

--- Comment #11 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54193&action=edit
Bug 17007: Fix typo in biblio's Swagger definition

By running the test introduced in Bug 17032, we can easily catch issues related
to object definitions in Swagger vs. Koha-object's columns.

This patch fixes a property typo in biblio.json

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:15:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:15:19 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-lWq2cN3eUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Barton, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:23:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:23:17 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-UDbVByZgzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Considering you have written a patch, and I have not, I'd like to see yours get
it in ;)

David, is this patch still in good condition? If so I'd be willing to test and
sign-off.

(In reply to David Cook from comment #24)
> To be honest, I don't know what I'm supposed to do about this patch anymore.
> 
> I don't think Marcel liked my patch, but his suggestions weren't feasible,
> so... I don't know. I'm not inclined to work on it, since I'm not sure what
> I need to do to get it to an acceptable point.
> 
> It's essentially a duplicate of bug 14238 anyway, so perhaps Kyle can write
> his own patch. I would be happy to add my sign off to that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:24:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:24:34 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-4XY0xyoHjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #6 from Lari Taskula <larit at student.uef.fi> ---
We should figure out what to do for properties 'issuing' and 'branchprinter'.
They are missing from api/v1/definitions/library.json but I would guess the
reason is that Benjamin noticed kohastructure mentioning that they are not used
in Koha. Perhaps they should be completely removed everywhere?

I noticed this issue by running the test introduced in Bug 17032 which won't
pass this definition because it sees these two "missing" properties.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:29:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:29:51 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-GZhMVtJZHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54194&action=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:30:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:30:39 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-VPSnto5czo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove dead(?) code related |Remove dead code related to
                   |to notifys                  |notifys
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #4)
> A second patch should remove the 2 columns notify_id and notify_level
> from the accountlines table.

But I am not familiar enough with this module to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:45:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:45:11 +0000
Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter
 and update master version number for 3.22.x
In-Reply-To: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17066-70-ijJaRUFXTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|NEW                         |Needs Signoff

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Same as 17013, but for 3.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:58:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:58:07 +0000
Subject: [Koha-bugs] [Bug 17085] New: Specify libmojolicious-perl min version
Message-ID: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085

            Bug ID: 17085
           Summary: Specify libmojolicious-perl min version
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Set min version for libmojolicious-perl to 6.0.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 12:58:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 10:58:28 +0000
Subject: [Koha-bugs] [Bug 17085] Specify libmojolicious-perl min version
In-Reply-To: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17085-70-mHHZgOKYxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:13:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:13:48 +0000
Subject: [Koha-bugs] [Bug 17085] Specify libmojolicious-perl min version
In-Reply-To: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17085-70-Qi73y7TyW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54195&action=edit
Bug 17085 - Specify libmojolicious-perl min version

Set min version for libmojolicious-perl to 6.0 and regenerate debian/control

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:15:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:15:25 +0000
Subject: [Koha-bugs] [Bug 17085] Specify libmojolicious-perl min version
In-Reply-To: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17085-70-yJbmzwmpmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
To test, apply patch, build package, install, check that correct version of
libmojolicious-perl is installed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:19:28 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-wTmaLYIuwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #10 from Lari Taskula <larit at student.uef.fi> ---
In case this test doesn't always return the same result, and fails sometimes,
you might be interested in this:

I applied many API-related patches on top of master and ran this test multiple
times. I noticed it didn't always have the same result; Swagger2 wasn't always
able to find the type of definition because for some reason $ref was left
unresolved for that definition - but after updating to the latest versions of
Swagger2 (0.83) and JSON::Validator (0.82), it now seems to work. Looks like
the author of JSON::Validator just patched some issues regarding to resolving
$refs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:39:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:39:26 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-KQtpSo3p0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:39:29 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-ml3sGN21Pb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #31 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54196&action=edit
Bug 13895: Reword borrowers to patrons in tags

We probably want to use patrons instead of borrowers; otherwise we would have
both tags since /patrons adds "patrons" as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:41:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:41:18 +0000
Subject: [Koha-bugs] [Bug 17086] New: Reword borrowers to patrons in Swagger
 tags for holds
Message-ID: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

            Bug ID: 17086
           Summary: Reword borrowers to patrons in Swagger tags for holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

Some routes for holds have tags called "borrowers". We should use "patrons"
instead in order not to have both (endpoints for patrons already add
"patrons").

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:44:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:44:42 +0000
Subject: [Koha-bugs] [Bug 17086] Reword borrowers to patrons in Swagger tags
	for holds
In-Reply-To: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17086-70-q6X1ESC0bG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54197&action=edit
Bug 17086: Reword borrowers to patrons in Swagger tags for holds

Routes for holds have tags called "borrowers". We should use "patrons" instead
in order not to have both (endpoints for patrons already add "patrons").

This patch changes the tags from borrowers to patrons in:
GET  /holds
POST /holds

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:44:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:44:40 +0000
Subject: [Koha-bugs] [Bug 17086] Reword borrowers to patrons in Swagger tags
	for holds
In-Reply-To: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17086-70-QDtWO1uXMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:45:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:45:21 +0000
Subject: [Koha-bugs] [Bug 17086] Reword borrowers to patrons in Swagger tags
	for holds
In-Reply-To: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17086-70-6pQ0sPaKMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:45:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:45:21 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete holds
In-Reply-To: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-10Dogfl8Wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17086


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086
[Bug 17086] Reword borrowers to patrons in Swagger tags for holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:51:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:51:13 +0000
Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to
 Koha::Patron->move_to_deleted
In-Reply-To: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16891-70-TbernwHjmf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #5)

> Could you confirm that it correctly works please?
> I have just retested and the cronjob script seems to work as expected.

I defer to Tom?s on the signoff, since I'm never confident that errors like
that aren't a configuration problem with my gitified package installation.
However, if there is more I can do to test I would be happy to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 13:53:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 11:53:22 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-ly9Vkz0qD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #10 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54198&action=edit
Bug 17005: Reword borrowers to patrons in Swagger tags for checkouts history

Routes for checkouts history have tags called "borrowers". We should use
"patrons"
instead in order not to have both (endpoints for patrons already add
"patrons").

This patch changes the tags from borrowers to patrons in:
GET  /checkouts/history
GET  /checkouts/history/{checkout_id}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:09:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:09:06 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-dzTEhoLB5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:09:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:09:09 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-TxZIPCc4Rb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54199&action=edit
Bug 17083 - Remove more event attributes from tools templates

This patch removes event attributes from several tool-related templates.
Events are defined instead in the JavaScript.

To test, apply the patch and:

- Go to Tools -> Label creator -> Manage -> Layouts and edit any layout.
  - In the "Font" setting, choose any font which includes the word
    "italic" or "oblique" in the name. Doing so should disable the
    "Oblique title" checkbox.
- Go to Tools -> Batch patron deletion/anonymization.
  - Submit the form without making any changes. You should be prompted
    to select an action.
- Go to Tools -> Inventory.
  - Select a batch of barcodes to upload.
  - Submit the form without selecting any filters. This should trigger a
    warning.
  - Also changed: Added Font Awesome icons to the "Select all" and
    "Clear all" links on the inventory results view.
- Go to Tools -> Notices and Slips.
  - Click "New notice"
  - Change the selection under "Koha module." The page should reload
    with the correct available message body fields. For instance,
    selecting "Holds" should make available reserves.* columns.
- Go to Tools -> Upload.
  - In the search form, enter a search term and click the 'Search'
    button. The form should submit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:15:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:15:20 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-5up6oHpioU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #47 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jacek Ablewicz from comment #46)
> I'll better open a separate bug report for that part.

I would be fine with having this form depend on browser-based validation using
the "required" attribute for now, and to consider another layer of JS
validation as a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:39:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:39:20 +0000
Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice
In-Reply-To: <bug-10472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10472-70-QceTTsetkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Srdjan Jankovic from comment #2)
> 
> Would you consider moving the query to C4::Acquisition please?

I don't think this is optional.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:46:28 +0000
Subject: [Koha-bugs] [Bug 14308] Remove CGI::checkbox from subfield editors
In-Reply-To: <bug-14308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14308-70-JkzatWyEjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14308

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Failed QA                   |RESOLVED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 15773 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:46:28 +0000
Subject: [Koha-bugs] [Bug 15773] Checkboxes do not work correctly when
 creating a new subfield for an authority framework
In-Reply-To: <bug-15773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15773-70-yK2NaGXgJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 14308 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:52:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:52:03 +0000
Subject: [Koha-bugs] [Bug 17087] New: Set Test::WWW::Mechanize version to
	1.42
Message-ID: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

            Bug ID: 17087
           Summary: Set Test::WWW::Mechanize version to 1.42
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org

This was set to a version that is not available in Wheezy or Jessie. The
version is not required, the only change to 1.42 (packaged for Wheezy and
Jessie) is a fix for Windows, see
http://cpansearch.perl.org/src/PETDANCE/Test-WWW-Mechanize-1.44/Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:52:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:52:20 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-WT9eddYkEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:54:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:54:13 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-e3pnSXJN6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54200&action=edit
Bug 17087 - Set Test::WWW::Mechanize version to 1.42

This was set to a version that is not available in Wheezy or Jessie.
The version is not required, the only change to 1.42 (packaged for
Wheezy and Jessie) is a fix for Windows, see
http://cpansearch.perl.org/src/PETDANCE/Test-WWW-Mechanize-1.44/Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:54:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:54:33 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-9uR4WImp7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:56:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:56:21 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-VDUO0qc6JY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54200|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54201&action=edit
Bug 17087 - Set Test::WWW::Mechanize version to 1.42

This was set to a version that is not available in Wheezy or Jessie.
The version is not required, the only change to 1.42 (packaged for
Wheezy and Jessie) is a fix for Windows, see
http://cpansearch.perl.org/src/PETDANCE/Test-WWW-Mechanize-1.44/Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 14:56:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 12:56:37 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-6TKksS56hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:07:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:07:17 +0000
Subject: [Koha-bugs] [Bug 17088] New: Bad MARC XML can halt export_records.pl
Message-ID: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

            Bug ID: 17088
           Summary: Bad MARC XML can halt export_records.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

If export_records.pl encounters a record that fails to load correctly as a
MARC::Record the export process will fail and only the records encountered up
to that point will be exported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:12:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:12:30 +0000
Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
In-Reply-To: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17088-70-0CkQpVzf7X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:12:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:12:32 +0000
Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
In-Reply-To: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17088-70-oHG7okkAXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54202&action=edit
Bug 17088 - Bad MARC XML can halt export_records.pl

If export_records.pl encounters a record that fails to load correctly as
a MARC::Record the export process will fail and only the records
encountered up to that point will be exported.

Test Plan:
1) Pick a record in your database, and replace the biblioitems.marcxml field
with some random characters
2) Export your records using the command:
   misc/export_records.pl  --format xml --record-type bibs --filename
/tmp/biblios.xml
3) Note you get an error and the script ends prematurely
4) Apply this patch
5) Repeat step 2
6) Note the full record set is exported ( except for your bad record )
7) Note an error is still generated for your bad record ( useful for
    tracking down bad records ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:12:41 +0000
Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
In-Reply-To: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17088-70-r2qU3EKC3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:12:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:12:44 +0000
Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
In-Reply-To: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17088-70-UakYm9RUi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:12:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:12:50 +0000
Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
In-Reply-To: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17088-70-Yv7IYxuf06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:21:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:21:10 +0000
Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments
In-Reply-To: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16899-70-20FzonIJ3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53275|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54203&action=edit
Bug 16899 - Add ability to disallow overpayments

Some SIP services ( such as Comprise ) require that an attempt at
over-paying a patron's account via SIP2 should fail, rather than create
a credit on the account. We should make this a configurable option on a
per-login basis in the SIP2 config file.

Test Plan:
1) Apply this patch
2) Enable the new parameter
   disallow_overpayment="1"
   for the login to be used in this test.
3) Restart your SIP server
4) Create or find a patron with fines
5) Attempt to send a payment via SIP for more than what the
   patron's balance is
6) Note the response indicates a payment failure
7) Attempt to send a payment via SIP for the account balance or
   less
8) Note the response indicates the payment has succeeded
9) Verify in Koha that the payment was processed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:34:17 +0000
Subject: [Koha-bugs] [Bug 12273] print entire list at once
In-Reply-To: <bug-12273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12273-70-15sK4Yt8MI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12273

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be working correctly now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:39:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:39:06 +0000
Subject: [Koha-bugs] [Bug 17089] New: Move the star ratings related code to
	Koha::Ratings
Message-ID: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

            Bug ID: 17089
           Summary: Move the star ratings related code to Koha::Ratings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

The subroutines in C4::Reviews are only doing CRUD operations.
This module can be moved easily to Koha::Reviews, especially as it already uses
DBIx::Class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:39:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:39:22 +0000
Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15449-70-5bLUMX2NEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bug 17089 - Move the star ratings related code to Koha::Ratings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:47:17 +0000
Subject: [Koha-bugs] [Bug 17090] New: Logged in user can't submit more than
	one review
Message-ID: <bug-17090-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17090

            Bug ID: 17090
           Summary: Logged in user can't submit more than one review
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: christian.stelzenmueller at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

A logged in user should be able to submit more than one review for a record, i.
e. to answer another comment / review. It would also help the staff to delete
the reviews seperately in the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:49:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:49:48 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-kBfiLpVOcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |frederic at tamil.fr
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:57:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:57:38 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-xHfigupd4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 15:57:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 13:57:40 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-uWBBmNDvJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54204&action=edit
Bug 16464 - If a patron has been discharged, show a message in the OPAC

This patch adds a message to the patron home page in the OPAC to be
shown if the user is restricted because of a discharge.

To test, apply the patch and log into the OPAC as a patron who has been
discharged.
 - You should see a message which says so, including a link to
   the discharge notice.
 - Log in to the OPAC as a patron with a manual restriction and confirm
   that the correct notice is displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:00:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:00:05 +0000
Subject: [Koha-bugs] [Bug 16395] New patron entry save panel wraps in an
	ugly way
In-Reply-To: <bug-16395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16395-70-JxFCGrVV0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16395

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This bug is no longer an issue because the patron edit form now uses a floating
toolbar instead of the panel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:07:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:07:05 +0000
Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev
 install ( follow-up for 16733)
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-Pjt1iqKz5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Plack: Handle multiple      |Improve PERL5LIB handling
                   |paths in PERL5LIB           |for packaged dev install
                   |                            |(follow-up for 16733)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:07:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:07:54 +0000
Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev
 install ( follow-up for 16733)
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-eTwUGtgF03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54205&action=edit
Bug 17049: Improve PERL5LIB handling for packaged dev install

This is a small follow-up for report 16033.
If you would have multiple paths in PERL5LIB from /etc/defaults,
adjust_paths_dev_install would agressively replace them for dev
installs.
This patch makes it remove usr/share/koha/lib only and add the
new dev install path.

Test plan:
[1] Apply the patches for 16033 and 17049.
[2] Add a <dev_install>/just/a/path</dev_install> to koha-conf.xml.
[3] Source the adjusted koha-functions.sh within your master clone:
    . debian/scripts/koha-functions.sh
[4] Enter unset PERL5LIB; adjust_paths_dev_install [your-clone]
[5] Check the result with echo $PERL5LIB. Should be /just/a/path.
[6] Try PERL5LIB=/usr/share/koha/lib
    Run adjust_paths_dev_install [your-clone]
    Check the result with echo $PERL5LIB. Should be /just/a/path.
[7] Similarly, try /a:/usr/share/koha/lib
    Expect: /just/a/path:/a
    And /a:/usr/share/koha/lib:/b. Expect: /just/a/path:/a:/b

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:08:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:08:15 +0000
Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev
 install ( follow-up for 16733)
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-d1EeciunZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:11:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:11:22 +0000
Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev
 install ( follow-up for 16733)
In-Reply-To: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17049-70-p58Fkt2kiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54205|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54206&action=edit
Bug 17049: Improve PERL5LIB handling for packaged dev install

This is a small follow-up for report 16733.
If you would have multiple paths in PERL5LIB from /etc/defaults,
adjust_paths_dev_install would agressively replace them for dev
installs.
This patch makes it remove usr/share/koha/lib only and add the
new dev install path.

Test plan:
[1] Apply the patches for 16733 and 17049.
[2] Add a <dev_install>/just/a/path</dev_install> to koha-conf.xml.
[3] Source the adjusted koha-functions.sh within your master clone:
    . debian/scripts/koha-functions.sh
[4] Enter unset PERL5LIB; adjust_paths_dev_install [your-clone]
[5] Check the result with echo $PERL5LIB. Should be /just/a/path.
[6] Try PERL5LIB=/usr/share/koha/lib
    Run adjust_paths_dev_install [your-clone]
    Check the result with echo $PERL5LIB. Should be /just/a/path.
[7] Similarly, try /a:/usr/share/koha/lib
    Expect: /just/a/path:/a
    And /a:/usr/share/koha/lib:/b. Expect: /just/a/path:/a:/b

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:13:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:13:43 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-lBpCROuaKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:13:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:13:46 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-IjYgktGjlG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54207&action=edit
Bug 17089: Koha::Ratings - Add Koha::Rating[s] classes

The subroutines in C4::Ratings are only CRUD operations.
This patch set moves the entire module to Koha::Rating[s] based on
Koha::Object[s]

Test plan for the whole patch set:
0/ Set OpacStarRatings to "results and details"
1/ Log in at the OPAC
2/ Launch a search, you should see the star ratings
3/ Go on a detail page, you should see the star ratings
4/ Rate the record
5/ Log in with another patron
6/ Go on the same detail page, you should see the previous rating
7/ Rate the racord, you should see "2 votes" and the average rating
value.
8/ Cancel your rate
9/ Disable JavaScript and repeat 7

Note: You cannot cancel your rate if JavaScript is disabled (not a
regression).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:13:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:13:50 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-LDF6LNZcFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54208&action=edit
Bug 17089: Koha::Ratings - move tests

Rewrite and move the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:13:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:13:59 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-fP0llGTQvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54209&action=edit
Bug 17089: Koha::Ratings - Remove AddRating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:05 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-qmY3sMTW3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54210&action=edit
Bug 17089: Koha::Ratings - Remove ModRating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:09 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-EeMJUI4Yoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54211&action=edit
Bug 17089: Koha::Ratings - Remove DelRating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:12 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-k6i8tlGQ5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54212&action=edit
Bug 17089: Koha::Ratings - Remove GetRating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:23 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-1aEXvnFvnR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|need subtitle on holds to   |Add subtitle to holds to
                   |pull                        |pull report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:29 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-mYTHCJDOP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:35 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-F6bySckor6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54213&action=edit
Bug 17089: Koha::Ratings - Remove C4::Ratings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:14:38 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-4ZLgpBBauM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54214&action=edit
Bug 17089: Mark out the boundaries of ratings

In the doc of C4::Ratings, it was written that the rate values should be
>=0 and <=5, but it was not taken into account.
This bug should be fixed on stable releases as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:17:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:17:45 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-JdT6wT27HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:17:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:17:47 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-J9CiOZ9tTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54215&action=edit
Bug 16991 - Add subtitle to holds to pull report

This patch adds output of subtitle to the holds to pull report using
keyword to MARC mapping information.

To test, apply the patch and go to Circulation -> Holds to pull. The
list of holds to pull should display subtitles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:24:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:24:38 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-zI0p6CLeTC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17090

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:24:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:24:38 +0000
Subject: [Koha-bugs] [Bug 17090] Logged in user can't submit more than one
	review
In-Reply-To: <bug-17090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17090-70-3WaUWBg976@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17090

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15839
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:37:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:37:14 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-ewsuchIkPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:39:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:39:05 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-The2NdmPFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54154|0                           |1
        is obsolete|                            |

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54216&action=edit
Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 16:39:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 14:39:39 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-5Y2lzS9J8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased last patch for Dependencies.pm (trivial)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:12:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:12:54 +0000
Subject: [Koha-bugs] [Bug 17091] New: Add AUTOLOAD to Koha::Objects
Message-ID: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

            Bug ID: 17091
           Summary: Add AUTOLOAD to Koha::Objects
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Up to now if a Koha::Objects based object needs to call DBIx::Class methods, we
have to create a new method for Koha::Objects, something like:
  sub method {
    my $self = shift;
    return $self->_resultset->method
  }

To simplify and ease the call to DBIx::Class method, we could create an
AUTOLOAD method.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:19:57 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-YJvWwrujtD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
I'm getting an error in the console when I try to cancel a rating:

Can't call method "rating_value" on an undefined value at
opac/opac-ratings-ajax.pl line 90

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:22:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:22:25 +0000
Subject: [Koha-bugs] [Bug 17092] New: Generate debian/ control with version
 numbers from PerlDependencies.pm
Message-ID: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092

            Bug ID: 17092
           Summary: Generate debian/control with version numbers from
                    PerlDependencies.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Proof of concept.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:22:38 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/ control with version
 numbers from PerlDependencies.pm
In-Reply-To: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17092-70-5VHyyCMOqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:23:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:23:52 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-QpMcTUR9Pi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:23:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:23:55 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-ILUNWsYzJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54217&action=edit
Bug 17091: Add AUTOLOAD to Koha::Objects

Up to now if a Koha::Objects based object needs to call DBIx::Class methods, we
have to create a new method for Koha::Objects, something like:
  sub method {
    my $self = shift;
    return $self->_resultset->method
  }

To simplify and ease the call to DBIx::Class method, this patch defines an
AUTOLOAD to call the DBIx::Class method on the resultset we are encapsulating.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:23:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:23:58 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-doLSlZoVvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54218&action=edit
Bug 17091: Remove explicit declaration of Koha::Objects->update

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:01 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-9z9jYG5MM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54219&action=edit
Bug 17091: Remove explicit declaration of Koha::Objects->count

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:05 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-x0WQ8p4wJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54220&action=edit
Bug 17091: Remove explicit declaration of Koha::Objects->pager

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:09 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-ASqSDheYXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54221&action=edit
Bug 17091: Remove explicit declaration of Koha::Objects->reset

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:24 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/ control with version
 numbers from PerlDependencies.pm
In-Reply-To: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17092-70-xUqieUD8rl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54222&action=edit
Bug 17092 Generate debian/control with version numbers from PerlDependencies.pm

Proof of concept.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:30 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-zp6aIDIR1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16961


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961
[Bug 16961] Add the Koha::Objects->update method
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:30 +0000
Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method
In-Reply-To: <bug-16961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16961-70-mnjjR7ajlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091
[Bug 17091] Add AUTOLOAD to Koha::Objects
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:24:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:24:41 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/ control with version
 numbers from PerlDependencies.pm
In-Reply-To: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17092-70-OdfeK6Za0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:27:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:27:04 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/ control with version
 numbers from PerlDependencies.pm
In-Reply-To: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17092-70-O6Io1N2jZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17087


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087
[Bug 17087] Set Test::WWW::Mechanize version to 1.42
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:27:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:27:04 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-1z89O7S1OU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17092


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092
[Bug 17092] Generate debian/control with version numbers from
PerlDependencies.pm
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:37:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:37:12 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-NhML7gVNXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54223&action=edit
Bug 17091: In a first phase, restrict the usage of AUTOLOAD in Koha::Objects

To make sure the methods will be covered by tests and devs won't
overused this method, I think it may be a good idea to restrict its
usage.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:37:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:37:55 +0000
Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP
In-Reply-To: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16899-70-SmPUYNKotS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to disallow     |Add ability to disallow
                   |overpayments                |overpayments via SIP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:39:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:39:03 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-fuuO8nA0WG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #11 from Mirko Tietgen <mirko at abunchofthings.net> ---
Possible test:

Use build-git-snapshot before applying the patch, see t/Creators.t fail.
Apply patch. Run build-git-snapshot again. t/Creators.t does not fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:39:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:39:23 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-zVLL6qqTtT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #137 from Owen Leonard <oleonard at myacpl.org> ---
These patches still apply cleanly and the QA issues seem fairly minor. Can
someone give it some attention?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:43:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:43:38 +0000
Subject: [Koha-bugs] [Bug 16346] Website should be translatable
In-Reply-To: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16346-70-ZF7DmyxzJA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16346

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Liz: I think you said on IRC that there was a bug in Polylang (IIRC). Is that
fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:50:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:50:03 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-SIdPhxqRjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #14 from Mirko Tietgen <mirko at abunchofthings.net> ---
Actually there is a nicer regex from the hackfest in greece at bug 16643.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:55:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:55:22 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-8b22h7lEeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:56:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:56:24 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16643-70-J6Rdh1PpR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52028|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54224&action=edit
Bug 16643 - Make debian/list-deps aware of Jessie folder structure

the old regex did not match the new folder structure

Rebased to depend on bug 17043

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:56:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:56:52 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16643-70-T6UVyBsJVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:57:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:57:08 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16643-70-rOhxK5d2b4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17043


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043
[Bug 17043] debian/list-deps fixes, master edition
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 17:57:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 15:57:08 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-um7E32dwDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16643


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643
[Bug 16643] Make debian/list-deps aware of Jessie folder structure
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:03:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:03:12 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16643-70-gdHUmxx35c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
You can test in a regex tester if the shorter regex matches the four examples
from the patch. https://regex101.com

/usr/lib/x86_64-linux-gnu/perl/5.20.2/POSIX.pm
/usr/lib/perl/5.14.2/POSIX.pm
/usr/lib/perl5/POSIX.pm
/usr/lib/x86_64-linux-gnu/perl5/5.20/YAML/Syck.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:07:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:07:17 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-6gOrQJyquI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:07:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:07:20 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-Q7gka1IDjQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54225&action=edit
Bug 17089: Improve errors handling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:09:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:09:25 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16643-70-5uUOsbiLym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54224|0                           |1
        is obsolete|                            |

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54226&action=edit
Bug 16643 - Make debian/list-deps aware of Jessie folder structure

the old regex did not match the new folder structure

Rebased to depend on bug 17043

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:11:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:11:09 +0000
Subject: [Koha-bugs] [Bug 17093] New: JavaScript error on patron entry page
 if toolbar is not displayed
Message-ID: <bug-17093-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17093

            Bug ID: 17093
           Summary: JavaScript error on patron entry page if toolbar is
                    not displayed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Under some circumstances the patron entry form and toolbar are not displayed by
memberentrygen.tt. For instance, if there are no libraries or patron categories
defined. If this happens a JavaScript error is triggered because a check for
#toolbar's position returns null.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:12:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:12:15 +0000
Subject: [Koha-bugs] [Bug 17094] New: Methods of Koha::Object[s] -based
 classed should not return DBIx::Class objects
Message-ID: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

            Bug ID: 17094
           Summary: Methods of Koha::Object[s]-based classed should not
                    return DBIx::Class objects
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

For instance the 2 methods get_shares and get_contents from Koha::Virtualshelf
return DBIx::Class objects instead of Koha::Virtualshelfshares and
Koha::Virtualshelfcontents objects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:12:26 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-0fw9pKDjdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17094


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094
[Bug 17094] Methods of Koha::Object[s]-based classed should not return
DBIx::Class objects
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:12:26 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-Uzjj1SamQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091
[Bug 17091] Add AUTOLOAD to Koha::Objects
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:14:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:14:47 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-UKoDzeHzx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:14:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:14:49 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-HPfHgp3ztv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54174|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54227&action=edit
[SIGNED-OFF] Bug 17082: Translatability: Fix sentence splitting in member.tt

This patch fixes sentences splitting in file
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

Fix is done with a new .inc file because the code is the same as in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

To test:
- Carefully review code changes
- Test on a fresh install without example data (or save database
  and test with empty tables 'branches' and 'categories')
- Go to Home > Patrons (members-home.pl)
- Verify that a warnings appears aubout missing libraries and patron
  categories
- Try to add a new patron (memberentry.pl)
- Verify that the same messages are triggered
- Verify that messages disappear as appropriate as soon as a library and
  a patron category are defined.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Note: Filed Bug 17093 for JS error on patron entry form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:18:05 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-5Qr8FeOYDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #15 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54228&action=edit
Bug 17043 - debian/list-deps fixes, 16.05 edition

This makes debian/list-deps ready for Debian Jessie
and adds small fixes I already use for package releases.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:20:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:20:21 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-oovksKjRgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #16 from Mirko Tietgen <mirko at abunchofthings.net> ---
Frederic: Above this is the first patch for 16.05. 16643 applies on top of it,
if you want to take that too. It's just a smaller regex and examples, but has
not been signed off yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:24:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:24:00 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-ZX3B7IxNWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #17 from Mirko Tietgen <mirko at abunchofthings.net> ---
Frederic: The third patch (Bug 17043 - Readonly deps) applies to 16.05.x and
should go in there. I will update the control file when it is pushed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:32:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:32:16 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-BC1IN58e1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:32:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:32:18 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-U1Ak8NSQtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54173|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54229&action=edit
[SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl

Numeric comparison operator is used where string comparison required,
resulting in the following warning in the log: 'Argument "delete" isn't
numeric in numeric eq (==).'

This patch corrects it to use 'eq' not '==' to compare strings.

To test, apply the patch and go to Acquisitions -> EDIFACT messages.

Delete an EDIFACT message. There should be no error in the error log.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:14 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-LT6xNpqepp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54207|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54230&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Add Koha::Rating[s] classes

The subroutines in C4::Ratings are only CRUD operations.
This patch set moves the entire module to Koha::Rating[s] based on
Koha::Object[s]

Test plan for the whole patch set:
0/ Set OpacStarRatings to "results and details"
1/ Log in at the OPAC
2/ Launch a search, you should see the star ratings
3/ Go on a detail page, you should see the star ratings
4/ Rate the record
5/ Log in with another patron
6/ Go on the same detail page, you should see the previous rating
7/ Rate the racord, you should see "2 votes" and the average rating
value.
8/ Cancel your rate
9/ Disable JavaScript and repeat 7

Note: You cannot cancel your rate if JavaScript is disabled (not a
regression).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:21 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-WB74yzqrHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54208|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54231&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - move tests

Rewrite and move the tests.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:28 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-xNHYKRsiAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54209|0                           |1
        is obsolete|                            |

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54232&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Remove AddRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:34 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-3zONnoEWW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54210|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54233&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Remove ModRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:40 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-TmewINd1Ci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54211|0                           |1
        is obsolete|                            |

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54234&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Remove DelRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:46 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-YmX2mFYBY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54212|0                           |1
        is obsolete|                            |

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54235&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Remove GetRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:40:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:40:54 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-g7oqPJEbI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54213|0                           |1
        is obsolete|                            |

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54236&action=edit
[SIGNED-OFF] Bug 17089: Koha::Ratings - Remove C4::Ratings

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:41:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:41:02 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-pVoTY6To4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54214|0                           |1
        is obsolete|                            |

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54237&action=edit
[SIGNED-OFF] Bug 17089: Mark out the boundaries of ratings

In the doc of C4::Ratings, it was written that the rate values should be
>=0 and <=5, but it was not taken into account.
This bug should be fixed on stable releases as well.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:41:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:41:08 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-qppQdqz26l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54225|0                           |1
        is obsolete|                            |

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54238&action=edit
[SIGNED-OFF] Bug 17089: Improve errors handling

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:41:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:41:58 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-x50hwL3HvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:52:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:52:04 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-1XU4GehzU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:52:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:52:07 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-5o5nM9flNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54239&action=edit
Bug 17094: Add delete to the Koha::Objects AUTOLOAD method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:52:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:52:10 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-xYnNoDpwYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54240&action=edit
Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects

Instead of DBIx::Class objects.

Test plan:
1/ Add content to a list and share it with another patron
2/ Try to view the list with the other patron
3/ download and send a shelf and check if the biblio list is correct
4/ prove t/db_dependent/Virtualshelves.t should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 18:57:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 16:57:25 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer
 alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-s06OOmFIGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Canceling a hold that has   |Canceling a hold awaiting
                   |been waiting too long from  |pickup no longer alerts
                   |Holds Awaiting Pickup no    |librarian about next hold
                   |longer alerts librarian     |
                   |about next hold             |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:02:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:02:24 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer
 alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-jhu1x8SEWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53840|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54241&action=edit
[SIGNED-OFF] Bug 17010 - Canceling a hold awaiting pickup no longer alerts
librarian about next hold

In previous versions of Koha, if a hold canceled from the "Holds over" tab had
other holds on it,
the librarian would be alerted with the message "This item is on hold for
pick-up at your library"
and directed to check it in to fill the next hold. This no longer happens.

Test Plan:
1) Apply this patch
2) Find a hold that has been waiting too long
3) Cancel that hold via waitingreserves.pl
4) Note you get the message "This item is on hold for pick-up at your library"
5) Confirm the ok button redirects you to the correct tab

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:02:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:02:36 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer
 alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-O1SsNP6n8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54242&action=edit
Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts
librarian about next hold

This patch makes a minor change to the markup to make the button in the
confirmation dialog conform to the appearance of similar buttons.

To test, follow the original test plan for this bug and verify that the
"OK" button in the dialog looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:20:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:20:13 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-n9ppGDIhXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:23:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:23:04 +0000
Subject: [Koha-bugs] [Bug 12436] koha-offline-circulation menu database and
 link on circulation page
In-Reply-To: <bug-12436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12436-70-V2memrOXhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12436

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:28:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:28:31 +0000
Subject: [Koha-bugs] [Bug 13310] Show hold count in staff catalog search
	results
In-Reply-To: <bug-13310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13310-70-HzkgY8oRRc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13310

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master
            Summary|Search.pl needs to show     |Show hold count in staff
                   |holds total                 |catalog search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:31:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:31:38 +0000
Subject: [Koha-bugs] [Bug 6760] Generate new card number on renewals and
 duplicate card issuance
In-Reply-To: <bug-6760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6760-70-lYswjbfT4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6760

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.6                         |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:51:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:51:47 +0000
Subject: [Koha-bugs] [Bug 13337] Change hold terms in OPAC
In-Reply-To: <bug-13337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13337-70-QQGjvlubAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13337

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:52:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:52:50 +0000
Subject: [Koha-bugs] [Bug 13309] opac-search.pl Holds count incorrect
In-Reply-To: <bug-13309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13309-70-q9USv0Ss5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13309

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 19:58:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 17:58:46 +0000
Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing
	card
In-Reply-To: <bug-12078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12078-70-TrRRuTBmeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
This bug was reported against an unsupported version of Koha and apparently
cannot be reproduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:05:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:05:39 +0000
Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve
In-Reply-To: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11979-70-7355GVzvjF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |master

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Is there a reason why the list of course reserves /shouldn't/ show the true
status of an item?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:06:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:06:26 +0000
Subject: [Koha-bugs] [Bug 13259] Set notforloan status when adding items to
 a course reserve
In-Reply-To: <bug-13259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13259-70-vjuhHfV5ma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.12                        |master
            Summary|add notforloan status when  |Set notforloan status when
                   |adding items on             |adding items to a course
                   |course_reserves/add_items.p |reserve
                   |l                           |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:09:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:09:52 +0000
Subject: [Koha-bugs] [Bug 6113] Keep previous ids when importing
 bibliographic and authority records
In-Reply-To: <bug-6113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-O3SWd2uXdR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|enhancement to keep         |Keep previous ids when
                   |previous ids                |importing bibliographic and
                   |                            |authority records
            Version|3.12                        |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:11:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:11:52 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-8FgeApojgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:29:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:29:41 +0000
Subject: [Koha-bugs] [Bug 11151] hold error message wrong if in transit
In-Reply-To: <bug-11151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11151-70-H0FrqU2kEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11151

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
            Version|3.12                        |master

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I can reproduce this in master. The error message still reads the same.
However, I can't see that anything is going wrong with transfers. If you revert
the waiting status to check out the transfer is marked as completed. So I think
the full extent of this bug is the text problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:39:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:39:00 +0000
Subject: [Koha-bugs] [Bug 13999] Going to a Patron Record After Deleting,
 doesn'  t present error message
In-Reply-To: <bug-13999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13999-70-gHjq0oM21F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13999

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Fixed in Bug 16082.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:47:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:47:03 +0000
Subject: [Koha-bugs] [Bug 17095] New: Regression: Error when checking out to
 non-existent patron
Message-ID: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

            Bug ID: 17095
           Summary: Regression: Error when checking out to non-existent
                    patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=X
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 16082, 'Display a friendly "patron does not exist" message if that's the
case - circulation.pl' changed the behavior of the checkout page so that if you
hit that page with a borrowernumber which doesn't exist a nice message will
tell you so.

Now when you do that you get an error message:

Can't call method "is_debarred" on an undefined value at /circ/circulation.pl
line 300.

git bisect blames Bug 16849, 'Move IsDebarred to Koha::Patron->is_debarred'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:48:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:48:36 +0000
Subject: [Koha-bugs] [Bug 6780] Log duplicate card issuance
In-Reply-To: <bug-6780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6780-70-ySNy2SJQh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6780

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.6                         |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 20:52:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 18:52:01 +0000
Subject: [Koha-bugs] [Bug 7503] OPAC fails WCAG 2.0 AA testing / search
 input field has no label
In-Reply-To: <bug-7503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7503-70-PPYlR1ma8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7503

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
3.16 is no longer maintained, so I'm marking this as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 21:10:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 19:10:31 +0000
Subject: [Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost.
In-Reply-To: <bug-15376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15376-70-SH3fOdoUH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376

Suzanne Fayle <sfayle at roseman.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sfayle at roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 21:10:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 19:10:55 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-bnYSw4F1JW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 21:10:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 19:10:58 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-bdFjEtCfUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54243&action=edit
Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist

Bug 16082, 'Display a friendly "patron does not exist" message if that's the
case - circulation.pl' changed the behavior of the checkout page so that if
you hit that page with a borrowernumber which doesn't exist a nice message will
tell you so.

Now when you do that you get an error message:
  Can't call method "is_debarred" on an undefined value at /circ/circulation.pl
line 300.

Test plan:
confirm that the friendly message is back :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 21:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 19:20:31 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-VogQoc2cmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> Tom?s, don't you think we should try and fill the interface column for
> existing values?

It could be done. I'm wondering how can we determine the source of the log. For
example regarding holds, or renewals. We should (maybe) have a cli script that
can be run anytime t ofix previous logs.

This should go to a separate bug IMHO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 22:59:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 20:59:51 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-NZd5054G9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54199|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54244&action=edit
[SIGNED-OFF]Bug 17083: Remove more event attributes from tools templates

This patch removes event attributes from several tool-related templates.
Events are defined instead in the JavaScript.

To test, apply the patch and:

- Go to Tools -> Label creator -> Manage -> Layouts and edit any layout.
  - In the "Font" setting, choose any font which includes the word
    "italic" or "oblique" in the name. Doing so should disable the
    "Oblique title" checkbox.
- Go to Tools -> Batch patron deletion/anonymization.
  - Submit the form without making any changes. You should be prompted
    to select an action.
- Go to Tools -> Inventory.
  - Select a batch of barcodes to upload.
  - Submit the form without selecting any filters. This should trigger a
    warning.
  - Also changed: Added Font Awesome icons to the "Select all" and
    "Clear all" links on the inventory results view.
- Go to Tools -> Notices and Slips.
  - Click "New notice"
  - Change the selection under "Koha module." The page should reload
    with the correct available message body fields. For instance,
    selecting "Holds" should make available reserves.* columns.
- Go to Tools -> Upload.
  - In the search form, enter a search term and click the 'Search'
    button. The form should submit.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised. Event attributes removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 23:00:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 21:00:04 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-f2EEf3coLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 23:43:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 21:43:22 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-CcYeY7u97V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 23:51:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 21:51:33 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-Wu2Qj4YeDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17097

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug  9 23:53:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 21:53:15 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-DVmyt7RgPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #12 from Liz Rea <liz at catalyst.net.nz> ---
You have no idea how relevant this was to me just now. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:03:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:03:59 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-x4ad1D46Wo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:04:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:04:02 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-5slFf6nWhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54156|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54245&action=edit
[PASSED QA] Bug 17069: Koha::Patron::Category->store must default
checkprevcheckout to 'inherit'

Creating a new patron category raises an error "An error occurred when updating
this patron category. Perhaps it already exists."
DBIx::Class does not default to the value defined at the DB devel if the
key checkprevcheckout has been passed to the constructor.
We may need to provide a global fix for this kind of issue: if a column
is defined as "not null" but has a default value, the constructor
(Koha::Object->new) should not pass it to the DBIx::Class constructor
(even if assuming that null means default is a terrible mysqlism).

Test plan:
Create a new patron category.

Works as expected.
Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:09:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:09:07 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-0d51qLqVSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|nightly at abunchofthings.net  |

--- Comment #13 from Mirko Tietgen <mirko at abunchofthings.net> ---
Timing is everything :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:17:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:17:10 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-aengOa2gfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:17:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:17:13 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-XTMtZjaTp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54229|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54248&action=edit
[PASSED QA] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl

Numeric comparison operator is used where string comparison required,
resulting in the following warning in the log: 'Argument "delete" isn't
numeric in numeric eq (==).'

This patch corrects it to use 'eq' not '==' to compare strings.

To test, apply the patch and go to Acquisitions -> EDIFACT messages.

Delete an EDIFACT message. There should be no error in the error log.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:22:28 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-qNrq32BwOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 00:22:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 09 Aug 2016 22:22:31 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-x7TK2HT93N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54227|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54249&action=edit
[PASSED QA] Bug 17082: Translatability: Fix sentence splitting in member.tt

This patch fixes sentences splitting in file
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

Fix is done with a new .inc file because the code is the same as in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

To test:
- Carefully review code changes
- Test on a fresh install without example data (or save database
  and test with empty tables 'branches' and 'categories')
- Go to Home > Patrons (members-home.pl)
- Verify that a warnings appears aubout missing libraries and patron
  categories
- Try to add a new patron (memberentry.pl)
- Verify that the same messages are triggered
- Verify that messages disappear as appropriate as soon as a library and
  a patron category are defined.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Note: Filed Bug 17093 for JS error on patron entry form.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 03:38:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 01:38:18 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-76u3HEgCvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #190 from Liz Rea <liz at catalyst.net.nz> ---
Hi,

Looks like this is not applying (however, it looks like an easy conflict to
fix)

Falling back to patching base and 3-way merge...
Auto-merging Koha/Patron.pm
CONFLICT (content): Merge conflict in Koha/Patron.pm

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 04:54:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 02:54:27 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-sZtfoaGmYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #191 from Liz Rea <liz at catalyst.net.nz> ---
Conflicts aside (which I sorted out just enough to test it - the only one I
didn't touch was the CSS one because that will sort itself out I think with a
new patch set) - I like this and think it's pretty awesome.

I'll be happy to test a rebased version of this.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 07:16:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 05:16:41 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-jKECTI1n0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 07:16:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 05:16:46 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-yHmd6odhsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #91 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54250&action=edit
Bug 7441: QA follow-up - Add note about missing NORMARC support

Adds a note about missing support for NORMARC (only supports
MARC21 and UNIMARC) to the system preference text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:21:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:21:33 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-K1BjX8F9QE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking at this again. 

Passes tests and QA test tools. 

I'd have preferred smaller steps here, it will take a while to work through
this as it touches all of the fines and fee related features:

  - recordpayment
  - makepayment
  - chargelostitem
  - manualinvoice
  - recordpayment_selectaccts
  - FixAccountForLostAndReturned
  - AddRenewal (rentals)
  - AddIssuingCharge (rentals)
  - UpdateFine (overdues)
  - AddReserve (hold fee)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:28:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:28:19 +0000
Subject: [Koha-bugs] [Bug 17098] New: Validation problems with form field
 type "number" ( decimal separator)
Message-ID: <bug-17098-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

            Bug ID: 17098
           Summary: Validation problems with form field type "number"
                    (decimal separator)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

With Koha language set to de-DE, it is not possible to enter numeric values
with decimal separator point like 5.00 if the input field is of type "numeric".
Validation requires comma (,)

Independently on Koha language and CurrencyFormat settings, you get an error
message (in German): "Bitte geben Sie eine Nummer ein."

To verify:
- Install language de-DE (alternatively use Firebug to manipulate page HTML to
<html lang="de-DE"> or to set lang="de-DE directly in form field).
- Go to /cgi-bin/koha/members/maninvoice.pl?borrowernumber=XXX ("Manuelle
Geb?hr")
- In field "Betrag:", enter 5.00
Result: Field border turns to red, field shows tooltip "Bitte geben Sie eine
Nummer ein."

Expected result: Point as decimal separator is accepted.

Same behaviour with it-IT, fr-FR, nl-NL

However if you set language to en or de-CH, both comma and point are accepted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:48:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:48:25 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-7vmwlzJQij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17098

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:48:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:48:25 +0000
Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type
 "number" ( decimal separator)
In-Reply-To: <bug-17098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17098-70-p71u8NLm27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12310

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
More information:

Discussion on IRC: http://irc.koha-community.org/koha/2016-08-09#i_1847065

Bug 12310 - Accept different monetary formats as input

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:51:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:51:35 +0000
Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve
In-Reply-To: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11979-70-Duhte1O0AU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, you are right - it should be the same as on the detail page I think.
Showing 'ordered' and all the other status.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:55:27 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-0VgPtxoknT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, this reads a bit like a duplicate to bug 14695 - can someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:56:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:56:58 +0000
Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for
 items on bib records
In-Reply-To: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5594-70-ba1vXZRCfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|default sort order for      |Option to configure default
                   |items on bib records        |sort order for items on bib
                   |                            |records

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 08:59:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 06:59:12 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-pVFtbpzGo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sandre, thx for explaining!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:01:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:01:26 +0000
Subject: [Koha-bugs] [Bug 17043] debian/list-deps fixes, master edition
In-Reply-To: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17043-70-7ABoHvCvhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043

--- Comment #18 from Fr?d?ric Demians <frederic at tamil.fr> ---
Thanks Mirko. I've picked patches 3 & 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:24:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:24:05 +0000
Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type
 "number" ( decimal separator)
In-Reply-To: <bug-17098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17098-70-nuIon6armn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Files with input type "numeric" (git grep --files-with-matches
'type="number"'):

Decimal:
koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt

Only digits (no problem):
koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:26:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:26:05 +0000
Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove
 GetAuthorisedValueCategories
In-Reply-To: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15803-70-hq7eRFKZLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52063|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54257&action=edit
Bug 15803: Koha::AuthorisedValues - Remove
C4::Koha::GetAuthorisedValueCategories

The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all
the authorised value categories.
We already have a method in the Koha::AuthorisedValues module to do this
job, let's use it!

Technical explanations:
The new subroutine of the AuthorisedValues TT plugin will allow to get
the authorised value categories from the templates.
The new html_helpers include file will get rid of the if selected else
end statements. Bug 15758 already uses this file, see the commit
description for more informations.

Test plan:
1/ Create or edit a new fund (aqbudgets.pl), the fields "statistic 1"
and "statistic 2" should be correctly filled with the list of authorised
value categories
2/ Edit subfields for a biblio and authority framework.
The "Authorized value" dropdown list should be correctly filled on both
pages
3/ Create new items search fields (from the administration area), same
as previously, the authorised value category dropdown list should be
correctly filled
4/ Add and edit patron attribute types, check the authorised value
category list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:48:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:48:29 +0000
Subject: [Koha-bugs] [Bug 17099] New: GetSupportName and GetSupportList from
 C4/ Koha.pm are no longer in used
Message-ID: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

            Bug ID: 17099
           Summary: GetSupportName and GetSupportList from C4/Koha.pm are
                    no longer in used
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Since bug 9468, these 2 subroutines are no longer in used and can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:49:05 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer in used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-PlvwODTa1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15779


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779
[Bug 15779] Remove unnecessary parts of C4::Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:49:05 +0000
Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha
In-Reply-To: <bug-15779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15779-70-kT1kP6cMWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17099


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099
[Bug 17099] GetSupportName and GetSupportList from C4/Koha.pm are no longer in
used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:50:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:50:34 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer in used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-p3f8vmJfcm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:50:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:50:37 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer in used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-imnwKVuDK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54258&action=edit
Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList

Since bug 9468, these 2 subroutines are no longer in used and can be
removed.

Test plan:
  git grep GetSupportName
and
  git grep GetSupportList
should not return entries (unless 1 in release notes)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 09:52:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 07:52:10 +0000
Subject: [Koha-bugs] [Bug 16796] Patron categories: Crash if enrolment date
	is not valid
In-Reply-To: <bug-16796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16796-70-GlYQdoMN9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16796

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:11:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:11:30 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-SbG7JswODc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Dead code (?) - sub         |Remove dead code "sub
                   |itemissues in               |itemissues" from
                   |C4/Circulation.pm           |C4/Circulation.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:17:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:17:17 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-p8cnA6eJvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:17:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:17:39 +0000
Subject: [Koha-bugs] [Bug 17100] New: On summary print,
 "Account fines and payments" is displaid even if there is nothing
 to pay
Message-ID: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

            Bug ID: 17100
           Summary: On summary print, "Account fines and payments" is
                    displaid even if there is nothing to pay
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If a patron got fines but the total is null (lost items then returned for
example), on print summary, there is a table "Account fines and payments" with
no lines in it.
There should be not table at all

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:18:29 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-8QUdxuF4An@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54259&action=edit
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm

To verify:
- git grep itemissues
Result: Appears in C4/Circulation.pm only

To test:
- apply patch
- git grep itemissues
Expected result: No occurences
- prove t/db_dependent/Circulation.t
Expected result: Pass OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:19:28 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-Bye8soBjEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:22:55 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displaid even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-XON30BcOCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

--- Comment #1 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 54260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54260&action=edit
Bug 17100 : Fix "Account fines and payments" diplay on patron's summary print

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:29:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:29:54 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displaid even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-Z5w9G8xuS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Test plan :

* without patch
  1/ find a patron with no lines in accountlines table : print summary shows no
"account fines and payments" => OK
  2/ find a patron with some lines in accountlines table and the total amount >
0 : print summary shows a table "account fines and payments" with fines to
recover => OK
  3/ find a patron with some lines in accountlines table but the total amount =
0 : print summary shows a table "account fines and payments" with nothing in it
=> NOK

* with the patch, same cases as before :
  1/ same as without patch
  2/ same as without patch
  3/ print summary does not show "account fines and payments"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 10:40:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 08:40:52 +0000
Subject: [Koha-bugs] [Bug 15661] Serials related pages miss a checkin tab
In-Reply-To: <bug-15661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15661-70-7YnhQNAvbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15661

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 11:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 09:47:55 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displaid even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-bfCaWayI5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Hi Sophie,

Your patch did not work for me becuase some more logic is needed in the
template file. Additionally, I encountred formatting problems.

Alternative patch follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 11:48:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 09:48:53 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displaid even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-rAqbAaH6x0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 54261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54261&action=edit
Bug 17100: [Alternative patch] Fix issues for on summary print

This alternative patch moves logic and formatting to the template file.

To test:
- Follow test plan in comment #2
- Additionally, verify that formatting follows syspref 'CurrencyFormat'
- Verify that amount column is right-aligned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 11:55:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 09:55:19 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-SbDofYJJuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #30 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
So, I'm not able to grasp the problems in swagger splitting specifications.
Since the specs seem to be maintained, it's probably best to minify before
validation, so the $ref problem is gone. The main point is to keep the specs in
an understandable (and patchable) structure.

Anyways, I still disagree on the automatic minifying. It has no place in
production code, since the specs should be static there in any case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 12:24:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 10:24:27 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-ymOEB1j7Mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52909|0                           |1
        is obsolete|                            |
  Attachment #52910|0                           |1
        is obsolete|                            |
  Attachment #52911|0                           |1
        is obsolete|                            |

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54262&action=edit
Bug 7595 - Add branchcode to accountlines

Adds a branchcode column to the accountlines table. For payments,
this inserts the branchcode of the library where the payment was
recorded. For manual invoices, it insert the branchcode of the
library where the manual invoice was created.

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

I tested with creating manual invoices, and paying partial fines,
entire fine lines, and writing off fines. All actions record the
branch where the action took place properly.

Signed-off-by: Marc Veron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 12:50:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 10:50:19 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-gX1480k98Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54263&action=edit
Bug 7595 - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 12:50:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 10:50:30 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-T3DyvE0UDz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54264&action=edit
Bug 7595 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:10:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:10:52 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-l7yDZsM3WW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:10:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:10:54 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-AqqxWX8juJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54201|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54265&action=edit
Bug 17087 - Set Test::WWW::Mechanize version to 1.42

This was set to a version that is not available in Wheezy or Jessie.
The version is not required, the only change to 1.42 (packaged for
Wheezy and Jessie) is a fix for Windows, see
http://cpansearch.perl.org/src/PETDANCE/Test-WWW-Mechanize-1.44/Changes

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:11:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:11:30 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-MM5dS5Zcvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Taking the liberty to promote this trivial change to PQA directly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:16:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:16:39 +0000
Subject: [Koha-bugs] [Bug 17101] New: Confirm a question before check in
Message-ID: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

            Bug ID: 17101
           Summary: Confirm a question before check in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: T.Reimann95 at gmx.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Here should be a new option for checkin message by itemtypes implemented. This
new option required a confirmation from the user (over a question which is
written there) bevor the item is checked in. The only possible answer for the
question are yes or no. By yes the item is checked in, by no it's not checked
in. 
To give an example what is meant here: If you create the item type audiobook,
you then can add the Check in Message : "Does envelope and content match?" and
for the check in message type: question. So if now a item with the item type
audiobook is checked in, the user is ask : "Does envelope and content match?"
and got the answer possibiltys yes and no. At this moment he can't read a new
barcode, so he must answer the question. If he answer yes the item is check in,
if he answer no the item is not check in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:17:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:17:47 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-UTvxdBD8rw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |T.Reimann95 at gmx.de
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:38:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:38:29 +0000
Subject: [Koha-bugs] [Bug 9490] Show responsibility statement (245c) under
 title and move authors down in OPAC XSLT
In-Reply-To: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9490-70-jZlHZ3e9b8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:38:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:38:30 +0000
Subject: [Koha-bugs] [Bug 9490] Show responsibility statement (245c) under
 title and move authors down in OPAC XSLT
In-Reply-To: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9490-70-cBinasDDN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14844|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:38:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:38:32 +0000
Subject: [Koha-bugs] [Bug 9490] Show responsibility statement (245c) under
 title and move authors down in OPAC XSLT
In-Reply-To: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9490-70-BjKRhUoUUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14845|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:40:27 +0000
Subject: [Koha-bugs] [Bug 9490] Show responsibility statement (245c) under
 title and move authors down in OPAC XSLT
In-Reply-To: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9490-70-5UZlse9ops@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13381
             Status|In Discussion               |RESOLVED

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Revisiting this discussion again, I think that bug 13381 (adding the
responsibiliby statement to results display) makes it no longer necessary to
keep this open.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:40:27 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-mySrhNxF7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9490

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:51:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:51:34 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-g0fzdF7HBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|On summary print, "Account  |On summary print, "Account
                   |fines and payments" is      |fines and payments" is
                   |displaid even if there is   |displayed even if there is
                   |nothing to pay              |nothing to pay

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 13:53:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 11:53:14 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-bcDnw0tl3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:06:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:06:55 +0000
Subject: [Koha-bugs] [Bug 13148] Should we have perl core modules in
 PerlDependencies.pm ?
In-Reply-To: <bug-13148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13148-70-gOpU4xo2lF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13148

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:07:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:07:03 +0000
Subject: [Koha-bugs] [Bug 13148] Should we have perl core modules in
 PerlDependencies.pm ?
In-Reply-To: <bug-13148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13148-70-Pd71WoKBc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13148

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:20:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:20:52 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer in used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-Cyq41JtEOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54258|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54267&action=edit
Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList

Since bug 9468, these 2 subroutines are no longer in used and can be
removed.

Test plan:
  git grep GetSupportName
and
  git grep GetSupportList
should not return entries (unless 1 in release notes)

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:21:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:21:20 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-a1tGhTBnUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
            Summary|GetSupportName and          |GetSupportName and
                   |GetSupportList from         |GetSupportList from
                   |C4/Koha.pm are no longer in |C4/Koha.pm are no longer
                   |used                        |used
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:28:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:28:59 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-FwFECGNWm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #31 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Benjamin Rokseth from comment #30)
> The main point is to keep the specs in an understandable (and patchable) 
> structure.
Completely agree on this.

It's unfortunate that Swagger has limitations that make it more complicated for
us.

> Anyways, I still disagree on the automatic minifying. It has no place in
> production code, since the specs should be static there in any case.
Perhaps it could be parametrized to be enabled / disabled, but for now I think
the best action is to obsolete that patch.

Thanks for your comments and engagement in discussion both here and GitHub,
Benjamin, I really appreciate it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:30:25 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-ACmKxbIbNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52985|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:33:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:33:03 +0000
Subject: [Koha-bugs] [Bug 17102] New: Automatically minify swagger.json
Message-ID: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

            Bug ID: 17102
           Summary: Automatically minify swagger.json
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

Since Bug 16212 introduces a minification script, it could be useful for
developers to have their specification automatically minified without the need
to run minifier for each modification.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:35:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:35:22 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-9kI6IGgZDe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17102


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102
[Bug 17102] Automatically minify swagger.json
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:35:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:35:22 +0000
Subject: [Koha-bugs] [Bug 17102] Automatically minify swagger.json
In-Reply-To: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17102-70-UFaSIXIwTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212
[Bug 16212] Swagger specification separation and minification
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:35:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:35:41 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-rDlbPnCVUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:35:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:35:44 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-qEcGUVmmMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54243|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54268&action=edit
[SIGNED-OFF] Bug 17095: (bug 16849 follow-up) Fix regression if patron does not
exist

Bug 16082, 'Display a friendly "patron does not exist" message if that's the
case - circulation.pl' changed the behavior of the checkout page so that if
you hit that page with a borrowernumber which doesn't exist a nice message will
tell you so.

Now when you do that you get an error message:
  Can't call method "is_debarred" on an undefined value at 
 /circ/circulation.pl line 300.

Test plan:
confirm that the friendly message is back :)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:36:39 +0000
Subject: [Koha-bugs] [Bug 17102] Automatically minify swagger.json
In-Reply-To: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17102-70-07KVn7WNfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54269&action=edit
Bug 17102: Automatically minify swagger.json

This patch adds automatic minification of swagger.json. Since startup
subroutine
is executed on each call to REST API, we need to be careful to not do useless
computation by minificating swagger.json when not required. Therefore, we need
some algorithm to determine whether minification is needed. In this patch,
minification is executed in two cases:
1. swagger.min.json does not exist
2. any of the specification files is modified more recently than
   swagger.min.json

Includes tests.

This feature requires Apache user to have write permissions to
swagger.min.json,
otherwise we cannot minify the specification automatically. Another solution is
to run the minifySwagger.pl manually after each modification or create a daemon
that listens to file modifications via "inotify" and executes minification when
needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:37:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:37:20 +0000
Subject: [Koha-bugs] [Bug 17102] Automatically minify swagger.json
In-Reply-To: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17102-70-zVYnMcvMMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Perhaps some parametrization is needed, it is probably not a good idea to run
this in production.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:38:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:38:49 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-HSOqBK95KL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #32 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Lari Taskula from comment #31)
> > Anyways, I still disagree on the automatic minifying. It has no place in
> > production code, since the specs should be static there in any case.
> Perhaps it could be parametrized to be enabled / disabled, but for now I
> think the best action is to obsolete that patch.
Moved to Bug 17102.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:40:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:40:31 +0000
Subject: [Koha-bugs] [Bug 5621] Google Translation for indian languages.
In-Reply-To: <bug-5621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5621-70-CAtsJdBHSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5621

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:41:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:41:16 +0000
Subject: [Koha-bugs] [Bug 13032] Feature Request -- command line switch to
 add page breaks to overdue_notices.pl
In-Reply-To: <bug-13032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13032-70-B4OVCI7fr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13032

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:48:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:48:26 +0000
Subject: [Koha-bugs] [Bug 8951] Patron Card Creator_How many words for a
	text field
In-Reply-To: <bug-8951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8951-70-pbr0TQnJPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8951

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This report against a long-unmaintained version has had no activity for years.
I'm going to assume it's invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 14:54:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 12:54:26 +0000
Subject: [Koha-bugs] [Bug 12950] Add Multiple Items adds too many items
In-Reply-To: <bug-12950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12950-70-jdgQdmUwwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12950

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:08:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:08:24 +0000
Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list
In-Reply-To: <bug-11029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11029-70-3MNUOZdAUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:09:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:09:27 +0000
Subject: [Koha-bugs] [Bug 9814] KohaAdminEmailAddress syspref webpage field
 doesn' t handle double quotes
In-Reply-To: <bug-9814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9814-70-WWb3wY3RtE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9814

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:13:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:13:28 +0000
Subject: [Koha-bugs] [Bug 13565] Several "DBD::mysql::db do failed" during
 upgrade from 3.14.x to 3.18.x
In-Reply-To: <bug-13565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13565-70-mKgF8JJL4P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13565

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Neither 3.14.x or 3.18.x is maintained any longer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:13:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:13:32 +0000
Subject: [Koha-bugs] [Bug 17069] Can't create new patron category on the
	intranet
In-Reply-To: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17069-70-X2w5XdHWiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:14:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:14:48 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-TAWAEZMnAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #92 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:17:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:17:01 +0000
Subject: [Koha-bugs] [Bug 11485] serial renew doing wonky things
In-Reply-To: <bug-11485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11485-70-vC1YOacLLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11485

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:19:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:19:02 +0000
Subject: [Koha-bugs] [Bug 14009] Circulation Branchcode Error
In-Reply-To: <bug-14009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14009-70-YyCvoPnOCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14009

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 OS|Linux                       |All
             Status|NEW                         |RESOLVED
           Hardware|HP                          |All
           Severity|enhancement                 |normal

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
It seems likely that this was a local problem rather than a Koha bug. In any
case, 3.14 is no longer maintained.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:21:39 +0000
Subject: [Koha-bugs] [Bug 10977] Connexion Gateway: biblios not importing as
	a batch
In-Reply-To: <bug-10977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10977-70-B8IOBSxGHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10977

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
There has been no activity on this report since it was originally reported
three years ago. The report is on an unmaintained version of Koha, so I'm
closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:22:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:22:52 +0000
Subject: [Koha-bugs] [Bug 10148] 007 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-PV7I9aXyzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:24:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:24:00 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-yMlX0ayYk8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:25:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:25:11 +0000
Subject: [Koha-bugs] [Bug 13765] Only serial issue can be deleted causing
	error
In-Reply-To: <bug-13765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13765-70-DyYQDTxXX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13765

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:27:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:27:18 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-kKp0U0UhJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54261|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 54270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54270&action=edit
Bug 17100: [Alternative patch] Fix issues for on summary print

This alternative patch moves logic and formatting to the template file.

To test:
- Follow test plan in comment #2
- Additionally, verify that formatting follows syspref 'CurrencyFormat'
- Verify that amount column is right-aligned

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:29:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:29:37 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-Em5FftYHZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:33:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:33:27 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-tnM7elF3wj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
> This should go to a separate bug IMHO.

I agree, it would make more sense as a separate bug and patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:37:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:37:22 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-gYvBdTvVo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Fr?d?ric!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:38:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:38:17 +0000
Subject: [Koha-bugs] [Bug 12910] Confirming a hold with branch transfer
 clears Return Date
In-Reply-To: <bug-12910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12910-70-UVYkxmt64t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12910

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:38:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:38:55 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-4mpl6pEx1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:43:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:43:32 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-B6m6qsOM5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:43:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:43:34 +0000
Subject: [Koha-bugs] [Bug 14218] Error in adding child fund
In-Reply-To: <bug-14218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14218-70-qNQP75nYpf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14218

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:47:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:47:46 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-zDWC9ZhV2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Would it not be simpler to pass the parameter timeformat => '24hr' to
output_pref instead of using an external lib?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:50:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:50:09 +0000
Subject: [Koha-bugs] [Bug 17082] Translatability: Fix sentence splitting in
	member.tt
In-Reply-To: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17082-70-9sj8Aa6YzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:51:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:51:47 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-jaFCEHWzAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:52:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:52:55 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-ERJWcjkkiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Eric!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:54:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:54:17 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-l3B8qq9tah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:54:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:54:58 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-IZLbnwCIxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:55:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:55:13 +0000
Subject: [Koha-bugs] [Bug 14219] Error in receiving books
In-Reply-To: <bug-14219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14219-70-qiXutvElOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14219

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This does not appear to be valid in master anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 15:58:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 13:58:58 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-qRwk2FJg4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:03:03 +0000
Subject: [Koha-bugs] [Bug 6439] In cataloguing all subfields are displayed,
 even with hidden=0
In-Reply-To: <bug-6439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6439-70-ZMGkuWPw0m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6439

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:03:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:03:44 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-iuodAO76Q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:09:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:09:02 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-mglUXMx4qX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:09:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:09:46 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-vhn4q4rDAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
  Attachment #54160|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:10:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:10:37 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-MBm39EmKov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:10:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:10:57 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-s63MAQDGO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

--- Comment #8 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 54271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54271&action=edit
Bug 13914 : Fix UNION in SQL request for reserves statistics

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:11:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:11:34 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-wjxYczT9zZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:12:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:12:35 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-6jtiy9Xjy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:15:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:15:24 +0000
Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display
 translated itemtype
In-Reply-To: <bug-16989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16989-70-JyucNrwcNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:16:23 +0000
Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in
 reports-home.tt
In-Reply-To: <bug-16964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16964-70-xDQyKgcSoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:17:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:17:28 +0000
Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing &rsaquo;
 from breadcrumbs
In-Reply-To: <bug-16953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16953-70-exkjHG6Shs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:17:52 +0000
Subject: [Koha-bugs] [Bug 12362] Branch transfer records orphaned on
	cancelled holds
In-Reply-To: <bug-12362-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12362-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12362-70-IJgbzGep5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
If a transfer has been initiated because of a hold I would expect the transfer
to remain in effect until completed by a check-in:

1. Hold is placed by patron at Library A.
2. Item is checked in at Library B and transfer is initiated.
3. Item is sent out for deliver to Library A.
4. Hold is canceled.
5. Item is delivered to Library A.
6. Item is checked in, completing the original transfer.
7. At the same time, a new transfer is initiated to return the item to its home
at Library B.

This is how it's working right now and that seems correct to me. Is this not
the behavior which was observed in version 3.14.x, or do I misunderstand the
problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:19:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:19:21 +0000
Subject: [Koha-bugs] [Bug 16944] Add "email" and "url" classes when edit or
 create a vendor
In-Reply-To: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16944-70-hvUDnDRLoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:29:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:29:12 +0000
Subject: [Koha-bugs] [Bug 13546] Branch transfer records orphaned when an
 item is withdrawn
In-Reply-To: <bug-13546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13546-70-NlGcW5U3Fu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13546

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think this raises some of the same questions as Bug 12362 in terms of trying
to understand what might be physically happening to items which have an open
transfer.

I think it's also important to consider the fact that Koha has, as far as I
know, no official definition of what 'withdrawn' should mean in functional
terms.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:30:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:30:31 +0000
Subject: [Koha-bugs] [Bug 11623] Errors with upgrade from 3.00.00.070 to
	3.14.02.000
In-Reply-To: <bug-11623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11623-70-NLAkhHypAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11623

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|In Discussion               |RESOLVED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
I think 3.14 is old enough now that this report doesn't need to stay open.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:31:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:31:52 +0000
Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
In-Reply-To: <bug-8897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8897-70-sJkwf3mtvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.12                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:35:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:35:16 +0000
Subject: [Koha-bugs] [Bug 2629] Diacritics not being ignored when searching
In-Reply-To: <bug-2629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2629-70-fUVTHuCugO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|In Discussion               |RESOLVED

--- Comment #46 from Owen Leonard <oleonard at myacpl.org> ---
To my understanding this may be valid if you are not using ICU, but it would
probably be better to address specific issues in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:38:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:38:33 +0000
Subject: [Koha-bugs] [Bug 7879] Memoize::Memcached two times slower than it
	should be
In-Reply-To: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7879-70-28cVAl1rRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|In Discussion               |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This report was made on a very old version of Koha and hasn't been updated
since. I think we should consider it closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:38:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:38:34 +0000
Subject: [Koha-bugs] [Bug 7119] general code-cleaning,
	tidy/whitespace omnibus
In-Reply-To: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7119-70-cMmkG3g8RZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119
Bug 7119 depends on bug 7879, which changed state.

Bug 7879 Summary: Memoize::Memcached two times slower than it should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:43:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:43:22 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-ytKb3uRvZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54217|0                           |1
        is obsolete|                            |

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54272&action=edit
[SIGNED-OFF]Bug 17091: Add AUTOLOAD to Koha::Objects

Up to now if a Koha::Objects based object needs to call DBIx::Class methods, we
have to create a new method for Koha::Objects, something like:
  sub method {
    my $self = shift;
    return $self->_resultset->method
  }

To simplify and ease the call to DBIx::Class method, this patch defines an
AUTOLOAD to call the DBIx::Class method on the resultset we are encapsulating.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:43:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:43:40 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-8QUBD6LDoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #8 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54273&action=edit
[SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->update

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:43:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:43:59 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-rVVTamj8AE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54218|0                           |1
        is obsolete|                            |
  Attachment #54219|0                           |1
        is obsolete|                            |

--- Comment #9 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54274&action=edit
[SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->count

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:44:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:44:30 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-vDHmumnTSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54220|0                           |1
        is obsolete|                            |
  Attachment #54221|0                           |1
        is obsolete|                            |
  Attachment #54223|0                           |1
        is obsolete|                            |

--- Comment #10 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54275&action=edit
[SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->pager

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:44:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:44:36 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-9DRwqhPymW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #11 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54276&action=edit
[SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->reset

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:44:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:44:41 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-O7lpJWf97t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

--- Comment #12 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54277&action=edit
[SIGNED-OFF]Bug 17091: In a first phase, restrict the usage of AUTOLOAD in
Koha::Objects

To make sure the methods will be covered by tests and devs won't
overused this method, I think it may be a good idea to restrict its
usage.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
AUTOLOAD added. No Koha QA errors. Test passed successfully

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:45:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:45:31 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-rE9Vg7b5Ue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:45:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:45:48 +0000
Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type
In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13990-70-I8c70zPat8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Although this doesn't seem to generate an error anymore, it is still the case
that id_type is required.

/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=4456

...returns:

<LookupPatron>
  <message>PatronNotFound</message>
</LookupPatron>

/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=4456&id_type=borrowernumber

...returns:

<LookupPatron>
  <id>4456</id>
</LookupPatron>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:52:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:52:28 +0000
Subject: [Koha-bugs] [Bug 14381] viewlog bug
In-Reply-To: <bug-14381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14381-70-6pEYmbNbtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14381

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:54:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:54:08 +0000
Subject: [Koha-bugs] [Bug 7879] Memoize::Memcached two times slower than it
	should be
In-Reply-To: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7879-70-zIJZcaJeVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16770

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #2)
> This report was made on a very old version of Koha and hasn't been updated
> since. I think we should consider it closed.

Bug 16770 removed this dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 16:54:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 14:54:08 +0000
Subject: [Koha-bugs] [Bug 16770] Remove wrong uses of Memoize::Memcached
In-Reply-To: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16770-70-qKEULpjMtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7879

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:03:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:03:38 +0000
Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the
 BarcodeInputFilter option
In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13763-70-1LezPqXXuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Still valid in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:05:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:05:25 +0000
Subject: [Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when
 cataloging a biblio
In-Reply-To: <bug-6590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6590-70-1nfkrrw4o5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.6                         |master
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:16:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:16:30 +0000
Subject: [Koha-bugs] [Bug 8891] "Long overdue (lost)" items in search
 results show garbled information
In-Reply-To: <bug-8891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8891-70-YGjC5jnDve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8891

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be working in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:22:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:22:36 +0000
Subject: [Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can
 result in duplicate holds
In-Reply-To: <bug-4054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4054-70-2CHxsss8qF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marc V?ron from comment #15)

> Hmm, if I have a JavaScript alert e.g. 
> "- This patron had already placed a hold on this item"
> and I click OK, I get an endless wait cursor!

This issue is still valid, but is unrelated to this bug report. The original
bug reported here is fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:22:38 +0000
Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the
 OPAC and Intranet to prevent duplicate data
In-Reply-To: <bug-7556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7556-70-VSEYXq9n5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556
Bug 7556 depends on bug 4054, which changed state.

Bug 4054 Summary: Double-clicking the 'place hold' button can result in duplicate holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:30:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:30:08 +0000
Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the
 OPAC and Intranet to prevent duplicate data
In-Reply-To: <bug-7556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7556-70-O8S12G36SO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Liz Rea from comment #0)
> We should probably use this on most submission forms in the OPAC.

Note that it has since been added to the place hold form in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:32:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:32:15 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn' t work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-FXNz3koUkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:32:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:32:18 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn' t work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-p7UJgSyNKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46381|0                           |1
        is obsolete|                            |

--- Comment #11 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> ---
Created attachment 54278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54278&action=edit
Bug 12586 - Record matching rules - Required match checks doesn't work with
MARCXML (follow-up)

The follow-up fixes a typo ('auth' to 'authority') and removes 'target_result'
and 'target_biblio'
which were introduced, seemingly unnecessarily, by the first patch in the set.

Signed-off-by: Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:43:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:43:37 +0000
Subject: [Koha-bugs] [Bug 11199] 008 value builder skips invalid characters
 and collapses remaining data
In-Reply-To: <bug-11199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11199-70-3R2rcfhtbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11199

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.12                        |master
           Severity|enhancement                 |normal

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This is still valid in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:52:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:52:01 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-4sN10wZjc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

--- Comment #9 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 54279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54279&action=edit
Bug 13914 : Fix UNION in SQL request for reserves statistics

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:55:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:55:41 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-Tp239iSoWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m
  Attachment #54271|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:56:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:56:10 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-2Od6lRI9TU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37267|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 17:57:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 15:57:28 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-oaYKaVPQyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:02:58 +0000
Subject: [Koha-bugs] [Bug 6868] Need a script to fix bad accountno data in
	accountlines
In-Reply-To: <bug-6868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6868-70-IGH5Q2WGzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
I think the version which caused this problem is old enough that we can close
this bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:06:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:06:34 +0000
Subject: [Koha-bugs] [Bug 14447] Show the vol./ no. on the child record
 based from the host entry
In-Reply-To: <bug-14447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14447-70-tqblGLJe1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14447

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Is this bug still valid? If so please update the version information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:07:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:07:43 +0000
Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for
 the same patron
In-Reply-To: <bug-12085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12085-70-BWFhWGfUGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:10:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:10:33 +0000
Subject: [Koha-bugs] [Bug 13671] Search returning empty
In-Reply-To: <bug-13671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13671-70-TqqAadjFth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|In Discussion               |RESOLVED

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
I think this report must be considered invalid unless someone can provide
additional details about reproducing the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:10:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:10:53 +0000
Subject: [Koha-bugs] [Bug 15191] Serials display improvements
In-Reply-To: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15191-70-tCQZndeG3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:11:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:11:59 +0000
Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/ page for
 terms and conditions of use in the opac
In-Reply-To: <bug-13376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13376-70-U9g0AUElu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:12:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:12:13 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-5dGbvYegJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

--- Comment #10 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
This patch fixes how the SQL request is built.
Union must be done before aggregation and not after, you have 2 results for
each value and not the sum of it.

Test plan
=========
On Reports > reservations, select all statuses as line, pickup library as
column (empty) and a range of hold date. Keep the results
Run the same reports but with statuses as column and pickup library as line
You should get the same results on another display.

* Without patch, if you've got representative data, most of the time you can
observe significant differences between both results

* With the patch, results are always the same (and right if you request
directly your database)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:17:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:17:02 +0000
Subject: [Koha-bugs] [Bug 11348] Wrong unavailability information for 'on
 hold' items in staff client result list
In-Reply-To: <bug-11348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11348-70-XcFdNRMEIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11348

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't appear to be valid in master anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:20:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:20:20 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-JSUuxqlRAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |larit at student.uef.fi
                 CC|                            |larit at student.uef.fi
             Status|Signed Off                  |ASSIGNED

--- Comment #23 from Lari Taskula <larit at student.uef.fi> ---
This one needs a bit more work. For example "allow-owner" is now only checking
against "borrowernumber", but we also need to be able to figure out ownership
e.g. from a checkout_id. Also, these patches need to be rebased on top of
master because there are already changes in API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:34:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:34:58 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-cKbiajLnma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

--- Comment #5 from Eric Phetteplace <ephetteplace at cca.edu> ---
It looks like a duplicate to me, too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:49:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:49:03 +0000
Subject: [Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors
	account
In-Reply-To: <bug-15143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15143-70-o8KuxSo5da@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This might be fixed by Bug 12446. It could also be fixed if someone offers a
solution to Bug 12949.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:52:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:52:59 +0000
Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link
	to guarantor
In-Reply-To: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12949-70-oITi5pDC1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12446

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
The way this works hasn't changed in master, but any automatic guarantor
removal will have to take Bug 12446 into consideration (if 12446 makes it in).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:52:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:52:59 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-cmxjMniMI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12949

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:53:09 +0000
Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link
	to guarantor
In-Reply-To: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12949-70-wbN9q5GaNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15143

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 18:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 16:53:09 +0000
Subject: [Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors
	account
In-Reply-To: <bug-15143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15143-70-rcTtqIQawo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12949

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 19:37:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 17:37:22 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-bu0n3Wv64I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 14695 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 19:37:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 17:37:22 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-H3xLlR4Agk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #158 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 2532 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 19:54:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 17:54:51 +0000
Subject: [Koha-bugs] [Bug 11723] Message "A refund has been applied" on all
 lost item returns
In-Reply-To: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11723-70-S3k5K8oMVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
            Version|3.12                        |master
           Severity|enhancement                 |normal
          Component|Notices                     |Circulation

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Tom?s Cohen Arazi from comment #2)
> (In reply to Jesse Maseto from comment #1)
> > This is not a bug. Functionality works as it should. This message appears
> > depending on how 'RefundLostItemFeeOnReturn' is set in your system.
> 
> The message appears depending on the fact of whether there was a refund or
> not.

I don't find this to be the case. If I mark an item missing when it is not
checked out, checking it in will not trigger any refund because a charge was
never put on anyone's account. The message should not display every times
something with a lost status is checked in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:02:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:02:07 +0000
Subject: [Koha-bugs] [Bug 12834] patron category with a category type
 written with an accent can' t be deleted
In-Reply-To: <bug-12834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12834-70-ckcBPRPZ5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12834

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:19:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:19:43 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-HSioNx3UYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low
             Status|Failed QA                   |ASSIGNED
           Severity|minor                       |normal
           Assignee|druthb at gmail.com            |gmcharlt at gmail.com

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
In master it still seems that the "user" placeholder works in the bibliographic
editor but not the item editor, although instead of username the user's last
name is used. The date placeholders work in both places.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:19:57 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-xtiGQTMDGF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:35:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:35:16 +0000
Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for
	AllowItemsOnHoldCheckout
In-Reply-To: <bug-15131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15131-70-2wOFIVZWg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131

--- Comment #3 from George Williams/Heather Braum (NEKLS) <gwilliams at nekls.org> ---
I'd like to test this, but could you add a test plan?

George

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:37:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:37:45 +0000
Subject: [Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working
In-Reply-To: <bug-13374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13374-70-q9uU5Les9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jorge de Cardenas from comment #0)
> We are trying to used AllowHoldsOnPatronsPossessions preference set to
> "Don't Allow" and it works only some times.

In master it seems to be working to block holds in the OPAC and staff client,
so unless someone can come up with an exception I think this bug should be
considered fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:42:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:42:18 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
	information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-eXYmYGU7kB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master
            Summary|sorting on volume number is |Holdings table sorting on
                   |not sorting right           |volume information
                   |                            |incorrect

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:47:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:47:58 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
	circulation
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-79Pa1It8KB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Patch does no longer apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:52:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:52:39 +0000
Subject: [Koha-bugs] [Bug 11573] change description of rental charges in
	account fines
In-Reply-To: <bug-11573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11573-70-Up5llR6szE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:54:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:54:49 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-8eEnjXmmRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:54:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:54:51 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-iPQsN1ihx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54280&action=edit
Bug 14629 - (QA Followup) sysprefs.sql changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 20:59:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 18:59:17 +0000
Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search
 language search
In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15067-70-Sh22iX6Svw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:05:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:05:29 +0000
Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
In-Reply-To: <bug-14670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14670-70-9ukVlMYodX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:10:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:10:54 +0000
Subject: [Koha-bugs] [Bug 6852] Staged import reports wrong success for
 items with false branchcode
In-Reply-To: <bug-6852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6852-70-FXbG2m72AJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
This is still valid in master. In my test I had a record with 7 items, the
first of which was invalid. No items were imported.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:12:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:12:23 +0000
Subject: [Koha-bugs] [Bug 16063] logic from overdue_notice.pl should be
 moved into a module
In-Reply-To: <bug-16063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16063-70-Lq9kMlBGeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:27:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:27:33 +0000
Subject: [Koha-bugs] [Bug 17103] New: Google API Loader jsapi called over
	http
Message-ID: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

            Bug ID: 17103
           Summary: Google API Loader jsapi called over http
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: indradg at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Google API loader js included in opac-bottom.inc is called over HTTP. This is
setting off MIXED CONTENT error on OPACs served over SSL. Directly impacts
GoogleIndicTransliteration syspref which stops working on SSLized OPACs. This
syspref is used extensively across Indian libraries to perform searches in
Indian languages. While the fix is trivial, non availability of the feature is
a deal breaker. Patch follows.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:28:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:28:00 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-8QMVAhzcjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:28:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:28:15 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-XT3DHnHfpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:28:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:28:45 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-va2QUnQ3wO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:28:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:28:59 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-vPXAQvU5D1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:54:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:54:57 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-fTtBvgZ3rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 21:54:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 19:54:59 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-VcS7FfgtMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54281&action=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)
Adds the UpdateItemLocationOnCheckin to svc/checkin

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:00:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:00:12 +0000
Subject: [Koha-bugs] [Bug 17104] New: svc/checkin does not use
 UpdateNotForLoanStatusOnCheckin
Message-ID: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104

            Bug ID: 17104
           Summary: svc/checkin does not use
                    UpdateNotForLoanStatusOnCheckin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I think svc/checkin should update not for loan status as a normal checkin does

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:00:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:00:35 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-J1vd4yh7SV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17104

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:00:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:00:35 +0000
Subject: [Koha-bugs] [Bug 17104] svc/checkin does not use
	UpdateNotForLoanStatusOnCheckin
In-Reply-To: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17104-70-b8zNJRHKUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11629
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14576
           Severity|enhancement                 |normal


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629
[Bug 11629] Add ability to update not for loan status on checkin
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:00:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:00:35 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: <bug-11629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11629-70-QJ7MXqT7HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17104


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104
[Bug 17104] svc/checkin does not use UpdateNotForLoanStatusOnCheckin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:20:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:20:04 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-R3XmnjvpiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 54282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54282&action=edit
Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:22:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:22:42 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-RBHHJqLYWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 10 22:44:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 10 Aug 2016 20:44:27 +0000
Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for
	AllowItemsOnHoldCheckout
In-Reply-To: <bug-15131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15131-70-xn2nZm80O2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Sorry, I forgot to add the steps to test this patchset!

To test, you need to:
- Apply the patches on master
- Run:
  $ sudo koha-upgrade-schema kohadev
=> SUCCESS: Verify that AllowItemsOnHoldCheckoutSCO is set to the same value
AllowItemsOnHoldCheckout was set
- Have an item that fills a hold
- Set AllowItemsOnHoldCheckoutSCO to "Don't allow"
- Try doing a checkout on the item, from the SCO interface
=> SUCCESS: You cannot.
- Set AllowItemsOnHoldCheckout to "Allow"
- Try doing a checkout on the item, from the SCO interface
=> SUCCESS: You cannot. The sysprefs are decoupled now.
- Set AllowItemsOnHoldCheckoutSCO to "Allow"
- Try doing a checkout on the item, from the SCO interface
=> SUCCESS: You can.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 03:53:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 01:53:35 +0000
Subject: [Koha-bugs] [Bug 7879] Memoize::Memcached two times slower than it
	should be
In-Reply-To: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7879-70-PWh9lVZntZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
(In reply to Owen Leonard from comment #2)
> This report was made on a very old version of Koha and hasn't been updated
> since. I think we should consider it closed.

fyi, this is still probably a valid issue for M::M (but, its not technically a
Koha bug)

 http://search.cpan.org/~tcohen/Memoize-Memcached-0.04/lib/Memoize/Memcached.pm

i think this M::M bug may describe the problem?
 https://rt.cpan.org/Public/Bug/Display.html?id=112659

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 06:35:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 04:35:54 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-6klfUnjjSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #1 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54283&action=edit
Bug 17084 - Automatic debian/control updates (master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 09:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 07:15:03 +0000
Subject: [Koha-bugs] [Bug 17105] New: Do not see checkouts in the table of
	circulation.pl
Message-ID: <bug-17105-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17105

            Bug ID: 17105
           Summary: Do not see checkouts in the table of circulation.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Saw this problem under 3.22 (but could probably have been master too):
Circulation page lists a number of checkouts.
But clicking Show checkouts does not list them in the table.

What happened?
This javascript error occurred: Sunday not defined.
Comes from includes/calendar.inc. And should be a zero. (As value for the
preference CalendarFirstDayOfWeek.)

After toggling this preference a few times, I could not reproduce the problem
anymore under 3.22 (Plack+memcache).
Probably a cache problem somehow.
Note that dbrev 3.21.00.015 moved the old value of Sunday to 0.

Just leaving this note here some time for future troubleshooting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 09:29:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 07:29:48 +0000
Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer
In-Reply-To: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14622-70-tM90OQZ6tE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17064


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064
[Bug 17064] Delete backup marc21_framework_DEFAULT.sql~ file
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 09:29:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 07:29:48 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-TnisKvqL7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14622
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622
[Bug 14622] Add fr-CA data folder in the web installer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:28:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:28:26 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-e1Xb17Ske3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
I tested this patch in our deployment setup (using docker containers), and
experienced the following:

Every second request invalidated/deleted the session. Seemingly the syspref
cache was emptied also. Enabling/disabling the SessionRestrictedByIp had no
effect, as it seemed the Context was gone. Really weird.

I will have to see if I can reproduce this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:30:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:30:08 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-kcQgTXJ9h4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:37:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:37:18 +0000
Subject: [Koha-bugs] [Bug 7397] Patron search from Checkout tab does
 'contains' instead of ' starts_with' search
In-Reply-To: <bug-7397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7397-70-o4TrpMgDUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7397

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Obsolete since Bug 15930 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:38:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:38:34 +0000
Subject: [Koha-bugs] [Bug 17106] New: DataTables patron search defaulting to
 'starts_with' - doc
Message-ID: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

            Bug ID: 17106
           Summary: DataTables patron search defaulting to 'starts_with' -
                    doc
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 15930 modified default value for DataTables patron search.

The doc text should also be modified : 
"Can be 'contain' or 'start_with' (default value). Used for the searchmember
parameter."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:38:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:38:56 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-VqBTkDZ8b4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:39:16 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-CgtcxSDYy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15930


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930
[Bug 15930] DataTables patron search defaulting to 'starts_with' and not
getting correct parameters to parse multiple word searches
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:39:16 +0000
Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to
 'starts_with' and not getting correct parameters to parse multiple word
 searches
In-Reply-To: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15930-70-IX7lIfBJIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17106


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106
[Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:41:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:41:42 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-2xbfMeWx77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:41:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:41:45 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-8RyCD3aYj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54259|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <c.gravely at arts.ac.uk> ---
Created attachment 54284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54284&action=edit
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm

To verify:
- git grep itemissues
Result: Appears in C4/Circulation.pm only

To test:
- apply patch
- git grep itemissues
Expected result: No occurences
- prove t/db_dependent/Circulation.t
Expected result: Pass OK

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:42:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:42:31 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-kBeFM7nspF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:42:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:42:33 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-ANZC5huQpt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 54285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54285&action=edit
Bug 17106 - DataTables patron search defaulting to 'starts_with' - doc

Bug 15930 modified default value for DataTables patron search.

The doc text should also be modified :
"Can be 'contain' or 'start_with' (default value). Used for the searchmember
parameter."

Test plan :
- install Koha with patch
- look at man page man/man3/C4::Utils::DataTables::Members.3pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:58:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:58:07 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-VIb31auRZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #33 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54286&action=edit
Bug 16212: Add script minifySwagger.pl

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:58:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:58:18 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-gJzY71m4fY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #34 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54287&action=edit
Bug 16212: Move from misc/devel to api/v1

Move minifySwagger.pl from misc/devel to api/v1 since it is directly related
to swagger.json and the usage is simplified when it is in the same location
with
swagger.json.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 10:59:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 08:59:02 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-3IRnaCIyAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #35 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54288&action=edit
Bug 16212: Use swagger.min.json insted of swagger.json

Our current approach with splitting the Swagger specification brings problems.
For example, in swagger.json, if we split the whole "definitions" object with
$ref, validations will fail with online.swagger.io validator.

(See http://online.swagger.io/validator/debug?url=url_to_your_swagger_json)

The problem also occurs with "paths" (Paths Object), because simply $ref to all
paths for example in /paths/index.json does not meet the Swagger2
specification.

The problem is solved by using the minification script and the minified version
of swagger.json after which the swagger.min.json is valid Swagger2
specification,
because the minifier resolves the problematic $refs of swagger.json file in the
minified version.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:00:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:00:30 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-h8ZVY2zw7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52982|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:00:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:00:54 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-0fgJ3qBC9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52983|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:01:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:01:43 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-8QaBxomfpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52984|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:03:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:03:45 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-yWXx1If9DF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #36 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Tests: 

swagger.json:

curl -X POST -H "accept:application/json" -d @swagger.json
http://online.swagger.io/validator/debug

{"messages":["attribute definitions.$ref is not of type
`object`"],"schemaValidationMessages":[{"level":"error","domain":"validation","keyword":"type","message":"instance
type (string) does not match any allowed primitive type (allowed:
[\"object\"])","schema":{"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/schema"},"instance":{"pointer":"/definitions/$ref"}}]}

swagger.min.json
curl -X POST -H "accept:application/json" -d @swagger.min.json
http://online.swagger.io/validator/debug
{}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:08:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:08:34 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-B93S6NQaDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Benjamin Rokseth from comment #5)
> I tested this patch in our deployment setup (using docker containers), and
> experienced the following:
> 
> Every second request invalidated/deleted the session. Seemingly the syspref
> cache was emptied also. Enabling/disabling the SessionRestrictedByIp had no
> effect, as it seemed the Context was gone. Really weird.
> 
> I will have to see if I can reproduce this.

What's the value of SessionStorage?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:09:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:09:12 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-jANsJobh6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:12:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:12:58 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-S6fxRtwxzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
I believe it was 'mysql'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:28:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:28:26 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-oU8ur0mqtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Benjamin Rokseth from comment #7)
> I believe it was 'mysql'

So should be ok. Let me know if you have steps to recreate the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:33:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:33:58 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-XgMZvOoUpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17084

--- Comment #31 from Mirko Tietgen <mirko at abunchofthings.net> ---
The corresponding control file update is at bug 17084:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084#c1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:33:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:33:58 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-3fj95WPlum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16929

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:41:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:41:01 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-6YsX9xMbjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:41:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:41:04 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-DNi7pK6cPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54284|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54289&action=edit
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm

To verify:
- git grep itemissues
Result: Appears in C4/Circulation.pm only

To test:
- apply patch
- git grep itemissues
Expected result: No occurences
- prove t/db_dependent/Circulation.t
Expected result: Pass OK

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:43:12 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-7i5z2pkhrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:47:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:47:03 +0000
Subject: [Koha-bugs] [Bug 17107] New: Add ident and Identifier-standard to
	known indexes
Message-ID: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

            Bug ID: 17107
           Summary: Add ident and Identifier-standard to known indexes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Add ident and Identifier-standard to known indexes in C4::Search::getIndexes().

Those indexes can be very useful, for example for IdRef feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:47:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:47:16 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-s4AbMUI6u8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:52:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:52:58 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-H2V47yIAz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 11:53:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 09:53:00 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-r2hyL2y2cK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 54290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54290&action=edit
Bug 17107 - Add ident and Identifier-standard to known indexes

Add ident and Identifier-standard to known indexes in C4::Search::getIndexes().
Those indexes can be very useful, for example for IdRef feature.

Test plan :
- Make sure some records have a field indexed with Identifier-standard,
ISBN=1234 for example
- Perform a search /cgi-bin/koha/opac-search.pl?idx=ident,phr&q=1234
=> you find the record
- Perform a search /cgi-bin/koha/opac-search.pl?q=ident:1234
=> Without patch : you get no results
=> With patch    : you find the record
Idem for 'Identifier-standard'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:00:21 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-jh1yt2ucJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54192|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54291&action=edit
Bug 15200 - t/Creators.t fails when using build-git-snapshot

ttf-dejavu was missing from the build dependencies.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:00:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:00:41 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-e0kvzyAxuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54290|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 54292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54292&action=edit
Bug 17107 - Add ident and Identifier-standard to known indexes

Add ident and Identifier-standard to known indexes in C4::Search::getIndexes().
Those indexes can be very useful, for example for IdRef feature.

Test plan :
- Make sure some records have a field indexed with Identifier-standard,
ISBN=1234 for example
- Perform a search /cgi-bin/koha/opac-search.pl?idx=ident,phr&q=1234
=> you find the record
- Perform a search /cgi-bin/koha/opac-search.pl?q=ident:1234
=> Without patch : you get no results
=> With patch    : you find the record
Idem for 'Identifier-standard'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:00:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:00:47 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-k65hlwknUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54283|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54293&action=edit
Bug 17084 - Automatic debian/control updates (master)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:02:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:02:39 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-KFbIJJk9sP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:02:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:02:45 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-6cKFZKeXOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:02:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:02:57 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-TpNG1KVXEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:03:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:03:07 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-ZuO70eLLVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:08:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:08:01 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-IhClZ9uMFo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |nowheezy

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
libbusiness-issn-perl is only packaged for jessie, adding keyword nowheezy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:11:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:11:37 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-GXYpXEmXTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|nowheezy                    |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #14)
> libbusiness-issn-perl is only packaged for jessie, adding keyword nowheezy.

Forget that, it is also packaged for wheezy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:23:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:23:12 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-iICoat4pcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nicole C. Engard from comment #11)
> Created attachment 51029 [details] [review]
> Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN

Should not we do that for GetVariationsOfISBN as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:05 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-q5qRWErK5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:08 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-eMcccVuyNK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53199|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54294&action=edit
Bug 16829: Add 'interface' column to action_logs

This patch introduces a new column for the action_logs table. It is
called 'interface' and it is intended to store the interface in which
the action was performed.

Sponsored-by: NEKLS

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:12 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-dYU0TByQxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53200|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54295&action=edit
Bug 16829: make logaction and GetLogs aware of the interface column

This patch changes the logaction API so it accepts a new 'interface' param.
Current code calling logaction is not changed, and this parameter can be
ommited
in most contexts, and it will correctly fall-back to C4::Context->interface.

Unit tests are provided on a different patch.

GetLogs gets patched as well, so it can be required to filter by 'interface'
param.

Sponsored-by: NEKLS

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:16 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-oIiD3tdjz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53201|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54296&action=edit
Bug 16829: Add 'interface' to the log viewer

This patch introduces the 'interface' filter to the log viewer.

To test:
- Apply the patch
- Open the log viewer
=> SUCCESS: As default, 'All' interfaces are chosen. OPAC, Intranet and SIP are
presented
- Do a lot of log searches, verify that the interface column shows what is
expected.
=> SUCCESS: The chosen 'interfaces' are kept when rendering results.

Sponsored-by: NEKLS

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:19 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-dUa8LKSUm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53202|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54297&action=edit
Bug 16829: DBIx update

Sponsored-by: NEKLS

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:28:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:28:23 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-S3Y1K1KJbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53203|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54298&action=edit
Bug 16829: Unit tests for logaction's 'interface parameter'

This patch introduces tests for the new 'interface' parameter for the
C4::Log::logaction and C4::Log::GetLogs functions.

In logaction, it falls back to C4::Context->interface if ommited.

To test:
- Run
  $ prove t/db_dependent/Log.t
=> SUCCESS: Tests pass
- Sign off

Sponsored-by: NEKLS

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:31:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:31:51 +0000
Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a
	name
In-Reply-To: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14328-70-Ma62vnY92A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #1)
> I can't reproduce this problem in master. Can this report be closed?

Not yet.
I will still follow this under 3.22.
It is quite hard to reproduce if you completely do not understand how it is
possible at all..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:18 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-81hDubs5Py@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52986|0                           |1
        is obsolete|                            |

--- Comment #33 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54299&action=edit
[SIGNED-OFF] Bug 16699: Split parameters and paths in Swagger

Parameters and paths should be split in our Swagger specification, because
otherwise swagger.json would become messy with all the paths and their
further specification in the same file. Also parameters should be split
for the same reason.

Instead of using index.json for definitions, parameters and paths, we define
new files "definitions.json", "parameters.json" and "paths.json" in order to
simplify the references. If we kept using index.json and try to reference
"/definitions/error.json" from "/paths/holds.json", reference would be
"../definitions/index.json#/error" instead of now simplified version,
"../definitions.json#/error".

Here is the proposed structure:

.
??? swagger.json
??? definitions.json
??? paths.json
??? parameters.json
??? definitions
?   ??? error.json
?   ??? patron.json
??? parameters
?   ??? patron.json
??? paths
?   ??? patrons.json
??? minifySwagger.pl
??? swagger.min.js

The swagger.json paths, definitions and parameters will look as follows:
...
  "paths": {
    "$ref": "paths.json"
  },
  "definitions": {
    "$ref": "definitions.json"
  },
  "parameters": {
    "$ref": "parameters.json"
  }
...

A problem with splitting specification into multiple files directly from
swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not
following the Swagger specification and an error will be thrown by the
Swagger-UI default validator (online.swagger.io/validator).

To overcome this problem, we use the minifySwagger.pl script from Buug 16212.
This allows the developers to work with the structure introduced in this patch
thus allowing developers to split the specification nicely, and still have a
valid Swagger specification in the minified swagger.min.json.

To test:
-2: Apply the minifier-patch in Buug 16212.
-1: Make sure you can validate your specification with Swagger2 validator at
    online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it
    locally from https://github.com/swagger-api/validator-badge.

1. Don't apply this patch yet, but first validate swagger.json
   with swagger.io-validator (or your local version, if you installed it)
2. Observe that validation errors are given
3. Run minifySwagger.pl
4. Validate swagger.min.json with the validator you used in step 1
5. Observe that validation passes and we overcame the invalid specification
   problem in swagger.min.json
6. Apply this patch
7. Run minifySwagger.pl
8. Repeat step 4
9. Observe that validation passes with new structure
10. Run REST tests at t/db_dependents/api/v1

(11. Study the new structure of our Swagger specifications :))

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:25 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-AIiC9Niosc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52987|0                           |1
        is obsolete|                            |

--- Comment #34 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54300&action=edit
[SIGNED-OFF] Bug 16699: Add borrowernumberQueryParam for reusability

The borrowernumber as a query parameter should be defined in parameters.json
in order to allow its reusability.

To test:
1. Apply patch
2. Run minifySwagger.pl
3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+
   _your_swagger_min_json or your local swagger-api/validator-badge validator
4. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:38 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-aKnHSaSXAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52988|0                           |1
        is obsolete|                            |

--- Comment #35 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54301&action=edit
[SIGNED-OFF] Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces

These definitions had indentation of 4 spaces, while rest of the specification
uses 2 spaces. This patch simply maintains the consistency in indentations and
provides no other modifications to code.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:47 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-lZfnc9loGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52989|0                           |1
        is obsolete|                            |

--- Comment #36 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54302&action=edit
[SIGNED-OFF] Bug 16699: Support multiple types in primitive definitions

Currently it is not possible to define multiple types for primitive definitions
in /definitions/*. If you try to use the following
"firstname": {
  "type": ["string", "null"],
  "description": "patron's first name"
}
in definitions.json, online.swagger.io validator will not validate it:
{"messages":["attribute definitions.firstname.type is not of type `string`"]}

One way to get around this issue is to extend definitions with custom
"x-primitives" object, where we will define all reusable primitive definitions.

To test:
1. Add the "firstname" example above to definitions.json
2. Run minifySwagger.pl
3. Validate your specification
4. Observe that error with description mentioned above is given
5. Apply patch
6. Repeat step 2 and 3
7. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:53 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-04I2OKMa4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52990|0                           |1
        is obsolete|                            |

--- Comment #37 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54303&action=edit
[SIGNED-OFF] Bug 16699: Reference new x-primitives in currently defined objects

Since we have defined some basic x-primitives in x-primitives.json, we can now
start to reuse them in our currently defined objects.

To test:
1. Apply patch
2. Run minifySwagger.pl
3. Validate your Swagger specifications
4. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:37:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:37:59 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-iOj89vGWbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52991|0                           |1
        is obsolete|                            |

--- Comment #38 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54304&action=edit
[SIGNED-OFF] Bug 16699: Move Swagger-related files to api/v1/swagger

This patch separates Swagger-specifications and the minifySwagger.pl from other
api-files by moving specifications & minifier into api/v1/swagger.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:42:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:42:01 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-DzSz7avZJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

--- Comment #39 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Rebased against 16271 which is now in master.

Removed patched t/api/v1/minifier.t which should be moved to bug #17102

Please test and get this moved further, as it is a pain to rebase swagger
definitions as is today ...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:53:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:53:05 +0000
Subject: [Koha-bugs] [Bug 17108] New: Automatic debian/control updates
	(stable)
Message-ID: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

            Bug ID: 17108
           Summary: Automatic debian/control updates (stable)
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 12:53:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 10:53:26 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-0VBLR4cxaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 13:09:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 11:09:45 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-R7WcgyUAOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #4 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54305&action=edit
Bug 17108 - Automatic debian/control updates (stable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 13:40:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 11:40:44 +0000
Subject: [Koha-bugs] [Bug 17109] New: sendbasket (working title)
Message-ID: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

            Bug ID: 17109
           Summary: sendbasket (working title)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 13:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 11:46:01 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-WidaNikQGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54305|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 13:48:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 11:48:31 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-V1BqDiDFd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:08:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:08:53 +0000
Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into
 Koha:: AuthorisedValues - part 2
In-Reply-To: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15799-70-UFrlNC3Yos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We have already started to move the authorised values related code to
the Koha namespace, but some are still missing.

To continue and move C4::Koha::*AuthorisedValues* subroutines to
Koha::AuthorisedValues, we will need to join on
marc_subfield_structure(.authorised_value which is actually an
authorised value category).

To do so we need to define a relationship (fk) between the two tables.
But we have "special AV" like Asort1 (and friends) , LOST, DAMAGED, etc.)
Which could not be in the authorised_values table [yet]. And 3 other
"special special AV) like itemtypes, branches and cn_source.
Others (undetermined so far) are linked to a marc_subfield_structure
from installer/**/marcflavour/**/*framework*.sql, like STACK.
My idea would be to move all the AV categories to a new table
authorised_value_categories. It will contain only 1 column
category_name refered by
  1. authorised_values.category,
  2. additional_fields.authorised_value_category (others authorised_value
field should be renamed like that when they refer AV categories) and
  3. iitems_search_fields.authorised_value_category.

And, maybe later, auth_subfield_structure, auth_tag_structure,
borrower_attribute_types, marc_tag_structure (some are varchar(10) et
20 when they should be 32!)

We could imagine more attributes to this table, but don't ask me to
add a authorised_value_categories.id as pk please :)
We will have to use temporary tables to deal with the DB constraints,
to add more fun.

Finally the .sql will have to be updated to reflect these changes.

I have just started but before to enter in this tunnel I'd like to
know if there are a couple of volunteers to test? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:22:58 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket (working title)
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-84nrc5NLp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:33:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:33:45 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-nEvnzhiIE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32642|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54306&action=edit
[SIGNED-OFF] Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class "patron-category" to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:33:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:33:53 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-GA74aEBFKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54282|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54307&action=edit
[SIGNED-OFF] Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:34:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:34:16 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-y3ATPbMyb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:47:18 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-7eJjI58OYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:47:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:47:21 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-VwuS1RZHN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54285|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54308&action=edit
[SIGNED-OFF] Bug 17106 - DataTables patron search defaulting to 'starts_with' -
doc

Bug 15930 modified default value for DataTables patron search.

The doc text should also be modified :
"Can be 'contain' or 'start_with' (default value). Used for the
searchmember parameter."

Test plan :
- install Koha with patch
- look at man page man/man3/C4::Utils::DataTables::Members.3pm

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:48:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:48:33 +0000
Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a
	name
In-Reply-To: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14328-70-N8YAIhknVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |3.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:53:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:53:15 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-pEgFjV34sp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Small patch
            Summary|sendbasket (working title)  |sendbasket: Remove second
                   |                            |authentication, add CSRF
                   |                            |token

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:53:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:53:45 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-50L9gDHhar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:53:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:53:48 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-jAoIcrij3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54309&action=edit
Bug 17109: Remove second authentication from (opac-)sendbasket

Patch deals with opac and intranet variant.
If we authenticated the first time, it is not necessary to do it
a second time rightaway.

Replaces a call to get_template_and_user (including checkauth) by
gettemplate.

Also removes duplicate use C4::Biblio statements.

Test plan:
[1] Put a few books in the cart.
[2] Send the cart from OPAC.
[3] Send the cart from intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:54:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:54:14 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-O73M6T1xbj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54310&action=edit
Bug 17109: Add CSRF token to [opac-]sendbasket

If you have no (valid) token, you will not be able to send the message.

Test plan:
[1] Verify if you can still send the cart from opac and intranet.
[2] While still being logged in, try to send the cart from opac by
    using the following URL:
   
/cgi-bin/koha/opac-sendbasket.pl?email_add=you at somedomain.com&comment=csrf_test&bib_list=doesnotmatter&csrf_token=justsomeguess12345
    This should now result in a csrf error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:54:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:54:54 +0000
Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made
	mandatory
In-Reply-To: <bug-4030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4030-70-em9UBA7AGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:55:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:55:48 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-lHKWg1XAt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16929


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929
[Bug 16929] Prevent opac-memberentry waiting for random chars
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 14:55:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 12:55:48 +0000
Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random
	chars
In-Reply-To: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16929-70-cf6U3EeZVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17109


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109
[Bug 17109] sendbasket: Remove second authentication, add CSRF token
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:01:49 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-4qBcMImesI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
         Depends on|15126, 16212                |16271


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
[Bug 15126] REST?API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212
[Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271
[Bug 16271] Allow more filters on /api/v1/holds
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:01:49 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-YfpF4sPUrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16699                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:01:49 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-7oLKvwAN05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16699                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:01:49 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-cnJ1vcWoPY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:01:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:01:54 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-LdV4d0hZ4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

--- Comment #40 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54311&action=edit
Bug 16699: Remove requirement from borrowernumberQueryParam

borrowernumberQueryParam shouldn't be required as also changed in Bug 16271.

To test:
1. Don't apply the patch yet, but first minify Swagger and run
   t/db_dependent/api/v1/holds.t
2. Observe that some tests fail with response code 400 when expecting 200.
3. Apply patch and minify Swagger
4. Run t/db_dependent/api/v1/holds.t
5. Observe that tests pass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:02:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:02:04 +0000
Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a
	name
In-Reply-To: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14328-70-hhvqN8wqGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I still hope to get some more light on this with bug 17109

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:02:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:02:13 +0000
Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a
	name
In-Reply-To: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14328-70-J66V1foBEH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17109

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:02:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:02:13 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-BS4Y9J5CX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14328

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:02:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:02:28 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-TvoxTi5mlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212
[Bug 16212] Swagger specification separation and minification
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:02:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:02:28 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-54MWePx1cX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:04:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:04:08 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-yI0se29znF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:04:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:04:11 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-XYCZ0NcY20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54270|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54312&action=edit
[SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print

This alternative patch moves logic and formatting to the template file.

To test:
- Follow test plan in comment #2
- Additionally, verify that formatting follows syspref 'CurrencyFormat'
- Verify that amount column is right-aligned

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:08:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:08:11 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-e8xtUn1qhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

--- Comment #41 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Benjamin Rokseth from comment #39)
> Rebased against 16271 which is now in master.
> 
> Removed patched t/api/v1/minifier.t which should be moved to bug #17102
> 
> Please test and get this moved further, as it is a pain to rebase swagger
> definitions as is today ...
Thanks Benjamin! And I agree, it can be surprisingly time consuming!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:25:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:25:56 +0000
Subject: [Koha-bugs] [Bug 17110] New: Lower CSRF expiry in Koha::Token
Message-ID: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

            Bug ID: 17110
           Summary: Lower CSRF expiry in Koha::Token
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:31:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:31:12 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-7Hq3GopMv5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54313&action=edit
Bug 17110: Lower CSRF expiry in Koha::Token

Default expiry in WWW:CSRF is one week.
This patch sets it to 8 hours by default in Koha, and allows to
change the expiry period individually by passing MaxAge.

Test plan:
[1] Put items in your cart.
[2] Apply the example patch too.
[3] Send the cart from opac within the allotted 10 seconds.
[4] Send again, but wait some 10 seconds before submitting. Too late!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:31:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:31:41 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-lyctLYEMNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Example patch and adjusted test still coming..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:32:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:32:03 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-eEyGLAlpsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17109


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109
[Bug 17109] sendbasket: Remove second authentication, add CSRF token
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:32:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:32:03 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-rfGAUa6dGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17110


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110
[Bug 17110] Lower CSRF expiry in Koha::Token
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 15:32:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 13:32:24 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-VQ7Phs1iZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 16:02:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 14:02:47 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-9PcKOl9iD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Kyle M Hall from comment #6)
> Would it not be simpler to pass the parameter timeformat => '24hr' to
> output_pref instead of using an external lib?

I note that output_pref(), if we were to take its name literally, is for
formatting date and time *output*. DateTime::Format::MySQL is already used in
other places and its name makes it clear that a DateTime passed through is
meant to be fed to an SQL query.

I think it better that we keep the concerns of formatting timestamps for human
display separate from formatting them for computer consumption.

I am reseting the status of this bug back to "Passed QA".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 16:39:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 14:39:54 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-8354O5AZhR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 16:39:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 14:39:58 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-KJLt6fVpdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53958|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54314&action=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch follows Galen's suggestion in comment #7.

TEST PLAN
---------
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
      didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
    -- the process ids for the zebrasrv and daemon processes should
       be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

Sponsored-by: Tulong Aklatan

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Works as expected, no regressions found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 16:53:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 14:53:30 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-UHfwT33TsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54215|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54315&action=edit
[SIGNED-OFF]Bug 16991: Add subtitle to holds to pull report

This patch adds output of subtitle to the holds to pull report using
keyword to MARC mapping information.

To test, apply the patch and go to Circulation -> Holds to pull. The
list of holds to pull should display subtitles.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Subtitle added using keyword to MARC mapping with default framework.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 16:53:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 14:53:41 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-xn1hvSj96E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:02:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:02:15 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-7rJjIW6vro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #16)
> (In reply to Nicole C. Engard from comment #11)
> > Created attachment 51029 [details] [review] [review]
> > Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN
> 
> Should not we do that for GetVariationsOfISBN as well?

If we do think this is the right way to go I will file a new bug for ISBN, I
just wanted to see if there was any opposing opinion here before doing that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:08:05 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn' t work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-RfMrzUARiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.hedstrom.mace at sub.s
                   |                            |u.se

--- Comment #12 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> ---
I added a sign-off since the patch works as intended. I'm unsure why it didn't
already have this status since it appears that it has previously been
signed-off by David Cook (see comment #6)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:14:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:14:11 +0000
Subject: [Koha-bugs] [Bug 17111] New: Automatic debian/control updates
	(oldstable)
Message-ID: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

            Bug ID: 17111
           Summary: Automatic debian/control updates (oldstable)
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:14:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:14:25 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-j8mJIRWT8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:14:44 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-KdigFvefwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17111

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:14:44 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-AmiLSrfDZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17108

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:30:25 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-YjA6zpWn6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #1 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54316&action=edit
Bug 17108 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:42:37 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-SIVi5lwdVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 17:43:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 15:43:56 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-0s6XtoPUHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
This is the result of debian/update-control on 3.22.x and should go in 3.22.10.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 18:01:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 16:01:08 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-QM3aI9lEIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Kyle M Hall from comment #19)
> Pushed to master for Koha 16.11, thanks Bernardo!

Are you sure you pushed all the patches? I just did a git bz apply, and it only
said the first one was already applied.

I was trying to test bug 16554 (I think).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 18:03:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 16:03:04 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-10BCW4WSUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #22 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #21)
> (In reply to Kyle M Hall from comment #19)
> > Pushed to master for Koha 16.11, thanks Bernardo!
> 
> Are you sure you pushed all the patches? I just did a git bz apply, and it
> only said the first one was already applied.
> 
> I was trying to test bug 16554 (I think).

Nevermind, I failed to git pull. Sorry. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 20:21:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 18:21:06 +0000
Subject: [Koha-bugs] [Bug 17112] New: Action buttons for course reserves
	detail page
Message-ID: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

            Bug ID: 17112
           Summary: Action buttons for course reserves detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The edit and delete links for titles on a course reserve should be styled
according to new interface guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 20:35:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 18:35:20 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-9NJk9U4NFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 20:35:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 18:35:23 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-bWo3dbw1nM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54317&action=edit
Bug 17112 - Action buttons for course reserves detail page

This patch revises the edit and delete buttons on the course reserves
detail page so that they are styled as Bootstrap buttons with Font
Awesome icons.

To test, apply the patch and choose or create a course reserve which has
in it at least one lost item and at least one item which is checked out.

- In the list of items on the course reserve detail page, confirm that
  the 'Edit' and 'Delete' buttons are correctly styled.
- Confirm that for the checked out item the delete button is disabled.
  Hovering over the button should trigger a tooltip. Clicking the button
  should trigger an alert.
- Confirm that for the lost item the same is true.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 20:52:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 18:52:29 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-rJOF7YDrm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53859|0                           |1
        is obsolete|                            |

--- Comment #4 from Mehdi Hamidi <mehdi.hamidi at inlibro.com> ---
Created attachment 54318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54318&action=edit
Bug 17015 - New koha calendar

The new calendar has it's own UI now.
  Added some new features to the calendar:
     - Copying calendar from branch to branch
     - Copy holidays from date to date or from range to range
- Added a column into discrete_calendar holidaytype.
- Adding new days in futureChecks type of holiday:
      - If the date from a year ago was exeption ('E'), the new day won't be a
holiday.
      - If the date from a year ago was fixed ('R') repeatable, the new day
will be a holiday.
      - If the date from a year ago was float ('F') a holiday that's not fixed,
the new day will on need validation.
      - If the date from a year ago was need validation ('N'), the new day will
still be on need validation.
  - You can change the opening and closing hours from the calendar UI directly.

  - The discrete_calendar uses sql queries for now, the next patch will be to
change that that it uses schema.
  - CSS and some client side calculation might be changed.


  - Please let us know what you think and if we should add/modify some
features.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 21:19:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 19:19:47 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-ZtGK3RwYvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53714|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54319&action=edit
Bug 16974: Make koha-plack should check and fix log files permissions

This patch adds a function to the koha-plack script so it checks for log file
existence and its permissions. This function is called from the start_plack
function.

If some of this conditions are not fulfilled, it solves the situation by either
touching and/or changing the permissions accordingly for the instances' plack
log files.

To test:
- Run (on kohadevbox):
  $ cd kohaclone
  $ debian/scripts/koha-plack --start kohadev
  $ debian/scripts/koha-plack --stop  kohadev
  $ ls /var/log/koha/kohadev/plack*
- Verify ownership of the created files (they might belong to the root user)
- Apply the patch
- Run:
  $ chown root:root /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files belong to kohadev-koha:kohadev-koha
- Run:
  $ debian/scripts/koha-plack --stop  kohadev
  $ rm /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files are created and belong to kohadev-koha:kohadev-koha
- Sign off :-D

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 21:21:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 19:21:53 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-SEzeWS5n5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
It did not work from within koha-shell. Since I don't think it would be called
from within koha-shell, I assume it is supposed to be like that. Just wanted to
leave a note in case it isn't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 21:23:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 19:23:05 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-I4siJNAn2U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Christophe Brocquet <christophe.brocquet at obspm.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.brocquet at obspm.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 21:24:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 19:24:39 +0000
Subject: [Koha-bugs] [Bug 17113] New: Unable to search multi-domain Active
 Directory forest due LDAP required base
Message-ID: <bug-17113-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17113

            Bug ID: 17113
           Summary: Unable to search multi-domain Active Directory forest
                    due LDAP required base
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: helpdesk at neci.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Auth_with_ldap currently prevents the use of an empty base due to the presence
of

my $base = $ldap->{base} or die ldapserver_error('base');

An AD Global Catalog search will automatically query all domains in a forest if
a blank base is specified, but otherwise limits the search to the domain
matching the base. Not being able to specify an empty base makes things
difficult if the forest contains disjoint domains that cannot be combined into
a single search base.

(Uncertain how this interacts with the work on bug 8993, but being able to use
the forest wide Global Catalog searches removes a lot of the contortions needed
to direct requests to the correct host responsible for a domain.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 21:49:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 19:49:02 +0000
Subject: [Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI
 GetRecords response
In-Reply-To: <bug-16246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16246-70-rLBdyttv7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.hedstrom.mace at sub.s
                   |                            |u.se

--- Comment #4 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> ---
Patch did not apply for me. Needs a rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 11 22:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 20:24:02 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-HR8krqa8jg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Christophe Brocquet <christophe.brocquet at obspm.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Christophe Brocquet <christophe.brocquet at obspm.fr> ---
It works as described

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:00:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:00:28 +0000
Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when
 series title ends with semicolon preceded by space.
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-eHvBorA9fU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:23:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:23:46 +0000
Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when
 series title ends with semicolon preceded by space.
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-Pv6Pjd3gvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #20 from Eric Phetteplace <ephetteplace at cca.edu> ---
If anyone else runs into this, I'm using a small bit of OPAC JavaScript as a
work-around since many of records are affected:

// fix 830$a series links ending in semicolons, see bug #14716
$('.results_summary.series a').each(function(){
    // URI-encoded semicolon
    var href = $(this).attr('href').replace(/;/g, '%3B')
    $(this).attr('href', href)
})

Stuffing unencoded text inside URLs seems like a bad idea. If Japanese
characters aren't working, maybe that's an issue with the url-encode function
itself but not the approach taken to resolve this bug? I would think that
almost anything being put in an href attribute would need to go through
url-encode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:26:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:26:39 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-hRH2Ecu2gT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54293|0                           |1
        is obsolete|                            |

--- Comment #5 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54320&action=edit
Bug 17084 - Automatic debian/control updates (master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:27:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:27:57 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-j03VA2anKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54320|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:28:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:28:17 +0000
Subject: [Koha-bugs] [Bug 17084] Nightly build bot bug
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-Qgp7B4IS73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54293|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:31:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:31:53 +0000
Subject: [Koha-bugs] [Bug 9557] Koha does not include EANs from MARC records
 in Syndetics links on OPAC pages
In-Reply-To: <bug-9557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9557-70-NbO1dmUHvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

--- Comment #1 from rkuiper at roundrocktexas.gov ---
We are also experiencing this problem.  The cover images are showing up on the
details page but not the search results page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:32:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:32:19 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-InXdMbceG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:34:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:34:04 +0000
Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown
 shows only 10 years
In-Reply-To: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12342-70-1Rv1HKdwzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:35:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:35:17 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-5cRlJbw701@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 00:50:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 22:50:08 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-O2OGoG52TF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Nightly build bot bug       |Automatic debian/control
                   |                            |updates (master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 01:51:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 11 Aug 2016 23:51:03 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-2v6O9bII5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #29)
> vi installer/.../subscription_numberpatterns.sql
> -- notice the [converted]
> :set fileencoding=utf-8
> :wq
> 
> I believe that is all that is needed to fix it.

While that fixes some, still issues with:
installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/autorites_norme_unimarc.sql
-- something about 'CO' duplicate primary key.
installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql
-- something about '000' duplicate primary key.
Also, ru-RU and uk-UA also seem to trigger on mandatory and repeatable fields
now. They are rather floody.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 02:31:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 00:31:41 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-tsFXLXK6Jc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 03:00:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 01:00:51 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-m7hp5b4jIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

--- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> ---
Created attachment 54321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54321&action=edit
Bug 17103 - Google API Loader jsapi called over http

This patch removes the hardcoded protocol ("http") from the URI,
leaving the browser to negotiate the correct http/https context.
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 03:06:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 01:06:47 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-UUABTVGGAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 04:20:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 02:20:24 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-Pu7Wgjn8Wy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54316|0                           |1
        is obsolete|                            |

--- Comment #3 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54322&action=edit
Bug 17108 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 06:52:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 04:52:38 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-oLpQryEEpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #6 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I believe this needs rebasing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 07:54:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 05:54:33 +0000
Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when
 series title ends with semicolon preceded by space.
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-7995icuxCZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not against url-encoding, but we need to find a way to do this with xslt
or outside the xslt that works better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 07:57:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 05:57:21 +0000
Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when
 series title ends with semicolon preceded by space.
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-242LEOGl58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Removing the ; would be an incomplete fix, but much easier to do as a
workaround solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 08:18:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 06:18:03 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-iQnccbnMxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 08:18:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 06:18:06 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-gvMOJiykiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54323&action=edit
Bug 17110: Add unit test for MaxAge parameter in Token.t

Test plan:
Run t/Token.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 08:18:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 06:18:09 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-cGSVJz4hU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54324&action=edit
Bug 17110: [EXAMPLE PATCH] CSRF expiry of 10 seconds in opac-sendbasket

This patch should NOT be pushed !
It is used to test the first patch only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 08:34:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 06:34:16 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-KuM2SCfVX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54325&action=edit
Bug 17109: Use Koha.Preference in sendbasket template

No need to send OPACBaseURL to the template, if you load the Koha TT
plugin inside the template.

Test plan:
Send a few items in your cart from OPAC and intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 08:48:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 06:48:57 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-gJGRpllSiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 09:32:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 07:32:42 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-Pjg2eArtKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 09:42:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 07:42:16 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-fEFFpaKlOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #6 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54330&action=edit
Bug  - Automatic debian/control updates (unstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 09:57:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 07:57:17 +0000
Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the
 OPACFineNoRenewals amount is reached
In-Reply-To: <bug-15582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15582-70-JEHs2nZs3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

Claire Gravely <c.gravely at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |c.gravely at arts.ac.uk

--- Comment #18 from Claire Gravely <c.gravely at arts.ac.uk> ---
Hi,
Just flagging a small grammar typo in the OPACFineNoRenewalsBlockAutoRenew
syspref description:

'If patron owe more than the value of OPACFineNoRenewals'

Should be 
'If a patron owes more...'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 09:57:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 07:57:56 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-fNGMeEqdrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54330|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:12:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:12:01 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-5qIR4qkokX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #7 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54331&action=edit
Bug  - Automatic debian/control updates (unstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:18:32 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-VBZ1PeX2f0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54230|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54332&action=edit
Bug 17089: Koha::Ratings - Add Koha::Rating[s] classes

The subroutines in C4::Ratings are only CRUD operations.
This patch set moves the entire module to Koha::Rating[s] based on
Koha::Object[s]

Test plan for the whole patch set:
0/ Set OpacStarRatings to "results and details"
1/ Log in at the OPAC
2/ Launch a search, you should see the star ratings
3/ Go on a detail page, you should see the star ratings
4/ Rate the record
5/ Log in with another patron
6/ Go on the same detail page, you should see the previous rating
7/ Rate the racord, you should see "2 votes" and the average rating
value.
8/ Cancel your rate
9/ Disable JavaScript and repeat 7

Note: You cannot cancel your rate if JavaScript is disabled (not a
regression).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:18:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:18:43 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-IMakpdPmpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54231|0                           |1
        is obsolete|                            |
  Attachment #54232|0                           |1
        is obsolete|                            |
  Attachment #54233|0                           |1
        is obsolete|                            |
  Attachment #54234|0                           |1
        is obsolete|                            |
  Attachment #54235|0                           |1
        is obsolete|                            |
  Attachment #54236|0                           |1
        is obsolete|                            |
  Attachment #54237|0                           |1
        is obsolete|                            |
  Attachment #54238|0                           |1
        is obsolete|                            |

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54333&action=edit
Bug 17089: Koha::Ratings - move tests

Rewrite and move the tests.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:18:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:18:49 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-PzV7aBW4lH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54334&action=edit
Bug 17089: Koha::Ratings - Remove AddRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:18:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:18:52 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-YEcIb85aOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54335&action=edit
Bug 17089: Koha::Ratings - Remove ModRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:18:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:18:56 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-cNaGwb4zdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54336&action=edit
Bug 17089: Koha::Ratings - Remove DelRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:19:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:19:00 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-EVPpaKN1T7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54337&action=edit
Bug 17089: Koha::Ratings - Remove GetRating

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:19:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:19:04 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-hqRAPXUTZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54338&action=edit
Bug 17089: Koha::Ratings - Remove C4::Ratings

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:19:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:19:07 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-Qz4d5gXG5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54339&action=edit
Bug 17089: Mark out the boundaries of ratings

In the doc of C4::Ratings, it was written that the rate values should be
>=0 and <=5, but it was not taken into account.
This bug should be fixed on stable releases as well.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:19:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:19:11 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-nwvQ9Wh1cG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54340&action=edit
Bug 17089: Improve errors handling

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:19:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:19:14 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-vFtnxoXxUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54341&action=edit
Bug 17089: [QA Follow-up] Add some test descriptions to Ratings.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:20:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:20:12 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-guJa1Wpaif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #6)
> I believe this needs rebasing

It applies cleanly on top of bug 16960.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:20:42 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-Z5PcDCgGrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me.

eval { $avg = $sum / $total }; 
Not your code, but an eval around a non-zero division seems overkill.

[% rating_avg_int = BLOCK %][% rating_avg | format("%.0f") %][% END %]
This kind of construct does not look very pretty. Simplify?

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:24:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:24:18 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-zfqSLbGys6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:26 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-EvHDPZ37Re@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:30 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-HfrjYiCtPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53419|0                           |1
        is obsolete|                            |

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54342&action=edit
Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm

This patch replaces sql queries done in some pl script and in
C4::Reports::Guided.
Since we have now a Koha::Patron::Categories module, we should use it
where it is possible.

Test plan:
- Prerequisite: Be sure you have several patron categories created, with
  different option enabled, and limit some to certain libraries.
- On the 'Circulation and fine rules' admin page (admin/smart-rules.pl),
  all the patron categories should be displayed (even the ones limited to
  another library), ordered by description. Try to add/update existing rules.
- On the overdue rules page (tools/overduerules.pl), all the patron
  categories with overduenoticerequired set should be displayed.
  Try to add/update existing rules.
- On the following reports:
    reports/borrowers_stats.pl
    reports/issues_avg_stats.pl
The patron categories should be displayed. Note that there is an
inconsistency with these 2 reports: the patron categories limited to
other libraries are displayed on them, when they are not on the other
reports. This should certainly be fixed (on another bug report).

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:35 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-kt7Pb2awXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53420|0                           |1
        is obsolete|                            |

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54343&action=edit
Bug 15407: Koha::Patron::Categories - replace C4::Category->all

The C4::Category module contained only 1 method to return the patron
categories available for the logged in user.
The new method Koha::Patron::Categories->search_limited does exactly the
same thing (see tests) and must be used in place of it.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to
other libraries.
- On the 'Item circulation alerts' admin page
  (admin/item_circulation_alerts.pl), modify the settings for check-in
  and checkout (NOTE: Should not we display all patron categories on
  this page? If yes, it must be done in another bug report to ease
  backporting it).
- Search for patrons in the admin (budget) and acquisition (order) module.
- On the patron home page (search form in the header)

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:40 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-ccCrzYBkJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53421|0                           |1
        is obsolete|                            |

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54344&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory

The purpose of C4::Members::GetBorrowercategory was to return the patron
category for a given categorycode. This can be done easily with the
Koha::Patron::Categories->find method.

Test plan:
- Same prerequisite as before
- Edit a guarantor and confirm the information will be updated for his/her
  guarantee(s).
- Update a child to adult patron (Note: Should not we hide the patron
  categories limited to others libraries? If yes, it must be done on another
  bug report).
  There is a special behavior if there is only 1 adult category, the
  user does not need to select a category. So the same as before with
  only 1 adult patron category.
- Import a patron with a category_code which does not exist. You should
  be warned.
- Modify some patron using the batch patron modification tool. The
  patron category descriptions should correctly be displayed.

Note that the overduerules page has already been tested in a previous
patch.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:45 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-Sf2gEWPIrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53422|0                           |1
        is obsolete|                            |

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54345&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList

C4::Members::GetBorrowercategoryList returned all the patron categories,
ordered by description.
This can be done using the search method of the Koha::Patron::Categories
module.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by description.
- On the "patron attribute types" admin page (admin/patron-attr-types.pl).
- On the "Batch patron deletion/anonymization"
  (tools/cleanborrowers.pl), the dropdown list should be filled
  correctly.
- On the import patron tool
- On the following report:
    reports/reserves_stats.pl
Confirm that the patron categories are displayed and that the report
still works as before.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:26:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:26:51 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-FQHFss4Wjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53892|0                           |1
        is obsolete|                            |

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54346&action=edit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
    reports/bor_issues_top.pl
    reports/borrowers_out.pl
    reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:33:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:33:58 +0000
Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the
 OPACFineNoRenewals amount is reached
In-Reply-To: <bug-15582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15582-70-hfOHK66IZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54347&action=edit
Bug 15582: Fix grammar in syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:37:01 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-fRrblUhlOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: OK Having another look

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:37:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:37:56 +0000
Subject: [Koha-bugs] [Bug 17089] Move the star ratings related code to
	Koha::Ratings
In-Reply-To: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17089-70-pErOXiuMnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #31)
> [% rating_avg_int = BLOCK %][% rating_avg | format("%.0f") %][% END %]
> This kind of construct does not look very pretty. Simplify?

It's not possible to set a variable to something using a filter:
  [% SET rating_avg_int = rating_avg | format("%.0f") %]
This does not work.

The construct is the same I already used in facets.inc:
  [% url = BLOCK %][% url %][% "&amp;sort_by=" _ sort_by |url %][% END %]

If you find something easier to write/read I will be happy to know it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:25 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-fDwjqFkYzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54331|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:39 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-e14C5vRMQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51432|0                           |1
        is obsolete|                            |
  Attachment #51433|0                           |1
        is obsolete|                            |
  Attachment #51434|0                           |1
        is obsolete|                            |
  Attachment #51435|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54348&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop

The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns
them ordered by the description (frameworktext). If a parameter is
passed, a selected flag is set. The selection of the options should be
done on the template side.
These 2 calls can be replaced with
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });

Test plan:
1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl)
You should see a dropdown list with the biblio frameworks. The framework
of the record should be selected by default
2/ Create a sql report using the biblio_framework parameter, something
like:
  SELECT COUNT(*) FROM biblio WHERE
frameworkcode=<<framework|biblio_framework>>
Save and execute the report.
You should get a dropdown list with the framework list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Both dropdowns Ok
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:36 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-pw9GV5Ep4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:50 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-fBTAvl1iNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54350&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo

This was the "Get" subroutine for the framework, it can be easily
replaced with a call to the Koha::BiblioFrameworks->find method.
This patch also replaces some confusing wordings (framework vs frameworkcode).

Test plan:
On the circulation home page, you should see a "Fast cataloguing" link
if the FA framework exists.

Note that the admin/marctagstructure.pl has already been tested in the
previous patch.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Link pops Ok
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:43 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-jUESBKkTRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54349&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks

C4::Koha::getframeworks returned a hashref of biblio frameworks.
It was mainly used to generate the dropdown list of frameworks.
The scripts modified in this patch did not necessary order the element
by description (frameworktext), the displays were not consistent from
one screen to another.
Using the same search method everywhere:
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
We will know always get the framework in the same order.

Test plan:
Following the different pages modified by this patch, and make sure the
frameworks are displayed correctly in the dropdown list:
1/ acqui/z3950_search.pl - Create an order from an external source.
2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field
3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select
another framework than the default one and click on the 'Search' button
4/ catalogue/MARCdetail.pl - On the MARC defail page, change the
framework you want to use to display the record
5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its
framework. When editing, the framework of the record should be selected
by default
6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click
on the "New record" button. You should see all the frameworks
7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first
step (select the merge reference), you should be allowed to select the
framework to use.
8/ tools/inventory.pl - On the inventory page, the "Item statuses" part
should be populated as before this patch
9/ tools/manage-marc-import.pl - Stage records for import. Before
importing them into the catalog, you should see the framework dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 10:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 08:46:53 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-N21qBo6eAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54351&action=edit
Bug 15801: minor fixes

- Fix a tab
- Fix a variable name in a template

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

With all patches applied no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 11:04:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 09:04:38 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-1Hhl7HUqqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54352&action=edit
Bug 15407: [QA Follow-up] Fix POD in reserves_stats.pl

Trivial fix.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 11:06:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 09:06:38 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-3HgCa4Z7b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-   my %cathash = ($line eq 'categorycode' or $column eq 'categorycode') ?
&catcodes_hash : ();
-   push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map
{$cathash{$_}} sort keys %cathash)};
+    my $patron_categories = Koha::Patron::Categories->search({}, {order_by =>
['categorycode']});
+    push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map {
$_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')'}
$patron_categories->as_list )};

You removed cathash, but left it in the push

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 11:22:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 09:22:10 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-mEUBPCwXDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54353&action=edit
Bug 15407: [QA Follow-up] Joubu, add your tests

Trivial fix (yes again).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 11:44:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 09:44:50 +0000
Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack
	safe
In-Reply-To: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16886-70-uLLnIMqO8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17114

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 11:49:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 09:49:42 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-r7wVjp132V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please git grep on Categories.GetName

Koha/Template/Plugin/Categories.pm:[% Categories.GetName( categorycode ) %].
koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc:
koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt:
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:

Remove the pod and replace the three remaining calls please..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:06:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:06:57 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-p4Uz7NNyHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54355&action=edit
Bug 15407: (follow-up) Koha::Patron::Categories - replace C4::Category->al

Categories.GetName should not have been removed in the previous patch
(merge conflict issue).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:12:03 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-VeDVC7biFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #65 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Another thing :)

perl t/db_dependent/Reserves.t
1..74
ok 1 - use C4::Reserves;
Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line 45.
ok 2 - CheckReserves Test 1
ok 3 - CheckReserves() include reserve_id in its response
ok 4 - CheckReserves Test 2
ok 5 - CheckReserves Test 3
ok 6 - GetReservesControlBranch returns item home branch when set to
ItemHomeLibrary
ok 7 - GetReservesControlBranch returns patron home branch when set to
PatronLibrary
DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected
operator 'cancellationdate' with undef operand at
/usr/share/koha/masterclone/Koha/Objects.pm line 168
# Looks like you planned 74 tests but ran 7.
# Looks like your test exited with 255 just after 7.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:21:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:21:35 +0000
Subject: [Koha-bugs] [Bug 17115] New: Reserves.t fails
Message-ID: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17115

            Bug ID: 17115
           Summary: Reserves.t fails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: gmcharlt at gmail.com

t/db_dependent/Reserves.t .. 2/74 SQL::Abstract::puke():
[SQL::Abstract::__ANON__] Fatal: unexpected operator 'cancellationdate' with
undef operand at Koha/Objects.pm line 168

To investigate, may be a major one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:22:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:22:00 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-GIaNISGFg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17115

--- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #65)
> Another thing :)
> 
> perl t/db_dependent/Reserves.t
> 1..74
> ok 1 - use C4::Reserves;
> Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line
> 45.
> ok 2 - CheckReserves Test 1
> ok 3 - CheckReserves() include reserve_id in its response
> ok 4 - CheckReserves Test 2
> ok 5 - CheckReserves Test 3
> ok 6 - GetReservesControlBranch returns item home branch when set to
> ItemHomeLibrary
> ok 7 - GetReservesControlBranch returns patron home branch when set to
> PatronLibrary
> DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected
> operator 'cancellationdate' with undef operand at
> /usr/share/koha/masterclone/Koha/Objects.pm line 168
> # Looks like you planned 74 tests but ran 7.
> # Looks like your test exited with 255 just after 7.

Exsts on master, see bug 17115.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:22:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:22:00 +0000
Subject: [Koha-bugs] [Bug 17115] Reserves.t fails
In-Reply-To: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17115-70-PobkHT54Fs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17115

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15407

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:25:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:25:27 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-jjdr5skwFf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:25:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:25:31 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-4n5NTP0c9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #48 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54356&action=edit
Bug 10848 - [QA Followup] Add missing branch option and fix pattern for
copyrightdate

- HTML5 input pattern for copyrightdate was not taking into an account
the database field type, which is smallint(5)
- added title="..." for the year field so the acceptable date format
should be displayed as a hint/tooltip in the browser
- added an missing option for configuring branch/library as mandatory

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:29:14 +0000
Subject: [Koha-bugs] [Bug 17115] Reserves.t fails
In-Reply-To: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17115-70-KU38vyvoNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17115

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looks like a duplicate of bug 16942

*** This bug has been marked as a duplicate of bug 16942 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:29:14 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-44qfTuLqar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 17115 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:31:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:31:20 +0000
Subject: [Koha-bugs] [Bug 17115] Reserves.t fails
In-Reply-To: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17115-70-veATeDTGow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17115

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #1)
> Looks like a duplicate of bug 16942
> 
> *** This bug has been marked as a duplicate of bug 16942 ***

Confirmed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 12:37:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 10:37:37 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-vOOrQ865rC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #49 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #41)

> If I enter a wrong format into the year field, it says 'Please use the specified
> format' (translated from German), but gives no clue about the format. 

On the 2nd thought, previous pattern ("[12][0-9\-\?]{3}") wasn't making much
sense - copyrightdate in the DB is just smallint(5).

Added a hint for the user regarding the required format for that field as a
title="", i.e. tooltip. Doesn't always work quite perfectly (depending on the
browser), but hopefully it would be good enough for the time being / close
enough for government work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:05:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:05:49 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-Cm0ai9Jcho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I'm not sure how this is valid but, if you enter start date == end date, the
validator tell you that it is not allowed.
It's a change with before this patch. We could imagine a budget for only 1 day,
which was allowed before, but not anymore.
Feel free to contradict :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:13:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:13:15 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-ak253NpwyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:13:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:13:18 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-Lg9MKTFljs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54306|0                           |1
        is obsolete|                            |
  Attachment #54307|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54358&action=edit
Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class "patron-category" to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:13:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:13:49 +0000
Subject: [Koha-bugs] [Bug 13134] Add patron category to returns confirmation
	dialogs
In-Reply-To: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13134-70-CFrMUa3e9a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54359&action=edit
Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:41:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:41:35 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-k5SxEp79oh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:41:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:41:38 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-YigGGBr66q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54308|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54360&action=edit
Bug 17106 - DataTables patron search defaulting to 'starts_with' - doc

Bug 15930 modified default value for DataTables patron search.

The doc text should also be modified :
"Can be 'contain' or 'start_with' (default value). Used for the
searchmember parameter."

Test plan :
- install Koha with patch
- look at man page man/man3/C4::Utils::DataTables::Members.3pm

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:45:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:45:38 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-ARWhdaVFKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54342|0                           |1
        is obsolete|                            |

--- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54361&action=edit
Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm

This patch replaces sql queries done in some pl script and in
C4::Reports::Guided.
Since we have now a Koha::Patron::Categories module, we should use it
where it is possible.

Test plan:
- Prerequisite: Be sure you have several patron categories created, with
  different option enabled, and limit some to certain libraries.
- On the 'Circulation and fine rules' admin page (admin/smart-rules.pl),
  all the patron categories should be displayed (even the ones limited to
  another library), ordered by description. Try to add/update existing rules.
- On the overdue rules page (tools/overduerules.pl), all the patron
  categories with overduenoticerequired set should be displayed.
  Try to add/update existing rules.
- On the following reports:
    reports/borrowers_stats.pl
    reports/issues_avg_stats.pl
The patron categories should be displayed. Note that there is an
inconsistency with these 2 reports: the patron categories limited to
other libraries are displayed on them, when they are not on the other
reports. This should certainly be fixed (on another bug report).

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:45:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:45:43 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-XQtXmBiy8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54343|0                           |1
        is obsolete|                            |

--- Comment #68 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54362&action=edit
Bug 15407: Koha::Patron::Categories - replace C4::Category->all

The C4::Category module contained only 1 method to return the patron
categories available for the logged in user.
The new method Koha::Patron::Categories->search_limited does exactly the
same thing (see tests) and must be used in place of it.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to
other libraries.
- On the 'Item circulation alerts' admin page
  (admin/item_circulation_alerts.pl), modify the settings for check-in
  and checkout (NOTE: Should not we display all patron categories on
  this page? If yes, it must be done in another bug report to ease
  backporting it).
- Search for patrons in the admin (budget) and acquisition (order) module.
- On the patron home page (search form in the header)

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:45:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:45:48 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-mTTXJ2qkzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54344|0                           |1
        is obsolete|                            |

--- Comment #69 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54363&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory

The purpose of C4::Members::GetBorrowercategory was to return the patron
category for a given categorycode. This can be done easily with the
Koha::Patron::Categories->find method.

Test plan:
- Same prerequisite as before
- Edit a guarantor and confirm the information will be updated for his/her
  guarantee(s).
- Update a child to adult patron (Note: Should not we hide the patron
  categories limited to others libraries? If yes, it must be done on another
  bug report).
  There is a special behavior if there is only 1 adult category, the
  user does not need to select a category. So the same as before with
  only 1 adult patron category.
- Import a patron with a category_code which does not exist. You should
  be warned.
- Modify some patron using the batch patron modification tool. The
  patron category descriptions should correctly be displayed.

Note that the overduerules page has already been tested in a previous
patch.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:45:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:45:53 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-TzLBgbF2zR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54345|0                           |1
        is obsolete|                            |

--- Comment #70 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54364&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList

C4::Members::GetBorrowercategoryList returned all the patron categories,
ordered by description.
This can be done using the search method of the Koha::Patron::Categories
module.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by description.
- On the "patron attribute types" admin page (admin/patron-attr-types.pl).
- On the "Batch patron deletion/anonymization"
  (tools/cleanborrowers.pl), the dropdown list should be filled
  correctly.
- On the import patron tool
- On the following report:
    reports/reserves_stats.pl
Confirm that the patron categories are displayed and that the report
still works as before.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:46:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:46:03 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-8wJ4VNoPev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54352|0                           |1
        is obsolete|                            |

--- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54366&action=edit
Bug 15407: [QA Follow-up] Fix POD in reserves_stats.pl

Trivial fix.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:45:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:45:58 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-IRTT0He7Bt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54346|0                           |1
        is obsolete|                            |

--- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54365&action=edit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
    reports/bor_issues_top.pl
    reports/borrowers_out.pl
    reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:46:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:46:07 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-yViifPLpWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54353|0                           |1
        is obsolete|                            |

--- Comment #73 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54367&action=edit
Bug 15407: [QA Follow-up] Joubu, add your tests

Trivial fix (yes again).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:46:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:46:12 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-8OgW9QfQyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54355|0                           |1
        is obsolete|                            |

--- Comment #74 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54368&action=edit
Bug 15407: (follow-up) Koha::Patron::Categories - replace C4::Category->al

Categories.GetName should not have been removed in the previous patch
(merge conflict issue).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:46:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:46:17 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-aRdzzlWMDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #75 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54369&action=edit
Bug 15407: [QA Follow-up] Confusing cathash removed

One of the patches removed %cathash. Some kind of silly remainder
was left in a string. Just used as a text field to explain the
filters used on borrowers_stats.pl. The filter name cathash is not
really easy and also was confusing in relation to the variable.

So just a string patch, replacing it with Patron category.

NOTE: The output of borrowers_stats.pl with the filters listed, is
not one of the most beautiful Koha screens.
Furthermore, translatibility of these filters is still an issue to
be handled on another report.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:47:18 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-yX9KfUa8Xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

--- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me. Tested selectively. Especially checked the code
carefully; hard to test everything in limited time. With a quick push we will
have some time before release to fix one or two things if needed. The number of
follow-ups here shows that we already found some. Bonus points for the rest.

Patch 3
It will probably work most of the time, but we assume often here that the find
returned a record and access its columns rightaway without checking.

Patch 4
admin/patron-attr-types.pl: Why collecting first in scalar context and later in
list context ? Seeing no difference, just slightly inconsistent..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:50:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:50:59 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-Qx636t0S4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:51:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:51:02 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-DFkJsCmWcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54315|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54370&action=edit
Bug 16991: Add subtitle to holds to pull report

This patch adds output of subtitle to the holds to pull report using
keyword to MARC mapping information.

To test, apply the patch and go to Circulation -> Holds to pull. The
list of holds to pull should display subtitles.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Subtitle added using keyword to MARC mapping with default framework.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 13:58:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 11:58:22 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-xGKqnAxZVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54371&action=edit
Bug 15407: Uniformise calls in patron-attr-types

Does not make sense to call first in list context and later in scalar
context.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:00:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:00:11 +0000
Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to
 Koha::Patron:: Categories - part 2
In-Reply-To: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15407-70-MmhDYUI3O1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #76)
> Patch 3
> It will probably work most of the time, but we assume often here that the
> find returned a record and access its columns rightaway without checking.

Yes, and it was almost the same before. Except that now the app will explode :)
At least we able to catch if something is wrong elsewhere.
But you are right, we need to focus on these calls.

> Patch 4
> admin/patron-attr-types.pl: Why collecting first in scalar context and later
> in list context ? Seeing no difference, just slightly inconsistent..

Fixed in last follow-up.

> Passed QA

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:05:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:05:21 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-GO8KKPL1GE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54311|0                           |1
        is obsolete|                            |

--- Comment #42 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54372&action=edit
Bug 16699: Remove requirement from borrowernumberQueryParam

borrowernumberQueryParam shouldn't be required as also changed in Bug 16271.

To test:
1. Don't apply the patch yet, but first minify Swagger and run
   t/db_dependent/api/v1/holds.t
2. Observe that some tests fail with response code 400 when expecting 200.
3. Apply patch and minify Swagger
4. Run t/db_dependent/api/v1/holds.t
5. Observe that tests pass.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:06:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:06:05 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-cPSJbwrgmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54372|Bug 16699: Remove           |[SIGNED-OFF] Bug 16699:
        description|requirement from            |Remove requirement from
                   |borrowernumberQueryParam    |borrowernumberQueryParam

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:06:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:06:25 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-vxNSCZQezv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:06:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:06:27 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-sDLNbwklMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:06:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:06:31 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-VhfWjqsCcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54314|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54373&action=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch follows Galen's suggestion in comment #7.

TEST PLAN
---------
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
      didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
    -- the process ids for the zebrasrv and daemon processes should
       be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

Sponsored-by: Tulong Aklatan

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Works as expected, no regressions found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:13:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:13:06 +0000
Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt
	(1/quarter)
In-Reply-To: <bug-10187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10187-70-eC4xLNcuzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #10)
> Is this bug still valid with the reworked serials module?

I'm going to say not, since frequencies are no longer coded into the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:18:32 +0000
Subject: [Koha-bugs] [Bug 8875] Cataloging authorithy search plugin displays
 badly accented characters
In-Reply-To: <bug-8875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8875-70-wr5uAnBUm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8875

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|In Discussion               |RESOLVED

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:25:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:25:29 +0000
Subject: [Koha-bugs] [Bug 11121] Patron Card Creator batch export cannot
 handle special characters ( usually)
In-Reply-To: <bug-11121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11121-70-O8u0KHtLhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:40:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:40:06 +0000
Subject: [Koha-bugs] [Bug 8964] AllowHoldsOnDamagedItems and
 AllowOnShelfHolds don' t work with Professional category type
In-Reply-To: <bug-8964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8964-70-XRH8Mpp6PS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8964

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I cannot reproduce this bug in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:50:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:50:53 +0000
Subject: [Koha-bugs] [Bug 6416] koha-remove fails when dropping user
In-Reply-To: <bug-6416-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6416-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6416-70-eJHV4lilEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Magnus Enger from comment #0)
> I have MySQL running on the same machine as Apache/Koha, and have created a
> new library with "sudo koha-create --create-db demo". 
> 
> When i do "sudo koha-remove demo" I get this: 
> 
> Removing Koha instance demo
> ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_demo'@'%'

I cannot reproduce this error in master, so I'm marking it fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:53:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:53:59 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-5paU5e8auH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:54:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:54:02 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-EmxNABGOks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54319|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54374&action=edit
Bug 16974: Make koha-plack should check and fix log files permissions

This patch adds a function to the koha-plack script so it checks for log file
existence and its permissions. This function is called from the start_plack
function.

If some of this conditions are not fulfilled, it solves the situation by either
touching and/or changing the permissions accordingly for the instances' plack
log files.

To test:
- Run (on kohadevbox):
  $ cd kohaclone
  $ debian/scripts/koha-plack --start kohadev
  $ debian/scripts/koha-plack --stop  kohadev
  $ ls /var/log/koha/kohadev/plack*
- Verify ownership of the created files (they might belong to the root user)
- Apply the patch
- Run:
  $ chown root:root /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files belong to kohadev-koha:kohadev-koha
- Run:
  $ debian/scripts/koha-plack --stop  kohadev
  $ rm /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files are created and belong to kohadev-koha:kohadev-koha
- Sign off :-D

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 14:56:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 12:56:26 +0000
Subject: [Koha-bugs] [Bug 13598] Tax Rate displays different from
 Acquisition Preference gist
In-Reply-To: <bug-13598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13598-70-Y0EiK0j29K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13598

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jack Morash from comment #0)
> When I set the Acquisitions Preference gist to 8.75%, it displays in the
> order Accounting details as 875.0%

Since the description of the preference includes the correct format ("Enter in
numeric form, 0.12 for 12%") I think this aspect of the bug is invalid in
master.

> When I set the Acquisitions Preference gist to 0.0875, it displays in the
> order Accounting Details as 8.8%

As Katrin points out, this aspect of the bug is a duplicate of Bug 10253.

Marking this resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:01:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:01:35 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-aDBlNxh6sb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54292|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54375&action=edit
Bug 17107 - Add ident and Identifier-standard to known indexes

Add ident and Identifier-standard to known indexes in C4::Search::getIndexes().
Those indexes can be very useful, for example for IdRef feature.

Test plan :
- Make sure some records have a field indexed with Identifier-standard,
ISBN=1234 for example
- Perform a search /cgi-bin/koha/opac-search.pl?idx=ident,phr&q=1234
=> you find the record
- Perform a search /cgi-bin/koha/opac-search.pl?q=ident:1234
=> Without patch : you get no results
=> With patch    : you find the record
Idem for 'Identifier-standard'

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:01:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:01:32 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-AuCLprYvGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:01:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:01:46 +0000
Subject: [Koha-bugs] [Bug 12684] Linking authorities to 65X field adds "7"
 as second indicator.
In-Reply-To: <bug-12684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12684-70-m8xzfsSN5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12684

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I cannot reproduce this problem in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:09:42 +0000
Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page
 while " independent branches" is on
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-rwKmof7xV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.10                        |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:13:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:13:48 +0000
Subject: [Koha-bugs] [Bug 13652] Need the display of fine amount against
	each book
In-Reply-To: <bug-13652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13652-70-vyYfJyp4q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13652

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:25:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:25:57 +0000
Subject: [Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and
 issues tables
In-Reply-To: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6271-70-nXS6vypFv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
This issue still exists in that the query in Circulation.pm is still the same,
and there are still renewals columns in both items and issues. I think we still
have yet to see a test plan which shows how the bug manifests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:37:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:37:32 +0000
Subject: [Koha-bugs] [Bug 14146] Additional days are not added to
 restriction period when checking-in several overdues for same patron
In-Reply-To: <bug-14146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14146-70-HTBx30HT39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Windows                     |All
            Version|3.16                        |master
           Hardware|PC                          |All

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Carolina Andreu from comment #0)
> We check-in
> second and third item, but restriction period remains the same number of
> days, additional days of suspension are not accumulated to the restriction
> period.

I find that this is still the way it works in master, but I wonder if it's not
the expected behavior? Could this be a problem of differing interpretations of
how "fine in days" is supposed to work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:57:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:57:17 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-t1DwurnS8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Windows                     |All
            Version|3.14                        |master
            Summary|Reserve not removed when    |Hold not removed when item
                   |issued to member that is    |is checked out to patron
                   |not in Priority # 1         |who is not next in priority
                   |position and comes via the  |list
                   |?invalid? reserve queue     |
           Hardware|PC                          |All

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think the "'invalid' reserve queue' is a red herring since it's (I assume) a
custom report and isn't related to the functionality of the holds system.

However, I am able to reproduce this problem in master:

1. Find a title with multiple holds.
2. Check an available item out to any patron who
   is not at the top of the hold priority list.
3. The hold for that patron is not removed -- it's
   still on hold for them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:57:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:57:49 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-5kFVr8N0PA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41048|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 15:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 13:59:31 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-MY4Ils9vB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54312
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54312
[SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print

Review of attachment 54312:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17100&attachment=54312)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
@@ +105,4 @@
>              </tr>
>  
>              [% FOREACH account IN accounts %]
> +                [% IF ( account.amountoutstanding < 0 ) || ( account.amountoutstanding > 0 ) %]

Marc, why did you replace
  next if amount == 0
with this lines?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:01:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:01:05 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12353-70-XrmyKsV8uF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:15:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:15:00 +0000
Subject: [Koha-bugs] [Bug 9510] holiday exceptions are being ignored
In-Reply-To: <bug-9510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9510-70-sRPr8SnMRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9510

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:18:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:18:48 +0000
Subject: [Koha-bugs] [Bug 17117] New: Patron personal details not displayed
 unless branch update request is enabled
Message-ID: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

            Bug ID: 17117
           Summary: Patron personal details not displayed unless branch
                    update request is enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org

In patron acount ("your personal details" tab, which serves as a form for
submitting update requests as well) it's not possible to display some account
details like expiration date etc., without enabling the field for branch /
library update requests too.

To reproduce:
- set OPACPatronDetails to "Allow"
- clear PatronSelfModificationBorrowerUnwantedField preference
- all possible fields in the update requests form are visible in patron
account, including some extra details (card number, expiration date, category)
in the "Library" section on top
- put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference
- the whole 'Library' section disappears

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:22:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:22:48 +0000
Subject: [Koha-bugs] [Bug 12903] UseQueryParse, Staff client search incatalog,
 Duplicated records  massage when adding a record.
In-Reply-To: <bug-12903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12903-70-0Z9bBuRwmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12903

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
As far as I can tell this bug is not valid in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:27:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:27:06 +0000
Subject: [Koha-bugs] [Bug 5806] Search results display items for all
 locations when the SearchMyLibrary first system pref is activated
In-Reply-To: <bug-5806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5806-70-PARqDX3eoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:31:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:31:33 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-Mo5Pp6KyrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:31:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:31:35 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-h3Xge4H8zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

--- Comment #1 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54377&action=edit
Bug 17117 - Patron personal details not displayed unless branch update request
is enabled

In patron acount ("your personal details" tab, which serves as a form
for submitting update requests as well) it's not possible to display
some account details like expiration date etc., without enabling
the field for branch / library update requests too.

To reproduce:

1) set OPACPatronDetails to "Allow"
2) clear PatronSelfModificationBorrowerUnwantedField preference
- all possible fields in the update requests form are visible
in patron account, including some extra details (card number,
expiration date, category) in the "Library" section on top
3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference
4) the whole 'Library' section disappears

To test:

1) apply patch
2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField,
'Library' section should remain visible (sans branch selection option)
3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same
preference, 'Library' section should now disappear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:33:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:33:00 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-xUprwC9SdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54317|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54378&action=edit
[SIGNED-OFF]Bug 17112: Action buttons for course reserves detail page

This patch revises the edit and delete buttons on the course reserves
detail page so that they are styled as Bootstrap buttons with Font
Awesome icons.

To test, apply the patch and choose or create a course reserve which has
in it at least one lost item and at least one item which is checked out.

- In the list of items on the course reserve detail page, confirm that
  the 'Edit' and 'Delete' buttons are correctly styled.
- Confirm that for the checked out item the delete button is disabled.
  Hovering over the button should trigger a tooltip. Clicking the button
  should trigger an alert.
- Confirm that for the lost item the same is true.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Buttons styled as Bootstrap. Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:33:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:33:15 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-Ga7SssG2kW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:34:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:34:44 +0000
Subject: [Koha-bugs] [Bug 14002] Show patron expiry date in OPAC
In-Reply-To: <bug-14002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14002-70-YMM9IED9CM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17117
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 16:34:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 14:34:44 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-14mwIXsW9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14002

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:14:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:14:40 +0000
Subject: [Koha-bugs] [Bug 13824] Print notices message_queue.status defaults
 to Pending for patrons without e-mail
In-Reply-To: <bug-13824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13824-70-IikuHJEDHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13824

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:14:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:14:49 +0000
Subject: [Koha-bugs] [Bug 13824] Print notices message_queue.status defaults
 to Pending for patrons without e-mail
In-Reply-To: <bug-13824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13824-70-yhXcKXa0x0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13824

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:15:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:15:42 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-mKAswyELVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54379&action=edit
[SIGNED-OFF]Bug 17117: Patron personal details not displayed unless branch
update request is enabled

In patron acount ("your personal details" tab, which serves as a form
for submitting update requests as well) it's not possible to display
some account details like expiration date etc., without enabling
the field for branch / library update requests too.

To reproduce:

1) set OPACPatronDetails to "Allow"
2) clear PatronSelfModificationBorrowerUnwantedField preference
- all possible fields in the update requests form are visible
in patron account, including some extra details (card number,
expiration date, category) in the "Library" section on top
3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference
4) the whole 'Library' section disappears

To test:

1) apply patch
2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField,
'Library' section should remain visible (sans branch selection option)
3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same
preference, 'Library' section should now disappear

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:15:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:15:58 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-RPx8YCO7oe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com
  Attachment #54377|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:16:23 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-NnjRULnsWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
           Assignee|oleonard at myacpl.org         |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:17:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:17:51 +0000
Subject: [Koha-bugs] [Bug 9321] holds queue printable version
In-Reply-To: <bug-9321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9321-70-RXt66GLjtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
I think the current version could probably use some tweaks, but those should be
addressed in a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:18:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:18:31 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-rzDV1QNvB1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:21:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:21:23 +0000
Subject: [Koha-bugs] [Bug 17090] Logged in user can't submit more than one
	review
In-Reply-To: <bug-17090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17090-70-p0ll53hRDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17090

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:22:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:22:37 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-0emmitygC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:22:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:22:43 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-rXmsiPSZ9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:35:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:35:40 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-ndIaIFh533@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

--- Comment #1 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54380&action=edit
Bug 17101 - Confirm a question before check in

This patch enable the checkin message type question. This type ask the user
before the item is check in, yes or no. Only if he click yes then the item is
checked in.

Test plan:

1. Create an itemtype, with the checkinmsgtype question
2. Create an item with the itemtype from 1
3. Check out the item from 2
4. Check in the item from 3
5. Click no ==> item shouldn't be check in
6. Check in the item from 3
7. Click yes ==> item should be check in

Optional:
Before step 4 check others item in, to check if the prevouis check in's are
still shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:45:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:45:37 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-jJiOCfufpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54380|0                           |1
        is obsolete|                            |

--- Comment #2 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54381&action=edit
Bug 17101 - Confirm a question before check in

This patch enable the checkin message type question. This type ask the user
before the item is check in, yes or no. Only if he click yes then the item is
checked in.

Test plan:

1. Create an itemtype, with the checkinmsgtype question
2. Create an item with the itemtype from 1
3. Check out the item from 2
4. Check in the item from 3
5. Click no ==> item shouldn't be check in
6. Check in the item from 3
7. Click yes ==> item should be check in

Optional:
Before step 4 check others item in, to check if the prevouis check in's are
still shown.

Sponsored-by: B?cherei Maichingen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:46:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:46:13 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-Fj1f6zk09q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:46:28 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-iDC709lCo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:58:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:58:48 +0000
Subject: [Koha-bugs] [Bug 3554] Print notices using print css
In-Reply-To: <bug-3554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3554-70-mIUchdAbhQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3554

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:59:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:59:30 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-GlUI0MWhWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:59:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:59:32 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-BjLtKMX1yn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51179|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54382&action=edit
Bug 16274: Add the new pref PatronSelfRegistrationLibraryList

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 17:59:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 15:59:38 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-81CGSOpiM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51180|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54383&action=edit
Bug 16274: Limit the patron self registration to some libraries

Currently a patron can select a home library in the list of all
libraries defined in the system.
However some of these libraries might not accept self registration.
This patch adds a new pref to display only the allowed libraries.

Test plan:
0/ Apply the patch, do not fill the new pref
1/ Self register a new patron
=> All the libraries defined should be displayed in the "Home library"
dropwdown list
2/ Fill the pref PatronSelfRegistrationLibraryList with some of the
branchcode defined in the system
=> Self register a new patron and confirm that the dropdown list has
been filtered.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:02:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:02:07 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-E4cnqv8ErL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Cleared small conflict (removal of GetTitles() )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:06:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:06:32 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-hsJx4HtvK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #39 from Owen Leonard <oleonard at myacpl.org> ---
Does this feature make it inaccurate to label the "Relatives' checkouts" tab as
such? "Guarantees' checkouts" perhaps?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:15:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:15:24 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-psyGMXpHSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:15:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:15:28 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-7gq1otSl7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51377|0                           |1
        is obsolete|                            |
  Attachment #51875|0                           |1
        is obsolete|                            |

--- Comment #31 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 54384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54384&action=edit
Bug 5670: Housebound Readers Module

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('HSBND_FREQ').

* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Borrower_Housebound.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values to 'HSBND_FREQ'.
- Switch on 'HouseboundModule' syspref.
- Ensure 'ExtendedPatronAttributes syspref is on.
- On patron pages, when editing, add some to the Housebound deliverer
  and chooser groups by setting their extended attributes.
- On a patron page, the Housebound menu should now be present.
  - create housebound profile
    + ensure Frequency values seem pulled from 'HSBND_FREQ'.
  - create 'housebound visits' (deliveries)
    + ensure chooser/deliverer lists are populated with patrons that
      have the Chooser or Deliverer Attribute type.
  - edit visits.
  - delete visits.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:16:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:16:10 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-3ViZslDBlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Smallish conflict in C4/Circulation.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:17:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:17:15 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-pzFpewHcCf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #32 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 54385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54385&action=edit
DO NOT PUSH: Add Housebound Schema files.

* Koha/Schema/Result/HouseboundProfile.pm: New file.
* Koha/Schema/Result/HouseboundVisit.pm: New file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:24:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:24:21 +0000
Subject: [Koha-bugs] [Bug 14433] To print a slip as receipit for a single
 issue (checkout)
In-Reply-To: <bug-14433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14433-70-81kqivQcnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14433

Wendy Sharkey <catalog at bfli.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catalog at bfli.org

--- Comment #1 from Wendy Sharkey <catalog at bfli.org> ---
We have a similar issue where a patron has checked out all their items and has
their slip in hand and then finds another book which they just have to have. It
would be useful to be able to print a slip for just that one item, or maybe
have a select items you want to print a slip for option.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:28:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:28:28 +0000
Subject: [Koha-bugs] [Bug 17118] New: Regression: Bug 15381 triggers error
 when trying to clear a linked authority
Message-ID: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

            Bug ID: 17118
           Summary: Regression: Bug 15381 triggers error when trying to
                    clear a linked authority
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

To reproduce:

1. Edit a record which has a field linked to an 
   authority record (100a for instance).
2. Click the link which triggers the tag editor.
   A pop-up window should be displayed.
3. In the pop-up window, click the "Clear field"
   button.
4. A second pop-up window opens and displays an error:

Can't call method "authtypecode" on an undefined value at
/authorities/blinddetail-biblio-search.pl line 61.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:31:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:31:32 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-D0a6DYc7FE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54381|0                           |1
        is obsolete|                            |

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54386&action=edit
Bug 17101 - Confirm a question before check in

This patch enable the checkin message type question. This type ask the user
before the item is check in, yes or no. Only if he click yes then the item is
checked in.

Test plan:

1. Create an itemtype, with the checkinmsgtype question
2. Create an item with the itemtype from 1
3. Check out the item from 2
4. Check in the item from 3
5. Click no ==> item shouldn't be check in
6. Check in the item from 3
7. Click yes ==> item should be check in

Optional:
Before step 4 check others item in, to check if the prevouis check in's are
still shown.

Sponsored-by: B?cherei Maichingen
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:33:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:33:24 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-eD2w3TprTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Followed the testplan, works for me.

It would be nice to have some kind of message about not checking in the item
after hitting cancel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:41:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:41:46 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-IlEagfvhhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:41:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:41:49 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-ESr9hGgS8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54086|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54387&action=edit
Bug 16955: Do not clear from cache when adding a new framework

There are several issues with these lines:
1/ $cache is not defined correctly and it not visible inside
duplicate_framework
2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode
3/ these calls are not needed. As we are creating a new framework, the cache
should be empty...

This patch will simply remove these calls

Test plan:
Duplicate a framework and confirm that you do not get any error in your
logs.

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:45:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:45:41 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-ilia5Te1Rc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

--- Comment #5 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54388&action=edit
Bug 17101 - Confirm a question before check in

This patch enable the checkin message type question. This type ask the user
before the item is check in, yes or no. Only if he click yes then the item is
checked in.

    Test plan:

    1. Create an itemtype, with the checkinmsgtype question
    2. Create an item with the itemtype from 1
    3. Check out the item from 2
    4. Check in the item from 3
    5. Click no ==> item shouldn't be check in and a message should be
displayed
    6. Check in the item from 3
    7. Click yes ==> item should be check in and a message should be displayed

    Optional:
    Before step 4 check others item in, to check if the prevouis check in's are
still shown.

    Sponsored-by: B?cherei Maichingen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 18:48:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 16:48:28 +0000
Subject: [Koha-bugs] [Bug 17119] New: Shouldn' t have to scroll to see
 submit button in Z39.50 authority search popup
Message-ID: <bug-17119-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17119

            Bug ID: 17119
           Summary: Shouldn't have to scroll to see submit button in
                    Z39.50 authority search popup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

If you use the "New from Z39.50" option in Authorities, the pop-up window shown
has no visible submit button. The list of Z39.50 search targets has a fixed
height for some reason, which pushes the submit button down out of view. I
think this is confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:14:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:14:22 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-qa9SemXXRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54386|0                           |1
        is obsolete|                            |
  Attachment #54388|0                           |1
        is obsolete|                            |

--- Comment #6 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54389&action=edit
Bug 17101 - Style up

Added a messag when an item is not checked in, becaus of answer no.

    (new) Test plan:

    1. Create an itemtype, with the checkinmsgtype question
    2. Create an item with the itemtype from 1
    3. Check out the item from 2
    4. Check in the item from 3
    5. Click no ==> item shouldn't be check in and a message should be
displayed
    6. Check in the item from 3
    7. Click yes ==> item should be check in

    Optional:
    Before step 4 check others item in, to check if the prevouis check in's are
still shown.

    Sponsored-by: B?cherei Maichingen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:15:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:15:05 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-MrM0gcpGjQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54388|-Bug-17101---Confirm-a-ques |Style up 1
           filename|tion-before-check-in.patch  |
  Attachment #54388|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:15:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:15:49 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-VfGgmee0rN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54386|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:16:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:16:04 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-mIyoU3o28g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54388|Bug 17101 - Confirm a       |Bug 17101 - Style up 1
        description|question before check in    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:16:15 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-yjaKFbzs3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54389|Bug 17101 - Style up        |Bug 17101 - Style up 2
        description|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:29:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:29:43 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-9IUzzJc9Xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

--- Comment #7 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54390&action=edit
Bug 17101 - Confirm a question before check in

This patch enable a message for the user after he hit no, by the
question in the check in window

        (new) Test plan:

        1. Create an itemtype, with the checkinmsgtype question
        2. Create an item with the itemtype from 1
        3. Check out the item from 2
        4. Check in the item from 3
        5. Click no ==> item shouldn't be check in and a message should be
displ
ayed
        6. Check in the item from 3
        7. Click yes ==> item should be check in
ed

        Optional:
        Before step 4 check others item in, to check if the prevouis check in's
        Sponsored-by: B?cherei Maichingen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:30:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:30:27 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-H9vSz1Oo4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54388|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:30:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:30:31 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-AaKmm6JCrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54389|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:30:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:30:54 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-9N2zUcs6jZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54390|Bug 17101 - Confirm a       |Bug 17101 - Style up
        description|question before check in    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:35:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:35:27 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-vUrOFwcWCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:47:23 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-kgIphH11bE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:47:25 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-wcP2RDFQTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54268|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54391&action=edit
Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist

Bug 16082, 'Display a friendly "patron does not exist" message if that's the
case - circulation.pl' changed the behavior of the checkout page so that if
you hit that page with a borrowernumber which doesn't exist a nice message will
tell you so.

Now when you do that you get an error message:
  Can't call method "is_debarred" on an undefined value at /circ/circulation.pl
line 300.

Test plan:
confirm that the friendly message is back :)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:48:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:48:46 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-64TTC0KcjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:48:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:48:49 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-N82Jhz5DEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54128|0                           |1
        is obsolete|                            |

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54392&action=edit
Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

Alternative patch works for me.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:48:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:48:54 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-0BfbmhiCfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54129|0                           |1
        is obsolete|                            |

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54393&action=edit
Bug 16686: Rename the transfer method to get_transfer

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:49:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:49:03 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-PWjUO4TuCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54130|0                           |1
        is obsolete|                            |

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54394&action=edit
Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s]

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 19:49:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 17:49:09 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-f1P3lFvdyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54131|0                           |1
        is obsolete|                            |

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54395&action=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 20:15:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 18:15:27 +0000
Subject: [Koha-bugs] [Bug 17120] New: Specify number of rows per page in
 report and initial run
Message-ID: <bug-17120-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120

            Bug ID: 17120
           Summary: Specify number of rows per page in report and initial
                    run
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

I think we could enhance reports so that the &limit= parameter could be
initially set with the report settings and stored in a field in the table.

I also think we could have the drop down available on the parameters page when
running the report the first time.

If you have a report you know that would run well and could be completely shown
with more rows, why not have the option to initially set it differently than
the default?

The LIMIT command in SQL is okay and works for actually limiting the total
number of results, but does weird things if you specify a number larger than
20.  The results still span multiple pages, plus it doesn't give you options
while running like this would.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 20:16:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 18:16:38 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-NKNbAMWgqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 20:16:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 18:16:42 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-jaSvv5LW4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54175|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54396&action=edit
Bug 16996: Do not explode if mandatory fields are missing

At the OPAC, if a patron modify his/her information and at least 1
mandatory field is missing, Koha will crash with
  Template process failed: undef error - Can't call method "description"

It is raised by Koha::Template::Plugin::Categories::GetName called with
an undefined categorycode.
The problem is that the values sent originaly are not sent back to the
template if the user missed something.
This patch makes that all info are resent to the template in order to
show the same form to the user.

Test plan:
0. Apply patch

1. Make sure that the categorycode is not hidden in the OPAC in:
     PatronSelfRegistrationBorrowerUnwantedField or
PatronSelfModificationBorrowerUnwantedField

2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for
example email.

3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave
blank the required field of point 2

4. Press "Submit update request"

There should be no software error.

NOTE: The warns will be floody on the logs.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 20:16:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 18:16:48 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-NqA8Os4g1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54176|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54397&action=edit
Bug 16996: (follow-up) Do not explode if mandatory fields are missing

When registering a new patron, if something went wrong, the form is
resent to the template but without the categorycode (not a dropdown list
anymore, but just displayed as a readonly value # TODO LATER).

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 20:36:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 18:36:33 +0000
Subject: [Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl
In-Reply-To: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15906-70-O0KomykFL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

--- Comment #6 from Michael Kuhn <mik at adminkuhn.ch> ---
In a user account some reasons for payments were created. In the leftside-tab
"Details" I click on "Make payment" and the individual fines & charges are
shown. One is selected, then the button "Pay" on the right is clicked. Now the
system asks for confirmation but still the following error message does appear
and nothing is paid:

Software error: Can't locate object method "new" via package "Koha::Account" at
/home/sandbox1/src/members/paycollect.pl line 114.

The buttons "Pay amount" and "Pay selected" at the bottom work all right,
though. But not the "Pay" button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:01:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:01:34 +0000
Subject: [Koha-bugs] [Bug 16809] Silence authority warnings
 C4::Biblio::TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-SDpVRrVOJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:01:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:01:36 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-LWHpWV14mw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:01:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:01:39 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-eUgjOYkE5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54132|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54398&action=edit
Bug 17009: Speed up the framework duplication

To duplicate frameworks, the code retrieve all the subfields, then
execute 1 insert per subfield.
It's unnecessary slow, we can use the DBMS to do it.

Test plan:
Create a new framework and duplicate the structure of another framework.

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:10:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:10:20 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-3h5kngLiTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
I haven't fully tested, but initial read through and applying looks good. This
makes it much easier to get memcached functioning with plack and is a good
improvement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:21:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:21:59 +0000
Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound
 notifications) to web based self checkout
In-Reply-To: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16732-70-tI1MWOAcey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11431

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:21:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:21:59 +0000
Subject: [Koha-bugs] [Bug 11431] Custom notification sounds
In-Reply-To: <bug-11431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11431-70-XBhB4iY0Ju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16732

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:32:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:32:30 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-8lwGomuZkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 54399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54399&action=edit
Bug 16554: Fix encoding on it-IT file

This patch only fixes encoding of file
installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 21:34:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 19:34:19 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-iU2MqXfPZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to M. Tompsett from comment #30)
...
> While that fixes some, still issues with:
> installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/
> autorites_norme_unimarc.sql -- something about 'CO' duplicate primary key.
> installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/
> framework_DEFAULT.sql -- something about '000' duplicate primary key.
> Also, ru-RU and uk-UA also seem to trigger on mandatory and repeatable
> fields now. They are rather floody.

Did you apply the compressed patches? 

Fixed encoding on it-IT file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 12 23:24:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 21:24:37 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-3gIBDZrFrt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #33 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #32)
> Did you apply the compressed patches? 

Oh, I may have forgotten that. Let me recheck with your encoding fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:26:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:26:28 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-TDgMSsAyXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #8 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54400&action=edit
Bug 17084 - Automatic debian/control updates (unstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:46:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:46:29 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-ecvK9FnJ5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54400|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:50:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:50:48 +0000
Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to
	Koha::Patron
In-Reply-To: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16907-70-JX0LZHSCvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53523|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54401&action=edit
Bug 16907: Koha::Patrons - Move DelMember to ->delete

This patch moves the C4::Members::DelMember subroutine to the
Koha::Patron module.
The delete method must be overwritten to permit handling of patron's
holds.

Test plan:
(With the 2 patches applied)
1/ Create a patron with holds and owner of lists
2/ Delete patrons using the web interface:
 - More > Delete on a patron page
 - Batch patron deletion tools
3/ and the cronjob script
 - perl misc/cronjobs/delete_patrons.pl -c [more options]

The patron should have been moved to the deletedborrowers table, his/her
holds and lists should have been deleted.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:50:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:50:54 +0000
Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to
	Koha::Patron
In-Reply-To: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16907-70-Ls0qe6lvSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53524|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54402&action=edit
Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete

This job should be done each time patron data are deleted. It's better
to do it just before deleting the patron than assuming the caller did
the job by itself.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:51:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:51:00 +0000
Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to
	Koha::Patron
In-Reply-To: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16907-70-i0j2G7p8xL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54184|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54403&action=edit
Bug 16907: Make sure the log will be written only if the patron has been
deleted

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 00:51:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 22:51:50 +0000
Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to
	Koha::Patron
In-Reply-To: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16907-70-mONur19iH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Nice work, Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 01:26:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 12 Aug 2016 23:26:05 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-v7i7ki8W6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #34 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54404&action=edit
Bug 16554 - DO NOT PUSH - Follow up to testing script

Made it so that it really does fail or not based on testing.
Also, added printing of files it is loading as it goes along.
Forced a fail test for the files that don't load so they
will get summarized at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:04:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:04:01 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-QeHdNSes4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51620|0                           |1
        is obsolete|                            |

--- Comment #35 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54405&action=edit
Bug 16554: Fix fr-FR sample files

Needs Bug 13669

Rewrite autorites_norme_unimarc.sql to
use only one INSERT IGNORE.

New load method complains about duplicate keys,
and both auth files are mandatory!

Also removed blank space from sample_labels.sql

Tested with unimarc_complet and all sample files.

To test
1) Apply the patch
2) Try fr-FR web installer, unimarc_complet + all sample files
There must be no errors

Don't know if fr-FR marc21 and unimarc_lecture_pub are used,
need a look from french users.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:04:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:04:07 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-6U6IBA3ZKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51621|0                           |1
        is obsolete|                            |

--- Comment #36 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54406&action=edit
Bug 16554: Fix I18N sample files

Needs Bug 13669

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
a) de-DE, es-ES, fr-CA and pl-PL
There must be no problems for marc21 + all sample files
b) nb-NO
There must be no problems for normarc + all sample files

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:04:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:04:18 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-b21WMSdHuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51753|0                           |1
        is obsolete|                            |

--- Comment #37 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54407&action=edit
Bug 16554: rewrite mandatory and sample data - es-ES

More changes to es-ES files

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:04:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:04:26 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-xGAlcY3NcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51756|0                           |1
        is obsolete|                            |

--- Comment #38 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54408&action=edit
Bug 16554: rewrite mandatory and sample data - nb-NO

More changes to nb-NO files

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:04:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:04:57 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-h1YxSDI1fP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51757|0                           |1
        is obsolete|                            |

--- Comment #39 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54409&action=edit
Bug 16554: rewrite mandatory and sample data - pl-PL

More changes to pl-PL files

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:05:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:05:08 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Sfa9ykyL1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51840|0                           |1
        is obsolete|                            |

--- Comment #40 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54410&action=edit
Bug 16554: DO NOT PUSH - test for all sample files

You will need to create a koha_test_installer DB before

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:05:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:05:13 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-JvT5sbVsmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51890|0                           |1
        is obsolete|                            |

--- Comment #41 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54411&action=edit
Bug 16554: DO NOT PUSH - (followup) - sorted filenames

Filenames must be loaded in alphabetical order.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:05:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:05:52 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-jWil5qfpJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51897|0                           |1
        is obsolete|                            |

--- Comment #42 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54412&action=edit
Bug 16554: More i18n changes - en, es, nb and pl files

Mostly fixes bad values in auth files ( '' -> 0 )

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:06:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:06:05 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-aGuPsehbc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54136|0                           |1
        is obsolete|                            |

--- Comment #43 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54413&action=edit
Bug 16554: rewrite mandatory and sample data - it-IT

More changes to it-IT files

Checked marc21 and unimarc files
unimarc_relatorterms.sql had bad encoding, others minor
errors

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:06:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:06:16 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-LbVDu1YO1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54137|0                           |1
        is obsolete|                            |

--- Comment #44 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54414&action=edit
Bug 16554: rewrite mandatory and sample data - de-DE

More changes to de-DE files

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:06:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:06:23 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-gRO7T7iWcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54399|0                           |1
        is obsolete|                            |

--- Comment #45 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54415&action=edit
Bug 16554: Fix encoding on it-IT file

This patch only fixes encoding of file
installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:06:30 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Dahwgfuvti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54404|0                           |1
        is obsolete|                            |

--- Comment #46 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54416&action=edit
Bug 16554 - DO NOT PUSH - Follow up to testing script

Made it so that it really does fail or not based on testing.
Also, added printing of files it is loading as it goes along.
Forced a fail test for the files that don't load so they
will get summarized at the end.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:07:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:07:34 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-ZROgHCtFCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #47 from M. Tompsett <mtompset at hotmail.com> ---
Those gzip's are a pain to handle. This comment serves as notice that I, Mark
Tompsett, sign those off too!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:18:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:18:09 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-NFs1koNWcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 54321
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54321
Bug 17103 - Google API Loader jsapi called over http

Review of attachment 54321:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17103&attachment=54321)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
@@ +209,4 @@
>      </script>
>  [% END %]
>  [% IF ( GoogleIndicTransliteration ) %]
> +    <script type="text/javascript" src="//www.google.com/jsapi"></script>

I was expecting https:// not just //. This should work, but only because google
and/or your browser makes it work. Explicit is always best.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:29:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:29:39 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-EphYeFEbDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54321|0                           |1
        is obsolete|                            |

--- Comment #3 from Indranil Das Gupta <indradg at l2c2.co.in> ---
Created attachment 54417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54417&action=edit
Bug 17103 - Google API Loader jsapi called over http

This patch removes the hardcoded protocol ("http") from the URI,
leaving the browser to negotiate the correct http/https context.
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:40:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:40:32 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-ztCKbIaJYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54417|0                           |1
        is obsolete|                            |

--- Comment #4 from Indranil Das Gupta <indradg at l2c2.co.in> ---
Created attachment 54418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54418&action=edit
Bug 17103 - Google API Loader jsapi called over http

This patch replaces the hardcoded protocol ("http") from the URI with
https since that is what Google defacto uses to serve JS resources
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 02:45:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 00:45:50 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-WCTw3Yz1nQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54318|0                           |1
        is obsolete|                            |

--- Comment #5 from Mehdi Hamidi <mehdi.hamidi at inlibro.com> ---
Created attachment 54419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54419&action=edit
Bug 17015 - New koha calendar

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 03:11:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 01:11:39 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-SNQYwoqLiz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 03:11:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 01:11:41 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-mqZmNuP98w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54418|0                           |1
        is obsolete|                            |

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54420&action=edit
Bug 17103 - Google API Loader jsapi called over http

This patch replaces the hardcoded protocol ("http") from the URI with
https since that is what Google defacto uses to serve JS resources
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 04:21:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 02:21:36 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-AfjgYxorLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #4 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54421&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:06:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:06:58 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-3vtzxHrjgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17066


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066
[Bug 17066] build-git-snapshot: add basetgz parameter and update master version
number for 3.22.x
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:06:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:06:58 +0000
Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter
 and update master version number for 3.22.x
In-Reply-To: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17066-70-QREfwEvObz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer & add
libhtml-parser-perl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:07:16 +0000
Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter
 and update master version number for 3.22.x
In-Reply-To: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17066-70-5MjblCWXqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17062                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer & add
libhtml-parser-perl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:07:16 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-rEiqZd9fno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17066                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066
[Bug 17066] build-git-snapshot: add basetgz parameter and update master version
number for 3.22.x
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:07:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:07:30 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-rx4kTRIp1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer & add
libhtml-parser-perl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:07:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:07:30 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-QL55KKahQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111
[Bug 17111] Automatic debian/control updates (oldstable)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:16:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:16:49 +0000
Subject: [Koha-bugs] [Bug 17063] debian/control.in update: change maintainer
 & add libhtml-parser-perl for 16.05.x
In-Reply-To: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17063-70-UpgP4coOfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17063

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:17:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:17:24 +0000
Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.*
In-Reply-To: <bug-16647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16647-70-k9qtqJLIDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:18:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:18:31 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-ulSTeRKNtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
This is already pushed to 16.05 (bug 17063) but needs to go in 3.22. This patch
applies.

Julian, can you please push it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:20:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:20:38 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-RYe5aI8dJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54421|0                           |1
        is obsolete|                            |

--- Comment #5 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54422&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:35:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:35:30 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-XwlRnHwACR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Hm this is getting a little confusing with the dependency bugs for different
versions. Sorry. I will add a new bug for 3.22.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:37:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:37:13 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-O9vDsPdnJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:37:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:37:13 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-g21vUvh6GI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111
Bug 17111 depends on bug 17062, which changed state.

Bug 17062 Summary: debian/control.in update: change maintainer & add libhtml-parser-perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |CLOSED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:43:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:43:35 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-BhtM0h3K9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
This bug is also valid for 3.22.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:44:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:44:01 +0000
Subject: [Koha-bugs] [Bug 17121] New: debian/control.in update: change
 maintainer for 3.22.x
Message-ID: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

            Bug ID: 17121
           Summary: debian/control.in update: change maintainer for 3.22.x
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Changing the package maintainer and removing a whitespace in debian/control.in.

The version for 3.22 does not include libhtml-parser-perl because bug 16971 is
not pushed to 3.22 yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:44:09 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-zUmlgjHAZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:44:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:44:15 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-z8ThpQY3A1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:46:34 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-1XiyuT553K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54423&action=edit
Bug 17121 - debian/control.in update: change maintainer for 3.22.x

Changing the package maintainer and removing a whitespace in
debian/control.in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:46:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:46:50 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-TQWL9ibvlx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:47:18 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-87S4O1BkG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17062

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:47:18 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-FkC2nivdpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17121

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:50:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:50:04 +0000
Subject: [Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter
 and update master version number
In-Reply-To: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17013-70-tjuCmedxFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:51:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:51:27 +0000
Subject: [Koha-bugs] [Bug 17017] Dependency fixes for 16.05
In-Reply-To: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17017-70-vD7ALJbpXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |CLOSED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:52:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:52:02 +0000
Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include
	youtube
In-Reply-To: <bug-14168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14168-70-vzZR7DtmzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:52:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:52:18 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-Yv1B3w7uco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:52:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:52:19 +0000
Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing
In-Reply-To: <bug-15587-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15587-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15587-70-WeoAdfhY4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587
Bug 15587 depends on bug 15303, which changed state.

Bug 15303 Summary: Letsencrypt option for Debian package installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |CLOSED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 13:57:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 11:57:33 +0000
Subject: [Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~
	file
In-Reply-To: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17064-70-MBTA4SqGgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |CLOSED

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
Not valid for 3.22. Closing bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:04:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:04:22 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-SOHRqlGgve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111
[Bug 17111] Automatic debian/control updates (oldstable)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:04:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:04:22 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-mQoOfOwpN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121
[Bug 17121] debian/control.in update: change maintainer for 3.22.x
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:04:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:04:34 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-dexN8799o0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:13:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:13:18 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-dKGNWnqlyD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54422|0                           |1
        is obsolete|                            |

--- Comment #6 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54424&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:14:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:14:43 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-BWq5pDYRYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
With the second patch, I see a message when the item was not checked in, but
there are no messages anymore for the other options besides "Question".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:20:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:20:18 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-NysMGxBwug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54322|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:21:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:21:30 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-ou75GuACip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17062                       |
             Status|ASSIGNED                    |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
[Bug 17062] debian/control.in update: change maintainer & add
libhtml-parser-perl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 14:21:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 12:21:30 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-ZPrSaLsUPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17111                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111
[Bug 17111] Automatic debian/control updates (oldstable)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 15:38:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 13:38:46 +0000
Subject: [Koha-bugs] [Bug 13032] Feature Request -- command line switch to
 add page breaks to overdue_notices.pl
In-Reply-To: <bug-13032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13032-70-qeDDpnWPU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think maybe we don't need a switch for that - it sounds interesting in
general.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 18:07:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 16:07:24 +0000
Subject: [Koha-bugs] [Bug 16746] Can not find duplicated authorities
 cataloguing a new one
In-Reply-To: <bug-16746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16746-70-HDPb5GuAPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16588

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 18:07:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 16:07:24 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-OeGRniB1Xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16746

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
Since this touches a lot of { index => ... } stuff, I thought I'd add bug 16746
to the see also, given my counter patch and discussion on the bug regarding
elastic vs. zebra calls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 18:23:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 16:23:17 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-oZ7SNlIok0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
After applying this, there was still Readonly in Koha/Edifact/Order.pm, which
is related in part to bug 16703's adding it back in, I think. Does _const
really need Readonly for it to work?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 18:27:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 16:27:13 +0000
Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password
	comparison
In-Reply-To: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6979-70-mCCUhzX5Pj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 46863
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46863
Bug 6979 - Handle multiple branches in non-auth_by_bin

Review of attachment 46863:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6979&attachment=46863)
-----------------------------------------------------------------

::: C4/Auth_with_ldap.pm
@@ +96,4 @@
>  		warn sprintf("LDAP Auth rejected : %s gets %d hits\n", $filter->as_string, $count) . description($search);
>  		return 0;
>  	}
> +    if ($count == 0) {

So what does $count>1 mean?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 19:59:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 17:59:09 +0000
Subject: [Koha-bugs] [Bug 1688] search string starting with '*' kills search
In-Reply-To: <bug-1688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1688-70-OBDPOWJmob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1688

--- Comment #1 from Nightly Build Bot <nightly at abunchofthings.net> ---
This is a test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 20:44:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 18:44:36 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-egTzhkqrMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 20:45:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 18:45:41 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-6rqeSEgkEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17108,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17111
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 20:45:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 18:45:41 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-bWgPzSc7y5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17084

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 13 20:45:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 13 Aug 2016 18:45:41 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-MNkXvYjBRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17084

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 09:21:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 07:21:11 +0000
Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password
	comparison
In-Reply-To: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6979-70-SJXIVj99H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pretty sure the greater than one is caught in the codeblock above your comment.
 If means more than one user in ldap matched the koha matchpoint. I.e. We 
can't perform a compare because we're not confident we're matching the right
user.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 10:56:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 08:56:17 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-qf3GQdDWNJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

--- Comment #9 from Tobias Reimann <T.Reimann95 at gmx.de> ---
Created attachment 54425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54425&action=edit
Bug 17101 - Confirm a question before check in

This patch enable a message for the user after he hit no, by the
question in the check in window. Fixed the bug that no other message are
displayed

        (new) Test plan:

        1. Create an itemtype, with the checkinmsgtype question
        2. Create an item with the itemtype from 1
        3. Check out the item from 2
        4. Check in the item from 3
        5. Click no ==> item shouldn't be check in and a message should be
displ
ayed
        6. Check in the item from 3
        7. Click yes ==> item should be check in
ed

        Optional:
        Before step 4 check others item in, to check if the prevouis check in's
        Sponsored-by: B?cherei Maichingen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 10:56:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 08:56:52 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-We8GR4t9ia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54390|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 10:57:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 08:57:10 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-aKUG5a8QJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54425|Bug 17101 - Confirm a       |Bug 17101 - Style Up fix
        description|question before check in    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 10:57:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 08:57:29 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-nnFctw0kA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Tobias Reimann <T.Reimann95 at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 11:46:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 09:46:45 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-Yt6LnfRIre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54424|0                           |1
        is obsolete|                            |

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54426&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 11:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 09:47:25 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-KmzAibI60T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 11:51:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 09:51:35 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-WOmplWz49u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #7)
> Comment on attachment 54312 [details] [review]
> [SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print
> 
> Review of attachment 54312 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
> @@ +105,4 @@
> >              </tr>
> >  
> >              [% FOREACH account IN accounts %]
> > +                [% IF ( account.amountoutstanding < 0 ) || ( account.amountoutstanding > 0 ) %]
> 
> Marc, why did you replace
>   next if amount == 0
> with this lines?

It did not work with amount == 0 because the amount comes as '0.00' (not sure
how much decimals tough)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:28:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:28:49 +0000
Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered
	borrowers
In-Reply-To: <bug-12566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12566-70-sRlh5iv4Kw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16275

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, there is a new patch on the way to master - bug 16275: it allows to
duplicate check on the e-mail address and will prevent another registration if
there is already an account with this address. Liz, does this resolve the issue
for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:28:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:28:49 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-9MGJX278d1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12566

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:32:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:32:43 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-irFn11i7yb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The follow-up is small - I think it's safe to treat it as a QA follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:42:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:42:09 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-H2nIL9bGUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #98 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Srdjan, I am sorry, I didn't get back to this earlier :(
Now patches don't apply and can't retest as you asked:

...
CONFLICT (content): Merge conflict in opac/opac-detail.pl
Auto-merging catalogue/detail.pl
CONFLICT (content): Merge conflict in catalogue/detail.pl
Auto-merging C4/XSLT.pm
CONFLICT (content): Merge conflict in C4/XSLT.pm
Auto-merging C4/Search.pm
CONFLICT (content): Merge conflict in C4/Search.pm
Auto-merging C4/Items.pm
...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:47:18 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-5NjaYnKvAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patches still apply - can we rescue this? 

The only left obstacle appears to be a missing unit test. Looking at comment#38
from David - could this be a possible way?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:52:25 +0000
Subject: [Koha-bugs] [Bug 13191] Null borrowernumber in reserves table
In-Reply-To: <bug-13191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13191-70-PMiSfax1Sv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WONTFIX

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This was reported against a very old and now unmaintained version of Koha -
3.16. I am closing WONTFIX - please reopen if you can still see this happening
in a more current version.

NULL borrowernumbers in old_reserves can happen when deleting a patron:
CONSTRAINT `old_reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE SET NULL,

In reserves the line should be deleted:
 CONSTRAINT `reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE,

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 12:59:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 10:59:26 +0000
Subject: [Koha-bugs] [Bug 14096] Licences on About page not consistently
	linked
In-Reply-To: <bug-14096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14096-70-uRJqf0WFra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14096

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I confirm - closing this. Please reopen if there are still concerns.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:24:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:24:44 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-zv3gLCy11h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
Trivial patch, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:38:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:38:46 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-Hk1dWUDRAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
This is a patch for 3.22.x! To test:

git checkout -b bug_17121 origin/3.22.x
debian/update-control
git diff

The result of git diff should be two changes in debian/control:

1) The maintainer line

-Maintainer: Galen Charlton <gmcharlt at gmail.com>
+Maintainer: Mirko Tietgen <mirko at abunchofthings.net>

2) A deleted trailing whitespace

- perl-modules, 
+ perl-modules,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:39:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:39:05 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-taLjXAYvXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:40:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:40:07 +0000
Subject: [Koha-bugs] [Bug 17121] debian/control.in update: change maintainer
	for 3.22.x
In-Reply-To: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17121-70-rlDHCa72LD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:48:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:48:38 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-MxlBkjRm9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Any update on this? I think still a feature a lot of people would like to see!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 13:53:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 11:53:19 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-sHsLQVstOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd still like to see a fix for this - some libraries like the languages in the
footer better than in the top menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:01:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:01:40 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-3APGdQyNUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:01:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:01:43 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-sR32HujFmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54420|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54427&action=edit
[PASSED QA] Bug 17103 - Google API Loader jsapi called over http

This patch replaces the hardcoded protocol ("http") from the URI with
https since that is what Google defacto uses to serve JS resources
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:07:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:07:43 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-DoqaWzoFHV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #104 from Mirko Tietgen <mirko at abunchofthings.net> ---
I wanted to test it at the hackfest in Berlin. Unfortunately Zeno said the code
is not available, he has to ask his employer first (If I understood correctly).
The bug is still assigned to Jesse, who is also not working on this any longer
I guess.

Zeno: could you update on this? If it is a proprietary enhancement you are
working on, you should not imply you are working on it for the community. It
would be helpful to know if your code will end up here, because otherwise you
are keeping people from developing this feature for Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:16:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:16:33 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-z7foB5VWik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:16:36 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-B89rUiSKOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54379|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54428&action=edit
[PASSED QA] Bug 17117: Patron personal details not displayed unless branch
update request is enabled

In patron acount ("your personal details" tab, which serves as a form
for submitting update requests as well) it's not possible to display
some account details like expiration date etc., without enabling
the field for branch / library update requests too.

To reproduce:

1) set OPACPatronDetails to "Allow"
2) clear PatronSelfModificationBorrowerUnwantedField preference
- all possible fields in the update requests form are visible
in patron account, including some extra details (card number,
expiration date, category) in the "Library" section on top
3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference
4) the whole 'Library' section disappears

To test:

1) apply patch
2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField,
'Library' section should remain visible (sans branch selection option)
3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same
preference, 'Library' section should now disappear

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:22:38 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-6elZwLWk3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #105 from Zeno Tajoli <z.tajoli at cineca.it> ---
I'm sorry but I need to confirm the words
of Mirko.
There are also problems on installing PazPar on a server
with a previous installation of Koha.
Today my suggestion is to use a different server with PazPar.
I will write more info after 25 of August.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:45:44 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-ynvmu2vsJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking at it again... having library mandatory appears a bit silly as it's
currently not possible to 'unset' it - so I got not idea on how to trigger this
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:55:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:55:07 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-YYSKPOUFaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe something for a different bug: What about renaming copyright date to
publication year? I think this could make the format more obvious too. Also...
is collection title meant to be series? We have this showing up in some places
in Koha and it seems related to UNIMARC - but not sure what it is supposed to
be in MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:57:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:57:54 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-5dDuztkYrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are some things not super-perfect here, but I think no blockers. 
Making the library mandatory doesn't hurt - we can think about having it empty
or to 'all libraries' separately.
The new format check keeps you from submitting something that cannot be stored
in the database - improving the GUI is also something we can do separately.
Maybe we could just display a hint behind the field in a grey font as we do in
other places.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:58:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:58:53 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-srStPSIRfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:58:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:58:58 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-1HbazgxV3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54083|0                           |1
        is obsolete|                            |
  Attachment #54084|0                           |1
        is obsolete|                            |
  Attachment #54356|0                           |1
        is obsolete|                            |

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54430&action=edit
[PASSED QA] Bug 10848 - Allow configuration of mandatory/required fields on the
suggestion form in OPAC

This patch adds a configuration option which allows to define which
fields should be mandatory for a patron purchase suggestion form in OPAC.

Test plan:

1/ Apply patch.
2/ Play with the new OPACSuggestionMandatoryFields system preference
(select some fields as manadatory, select all, deselect all, try to
submit some suggestions with mandatory fields filled and/or not
filled etc.) to ensure that required fields (and only required fields)
are enforced in the browser to be filled.
3/ With all options deselected, 'Title' field should still be
mandatory (by default).

Signed-off-by: barbara johnson <barbara.johnson at bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 14:59:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 12:59:46 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-tTShYSq6GQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54431&action=edit
[PASSED QA] Bug 10848 - Allow configuration of mandatory/required fields on the
suggestion form in OPAC - part 2

Add 'OPACSuggestionMandatoryFields' syspref definition plus
an atomic DB update for the new preference.

Signed-off-by: barbara johnson <barbara.johnson at bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:01:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:01:01 +0000
Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required
 fields on the suggestion form in OPAC
In-Reply-To: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10848-70-nlE6za3PCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54432&action=edit
[PASSED QA] Bug 10848 - [QA Followup] Add missing branch option and fix pattern
for copyrightdate

- HTML5 input pattern for copyrightdate was not taking into an account
the database field type, which is smallint(5)
- added title="..." for the year field so the acceptable date format
should be displayed as a hint/tooltip in the browser
- added an missing option for configuring branch/library as mandatory

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:14:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:14:08 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-DR4uvm4mki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:14:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:14:11 +0000
Subject: [Koha-bugs] [Bug 17112] Action buttons for course reserves detail
	page
In-Reply-To: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17112-70-ZpY2SryjfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54378|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54433&action=edit
[PASSED QA] Bug 17112: Action buttons for course reserves detail page

This patch revises the edit and delete buttons on the course reserves
detail page so that they are styled as Bootstrap buttons with Font
Awesome icons.

To test, apply the patch and choose or create a course reserve which has
in it at least one lost item and at least one item which is checked out.

- In the list of items on the course reserve detail page, confirm that
  the 'Edit' and 'Delete' buttons are correctly styled.
- Confirm that for the checked out item the delete button is disabled.
  Hovering over the button should trigger a tooltip. Clicking the button
  should trigger an alert.
- Confirm that for the lost item the same is true.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Buttons styled as Bootstrap. Works as expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:19:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:19:00 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-73cQHnrFTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:19:03 +0000
Subject: [Koha-bugs] [Bug 17099] GetSupportName and GetSupportList from C4/
 Koha.pm are no longer used
In-Reply-To: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17099-70-3QkkiSx9iS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54267|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54434&action=edit
[PASSED QA] Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList

Since bug 9468, these 2 subroutines are no longer in used and can be
removed.

Test plan:
  git grep GetSupportName
and
  git grep GetSupportList
should not return entries (unless 1 in release notes)

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:58:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:58:31 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-nsWhtToOH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 15:58:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 13:58:34 +0000
Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools
	templates
In-Reply-To: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17083-70-kn5TwAYIMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54244|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54435&action=edit
[PASSED QA] Bug 17083: Remove more event attributes from tools templates

This patch removes event attributes from several tool-related templates.
Events are defined instead in the JavaScript.

To test, apply the patch and:

- Go to Tools -> Label creator -> Manage -> Layouts and edit any layout.
  - In the "Font" setting, choose any font which includes the word
    "italic" or "oblique" in the name. Doing so should disable the
    "Oblique title" checkbox.
- Go to Tools -> Batch patron deletion/anonymization.
  - Submit the form without making any changes. You should be prompted
    to select an action.
- Go to Tools -> Inventory.
  - Select a batch of barcodes to upload.
  - Submit the form without selecting any filters. This should trigger a
    warning.
  - Also changed: Added Font Awesome icons to the "Select all" and
    "Clear all" links on the inventory results view.
- Go to Tools -> Notices and Slips.
  - Click "New notice"
  - Change the selection under "Koha module." The page should reload
    with the correct available message body fields. For instance,
    selecting "Holds" should make available reserves.* columns.
- Go to Tools -> Upload.
  - In the search form, enter a search term and click the 'Search'
    button. The form should submit.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised. Event attributes removed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:11:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:11:53 +0000
Subject: [Koha-bugs] [Bug 16841] Help for Library EANs
In-Reply-To: <bug-16841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16841-70-RxegZHdjzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:11:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:11:56 +0000
Subject: [Koha-bugs] [Bug 16841] Help for Library EANs
In-Reply-To: <bug-16841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16841-70-liQptdW51l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53085|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54436&action=edit
[PASSED QA] Bug 16841: Help for library EANs

To test:

1) Go to Admin -> Library EANs
2) Click Help in top-right corner
3) Confirm that Help window opens with appropriate help text
4) Confirm link to manual works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixed link to the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:18:58 +0000
Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages
In-Reply-To: <bug-16843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16843-70-ViGRagW4D0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:19:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:19:01 +0000
Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages
In-Reply-To: <bug-16843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16843-70-Qk71ZSoM4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53081|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54437&action=edit
[PASSED QA] Bug 16843: Help for EDIFACT messages

To test:

1) Go to Acqui -> EDIFACT messages
2) Click Help in top-right corner
3) Confirm that Help window opens with appropriate help text
4) Confirm link to manual works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:24:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:24:19 +0000
Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts
In-Reply-To: <bug-16842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16842-70-PDVuXHlkHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:24:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:24:22 +0000
Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts
In-Reply-To: <bug-16842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16842-70-ZUe5JpC0xB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53080|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54438&action=edit
[PASSED QA] Bug 16842: Help for EDI accounts

To test:

1) Go to Admin -> EDI accounts
2) Click Help in top-right corner
3) Confirm that Help window opens with appropriate help text
4) Confirm links work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Fixed link to the manual: cat -> acq

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:25:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:25:11 +0000
Subject: [Koha-bugs] [Bug 16982] Add EDI account to new menu on vendor page
In-Reply-To: <bug-16982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16982-70-Udq2fYvgfE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|add edi account to new menu |Add EDI account to new menu
                   |on vendor page              |on vendor page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:32:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:32:44 +0000
Subject: [Koha-bugs] [Bug 16982] Add EDI account to new menu on vendor page
In-Reply-To: <bug-16982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16982-70-hjGqh1stIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tiny capitalization issue "EDI Account" and a question: 

My expectation for this feature was that I'd be led to a page where I could add
an EDI account for the vendor I came from - so I was surprised that the vendor
that showed on 'new' was not the one I had started from. Could we improve this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:35:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:35:33 +0000
Subject: [Koha-bugs] [Bug 16817] Apply hold fee on collection not application
In-Reply-To: <bug-16817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16817-70-4NlrZ60k4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16817

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:36:39 +0000
Subject: [Koha-bugs] [Bug 6759] Use a different account type for account
 renewals than for new accounts
In-Reply-To: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6759-70-p4JtrCJaAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Use Accounttype 'R' for     |Use a different account
                   |renewal related fees        |type for account renewals
                   |                            |than for new accounts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:36:58 +0000
Subject: [Koha-bugs] [Bug 6759] Use a different account type for account
 renewals than for new accounts
In-Reply-To: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6759-70-wAulahoTpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|navya.vp at osslabs.biz        |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Resetting to default - please take the bug if you intend to work on it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:42:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:42:57 +0000
Subject: [Koha-bugs] [Bug 16595] Concurrent search between ISBN-10 and
 ISBN-13 in staff client and OPAC
In-Reply-To: <bug-16595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16595-70-sjVyFa8vg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16595

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 13528 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:42:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:42:57 +0000
Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn
	variations
In-Reply-To: <bug-13528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13528-70-SF3gcYoSeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imingchan at yahoo.com.au

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16595 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:45:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:45:22 +0000
Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken
In-Reply-To: <bug-15782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15782-70-Z2n8cxqDTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this can be closed - 3.20 will mostly get security fixes at this point
in time. Thx a lot Owen for testing this out!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:52:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:52:12 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-UI3AgQV0oN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Oliver, just found this bug:

1) Could you reattach the file as a complete patch file? It's only the diff,
but it doesn't have the information about the authorship etc. as you can see on
other bugs.

There are at least 2 ways to do this:
- git format-patch
(https://wiki.koha-community.org/wiki/Version_Control_Using_Git)
- git bz (https://wiki.koha-community.org/wiki/Git_bz_configuration)

In both cases, make sure you set up your git config before you create the file
so it contains your name and e-mail address.

2) After attaching a patch file, don't forget to change the status to "Needs
Sign-off". This will make the bug show up in the lists the testers look at -
otherwise your work can be easily missed.

3) If you provide a patch, don't forget to assign the bug to yourself, changing
the 'Assignee' in the bug report.

Please let us know if we can help you with any of that or if there are other
questions about the development process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:54:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:54:58 +0000
Subject: [Koha-bugs] [Bug 16631] Show groups/categories of reports to
	authorized staff
In-Reply-To: <bug-16631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16631-70-smeIkJNmD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:57:27 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-ytpnxqlqsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #89 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We are so close on this... please don't give up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 16:59:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 14:59:29 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-2rh6MXMFsD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Chris, any update on this maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:01:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:01:17 +0000
Subject: [Koha-bugs] [Bug 4533] Add "duplicate item" link when editing items
In-Reply-To: <bug-4533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4533-70-iIDZQbpIvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Feature exists!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:11:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:11:39 +0000
Subject: [Koha-bugs] [Bug 4814] Item Type (MARC952 $c) not self-populating
 from imported OCLC bib
In-Reply-To: <bug-4814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4814-70-TLyfGkwmiP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We don't have enough information to reproduce this:

- How was the record imported? Staged tools, Z39.50, SRU, bulkmarcimport,
connexion client functionality?
- Does the problem appear in current versions of Koha?
- How does a sample record look like?

I think this is more likely to be an issue outside of Koha - maybe
capitalization of the itemtype code or similar. I am setting resolved INVALID
for now - please reopen if you have more information and still see this problem
happening.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:17:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:17:24 +0000
Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system
 preference in UNIMARC
In-Reply-To: <bug-11460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11460-70-CCBPrqnL7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|3.14                        |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The pref description currently reads:

Map the MARC subfield to an item's callnumber. [ .... ] (This can contain
multiple subfields to look in; for instance 082ab would look in 082 subfields a
and b.)
Examples (for MARC21 records): Dewey: 082ab or 092ab; LOC: 050ab or 090ab; from
the item record: 852hi 

I think the easiest solution for now would be to add a UNIMARC example in the
text and remove the default setting for new installations. Presetting it with a
matching value depending on the MARC selection would not be so easy.

For every language installer, a syspref.sql file can be added later to set
individual values (check it-IT or de-DE for examples) that are good for the
given language.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:18:58 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-UXW9Ow0kLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10276
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
[Bug 10276] Extend IndependentBranches to support groups of libraries
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:18:58 +0000
Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support
 groups of libraries
In-Reply-To: <bug-10276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10276-70-HQsEDSDbxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022
[Bug 12022] Independent branches does not isolate pending and approved comments
by branch.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:19:53 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-X7hdiKUyjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |master

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Commit message mentions a depending bug that was marked as WONTFIX - Kyle,
could you take a look here maybe?

My feeling is that the behaviour might still be desirable, but we'd need a
restart on the patches?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:22:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:22:35 +0000
Subject: [Koha-bugs] [Bug 16712] Unknown Error Message from Item records
In-Reply-To: <bug-16712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16712-70-DvxXNNyzmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16712

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We have been using 3.18 for a long time now with our libraries without
experiencing this error. I think it might be related to invalid data - as it
sounds like an error in the MARCXML.

Laura, please reopen, if you still experience the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:52:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:52:17 +0000
Subject: [Koha-bugs] [Bug 16775] install.pl error: BLOB, TEXT,
 GEOMETRY or JSON column ' defaultvalue' can't have a default value
In-Reply-To: <bug-16775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16775-70-3L4sqdwtfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16775

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Katrin's comments (comment #8) are correct. Those issues are solved by those
bug patches. Marking as duplicate.

*** This bug has been marked as a duplicate of bug 16554 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 17:52:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 15:52:17 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-rp5wqJqOw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pallavi.tomar at gmail.com

--- Comment #48 from M. Tompsett <mtompset at hotmail.com> ---
*** Bug 16775 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:28:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:28:17 +0000
Subject: [Koha-bugs] [Bug 16865] marking branchcode unwanted breaks self
	registration
In-Reply-To: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16865-70-zMqpCMUyOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
-- or add a default branch code? :)
Similar to bug 16892 that I did for the OAuth2 auto-register.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:33:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:33:42 +0000
Subject: [Koha-bugs] [Bug 14618] XSLT: missing punctuation between the Type
 of Material and the Nature of contents
In-Reply-To: <bug-14618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14618-70-3XWTRDtV5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14618

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54439&action=edit
screenshot

This is a screenshot from a 3.18.x - all I see is maybe a missing space before
the first ;?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:35:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:35:50 +0000
Subject: [Koha-bugs] [Bug 14618] XSLT: missing punctuation between the Type
 of Material and the Nature of contents
In-Reply-To: <bug-14618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14618-70-PVD5PE9Q9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14618

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Display could be normalized a bit I'd say - it's the same on master - switching
version. Maybe we should change the ; to |?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:38:05 +0000
Subject: [Koha-bugs] [Bug 14447] Show the vol./ no. on the child record
 based from the host entry
In-Reply-To: <bug-14447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14447-70-isxcu7Smgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I think this worked ok in my testing - changing to WORKSFORME. 
Please reopen if we missed something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:45:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:45:05 +0000
Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch
In-Reply-To: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13736-70-BT3YCBidNi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|ASSIGNED                    |Needs Signoff
            Version|3.18                        |master

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like there is a bit of a mismatch between EDS-specific system
preferences in the templats and having it as a plugin in the first place. Could
those change be generalized in some way? For example we could enable plugins to
add specific JavaScript to the files maybe.

Patch doesn't apply to master - I am moving this to master and "Patch doesn't
apply" for the moment. The installation instructions still include:
'Click on Run Tool and follow instructions to patch core Koha files.'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 18:45:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 16:45:15 +0000
Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch
In-Reply-To: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13736-70-JNLPNPV9bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:01:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:01:16 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-HzQhj69Yz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51912|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54440&action=edit
Bug 16615: Open Library API fails for full-site-SSL

When running Koha in a full-site-SSL configuration accessing
external resouces like Open Library cover images via HTTP
doesn't work (mixed SSL/non-SSL content). It thus breaks a
core feature of Koha. Referencing such resources always via
HTTPS resolves the problem and also enhances privacy as a
side-effect.

Previous tickets took care of Amazon resources. This ticket
is supposed to address the remaining external resource providers,
starting with Open Library.

TEST PLAN
---------
1) Over https access your OPAC with the Enhanced Content system
   preferences 'OpenLibraryCovers' set to 'Add', and
   'OpenLibrarySearch' set to 'Show'.
2) Search for something (e.g. Mo Willems)
   -- Your browser console log will show messages about
      mixed content.
3) Apply the patch
4) Making sure to reload the java script, attempt steps 1 & 2
   again.
   -- no mixed content messages should be given
5) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:02:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:02:52 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-SFPMCi06yF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54441&action=edit
Bug 16615: Follow up - missed a spot

Also, it is recommended to apply bug 17103 before this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:04:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:04:56 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-N6df00hFMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54440|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54442&action=edit
Bug 16615: Open Library API fails for full-site-SSL

When running Koha in a full-site-SSL configuration accessing
external resouces like Open Library cover images via HTTP
doesn't work (mixed SSL/non-SSL content). It thus breaks a
core feature of Koha. Referencing such resources always via
HTTPS resolves the problem and also enhances privacy as a
side-effect.

Previous tickets took care of Amazon resources. This ticket
is supposed to address the remaining external resource providers,
starting with Open Library.

TEST PLAN
---------
1) Over https access your OPAC with the Enhanced Content system
   preferences 'OpenLibraryCovers' set to 'Add', and
   'OpenLibrarySearch' set to 'Show'.
2) Search for something (e.g. Mo Willems)
   -- Your browser console log will show messages about
      mixed content.
3) Apply the patch
4) Making sure to reload the java script, attempt steps 1 & 2
   again.
   -- no mixed content messages should be given
5) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:05:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:05:01 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-DAlelR8sUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54441|0                           |1
        is obsolete|                            |

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54443&action=edit
Bug 16615: Follow up - missed a spot

Also, it is recommended to apply bug 17103 before this.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:05:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:05:41 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-0RA5BA07x9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:06:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:06:11 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-BIpfG3sZp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |oliver.bock at aei.mpg.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:07:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:07:51 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-40ewUCYUEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54444&action=edit
Bug 17103 - Google API Loader jsapi called over http

This patch replaces the hardcoded protocol ("http") from the URI with
https since that is what Google defacto uses to serve JS resources
Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
to function correctly when used in SSLized OPACs.

Test plan
---------

1/ Make sure your OPAC is being served both over HTTP and HTTPS
2/ Set GoogleIndicTransliteration syspref to "Show"
3/ Access the OPAC over http, Google transliteration element will
   show up in masthead searchbox.
4/ Access the OPAC over https. The element will not show. Console
   will show MIXED CONTENT error and failure of google loader.
5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
   GoogleIndicTransliteration will work.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:08:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:08:37 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-aVEC7rPZQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Oops... Sorry, I was trying to set the signed off status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:12:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:12:20 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-0lFg23BJu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54444|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 54444
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54444
Bug 17103 - Google API Loader jsapi called over http

My mistake. Sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:12:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:12:56 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-5IL3PhXbeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:13:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:13:50 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-cQL6HIdKYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
I've signed off the first, and added the second. A single 's' shouldn't really
need a secondary sign off should it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 19:25:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 17:25:33 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-Pf6CM2f0No@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Now this moved faster than I expected :) 

Oliver, would you be able to sign-off Mark's follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:23:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:23:28 +0000
Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu
In-Reply-To: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16981-70-2dhdLXZY94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:23:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:23:31 +0000
Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu
In-Reply-To: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16981-70-TgHaPh9OH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53732|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54445&action=edit
[PASSED QA] Bug 16981: Add EDI Admin to Acq Menu

This patch adds the links to EDI Accounts and Library EANs
to the menu on the left of the Acq module.

To test:
* Log in to Koha
* Visit Acquisitions
* Confirm that EDI links show on the menu on the right
  if you have permissions to access EDI.

Signed-off-by: Marc <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:30:51 +0000
Subject: [Koha-bugs] [Bug 16981] Add EDI admin links to acq menu
In-Reply-To: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16981-70-RGK4xQ44B8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|add EDI admin to acq menu   |Add EDI admin links to acq
                   |                            |menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:43:12 +0000
Subject: [Koha-bugs] [Bug 16738] Improve EDIFACT messages template
In-Reply-To: <bug-16738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16738-70-WRW8VsiB0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:43:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:43:15 +0000
Subject: [Koha-bugs] [Bug 16738] Improve EDIFACT messages template
In-Reply-To: <bug-16738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16738-70-ojMoiw21lP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53204|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54446&action=edit
[PASSED QA] Bug 16738 - Improve EDIFACT messages template

This patch makes several improvements to the EDIFACT messages template
to make it more consistent with similar interfaces in Koha. Changes to
edimsg.tt are made to simplify the display of the data in a modal.

This patch also corrects a couple of markup errors.

To test you must have multiple rows of data in the edifact_messages
table. I tested with dummy data I inserted manually. Should should have
some rows which use 'QUOTE' and 'ORDERS' as the message_type.

To test deletions you may need to apply the patch for Bug 16737.

- Apply the patch and go to Acquisitions -> EDIFACT messages.
- In the table of messages, the date should be displayed according to
  your system preference.
- Sorting by date should work correctly regardless of date format
  setting.
- The 'Actions' column should contain 'View message' and 'Delete'
  Bootstrap-style buttons with Font Awesome icons. The column should be
  unsorted.
- Clicking the 'Delete' button should prompt you to confirm.
- Clicking the 'View message' button should trigger a modal which loads
  the message data.
- Test the page with no messages or when all messages have been
  deleted. The page should display a standard message dialog instead of
  an empty table.

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:54:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:54:51 +0000
Subject: [Koha-bugs] [Bug 8291] patron import should show error names
In-Reply-To: <bug-8291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8291-70-tIfMICEbOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There was already some work done on this - marking as duplicate with bug 5771.

*** This bug has been marked as a duplicate of bug 5771 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:54:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:54:51 +0000
Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers -
 Provide a download file of errors
In-Reply-To: <bug-5771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5771-70-1WfbPBPodB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 8291 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 20:58:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 18:58:17 +0000
Subject: [Koha-bugs] [Bug 8775] add collection code to lost report
In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8775-70-FqUKLxw3Jx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 21:00:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 19:00:18 +0000
Subject: [Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images
In-Reply-To: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16342-70-BXgGKlYZQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Placks breaks Baker and     |Plack breaks Baker and
                   |Taylor cover images         |Taylor cover images

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 21:11:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 19:11:41 +0000
Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings,
 making it impossible to translate
In-Reply-To: <bug-15275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15275-70-ZMwM4dnPgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking at Mark's last comment, this appears to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 21:13:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 19:13:57 +0000
Subject: [Koha-bugs] [Bug 16740] EDIFACT on Basket Groups leads to 500 error
In-Reply-To: <bug-16740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16740-70-v6u3j1EHXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16740

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16739

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
           Severity|enhancement                 |normal
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16739 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 21:20:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 19:20:18 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
In-Reply-To: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8426-70-o5mPx3h7rg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have learned since that ICU doesn't support some things - so it does make
sense to maintain these mappings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 21:42:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 19:42:46 +0000
Subject: [Koha-bugs] [Bug 5851] SIP Slips printed in wrong circumstances --
 Local hold and no hold items
In-Reply-To: <bug-5851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5851-70-dyX2SKjl0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5851

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am a bit confused by this:
print slip = set a hold waiting/triggering a hold?

I suspect this has been fixed since, but it's hard to tell without more
information.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 22:19:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 20:19:32 +0000
Subject: [Koha-bugs] [Bug 9626] can't pay FU fines without messing things up
In-Reply-To: <bug-9626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9626-70-PtyyMG7XYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9626

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Can not reproduce in master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 23:13:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 21:13:24 +0000
Subject: [Koha-bugs] [Bug 17122] New: Paying fines via Koha offline
 circulation reports false success for non-existing cardnumbers
Message-ID: <bug-17122-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17122

            Bug ID: 17122
           Summary: Paying fines via Koha offline circulation reports
                    false success for non-existing cardnumbers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the cardnumber doesn't exist, applying the koc file will still report
success.

- Upload .koc file, don't apply directly, but add to queue.
- Take a look at the queue - verify cardnumbers shows in red and is not linked
(not found)
- Apply payment anyway - verify it reports "Success."


The logs show:

[Sun Aug 14 23:05:43.150296 2016] [cgi:error] [pid 18058] [client
127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl: DBD::mysql::st
execute failed: Column 'borrowernumber' cannot be null [for Statement "INSERT
INTO accountlines, referer:
http://localhost:8080/cgi-bin/koha/offline_circ/list.pl
[Sun Aug 14 23:05:43.150512 2016] [cgi:error] [pid 18058] [client
127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl:  
(borrowernumber,
accountno,date,amount,description,accounttype,amountoutstanding,manager_id,
note), referer: http://localhost:8080/cgi-bin/koha/offline_circ/list.pl
[Sun Aug 14 23:05:43.150848 2016] [cgi:error] [pid 18058] [client
127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl:   VALUES
(?,?,now(),?,'',?,?,?,?)" with ParamValues: 0=undef, 1=1, 2=-1.05, 3='Pay',
4=-1.05, 5="1", 6=''] at /home/katrin/kohaclone/C4/Accounts.pm line 157.,
referer: http://localhost:8080/cgi-bin/koha/offline_circ/list.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 14 23:34:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 21:34:33 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-78IpI5EW0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am testing with a staff patron logged in at a different branch than their
homebranch. The problems spotted so far concern writing off fines.

Some first test results: 

I GENERAL
- Passes QA test tools
- Passes perl t/db_dependent/Accounts.t
- Database update ok

II API
1) Koha offline circulation
- Payment is correctly applied.
  Logged-in branch of the staff user is recorded.
2) SIP
-  ( To be tested )

III PATRON ACCOUNT - STAFF
1) Reverse payment
   OK
2) Create manual invoice
   OK
3) Create manual credit
   OK
4) Pay (single fine)
   OK
5) Pay selected
   OK
6) Write off (single fine)
   NOT OK - doesn't record a branchcode.
7) Pay an amount (partial)
   OK
8) Write off all
   NOT OK - doesn't record a branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 00:14:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 14 Aug 2016 22:14:12 +0000
Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines
In-Reply-To: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7595-70-TMMSAuhLN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Continued testing, but didn't get much further:

IV CIRCULATION
1) Checkout with rental fine
   OK
2) Renew with rental fine
   NOT OK - no rental fine recorded

>From the logs:

[Mon Aug 15 00:09:28.378180 2016] [cgi:error] [pid 20899] [client
127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew: DBD::mysql::st
execute failed: Unknown column 'branch' in 'field list' [for Statement "INSERT
INTO accountlines, referer:
http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1
[Mon Aug 15 00:09:28.378352 2016] [cgi:error] [pid 20899] [client
127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew:                    
(date, borrowernumber, accountno, amount, manager_id,, referer:
http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1
[Mon Aug 15 00:09:28.378447 2016] [cgi:error] [pid 20899] [client
127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew:                    
description,accounttype, amountoutstanding, itemnumber, branch), referer:
http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1
[Mon Aug 15 00:09:28.378810 2016] [cgi:error] [pid 20899] [client
127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew:                    
VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0="1", 1='43', 2=0.1000,
3="1", 4="Renewal of Rental Item Something", 5='Rent', 6=0.1000, 7="751",
8="TPL"] at /home/katrin/kohaclone/C4/Circulation.pm line 3120., referer:
http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 02:34:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 00:34:25 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-sBvIBojoSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #100 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #99)
> I'm going to guess off the top of my head without checking... But I usually
> state the file where the problem is. That's why it is marked as "Patch does
> not apply".

How very concise.

In hindsight, "PerlDependencies issue." and "Patch does not apply" does imply
that the patch didn't apply, because of an issue with the PerlDependencies.pm
changes.

Thanks for that. I'll look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 02:51:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 00:51:13 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-iUhSTWJ6K6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

--- Comment #8 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Sorry, my bad, missed that one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 04:44:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 02:44:31 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-pCit1oCTRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marc V?ron from comment #17)
> I tested and got following results:
> OPAC:
> Detail page:
> http://www.amazon.com/dp/3907142330?tag=TEST&

Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
dangling ampersand. Though if you really think that adding the ref portion is
the correct course of action, I could do that. What say you, Marc?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 04:50:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 02:50:04 +0000
Subject: [Koha-bugs] [Bug 17123] New: Can't call method "raw" on an
 undefined value at /home/ srdjan/koha/dev/C4/Search.pm line 806.
Message-ID: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123

            Bug ID: 17123
           Summary: Can't call method "raw" on an undefined value at
                    /home/srdjan/koha/dev/C4/Search.pm line 806.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: srdjan at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 04:50:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 02:50:51 +0000
Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined
 value at /home/srdjan/ koha/dev/C4/Search.pm line 806.
In-Reply-To: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17123-70-SNvZwi62pT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11232

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 04:50:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 02:50:51 +0000
Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra
In-Reply-To: <bug-11232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11232-70-lPmaYsm8vI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17123

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:19:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:19:04 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-jPpd1jrSjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50163|0                           |1
        is obsolete|                            |

--- Comment #99 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54447&action=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- added sort_by input param to GetItemsInfo()

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:19:28 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-wSeoYKzNFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50164|0                           |1
        is obsolete|                            |

--- Comment #100 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54448&action=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:19:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:19:46 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-7iAZgN5l2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50165|0                           |1
        is obsolete|                            |

--- Comment #101 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54449&action=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:20:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:20:27 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-hLUVHOBh2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50166|0                           |1
        is obsolete|                            |

--- Comment #102 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54450&action=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:20:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:20:44 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-hrzqBN6aBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50167|0                           |1
        is obsolete|                            |

--- Comment #103 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54451&action=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:22:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:22:02 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-X4PHjRqOd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 05:22:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 03:22:05 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-XFNc0Rnvpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50168|0                           |1
        is obsolete|                            |

--- Comment #104 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 54452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54452&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 09:20:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 07:20:51 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-44lb8wYekK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
my @valid_params = Koha::Patrons->_resultset->result_source->columns;

Normally, we should not touch the private underscored subs like _resultset
somewhere else?
We also have _columns in Koha/Object. Should that be made public?

In this specific case I even wonder if you should do this validation here in
REST or just pass the params to Objects (Patrons) and validate there if needed.
Would it be unexpected to return nothing if you search for an unexisting
column?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 09:26:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 07:26:36 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-vu4hrhgJfE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |benjamin.rokseth at kul.oslo.k
                   |ity.org                     |ommune.no
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 09:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 07:28:08 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-ANpruoX9yK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
(In reply to M. Tompsett from comment #19)
> (In reply to Marc V?ron from comment #17)
> > I tested and got following results:
> > OPAC:
> > Detail page:
> > http://www.amazon.com/dp/3907142330?tag=TEST&
> 
> Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
> dangling ampersand. Though if you really think that adding the ref portion
> is the correct course of action, I could do that. What say you, Marc?

I did some research, it seems that http://www.amazon.com/dp/3907142330?tag=TEST
will be OK. Trailing & is superfluous. It seems to do no harm but can we remove
it anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 09:34:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 07:34:46 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-uLowMvYaZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jiri Kozlovsky from comment #14)
> Changed description to have SIGNED-OFF included

This is not strictly necessary. A lot of reports go without it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 09:59:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 07:59:08 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-kFSVkDeyZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 10:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 08:26:59 +0000
Subject: [Koha-bugs] [Bug 17124] New: DecreaseLoanHighHolds.t does not pass
Message-ID: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

            Bug ID: 17124
           Summary: DecreaseLoanHighHolds.t does not pass
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 10:27:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 08:27:20 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-niTcDdtqVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849
[Bug 16849] Move IsDebarred to Koha::Patron->is_debarred
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 10:27:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 08:27:20 +0000
Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred
In-Reply-To: <bug-16849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16849-70-tOLO97iiB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17124


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124
[Bug 17124] DecreaseLoanHighHolds.t does not pass
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 10:29:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 08:29:54 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-1ADwHZFYOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 10:29:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 08:29:57 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-q5ZIjQGljC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54453&action=edit
Bug 17124: Fix tests in DecreaseLoanHighHolds.t

One test of DecreaseLoanHighHolds.t does not pass,
A hashref representing a patron has a 'borrower' key defined, instead of
'borrowernumber'.

Test plan:
  prove t/db_dependent/DecreaseLoanHighHolds.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:00:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:00:52 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-3BkUG2p8BE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #11 from Oliver Bock <oliver.bock at aei.mpg.de> ---
Hi guys,

I would sign it off code-wise but I'm not able to sign it off based on the test
plan just because I can't test it that way (no HTTP/non-SSL access possible).
That said, in principle I'm fine with the patch.

Best,
Oliver

PS: FYI, I stripped my local git details from the original patch as I didn't
remember that you use git at all ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:05:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:05:39 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-e38LoWhcbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:05:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:05:41 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-EtqDJXdYVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54204|0                           |1
        is obsolete|                            |

--- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54454&action=edit
Bug 16464 - If a patron has been discharged, show a message in the OPAC

This patch adds a message to the patron home page in the OPAC to be
shown if the user is restricted because of a discharge.

To test, apply the patch and log into the OPAC as a patron who has been
discharged.
 - You should see a message which says so, including a link to
   the discharge notice.
 - Log in to the OPAC as a patron with a manual restriction and confirm
   that the correct notice is displayed.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:06:30 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-CqHvU1Nco3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Feel free to sign off - I or someone else will probably test without HTTPS in
QA... :)

Take a look at the git bz link - I think it will explain some about our
workflow with git and Bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:31:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:31:42 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-szDVlQQWZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

--- Comment #3 from Holger Mei?ner <h.meissner.82 at web.de> ---
Created attachment 54455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54455&action=edit
Bug 14434: Display "On hold" in OPAC for auto renewed items

This patch makes the OPAC display "On hold" instead of "Automatic
renewal" when a hold is placed.

Test plan:
1) Issue an item with automatic renewal.
2) Place a hold on the item.
3) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)."
4) Apply patch.
5) Refresh OPAC and note that now "On hold" is displayed.
6) Cancel the hold, then log in as patron again and note that now
   "Automatic renewal (x of y renewals remaining)" is displayed
   once again.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:33:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:33:28 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-YCjxYzPFoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Holger Mei?ner <h.meissner.82 at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |h.meissner.82 at web.de
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:42:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:42:21 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-chyQVH5W9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #18 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Marcel de Rooy from comment #16)
> my @valid_params = Koha::Patrons->_resultset->result_source->columns;
> 
> Normally, we should not touch the private underscored subs like _resultset
> somewhere else?
> We also have _columns in Koha/Object. Should that be made public?
Also there is a "columns" sub in Koha::Objets from Bug 16889.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:42:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:42:33 +0000
Subject: [Koha-bugs] [Bug 17125] New: opac-basket: DataTables warning: table
 id= itemst - Cannot reinitialise DataTable.
Message-ID: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

            Bug ID: 17125
           Summary: opac-basket: DataTables warning: table id=itemst -
                    Cannot reinitialise DataTable.
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Put items in your cart.
Click on the cart.
Error: DataTables warning: table id=itemst - Cannot reinitialise DataTable. 
For more information about this error, please see http://datatables.net/tn/3

Anyone else seeing this error in 3.22?
Problem is not in master, since DataTables has been upgraded on report 15285.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:44:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:44:29 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-4MAhiUu4iI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Oliver Bock <oliver.bock at aei.mpg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54443|0                           |1
        is obsolete|                            |

--- Comment #13 from Oliver Bock <oliver.bock at aei.mpg.de> ---
Created attachment 54456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54456&action=edit
Bug 16615: Follow up - missed a spot (signed-off)

Attaching the signed-off patch manually as "git bz attach" failed because of
some missing default. Maybe the wiki defaults list is incomplete? Also, please
try to get rid of putting the clear-text PW into any gitconfig. git bz should
really prompt for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:48:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:48:27 +0000
Subject: [Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id=
 itemst - Cannot reinitialise DataTable.
In-Reply-To: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17125-70-kgLwsB15p8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
It should not appear, since the table seems to be initialized only once in the
document ready function. But putting this check around it should resolve the
problem:

if( ! $.fn.dataTable.isDataTable('#itemst') ) {
...
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 11:59:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 09:59:58 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-IMVweMUMRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52992|0                           |1
        is obsolete|                            |

--- Comment #24 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54457&action=edit
Bug 14868: Swagger2-driven Permission checking

Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.

This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:00:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:00:28 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-ErMBtwVCpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52993|0                           |1
        is obsolete|                            |

--- Comment #25 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54458&action=edit
Bug 14868: Give users possibility to request their own object

Allow access to user's own objects even if they do not have required
permissions.
This will be very useful in many cases where an user wants to request their own
object, for example renewing their checkouts or placing a hold for themselves.

First, this patch renames "x-koha-permission" to "x-koha-authorization" in
order
to describe the new functionality better.

Second, we can now add two extra parameters under "x-koha-authorization":
- "allow-owner"; Allows the owner of object to access it (without permission)
- "allow-guarantor"; Allows guarantor of the owner of object to access it
                     (without permission)

Third, since permission checking is outside of actual controller, we need a way
to find out ownership from different types of parameters, e.g. checkout_id from
/checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc.
A solution is to match the parameter with a subroutine that is designed to
verify
the ownership for that object. See the new subroutines in Koha::REST::V1.

To use this functionality you will simply define it in Swagger:
"/patrons/{borrowernumber}": {
  "get": {
    ...,
    "x-koha-authorization": {
      "allow-owner": true,
      "permissions": {
        "borrowers": "1"
      }
    }
  }
}

If a parameter that is not yet defined in
Koha::REST::V1::check_object_ownership,
you also need to define it and implement a subroutine that determines
ownership.

Tests are provided in a following patch that adds this functionality for
current
API operations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:00:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:00:58 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-XSwfXYQkzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:01:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:01:01 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-j04jGrzFBP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52994|0                           |1
        is obsolete|                            |
  Attachment #52996|0                           |1
        is obsolete|                            |

--- Comment #26 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54459&action=edit
Bug 14868: Use x-koha-authorization in current routes

To test:
1. Run t/db_dependent/api/v1/holds.t
2. Run t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:01:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:01:56 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-fKN4UalbVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:01:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:01:59 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-QUb04aaOeQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54453|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54460&action=edit
Bug 17124: Fix tests in DecreaseLoanHighHolds.t

One test of DecreaseLoanHighHolds.t does not pass,
A hashref representing a patron has a 'borrower' key defined, instead of
'borrowernumber'.

Test plan:
  prove t/db_dependent/DecreaseLoanHighHolds.t
must return green

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:14:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:14:31 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-ALQx0kzmi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

--- Comment #3 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
This remains a problem in 3.20 (we move to 16.05 soon). As a workaround we have
set up a report to be run whenever an order is cancelled, to look for
reservations. We have added this to the homepage, and our cataloging /
acquisitions staff can easily access it.  

SELECT o.ordernumber, b.title, b.author, p.surname, p.firstname, r.reservedate, 
       r.cancellationdate, r.branchcode
FROM reserves r 
LEFT JOIN borrowers p USING (borrowernumber)
LEFT JOIN biblio b USING (biblionumber) 
LEFT JOIN aqorders o USING (biblionumber)
LEFT JOIN aqbasket n using (basketno)
WHERE o.ordernumber=<<Order number>>

Better than nothing I suppose.

Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 12:15:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 10:15:30 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-fi9bobT8Rd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

--- Comment #27 from Lari Taskula <larit at student.uef.fi> ---
The patches went through heavy rebasing (now on top of master) and
modifications.

These patches fix wrong error messages, extend "allow-owner" functionality to
be able to find out object owner from any parameter (not just borrowernumber
like before), adds "allow-guarantor" that works similar to "allow-owner" but
checks access for guarantor of the owner of the object instead, and adds some
more tests that cover these changes. Meanwhile I also squashed "Rename
'x-koha-permission' to 'x-koha-authorization'" into "Give users possibility to
request their own object".

Because of heavy changes, I had to remove the sign-offs and would now be very
interested to hear comments especially on the solution to find out object
ownership from any parameter, and of course suggestions for a better solution
if someone can come up with one.

I think it's very useful to be able to define permissions in Swagger because it
is now documented in your specification, and also permission checking is
centralized into one place instead of duplicating it for nearly every operation
in each controller.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 13:01:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 11:01:37 +0000
Subject: [Koha-bugs] [Bug 17126] New: REST API: add route to delete biblio
Message-ID: <bug-17126-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17126

            Bug ID: 17126
           Summary: REST API: add route to delete biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

Add API route to delete biblio

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 13:02:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 11:02:49 +0000
Subject: [Koha-bugs] [Bug 17127] New: Can't blacklist MARC21 500 with
	NotesBlacklist
Message-ID: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

            Bug ID: 17127
           Summary: Can't blacklist MARC21 500 with NotesBlacklist
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

NotesBlacklist will hide fields from the descriptions tab in the OPAC. This
works fine for all fields, but 500 in our tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:04:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:04:33 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-IGFyRRXezW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54157|0                           |1
        is obsolete|                            |

--- Comment #16 from Marc V?ron <veron at veron.ch> ---
Created attachment 54461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54461&action=edit
Bug 16960: Fix error on validating the registration

Followed steps in comment #14, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:04:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:04:50 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-8WYNTyqcfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:16:15 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-z0KiIfciER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:16:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:16:20 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-Vk7MTYgti9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54442|0                           |1
        is obsolete|                            |
  Attachment #54456|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54462&action=edit
Bug 16615: Open Library API fails for full-site-SSL

When running Koha in a full-site-SSL configuration accessing
external resouces like Open Library cover images via HTTP
doesn't work (mixed SSL/non-SSL content). It thus breaks a
core feature of Koha. Referencing such resources always via
HTTPS resolves the problem and also enhances privacy as a
side-effect.

Previous tickets took care of Amazon resources. This ticket
is supposed to address the remaining external resource providers,
starting with Open Library.

TEST PLAN
---------
1) Over https access your OPAC with the Enhanced Content system
   preferences 'OpenLibraryCovers' set to 'Add', and
   'OpenLibrarySearch' set to 'Show'.
2) Search for something (e.g. Mo Willems)
   -- Your browser console log will show messages about
      mixed content.
3) Apply the patch
4) Making sure to reload the java script, attempt steps 1 & 2
   again.
   -- no mixed content messages should be given
5) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:16:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:16:25 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-ZOtRoy8dWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54463&action=edit
Bug 16615: Follow up - missed a spot

Also, it is recommended to apply bug 17103 before this.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Oliver Bock <oliver.bock at aei.mpg.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:16:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:16:29 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-12Gm9EvmSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54464&action=edit
Bug 16615: Update OPACSearchForTitleIn to access openlibrary.org via https

Note that we could also update the syspref for existing installs

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:16:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:16:54 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-e6VLrDRebB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.22                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:39:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:39:52 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-xcJcBIuKAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54162|0                           |1
        is obsolete|                            |

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Created attachment 54465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54465&action=edit
Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new

Recently we face the same issue on different modules after we moved them to the
Koha namespace using Koha::Object of using DBIx::Class directly.

1/ Koha::Patron::Modification on bug 16960 comment 14 and 15
2/ Koha::Patron::Category from bug 17069
3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917

If a DB column is defined as NOT NULL and has a default value, the DBIx::Class
$rs->update_or_insert method won't use the default value if the column name
has been passed to the constructor.

We do that almost everywhere as we retrieve the data from the HTML forms
without
checking/cleaning them.

There are several ways to fix that:
1/ Continue to fix them case by case (what we did for the recent issues)
2/ Try to fix them globally (existing ones and the next ones)

This patch propose a global solution to avoid future issues of this kind.

The idea is not to pass the undefined values which cannot be nullable to the
DBIx::Class constructor.

Tested all patches together. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:40:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:40:50 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-RHTfcijLPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54163|0                           |1
        is obsolete|                            |

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 54466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54466&action=edit
Bug 17080: Make C4::Members::AddMember uses Koha::Patron->store

These calls have been added from commit e196f19 (Bug 12633: Remove SQLHelper
in C4::Members) which added a TODO:
"This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower."

This is now done by this patch: instead of calling DBIx::Class directly
we use Koha::Patron

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:41:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:41:39 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-HT49t5mrGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54164|0                           |1
        is obsolete|                            |

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 54467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54467&action=edit
Bug 17080: borrowers table - use default values defined in the DBIx::Class
schema

This patch basically just revert bug 16960 - Fix error on validating the
registration

This job is now done by the Koha::Object constructor, no need to clean
the hash before sending it to AddMember.

Test plan:
Make sure there is no regression on bug 16960 (validate a self registration).

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:42:27 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-XRWjKsunbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54165|0                           |1
        is obsolete|                            |

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Created attachment 54468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54468&action=edit
Bug 17080: borrowers.checkprevcheckout - use the default value defined in the
DBIx::Class schema

This line has been added by bug 16917 to define the default value of
borrowers.checkprevcheckout.
As this value is defined in the DBIx::Class schema, we should not have
to handle it here.

Test plan:
Confirm that this patch does not reintroduced the bug fixed by bug
16917.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:43:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:43:19 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-89x9oZV1sm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54166|0                           |1
        is obsolete|                            |

--- Comment #13 from Marc V?ron <veron at veron.ch> ---
Created attachment 54469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54469&action=edit
Bug 17080: categories.checkprevcheckout - use the default value defined in the
DBIx::Class schema

This patch reverts bug 17069

Test plan:
Create a new patron category

  prove t/db_dependent/Koha/Patron/Categories.t
should return green

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 14:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 12:44:07 +0000
Subject: [Koha-bugs] [Bug 17080] Koha::Object-> new should handle default
 values for NOT NULL columns
In-Reply-To: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17080-70-oTHxwU0WWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:01:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:01:52 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-PYoItZwhWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Did the test script pass for you guys?
I get errors on "loading kohastructure for fr-FR | not marc21", stuffs like
"Cannot add or update a child row: a foreign key constraint fails" and
"Duplicate entry 'CO' for key 'PRIMARY'"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:02:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:02:35 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-OmU7Fn3wON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54309|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 54470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54470&action=edit
Bug 17109: Remove second authentication from (opac-)sendbasket

Patch deals with opac and intranet variant.
If we authenticated the first time, it is not necessary to do it
a second time rightaway.

Replaces a call to get_template_and_user (including checkauth) by
gettemplate.

Also removes duplicate use C4::Biblio statements.

Test plan:
[1] Put a few books in the cart.
[2] Send the cart from OPAC.
[3] Send the cart from intranet.

Tested 3 patches together. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:05:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:05:52 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-w19fKKJ9Ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54310|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 54471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54471&action=edit
Bug 17109: Add CSRF token to [opac-]sendbasket

If you have no (valid) token, you will not be able to send the message.

Test plan:
[1] Verify if you can still send the cart from opac and intranet.
[2] While still being logged in, try to send the cart from opac by
    using the following URL:
   
/cgi-bin/koha/opac-sendbasket.pl?email_add=you at somedomain.com&comment=csrf_test&bib_list=doesnotmatter&csrf_token=justsomeguess12345
    This should now result in a csrf error.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:07:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:07:15 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-WbiieyC8TS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54325|0                           |1
        is obsolete|                            |

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 54472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54472&action=edit
Bug 17109: Use Koha.Preference in sendbasket template

No need to send OPACBaseURL to the template, if you load the Koha TT
plugin inside the template.

Test plan:
Send a few items in your cart from OPAC and intranet.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:08:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:08:02 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-hrbykhGgRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:11:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:11:31 +0000
Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined
 value at /home/srdjan/ koha/dev/C4/Search.pm line 806.
In-Reply-To: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17123-70-NYgEnN1SXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|enhancement                 |normal

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Srdjan, could you be more specific on how to reproduce it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:14:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:14:34 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-CJM6fkgTcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #40)
> I haven't fully tested, but initial read through and applying looks good.
> This makes it much easier to get memcached functioning with plack and is a
> good improvement

I agree! This is a huge improvement and greatly simplifies the setup.

Jacek, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:22:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:22:08 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-UNpFLFNLjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #49)
> Did the test script pass for you guys?
> I get errors on "loading kohastructure for fr-FR | not marc21", stuffs like
> "Cannot add or update a child row: a foreign key constraint fails" and
> "Duplicate entry 'CO' for key 'PRIMARY'"

Forgot the gzip files!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:25:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:25:45 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-xOgxASffIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54313|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 54473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54473&action=edit
Bug 17110: Lower CSRF expiry in Koha::Token

Default expiry in WWW:CSRF is one week.
This patch sets it to 8 hours by default in Koha, and allows to
change the expiry period individually by passing MaxAge.

Test plan:
[1] Put items in your cart.
[2] Apply the example patch too.
[3] Send the cart from opac within the allotted 10 seconds.
[4] Send again, but wait some 10 seconds before submitting. Too late!

Tested 3 patches together, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:26:34 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-8PfLZgqctM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54323|0                           |1
        is obsolete|                            |

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 54474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54474&action=edit
Bug 17110: Add unit test for MaxAge parameter in Token.t

Test plan:
Run t/Token.t

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:27:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:27:21 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-r443Dey7UJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54324|0                           |1
        is obsolete|                            |

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 54475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54475&action=edit
Bug 17110: [EXAMPLE PATCH] CSRF expiry of 10 seconds in opac-sendbasket

This patch should NOT be pushed !
It is used to test the first patch only.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:27:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:27:36 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-o7K86cC3T6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:36:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:36:03 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-z40nT1rZRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Still fails, even with gzip files:
# 21/26:
/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorite_default.sql
C4::Installer::load_sql returned the following errors while attempting to load
/home/koha/src/installer/data/mysql/fr-FR/marcflavour/un
imarc_complet/Obligatoire/autorites_norme_unimarc.sql:
not ok 1 -
/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql:
DBD::mysql::s
t execute failed: Cannot add or update a child row: a foreign key constraint
fails (`koha_test_installer`.`auth_subfield_structure`, CO
NSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`)
REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UP
DATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.
# 
#   Failed test
'/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql:
DBD::my
sql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_test_installer`.`auth_subfield_structur
e`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`)
REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE C) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.
# '
#   at t/db_dependent/Test_installer.t line 48.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:37:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:37:54 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-nU0CtcV8tA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:37:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:37:57 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-X3uPuPrL9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54460|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54476&action=edit
Bug 17124: Fix tests in DecreaseLoanHighHolds.t

One test of DecreaseLoanHighHolds.t does not pass,
A hashref representing a patron has a 'borrower' key defined, instead of
'borrowernumber'.

Test plan:
  prove t/db_dependent/DecreaseLoanHighHolds.t
must return green

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:44:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:44:12 +0000
Subject: [Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id=
 itemst - Cannot reinitialise DataTable.
In-Reply-To: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17125-70-VRU6ogfx7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, I do not get the error and the table displays correctly.
However, looking at the code:
  243 [% UNLESS ( print_basket ) %]<th>&nbsp;</th>[% END %]
This test does not exist in the aoColumns declaration.

But it should only affects the display when you print the page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:48:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:48:47 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-tROJUNAO47@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #17 from Oliver Bock <oliver.bock at aei.mpg.de> ---
The previous patch only updates the OpenLibrary URL. Why not change all of them
(after testing they support it)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:49:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:49:35 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-2amsa6g7RO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54471
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54471
Bug 17109: Add CSRF token to [opac-]sendbasket

Review of attachment 54471:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17109&attachment=54471)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt
@@ +20,5 @@
>                              [% END %]
>  
> +                            [% IF csrf_error %]
> +                                <p>No valid CSRF token!</p>
> +                                <p><a class="focus close" href="#">Close window</a></p>

If you do that here, I will have to do it in all other places (and really don't
want to! :) )
Are you sure we really want to stylish it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:56:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:56:26 +0000
Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)
In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16588-70-eNq996CKoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54477&action=edit
Bug 16588: (follow-up) Remove Readonly from Edifact

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 15:58:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 13:58:14 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-CMxxirgvNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Oliver Bock from comment #17)
> The previous patch only updates the OpenLibrary URL. Why not change all of
> them (after testing they support it)?

Because I did not test them :)
Feel free to submit a patch to replace it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:14:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:14:00 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-E6S7Bm6SKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:14:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:14:05 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-TDp5pCSmRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54260|0                           |1
        is obsolete|                            |
  Attachment #54312|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54478&action=edit
Bug 17100: Do not display payments if patron has nothing to pay

This alternative patch moves logic and formatting to the template file.

To test:
* without patch
  1/ find a patron with no lines in accountlines table : print summary shows no
"account fines and payments" => OK
  2/ find a patron with some lines in accountlines table and the total amount >
0 : print summary shows a table "account fines and payments" with fines to
recover => OK
  3/ find a patron with some lines in accountlines table but the total amount =
0 : print summary shows a table "account fines and payments" with nothing in it
=> NOK

* with the patch, same cases as before :
  1/ same as without patch
  2/ same as without patch
  3/ print summary does not show "account fines and payments"

- Additionally, verify that formatting follows syspref 'CurrencyFormat'
- Verify that amount column is right-aligned

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:14:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:14:11 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-EZvFu8lNne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54479&action=edit
Bug 17100: Restore previous logic

There is no need to change the previous logic here, so let's restore it.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:14:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:14:53 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-5j0tCtH0PI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marc V?ron from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > Comment on attachment 54312 [details] [review] [review]
> > [SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print
> > 
> > Review of attachment 54312 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
> > @@ +105,4 @@
> > >              </tr>
> > >  
> > >              [% FOREACH account IN accounts %]
> > > +                [% IF ( account.amountoutstanding < 0 ) || ( account.amountoutstanding > 0 ) %]
> > 
> > Marc, why did you replace
> >   next if amount == 0
> > with this lines?
> 
> It did not work with amount == 0 because the amount comes as '0.00' (not
> sure how much decimals tough)

It's because you compared string "0.00", instead of integer 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:18:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:18:11 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-ZX9M2DcMt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #11 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I am grateful that this is a preference and not a behavior change.  We have
many family members that use the same e-mail address for more than one account,
and this would make it impossible for them to register more than one family
member.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:31:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:31:36 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron self registration if the
 email already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-csp4aJmUoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's totally optional - I tested with the option being off as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:37:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:37:06 +0000
Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined
 value at C4/ Search.pm line 806
In-Reply-To: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17123-70-4GAYP94aZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't call method "raw" on  |Can't call method "raw" on
                   |an undefined value at       |an undefined value at
                   |/home/srdjan/koha/dev/C4/Se |C4/Search.pm line 806
                   |arch.pm line 806.           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:45:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:45:00 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-5AemHOzNrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126
[Bug 10126] C4::Reports::Guided is not Plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:45:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:45:00 +0000
Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe
In-Reply-To: <bug-10126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10126-70-jU8wBOSfZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7172


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:45:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:45:06 +0000
Subject: [Koha-bugs] [Bug 17128] New: summary-print.pl is not plack safe
Message-ID: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

            Bug ID: 17128
           Summary: summary-print.pl is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7172

Variable "$borrowernumber" is not available at
/home/koha/src/members/summary-print.pl line 101.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:45:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:45:06 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-sIIaS7KIq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17128


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128
[Bug 17128] summary-print.pl is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:45:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:45:27 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-NmCsEKa1Zn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54480&action=edit
Test import record

Tried usingn this to test, no items added (fund codes are valid in my instance)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:47:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:47:13 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-Ti8jsAf0Vp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Tested using attached record, no items were created upon staging

Fund codes are valid in my instance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:50:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:50:23 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-RHePNACbqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:50:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:50:27 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-QE049x5arw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54481&action=edit
Bug 17128: Make summary-print.pl plack safe

$borrowernumber is used in build_issue_data but not correctly defined
(Variable "$borrowernumber" is not available)

That may cause wrong charge displayed in the summary slip.

Test plan:
- Set rental charge for an item type
- Define a rental discount for that item type in the circ rules
- check in an item matching this rule
Without this patch the charge displayed in the summary slip won't be
calculated with the discount
With this patch applied, the warning in the logs will no longer appear
and the values will be correctly calculated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 16:59:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 14:59:03 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-inyGKVsdsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54454
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54454
Bug 16464 - If a patron has been discharged, show a message in the OPAC

Review of attachment 54454:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16464&attachment=54454)
-----------------------------------------------------------------

::: opac/opac-user.pl
@@ +101,5 @@
>      }
> +    my $available = Koha::Patron::Discharge::count({
> +        borrowernumber => $borrowernumber,
> +        validated      => 1,
> +    });

Why do you count the number of validated discharges? I'd say that the following
call to is_discharged is enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:03:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:03:43 +0000
Subject: [Koha-bugs] [Bug 17129] New: Tests fail when DEBUG=1 is set
Message-ID: <bug-17129-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17129

            Bug ID: 17129
           Summary: Tests fail when DEBUG=1 is set
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: QA tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

When running the QA tools with DEBUG=1 I get all files FAIL
on valid

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:09:21 +0000
Subject: [Koha-bugs] [Bug 17130] New: DEBUG mode should be enabled via
	koha-conf
Message-ID: <bug-17130-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17130

            Bug ID: 17130
           Summary: DEBUG mode should be enabled via koha-conf
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would be nice if we could set DEBUG mode via the koha-conf rather than ENV 
as the ENV don't always seem to pass to all modules (e.g. Cache.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:12:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:12:08 +0000
Subject: [Koha-bugs] [Bug 17131] New: Zebra index for Title is too broad
Message-ID: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131

            Bug ID: 17131
           Summary: Zebra index for Title is too broad
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 54482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54482&action=edit
Test file

One of the zebra index definitions in marc21/biblios/biblio-koha-indexdefs.xml
for Title includes the entire 245 tag:

  <!--record.abs line 116: melm 245        Title:w,Title:p-->
  <index_data_field tag="245">
    <target_index>Title:w</target_index>
    <target_index>Title:p</target_index>
  </index_data_field>

Since 245$c can contain Author, this means that author names will show up in
Title searches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:13:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:13:25 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-1ws84kSZ1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54481|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54483&action=edit
Bug 17128: Make summary-print.pl plack safe

$borrowernumber is used in build_issue_data but not correctly defined
(Variable "$borrowernumber" is not available)

That may cause wrong charge displayed in the summary slip.

Test plan:
- Set rental charge for an item type
- Define a rental discount for that item type in the circ rules
- check in an item matching this rule
Without this patch the charge displayed in the summary slip won't be
calculated with the discount
With this patch applied, the warning in the logs will no longer appear
and the values will be correctly calculated.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:13:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:13:46 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-4weQp6Vu8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:18:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:18:45 +0000
Subject: [Koha-bugs] [Bug 17131] Zebra index for Title is too broad
In-Reply-To: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17131-70-955bMOSzG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
To reproduce:

In the staff client

1/ Import the attached test file.
2/ Make sure the bib record has been indexed -- you can do a keyword search for
'The masks of god' to verify.
3/ Go to advanced search, do a title search for 'Campbell' -- This will return
results for 'The masks of god', even though 'Campbell' is not in the title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:19:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:19:16 +0000
Subject: [Koha-bugs] [Bug 17131] Zebra index for Title is too broad
In-Reply-To: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17131-70-xLbDsXPJL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:20:42 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-kriLoBXkQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1/ user will replace the field with the surname of the librarian, is it what we
want?

2/ Should not we just remove this hidden feature as it does not exist in the
manual?

3/ If we decide to keep it, let's
- use same code for add biblios and add items
- use "USER" or "<<USER>>" or whatever instead of "user"
- update existing installs

I can provide a patch if you reach a consensus.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:20:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:20:51 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-TTCVB0U8RQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 17:24:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 15:24:36 +0000
Subject: [Koha-bugs] [Bug 11685] GetSupportName and GetSupportList do not
 split AdvancedSearchTypes by pipe
In-Reply-To: <bug-11685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11685-70-fnBXa3hOKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |INVALID

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
No longer valid, these 2 subs have been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:03:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:03:26 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-ayRzW4dli9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48735|0                           |1
        is obsolete|                            |
  Attachment #48736|0                           |1
        is obsolete|                            |
  Attachment #48737|0                           |1
        is obsolete|                            |
  Attachment #48738|0                           |1
        is obsolete|                            |
  Attachment #48739|0                           |1
        is obsolete|                            |
  Attachment #48740|0                           |1
        is obsolete|                            |
  Attachment #48741|0                           |1
        is obsolete|                            |

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54484&action=edit
Bug 12904 - Force browser to load new javascript files after upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of "200
   OK" for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the "size" column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   "304 Not Modified." In Chrome the "size" columns should show "from
   cache."
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a "koha_version" query string. These files should
   have a status of "200 OK" indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration -> Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools -> Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog -> Detail page -> MARC Preview (greybox JS)
- Help -> Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:03:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:03:37 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-A11Fh4pFTp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54485&action=edit
Bug 12904 - Update template css and js file references

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:16:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:16:30 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-9ymRTBcgbb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:16:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:16:30 +0000
Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object
 definition is up-to-date with database
In-Reply-To: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17032-70-AzS8yZTx1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008
[Bug 17008] REST API: Correct data types in Swagger
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:16:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:16:33 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-HInoTgEifu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54486&action=edit
Bug 17008: Test to compare Swagger property types against column data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type. For this to succeed, we need a SQL data type => Swagger data type
mapping. See "_sql_to_swagger_data_type_mapping" in definitions.t. SQL data
types
currently defined in the mapping are extracted with a simple script that
iterates
through each column from each schema's resultset and storing the data type, so
the mapping covers at least all currently defined data types and some manually
added ones as well.

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/definitions/patron.json cardnumber to be type "integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 18:45:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 16:45:31 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-lSOWvoC8nQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com
             Status|Needs Signoff               |In Discussion

--- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
I think that "On hold" isn't clear yet. Maybe something like "Not renewable (On
hold)" would be much better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 19:32:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 17:32:03 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-B0gZdO5QlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54484|0                           |1
        is obsolete|                            |
  Attachment #54485|0                           |1
        is obsolete|                            |

--- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54488&action=edit
Bug 12904 - Force browser to load new javascript files after upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of "200
   OK" for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the "size" column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   "304 Not Modified." In Chrome the "size" columns should show "from
   cache."
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a "koha_version" query string. These files should
   have a status of "200 OK" indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration -> Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools -> Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog -> Detail page -> MARC Preview (greybox JS)
- Help -> Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 19:36:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 17:36:24 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-8tAKqUsqA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm at a loss. I just rebased and squashed/split all these patches for
readability. Everything is working, but the browser continues to indicate it's
grabbing cached files even when the filename has changed!

At first I thought it was because the rewrite was doing a 301 redirect, so I
removed that, and still had the same thing. Next I tried a 307, but again, the
same results ( though chrome decided not to cache some files at all with a 307
).

Here is a video demonstration: http://screencast.com/t/JfFonhkWax

Martin, Jonathan, any ideas on what is going on?

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 19:39:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 17:39:10 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-3r8s6Gf4Th@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54489&action=edit
Bug 12904 - Update template css and js file references

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:05:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:05:46 +0000
Subject: [Koha-bugs] [Bug 17075] Items' subfields do not obey the mandatory
	flag
In-Reply-To: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17075-70-cLEb1vrzvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

bondiurbano <costalc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Subfields of the items do   |Items' subfields do not
                   |not obey the mandatory flag |obey the mandatory flag

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:12:03 +0000
Subject: [Koha-bugs] [Bug 17132] New: Availability search broken when using
	Elastic
Message-ID: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

            Bug ID: 17132
           Summary: Availability search broken when using Elastic
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Elastic appears to be indexing onloan as a string, but our code assumes it is a
boolean.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:12:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:12:06 +0000
Subject: [Koha-bugs] [Bug 17132] Availability search broken when using
	Elastic
In-Reply-To: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17132-70-pqczBFpCIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:13:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:13:40 +0000
Subject: [Koha-bugs] [Bug 17132] Availability search broken when using
	Elastic
In-Reply-To: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17132-70-GtJr06c0VQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:13:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:13:42 +0000
Subject: [Koha-bugs] [Bug 17132] Availability search broken when using
	Elastic
In-Reply-To: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17132-70-fiGSntaDBF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54490&action=edit
Bug 17132 - Availability search broken when using Elastic

Elastic appears to be indexing onloan as a string, but our code assumes
it is a boolean.

Test Plan:
1) Ensure you are set up using Elastic as your search engine
2) Search only for available items from the advanced search
3) Note you get no results
4) Apply this patch
5) Re-run the search
6) You should now get results!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:17:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:17:48 +0000
Subject: [Koha-bugs] [Bug 16689] Translate Koha website to German
In-Reply-To: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16689-70-zpfxtWTqvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16689

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Hi Katrin & Marc, I thought I'd use this as an umbrella bug that we attach
sub-bugs too. That way we can claim pages to work on and check each others work
when it's done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:19:57 +0000
Subject: [Koha-bugs] [Bug 17133] New: DE Startseite
Message-ID: <bug-17133-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17133

            Bug ID: 17133
           Summary: DE Startseite
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: mirko at abunchofthings.net

?bersetzung der Startseite

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:20:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:20:22 +0000
Subject: [Koha-bugs] [Bug 17133] DE Startseite
In-Reply-To: <bug-17133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17133-70-vhIuWnSSeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17133

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|wizzyrea at gmail.com          |mirko at abunchofthings.net
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:21:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:21:07 +0000
Subject: [Koha-bugs] [Bug 16346] Website should be translatable
In-Reply-To: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16346-70-0K96kFU7V2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16346

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Works! YAY!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:21:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:21:07 +0000
Subject: [Koha-bugs] [Bug 16689] Translate Koha website to German
In-Reply-To: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16689-70-C2fKdgalnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16689
Bug 16689 depends on bug 16346, which changed state.

Bug 16346 Summary: Website should be translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16346

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:21:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:21:50 +0000
Subject: [Koha-bugs] [Bug 16689] Translate Koha website to German
In-Reply-To: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16689-70-xHzJfYyYhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16689

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17133
[Bug 17133] DE Startseite
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:21:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:21:50 +0000
Subject: [Koha-bugs] [Bug 17133] DE Startseite
In-Reply-To: <bug-17133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17133-70-b033gzm4qA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17133

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16689


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16689
[Bug 16689] Translate Koha website to German
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:30:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:30:27 +0000
Subject: [Koha-bugs] [Bug 17134] New: Facet's area shoes itemtypes' code
	instead of names
Message-ID: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

            Bug ID: 17134
           Summary: Facet's area shoes itemtypes' code instead of names
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In OPAC's search results, Koha shows itemtypes' codes instead name.

See file attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:31:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:31:13 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shoes itemtypes' code instead
	of names
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-kdN8AKNMnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #1 from bondiurbano <costalc at gmail.com> ---
Created attachment 54491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54491&action=edit
OPAC display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:32:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:32:36 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-1fa9WYu44v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

bondiurbano <costalc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Facet's area shoes          |Facet's area shows
                   |itemtypes' code instead of  |itemtypes' code instead of
                   |names                       |item's description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:43:50 +0000
Subject: [Koha-bugs] [Bug 12951] Login failure shows wrong message if user
 doesn' t have the right permissions (staff client)
In-Reply-To: <bug-12951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12951-70-oQI5pMam99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12951

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
I can't reproduce this problem in master. Is it still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 20:59:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 18:59:41 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-a3z7Fbj20x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Did you enter a description? The screenshot highlights 'Search category,' not
'Description.' Description is what should show in the facet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 21:09:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 19:09:37 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-ce3CqhxbG5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #3 from bondiurbano <costalc at gmail.com> ---
Hi Owen!

Yes, it should show item's Description instead of code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 21:51:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 19:51:56 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-nGjSUBUsMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

--- Comment #2 from Jessie Zairo <jzairo at bywatersolutions.com> ---
Yes, this would be helpful. I have had several requests to change it on the
database side. If a number is miskeyed incorrectly, it would be great to have
an option right their for staff to edit the invoice number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:03:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:03:26 +0000
Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound
 notifications) to web based self checkout
In-Reply-To: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16732-70-UhqrRVSwmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:03:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:03:29 +0000
Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound
 notifications) to web based self checkout
In-Reply-To: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16732-70-qp3hN6TLDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54492&action=edit
Bug 16732 - Add audio alerts (custom sound notifications) to web based self
checkout

This patch adds the infrastructure needed to allow audio alerts, as
configured in administration, to affect the sco module

This patch allows only for the use of sounds with a full URL to be used
and does not allow for the Koha standard sounds to be accessed via the
SCO

To test:
Ensure you have the preference AudioAlerts enabled
Ensure you can hear normal sounds from the staff module
Define an audio alert such as:
    Selector: .sco_entry
    Sound: https://archive.org/download/Doorbell_1/doorbell.ogg
Load the SCO module
You should hear the doorbell noise (everytime you reload even!)
Test that the default sounds are not activated for the SCO, you must
sepcifically define them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:25:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:25:50 +0000
Subject: [Koha-bugs] [Bug 16689] Translate Koha website to German
In-Reply-To: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16689-70-3bwlgTY3D7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16689

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had started yesterday on "Project organisation" for a quick test - not sure
how confident I feel about my translation skill tho :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:26:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:26:37 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-AZ9DiEXi4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #4 from Claudio <costalc at gmail.com> ---
Owen, this happens when an itemtype category (LIBRO) is assigned to an
itemtype. Otherwise it works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:30:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:30:29 +0000
Subject: [Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial
 frequency and numbering management
In-Reply-To: <bug-16967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16967-70-RH52g1Citi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Aliki Pavlidou <pavlidoualiki at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavlidoualiki at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:44:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:44:16 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-8ZuHYbtstI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Did you set up your authorised value with both descriptions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:46:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:46:07 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-gDawCzwum0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's hidden.. but I think not unused. I'd prefer 3). A placeholder like
<<USER>> or similar that is unlikely to happen otherwise would work for me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:54:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:54:16 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-wGHBksg0ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #6 from Claudio <costalc at gmail.com> ---
Hi Katrin,

Yes, I did. See image attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 22:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 20:55:27 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-6hYHJ81vuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #7 from Claudio <costalc at gmail.com> ---
Created attachment 54493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54493&action=edit
image

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 23:02:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 21:02:11 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-QPFvucd8A2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the screenshot!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 23:06:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 21:06:39 +0000
Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead
 of item' s description
In-Reply-To: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17134-70-nzsZSTmM3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #9 from Claudio <costalc at gmail.com> ---
You're welcome! 

It did not happen in prior versions of Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 23:22:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 21:22:16 +0000
Subject: [Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order'
 when itemtype is not for loan
In-Reply-To: <bug-13854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13854-70-8JRtiWJ7JF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 15 23:40:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 21:40:43 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-fvEIH0YHgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #129 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mark,
looking at https://wiki.koha-community.org/wiki/Hidden_values:
-8 is described as "flag" - which noone knows exactly what it means I think.
For "Everything hidden everywhere" I would have picked 8 or 5. 
Can you explain your choice of -8?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 00:05:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 22:05:41 +0000
Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get
	out of sync
In-Reply-To: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12584-70-kcZX1hmsm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Had it result been that long I've been out of the loop.. Did we ever f in nd
the right deacons option..  Wondering if lars can point us in the right
direction if this isn't already fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 00:10:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 22:10:06 +0000
Subject: [Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial
 frequency and numbering management
In-Reply-To: <bug-16967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16967-70-3XJ29XHrVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #2 from Aliki Pavlidou <pavlidoualiki at gmail.com> ---
Dear Owen,

I've tested 

-> Manage frequencies:

- Everything works just fine. When I've selected to "Delete" a frequency, there
was this message:
This frequency is still used by 2 subscription(s). Do you still want to delete
it?
The list of titles it was also there, after clicking the "Show subscriptions"
link.

- The form submission validation is still working correctly, as I've entered a
non-numeric data (the word: two) in the "issues per unit" field and after
submitting the form, I got back as a result this message:
Some fields are not valid. Issues per unit is required (must be a number
greater than 0).

-> Manage numbering patterns:

- Like before, I tried to "Delete" "Back up pattern1", and the following
message appeared:
This pattern is still used by 2 subscription(s). Do you still want to delete
it?
The list of titles it was also there, after clicking the "Show subscriptions"
link.

- Regarding creating a new numbering pattern, I was trying to create one yearly
subscription that has 11 issues per year. Do you have any idea how could I set
this pattern? For example 2015 was the 18th year of this journal publication,
and July and August was merged into one issue.

Kind regards
Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 01:02:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 23:02:44 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-BLCiOTb8ZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #130 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #129)
> Hi Mark,
> looking at https://wiki.koha-community.org/wiki/Hidden_values:
> -8 is described as "flag" - which noone knows exactly what it means I think.
> For "Everything hidden everywhere" I would have picked 8 or 5. 
> Can you explain your choice of -8?

Because even though it is <0 which is typically visible in OPAC, -8 is NOT
visible in OPAC. There is logic which uses <0 in a lot of places and a -8 is
bound to catch it if you are looking around and notice it isn't there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 01:05:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 23:05:22 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-jKgL6HOWBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #131 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #129)
> Can you explain your choice of -8?

opac-MARCDetail.pl on the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 01:11:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 23:11:26 +0000
Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get
	out of sync
In-Reply-To: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12584-70-icTZwy4uRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #6)
> Had it result been that long I've been out of the loop.. Did we ever f in nd
> the right deacons option..  Wondering if lars can point us in the right
> direction if this isn't already fixed?

I'm working on a rewrite of the instance handling code, that will move this to
another file. We could discuss this on a dev meeting, or in Marseille. Better
earlier.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 01:46:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 15 Aug 2016 23:46:17 +0000
Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined
 value at C4/ Search.pm line 806
In-Reply-To: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17123-70-gVVFmvhc7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Unfortunately I cannot at the moment, it must be a combination of things
introduced relatively recently to the master. I have not been playing with OPAC
for a month or so, and this thing jumped on me. What I did meanwhile as well
was to move zebra indexing to dom.
I'll try to see what exactly is causing it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 05:44:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 03:44:32 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-22L82WsP2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 05:44:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 03:44:35 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-CfhP27nrhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53791|0                           |1
        is obsolete|                            |

--- Comment #12 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54494&action=edit
Bug 16939: Making all 'add to basket' actions buttons

Edit: Fixing 'clas' typo in addorderiso2709.tt
Edit: Adding actions class to td
Edit: Fixing js error
Edit: circ/reserveratios.tt updated so that the plus icon doesn't show
      if there is no link
Edit: fixing logic in circ/reserveratios.tt

To test:

1) Go to Acqui -> find a vendor -> view a basket
2) Click add to basket -> fill in 'for an existing record' and hit search
3) 'View MARC' and 'Order' buttons should show under an Actions column with
appropriate icons
4) Click Order
5) Click add item when you are redirected to the New order page (no need to
fill in any details)
6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column
with appropriate icons
7) Go back to your basket and click add to basket -> from a subscription (we
are skipping from a suggestion because this already has a button before my
patch)
8) Confirm that 'Order' shows as a button with appropriate icon
9) Go back to your basket and click add to basket -> from an external source
10) fill in any fields and click search to bring up results
11) 'Order' should now show as a button with appropriate icons. MARC and Card
preview have been moved into a dropdown menu - confirm this works as expected.
Links have not been changed when clicking on a row
12) Go back to your basket and click add to basket -> from a staged file
13) 'Add orders' should now show as a button with appropriate icon
14) Go back to your basket and click add to basket -> from titles with highest
hold ratios
15) 'X to order' should now show as a button with appropriate icon

Sponsored-by: Catalyst IT

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 05:45:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 03:45:46 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-eP1VDOkajC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

--- Comment #13 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Owen Leonard from comment #11)
> I'm still getting the plus sign when there is no link. I think the template
> logic is off somewhere. If it helps, feel free to break up and re-indent
> that section since right now it's all on one line.

I rearranged some stuff, so hopefully this new patch works for you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 08:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 06:33:40 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-lUhFEQkOiF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

--- Comment #24 from Marc V?ron <veron at veron.ch> ---
+1 for 3 with <<  >>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 09:27:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 07:27:45 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-no60fhUGws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 54495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54495&action=edit
Problem with workflow if hold found

There is a problem with the workflow if a hold is found. What should users do
first first, confirm hold etc. or confirm question?

Confirming hold leads to an internal server error, plack error log says: Fatal:
unexpected operator 'cancellationdate' with undef operand at
....Koha/Objects.pm line 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 09:47:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 07:47:14 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-t7i8SADJK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #54)
> I'm at a loss. I just rebased and squashed/split all these patches for
> readability. Everything is working, but the browser continues to indicate
> it's grabbing cached files even when the filename has changed!
> 
> At first I thought it was because the rewrite was doing a 301 redirect, so I
> removed that, and still had the same thing. Next I tried a 307, but again,
> the same results ( though chrome decided not to cache some files at all with
> a 307 ).
> 
> Here is a video demonstration: http://screencast.com/t/JfFonhkWax
> 
> Martin, Jonathan, any ideas on what is going on?
> 
> Kyle

Using firebug (network tab) that sounds ok for me:
(reload mainpage)
mainpage_16.0600014.css 301 (moved permanentely)
mainpage.css 200

(click on mainpage)
nothing # from cached

(change version using the interface, so the page reload and will hit some .css
and .js files, that's why we are focusing on mainpage.css)
(click on mainpage)
mainpage_16.0600014.css 301 (moved permanentely)
mainpage.css 200

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:20:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:20:52 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-NOpSQYxrSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:20:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:20:57 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-gFzlUQNGTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5932|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54496&action=edit
Bug 7045: Use <<tag>> for default value placeholders

When adding a biblio, the default value of a MARC subfield defined in
the frameworks can be used as placeholders to set the current date or
the surname of the logged in user (use cases?).
The different placeholders are 'YYYY', 'MM', 'DD', 'user'.
When adding an item, same behavior except that 'user' is not replaced.

This patch makes behaviors consistent between the 2 editors and
surrounds placeholders with << >>
We will now have: <<YYYY>>, <<MM>>, <<DD>> and <<USER>>

Test plan:
Define default values for biblio and item subfields.
Create a bibliographic record and attach it an item.
The default values should be used and replaced if you used placeholders.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:21:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:21:04 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-iccYSjUuHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54497&action=edit
Bug 7045: Update default value placeholders for existing installs

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:21:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:21:58 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-urt3gfY0aF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:22:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:22:52 +0000
Subject: [Koha-bugs] [Bug 10294] when the word "user" is included in default
 in framework, surname of login creating record inserted
In-Reply-To: <bug-10294-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10294-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10294-70-inRaufDI9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Rocio Dressler from comment #3)
> Hello, this is still an issue for libraries. We would like to be able to use
> the actual text "user" without it transforming into the surname of the
> librarian modifying the record.

Will be fixed by the patch I have just submitted on bug 7045.

*** This bug has been marked as a duplicate of bug 7045 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:22:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:22:52 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-iMGHG0hZck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drnoe at bywatersolutions.com

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 10294 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:35:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:35:22 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-7YufTQsH13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:35:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:35:34 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-AcCucKsL3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51332|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54498&action=edit
Bug 16272: Automatically switch an on-site checkout to a regular checkout when
checked out

Use case: A patron checks some items out on-site and want to take it home.
To facilitate the librarian work the checkout is directly switched from
on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is
on.

Test plan:
0/ Let the new pref SwitchOnSiteCheckouts off
1/ Checkout one items to a patron and tick the "on-site checkout"
checkbox
2/ Check the same item out without ticking the "on-site checkout"
checkbox
=> You should get "This item can not be renewed, it's an on-site checkout"
3/ Switch the pref on
4/ Repeat 2
=> The on-site checkout should be automatically switched to a regular checkout

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small changes to apply to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:35:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:35:39 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-226CP2QhYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51333|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54499&action=edit
Bug 16272: Specific case when switching an on-site checkout to a regular
checkout

In the case on-site checkouts are considered as a regular checkout in issuing
rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on):
When after the on-site checkout the maximum limit of checkouts is
reached and the patron wants to switch an on-site checkout to a regular
checkout, the C4::Circulation::TooMany subroutine will return a
TOO_MANY_CHECKOUTS error.
To avoid that, we need to allow an extra checkout in this subroutine.

Test plan:
0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and
SwitchOnSiteCheckouts on
1/ In the issuing rules, set the total number of checkouts (maxissueqty)
to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty)
2/ Check 2 items out ticking the 'on-site checkout' checkbox
3/ Check one of these items out, to automatically switch it to a regular
checkout
=> The checkout should be allowed.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:36:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:36:28 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-Y84xlfeSZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #6)
> Smallish conflict in C4/Circulation.pm

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:39:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:39:38 +0000
Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get
	out of sync
In-Reply-To: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12584-70-k20NzYwzcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.16                        |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 10:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 08:42:27 +0000
Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11
In-Reply-To: <bug-14952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14952-70-uznn5cQOqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This bug is (will) certainly fixed by bug 16403, bug 16573 and/or bug 16554.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:06:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:06:46 +0000
Subject: [Koha-bugs] [Bug 12345] Can't Clear Reading History for Anonymous
	patron
In-Reply-To: <bug-12345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12345-70-qCJpTGVeFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.14                        |unspecified

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Still valid.
But the behavior is the expected one: When you delete a checkout history you
actually anonymise the checkout history :)

On bug 11009 we decided not to display the checkout history on the staff
interface. Maybe we should do the same at the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:07:02 +0000
Subject: [Koha-bugs] [Bug 12345] Can't Clear Reading History for Anonymous
	patron
In-Reply-To: <bug-12345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12345-70-39uggKToMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11009

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:07:02 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-c3XZKb50n4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12345

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:09:48 +0000
Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for
	anonymisation errors
In-Reply-To: <bug-9944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9944-70-whBFTiHpVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.12                        |unspecified

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Still valid:

141     # Anonymising all members
142     if ($do_anonym) {
143         #FIXME: anonymisation errors are not handled
144         ($totalAno,my $anonymisation_error) =
AnonymiseIssueHistory($last_issue_date);
145         $template->param(
146             do_anonym   => '1',
147         );
148     }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:11:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:11:25 +0000
Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for
	anonymisation errors
In-Reply-To: <bug-9944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9944-70-pjjPk2gEAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16966

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note that bug 16966 will improve it a bit: the number of records anonymised
will be displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:11:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:11:25 +0000
Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move
 GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
In-Reply-To: <bug-16966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16966-70-OghIbNKeLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9944

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:26:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:26:55 +0000
Subject: [Koha-bugs] [Bug 10066] updating biblio return undefined error if
 linked authority does not exist in db
In-Reply-To: <bug-10066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10066-70-SX5oXfMpLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10066

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.10                        |unspecified
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looking at the code, this is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 11:40:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 09:40:29 +0000
Subject: [Koha-bugs] [Bug 13860] cloud-kw.pl not UTF-8 compliant
In-Reply-To: <bug-13860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13860-70-BeoR8qWK3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13860

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
That's fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 12:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 10:01:49 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-sxpnGO4YT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54496|0                           |1
        is obsolete|                            |

--- Comment #28 from Marc V?ron <veron at veron.ch> ---
Created attachment 54500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54500&action=edit
Bug 7045: Use <<tag>> for default value placeholders

When adding a biblio, the default value of a MARC subfield defined in
the frameworks can be used as placeholders to set the current date or
the surname of the logged in user (use cases?).
The different placeholders are 'YYYY', 'MM', 'DD', 'user'.
When adding an item, same behavior except that 'user' is not replaced.

This patch makes behaviors consistent between the 2 editors and
surrounds placeholders with << >>
We will now have: <<YYYY>>, <<MM>>, <<DD>> and <<USER>>

Test plan:
Define default values for biblio and item subfields.
Create a bibliographic record and attach it an item.
The default values should be used and replaced if you used placeholders.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 12:02:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 10:02:35 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-Gnp4syVgGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54497|0                           |1
        is obsolete|                            |

--- Comment #29 from Marc V?ron <veron at veron.ch> ---
Created attachment 54501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54501&action=edit
Bug 7045: Update default value placeholders for existing installs

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 12:06:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 10:06:16 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-Ln2c5znmHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 12:07:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 10:07:49 +0000
Subject: [Koha-bugs] [Bug 16549] Remove the use of "onclick" from header
	search forms
In-Reply-To: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16549-70-VkeMAjG136@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
This patch appears to introduce a bug reverting previous behaviour. In the
staff client search the catalogue when results are displayed instead of the
active tab remaining 'Search the catalogue' it is switched to 'Check out'.
Users are findling this behaviour irritating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 12:30:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 10:30:11 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-TQ9g02a4rT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54486|0                           |1
        is obsolete|                            |

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54502&action=edit
Bug 17008: Test to compare Swagger property types against column data types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:18:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:18:14 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item ( depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-Y6OTrOsahC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:20:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:20:51 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-tMVtkCDBHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:26:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:26:16 +0000
Subject: [Koha-bugs] [Bug 16680] Library name are not displayed for holds in
	transit
In-Reply-To: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16680-70-B97avvAquG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:28:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:28:01 +0000
Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery
 when leaving form fields empty
In-Reply-To: <bug-16707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16707-70-YqSadXx6iK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:28:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:28:15 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-rPS3cZeyQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54503&action=edit
Bug 17109: [QA Follow-up] Die when wrong token

Removes template var csrf_error and associated handling.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Restested with opac and intranet: Still sends or dies elegantly..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:28:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:28:56 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-jbZJIzGIpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> If you do that here, I will have to do it in all other places (and really
> don't want to! :) )
> Are you sure we really want to stylish it?

No problem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:30:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:30:23 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-2HQZFvKLzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:40:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:40:04 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-3y8fzdHeuX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:42:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:42:18 +0000
Subject: [Koha-bugs] [Bug 16705] Status missing in Opac,
	serials subscription history
In-Reply-To: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16705-70-B5laqqQoq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16705

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:43:36 +0000
Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing
In-Reply-To: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16708-70-Vt67WHX0Qp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:46:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:46:05 +0000
Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as
 of version 16.05)
In-Reply-To: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16724-70-PNU7VkPtkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:48:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:48:01 +0000
Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref
In-Reply-To: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16731-70-SWr0TnHj4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:51:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:51:25 +0000
Subject: [Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
In-Reply-To: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16737-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16737-70-yyWI7dve5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Depends on|                            |7736

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 14:51:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 12:51:25 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-Ted77dEUAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16737


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737
[Bug 16737] Error when deleting EDIFACT message
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:04:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:04:03 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-6kG0TTaRKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|IndependantBranches         |IndependentBranches
                   |preference appears to       |preference overrides
                   |override AutoLocation       |AutoLocation security
                   |security feature            |feature
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:04:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:04:54 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-SMERlMd6Fa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:06:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:06:20 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-pGsxOo1i7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Confirmed on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:07:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:07:35 +0000
Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about
 Plack::App:: CGIBin instance
In-Reply-To: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16644-70-TKTlD5lnWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:08:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:08:30 +0000
Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
In-Reply-To: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16736-70-cqgWZfeYkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:10:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:10:24 +0000
Subject: [Koha-bugs] [Bug 16742] Remove unused template subject.tt
In-Reply-To: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16742-70-AJJVLP2cgu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:12:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:12:31 +0000
Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated
 "'s"in request.tt
In-Reply-To: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16697-70-DsZNQrZ2m3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:14:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:14:04 +0000
Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence
 splitting by < strong> in about.tt
In-Reply-To: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16718-70-dHaPVqgZfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:15:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:15:36 +0000
Subject: [Koha-bugs] [Bug 16751] Fix sitemaper typo
In-Reply-To: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16751-70-h89cjs0ORR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16751

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:15:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:15:51 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-sVh7r7feL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:16:06 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-034NXlQn7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54504&action=edit
Bug 9569: Fix AutoLocation - handle .* for subnets

The example in branches.tt is:
  Can be entered as a single IP, or a subnet such as 192.168.1.*

But actually the regex in C4::Auth does not handle subnets.

Test plan:
0/ Apply all the patches
1/ Switch AutoLocation on
2/ Define a subnet (192.168.0.* if your ip is like 192.168.0.X) in the IP
range of your library
3/ Log in on the staff interface
=> Should work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:16:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:16:14 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-I6z8xevrNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54505&action=edit
Bug 9569: AutoLocation should not depend on IndependentBranches

Those 2 prefs can be independent and it does not make sense to consider
AutoLocation only if IndependentBranches is set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:16:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:16:22 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-rKJcG1wY3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54506&action=edit
Bug 9569: Remove unused occurrence of AutoLocation

`git grep ManualLocation` does not return any results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:16:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:16:29 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-BJEi1sDOcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54507&action=edit
Bug 9569: Do not check the IP for login at the OPAC

At the OPAC, the AutoLocation feature should not be taken into account:
login to the OPAC from outside the IP range should work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:17:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:17:31 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-5ZkL5FVFKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.10                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:17:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:17:50 +0000
Subject: [Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation
 enabled, OPAC login does not redirect properly outside IP range
In-Reply-To: <bug-6804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6804-70-O3wCIgDsvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Will be fixed by bug 9569.

*** This bug has been marked as a duplicate of bug 9569 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:17:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:17:50 +0000
Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides
 AutoLocation security feature
In-Reply-To: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9569-70-OuI6ufqKQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.sekjal at gmail.com

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 6804 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:23:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:23:23 +0000
Subject: [Koha-bugs] [Bug 12629] Software error when trying to merge records
 from different frameworks
In-Reply-To: <bug-12629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12629-70-DobypHyTmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |unspecified
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #2)
> This bug has had a patch since 2014 but was never marked "Needs signoff!"
> However, I can't reproduce the problem in master. Is it still valid?

Looking at the code, I'd say it's still valid and appears when a field is
defined in one framework but in the other one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:25:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:25:31 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-cfFHSgs50N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
For the special case, if a default rule is set in addition to the circ rule
then the onsite checkout to change to a regular checkout still activates a too
many warning

I think you need the delta at the lines below as well

 539         if (
C4::Context->preference('ConsiderOnSiteCheckoutsAsNormalCheckouts') ) {
 540             if ( $checkout_count >= $max_checkouts_allowed ) {
 541                 return {
 542                     reason => 'TOO_MANY_CHECKOUTS',
 543                     count => $checkout_count,
 544                     max_allowed => $max_checkouts_allowed,
 545                 };
 546             }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:29:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:29:29 +0000
Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not
 working properly
In-Reply-To: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15173-70-4Ruw3VDBnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7673
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
[Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:29:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:29:29 +0000
Subject: [Koha-bugs] [Bug 7673] New patron permissions to manage items (edit,
 batchmod, delete all)
In-Reply-To: <bug-7673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7673-70-4H21Fjw66u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15173


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173
[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:31:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:31:32 +0000
Subject: [Koha-bugs] [Bug 16651] Notes field blank for 952$z in
	opac-course-details.pl
In-Reply-To: <bug-16651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16651-70-K8ZxiI2OwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:37:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:37:44 +0000
Subject: [Koha-bugs] [Bug 16770] Remove wrong uses of Memoize::Memcached
In-Reply-To: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16770-70-NiV6BAx7rz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:38:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:38:37 +0000
Subject: [Koha-bugs] [Bug 16772] Change label from 'For:' to 'Library:' to
 ease translation
In-Reply-To: <bug-16772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16772-70-vZmwu8zFKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16772

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:42:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:42:21 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-e9OA7LfOgS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

--- Comment #3 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54508&action=edit
Bug 17008: Add "swaggerize" for Koha::Object and Koha::Objects

This patch adds new subroutine "swaggerize" for Koha::Object and Koha::Objects.

By matching column data types with corresponding Swagger data type, we can e.g.
numify values in order to be able to return borrowernumber:123 instead of
borrowernumber:"123".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:45:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:45:00 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-OcVQ6e6rfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54502|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54509&action=edit
Bug 17008: Test to compare Swagger property types against column data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type by using Koha::Util::Swagger::column_type_to_swagger_type().

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/definitions/patron.json cardnumber to be type "integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:45:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:45:34 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-jufNl6tOHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

--- Comment #5 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54510&action=edit
Bug 17008: Fix current data types

This patch changes current Swagger definitions for patrons and holds to have
data types corresponding to column data types in their database tables.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Note that test has a lot of failures.
3. Apply this patch.
4. Run t/db_dependent/api/v1/swagger/definitions.t
5. Note that tests pass.
6. Run REST of the tests in t/db_dependent/api/v1/*

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:48:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:48:37 +0000
Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing
In-Reply-To: <bug-15705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15705-70-8i3zHvpJsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:49:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:49:14 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-9TQ3DOILSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:50:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:50:55 +0000
Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl
In-Reply-To: <bug-12176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12176-70-DkjhlyjtB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15173


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173
[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 15:50:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 13:50:55 +0000
Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not
 working properly
In-Reply-To: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15173-70-wjlG4eeLFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
         Depends on|                            |12176
             Status|NEW                         |ASSIGNED
           Severity|enhancement                 |major

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This bug has been introduced by bug 12176.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176
[Bug 12176] Remove HTML from additem.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:00:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:00:34 +0000
Subject: [Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id=
 itemst - Cannot reinitialise DataTable.
In-Reply-To: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17125-70-woJDGyacF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hmm Not only opac-basket. opac-detail, opac-user etc. Probably all occurrences
of dataTables..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:08:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:08:58 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-hC9zxnooLX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:10:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:10:46 +0000
Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when
	cancelling holds
In-Reply-To: <bug-14968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14968-70-FpvI9jJHXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:14:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:14:06 +0000
Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not
 working properly
In-Reply-To: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15173-70-GucpQaoyln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:14:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:14:10 +0000
Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not
 working properly
In-Reply-To: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15173-70-7JiC9eSKhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54511&action=edit
Bug 15173: Restore SubfieldsToAllowForRestrictedEditing

Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176
broke it assuming that only selects were impacted by this feature.

Test plan:
Go back on bug 7673 and confirm that
SubfieldsToAllowForRestrictedEditing is working as expected with this
patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:14:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:14:24 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-UGf8phBC5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|enhancement                 |major

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Marking as Major, as it breaks production sites on upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:16:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:16:59 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-gSLoi9xh2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:19:37 +0000
Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not
 populating itemtype correctly
In-Reply-To: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16760-70-l34WJfhlvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:30:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:30:15 +0000
Subject: [Koha-bugs] [Bug 13245] Send Cart via Email corrupts some Unicode
	characters
In-Reply-To: <bug-13245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13245-70-MbQviuWakF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13245

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.12                        |unspecified

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #6)
> Is this bug still valid? I appears to be working correctly in master, but
> I'm not entirely sure I'm testing correctly.

Yes I guess it is still an issue as we use HTML-Format 2.11.
I'd opt to close this bug as it's not a bug from Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:38:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:38:35 +0000
Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM
 when using 12 hour time format
In-Reply-To: <bug-16780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16780-70-Lo3fxBVpO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:39:16 +0000
Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw
 invalid local time exception
In-Reply-To: <bug-9031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9031-70-lZjK1FTpGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16376
            Version|3.8                         |unspecified
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:39:16 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-EsE0hWgBcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9031

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:40:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:40:37 +0000
Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken
In-Reply-To: <bug-16854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16854-70-wtUxeXMuaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:43:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:43:49 +0000
Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of
 SQL call in export.pl
In-Reply-To: <bug-16855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16855-70-MWZOT8zvbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:43:52 +0000
Subject: [Koha-bugs] [Bug 12036] Neworderempty.pl fails to add items when
 itemrecorddisplay is too long ( acqCreateItem=ordering)
In-Reply-To: <bug-12036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12036-70-lffT5u2OGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marked as resolved, please reopen if the issue still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:45:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:45:27 +0000
Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl
In-Reply-To: <bug-16859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16859-70-Y9Xm7J7vmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:51:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:51:10 +0000
Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown
 parameter from opac-detail.tt
In-Reply-To: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15636-70-Xpn57wG8c3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:55:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:55:10 +0000
Subject: [Koha-bugs] [Bug 16774] Format date on 'Transfers to receive' page
 to dateformat system preference
In-Reply-To: <bug-16774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16774-70-5niXEWJQST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16774

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:57:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:57:07 +0000
Subject: [Koha-bugs] [Bug 13249] AutoCreateAuthorities doesn' t work for
 fields different from 700
In-Reply-To: <bug-13249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13249-70-tmY8pssBYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13249

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What is the "Thesaurus plugin"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:57:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:57:39 +0000
Subject: [Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when
 adding/editing a biblio
In-Reply-To: <bug-16807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16807-70-IPC8I1jpFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Depends on|                            |14889


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889
[Bug 14889] Move the framework related code to Koha::BiblioFramework[s]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 16:57:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 14:57:39 +0000
Subject: [Koha-bugs] [Bug 14889] Move the framework related code to
 Koha::BiblioFramework[s]
In-Reply-To: <bug-14889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14889-70-fYosyxvkGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16807


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807
[Bug 16807] Frameworks unordered  in dropdown when adding/editing a biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:01:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:01:10 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-buoXAd5B0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:02:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:02:39 +0000
Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in
 t/db_dependent/ SuggestionEngine_ExplodedTerms.t
In-Reply-To: <bug-16869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16869-70-UHvImlN7qi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:04:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:04:17 +0000
Subject: [Koha-bugs] [Bug 15929] typo in explanation for
 MaxSearchResultsItemsPerRecordStatusCheck
In-Reply-To: <bug-15929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15929-70-arRr7oVDTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:05:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:05:32 +0000
Subject: [Koha-bugs] [Bug 16779] Move road type after address in US style
 address formatting ( main address)
In-Reply-To: <bug-16779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16779-70-XKOcnvoUUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16779

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:09:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:09:54 +0000
Subject: [Koha-bugs] [Bug 17135] New: Fine for the previous overdue may get
 overwritten by the next one
Message-ID: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

            Bug ID: 17135
           Summary: Fine for the previous overdue may get overwritten by
                    the next one
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When patron renews an item which has overdue fines accruing, fine amount
updating stops, but fine record remains associated with a given issue (by
issue_id in accountlines). If this item becomes due again, fines.pl doesn't
create new fine record for 2nd+ overdue of the same issue - it just overwrites
'amount' and 'amountoutstanding' in the existing record instead, and the
previous fine for this issue gets effectively lost.

This used to work correctly in 3.18-3.22 (more or less - historically
implementation was pretty convoluted, it used due date in the fine description
for matching issue record with the fine record), but it's broken since 16.05;
probably a regression from Bug 15675 (?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:10:49 +0000
Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of
 images in audio_alerts.tt
In-Reply-To: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16793-70-sibhCRtVg7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Depends on|                            |16148


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148
[Bug 16148] Revised layout and behavior of marc modification template
management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:10:49 +0000
Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc
 modification template management
In-Reply-To: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16148-70-yKjZkD1B4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16793


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793
[Bug 16793] Use Font Awesome for arrows instead of images in audio_alerts.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:11:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:11:17 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-PPsniFSLl8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15675


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675
[Bug 15675] Add issue_id column to accountlines and use it for updating fines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:11:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:11:17 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-sEOjduL3Kk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135
[Bug 17135] Fine for the previous overdue may get overwritten by the next one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:12:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:12:20 +0000
Subject: [Koha-bugs] [Bug 10880] Staff Client Display856uAsImage options
	need updating
In-Reply-To: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10880-70-2rbekzrI4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
To make it works, you need to set 856$q=img (or image, gif, etc.)

This feature seems to correctly implemented for MARC21 only:

git grep -l Display856uAsImage | grep MARC21

MARC21
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl

UNIMARC
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl

NORMARC:
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:12:26 +0000
Subject: [Koha-bugs] [Bug 10282] Implement (OPAC)Display856uAsImage for
	NORMARC XSLT
In-Reply-To: <bug-10282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10282-70-VZhK1PO5S7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10282

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10880

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:12:26 +0000
Subject: [Koha-bugs] [Bug 10880] Staff Client Display856uAsImage options
	need updating
In-Reply-To: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10880-70-zQ1YfbndUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10282

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:13:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:13:22 +0000
Subject: [Koha-bugs] [Bug 10880] Staff Client Display856uAsImage options
	need updating
In-Reply-To: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10880-70-dGOxpbW22H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.12                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:14:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:14:33 +0000
Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of
 images in audio_alerts.tt
In-Reply-To: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16793-70-nnzCFryTBS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Fr?d?ric, some style definitions may be missing in 16.05 (.overline,
.underline, .order-control) since they are introduced by bug 16148, which is
not in 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:17:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:17:38 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-cK8vj9hGZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

--- Comment #5 from Holger Mei?ner <h.meissner.82 at web.de> ---
"On hold" is what is displayed for manual renewals when a hold is placed. I
think it should be the same for auto renewals. Otherwise the patron might have
regular items that are "on hold" and auto-renewed items that are "not renewable
(on hold)".

So maybe the wording should be changed/discussed in another bug? This one is
just about adding the standard information that was missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:22:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:22:14 +0000
Subject: [Koha-bugs] [Bug 16795] Patron categories: Accept integers only for
 enrolment period and age limits
In-Reply-To: <bug-16795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16795-70-gNG827wy0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16286
                 CC|                            |julian.maurice at biblibre.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286
[Bug 16286] Use validation plugin when adding or editing patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:22:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:22:14 +0000
Subject: [Koha-bugs] [Bug 16286] Use validation plugin when adding or
 editing patron category
In-Reply-To: <bug-16286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16286-70-oQPJqUjBTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795
[Bug 16795] Patron categories: Accept integers only for enrolment period and
age limits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:22:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:22:31 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-k1Akl8nTpD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
+1 for a new bug regarding the wording

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:26:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:26:29 +0000
Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear
 all" links to shelves.tt
In-Reply-To: <bug-16803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16803-70-ieaWf7oVTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:29:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:29:17 +0000
Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings
 "Argument "" isn' t numeric"
In-Reply-To: <bug-16857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16857-70-KA1WR6kgZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:30:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:30:55 +0000
Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t
In-Reply-To: <bug-16860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16860-70-olo7YAmBG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:32:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:32:50 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-4xCZ58Qlj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54455|0                           |1
        is obsolete|                            |

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54512&action=edit
[SIGNED-OFF]Bug 14434: Display "On hold" in OPAC for auto renewed items

This patch makes the OPAC display "On hold" instead of "Automatic
renewal" when a hold is placed.

Test plan:
1) Issue an item with automatic renewal.
2) Place a hold on the item.
3) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)."
4) Apply patch.
5) Refresh OPAC and note that now "On hold" is displayed.
6) Cancel the hold, then log in as patron again and note that now
   "Automatic renewal (x of y renewals remaining)" is displayed
   once again.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:33:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:33:01 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-YyFGciQdxC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:34:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:34:49 +0000
Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of
 images in audio_alerts.tt
In-Reply-To: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16793-70-szAriSm9nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Julian Maurice from comment #6)
> Fr?d?ric, some style definitions may be missing in 16.05 (.overline,
> .underline, .order-control) since they are introduced by bug 16148, which is
> not in 16.05.x

Thanks a lot for catching this! You're totally correct. Those CSS rules are
missing in 16.05.x. The visual effect is almost unnoticeable, but it's there. I
will fix that. Thks again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:37:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:37:55 +0000
Subject: [Koha-bugs] [Bug 16677] Use abbr for authorities linked headings
In-Reply-To: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16677-70-B9hJa7RWWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:39:29 +0000
Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes
 in moremember-brief.tt
In-Reply-To: <bug-16730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16730-70-xPYLqUntrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:40:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:40:45 +0000
Subject: [Koha-bugs] [Bug 16801] Include Font Awesome Icons to check/ unchek
 all in Administration > Library transfer limits
In-Reply-To: <bug-16801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16801-70-ZnnmxHtMDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:45:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:45:11 +0000
Subject: [Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC
In-Reply-To: <bug-16805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16805-70-p4YW0c4N2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:50:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:50:52 +0000
Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of
 images in audio_alerts.tt
In-Reply-To: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16793-70-0uxltRQ4Pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54513&action=edit
Bug 16793 [16.05] Add 3 missing css rules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:54:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:54:54 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-G2ZZezyG6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49648|0                           |1
        is obsolete|                            |
  Attachment #49649|0                           |1
        is obsolete|                            |
  Attachment #49650|0                           |1
        is obsolete|                            |
  Attachment #49651|0                           |1
        is obsolete|                            |
  Attachment #49652|0                           |1
        is obsolete|                            |
  Attachment #49653|0                           |1
        is obsolete|                            |
  Attachment #52425|0                           |1
        is obsolete|                            |
  Attachment #53224|0                           |1
        is obsolete|                            |
  Attachment #53225|0                           |1
        is obsolete|                            |

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54514&action=edit
Bug 14504: Add delete_items.pl: a command line batch deletion tool

http://bugs.koha-community.org/show_bug.cgi?id=14504

Signed-off-by: Heather Braum <hbraum at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:17 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-fDEsNxSm6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54515&action=edit
Bug 14504: (QA followup)

* Fix POD warning.
* Remove redundant 'use stric' and 'use warnings'
* Remove $VERSION and --version option.
* Remove --dry-run option
* Split test for --help and check for @criteria into two separate pod2usage
calls,
    enabling -msg on the latter.
* Fix 'target_tiems' typo.
* Test for holds on items to be deleted.
* Fix whitespace
* Fix test for holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:20 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-VfZwfO33Sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54516&action=edit
bug 14504: split logic from DelItemCheck() into ItemSafeToDelete()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:23 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-WIHkw1Asl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54517&action=edit
bug 14504: use C4::Items::DelItemCheck in delete_items.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:27 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-N9ttuP6Emu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54518&action=edit
Bug 14504: (QA followup) use TestBuilder, remove do_not_commit

Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t

Remove the option 'do_not_commit' from C4::Items::DelItemCheck.

Whitespace cleanup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:30 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-WqaDZOaURG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54519&action=edit
bug 14504: (QA followup) fixing DelItemCheck arguments

Remove $dbh as argument to C4::Items::DelItemCheck
and C4::Items::ItemSafeToDelete, also change all
calls to these functions throughout the codebase.

Also remove remaining reference to 'do_not_commit' in
t/db_dependent/Items_DelItemCheck.t

Fixed doubled "$$" in C4/ImportBatch.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:34 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-jVCXK4RkK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54520&action=edit
Bug 14504: (QA followup) fix test transaction, book_on_loan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:37 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-ajXXXraI14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54521&action=edit
Bug 14504: (QA followup) Tidy tests

This patch re-introduces the transaction into
t/db_dependent/Items_DelItemCheck.t
and does some cleaning on the touched tests so they raise less warnings.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 17:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 15:55:40 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-hItpGQAGgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54522&action=edit
Bug 14504: (QA followup) Fix delete_records_via_leader.pl call to DelItemCheck

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:00:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:00:07 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-XVjoX0yUrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:00:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:00:22 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-TQJUB96TZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54523&action=edit
Bug 16272: (follow-up) Specific case when switching an on-site checkout to a
regular checkout

Same as previous patch but if another circ rule exists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:00:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:00:38 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-vAI5QHAwTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54524&action=edit
Bug 16272: Add description for tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:01:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:01:13 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-4tb2zktJ0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #10)
> For the special case, if a default rule is set in addition to the circ rule
> then the onsite checkout to change to a regular checkout still activates a
> too many warning
> 
> I think you need the delta at the lines below as well

Good catch! Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:40:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:40:42 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-t5Z9G9KRWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54525&action=edit
Bug 14504 - Changes missed while fixing patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:45:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:45:23 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-Y2WCvb7M76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:54:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:54:11 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-ctEnb3cWTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11079|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 11079
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11079
[SIGNED-OFF] Bug 8137 - Checkout limit by patron category for all libraries

This patch is so out of date this bug will require a new patch to be written.
Obsoleting it and resetting the bug status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:54:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:54:20 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-CwJWNEq6BC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:54:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:54:25 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-3oqbip724l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 18:54:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 16:54:32 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-WZPne3oB7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:16:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:16:29 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-OQ9fcaIC5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:16:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:16:31 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-4f21buIIHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54498|0                           |1
        is obsolete|                            |

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54526&action=edit
Bug 16272: Automatically switch an on-site checkout to a regular checkout when
checked out

Use case: A patron checks some items out on-site and want to take it home.
To facilitate the librarian work the checkout is directly switched from
on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is
on.

Test plan:
0/ Let the new pref SwitchOnSiteCheckouts off
1/ Checkout one items to a patron and tick the "on-site checkout"
checkbox
2/ Check the same item out without ticking the "on-site checkout"
checkbox
=> You should get "This item can not be renewed, it's an on-site checkout"
3/ Switch the pref on
4/ Repeat 2
=> The on-site checkout should be automatically switched to a regular checkout

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small changes to apply to master.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:16:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:16:38 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-ozPDtIRBlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54499|0                           |1
        is obsolete|                            |

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54527&action=edit
Bug 16272: Specific case when switching an on-site checkout to a regular
checkout

In the case on-site checkouts are considered as a regular checkout in issuing
rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on):
When after the on-site checkout the maximum limit of checkouts is
reached and the patron wants to switch an on-site checkout to a regular
checkout, the C4::Circulation::TooMany subroutine will return a
TOO_MANY_CHECKOUTS error.
To avoid that, we need to allow an extra checkout in this subroutine.

Test plan:
0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and
SwitchOnSiteCheckouts on
1/ In the issuing rules, set the total number of checkouts (maxissueqty)
to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty)
2/ Check 2 items out ticking the 'on-site checkout' checkbox
3/ Check one of these items out, to automatically switch it to a regular
checkout
=> The checkout should be allowed.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:16:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:16:46 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-SPPmHApaT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54523|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54528&action=edit
Bug 16272: (follow-up) Specific case when switching an on-site checkout to a
regular checkout

Same as previous patch but if another circ rule exists

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:16:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:16:51 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-MEpK6V8qVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54524|0                           |1
        is obsolete|                            |

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54529&action=edit
Bug 16272: Add description for tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:30:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:30:52 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-ylwfAhj7rL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17101

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:30:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:30:52 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-zJwqnkXSRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16942

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Internal server error when confirming might be related to Bug 16942
See IRC: 
http://irc.koha-community.org/koha/2016-08-16#i_1849391

Regarding the work flow: It is confusing to have two things to confirm. Maybe
two steps are better:

First the question about checking in and only after confirming this question
the qeustion about holds.

What do you think about?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 20:39:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 18:39:56 +0000
Subject: [Koha-bugs] [Bug 13847] Cannot download large reports as Open
 Office Spreadsheet ODS
In-Reply-To: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13847-70-yLb03zg7Zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|normal                      |major
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Bumping this a bit, even at 25k rows in my kohadev box the process just grows
and eats memory and CPU time even after the page times out. We should either
fix this or remove the ods option

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 21:21:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 19:21:57 +0000
Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists
In-Reply-To: <bug-15924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15924-70-hpzAOZy8AE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 21:23:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 19:23:51 +0000
Subject: [Koha-bugs] [Bug 13847] Cannot download large reports as Open
 Office Spreadsheet ODS
In-Reply-To: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13847-70-xVTascMy6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think removing is not option. We could display a warning that the report
won't download completely maybe? And then cut it off at a reasonable number of
lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 22:39:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 20:39:40 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-FW7oIz7mmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 22:39:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 20:39:44 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-WPOVTShyUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #54 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 54530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54530&action=edit
Bug 14504: (QA followup) Fix error causing item not to be deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 22:39:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 20:39:57 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-FRXb6InJp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #55 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 54531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54531&action=edit
Bug 14504: (QA followup) Change argument --criteria to --where

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 16 23:12:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 21:12:06 +0000
Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes
 them un-writeoffable
In-Reply-To: <bug-11217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11217-70-CYdHQcbf8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217

Christopher Davis <cgdavis at uintah.utah.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgdavis at uintah.utah.gov

--- Comment #1 from Christopher Davis <cgdavis at uintah.utah.gov> ---
Dear Colleagues,

This bug is also giving my institution trouble. Anyone else?

Thanks,

Christopher Davis

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 00:24:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 22:24:09 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-vdES4dplkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #9 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
So I narrowed down the problem:

session is created by a simple auth session module we wrote largely mimicking
svc/authentication.

Noticed that the $ip param is missing from the session, and neither ip nor
_SESSION_REMOTE_ADDR is present in the mysql session storage.

So I guess svc/authentication and other CGI scripts pass $ip somehow or
generates by ENV{REMOTE_ADDR}, and we will have to adjust to that. Or revert to
use svc/authentication. Or address some other API authentication bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 00:44:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 22:44:49 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-n6mZSEcHOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Jonathan, I inserted my infamous Plack::Middleware::Tomas that just prints env,
and interestingly:

 {
    HTTP_ACCEPT                     
"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8",
    HTTP_ACCEPT_ENCODING             "gzip, deflate",
    HTTP_ACCEPT_LANGUAGE             "en-US,en;q=0.5",
    HTTP_COOKIE                      "KohaOpacLanguage=en;
CGISESSID=59977e155eba3200f39ba4b1cb23efec",
    HTTP_DNT                         1,
    HTTP_HOST                        "localhost:8081",
    HTTP_REFERER                    
"http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51",
    HTTP_UPGRADE_INSECURE_REQUESTS   1,
    HTTP_USER_AGENT                  "Mozilla/5.0 (Macintosh; Intel Mac OS X
10.11; rv:49.0) Gecko/20100101 Firefox/49.0",
    HTTP_X_FORWARDED_FOR             "10.0.2.2",
    HTTP_X_FORWARDED_HOST            "localhost:8081",
    HTTP_X_FORWARDED_SERVER          "kohadev-intra.myDNSname.org",
    PATH_INFO                        "/intranet/mainpage.pl",
    psgi.errors                      *main::STDERR  (write-only, flags: append,
layers: unix perlio),
    psgi.input                       *Starman::Server::$io  (layers: scalar),
    psgi.multiprocess                1,
    psgi.multithread                 "",
    psgi.nonblocking                 "",
    psgi.run_once                    "",
    psgi.streaming                   1,
    psgi.url_scheme                  "http",
    psgi.version                     [
        [0] 1,
        [1] 1
    ],
    psgix.harakiri                   1,
    psgix.input.buffered             1,
    psgix.io                         *Symbol::GEN41  (read/write, layers: unix
perlio),
    QUERY_STRING                     "",
    REMOTE_ADDR                      "10.0.2.2",
    REMOTE_HOST                      undef,
    REMOTE_PORT                      0,
    REQUEST_METHOD                   "GET",
    REQUEST_URI                      "/intranet/mainpage.pl",
    SCRIPT_NAME                      "",
    SERVER_NAME                      0,
    SERVER_PORT                      8081,
    SERVER_PROTOCOL                  "HTTP/1.1"
}

so HTTP_X_FORWARDED_FOR and REMOTE_ADDR have the right values. Are you implying
that Mojo is messing with ENV?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 00:46:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 22:46:26 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-eN5lt8hybB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Full-site SSL: always use   |OpenLibrary: always use SSL
                   |SSL when referencing        |when referencing external
                   |external resources          |resources

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
Since the Passed QA scope is OpenLibrary only. I figure another bug is better
suited to fixing other issues. That's why I renamed this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 01:44:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 16 Aug 2016 23:44:19 +0000
Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
In-Reply-To: <bug-14420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14420-70-XEoYJ8arLX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
  Attachment #40362|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 07:17:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 05:17:10 +0000
Subject: [Koha-bugs] [Bug 17136] New: Dependency packages in the Koha
	repository
Message-ID: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17136

            Bug ID: 17136
           Summary: Dependency packages in the Koha repository
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

I will try to add some info which packages I add to the Koha Debian repository,
and why.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 07:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 05:19:37 +0000
Subject: [Koha-bugs] [Bug 17136] Dependency packages in the Koha repository
In-Reply-To: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17136-70-qFSLSLpkzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17136

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Planned: newer libsoap-lite-perl to avoid dependency problems
(libossp-uuid-perl vs. newer Catmandu) See Bug 16254.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 07:23:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 05:23:41 +0000
Subject: [Koha-bugs] [Bug 17136] Dependency packages in the Koha repository
In-Reply-To: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17136-70-g5cbWtxLQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17136

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Planned: libsearch-elasticsearch-perl and libcatmandu-store-elasticsearch-perl
for Elasticsearch support. They are not in Debian yet. See bug 12478. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834363.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 07:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 05:25:22 +0000
Subject: [Koha-bugs] [Bug 17136] Dependency packages in the Koha repository
In-Reply-To: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17136-70-bcCJ3tGd3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17136

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Planned: koha-elasticsearch. Meta package to pull in the necessary
dependencies. See bug 12478. See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17136#c2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 09:25:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 07:25:11 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-UzvVXWOO9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #20 from Oliver Bock <oliver.bock at aei.mpg.de> ---
Too bad. I intentionally named this bug without a specific service because all
previous fixes so far typically only covered a single service. That means all
the rest doesn't get fixed. My hope was to kick off a general fixing round,
starting things of myself with OpenLibrary. This (intended) effort depends of
course on others stepping in to fix the rest. Changing this back to the old
scheme seems like a missed opportunity.

Best,
Oliver

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:30:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:30:46 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-fAFiNWzGqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's just a workflow thing. Once patches have been pushed we don't 'reuse' the
bug for more patches - it causes too much confusion with the status and also
our release notes are created from the bug titles. 
We use one Omnibus bug with linked bugs for the separate issues. I will create
an Omnibus bug and links this one to show how it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:32:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:32:05 +0000
Subject: [Koha-bugs] [Bug 17137] New: Omnibus: Always use SSL when
 referencing external sources
Message-ID: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

            Bug ID: 17137
           Summary: Omnibus: Always use SSL when referencing external
                    sources
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Amazon, OpenLibrary, etc shoudl all use https if available as otherwise they
create a mixed content error for sites using https.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:32:21 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-H84V4NLmNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16615


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615
[Bug 16615] OpenLibrary: always use SSL when referencing external resources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:32:21 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-y6tABgLS0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:32:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:32:57 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-di3n5q6bAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
https://bugs.koha-community.org/bugzilla3/showdependencytree.cgi?id=17137&hide_resolved=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:35:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:35:43 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-ezpdmqjKHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #23 from Oliver Bock <oliver.bock at aei.mpg.de> ---
Ok, sounds good. This should also ensure that completed patches can already be
rolled out with the next release.

Thanks,
Oliver

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:43:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:43:34 +0000
Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t
In-Reply-To: <bug-16866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16866-70-nhGafQIiLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:48:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:48:13 +0000
Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for
 closed connections reliably
In-Reply-To: <bug-13807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13807-70-POdhd0Elop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
This has been pushed to 16.05.x (August 1st), will be in 16.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:48:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:48:50 +0000
Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for
 closed connections reliably
In-Reply-To: <bug-13807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13807-70-ODp9Y47IEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 10:58:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 08:58:29 +0000
Subject: [Koha-bugs] [Bug 16917] Error when importing patrons,
 Column 'checkprevcheckout'   cannot be null
In-Reply-To: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16917-70-AxehwoYnAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Stable            |Pushed to Master

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 11:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 09:26:34 +0000
Subject: [Koha-bugs] [Bug 17138] New: UpdateFine() modyfies existing fine
 records even when there is no need
Message-ID: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

            Bug ID: 17138
           Summary: UpdateFine() modyfies existing fine records even when
                    there is no need
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In C4/Overdues.pm:

  574:     # we're updating an existing fine.  Only modify if amount changed

  577:     if ( $data->{'amount'} != $amount ) {

for some numbers (e.g. 5.60) the comparison in line 577 fails
($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be a
floating point number with no exact binary representation). E.g. when the fine
amounts are multiple of 0.20, it fails for the 33.3% of the amounts (on
average).

Depending on the fine charging settings, this may trigger unnecessary database
writes (and a lot of them). If 'Fine Charging Interval' is 1 day, this has very
little practical consequences (misc/cronjobs/fines.pl script is usually run
once per day, and all fines need an increase anyway). But if the charging
interval is longer, e.g. 7 days, in a given day amount changes only for the 1/7
of the fines (again, on average), and over 60% of the database writes would be
redundant.

To reproduce:
1) run misc/cronjobs/fines.pl
2) add

   warn "AMOUNT ".$data->{'amount'}." vs $amount";

below line 577 in C4/Overdues.pm
3) run misc/cronjobs/fines.pl again
4) you'll see some warnings like 'AMOUNT 5.600000 vs 5.6'

or: dump accountlines table after step 1), run the script 2nd time, dump the
table again and compare the contents - some of the records would have a
different timestamp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 11:33:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 09:33:02 +0000
Subject: [Koha-bugs] [Bug 2735] Authority search in OPAC stops at 15 pages
In-Reply-To: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2735-70-MQwQkRGySI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 11:53:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 09:53:31 +0000
Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with
 the CSV profile doesn't set the issue claimed
In-Reply-To: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12178-70-nNMZ6gRRsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:04:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:04:53 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-lW6JpDL6r5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:04:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:04:55 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-SApBE7KvMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #1 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54532&action=edit
Bug 17138 - UpdateFine() modyfies existing fine records even when there is no
need

In C4/Overdues.pm:

  574:     # we're updating an existing fine.  Only modify if amount changed

  577:     if ( $data->{'amount'} != $amount ) {

for some numbers (e.g. 5.60) the comparison in line 577 fails
($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be
a floating point number with no exact binary representation).
E.g. when the fine amounts are multiple of 0.20, it fails for the 33.3%
of the amounts (on average).

Depending on the fine charging settings, this may trigger unnecessary
database writes (and a lot of them). If 'Fine Charging Interval' is
1 day, this has very little practical consequences (misc/cronjobs/fines.pl
script is usually run once per day, and all fines need an increase
anyway). But if the charging interval is longer, e.g. 7 days, in a given
day amount changes only for the 1/7 of the fines (again, on average),
and over 60% of the database writes would be redundant.

To reproduce:

1) run misc/cronjobs/fines.pl
2) add

   warn "AMOUNT ".$data->{'amount'}." vs $amount";

below line 577 in C4/Overdues.pm
3) run misc/cronjobs/fines.pl again
4) you'll see some warnings like 'AMOUNT 5.600000 vs 5.6'

or: dump accountlines table after step 1), run the script 2nd time, dump
the table again and compare the contents - some of the records would have
a different timestamp.

To test:

1) apply patch
2) redo steps 1) - 4) above
3) no more warnings in step 4
4) 2nd run of misc/cronjobs/fines.pl should be noticeably faster

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:09:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:09:09 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-RLIsuyYZLX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:19:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:19:14 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-F2RPwzM0tY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #2 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #1)

> 4) 2nd run of misc/cronjobs/fines.pl should be noticeably faster

On my test setup (19200 overdues, ~6500 redundant updates, FinesLog disabled)
fines.pl run time was 90 seconds (before) vs 50 seconds (after). Not very
striking difference, but this is on server with SSD drive, and

   innodb_flush_log_at_trx_commit = 2

in mysql config; YMMV.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:21:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:21:08 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15342-70-4PNmdnkEX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17138


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138
[Bug 17138] UpdateFine() modyfies existing fine records even when there is no
need
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:21:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:21:08 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-UnK0SlAjJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15342


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342
[Bug 15342] Performance 3.22 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:22:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:22:42 +0000
Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from
	login timeout
In-Reply-To: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15006-70-4T2MD7m4Nt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #87 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:25:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:25:13 +0000
Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification
 tool does not get any patrons
In-Reply-To: <bug-16682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16682-70-0h6aHsvBsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:30:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:30:58 +0000
Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout
In-Reply-To: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16810-70-sfOBTpR7oN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:43:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:43:58 +0000
Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails
In-Reply-To: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14138-70-bVoLEmM3yi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:47:23 +0000
Subject: [Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied
In-Reply-To: <bug-16813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16813-70-yOQaMRGZc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:48:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:48:10 +0000
Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not
	been removed
In-Reply-To: <bug-16844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16844-70-xaskqbSdRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:50:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:50:29 +0000
Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail
	page style
In-Reply-To: <bug-16893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16893-70-NAyxGhYp0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:55:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:55:16 +0000
Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists
In-Reply-To: <bug-16897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16897-70-kclHzDb2Rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 12:58:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 10:58:16 +0000
Subject: [Koha-bugs] [Bug 16900] Hold suspend button incorrectly styled in
 patron holds list
In-Reply-To: <bug-16900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16900-70-HY8vLRPL3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:01:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:01:35 +0000
Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt
 (sentence splitting)
In-Reply-To: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16621-70-zS704zrd9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:11:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:11:14 +0000
Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated
 ' in currency.tt
In-Reply-To: <bug-16701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16701-70-0tsQa2bbhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:12:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:12:16 +0000
Subject: [Koha-bugs] [Bug 16777] Correct intranet search alias
In-Reply-To: <bug-16777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16777-70-WmpBWXa3Ql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16777

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:14:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:14:28 +0000
Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members
In-Reply-To: <bug-16888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16888-70-LE5IXh0Kgu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:18:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:18:28 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-zCq7k7DLkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:28:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:28:57 +0000
Subject: [Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id=
 itemst - Cannot reinitialise DataTable.
In-Reply-To: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17125-70-5q83KWq4ut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Horrible: A duplicated PROCESS jsinclude line in opac-bottom.inc was the
culprit. Somehow created in a rebase.
Closing this report now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:29:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:29:09 +0000
Subject: [Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id=
 itemst - Cannot reinitialise DataTable.
In-Reply-To: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17125-70-9ET1KoosLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:39:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:39:56 +0000
Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in
	the list.
In-Reply-To: <bug-15974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15974-70-e1LARFhvH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:42:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:42:48 +0000
Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in
 GetborCatFromCatType and GetAuthorisedValues
In-Reply-To: <bug-16716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16716-70-yxlihPIJbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:45:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:45:26 +0000
Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences
In-Reply-To: <bug-16947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16947-70-Fzvfrm1g1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:47:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:47:50 +0000
Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted
	order line
In-Reply-To: <bug-16934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16934-70-gf1BchUz9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 13:52:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 11:52:40 +0000
Subject: [Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed
In-Reply-To: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17037-70-pVxtnE41tN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

--- Comment #3 from Matthew K <m.kibble at sae.edu> ---
Hi,

We finally managed to get the item information to display again. I'd overloaded
the archive by importing too many records; Just required a clean out. Is there
a way to expand the archive space?

However, the search results won't update any additions or deletions of records
(they definitely exist/have been deleted - can be located through items
issued). I've speculated that it may have something to do with Zebra and may
require a manual index, but when we were trying this with the initial problem,
the koha-conf.xml file apparently didn't exist (though I don't know if this is
still the case). Any additional suggestions would be appreciated.

Also, with regards to updating. Would an update to a later version cause any
data loss with regards to currently issued items? What precautions can I take
to avoid this?

Apologies if any of these questions are irrelevant or novice. I'm still very
new to the software.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 14:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 12:09:42 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-df1yOvd1P2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 14:14:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 12:14:04 +0000
Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected
In-Reply-To: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15397-70-HwlU5xXOrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 14:38:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 12:38:25 +0000
Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines
	calculations
In-Reply-To: <bug-15741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15741-70-5uZj0ZvT3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

--- Comment #12 from Lari Taskula <larit at student.uef.fi> ---
This bug still appears in master at "Pay amount" and "Pay selected" for payment
of 1.14, but not with 64.60.

To replicate:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Go to Pay fines tab
7. Click "Pay selected" and confirm
8. Observe error message "You must pay a value less than or equal to 1.14."

However, via individual row's "Pay" button it seems to work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 14:53:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 12:53:17 +0000
Subject: [Koha-bugs] [Bug 16988] Suspending a hold with
 AutoResumeSuspendedHolds disabled results in error
In-Reply-To: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16988-70-7NcAHu9lvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:01:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:01:46 +0000
Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two
	new prefs
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-9QPNEWFuX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:35:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:35:40 +0000
Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack
In-Reply-To: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16818-70-GiF8SZ03eb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:37:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:37:51 +0000
Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities
In-Reply-To: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16971-70-qC3qvjDhVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:38:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:38:49 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-BGSqmjLmOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:42:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:42:06 +0000
Subject: [Koha-bugs] [Bug 16868] Silence error
	t/db_dependent/Linker_FirstMatch.t
In-Reply-To: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16868-70-KN7kRUFhHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Depends on|                            |16155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
[Bug 16155] Composite keys in TestBuilder and more
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:42:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:42:06 +0000
Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
In-Reply-To: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16155-70-hwxfQf3OKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868
[Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:42:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:42:16 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-cq3BRRxyI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:43:50 +0000
Subject: [Koha-bugs] [Bug 16809] Silence authority warnings
 C4::Biblio::TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-EkkiQBrhcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:43:52 +0000
Subject: [Koha-bugs] [Bug 16809] Silence authority warnings
 C4::Biblio::TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-iO4cMjDtQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52832|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54535&action=edit
Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc

Most of the floodiness is caused by accessing the cgi parameters
in a context which is hard to determine. By purposefully saving
the value to a scalar variable and using the variable, the issue
disappears, and it will likely be a tiny tad faster as variable
access is faster than multiple function calls.

TEST PLAN
---------
 1) Back up your intranet error log
    -- for example:
       cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
    -- for example:
       echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
    -- floody!
 9) Apply patch
10) repeat steps 2-8
    -- blank!
11) restore your intranet error log
   -- for example:
      mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with addbiblio.pl. I would have preferred the scalar option in terms
of simpler code, but this works too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:43:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:43:56 +0000
Subject: [Koha-bugs] [Bug 16809] Silence authority warnings
 C4::Biblio::TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-W90hRCy9Ha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54536&action=edit
Bug 16809: Follow-up for scalarizing biblionumber

Still resolves another multi_param warning.

Test plan:
Look at your logs before and after this patch when saving a biblio
record (you may have to start plack again).
If your biblionumber is mapped to 999c, you should no longer have a warn
about line 2563 (disclaimer: line numbers are subject to change).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:44:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:44:10 +0000
Subject: [Koha-bugs] [Bug 16864] Silence warnings in
	t/db_dependent/ILSDI_Services.t
In-Reply-To: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16864-70-OEDPsPetfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:44:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:44:33 +0000
Subject: [Koha-bugs] [Bug 14251] style discharge letter
In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14251-70-cWTiGlhjBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m

--- Comment #6 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Katrin, are you sure CSS is used ?
I see the code uses PDF::FromHTML to produce the pd file or the documentation
says "it is not designed to utilise CSS."
(http://search.cpan.org/~audreyt/PDF-FromHTML-0.31/lib/PDF/FromHTML.pm)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:44:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:44:58 +0000
Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning
In-Reply-To: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16727-70-JnqTHxKx53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:45:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:45:26 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-V1m61FKspQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:45:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:45:29 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-dpKjdvLcGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54537&action=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:46:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:46:41 +0000
Subject: [Koha-bugs] [Bug 16809] Silence CGI param warnings from
 C4::Biblio:: TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-e6O3aUt3j7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Silence authority warnings  |Silence CGI param warnings
                   |C4::Biblio::TransformHtmlTo |from
                   |Marc                        |C4::Biblio::TransformHtmlTo
                   |                            |Marc
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:47:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:47:57 +0000
Subject: [Koha-bugs] [Bug 17044] Wrong destination for 'api' directory
In-Reply-To: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17044-70-bViBdJYUwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:53:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:53:49 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-QwHaG4irnK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:58:20 +0000
Subject: [Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt
In-Reply-To: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17068-70-XlWNfvNhnO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 15:59:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 13:59:03 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
 & add libhtml-parser-perl
In-Reply-To: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17062-70-ZW8VscemdN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
See 17063 for 16.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:00:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:00:48 +0000
Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig
In-Reply-To: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17065-70-DUz7mIXg0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:02:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:02:21 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-C0KBVnu4qT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #26 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:14:29 +0000
Subject: [Koha-bugs] [Bug 14251] style discharge letter
In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14251-70-53XrLPcSDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not totally sure - we haven't played much with the discharge notices so far.

We have added a few line breaks so far, but no more formatting I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:15:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:15:36 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-JZRwMQlT2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #1 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Dunno how to resolve this problem properly

- reintroduce due date to the issue record <-> fine record matching in
UpdateFine()
- unlink fine record from the issue record on renewal (set issue_id to NULL in
fine record)
- set fine type to 'F' on renewal, and ignore records of such type in the
matching code in UpdateFine()

or maybe some combination of the above? I think this problem can happen only
when there is at least 1 renewal of due item involved (any kind of renewal),
but I'm not entirely sure. All that legacy fine calculation code works in truly
mysterious ways.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:20:36 +0000
Subject: [Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion
 confirmation in some templates
In-Reply-To: <bug-16372-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16372-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16372-70-POaCKDJ0t6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16058
                 CC|                            |julian.maurice at biblibre.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058
[Bug 16058] Add a button to delete an individual news item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:20:36 +0000
Subject: [Koha-bugs] [Bug 16058] Add a button to delete an individual news
	item
In-Reply-To: <bug-16058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16058-70-Ib8kePVHR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16372


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372
[Bug 16372] Replace the use of "onclick" for deletion confirmation in some
templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:30:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:30:32 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-Z0tuathFf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Owen Leonard from comment #7)
> I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic
> that it depends on Bug 16386?

This patch seems not to be really dependent on bug 16386 (except that it was
written on top of it).
I'll try to write a patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:35:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:35:57 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-3woIsyhedz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #11 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Julian Maurice from comment #10)
> (In reply to Owen Leonard from comment #7)
> > I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic
> > that it depends on Bug 16386?
> 
> This patch seems not to be really dependent on bug 16386 (except that it was
> written on top of it).
> I'll try to write a patch for 3.22.x

That is awesome.  Thank you.  :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:36:58 +0000
Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch
In-Reply-To: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13736-70-QCWkHvpRjy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 42894
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42894
EDS Plugin Patches Code checks to see if  setting EDSEnabled is ON and
integrates the EDS Plugin to the Opac

Review of attachment 42894:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13736&attachment=42894)
-----------------------------------------------------------------

I'm pretty sure something jquery/ajax-y could be written to get the plugin to
accomplish the same thing. I too, like Katrin in comment #4, have some
misgivings about this implementation.

::: C4/Auth.pm
@@ +471,4 @@
>              AuthorisedValueImages                 => C4::Context->preference("AuthorisedValueImages"),
>              BranchesLoop                          => GetBranchesLoop($opac_name),
>              BranchCategoriesLoop                  => GetBranchCategories( 'searchdomain', 1, $opac_name ),
> +	    EDSEnabled                            => C4::Context->preference("EDSEnabled"),

Never needed.
Access [% Koha.Preference('EDSEnabled') %] in template files.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
@@ +48,4 @@
>      function _(s) { return s } // dummy function for gettext
>  </script>
>  <script type="text/javascript" src="[% interface %]/[% theme %]/lib/modernizr.min.js"></script>
> +[% IF ( EDSEnabled ) %]<script type="text/javascript" language="javascript" src="/plugin/Koha/Plugin/EDS/js/EDSScript.js"></script>[% END %]

Including a plugin javascript link should be possible in the OPACUserJS system
preference. Make sure to carefully add/remove as needed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:37:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:37:39 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random
	data
In-Reply-To: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-ux6DasZ6tw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |sophie.meynieux at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:41:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:41:41 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-ErReKGBZ2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54538&action=edit
[3.22.x] Bug 16450 - Remove the use of "onclick" from guarantor search template

This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.

This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.

To test, apply the patch and clear your browser cache if necessary.

- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
  button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
  as the guarantor. The guarantor's address information should be added
  to the "Main address" section.

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:42:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:42:13 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-AP0S3yJhJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:45:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:45:26 +0000
Subject: [Koha-bugs] [Bug 17139] New: Translation process should not pick
 class value inside span tags
Message-ID: <bug-17139-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139

            Bug ID: 17139
           Summary: Translation process should not pick class value inside
                    span tags
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Example:

koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
line 14:
 <span class="BT">

BT is picked for translation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:47:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:47:15 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-vTXOHSiRb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:47:17 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-GNZNtl7hx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51228|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54539&action=edit
Bug 16258 Add a syspref to govern EDIFACT functionality

Adds an "Edifact" systempreference to govern whether edifact processing
is enabled. In most places this is hidden if the current
vendor does not appear in the edi vendors table. This preference
hides the admin screens which define this and a couple of links.

Also fixes an anomaly whereby the basketgroup screen was not
making the same check on whether edi ordering should be enabled as
the basket screen. Both now use the same logic.

Rebase by mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:57:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:57:49 +0000
Subject: [Koha-bugs] [Bug 17139] Translation process should not pick class
 value inside span tags
In-Reply-To: <bug-17139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17139-70-c7S0XOhNRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
...but we have:

<span class="UF"><abbr title="Used For">


Inside abbr tag, "Used For" should be translatable (is picked by translation
process).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:59:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:59:36 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-lqV4oTFdXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 16:59:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 14:59:39 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-HJ8dW06lgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52902|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54540&action=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
         in jessie is just fine and should be added to the community
         repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:01:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:01:29 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-cFcQ8mg0dH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54540|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 54541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54541&action=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
         in jessie is just fine and should be added to the community
         repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:02:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:02:43 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-7QrMG4en1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Rebased. Kitten saved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:02:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:02:44 +0000
Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when
	TransformHtmlToMarc
In-Reply-To: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16370-70-TSmi4OoEOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:24:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:24:39 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
 authority records to a biblio record during edition. (AJAX)
In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11299-70-uFBrdekWIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #25 from M. Tompsett <mtompset at hotmail.com> ---
The addbiblio.tt conflict is easy enough to resolve, though you need to look
into fontawesome classes instead of icon-ok.

The C4/Biblio.pm conflict is harder to resolve, as the logic which is ripped
out and replaced with a function has changed. This means the logic in the new
function needed to be rechecked.

Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:36:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:36:12 +0000
Subject: [Koha-bugs] [Bug 17140] New: Incorrect rounding in total fines
 calculations, part 2
Message-ID: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

            Bug ID: 17140
           Summary: Incorrect rounding in total fines calculations, part 2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 15741 fixes some rounding issues but not all, for example trying to paying
a fine of 1.14 still does not work (also 1.39).

To replicate bug:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Go to Pay fines tab
7. Click "Pay selected" and confirm
8. Observe error message "You must pay a value less than or equal to 1.14."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:36:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:36:29 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-JSpbLuPH51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15741


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741
[Bug 15741] Incorrect rounding in total fines calculations
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:36:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:36:29 +0000
Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines
	calculations
In-Reply-To: <bug-15741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15741-70-LDt2Wx5PqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17140


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140
[Bug 17140] Incorrect rounding in total fines calculations, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:39:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:39:27 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-WH5t2DqeVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54542&action=edit
Bug 17140: Test to cover more rounding issues in fines calculations

To test:
1. Run t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 17:44:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 15:44:06 +0000
Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module,
 use Koha::Account::  pay internally for recordpayment
In-Reply-To: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15895-70-PHFmArs3K4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53883|0                           |1
        is obsolete|                            |

--- Comment #18 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54543&action=edit
Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for
recordpayment

This is the first patch in a series to unify all payment functions into
a single method.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay amount" button

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:03:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:03:57 +0000
Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price
	= 0
In-Reply-To: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14535-70-90ztwxGYLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just had another library reporting this as a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:28:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:28:03 +0000
Subject: [Koha-bugs] [Bug 17141] New: Incorrect method called in edit_cron
	to get logdir
Message-ID: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

            Bug ID: 17141
           Summary: Incorrect method called in edit_cron to get logdir
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Should call the config method to retrieve the logdir otherwise an error is
generated at runtime

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:28:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:28:50 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-Cz9YLz8cJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Incorrect method called in  |Incorrect method called in
                   |edit_cron to get logdir     |edi_cron to get logdir

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:34:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:34:26 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-PXSIZPQ1Xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com
             Status|NEW                         |Needs Signoff

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 54544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54544&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:44:07 +0000
Subject: [Koha-bugs] [Bug 17142] New: Don' t show library group selection in
 advanced search if groups are not defined
Message-ID: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

            Bug ID: 17142
           Summary: Don't show library group selection in advanced search
                    if groups are not defined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org

Even if library groups/search domains are not defined in the system, (empty)
select for "Groups of libraries" under "Location and availability" section in
OPAC advanced search is still visible; it shouldn't. Side effect of Bug 15295 -
'searchdomainloop' variable in the template is now an object, it needs a
different kind of statement (.count) to check if it's empty or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:44:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:44:58 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-0Qtt7osdQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295
[Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:44:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:44:58 +0000
Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to
 Koha::Libraries - part 2
In-Reply-To: <bug-15295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15295-70-ERXnpnfhVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17142


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142
[Bug 17142] Don't show library group selection in advanced search if groups are
not defined
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:52:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:52:35 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-Vp6IKVLyuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:52:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:52:37 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-r8oX9AdZf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

--- Comment #1 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54545&action=edit
Bug 17142 - Don't show library group selection in advanced search if groups are
not defined

Even if library groups/search domains are not defined in the system,
(empty) select for "Groups of libraries" under "Location and
availability" section in OPAC advanced search is still visible; it
shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable
in the template is now an object, it needs a different kind of statement
(.count) for checking if it's empty or not.

To test:

1) apply patch
2) when there are no groups of libraries defined in Administration ->
Libraries and Groups, "Groups of libraries" selection should be
no longer visible in OPAC adavanced search page
3) add library group or two: "Groups of libraries" selection should
reappear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 18:54:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 16:54:13 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-Bnd0LssGcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:19:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:19:25 +0000
Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the patron's
 opac checkout summary
In-Reply-To: <bug-14668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14668-70-3nsFBzeqgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Aliki Pavlidou <pavlidoualiki at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavlidoualiki at gmail.com

--- Comment #11 from Aliki Pavlidou <pavlidoualiki at gmail.com> ---
Hello everybody!


1. THE CHECKOUT TAB, INTRANET

First things first there was no "h" subfield at the editing page of an item.

The "h" subfield for items.enumchron is in "MARC21 Holding field (952)".
The matching "v" subfield is in UNIMARC Holding field (995), which was showing
at the editing page.
So I tested it by adding the values "volume 42" in the following subfield "v -
Note sur le N? de p?riodique". 
In this perspective everything worked just fine and the enumchron was
concatenated with the title, and the barcode.


2. A PATRON'S RELATIVE, INTRANET + OPAC

The enumchron was in the "Relatives' checkouts" tab, of the guarantor's
checkout page.


P.S.: Please let me know if there is something I should do to check it with the
"h" subfield.

Best regards
Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:20:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:20:38 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-ttfjZs8mYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
[Bug 16942] Confirm hold results in ugly error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:20:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:20:38 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-8J66H36YQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695
[Bug 14695] Add ability to place multiple item holds on a given record per
patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:21:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:21:29 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-IIpaqvqjY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:21:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:21:34 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-6SzYpl43d8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51277|0                           |1
        is obsolete|                            |
  Attachment #51278|0                           |1
        is obsolete|                            |
  Attachment #51279|0                           |1
        is obsolete|                            |
  Attachment #51280|0                           |1
        is obsolete|                            |
  Attachment #51281|0                           |1
        is obsolete|                            |
  Attachment #51282|0                           |1
        is obsolete|                            |
  Attachment #51283|0                           |1
        is obsolete|                            |
  Attachment #51284|0                           |1
        is obsolete|                            |
  Attachment #51285|0                           |1
        is obsolete|                            |
  Attachment #51286|0                           |1
        is obsolete|                            |
  Attachment #51287|0                           |1
        is obsolete|                            |
  Attachment #51288|0                           |1
        is obsolete|                            |
  Attachment #51289|0                           |1
        is obsolete|                            |
  Attachment #52457|0                           |1
        is obsolete|                            |

--- Comment #159 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54546&action=edit
Bug 14695 - Update database

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:21:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:21:47 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-yKRZMymJOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #160 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54547&action=edit
Bug 14695 - Update DB Schema file

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:21:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:21:52 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-UHAEv0IL1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #161 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54548&action=edit
Bug 14695 - Add new circulation rule

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:21:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:21:58 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-7AiYff9Tph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #162 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54549&action=edit
Bug 14695 - Tidy C4::Reserves::CanItemBeReserved

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:04 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-ZQuUT2a6xN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #163 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54550&action=edit
Bug 14695 - Add ability to place multiple item holds on a given record per
patron

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:10 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-LGSVQOTWBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #164 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54551&action=edit
Bug 14695 [QA Followup] - Filling one hold fills all of them

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:16 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-aFkW1vmDRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #165 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54552&action=edit
Bug 14695 [QA Followup] - Make existing unit tests pass

* Removes tests no longer needed
* Updates rules to work with existing tests
* Fixes code issues revealed by unit tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:22 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-j3jUrFgAfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #166 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54553&action=edit
Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:28 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-5iq269EPNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #167 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54554&action=edit
Bug 14695 - Warn librarian if max_holds_per_record is reached

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:33 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-EI1tlx3dTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #168 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54555&action=edit
Bug 14695 - Don't use holds_to_place_count when checking an item.

This fix the following bug:
If you select 2 in "Holds to place (count)" and finally
check an item, so you get 2 holds for the same item.

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:39 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-T5Bz8PkXUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #169 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54556&action=edit
Bug 14695 [QA Followup] - Fix method names 'type' to '_type'

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:45 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-AsiiGPbXPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #170 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54557&action=edit
Bug 14695: Fix typo in template

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:51 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-iPNcxJUweX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #171 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54558&action=edit
Bug 14695 [QA Followup] - Disable "Holds to place (count)" unless "Hold next
available item" is checked

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:22:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:22:57 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-0U9ufnHsAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #172 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54559&action=edit
Bug 14695 [QA Followup] - Tell librarian if item doesn't allow or forces item
level holds in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:27:26 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-JAne2JGyWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA
             Blocks|14695                       |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #4)
> > Kyle, the following test should fail without this patch:
> >   is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
> > );        
> > 
> > Could you please adapt it?
> 
> The test still passes.

They unit tests fail for me without the initial patch applied.

prove t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. 1/14 DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 'BIBLIONUMBER '557' AND
`ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND `ARRAY(0x88' at line 1 [for
Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`,
`me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`,
`me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`,
`me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`,
`me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`,
`me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype` FROM `reserves` `me`
WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND `ARRAY(0x8818f68)`
BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )" with ParamValues:
0='557', 1='140', 2='114'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1832.
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near 'BIBLIONUMBER '557' AND `ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND
`ARRAY(0x88' at line 1 [for Statement "SELECT `me`.`reserve_id`,
`me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`,
`me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`,
`me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`,
`me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`,
`me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`
FROM `reserves` `me` WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND
`ARRAY(0x8818f68)` BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )"
with ParamValues: 0='557', 1='140', 2='114'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 6/14 subtests

Test Summary Report
-------------------
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 65280 Tests: 8 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 14 tests but ran 8.
Files=1, Tests=8,  3 wallclock secs ( 0.02 usr  0.01 sys +  1.74 cusr  0.18
csys =  1.95 CPU)
Result: FAIL


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695
[Bug 14695] Add ability to place multiple item holds on a given record per
patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:27:26 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-GxttCXFFav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16942                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
[Bug 16942] Confirm hold results in ugly error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:57:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:57:21 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-Poh9OI4v9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:58:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:58:08 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-FUcNYclYmY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:58:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:58:47 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-WiGtBcDpbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 19:59:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 17:59:33 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-ALnMEBqhtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Indranil!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 20:00:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 18:00:29 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-fZKFWQCh5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Olli!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 20:09:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 18:09:45 +0000
Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface'
	column
In-Reply-To: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16829-70-ZFwq5cx30j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 20:12:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 18:12:38 +0000
Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date
 doesn't do anything, date last seen always defaults to current date.
In-Reply-To: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16834-70-HUUklJbEmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Yes it does

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 20:42:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 18:42:06 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-3oadgN70T6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
  Attachment #53466|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 20:43:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 18:43:57 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-848V1qsjZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Tomas, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 17 23:42:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 17 Aug 2016 21:42:44 +0000
Subject: [Koha-bugs] [Bug 16371] Quote of the Day (QOTD) - Display in
 different interfaces
In-Reply-To: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16371-70-OYXvajr7RY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 03:28:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 01:28:33 +0000
Subject: [Koha-bugs] [Bug 17143] New: Popup Notification for
 decreaseloanhighholds preference
Message-ID: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

            Bug ID: 17143
           Summary: Popup Notification for decreaseloanhighholds
                    preference
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If you have an item that meets the holds requirement by the
decreaseloanhighholds preference, but doesn?t get a decrease in the actual
checkout period; you still get a popup notification that the high demand
feature is being used and the loan period will be decreased. The notification
shouldn't populate if the decreased loan period matches or is higher than the
original loan period.  The current behavior in the system looks at the the
number of holds and doesn't take the loan periods with an equal value into
consideration when enforcing the preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 07:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 05:39:29 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-QFpl63nSL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Pongtawat <pongtawat at punsarn.asia> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pongtawat at punsarn.asia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 09:08:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 07:08:52 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-Z145cDXNqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53760|0                           |1
        is obsolete|                            |

--- Comment #25 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 54560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54560&action=edit
Latest version of patch, with silly typo fixed

Hi Marc,

Thanks for that. Can't believe I didn't put the fix for that into the patch
here - we've been running with it for ages! :-) 

This version of the patch should have fixed it (and also rebased to master so
that it will apply!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 09:09:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 07:09:03 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-vZtAIp9YBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 09:37:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 07:37:48 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-Ad8AEIPZnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 09:49:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 07:49:29 +0000
Subject: [Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import
	breaks in Plack
In-Reply-To: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15032-70-JRZDiQelVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Script are running so faster with Plack, we may disable the background mode
when using Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 10:22:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 08:22:39 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-mZ8B1eA83M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 10:33:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 08:33:35 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-oVocG6c7SF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #10)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Jonathan Druart from comment #4)
> > > Kyle, the following test should fail without this patch:
> > >   is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
> > > );        
> > > 
> > > Could you please adapt it?
> > 
> > The test still passes.
> 
> They unit tests fail for me without the initial patch applied.

% git fetch origin
% git reset --hard origin/master
% git clean -f -d
%  prove t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. ok     
All tests successful.
Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
csys =  2.94 CPU)
Result: PASS

What I meant is that the test 'Hold object used correctly' successes when we
are expecting it to fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 11:01:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 09:01:27 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-0bb27D5DDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 11:14:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 09:14:05 +0000
Subject: [Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the
	item number?
In-Reply-To: <bug-9834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9834-70-3GS5zdkGst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #4 from Sally Healey <sally.healey at cheshiresharedservices.gov.uk> ---
Still valid.

Being able to revert an item level hold to a global hold would be excellent.

We only allow patrons to make global holds, so patrons waiting for specific
items (which are now on loan) when they could've had one of the other copies is
not ideal.

It also impacts the patron who checked out the item, as they have to return it
after one circ period, and cannot renew.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 11:34:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 09:34:55 +0000
Subject: [Koha-bugs] [Bug 7088] cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-HCYpModAz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #10 from Sally Healey <sally.healey at cheshiresharedservices.gov.uk> ---
This would be a nice feature to add to Koha.

As it's an enhancement, I think it's worth asking:  could we also consider a
system preference to have a different circ period if the item is required by
another patron?

For instance, standard circ period is 21 days.  
Item is on hold - renewal only gives a new circ period of 7 days.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 11:52:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 09:52:32 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-LHVGaQ2VIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
Hi Nicholas,

I tested and acces was restricted as expected (except printslip.pl, see below)

QA-Tools complain:

 FAIL   opac/sco/help.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 34)
                forbidden pattern: tab char (line 35)

 FAIL   opac/sco/printslip.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 39)
                forbidden pattern: tab char (line 40)

   FAIL   valid
                Global symbol "$query" requires explicit package name 
                opac/sco/printslip.pl had compilation errors.

 FAIL   opac/sco/sco-main.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 60)
                forbidden pattern: tab char (line 61)
                forbidden pattern: tab char (line 62)

 FAIL   opac/sco/sco-patron-image.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 40)
                forbidden pattern: tab char (line 39)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 12:28:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 10:28:28 +0000
Subject: [Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import
	breaks in Plack
In-Reply-To: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15032-70-EQ0eBc7X1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 12:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 10:40:27 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-46JmLnbGlB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #38 from Mirko Tietgen <mirko at abunchofthings.net> ---
Can this go to Passed QA then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 13:13:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 11:13:49 +0000
Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when
	TransformHtmlToMarc
In-Reply-To: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16370-70-E4EoKovXl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> Create a framework that doesn't include the 000 in the editor (set to ignore)
> alternatively, import the attached framework.

Hmm. Isn't this kind of a strange use case?

I have doubts on correcting the problem in TransformHtmlToMarc.
Currently, the marc21 leader plugin forces the leader position to Unicode. But
what if you edit the leader manually? (Just as strange as ignoring the leader.)

And what are the implications for UNIMARC? Note that the encoding for that is
not in the leader but in field 100.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 13:28:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 11:28:06 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-kGbJ6TA09M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54508|0                           |1
        is obsolete|                            |

--- Comment #6 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54561&action=edit
Bug 17008: Add "swaggerize" for Koha::Object and Koha::Objects

This patch adds new subroutine "swaggerize" for Koha::Object and Koha::Objects.

By matching column data types with corresponding Swagger data type, we can e.g.
numify values in order to be able to return borrowernumber:123 instead of
borrowernumber:"123".

Before this patch, we usually returned an unblessed representation of the
Koha-object in controller by calling e.g.
  $c->$cb($patron->unblessed, 200);

This would cause the returned JSON to have { "borrowernumber": "123" ... }, or
in other words everything as strings (apart from undefs, which would be null).

Now, we also return an unblessed representation of the Koha-object, but where
numbers are actually numified simply by calling e.g.
  $c->$cb($patron->swaggerize, 200);

Here our returned JSON will have { "borrowernumber": 123 ... } in "integer"
data
type of Swagger, as well as every other column that is defined to be an
integer.
Decimals, doubles and floats should have "number" data type and will also be
numified for the returned JSON.

To test:
1. Apply this patch and run t/db_dependent/Koha/Util/Swagger.t
2. Apply REST of the patches and follow their test plan for seeing how this
   works in practice

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 13:28:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 11:28:25 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-o2AMZwiYeV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54510|0                           |1
        is obsolete|                            |

--- Comment #7 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54562&action=edit
Bug 17008: Fix current data types

This patch changes current Swagger definitions for patrons and holds to have
data types corresponding to column data types in their database tables.

To test:
1. GET http://yourlibrary/api/v1/patrons/YYY where YYY is existing
borrowernumber
2. Observe that numbers / integers are in string data type.
3. Apply this patch.
4. Repeat step 1.
5. Observe that numbers / integers are now actually numbers / integers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 13:28:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 11:28:37 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-nMoEZxHc5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54509|0                           |1
        is obsolete|                            |

--- Comment #8 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54563&action=edit
Bug 17008: Test to compare Swagger property types against column data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type by using Koha::Util::Swagger::column_type_to_swagger_type().

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/definitions/patron.json cardnumber to be type "integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:00:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:00:54 +0000
Subject: [Koha-bugs] [Bug 17144] New: Can't call method "param" on an
 undefined value at /home/ marc/koha/admin/edi_accounts.pl line 157
Message-ID: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

            Bug ID: 17144
           Summary: Can't call method "param" on an undefined value at
                    /home/marc/koha/admin/edi_accounts.pl line 157
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To reproduce:
- In Staff client, go to Administration > EDI accounts
- Click "+ New account"
Result: Internal Server Error
Plack error log says: 
Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:18:16 +0000
Subject: [Koha-bugs] [Bug 17144] Can't call method "param" on an undefined
 value at /home/marc/ koha/admin/edi_accounts.pl line 157
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-s2o5liV050@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:19:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:19:13 +0000
Subject: [Koha-bugs] [Bug 17144] Can't call method "param" on an undefined
 value at /home/marc/ koha/admin/edi_accounts.pl line 157
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-TFZgPRglUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54564&action=edit
Bug 17144: Fix variable scope issues in edi_account.pl

To reproduce:
- In Staff client, go to Administration > EDI accounts
- Click "+ New account"
Result: Internal Server Error
Plack error log says:
Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157

To test:
-Apply patch
- Add an EDI account
- Edit an EDI account
- Delete an EDI account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:20:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:20:38 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-HzfMXL8EuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff
            Summary|Can't call method "param"   |Fix variable scope issue in
                   |on an undefined value at    |edi_accounts.pl
                   |/home/marc/koha/admin/edi_a |
                   |ccounts.pl line 157         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:28:08 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-aapimpiMlK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54565&action=edit
Bug 17140: Fix rounding in total fines calculations, part 2

This patch fixes still occuring issue with total fines calculations.

To test:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Run t/db_dependent/Members.t
7. Observe failure in a test case
8. Apply patch.
7. Repeat step 3 and 4
8. Observe that payment goes through
9. Run t/db_dependent/Members.t
10. Observe test passing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:28:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:28:25 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-q3KKLfLlTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:29:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:29:28 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-lgnDm674Zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54565|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54566&action=edit
Bug 17140: Fix rounding in total fines calculations, part 2

This patch fixes still occuring issue with total fines calculations.

To test:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Run t/db_dependent/Members.t
7. Observe failure in a test case
8. Apply patch.
9. Repeat step 3 and 4
10. Observe that payment goes through
11. Run t/db_dependent/Members.t
12. Observe test passing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:32:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:32:51 +0000
Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume
 individual holds from the patron holds table
In-Reply-To: <bug-14310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14310-70-OswMad6jmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:36:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:36:31 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-0mkYP3BuLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:43:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:43:43 +0000
Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date
 doesn't do anything, date last seen always defaults to current date.
In-Reply-To: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16834-70-HTcskraHke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 14:58:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 12:58:59 +0000
Subject: [Koha-bugs] [Bug 17145] New: Cannot upload .mrc file for staging
	Marc records
Message-ID: <bug-17145-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17145

            Bug ID: 17145
           Summary: Cannot upload .mrc file for staging Marc records
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: gmcharlt at gmail.com
          Reporter: vermeir_bram at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

Today I upgraded the koha installation from 3.20.05 to 16.05.02
All seems to work just fine, except for the uploading of a mrc file for
staging.

Errormessage:
Upload failed -- unable to store file on server

I checked the Koha logs and found this
script not found or unable to stat:
/usr/share/koha/intranet/cgi-bin/tools/upload-file-progress.pl

I checked the location and indeed the upload-file-progress.pl file is missing.
I downloaded the file and uploaded it to the correct folder

Next errormessage:
AH01215: (2)No such file or directory: exec of
'/usr/share/koha/intranet/cgi-bin/tools/upload-file-progress.pl

The uploads directory has the correct rights and is located in
/var/lib/koha/biblio/uploads


can someone please help me out?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:00:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:00:55 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-OpZGhiSEQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 54567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54567&action=edit
Button Create EDIFACT order still appears

If syspref "Edifact" is disabled but the vendor has an Edifact account, the
button "Create EDIFACT order" still displays.
I would expect that it does no longer appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:20:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:20:33 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-4LNuk2UxfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
I can reproduce the error with a tweaked URL:

http://192.168.1.29:8080/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=50123&itemnumber=22&searchid=#edititem

...where biblionumber 50123 does not exist

Result:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:39:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:39:03 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-PcDZd4039g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #10)
> so HTTP_X_FORWARDED_FOR and REMOTE_ADDR have the right values. Are you
> implying that Mojo is messing with ENV?

ENV is correctly set if you hit mainpage, but not /api/*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:41:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:41:32 +0000
Subject: [Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed
In-Reply-To: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17037-70-KrJGMBbZEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You should use the mailing list for this kind of questions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:41:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:41:58 +0000
Subject: [Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed
In-Reply-To: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17037-70-rWMHLC7LGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:48:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:48:49 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-4DOB5Ps4j4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think we should remove the * 1000 / 1000

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:49:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:49:07 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-xXITt0ACoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:55:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:55:44 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-Jt2Z1KljfC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54537|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 54568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54568&action=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:56:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:56:11 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-h8Dmd5K3tz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:57:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:57:05 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-hTygisE6co@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53737|0                           |1
        is obsolete|                            |
  Attachment #53738|0                           |1
        is obsolete|                            |

--- Comment #12 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 54569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54569&action=edit
Bug 16942 - Confirm hold results in ugly error

Confirming a hold to set it to waiting will result in an DBIC error in
master.

Test Plan:
1) Attempt to check in an item on hold and confirm the hold
2) Note the error
3) Apply this patch
4) Repeat step 1
5) Note there is no error!

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

https://bugs.koha-community.org/show_bug.cgi?id=14942

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 15:57:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 13:57:14 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-JXk9DipWCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #13 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 54570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54570&action=edit
Bug 16942 [QA Followup] - Add unit test

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 16:00:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 14:00:00 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-fbgw0tZzNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 16:02:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 14:02:41 +0000
Subject: [Koha-bugs] [Bug 14251] style discharge letter
In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14251-70-vAmOEGNnvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 16:22:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 14:22:04 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-HBY2qc9q5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 16:23:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 14:23:51 +0000
Subject: [Koha-bugs] [Bug 17143] Popup Notification for
	decreaseloanhighholds preference
In-Reply-To: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17143-70-DlSNrsuiBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
This is an annoyance and is confusing to staff.  We may even be seeing some
shorter period loans getting hit by this message, but I have yet to get my
hands on examples.  Just word of mouth right now.  But we are definitely seeing
the popup with equal loan periods.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 16:24:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 14:24:35 +0000
Subject: [Koha-bugs] [Bug 17143] Popup Notification for
	decreaseloanhighholds preference
In-Reply-To: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17143-70-s9LMbkMfSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:04:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:04:12 +0000
Subject: [Koha-bugs] [Bug 17147] New: Streamline messages following batch
 record modification
Message-ID: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

            Bug ID: 17147
           Summary: Streamline messages following batch record
                    modification
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

After completing a batch record modification, a separate message dialog is
displayed for each record which was modified. If you modify 500 records at a
time this can result in a very long page. I think it would be better to display
messages in a more compact way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:10:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:10:04 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-Px6so5TPOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54572&action=edit
Bug 17147 - Streamline messages following batch record modification

This patch changes the display of informational messages during and
after the batch record modification process. Instead of showing a
separate dialog for each record modified, messages are now grouped into
one dialog.

To test, apply the patch and clear your browser cache if necessary. You
must have at least one MARC modification template defined.

- Go to Tools -> Batch record modification.
- Submit a list of biblionumbers which contains at least one number
  which doesn't exist in your database.
- Confirm that warning and success messages are grouped instead of
  showing in separate dialogs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:10:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:10:00 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-XLpj6LG6tF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:13:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:13:07 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-cjVsbnvrbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:17:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:17:36 +0000
Subject: [Koha-bugs] [Bug 17148] New: Add floating toolbar for tabs on
 cataloging interface
Message-ID: <bug-17148-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17148

            Bug ID: 17148
           Summary: Add floating toolbar for tabs on cataloging interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 54573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54573&action=edit
add floating toolbar for tabs

Hi,

It would be nice if tabs are add in floating toolbar like buttons.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:18:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:18:04 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-3L0oLznTzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:18:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:18:06 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-A1S3dOaDTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54574&action=edit
Bug 13949 - Item search should have holding library

This patch adds holding library ("current location") to the list of
fields available in the item search form.

To test, apply the patch and go to Search -> Item search.

- Perform a search using the "current location" option and verify that
  it returns the correct results.
- Try other searches to confirm that they work as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:37:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:37:33 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-bGIDnGkV4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
> % git fetch origin
> % git reset --hard origin/master
> % git clean -f -d
> %  prove t/db_dependent/Letters/TemplateToolkit.t
> t/db_dependent/Letters/TemplateToolkit.t .. ok     
> All tests successful.
> Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
> csys =  2.94 CPU)
> Result: PASS
> 
> What I meant is that the test 'Hold object used correctly' successes when we
> are expecting it to fail.

Are you applying the "Bug 16942 [QA Followup] - Add unit test" patch to master
before running the tests? If you apply that patch, the test should fail. Then,
if you apply "Bug 16942 - Confirm hold results in ugly error" the test should
pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:38:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:38:08 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-KCDH08r0mq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137
                 CC|                            |kyle at bywatersolutions.com
         Depends on|17137                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:38:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:38:08 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-oASxhkKLgd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16615                       |
         Depends on|                            |16615


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615
[Bug 16615] OpenLibrary: always use SSL when referencing external resources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:39:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:39:47 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-X0COPAV1Z4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Oliver, Mark and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:39:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:39:53 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-7JP3nB3qyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:42:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:42:50 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-4UvZalB5vR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:43:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:43:49 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-FTKxl56fIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:43:52 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-QUKK7aSxYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54575&action=edit
Bug 17006: Add API route for changing patron's password

PATCH /patrons/{borrowernumber}/password (change password)

Required body params:
- current_password
- new_password

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
   that errors are displayed appropriately.

You may find this useful for testing:

curl -X PATCH http://library/api/v1/patrons/123/password
     --data '{"current_password":"123456", "new_password":"1234"}'
     --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:45:44 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-Zdyuh3S7Nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:45:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:45:52 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-e0K415mcKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:47:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:47:09 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-vBWVHBj299@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Items.t fails if SearchEngine is set to Elastic:

prove t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Items.t .. 1/5  problem with :564 : :1: parser error :
Start tag expected, '<' not found
tAw
^

tAw at /home/vagrant/kohaclone/C4/Biblio.pm line 1339.
    # Looks like you planned 3 tests but ran 1.
Can't call method "field" on an undefined value at
/home/vagrant/kohaclone/Koha/ElasticSearch/Indexer.pm line 180.
# Looks like your test exited with 255 just after 4.
t/db_dependent/Koha/Items.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/5 subtests

Test Summary Report
-------------------
t/db_dependent/Koha/Items.t (Wstat: 65280 Tests: 4 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 5 tests but ran 4.
Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.30 cusr  0.13
csys =  1.45 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:49:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:49:06 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-ClYUM44Gdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:56:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:56:56 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-DusLc6jjWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:58:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:58:32 +0000
Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date
 doesn't do anything, date last seen always defaults to current date.
In-Reply-To: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16834-70-iFMWp0Wq59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #7)
> Yes it does

Confirmed!

So I found what is the problem, but no idea how to fix it:
inventory.pl calls ModItem and update datelastseen (l.210), but a call to
ModDateLastSeen is done later (l.332). ModDateLastSeen does not accept any
parameters and update datelastseen with the today's date.

My supposition is that bug 14001 introduced this bug by trying to fix something
else.
Maybe we could just remove the call to ModDateLastSeen and handle $moddatecount
somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 17:59:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 15:59:48 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-6Ned0NANkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jacek!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:01:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:01:02 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-6C9uiAk0V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Adding new category in      |Require some fields when
                   |authorized values           |adding authorized value
                   |                            |category

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:01:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:01:18 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-xr18t3KI2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54576&action=edit
Bug 17006: Respect system preference "OpacPasswordChange"

Allow patron to change their own password without borrowers-flag only
if OpacPasswordChange system preference is enabled.

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Set OpacPasswordChange system preference to "Don't allow".
4. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber for a borrower that does not
   have any permissions
5. Observe permission error.
6. Set OpacPasswordChange system preference to "Allow".
7. Repeat step 4 and make sure that password was changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:02:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:02:44 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-coY20e2yMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:03:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:03:35 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-S204Th3V5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #14)
> > % git fetch origin
> > % git reset --hard origin/master
> > % git clean -f -d
> > %  prove t/db_dependent/Letters/TemplateToolkit.t
> > t/db_dependent/Letters/TemplateToolkit.t .. ok     
> > All tests successful.
> > Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
> > csys =  2.94 CPU)
> > Result: PASS
> > 
> > What I meant is that the test 'Hold object used correctly' successes when we
> > are expecting it to fail.
> 
> Are you applying the "Bug 16942 [QA Followup] - Add unit test" patch to
> master before running the tests? If you apply that patch, the test should
> fail. Then, if you apply "Bug 16942 - Confirm hold results in ugly error"
> the test should pass.

I completely understood that.

So maybe you should explain me why the following test pass:

180 $prepared_letter = GetPreparedLetter(
181     (
182         module      => 'test',
183         letter_code => 'TEST_HOLD',
184         tables      => { 
185             reserves => [ $patron->{borrowernumber}, $biblio->id() ]
186         },
187     )
188 );
189 is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
)

What does reserves => { $borrowernumber, $biblionumber } mean?
How do you know that $borrowernumber is a borrowernumber?
It looks like something magic and to me it should not work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:04:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:04:07 +0000
Subject: [Koha-bugs] [Bug 17095] Regression: Error when checking out to
 non-existent patron
In-Reply-To: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17095-70-yF94thR3vD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:06:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:06:07 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-9B5emW2cqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:08:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:08:24 +0000
Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
In-Reply-To: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16991-70-N82l8NuZnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm sorry to ask this, but could you update your patch to use
Koha::Biblio->subtitles to get this list of subtitles? That way we aren't
duplicating logic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:09:17 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-KSbssoF2Pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:09:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:09:19 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-rMGxAvRcZp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22110|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54577&action=edit
Bug 11019 - Require some fields when adding authorized value category

This patch modifies the form for adding an authorized value so that
category, authorized value, and description are required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in category, authorized value,
  or description. You should be prevented from submitting the form.
- Verify that filling in the required fields allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:09:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:09:58 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-4iYPvNP6RM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|amitddng135 at gmail.com       |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:10:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:10:56 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-bsiIB5ASnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
That is sufficient to me! Pushed to master for 16.11!

(In reply to Galen Charlton from comment #7)
> (In reply to Kyle M Hall from comment #6)
> > Would it not be simpler to pass the parameter timeformat => '24hr' to
> > output_pref instead of using an external lib?
> 
> I note that output_pref(), if we were to take its name literally, is for
> formatting date and time *output*. DateTime::Format::MySQL is already used
> in other places and its name makes it clear that a DateTime passed through
> is meant to be fed to an SQL query.
> 
> I think it better that we keep the concerns of formatting timestamps for
> human display separate from formatting them for computer consumption.
> 
> I am reseting the status of this bug back to "Passed QA".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:11:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:11:19 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-0lIFMUik0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:12:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:12:19 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-guMHGnPFdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:12:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:12:21 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-4lpaT8L9I4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54578&action=edit
Bug 14876 - (QA Followup) Fix pod

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:14:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:14:30 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-bXN6B7rCne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:17:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:17:16 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-YaKPeE138w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:17:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:17:47 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-MNPEdfyi3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:19:28 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-CTJgekwSMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #4)
> 2/ Since this plugin is only used once, why did you choose to use a TT
> plugin?

If we don't use this we'd have to iterate through the search results and counts
the holds for each before display, this way we only check for those that are
being currently shown.

We could also alter detail.tt to use this function

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:32:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:32:09 +0000
Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds
	tab
In-Reply-To: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16686-70-bgGWwHPTMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Found the bug, unrelated. Fixed on followup to bug 16272.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:36:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:36:05 +0000
Subject: [Koha-bugs] [Bug 15268] Patron search differs between 'Check out'
 search and 'Patron' search on two-word surnames like 'St. Claire'
In-Reply-To: <bug-15268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15268-70-CPH6FJdl2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master. Barton could you re-test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:37:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:37:05 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-I4X6LmgL9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54579&action=edit
Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:37:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:37:20 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-U4cjJ1DgyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54579|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54580&action=edit
Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 18:46:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 16:46:26 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-zjpCegEfMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Kyle M Hall from comment #9)
> Thanks Olli! That is most excellent info! Would you be willing to write a
> proof of concept? If you can put that up, I'd be more than happy to do the
> grunt work of handling all the SIP server logging calls.

Ping! Olli ^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 19:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 17:07:02 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-2hS9bRwU5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #6)
> (In reply to Jonathan Druart from comment #4)
> > 2/ Since this plugin is only used once, why did you choose to use a TT
> > plugin?
> 
> If we don't use this we'd have to iterate through the search results and
> counts the holds for each before display, this way we only check for those
> that are being currently shown.

I am not sure I am following you, the results returned by searchResults are
always displayed, isn't?

Since we already iterate in catalogue/search.pl it's not a big deal to do this
job over there. I don't think it's the job of a plugin to calculate the number
of holds for a given record.

Feel free to ask for another QA point of view ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 19:07:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 17:07:13 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-Y4ERamcUC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 19:13:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 17:13:37 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-ienctWz1lT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 19:13:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 17:13:40 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-YNrrUTBynP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54581&action=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:15:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:15:13 +0000
Subject: [Koha-bugs] [Bug 15268] Patron search differs between 'Check out'
 search and 'Patron' search on two-word surnames like 'St. Claire'
In-Reply-To: <bug-15268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15268-70-K42300Ffkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
This was caused by the "Starts With" vs. "Contains" user search -- Bug 15930.
That bug is closed, and I'm marking this one as a duplicate.

*** This bug has been marked as a duplicate of bug 15930 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:15:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:15:13 +0000
Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to
 'starts_with' and not getting correct parameters to parse multiple word
 searches
In-Reply-To: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15930-70-oiQftQJ44n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #18 from Barton Chittenden <barton at bywatersolutions.com> ---
*** Bug 15268 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:28:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:28:00 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-WWyeLDp03t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54581|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54582&action=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:28:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:28:13 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-gTTLs4S18g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:38:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:38:58 +0000
Subject: [Koha-bugs] [Bug 17149] New: EDI accounts: Add missing '>' to
	breadcrumb
Message-ID: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

            Bug ID: 17149
           Summary: EDI accounts: Add missing '>' to breadcrumb
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Breadcrumb on "EDI accounts" pages reads 
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:43:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:43:18 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-yKKZNmU3R7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:45:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:45:33 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-gYvsyTKEAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 54583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54583&action=edit
Bug 17149 - EDI accounts: Add missing '>' to breadcrumb

To verify:
Breadcrumb on "EDI accounts" pages reads
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

To test:
- Apply patch
- Add, edit and delete an EDI account
- Verify that breadcrumb displays properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:45:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:45:57 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-ItCPW4XIjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:48:04 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-9wOzQDnXWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17144

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Note: Maybe you need first to apply Bug 17144 to be able to test the pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 20:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 18:48:04 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-fU9CstszPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17149

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 21:28:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 19:28:41 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-ocriVi4lZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
To reproduce without tweaking the URL (can happen to users):

- Edit an item
- Save
- You are on .../cgi-bin/koha/cataloguing/additem.pl
- In header menu, right-click on any menu item, in context menu choose "Open
link in new tab"
Result: New tab opens, "Internal Server Error", URL is
.../cgi-bin/koha/cataloguing/additem.pl#

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 18 22:11:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 20:11:24 +0000
Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to
 Default framework
In-Reply-To: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16424-70-8ab3rd8Yi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:21:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:21:17 +0000
Subject: [Koha-bugs] [Bug 17150] New: Cancelling holds over process needs
	improvement
Message-ID: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

            Bug ID: 17150
           Summary: Cancelling holds over process needs improvement
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 54584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54584&action=edit
Cancel Hold buttons

I'm not seeing a bug with all of this spelled out exactly, so if I repeat
something already posted, I'm sorry.  It may be that some of this needs to be
broken into different bugs, or is already addressed in another bug.  I am
linking together what I know to be part of the problem, but not the whole
picture.

Cancelling a hold that is over is a tedious process at best.  I'll try to
explain what we are seeing.

So, when we go to the Holds over tab in the Holds awaiting pickup, we find the
item.

Issue #1 (holds01.png): Even though the buttons are different, they don't act
different, they are not even necessarily accurate about the item, and they have
lost functionality between 3.18 to 3.22.

Issue #2:  Even though a transfer might be triggered, you have to check the
item in to get the slip.  Waste of time.  It should come up with this choice
when the transfer is triggered while cancelling (holds04.png).

Issue #3:  Even though the item might have another hold request, it isn't
revealed when you cancel the hold.  So, you have to check EVERYTHING in that
you cancelled to see if there is a hold, or a pending transfer.  Again, this
should happen when cancelling the hold.

Issue #4: As mentioned in issue #1, the buttons are not very accurate about
what happens next with the item.  Sometimes there is a hold request at the
current location (holds05.png).  So, you have to check ALL of these items in to
find out if they have holds.  Again, this should happen when cancelling the
hold.

Issue #5: Even though there is a hold request for an item you are cancelling,
cancelling the hold applies a transfer.  So, when you check the item in after
cancelling, you see a transfer to the item's home location AND the hold request
(holds06.png).  This is CONFUSING and crazy.  Especially if it is to the same
location.  We end up having to cancel the hold, check the item in, cancel the
transfer, check the item in again, and then trigger the hold.  Why not just
skip cancelling the transfer and trigger the hold?  Because the transfer will
still be in the system!  Crazy!

Issue #6: When you cancel a hold, you get bounced back to the Holds waiting
tab, so you have to click back over to the Holds over tab for the next item.  I
think there is another bug on this one, but I can't find it at the moment.

So, why don't we just use the Cancel All button (by the way, shouldn't it read
"Cancel all")?  Because not all the items are still in our hands.  Some items
end up walking out without being checked out.

Issue #7: It would be great if there were a button to mark the item missing, or
maybe someone calls and finds out the person has the item, so a button to check
the item out to that patron would be great.

Issue #8: I've noticed another little quirk.  If you compare holds04.png with
holds06.png, you'll see that the transfer popups are different.  holds04.png
has no buttons.  Just links.  I know that one transfer is related to the hold,
which doesn't make sense because when we cancel it, it doesn't affect the hold.

Issue #9: You may also notice on holds06.png, the address fits on the full line
in the transfer popup, but not in the holds popup.  The popup boxes are the
same size, and the bullets offset in the same place, so something is off on the
formatting.

Issue #10: Cancelling a hold takes 2 to 3 times longer in 3.22 than it did in
3.18.  This is surprising since the popups were taken away!

So, ideally, if these are legitimate issues, and are addressed, this is what we
would expect to see:

1: Just show a Cancel button for all items with the words "Cancel hold".  What
happens when you click the button should be self explanatory.  Perhaps if Koha
didn't have to determine the next status of the item just to create a button,
the refresh of the page would improve.  Hmmmmm....
2: When you cancel a hold, if the item needs to go home, it will show the
transfer popup to let you print the slip.
3: When you cancel a hold, if the item has a hold, it doesn't trigger a
transfer, and only shows the hold popup, whether it is a local hold or going
somewhere else.
4: Whether it has a popup or not, when done with the popup it should put you
back on the same tab you were last on.
5: Buttons should be on the transfer popup.
6: Formatting should be consistent between the hold and transfer popups (I
know, this is sooooo trivial).
7: We should have more options for holds that are over, than just Cancel, since
there are other things that can be happening, like missing or already with the
patron.  A "Mark missing" button and a "Checkout to this patron" button would
be nice.

Sorry if this sounds like a rant.  I know that how we do things isn't the way
everyone does things, but this has bugged me for a LONG time, and I think these
are some great improvements, even if they need to be tweaked a bit to
accommodate other workflows.  I will add the screens and see alsos in a moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:21:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:21:49 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-dG723MNw1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 54585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54585&action=edit
Transfer Popup

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:22:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:22:09 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-Q05uzWPf8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 54586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54586&action=edit
Hold Popup

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:22:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:22:40 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-P5YKgTjdLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 54587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54587&action=edit
Transfer and hold popups

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:02 +0000
Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for
 processing transfers
In-Reply-To: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8451-70-c4ApJpXRXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:02 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-SqH5QVRGXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8451

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:22 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-E1MiqhJ8pa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8292

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:22 +0000
Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
In-Reply-To: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8292-70-azOETFCZz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:36 +0000
Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs
	improvement
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-v7gWBBWPJC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9322

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 01:23:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 18 Aug 2016 23:23:36 +0000
Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from
 circ/branchtransfers.pl), completing one completes them all
In-Reply-To: <bug-9322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9322-70-0rJu6jTqGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 03:03:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 01:03:05 +0000
Subject: [Koha-bugs] [Bug 17151] New: Extended patron attributes not
 importing when using double quotes
Message-ID: <bug-17151-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17151

            Bug ID: 17151
           Summary: Extended patron attributes not importing when using
                    double quotes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: danielle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Patron import tool directions on Patron Import Tool Page states:
_____________

   Example 2: STARTDATE:January 1 2010,TRACK:Day

If an input record has more than one attribute, the fields should either be
entered as an unquoted string (previous examples), or with each field wrapped
in separate double quotes and delimited by a comma:

    Example 3: "STARTDATE:January 1, 2010","TRACK:Day"

The second syntax would be required if the data might have a comma in it, like
a date string.
____________

Only the second example works "STARTDATE:January 1 2010,TRACK:Day"

The double quotes import does not work. Loading the patron will fail with a
"Line 2 could not be parsed!" error. 

Partners of BWS are also reporting this same behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 07:52:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 05:52:36 +0000
Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for
 processing transfers
In-Reply-To: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8451-70-2uQm3sSG1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:09:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:09:54 +0000
Subject: [Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call
 to fetch content
In-Reply-To: <bug-16641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16641-70-2pjajkFuY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
   Patch complexity|Trivial patch               |Small patch

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Any test credentials available to test this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:14:44 +0000
Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl
In-Reply-To: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15538-70-Nyk3yN7G6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |In Discussion

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Do we really want to replace verbose options in cmdline scripts by logger
calls?
The first comment speaks about debug prints, but you are removing the verbose
option too.
I would like to see some more consensus about doing so. Maybe ask the dev list?

In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:19:22 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-Iyc4eP1jCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hm Not sure if you are improving the code here. Wasn't it possible to move a
lot of this code to some module shared by both scripts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:22:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:22:03 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-QZhSa4kdu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:31:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:31:59 +0000
Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for
 processing transfers
In-Reply-To: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8451-70-1hcmcIjUeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17101
             Status|Failed QA                   |In Discussion

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Bug 17101 as well raises the question about multiple prompts while checking in.

I think it is an architectural question that needs a separate bug.

Setting to "In Discussion"

(See comment #10)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:31:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:31:59 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-5P3o92pEaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8451

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:35:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:35:48 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-zcrK43Y6Pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:37:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:37:34 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-q8P1tvikWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Added Bug 8451 as related ("Confusing and problematic double prompt for
processing transfers")

Setting to "In Discussion" because the whole check in process needs
clarification.
See:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451#c10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:45:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:45:47 +0000
Subject: [Koha-bugs] [Bug 17104] svc/checkin does not use
	UpdateNotForLoanStatusOnCheckin
In-Reply-To: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17104-70-mun5UK2jUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:53:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:53:42 +0000
Subject: [Koha-bugs] [Bug 16956] Inserting null borrowernumber value in
 statistics table while book is checkin if book is not checkedout
In-Reply-To: <bug-16956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16956-70-iMp3VyIDKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16956

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:56:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:56:45 +0000
Subject: [Koha-bugs] [Bug 13945] Multiple dialogs for item that needs
 transferred and hold captured at checkin
In-Reply-To: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13945-70-bU9mGiJtjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8451

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:56:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:56:45 +0000
Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for
 processing transfers
In-Reply-To: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8451-70-EXiFKQDYdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13945

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:57:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:57:09 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-HYlRXC5z2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13945

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:57:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:57:09 +0000
Subject: [Koha-bugs] [Bug 13945] Multiple dialogs for item that needs
 transferred and hold captured at checkin
In-Reply-To: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13945-70-N5P6C65ORj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17101

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 08:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 06:58:20 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16933-70-YXZCVFsStx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:12:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:12:08 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-6g9gcvmf18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16884

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:12:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:12:08 +0000
Subject: [Koha-bugs] [Bug 16884] Branch transfer dialog does not appear for
 check-ins on check-out screen
In-Reply-To: <bug-16884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16884-70-Av2sIYIkPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16884

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17101

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
The same problem will also occur e.g. with Bug 17101

I think the handling should be similar as if an item is reserved for an other
patron (not possible to check in here, marked as 'On hold' in column 'Check
in').

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:21:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:21:40 +0000
Subject: [Koha-bugs] [Bug 11992] detail.pl display issue after item on hold
 & in transit is checked in
In-Reply-To: <bug-11992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11992-70-mbPjRVw6sM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11992

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:22:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:22:59 +0000
Subject: [Koha-bugs] [Bug 11991] "Item is already waiting" message after
 in-transit item on hold checked in
In-Reply-To: <bug-11991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11991-70-iWpcrDflNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:36:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:36:26 +0000
Subject: [Koha-bugs] [Bug 16491] Link barcodes in messages link to specific
 item during check in
In-Reply-To: <bug-16491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16491-70-XWiWPEuXLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16491

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:38:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:38:09 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-qanXIKJBmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #6)
> Hm Not sure if you are improving the code here. Wasn't it possible to move a
> lot of this code to some module shared by both scripts?

With this code this script will now follow the same pattern as other scripts.
So yes, I think it improves the code.
Everything is possible :) I did not want to add too much changes just for a var
scope problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:39:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:39:05 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-HQSZYDK2EM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51407|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54588&action=edit
Bug 16276: Update borrowers.lastseen when a patron is active

In order to add the ability to delete patrons who have been inactive for
more than a given time, we need to track down the last time they were
active.
To do that, we need a new DB column in the borrowers table (lastseen).
Note that the borrowers.lastseen column will not be initialised for existing
installations (set to NULL) so inactive existing patrons will never be
deleted.
A workaround would be to init them at the date when the new column will
be added.

Test plan:
0/ Set the new pref TrackLastPatronActivity on
1/ Log in as a patron (staff or OPAC)
2/ Check that the borrowers.lastseen field has been updated with the
current time

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:39:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:39:11 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-K1vc3Au4GI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51408|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54589&action=edit
Bug 16276: Make delete_patrons.pl deal with --last_seen

This patch modify the delete_patrons.pl cronjob to deal with the
last_seen option.

To test it, you just have to use the --last_seen option and pass a valid
date (iso format)

Example:
  perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm
will delete all the patrons who do not have been active since this date.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:39:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:39:17 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-CMnfPK5KEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51409|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54590&action=edit
Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small change: number of tests in t/db_dependent/Members.t

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:39:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:39:20 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-omgypottX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51410|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54591&action=edit
Bug 16276: Make the batch patron deletion tool deal with last_seen

This patch adds the same change as the previous one to the batch patron
deletion tool.

If the pref TrackLastPatronActivity is enabled, the librarians will be
able to delete patrons who do not have been connected since a given
time.

Test plan:
Define a date for the "who have not been connected since" options and
confirm that it works as expected.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:39:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:39:26 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-3Meim4NTbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51412|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54592&action=edit
Bug 16276: Add a new pref TrackLastPatronActivity and new column
borrowers.lastseen

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:40:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:40:25 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-QqCijUMUMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch set does not include the DBIC schema changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:43:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:43:35 +0000
Subject: [Koha-bugs] [Bug 14822] Fine totals on circulation.pl don' t
 include manually added fees
In-Reply-To: <bug-14822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14822-70-PbIAK2ldcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:52:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:52:08 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-x8SMOxIT9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You won't believe it:
[Fri Aug 19 09:44:56 2016] [error] [client 82.173.53.17] [Fri Aug 19 09:44:56
2016] renew: Can't use string ("2144746608") as a HASH ref while "strict refs"
in use at /usr/share/koha/masterclone/C4/Overdues.pm line 508., referer:
https://master.rijkskoha.nl:28443/cgi-bin/koha/circ/circulation.pl?borrowernumber=1

UpdateFine is not called with a param hash. Just hope that this changed over
time while this patch was waiting for some attention..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:52:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:52:44 +0000
Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item
In-Reply-To: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15729-70-8qie6PfSwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 09:55:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 07:55:36 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-49GVj9AF3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #35 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #34)

> UpdateFine is not called with a param hash. Just hope that this changed over
> time while this patch was waiting for some attention..

It did.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:07:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:07:43 +0000
Subject: [Koha-bugs] [Bug 14892] Initial checkin of an item to be
 transferred shows incorrect holding location
In-Reply-To: <bug-14892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14892-70-MvW8EHzHoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14892

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:09:21 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-APbt9zMABz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:10:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:10:25 +0000
Subject: [Koha-bugs] [Bug 15488] Self-check module highlighting
In-Reply-To: <bug-15488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15488-70-xFVH2sv0oR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15488

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:11:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:11:14 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-wdG59NQSFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
marc, I do not recreate. On which link do you click?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:14:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:14:40 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14224-70-IwOEHimtTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:15:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:15:38 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-M3DmuUvalQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51627|0                           |1
        is obsolete|                            |

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54593&action=edit
Bug 14390 - Fine not updated from 'FU' to 'F' on renewal

Test Plan:
1) Find an overdue checkout with a fine
2) Renew item, note fine is not closed out (Account type F)
3) Apply this patch
4) Find another overdue checkout with a fine
5) Renew item, note fine is now correctly closed out
6) Backdate a checkout to be already overdue ( but not have a fine since
    fines.pl hasn't run yet )
7) Renew item, note a closed out fine is created

Signed-off-by: Sean Minkel <sminkel at rcplib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:15:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:15:50 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-qDO4dVM36n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51628|0                           |1
        is obsolete|                            |

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54594&action=edit
Bug 14390 [QA Followup] - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:15:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:15:57 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-6C020eC0NQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51629|0                           |1
        is obsolete|                            |

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54595&action=edit
Bug 14390 [QA Followup] - Fix warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:16:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:16:10 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-2OhodXrnHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54596&action=edit
Bug 14390: [QA Follow-up] UpdateFine should be passed a hash

Renewing an overdue would not work.
Log shows:
renew: Can't use string ("2144746608") as a HASH ref while "strict refs" in use
at C4/Overdues.pm line 508., referer:
/cgi-bin/koha/circ/circulation.pl?borrowernumber=1

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:16:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:16:56 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-PQkLF9AIeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #35)
> (In reply to Marcel de Rooy from comment #34)
> 
> > UpdateFine is not called with a param hash. Just hope that this changed over
> > time while this patch was waiting for some attention..
> 
> It did.
That helps :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:17:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:17:19 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-3XVhvMBcnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still working on this. Please wait..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:18:32 +0000
Subject: [Koha-bugs] [Bug 17058] Automatic renewals broken when
 BorrowerRenewalPeriodBase is set to current day
In-Reply-To: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17058-70-23oe6e63nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Viccy Kemp from comment #0)
> Setting "BorrowerRenewalPeriodBase" to CURRENT DATE negates automatic
> renewal for all items.

Did you mean "RenewalPeriodBase" instead of "BorrowerRenewalPeriodBase"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:19:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:19:23 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-YnOc6CzCTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #42 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
UpdateFine() calling convention got changed in Bug 15675. Bug 15675 has some
other unpleasant side effects (see Bug 17135) which are not yet resolved, and
it looks like this report may be helpful for fixing Bug 17135 (?). IMO both
those reports desperately need some more attention - Bug 17135 is pretty nasty,
and stable / 16.05 is affected by it as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:20:31 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-LnPE5qAswe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17135

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:20:31 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-SuxyvqGZsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14390

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:34:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:34:13 +0000
Subject: [Koha-bugs] [Bug 17058] Automatic renewals broken when
 BorrowerRenewalPeriodBase is set to current day
In-Reply-To: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17058-70-6nxg8otwhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looks ok to me, could you please detail the steps to recreate the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:35:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:35:37 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-mqDGKQox5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I tested by creating an overdue, backdating it, ran fines, renewed it.
The fine is set to type F. That is ok.

But we are not ready yet. What will happen if it gets overdue again?
I backdated the due date and the last renewal date.
Ran fines again. And here comes the problem:
The accountline that has type F but still has the issue id(!), got updated with
the new amount and was set back to FU. (So: old fine got lost!) UpdateFine does
not respect the F type here; the issue id is leading.
Note that in this case the test ..amount<>..amount in UpdateFine may be
misleading too.

How to solve this? Can we remove the issue id in accountlines after switching
to F? Or should UpdateFine no longer update a F record although it has the
right issue id, but add a new record?

Please add a follow-up. This should be tested again. So reset to Needs Signoff.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:36:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:36:59 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-AxY5tPqOA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #42)
> UpdateFine() calling convention got changed in Bug 15675. Bug 15675 has some
> other unpleasant side effects (see Bug 17135) which are not yet resolved,
> and it looks like this report may be helpful for fixing Bug 17135 (?). IMO
> both those reports desperately need some more attention - Bug 17135 is
> pretty nasty, and stable / 16.05 is affected by it as well.

OK Our comments crossed each other. The new report describes it too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:38:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:38:07 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-Odvj0uWnpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:38:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:38:14 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-PwfIT37NDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 54597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54597&action=edit
Steps to get "Internal server error"

To reproduce:

- Add (not edit) a new item
- Right click e.g. on "Search" in the top menu bar
- Status line shows .../cgi-bin/koha/cataloguing/additem.pl#
- In context menu, choose "Open link in new tab"
Result: New tab opens with "Internal server error"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:39:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:39:10 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-BBKGA4GXsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
A fix on bug 14390 might address this too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:40:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:40:16 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-TFlXLHR8wu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:41:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:41:28 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-xDk2wicXCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
plack_error.log:
Can't call method "fields" on an undefined value at
/home/marc/koha/cataloguing/additem.pl line 742.
 at /home/marc/koha/circ/returns.pl line 34.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:46:01 +0000
Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in
In-Reply-To: <bug-15085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15085-70-P6KLMzIld5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17101
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:46:01 +0000
Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in
In-Reply-To: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17101-70-y6QbN2NubX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15085

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:47:23 +0000
Subject: [Koha-bugs] [Bug 5956] Highlight holds on check-in
In-Reply-To: <bug-5956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5956-70-SqSGjPrz8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:49:43 +0000
Subject: [Koha-bugs] [Bug 8073] Sound cue when checking in items on hold
In-Reply-To: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8073-70-RFh8DsWfDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:50:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:50:44 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
 use CT for return branch
In-Reply-To: <bug-12021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12021-70-oieTHKd6fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:51:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:51:36 +0000
Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message
	appears
In-Reply-To: <bug-14525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14525-70-jJBicxSEpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:53:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:53:29 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation:: AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-0c3n5VUM3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:56:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:56:42 +0000
Subject: [Koha-bugs] [Bug 10819] Allow for auto filling of holds when items
 are checked in via SCO
In-Reply-To: <bug-10819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10819-70-HyOfIYVNoD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10819

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 10:59:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 08:59:14 +0000
Subject: [Koha-bugs] [Bug 14460] Show library a book can be returned to/home
 library/ checkout library in patron account
In-Reply-To: <bug-14460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14460-70-3JY46DUzjw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14460

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:00:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:00:19 +0000
Subject: [Koha-bugs] [Bug 13847] Cannot download large reports as Open
 Office Spreadsheet ODS
In-Reply-To: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13847-70-oXBkrHVaP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8437
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We could use buffer, but it does not work under Plack (bug 8437).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:00:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:00:19 +0000
Subject: [Koha-bugs] [Bug 8437] Plack and database backup
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-4LyckX0Uv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13847

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:00:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:00:23 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-LGNLeQbQ1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #132 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Will continue with this in the next days.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:01:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:01:32 +0000
Subject: [Koha-bugs] [Bug 16744] new records not indexed if using a
 customize Koha Framework
In-Reply-To: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16744-70-KCBCRaartL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #6)
> Could you test on 16.05 and master please?
> This may be fixed by bug 16431.

ping?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:02:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:02:26 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-oeNSB5xyCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:04:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:04:25 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-nZveoNQxub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> How to solve this? Can we remove the issue id in accountlines after
> switching to F? Or should UpdateFine no longer update a F record although it
> has the right issue id, but add a new record?

I think it should add a new line as it's a 'new fine'. If we differentiate
between F and FU cleanly, we can keep the issue_id too, I think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:06:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:06:57 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-E4pTQpNCKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please also take a look at bug 17135 - glad this didn't go into stable yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:07:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:07:46 +0000
Subject: [Koha-bugs] [Bug 9157] Enhance inventory tool to skip checked out
	barcodes
In-Reply-To: <bug-9157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9157-70-ETeBt3egmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:08:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:08:29 +0000
Subject: [Koha-bugs] [Bug 13491] make Selfcheck follow the
	CircAutoPrintQuickSlip
In-Reply-To: <bug-13491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13491-70-IBCQsvBvch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:11:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:11:13 +0000
Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in
 transit results in duplicate dialogs upon check-in
In-Reply-To: <bug-4040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4040-70-tI2iMQJNwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8451

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:11:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:11:13 +0000
Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for
 processing transfers
In-Reply-To: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8451-70-B3pWxShyMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=4040

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:12:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:12:35 +0000
Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send
	empty file
In-Reply-To: <bug-9099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9099-70-Clr7qP9NVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:13:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:13:14 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-aGsTgHPiN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the cleanest way without losing information (issue_id) would be your
third option:

> - set fine type to 'F' on renewal, and ignore records of such type in the 
> matching code in UpdateFine()

As Marcel points out, Kyle had a go on fixing this on bug 14390, but it needs
more work now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:21:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:21:40 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-61iMcZAs3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When automatically deleting |When automatically deleting
                   |expired borrowers, make     |expired borrowers, make
                   |sure they didn't log them   |sure they didn't log in
                   |selves recently             |recently

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:23:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:23:45 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-MUNKbiZ3xX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

--- Comment #37 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #36)
> glad this didn't go into stable yet.

I was under the impression that it did (comment #30), stable == 16.05 right
now?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:25:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:25:09 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-mZUYeDwvi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You are correct - I got my versions confused :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:31:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:31:56 +0000
Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not
	clear
In-Reply-To: <bug-16726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16726-70-j75VuLSic4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note that you can use JS code to clean the search box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:33:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:33:19 +0000
Subject: [Koha-bugs] [Bug 7550] Self checkout should limit display of patron
 image to logged-in patron
In-Reply-To: <bug-7550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7550-70-KvXL4MsVnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:28 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-2Zch9tH9iz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46192|0                           |1
        is obsolete|                            |

--- Comment #62 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54598&action=edit
Bug 7679: circulation statistics wizard improvements

- Add patron branch to the list of possible rows, columns, and filters
- Add extended patron attributes to the list of possible rows, columns,
  and filters
- Allow to group period by hour
- Allow to translate filter names

NOTE: Removed signed off, since I believe I have dealt with the conflicts.
      Retesting required. Found some comments C4::Date that I missed.
      line prepatch 194/ postpatch 233 seems to be where the major
      conflict is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:34 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-tmrLg4U3vQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46193|0                           |1
        is obsolete|                            |

--- Comment #63 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54599&action=edit
Bug 7679: Followup: circulation statistics wizard improvements

Signed-off-by: Brendan <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:38 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-J7pli4JwOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46194|0                           |1
        is obsolete|                            |

--- Comment #64 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54600&action=edit
Bug 7679: Fix criteria display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:43 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-vB7u3uxyM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46195|0                           |1
        is obsolete|                            |

--- Comment #65 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54601&action=edit
Bug 7679: Group different case values in the same row/column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:48 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-qMR9ACN9gU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46196|0                           |1
        is obsolete|                            |

--- Comment #66 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54602&action=edit
Bug 7679: Fix several bugs in circulation statistics wizard

- Display values in NULL columns/rows
- Display columns/rows that contain values only in NULL rows/columns
- "To" filter in period row should be inclusive (YYYY-MM-DD should be
  YYYY-MM-DD 23:59:59)
- Make it possible to use only the "To" filter in period row (actually
  it results in DBI error (2 bind variables instead of 1))

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:52 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-Dw3WnjQ58z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46197|0                           |1
        is obsolete|                            |

--- Comment #67 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54603&action=edit
Bug 7679: Fix two SQL queries when using patron attributes

and remove some Perl warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:34:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:34:56 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-CvXfr1Vxvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46198|0                           |1
        is obsolete|                            |

--- Comment #68 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54604&action=edit
Bug 7679: Various fixes for circulation statistics wizard

- use SQL TRIM functions to avoid having '' and ' ' considered as
  different values
- use Text::Unaccent to remove accents from columns or rows values when
  accessing %table. This is required as MySQL consider as equals two
  strings that differ only by their accents when using GROUP BY clause.
- Exclude '' values from the list of columns or rows. Otherwise we could
  have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same
  values in their cells.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:35:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:35:01 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-tQRZlOzRrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46199|0                           |1
        is obsolete|                            |

--- Comment #69 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54605&action=edit
Bug 7679: Display all table headers (case and accent sensitive)

It appears that we can't assume that a lowercase word is equivalent to
the same word in uppercase (or a mix of lowercase and uppercase
letters). And this is also true about accented words.
So display all values even if they differ only by case or by their
accents.
This means that:
- "foobar" and "Foobar" will be in two separate rows/columns
- "Etudiant" and "?tudiant" (french) will be in two separate
  rows/columns too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:35:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:35:18 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-OIAoOil1To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #70 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:35:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:35:42 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-uxLqGUjLF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

--- Comment #39 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Had a look at 16.05.x branch on git to be sure, and yep, 16.05 is definitely
affected by Bug 17135 too. Would be good to fix this issue ASAP, before angry
mob of librarians shows up (with the pitchforks ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:36:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:36:14 +0000
Subject: [Koha-bugs] [Bug 9081] Opac news not output on check in and check
	out notices
In-Reply-To: <bug-9081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9081-70-KWXn75uJYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:37:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:37:23 +0000
Subject: [Koha-bugs] [Bug 11063] Add circulation message's patron when
 checkin items ( returns.pl)
In-Reply-To: <bug-11063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11063-70-qEUjojNtl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:38:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:38:32 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
 wrong branch should generate transfer slip
In-Reply-To: <bug-12043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12043-70-kq7BTrsyMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:39:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:39:41 +0000
Subject: [Koha-bugs] [Bug 13250] Slow checkins when patron is restricted
 indefinitely and checked-in item triggers a suspension in days
In-Reply-To: <bug-13250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13250-70-dvmu7XiBm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13250

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:40:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:40:42 +0000
Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in.
In-Reply-To: <bug-13033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13033-70-v7PWMmpTJU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:43:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:43:58 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-cve2KTM76m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #25 from Oliver Bock <oliver.bock at aei.mpg.de> ---
Sure, no problem. Hopefully my other tickets will also be processed soon...

One final question: is this going to be backported to 3.22 as well? We're still
on that release.

Thanks,
Oliver

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:45:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:45:21 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-V5dTFwhMWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's marked as a bug (not enh) so the RMaints will take a look at this and
decide.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:46:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:46:26 +0000
Subject: [Koha-bugs] [Bug 11079] Number of overdues days come while checkin
	the items
In-Reply-To: <bug-11079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11079-70-cOtPWRXbFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11079

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:50:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:50:05 +0000
Subject: [Koha-bugs] [Bug 16743] Datatables error when checking overdues in
	chrome
In-Reply-To: <bug-16743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16743-70-NxfXmFCMqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16743

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you confirm that you have correctly flush the browser's cache?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 11:52:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 09:52:39 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-ZgU4Aa0CQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #4 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #3)
> I think the cleanest way without losing information (issue_id) would be your
> third option:
> 
> > - set fine type to 'F' on renewal, and ignore records of such type in the 
> > matching code in UpdateFine()

That would work OK for the newly created fine records, but the ones existing in
the database may need some cleaning up. This F/FU/O/.. is a long standing
problem, and I'm a bit worried what kind of fine 'types' people may have in
their databases (probably all kinds imaginable); not sure if this approach
alone would be safe enough.

Removing issue_id on renewal would be a simplest way, question is if it's even
all that useful for closed fines? I wonder what happens with this field on
returns (when issue record is moved to old_issues).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:04:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:04:21 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-O0SOGymEhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
issue_id ... Hm, I think you could probably use it for statistics... finding
out about... not sure. Might be I just like things linked :)

I seem to remember that we talked about a clean-up script on some other bug
report that I can't locate right now. I'd love if we could clean this up once
and for all.

I think if we have F and FU and issue_id or no issue_id (what's with old issues
before the patch?) then we will have multiple ways to say the same thing
(accruing or not) and that could get quite confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:08:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:08:00 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-Fv0AdgaTkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44542|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54606&action=edit
Bug 14060: Remove readonly attributes on date inputs

In order to remove accessibility issues due to the readonly attributes
on date inputs, this patch will remove them and introduce a javascript
validation on them.

This patch is not perfect for some reason:
I didn't manage to force the user to select a valid date. One solution
would be to reopen the datepicker plugin until a valid date is inserted.
But it could be annoying for users (and for me: I did not manage to
implement this solution).
You will note that input is emptied if the date is not valid. This is a
quick and efficient solution to prevent submitting invalid date and make
Koha explodes. A proper solution would be to implement the check server
side send a friendly message to the user.

Test plan:
For all inputs, try an invalid and a valid date.
 1/ Debar a patron
 2/ On the checkout tables (circulation and moremember), add a renewal
due date (at the bottom of the tables)
 3/ On the checkout page, specify a due date
 4/ On the return page, specify a return date
 5/ On the invoice page (acquisition module), enter a shipment and
billing date
 6/ On the invoice search page (invoices.pl) use filters shipment and
billing dates
 7/ On the offline circ page, specify a due date
 8/ On the edit patron page (memberentry), add a debarment
 9/ On the reserve page (reserve/request.pl), use the date inputs to
suspend until a defined date
10/ Edit patrons in a batch (tools/modborrowers.pl) and use the
registration and expiry date inputs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:08:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:08:06 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-VXMCSL6Hga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44543|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54607&action=edit
Bug 14060: Add OnClose event on missing datepicker

The "suspend until" inputs (hold list on circ/circulation.pl and
members/moremember.pl) were not set in the same way.
The minDate option should be set for both (bug 10703 removed it for
circ/circulation.pl).
This patch reintroduces the option and add the OnClose event on both.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:08:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:08:12 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-ERtTdVr7U5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44544|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54608&action=edit
Bug 14060: Display the date format on the warning popup

The date format is now displayed on the warning popup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:08:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:08:16 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-GI7F9JiJXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45282|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54609&action=edit
Bug 14060: Force the input to contain a valid date

Before this patch, the user was still allowed to enter a valid date.
Now, if the date is not valid, the input is emptied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:08:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:08:21 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-bUDDztRR3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46224|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54610&action=edit
Bug 14060: Add support for dmydot

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:10:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:10:04 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-8mS9KFNcLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #25)
> I think this version should be push as it, and follow-ups could come later...

No discussion and what I proposed is the only suggestion, so I switch the
status back to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:14:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:14:06 +0000
Subject: [Koha-bugs] [Bug 16840] URLs for old releases are broken with every
	new release
In-Reply-To: <bug-16840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16840-70-QC7BloFC4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Jason,
I am CCing Tomas and Kyle as I have no idea who deals with the tarballs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:18:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:18:59 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to deleted a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-PO70h5pYpf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10869,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10758
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick,
There is already a big warning when you try to delete a record used in orders.
I do not understand why we should block the user to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:18:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:18:59 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-IXRGf6DdHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16872

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:18:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:18:59 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-nyBcXkjKix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16872

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:37:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:37:41 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-xE3MAVxxP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54566|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54611&action=edit
Bug 17140: Fix rounding in total fines calculations, part 2

This patch fixes still occuring rounding issue with total fines calculations.

To test:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Run t/db_dependent/Members.t
7. Observe failure in a test case
8. Apply patch.
9. Repeat step 3 and 4
10. Observe that payment goes through
11. Run t/db_dependent/Members.t
12. Observe test passing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:43:10 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-sGUyTia7fR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a side note:

L2921 GetMember call (always)
L2975 GetMemberDetails call ( RenewalSendNotice==1)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 12:45:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 10:45:16 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-RfvBYIR1Pr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #6 from Lari Taskula <larit at student.uef.fi> ---
Is the precision of 2 decimal places enough? I saw it is used in boraccount.pl,
pay.pl and moremember.pl and maybe this discussion has been had before? I think
there can still be weird cases if you add a fine of 5.005 or anything that has
more than 2 decimal places.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:04:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:04:52 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-sS1nysrrzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54588|0                           |1
        is obsolete|                            |

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54612&action=edit
Bug 16276: Update borrowers.lastseen when a patron is active

In order to add the ability to delete patrons who have been inactive for
more than a given time, we need to track down the last time they were
active.
To do that, we need a new DB column in the borrowers table (lastseen).
Note that the borrowers.lastseen column will not be initialised for existing
installations (set to NULL) so inactive existing patrons will never be
deleted.
A workaround would be to init them at the date when the new column will
be added.

Test plan:
0/ Set the new pref TrackLastPatronActivity on
1/ Log in as a patron (staff or OPAC)
2/ Check that the borrowers.lastseen field has been updated with the
current time

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:04:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:04:57 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-0uWdkU5GH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54589|0                           |1
        is obsolete|                            |

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54613&action=edit
Bug 16276: Make delete_patrons.pl deal with --last_seen

This patch modify the delete_patrons.pl cronjob to deal with the
last_seen option.

To test it, you just have to use the --last_seen option and pass a valid
date (iso format)

Example:
  perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm
will delete all the patrons who do not have been active since this date.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:05:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:05:01 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-HU9ylGiHRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54590|0                           |1
        is obsolete|                            |

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54614&action=edit
Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small change: number of tests in t/db_dependent/Members.t

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:05:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:05:06 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-NIVZMnF0gB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54591|0                           |1
        is obsolete|                            |

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54615&action=edit
Bug 16276: Make the batch patron deletion tool deal with last_seen

This patch adds the same change as the previous one to the batch patron
deletion tool.

If the pref TrackLastPatronActivity is enabled, the librarians will be
able to delete patrons who do not have been connected since a given
time.

Test plan:
Define a date for the "who have not been connected since" options and
confirm that it works as expected.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:05:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:05:13 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-FIpbf06Jgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54592|0                           |1
        is obsolete|                            |

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54616&action=edit
Bug 16276: Add a new pref TrackLastPatronActivity and new column
borrowers.lastseen

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:05:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:05:17 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-BuscVRaxUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54617&action=edit
Bug 16276: [QA Follow-up] Number of tests corrected

Applies to t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:05:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:05:21 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-feDeB5B3wZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54618&action=edit
Bug 16276: [QA Follow-up] Only track when pref is enabled

Do not track when the pref has not been enabled.
This patch moves the conditional update in Auth.pm to Koha::Patron.
And adds a test for the new track_login method.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:06:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:06:31 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-jvDZKSISkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

--- Comment #6 from Lari Taskula <larit at student.uef.fi> ---
A little advertisement if you don't mind... I recommend checking out Bug 16212,
Bug 16699 and Bug 14868 because they make Swagger more maintainable as new
operations are introduced, fix problems with our spec being actually valid
against Swagger schema and also enable our spec to be used with Swagger-UI
(which is awesome), and introduce required permissions for an operation
directly in Swagger instead of having them (hidden) inside controllers. If
possible it would be nice to have sign-offs for them ASAP because as API grows
larger, it will be more and more annoying to rebase those 3 bugs on master.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:08:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:08:49 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-fZLkyZyEmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

--- Comment #7 from Lari Taskula <larit at student.uef.fi> ---
We have also rebased these bugs on top of master, see our API in our test
server at http://renki.pohjoiskarjala.net/api/v1/doc with Swagger-UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:08:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:08:50 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-shgkJJLJUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:10:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:10:41 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-ymt3gZizCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Oops forgot some signoff lines..Hang on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:11:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:11:45 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-eA7tRUCKNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54612|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54619&action=edit
Bug 16276: Update borrowers.lastseen when a patron is active

In order to add the ability to delete patrons who have been inactive for
more than a given time, we need to track down the last time they were
active.
To do that, we need a new DB column in the borrowers table (lastseen).
Note that the borrowers.lastseen column will not be initialised for existing
installations (set to NULL) so inactive existing patrons will never be
deleted.
A workaround would be to init them at the date when the new column will
be added.

Test plan:
0/ Set the new pref TrackLastPatronActivity on
1/ Log in as a patron (staff or OPAC)
2/ Check that the borrowers.lastseen field has been updated with the
current time

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:11:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:11:49 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-QUcfqJBPve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54613|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54620&action=edit
Bug 16276: Make delete_patrons.pl deal with --last_seen

This patch modify the delete_patrons.pl cronjob to deal with the
last_seen option.

To test it, you just have to use the --last_seen option and pass a valid
date (iso format)

Example:
  perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm
will delete all the patrons who do not have been active since this date.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:11:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:11:53 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-mbcg7jC3Lh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54614|0                           |1
        is obsolete|                            |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54621&action=edit
Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small change: number of tests in t/db_dependent/Members.t

https://bugs.koha-community.org/show_bug.cgi?id=12276

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:11:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:11:57 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-sAGknX5q1L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54615|0                           |1
        is obsolete|                            |

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54622&action=edit
Bug 16276: Make the batch patron deletion tool deal with last_seen

This patch adds the same change as the previous one to the batch patron
deletion tool.

If the pref TrackLastPatronActivity is enabled, the librarians will be
able to delete patrons who do not have been connected since a given
time.

Test plan:
Define a date for the "who have not been connected since" options and
confirm that it works as expected.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:12:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:12:01 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-Dl9uOFJue3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54616|0                           |1
        is obsolete|                            |

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54623&action=edit
Bug 16276: Add a new pref TrackLastPatronActivity and new column
borrowers.lastseen

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:12:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:12:05 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-nkpuUarCAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54617|0                           |1
        is obsolete|                            |

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54624&action=edit
Bug 16276: [QA Follow-up] Number of tests corrected

Applies to t/db_dependent/Members.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:12:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:12:09 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-UkB2ULZvPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54618|0                           |1
        is obsolete|                            |

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54625&action=edit
Bug 16276: [QA Follow-up] Only track when pref is enabled

Do not track when the pref has not been enabled.
This patch moves the conditional update in Auth.pm to Koha::Patron.
And adds a test for the new track_login method.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:15:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:15:55 +0000
Subject: [Koha-bugs] [Bug 16873] Renewal error message not specific enough
	on self check.
In-Reply-To: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16873-70-QvvpYsqeg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|minor                       |normal
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:17:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:17:00 +0000
Subject: [Koha-bugs] [Bug 16873] Renewal error message not specific enough
	on self check.
In-Reply-To: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16873-70-HbW3Wfa1jf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54626&action=edit
Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check in an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check in an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check in an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:16:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:16:57 +0000
Subject: [Koha-bugs] [Bug 16873] Renewal error message not specific enough
	on self check.
In-Reply-To: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16873-70-rXlNoI6EN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:18:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:18:06 +0000
Subject: [Koha-bugs] [Bug 16930] Search returns no results if "and" appears
 before a colon
In-Reply-To: <bug-16930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16930-70-m8KwgAg9OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16930

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|16.05                       |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:40:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:40:33 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-H7U0flC5oB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:40:57 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-vEdUJwHXwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:44:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:44:15 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16942-70-xBeM4hHbYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
> So maybe you should explain me why the following test pass:
> 
> 180 $prepared_letter = GetPreparedLetter(
> 181     (
> 182         module      => 'test',
> 183         letter_code => 'TEST_HOLD',
> 184         tables      => { 
> 185             reserves => [ $patron->{borrowernumber}, $biblio->id() ]
> 186         },
> 187     )
> 188 );
> 189 is( $prepared_letter->{content}, $hold->id(), 'Hold object used
> correctly' )
> 
> What does reserves => { $borrowernumber, $biblionumber } mean?
> How do you know that $borrowernumber is a borrowernumber?
> It looks like something magic and to me it should not work.

Ah, I see now! I'll look into that!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:44:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:44:30 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-jCakL0uyzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:44:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:44:33 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-ky6KLQbUdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54627&action=edit
Bug 16990: Display branch names instead of code in patron mod requests

To test:
- change your homebranch in the OPAC, submit
- change patron modification request in the staff client
- Verify that it shows the old and new branch name instead of the
  code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:45:01 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-e0KN1kh1cL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16960


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960
[Bug 16960] Patron::Modifications should be fixed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:45:01 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-Iu04xLb3cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990
[Bug 16990] Show branch name instead of branch code when managing patron
modification requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:46:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:46:49 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-zR53cEUWir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '7874' for key
'PRIMARY' at /home/koha/src/Koha/Object.pm line 109
 at /home/koha/src/opac/opac-memberentry.pl line 428

To recreate:
At the OPAC, change some of your patron's details.
And change the same ones or others => boom

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:47:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:47:48 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-BqVYHawSsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 13:55:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 11:55:31 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-Sjqu3su6ny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #6 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #5)
> issue_id ... Hm, I think you could probably use it for statistics... finding
> out about... not sure. Might be I just like things linked :)

Hm, issue_id is not a foreign key, it stays in fine record after check-in. I
agree that it may be useful after all - for statistics, or e.g. for displaying
more accurate info regarding what the given fine was for, in staff and OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:07:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:07:56 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-Mgjoe2Rqro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #7 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Yet another way to fix this would be an extra column in issues table to keep an
accountlines_id of the currently accruing overdue fine for this issue (to be
set NULL on renewal). Good for performance, and probably for other things too
in the future..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:10:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:10:32 +0000
Subject: [Koha-bugs] [Bug 3379] Rounding error for fines total in
 C4::Members:: GetMemberAccountRecords
In-Reply-To: <bug-3379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3379-70-kbkfLUGgfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:11:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:11:03 +0000
Subject: [Koha-bugs] [Bug 3379] Rounding error for fines total in
 C4::Members:: GetMemberAccountRecords
In-Reply-To: <bug-3379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3379-70-kSeu5dI9hp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17140

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:11:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:11:03 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-s5GeK6IVl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3379

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:15:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:15:46 +0000
Subject: [Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for
	translations
In-Reply-To: <bug-8645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8645-70-PguhJNTrQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:18:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:18:27 +0000
Subject: [Koha-bugs] [Bug 11728] Offline circ shows weird amount of decimals
 in fine amount
In-Reply-To: <bug-11728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11728-70-nM4XtIhTVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11728

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:20:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:20:43 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-DVUBRWsgEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11425
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:20:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:20:43 +0000
Subject: [Koha-bugs] [Bug 11425] Search form for items
In-Reply-To: <bug-11425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11425-70-N7vgUkZ41l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16485

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:28:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:28:43 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-ItPaQJSoV9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

--- Comment #9 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
It seems there is a confusion between Collection code and collection title.
Collection code is selected as filter, but only collection title appear in
results display.
Both column should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:34:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:34:49 +0000
Subject: [Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for
	translations
In-Reply-To: <bug-8645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8645-70-6XQIMXRlcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marc V?ron from comment #8)
> Still valid?

Yes. There is still one English string in background-job-progressbar.js at line
72:

      alert('Failed to submit form: ' + textStatus);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:36:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:36:46 +0000
Subject: [Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows
 circulation down in case of a record with many items and many holds
In-Reply-To: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14736-70-qeBXeGNYnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Priority|P5 - low                    |P3
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:44:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:44:08 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-RoG0QmB4ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:44:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:44:14 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-gjbdvt0xlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54628&action=edit
Bug 16960: Delete previous patron modifications

If a patron edit his/her details a second time, we need to delete the
first ones to avoid a "duplicate entry for key PRIMARY" error.

Test plan:
Log in at the OPAC
Edit your details
Edit them again
=> Without this patch, Koha will crash
=> With the patch applied, everything should work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 14:51:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 12:51:45 +0000
Subject: [Koha-bugs] [Bug 17033] Rotating Collection does not show on
	tools-home.pl
In-Reply-To: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17033-70-sYRLl3NyFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Works for me and the permissions are the same.
Reopen if it persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:00:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:00:28 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-A6ZVqDAvIE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54575|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54629&action=edit
Bug 17006: Add API route for changing patron's password

Fixed trailing whitespace

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:00:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:00:42 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-8qt067FGqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54576|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54630&action=edit
Bug 17006: Respect system preference "OpacPasswordChange"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:06:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:06:24 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-P83dGlc5yR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54457|0                           |1
        is obsolete|                            |

--- Comment #28 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54631&action=edit
Bug 14868: Swagger2-driven Permission checking

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:06:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:06:48 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-LWyz0XoOtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54458|0                           |1
        is obsolete|                            |

--- Comment #29 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54632&action=edit
Bug 14868: Give users possibility to request their own object

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:07:10 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-qP8E9mvKMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54459|0                           |1
        is obsolete|                            |

--- Comment #30 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54633&action=edit
Bug 14868: Use x-koha-authorization in current routes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:07:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:07:40 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-1vhxQTkGDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12478
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It looks like it has been introduced by bug 12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:07:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:07:40 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-YZ4sALCK99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17048


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048
[Bug 17048] Authority search result list page scrolling not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:22:58 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-UXInCr4Ken@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |2735

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Same at the OPAC, because of bug 2735.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735
[Bug 2735] Authority search in OPAC stops at 15 pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:22:58 +0000
Subject: [Koha-bugs] [Bug 2735] Authority search in OPAC stops at 15 pages
In-Reply-To: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2735-70-AlSNw5n3YA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17048


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048
[Bug 17048] Authority search result list page scrolling not working properly
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:35:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:35:31 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-ZMqvYY615A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48368|0                           |1
        is obsolete|                            |

--- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54634&action=edit
Bug 13501: Add JS library select2 3.5.4

use it on cataloguing and batch items edit pages

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:35:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:35:36 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-DLdnLq6YQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48369|0                           |1
        is obsolete|                            |

--- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54635&action=edit
Bug 13501: Indentation fix (batchMod-edit.tt)

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:35:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:35:41 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-4lX9RVmT8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48370|0                           |1
        is obsolete|                            |

--- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54636&action=edit
Bug 13501: Move "Required" and checkbox after input/select

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:35:45 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-Btkf1xwg5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54637&action=edit
Bug 13501: Highlight select2 control if field is required and value is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:35:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:35:49 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-CG6HY4JB8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #38 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54638&action=edit
Bug 13501: Fix behavior of 'Delete subfield' button on select2 controls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:36:58 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-KAcSb9Jbma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rebased on master + 2 more patches for comment 32 and comment 33

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:40:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:40:15 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-ewxs7Hc6cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:40:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:40:18 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-UHjkPYiutH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54639&action=edit
Bug 17048: Fix pagination offset for authority searches

At the intranet, the pagination has been broken by bug 12478 (Elastic
Search). There was a confusion between the offset and the page number.

At the OPAC, it is broken since bug 2735 which has mimicked the intranet
script.

Test plan:
Search for a term which will return more than 1 page of results.
Click on the second page
=> Without this patch, the first result of the second page is the second
result of the first page
=> With this patch applied, the offset will be corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:40:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:40:55 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-wPgLIc2tyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
In table accountlines, definition of amount is decimal 28,6
http://schema.koha-community.org/tables/accountlines.html

I am able to enter a manual invoice like 0.008 (displays as 0.01) or 0.004
(displays as 0.00)

The table then contains:
mysql> select amount from accountlines where borrowernumber = 13;
+----------+
| amount   |
+----------+
| 0.008000 |
| 0.004000 |
+----------+

The 'Pay fines' tab shows an amount of 0.01 and an amount of 0.00

I payed the first one (0.01), it asked 0.01

mysql> select amount from accountlines where borrowernumber = 13;
+-----------+
| amount    |
+-----------+
|  0.008000 |
|  0.004000 |
| -0.010000 |
+-----------+

The 'Pay fines tab then shows an amount of 0.00
If I want to pay using 'Pay' on the line, it asks for 0.00, but obviously it is
not possible to pay the amount.

Same with 'Pay amount'

Now I add manual invoices, let's say 3 times 0.003

mysql> select amount from accountlines where borrowernumber = 13;
+-----------+
| amount    |
+-----------+
|  0.008000 |
|  0.004000 |
| -0.010000 |
|  0.003000 |
|  0.003000 |
|  0.003000 |
+-----------+

The Account tab shows all 0.00 in 'Outstanding' column, but a 'Total due' of
0.01

A similar situation occurs with Rental discounts in Circulation and fines rules
(smart-rules.pl), e.g. values like 2.961000

That will lead to confusion... 

What to do? Maybe the following:

 - Define a systemwide decimal precision for data entry of amounts?
 - Maybe depending on the decimal places in syspref CurrencyFormat?
 - Make Rental discounts round to that precision?
 - Allow 'Price' plug-in to override if more precision is necessary, e.g. for
calculating / displaying taxes in acquisition? (Koha/Number/Price.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:51:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:51:28 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-QEUvPdduqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:55:40 +0000
Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses
	biblioitems.itemtype
In-Reply-To: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13452-70-BKFzwJ87kH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #10)
> On reports/issues_avg_stats.pl, select row=patron category and column=item
> type
> 
> DBD::mysql::st execute failed: You have an error in your SQL syntax

I tried just now and saw no errors.

Generated SQL:

SELECT borrowers.categorycode, items.itype,  issuedate, returndate, COUNT(*)
FROM `old_issues`,borrowers,biblioitems
  LEFT JOIN items ON (biblioitems.biblioitemnumber=items.biblioitemnumber)
WHERE old_issues.itemnumber=items.itemnumber
  AND old_issues.borrowernumber=borrowers.borrowernumber
group by borrowers.categorycode, items.itype, issuedate, returndate
order by borrowers.categorycode, items.itype

I tried to change the value of item-level_itypes syspref, but it works as well.
Could you give it another try ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:57:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:57:53 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-hJULyEOass@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Prices should be stored with a big precision (6 is largely enough) and
displayed with 2 decimals.
That is how it's done in the acq module and almost everywhere else I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:58:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:58:31 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-8RdxZO6G0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |9021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:58:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:58:31 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS:: Send drivers
In-Reply-To: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-nsqLRBVomZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17067


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067
[Bug 17067] Missing field "sms_provider_id" in database schema
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:59:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:59:03 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-xtNa5gpojj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|wizzyrea at gmail.com          |gmcharlt at gmail.com
            Product|Project Infrastructure      |Koha
          Component|Project website             |Database
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:59:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:59:40 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-oKmXR0YctV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|9021                        |
          Component|Database                    |Project website
           Assignee|gmcharlt at gmail.com          |wizzyrea at gmail.com
            Product|Koha                        |Project Infrastructure
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 15:59:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 13:59:40 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS:: Send drivers
In-Reply-To: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-7UtUlZNiAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17067                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067
[Bug 17067] Missing field "sms_provider_id" in database schema
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:00:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:00:11 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-gBcgKi4Ien@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Liz, do you know who is supposed to update the schema?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:06:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:06:51 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-WqK18G187d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Andy Boze <Boze.1 at nd.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|Boze.1 at nd.edu               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:09:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:09:04 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-EfempRUJoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:10:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:10:56 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-mNhZ4jLjrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:12:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:12:33 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-mcbgSe3anz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #28)
> Adds the UpdateItemLocationOnCheckin to svc/checkin

Why is it needed?
svc/checkin calls AddReturn (which deals with UpdateItemLocationOnCheckin).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:25:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:25:25 +0000
Subject: [Koha-bugs] [Bug 17152] New: Duplicating a subfield should not copy
	the data
Message-ID: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

            Bug ID: 17152
           Summary: Duplicating a subfield should not copy the data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When cataloguing, if you want to duplicate a subfield that is not empty, the
new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is created
with subfields but without data in it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:28:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:28:07 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-o0xWFOk4kZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:28:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:28:10 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-2Gnm9a3Wp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54640&action=edit
Bug 13921 - XSLT Literary Formats Not Showing

This patch adds some missing literary formats to the staff client and
OPAC's search results XSLT display.

To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system
preferences enabled.  XSLTResultsDisplay and OPACXSLTResultsDisplay
should be set to 'default.'

Perform searches in the staff client and the OPAC and confirm that the
following literary forms (defined in 008 position 33) display correctly:
Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.;
Letters; Short stories; Mixed forms; Poetry; Speeches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:35:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:35:39 +0000
Subject: [Koha-bugs] [Bug 7649] remove kw,wrdl from search history
In-Reply-To: <bug-7649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7649-70-VHqvnTFlCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7649

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:40:27 +0000
Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses
	biblioitems.itemtype
In-Reply-To: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13452-70-BSgTud0IMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Still the same.
Actually $itype is set to undef because not defined in the same scope.
If you are not using plack it should work correctly, with plack it will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:46:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:46:31 +0000
Subject: [Koha-bugs] [Bug 14838] Coding issue on reports header row
In-Reply-To: <bug-14838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14838-70-LZVZxG9kzF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14838

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:49:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:49:19 +0000
Subject: [Koha-bugs] [Bug 7204] Deleting a framework which still has biblios
 attached to it end up in subtle problems
In-Reply-To: <bug-7204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7204-70-nyVqSNRz6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7204

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be fixed in master. Koha does not give you the option of
deleting a framework if it is use:

This framework cannot be deleted

Books, Booklets, Workbooks (BKS)

The framework is used 14 times.

[ <- Return to frameworks ]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:52:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:52:19 +0000
Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports
In-Reply-To: <bug-11887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11887-70-H0io3pSmlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Should this be 'Needs signoff?'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 16:53:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 14:53:54 +0000
Subject: [Koha-bugs] [Bug 13552] Add debar option to batch patron
	modification
In-Reply-To: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13552-70-CHcBpuRkUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Added: debarredcomment and  |Add debar option to batch
                   |debarreddate in batch       |patron modification
                   |patrons modification        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:01:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:01:55 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-ynZTfa9IuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #8)
> Prices should be stored with a big precision (6 is largely enough) and
> displayed with 2 decimals.

Hm, maybe charges / fines should be treated a bit differently.. When there is a
fine like 1.342, and it displays as 1.32, how do you know what exact amount to
enter to make account balanced? Doing a math (comparisons etc.) with amounts
casted to .2f would solve some kinds of this problems (I think that's like
accountants do it [on Discovery Channel]) to solve < .01 difference problems on
invoices etc.

Fine calculations in Koha a mostly done in floating-point - it's probably good
enough for 99.9(9) of cases (~16 significant decimal digits precision with
64bit floats) as long as you are doing a casting (btw, to .2f or .6f ?) in most
important places.

Mysql calculations for decimal(x,y) are allegedly precise, though, and fine
calculations in koha are not always floating-point, e.g. in
GetMemberIssuesAndFines():

    SELECT SUM(amountoutstanding) FROM accountlines

Storing all fines/charges amounts rounded to .2f and doing most of the math in
.2 precision is tempting (but that alone would not be enough to prevent all
kinds of such problems) - hopefully nobody is using bitcoin as a main currency
in Koha..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:03:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:03:49 +0000
Subject: [Koha-bugs] [Bug 12814] Authority cataloging problem
In-Reply-To: <bug-12814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12814-70-rltOWvqFmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|KOHA Cataloging             |Authority cataloging
                   |(Authorities) Problem       |problem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:09:21 +0000
Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to
 Koha::Authority::Type [s] - part 2
In-Reply-To: <bug-15381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15381-70-S19aZRw0fg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118
[Bug 17118] Regression: Bug 15381 triggers error when trying to clear a linked
authority
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:09:21 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-n67qUnr5PV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #10 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #4)
> I think we should remove the * 1000 / 1000

+1, it isn't really serving any useful purpose, it's not warranted that the
result of the multiplication will be an integer anyway.

BTW, there is another one like that (*100, /100) in GetBorNotifyAcctRecord().
Still with an int() thing, which is definitely incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:09:21 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-g6MGp0jDTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |15381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:15:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:15:19 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-5lXW5eJSeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:15:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:15:22 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-aEE7sRHNpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54641&action=edit
Bug 17118: (follow-up 15381) Fix regression when clearing a linked authority

Changes made on bug 15381 assumed that the authid was always set.
But if the user wants to clear the field of the authority, the script is
called with authid=0 (FIXME...)

To fix this issue, it's better to move the new calls to
  Koha::Authorities->find($authid)->authtypecode
and
  Koha::Authority::Types->find($authtypecode);
at the correct place

Test plan:
1. Edit a record which has a field linked to an
   authority record (100a for instance).
2. Click the link which triggers the tag editor.
   A pop-up window should be displayed.
3. In the pop-up window, click the "Clear field"
   button.
=> Without this patch A second pop-up window opens and displays an error:
  Can't call method "authtypecode" on an undefined value at
/authorities/blinddetail-biblio-search.pl line 61.
=> With this patch applied the field is correctly cleared.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:23:00 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-3FgLlP7D66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 54642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54642&action=edit
Illustration of precision problem with calculated rental fees and manual
invoices

I made some screenshots to explain what I mean.
(Screenshots made with patch applied).

I still think that
- it should not be possible to manually enter values like 1.003 (manual
invoices, payment, credit, item rental fees, others?)
- a calculated rental fee (from item rental fee and patron category discount)
should be rounded to 2 decimals

Otherwise, after payement, you will have remainders in the database that lead
to strange behaviour (see attachment).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:24:02 +0000
Subject: [Koha-bugs] [Bug 12644] Add subtitles staff client cart
In-Reply-To: <bug-12644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12644-70-TWokepd9Ny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com
            Summary|Add subtitles to all cart   |Add subtitles staff client
                   |views                       |cart
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|OPAC                        |Staff Client

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This bug doesn't appear valid for the OPAC, but does affect the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:27:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:27:29 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
	calculations, part 2
In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17140-70-pLbEm0yp1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Created attachment 54643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54643&action=edit
Screenshots with some notes added

Added the same screenshots with some notes on them.

See comment #11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:29:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:29:46 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-XlAUczpFpb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53112|0                           |1
        is obsolete|                            |

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54644&action=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
        will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates
9) Try entering various incorrect syntax in the pref and note you are warned

Sponsored by:
    Arcadia Public Library (http://library.ci.arcadia.ca.us/)
    Middletown Township Public Library (http://www.mtpl.org/)

Signed-off-by: Cathi Wiggins <cwiggins at ArcadiaCA.gov>

Signed-off-by: Megan Wianecki  <mwianecki at mtpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:29:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:29:52 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-K7ZKESMlU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53113|0                           |1
        is obsolete|                            |

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54645&action=edit
Bug 14576 - Unit tests

Signed-off-by: Cathi Wiggins <cwiggins at ArcadiaCA.gov>

Signed-off-by: Megan Wianecki  <mwianecki at mtpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:29:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:29:57 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-d4b370XZ8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53114|0                           |1
        is obsolete|                            |

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54646&action=edit
Bug 14576 - (QA followup) Fix message for use of value not in authorized values

Signed-off-by: Cathi Wiggins <cwiggins at ArcadiaCA.gov>

Signed-off-by: Megan Wianecki  <mwianecki at mtpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:30:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:30:04 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-m53wR1adxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53115|0                           |1
        is obsolete|                            |

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54647&action=edit
Bug 14576 (QA Folllowup) Address issues

use mock for tests
use a separate variable for yaml
fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:30:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:30:10 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-WpfGfZbRqV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54281|0                           |1
        is obsolete|                            |

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54648&action=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:31:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:31:34 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-vkLKxKiTTY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Nick Clemens from comment #28)
> > Adds the UpdateItemLocationOnCheckin to svc/checkin
> 
> Why is it needed?
> svc/checkin calls AddReturn (which deals with UpdateItemLocationOnCheckin).

Yeah....nevermind that bit, removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:32:34 +0000
Subject: [Koha-bugs] [Bug 17104] svc/checkin does not use
	UpdateNotForLoanStatusOnCheckin
In-Reply-To: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17104-70-Ahh32lVebA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Nevermind, wasn't thinking, this work is done in AddReturn, called by
svc/checkin

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:40:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:40:33 +0000
Subject: [Koha-bugs] [Bug 13552] Add debar option to batch patron
	modification
In-Reply-To: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13552-70-1hwupymQEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:46:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:46:59 +0000
Subject: [Koha-bugs] [Bug 16809] Silence CGI param warnings from
 C4::Biblio:: TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-kEUq8qosQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:47:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:47:02 +0000
Subject: [Koha-bugs] [Bug 16809] Silence CGI param warnings from
 C4::Biblio:: TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-y0d9iG9aO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54535|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54649&action=edit
Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc

Most of the floodiness is caused by accessing the cgi parameters
in a context which is hard to determine. By purposefully saving
the value to a scalar variable and using the variable, the issue
disappears, and it will likely be a tiny tad faster as variable
access is faster than multiple function calls.

TEST PLAN
---------
 1) Back up your intranet error log
    -- for example:
       cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
    -- for example:
       echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
    -- floody!
 9) Apply patch
10) repeat steps 2-8
    -- blank!
11) restore your intranet error log
   -- for example:
      mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with addbiblio.pl. I would have preferred the scalar option in terms
of simpler code, but this works too.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:47:23 +0000
Subject: [Koha-bugs] [Bug 16809] Silence CGI param warnings from
 C4::Biblio:: TransformHtmlToMarc
In-Reply-To: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16809-70-1hAXqiEOpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54536|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54650&action=edit
Bug 16809: Follow-up for scalarizing biblionumber

Still resolves another multi_param warning.

Test plan:
Look at your logs before and after this patch when saving a biblio
record (you may have to start plack again).
If your biblionumber is mapped to 999c, you should no longer have a warn
about line 2563 (disclaimer: line numbers are subject to change).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:49:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:49:23 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-Rgho00GxG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:49:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:49:26 +0000
Subject: [Koha-bugs] [Bug 14612] Overdue notice triggers should show
 branchname instead of branchcode
In-Reply-To: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14612-70-RUO8PvG71F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54582|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54651&action=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:52:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:52:23 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-cue1e4ugat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #37)
> Created attachment 54637 [details] [review]
> Bug 13501: Highlight select2 control if field is required and value is
> missing

Are you sure you want to remove select2.min.css?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:53:23 +0000
Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency
	code.
In-Reply-To: <bug-14520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14520-70-BHm4kaKqwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Created attachment 54652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54652&action=edit
It is no longer possible to add currency with same code

See attachment. Issue seems to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:54:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:54:00 +0000
Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency
	code.
In-Reply-To: <bug-14520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14520-70-Ri1deMM41Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 17:58:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 15:58:46 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-4IqLjgScrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |LATER
             Status|NEW                         |RESOLVED

--- Comment #9 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Marc V?ron from comment #8)
> Is this bug still valid?

I don't think that I've seen it happen since 3.16 -- given that we have a
work-around in the form of the inserts into message_transports, I'm happy to
close; we can re-open later if necessary.

I suspect that the original issue happened due to a cascading delete on the
'letter' table.

I'm closing the bug, if it pops up again, we can always re-open.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 18:05:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 16:05:13 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-Lgf0N2LggQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 18:05:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 16:05:16 +0000
Subject: [Koha-bugs] [Bug 15164] Allow editing of the invoice number after
	initial saving
In-Reply-To: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15164-70-dSOdRH8v4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54568|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54653&action=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 18:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 16:18:05 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-Xq2iQNi30W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17135

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 18:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 16:18:05 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-KRNaC6fy0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15675

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 18:41:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 16:41:48 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-B6YwtFR6VQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54648|0                           |1
        is obsolete|                            |

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54654&action=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:05:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:05:18 +0000
Subject: [Koha-bugs] [Bug 8173] Have Full title (245) to always display in
	system
In-Reply-To: <bug-8173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8173-70-rwO3Vwyvox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8173

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This issue has been fixed in many places via the 'Keywords to MARC mapping'
system and via bug reports for individual cases. I think specific reports are
better than this broad one, so I'm closing it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:11:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:11:54 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-bDK7GV7Q2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54054|0                           |1
        is obsolete|                            |

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54655&action=edit
Bug 17050: Do not kick the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (neither $ENV{HTTP_*}) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:12:03 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-vjqWQnRjyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54656&action=edit
Bug 17050: (QA followup) Use Mojo::Transaction to get the remote address

While the original patch fixes the issue, reading at Mojolicious source code,
revealed
that Mojo::Transaction already has proper processing for detecting the remote
address:

sub remote_address {
  my $self = shift;

  return $self->original_remote_address(@_) if @_;
  return $self->original_remote_address unless $self->req->reverse_proxy;

  # Reverse proxy
  return ($self->req->headers->header('X-Forwarded-For') // '') =~ /([^,\s]+)$/
    ? $1
    : $self->original_remote_address;
}

Without this patch, if there's a request without HTTP_X_FORWARDED_FOR, then the
remote
address would be empty. Such would be the case of a dev/standard setup without
Plack.

This patch makes Koha::REST::V1::startup use tx->remote_address instead of
dealing with the
headers on its own.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:12:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:12:49 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-xY4gHDEi3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:14:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:14:33 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-oZGuZguNca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Adding a single field to the biblio table seems much too limiting. Would you
combine all the 245 subfields > 'a' into one string and store it that way?

Is anyone thinking about a better way to do this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:17:52 +0000
Subject: [Koha-bugs] [Bug 11979] Display correct not for loan status
 description on course reserves
In-Reply-To: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11979-70-dG3j7yRVQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|items status not for loan   |Display correct not for
                   |on course reserve           |loan status description on
                   |                            |course reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:44:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:44:37 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-01ec7d4sZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #42 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Kyle M Hall from comment #41)
> (In reply to Nick Clemens from comment #40)
> > I haven't fully tested, but initial read through and applying looks good.
> > This makes it much easier to get memcached functioning with plack and is a
> > good improvement
> 
> I agree! This is a huge improvement and greatly simplifies the setup.
> 
> Jacek, what do you think?

I think generally it's good, and certainly good enough for the 'promotion' from
"In discussion" to "Needs sign-off". I have some doubts re/ certain parts
(mostly about an introduction of that 'namespace' thingy to the Koha caching
system - not entirely sure if it's strictly necessary, and - in case it is - if
doing it in this particular way is the best way possible).

But it's more the matter of opinion / personal preferences (and/or my lack of
understanding why it's needed to be done, and/or why in that way) than any real
concerns.

So far I haven't spotted any regressions in this patch set - looks like there
may be some (= most likely very-very slight) performance hits involved for the
caching system, because of the 'namespaces' introduction, but IMO sorting out
inconsistencies of the memcached config / setups problems in the systemic way
is _much_ more important then that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 20:54:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 18:54:14 +0000
Subject: [Koha-bugs] [Bug 11979] Display correct not for loan status
 description on course reserves
In-Reply-To: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11979-70-Oy88HXIUhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
It turns out the template /tries/ to show the correct not for loan status, but
the notforloan data which is passed to item-status.inc is incomplete. Compare
the item data pulled by GetBiblioFromItemNumber in Biblio.pm (from which the
course reserves information comes) to GetItemsInfo in Items.pm (from which the
item data comes for pages like opac-detail.pl).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:13:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:13:16 +0000
Subject: [Koha-bugs] [Bug 7703] Don' t block bulk hold action on search
 results if some items can' t be placed on hold
In-Reply-To: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7703-70-g5mb3at60c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #34 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 4249 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:13:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:13:16 +0000
Subject: [Koha-bugs] [Bug 4249] Can't place multiple holds if one record has
 no holdable items (staff)
In-Reply-To: <bug-4249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4249-70-AhnHVt9hpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4249

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 7703 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:22:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:22:51 +0000
Subject: [Koha-bugs] [Bug 17153] New: Logging in during a search navigates
 to account page instead of back to search results
Message-ID: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

            Bug ID: 17153
           Summary: Logging in during a search navigates to account page
                    instead of back to search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ldjamison at marywood.edu
        QA Contact: testopia at bugs.koha-community.org

When a patron logs in the OPAC on any page, except opac-reserve.pl, they are
always redirected to opac-user.pl.

This can prove to be problematic in regards to tasks such as navigating search
results (including both catalog and EDS searches if the EDS plugin is
installed), adding tags, adding comments, or nearly any other action which
requires a patron to login.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:36:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:36:54 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-4iJ7Pw04wR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ldjamison at marywood.edu

--- Comment #1 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 54657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54657&action=edit
Forces redirect to search results after logging in on opac-search.pl

To test:
- Perform a catalog or EDS search
- Login from opac-search.pl
- Without the patch, the page should redirect to opac-user.pl
- Log out
- Apply patch
- Perform a search again
- Login again from opac-search.pl
- The page should redirect back to search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:37:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:37:39 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-9ufPA2unDj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ldjamison at marywood.edu      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:49:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:49:40 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-rfzvGjoc0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54658&action=edit
Bug 16573: (RM followup) Update DBIx schema and prevent upgrade issues

This patch updates the DBIx::Class schema files, and introduces the IGNORE
option to the updatedatabase.pl's ALTER TABLE to prevent issues for users
upgrading from 3.22 onwards.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:50:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:50:51 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-VYkxCaablX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:51:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:51:00 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-yrMFQtphKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:51:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:51:07 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-p9rtw4eNSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:51:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:51:16 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-sFuR1FtMM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 21:51:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 19:51:37 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-v02vbazXYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Back to the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:24:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:24:40 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-TyCuDC5w54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

Aliki Pavlidou <pavlidoualiki at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavlidoualiki at gmail.com

--- Comment #7 from Aliki Pavlidou <pavlidoualiki at gmail.com> ---
Hello,

I tried to test this patch with the sandbox system, but it does not work.

I've got this log in message in which the test/test credentials don't apply.

"Welcome to the Koha web installer

Before we begin, please verify you have the correct credentials to continue.
Please log in with the username and password given to you by your systems
administrator and located in your koha-conf.xml configuration file.

Please enter your username and password:"


Kind regards

Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:52:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:52:13 +0000
Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when
 using decreaseLoanHighHolds feature
In-Reply-To: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16387-70-YTgDXGTK5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I was just noticing this.  I talked with Nick Clemens, and he thinks it might
be this in circulation.pm:

1178         my $issuedate = DateTime->now( time_zone => C4::Context->tz() );
1179 
1180         my $calendar = Koha::Calendar->new( branchcode => $branch );
1181 
1182         my $itype =
1183           ( C4::Context->preference('item-level_itypes') )
1184           ? $biblio->{'itype'}
1185           : $biblio->{'itemtype'};
1186 
1187         my $orig_due = C4::Circulation::CalcDateDue( $issuedate, $itype,
$branch, $borrower );
1188 
1189         my $decreaseLoanHighHoldsDuration =
C4::Context->preference('decreaseLoanHighHoldsDuration');
1190 
1191         my $reduced_datedue = $calendar->addDate( $issuedate,
$decreaseLoanHighHoldsDuration );
1192 
1193         if ( DateTime->compare( $reduced_datedue, $orig_due ) == -1 ) {
1194             $return_data->{exceeded} = 1;
1195             $return_data->{duration} = $decreaseLoanHighHoldsDuration;
1196             $return_data->{due_date} = $reduced_datedue;

Line 1196 is assigning the value in $reduced_datedue.
Line 1191 is basing the value of $reduced_datedue from $issuedate
Line 1178 is assigning $issuedate a value based on now(the time at this very
moment).

So somehow we need $reduced_datedue to use the same time as $orig_due, but only
adjust the date, and not reference $issuedate.

I would do this, but I barely understand what I am looking at, thanks to Nick's
help.

Hope this helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:52:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:52:52 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-UUmvVTjLUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:52:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:52:55 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-9yirmJxBgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54659&action=edit
Bug 8030 (QA Followup) - Use REST api and provide feedback

Use REST API
If cancelled return to previous selection
If fail return to previous selection
Use fa spinning icon while waiting
Disable select while waiting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:52:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:52:59 +0000
Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when
 using decreaseLoanHighHolds feature
In-Reply-To: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16387-70-6lE2e2dY8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:53:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:53:55 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-SHEUmScph4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #10)
> Nick, can you please take a look at the questions and comments? Thx!
All set

I did an admittedly rough job of inserting the icon, some feedback from Owen on
placement and preferred icon would be apreciated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:55:40 +0000
Subject: [Koha-bugs] [Bug 17143] Popup Notification for
	decreaseloanhighholds preference
In-Reply-To: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17143-70-nqBExEoNMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16387

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 22:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 20:55:40 +0000
Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when
 using decreaseLoanHighHolds feature
In-Reply-To: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16387-70-PQlIT40Uyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17143

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 23:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 21:02:06 +0000
Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when
 using decreaseLoanHighHolds feature
In-Reply-To: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16387-70-sCVwScPH1O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17143


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143
[Bug 17143] Popup Notification for decreaseloanhighholds preference
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 23:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 21:02:06 +0000
Subject: [Koha-bugs] [Bug 17143] Popup Notification for
	decreaseloanhighholds preference
In-Reply-To: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17143-70-oyrICdVGra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16387

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I just added some information to bug 16387 that may be related to this.

1178         my $issuedate = DateTime->now( time_zone => C4::Context->tz() );
1179 
1180         my $calendar = Koha::Calendar->new( branchcode => $branch );
1181 
1182         my $itype =
1183           ( C4::Context->preference('item-level_itypes') )
1184           ? $biblio->{'itype'}
1185           : $biblio->{'itemtype'};
1186 
1187         my $orig_due = C4::Circulation::CalcDateDue( $issuedate, $itype,
$branch, $borrower );
1188 
1189         my $decreaseLoanHighHoldsDuration =
C4::Context->preference('decreaseLoanHighHoldsDuration');
1190 
1191         my $reduced_datedue = $calendar->addDate( $issuedate,
$decreaseLoanHighHoldsDuration );
1192 
1193         if ( DateTime->compare( $reduced_datedue, $orig_due ) == -1 ) {
1194             $return_data->{exceeded} = 1;
1195             $return_data->{duration} = $decreaseLoanHighHoldsDuration;
1196             $return_data->{due_date} = $reduced_datedue;

I think because the time index in $reduced_datedue isn't the same as the time
index in $orig_due, the two will never be equal, unless checked out at the time
indicated in the $org_due.  Therefore, if the original due date is in 14 days,
and reduced due date is set to 14 days, the two are not going to match because
of the time index.

I'm thinking that if the other bug is resolved, this will be as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387
[Bug 16387] Incorrect loan period calculation when using  decreaseLoanHighHolds
feature
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 23:14:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 21:14:54 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-LBVlALrMAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #26 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 54658
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54658
Bug 16573: (RM followup) Update DBIx schema and prevent upgrade issues

Review of attachment 54658:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16573&attachment=54658)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +12789,4 @@
>  $DBversion = '16.06.00.012';
>  if ( CheckVersion($DBversion) ) {
>      $dbh->do(q{
> +        ALTER IGNORE TABLE virtualshelves MODIFY COLUMN created_on DATETIME not NULL;

"As of MySQL 5.7.4, the IGNORE clause for ALTER TABLE is removed and its use
produces an error."
(https://dev.mysql.com/doc/refman/5.7/en/alter-table.html)
I'd leave out the ignore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 23:26:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 21:26:27 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-J5JZUCgh5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #6 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
> You will have to select a budget for each item before being able to save.

What do you mean by this? If the fund is in the file, it should auto-populate,
correct?

Tested:

1. Staged a MARC file with two bibs, one with 1 item and the other with 3.
2. Added the staged file to the basket.
3. At this point everything looks good, other than the fact that I needed to
manually select the fund. Price populates, I see two records, one with one item
and the other with 3.
4. After saving, two bib records are created, but they both have 4 items. It
was like it added all the items to both records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 19 23:28:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 19 Aug 2016 21:28:36 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-2ZumXeB0Bv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #7 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
Created attachment 54660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54660&action=edit
Test Case of 2 bibs, 1 item on one bib, 3 on the other

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 20 07:31:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 20 Aug 2016 05:31:01 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-jSQL6NtO4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 28200
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28200
Collapse unused message transport types in notice editor

Review of attachment 28200:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12236&attachment=28200)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
@@ +344,4 @@
>                    [% letter.message_transport_type %]
>                  [% END %]
>                </legend>
> +              <ol[% IF (letter.title.length < 1 && letter.content.length < 1) %] class="noshow_mtt noshow_mtt_[% letter.message_transport_type%]"[% END %]>

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 20 07:47:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 20 Aug 2016 05:47:12 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-EQZt2IeNFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Patch doesn't apply         |RESOLVED
                 CC|                            |mtompset at hotmail.com

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
I believe upon further inspection that:

 $( "#transport-types" ).accordion({ collapsible: true, active:false, animate:
200 });

accomplishes what the point of this patch was. Marking as resolved/fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 01:20:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 20 Aug 2016 23:20:41 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-wQThRCciIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54655|0                           |1
        is obsolete|                            |

--- Comment #14 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54661&action=edit
Bug 17050: Do not kick the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (neither $ENV{HTTP_*}) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 01:20:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 20 Aug 2016 23:20:50 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-xURCHM53ly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54656|0                           |1
        is obsolete|                            |

--- Comment #15 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54662&action=edit
Bug 17050: (QA followup) Use Mojo::Transaction to get the remote address

While the original patch fixes the issue, reading at Mojolicious source code,
revealed
that Mojo::Transaction already has proper processing for detecting the remote
address:

sub remote_address {
  my $self = shift;

  return $self->original_remote_address(@_) if @_;
  return $self->original_remote_address unless $self->req->reverse_proxy;

  # Reverse proxy
  return ($self->req->headers->header('X-Forwarded-For') // '') =~ /([^,\s]+)$/
    ? $1
    : $self->original_remote_address;
}

Without this patch, if there's a request without HTTP_X_FORWARDED_FOR, then the
remote
address would be empty. Such would be the case of a dev/standard setup without
Plack.

This patch makes Koha::REST::V1::startup use tx->remote_address instead of
dealing with the
headers on its own.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 01:23:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 20 Aug 2016 23:23:30 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-Py7SLNveW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #16 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Good Mojo, Jonathan & Tomas! Working now as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 11:44:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 09:44:51 +0000
Subject: [Koha-bugs] [Bug 8073] Sound cue when checking in items on hold
In-Reply-To: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8073-70-JgwdTiHSmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This should be doable with the new audio alerts system now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 21:12:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 19:12:56 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-00nh24xCvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 21:12:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 19:12:59 +0000
Subject: [Koha-bugs] [Bug 17128] summary-print.pl is not plack safe
In-Reply-To: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17128-70-qqroBMH30a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54483|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54663&action=edit
[PASSED QA] Bug 17128: Make summary-print.pl plack safe

$borrowernumber is used in build_issue_data but not correctly defined
(Variable "$borrowernumber" is not available)

That may cause wrong charge displayed in the summary slip.

Test plan:
- Set rental charge for an item type
- Define a rental discount for that item type in the circ rules
- check in an item matching this rule
Without this patch the charge displayed in the summary slip won't be
calculated with the discount
With this patch applied, the warning in the logs will no longer appear
and the values will be correctly calculated.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 21:18:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 19:18:28 +0000
Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack
	safe
In-Reply-To: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16886-70-NyzDWTsfEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 21:18:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 19:18:30 +0000
Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack
	safe
In-Reply-To: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16886-70-waCABvEss0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53264|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54664&action=edit
[PASSED QA] Bug 16886: Make the 'Upload patron images' tool plack safe

Some vars are accessed from subroutine, but defined with my.
It causes at least the 2 followings errors:
Variable "$filetype" is not available at
/home/koha/src/tools/picture-upload.pl line 240.
Variable "$uploadfilename" is not available at
/home/koha/src/tools/picture-upload.pl line 241.

To avoid that, they are now declared with our.

Test plan:
Upload image for a patron and confirm that you get a "Result" table and
the errors do not longer appear in the logs.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:25:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:25:40 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-K4MxWYEyMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54665&action=edit
[PASSED QA] Bug 16960 - Patron::Modifications should be fixed

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Test Plan:
1) Apply this patch
2) Create some patron modification requests
3) Ensure you can approve and deny modifications
4) Ensure patron self registration works

Signed-off-by: Bob Birchall <bob at calyx.net.au>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:25:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:25:44 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-bVRyMVjrAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54666&action=edit
[PASSED QA] Bug 16960: Update 1 missing occurrence of GetModifications

Signed-off-by: Bob Birchall <bob at calyx.net.au>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:25:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:25:48 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-r3v5HimZ1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54667&action=edit
[PASSED QA] Bug 16960: Fix error on validating the registration

Followed steps in comment #14, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:25:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:25:52 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-UAKIvUWe2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54668&action=edit
[PASSED QA] Bug 16960: Delete previous patron modifications

If a patron edit his/her details a second time, we need to delete the
first ones to avoid a "duplicate entry for key PRIMARY" error.

Test plan:
Log in at the OPAC
Edit your details
Edit them again
=> Without this patch, Koha will crash
=> With the patch applied, everything should work as expected

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:26:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:26:41 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-8Xz1atV18W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:26:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:26:44 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-B642M8WDbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54080|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:26:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:26:46 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-yv9C0NYov1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54628|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:26:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:26:49 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-kPgqXmPm2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54461|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:26:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:26:51 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-bqQYSNaeGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54079|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:39:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:39:13 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-AcouqeyY9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54500|0                           |1
        is obsolete|                            |
  Attachment #54501|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54669&action=edit
[PASSED QA] Bug 7045: Use <<tag>> for default value placeholders

When adding a biblio, the default value of a MARC subfield defined in
the frameworks can be used as placeholders to set the current date or
the surname of the logged in user (use cases?).
The different placeholders are 'YYYY', 'MM', 'DD', 'user'.
When adding an item, same behavior except that 'user' is not replaced.

This patch makes behaviors consistent between the 2 editors and
surrounds placeholders with << >>
We will now have: <<YYYY>>, <<MM>>, <<DD>> and <<USER>>

Test plan:
Define default values for biblio and item subfields.
Create a bibliographic record and attach it an item.
The default values should be used and replaced if you used placeholders.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:39:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:39:09 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-HpFnlor4x2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 22:39:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 20:39:41 +0000
Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent
In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7045-70-6XfLNNsEAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54670&action=edit
[PASSED QA] Bug 7045: Update default value placeholders for existing installs

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 21 23:37:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 21 Aug 2016 21:37:44 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-uNntFtPutW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Mark, you are right! I missed that in the docs. Kyle, just upgrade the schema
files!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 04:23:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 02:23:46 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-16AUrvtAgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #192 from Liz Rea <liz at catalyst.net.nz> ---
Notably missing here is a view of a borrower's pending and in-process requests
from the borrower detail or circulation screens in the staff interface. That's
probably desirable, since there is a view of them in the OPAC. 

It could be a subset of the Holds tab, or it's own tab. 

An option to display branch wide (filtered, if necessary) completed requests,
and for individual borrowers would be a nice-to-have. Custom reports will get
the job done in the mean time, albeit a little inconveniently.

It might also be good to show requests as some kind of statistic for the
borrowers in the "Statistics" tab in the members area. "Articles requested"
maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 06:36:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 04:36:19 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-LZX4gWPRG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 06:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 04:36:23 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-Q95B9IAoSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54641|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54671&action=edit
[SIGNED-OFF] Bug 17118: (follow-up 15381) Fix regression when clearing a linked
authority

Changes made on bug 15381 assumed that the authid was always set.
But if the user wants to clear the field of the authority, the script is
called with authid=0 (FIXME...)

To fix this issue, it's better to move the new calls to
  Koha::Authorities->find($authid)->authtypecode
and
  Koha::Authority::Types->find($authtypecode);
at the correct place

Test plan:
1. Edit a record which has a field linked to an
   authority record (100a for instance).
2. Click the link which triggers the tag editor.
   A pop-up window should be displayed.
3. In the pop-up window, click the "Clear field"
   button.
=> Without this patch A second pop-up window opens and displays an error:
  Can't call method "authtypecode" on an undefined value at
/authorities/blinddetail-biblio-search.pl line 61.
=> With this patch applied the field is correctly cleared.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 07:33:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 05:33:11 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-U3DZfVFtVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

--- Comment #5 from paxed <pasi.kallinen at pttk.fi> ---
(In reply to M. Tompsett from comment #4)
> I believe upon further inspection that:
> 
>  $( "#transport-types" ).accordion({ collapsible: true, active:false,
> animate: 200 });
> 
> accomplishes what the point of this patch was. Marking as resolved/fixed.

Not really. The intention was to have the unused entries start as collapsed,
and the entries in use as open - easier to see with a glance which ones are in
use, without needing to scroll past the unused entries. If I understand
correctly, accordion will just make it even more awkward to see which ones are
in use.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 08:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 06:42:20 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-HL80yUoATm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #40)
> (In reply to Julian Maurice from comment #37)
> > Created attachment 54637 [details] [review] [review]
> > Bug 13501: Highlight select2 control if field is required and value is
> > missing
> 
> Are you sure you want to remove select2.min.css?

I didn't remove select2.min.css, I added a new file select2.css for custom CSS
related to select2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 08:44:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 06:44:35 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-pgy1WfLkP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 09:43:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 07:43:59 +0000
Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a
 production server will create duplicate fines!
In-Reply-To: <bug-13104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13104-70-8Pc52U0JxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Is the following warning for syspref "dateformat" still valid? 
("Do not change this preference on a production server with overdue items that
are accruing fines. Doing so will result in duplicate fines!")

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 09:58:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 07:58:19 +0000
Subject: [Koha-bugs] [Bug 16940] Show active currency's symbol to users in
	OPAC
In-Reply-To: <bug-16940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16940-70-g1j02EzaNi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:11:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:11:08 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-2Vr88ROaAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:14:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:14:07 +0000
Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point
In-Reply-To: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10253-70-vOHjGsVhxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:14:44 +0000
Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite
In-Reply-To: <bug-12825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12825-70-wTeJV2ROKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:16:15 +0000
Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/ shipping cost should be
 included PRE-gst tax (as an option)
In-Reply-To: <bug-11062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11062-70-2dlf2WC9sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:17:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:17:08 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-j4fWOTq67h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:17:52 +0000
Subject: [Koha-bugs] [Bug 16017] Currency constraints and poorly named prices
In-Reply-To: <bug-16017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16017-70-PFMRsgyRdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:23:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:23:58 +0000
Subject: [Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say
 book is available even though it it still checked out to someone else
In-Reply-To: <bug-4812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4812-70-JXqoWygzJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:35:45 +0000
Subject: [Koha-bugs] [Bug 4850] CheckReserves does not respect holds
	circulation policies
In-Reply-To: <bug-4850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4850-70-tXSejnxdMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Regarding comments #6 and #7:

Maybe there could be a hint in the description of syspref 'item-level_itypes'
and/or in 'Circulation and fine rule' for table 'Default holds policy by item
type'?

If yes, what would be a good wording?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:38:05 +0000
Subject: [Koha-bugs] [Bug 9412] add optional_params to C4::Service
In-Reply-To: <bug-9412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9412-70-MKKvGtQVAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:38:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:38:11 +0000
Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service
In-Reply-To: <bug-4439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4439-70-swMxmPRaNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 10:38:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 08:38:58 +0000
Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly;
	should use jQuery
In-Reply-To: <bug-4437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4437-70-yd7pd7kUox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Sill valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 11:16:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 09:16:56 +0000
Subject: [Koha-bugs] [Bug 17154] New: Note column iis missing on account
	lines receipt
Message-ID: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

            Bug ID: 17154
           Summary: Note column iis missing on account lines receipt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When displaying Fines > Account tab of a patron, you can see on screen a Note
column that is missing if you click on Print

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 11:27:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 09:27:45 +0000
Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a
 production server will create duplicate fines!
In-Reply-To: <bug-13104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13104-70-0tKY67I32m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

--- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marc V?ron from comment #8)
> Is the following warning for syspref "dateformat" still valid? 
> ("Do not change this preference on a production server with overdue items
> that are accruing fines. Doing so will result in duplicate fines!")

No longer valid for both preferences (dateformat, TimeFormat) since 16.05.
Still valid in 3.22 (oldstable).

Changing the format[s] in production 16.05+ would not affect the existing fines
descriptions though (nor the entries in actionlogs, ...) so such changes may
cause some inconsistencies in fines descriptions display; fines created after
the syspref changes will have time/date part in description formatted
differently.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 11:32:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 09:32:04 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-20oXL4RcFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Note column iis missing on  |Note column is missing on
                   |account lines receipt       |account lines receipt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 12:05:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 10:05:09 +0000
Subject: [Koha-bugs] [Bug 17155] New: problem with acquisition receive
	shipment file
Message-ID: <bug-17155-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17155

            Bug ID: 17155
           Summary: problem with acquisition receive shipment file
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hirakhazarika2014 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 54672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54672&action=edit
when I try to receive the order book in receive shipment After putting invoice
number showing as like attachment picture . It should be showing book details
with receive option.

Dear 
Sir/ Madam

With due respect, it is hereby informed you that I have given a order to one
vendor when I try to receive  the order. After that I click the receive
shipment option and try to receive the order but when I try to receive the
order whatever book I have given in order nothing showing in receive shipment
file. So that I can not receive the book and it is also not showing  vendor
account details. What I have to do for show book receive option and vendor
account details. It is should be showing books details after putting invoice
number in receive shipment file with receive option. So that kindly see the
problem as mention.( Koha version 16.05.02)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 12:11:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 10:11:31 +0000
Subject: [Koha-bugs] [Bug 17155] problem with acquisition receive shipment
	file
In-Reply-To: <bug-17155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17155-70-XEos1Umg2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hirak,

this is not likely to be a bug, so it's better suited for the mailing list. I
have seen you already sent it there, please take a look at the answer from
Michael Kuhn: https://lists.katipo.co.nz/pipermail/koha/2016-August/046057.html

That said, did you close the basket with you orders? It's the most common
reason for what you describe.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 12:13:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 10:13:55 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-59FiwWA85S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

--- Comment #1 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 54673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54673&action=edit
Bug 17154 : Note column is missing on account lines receipt

    When displaying Fines > Account tab for a patron, you can see on screen a
Note column that is missing if you click on Print

    Test plan :
    * Find a patron with accountlines or add them manually (Create manual
invoice/credit).
    * Be sure some of them got a Note
    * Clik on Print fior those lines

    Without patch, the printed receipt does not show the Note column
    with the patch, the printed receipt shows a Note column and Note content is
correctly printed for accountline with a note.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 12:21:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 10:21:38 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-EMI3T7IJvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
I also think the plugin is a good solution. It keeps the code DRY. There is a
distinct likelihood that we will want to display the holds count in other
places in the future. The plugin means we only need to modify half the files we
would need to otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:01:22 +0000
Subject: [Koha-bugs] [Bug 17155] problem with acquisition receive shipment
	file
In-Reply-To: <bug-17155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17155-70-Vv76TvCmIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17155

--- Comment #2 from Hirak Jyoti Hazarika <hirakhazarika2014 at gmail.com> ---
1.No Sir, I did not close the basket at the order time. I am using koha 16.05
version on Lubuntu 14.04. I have created one vendor and one basket and I order
some book and when I try to receive the book in receive shipment module. i have
putted my vendor invoice and after that i have given next option. Nothing
showing in receive shipment module. it is should be showing all book details
with receive option. In my case book details is not showing. 

2. How can i see all book details in receive shipment module in Acquisition
with receive option and vendor account details.
 suggestion please

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:02:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:02:50 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-ShwPG1ADaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:02:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:02:54 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-cUCNXdHe5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54634|0                           |1
        is obsolete|                            |
  Attachment #54635|0                           |1
        is obsolete|                            |
  Attachment #54636|0                           |1
        is obsolete|                            |
  Attachment #54637|0                           |1
        is obsolete|                            |
  Attachment #54638|0                           |1
        is obsolete|                            |

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54674&action=edit
Bug 13501: Add JS library select2 3.5.4

use it on cataloguing and batch items edit pages

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:02:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:02:59 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-nxFhqar4vA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54675&action=edit
Bug 13501: Indentation fix (batchMod-edit.tt)

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:03:03 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-p4I5a9y4VL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54676&action=edit
Bug 13501: Move "Required" and checkbox after input/select

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:03:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:03:08 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-DEQhebrKa6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54677&action=edit
Bug 13501: Highlight select2 control if field is required and value is missing

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:03:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:03:12 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-kNipF6ha2s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54678&action=edit
Bug 13501: Fix behavior of 'Delete subfield' button on select2 controls

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:03:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:03:46 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-4pu0JEVfQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #41)
> (In reply to Jonathan Druart from comment #40)
> > (In reply to Julian Maurice from comment #37)
> > > Created attachment 54637 [details] [review] [review] [review]
> > > Bug 13501: Highlight select2 control if field is required and value is
> > > missing
> > 
> > Are you sure you want to remove select2.min.css?
> 
> I didn't remove select2.min.css, I added a new file select2.css for custom
> CSS related to select2

Sorry I have misread the diff, everything is fine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:07:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:07:00 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-tEwk8yRY2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16583

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:07:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:07:00 +0000
Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu
 16.04 and MySQL 5.7
In-Reply-To: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16583-70-moUfwTAYFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |unspecified
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16402,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16664,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16573
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:07:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:07:00 +0000
Subject: [Koha-bugs] [Bug 16664] SQL issues in 16.05 preventing installation
	in MySQL 5.7
In-Reply-To: <bug-16664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16664-70-BXhuD5Eo7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16664

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16583

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:07:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:07:00 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-zhF4F0EpRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16583

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:27:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:27:17 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-mVe7Jvtg2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
CCing Katrin, Tomas, Marcel and Martin.

It's not clear to me when we need a TT plugin.
Sometimes it's obvious (get branch names, get patron category description,
filter (json, date, price), pref values, etc.)
But sometimes it's not: Borrowers.IsDebarred, Borrowers.HasOverdues.
Holds.count is part of this second group.

I don't think plugins should be a lazy solution for developers.

We need to define when we can use a plugin, otherwise any methods from Koha
modules could have their plugin wrapper.

And we will have to maintain:
  Koha::Holds->count({biblionumber => $biblionumber });
  Koha::Template::Plugin::Holds->count($biblionumber);
and
  Koha::REST::V1::Hold->count($biblionumber);?# does not exist (yet)

(I don't switch to in discussion otherwise you will hate me)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:35:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:35:10 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-Q5pmPR35Sc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54661|0                           |1
        is obsolete|                            |
  Attachment #54662|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54679&action=edit
Bug 17050: Do not kick the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (neither $ENV{HTTP_*}) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:35:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:35:15 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-fM7D9wjXUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54680&action=edit
Bug 17050: (QA followup) Use Mojo::Transaction to get the remote address

While the original patch fixes the issue, reading at Mojolicious source code,
revealed
that Mojo::Transaction already has proper processing for detecting the remote
address:

sub remote_address {
  my $self = shift;

  return $self->original_remote_address(@_) if @_;
  return $self->original_remote_address unless $self->req->reverse_proxy;

  # Reverse proxy
  return ($self->req->headers->header('X-Forwarded-For') // '') =~ /([^,\s]+)$/
    ? $1
    : $self->original_remote_address;
}

Without this patch, if there's a request without HTTP_X_FORWARDED_FOR, then the
remote
address would be empty. Such would be the case of a dev/standard setup without
Plack.

This patch makes Koha::REST::V1::startup use tx->remote_address instead of
dealing with the
headers on its own.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:36:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:36:37 +0000
Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses
	biblioitems.itemtype
In-Reply-To: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13452-70-lwxN0CZZwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|katrin.fischer at bsz-bw.de    |julian.maurice at biblibre.com
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:45:55 +0000
Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
In-Reply-To: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16960-70-qPXaj09fCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks for the followups Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:46:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:46:58 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-KjWOzWuHpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From catalogue/detail.pl:

#we only need to pass the number of holds to the template
my $holds = C4::Reserves::GetReservesFromBiblionumber({ biblionumber =>
$biblionumber, all_dates => 1 });
$template->param( holdcount => scalar ( @$holds ) );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 13:59:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 11:59:13 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-AqO04ymdp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I was also wondering why
  my $nb_holds = Koha::Holds->count({ biblionumber => $biblionumber })->count;
and not something like
  my $nb_holds = Koha::Biblios->find(biblionumber)->get_holds->count

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:07:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:07:40 +0000
Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the
	search results
In-Reply-To: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14876-70-59RMRZIia4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #11)
> and not something like
>   my $nb_holds = Koha::Biblios->find(biblionumber)->get_holds->count

Hm. Does not really look nice to me.
Apart from looking up the biblio record without using it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:08:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:08:12 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-cgCSDnyEs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

some issues here:
1) You forgot to remove the update_location file form svc that is no longer
used.
2) when changing the pickup location I get an alert "You want to change the
pickup location?" - I am not sure this kind of message is necessary, we usually
only seem to ask for confirmation when something is deleted.
3) After confirming the message, I get an error alert: There was an error:error
Method Not Allowed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:09:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:09:04 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-Fu9gqm1JQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah, one more small thing, could we use "updated" instead of "set" to indicate a
change? "set" is quite hard to translate correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:09:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:09:12 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-0ly3ESYS6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #7 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54682&action=edit
Bug 17004: Add API route for logging out user

To test:
1. Login to Koha either by newly introduced POST /auth/session
   or traditional way.
2. Send a DELETE request to /auth/session
3. Observe that you are no longer logged-in in Koha.
4. Repeat step 2 and observe error about invalid session id.

You may find this cURL useful:
curl -X DELETE http://lib/api/v1/auth/session --cookie
'CGISESSID=88e735aaf7c6cf194a775425cbd00570'
(replace CGISESSID=... with your CGISESSID)


Current status: Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:10:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:10:44 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-RRxNogshl8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:10:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:10:46 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-oVehSN8LCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54682|0                           |1
        is obsolete|                            |

--- Comment #8 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54683&action=edit
Bug 17004: Add API route for logging out user

To test:
1. Login to Koha either by newly introduced POST /auth/session
   or traditional way.
2. Send a DELETE request to /auth/session
3. Observe that you are no longer logged-in in Koha.
4. Repeat step 2 and observe error about invalid session id.

You may find this cURL useful:
curl -X DELETE http://lib/api/v1/auth/session --cookie
'CGISESSID=88e735aaf7c6cf194a775425cbd00570'
(replace CGISESSID=... with your CGISESSID)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:11:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:11:54 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-Z3HmkAEDlh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #9 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Lari Taskula from comment #7)
> Current status: Signed Off
Uncommented wrong line in git bz attach. Current status is Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:17:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:17:37 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-PSWtsXzbzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Nick Clemens from comment #11)

> Use fa spinning icon while waiting

Do you have a plan to replace other spinners in the interface with this
version? We need to keep things consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:25:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:25:21 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-R1Dt4KVHLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54683|0                           |1
        is obsolete|                            |

--- Comment #10 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54684&action=edit
Bug 17004: Add API route for logging out user

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:28:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:28:47 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-g3gfLLR1XK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Resetting status to ASSIGNED as this needs some work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:41:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:41:46 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-R3U8CmYDwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Closing this bug as the original bug is certainly fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:43:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:43:00 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-t12KPJPRWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54196|0                           |1
        is obsolete|                            |

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54685&action=edit
Bug 13895: Reword borrowers to patrons in tags

We probably want to use patrons instead of borrowers; otherwise we would have
both tags since /patrons adds "patrons" as well.

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:43:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:43:33 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-Ya5E8fc0As@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> ---
Signed off the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:44:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:44:06 +0000
Subject: [Koha-bugs] [Bug 17156] New: Record matching on tag 001 does not
	work
Message-ID: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

            Bug ID: 17156
           Summary: Record matching on tag 001 does not work
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: joachim.ganseman at ehb.be
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Reproduction of the problem:
- Stage and import a MARC21 record that contains data in Field 001. Update the
zebra-index if necessary.
- Define a record matching rule (in Administration -> Record Matching Rules) on
Field 001: Search index = Control-number ; Tag = 001 ; leave Subfield, Offset
and Length empty.
- Now import the exact same record again, using this matching rule.

Expected result: match found
Actual result: no match found

My gut feeling is that because 001 is a Control Field without any subfields,
something goes wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:44:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:44:05 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-tGCojjywtg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53837|0                           |1
        is obsolete|                            |

--- Comment #15 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54686&action=edit
Bug 16825: (followup) Add API route for getting an item

Fixed tab-character.

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:44:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:44:27 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-F9JTfK8ur3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54052|0                           |1
        is obsolete|                            |

--- Comment #16 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54687&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Signed-off-by: Jiri Kozlovsky <mail at jkozlovsky.cz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:45:12 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-Tret2Gf09Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17157

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:45:12 +0000
Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to
 additem.pl causes software error
In-Reply-To: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16750-70-wVKE2A1ofj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17157

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:45:12 +0000
Subject: [Koha-bugs] [Bug 17157] New: Middle click on dropdown menu in
 header may cause software error.
Message-ID: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

            Bug ID: 17157
           Summary: Middle click on dropdown menu in header may cause
                    software error.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

This bug is related to bug 16750 and found in bug 13980 (from comment 8)

If you save an item and right click on "Search" or "More" you will get a
software error:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:48:35 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-fY94Aczg0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54688&action=edit
Bug 17157: Fix middle click on "Search" drowndown menu

If you save an item and right click on "Search" or "More" you will get
a software error:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

You will now be redirected to the adv search form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:48:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:48:51 +0000
Subject: [Koha-bugs] [Bug 17156] Record matching on tag 001 does not work
In-Reply-To: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17156-70-7FKdwFKSjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Which version did you test this in? How does your 001 field look like?

We use matching on Control-number in almost all our installations up to 3.22.x
- so I hope it's a configuration issue and not a bug (and if it's a bug, we
should fix this really fast)

Can you share a screenshot of your matching-rule set-up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:49:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:49:48 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-vya2rcK2c4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54689&action=edit
Bug 17157: Same for "More"

Here I decided to redirect to the mainpage.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:50:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:50:53 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-ZZmZDs8zLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
These patches are not ideal but could provide a workaround.
Bug 16750 fails to provide a correct fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 14:52:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 12:52:42 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: <bug-14699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14699-70-Z797T4mUyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Owen Leonard from comment #7)
> (In reply to Nick Clemens from comment #6)
> 
> > 2 - Select all searches but respect filters.  If I filter down to 8 searches
> > it should select only those.  If my filter finds 21 searches (default 20
> > visible) it should select all 21, but not searches limited by filter. 
> > Labels would say "With ## selected searches: delete"
> 
> I think this is the correct goal. With a filtered result clicking "select
> all" shouldn't select lines which are not visible because of the filter.
> However, with a filtered or unfiltered result clicking "select all" should
> select records across all pages.

I think there is a problem with this solution: we can't do that with
AJAX-paginated tables. It's not the case of this particular table, but if we
want to have a consistent behaviour for all the "Select all/Clear all" buttons
we must do something that is possible on every table.
So, for this particular table I suggest to keep the current behaviour, change
only the labels to "Select all visible rows" or something similar, and maybe
add an action "Clear all history" ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:01:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:01:21 +0000
Subject: [Koha-bugs] [Bug 17158] New: Restart memcached after update
Message-ID: <bug-17158-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17158

            Bug ID: 17158
           Summary: Restart memcached after update
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

If memcached is enabled, an update with Debian packages may lead to the
webinstaller showing instead of staff login. It stops after the memcached
service is restarted. This should be automated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:02:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:02:52 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-VtEbYhnOHs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #37)
> As far as I understand, my followup takes care of the error handling
> problem. 

Not sure about that.
You just run them one after another without looking at the exit code of the
previous script as initially proposed.
Since this keeps package and non-package more in sync, I would agree though.

I think we c/should try to resolve the effects of a failing cronjob on other
cronjobs in another report. Some implicit consensus about that in the former
comments. Sounds like a larger thing btw than just an exit code.
And now fix the obvious order.
[ Anyone still willing to write the koha-cron.pl that does it all (moving all
code to modules)? .. ]

Can we merge both patches and have these cronjobs on separate lines again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:11:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:11:36 +0000
Subject: [Koha-bugs] [Bug 17058] Automatic renewals broken when
 BorrowerRenewalPeriodBase is set to current day
In-Reply-To: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17058-70-IUCjfRpmx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.hedstrom.mace at sub.s
                   |                            |u.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:18:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:18:36 +0000
Subject: [Koha-bugs] [Bug 17156] Record matching on tag 001 does not work
In-Reply-To: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17156-70-ZusPucYy44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

--- Comment #2 from joachim.ganseman at ehb.be ---
Created attachment 54690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54690&action=edit
Screenshot of matching rule

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:25:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:25:28 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-QTtt9ILwFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:25:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:25:41 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-DkbDqQuL3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:26:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:26:01 +0000
Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in
	notice editor
In-Reply-To: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12236-70-ggyD6d3aLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Feel free to fix it then. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:30:25 +0000
Subject: [Koha-bugs] [Bug 17156] Record matching on tag 001 does not work
In-Reply-To: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17156-70-LrbMpEzK34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

--- Comment #3 from joachim.ganseman at ehb.be ---
I sincerely hope too that it's a config mishap :) A screenshot was just
attached. I'm using Koha 16.05 on Ubuntu Trusty (14.04) with all of the latest
package updates installed.

Actually what happens is that there is no match detected on 001, so a new
bibliographic record gets made, however the accompanying 952 item does get
detected as a duplicate barcode (match on 952$p), so the item is not added. Net
result: 2 biblios with only 1 having an item attached.

Our field 001 is populated with the internal shelfmark. This can be any text
string, including spaces, punctuation, and alphanumeric characters including
capital letters. But I'm currently testing with a file that contains only
simple 5-digit numbers in that field, and there I can't get it to match either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:34:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:34:15 +0000
Subject: [Koha-bugs] [Bug 17159] New: Cron: whats the use of --noemail
 cleanup_database.pl --mail
Message-ID: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

            Bug ID: 17159
           Summary: Cron: whats the use of --noemail cleanup_database.pl
                    --mail
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

We have two lines for cleanup_database in cron.
koha-foreach --enabled /usr/share/koha/bin/cronjobs/cleanup_database.pl
--sessions --zebraqueue 10 --list-invites
koha-foreach --enabled --noemail
/usr/share/koha/bin/cronjobs/cleanup_database.pl --mail

The second line contains an noemail parameter that seems to be unused.
What is it doing there ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:34:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:34:54 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-peq2B6dYXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:38:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:38:37 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-GvttWtcKPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54514|0                           |1
        is obsolete|                            |

--- Comment #56 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54691&action=edit
Bug 14504: Add delete_items.pl: a command line batch deletion tool

http://bugs.koha-community.org/show_bug.cgi?id=14504

Signed-off-by: Heather Braum <hbraum at nekls.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:38:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:38:45 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-MRKhtMp4xu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54515|0                           |1
        is obsolete|                            |

--- Comment #57 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54692&action=edit
Bug 14504: (QA followup)

* Fix POD warning.
* Remove redundant 'use stric' and 'use warnings'
* Remove $VERSION and --version option.
* Remove --dry-run option
* Split test for --help and check for @criteria into two separate pod2usage
calls,
    enabling -msg on the latter.
* Fix 'target_tiems' typo.
* Test for holds on items to be deleted.
* Fix whitespace
* Fix test for holds.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:38:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:38:54 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-CPJmWDnCaE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54516|0                           |1
        is obsolete|                            |

--- Comment #58 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54693&action=edit
bug 14504: split logic from DelItemCheck() into ItemSafeToDelete()

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:39:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:39:02 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-729JeMwFuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54517|0                           |1
        is obsolete|                            |

--- Comment #59 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54694&action=edit
bug 14504: use C4::Items::DelItemCheck in delete_items.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:39:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:39:18 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-z3g2SwH7cl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54518|0                           |1
        is obsolete|                            |

--- Comment #60 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54695&action=edit
Bug 14504: (QA followup) use TestBuilder, remove do_not_commit

Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t

Remove the option 'do_not_commit' from C4::Items::DelItemCheck.

Whitespace cleanup.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:39:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:39:30 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-pNmhbZIjWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54519|0                           |1
        is obsolete|                            |

--- Comment #61 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54696&action=edit
bug 14504: (QA followup) fixing DelItemCheck arguments

Remove $dbh as argument to C4::Items::DelItemCheck
and C4::Items::ItemSafeToDelete, also change all
calls to these functions throughout the codebase.

Also remove remaining reference to 'do_not_commit' in
t/db_dependent/Items_DelItemCheck.t

Fixed doubled "$$" in C4/ImportBatch.pm

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:39:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:39:40 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-S8EU5kvgAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54520|0                           |1
        is obsolete|                            |

--- Comment #62 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54697&action=edit
Bug 14504: (QA followup) fix test transaction, book_on_loan

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:39:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:39:49 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-40phiKpzmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54521|0                           |1
        is obsolete|                            |

--- Comment #63 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54698&action=edit
Bug 14504: (QA followup) Tidy tests

This patch re-introduces the transaction into
t/db_dependent/Items_DelItemCheck.t
and does some cleaning on the touched tests so they raise less warnings.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:40:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:40:05 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-NKDsCPaFRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54522|0                           |1
        is obsolete|                            |

--- Comment #64 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54699&action=edit
Bug 14504: (QA followup) Fix delete_records_via_leader.pl call to DelItemCheck

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:40:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:40:25 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-aUzBMxuMSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54525|0                           |1
        is obsolete|                            |

--- Comment #65 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54700&action=edit
Bug 14504: Changes missed while fixing patches

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:40:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:40:33 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-AFhbzOApY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54530|0                           |1
        is obsolete|                            |

--- Comment #66 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54701&action=edit
Bug 14504: (QA followup) Fix error causing item not to be deleted

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:40:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:40:44 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-uUSkHBK5dl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54531|0                           |1
        is obsolete|                            |

--- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54702&action=edit
Bug 14504: (QA followup) Change argument --criteria to --where

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:40:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:40:53 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-J9Dc0KLqms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #68 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54703&action=edit
Bug 14504: (followup) Make deletion conditional on --commit

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 15:41:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 13:41:25 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/ withdrawn statuses
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-bd9Tpj8uof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:02:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:02:45 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-TOgpjCwlyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:07:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:07:50 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-xbWQdGDBaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|15675                       |14390
                 CC|                            |kyle at bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390
[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675
[Bug 15675] Add issue_id column to accountlines and use it for updating fines
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:07:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:07:50 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-ZgDO3uJmjQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135
[Bug 17135] Fine for the previous overdue may get overwritten by the next one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:07:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:07:50 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-uR1SJZRcNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17135                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135
[Bug 17135] Fine for the previous overdue may get overwritten by the next one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:08:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:08:03 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-qDx6aQUAKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15675


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675
[Bug 15675] Add issue_id column to accountlines and use it for updating fines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:08:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:08:03 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-t9W57i0oJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135
[Bug 17135] Fine for the previous overdue may get overwritten by the next one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:14:29 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-l9mayDT1H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:14:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:14:32 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-VuNvCcIs2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54704&action=edit
Bug 14390 [QA Followup] - Never try to update closed out fines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:15:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:15:37 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-dDj3Dd0IjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:15:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:15:40 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-gbvNrXLzIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54470|0                           |1
        is obsolete|                            |
  Attachment #54471|0                           |1
        is obsolete|                            |
  Attachment #54472|0                           |1
        is obsolete|                            |
  Attachment #54503|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54705&action=edit
Bug 17109: Remove second authentication from (opac-)sendbasket

Patch deals with opac and intranet variant.
If we authenticated the first time, it is not necessary to do it
a second time rightaway.

Replaces a call to get_template_and_user (including checkauth) by
gettemplate.

Also removes duplicate use C4::Biblio statements.

Test plan:
[1] Put a few books in the cart.
[2] Send the cart from OPAC.
[3] Send the cart from intranet.

Tested 3 patches together. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:15:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:15:44 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-4v4fAJKUgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54706&action=edit
Bug 17109: Add CSRF token to [opac-]sendbasket

If you have no (valid) token, you will not be able to send the message.

Test plan:
[1] Verify if you can still send the cart from opac and intranet.
[2] While still being logged in, try to send the cart from opac by
    using the following URL:
   
/cgi-bin/koha/opac-sendbasket.pl?email_add=you at somedomain.com&comment=csrf_test&bib_list=doesnotmatter&csrf_token=justsomeguess12345
    This should now result in a csrf error.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:15:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:15:48 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-qew7AS4oN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54707&action=edit
Bug 17109: Use Koha.Preference in sendbasket template

No need to send OPACBaseURL to the template, if you load the Koha TT
plugin inside the template.

Test plan:
Send a few items in your cart from OPAC and intranet.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:15:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:15:55 +0000
Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication,
	add CSRF token
In-Reply-To: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17109-70-r7kOJ7kOLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54708&action=edit
Bug 17109: [QA Follow-up] Die when wrong token

Removes template var csrf_error and associated handling.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Restested with opac and intranet: Still sends or dies elegantly..

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:16:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:16:09 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-1k1C0X0LIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #45)
> > How to solve this? Can we remove the issue id in accountlines after
> > switching to F? Or should UpdateFine no longer update a F record although it
> > has the right issue id, but add a new record?
> 
> I think it should add a new line as it's a 'new fine'. If we differentiate
> between F and FU cleanly, we can keep the issue_id too, I think?

Katrin has is exactly. If the same checkout goes overdue twice, the patron
should have two separate fines ( and each one will show a different due date
for the same checkout ).

This new followup will stop UpdateFine from updating closed out fines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:18:29 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-iAL9rt4m7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
We should never remove the issue_id from an accountline. It's not a foreign key
because of the way we move issues to the old_issues table. It is necessary in
order to know which checkout a fine is related to.

The solution is pretty simple, we should never update closed out fines (
account type 'F' ). My latest followup on bug 14390 implements this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:21:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:21:29 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-eqhn2iyU7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The test case already exists a few lines after.
What you want to do is to move it before the ELSIF ISSUE.auto_renew tests, not
to add another one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:21:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:21:56 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-4kIIdDWUg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |h.meissner.82 at web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:23:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:23:03 +0000
Subject: [Koha-bugs] [Bug 17160] New: Foreign key constraint for
 message_transports is too loose
Message-ID: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

            Bug ID: 17160
           Summary: Foreign key constraint for message_transports is too
                    loose
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

I think this is the probable cause for Bug 13171.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=a05ef0684ae98f3fa1808fbc1533e43f684ebe9f;hb=HEAD#l2544

The message transports definition

--
-- Table structure for table `message_transports`
--

DROP TABLE IF EXISTS `message_transports`;
CREATE TABLE `message_transports` (
  `message_attribute_id` int(11) NOT NULL,
  `message_transport_type` varchar(20) NOT NULL,
  `is_digest` tinyint(1) NOT NULL default '0',
  `letter_module` varchar(20) NOT NULL default '',
  `letter_code` varchar(20) NOT NULL default '',
  `branchcode` varchar(10) NOT NULL default '',
  PRIMARY KEY  (`message_attribute_id`,`message_transport_type`,`is_digest`),
  KEY `message_transport_type` (`message_transport_type`),
  KEY `letter_module` (`letter_module`,`letter_code`),
  CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`)
REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON
UPDATE CASCADE,
  CONSTRAINT `message_transports_ibfk_2` FOREIGN KEY (`message_transport_type`)
REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE
CASCADE ON UPDATE CASCADE,
  CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`,
`letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`,
`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

Has

`message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON
UPDATE CASCADE,
  CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`,
`letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`,
`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE

The foreign key contstraints `module`, `code`, `branchcode` do *NOT* uniquely
identify a row in the letter table, because message_transport_type may vary.
Therefore, a deletion *any* message transport type will delete *all* rows
matching `module`, `code`, `branchcode`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:23:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:23:27 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-VhsiBlSPmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:25:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:25:37 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on data in items table.
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-eJD2DASo1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add command-line script to  |Add command-line script to
                   |batch delete items based on |batch delete items based on
                   |lost/withdrawn statuses     |data in items table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:29:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:29:01 +0000
Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for
 message_transports is too loose
In-Reply-To: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17160-70-MQX0w1fupm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:30:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:30:44 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-Skz3WcpKhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you please detail why you need this change?
I will break the following use case:
- Start to fill a form
- *Ring belt end of the day*
- you hurry up to get back at home quickly
- Tomorrow morning, you finish to fill the form
- Submit
- You lost your changes

Ok it's a bit far-fetched but I don't understand what will bring us this
8-hours limitation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:37:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:37:19 +0000
Subject: [Koha-bugs] [Bug 17156] Record matching on tag 001 does not work
In-Reply-To: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17156-70-TJY9aLdzxy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

joachim.ganseman at ehb.be changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from joachim.ganseman at ehb.be ---
Yikes, it was my fault after all - turns out my index still wasn't updated -
maybe I tried to be too fast. Or there's some caching issue on my system. In
any case, the exact same configuration now works flawlessly for me.

I did notice that zebra couldn't get to the correct /var/lock directory after
my last reset of the DB though, but after a sudo chown on that directory to the
koha user on my system, that seemed to work.

I'll delete this bugreport then. Terribly sorry for the scare :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:43:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:43:21 +0000
Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's
	renewability
In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17003-70-60GuREWeJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:43:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:43:24 +0000
Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's
	renewability
In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17003-70-0NpSbBi5mJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54709&action=edit
Bug 17003: Add API route to get checkout's renewability

GET /checkouts/{checkout_id}/renewability (renewability status)

Response:
- 200: renewable (empty response object {})
- 403: not renewable (or not authorized to make renewals)

To test:
1. Login to Koha
2. Checkout something for yourself
3. Make GET request to http://yourlibrary/api/v1/checkouts/YYY/renewability
   where YYY is checkout_id of your checkout.
4. Observe returned data and HTTP code (200 for renewable, 403 for not
renewable)
   If not renewable, an error should also be presented.
5. Run t/db_dependent/api/v1/checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:44:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:44:42 +0000
Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's
	renewability
In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17003-70-9ehKNIdqiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54709|0                           |1
        is obsolete|                            |

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54710&action=edit
Bug 17003: Add API route to get checkout's renewability

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:55:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:55:23 +0000
Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-ZbMfMZPM1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for
xnciptoolkit drivers
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 16:55:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 14:55:23 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-X7UJaV9hmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16826


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
[Bug 16826] Add API routes for getting item availability and holdability
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 17:13:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 15:13:37 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-fpUcDUeocS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54684|0                           |1
        is obsolete|                            |

--- Comment #11 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54711&action=edit
Bug 17004: Add API route for logging out user

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 17:45:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 15:45:08 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-hK79bscx3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 17:45:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 15:45:11 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-pV3pJyWzVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54712&action=edit
Bug 8030 - (QA followup)     Remove svc file no longer user     Use animated
gif for waiting as elsewhere     Remove confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 17:47:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 15:47:20 +0000
Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification
	templates
In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13560-70-a4fJJCVzMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 17:48:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 15:48:53 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-cSOxiNfR4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #13)
> 3) After confirming the message, I get an error alert: There was an
> error:error Method Not Allowed

I don't see this one, do you have the REST API running?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 18:17:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 16:17:17 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-ldTwFlcKPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 18:41:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 16:41:51 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-C4Yf9QeP6M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Sorry, while applying I get:
"fatal: sha1 information is lacking or useless (opac/opac-user.pl)"
Can not fall back to 3-way-merge because of missing Blobs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 18:52:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 16:52:02 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-zOoe5DR5OP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I haven't installed the RESTful API or activated it. I didn't suspect it to
be a mandatory thing at this point in time, am I mistaken?
Owen had the same error message testing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 18:58:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 16:58:56 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-FXonuypteI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #18)
> Hm, I haven't installed the RESTful API or activated it. I didn't suspect it
> to be a mandatory thing at this point in time, am I mistaken?
> Owen had the same error message testing this.

As of bug 17030 the REST API should be activated by default for new
installs/upgrades and this feature is based on that assumption.

If you add Mirko's nightly builds to your apt sources and upgrade then all
should be running:
https://apt.abunchofthings.net/koha-nightly/

you can test by accessing the staff url of your site at
http://localhost:8081/api/v1/holds

Updating hostname/port as necessary

If all is working you will get a JSON blob of the holds in your system

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:07:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:07:30 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-YXSJLsSSa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54688|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 54713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54713&action=edit
Bug 17157: Fix middle click on "Search" drowndown menu

If you save an item and right click on "Search" or "More" you will get
a software error:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

You will now be redirected to the adv search form.

Wors as described.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:08:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:08:18 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-PXki9lsqlB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54689|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 54714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54714&action=edit
Bug 17157: Same for "More"

Here I decided to redirect to the mainpage.

Works as dexcribed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:08:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:08:44 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-kQrDJp67DA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:09:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:09:27 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to deleted a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-3W5xF366PR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> Nick,
> There is already a big warning when you try to delete a record used in
> orders.
> I do not understand why we should block the user to do it.

Hmm...yes you do get a big warning, I guess I still find it bothersome that the
user can't fix it once they have made this decision, maybe instead of
preventing delete we should add a method for reattaching the order to a record?

Also, if you 'Delete items in a batch' and choose 'Delete record if no items
remain' you do not receive the warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:10:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:10:54 +0000
Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined
 value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl
In-Reply-To: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13980-70-kvHfan36sU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

--- Comment #14 from Marc V?ron <veron at veron.ch> ---
(In reply to Marc V?ron from comment #11)
> Created attachment 54597 [details]
> Steps to get "Internal server error"
> 
> To reproduce:
> 
> - Add (not edit) a new item
> - Right click e.g. on "Search" in the top menu bar
> - Status line shows .../cgi-bin/koha/cataloguing/additem.pl#
> - In context menu, choose "Open link in new tab"
> Result: New tab opens with "Internal server error"

Fixed by Bug 17157

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:12:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:12:07 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-HkbeQqev1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|You should not be allowed   |You should not be allowed
                   |to deleted a record with    |to delete a record with
                   |open orders attached        |open orders attached
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:16:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:16:00 +0000
Subject: [Koha-bugs] [Bug 17156] Record matching on tag 001 does not work
In-Reply-To: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17156-70-OWlM81XPse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17156

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
All good :) Still a bit glad it's not a bug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:22:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:22:08 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-onxUIchEJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54658|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:22:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:22:20 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-vOW75u4RBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 19:32:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 17:32:33 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-oJI8Cj7Oyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am adding this to the agenda of the next dev meeting - I think if we make the
API mandatory, we need to take other steps too (amending installation
instructions for exapmle) and we should be aware of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:35:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:35:32 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-oQWaH8l2Oq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>Let user access their own checkouts and if OpacRenewalAllowed system preference
>is on, also let user to renew their checkouts.

I am concerned about this kind of behaviour. Would it mean that any user
(without any permission) can do this using the REST API as long as they can get
access to a valid session cookie/log into the OPAC?

This checks for OpacRenewalAllowed, but what about opacuserlogin?

Could we make this behaviour optional?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:43:52 +0000
Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price
	= 0
In-Reply-To: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14535-70-SMnnInij2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

--- Comment #3 from Sandre Cunha <cunha at monterey.org> ---
This is not an issue for us, as the only items we have with a price of zero are
pre-orders which will be published in the next fiscal year. We want them to
show in the OPAC to avoid patrons suggesting them, but use a zero price to keep
them from affecting the current budget. Just wanted the community to be aware
of this aspect when working on this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:44:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:44:44 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-U3CBDplGl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
All I have to say, is that this patches are really awesome :-D

Please rebase them on top of bug 17050, and port the fix so RestrictSessionByIP
isn't broken by this patchset.

Awesome job!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:45:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:45:28 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-3FhCB7njFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:50:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:50:12 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-tZ2Hm6cG1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

--- Comment #4 from Sandre Cunha <cunha at monterey.org> ---
(In reply to Ray Delahunty from comment #3)
> This remains a problem in 3.20 (we move to 16.05 soon). As a workaround we
> have set up a report to be run whenever an order is cancelled, to look for
> reservations. We have added this to the homepage, and our cataloging /
> acquisitions staff can easily access it.  
> 
> SELECT o.ordernumber, b.title, b.author, p.surname, p.firstname,
> r.reservedate, 
>        r.cancellationdate, r.branchcode
> FROM reserves r 
> LEFT JOIN borrowers p USING (borrowernumber)
> LEFT JOIN biblio b USING (biblionumber) 
> LEFT JOIN aqorders o USING (biblionumber)
> LEFT JOIN aqbasket n using (basketno)
> WHERE o.ordernumber=<<Order number>>
> 
> Better than nothing I suppose.
> 
> Ray Delahunty
> University of the Arts London

And then how are the patrons notified?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 20:56:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 18:56:49 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-2HvEJ5M8vA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #3 from Lee Jamison <ldjamison at marywood.edu> ---
Sorry about that, Marc!

I'm uploading an updated patch now which should correct that fatality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:01:22 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-z3LHDIgrF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54657|0                           |1
        is obsolete|                            |

--- Comment #4 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 54715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54715&action=edit
Bug 17153: Fixed Fail Fail

This updated patch should correct fatal error when applying 54657.

Forces redirect to search results after logging in on opac-search.pl

To test:
- Perform a catalog or EDS search
- Login from opac-search.pl
- Without the patch, the page should redirect to opac-user.pl
- Log out
- Apply patch
- Perform a search again
- Login again from opac-search.pl
- The page should redirect back to search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:24:02 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-G3yrFByM28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:34:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:34:46 +0000
Subject: [Koha-bugs] [Bug 16593] Access Control - Malicious user can delete
 the search history of another user
In-Reply-To: <bug-16593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16593-70-dkbgHvTRaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Koha                        |OPAC
              Group|Koha security               |
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:42:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:42:23 +0000
Subject: [Koha-bugs] [Bug 8073] Sound cue when checking in items on hold
In-Reply-To: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8073-70-zyJ8EC1SZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073

--- Comment #3 from Cab Vinton <bibliwho at gmail.com> ---
OK, thank you, Katrin!

For anyone else tracking this, ByWater has a helpful tutorial on how to use the
AudioAlerts functionality here:

http://bywatersolutions.com/2016/04/19/koha-3-22-custom-sound-alerts/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:42:27 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-9cu15dM22x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #48)
> (In reply to Katrin Fischer from comment #45)
> > > How to solve this? Can we remove the issue id in accountlines after
> > > switching to F? Or should UpdateFine no longer update a F record although it
> > > has the right issue id, but add a new record?
> > 
> > I think it should add a new line as it's a 'new fine'. If we differentiate
> > between F and FU cleanly, we can keep the issue_id too, I think?
> 
> Katrin has is exactly. If the same checkout goes overdue twice, the patron
> should have two separate fines ( and each one will show a different due date
> for the same checkout ).
> 
> This new followup will stop UpdateFine from updating closed out fines.

We are coming closer to a solution!
But please note that we need type F (imo) in the totalamount calculation and
the max fine reduction. We should focus on what happens next in UpdateFine.
The test $data->{'amount'} != $amount is not sufficient. Here we should exclude
type F somehow. But take care with $type that you get from CalcFine. It may not
be what you expect it to be ..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 21:54:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 19:54:52 +0000
Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price
	= 0
In-Reply-To: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14535-70-uQrwYJODdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sandre, what is your suggestion to resolve this? Would it be a problem if
those showed up as late orders after the normal period?

How are you treating gifts? I think one of the libraries explained that they
use 0 for tracking gifts that they expect to receive or have asked for or when
they don't know how much an item will cost.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 22:17:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 20:17:01 +0000
Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price
	= 0
In-Reply-To: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14535-70-QZSYWz92ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

--- Comment #5 from Sandre Cunha <cunha at monterey.org> ---
I don't think it would be a problem if the 0-priced items showed up on the late
list. I don't have a suggestion as I don
t quite understand the intended purpose of including

129             AND aqorders.rrp <> 0
130             AND aqorders.ecost <> 0

in the selection, and what the ramifications of removing one or both would be.

We do not "track" gifts in the manner you described, as ours are either gifts
of physical items or monetary donations (from which items are ordered in the
usual way, but from a trust fund account.)

A larger problem is that we do so much ordering of pre-publication items, and
there is no way to adjust the "lateness" according to the scheduled publication
date. For example, right now we have a purchase suggestion for an item that
will not be published until April 2017. We want to make the order to get the
item (by a popular author) into the OPAC so patrons can see it is on order and
place holds, but if I do that now, the item would be "late" in 30 days, even
though it will not be published for 6 months.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 22:56:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 20:56:46 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-mYLoFojbPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to David Cook from comment #2)
> I don't know if that means that people are using the Indexdata repositories
> or if they're just ignoring erroneous behaviour in Zebra when using ICU...

Probably the latter. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 23:12:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 21:12:31 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-4WUAuoDZNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I have just confirmed this issue.  I have tested the SIP response and can see
the AF field cycling through different responses each time we scan the item. 
This is pretty messed up.  Our self check has been showing the name of the
patron the item is on hold for in some instances.  Would love to see this fixed
ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 23:13:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 21:13:32 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-PKmPtq58d3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 22 23:59:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 21:59:26 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-E3NUonBind@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #12 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
wow, amazing work! very much like the code we use in production, but better!
AND with test coverage ;)

Would it be possible to also supply patron permissions in the response? I found
the easiest way was to just iterate against haspermissions thus:

+   my $permissions = haspermission($userid); # defaults to all permissions
+   # delete all empty permissions
+   while ( my ($key, $val) = each %{$permissions} ) {
+       delete $permissions->{$key} unless $val;
+   }

then you could just return $permission as a hash object

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:20:29 +0000
Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in
 their OPAC account
In-Reply-To: <bug-9699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9699-70-ASDbE7IJ5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|allow patrons to see notice |Allow patrons to see
                   |log                         |notices sent to them in
                   |                            |their OPAC account

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:24:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:24:14 +0000
Subject: [Koha-bugs] [Bug 9790] move item specific holds to circ matrix
In-Reply-To: <bug-9790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9790-70-EBkoV9odwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9790

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Item specific holds are now managed in the circulation conditions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:27:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:27:48 +0000
Subject: [Koha-bugs] [Bug 10814] Add a link to shelving locations / LOC
 authorised value for pointing to a map or similar
In-Reply-To: <bug-10814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10814-70-ectSSpi3qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|add a link to an authorized |Add a link to shelving
                   |value                       |locations / LOC authorised
                   |                            |value for pointing to a map
                   |                            |or similar

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:30:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:30:39 +0000
Subject: [Koha-bugs] [Bug 11895] Keep stats on course reserves
In-Reply-To: <bug-11895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11895-70-rlg5ig9mhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keep stats on reserves      |Keep stats on course
                   |                            |reserves
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Rereading this I think Nicole was referring to course reserves - not holds.
Changing the title.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:50:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:50:44 +0000
Subject: [Koha-bugs] [Bug 11895] Keep stats on course reserves
In-Reply-To: <bug-11895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11895-70-uaNwRGrTsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895

--- Comment #3 from Tom Misilo <misilot at fit.edu> ---
Yes it was in regards to course reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 00:52:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 22:52:52 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-BbJP8E00ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #6 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
I cannot reproduce the bug. Can someone check to see if this patch is still
necessary?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:00:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:00:02 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-wOwkJAadlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:00:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:00:07 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-NhNBI5JjY7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54629|0                           |1
        is obsolete|                            |
  Attachment #54630|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54716&action=edit
[SIGNED-OFF] Bug 17006: Add API route for changing patron's password

PATCH /patrons/{borrowernumber}/password (change password)

Required body params:
- current_password
- new_password

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
   that errors are displayed appropriately.

You may find this useful for testing:

curl -X PATCH http://library/api/v1/patrons/123/password
     --data '{"current_password":"123456", "new_password":"1234"}'
     --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:01:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:01:02 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-ojhli5P3X9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54716|0                           |1
        is obsolete|                            |

--- Comment #6 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54717&action=edit
[SIGNED-OFF] Bug 17006: Add API route for changing patron's password

PATCH /patrons/{borrowernumber}/password (change password)

Required body params:
- current_password
- new_password

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
   that errors are displayed appropriately.

You may find this useful for testing:

curl -X PATCH http://library/api/v1/patrons/123/password
     --data '{"current_password":"123456", "new_password":"1234"}'
     --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:01:11 +0000
Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's
	password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-P20MIp04sD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #7 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54718&action=edit
[SIGNED-OFF] Bug 17006: Respect system preference "OpacPasswordChange"

Allow patron to change their own password without borrowers-flag only
if OpacPasswordChange system preference is enabled.

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Set OpacPasswordChange system preference to "Don't allow".
4. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber for a borrower that does not
   have any permissions
5. Observe permission error.
6. Set OpacPasswordChange system preference to "Allow".
7. Repeat step 4 and make sure that password was changed.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:05:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:05:45 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-L98LlEUfnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:05:48 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-ys8owJWtXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54715|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54719&action=edit
[SIGNED-OFF] Bug 17153: Logging in during a search should navigate back to
search results

Forces redirect to search results after logging in on opac-search.pl

To test:
- Perform a catalog or EDS search
- Login from opac-search.pl
- Without the patch, the page should redirect to opac-user.pl
- Log out
- Apply patch
- Perform a search again
- Login again from opac-search.pl
- The page should redirect back to search results

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:10:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:10:38 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Ww88ZPYHzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
With all patches applied, all test succeed with Marc fix :)

git log --oneline | head -16
c1bfb24 Bug 16554: More i18n changes - uk-UA files
23001ea Bug 16554: More i18n changes - ru-RU files
ca09bf0 Bug 16554: More i18n changes - fr-FR files
72ca21d Bug 16554 - DO NOT PUSH - Follow up to testing script
4c32489 Bug 16554: Fix encoding on it-IT file
0644c60 Bug 16554: rewrite mandatory and sample data - de-DE
989c319 Bug 16554: rewrite mandatory and sample data - it-IT
9c6ce1d Bug 16554: More i18n changes - en, es, nb and pl files
c85d6e7 Bug 16554: DO NOT PUSH - (followup) - sorted filenames
79c2f1f Bug 16554: DO NOT PUSH - test for all sample files
1442061 Bug 16554: rewrite mandatory and sample data - pl-PL
596721f Bug 16554: rewrite mandatory and sample data - nb-NO
63afd53 Bug 16554: rewrite mandatory and sample data - es-ES
83b2d0d Bug 16554: Fix I18N sample files
1ba4ed1 Bug 16554: Fix fr-FR sample files
3315a88 Bug 17023: Repair "cancel" link

...
ok
All tests successful.
Files=1, Tests=1, 3975 wallclock secs ( 0.24 usr  0.02 sys + 10.02 cusr  1.48
csys = 11.76 CPU)
Result: PASS

Dropping and re-creating database and running for fr-FR only it's Ok, all
success.

$ prove -v t/db_dependent/Test_installer.t
t/db_dependent/Test_installer.t .. DBD::mysql::db do failed: Table
'koha_test_installer.systempreferences' doesn't exist [for Statement "
            SELECT * FROM systempreferences WHERE 1 = 0 "] at
/home/bgkriegel/kohaclone/Koha/Database.pm line 93.

loading kohastructure for fr-FR | not marc21
# 01/26: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql
...
# 26/26:
/home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql
loading kohastructure for fr-FR | not unimarc
# 01/24: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql
...
# 24/24:
/home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_simple_bib_frameworks.sql
ok 1 - No failures
1..1
ok
All tests successful.
Files=1, Tests=1, 327 wallclock secs ( 0.05 usr  0.00 sys +  2.01 cusr  0.22
csys =  2.28 CPU)
Result: PASS

Don't know what to think :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:18:16 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-OxGXWkvOqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:18:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:18:19 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-szkjjFp3hw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54640|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54720&action=edit
[SIGNED-OFF] Bug 13921 - XSLT Literary Formats Not Showing

This patch adds some missing literary formats to the staff client and
OPAC's search results XSLT display.

To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system
preferences enabled.  XSLTResultsDisplay and OPACXSLTResultsDisplay
should be set to 'default.'

Perform searches in the staff client and the OPAC and confirm that the
following literary forms (defined in 008 position 33) display correctly:
Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.;
Letters; Short stories; Mixed forms; Poetry; Speeches.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:20:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:20:46 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-9akXAC7am6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54627|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54721&action=edit
[SIGNED-OFF] Bug 16990: Display branch names instead of code in patron mod
requests

To test:
- change your homebranch in the OPAC, submit
- change patron modification request in the staff client
- Verify that it shows the old and new branch name instead of the
  code

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:20:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:20:43 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-mhYqPtFv9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:24:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:24:56 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-3dppksHtib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
I am not able to reproduce the bug. Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:26:31 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-1k7YAVEXLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:26:34 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-PsOSAINYBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54583|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54722&action=edit
[SIGNED-OFF] Bug 17149 - EDI accounts: Add missing '>' to breadcrumb

To verify:
Breadcrumb on "EDI accounts" pages reads
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

To test:
- Apply patch
- Add, edit and delete an EDI account
- Verify that breadcrumb displays properly

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:28:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:28:56 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-g4rDhKjiHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:28:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:28:59 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-1YHXZXWTCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54577|0                           |1
        is obsolete|                            |

--- Comment #12 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54723&action=edit
[SIGNED-OFF] Bug 11019 - Require some fields when adding authorized value
category

This patch modifies the form for adding an authorized value so that
category, authorized value, and description are required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in category, authorized value,
  or description. You should be prevented from submitting the form.
- Verify that filling in the required fields allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:31:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:31:07 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-CWybGGM4UG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:31:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:31:10 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-U9vcHpEKVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54574|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54724&action=edit
[SIGNED-OFF] Bug 13949 - Item search should have holding library

This patch adds holding library ("current location") to the list of
fields available in the item search form.

To test, apply the patch and go to Search -> Item search.

- Perform a search using the "current location" option and verify that
  it returns the correct results.
- Try other searches to confirm that they work as before.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:58:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:58:03 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-OSBjn1xvuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 01:58:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 22 Aug 2016 23:58:06 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-DQwiOlKbgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54572|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54725&action=edit
[SIGNED-OFF] Bug 17147 - Streamline messages following batch record
modification

This patch changes the display of informational messages during and
after the batch record modification process. Instead of showing a
separate dialog for each record modified, messages are now grouped into
one dialog.

To test, apply the patch and clear your browser cache if necessary. You
must have at least one MARC modification template defined.

- Go to Tools -> Batch record modification.
- Submit a list of biblionumbers which contains at least one number
  which doesn't exist in your database.
- Confirm that warning and success messages are grouped instead of
  showing in separate dialogs.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:01:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:01:34 +0000
Subject: [Koha-bugs] [Bug 17161] New: Making 'preview MARC' links show as
 buttons in batch record mod
Message-ID: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

            Bug ID: 17161
           Summary: Making 'preview MARC' links show as buttons in batch
                    record mod
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:07:16 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-0IB7IZ7Snk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:07:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:07:19 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-TxHnaMIME9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54726&action=edit
Bug 17161: Making 'Preview MARC' links show as buttons in batch record
modification

This patch removes the column heading and makes all links show as font
awesome buttons. I have also changed the wording from Preview MARC to
Show MARC to shorten the button and be consistent with other places in
Koha

To test:
1) Go to Tools -> Batch record modification
2) Put in some record numbers and click Continue
3) Ensure column heading 'Preview' no longer shows, and buttons are
showing with an appropriate icon. Confirm button still works as
expected.
4) Confirm button does not wrap on narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:07:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:07:27 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-qzlvWgDIYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:12:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:12:12 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-PVfiUyVHL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
This patch works well, however there are some things that should be considered
and improved before signing off on this:
1) With Edifact disabled, the EDI links still appear in the Admin sidebar
navigation
2) With Edifact disabled, I can still directly navigate to edi_accounts.pl
etc., either through the sidebar nav or going straight to the URL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:21:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:21:53 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-DxmVyx1yax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:21:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:21:56 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-J6ZopEDLVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54545|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54727&action=edit
[SIGNED-OF] Bug 17142 - Don't show library group selection in advanced search
if groups are not defined

Even if library groups/search domains are not defined in the system,
(empty) select for "Groups of libraries" under "Location and
availability" section in OPAC advanced search is still visible; it
shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable
in the template is now an object, it needs a different kind of statement
(.count) for checking if it's empty or not.

To test:

1) apply patch
2) when there are no groups of libraries defined in Administration ->
Libraries and Groups, "Groups of libraries" selection should be
no longer visible in OPAC adavanced search page
3) add library group or two: "Groups of libraries" selection should
reappear.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:26:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:26:02 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-7squ3TBn02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:26:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:26:05 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-qU5lIkE0F1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54544|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54728&action=edit
[SIGNED-OFF] Bug 17141: Call config method to retrieve logdir

Incorrect method call is causing runtime error and not
retrieving the correct logdir value
Change retrieves the value correctly

To test:
1) Run edi_cron.pl, notice error
2) Apply patch and run edi_cron.pl again, should work as expected

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:33:25 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-LSAkixyf9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:33:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:33:29 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-JZjWBM1ADY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52901|0                           |1
        is obsolete|                            |

--- Comment #9 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54729&action=edit
[SIGNED-OFF] Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:33:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:33:36 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-k3Sx2P1nlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54541|0                           |1
        is obsolete|                            |

--- Comment #10 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54730&action=edit
[SIGNED-OFF] Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of
File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
         in jessie is just fine and should be added to the community
         repo if wheezy will be supported for the coming release.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:58:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:58:38 +0000
Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove
 GetAuthorisedValueCategories
In-Reply-To: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15803-70-62yokInHo6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:58:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:58:41 +0000
Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove
 GetAuthorisedValueCategories
In-Reply-To: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15803-70-u2fV53yluT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54257|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54731&action=edit
[SIGNED-OFF] Bug 15803: Koha::AuthorisedValues - Remove
C4::Koha::GetAuthorisedValueCategories

The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all
the authorised value categories.
We already have a method in the Koha::AuthorisedValues module to do this
job, let's use it!

Technical explanations:
The new subroutine of the AuthorisedValues TT plugin will allow to get
the authorised value categories from the templates.
The new html_helpers include file will get rid of the if selected else
end statements. Bug 15758 already uses this file, see the commit
description for more informations.

Test plan:
1/ Create or edit a new fund (aqbudgets.pl), the fields "statistic 1"
and "statistic 2" should be correctly filled with the list of authorised
value categories
2/ Edit subfields for a biblio and authority framework.
The "Authorized value" dropdown list should be correctly filled on both
pages
3/ Create new items search fields (from the administration area), same
as previously, the authorised value category dropdown list should be
correctly filled
4/ Add and edit patron attribute types, check the authorised value
category list.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 02:58:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 00:58:47 +0000
Subject: [Koha-bugs] [Bug 16593] Access Control - Malicious user can delete
 the search history of another user
In-Reply-To: <bug-16593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16593-70-41fZH17qAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16593

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:20:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:20:58 +0000
Subject: [Koha-bugs] [Bug 17162] New: Moving MARC tags structure actions
 into a drop down menu
Message-ID: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

            Bug ID: 17162
           Summary: Moving MARC tags structure actions into a drop down
                    menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:24:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:24:50 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-RlOlM1uuAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:24:54 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-r2V0mvuuu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54732&action=edit
Bug 17162: Moving MARC tags structure actions into a drop down menu

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Confirm that three links, Subfields, Edit and Delete, now show in
drop-down menu with appropriate font awesome icons
4) Confirm that Subfields takes you to the right page and Edit and
Delete work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:25:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:25:03 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-sLPLGW26JS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:29:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:29:11 +0000
Subject: [Koha-bugs] [Bug 17163] New: Making MARC subfields structure
	actions buttons
Message-ID: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

            Bug ID: 17163
           Summary: Making MARC subfields structure actions buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:30:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:30:07 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-ZlLF2AwH94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:32:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:32:15 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-NuPSSw40W1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:32:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:32:18 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-s02gXtX21C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54733&action=edit
Bug 17163: Making MARC subfirlds structure actions buttons

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Click Subfields
4) Confirm Edit and Delete links show as buttons with appropriate icons
in one column called 'Actions'
5) Confirm buttons do not wrap on narrower browser
6) Confirm buttons behave as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:33:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:33:46 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-vT9z9SW4Wh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54733|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54734&action=edit
Bug 17163: Making MARC subfields structure actions buttons

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Click Subfields
4) Confirm Edit and Delete links show as buttons with appropriate icons
in one column called 'Actions'
5) Confirm buttons do not wrap on narrower browser
6) Confirm buttons behave as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:39:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:39:47 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-gRH8C3CSz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
fatal: sha1 information is lacking or useless (Koha/Objects.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:47:55 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-FPUViafaRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 03:47:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 01:47:58 +0000
Subject: [Koha-bugs] [Bug 17056] Remove event attributes from various
	templates
In-Reply-To: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17056-70-pZxRhNzC1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54051|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54735&action=edit
[SIGNED-OFF] Bug 17056 - Remove event attributes from various templates

This patch removes event attributes from several templates, moving event
definitions into the JavaScript instead.

To test, apply the patch and:

- View the MARC detail page for any bibliographic record. Changing the
  framework selection should reload the display using the selected
  framework.

- Perform the same test on the labeled MARC view. (Set the
  viewLabeledMARC system preference to "Allow" if necessary).

- To test the changes to Reports you should have at least one report
  group and at least one report subgroup.
  - Create a new saved SQL report.
  - Select a report group. Doing so should trigger the display of report
    subgroups. Deselecting the report group should hide the subgroups.

- In Acquisitions -> Suggestions, create a new suggestion.
  - In the 'Acquisition information' section, changing values for
    copies, currency, and price should change the value in the total
    field.

- In Circulation -> Upload offline circulation file:
  - My patch for Bug 16602 added the required code but forgot to remove
    the corresponding onclick attributes.
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
    - After uploading a file, both the 'Add to offline circulation
      queue' and 'Apply directly' buttons should work to trigger their
      corresponding processes (keeping Bug 16603 in mind).

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 04:05:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 02:05:07 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-wUziXCvKik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #53 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #51)
> Still fails, even with gzip files:

Could you ls -la the offending files?

$ ls -la
/home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql
-rw-rw-r-- 1 mtompset mtompset 323371 Aug 22 21:28
/home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql


I just retested on Debian, which is still <5.7, and Ubuntu 16.04 LTS.

Perhaps your files are older? Try reloading them from scratch?

mkdir ~/16554
cd ~/16554
wget -O fr-FR.gz
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898
wget -O ru-RU.gz
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899
wget -O uk-UA.gz
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900
gunzip fr-FR.gz
gunzip ru-RU.gz
gunzip uk-UA.gz
cd ~/kohaclone
git checkout -b bug_16554 origin/master
git pull
git am < ~/16554/fr-FR
git am < ~/16554/ru-RU
git am < ~/16554/uk-UA
git bz apply 16554
...

Because I'm just as confused as BGK as to why you might have those issues, JD.
Though, I really hate those white space issues with the patches, but that isn't
causing me any failures.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 04:12:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 02:12:54 +0000
Subject: [Koha-bugs] [Bug 17164] New: Software error when enrolment fee or
 reserve fee are too high ( Patron categories)
Message-ID: <bug-17164-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

            Bug ID: 17164
           Summary: Software error when enrolment fee or reserve fee are
                    too high (Patron categories)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

For some reason I had ridiculously high enrolment fee and reserve fee data
causing a software error when trying to access Patron Categories

Software error: Template process failed: undef error - round() overflow. Try
smaller precision or use Math::BigFloat at
/home/vagrant/kohaclone/Koha/Number/Price.pm line 44.
My enrolment fee was set at 8866609962973970000000.00 and my reserve fee was
set at 3862694923528880000000.00

Obviously it's very unlikely for a librarian to set the enrolment fee or
reserve fee to be this high but if it happens accidentally, it breaks the
system and causes this error. Perhaps there should be some kind of constraint
when entering this, like a maximum reserve fee constraint etc.?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 04:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 02:19:03 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-ejjFZ88sgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #7 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 04:42:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 02:42:12 +0000
Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from
 subscription add template
In-Reply-To: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16963-70-M3wRV86ama@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 04:42:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 02:42:15 +0000
Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from
 subscription add template
In-Reply-To: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16963-70-a2MnUQo79N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53662|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54736&action=edit
[SIGNED-OFF] Bug 16963 - Remove the use of "onclick" from subscription add
template

This patch removes the use of event attributes from the subscription add
template and the template for testing prediction patterns. Events are
now defined in the JavaScript.

To test, go to Serials -> New subscription.

- Test that the "Search for vendor," "Search for record," and "Create
  record" links work correctly.
- Test the "Next" button without entering a vendor or a biblionumber.
  You should be warned about selecting a vendor and biblionumber.
- After selecting a bibliographic record to link to the subscription,
  click the "Next" button. The second section of the subscription add
  form should be displayed.
- Under frequency, choose "1/day."
- Confirm that the "Show advanced pattern" link correctly toggles
  display of the advanced pattern form.
- Under the advanced pattern form, test the "Modify pattern" button. It
  should enable editing in the form.
- Test the "Cancel modifications" and "Save as new pattern" buttons.
- Test the "Test prediction pattern" button.
  - In the "Prediction pattern" box, test that the checkboxes next to
    each day of the week, when checked, trigger the corresponding issue
    number to be marked as "not published."
- Finally, confirm that your subscription is saved correctly.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:05:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:05:54 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14826-70-r5Duht1M62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #16 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
fatal: sha1 information is lacking or useless (C4/Accounts.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:11:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:11:13 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-FnoaHFNfn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:11:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:11:16 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-6PqenXZak3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52459|0                           |1
        is obsolete|                            |

--- Comment #7 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54737&action=edit
[SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some
acquisitions templates - Uncertain prices

This patch modifies the acquisitions uncertain prices template to remove
event attributes onclick and onchange.

Also changed on the uncertain prices page: Added a label to the orders
filter, removed redundant form submit function.

- Locate a vendor which has orders with uncertain prices
- Click the 'Uncertain prices' tab in the left-hand sidebar
- Enter invalid data in the "price" field for any order. Confirm that an
  error is triggered when the field loses focus.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:11:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:11:24 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-D2bVSefa4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52460|0                           |1
        is obsolete|                            |

--- Comment #8 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54738&action=edit
[SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some
acquisitions templates - Funds

This patch modifies the funds administration page and other files
related to the process of searching for and selecting fund owners and
users in order to remove the use of event attributes like 'onclick.'

Also changed in this patch: I have revised the way the "select owner"
and "select user" controls look. They are now links with Font Awesome
icons.

- Go to Administration -> Funds and open a fund for editing.
- Test the process of adding and updating an owner:
  - Click the 'Select owner' link.
  - Search for and select an owner in the pop-up window.
  - Save the fund and verify that the owner was saved correctly.
  - Perform the same test with the 'Remove owner' link.
- Use the same process to test the addition and removal of users.
  - Confirm that the 'Remove' link works correctly before and after
    submitting the form to save changes to the fund.

This patch changes a file which is used by both the funds template and
the template used when setting a guarantor on a patron. To test the
changes in that context:

- Open a 'child' type patron record.
- Under 'Guarantor information,' test the process of setting and
  removing a guarantor to confirm that data is saved correctly.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:11:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:11:30 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-2odPmTSjdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53569|0                           |1
        is obsolete|                            |

--- Comment #9 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54739&action=edit
[SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some
acquisitions templates - Transfer order

This patch removes the use of 'onclick' from the acquisitions transfer
order process. The patch also modifies the style of some links and
buttons to conform with current guidelines.

- Locate an open basket with items in it
- Click the 'Transfer' link for a title in the basket
- In the pop-up window:
  - Confirm that the 'Cancel' button at the bottom of the window is a
    Bootstrap-style button.
  - Search for a vendor; Confirm that the 'Choose' link is a
    Bootstrap-style button.
  - Choose a vendor; Confirm that the 'Choose' link on the following
    page is a Bootstrap-style button.
  - Confirm that clicking the 'Choose' button transfers the item to the
    correct basket.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:28:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:28:20 +0000
Subject: [Koha-bugs] [Bug 17165] New: Improve heading on vendor search when
 searching for all vendors in Serials
Message-ID: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

            Bug ID: 17165
           Summary: Improve heading on vendor search when searching for
                    all vendors in Serials
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Same fix from Bug 13238 needs to be applied to the vendor search in Serials
when adding or modifying a subscription

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:32:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:32:47 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-t8yRhWyyzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:32:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:32:50 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-1GicYVu4CQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54740&action=edit
Bug 17165: Improve heading on vendor search when searching for all vendors in
Serials

To test:
1) Go to Serials
2) Click New subscription or edit an existing one
3) Click Search for a vendor
4) Make a search that will return no results (i.e. has a typo etc.)
5) Confirm there is an appropriate message
6) Go back and make a search that will return results (i.e. putting in one
letter
    'a' etc.)
7) Confirm that heading is worded better and search term is displayed
8) Go back and make search without entering any search terms
9) Confirm that heading is worded better, no search term is displayed

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:33:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:33:03 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-brxXtjcSbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:49:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:49:22 +0000
Subject: [Koha-bugs] [Bug 17166] New: OPAC suggestion form: making Title a
 required field to remove onclick Check function
Message-ID: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

            Bug ID: 17166
           Summary: OPAC suggestion form: making Title a required field to
                    remove onclick Check function
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

Currently we have an onclick function that checks if anything has been entered
in Title before submitting. Using the built-in required attribute makes this
unnecessary

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:51:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:51:45 +0000
Subject: [Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a
 required field to remove onclick Check function
In-Reply-To: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17166-70-NGfjoA9EEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:51:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:51:48 +0000
Subject: [Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a
 required field to remove onclick Check function
In-Reply-To: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17166-70-S9KLyvAl4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54741&action=edit
Bug 17166: OPAC suggestion form: Make Title a required field

To test:
1) Log in to OPAC
2) Go to your suggestions
3) New suggestion
4) Attempt to submit a suggestion without the title
5) Notice pop-up error box
6) Apply patch and refresh page
7) Attempt to submit a suggestion without the title
8) Notice error bubble and form cannot submit

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 05:51:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 03:51:57 +0000
Subject: [Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a
 required field to remove onclick Check function
In-Reply-To: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17166-70-E1ndmFtElv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 06:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 04:42:27 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-kwlGWT9v8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #54 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #51)
> Still fails, even with gzip files:
> # 21/26:
> /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/
> Obligatoire/autorite_default.sql
> C4::Installer::load_sql returned the following errors while attempting to
> load /home/koha/src/installer/data/mysql/fr-FR/marcflavour/un
> imarc_complet/Obligatoire/autorites_norme_unimarc.sql:
> not ok 1 -
> /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/
> Obligatoire/autorites_norme_unimarc.sql: DBD::mysql::s
> t execute failed: Cannot add or update a child row: a foreign key constraint
> fails (`koha_test_installer`.`auth_subfield_structure`, CO
> NSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`)
> REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UP
> DATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.
> # 
> #   Failed test
> '/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/
> Obligatoire/autorites_norme_unimarc.sql: DBD::my
> sql::st execute failed: Cannot add or update a child row: a foreign key
> constraint fails (`koha_test_installer`.`auth_subfield_structur
> e`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`)
> REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE C) at
> /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.
> # '
> #   at t/db_dependent/Test_installer.t line 48.

OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4,
so if you upgraded through 3.19.00.042, you may find the upgrade had issues.

I have a massive head cold. If no one posts a "make all the ALTER IGNORE into
ALTER only" patch later, I will. I'm going to bed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 06:54:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 04:54:14 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-V7XPPa6SWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:26:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:26:58 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-zHSJYR1UpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
(In reply to Aleisha Amohia from comment #2)
> I am not able to reproduce the bug. Can you please check?

It is still an issue.

Clicking on "New account" results in "Internal server error"

plack-error.log:

Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl
line 147.
Variable "$input" is not available at /home/marc/koha/admin/edi_accounts.pl
line 157.
Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl
line 159.
Variable "$template" is not available at /home/marc/koha/admin/edi_accounts.pl
line 161.
Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157.

Does not happen with patch (after re-starting plack).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:27:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:27:33 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
 ( Internal server error)
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-fqx2pDbrTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix variable scope issue in |Fix variable scope issue in
                   |edi_accounts.pl             |edi_accounts.pl (Internal
                   |                            |server error)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:44:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:44:42 +0000
Subject: [Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a
 required field to remove onclick Check function
In-Reply-To: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17166-70-RIjkuNx41A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, I tested bug 10848 some days ago, it's currently waiting to get
pushed. Haven't tested, but it might make this patch obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:45:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:45:59 +0000
Subject: [Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
 ( Internal server error with plack)
In-Reply-To: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17144-70-uNXjLpCDx1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix variable scope issue in |Fix variable scope issue in
                   |edi_accounts.pl (Internal   |edi_accounts.pl (Internal
                   |server error)               |server error with plack)
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:55:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:55:06 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-XKcyvQg6o2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think Jacek is right - we need the F fines for the total amount calculation
in order to not break the MaxFine behaviour:

    if (my $maxfine = C4::Context->preference('MaxFine')) {
        if ($total_amount_other + $amount > $maxfine) { ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 07:57:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 05:57:55 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-syZVWzcdmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:01:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:01:55 +0000
Subject: [Koha-bugs] [Bug 6778] Display suggestor's name in catalog detail
	page
In-Reply-To: <bug-6778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6778-70-YP28ja2Zgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6778

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|shinoy.m at osslabs.biz        |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
No activity since 2011 - removing assignee.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:02:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:02:03 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-aw3YfYTP5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:14:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:14:25 +0000
Subject: [Koha-bugs] [Bug 15900] Remove use of recordpayment in
	ProcessOfflinePayment
In-Reply-To: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15900-70-cZm40xTqi5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:14:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:14:27 +0000
Subject: [Koha-bugs] [Bug 15900] Remove use of recordpayment in
	ProcessOfflinePayment
In-Reply-To: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15900-70-a80NgIGheb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52142|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 54742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54742&action=edit
Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment

Test plan:
1) Apply this patch
2) prove t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:22:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:22:37 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-WtvYVz9YLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54740|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54743&action=edit
Bug 17165: Improve heading on vendor search when searching for all vendors in
Serials

To test:
1) Go to Serials
2) Click New subscription or edit an existing one
3) Click Search for a vendor
4) Make a search that will return no results (i.e. has a typo etc.)
5) Confirm there is an appropriate message
6) Go back and make a search that will return results (i.e. putting in one
letter
    'a' etc.)
7) Confirm that heading is worded better and search term is displayed
8) Go back and make search without entering any search terms
9) Confirm that heading is worded better, no search term is displayed

Sponsored-by: Catalyst IT

Patch behaves as dexcribed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:23:02 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-XWck75BGAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:37:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:37:08 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-nJTeM7qL57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:37:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:37:49 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-qkAKWAmezs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:42:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:42:17 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-ZHnk85BmEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54732|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54744&action=edit
Bug 17162: Moving MARC tags structure actions into a drop down menu

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Confirm that three links, Subfields, Edit and Delete, now show in
drop-down menu with appropriate font awesome icons
4) Confirm that Subfields takes you to the right page and Edit and
Delete work as expected

Sponsored-by: Catalyst IT

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:42:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:42:50 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-9EKpWasZHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 08:43:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 06:43:51 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-fk0t3aK4nX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54734|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 54745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54745&action=edit
Bug 17163: Making MARC subfields structure actions buttons

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Click Subfields
4) Confirm Edit and Delete links show as buttons with appropriate icons
in one column called 'Actions'
5) Confirm buttons do not wrap on narrower browser
6) Confirm buttons behave as expected

Sponsored-by: Catalyst IT

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:20:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:20:44 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-U8Gf91YP35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
(In reply to Marc V?ron from comment #20)
> (In reply to M. Tompsett from comment #19)
> > (In reply to Marc V?ron from comment #17)
> > > I tested and got following results:
> > > OPAC:
> > > Detail page:
> > > http://www.amazon.com/dp/3907142330?tag=TEST&
> > 
> > Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
> > dangling ampersand. Though if you really think that adding the ref portion
> > is the correct course of action, I could do that. What say you, Marc?
> 
> I did some research, it seems that
> http://www.amazon.com/dp/3907142330?tag=TEST will be OK. Trailing & is
> superfluous. It seems to do no harm but can we remove it anyway?

Re-tested with full test plan. Dangling ampersand does no harm.
Will sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:21:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:21:32 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-ghVRspSanI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52670|0                           |1
        is obsolete|                            |

--- Comment #22 from Marc V?ron <veron at veron.ch> ---
Created attachment 54746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54746&action=edit
Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to "?tag={AAT}&ref..."

TEST PLAN
---------
 1) Added:
     "100 years of Canadian foreign policy /
      edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
    - AmazonAssocTag was set to TEST (easy to notice)
    - AmazonCoverImages was set to 'Show'
    - OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
    -- hovering over picture shows URL with ?tag=TEST& in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
    the picture contained ?tag=TEST& in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
    page contained ?tag=TEST& in it.
12) Confirmed the URL in the checked out list on your reading
    history page contained ?tag=TEST& in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:23:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:23:04 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-fJ0lEZ1UMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:39:16 +0000
Subject: [Koha-bugs] [Bug 5806] Search results display items for all
 locations when the SearchMyLibrary first system pref is activated
In-Reply-To: <bug-5806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5806-70-8VmOBzuxKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:41:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:41:13 +0000
Subject: [Koha-bugs] [Bug 15901] Remove use of recordpayment in
 C4::SIP::ILS::Transaction:: FeePayment
In-Reply-To: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15901-70-JMvCIA7AXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15901

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:41:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:41:15 +0000
Subject: [Koha-bugs] [Bug 15901] Remove use of recordpayment in
 C4::SIP::ILS::Transaction:: FeePayment
In-Reply-To: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15901-70-2htdAX8ScN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15901

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52143|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 54747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54747&action=edit
Bug 15901 - Remove use of recordpayment in
C4::SIP::ILS::Transaction::FeePayment

Test plan:
1) Apply this patch
2) Make a payment via SIP2
3) The payment should succeed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:41:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:41:36 +0000
Subject: [Koha-bugs] [Bug 6069] Multiple level budget list on suggestions
In-Reply-To: <bug-6069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6069-70-rYHKUfbjeS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
- patch does not apply
- ist this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:42:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:42:28 +0000
Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some
 fields were missing.
In-Reply-To: <bug-6070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6070-70-Zn3EkiIWPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #40 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:44:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:44:57 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: <bug-6138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6138-70-qzeNyFW0E1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
- Is this bug still valid?
- Patch does not apply

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:46:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:46:07 +0000
Subject: [Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and
 issues tables
In-Reply-To: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6271-70-0EpQj6wbZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:47:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:47:06 +0000
Subject: [Koha-bugs] [Bug 6772] Implementation of a recommendations engine
In-Reply-To: <bug-6772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6772-70-U8Bss6MWJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6772

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 09:57:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 07:57:28 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6782-70-Ew2A9FOLOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
- Still an issue on current master, see comment #8
- Patch does not apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 10:00:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 08:00:59 +0000
Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging
In-Reply-To: <bug-6890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6890-70-uXsuhdeWLd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:16:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:16:32 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-52bc9U5rJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #51 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #50)
> I think Jacek is right - we need the F fines for the total amount
> calculation in order to not break the MaxFine behaviour:

s/Jacek/Marcel/, but yep, the last patch changes existing MaxFine behaviour
quite dramatically.

While this feature current behaviour looks a bit broken to me (hard to say,
syspref description is far from clear), implementation is lacking (there is no
need to fetch all that old fines from accountlines in UpdateFine() even when
this syspref is not enabled), and - call me a Marxist - IMO it's socially
unjust feature ;), sorting it out (if really necessary) is outside of the scope
of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:25:22 +0000
Subject: [Koha-bugs] [Bug 15902] Remove use of recordpayment in
	process_koc.pl
In-Reply-To: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15902-70-Lg0b34V3Rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:25:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:25:24 +0000
Subject: [Koha-bugs] [Bug 15902] Remove use of recordpayment in
	process_koc.pl
In-Reply-To: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15902-70-SbqM3QnxX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52144|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 54748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54748&action=edit
Bug 15902 - Remove use of recordpayment in process_koc.pl

Test plan:
1) Apply this patch
2) Create an offline circ payment
3) Process the offline circ payment
4) Payment should show in Koha

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:27:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:27:27 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-BpcmGjCLs7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #93 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:34:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:34:52 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-hMLwpfXgBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Aleisha Amohia from comment #6)
> I cannot reproduce the bug. Can someone check to see if this patch is still
> necessary?

Yes it is. Did you see the screenshots? They explain very well the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:35:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:35:18 +0000
Subject: [Koha-bugs] [Bug 10148] 007 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-QACPZY4B7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:36:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:36:36 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-u6R4HD9MWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:40:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:40:00 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-0yX7d4ykSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:41:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:41:35 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-W8EbEYcDoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:41:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:41:37 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-BWx41OVRwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52146|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 54749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54749&action=edit
Bug 15899 - Fix up unit tests

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:41:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:41:47 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-SjAuc0pqz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52147|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 54750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54750&action=edit
Bug 15899 - Remove C4::Accounts::recordpayment

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) git grep recordpayment should show no calls to the recordpayment sub

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:41:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:41:53 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-Wsar18soSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #14 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:43:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:43:07 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-mHdrsfraPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:43:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:43:45 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-t81quUw6sM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:44:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:44:52 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-JSoY4kHiCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:45:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:45:56 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-sf9EBYQkmY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:47:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:47:29 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-kWtJ0gpk3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:47:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:47:53 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-179M5Pm6Jf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #52 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #49)
> (In reply to Kyle M Hall from comment #48)
> > (In reply to Katrin Fischer from comment #45)
> > > > How to solve this? Can we remove the issue id in accountlines after
> > > > switching to F? Or should UpdateFine no longer update a F record although it
> > > > has the right issue id, but add a new record?
> > > 
> > > I think it should add a new line as it's a 'new fine'. If we differentiate
> > > between F and FU cleanly, we can keep the issue_id too, I think?
> > 
> > Katrin has is exactly. If the same checkout goes overdue twice, the patron
> > should have two separate fines ( and each one will show a different due date
> > for the same checkout ).
> > 
> > This new followup will stop UpdateFine from updating closed out fines.
> 
> We are coming closer to a solution!
> But please note that we need type F (imo) in the totalamount calculation and
> the max fine reduction. We should focus on what happens next in UpdateFine.

IMO adding the filter (for FU, or FU|O|M ?) in

   if ( $rec->{issue_id} == $issue_id ) {

should do the trick.

> The test $data->{'amount'} != $amount is not sufficient. Here we should
> exclude type F somehow.

This test is kind of broken by itself (not always reliable, Bug 17138) but
excluding F fines in there will not be sufficient IMO - it would prevent
updating of the wrong fine record (in case when the one in $data is an
incorrect match), but the right fine record update may get skipped too in such
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:48:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:48:01 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-nea7nlbhdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:48:04 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-oxJkaHdWU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54726|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54751&action=edit
Bug 17161: Making 'Preview MARC' links show as buttons in batch record
modification

This patch removes the column heading and makes all links show as font
awesome buttons. I have also changed the wording from Preview MARC to
Show MARC to shorten the button and be consistent with other places in
Koha

To test:
1) Go to Tools -> Batch record modification
2) Put in some record numbers and click Continue
3) Ensure column heading 'Preview' no longer shows, and buttons are
showing with an appropriate icon. Confirm button still works as
expected.
4) Confirm button does not wrap on narrower browser

Sponsored-by: Catalyst IT
Works as described
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:57:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:57:59 +0000
Subject: [Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
In-Reply-To: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17020-70-Zi7Q3AifNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 11:59:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 09:59:04 +0000
Subject: [Koha-bugs] [Bug 17040] Context menu when editing items is not
	translated
In-Reply-To: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17040-70-3o24Z4cJF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17040

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:00:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:00:54 +0000
Subject: [Koha-bugs] [Bug 17081] Incorrect comparison operator used in
	edifactmsgs.pl
In-Reply-To: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17081-70-9rG1mOvcaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17081

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:01:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:01:45 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-vds89OoQjh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53514|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54752&action=edit
Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:01:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:01:48 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-PpLmQmmruc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53515|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54753&action=edit
Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:01:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:01:58 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-svDBEGnhhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53517|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54755&action=edit
Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:01:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:01:54 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-3Vcho8h2ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53516|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54754&action=edit
Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:02:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:02:02 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-5AgWrF31je@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53518|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54756&action=edit
Bug 16911: Rename extend_subscription with renew_account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:02:06 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-6sfW4VBp0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53533|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54757&action=edit
Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:02:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:02:34 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-kx9Wd0KszP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:02:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:02:52 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-wQHDlS7C0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Aleisha Amohia from comment #7)
> fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t)

Apply cleanly on top of bug 16911.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:03:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:03:30 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-NoslFTvM8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Aleisha Amohia from comment #3)
> fatal: sha1 information is lacking or useless (Koha/Objects.pm).

Did you apply all the dependencies?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:09:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:09:04 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-eZs7f2Bw5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:09:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:09:56 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-Co9B0LavVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:10:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:10:59 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-DymEm8AOQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:11:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:11:55 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-cN4DGsiJ6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:14:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:14:54 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-BxwdVZ4xYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #53 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #49)

> But take care with $type that you get from CalcFine.
> It may not be what you expect it to be ..

Looks like $type argument passed to UpdateFine() is always NULL / undef,
setting it to the custom string is not possible in Administration ->
Circulation and fines rules, or anywhere else in the system (not implemented?).
But in case it's not NULL in the database, it affects just a fine description
and the log entry. 

There doesn't seem to be anything wrong with it - ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:15:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:15:45 +0000
Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display
 translated itemtype
In-Reply-To: <bug-16989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16989-70-nvCUUkT7Fq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:16:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:16:27 +0000
Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in
 reports-home.tt
In-Reply-To: <bug-16964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16964-70-BoGIsxbPK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:17:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:17:14 +0000
Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing &rsaquo;
 from breadcrumbs
In-Reply-To: <bug-16953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16953-70-5GVYGvaGZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:18:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:18:07 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-rRui1BRGDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:18:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:18:10 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-wIi41Sy6eg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54729|0                           |1
        is obsolete|                            |
  Attachment #54730|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54758&action=edit
Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:18:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:18:24 +0000
Subject: [Koha-bugs] [Bug 16944] Add "email" and "url" classes when edit or
 create a vendor
In-Reply-To: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16944-70-nZZkSN8ECh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:18:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:18:23 +0000
Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl
	atomicupdates
In-Reply-To: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16685-70-x6R4C3MlZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54759&action=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
         in jessie is just fine and should be added to the community
         repo if wheezy will be supported for the coming release.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:20:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:20:26 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-aGCANJGeMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:20:29 +0000
Subject: [Koha-bugs] [Bug 17142] Don' t show library group selection in
 advanced search if groups are not defined
In-Reply-To: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17142-70-qALNfsjjZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54727|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54760&action=edit
Bug 17142 - Don't show library group selection in advanced search if groups are
not defined

Even if library groups/search domains are not defined in the system,
(empty) select for "Groups of libraries" under "Location and
availability" section in OPAC advanced search is still visible; it
shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable
in the template is now an object, it needs a different kind of statement
(.count) for checking if it's empty or not.

To test:

1) apply patch
2) when there are no groups of libraries defined in Administration ->
Libraries and Groups, "Groups of libraries" selection should be
no longer visible in OPAC adavanced search page
3) add library group or two: "Groups of libraries" selection should
reappear.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:21:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:21:29 +0000
Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using
	build-git-snapshot
In-Reply-To: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15200-70-bXIwOLQO8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #17 from Fr?d?ric Demians <frederic at tamil.fr> ---
Is relevant for 16.05? It doesn't apply as it is on stable branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:22:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:22:54 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-zunz1AgJZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:23:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:23:43 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-zAB0ZHtfXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:24:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:24:47 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-MIhjV9VNrP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:26:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:26:01 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-jry1WIsQ8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:26:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:26:04 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-aE3ARwjN3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54723|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54761&action=edit
Bug 11019 - Require some fields when adding authorized value category

This patch modifies the form for adding an authorized value so that
category, authorized value, and description are required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in category, authorized value,
  or description. You should be prevented from submitting the form.
- Verify that filling in the required fields allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:26:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:26:07 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-hMCUIVTyJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:28:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:28:02 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-Tzgcn85AIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Kyle M Hall from comment #8)

> The solution is pretty simple, we should never update closed out fines (
> account type 'F' ). My latest followup on bug 14390 implements this.

Looks like that should solve the problem sufficiently (followup in Bug 14390
needs only a small correction so MaxFine behaviour remains unchanged). Also an
idea from comment #7 turns out to be not that good after all, it would just add
an unnecessary redundancy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:29:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:29:22 +0000
Subject: [Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-HENYGtYq7a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #27 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:30:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:30:49 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-NQt1gaup8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:30:51 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-JtMHkbaz2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54724|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54762&action=edit
Bug 13949 - Item search should have holding library

This patch adds holding library ("current location") to the list of
fields available in the item search form.

To test, apply the patch and go to Search -> Item search.

- Perform a search using the "current location" option and verify that
  it returns the correct results.
- Try other searches to confirm that they work as before.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:31:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:31:30 +0000
Subject: [Koha-bugs] [Bug 13949] Item search should have holding library
In-Reply-To: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13949-70-ELNISnLbIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11425
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425
[Bug 11425] Search form for items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:31:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:31:30 +0000
Subject: [Koha-bugs] [Bug 11425] Search form for items
In-Reply-To: <bug-11425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11425-70-hw158kGtK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949
[Bug 13949] Item search should have holding library
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:33:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:33:52 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-1i67RBKKL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:34:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:34:46 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-8LeHL8vCjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:37:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:37:53 +0000
Subject: [Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass
In-Reply-To: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17124-70-KSd1MQJ1rG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:38:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:38:57 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-C2nDqDUSFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:39:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:39:59 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-Dnd3kvD216@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:41:34 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-QriNy9TjJn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:42:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:42:41 +0000
Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can
 fail if TimeFormat is 12hr
In-Reply-To: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17001-70-7N4adpU9Oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #9 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:44:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:44:16 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-bKtAuwNJh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:47:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:47:12 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-rwoLOiZPNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #10 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Side note: clean up of the 'F' / 'FU' fine types in existing accountlines
records is already done (in Bug 15675), most likely there shouldn't be any real
concerns remaining about that part any more.

Not sure if 'O' and 'M' (what is 'sundry' BTW, miscellaneous ?) may need some
extra attention or not - probably a non-iussue, there are some references to
those fine types remaining in the code base, but they are there from the dawn
of time (pre 3.0 ?), and I don't see anything relevant in updatedatabase.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:47:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:47:38 +0000
Subject: [Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from
	C4/Circulation.pm
In-Reply-To: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16741-70-QVkhJOHGUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:48:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:48:33 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-IxTqq8W5Y9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:52:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:52:35 +0000
Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from
 subscription add template
In-Reply-To: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16963-70-b91li1cihb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 12:52:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 10:52:38 +0000
Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from
 subscription add template
In-Reply-To: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16963-70-r3w1Ey9eYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54763&action=edit
Bug 16963 - Remove the use of "onclick" from subscription add template

This patch removes the use of event attributes from the subscription add
template and the template for testing prediction patterns. Events are
now defined in the JavaScript.

To test, go to Serials -> New subscription.

- Test that the "Search for vendor," "Search for record," and "Create
  record" links work correctly.
- Test the "Next" button without entering a vendor or a biblionumber.
  You should be warned about selecting a vendor and biblionumber.
- After selecting a bibliographic record to link to the subscription,
  click the "Next" button. The second section of the subscription add
  form should be displayed.
- Under frequency, choose "1/day."
- Confirm that the "Show advanced pattern" link correctly toggles
  display of the advanced pattern form.
- Under the advanced pattern form, test the "Modify pattern" button. It
  should enable editing in the form.
- Test the "Cancel modifications" and "Save as new pattern" buttons.
- Test the "Test prediction pattern" button.
  - In the "Prediction pattern" box, test that the checkboxes next to
    each day of the week, when checked, trigger the corresponding issue
    number to be marked as "not published."
- Finally, confirm that your subscription is saved correctly.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:05:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:05:07 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-v5u6qJ2RKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not sure to understand how uncertainprices.pl is supposed to work but I
think have found a regression:
- Change the price to something wrong
- focus out => alert
- Change the price to something ok
- Save => nothing happens

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:21:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:21:35 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-T2j25IgBQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #35 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Katrin Fischer from comment #34)
> >Let user access their own checkouts and if OpacRenewalAllowed system preference
> >is on, also let user to renew their checkouts.
> 
> I am concerned about this kind of behaviour. Would it mean that any user
> (without any permission) can do this using the REST API as long as they can
> get access to a valid session cookie/log into the OPAC?
Yes, only for their own checkouts. Of course appropriate system preferences
need to be considered, as you mentioned:

> This checks for OpacRenewalAllowed, but what about opacuserlogin?
Great suggestion, I totally ignored opacuserlogin. I think it is very important
to also check opacuserlogin here and in other operations where this type of
behaviour would be useful.

There are many operations where it would be useful to let resource owner to
access their own data even if they have no special permissions for it
(checkouts/history, holds, accountlines, patron info, password change etc.).
For this behaviour, I have proposed a patch in Bug 14868 which will centralize
that feature so we don't have to check permissions/ownership in each controller
over and over again, and also for each operation will add permission
documentation into Swagger. Perhaps opacuserlogin could be considered there and
restrict access to this behaviour in every operation, if it is disabled.

> Could we make this behaviour optional?
I'm not fully sure I understand your concern enough to see why it should have
extra optionality, if this behaviour is already enabled in OPAC. If your main
concern was opacuserlogin, then I think it is enough to consider it. Are there
some other preferences that should also be considered?

Thanks for the comment Katrin, very much appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:21:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:21:59 +0000
Subject: [Koha-bugs] [Bug 15900] Remove use of recordpayment in
	ProcessOfflinePayment
In-Reply-To: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15900-70-0AK0YFPLwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> On top of 15895, test fails
> 
> prove t/db_dependent/Circulation.t
> t/db_dependent/Circulation.t .. 1/83 Can't locate object method "find" via
> package "Koha::Borrowers" (perhaps you forgot to load "Koha::Borrowers"?) at
> /home/bgkriegel/kohaclone/C4/Circulation.pm line 3912.
> 
> Am I missing something?

Same here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:23:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:23:26 +0000
Subject: [Koha-bugs] [Bug 15902] Remove use of recordpayment in
	process_koc.pl
In-Reply-To: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15902-70-XExnhKTT1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 FAIL   offline_circ/process_koc.pl
   FAIL   forbidden patterns
                forbidden pattern: Koha::Borrower has been moved by bug 15548
(line 367)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:29:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:29:08 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-hDT1YwlCx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:29:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:29:11 +0000
Subject: [Koha-bugs] [Bug 17165] Improve heading on vendor search when
 searching for all vendors in Serials
In-Reply-To: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17165-70-wHdSOGmbTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54743|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54764&action=edit
Bug 17165: Improve heading on vendor search when searching for all vendors in
Serials

To test:
1) Go to Serials
2) Click New subscription or edit an existing one
3) Click Search for a vendor
4) Make a search that will return no results (i.e. has a typo etc.)
5) Confirm there is an appropriate message
6) Go back and make a search that will return results (i.e. putting in one
letter
    'a' etc.)
7) Confirm that heading is worded better and search term is displayed
8) Go back and make search without entering any search terms
9) Confirm that heading is worded better, no search term is displayed

Sponsored-by: Catalyst IT

Patch behaves as dexcribed.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:38:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:38:04 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-HlVo7I0SSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #13 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Benjamin Rokseth from comment #12)
> wow, amazing work! very much like the code we use in production, but better!
> AND with test coverage ;)
> 
> Would it be possible to also supply patron permissions in the response? I
> found the easiest way was to just iterate against haspermissions thus:
> 
> +   my $permissions = haspermission($userid); # defaults to all permissions
> +   # delete all empty permissions
> +   while ( my ($key, $val) = each %{$permissions} ) {
> +       delete $permissions->{$key} unless $val;
> +   }
> 
> then you could just return $permission as a hash object
Thank you for the kind support, Benjamin! That made my day!

I think permissions could be useful information to provide in the response.
Feel free to provide enhancement patches, I would be happy to sign-off them!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:40:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:40:39 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
	editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-x0tfpc7nx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Sequence of subfield in     |Default sequence of
                   |Editor                      |subfields in cataloguing
                   |                            |editor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:46:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:46:40 +0000
Subject: [Koha-bugs] [Bug 12284] More granular display options for
	authorities
In-Reply-To: <bug-12284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12284-70-n5uMuw4N5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12284

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We are also missing the option to "collapse" or in this case "uncollapse"
subfields by default. For authorities atm only mandatory fields appear
uncollapsed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:48:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:48:07 +0000
Subject: [Koha-bugs] [Bug 16935] launch export_records.pl with
 deleted_barcodes param fails
In-Reply-To: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16935-70-9V0AWWCeb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:49:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:49:13 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
	editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-eAjeJP2dKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid in current versions - it would be nice to be able to change the
default sequence of subfields appearing in the editor. Another example is $i in
7xx fields which usually should be the first subfield in the sequence.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:51:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:51:07 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-eTNlPYcTpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54631|0                           |1
        is obsolete|                            |

--- Comment #32 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54765&action=edit
Bug 14868: Swagger2-driven Permission checking

Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.

This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:51:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:51:32 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-Jm8mqv55kU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54632|0                           |1
        is obsolete|                            |

--- Comment #33 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54766&action=edit
Bug 14868: Give users possibility to request their own object

Allow access to user's own objects even if they do not have required
permissions.
This will be very useful in many cases where an user wants to request their own
object, for example renewing their checkouts or placing a hold for themselves.

First, this patch renames "x-koha-permission" to "x-koha-authorization" in
order
to describe the new functionality better.

Second, we can now add two extra parameters under "x-koha-authorization":
- "allow-owner"; Allows the owner of object to access it (without permission)
- "allow-guarantor"; Allows guarantor of the owner of object to access it
                     (without permission)

Third, since permission checking is outside of actual controller, we need a way
to find out ownership from different types of parameters, e.g. checkout_id from
/checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc.
A solution is to match the parameter with a subroutine that is designed to
verify
the ownership for that object. See the new subroutines in Koha::REST::V1.

To use this functionality you will simply define it in Swagger:
"/patrons/{borrowernumber}": {
  "get": {
    ...,
    "x-koha-authorization": {
      "allow-owner": true,
      "permissions": {
        "borrowers": "1"
      }
    }
  }
}

If a parameter that is not yet defined in
Koha::REST::V1::check_object_ownership,
you also need to define it and implement a subroutine that determines
ownership.

Tests are provided in a following patch that adds this functionality for
current
API operations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:51:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:51:52 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-V99FFJt72s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54633|0                           |1
        is obsolete|                            |

--- Comment #34 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54767&action=edit
Bug 14868: Use x-koha-authorization in current routes

To test:
1. Run t/db_dependent/api/v1/holds.t
2. Run t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:52:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:52:09 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-E30PZomLiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17050


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050
[Bug 17050] Accessing the REST API through Plack kicks the session out
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 13:52:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 11:52:09 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-um3M5spiIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:05:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:05:33 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-g3dNm8n1vY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:24:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:24:36 +0000
Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow
In-Reply-To: <bug-13665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13665-70-3hAtUUYXii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:25:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:25:28 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-4Sw39GyJxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:43:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:43:08 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-kdLHH3qEjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> Could you please detail why you need this change?
> I will break the following use case:
> - Start to fill a form
> - *Ring belt end of the day*
> - you hurry up to get back at home quickly
> - Tomorrow morning, you finish to fill the form
> - Submit
> - You lost your changes
> 
> Ok it's a bit far-fetched but I don't understand what will bring us this
> 8-hours limitation.

You only need the token between loading the form and submitting it. I do not
understand why you need 7 days for doing so?

Suppose an attacker got a CSRF token somehow from one user. Now he only needs
that user to click on a malicious Koha URL that also sends the token. The
amount of danger is obviously directly related to the length of the expiry
period. Shorter is better, but should be balanced with ease of use.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:43:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:43:41 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-QPl8Vi2GLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:43:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:43:44 +0000
Subject: [Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a
	drop down menu
In-Reply-To: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17162-70-1wmRWpw8aT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54744|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54768&action=edit
Bug 17162: Moving MARC tags structure actions into a drop down menu

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Confirm that three links, Subfields, Edit and Delete, now show in
drop-down menu with appropriate font awesome icons
4) Confirm that Subfields takes you to the right page and Edit and
Delete work as expected

Sponsored-by: Catalyst IT

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:45:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:45:20 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-xMahJroCR8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54745|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54769&action=edit
Bug 17163: Making MARC subfields structure actions buttons

To test:
1) Go to Admin -> MARC bibliographic framework
2) Go to Actions -> MARC structure for any framework
3) Click Subfields
4) Confirm Edit and Delete links show as buttons with appropriate icons
in one column called 'Actions'
5) Confirm buttons do not wrap on narrower browser
6) Confirm buttons behave as expected

Sponsored-by: Catalyst IT

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:45:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:45:18 +0000
Subject: [Koha-bugs] [Bug 17163] Making MARC subfields structure actions
	buttons
In-Reply-To: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17163-70-iulbc862D1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:47:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:47:30 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-njeEXBJX4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

--- Comment #35 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54770&action=edit
Bug 14868: Display required permissions in permission error response

When user does not have required permissions to use API operation, it would be
useful to let him know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.

To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:48:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:48:30 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-S2JNXdKYSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54770|0                           |1
        is obsolete|                            |

--- Comment #36 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 54771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54771&action=edit
Bug 14868: Display required permissions in permission error response

When user does not have required permissions to use API operation, it would be
useful to let them know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.

To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:49:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:49:40 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-UKGlTr8buB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:49:43 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-RuwzVKTcS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54751|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54772&action=edit
Bug 17161: Making 'Preview MARC' links show as buttons in batch record
modification

This patch removes the column heading and makes all links show as font
awesome buttons. I have also changed the wording from Preview MARC to
Show MARC to shorten the button and be consistent with other places in
Koha

To test:
1) Go to Tools -> Batch record modification
2) Put in some record numbers and click Continue
3) Ensure column heading 'Preview' no longer shows, and buttons are
showing with an appropriate icon. Confirm button still works as
expected.
4) Confirm button does not wrap on narrower browser

Sponsored-by: Catalyst IT
Works as described
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:49:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:49:46 +0000
Subject: [Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons
 in batch record mod
In-Reply-To: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17161-70-lZaeOE654r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54773&action=edit
Bug 17161: Add missing td tag

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:51:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:51:03 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-KQ6JODPc0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #53)
> (In reply to Marcel de Rooy from comment #49)
> 
> > But take care with $type that you get from CalcFine.
> > It may not be what you expect it to be ..
> 
> Looks like $type argument passed to UpdateFine() is always NULL / undef,
> setting it to the custom string is not possible in Administration ->
> Circulation and fines rules, or anywhere else in the system (not
> implemented?). But in case it's not NULL in the database, it affects just a
> fine description and the log entry. 
> 
> There doesn't seem to be anything wrong with it - ?

Well anything? :)
These kind of things make maintaining code only harder. They implicitly suggest
something while it is not there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 14:54:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 12:54:36 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-L2rTUTub2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #5)
> Why do you count the number of validated discharges? I'd say that the
> following call to is_discharged is enough.

I was following the example of opac-discharge.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:02:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:02:54 +0000
Subject: [Koha-bugs] [Bug 15139] Show nonpublic note in overdues report
In-Reply-To: <bug-15139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15139-70-9gVdTUDPrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Another library is asking for this - almost missed I had already filed a
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:06:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:06:44 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-2Yvf7SpHKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #55 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #54)
> (In reply to Jacek Ablewicz from comment #53)
> > (In reply to Marcel de Rooy from comment #49)
> > 
> > > But take care with $type that you get from CalcFine.
> > > It may not be what you expect it to be ..
> > 
> > Looks like $type argument passed to UpdateFine() is always NULL / undef,
> > setting it to the custom string is not possible in Administration ->
> > Circulation and fines rules, or anywhere else in the system (not
> > implemented?). But in case it's not NULL in the database, it affects just a
> > fine description and the log entry. 
> > 
> > There doesn't seem to be anything wrong with it - ?
> 
> Well anything? :)
> These kind of things make maintaining code only harder. They implicitly
> suggest something while it is not there.

Couldn't agree more.. What I meant was: anything wrong with it in UpdateFine()
in particular, which may make a proposed solutions insufficient or more
problematic?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:16:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:16:55 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-7QfFf8g3tJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #3 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #1)

> Depending on the fine charging settings, this may trigger unnecessary
> database writes (and a lot of them). If 'Fine Charging Interval' is
> 1 day, this has very little practical consequences (misc/cronjobs/fines.pl
> script is usually run once per day, and all fines need an increase
> anyway).

After a closer look - this is not entirely true. If the library has fine caps
enabled (for individual items, or a total limit for all overdues), unnecessary
database writes may happen there as well, even if 'Fine Charging Interval' is
1 day.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:19:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:19:17 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-1wk5lNrexV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54454|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54774&action=edit
Bug 16464 - If a patron has been discharged, show a message in the OPAC

This patch adds a message to the patron home page in the OPAC to be
shown if the user is restricted because of a discharge.

To test, apply the patch and log into the OPAC as a patron who has been
discharged.
 - You should see a message which says so, including a link to
   the discharge notice.
 - Log in to the OPAC as a patron with a manual restriction and confirm
   that the correct notice is displayed.

Signed-off-by: Claire Gravely <c.gravely at arts.ac.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:19:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:19:21 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-97FmFnFT80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54775&action=edit
Bug 16464: Add FIXME

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:19:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:19:43 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-AY9lN8AoaA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:19:53 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-J3KJkkH1Ge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:20:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:20:09 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-jNZBGNKFtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > Why do you count the number of validated discharges? I'd say that the
> > following call to is_discharged is enough.
> 
> I was following the example of opac-discharge.pl.

Added FIXME to see later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:34:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:34:29 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-zFugE3HBtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Nightly Build Bot <nightly at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54426|0                           |1
        is obsolete|                            |

--- Comment #9 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54776&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:42:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:42:43 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-Kkj8hfRuFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54776|0                           |1
        is obsolete|                            |

--- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54777&action=edit
Bug 17111 - Automatic debian/control updates (oldstable)

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:42:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:42:48 +0000
Subject: [Koha-bugs] [Bug 16918] opacmain.pl is not running under plack
In-Reply-To: <bug-16918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16918-70-DaeCTVkkzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:43:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:43:03 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-d4EEis1wUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:43:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:43:13 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-oeqxJik1Ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #56 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
P.S.: And sorry for the logorrhea ;). I'm just getting worried that it may miss
a deadline for the upcoming 16.05 maintenance release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:43:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:43:34 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-IL6lmFq2k5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:43:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:43:53 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-IhlFPeHy2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #11 from Mirko Tietgen <mirko at abunchofthings.net> ---
Latest version including libhtml-parser-perl.

Skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 15:44:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 13:44:51 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-6kkFQSsxEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Jonathan, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:05:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:05:40 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-ToHdKASR7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+ if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) {

Why not force them both to sprintf and get rid of the hardcoded 6 ?
Or would rounding with Math::Round::nearest be better than sprintf ?

    my $info = $schema->source('Accountline')->column_info('amount');
    my $scale = $info->{size}->[1];

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:05:48 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: <bug-14699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14699-70-4J2JcpFa0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Julian Maurice from comment #8)
> (In reply to Owen Leonard from comment #7)
> > (In reply to Nick Clemens from comment #6)
>I suggest to keep the current behaviour,
> change only the labels to "Select all visible rows" or something similar,
> and maybe add an action "Clear all history" ?

That sounds fine to me

The problem in comment 6 with the delete button should also be addressed:
with these patches the delete link still isn't visibly enabled but will delete
all selected regardless of visibility

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:12:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:12:20 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-ltCln5GMRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|cbrannon at cdalibrary.org     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:15:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:15:10 +0000
Subject: [Koha-bugs] [Bug 16815] API routes to list, create, update,
 delete holds need permissions
In-Reply-To: <bug-16815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16815-70-I2jyCiIV3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Version|master                      |16.05
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I mark it for 16.05 as the REST api has been enabled in that branch's latest
release. And the proper solution for master what Lari mentions: bug 14868.

I'll start working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:19:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:19:41 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-c5FWgNTtsR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #94 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:32:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:32:58 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-cWyc5EC9iS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #54)
> OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL
> 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had
> issues.
> 
> I have a massive head cold. If no one posts a "make all the ALTER IGNORE
> into ALTER only" patch later, I will. I'm going to bed.

I don't understand, I was just using the test script
t/db_dependent/Test_installer.t, there is nothing about the updatedatabase
script inside.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:48:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:48:13 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-MFyIH2FtoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54704|0                           |1
        is obsolete|                            |

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54778&action=edit
Bug 14390: [Follow-up] Only update FU record in UpdateFine

Exclude O, F and M when outstanding == 0.
Check if the issue_id points to a FU record.

Note: We only warn now when we see a second FU record with this issue id.
That should be a rare exception. As before, we are just counting it in
our total. Added a FIXME.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested fine on overdue. Renewed and backdated for a second fine. The F
and FU can be seen on the Fines tab and are totaled on Check out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:51:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:51:17 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-2ylwFTjtS5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Oops. Taking the liberty to replace your last follow-up, Kyle.
Kyle or Jacek: Could one (or both) of you test this one too ?
After that we can probably go the QA fast lane..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 16:53:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 14:53:16 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-IOVtaBQitQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #52)
> IMO adding the filter (for FU, or FU|O|M ?) in
> 
>    if ( $rec->{issue_id} == $issue_id ) {
> 
> should do the trick.

Followed that after all too. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:17:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:17:59 +0000
Subject: [Koha-bugs] [Bug 17167] New: Koha has two separate renewal responses
Message-ID: <bug-17167-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167

            Bug ID: 17167
           Summary: Koha has two separate renewal responses
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When checking an item out through SIP and the item has hit it's renewal limit,
Koha responds with "Item has reached maximum renewals", but when renewing an
item through SIP and the item has hit it's renewal limit, Koha responds with
"NO_MORE_RENEWALS: 1 ".

It doesn't make sense that there are different responses for essentially the
same thing, even though in this case it is technically two different processes.
 Also, the number 1 seems to have no purpose.  I increased the number of
renewals, and this number doesn't change, so I don't know what it is supposed
to be indicating.  This makes trapping renewal limits more tedious.  I would
recommend the following changes to these responses.

1. Have the checkout and renewal processes through SIP respond with the same
"Item has reached maximum renewals."
2. Note the period added to the end of the response.
3. Note the removal of the space at the end of the renewal response.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:20:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:20:04 +0000
Subject: [Koha-bugs] [Bug 17168] New: Add a command line script for updating
 patron category based on status
Message-ID: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

            Bug ID: 17168
           Summary: Add a command line script for updating patron category
                    based on status
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Work to be done:
* Create a script to run on a regular basis that updates patrons from one
category to another based on parameters passed in as defined below
* checks fine amount
* checks registration date
* checks patron fields for specific value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:20:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:20:20 +0000
Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating
 patron category based on status
In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17168-70-gTkoB8cEkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com
  Change sponsored?|---                         |Sponsored
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:23:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:23:21 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-29z7PIoHqf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:23:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:23:24 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-KEgKEywxkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54778|0                           |1
        is obsolete|                            |

--- Comment #60 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54779&action=edit
Bug 14390: [Follow-up] Only update FU record in UpdateFine

Exclude O, F and M when outstanding == 0.
Check if the issue_id points to a FU record.

Note: We only warn now when we see a second FU record with this issue id.
That should be a rare exception. As before, we are just counting it in
our total. Added a FIXME.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested fine on overdue. Renewed and backdated for a second fine. The F
and FU can be seen on the Fines tab and are totaled on Check out.

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:25:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:25:26 +0000
Subject: [Koha-bugs] [Bug 17169] New: Add facets for ccode and language to
	elasticsearch
Message-ID: <bug-17169-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169

            Bug ID: 17169
           Summary: Add facets for ccode and language to elasticsearch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Work to be done :

* Add collection code facet to limit results using CCODE values
* Add language facet to limit results based on the material language

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:25:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:25:39 +0000
Subject: [Koha-bugs] [Bug 17169] Add facets for ccode and language to
	elasticsearch
In-Reply-To: <bug-17169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17169-70-oV1cQ9peLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:26:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:26:21 +0000
Subject: [Koha-bugs] [Bug 17167] Koha has two separate renewal responses
In-Reply-To: <bug-17167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17167-70-LHHFhHNN2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Since renewals can be blocked by holds, I'll revise my wish list here:

1. Have the checkout and renewal processes through SIP respond with the same
"Item cannot be renewed."
2. Note the period added to the end of the response.
3. Note the removal of the space at the end of the renewal response.
4. The remainder of responses should be reviewed for punctuation and stray
spaces.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:28:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:28:42 +0000
Subject: [Koha-bugs] [Bug 10148] 007 not filling in with existing values
In-Reply-To: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-mn7HI0IwGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:29:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:29:05 +0000
Subject: [Koha-bugs] [Bug 17167] Koha has two separate renewal responses
In-Reply-To: <bug-17167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17167-70-U7hQeKUBtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
If there is a way to have the messages be more specific about the blocks, such
as renewal limit reached or hold on the item, a more specific response would be
considered, but the response should be the same whether through the renew
process or the checkout process.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:29:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:29:42 +0000
Subject: [Koha-bugs] [Bug 17087] Set Test::WWW::Mechanize version to 1.42
In-Reply-To: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17087-70-MYAC76F9el@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:29:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:29:51 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-5kRYViGV7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Did we verify old cases of double FU from renewals are taken care of (cleaned)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:31:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:31:17 +0000
Subject: [Koha-bugs] [Bug 17053] Clearing search term in Reports
In-Reply-To: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17053-70-cpaT0MfmQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:32:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:32:32 +0000
Subject: [Koha-bugs] [Bug 17170] New: Add the ability to create 'saved
 searches' for use as filters when searching the catalog
Message-ID: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

            Bug ID: 17170
           Summary: Add the ability to create 'saved searches' for use as
                    filters when searching the catalog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Work to be done:

1) Add a button to save a given search after it is performed.
2) Add a table and administrative area to add searches manually, allowing the
description and "Display in OPAC?" to be saved and edited.
3) Add these saved searches to the advanced search and results pages in the
OPAC and staff side.

Use case:
Librarian searches for materials by certain collection codes which define and
age range (Early readers, picture books, etc.) they save this search

Patron searching for 'Vampires' gets many results

They can add the 'saved search' to their current search to retrieve only
relevant records

Patron finds books for small children about vampires

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:33:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:33:39 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-0E6dI9pjdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Lee, eds-search.pl is not part of Koha and this part of the patch should be
removed I'd say.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:34:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:34:01 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-UEqEZ2LNYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |ldjamison at marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:34:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:34:51 +0000
Subject: [Koha-bugs] [Bug 17074] Fix links in result list of 'scan indexes'
 search and keep search term
In-Reply-To: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17074-70-fgqnutR0NH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:37:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:37:06 +0000
Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to
 output_pref" can be carped
In-Reply-To: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16848-70-TkBBHQW1aH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:38:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:38:31 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-Vs9vJvfjkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:38:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:38:34 +0000
Subject: [Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
In-Reply-To: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17149-70-Vr71t8Dw4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54722|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54780&action=edit
Bug 17149 - EDI accounts: Add missing '>' to breadcrumb

To verify:
Breadcrumb on "EDI accounts" pages reads
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

To test:
- Apply patch
- Add, edit and delete an EDI account
- Verify that breadcrumb displays properly

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:41:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:41:24 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-9zUzy6XTq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7736
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:41:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:41:24 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-X2pWTULvhB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17141


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141
[Bug 17141] Incorrect method called in edi_cron to get logdir
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:42:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:42:02 +0000
Subject: [Koha-bugs] [Bug 16776] If language is set by external link
 language switcher does not work
In-Reply-To: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16776-70-0ffAmJ7HYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:42:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:42:26 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-WIeOX091pL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:42:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:42:29 +0000
Subject: [Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get
	logdir
In-Reply-To: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17141-70-PFJrDZ2aY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54728|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54781&action=edit
Bug 17141: Call config method to retrieve logdir

Incorrect method call is causing runtime error and not
retrieving the correct logdir value
Change retrieves the value correctly

To test:
1) Run edi_cron.pl, notice error
2) Apply patch and run edi_cron.pl again, should work as expected

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Note: I did not test but changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:43:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:43:33 +0000
Subject: [Koha-bugs] [Bug 16806] "Too soon" renewal error generates no alert
	for user
In-Reply-To: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16806-70-gQsW2Q3X4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:44:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:44:52 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-G86YM8sK0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #62 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Note: for ensuring that MaxFine behaviour is unchanged, I did just:

1) set MaxFine to 100.00
2) commented out $accountline->set(...) in UpdateFine
3) (without the last patch): fines.pl 2>warnings.01 - I got over 1200 "Reducing
fine for ... MaxFine reached" warnings in warnings.01 for my test database with
19k overdues
4) (with the last patch included): fines.pl 2>warnings.02
5) diff warnings.01 warnings.02: no differences

Some extra testing with step 2) excluded would be better, but hopefully the
above is good enough. Also in my opinion code changes introduced by the last
patch are 100% solid and regression-free.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:48:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:48:23 +0000
Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results
In-Reply-To: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16894-70-5rYov9QjFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:58:20 +0000
Subject: [Koha-bugs] [Bug 17171] New: Add a syspref to allow currently
 issued items to be issued to a new patron without staff confirmation
Message-ID: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

            Bug ID: 17171
           Summary: Add a syspref to allow currently issued items to be
                    issued to a new patron without staff confirmation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Work to be done:
1) Add new system preference AutoReturnCheckedOutItemForNewCheckout ( or
something more terse )
2) Add new system preference AutoReturnCheckedOutItemForNewCheckoutForgiveFine
3) Modify circulation.pl to accept these new parameters and report what
happened (yellow box) instead of prompting for confirmation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:58:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:58:32 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-ZkbA4Yv5bu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #63 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #61)
> Did we verify old cases of double FU from renewals are taken care of
> (cleaned)?

Old 2+ FU records for the same item were taken care of in Bug 15675 (IMO quite
effecively) - I don't think there is a need to include / repeat the same or
similar procedure in this report. Double FUs created post-Bug 15675: there
shouldn't be any (none such cases in my test DB, at least).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 17:58:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 15:58:56 +0000
Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued
 items to be issued to a new patron without staff confirmation
In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17171-70-OZGE5C4jGN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:04:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:04:43 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-fQNIWm3mvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54719|0                           |1
        is obsolete|                            |

--- Comment #7 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 54782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54782&action=edit
Bug 17153: Simplified redirect

To test:
- Perform a catalog search
- Login from opac-search.pl
- Without the patch, the page should redirect to opac-user.pl
- Log out
- Apply patch
- Perform a search again
- Login again from opac-search.pl
- The page should redirect back to search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:05:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:05:09 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-uCdPSZ3aSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
But doesn't the problem described here still exist after bug 15675? Renewing an
item with a fine should recreate the problem - so maybe we should also run the
clean-up script again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:05:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:05:09 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-lG080Ef7hU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:05:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:05:26 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-1j2SOH0eGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #65 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #60)
> Created attachment 54779 [details] [review]
> Bug 14390: [Follow-up] Only update FU record in UpdateFine
> 
> Exclude O, F and M when outstanding == 0.

Great idea, misa like! Not 100% perfect ;), but a lot better performance-wise
in a typical production DB, just the right thing to do without rewriting ~half
of this function from scratch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:16:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:16:40 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-qOicruroMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:17:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:17:09 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-1xPRNEJTzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:19:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:19:11 +0000
Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet
In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15544-70-pmljMfJtEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like this might have got lost - it was never set to "Needs Sign-off".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:19:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:19:14 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-SRSg2NE5gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #66 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #64)
> But doesn't the problem described here still exist after bug 15675? Renewing
> an item with a fine should recreate the problem - so maybe we should also
> run the clean-up script again?

Yeah, you are right! In the production DB, past bug 15675, there may be some
'FU' fines records still linked to the existing issue records, which are not
currently accruing, looks like they should be dealt with somehow.

I wonder while I have no such cases in my test DB, probably because it got
cloned from the production DB some time ago, and there was not a whole lot of
renewals done in it since then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:20:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:20:33 +0000
Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for
 message_transports is too loose
In-Reply-To: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17160-70-CDHqkMudRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Barton, I understand the problem but it does not look so easy to fix it.
In the message_transports we have

MariaDB [koha]> select message_transport_type, letter_module, letter_code from
message_transports;                            
+------------------------+---------------+-------------+
| message_transport_type | letter_module | letter_code |
+------------------------+---------------+-------------+
| email                  | circulation   | CHECKIN     |
| sms                    | circulation   | CHECKIN     |
| email                  | circulation   | CHECKOUT    |
| sms                    | circulation   | CHECKOUT    |
| email                  | circulation   | DUE         |
| sms                    | circulation   | DUE         |
| email                  | circulation   | DUEDGST     |
| sms                    | circulation   | DUEDGST     |
| email                  | circulation   | PREDUE      |
| sms                    | circulation   | PREDUE      |
| email                  | circulation   | PREDUEDGST  |
| sms                    | circulation   | PREDUEDGST  |
| email                  | reserves      | HOLD        |
| sms                    | reserves      | HOLD        |
+------------------------+---------------+-------------+
14 rows in set (0.10 sec)

But the letter table does necessarily contain a sms template for CHECKIN or
CHECKOUT (or whatever).
If it does not exist, we won't be able to create the FK correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:20:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:20:55 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-p5sNF0BdKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It might also depend on configuraton - it's possible to block renewals of
overdue items now, but it's a more recent feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:42:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:42:14 +0000
Subject: [Koha-bugs] [Bug 8055] reversing fines wonky
In-Reply-To: <bug-8055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8055-70-1kYuOSGEsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |koha-bugs at lists.koha-commun
                   |                            |ity.org
             Status|Failed QA                   |ASSIGNED

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm planning a true Void Payment function for the accounts rewrite rewrite. I
will not be working on this patch any longer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:44:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:44:11 +0000
Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with
	DBIx::Class
In-Reply-To: <bug-12610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12610-70-NXUk3VvqE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX
           Assignee|kyle at bywatersolutions.com   |gmcharlt at gmail.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
I don't have time to continue working on this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 18:44:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 16:44:11 +0000
Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class
	throughout Koha
In-Reply-To: <bug-12608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12608-70-pcYVyOFy9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608
Bug 12608 depends on bug 12610, which changed state.

Bug 12610 Summary: Replace use of DBI in C4::Tags with DBIx::Class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:00:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:00:39 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-I4TLRdkTxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54783&action=edit
Bug 15438: Do not display irrelevant errors when checking out via SIP

See bug report for more info

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:02:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:02:07 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-PBBtHninl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Christopher,
Since my understanding of the code under C4/SIP is closed to 0, I have tried to
fix what you described but did not try the patch.
I am not sure at all it's the best way to fix it, but at least we have a patch
to start :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:25:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:25:39 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-mGx6vct1og@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:25:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:25:42 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-1JiNHoMyyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54784&action=edit
Bug 17152: Do not copy value when duplicating a subfield

When cataloguing, if you want to duplicate a subfield that is not
empty, the new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is
created with subfields but without data in it.

Test plan:
Add or edit a bibliographic record
Fill a subfield
Duplicate the subfield
=> Without this patch the value of the input will be copied
=> With this patch the new input will be emptied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:26:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:26:21 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-GWStPhafkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:36:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:36:46 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-wiPYRBhXzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #56 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #55)
> (In reply to M. Tompsett from comment #54)
> > OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL
> > 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had
> > issues.
> 
> I don't understand, I was just using the test script
> t/db_dependent/Test_installer.t, there is nothing about the updatedatabase
> script inside.

Yes, but is your schema for koha_test_installer current? Did you copy if from
an upgraded DB? I'm just trying to think of ways you could get up with the
constraint failing. I don't guarantee they are good ideas. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:44:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:44:54 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-ky6gdsACtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:44:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:44:57 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-rWZSU6myck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26980|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54785&action=edit
Bug 12022 - Independent branches does not isolate pending and approved comments
by branch.

Test Plan:
1) Create some comments for two libraries
2) Log in as non-superlibrarian
3) Set the logged in library to one of those two libraries
4) View comments, not you only see the comments from patrons
   whose home library matches the logged in library
5) Log in as a superlibrarian
6) Note you see all the comments reguardless of the patron's
   home library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:45:12 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-G25YnLDzLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|10276                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
[Bug 10276] Extend IndependentBranches to support groups of libraries
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:45:12 +0000
Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support
 groups of libraries
In-Reply-To: <bug-10276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10276-70-8slXAdH2na@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|12022                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022
[Bug 12022] Independent branches does not isolate pending and approved comments
by branch.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:45:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:45:41 +0000
Subject: [Koha-bugs] [Bug 17172] New: Cancelling an order before basket is
 closed leaves aqorders.status set to 'ordered'.
Message-ID: <bug-17172-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17172

            Bug ID: 17172
           Summary: Cancelling an order before basket is closed leaves
                    aqorders.status set to 'ordered'.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Deleting an order before a basket is closed sets
aqorders.datecancellationprinted, but does *not* change aqorders.orderstatus,
which stays at 'new'.

When the basket is closed, aqorders.orderstatus is set to 'ordered'

I can't tell if this is an oversight, or an attempt to distinguish between
orders cancelled before the basket is sent to the vendor (i.e. orders abandoned
by the library) and orders cancelled after the basket is closed (cancelled by
the vendor) -- See Bug 10918.

To replicate:

Prerequisites: Existing vendor, Budget, Fund, set up an open basket.

1/ Place an order
2/ Cancel the order

Run the following query:

SELECT
    ordernumber,
    biblionumber, 
    orderstatus, 
    datecancellationprinted
FROM
    aqorders
WHERE
    orderstatus IN ('ordered', 'new')
    AND datecancellationprinted IS NOT NULL

You will see orders with orderstatus set to 'new', and datecancellationprinted
with today's date.

3/ Close the basket

Run the query again, orderstatus for the new orders will now be 'ordered'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:50:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:50:04 +0000
Subject: [Koha-bugs] [Bug 17173] New: Quick edit a subfield in frameworks
Message-ID: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17173

            Bug ID: 17173
           Summary: Quick edit a subfield in frameworks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

There are too many click to jump to the edit form of a specific subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:50:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:50:10 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-wZzXLM2lFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #68 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #67)
> It might also depend on configuraton - it's possible to block renewals of
> overdue items now, but it's a more recent feature.

That wasn't it.. turns out I did wrong kind of search the 1st time :(. Sorry
for overlooking this. If I do something like that instead:

  SELECT ac.*, b.cardnumber, iss.date_due
  FROM accountlines ac
  LEFT JOIN issues iss ON (iss.issue_id = ac.issue_id)
  LEFT JOIN borrowers b ON (iss.borrowernumber = b.borrowernumber)
  WHERE ac.accounttype = 'FU'
  AND iss.issue_id IS NOT NULL
  AND iss.date_due >= NOW();

sure enough I get some hits. Not a lot, and they are not "double FU"s per se,
but indeed accounttype in such records should be changed from 'FU' to 'F'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:53:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:53:22 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-kBDWNX2K72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:53:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:53:40 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-cIhk3Umcuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:54:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:54:26 +0000
Subject: [Koha-bugs] [Bug 17173] Quick edit a subfield in frameworks
In-Reply-To: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17173-70-X0mPonyKnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17173

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:54:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:54:29 +0000
Subject: [Koha-bugs] [Bug 17173] Quick edit a subfield in frameworks
In-Reply-To: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17173-70-48Mn14TdqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17173

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54786&action=edit
Bug 17173: Quick jump to subfield edition form

There are too many clicks to jump to the edit form of a specific
subfield.

This patch adds a hidden feature (i.e. will not be polished or
documented).

When searching for a tag field from a marc framework structure, it's not
possible to search for a tag subfield to jump directly to the subfield
edition form.

Test plan:
On /admin/marctagstructure.pl?frameworkcode=FRAMEWORKCODE
Search for a subfield (952$d)
you will be redirected to the subfield edition form

There is no check if the subfield does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:56:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:56:17 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-lIerxABHXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #56)
> (In reply to Jonathan Druart from comment #55)
> > (In reply to M. Tompsett from comment #54)
> > > OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL
> > > 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had
> > > issues.
> > 
> > I don't understand, I was just using the test script
> > t/db_dependent/Test_installer.t, there is nothing about the updatedatabase
> > script inside.
> 
> Yes, but is your schema for koha_test_installer current? Did you copy if
> from an upgraded DB? I'm just trying to think of ways you could get up with
> the constraint failing. I don't guarantee they are good ideas. :)

The script recreate the DB before each run/language.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 19:59:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 17:59:41 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-eysAElRh8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
My new patch just filters based on if the librarian is a superlibrarian or not.
I imagine this would be nice outside of enabling IndependentBranches. If
someone disagrees, please let me know ; )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 20:08:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 18:08:26 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-1BlPk87B5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #69 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #68)

At the 1st glance it may look like follow-up for this should be relatively easy
to write, but I have a feeling that this statement

>   AND iss.date_due >= NOW();

is not quite right / not good enough for covering all possible cases (doesn;t
take into account grace periods settings etc.); I'd really appreciate any help
in this matter from more experienced individuals.. In any case I pre-volunteer
as a tester :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 20:12:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 18:12:43 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-yTsjiBeLaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #58 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #57)
> The script recreate the DB before each run/language.

No, each table. But that wouldn't explain fr-FR which wasn't first. *sigh* Just
trying to think of something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 20:58:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 18:58:59 +0000
Subject: [Koha-bugs] [Bug 17102] Automatically minify swagger.json
In-Reply-To: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17102-70-qxUqbmulox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I think this workflow wouldn't fit into Koha's QA process. And as you said, it
shouldn't be encouraged in production.

BUT

maybe we could make kohadevbox have this as a feature for developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 21:29:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 19:29:08 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-IzwXbHEh3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Think whats being exposed here is that CanBookBeIssued is returning a 3 element
return (although still documented as being 2!!) and the Sip routine does not
reflect that change.
The Sip code should not pass a borrowernumber into AF you should see a 'on hold
for another patron' message. The crude add all reasons logic is there because
new reasons get added to C4/Circulation but not to the sip interface and theres
a danger of saying "Not issued because --" The fix would be to make the call
match how it now appears in C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 21:32:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 19:32:23 +0000
Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for
 message_transports is too loose
In-Reply-To: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17160-70-wMN09smeLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> Barton, I understand the problem but it does not look so easy to fix it.

<snip>

> But the letter table does necessarily contain a sms template for CHECKIN or
> CHECKOUT (or whatever).
> If it does not exist, we won't be able to create the FK correctly.

I see your point... can we remove

    ON DELETE CASCADE ON UPDATE CASCADE

from

    CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`,
`letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`,
`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE


So that at least we're not losing lines in 'message_transports' if we happen to
delete a row from the letter table?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 21:50:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 19:50:27 +0000
Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into
 Koha:: AuthorisedValues - part 2
In-Reply-To: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15799-70-OEj7GC9Dcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 21:50:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 19:50:41 +0000
Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha
In-Reply-To: <bug-15779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15779-70-MWnZXsbTzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 22:22:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 20:22:37 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-gT5Y7MOP6p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #5)
> Christopher,
> Since my understanding of the code under C4/SIP is closed to 0, I have tried
> to fix what you described but did not try the patch.
> I am not sure at all it's the best way to fix it, but at least we have a
> patch to start :)

Are there instructions somewhere to setup and configure SIP on the backend?  If
so, I could try to setup a test environment on my VM and test the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 22:59:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 20:59:11 +0000
Subject: [Koha-bugs] [Bug 17172] Cancelling an order before basket is closed
 leaves aqorders.status set to 'ordered'.
In-Reply-To: <bug-17172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17172-70-PyKxv9Zjsf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17172

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, it looks like a bug to me as we have a specific cancelled status.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 23:01:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 21:01:57 +0000
Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued
 items to be issued to a new patron without staff confirmation
In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17171-70-HAzy0Rq5Vu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
AutoReturnCheckedOutItemForNewCheckoutForgiveFine

It looks a bit like all the Koha buzz words in one word :) Could we find
something a bit shorter?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 23:03:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 21:03:24 +0000
Subject: [Koha-bugs] [Bug 17169] Add facets for ccode and language to
	elasticsearch
In-Reply-To: <bug-17169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17169-70-Zxr7ENjLsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 23:08:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 21:08:01 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-7gJc3FHBE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Christopher Brannon from comment #7)
> Are there instructions somewhere to setup and configure SIP on the backend? 
> If so, I could try to setup a test environment on my VM and test the patch.

Some documentation here:
https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup

Basically you can:
1 - enable and start sip using package commands
2 - make sure the patrons listed in SIPconfig.xml exist in Koha
3 - Use sip_cli_emulator from the koha-shell
Use localhost and port 6001

That should do it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 23 23:08:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 21:08:35 +0000
Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for
 message_transports is too loose
In-Reply-To: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17160-70-VlUQVImyoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Wondering - how would you delete a single message transport line without SQL?
In the GUI the letter with all its message types appears as one thing that can
only be deleted completely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 00:17:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 22:17:09 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-LqPQuGzO95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think what scares me off is that 'anyone' will be able to use the API to some
extend - I am thinking of it not so much as a thing accessible to end users I
guess. There would be no way to control who uses certain functionality. Maybe
too paranoid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 00:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 22:17:52 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-iixufxLSW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
But I certainly like the idea of centralizing the permission checks :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 00:24:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 22:24:39 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-5SlpLOldY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I just took a look at this and I have a problem:

Sometimes we like to add an empty authorised value to appear as an empty/unset
entry in a a pull down list.

An example:
Extended patron attribute linked to an authorised value list.
The empty entry is the first in the list and will show if the field is
empty/was not imported.

Could we remove the required form the actual authorised value?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 00:30:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 22:30:02 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-gmZ7HTy0c7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #10 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 54787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54787&action=edit
Bug 17050: (QA followup) Use Mojo::Transaction to get the remote address

While the original patch fixes the issue, reading at Mojolicious source code,
revealed
that Mojo::Transaction already has proper processing for detecting the remote
address:

sub remote_address {
  my $self = shift;

  return $self->original_remote_address(@_) if @_;
  return $self->original_remote_address unless $self->req->reverse_proxy;

  # Reverse proxy
  return ($self->req->headers->header('X-Forwarded-For') // '') =~ /([^,\s]+)$/
    ? $1
    : $self->original_remote_address;
}

Without this patch, if there's a request without HTTP_X_FORWARDED_FOR, then the
remote
address would be empty. Such would be the case of a dev/standard setup without
Plack.

This patch makes Koha::REST::V1::startup use tx->remote_address instead of
dealing with the
headers on its own.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 00:52:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 22:52:04 +0000
Subject: [Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a
 required field to remove onclick Check function
In-Reply-To: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17166-70-khZpvzrOQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Katrin Fischer from comment #2)
> Hi Aleisha, I tested bug 10848 some days ago, it's currently waiting to get
> pushed. Haven't tested, but it might make this patch obsolete.

True! When that gets pushed, this can be marked a duplicate of that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:09:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:09:53 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-8QKG5AI0RK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #9 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #7)
> Yes it is. Did you see the screenshots? They explain very well the issue.

You're right sorry, I was trying to reproduce it in the wrong place. Tested in
the right place this time and patch works well. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:09:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:09:14 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-9DCqY8FuUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:09:17 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-XPOLOx4dGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54639|0                           |1
        is obsolete|                            |

--- Comment #8 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54788&action=edit
[SIGNED-OFF] Bug 17048: Fix pagination offset for authority searches

At the intranet, the pagination has been broken by bug 12478 (Elastic
Search). There was a confusion between the offset and the page number.

At the OPAC, it is broken since bug 2735 which has mimicked the intranet
script.

Test plan:
Search for a term which will return more than 1 page of results.
Click on the second page
=> Without this patch, the first result of the second page is the second
result of the first page
=> With this patch applied, the offset will be corrected

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:21:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:21:46 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-ALafPW6MBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54752|0                           |1
        is obsolete|                            |

--- Comment #22 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54789&action=edit
[SIGNED-OFF] Bug 16911: Koha::Patron::Categories - Add tests for
->get_expiry_date

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:21:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:21:43 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-vYQSr7u16h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:21:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:21:53 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-ez2pBktwOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54753|0                           |1
        is obsolete|                            |

--- Comment #23 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54790&action=edit
[SIGNED-OFF] Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to
->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:22:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:22:01 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-ak8yASHtR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54754|0                           |1
        is obsolete|                            |

--- Comment #24 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54791&action=edit
[SIGNED-OFF] Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:22:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:22:08 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-9EGLOJKmYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54755|0                           |1
        is obsolete|                            |

--- Comment #25 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54792&action=edit
[SIGNED-OFF] Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:22:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:22:15 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-w8hW3V9dPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54756|0                           |1
        is obsolete|                            |

--- Comment #26 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54793&action=edit
[SIGNED-OFF] Bug 16911: Rename extend_subscription with renew_account

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:22:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:22:21 +0000
Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move
 ExtendMemberSubscriptionTo to -> renew_account
In-Reply-To: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16911-70-b1Kokw0m4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54757|0                           |1
        is obsolete|                            |

--- Comment #27 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54794&action=edit
[SIGNED-OFF] Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:28:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:28:52 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-gm2h82tBOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #3)
> Created attachment 53519 [details] [review]
> Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded

Tests failed:

prove t/db_dependent/Koha/Patrons.t 
t/db_dependent/Koha/Patrons.t .. 1/8 Violation of unique constraint in Category
at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.
Violation of unique constraint in Category at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.
Violation of unique constraint in Category at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.

    #   Failed test 'New kid pay 5'
    #   at t/db_dependent/Koha/Patrons.t line 200.
    #          got: '0'
    #     expected: '5'

    #   Failed test 'Kid growing and become a juvenile, but shouldn't pay for
the upgrade '
    #   at t/db_dependent/Koha/Patrons.t line 206.
    #          got: '0'
    #     expected: '5'

    #   Failed test 'Kid growing and become a juvenile, he should pay 15'
    #   at t/db_dependent/Koha/Patrons.t line 215.
    #          got: '0'
    #     expected: '15'

    #   Failed test 'Juvenile growing and become an young adult, he should pay
35'
    #   at t/db_dependent/Koha/Patrons.t line 222.
    #          got: '0'
    #     expected: '35'
    # Looks like you failed 4 tests of 4.

#   Failed test 'add_enrolment_fee_if_needed'
#   at t/db_dependent/Koha/Patrons.t line 228.
# Looks like you failed 1 test of 8.
t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 8 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=8,  2 wallclock secs ( 0.03 usr  0.00 sys +  2.12 cusr  0.09
csys =  2.24 CPU)
Result: FAIL

The enrolment fee behaviour all works as expected, so happy to sign off once
the tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:42:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:42:44 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-7AM4tZxqvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54239|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54795&action=edit
[SIGNED-OFF] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:43:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:43:34 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-EZDax882cl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:43:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:43:37 +0000
Subject: [Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed
 should not return DBIx::Class objects
In-Reply-To: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17094-70-9tYqRcdxsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54240|0                           |1
        is obsolete|                            |

--- Comment #6 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54796&action=edit
[SIGNED-OFF] Bug 17094: Make Koha::Virtualshelf methods return
Koha::Objects-based objects

Instead of DBIx::Class objects.

Test plan:
1/ Add content to a list and share it with another patron
2/ Try to view the list with the other patron
3/ download and send a shelf and check if the biblio list is correct
4/ prove t/db_dependent/Virtualshelves.t should return green

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:51:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:51:48 +0000
Subject: [Koha-bugs] [Bug 17174] New: Making z39.50 authority search actions
	buttons
Message-ID: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

            Bug ID: 17174
           Summary: Making z39.50 authority search actions buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:54:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:54:41 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-s42MnN0Gyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:54:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:54:44 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-rQyTtmZfi3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54797&action=edit
Bug 17174: Making z39.50 Authority search actions buttons

Have changed the wording of the MARC button to Show MARC to be
consistent with other places in Koha.

To test:

1) Go to Authorities -> New from Z39.50
2) Put in any search terms and click Search
3) Confirm that both options (MARC and Import) now show as buttons "Show
MARC" and "Import" under one "Actions" column with approriate icons
4) Confirm buttons work as expected
5) Confirm buttons do not wrap on narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:54:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:54:52 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-7tYR3hj7F9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 01:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 23 Aug 2016 23:58:20 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-9Rlm4S3qnC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53520|0                           |1
        is obsolete|                            |

--- Comment #10 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54798&action=edit
[SIGNED-OFF] Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to
->add_enrolment_fee_if_needed

This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded
subroutine to the Koha::Patron->add_enrolment_fee_if_needed method.
The behavior should be unchanged.

Test plan:
1/ Define enrolment fee for 2 patron categories
2/ Create a patron using the first category
=> The patron should be charged
3/ Change the patron category to the other one
=> The patron should be charged again

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:16:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:16:50 +0000
Subject: [Koha-bugs] [Bug 17175] New: Typo in patron card images error
	message
Message-ID: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

            Bug ID: 17175
           Summary: Typo in patron card images error message
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

When you try to upload an image in Patron Card Creator without attaching the
image (i.e. just clicking Upload), an error message is displayed:
WARNING: An error has occurred while attempting to upload the image file.
Please ask you system administrator to check the error log for more details. 
Should say 'your' instead of 'you'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:18:29 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-21X266TWal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:18:32 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-iAvF6zwDSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54799&action=edit
Bug 17175: Typo in patron card images error message

To test:
1) Go to Tools -> Patron Card Creator -> New Image
2) Click Upload without attaching anything
3) Notice typo
4) Apply patch and refresh page (resend information if prompted)
5) Notice typo fixed

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:18:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:18:41 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-4cxn7Wflwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com
                   |u                           |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:24:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:24:58 +0000
Subject: [Koha-bugs] [Bug 17176] New: Did you mean searches should respect
 UseAuthoritiesForTracings and search by terms instead of numbers
Message-ID: <bug-17176-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17176

            Bug ID: 17176
           Summary: Did you mean searches should respect
                    UseAuthoritiesForTracings and search by terms instead
                    of numbers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In catalogs where some authorities may not be linked it would be beneficial to
have 'Did you mean?' searches constructed with terms rather than authority
numbers as the latter can result in dead links.  

Alternatively 'Did you mean?' shouldn't suggest unused authorities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:26:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:26:05 +0000
Subject: [Koha-bugs] [Bug 17177] New: Can't locate Koha/Config/ SysPrefs.pm
 in @INC on intranet about page
Message-ID: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

            Bug ID: 17177
           Summary: Can't locate Koha/Config/SysPrefs.pm in @INC on
                    intranet about page
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: About
          Assignee: nengard at gmail.com
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

>From 3.20.11 going to the intranet About page will cause this error:

Can't locate Koha/Config/SysPrefs.pm in @INC (@INC contains:
/usr/share/koha/lib /etc/perl /usr/local/lib/perl/5.14.2
/usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14
/usr/share/perl/5.14 /usr/local/lib/site_perl .) at
/usr/share/koha/intranet/cgi-bin/about.pl line 38.

Seems to have been introduced by f49adba138c7deb6736c50a75e1863b1d4647669 and
only a problem, I think, in the 3.20 line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:26:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:26:26 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-sdVIkFh59g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:29:14 +0000
Subject: [Koha-bugs] [Bug 17178] New: Add a popup/ keyboard shortcuts for
 diacritics and symbols in the cataloging editor
Message-ID: <bug-17178-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178

            Bug ID: 17178
           Summary: Add a popup/keyboard shortcuts for diacritics and
                    symbols in the cataloging editor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Work to be done:

1) Add a dialog, accessible by keyboard shortcut, that shows a variety of
special characters that can then be entered by clicking or choosing a keyboard
shortcut.
2) These characters should include, at a minimum, Spanish language characters
and the copyright/published symbols.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:31:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:31:45 +0000
Subject: [Koha-bugs] [Bug 17179] New: Add keyboard shortcuts to repeat
 (duplicate) a field, and cut text
Message-ID: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

            Bug ID: 17179
           Summary: Add keyboard shortcuts to repeat (duplicate) a field,
                    and cut text
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

add two more keyboard shortcut commands to the list already available:

Ctrl-R : Repeat or duplicate a field
Ctrl-C : cut command (to be used with paste - Ctrl-V)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:32:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:32:04 +0000
Subject: [Koha-bugs] [Bug 17179] Add keyboard shortcuts to repeat
 (duplicate) a field, and cut text
In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17179-70-6iMH26tmV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:33:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:33:30 +0000
Subject: [Koha-bugs] [Bug 17180] New: Add a current date macro to the
 advanced cataloging editor
Message-ID: <bug-17180-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17180

            Bug ID: 17180
           Summary: Add a current date macro to the advanced cataloging
                    editor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:33:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:33:39 +0000
Subject: [Koha-bugs] [Bug 17180] Add a current date macro to the advanced
 cataloging editor
In-Reply-To: <bug-17180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17180-70-ylYUl88fu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17180

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:35:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:35:12 +0000
Subject: [Koha-bugs] [Bug 17181] New: Patron card creator replaces existing
 image when uploading image with same name
Message-ID: <bug-17181-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

            Bug ID: 17181
           Summary: Patron card creator replaces existing image when
                    uploading image with same name
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

If you try to upload an image into Patron Card Creator with the same file name
as an image that has already been upload, the original image gets replaced,
without any warning. There should be some kind of warning before replacing,
i.e. "The name "filename" already exists. Upload and replace image or cancel
upload?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:38:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:38:29 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14567-70-7lwXps2WjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|robin at catalyst.net.nz       |nick at bywatersolutions.com
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:38:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:38:58 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14567-70-KoTxSWFgag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:41:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:41:31 +0000
Subject: [Koha-bugs] [Bug 17182] New: Allow Keyword to MARC mapping for
 acquisitions searches
Message-ID: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

            Bug ID: 17182
           Summary: Allow Keyword to MARC mapping for acquisitions
                    searches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

* Bring Keyword to MARC mapping in to acquisitions search results
* This will work like svc/checkouts which shows anything mapped to subtitle on
the table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:41:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:41:39 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
	acquisitions searches
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-PCqWVDt0fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:54:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:54:34 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-M1ANmMA9Tq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 02:54:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 00:54:37 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-ohZf8yoOec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 54800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54800&action=edit
Bug 17177 - about.pl references a module that doesn't exist

To test
1/ Go to the about page, notice error
2/ Apply patch
3/ Notice error gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 03:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 01:12:03 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-MiUfVgyyFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 03:12:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 01:12:06 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-xIRQeJyaDK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54801&action=edit
Bug 15711: Fixing the 'Delete selected' button on patroncard images

To test:
1) Go to Tools -> Patron Card Creator -> Manage images
2) Upload an image if you haven't already
3) Click Delete selected without selecting any images
4) Notice broken behaviour as described in Description
5) Apply patch, refresh page
6) Click Delete selected without selecting any images
7) Notice alert. Click OK
8) Select one image or more, click Delete selected
9) Notice confirm delete message.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 03:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 01:12:26 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-2jYXWzD8Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com
                   |u                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 03:45:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 01:45:38 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-EFgIFY8ewb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Tim Hannah <timdhannah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timdhannah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 05:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 03:43:12 +0000
Subject: [Koha-bugs] [Bug 17183] New: Koha News 'delete selected' function
 doesn' t check if anything has been selected
Message-ID: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

            Bug ID: 17183
           Summary: Koha News 'delete selected' function doesn't check if
                    anything has been selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

The 'delete selected' button in Koha News doesn't first check if any news items
have been selected to delete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 05:46:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 03:46:50 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-g5VtktPPqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 05:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 03:46:53 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-s0Omr4mYoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54802&action=edit
Bug 17183: Check if any checkboxes have been checked for 'Delete Selected'
button in Koha News

To test:
1) Go to Tools -> Koha News
2) Click 'Delete selected' button without selecting anything
3) Notice you are asked to confirm if you would like to delete ... but
you didn't choose anything to delete
4) Apply patch and refresh page
5) Click 'Delete selected' button without selecting anything
6) Should see alert.
7) Select one or more news items to delete and click 'Delete selected'
button
8) Should be asked to confirm
9) Confirm that the delete works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 05:47:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 03:47:03 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-RkWZUDgpo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 06:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 04:02:06 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-BPzup7R7cK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #25)
> Considering you have written a patch, and I have not, I'd like to see yours
> get it in ;)
> 
> David, is this patch still in good condition? If so I'd be willing to test
> and sign-off.
> 

Sorry for the delay. Didn't see your comment until now. I'll have to review the
patch, but I'll get back to you this week.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 07:13:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 05:13:26 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-n3hXDF40g2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54787|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 07:16:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 05:16:04 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-3m5dA8vUBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:02:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:02:08 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-Up8cGGWHjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Ah, I can recreate, but only after build_holds_queue has been run and picked up
the hold for the first patron

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:15:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:15:55 +0000
Subject: [Koha-bugs] [Bug 17184] New: Catalogue search
Message-ID: <bug-17184-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17184

            Bug ID: 17184
           Summary: Catalogue search
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: lau at aliftechnologies.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 54803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54803&action=edit
catalogue search is shown item serach in catalogue and check in.

Hi.

Lately I encounter an issue in catalogue. My client catalogue some books in 
the system. When try to search the books in catalogue, it show "no results
found".

I try used the check in, the system show d books details. I had check the books
details in catalogue. Everything is correct.

Kindly advise on this issue. My Koha ver is 3.04. Below is the screen shot
attached. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:18:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:18:21 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-DweBwLVoEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:27:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:27:55 +0000
Subject: [Koha-bugs] [Bug 16935] launch export_records.pl with
 deleted_barcodes param fails
In-Reply-To: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16935-70-lGeoLM1JHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fridolin.somers at biblibre.co
                   |                            |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:32:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:32:37 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-zHWNgVBQaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:41:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:41:30 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-TdVj8swnpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:46:54 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-ETAehyLGfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:46:54 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-rmvGMBLBQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030
[Bug 8030] Change pickup location of a hold from patron record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:50:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:50:04 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-leuTcqKh0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 09:53:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 07:53:32 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-hP1oZ12MGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #58)
> (In reply to Jonathan Druart from comment #57)
> > The script recreate the DB before each run/language.
> 
> No, each table. But that wouldn't explain fr-FR which wasn't first. *sigh*
> Just trying to think of something.

It's not important, but the script recreates the table before each new
"install" (lang+marcflavour):

 29 for my $lang ( qw ( de-DE en es-ES fr-CA fr-FR it-IT nb-NO pl-PL ru-RU
uk-UA ) ) {
 30     for my $marcflavour ( qw( marc21 unimarc ) ) {
 31         say "loading kohastructure for $lang | not $marcflavour";
 32         recreate_db( $db_name );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:14:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:14:03 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-SqRdNDTr47@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:14:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:14:06 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-BVI84qXjN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54804&action=edit
Bug 16912: Update patron category enrolment fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:24:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:24:16 +0000
Subject: [Koha-bugs] [Bug 17185] New: Staff client shows "Lists that include
 this title:" even if item is not in a list
Message-ID: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

            Bug ID: 17185
           Summary: Staff client shows "Lists that include this title:"
                    even if item is not in a list
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: arouss1980 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 54805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54805&action=edit
screenshot of staff client showing the error

In the staff client, the text "Lists that include this title:" is always shown,
regardless of whether the item is in a list or not (please see attached
screenshot).

I've found a way to fix this, and will attach a patch using git bz.

This is my first bug report so please be gentle :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:59:06 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-Er7Pc7AS3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Andreas Roussos <arouss1980 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:59:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:59:17 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-MZWuv0k8Yy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 10:59:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 08:59:20 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-BeZU36QDzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54473|0                           |1
        is obsolete|                            |
  Attachment #54474|0                           |1
        is obsolete|                            |
  Attachment #54475|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54806&action=edit
Bug 17110: Lower CSRF expiry in Koha::Token

Default expiry in WWW:CSRF is one week.
This patch sets it to 8 hours by default in Koha, and allows to
change the expiry period individually by passing MaxAge.

Test plan:
[1] Put items in your cart.
[2] Apply the example patch too.
[3] Send the cart from opac within the allotted 10 seconds.
[4] Send again, but wait some 10 seconds before submitting. Too late!

Tested 3 patches together, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:01:22 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-mcHV7sz3Mj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54807&action=edit
Bug 17110: Add unit test for MaxAge parameter in Token.t

Test plan:
Run t/Token.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:20:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:20:45 +0000
Subject: [Koha-bugs] [Bug 17076] Format fines in patron search results table
 (staff client)
In-Reply-To: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17076-70-XnHzIBQA9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17076

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:24:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:24:49 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-KnOFA9PwEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not make up my mind on what it's best. So let it go and see later if we
need to adapt it.
Another idea was to use max(pref(timeout), 8h or 24h) for the value of
CSRF_EXPIRY_HOURS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:26:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:26:42 +0000
Subject: [Koha-bugs] [Bug 17078] Format fines on opac-account.pl
In-Reply-To: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17078-70-zfToitzudb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17078

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:27:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:27:47 +0000
Subject: [Koha-bugs] [Bug 17055] Add classes to different note types to
 allow for styling on checkins page
In-Reply-To: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17055-70-pSgRwmzoFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:28:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:28:46 +0000
Subject: [Koha-bugs] [Bug 17052] Patron category description not displayed
 in the sidebar of paycollect
In-Reply-To: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17052-70-VdccgNo9bn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:29:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:29:50 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-p2Hm0Sif6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:29:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:29:53 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-UnyjZy93KN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54799|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54808&action=edit
Bug 17175: Typo in patron card images error message

To test:
1) Go to Tools -> Patron Card Creator -> New Image
2) Click Upload without attaching anything
3) Notice typo
4) Apply patch and refresh page (resend information if prompted)
5) Notice typo fixed

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:37:01 +0000
Subject: [Koha-bugs] [Bug 17030] Configure the REST api on packages install
In-Reply-To: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17030-70-zzE4JKXy9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |Pushed to Master

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
Reverted on 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:50:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:50:26 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-jqL0ymIdvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:50:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:50:28 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-nCxlpWbhfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54808|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54809&action=edit
Bug 17175: Typo in patron card images error message

To test:
1) Go to Tools -> Patron Card Creator -> New Image
2) Click Upload without attaching anything
3) Notice typo
4) Apply patch and refresh page (resend information if prompted)
5) Notice typo fixed

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 11:50:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 09:50:42 +0000
Subject: [Koha-bugs] [Bug 17175] Typo in patron card images error message
In-Reply-To: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17175-70-jbnXj5i9A1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:01:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:01:40 +0000
Subject: [Koha-bugs] [Bug 16944] Add "email" and "url" classes when edit or
 create a vendor
In-Reply-To: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16944-70-tVf27gpIaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:07:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:07:03 +0000
Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance
	Improvement
In-Reply-To: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15107-70-z7s2uhCa8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We are moving our code to the Koha namespace using DBIx::Class objects, I am
not sure it's a good idea to go back and use DBI directly.

See bug 16891 and bug 16907.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:10:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:10:03 +0000
Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of
	stopping zebrasrv
In-Reply-To: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16885-70-8HgQ1g9BoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:10:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:10:10 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-Ttdf5cEK0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #9 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
The description of the bug above is incorrect. Has anyone been able to
reproduce the bug on current master? Heres the output I see following the setup
as described: 
Request:11YN20160824    10574720160828   
093005AO|AA23529001203323|AB502326000812|AC|AD|
Response:120NUN20160824    105747AOCPL|AA23529001203323|AB502326000812|AJThe
flying gun /|AH|AFItem is reserved for another patron upon return.|BLY|[0d]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:26:59 +0000
Subject: [Koha-bugs] [Bug 16935] launch export_records.pl with
 deleted_barcodes param fails
In-Reply-To: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16935-70-UtKhERruEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:27:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:27:01 +0000
Subject: [Koha-bugs] [Bug 16935] launch export_records.pl with
 deleted_barcodes param fails
In-Reply-To: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16935-70-ZO1Zr5D6fI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 54810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54810&action=edit
Bug 16935 - launch export_records.pl with deleted_barcodes param fails

When launching misc/export_records.pl with this command line :

 misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes
--filename=/tmp/koha.mrc

You get this error message :

DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax;
check the manual that corresponds to your MariaDB server version for the right
syntax to use near '' at line 4 [for Statement " (
            SELECT DISTINCT barcode
            FROM deleteditems
            WHERE deleteditems.biblionumber = ?
        "] at misc/export_records.pl line 189.

This is because of a '(' after 'q|', looks like a typo.
Also, this patch removes useless var $q.

Test plan :
- Delete an item with barcode
- Without patch, run : misc/export_records.pl --date=`date +%d/%m/%Y`
--deleted_barcodes --filename=/tmp/koha.mrc
=> You get dirty MySQL
- Without patch, run the same command
=> No error and the file is generated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:27:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:27:59 +0000
Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files
	permissions
In-Reply-To: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16974-70-gYGYWU47Qx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:29:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:29:28 +0000
Subject: [Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
In-Reply-To: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17103-70-F6xfzhuTAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:30:51 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-n6thY5D85j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:33:25 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-ekg6YAkl7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Colin Campbell from comment #9)
> The description of the bug above is incorrect. Has anyone been able to
> reproduce the bug on current master? Heres the output I see following the
> setup as described: 
> Request:11YN20160824    10574720160828   
> 093005AO|AA23529001203323|AB502326000812|AC|AD|
> Response:120NUN20160824    105747AOCPL|AA23529001203323|AB502326000812|AJThe
> flying gun /|AH|AFItem is reserved for another patron upon return.|BLY|[0d]

As it depends on the keys order, I'd say the behavior may change randomly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:39:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:39:31 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-EPCXcRy5Kp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:41:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:41:54 +0000
Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new
	framework
In-Reply-To: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16955-70-jy6a9TxnVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:43:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:43:13 +0000
Subject: [Koha-bugs] [Bug 17117] Patron personal details not displayed
 unless branch update request is enabled
In-Reply-To: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17117-70-1ityLFUfuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:44:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:44:53 +0000
Subject: [Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
In-Reply-To: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17009-70-gm9LiqIS1L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:45:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:45:21 +0000
Subject: [Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known
	indexes
In-Reply-To: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17107-70-csqsdbHHdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:51:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:51:17 +0000
Subject: [Koha-bugs] [Bug 17100] On summary print,
 "Account fines and payments" is displayed even if there is nothing
 to pay
In-Reply-To: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17100-70-zGRKUGWCue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:52:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:52:35 +0000
Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to
 'starts_with' and not getting correct parameters to parse multiple word
 searches
In-Reply-To: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15930-70-FwxbQ40GGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:57:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:57:17 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-xRG6dhtmEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 12:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 10:57:19 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-ic0Z8GKhOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54802|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54811&action=edit
Bug 17183: Check if any checkboxes have been checked for 'Delete Selected'
button in Koha News

To test:
1) Go to Tools -> Koha News
2) Click 'Delete selected' button without selecting anything
3) Notice you are asked to confirm if you would like to delete ... but
you didn't choose anything to delete
4) Apply patch and refresh page
5) Click 'Delete selected' button without selecting anything
6) Should see alert.
7) Select one or more news items to delete and click 'Delete selected'
button
8) Should be asked to confirm
9) Confirm that the delete works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:01:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:01:15 +0000
Subject: [Koha-bugs] [Bug 17186] New: Error duplicate bibliography when
	saving new record
Message-ID: <bug-17186-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17186

            Bug ID: 17186
           Summary: Error duplicate bibliography when saving new record
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: hien.pham at dlcorp.com.vn
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When I saving new record in module catalog, Koha automatic created two record
in database with same data. This error is not full time, it just happens to
some records in Koha.

Koha version: 3.18.04

Please help me for check this error.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:01:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:01:31 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-yDKlsA5aC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54800|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54812&action=edit
Bug 17177 - about.pl references a module that doesn't exist

To test
1/ Go to the about page, notice error
2/ Apply patch
3/ Notice error gone

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
caused by a bad merge conflict with bug 12721 when backporting it to 3.20.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:01:49 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-s4pcnTEWMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:02:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:02:01 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-gnxerjZ9fD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:02:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:02:11 +0000
Subject: [Koha-bugs] [Bug 17177] Can't locate Koha/Config/ SysPrefs.pm in
 @INC on intranet about page
In-Reply-To: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17177-70-Oa11Wd9ZAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:11:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:11:47 +0000
Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching
	field mapping
In-Reply-To: <bug-13146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13146-70-b0cTPEPcf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15342


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342
[Bug 15342] Performance 3.22 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:11:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:11:47 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15342-70-CvFY1B26kr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13146


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146
[Bug 13146] Improve GetRecordValue function by caching field mapping
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:16:06 +0000
Subject: [Koha-bugs] [Bug 17187] New: Lower the timeout preference from 139
	days to 1 day
Message-ID: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

            Bug ID: 17187
           Summary: Lower the timeout preference from 139 days to 1 day
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

>From sysprefs.sql:  ('timeout','12000000',NULL,'Inactivity timeout for cookies
authentication (in seconds)','Integer'),
>From C4/Auth.pm:  my $timeout = C4::Context->preference('timeout') || 600;
Some googling results: 
The default in PHP is 1440 seconds (24 minutes).
30 minutes (=1800 secs) is the default expiration time of a cookie.

This patch proposes to lower 12 million to 1d (one day). The perfect balance
between usability and security??
Also note that we are talking about a session cookie. So end of session always
means end of game.

Who offers less ?
And what about changing current values? [Starting with: If it is null or the 12
million secs, change it.]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:16:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:16:51 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-2ix263fvck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17110

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:16:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:16:51 +0000
Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
In-Reply-To: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17110-70-opoI6fEnIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17187

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #12)
> I do not make up my mind on what it's best. So let it go and see later if we
> need to adapt it.
> Another idea was to use max(pref(timeout), 8h or 24h) for the value of
> CSRF_EXPIRY_HOURS

I will open up a new report for lowering the default timeout value.
If that meets approval, we could change this accordingly.
Thx for QA.

PS
Note that we also still have bug 15428..
And now bug 17187.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:18:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:18:30 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
 list incorrectly in admin/ edi scripts
In-Reply-To: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16514-70-sCRdCVE8Ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I cannot test this patch, edi_accounts.pl is not plack compatible:
Variable "$schema" is not available at /home/koha/src/admin/edi_accounts.pl
line 147.
Variable "$input" is not available at /home/koha/src/admin/edi_accounts.pl line
157.
Variable "$schema" is not available at /home/koha/src/admin/edi_accounts.pl
line 159.
Variable "$template" is not available at /home/koha/src/admin/edi_accounts.pl
line 161.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:22:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:22:09 +0000
Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet
In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15544-70-CAktmv0saR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is the old way to dev in Koha :)
You will need to correctly indent the template, use Koha::Objects for CRUD
operations.
Moreover the new table is not added to kohastructure.sql and updatedatabase.pl,
and you will need to populate it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:22:38 +0000
Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic
	search
In-Reply-To: <bug-14899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14899-70-FiDzqfTe1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15544

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:22:38 +0000
Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet
In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15544-70-PAwPW01ldv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14899

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note that there is a patch in the queue for ES: bug 14899

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:22:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:22:49 +0000
Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the
	intranet
In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15544-70-REB1t8gCRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Facets must be managed from |Zebra facets must be
                   |the intranet                |managed from the intranet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:25:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:25:30 +0000
Subject: [Koha-bugs] [Bug 14855] Resend notices in Notices tab with AJAX +
	REST
In-Reply-To: <bug-14855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14855-70-2jc2VBBifS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Blocked by bug 14843.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:27:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:27:56 +0000
Subject: [Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows
 circulation down in case of a record with many items and many holds
In-Reply-To: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14736-70-EM7vXiD7zq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:28:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:28:03 +0000
Subject: [Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows
 circulation down in case of a record with many items and many holds
In-Reply-To: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14736-70-0Tg44M80g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:27:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:27:59 +0000
Subject: [Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows
 circulation down in case of a record with many items and many holds
In-Reply-To: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14736-70-o6mz1VdyhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54813&action=edit
Bug 14736 - AllowRenewalIfOtherItemsAvailable slows circulation down in case of
a record with many items and many holds

If the AllowRenewalIfOtherItemsAvailable sys pref is set to allow, and a
borrower has an item checked out that has many items {30+} AND many
holds {70+) on it, loading the checkouts table for this borrower takes
FOREVER to load. The load time takes forever, because of the
factoring that happens to determine if an item is truly
available for renewal.

This patch swaps the use of GetMemberDetails for GetMember
and reorders the subroutine calls to check each items' renewability
from fastest to slowest.

In a test case, the results of pre patch were:
Start of loop: 2016-08-24T11:05:14
End of loop:   2016-08-24T11:05:29
Resulting in 15 seconds being spent in the loop

Post patch results were:
Start of loop: 2016-08-24T11:08:43
End of loop:   2016-08-24T11:08:48
Resulting in only 5 seconds being spent in the loop!

Test Plan:
1) Apply this patch
2) Note there are no changes in functionality for the renewals column of
   the patron checkouts table.

If you wish to go further and test the performance benefit:
1) Create a record with 50 items and 100 holds ( 50 waiting, 50 unfilled )
2) Check out one of the waiting holds to a patron
3) Time the amount of time it takes for the checkouts table to load
4) Apply this patch
5) Repeat step 3, you should see an improvement in load time

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:30:09 +0000
Subject: [Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway
	provider reports
In-Reply-To: <bug-14767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14767-70-gONzgQwfrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |BLOCKED

--- Comment #5 from Lari Taskula <larit at student.uef.fi> ---
Blocked by Bug 14723.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:32:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:32:41 +0000
Subject: [Koha-bugs] [Bug 17188] New: Koha does not support several
	memcached servers
Message-ID: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

            Bug ID: 17188
           Summary: Koha does not support several memcached servers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

There is a bug in the initialisation of memcached, the server string is
not correctly parsed.
If several memcached servers are defined, they are separated by commas
and so the string should be split accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:33:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:33:38 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
	servers
In-Reply-To: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17188-70-uuhxLIhrS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:33:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:33:41 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
	servers
In-Reply-To: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17188-70-n6bfyXCqjp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54814&action=edit
Bug 17188: Fix support of several memcached servers

There is a bug in the initialisation of memcached, the server string is
not correctly parsed.
If several memcached servers are defined, they are separated by commas
and so the string should be split accordingly

Test plan:
1/ Set MEMCACHED_SERVERS='localhost:11211,localhost:11222'
2/ Set DEBUG=1
3/ Reload plack, and check the log
=> Without this patch, you see
  Memcached server settings: localhost:11211,localhost:11222 with koha
  Selected caching system: Cache::Memory=HASH(0x9de2034)
i.e. Memcached has not been configured correctly and the default caching
system is used (Cache::Memory)
=> With this patch, you should see
Memcached server settings: localhost:11211, localhost:11222 with koha
Selected caching system: Cache::Memcached::Fast=SCALAR(0xa2a0c54)
i.e. Memcached has been configured correctly \o/

Note that the cache_servers attribute is never set and it not used. It's
better to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:34:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:34:26 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-23J2noKAuZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #11 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
OK this was introduced in a fix for Bug 4946 which changed how CanBookBEIssued
returns data to the caller. Previously the routine returned a hashref of
reasons for confirmation denial and each entry could be a key for further data
this flattened it out and returns borrowernumber, surname and firstname as top
level keys (i.e. they appear where the caller expects reasons) If you
repeatedly try to issue the same item we then get these being fed in turn. 
CanBookBeIssued is a bit of a mess (the number of things passed back to the
caller can vary according to circumstances) The Sip check out needs some logic
to make sense of the return as the sub itself fails to

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:34:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:34:30 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-M9xJJ8ehyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17188

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 Bug XXXXX_1: Fix support of several memcached servers 
moved to bug 17188.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188
[Bug 17188] Koha does not support several memcached servers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:34:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:34:30 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
	servers
In-Reply-To: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17188-70-4tKUrG5nww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16579


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579
[Bug 16579] Use separate memcached namespace for caching koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:37:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:37:24 +0000
Subject: [Koha-bugs] [Bug 17189] New: Add the ability to define several
 memcached namespaces
Message-ID: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

            Bug ID: 17189
           Summary: Add the ability to define several memcached namespaces
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We need to define several namespaces for our cache system.
For instance sysprefs, koha conf (koha-conf.xml) and unit tests
should be defined in a separate namespace.
This will permit to
- launch the tests without interfering with other cache values
- and flush the sysprefs cache without flushing all other values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:37:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:37:40 +0000
Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to
 be limited by branch
In-Reply-To: <bug-15023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15023-70-uJd8LWlH2J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:39:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:39:22 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-E31fNOmyUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:39:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:39:28 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-EwWbzjKD3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54816&action=edit
Bug 17189: Add the ability to define several memcached namespaces -
Koha::Caches

We need to define several namespaces for our cache system.
For instance sysprefs, koha conf (koha-conf.xml) and unit tests
should be defined in a separate namespace.
This will permit to
- launch the tests without interfering with other cache values
- and flush the sysprefs cache without flushing all other values

To do so, we need to store different Koha::Cache objects at a package
level. That's why this patch adds a new Koha::Caches module.

FIXME: There is an architecture problem here: the L1 cache should be
defined in Koha::Cache

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:39:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:39:25 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-sQdqNFiEu0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54815&action=edit
Bug 17189: Add the ability to define several memcached namespaces - tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:39:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:39:32 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-DyBs0Q1r7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54817&action=edit
Bug 17189: Add the ability to define several memcached namespaces - replace
existing occurrences

s/Koha::Cache->get_instance/Koha::Caches->get_instance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:40:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:40:21 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-IqMhacFUSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17189

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 Bug XXXXX_2: Add the ability to define several namespaces - tests
 Bug XXXXX_2: Add the ability to define several namespaces - Koha::Caches 
 Bug XXXXX_2: Add the ability to define several namespaces - replace existing
occurrences

Moved to bug 17189.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
[Bug 17189] Add the ability to define several memcached namespaces
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:40:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:40:21 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-cwSL4sDR0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16579


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579
[Bug 16579] Use separate memcached namespace for caching koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:40:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:40:28 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-EyJqre8i8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #12 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
The logic in C4::Circulation is that causes are returned in Uppercase and data
associated with causes are in lower case (In some cases the data is still
appearing as hash elemrnts of the uppercase entry but in these cases the case
distinction holds) Its a godawful design - but by wrapping the call in a rtn
that drops any lowercase "pseudo" causes we can fix the bug in hand.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:02 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-8NZnz0DNGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:05 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-RTPnBPi2At@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54818&action=edit
Bug 11921: Restore memcached infos to koha-conf

MEMCACHED_SERVERS and MEMCACHED_NAMESPACE should be moved back to
koha-conf instead of an ENV var to let command line scripts use
the cache mechanism.

TODO:
- Add the entries to koha-conf.xml
- Remove occurrences of MEMCACHED_SERVERS in package, apache and plack files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:09 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-Mqdin7kOpa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54819&action=edit
Bug 11921: Restore memcached infos to koha-conf - Koha::Config

Move C4::Context->read_config_file to Koha::Config
That permits to reuse it from Koha::Cache without needing C4::Context
(and introduce a circular deps).

TODO: Add decent POD to Koha::Config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:12 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-6II1Fw0yoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54820&action=edit
Bug 11921: Update remaining occurrences of ->ismemcached

TODO: Would be better to provide a better way to know if memcache is correctly
set

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:37 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-Mr4AuJures@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11921

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 Bug XXXXX_3: Restore memcached infos to koha-conf
 Bug XXXXX_3: Restore memcached infos to koha-conf - Koha::Config
 Bug XXXXX_3: Update remaining occurrences of ->ismemcached

Moved to bug 11921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921
[Bug 11921] memcached configuration should be moved back to koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:43:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:43:37 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-93VRodA13w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16579


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579
[Bug 16579] Use separate memcached namespace for caching koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:03 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-MKQlku2Jz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17188, 17189
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188
[Bug 17188] Koha does not support several memcached servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
[Bug 17189] Add the ability to define several memcached namespaces
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:03 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
	servers
In-Reply-To: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17188-70-oyQt72xDXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921
[Bug 11921] memcached configuration should be moved back to koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:03 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-ly2X5p0cqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921
[Bug 11921] memcached configuration should be moved back to koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:10 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-Df6FqKqXfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=11921                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:10 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-5x2WPVGxrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16579                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:44:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:44:46 +0000
Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved
 back to koha-conf.xml
In-Reply-To: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11921-70-MBZK4NvYKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
See bug 16579 for more information on these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:44 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-yejAZMP4S9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53946|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:42 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-OvuotA0RCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53945|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:45 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-RgFDE0K5JW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53952|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:47 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-3IkLSRvdYF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53953|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:48 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-rrUYJYc3LU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53954|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:51 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-en1gOwG1t9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53955|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:45:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:45:52 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-7lFDYj3OFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53956|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:49:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:49:31 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for
 caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-ZCza7eIfb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #42)
> (In reply to Kyle M Hall from comment #41)
> > (In reply to Nick Clemens from comment #40)
> > > I haven't fully tested, but initial read through and applying looks good.
> > > This makes it much easier to get memcached functioning with plack and is a
> > > good improvement
> > 
> > I agree! This is a huge improvement and greatly simplifies the setup.
> > 
> > Jacek, what do you think?
> 
> I think generally it's good, and certainly good enough for the 'promotion'
> from "In discussion" to "Needs sign-off". I have some doubts re/ certain
> parts (mostly about an introduction of that 'namespace' thingy to the Koha
> caching system - not entirely sure if it's strictly necessary, and - in case
> it is - if doing it in this particular way is the best way possible).

I agree, that's why I have added to FIXME in the commit message since the first
submission :)

    FIXME: There is an architecture problem here: the L1 cache should be
    defined in Koha::Cache

All the patches have been splited into 3 bug reports.
Letting this one for the general discussion about these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 13:49:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 11:49:49 +0000
Subject: [Koha-bugs] [Bug 16579] [OMNIBUS] Use separate memcached namespace
 for caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-bGTvYwZQmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Use separate memcached      |[OMNIBUS] Use separate
                   |namespace for caching       |memcached namespace for
                   |koha-conf.xml               |caching koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:07:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:07:12 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-5TAy2knjM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #70 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #64)
> But doesn't the problem described here still exist after bug 15675? Renewing
> an item with a fine should recreate the problem - so maybe we should also
> run the clean-up script again?

This bug did not create two FU records, Katrin. It changed a F record back to
FU. Note that a record like type M (Sundry) from manual invoice does not have
an issue id (only an optional item number); so would not change to FU. I am not
sure if we can create type O records still (apart from adding them manually to
authorized values).
I see no need to run the cleanup script in this regard.
I would suggest to open up a new report for cleaning up isolated FU records
which should have been closed (as Jacek mentioned earlier).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:10:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:10:07 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-qhAp15OeGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #71 from Kyle M Hall <kyle at bywatersolutions.com> ---
For what it's worth, it's pretty trivial to clean up any checked in fines with
a status of FU Katrin.

-- Close out any accruing fines with no current issue
UPDATE accountlines LEFT JOIN issues USING ( itemnumber, borrowernumber ) SET
accounttype = 'F' WHERE accounttype = 'FU' and issues.issue_id IS NULL;

-- Close out any extra not really accruing fines, keep only the latest accruing
fine
UPDATE accountlines SET accounttype = 'F' WHERE accountlines_id NOT IN ( SELECT
accountlines_id FROM ( SELECT * FROM accountlines WHERE accounttype = 'FU'
ORDER BY accountlines_id DESC ) a2 GROUP BY borrowernumber, itemnumber );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:16:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:16:44 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-kkwby2wDBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #62)
> Note: for ensuring that MaxFine behaviour is unchanged, I did just:
> 
> 1) set MaxFine to 100.00
> 2) commented out $accountline->set(...) in UpdateFine
> 3) (without the last patch): fines.pl 2>warnings.01 - I got over 1200
> "Reducing fine for ... MaxFine reached" warnings in warnings.01 for my test
> database with 19k overdues
> 4) (with the last patch included): fines.pl 2>warnings.02
> 5) diff warnings.01 warnings.02: no differences
> 
> Some extra testing with step 2) excluded would be better, but hopefully the
> above is good enough. Also in my opinion code changes introduced by the last
> patch are 100% solid and regression-free.

Thx for your signoff and additional testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:19:22 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-Y9dg4cfAaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #73 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Alright :) Glad that this is easier than I thought initially. 
So all is ready for QA?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:20:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:20:37 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-1E4BUMd5rA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #74 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #70)
> This bug did not create two FU records, Katrin. It changed a F record back
> to FU. 

To be more precise: Without this patch, the FU did not become F. Without the
last follow-up the corrected F became FU again. Clear enough? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:23:00 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-dWvXGZhQCZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #75 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
IMO update database part from Bug 15675 is of no use here (and there is no need
to check for duplicated FUs for the same item again, there shouldn't be any).
What I think needs to be done:

1) select the FU fine records that may need correction: for that we may need to
compare a due date from issue record and the date on the end of the fine
description - if the dates are the same, this is a correct FU record, no need
to change anything in it

2) if the dates are different, there are two possibilities:

3.a) if the fine is not accruing / item is not currently due: it's an old fine
record (either left unclosed by Bug 15675 or maybe patron renewed this item
after Bug 15675 was applied in the production database; maybe it got
overwritten in the meantime or maybe not, there is no easy way to tell): it
needs to be closed (FU -> F)

3.b) if the fine is accruing (item is due / CalcFine() returns a positive
value): this is an old record which got overwritten: leave it as FU, but
correct a due date in fine description.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:27:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:27:55 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-vqZMduG6oc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #75)
> IMO update database part from Bug 15675 is of no use here (and there is no
> need to check for duplicated FUs for the same item again, there shouldn't be
> any). What I think needs to be done:
> 
> 1) select the FU fine records that may need correction: for that we may need
> to compare a due date from issue record and the date on the end of the fine
> description - if the dates are the same, this is a correct FU record, no
> need to change anything in it
> 
> 2) if the dates are different, there are two possibilities:
> 
> 3.a) if the fine is not accruing / item is not currently due: it's an old
> fine record (either left unclosed by Bug 15675 or maybe patron renewed this
> item after Bug 15675 was applied in the production database; maybe it got
> overwritten in the meantime or maybe not, there is no easy way to tell): it
> needs to be closed (FU -> F)
> 
> 3.b) if the fine is accruing (item is due / CalcFine() returns a positive
> value): this is an old record which got overwritten: leave it as FU, but
> correct a due date in fine description.
> 
> What do you think?

Sounds good. But please open up a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:28:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:28:15 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-Wbgs9zORHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #77 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #73)
> Alright :) Glad that this is easier than I thought initially. 
> So all is ready for QA?

Yes. We are ready now.
Since this actually was my QA session, I am happy to promote this patch set to
Passed QA now.
I leave it to anyone interested to add additional cleaning up on a new report
please. 
This patch set is for 16.05 too since bug 15675 was pushed to 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:33:16 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-SpXFWAYb7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #10)
> Side note: clean up of the 'F' / 'FU' fine types in existing accountlines
> records is already done (in Bug 15675), most likely there shouldn't be any
> real concerns remaining about that part any more.
> 
> Not sure if 'O' and 'M' (what is 'sundry' BTW, miscellaneous ?) may need
> some extra attention or not - probably a non-iussue, there are some
> references to those fine types remaining in the code base, but they are
> there from the dawn of time (pre 3.0 ?), and I don't see anything relevant
> in updatedatabase.

Sundry is small expenses (no issue id involved)
I think O is unused (by default at least)
If 14390 gets in, can we close this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:39:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:39:56 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-XieeojYKmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54593|0                           |1
        is obsolete|                            |

--- Comment #78 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54821&action=edit
Bug 14390 - Fine not updated from 'FU' to 'F' on renewal

Test Plan:
1) Find an overdue checkout with a fine
2) Renew item, note fine is not closed out (Account type F)
3) Apply this patch
4) Find another overdue checkout with a fine
5) Renew item, note fine is now correctly closed out
6) Backdate a checkout to be already overdue ( but not have a fine since
    fines.pl hasn't run yet )
7) Renew item, note a closed out fine is created

Signed-off-by: Sean Minkel <sminkel at rcplib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:40:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:40:02 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-4vVgU9E1ct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54594|0                           |1
        is obsolete|                            |

--- Comment #79 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54822&action=edit
Bug 14390 [QA Followup] - Unit Test

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:40:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:40:09 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-RbZsYrMLHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54595|0                           |1
        is obsolete|                            |

--- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54823&action=edit
Bug 14390 [QA Followup] - Fix warning

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:40:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:40:14 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-nYNtP858Gi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54596|0                           |1
        is obsolete|                            |

--- Comment #81 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54824&action=edit
Bug 14390: [QA Follow-up] UpdateFine should be passed a hash

Renewing an overdue would not work.
Log shows:
renew: Can't use string ("2144746608") as a HASH ref while "strict refs" in use
at C4/Overdues.pm line 508., referer:
/cgi-bin/koha/circ/circulation.pl?borrowernumber=1

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 14:40:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 12:40:19 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-xc1wS127T7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54779|0                           |1
        is obsolete|                            |

--- Comment #82 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54825&action=edit
Bug 14390: [Follow-up] Only update FU record in UpdateFine

Exclude O, F and M when outstanding == 0.
Check if the issue_id points to a FU record.

Note: We only warn now when we see a second FU record with this issue id.
That should be a rare exception. As before, we are just counting it in
our total. Added a FIXME.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested fine on overdue. Renewed and backdated for a second fine. The F
and FU can be seen on the Fines tab and are totaled on Check out.

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:01:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:01:15 +0000
Subject: [Koha-bugs] [Bug 10227] GetMessagingPreferences does not return
 correct Digest preferences
In-Reply-To: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10227-70-5gQ7LzukzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

--- Comment #1 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 54826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54826&action=edit
Bug 10227 : Fix GetMessagingPreferences when digest is possible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:02:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:02:12 +0000
Subject: [Koha-bugs] [Bug 10227] GetMessagingPreferences does not return
 correct Digest preferences
In-Reply-To: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10227-70-E7Hik6SxKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:02:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:02:53 +0000
Subject: [Koha-bugs] [Bug 10227] GetMessagingPreferences does not return
 correct Digest preferences
In-Reply-To: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10227-70-oDQxz4REuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:15:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:15:21 +0000
Subject: [Koha-bugs] [Bug 17184] Catalogue search
In-Reply-To: <bug-17184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17184-70-QN6EiwxfgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17184

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This sounds more like a support request than a bug report.

Support requests should be made on the Koha mailing list, on IRC, or by
contracting with a support vendor. All these options are linked to here:
http://koha-community.org/support/

Keep in mind that the first suggestion you're going to get is to upgrade Koha.
3.04 is very very old now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:22:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:22:16 +0000
Subject: [Koha-bugs] [Bug 10227] GetMessagingPreferences does not return
 correct Digest preferences
In-Reply-To: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10227-70-PW2B6s8SHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

--- Comment #2 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
This bug is a bit tricky to test, as the result is somehow  random, depending
on the order of rows returned by sql request. You've got to change the
preferences several times to see bad results.

Enable EnhancedMessaging preferences
Set preferences for a borrower or a category. 
run misc/cronjobs/advance_notices.pl and look in message_queue table the
letter_code of the generated messages.
Change digest selection and do the test again several times 

Without patch, for message where digest is allowed (Advance_Notice, Item_Due),
for a borrower or a category with 'wants_digest' selected,
GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and
sometimes not.

With the patch, letter_code returned is always correct depending on digest
selected or not

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:30:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:30:48 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-u4xUnbeBq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54783|0                           |1
        is obsolete|                            |
             Status|In Discussion               |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #13 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 54827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54827&action=edit
Proposed patch

This patch strips the unwanted data out of the hashrefs returned to the
routine. Taking on board Jonathan's earlier patch I've made an explicit end to
the loop once we've blocked the issue - This stops the anomalous data from
appearing in screen message


Its tempting to refactor the routine in C4::Circulation too but that should
probably not be contemplated while sober.

please test, theres lots of room here for odd corner cases

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:36:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:36:08 +0000
Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-0VINm7d7J0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add API route for getting   |REST API: Add API route for
                   |an item                     |getting an item

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:36:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:36:35 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-DITI5QLX37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add API routes for getting  |REST API: Add API routes
                   |item availability and       |for getting item
                   |holdability                 |availability and
                   |                            |holdability

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:37:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:37:15 +0000
Subject: [Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in
 Swagger tags for holds
In-Reply-To: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17086-70-NAlrQnDNRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Reword borrowers to patrons |REST API: Reword borrowers
                   |in Swagger tags for holds   |to patrons in Swagger tags
                   |                            |for holds

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:38:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:38:51 +0000
Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
In-Reply-To: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1993-70-BfFrLLUFgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|sophie.meynieux at biblibre.co |gmcharlt at gmail.com
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:46:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:46:52 +0000
Subject: [Koha-bugs] [Bug 12300] Revert BZ10727 - Remove duplicate <br /> in
 printed hold notices
In-Reply-To: <bug-12300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12300-70-7V4eL8W8wt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #4 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Since Bug 11603 as been pushed, HOLD_PRINT is not used any more, there is no
need of this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:49:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:49:19 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-WtSGNKnx68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

--- Comment #12 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
May I close this bug as it seems everybody uses templates as they are since a
while ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:52:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:52:19 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-wyAadhs3bL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:52:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:52:22 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-RCUPJjXxZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54828&action=edit
Bug 17187: Lower the timeout preference from 139 days to 1 day

Default timeout is now 12000000 seconds == almost 139 days !
Surely, your session will be shorter. But we should lower this
value.
Balancing usability and security, I propose 1d (1 day) now.
Current pref value will be affected only if it is NULL or equal
to the old default.

Test plan:
Check your current value. Optionally change to NULL or 12000000.
Run the dbrev and see what happens.
Beware of cached values while testing or flush the cache.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 15:52:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 13:52:32 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-hd9W7C6FB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:07:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:07:56 +0000
Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder'
 s borrowernumber in AF (screen message) field.
In-Reply-To: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15438-70-PtTwth2xMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Colin Campbell from comment #12)
> The logic in C4::Circulation is that causes are returned in Uppercase and
> data associated with causes are in lower case (In some cases the data is
> still appearing as hash elemrnts of the uppercase entry but in these cases
> the case distinction holds) Its a godawful design - but by wrapping the call
> in a rtn that drops any lowercase "pseudo" causes we can fix the bug in hand.

This is really awkward indeed :)
I'd prefer to list all the available error codes and add a big warning to
CanBookBeIssued to inform the devs that this white-list need to be updated as
well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:09:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:09:09 +0000
Subject: [Koha-bugs] [Bug 17173] Quick edit a subfield in frameworks
In-Reply-To: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17173-70-sD8SQqQUDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17173

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54786|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 54829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54829&action=edit
Bug 17173: Quick jump to subfield edition form

There are too many clicks to jump to the edit form of a specific
subfield.

This patch adds a hidden feature (i.e. will not be polished or
documented).

When searching for a tag field from a marc framework structure, it's not
possible to search for a tag subfield to jump directly to the subfield
edition form.

Test plan:
On /admin/marctagstructure.pl?frameworkcode=FRAMEWORKCODE
Search for a subfield (952$d)
you will be redirected to the subfield edition form

There is no check if the subfield does not exist.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:09:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:09:40 +0000
Subject: [Koha-bugs] [Bug 17173] Quick edit a subfield in frameworks
In-Reply-To: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17173-70-vqeqU4Ln7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17173

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:13:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:13:52 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-XrpXqScxaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

--- Comment #1 from Andreas Roussos <arouss1980 at gmail.com> ---
Created attachment 54830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54830&action=edit
Bug 17185: Staff client shows "Lists that include this title:" even if item is
not in a list

In the staff client, the text "Lists that include this title:"
is always shown, regardless of whether the item is in a list
or not. This patch fixes that.

Test plan:
1) Log in to staff client.
2) Go to biblio details view:
   /cgi-bin/koha/catalogue/detail.pl?biblionumber=X
   Confirm that "Lists that include this title:" is
   shown even if the item is not in a list.
3) Apply the patch.
4) Repeat step 2. Confirm that the patch works, i.e.
   "Lists that include this title:" is only shown
   for biblios that are actually in a list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:22:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:22:05 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-BfUbsXCZjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hm noemail is picked up by koha-list
So it says something like: if you did not enable email, call cleanup with mail
option. Some kind of contradiction in itself huh?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:29:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:29:43 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-jpZroGo3nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:29:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:29:45 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-KHSBLdVhDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54831&action=edit
Bug 17159: Do not conditionally run cleanup_database with --mail

As a simplification, I propose here to just call cleanup_database in
only one line. And not test the mail enabled/disabled flag for the --mail
option. If we have no lines to delete, that's just fine and we can go
home early :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:30:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:30:24 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-5Mc9ZdsKIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:33:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:33:58 +0000
Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail
 cleanup_database.pl --mail
In-Reply-To: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17159-70-Oqt2Aa3WT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54832&action=edit
Bug 17159: Add --mail to the cron example file too

It was not even there yet.

Test plan:
Verify if this change looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:39:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:39:34 +0000
Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic
	search
In-Reply-To: <bug-14899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14899-70-XsleRhVcdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:41:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:41:24 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-p1r5YjZzxS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Andreas Roussos <arouss1980 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:45:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:45:46 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-QEsnI6ev6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:45:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:45:49 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-0NtGhQ1u7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54830|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54833&action=edit
Bug 17185: Staff client shows "Lists that include this title:" even if item is
not in a list

In the staff client, the text "Lists that include this title:"
is always shown, regardless of whether the item is in a list
or not. This patch fixes that.

Test plan:
1) Log in to staff client.
2) Go to biblio details view:
   /cgi-bin/koha/catalogue/detail.pl?biblionumber=X
   Confirm that "Lists that include this title:" is
   shown even if the item is not in a list.
3) Apply the patch.
4) Repeat step 2. Confirm that the patch works, i.e.
   "Lists that include this title:" is only shown
   for biblios that are actually in a list.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Only applies to non-XSLT view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:49:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:49:49 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-BP8L2mp4K3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.05                       |master
           Assignee|gmcharlt at gmail.com          |arouss1980 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:53:18 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-BAeehHEPhI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 16:53:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 14:53:20 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-EuoIgbZb8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54833|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54834&action=edit
Bug 17185: Staff client shows "Lists that include this title:" even if item is
not in a list

In the staff client, the text "Lists that include this title:"
is always shown, regardless of whether the item is in a list
or not. This patch fixes that.

Test plan:
1) Log in to staff client.
2) Go to biblio details view:
   /cgi-bin/koha/catalogue/detail.pl?biblionumber=X
   Confirm that "Lists that include this title:" is
   shown even if the item is not in a list.
3) Apply the patch.
4) Repeat step 2. Confirm that the patch works, i.e.
   "Lists that include this title:" is only shown
   for biblios that are actually in a list.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Only applies to non-XSLT view.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 17:31:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 15:31:44 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-znUjrV8Ml7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #83 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #76)

> > What do you think?
> 
> Sounds good. But please open up a new report.

Let's move it to Bug 17135 (entities must not be multiplied beyond necessity
;). After all, without the 3.a. part from comment #75 or something like that,
Bug 14390 is only a half of the solution for this issue - i.e. Bug 17135 is
still valid and still a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 17:43:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 15:43:35 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-mhj8lDC80y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 17:44:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 15:44:40 +0000
Subject: [Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
In-Reply-To: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17008-70-gfwHWqrvlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 17:45:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 15:45:20 +0000
Subject: [Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in
 Swagger tags for holds
In-Reply-To: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17086-70-RuiZQh39WO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 17:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 15:45:44 +0000
Subject: [Koha-bugs] [Bug 17126] REST API: add route to delete biblio
In-Reply-To: <bug-17126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17126-70-aEsoRnLbao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17126

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 18:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 16:25:22 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-OMrE84sigX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #84 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks for the followup and qa Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 21:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 19:42:54 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-1uMQOyVdoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We've concluded to wait for this until bug 14868 is sorted out and not to
backport REST API patches for now to the stable releases until we have worked
out the structure of things a bit more.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 21:44:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 19:44:49 +0000
Subject: [Koha-bugs] [Bug 17190] New: Mark REST API dependencies as
 mandatory in PerlDependencies.pm
Message-ID: <bug-17190-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190

            Bug ID: 17190
           Summary: Mark REST API dependencies as mandatory in
                    PerlDependencies.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

A bug to not forget this when making the REST API mandatory by using it for
features in the GUI.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 21:45:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 19:45:13 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-EmsLAzsqBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17190


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190
[Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 21:45:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 19:45:13 +0000
Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in
 PerlDependencies.pm
In-Reply-To: <bug-17190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17190-70-QuzEFcqHpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 21:50:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 19:50:46 +0000
Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate
 pending and approved comments by branch.
In-Reply-To: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12022-70-xWrHmxEmFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, sorry, but I think this behaviour change will possibly upset some
libraries. Could we tie it to IndyBranches - or a new pref? There is another
example where the latter has been done: IndependentBranchesPatronModifications

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:04:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:04:59 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-DJ0AJenX3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Conclusion at the dev meeting was: I am too paranoid ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:18:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:18:38 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
	record
In-Reply-To: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8030-70-GzgyPF9dFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking 'BLOCKED' for now - please swich back once dependencies have been
cleared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:26:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:26:35 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-qvDUbtXPE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we make this also dependent on bug 14868?
We also need to resolve the question of taking opacuserlogin into account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:51:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:51:35 +0000
Subject: [Koha-bugs] [Bug 17191] New: Confirm message on deleting tag in OPAC
Message-ID: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

            Bug ID: 17191
           Summary: Confirm message on deleting tag in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

There is currently no confirm message before deleting a tag in OPAC, there
should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:53:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:53:06 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-csXrvZodZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:53:09 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-09aTJQN1EA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54835&action=edit
Bug 17191: Confirm message on deleting tag in OPAC

To test:
1) Log into OPAC, go to your tags
2) Click Delete
3) Confirm message should pop up
4) Ensure clicking Cancel works as expected, ensure clicking OK works as
expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:53:23 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-kXVifNQosq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:58:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:58:10 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-WsrZK6f1dX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53519|0                           |1
        is obsolete|                            |

--- Comment #12 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54836&action=edit
[SIGNED-OFF] Bug 16912: Koha::Patrons - Move and rewrite tests for
AddEnrolmentFeeIfNeeded

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:58:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:58:24 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-IeGYNcbw26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

--- Comment #13 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54837&action=edit
Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to
->add_enrolment_fee_if_needed

This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded
subroutine to the Koha::Patron->add_enrolment_fee_if_needed method.
The behavior should be unchanged.

Test plan:
1/ Define enrolment fee for 2 patron categories
2/ Create a patron using the first category
=> The patron should be charged
3/ Change the patron category to the other one
=> The patron should be charged again

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 22:59:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 20:59:49 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-yMWnS6gH4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54837|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:00:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:00:20 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-KtAzrXkn8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:00:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:00:23 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-7DGPoaM7k3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54804|0                           |1
        is obsolete|                            |

--- Comment #14 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54838&action=edit
[SIGNED-OFF] Bug 16912: Update patron category enrolment fees

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:01:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:01:21 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-Cp2aZBuvcJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|cunha at monterey.org          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:01:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:01:26 +0000
Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move
 AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
In-Reply-To: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16912-70-TtwGlSaOBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

--- Comment #15 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
All tests pass and patch works as described, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:05:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:05:12 +0000
Subject: [Koha-bugs] [Bug 15700] Buttons don't work in inventory
In-Reply-To: <bug-15700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15700-70-Ecr7aGfwC7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15700

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Buttons don't work in       |Buttons don't work in
                   |inventory/stocktaking       |inventory

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:06:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:06:36 +0000
Subject: [Koha-bugs] [Bug 15700] Buttons don't work in inventory
In-Reply-To: <bug-15700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15700-70-ejHBSh41In@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15700

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
This looks like it has been fixed in version 16.06. Setting to Resolved :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:11:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:11:37 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-Vz6OhmMqbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Some of this has been fixed (the radio buttons work as expected now), but the
default framework only ever exports as .ods file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:11:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:11:45 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-6LebVee0Uj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:29:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:29:28 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-7hYjhIGw8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:29:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:29:32 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-1TJ2Q8VqNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54839&action=edit
Bug 16035: MARC default bibliographic framework Export fix

This patch makes sure that, if there is no framework code passed, then
'default' is passed. At the moment, no framework code was being passed
so the code broke and triggered some warns too.

To test:
1) Go to Admin -> MARC Bibliographic framework
2) Try to export default framework in all formats, notice the file is
only exported as .ods and is an empty file. Notice warns in intranet
error log.
3) Apply patch and refresh page
4) Confirm exporting default framework works in all formats and
spreadsheet has data
5) Notice warns in error log are gone
6) Confirm export still works for other frameworks

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 24 23:30:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 21:30:15 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-97VLUEtkC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 00:04:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 22:04:55 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-Vs6ODyBLwY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 53699
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53699
Bug 12532 - Redirect guarantee email to guarantor

Review of attachment 53699:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=53699)
-----------------------------------------------------------------

Hi Maxime and Mehdi,

working on this again:

A) I am confused about some changes that seem unrelated to this feature - can
you please explain you explain and/or amend test plan? (see splitter comments
below)
B) Is it correct that ACCTDETAILS and RLIST have been dropped from this patch
set? (comparing comment#1 to code and syspref description)

C) I'd also like to take into account Kyle's earlier comment#28:

>1) Should this be a blanket setting? Maybe the parent of an 8 year old would want this, but not the parent of a 17 year old
I agree with Kyle here, having this as a global setting will not match the
needs of every library. But I think moving from global to more granular should
be possible later without any regressions, so for me this is not a blocker.

>2) Should the generation of the notice be based on the guarantees messaging settings, or the guarantors?
It's a good question: Who can decide that the e-mails are forwarded? I don't
have a clear idea about this.
Again, not a blocker for me if we'd handle this globally at first. Maybe it
could also be a setting under administration -> category codes?

>3) Following 2, perhaps guarantors should have the option of receiving notices of guarantees as part of the messaging preferences
See above :)

>4) Wouldn't it be prudent to send the notice to both? It could just CC the guarantor
I have thought about it and I'd really like to see this change happen. I know
more places need to be touched, but it seems to be a much cleaner and clearer
solution to me. Also: if we change this later on, we got a behaviour change.
Worth to give this more thought from the beginning.

>I think at a minimum this should be an option for each guarantor, and the email should just add them as a CC ( or some other method so that both the guarantee and guarantor receive >the notice ). A default setting of on or off could be added to the patron types editor, and a checkbox for receiving guarantees notices could be added to the messaging settings for >guarantors on the staff side and the opac.

@Kyle - would you be ok with this being global and CC as a first step?

D) Some thoughts about wording - you might want to check this with a native
speaker :)

- I am in favor of short preference names - I was wondering if we couldn't 
  just leave the "Enable" off: RedirectGuaranteeEmail
- Similar for the preference description: 
  Now: [Do|Don't] enable the ability to redirect guarantee email messages 
  to guarantor. All email message placed in message_queue table will be
affected.
  Suggestion: [Enable|Don't enable] redirection of guarantee email messages to
the guarantor.
  All email messages send via the message_queue table will be affected.

-------------------------------------------

Some general notes:
- database update - ok
- QA test tools - ok
- tests pass for me - apart from one test failing in 
  Letters.t before and after the patch - ok
- functionality tested for checkout notices with and 
  without guarantor and yes/no pref setting - ok

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ +183,5 @@
> +         - pref: EnableRedirectGuaranteeEmail
> +           choices:
> +               yes: Do
> +               no: "Don't"
> +         - enable the ability to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected.

In the initial description of this feature you named ACCTDETAILS and RLIST -
those don't go through the message_queue. Looking at the code, I think they are
not included?
Which messages are affected?

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +82,1 @@
>  

Why those changes?

@@ +1069,5 @@
> +    [% IF ( !opadd ) && ( !opduplicate ) && !destination %]
> +        <script type="text/javascript">
> +            $("#saverecord").attr("id","PatronMmessagingPreferences");
> +        </script>
> +    [% END %]

Same here: why those changes?

::: members/memberentry.pl
@@ +323,5 @@
>      push @errors, "ERROR_login_exist";
>    }
>    
> +  my $password = $input->param('password') || '';
> +  my $password2 = $input->param('password2') || '';

Same here: why those changes?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 00:05:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 22:05:14 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-7L8zawlQW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 00:35:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 22:35:04 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-DmluCvvW73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not a real fan of the dangling '&' - instead of fixing it, does someone
know of the ref parameter is required? It appears to be hardcoded to
ref=sib_dp_pt/002-7879865-0184864, but links also appear to work without it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 00:57:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 22:57:22 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-XZWSQJk0fK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like Reed Wade removed the ref parameter in the first attempt to fix
this bug:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10024

Wasn't able to find out when and why it was added.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 01:01:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 23:01:53 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-CAFN3NQG3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I ended up way back... where no bug numbers and explanations exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 01:52:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 24 Aug 2016 23:52:33 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn' t work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-MkIMz7qJnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Interesting read in this context - I wasn't aware of the database side check
option before:
http://bywatersolutions.com/2013/07/23/match-points-in-koha/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 06:04:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 04:04:44 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-GpjuHw5aEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 06:04:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 04:04:49 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-RoVzEc6twX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53066|0                           |1
        is obsolete|                            |

--- Comment #20 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54840&action=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) IMPORTANT STEP:
    Before you import, make sure that the authtypecode of the file you
    are going to import matches the Code of your new authority type. Use
    Vim or something similar to do a search and replace and change the
    codes in your file - do NOT use LibreOffice etc. because it tries to
    be too helpful and messes with the formatting of the file (this is what has
    broken the Import function in previous testing of this patch)
7) Import into your new authority type using the file you just exported
(make sure you've done Step 6)
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 06:11:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 04:11:09 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-t6FyVBLLef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #21 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Just to explain further:
We worked out why Import wasn't working. The patch itself appears to be fine. 

When we try to Import and exported file, the database sees that authtypecode
already exists and instead of importing into a new authority type, it simply
updates the existing authority type with that authtypecode. This is why we see
no error when it doesn't work - it still 'worked', just didn't do what we
wanted it to do.

This means we must change the file itself so that authtypecode matches the Code
of our new authority type, however after spending way too long fiddling around,
we realised that LibreOffice formatted the file weirdly after saving and caused
errors in the file, so the Import didn't work properly. This is probably a
separate bug, regarding the way the code handles incorrectly formatted files
and the error message it shows.

Changing the authtype code in Vim did not stuff up the formatting and meant we
were able to Import correctly. So, the patch itself should work as long as all
the speechmarks etc. are in the right places after you have changed the
authtypecode to match your new authority type.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 07:26:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 05:26:23 +0000
Subject: [Koha-bugs] [Bug 7569] Add Google Transliteration tool to fields
 during cataloging and in advanced search in OPAC
In-Reply-To: <bug-7569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7569-70-oemYjhp8rC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in
           Assignee|ebin.joseph at osslabs.biz     |indradg at l2c2.co.in

--- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> ---
This bug has not been touched by the assignee (Ebin Joseph) in last 4+ years.
The original reporter (Savitra Sirohi) too has moved on (he no longer works in
library technology domain). Given that this is useful to Indian libraries, L2C2
Technologies will like to take over this bug and push out the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 07:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 05:26:59 +0000
Subject: [Koha-bugs] [Bug 7569] Add Google Transliteration tool to fields
 during cataloging and in advanced search in OPAC
In-Reply-To: <bug-7569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7569-70-ixZ9UkzBYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 07:44:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 05:44:01 +0000
Subject: [Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper
	record
In-Reply-To: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16921-70-QlN8yuCHkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Hi all! Hmmmm - problems disappeared upgrading to zebra 2.0.62. (Forgot about
this bug, actually!)
The version in fedora was a bit older than that - I've updated that too! :-)
Closing this bug - thanks for all the help everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 08:07:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 06:07:15 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-pHWEpGn2U6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 08:09:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 06:09:05 +0000
Subject: [Koha-bugs] [Bug 17192] New: Authority search paging doesn't work
Message-ID: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17192

            Bug ID: 17192
           Summary: Authority search paging doesn't work
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: vanoudt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Hi everyone,

Found an interesting bug in authority search. Basically, page 1 of the data
shows items 1-20, page 2 of the search shows items 2-21, page 3 shows 3-22 etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 08:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 06:12:41 +0000
Subject: [Koha-bugs] [Bug 17192] Authority search paging doesn't work
In-Reply-To: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17192-70-QKiOsypD0m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17192

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |vanoudt at gmail.com
           Assignee|gmcharlt at gmail.com          |vanoudt at gmail.com

--- Comment #1 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 54841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54841&action=edit
Fix authority paging

The attached patch fixes authority paging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 08:37:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 06:37:56 +0000
Subject: [Koha-bugs] [Bug 17192] Authority search paging doesn't work
In-Reply-To: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17192-70-i3rtfFEway@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17192

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 09:25:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 07:25:13 +0000
Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to
 'starts_with' and not getting correct parameters to parse multiple word
 searches
In-Reply-To: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15930-70-Pmh3MAJbwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Julian Maurice from comment #19)
> Pushed to 3.22.x, will be in 3.22.10

Wrong bug. Please ignore that comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 09:25:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 07:25:14 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14544-70-jZkPkZJxTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17185


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185
[Bug 17185] Staff client shows "Lists that include this title:" even if item is
not in a list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 09:25:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 07:25:14 +0000
Subject: [Koha-bugs] [Bug 17185] Staff client shows "Lists that include this
 title:" even if item is not in a list
In-Reply-To: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17185-70-XX5CoxDah9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14544
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544
[Bug 14544] Move the list related code to Koha::Virtualshelves
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 09:27:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 07:27:07 +0000
Subject: [Koha-bugs] [Bug 17106] DataTables patron search defaulting to
 'starts_with' - doc
In-Reply-To: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17106-70-zUQ7DqGUkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 09:54:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 07:54:53 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-HFEkN9tnJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
The database schema has been updated by Chris Cormack as of today after a
request on the koha-devel list.

See:
http://schema.koha-community.org/16_05/
http://schema.koha-community.org/master/

(cc-ing Chris Cormack)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:05:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:05:58 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-ibeEU6M3ze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #173 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #150)
> > Note that this patch set is not ready to be pushed as it, there is a big
> > lack of tests (for new modules, new subroutines/methods and modified
> > subroutines).
> 
> Agreed, I'll take a look and see what I can do about that!

That is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:18:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:18:56 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-HEfr8QGx5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

--- Comment #9 from Holger Mei?ner <h.meissner.82 at web.de> ---
Oops. Sorry about that. And now that I realized it's actually the same code for
both cases, I used "Not renewable (on hold)" as H?ctor suggested. I hope that's
okay :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:19:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:19:40 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-OjvryNUEJA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

--- Comment #10 from Holger Mei?ner <h.meissner.82 at web.de> ---
Created attachment 54842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54842&action=edit
Bug 14434: Display "Not renewable (on hold)" in OPAC

This patch makes the OPAC display "Not renewable (on hold)" when
a hold is placed.

Test plan:
1) Do not apply patch.
2) Issue an item with automatic renewal.
3) Issue an item with manual renewal.
4) Place a hold on both items.
5) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)" for the auto renewed item
   and "(On hold) for the other item.
6) Apply patch.
7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed
   for both items.
8) Cancel the holds, then log in as patron again and confirm that the
   correct renewal conditions are displayed.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:23:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:23:33 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-8JqIfKe3i6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Holger Mei?ner <h.meissner.82 at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54512|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:24:02 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-vG8J4zNTCQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Holger Mei?ner <h.meissner.82 at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:29:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:29:43 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-XGVJ99XZh6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Holger Mei?ner <h.meissner.82 at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54842|0                           |1
        is obsolete|                            |

--- Comment #11 from Holger Mei?ner <h.meissner.82 at web.de> ---
Created attachment 54843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54843&action=edit
Bug 14434: Display "Not renewable (on hold)" in OPAC

This patch makes the OPAC display "Not renewable (on hold)" when
a hold is placed.

Test plan:
1) Do not apply patch.
2) Issue an item with automatic renewal.
3) Issue an item with manual renewal.
4) Place a hold on both items.
5) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)" for the auto renewed item
   and "(On hold) for the other item.
6) Apply patch.
7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed
   for both items.
8) Cancel the holds, then log in as patron again and confirm that the
   correct renewal conditions are displayed.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 10:48:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 08:48:01 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-7qHjt1SvMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

--- Comment #3 from Michael Kuhn <mik at adminkuhn.ch> ---
Even after the update of the database schema the field "sms_provider_id" is not
there, neither in http://schema.koha-community.org/16_05/ nor in
http://schema.koha-community.org/master/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:00:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:00:46 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-dQrKt7RJua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |ASSIGNED
             Blocks|                            |15342

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As of a topic on the ML
(http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html)
removing this column would bring performance gains.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342
[Bug 15342] Performance 3.22 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:00:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:00:46 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15342-70-6Ypsr0vlrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455
[Bug 10455] remove redundant 'biblioitems.marc' field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:15:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:15:53 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-S3nubuU8rU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX
                 CC|                            |z.tajoli at cineca.it

--- Comment #4 from Zeno Tajoli <z.tajoli at cineca.it> ---
In fact I use ICU on jessie and I install Zebra from  Indexdata repositories.
I think it is the only option avaible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:30:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:30:17 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-UYbOqT6XU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:30:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:30:20 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-Ox2aUUjxqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54844&action=edit
Bug 10455: Remove biblioitems.marc - DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:30:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:30:24 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-1CbkCljbA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54845&action=edit
Bug 10455: Remove biblioitems.marc

Any discussions about biblioitems.marc bring to the same conclusion:
This field is useless and should be removed.
We are storing MARC data into 2 different fields, that does not make
sense.

Test plan:
Add / update / export / import /delete records
should work as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:30:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:30:28 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-2cbOSXDaB1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54846&action=edit
Bug 10455: Remove biblioitems.marc - rm MARC21_parse_test.pl

This script seems to be unused and it won't be of any usefulness after
the removal of biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:30:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:30:35 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-xDm2M3FmFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54847&action=edit
Bug 10455: Remove biblioitems.marc - update delete_records_via_leader.pl

Recently added, delete_records_via_leader.pl reads biblioitems.marc as a
text field and search for record to delete regarding the leader 5.
This can be acchieve doing the same thing on biblioitems.marcxml (will
certainly be slower) waiting for a patch on bug 15537.

Test plan:
Confirm that this script works as before, to do so the easiest way would
be to dump your DB before executing the update DB entry, execute the
script to delete records, reinsert the DB, execute the udpate DB entry
(remove biblioitems.marc), execute the script to delete records.
You should get the same number of records deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:32:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:32:08 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-ZBviboziU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10455
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have modified this script on bug 10455 with:

-my @biblioitems =
-  $schema->resultset('Biblioitem')->search( { marc => { LIKE => '_____d%' } }
);
+my @biblioitems = # Should be replaced by a call to C4::Search on zebra index
+                  # Record-status when bug 15537 will be pushed
+  $schema->resultset('Biblioitem')->search( { marcxml => { LIKE =>
'<leader>_____d%' } } );

Could you confirm you agree with that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:32:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:32:08 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-cmaecc2Nm8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11084

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:38:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:38:48 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-7GsDzdzXNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #5 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #4)
> + if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) {

> Or would rounding with Math::Round::nearest be better than sprintf ?

Quite possibly; sprintf('%.6f', ...) is not ideal, theoretically this
comparison may still fail (but less often then currently) for some borderline
cases, because mysql is supposedly using slightly different kind of rounding
for internal decimal(x,y) arithmetic then sprintf (sprintf: half to even aka
bankers rounding, mysql - half away from zero, commercial rounding).

If someone is having numbers like 1.1212125 (more then 6 fractional digits, and
the 7th digit is 5) in circulation & fine rules, calculated fine amount may get
rounded differently. In such case though, fines.pl being not always as fast as
humanly possible would be the least of his/her problems ;)

> Why not force them both to sprintf and get rid of the hardcoded 6 ?

I guess this can be done in other ways like

   abs($amount1 - $amount2) < 0.000001

but IMO that specific .6 precision is kind of important?

>     my $info = $schema->source('Accountline')->column_info('amount');
>     my $scale = $info->{size}->[1];

This (and adding a new module for more predictable rounding etc.) would be a
good start for solving all prices / fines rounding problems in Koha, once and
for all.. I'm just not entirely happy with starting such monumental task right
in this report, looks like a bit of an overkill to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:41:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:41:42 +0000
Subject: [Koha-bugs] [Bug 17193] New: C4::Search::SearchAcquisitions is not
	used
Message-ID: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

            Bug ID: 17193
           Summary: C4::Search::SearchAcquisitions is not used
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

and can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:42:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:42:43 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-3eUDrnwem6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:42:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:42:45 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-reB9iA5QxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54848&action=edit
Bug 17193: Remove C4::Search::SearchAcquisitions

This subroutine is not used and can be removed

Test plan:
  git grep SearchAcquisitions
should not return any results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 11:43:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 09:43:03 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-GgQZ7x5QHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #5)
> This (and adding a new module for more predictable rounding etc.) would be a
> good start for solving all prices / fines rounding problems in Koha, once
> and for all.. I'm just not entirely happy with starting such monumental task
> right in this report, looks like a bit of an overkill to me.

Agreed. But replacing a hardcoded 6 by one or two lines might not be that
monumental ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:17:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:17:23 +0000
Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search
 terms to z39.50 search
In-Reply-To: <bug-13062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13062-70-4TbJIuuiuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062

Michal Dudzik <dudzikmichal at wp.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dudzikmichal at wp.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:19:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:19:17 +0000
Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started
 from the " Edit biblio record" page
In-Reply-To: <bug-8583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8583-70-64eQwgTaNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583

Michal Dudzik <dudzikmichal at wp.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dudzikmichal at wp.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:20:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:20:03 +0000
Subject: [Koha-bugs] [Bug 13989] Undocumented Option in ILS-DI LookupPatron
In-Reply-To: <bug-13989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13989-70-NXILbzfp7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13989

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |z.tajoli at cineca.it
         Resolution|---                         |FIXED

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
In the description of LookupPatron API now I see from C4/ILSDI/Services.pm:

 273 
 274 =head2 LookupPatron
 275 
 276 Looks up a patron in the ILS by an identifier, and returns the
borrowernumber.
 277 
 278 Parameters:
 279 
 280   - id (Required)
 281         an identifier used to look up the patron in Koha
 282   - id_type (Optional)
 283         the type of the identifier, possible values:
 284         - cardnumber
 285         - firstname
 286         - userid
 287         - borrowernumber

cardnumber, firstname, userid, borrowernumber are the values from 
homonym column of borrowers table.
http://schema.koha-community.org/tables/borrowers.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:23:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:23:25 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-TTC3MVppQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:27:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:27:20 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-ZFUdwecTH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54849&action=edit
Bug 10455: (follow-up) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:28:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:28:32 +0000
Subject: [Koha-bugs] [Bug 17194] New: When edit record,
 Button "Z39.50/SRU search" not work
Message-ID: <bug-17194-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194

            Bug ID: 17194
           Summary: When edit record, Button "Z39.50/SRU search" not work
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: dudzikmichal at wp.pl
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When edit record and click to button "Z39.50/SRU search" the popup not showing.
Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:30:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:30:31 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-63UFhWJkuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54849|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54850&action=edit
Bug 10455: (follow-up) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:38:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:38:33 +0000
Subject: [Koha-bugs] [Bug 2778] Search Also missing from subfied framework
	edit
In-Reply-To: <bug-2778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2778-70-S8psX1NtxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2778

Michal Dudzik <dudzikmichal at wp.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dudzikmichal at wp.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:39:46 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
 even when there is no need
In-Reply-To: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17138-70-BmcOfUV6m0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #7 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Jacek Ablewicz from comment #5)
> > This (and adding a new module for more predictable rounding etc.) would be a
> > good start for solving all prices / fines rounding problems in Koha, once
> > and for all.. I'm just not entirely happy with starting such monumental task
> > right in this report, looks like a bit of an overkill to me.
> 
> Agreed. But replacing a hardcoded 6 by one or two lines might not be that
> monumental ?

Ok, I'm happy with that; I don't have any strong opinion either way. My gut
feeling though is that it would be better to have this in some kind of module,
so it will be reusable. Otherwise, I'm worried that something like that would
need to be included in each and every places where calculations in Koha are
being tinkered with.

But I'll better check first if those DBIx calls are not too costly. One never
knows - this DBIx stuff is full of surprises, and not always the pleasant
ones..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 12:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 10:47:25 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-2FEgJheR6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #39)
> Can we merge both patches and have these cronjobs on separate lines again?
Actually, better leave them as-is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:18:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:18:44 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-VG2CaviSXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #40 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Katrin Fischer from comment #39)
> Should we make this also dependent on bug 14868?
I read the dev meeting logs and understood that people like the idea in Bug
14868, but as of now, I find it problematic that if any changes will still be
introduced especially in Bug 14868's dependency Bug 16699, rebasing patches
here will be quite time consuming and could cause hair-pulling. Perhaps we
could wait until Bug 16699's structure gets some type of approval?

> We also need to resolve the question of taking opacuserlogin into account.
Yes I think this should be discussed, for example, could it make sense for
somebody to disable opacuserlogin but still wanting to have API access to own
objects? Or simply control both of these under the same preference,
opacuserlogin?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:32:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:32:44 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-pntRo1CB6B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://ftp.indexdata.dk/pub
                   |                            |/zebra/debian/README

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
I've added a link to the IndexData Debian README file into the URL field above.
The Ubuntu one is here: http://ftp.indexdata.dk/pub/zebra/ubuntu/README

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:53:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:53:01 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-4S4gbig1DZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:53:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:53:04 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-Lfqy2QW3Hj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52800|0                           |1
        is obsolete|                            |

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54851&action=edit
Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue
notices

The patch changes the sequence of cronjobs in the crontab example
file and in the cron.daily file of the packages.

This is why:
1) Renew automatically
   ... only when we can't renew, we want to
2) Calculate fines
   ... once the fine are calculated and charged
   we can print the amount into the
3) Overdue notices

Before the change it could happen that you'd charge for an item,
that would then be renewed. Or that you'd try to print fine
amounts into the overdue notices, when they would only be
charged moments later.

To test:
- configure your system so you have items that should
  - be charged with fines
  - renew automatically
- configure your crontabs according to the example file
  or switch the cron.daily in your package installation with
  the new one
- configure your overdue notices so that one should be generated
  <<items.fine>>
- Wait for the cronjobs or schedule them to run earlier
- Verify all is well and as it should be

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:53:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:53:14 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-P0BGsMTNLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52812|0                           |1
        is obsolete|                            |

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54852&action=edit
Bug 11144 [QA Followup] - Let each script run in sequence even if one fails

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Tested the A;B;C variant here. If A fails, B will run. Since we can safely
assume that A (or B) will not fail on a daily basis, this seems to be better
than running them in the wrong order every day.

As the comments on Bugzilla show, several people support this improved
(reordered) scheme and look forward to improved error handling on another
report (obviously not that simple).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:56:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:56:01 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-G31lE7gYQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Stirring up the discussion again in this final phase(?).
I do not see further objections to pass QA on this one.
Let's solve the "snowball errors" on new reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 13:56:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 11:56:16 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-PzivohAe1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:06:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:06:52 +0000
Subject: [Koha-bugs] [Bug 17195] New: Split logging of item modifications
 from CataloguingLog into separate system preferences
Message-ID: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

            Bug ID: 17195
           Summary: Split logging of item modifications from
                    CataloguingLog into separate system preferences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Because logging modifications to items has so much overhead, it is not
recommended that CataloguingLog be enabled. If we split off modifications to
items into a separate system preference CataloguingLogItems, then libraries can
at least log modifications to records without taking a large processing hit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:20:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:20:27 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-wCD04Cy0Z2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:20:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:20:30 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-2TmZXIJP3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54848|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54853&action=edit
Bug 17193: Remove C4::Search::SearchAcquisitions

This subroutine is not used and can be removed

Test plan:
  git grep SearchAcquisitions
should not return any results.

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:30:51 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-dNoZDC5lfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:30:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:30:54 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-42sr0tfqgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54835|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54854&action=edit
Bug 17191: Confirm message on deleting tag in OPAC

To test:
1) Log into OPAC, go to your tags
2) Click Delete
3) Confirm message should pop up
4) Ensure clicking Cancel works as expected, ensure clicking OK works as
expected

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:31:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:31:53 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-DK4bhbNsMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54855&action=edit
Bug 10455: (follow-up 2) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:33:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:33:09 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-vwCWSyYTzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54855|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54856&action=edit
Bug 10455: (follow-up 2) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:42:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:42:23 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-DIFscOBSR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Please don't add new instances of "onclick." 

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:44:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:44:02 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-XtYluvQqTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54856|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54857&action=edit
Bug 10455: (follow-up 2) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:44:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:44:27 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-asyT8mwmUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:45:12 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-XQLgKvAKUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54857|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54858&action=edit
Bug 10455: (follow-up 2) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:45:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:45:16 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-h63929SuNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54859&action=edit
Bug 10455: (follow-up 3) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:48:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:48:17 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-4HWz0sLmHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54859|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54860&action=edit
Bug 10455: (follow-up 3) Remove biblioitems.marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:52:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:52:44 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-j4BGOHAGnj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:54:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:54:35 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-gWl5qfPc30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54861&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:54:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:54:40 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-c2XZ1hTeSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54862&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:54:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:54:45 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-EpIgwpZHHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54863&action=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:54:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:54:50 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-CB9XD2AqxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54864&action=edit
Bug 15758: Koha::Libraries - Remove GetBranches

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:54:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:54:56 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-eMugnIdUpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54865&action=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:55:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:55:01 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-CvgyIaPT8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54866&action=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:55:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:55:07 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-jP4v8qqeGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54867&action=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 14:55:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 12:55:12 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-DeQBcFBCn3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54868&action=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:13 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-dmi9gl6EMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54037|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:18 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-hPz8AgWhBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54038|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:23 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-6BPo4iSWjW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54039|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:35 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-i3iG8VDMZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54041|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:28 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-67dHNlGHAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54040|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:40 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-cBsTe8ckDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54042|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:52 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-OxBQS6Ikzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54044|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:01:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:01:46 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-JkAWj5nFQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54043|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:04:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:04:09 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-lrc9LfyGYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|---                         |Large patch

--- Comment #90 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: On my list for tomorrow..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:18:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:18:15 +0000
Subject: [Koha-bugs] [Bug 17195] Split logging of item modifications from
 CataloguingLog into separate system preferences
In-Reply-To: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17195-70-M5T223XieB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:22:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:22:11 +0000
Subject: [Koha-bugs] [Bug 17195] Split logging of item modifications from
 CataloguingLog into separate system preferences
In-Reply-To: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17195-70-KxeXiQxpRe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:22:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:22:13 +0000
Subject: [Koha-bugs] [Bug 17195] Split logging of item modifications from
 CataloguingLog into separate system preferences
In-Reply-To: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17195-70-O2tuerjvgy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54869&action=edit
Bug 17195 - Split logging of item modifications from CataloguingLog into
separate system preferences

Because logging modifications to items has so much overhead, it is not
recommended that CataloguingLog be enabled. If we split off
modifications to items into a separate system preference
CataloguingLogItems, then libraries can at least log modifications to
records without taking a large processing hit.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Disable CataloguingLog and CataloguingLogItems
4) Edit a record and edit an item
5) Note no action logs are produced
6) Enable CataloguingLog
7) Edit a record and edit an item
8) Note only a record edit action log is produced
9) Disable CataloguingLog, enable CataloguingLogItems
10) Edit a record and edit an item
11) Note only an item edit action log is produced
12) Enable both CataloguingLog and CataloguingLogItems
13) Edit a record and edit an item
14) Note an action log is created from both edits

This test plan can be repeated with creating and deleting items/records
as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:29:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:29:10 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-MQowrccquR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:29:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:29:16 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-wA5H4t0mvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54287|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:29:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:29:58 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-QN79Vkxijl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54286|0                           |1
        is obsolete|                            |

--- Comment #37 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54870&action=edit
Bug 16212: Add script minifySwagger.pl

This patch introduces the misc/devel/minifySwagger.pl script that
loads the Swagger files, follows references and produces a compact
("minified") version of the swagger file which is suitable for
distribution.

The wiki page should be updated with instructions on how to regenerate
it so the Release Manager does it on each spec upgrade.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:31:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:31:33 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-BYRXiDP0oA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54288|0                           |1
        is obsolete|                            |

--- Comment #38 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54871&action=edit
Bug 16212: Use swagger.min.json insted of swagger.json

Our current approach with splitting the Swagger specification brings problems.
For example, in swagger.json, if we split the whole "definitions" object with
$ref, validations will fail with online.swagger.io validator.

(See http://online.swagger.io/validator/debug?url=url_to_your_swagger_json)

The problem also occurs with "paths" (Paths Object), because simply $ref to all
paths for example in /paths/index.json does not meet the Swagger2
specification.

The problem is solved by using the minification script and the minified version
of swagger.json after which the swagger.min.json is valid Swagger2
specification,
because the minifier resolves the problematic $refs of swagger.json file in the
minified version.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:32:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:32:05 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-ifPSbHt7Bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:32:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:32:10 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-uBhXhzv5wV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54870|0                           |1
        is obsolete|                            |

--- Comment #39 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54872&action=edit
Bug 16212: Add script minifySwagger.pl

This patch introduces the misc/devel/minifySwagger.pl script that
loads the Swagger files, follows references and produces a compact
("minified") version of the swagger file which is suitable for
distribution.

The wiki page should be updated with instructions on how to regenerate
it so the Release Manager does it on each spec upgrade.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:32:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:32:36 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-8GnfMD1qbj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:32:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:32:44 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-CFaTZCMrpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54871|0                           |1
        is obsolete|                            |

--- Comment #40 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54873&action=edit
Bug 16212: Use swagger.min.json insted of swagger.json

Our current approach with splitting the Swagger specification brings problems.
For example, in swagger.json, if we split the whole "definitions" object with
$ref, validations will fail with online.swagger.io validator.

(See http://online.swagger.io/validator/debug?url=url_to_your_swagger_json)

The problem also occurs with "paths" (Paths Object), because simply $ref to all
paths for example in /paths/index.json does not meet the Swagger2
specification.

The problem is solved by using the minification script and the minified version
of swagger.json after which the swagger.min.json is valid Swagger2
specification,
because the minifier resolves the problematic $refs of swagger.json file in the
minified version.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:35:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:35:25 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-F8n5Mg7syw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #41 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I've moved the minifySwagger.pl script back to misc/devel as it is similar to
how we handle the DBIx schema files.

@RM: Beware you need to create the minified file before pushing this patches,
as it would otherwise break the REST api (which points to the minified version
with this patchset):

$ misc/devel/minifySwagger.pl --source api/v1/swagger.json --destination
api/v1/swagger.min.json

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:36:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:36:03 +0000
Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized
In-Reply-To: <bug-14939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14939-70-dGdjoLwR76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 45602
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45602
Bug 14939: Modularize OAI Server existing classes

Review of attachment 45602:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14939&attachment=45602)
-----------------------------------------------------------------

::: Koha/OAI/Server/ListRecords.pm
@@ +42,5 @@
> +        $set = GetOAISetBySpec($token->{'set'});
> +    }
> +    my $max = $repository->{koha_max_count};
> +    my $sql = "
> +        (SELECT biblioitems.biblionumber, biblioitems.timestamp, marcxml

We have this...

@@ +49,5 @@
> +    $sql .= " JOIN oai_sets_biblios ON biblioitems.biblionumber = oai_sets_biblios.biblionumber " if defined $set;
> +    $sql .= " WHERE timestamp >= ? AND timestamp <= ? ";
> +    $sql .= " AND oai_sets_biblios.set_id = ? " if defined $set;
> +    $sql .= ") UNION
> +        (SELECT deletedbiblio.biblionumber, null as marcxml, timestamp FROM deletedbiblio";

then this (marcxml and timestamp inverted)

@@ +67,5 @@
> +    $sth->execute( @bind_params );
> +
> +    my $count = 0;
> +    my $format = $args{metadataPrefix} || $token->{metadata_prefix};
> +    while ( my ($biblionumber, $timestamp) = $sth->fetchrow ) {

And finally this.

Should not we remove marcxml (as it's unused)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:43:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:43:45 +0000
Subject: [Koha-bugs] [Bug 17196] New: Move marcxml out of the biblioitems
	table
Message-ID: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

            Bug ID: 17196
           Summary: Move marcxml out of the biblioitems table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:45:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:45:54 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-t00fZD1uTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197
[Bug 17197] misc/batchupdateISBNs.pl is certainly no longer in use
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:45:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:45:54 +0000
Subject: [Koha-bugs] [Bug 17197] New: misc/batchupdateISBNs.pl is certainly
 no longer in use
Message-ID: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197

            Bug ID: 17197
           Summary: misc/batchupdateISBNs.pl is certainly no longer in use
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 17196

This script has not been updated for ages and is UNIMARC specific.
Since I am working on bug 17196 to move marcxml out of biblioitems table, I'd
like not to rewrite unused scripts (and lost my time...)
So if someone complains later, I will rewrite it on top of bug 17196.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:46:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:46:04 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-0pJCoUBg2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:46:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:46:04 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-0mvIN2qpmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455
[Bug 10455] remove redundant 'biblioitems.marc' field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:47:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:47:12 +0000
Subject: [Koha-bugs] [Bug 17197] misc/batchupdateISBNs.pl is certainly no
	longer in use
In-Reply-To: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17197-70-E4cpznXw4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:47:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:47:15 +0000
Subject: [Koha-bugs] [Bug 17197] misc/batchupdateISBNs.pl is certainly no
	longer in use
In-Reply-To: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17197-70-PTy4zVPWOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54874&action=edit
Bug 17197: Remove misc/batchupdateISBNs.pl

This script has not been updated for ages and is UNIMARC specific.
Since I am working on bug 17196 to move marcxml out of biblioitems
table, I'd like not to rewrite unused scripts (and lost my time...)
So if someone complains later, I will rewrite it on top of bug 17196.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:50:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:50:55 +0000
Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and
	minification
In-Reply-To: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16212-70-Cdg9NdO5C6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Julian, Lari!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 15:55:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 13:55:14 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-rmksWiWgJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54875&action=edit
Bug 10455: Remove MARC21_utf8_flag_fix.pl

Is this script still in use?
It uses the biblioitems.marc field so if it's still useful it will need
to be rewritten.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:09:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:09:50 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-agPnUzOcDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #90 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54876&action=edit
Bug 7677: QA followup

Fix 'unique contraint primary' error when receiving serials

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:10:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:10:31 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-M4PfsG2Xt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:31:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:31:15 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-MrKS8f9fhW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #8 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
> What do you mean by this? If the fund is in the file, it should auto-populate, correct?

Yes, but if the fund code in the file does not match any koha fund code, the
fund will be left blank, and the user will have to select a fund before being
able to submit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:36:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:36:38 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-q1u9WwGmZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
After applying the patch the export is triggered in the correct format, but
it's still mostly empty. The CSV file, for instance, only has header
information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:39:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:39:25 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-iu8w2AFS8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:39:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:39:28 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-yb10xsLOpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54843|0                           |1
        is obsolete|                            |

--- Comment #12 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54877&action=edit
[SIGNED-OFF]Bug 14434: Display "Not renewable (on hold)" in OPAC

This patch makes the OPAC display "Not renewable (on hold)" when
a hold is placed.

Test plan:
1) Do not apply patch.
2) Issue an item with automatic renewal.
3) Issue an item with manual renewal.
4) Place a hold on both items.
5) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)" for the auto renewed item
   and "(On hold) for the other item.
6) Apply patch.
7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed
   for both items.
8) Cancel the holds, then log in as patron again and confirm that the
   correct renewal conditions are displayed.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:43:36 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-GOuFXsQE6y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:43:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:43:39 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-rMbhGxK7yx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54797|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54878&action=edit
[SIGNED-OFF] Bug 17174: Making z39.50 Authority search actions buttons

Have changed the wording of the MARC button to Show MARC to be
consistent with other places in Koha.

To test:

1) Go to Authorities -> New from Z39.50
2) Put in any search terms and click Search
3) Confirm that both options (MARC and Import) now show as buttons "Show
   MARC" and "Import" under one "Actions" column with approriate icons
4) Confirm buttons work as expected
5) Confirm buttons do not wrap on narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 16:58:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 14:58:29 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-cxUIelV8on@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #9 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Nick, can you post the MarcItemFieldsToOrder syspref you used?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:01:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:01:32 +0000
Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page
 while " independent branches" is on
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-ef3Sb3Gg5I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:03:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:03:04 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-xiJHgV4Ivm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Revert Bug 8781 - Access to |Allow transferring of items
                   |Transfer page while         |to be have separate
                   |"independent branches" is   |IndependentBranches syspref
                   |on                          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:07:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:07:13 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-84CEVTRFoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54801|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54879&action=edit
[SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button on patroncard
images

To test:
1) Go to Tools -> Patron Card Creator -> Manage images
2) Upload an image if you haven't already
3) Click Delete selected without selecting any images
4) Notice broken behaviour as described in Description
5) Apply patch, refresh page
6) Click Delete selected without selecting any images
7) Notice alert. Click OK
8) Select one image or more, click Delete selected
9) Notice confirm delete message.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:07:10 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-FeqxZQtV7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:08:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:08:00 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-aSaAC2XVzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:08:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:08:02 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-JBhsQwlb3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18272|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54880&action=edit
Bug 10300 - Allow transferring of items to be have separate IndependentBranches
syspref

Some libraries want to have IndependentBranches enabled, but still be
able to transfer items between themselves.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable IndpendentBranches and IndependentBranchesTransfers
4) Log in as a super librarian
5) Note you can transfer items
6) Log in as a non-super librarian
7) Note you cannot transfer items
8) Disable IndependentBranchesTransfers
9) Note you can now transfer items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:18:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:18:18 +0000
Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
In-Reply-To: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10455-70-GkTqJQckJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54881&action=edit
Bug 10455: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 17:28:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 15:28:01 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-aevYJu9w6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Matthias Meusburger from comment #9)
> Nick, can you post the MarcItemFieldsToOrder syspref you used?

homebranch: 975$a
holdingbranch: 975$b
itype: 975$9|975$z
nonpublic_note: 975$x
public_note: 975$y
loc: 975$8
ccode: 975$c
notforloan: 975$7
uri: 975$u
copyno: 975$n
quantity: 969$h
budget_code: 922$a
price: 975$p

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 18:06:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 16:06:23 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-ardBKArLW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #32 from Owen Leonard <oleonard at myacpl.org> ---
I'm getting a JavaScript error on returns.pl:

SyntaxError: expected expression, got ','
$("#barcode").focus(); },

Is it possible for the error message to use the date format pattern instead of
the date format name? It's not very clear for the alert to say

"Please enter a valid date (should match us)."

It would be better to see:

"Please enter a valid date (should match MM/DD/YYYY)."

Other than that, this seems to be working really well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 18:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 16:09:17 +0000
Subject: [Koha-bugs] [Bug 17198] New: KOha database resotre
Message-ID: <bug-17198-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17198

            Bug ID: 17198
           Summary: KOha database resotre
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: matsyufsms at gmail.com
        QA Contact: testopia at bugs.koha-community.org

HEllo 

I get error whever i try to restore koha.sql on new installaion

Error = ERROR 1062 (23000) at line 113372: Duplicate entry 'INNODB' for key
'name'


HOw cna i get about it

Yusuf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 18:46:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 16:46:57 +0000
Subject: [Koha-bugs] [Bug 17199] New: 844.307.5701) Ricoh printer tech
 support number | Ricoh Printer
Message-ID: <bug-17199-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17199

            Bug ID: 17199
           Summary: 844.307.5701) Ricoh printer tech support number |
                    Ricoh Printer
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: happyhaind at yopmail.com
        QA Contact: testopia at bugs.koha-community.org

844.307.5701) Ricoh printer tech support number | Ricoh Printer  
all!@!!!((844.307.5701)Ricoh Printer )??????????????????????????? Ricoh Printer
customer support number ???????????????????????????usa canada @@Call,
+(844.307.5701) for all type help by How to contact Ricoh by phone Ricoh 
???????????????????????????
customer support number Ricoh tech support phone number usa, Ricoh toll free
phone number +???????????????????????????(844.307.5701) Ricoh tech support
number usa Ricoh Printer  technical
support phone number usa Ricoh customer service phone number usa Ricoh Tech
Support Number,Ricoh Printer  customer service phone number usa,Ricoh tech
support
phone number, Printer Ricoh Tech Support Phone Number, Ricoh Printer  Help Desk
Phone Number, ???????????????????????????Ricoh Printer  tech support number,
Ricoh technical support phone number, @@@???????????????????????????
Ricoh phone number, Ricoh technical support number, Ricoh support phone number,
Ricoh Printer  technical support, Ricoh Customer Service Phone Number, Ricoh
Customer Service Number, Ricoh Customer Support Phone Number, Ricoh Customer
Support Number, @@(844.307.5701)@@ Ricoh Customer Service Helpline
Number,???????????????????????????
Ricoh Customer Care Number, Ricoh support team phone number,
@@(844.307.5701)@@Ricoh help number-Ricoh Helpline Number; Ricoh help phone
number-Ricoh
Helpline Number, Ricoh Tech Support Toll free Number, Ricoh Support Telephone
Number, Ricoh Tech Support Telephone number, Ricoh Tech Support contact
???????????????????????????
number, Ricoh support contact number, Ricoh technical support contact number.
Call, +(844.307.5701) Ricoh tech support phone number, Printer Ricoh Tech
Support Phone Number, Ricoh Help Desk Phone Number, Ricoh tech support number,
Ricoh technical support phone number, Ricoh phone number, Ricoh technical
???????????????????????????
support number, Ricoh support phone number. It is very popular toll free number
844.307.5701 which provide by Ricoh technical support, Ricoh Customer
Service Phone Number, Ricoh Customer Service Number, Ricoh Customer Support
Phone Number, Ricoh Customer Support Number, Ricoh Customer Service Helpline
Number, Ricoh Customer Care Number, Ricoh support team phone number. Call,
Ricoh tech support phone number, Printer Ricoh Tech Support Phone Number,
Ricoh Help Desk Phone Number, Ricoh tech support number, Ricoh technical
support phone number, Ricoh phone number, Ricoh technical support number,
Ricoh support phone number, Ricoh technical support, Ricoh Customer Service
Phone Number, Ricoh Customer Service Number, Ricoh Customer Support Phone
Number, Ricoh Customer Support Number, Ricoh Customer Service Helpline Number,
Ricoh Customer Care Number, Ricoh support team phone number, #Ricoh Tech
Support Phone +(844.307.5701) Number Ricoh customer support number Ricoh
(844.307.5701) technical support Ricoh support phone number Ricoh tech
support toll free number in usa Ricoh tech support phone number Ricoh tech
support phone number free Ricoh technical support phone number Ricoh
technologies phone number Ricoh telephone support number Ricoh support contact
number Ricoh (844.307.5701) customer support phone number Ricoh (1-844-
443-4666) problems Ricoh (844.307.5701) tech support Ricoh (844.307.5701)
technical support Ricoh (844.307.5701) toll free number Ricoh com
customer service phone number Ricoh contact phone number Ricoh contact
telephone number Ricoh customer service contact number Ricoh customer service
eRouter Ricoh customer service phone number Ricoh customer service telephone
number Ricoh customer services eRouter Ricoh customer support eRouter
address Ricoh customer support number Ricoh customer support phone number Ricoh
(844.307.5701) tech support assistant Ricoh support assistant Ricoh
tech support +Ricoh (844.307.5701) +online +support +Ricoh+support+number
+Ricoh+online+support Ricoh (844.307.5701) number technical support Ricoh
(844.307.5701) service number Ricoh (844.307.5701) support contact phone number
Ricoh (844.307.5701) telephone support number telephone number Ricoh
(844.307.5701) customer service number Ricoh (844.307.5701) compaq Ricoh
(844.307.5701) support Ricoh (844.307.5701) compaq support Ricoh (1-844
-443-4666) customer service Ricoh (844.307.5701) contact phone number Ricoh
(844.307.5701) customer phone number Ricoh (844.307.5701) customer
services number Ricoh (844.307.5701) customer support telephone number Ricoh
(844.307.5701) support online Ricoh (844.307.5701) tech support Ricoh
(844.307.5701) service phone number Ricoh (844.307.5701) support customer
service number Ricoh (844.307.5701) tech support phone numbers Ricoh (1-
844-443-4666) technical support contact number Ricoh (844.307.5701) telephone
number customer service number Ricoh (844.307.5701) tech support online
Ricoh (844.307.5701) tech support Ricoh (844.307.5701) customer support Ricoh
(844.307.5701) customer service Ricoh (844.307.5701) online support
Ricoh (844.307.5701) phone number customer support Ricoh (844.307.5701) support
telephone numbers Ricoh (844.307.5701) technical support numbers
Ricoh (844.307.5701) usa support telephone number Ricoh (844.307.5701) support
Ricoh (844.307.5701) support Ricoh support Ricoh (1
???????????????????????????

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 19:00:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 17:00:49 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-Ul7V2WLDro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 19:00:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 17:00:51 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-KD9U9Kb1Kp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54828|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54882&action=edit
[SIGNED-OFF] Bug 17187: Lower the timeout preference from 139 days to 1 day

Default timeout is now 12000000 seconds == almost 139 days !
Surely, your session will be shorter. But we should lower this
value.
Balancing usability and security, I propose 1d (1 day) now.
Current pref value will be affected only if it is NULL or equal
to the old default.

Test plan:
Check your current value. Optionally change to NULL or 12000000.
Run the dbrev and see what happens.
Beware of cached values while testing or flush the cache.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 19:14:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 17:14:07 +0000
Subject: [Koha-bugs] [Bug 17102] Automatically minify swagger.json
In-Reply-To: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17102-70-beewLoFADr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:05:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:05:28 +0000
Subject: [Koha-bugs] [Bug 17200] New: Badly formatted "hold for" patron name
 on catalog detail page
Message-ID: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

            Bug ID: 17200
           Summary: Badly formatted "hold for" patron name on catalog
                    detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

First name and surname are run together under the "status" column on the
bibliographic detail page if an item is on hold for a patron:

" Hold for: JohnSmith (1234567) "

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:16:23 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-sy5zOI7Xp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:16:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:16:26 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-9U3pzNlbPB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54883&action=edit
Bug 17200 - Badly formatted "hold for" patron name on catalog detail page

This patch adds a space between first name and surname on the
bibliographic detail page when there is "hold for" information in the
status column of the holdings table.

To test, apply the patch locate a title in the staff client catalog
which has one or more confirmed holds on it. Verify that the patron's
name in the "status" column of the holdings table looks correct, with a
space between first and last name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:19:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:19:15 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-iq11KCuLbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54299|0                           |1
        is obsolete|                            |

--- Comment #43 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54884&action=edit
Bug 16699: Split parameters and paths in Swagger

Parameters and paths should be split in our Swagger specification, because
otherwise swagger.json would become messy with all the paths and their
further specification in the same file. Also parameters should be split
for the same reason.

Instead of using index.json for definitions, parameters and paths, we define
new files "definitions.json", "parameters.json" and "paths.json" in order to
simplify the references. If we kept using index.json and try to reference
"/definitions/error.json" from "/paths/holds.json", reference would be
"../definitions/index.json#/error" instead of now simplified version,
"../definitions.json#/error".

Here is the proposed structure:

.
??? swagger.json
??? definitions.json
??? paths.json
??? parameters.json
??? definitions
?   ??? error.json
?   ??? patron.json
??? parameters
?   ??? patron.json
??? paths
?   ??? patrons.json
??? minifySwagger.pl
??? swagger.min.js

The swagger.json paths, definitions and parameters will look as follows:
...
  "paths": {
    "$ref": "paths.json"
  },
  "definitions": {
    "$ref": "definitions.json"
  },
  "parameters": {
    "$ref": "parameters.json"
  }
...

A problem with splitting specification into multiple files directly from
swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not
following the Swagger specification and an error will be thrown by the
Swagger-UI default validator (online.swagger.io/validator).

To overcome this problem, we use the minifySwagger.pl script from Buug 16212.
This allows the developers to work with the structure introduced in this patch
thus allowing developers to split the specification nicely, and still have a
valid Swagger specification in the minified swagger.min.json.

To test:
-2: Apply the minifier-patch in Buug 16212.
-1: Make sure you can validate your specification with Swagger2 validator at
    online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it
    locally from https://github.com/swagger-api/validator-badge.

1. Don't apply this patch yet, but first validate swagger.json
   with swagger.io-validator (or your local version, if you installed it)
2. Observe that validation errors are given
3. Run minifySwagger.pl
4. Validate swagger.min.json with the validator you used in step 1
5. Observe that validation passes and we overcame the invalid specification
   problem in swagger.min.json
6. Apply this patch
7. Run minifySwagger.pl
8. Repeat step 4
9. Observe that validation passes with new structure
10. Run REST tests at t/db_dependents/api/v1

(11. Study the new structure of our Swagger specifications :))

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:19:28 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-Sk2cqeTCkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54300|0                           |1
        is obsolete|                            |

--- Comment #44 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54885&action=edit
Bug 16699: Add borrowernumberQueryParam for reusability

The borrowernumber as a query parameter should be defined in parameters.json
in order to allow its reusability.

To test:
1. Apply patch
2. Run minifySwagger.pl
3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+
   _your_swagger_min_json or your local swagger-api/validator-badge validator
4. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:19:37 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-HIkhAr9ils@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54301|0                           |1
        is obsolete|                            |

--- Comment #45 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54886&action=edit
Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces

These definitions had indentation of 4 spaces, while rest of the specification
uses 2 spaces. This patch simply maintains the consistency in indentations and
provides no other modifications to code.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:19:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:19:51 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-8S00jytDs7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54302|0                           |1
        is obsolete|                            |

--- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54887&action=edit
Bug 16699: Support multiple types in primitive definitions

Currently it is not possible to define multiple types for primitive definitions
in /definitions/*. If you try to use the following
"firstname": {
  "type": ["string", "null"],
  "description": "patron's first name"
}
in definitions.json, online.swagger.io validator will not validate it:
{"messages":["attribute definitions.firstname.type is not of type `string`"]}

One way to get around this issue is to extend definitions with custom
"x-primitives" object, where we will define all reusable primitive definitions.

To test:
1. Add the "firstname" example above to definitions.json
2. Run minifySwagger.pl
3. Validate your specification
4. Observe that error with description mentioned above is given
5. Apply patch
6. Repeat step 2 and 3
7. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:20:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:20:02 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-AMuy1fIZWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54303|0                           |1
        is obsolete|                            |

--- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54888&action=edit
Bug 16699: Reference new x-primitives in currently defined objects

Since we have defined some basic x-primitives in x-primitives.json, we can now
start to reuse them in our currently defined objects.

To test:
1. Apply patch
2. Run minifySwagger.pl
3. Validate your Swagger specifications
4. Observe that validation passes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:20:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:20:13 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-h1ZJkMr0Ys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54304|0                           |1
        is obsolete|                            |

--- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54889&action=edit
Bug 16699: Move Swagger-related files to api/v1/swagger

This patch separates Swagger-specifications and the minifySwagger.pl from other
api-files by moving specifications & minifier into api/v1/swagger.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.

Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>

My name is Johanna R?is? and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:20:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:20:21 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-5icodMslf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54372|0                           |1
        is obsolete|                            |

--- Comment #49 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54890&action=edit
Bug 16699: Remove requirement from borrowernumberQueryParam

borrowernumberQueryParam shouldn't be required as also changed in Bug 16271.

To test:
1. Don't apply the patch yet, but first minify Swagger and run
   t/db_dependent/api/v1/holds.t
2. Observe that some tests fail with response code 400 when expecting 200.
3. Apply patch and minify Swagger
4. Run t/db_dependent/api/v1/holds.t
5. Observe that tests pass.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:21:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:21:18 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-YykIrAVUcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 20:21:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 18:21:22 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-MYOweQvQi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

--- Comment #50 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 54891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54891&action=edit
Bug 16699: (QA followup) Move minified swagger file into the swagger/ dir

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 21:34:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 19:34:22 +0000
Subject: [Koha-bugs] [Bug 17199] SPAM
In-Reply-To: <bug-17199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17199-70-LK6INyS88G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|844.307.5701) Ricoh printer |SPAM
                   |tech support number | Ricoh |
                   |Printer                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 22:35:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 20:35:58 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-krG1npzvEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I searched for documentation up and down last night - didn't come up with much. 

We don't have a 'please give feedback' status - so I am setting 'Failed QA',
please take a look and consider/comment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 23:23:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 21:23:10 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-Zwlgja4pIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54891|0                           |1
        is obsolete|                            |

--- Comment #51 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54892&action=edit
Bug 16699: (QA followup) Move minified swagger file into the swagger/ dir

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 23:32:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 21:32:12 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-455FsSwMdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 23:32:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 21:32:15 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17191-70-WPbHeNj2O2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17191

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54854|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54893&action=edit
Bug 17191: Confirm message on deleting tag in OPAC

Edit: removing use of onclick

To test:
1) Log into OPAC, go to your tags
2) Click Delete
3) Confirm message should pop up
4) Ensure clicking Cancel works as expected, ensure clicking OK works as
expected

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Aug 25 23:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 21:43:10 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-K6tLBq5fBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #26)
> I searched for documentation up and down last night - didn't come up with
> much. 
> 
> We don't have a 'please give feedback' status - so I am setting 'Failed QA',
> please take a look and consider/comment.

My guess, and I'm assuming Amazon would be able to tell us, is that ref=...
means that is the page it came from. In terms of generating revenue, I'm
guessing that not just the tag but the ref is also paid. Only Amazon would
know. And their documentation is not easily searched through.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 00:26:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 22:26:26 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-V2Q0KOI06V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54765|0                           |1
        is obsolete|                            |

--- Comment #37 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54894&action=edit
Bug 14868: Swagger2-driven Permission checking

Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.

This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 00:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 22:26:34 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-OBxlmYRQ9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54766|0                           |1
        is obsolete|                            |

--- Comment #38 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54895&action=edit
Bug 14868: Give users possibility to request their own object

Allow access to user's own objects even if they do not have required
permissions.
This will be very useful in many cases where an user wants to request their own
object, for example renewing their checkouts or placing a hold for themselves.

First, this patch renames "x-koha-permission" to "x-koha-authorization" in
order
to describe the new functionality better.

Second, we can now add two extra parameters under "x-koha-authorization":
- "allow-owner"; Allows the owner of object to access it (without permission)
- "allow-guarantor"; Allows guarantor of the owner of object to access it
                     (without permission)

Third, since permission checking is outside of actual controller, we need a way
to find out ownership from different types of parameters, e.g. checkout_id from
/checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc.
A solution is to match the parameter with a subroutine that is designed to
verify
the ownership for that object. See the new subroutines in Koha::REST::V1.

To use this functionality you will simply define it in Swagger:
"/patrons/{borrowernumber}": {
  "get": {
    ...,
    "x-koha-authorization": {
      "allow-owner": true,
      "permissions": {
        "borrowers": "1"
      }
    }
  }
}

If a parameter that is not yet defined in
Koha::REST::V1::check_object_ownership,
you also need to define it and implement a subroutine that determines
ownership.

Tests are provided in a following patch that adds this functionality for
current
API operations.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 00:26:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 22:26:42 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-JswChjMu1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54767|0                           |1
        is obsolete|                            |

--- Comment #39 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54896&action=edit
Bug 14868: Use x-koha-authorization in current routes

To test:
1. Run t/db_dependent/api/v1/holds.t
2. Run t/db_dependent/api/v1/patrons.t

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 00:26:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 22:26:48 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-MUZeZ4WOkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54771|0                           |1
        is obsolete|                            |

--- Comment #40 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54897&action=edit
Bug 14868: Display required permissions in permission error response

When user does not have required permissions to use API operation, it would be
useful to let them know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.

To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 00:36:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 25 Aug 2016 22:36:37 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-rVXntJuVS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #41 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Great Work, Lari!

Tested thus :
1) minified swagger:
perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger/swagger.min.json (minifySwagger should perhaps have execution
permissions?)

2) restarted plack to pick up changes
3) loaded testdata and added circulation rule to allow holds
4) ran tests t/db_dependent/api/v1/patrons.t and t/db_dependent/api/v1/holds.t
5) ran some manual tests, without permissions, observed authentication failure
6) tested with patron session without borrower permissions, permission failure
except on own patron info and own holds
7) tested with superlibrarian

Should get an extra pair of eyes and testing, but I'm all OK.

Now let's get Bug Bug 17004 moving as well (API auth), and we're really moving
towards a great RESTful API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:07:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:07:25 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-gAaMyTdPyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:07:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:07:28 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-qwaUww6Jt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54839|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54898&action=edit
Bug 16035: MARC default bibliographic framework Export fix

This patch makes sure that, if there is no framework code,
     $frameworkcode is set to 'default'. This fixes the format issue.
     Then, if $frameworkcode = default, an empty string (rather than
     null) is passed to the ExportFramework method, as the framework
     code in the DB for default codes is "".

To test:
1) Go to Admin -> MARC Bibliographic framework
2) Try to export default framework in all formats, notice the file is
only exported as .ods and is an empty file. Notice warns in intranet
error log.
3) Apply patch and refresh page
4) Confirm exporting default framework works in all formats and
spreadsheet has data
5) Notice warns in error log are gone
6) Confirm export still works for other frameworks

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:11:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:11:37 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-a6D4z8WeTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54840|0                           |1
        is obsolete|                            |

--- Comment #22 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54899&action=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) IMPORTANT STEP:
    Before you import, make sure that the authtypecode of the file you
    are going to import matches the Code of your new authority type. Use
    Vim or something similar to do a search and replace and change the
    codes in your file - do NOT use LibreOffice etc. because it tries to
    be too helpful and messes with the formatting of the file (this is what has
    broken the Import function in previous testing of this patch)
7) Import into your new authority type using the file you just exported
(make sure you've done Step 6)
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Go to Admin -> MARC bibliographic framework
12) Confirm that the 'Export' and 'Import' functions still work here as well

Note: If the Export does not work for the default auth type, do not
panic. The patch for bug 16035 should fix this.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:14:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:14:36 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-zK7CglfGoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54899|0                           |1
        is obsolete|                            |

--- Comment #23 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54900&action=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) IMPORTANT STEP:
    Before you import, make sure that the authtypecode of the file you
    are going to import matches the Code of your new authority type. Use
    Vim or something similar to do a search and replace and change the
    codes in your file - do NOT use LibreOffice etc. because it tries to
    be too helpful and messes with the formatting of the file (this is what has
    broken the Import function in previous testing of this patch)
7) Import into your new authority type using the file you just exported
(make sure you've done Step 6)
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:41:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:41:19 +0000
Subject: [Koha-bugs] [Bug 6847] Bulk userid, password generation and email
In-Reply-To: <bug-6847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6847-70-KBy0SdIPVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

--- Comment #2 from Bob Birchall <bob at calyx.net.au> ---
(In reply to Marc V?ron from comment #1)
> Is this bug still valid?

I think it is.  AutoEmailOpacUser will only work if you create a new patron
from scratch and finish the registering process in one session. If you use
patron data import no emails are sent out when the account is created.

Bug 9097 is similar but different.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:46:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:46:27 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9097-70-0iCRJxJPSZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

Irma Birchall <irma at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irma at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:47:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:47:24 +0000
Subject: [Koha-bugs] [Bug 6847] Bulk userid, password generation and email
In-Reply-To: <bug-6847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6847-70-O1XNJ35MMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847

Irma Birchall <irma at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irma at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:52:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:52:47 +0000
Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no
 records have been passed in
In-Reply-To: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16949-70-Mu07srUSCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 04:52:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 02:52:49 +0000
Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no
 records have been passed in
In-Reply-To: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16949-70-bB4MPxtVZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53870|0                           |1
        is obsolete|                            |

--- Comment #10 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54901&action=edit
Bug 16949: Batch record deletion says success when no records have been passed
in

The reason this happens is because the page will say success when the total
number of records given equals the total number of successful deletions. If you
pass in no records, there are no successful deletions --> 0 = 0 --> it thinks
it has been successful. This patch adds a check that validates if any
checkboxes were selected before submitting the final form.
I have removed the check for if any records were selected AFTER the form
has been submitted because it seemed unnecessary if the form can't be
submitted without selection of records anyway.

To test:
1) Go to Tools -> Batch record deletion
2) Put in a record number and click Continue
3) Deselect the record so that it doesn't actually delete and click Delete
selected records
4) Page says 'All records have been deleted successfully!'
5) Apply patch. Go back and repeat step 3
6) Form should not submit and you should receive an alert saying that no
records have been selected.
7) If you try selecting and deleting a record after this alert, it
should still work

Note: Have also changed the wording of error in Step 1 when you are
entering record numbers to delete.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 05:07:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 03:07:47 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-1xVUsEC6fL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vanoudt at gmail.com

--- Comment #10 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
*** Bug 17192 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 05:07:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 03:07:47 +0000
Subject: [Koha-bugs] [Bug 17192] Authority search paging doesn't work
In-Reply-To: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17192-70-KWmqIEHGzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17192

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
         Resolution|---                         |DUPLICATE
             Status|Needs Signoff               |RESOLVED

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
I think this is the same as Bug 17048. Will mark this as a duplicate

*** This bug has been marked as a duplicate of bug 17048 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 06:29:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 04:29:19 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-iAk9mooQtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

--- Comment #3 from Amanda <amanda.kelly at charteredaccountantsanz.com> ---
Owen and Nick, 

yes you are correct. This was a customisation - the creation of an "invalid
reserves queue". The fix was - Catalyst made the Invalid RQ just a report - the
queue had been assigning an item to fill a reserve, it now ignores that. And
fills it with whatever item is issued to the borrower.  That made the reserve
come off.

So I will close this bug. 

thanks for looking into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 06:30:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 04:30:18 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-zT6PeKSYGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Amanda <amanda.kelly at charteredaccountantsanz.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 07:28:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 05:28:46 +0000
Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links
 so referred revenue lost
In-Reply-To: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4460-70-ZUeEEVohVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not persuaded that the ref is really an important part - and if you are
paid by it it would be interesting to know what our hardcoded value means.

No mention of the ref parameter:
https://affiliate-program.amazon.com/help/operating/linking
https://affiliate-program.amazon.com/help/topic/t64/a1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 07:42:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 05:42:26 +0000
Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the
	intranet
In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15544-70-2TAmEuqkGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 07:45:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 05:45:08 +0000
Subject: [Koha-bugs] [Bug 17192] Authority search paging doesn't work
In-Reply-To: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17192-70-tT7HzvIDLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17192

--- Comment #3 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Didn't see that bug. Yep - sounds exactly like a duplicate! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:32:34 +0000
Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized
In-Reply-To: <bug-14939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14939-70-sVcSpF8EDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939

--- Comment #53 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Jonathan Druart from comment #52)

> Should not we remove marcxml (as it's unused)?

Maybe. Could you take a look at bug 15108? It improves greatly SQL queries
generated by Koha OAI Server, and so performances. You could QA it :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:04 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-TzKOO063ki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:08 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-m3E9DeK1xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54606|0                           |1
        is obsolete|                            |
  Attachment #54607|0                           |1
        is obsolete|                            |
  Attachment #54608|0                           |1
        is obsolete|                            |
  Attachment #54609|0                           |1
        is obsolete|                            |
  Attachment #54610|0                           |1
        is obsolete|                            |

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54902&action=edit
Bug 14060: Remove readonly attributes on date inputs

In order to remove accessibility issues due to the readonly attributes
on date inputs, this patch will remove them and introduce a javascript
validation on them.

This patch is not perfect for some reason:
I didn't manage to force the user to select a valid date. One solution
would be to reopen the datepicker plugin until a valid date is inserted.
But it could be annoying for users (and for me: I did not manage to
implement this solution).
You will note that input is emptied if the date is not valid. This is a
quick and efficient solution to prevent submitting invalid date and make
Koha explodes. A proper solution would be to implement the check server
side send a friendly message to the user.

Test plan:
For all inputs, try an invalid and a valid date.
 1/ Debar a patron
 2/ On the checkout tables (circulation and moremember), add a renewal
due date (at the bottom of the tables)
 3/ On the checkout page, specify a due date
 4/ On the return page, specify a return date
 5/ On the invoice page (acquisition module), enter a shipment and
billing date
 6/ On the invoice search page (invoices.pl) use filters shipment and
billing dates
 7/ On the offline circ page, specify a due date
 8/ On the edit patron page (memberentry), add a debarment
 9/ On the reserve page (reserve/request.pl), use the date inputs to
suspend until a defined date
10/ Edit patrons in a batch (tools/modborrowers.pl) and use the
registration and expiry date inputs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:12 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-oxmy2235o3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54903&action=edit
Bug 14060: Add OnClose event on missing datepicker

The "suspend until" inputs (hold list on circ/circulation.pl and
members/moremember.pl) were not set in the same way.
The minDate option should be set for both (bug 10703 removed it for
circ/circulation.pl).
This patch reintroduces the option and add the OnClose event on both.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:19 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-dBdtB34AzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54905&action=edit
Bug 14060: Force the input to contain a valid date

Before this patch, the user was still allowed to enter a valid date.
Now, if the date is not valid, the input is emptied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:16 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-bQz3P4nvvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54904&action=edit
Bug 14060: Display the date format on the warning popup

The date format is now displayed on the warning popup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:24 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-WWbxMADkjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54906&action=edit
Bug 14060: Add support for dmydot

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 09:45:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 07:45:30 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-vOi7JaPFph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54907&action=edit
Bug 14060: Display date format pattern instead of date format name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 10:24:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 08:24:14 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-jfajvo95pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17193


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193
[Bug 17193] C4::Search::SearchAcquisitions is not used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 10:24:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 08:24:14 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-T6H1V9Xmzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 10:47:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 08:47:04 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-6gmC7sLa6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #91 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54908&action=edit
Bug 15758: [QA Follow-up] Remove onlymine from Plugin/Branches.pm

Hard to miss that one:
Template process failed: plugin error - Bareword "C4::Branch::onlymine" not
allowed while "strict subs" in use at Koha/Template/Plugin/Branches.pm line 59.
Compilation failed in require at /usr/lib/perl5/Template/Plugins.pm line 206.

Removed OnlyMine from Plugin/Branches. Replaced by a template var in
cleanborrowers; it was used only once.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 10:47:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 08:47:09 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-t6ffn03pBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #92 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54909&action=edit
Bug 15758: [QA Follow-up] Some corrections related to GetBranchName

[1] Acquisition.pm
The lines filling $row in GetBasketGroupAsCSV may have side-effects when
the library name is not found. This change restores former behavior. Just
theoretically more safe.
Note that it also contained a typo: $row->{deliveryplace} should have been
$row->{$place}.

[2] Auth.pm
checkauth: $branchname = Koha::Libraries->find($branchcode)->branchname;
Should normally be fine, but I rather have an empty string here than
crashing on "Can't call method branchname on undefined value".
Same for sub check_api_auth.
Note that this holds for a larger number of calls, but I am adding a check
here because it is checkauth.
Also removed a duplicate use Koha::Libraries-statement.

[3] Search.pm
Also removed a duplicate use statement for Libraries.

[4] svc/holds
Added an (explicit) use statement for Koha::Libraries.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 10:47:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 08:47:35 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-8wCAO3PiDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #93 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
No not ready yet (by far..)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:22:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:22:41 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-6k7orC7CvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #12 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Bug 14390 moved forward, now thanks to it if there is a clear distinction
between F and FU fines in a given production database, it will stay that way in
the future - for such databases problem is effectively solved.

But if F / FU distinction initially is not entirely clear - if there are some
non-accruing FU fines still left in the DB - Bug 14390 is only half the
solution, IMO such fine records may still get overwritten even with Bug 14390
applied.

This is not all that awfully clear - but after thinking for a while about it,
I'm pretty sure that some DB clean up (at least closing the non-accruing FU
fines left behind by Bug 15675) is still required for fixing an issue described
by this report. Consider the following scenario (starting in some pre-Bug 15675
setup, e.g. in 3.22.x)

1) Item gets overdued, 'FU' fine record gets created, fine starts accruing
2) Patron renews this item, fine record created in step 1) stops accruing
(because date due in fine description doesn't match with due date in issue
record any more), fine type is still 'FU'
3) Upgrade: ... Bug 15675 gets applied ... Bug 14390 gets applied
4) Fine record from 1) is still FU and it's now linked to the issue record by
issue_id
5) This item gets overdued again: instead of creating a new one, UpdateFine()
will pick the same old fine record for updating (it's FU and it's linked to the
existing issue), amount from the previous overdue gets overwritten.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:32:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:32:55 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-UwjIPSFxug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #13 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Proposed solution for the issues still remaining (moved from Bug 14390):

1) select the FU fine records that may need correction: for that we may need to
compare a due date from issue record and the date on the end of the fine
description - if the dates are the same, this is a correct FU record, no need
to change anything in it

2) if the dates are different, there are two possibilities:

3.a) if the fine is not accruing / item is not currently due: it's an old fine
record (either left unclosed by Bug 15675 or maybe patron renewed this item
after Bug 15675 was applied in the production database; maybe it got
overwritten in the meantime or maybe not, there is no easy way to tell): it
needs to be closed (FU -> F)

3.b) if the fine is accruing (item is due / CalcFine() returns a positive
value): this is an old record which got overwritten: leave it as FU, but
correct a due date in fine description.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:10 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-fbRgNQXmVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:13 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-wzFFnQQH2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54910&action=edit
Bug 17196: Move marcxml out of the biblioitems table

Two discussions on koha-devel lead to the same conclusion:
biblioitems.marcxml should be moved out this table
- biblio and biblioitems
http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html
- biblioitems.marcxml & biblioitems.marc / HUGE performance issue !
http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html

There are several goals to do it:
- Performance
As Paul Poulain wrote, a simple query like
  SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY
publicationyear;
takes more than 10min on a DB with more than 1M bibliographic records
but only 3sec (!) on the same DB without the biblioitems.marcxml field
Note that priori to this patch set, the biblioitems.marcxml was not
retrieved systematically, but was, at least, in
C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders
- Flexibility
Storing the marcxml in a specific table would allow use to store several
kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats
(marcflavour)
- Clean code
It would be a first step toward Koha::MetadataRecord for bibliographic
records (not done in this patch set).

Test plan:
- Update the DBIC Schema
- Add / Edit / Delete / Import / Export bibliographic records
- Add items
- Reindex records using ES
- Confirm that the following scripts still work:
    * misc/cronjobs/delete_records_via_leader.pl
    * misc/migration_tools/build_oai_sets.pl
- Look at the reading history at the OPAC (opac-readingrecord.pl)
- At the OPAC, click on a tag, you must see the result

Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:16 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-H8kcg8ZziX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54911&action=edit
Bug 17196: Fix query builder for item search

The item search needs to join on biblio_metadata to allow search on
marcxml field

Test plan:
Launch complex item searches (using marc fields).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:22 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-YdvOJjFvbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54912&action=edit
Bug 17196: Update misc/maintenance/sanitize_records.pl

Test plan:
Use the sanitize_records.pl maintenance script with the --auto-search
option

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:25 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-Of1gtDpmom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54913&action=edit
Bug 17196: Update switch_marc21_series_info.pl

Not sure if this script is still used, could someone confirm?

Test plan:
If you know how to test it, please do

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:33:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:33:36 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-dajiwwjdeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54914&action=edit
Bug 17196: DB Changes

Remove biblioitems.marcxml and deletedbiblioitems.marcxml
and adds 2 table biblio_metadata and deletedbiblio_metadata

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:48:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:48:10 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-5EkXk12AxL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #14 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
This part

> 3.b) if the fine is accruing (item is due / CalcFine() returns a positive
> value): this is an old record which got overwritten: leave it as FU, but
> correct a due date in fine description.

is optional, not that much important - arguably it may be even better to leave
such records as is. If due date in description gets corrected, there wouldn't
be a way to tell that this fine got overwritten in the past. Usefulness of such
information (if it got overwritten or not) IMO is rather limited in most
practical circumstances, but still this may be considered as a data loss by
some users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:51:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:51:40 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-AvNCXCnAcp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:51:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:51:43 +0000
Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto
 renewal will not work because hold has been placed
In-Reply-To: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14434-70-Nm8vMMlbbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54877|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54915&action=edit
Bug 14434: Display "Not renewable (on hold)" in OPAC

This patch makes the OPAC display "Not renewable (on hold)" when
a hold is placed.

Test plan:
1) Do not apply patch.
2) Issue an item with automatic renewal.
3) Issue an item with manual renewal.
4) Place a hold on both items.
5) Log in as patron and note that the column "Renew" says "Automatic
   renewal (x of y renewals remaining)" for the auto renewed item
   and "(On hold) for the other item.
6) Apply patch.
7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed
   for both items.
8) Cancel the holds, then log in as patron again and confirm that the
   correct renewal conditions are displayed.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:56:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:56:50 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-A7e0qEYvLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:56:54 +0000
Subject: [Koha-bugs] [Bug 17174] Making z39.50 authority search actions
	buttons
In-Reply-To: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17174-70-QIUO50jSVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17174

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54878|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54916&action=edit
Bug 17174: Making z39.50 Authority search actions buttons

Have changed the wording of the MARC button to Show MARC to be
consistent with other places in Koha.

To test:

1) Go to Authorities -> New from Z39.50
2) Put in any search terms and click Search
3) Confirm that both options (MARC and Import) now show as buttons "Show
MARC" and "Import" under one "Actions" column with approriate icons
4) Confirm buttons work as expected
5) Confirm buttons do not wrap on narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 11:59:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 09:59:22 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-Lvs3hBvi4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #94 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Impressive work, Jonathan.

Some findings so far for first two patches. Looks like I will not finish this
one today.

=== Patch 1
C4/Labels/Label.pm
L100 require Koha::Libraries;
Remember you failed patches before for that? :)
L101 # FIXME Is this used??
Not sure. But can you use those fields when you define a label in the editor or
something?
One of the templates contains the string in text and implicitly seems to
suggest that.
t/db_dependent/Reserves.t still fails (cause somewhere else)

=== Patch 2
Auth.pm: use for Branches removed; but still called. (Will be resolved, yes)
TODO in C4/Search.pm L337
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt: Exceptional
[% l.branchname || 'UNKNOWN' %] Inconsistent?
t/db_dependent/Holds/RevertWaitingStatus.t
DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected
operator 'cancellationdate' with undef operand at
/usr/share/koha/masterclone/Koha/Objects.pm line 168
Probably something similar as in Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:02:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:02:15 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15711-70-mLlGWtqhLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha, I get the exact same behavior with and without the patch:
I get the first "Please select images to delete.", then "Are you sure you want
to delete image(s): undefined?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:05:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:05:28 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-3u6kyNXofI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:05:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:05:32 +0000
Subject: [Koha-bugs] [Bug 17187] Lower the timeout preference from 139 days
	to 1 day
In-Reply-To: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17187-70-qZbmGiYKp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17187

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54882|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54917&action=edit
Bug 17187: Lower the timeout preference from 139 days to 1 day

Default timeout is now 12000000 seconds == almost 139 days !
Surely, your session will be shorter. But we should lower this
value.
Balancing usability and security, I propose 1d (1 day) now.
Current pref value will be affected only if it is NULL or equal
to the old default.

Test plan:
Check your current value. Optionally change to NULL or 12000000.
Run the dbrev and see what happens.
Beware of cached values while testing or flush the cache.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:06:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:06:51 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-mivAuEfCdM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54914|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54918&action=edit
Bug 17196: DB Changes

Remove biblioitems.marcxml and deletedbiblioitems.marcxml
and adds 2 table biblio_metadata and deletedbiblio_metadata

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:16:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:16:16 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-t7zHvEK2vq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #94)
> === Patch 1
> C4/Labels/Label.pm
> L100 require Koha::Libraries;
> Remember you failed patches before for that? :)

Yes :)
But I have replaced an existing require with another one, not added a new one.

> L101 # FIXME Is this used??
> Not sure. But can you use those fields when you define a label in the editor
> or something?
> One of the templates contains the string in text and implicitly seems to
> suggest that.
> t/db_dependent/Reserves.t still fails (cause somewhere else)

Yes, see bug 16942.

> === Patch 2
> Auth.pm: use for Branches removed; but still called. (Will be resolved, yes)
> TODO in C4/Search.pm L337

Yes it's a TODO, for later.

> koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt:
> Exceptional [% l.branchname || 'UNKNOWN' %] Inconsistent?

No, the UNKNOWN comes from the pl. Now it's translatable.

> t/db_dependent/Holds/RevertWaitingStatus.t
> DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected
> operator 'cancellationdate' with undef operand at
> /usr/share/koha/masterclone/Koha/Objects.pm line 168
> Probably something similar as in Reserves.t

Same as before, see bug 16942.


Thanks for QAing, really much appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:24:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:24:48 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-FKGHnplqkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #15 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #13)

This part

> 3.a) if the fine is not accruing / item is not currently due:

giving me a big headache. Would be a simple sql statement like 

    issues.due_date > NOW()

good enough for selecting old FU fines which need to be closed (+ the unmatched
due date in fine description), or do we need some more elaborate way for
determining that? And we can't just close all old FU fines with unmatched
dates, not taking into account their current status (due / not due, accruing /
not accruing). Any opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:35:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:35:32 +0000
Subject: [Koha-bugs] [Bug 17201] New: Remaining calls to
	C4::Context->marcfromkohafield
Message-ID: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

            Bug ID: 17201
           Summary: Remaining calls to C4::Context->marcfromkohafield
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 16341 moved caching for marc subfield structure to Koha:::Cache and removed
the global variable C4::Context->marcfromkohafield. 

Two scripts with calls for this variable remain in the code:

t/db_dependent/Search.t

and

Koha/MetadataRecord.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:35:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:35:47 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-SB3AvON1PL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201
[Bug 17201] Remaining calls to C4::Context->marcfromkohafield
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:35:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:35:47 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-So1v1GV99T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16431


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431
[Bug 16431] Marc subfield structure should be cached using Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:38:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:38:35 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-yJtywHGNMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:38:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:38:38 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-IYIqoqqfjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54883|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 54919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54919&action=edit
Bug 17200 - Badly formatted "hold for" patron name on catalog detail page

This patch adds a space between first name and surname on the
bibliographic detail page when there is "hold for" information in the
status column of the holdings table.

To test, apply the patch locate a title in the staff client catalog
which has one or more confirmed holds on it. Verify that the patron's
name in the "status" column of the holdings table looks correct, with a
space between first and last name.

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:41:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:41:32 +0000
Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
In-Reply-To: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16694-70-3rjoq838EM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54920&action=edit
Bug 16694 - Limit SIP2 auth by patron attribute

The main use case of this bug is to use patron attributes to grant special
privileges, e.g. to open a door to an unmanned library.

This patch adds an extra check against patron attributes if login account
in SIPconfig.xml has a key validate_patron_attribute set to some patron
attribute.

If a patron information request is sent (63), and patron has proper rights in
the
given attribute: (a value of 1/true or some authorised value mapping to 1)
The user will be allowed access (in SIP: charge and/or renewal ok).
Otherwise denied.

Please note that this is specific to the SIP login account, so self checkout
machines can be handled differently than e.g. a door card terminal.

To test:
0) you need to debug using telnet or the koha provided sip_client
1) add validate_patron_attribute="testattribute" to some login account in
SIPconfig.xml
2) add a patron attribute "testattribute"
3) edit some patron and set "testattribute" to "1"
4) do a sip login with the given login account from SIPconfig.xml
5) do a patron information request (63) on the patron
6) observe that no charge or renewal denied is given in the response (64  )
7) try all or any of the following:
 - set patron attribute to anything but "1"
 - delete the patron attribute
 - map the patron attribute to an authorized list, e.g. (YES_NO) and
   set it to a value that doesn't map to "1", e.g. "No".
8) do a patron information request (63) again
9) observe that charge and renewal is now denied in the SIP response (64YY)
10) thank yourself if noone else does and grab a coffee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:42:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:42:13 +0000
Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
In-Reply-To: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16694-70-y1PUqLJiiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 12:48:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 10:48:39 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-EGWi0B6PVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 13:40:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 11:40:33 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-NNl4RvdYHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 13:40:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 11:40:46 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-z2KCfu3uwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 13:48:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 11:48:05 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-6qPJdeaEKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #16 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #15)
> Would be a simple sql statement like 
> 
>     issues.due_date > NOW()
> 
> good enough for selecting old FU fines which need to be closed (+ the

I guess not good enough after all: item may be due but the fine not accruing
yet: if overdue is in the grace period, or eg. in the middle of the 1st charge
period, (when charge period > 1 day). With just 'issues.due_date > NOW()' there
is a possibility that some unclosed old FU fines may still get left behind.

I don't see any way to fix this without involving CalcFine() and a good part of
Getoverdues(), but in that case it's starting to look more like some kind of
external script instead of simple DB update. Or at least I don't see that kinds
of things in updatedatabase.pl - what are the community guidelines in such
case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 13:55:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 11:55:15 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-PZU5j96AAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Reopening because this issue still exists:

> 1. Find a title with multiple holds.
> 2. Check an available item out to any patron who
>    is not at the top of the hold priority list.
> 3. The hold for that patron is not removed -- it's
>    still on hold for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 13:55:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 11:55:21 +0000
Subject: [Koha-bugs] [Bug 14549] Hold not removed when item is checked out
 to patron who is not next in priority list
In-Reply-To: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14549-70-AKuFKiJGHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:02:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:02:53 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-Su6QRRbcXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #96 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 54921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54921&action=edit
Bug 15758: [QA Follow-up] Corrections related to GetBranches

[1] C4/Search
A call to Koha::Libraries is added to routine pazGetRecords, but the
results of that call are not used. So removing it again.

[2] catalogue/itemsearch.pl
Although A=>B=>C=>D works, we'd better use here A=>B, C=>D.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:04:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:04:40 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-sTKFd2HLT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #97 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some more tiny comments from the last big patch:

You say that this (horrible??) category key within the branches hash is not
used anymore due to bug 15295 ? I think so too. More evidence to present?

FIXME in transferbook is fine with me. Just leave it. This PE stuff should
perhaps be removed, but not on this report.

circ/branchtransfers.pl
+        $item{'tobrname'}              = $tobranchcd;
and
+    $item{'tobrname'}              = $tobcd;
With a corresponding: <td class="tf-destination">[% Branches.GetName(
trsfitemloo.tobrname ) %]</td>
Do not really look good.. Name versus code?
L194 Do we still need this warn BTW ?

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+                        <p class="problem">Please return item to: [%
Branches.GetName( errmsgloo.msg ) %]</p>
Hmm.

I will finish it later next week. I guess that splitting up this patch set in
two parts would have been better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:33:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:33:37 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-p84UuxAuSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:33:40 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-xu1O37gwzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54922&action=edit
Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield

I am not sure this code is called so I don't know how to test it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:37:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:37:33 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-mkSuWA2Ftq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54923&action=edit
Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:39:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:39:02 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-GnrqdLKJOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Second patch will fix the Search.t tests and make Jenkins happy!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:48:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:48:15 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-QkgliVQKdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:48:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:48:18 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-24f4eu2xHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54761|0                           |1
        is obsolete|                            |

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54924&action=edit
Bug 11019 - Require some fields when adding authorized value category

This patch modifies the form for adding an authorized value so that
category, authorized value, and description are required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in category, authorized value,
  or description. You should be prevented from submitting the form.
- Verify that filling in the required fields allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Follow-up for QA: Allow a blank authorised value to be created.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 14:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 12:57:27 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-Ir2pmYUhG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Tests work! Huzzah!

For MetadataRecord.pm:
1 - you need to use or specify namespace for GetMarcSubfieldStructure
2 - my ($tag, $subfield) = @$tagfield; doesn't work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:08:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:08:10 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on data in items table.
In-Reply-To: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14504-70-WYIglcSak6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #69 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Barton!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:08:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:08:30 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-iCeXD4B1ax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #97)
> Some more tiny comments from the last big patch:
> 
> You say that this (horrible??) category key within the branches hash is not
> used anymore due to bug 15295 ? I think so too. More evidence to present?

Everywhere it was used, Koha::LibraryCategory is now used

> FIXME in transferbook is fine with me. Just leave it. This PE stuff should
> perhaps be removed, but not on this report.

Definitely not :)

> circ/branchtransfers.pl
> +        $item{'tobrname'}              = $tobranchcd;
> and
> +    $item{'tobrname'}              = $tobcd;
> With a corresponding: <td class="tf-destination">[% Branches.GetName(
> trsfitemloo.tobrname ) %]</td>
> Do not really look good.. Name versus code?

Yes the var name is wrong. Patch is coming.

> L194 Do we still need this warn BTW ?

No idea. In doubt, let's keep it.

> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
> +                        <p class="problem">Please return item to: [%
> Branches.GetName( errmsgloo.msg ) %]</p>
> Hmm.

Ugly but correct.

> I will finish it later next week. I guess that splitting up this patch set
> in two parts would have been better.

Yes it's what I did for C4::Members. But here for libraries it looked easier to
get 1 big test than having to test everything for each patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:08:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:08:53 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ore5NlBaFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54925&action=edit
Bug 15758: Fix variable name, it's a branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:10:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:10:59 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-ORwgIUilhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.11, thanks Lari!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:11:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:11:11 +0000
Subject: [Koha-bugs] [Bug 17202] New: Deleting a rotating collection with
 items should either be prohibited or items should be removed
Message-ID: <bug-17202-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202

            Bug ID: 17202
           Summary: Deleting a rotating collection with items should
                    either be prohibited or items should be removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
Create a rotating collection
Add an item
Delete the rotating collection
View the db (SELECT * FROM collections_tracking;)
The item is still in the collection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:11:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:11:39 +0000
Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items
 should either be prohibited or items should be removed
In-Reply-To: <bug-17202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17202-70-0hLAoUmkOs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:27:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:27:03 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-IOVq7FJt8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17201
         Depends on|17201                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201
[Bug 17201] Remaining calls to C4::Context->marcfromkohafield
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:27:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:27:03 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-wfDmbpIcGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16431
             Blocks|16431                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431
[Bug 16431] Marc subfield structure should be cached using Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:30:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:30:15 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-yRpYV9epYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:30:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:30:18 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-cLvszVg4pB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54922|0                           |1
        is obsolete|                            |
  Attachment #54923|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54926&action=edit
Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield

I am not sure this code is called so I don't know how to test it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:30:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:30:22 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-BQRBtryz9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54927&action=edit
Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:35:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:35:23 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-ZC2d4p7y9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:35:26 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-EU1oUeIQa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54919|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54928&action=edit
Bug 17200 - Badly formatted "hold for" patron name on catalog detail page

This patch adds a space between first name and surname on the
bibliographic detail page when there is "hold for" information in the
status column of the holdings table.

To test, apply the patch locate a title in the staff client catalog
which has one or more confirmed holds on it. Verify that the patron's
name in the "status" column of the holdings table looks correct, with a
space between first and last name.

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:35:45 +0000
Subject: [Koha-bugs] [Bug 17200] Badly formatted "hold for" patron name on
 catalog detail page
In-Reply-To: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17200-70-M0j8Bimweu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16871
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Introduced by bug 16871.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871
[Bug 16871] Translatability: Avoid [%%-problem and fix related sentence
splitting in catalogue/detail.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:35:45 +0000
Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix
 related sentence splitting in catalogue/detail.tt
In-Reply-To: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16871-70-T239wnSWKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200
[Bug 17200] Badly formatted "hold for" patron name on catalog detail page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:36:58 +0000
Subject: [Koha-bugs] [Bug 17203] New: Searching by year does not work
Message-ID: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

            Bug ID: 17203
           Summary: Searching by year does not work
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When searching by year in OPAC or Intranet no results are shown. All data is
saved in copyright field in biblioitems table.

Tested in 16.05.02

See file attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:38:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:38:26 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-EzNHL0wTM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

--- Comment #1 from Claudio <costalc at gmail.com> ---
Created attachment 54929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54929&action=edit
Search by date error explanation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:39:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:39:27 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-VEOxhqPSpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:39:29 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-k2yXZBINgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54926|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54930&action=edit
Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield

I am not sure this code is called so I don't know how to test it.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:40:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:40:00 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-09hxUFlNY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54927|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54931&action=edit
Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:42:54 +0000
Subject: [Koha-bugs] [Bug 17204] New: Rancor Z39.50 search fails under plack
Message-ID: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204

            Bug ID: 17204
           Summary: Rancor Z39.50 search fails under plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Enable plack
Open advanced cataloging editor
Perform a Z39.50 search
Internal Search Error
Disable plack
Perform a Z39.50 Search
Successful results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:43:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:43:27 +0000
Subject: [Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
In-Reply-To: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17204-70-jvz6GZ2o98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Depends on|                            |17201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201
[Bug 17201] Remaining calls to C4::Context->marcfromkohafield
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:43:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:43:27 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-3ej4MyRFjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17204


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204
[Bug 17204] Rancor Z39.50 search fails under plack
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:43:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:43:54 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-CbNgP2fOO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
To test:
Disable plack (bug 17204)
Open advanced cataloging editor
Perform a Z39.50 search
Internal Search Error
Apply patch
Reload
Perform a Z39.50 search
Success

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:45:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:45:26 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-oeDucw0DC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:45:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:45:28 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-MudznV7bsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54725|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54932&action=edit
Bug 17147 [Revised] Streamline messages following batch record modification

This patch changes the display of informational messages during and
after the batch record modification process. Instead of showing a
separate dialog for each record modified, messages are now grouped into
one dialog.

To test, apply the patch and clear your browser cache if necessary. You
must have at least one MARC modification template defined.

- Go to Tools -> Batch record modification.
- Submit a list of biblionumbers which contains at least one number
  which doesn't exist in your database.
- Confirm that warning and success messages are grouped instead of
  showing in separate dialogs.
- Submit a list of biblionumbers using a MARC modification template
  which contains no actions. Confirm that the resulting error message is
  correctly formatted.

Revision formats the error messages without the unordered list, which
was giving them padding which didn't look correct inside a dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:55:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:55:17 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-VvF2XFSZl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:55:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:55:20 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-ngZH1gXQiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54737|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54933&action=edit
[SIGNED-OFF] Bug 16752 [Revised] Remove the use of event attributes from some
acquisitions templates - Uncertain prices

This patch modifies the acquisitions uncertain prices template to remove
event attributes onclick and onchange.

Also changed on the uncertain prices page: Added a label to the orders
filter, removed redundant form submit function.

- Locate a vendor which has orders with uncertain prices
- Click the 'Uncertain prices' tab in the left-hand sidebar
- Enter invalid data in the "price" field for any order. Confirm that an
  error is triggered when the field loses focus.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

QA Revision: Corrected input type of submit button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 15:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 13:56:54 +0000
Subject: [Koha-bugs] [Bug 16788] Update Control file for 3.22.x
In-Reply-To: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16788-70-au34YQvHUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16788

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 54934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54934&action=edit
3.22.10 debian control fixes for debian package

This is what went into the 3.22.10 package, should go in 3.22.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:01:06 +0000
Subject: [Koha-bugs] [Bug 16788] Update Control file for 3.22.x
In-Reply-To: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16788-70-3mRJCabtck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16788

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
This is what actually went in 3.22.10 package. Not really anything to test, but
I don't want to add it manually each time. :)

Setting straight to Passed QA.

One could install Koha 3.22.10 from the Koha repository and observe it does not
explode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:01:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:01:29 +0000
Subject: [Koha-bugs] [Bug 16788] Update Control file for 3.22.x
In-Reply-To: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16788-70-cuULGgQoVQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16788

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52672|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:07:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:07:28 +0000
Subject: [Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning,
 and contracts
In-Reply-To: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16754-70-tLbrlFcVbb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #7)

> We could imagine a budget for only 1
> day, which was allowed before, but not anymore.

That seems very unlikely. It wouldn't be difficult to add a new validation
setting to allow the two dates to match, but I'm not sure it's worth it just
for this form and without an indication that it's an important feature. I think
this form should match others in Koha where the end date in a date span is
required to be after the start.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:08:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:08:02 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-cpzmpIbccx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:08:05 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-5Q8kjmhAai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54738|0                           |1
        is obsolete|                            |
  Attachment #54739|0                           |1
        is obsolete|                            |
  Attachment #54933|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54935&action=edit
Bug 16752 - Remove the use of event attributes from some acquisitions templates
- Funds

This patch modifies the funds administration page and other files
related to the process of searching for and selecting fund owners and
users in order to remove the use of event attributes like 'onclick.'

Also changed in this patch: I have revised the way the "select owner"
and "select user" controls look. They are now links with Font Awesome
icons.

- Go to Administration -> Funds and open a fund for editing.
- Test the process of adding and updating an owner:
  - Click the 'Select owner' link.
  - Search for and select an owner in the pop-up window.
  - Save the fund and verify that the owner was saved correctly.
  - Perform the same test with the 'Remove owner' link.
- Use the same process to test the addition and removal of users.
  - Confirm that the 'Remove' link works correctly before and after
    submitting the form to save changes to the fund.

This patch changes a file which is used by both the funds template and
the template used when setting a guarantor on a patron. To test the
changes in that context:

- Open a 'child' type patron record.
- Under 'Guarantor information,' test the process of setting and
  removing a guarantor to confirm that data is saved correctly.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:08:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:08:09 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-K6rN6IaChS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54936&action=edit
Bug 16752 - Remove the use of event attributes from some acquisitions templates
- Transfer order

This patch removes the use of 'onclick' from the acquisitions transfer
order process. The patch also modifies the style of some links and
buttons to conform with current guidelines.

- Locate an open basket with items in it
- Click the 'Transfer' link for a title in the basket
- In the pop-up window:
  - Confirm that the 'Cancel' button at the bottom of the window is a
    Bootstrap-style button.
  - Search for a vendor; Confirm that the 'Choose' link is a
    Bootstrap-style button.
  - Choose a vendor; Confirm that the 'Choose' link on the following
    page is a Bootstrap-style button.
  - Confirm that clicking the 'Choose' button transfers the item to the
    correct basket.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 16:08:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 14:08:15 +0000
Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from
 some acquisitions templates
In-Reply-To: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16752-70-kWba5TMjgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54937&action=edit
Bug 16752 [Revised] Remove the use of event attributes from some acquisitions
templates - Uncertain prices

This patch modifies the acquisitions uncertain prices template to remove
event attributes onclick and onchange.

Also changed on the uncertain prices page: Added a label to the orders
filter, removed redundant form submit function.

- Locate a vendor which has orders with uncertain prices
- Click the 'Uncertain prices' tab in the left-hand sidebar
- Enter invalid data in the "price" field for any order. Confirm that an
  error is triggered when the field loses focus.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

QA Revision: Corrected input type of submit button.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 17:15:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 15:15:10 +0000
Subject: [Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
In-Reply-To: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17204-70-qGUd2UZ0bQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 17:15:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 15:15:12 +0000
Subject: [Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
In-Reply-To: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17204-70-vH6uvN1i9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54938&action=edit
Bug 17204  - Rancor Z39.50 search fails under plack

MetaSearcher.pm forks children to handle searching each server. When the
process waits for the children it never continues.

The simplest solution here is to exclude the metasearcher service from
running under plack

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 17:24:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 15:24:43 +0000
Subject: [Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
In-Reply-To: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17204-70-nXDnl5rgCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 19:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 17:19:53 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-MyLRe0pkAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
It's good to see this project funded.  Is any work currently being done on
this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 19:57:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 17:57:26 +0000
Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue
 conflict with each other
In-Reply-To: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14514-70-eN5F73QH2s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #19 from Joel Sasse <jsasse at plumcreeklibrary.net> ---
Liz,

Would you please respond to Kyle's questions in the previous comment? I am
anxious to test this patch, sign off on, and get it into Koha as soon as
possible.

Thanks,
Joel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 20:11:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 18:11:44 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-ilJGKY69CN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 20:11:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 18:11:46 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-sfI9LhkqpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54880|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 54939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54939&action=edit
[SIGNED-OFF] Bug 10300 - Allow transferring of items to be have separate
IndependentBranches syspref

Some libraries want to have IndependentBranches enabled, but still be
able to transfer items between themselves.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable IndpendentBranches and IndependentBranchesTransfers
4) Log in as a super librarian
5) Note you can transfer items
6) Log in as a non-super librarian
7) Note you cannot transfer items
8) Disable IndependentBranchesTransfers
9) Note you can now transfer items

Signed-off-by: Maribeth Shafer <mshafer at ckls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 21:26:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 19:26:29 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-4SYgRWyhZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 21:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 19:26:31 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-YGOqsrtm81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54940&action=edit
Bug 15388 - Show Syndetics covers by UPC in search results

Syndetics code accepts UPC and OCLC numbers, however, we were only passing this
if there
was an ISBN. This patch alters the code to search if either an ISBN or
UPC is present

To test:
Enable syndetics (will need an account)
Search for items with UPCs or OCLC numbers and no ISBN (DVDs)
Note there are no images in search results but there are in details
Apply patch
Note that items with images in details now also have images in results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 21:28:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 19:28:44 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-1aX9D983s4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |nick at bywatersolutions.com
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 23:02:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 21:02:15 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16933-70-yjdTgdE750@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

tmcmahon at wlpl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmcmahon at wlpl.org

--- Comment #1 from tmcmahon at wlpl.org ---
Created attachment 54941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54941&action=edit
Patch to fix Alt+y for selecting Yes to prompts

This patch changes the keyboard shortcut for renew from Alt+y to Alt+w.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 23:03:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 21:03:32 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16933-70-ScGfgZiTzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

tmcmahon at wlpl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54941|Patch to fix Alt+y for      |Patch to fix Alt+y for
        description|selecting Yes to prompts    |selecting Yes at dialogs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Aug 26 23:06:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 21:06:04 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16933-70-c5X3M123AU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

tmcmahon at wlpl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

--- Comment #2 from tmcmahon at wlpl.org ---
I didn't know why Alt+y was used for renew, so I changed it to Alt+w so it
doesn't conflict with Alt+y to answer yes in dialogs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:43:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:43:02 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-vCFT1fDNKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53216|0                           |1
        is obsolete|                            |
  Attachment #53820|0                           |1
        is obsolete|                            |

--- Comment #19 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942&action=edit
Bug 16330: REST API: add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Revised Test plan:
1) Apply this patch (on top of dependent bug 14868)
2) Run minifySwagger to create swagger.min.json and restart Plack
3) Run tests perl t/db_dependent/api/v1/patrons.t
4) Add a user with proper rights to use the REST API
5) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

On top of 15126
Tested using postman, first try with the api
GET, POST, PUT and DELETE works, i.e. list, add, update, search and delete.
Small errors fixed in followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:44:09 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-PtOwV9hfcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:44:09 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-W7efuYpFG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|15126                       |16699, 14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
[Bug 15126] REST?API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:44:09 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-jFABid2r4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16330                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:44:09 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-xKvjK8xXtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 00:47:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 22:47:47 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-ue2Lg7b7zC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #20 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Rebased against 16699 (now in master) and 14868 (Swagger permission checking).

Also merged in followup patch fixing spelling and tests, and now using
Koha::Patrons->columns to test params against, as it was introduced in Bug
16889.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 01:31:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 23:31:36 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-lEkeEdXn76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53819|0                           |1
        is obsolete|                            |

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54943&action=edit
Bug 16497 - REST API: add routes to list libraries

Simple routes to list all or get one Library
GET /api/v1/libraries              - List all libraries
GET /api/v1/libraries/{branchcode} - Get one Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Lari Taskula <larit at student.uef.fi>
Signed-off-by: Ji?? Kozlovsk? <mail at jkozlovsky.cz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 01:32:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 26 Aug 2016 23:32:27 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-eZqTyMTEQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #8 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Rebased against 16699

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 08:08:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 06:08:06 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-cphJgLhuXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
For background information, see:
http://blog.l2c2.co.in/index.php/2016/08/26/koha-spine-label-is-not-printing-the-in-your-call-numbers-here-is-why/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 16:55:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 14:55:28 +0000
Subject: [Koha-bugs] [Bug 17205] New: Error message while upgrading to
	16.05.03
Message-ID: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

            Bug ID: 17205
           Summary: Error message while upgrading to 16.05.03
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: gmcharlt at gmail.com
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Upgrading from 16.05.02 to 16.05.03 shows an error. See file attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 16:56:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 14:56:38 +0000
Subject: [Koha-bugs] [Bug 17205] Error message while upgrading to 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-lEscHchLoB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

--- Comment #1 from Claudio <costalc at gmail.com> ---
Created attachment 54944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54944&action=edit
Error image

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 19:26:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 17:26:13 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-X3k4MyErWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Claudio, Koha is using 008 for this - so the copyrightdate column should not
matter in this case. Are you using MARC21 or UNIMARC? Can you find out about
the Zebra version you are using?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 19:29:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 17:29:23 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-Svs0hauOZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |koha-bugs at lists.koha-commun
                   |                            |ity.org
           Severity|enhancement                 |normal
            Summary|Error message while         |Error in ES-es po files for
                   |upgrading to 16.05.03       |16.05.03
                 CC|                            |bgkriegel at gmail.com,
                   |                            |frederic at tamil.fr
          Component|Installation and upgrade    |I18N/L10N
                   |(command-line installer)    |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Claudio, the update worked, but the translation files for es-ES have some
translation error in them, so the Spanish templates weren't translated
correctly. Try to look for the po file and the problematic string - something
about the %s is wrong there. When you fix this and reinstall it should be ok.
Would also be good to fix on translate.koha-community.org to avoid problems for
other users.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 19:33:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 17:33:09 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-IPFZtp8t1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aliki, could you try again with another sandbox? Make sure you try with a
selected test database, to avoid the web installer if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 19:37:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 17:37:39 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-1F886Ox0U9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

--- Comment #3 from Claudio <costalc at gmail.com> ---
Yes, the update works fine! If it is a translation warning message I stay
quiet... I will tray to update the spanish translation according your
suggestion.

Many thanks Katrin!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 20:02:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 18:02:32 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-MyeE9yq2l7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

--- Comment #3 from Claudio <costalc at gmail.com> ---
008? Nobody is cataloguing 008 in this corner of the world... my God...

Using MARC21.

Zebra version: 4.2.30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 20:15:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 18:15:25 +0000
Subject: [Koha-bugs] [Bug 12374] Feature request: add koha-mqsqldump script,
 analagous to koha-mysql
In-Reply-To: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12374-70-VKRmqbfl0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 54945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54945&action=edit
Bug 12374: Add koha-mqsqldump script, analagous to koha-mysql

Includes documentation, koha-common.install entry, and bash completion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 20:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 18:22:58 +0000
Subject: [Koha-bugs] [Bug 12374] Feature request: add koha-mqsqldump script,
 analagous to koha-mysql
In-Reply-To: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12374-70-sGrKfrF45t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374

--- Comment #3 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Magnus Enger from comment #1)
> We already have the koha-dump script, which creates two files, one mysqldump
> and one .tar.gz file containing some config and log files, in the
> /var/spool/koha/<instancename> dir. Perhaps it could be an option to extend
> this script with a couple more options, to make it possible to:
> 
> - not dump the configs and logs
> - place the mysqldump in a given dir

I feel that this tool fills a different need -- mysqldump has a *lot* of
command line options not available in koha-dump -- chiefly, the ability to dump
only a certain table, or perhaps only certain records in a given table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 20:44:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 18:44:09 +0000
Subject: [Koha-bugs] [Bug 12374] Feature request: add koha-mqsqldump script,
 analagous to koha-mysql
In-Reply-To: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12374-70-NZaOZ0NfGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Barton Chittenden <barton at bywatersolutions.com> ---
Test plan:

1/ Run mysqldump by hand, redirect output to 'file1.sql'
   egrep '^..(user|database|pass|host)' $KOHA_CONF

   which will yield something like this:

    <database>koha_xyzzy</database>
    <hostname>localhost</hostname>
    <user>koha_xyzzy</user>
    <pass>setecAstronomy</pass>

   mysqldump -p -u koha_xyzzy -h localhost koha_xyzzy > file1.sql
   Enter password:

2/ Apply patch
3/ Run koha-mysqldump against the instance, redirect output to 'file2.sql'
   ./debian/scripts/koha-mysqldump xyzzy > file2.sql
4/ The files should be identical, except for time stamps contained in the file:

   diff file1.sql file2.sql
   5965c5965
   < -- Dump completed on 2016-08-27 11:33:42
   ---
   > -- Dump completed on 2016-08-27 11:35:48

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 20:46:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 18:46:35 +0000
Subject: [Koha-bugs] [Bug 12374] Feature request: add koha-mqsqldump script,
 analagous to koha-mysql
In-Reply-To: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12374-70-8w30TStZrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |barton at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 22:02:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 20:02:16 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-EjU2djXmk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, I fixed that problem a couple of days ago, but late for the release, sorry.
It will be OK for the next release.
Problem is on '%intentando', visible on first translated line of your screen
capture, needs to be '%sintentando'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 22:47:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 20:47:56 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-fCX2F1sIHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

--- Comment #5 from Claudio <costalc at gmail.com> ---
Thanks Bernardo!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Aug 27 22:49:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 20:49:58 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-vJVLxEZ5RR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

--- Comment #4 from Claudio <costalc at gmail.com> ---
Thank you very much Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:02:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:02:09 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-F4sWiFxe6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have tried to verify: yr = pubdate = Date-of-publication
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/ccl.properties;h=3ec13637548817990250d9c6e8ae8f42ab843278;hb=53631f9ffdc86c1afbcc3108ac3ddf1f73fef40e

And only pubdate appears in the inded definition - and there only for 008. Try
to catalog the first date in 008 to see if the search starts to work for you.
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml;h=38f91a2103e98e4736ef2a919a89dc27aa7fa06c;hb=53631f9ffdc86c1afbcc3108ac3ddf1f73fef40e

260/264 are indexed in other indexes (one being copydate), but yr is the one
used for the date range search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:06:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:06:31 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-y6TTSLYpM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Resolving fixed - can only fix for the next release, which Bernardo already did
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:25:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:25:06 +0000
Subject: [Koha-bugs] [Bug 17203] Searching by year does not work
In-Reply-To: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17203-70-mux3Lxw51q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17203

--- Comment #6 from Claudio <costalc at gmail.com> ---
Katrin, cataloguing first date in 008 the search works fine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:26:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:26:40 +0000
Subject: [Koha-bugs] [Bug 17205] Error in ES-es po files for 16.05.03
In-Reply-To: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17205-70-5tcp8E4g1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17205

--- Comment #7 from Claudio <costalc at gmail.com> ---
Thanks again and again and again Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:58:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:58:52 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-lInxO4TRhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at ptfs-europe.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Patch tested with a sandbox, by Lisette Scheer <lisetteslatah at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:59:06 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-cKFYi3ITDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53543|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 00:59:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 27 Aug 2016 22:59:13 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-60Bg6dXHYi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

--- Comment #10 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 54946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54946&action=edit
Bug 16874: Making serials collections actions buttons

To test:
1) Go to serials -> Search a subscription (or make a new one)
2) Ensure that subscription has an end-date that has passed or will pass soon
3) Go to Serials collection (left sidebar menu)
4) Ensure that Subscription summary table has two buttons, Create routing list
and Renew. These buttons should be bolded and the table cell highlighted
5) Ensure 'Print list' is a button in year tables below
6) Edit subscription to have a later end-date (will not expire soon)
7) Go back to serials collection
8) Ensure that table cell is no longer highlighted and buttons not bolded.
Renew button should not be there.
9) Ensure that both buttons do not wrap when the browser is narrow

Sponsored-by: Catalyst IT
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 03:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 01:03:18 +0000
Subject: [Koha-bugs] [Bug 16070] Empty (undef) system preferences may cause
 some issues in combination with memcache
In-Reply-To: <bug-16070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16070-70-7GNyA2coTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16070

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Added to Koha 16.05.00 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 03:59:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 01:59:46 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-4e6EH7v2Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 10:31:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 08:31:59 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-UWPm0dW6lH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

--- Comment #14 from Fr?d?ric Demians <frederic at tamil.fr> ---
See this:

https://lists.katipo.co.nz/pipermail/koha/2016-August/046113.html

The bug described here exists in 16.05, but its solution depends on a CSRF
related patch which hasn't yet been ported on 16.05 due to dependencies (this
has to be discussed).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 10:36:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 08:36:17 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-wECZ4UrNHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

--- Comment #15 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 54947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54947&action=edit
[16.05] Bug 16996 Fix a bug introduced in 16.05

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 10:44:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 08:44:34 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
 Can't call method " description"
In-Reply-To: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16996-70-S1XUb60qJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #16 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Fr?d?ric Demians from comment #14)

> The bug described here exists in 16.05, but its solution depends on a CSRF
> related patch which hasn't yet been ported on 16.05 due to dependencies
> (this has to be discussed).

Something beyond these?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16591#c18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:13:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:13:51 +0000
Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in.
In-Reply-To: <bug-13033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13033-70-GArpOVoWmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Barton and Nick, 
was WaitingNotifyAtCheckin turned on?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:17:52 +0000
Subject: [Koha-bugs] [Bug 13066] search the catalog tab not selected on
 results in staff client
In-Reply-To: <bug-13066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13066-70-jsSflZRkdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13066

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WORKSFORME

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can't recreate the problem either - closing WORKSFORME.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:18:57 +0000
Subject: [Koha-bugs] [Bug 16736] Keep library filter when changing suggestion
In-Reply-To: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16736-70-E1CHpf5j2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keep branch filter when     |Keep library filter when
                   |changing suggestion         |changing suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:19:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:19:18 +0000
Subject: [Koha-bugs] [Bug 8147] suggestions management forgets branch info
In-Reply-To: <bug-8147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8147-70-rLaonMgSJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16736 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:19:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:19:18 +0000
Subject: [Koha-bugs] [Bug 16736] Keep library filter when changing suggestion
In-Reply-To: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16736-70-9k1RApuXJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 8147 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:22:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:22:33 +0000
Subject: [Koha-bugs] [Bug 9825] Fixed fields not limited in length after
 upgrade from 3.6.x
In-Reply-To: <bug-9825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9825-70-e4LBWWqh7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9825

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is it safe to mark this WONTFIX?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:25:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:25:52 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to " OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-n1xvzqThPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi George, feel free to submit a patch doing this! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:32:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:32:43 +0000
Subject: [Koha-bugs] [Bug 7384] keyword to marc mapping in emails
In-Reply-To: <bug-7384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7384-70-OUPV2K52Kk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can you explain this a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:34:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:34:26 +0000
Subject: [Koha-bugs] [Bug 9537] Add a list of the patches that have been
 applied to a koha installation
In-Reply-To: <bug-9537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9537-70-V6v6rnYyUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9537

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure how this could work outside of a git installation - I think you'd
have to keep all the information about the patches in Koha somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:35:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:35:23 +0000
Subject: [Koha-bugs] [Bug 5353] Old basket and basketgroups
In-Reply-To: <bug-5353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5353-70-a4bKhmzpPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Any update on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:36:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:36:04 +0000
Subject: [Koha-bugs] [Bug 7115] Suggestion form has wrong label if
 AdvancedSearchTypes = collection
In-Reply-To: <bug-7115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7115-70-77onJrJVz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7115

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The suggestion form is now using SUGGEST_FORMAT.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:49:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:49:01 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-vt8GbzI5BQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:49:05 +0000
Subject: [Koha-bugs] [Bug 11019] Require some fields when adding authorized
 value category
In-Reply-To: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-RujhKy3LGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54924|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54948&action=edit
[PASSED QA] Bug 11019 - Require some fields when adding authorized value
category

This patch modifies the form for adding an authorized value so that
the category is a required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in the category.
  You should be prevented from submitting the form.
- Verify that filling in the required field allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Follow-up for QA: Allow a blank authorised value to be created.

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>
Amended test plan.



Current patch-complexity: Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:53:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:53:22 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-kAz1loWcgS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 14:53:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 12:53:25 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-d7DkrlVTfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54720|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54949&action=edit
[PASSED QA] Bug 13921 - XSLT Literary Formats Not Showing

This patch adds some missing literary formats to the staff client and
OPAC's search results XSLT display.

To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system
preferences enabled.  XSLTResultsDisplay and OPACXSLTResultsDisplay
should be set to 'default.'

Perform searches in the staff client and the OPAC and confirm that the
following literary forms (defined in 008 position 33) display correctly:
Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.;
Letters; Short stories; Mixed forms; Poetry; Speeches.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 15:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 13:08:05 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-J4DUZSSPJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 15:08:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 13:08:08 +0000
Subject: [Koha-bugs] [Bug 16990] Show branch name instead of branch code
 when managing patron modification requests
In-Reply-To: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16990-70-qSYUEDXBXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54721|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54950&action=edit
[PASSED QA] Bug 16990: Display branch names instead of code in patron mod
requests

To test:
- change your homebranch in the OPAC, submit
- change patron modification request in the staff client
- Verify that it shows the old and new branch name instead of the
  code

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:21 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-KSpjFafDYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53890|0                           |1
        is obsolete|                            |
  Attachment #53891|0                           |1
        is obsolete|                            |
  Attachment #53924|0                           |1
        is obsolete|                            |
  Attachment #54685|0                           |1
        is obsolete|                            |

--- Comment #41 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54951&action=edit
Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bugs 16699 and 14868

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Lari Taskula <larit at student.uef.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:46 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-6KKsUhdrr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|15126, 16086                |16699, 14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
[Bug 15126] REST?API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086
[Bug 16086] Add Koha::Issue objects.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
[Bug 16699] Swagger: Split parameters and paths, and specify required
permissions for resource
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:46 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-jNFPYws2Ar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13895


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:46 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-AmGIXOPQKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13895                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:46 +0000
Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects.
In-Reply-To: <bug-16086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16086-70-7gyeZU9int@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13895                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:39:46 +0000
Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths,
 and specify required permissions for resource
In-Reply-To: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16699-70-1n4Y9ouGaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13895


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 18:44:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 16:44:04 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-d0mQo7niTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #42 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Since Bug 16699 now already is in master, I took the liberty of rebasing this
patch against master atop on 14868 which was discussed above.

Since rebasing each patch is too much work, I merged all the previous patches
in.

No functionality is changed, and tests are updated to match new permissions
from Bug 14868, so I leave it as Signed off, but more testing should probably
be done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:02:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:02:14 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-eKPIIB1eSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:02:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:02:18 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-g9C7xagJTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54713|0                           |1
        is obsolete|                            |
  Attachment #54714|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54952&action=edit
[PASSED QA] Bug 17157: Fix middle click on "Search" drowndown menu

If you save an item and right click on "Search" or "More" you will get
a software error:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

You will now be redirected to the adv search form.

Wors as described.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:02:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:02:24 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-3PL5EnAUm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Jiri Kozlovsky <mail at jkozlovsky.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54068|0                           |1
        is obsolete|                            |
  Attachment #54711|0                           |1
        is obsolete|                            |

--- Comment #14 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
Created attachment 54953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54953&action=edit
Bug 17004: Add API route to authenticate patron (CGISESSID) including logout

POST /auth/session (login)
DELETE /auth/session (logout)

Required POST data:
- "password"
- either "userid" or "cardnumber".

To test:
1. Make sure you are logged out from Koha.
2. Make a POST request to http://yourlibrary/api/v1/auth/session with form data
   "userid" => <your_user_id> and "password" => <your_password>.
3. If your userid and password is correct, you should be returned with most
   basic patron data and your CGISESSID.
4. Also attempt with invalid login to get an error.
5. Send a DELETE request to /auth/session
6. Observe that you are no longer logged-in in Koha.
7. Run tests at b/t/db_dependent/api/v1/auth.t

You may find this cURL useful:
curl -X DELETE http://lib/api/v1/auth/session --cookie
'CGISESSID=88e735aaf7c6cf194a775425cbd00570'
(replace CGISESSID=... with your CGISESSID)

----

I've rebased both attachments to master (restructuralized swagger
definitions).

And added proposed permissions as proposed by Benjamin Rokseth.

Btw, very nice work Lari!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:02:58 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error.
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-KB4bfRYkrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54954&action=edit
[PASSED QA] Bug 17157: Same for "More"

Here I decided to redirect to the mainpage.

Works as dexcribed.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:03:18 +0000
Subject: [Koha-bugs] [Bug 17157] Middle click on dropdown menu in header may
 cause software error
In-Reply-To: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17157-70-rAAHQ272IG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Middle click on dropdown    |Middle click on dropdown
                   |menu in header may cause    |menu in header may cause
                   |software error.             |software error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:13:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:13:50 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-x5smrf6Gfs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:13:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:13:53 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
 not working properly
In-Reply-To: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17048-70-ac9eNNX4Yj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54788|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54955&action=edit
[PASSED QA] Bug 17048: Fix pagination offset for authority searches

At the intranet, the pagination has been broken by bug 12478 (Elastic
Search). There was a confusion between the offset and the page number.

At the OPAC, it is broken since bug 2735 which has mimicked the intranet
script.

Test plan:
Search for a term which will return more than 1 page of results.
Click on the second page
=> Without this patch, the first result of the second page is the second
result of the first page
=> With this patch applied, the offset will be corrected

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:20:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:20:26 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-JEsCJiXGJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:20:29 +0000
Subject: [Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when
 trying to clear a linked authority
In-Reply-To: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17118-70-vsOn2ZxrKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54671|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54956&action=edit
[PASSED QA] Bug 17118: (follow-up 15381) Fix regression when clearing a linked
authority

Changes made on bug 15381 assumed that the authid was always set.
But if the user wants to clear the field of the authority, the script is
called with authid=0 (FIXME...)

To fix this issue, it's better to move the new calls to
  Koha::Authorities->find($authid)->authtypecode
and
  Koha::Authority::Types->find($authtypecode);
at the correct place

Test plan:
1. Edit a record which has a field linked to an
   authority record (100a for instance).
2. Click the link which triggers the tag editor.
   A pop-up window should be displayed.
3. In the pop-up window, click the "Clear field"
   button.
=> Without this patch A second pop-up window opens and displays an error:
  Can't call method "authtypecode" on an undefined value at
/authorities/blinddetail-biblio-search.pl line 61.
=> With this patch applied the field is correctly cleared.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:32:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:32:26 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-NdjsBChY46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54953|0                           |1
        is obsolete|                            |

--- Comment #15 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 54957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54957&action=edit
Bug 17004: Add API route to authenticate patron (CGISESSID) including logout

POST /auth/session (login)
DELETE /auth/session (logout)

Required POST data:
- "password"
- either "userid" or "cardnumber".

To test:
1. Make sure you are logged out from Koha.
2. Make a POST request to http://yourlibrary/api/v1/auth/session with form data
   "userid" => <your_user_id> and "password" => <your_password>.
3. If your userid and password is correct, you should be returned with most
   basic patron data and your CGISESSID.
4. Also attempt with invalid login to get an error.
5. Send a DELETE request to /auth/session
6. Observe that you are no longer logged-in in Koha.
7. Run tests at b/t/db_dependent/api/v1/auth.t

You may find this cURL useful:
curl -X DELETE http://lib/api/v1/auth/session --cookie
'CGISESSID=88e735aaf7c6cf194a775425cbd00570'
(replace CGISESSID=... with your CGISESSID)

----

I've rebased both attachments to master (restructuralized swagger
definitions).

And added proposed permissions as proposed by Benjamin Rokseth.

Btw, very nice work Lari!

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:34:38 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-WzZvWHmh1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:34:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:34:41 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-86itCLjoDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54930|0                           |1
        is obsolete|                            |
  Attachment #54931|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54958&action=edit
[PASSED QA] Bug 17201: (bug 16431 follow-up) Remove occurrence of
marcfromkohafield

I am not sure this code is called so I don't know how to test it.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:35:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:35:14 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-oom0a8MEvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54959&action=edit
[PASSED QA] Bug 17201: (bug 16431 follow-up2) Remove occurrence of
marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:35:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:35:54 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-kyJy1eHncf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:37:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:37:08 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-q2NEewgO2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #16 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Shit man, you beat me with five minutes! Was just rebasing the same patch ;)

Great work, Lari and Jiri! Everything works as expected.

Just a sidenote: perhaps we should .gitignore swagger.min.json, or we will face
a whole lot of merge issues? I propose this in a new bug. Part of the testing
should be to minify anyways, as it will spot issues in references.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:39:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:39:57 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-jWOCK5XcI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:40:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:40:00 +0000
Subject: [Koha-bugs] [Bug 17183] Koha News 'delete selected' function doesn'
 t check if anything has been selected
In-Reply-To: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17183-70-mSp7KaOWWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17183

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54811|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54960&action=edit
[PASSED QA] Bug 17183: Check if any checkboxes have been checked for 'Delete
Selected' button in Koha News

To test:
1) Go to Tools -> Koha News
2) Click 'Delete selected' button without selecting anything
3) Notice you are asked to confirm if you would like to delete ... but
you didn't choose anything to delete
4) Apply patch and refresh page
5) Click 'Delete selected' button without selecting anything
6) Should see alert.
7) Select one or more news items to delete and click 'Delete selected'
button
8) Should be asked to confirm
9) Confirm that the delete works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 21:42:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 19:42:31 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 ( Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-l6kTVTIHSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #17 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Benjamin Rokseth from comment #16)
> Shit man, you beat me with five minutes! Was just rebasing the same patch ;)
> 
> Great work, Lari and Jiri! Everything works as expected.
> 
> Just a sidenote: perhaps we should .gitignore swagger.min.json, or we will
> face a whole lot of merge issues? I propose this in a new bug. Part of the
> testing should be to minify anyways, as it will spot issues in references.

Well then, sorry about that :D I didn't know you're working on it .. maybe an
IRC channel would solve such interference?

I agree with ignoring all possible minified files in Koha in general. Are there
currently any other minified files? I can't think of any right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 22:07:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 20:07:54 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-GFlY4yCJpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 22:07:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 20:07:57 +0000
Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons
In-Reply-To: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16874-70-KGoEz36zAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54946|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54961&action=edit
[PASSED QA] Bug 16874: Making serials collections actions buttons

To test:
1) Go to serials -> Search a subscription (or make a new one)
2) Ensure that subscription has an end-date that has passed or will pass soon
3) Go to Serials collection (left sidebar menu)
4) Ensure that Subscription summary table has two buttons, Create routing list
and Renew. These buttons should be bolded and the table cell highlighted
5) Ensure 'Print list' is a button in year tables below
6) Edit subscription to have a later end-date (will not expire soon)
7) Go back to serials collection
8) Ensure that table cell is no longer highlighted and buttons not bolded.
Renew button should not be there.
9) Ensure that both buttons do not wrap when the browser is narrow

Sponsored-by: Catalyst IT
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 23:30:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 21:30:59 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-FfL70U26C8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #91 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Matthias,
in testing things looked great, but now the tests are failing for me, hoping
it's easy to fix:
perl t/db_dependent/Serials_2.t:
Can't call method "lastvalue1" on an undefined value at
/home/katrin/kohaclone/C4/Serials.pm line 1575.
# Looks like your test exited with 2 just after 46.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 23:51:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 21:51:14 +0000
Subject: [Koha-bugs] [Bug 17206] New: Can't switch to default framework
Message-ID: <bug-17206-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17206

            Bug ID: 17206
           Summary: Can't switch to default framework
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

To test:
- Create a record using the Fast add framework
- Save the record
- Open the record for editing
- Use the "Settings" pull down to change the framework to default
- Note: page reloads, but framework doesn't change
- Try another framework - it works
- Try changing to default from there
- Notice it switches back to FA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Aug 28 23:51:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 21:51:22 +0000
Subject: [Koha-bugs] [Bug 17206] Can't switch to default framework
In-Reply-To: <bug-17206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17206-70-hpnaDDHthv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17206

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 00:12:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 22:12:56 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn' t work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-Zn5KJPXLTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works in my tests, but is missing unit tests. 
Would it be possible to add a unit test covering the new behaviour here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 00:29:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 22:29:32 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-2bfUSCf1ph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 00:29:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 22:29:35 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-sabOK7fB0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54853|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 54962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54962&action=edit
[PASSED QA] Bug 17193: Remove C4::Search::SearchAcquisitions

This subroutine is not used and can be removed

Test plan:
  git grep SearchAcquisitions
should not return any results.

Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 00:45:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 22:45:38 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14435-70-ZnkFkWE05L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I got no problem with this not being perfect for the time being, but could we
add one little thing? 

I am missing an option to delete the saved results - either from the GUI or
maybe when the runreport.pl is run an option to clean the last x saved
results... I am a little worried that this table will fill up quickly with no
way to get rid of stored results.

Please read "failed qa" as asking for feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 01:12:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 23:12:44 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-DkkmJCp6r4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, 

starting with a first code review here:

1) There seem to be a few lines doubled up in AddIssue now:

        $item->{'issues'}++;
        if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) {
            UpdateTotalIssues($item->{'biblionumber'}, 1);
        }

            $item->{'issues'}++;
            if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) {
                UpdateTotalIssues( $item->{'biblionumber'}, 1 );
            }

2) This line is a change of behaviour: Before the change was dependent on the
system preference - now it will always happen?
-    CartToShelf( $itemnumber ) if (
C4::Context->preference("ReturnToShelvingCart") );
+    CartToShelf( $itemnumber ) if ( $item->{'location'} eq 'CART' &&
$item->{'permanent_location'} ne 'CART' );

3) ReturnToShelvingCart is removed from the code, but the system preference is
not deleted in the database update.

4) koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js contains strings -
those can not be translated (js files can't be in general)

5) Tests are failing for me (run within koha-shell in kohadevbox):
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/Circulation/issue.t 
Global symbol "$item" requires explicit package name at
/home/vagrant/kohaclone/C4/Items.pm line 635.
Global symbol "$item" requires explicit package name at
/home/vagrant/kohaclone/C4/Items.pm line 635.

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 01:16:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 23:16:13 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-eMEhL7icAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |dependency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 01:19:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 28 Aug 2016 23:19:47 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-PY9dCsEv2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Adding Mirko as this adds a new dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 02:05:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 00:05:55 +0000
Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal
 before' ( days or hours)
In-Reply-To: <bug-14395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14395-70-42R1jZsSHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

--- Comment #51 from Claudio <costalc at gmail.com> ---
*** Bug 15666 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 02:05:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 00:05:55 +0000
Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when
 OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"
In-Reply-To: <bug-15666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15666-70-PSIwhkqvqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

Claudio <costalc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #20 from Claudio <costalc at gmail.com> ---


*** This bug has been marked as a duplicate of bug 14395 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 02:41:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 00:41:16 +0000
Subject: [Koha-bugs] [Bug 17207] New: Cannot access the website from China
Message-ID: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17207

            Bug ID: 17207
           Summary: Cannot access the website from China
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: thadickal.mapleleaf at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Recently, many schools in China, specifically in Shanghai and surrounding area
have not been able to access the Koha website. Can you please advise us how we
can restore our connection to your service. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 04:05:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 02:05:45 +0000
Subject: [Koha-bugs] [Bug 17207] Cannot access the website from China
In-Reply-To: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17207-70-mzjNObOxlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17207

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
             Status|NEW                         |In Discussion

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Do you mean the koha-community.org main website? And when you say "cannot
access" what kind of error messages are you getting?

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 04:29:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 02:29:20 +0000
Subject: [Koha-bugs] [Bug 17208] New: Classification sources and filing
 rules shouldn't allow
Message-ID: <bug-17208-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208

            Bug ID: 17208
           Summary: Classification sources and filing rules shouldn't
                    allow
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 04:29:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 02:29:35 +0000
Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules
 shouldn't allow 'New' with same code
In-Reply-To: <bug-17208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17208-70-4EULBV6hSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Classification sources and  |Classification sources and
                   |filing rules shouldn't      |filing rules shouldn't
                   |allow                       |allow 'New' with same code

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 04:31:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 02:31:47 +0000
Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules
 shouldn't allow 'New' with same code
In-Reply-To: <bug-17208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17208-70-jkVUmXSWS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Hit enter too early. At the moment, you can attempt to create sources and
filing rules using codes that already exist, and you receive a message saying
that the new source or filing rule was created, however it isn't actually added
to the database (as the codes must be unique), so it doesn't work. 
There should be some kind of check upon submission of the form that checks if
the code already exists (like the check of a barcode before creating a new
item).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 05:34:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 03:34:47 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-JV8x7m25v3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 05:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 03:34:50 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-SiYW8YUfXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54932|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54963&action=edit
[SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record
modification

This patch changes the display of informational messages during and
after the batch record modification process. Instead of showing a
separate dialog for each record modified, messages are now grouped into
one dialog.

To test, apply the patch and clear your browser cache if necessary. You
must have at least one MARC modification template defined.

- Go to Tools -> Batch record modification.
- Submit a list of biblionumbers which contains at least one number
  which doesn't exist in your database.
- Confirm that warning and success messages are grouped instead of
  showing in separate dialogs.
- Submit a list of biblionumbers using a MARC modification template
  which contains no actions. Confirm that the resulting error message is
  correctly formatted.

Revision formats the error messages without the unordered list, which
was giving them padding which didn't look correct inside a dialog.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 05:37:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 03:37:29 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-WrM9eFiSJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 05:37:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 03:37:32 +0000
Subject: [Koha-bugs] [Bug 17154] Note column is missing on account lines
	receipt
In-Reply-To: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17154-70-kaQmu4dOjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17154

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54673|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54964&action=edit
[SIGNED-OFF] Bug 17154 : Note column is missing on account lines receipt

When displaying Fines > Account tab for a patron, you can see on screen a Note
column that is missing if you click on Print

    Test plan :
    * Find a patron with accountlines or add them manually (Create manual
invoice/credit).
    * Be sure some of them got a Note
    * Clik on Print fior those lines

    Without patch, the printed receipt does not show the Note column
    with the patch, the printed receipt shows a Note column and Note content is
correctly printed for accountline with a note.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:09:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:09:43 +0000
Subject: [Koha-bugs] [Bug 17195] Split logging of item modifications from
 CataloguingLog into separate system preferences
In-Reply-To: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17195-70-uSLk8eUlkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Hi Kyle,

Everything was working well until Step 9. I am still seeing the record edit
action log with CataloguingLog turned off. Everything else works as expected
though

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:31:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:31:22 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
 list incorrectly in admin/ edi scripts
In-Reply-To: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16514-70-EUbvHdtZLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:31:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:31:24 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
 list incorrectly in admin/ edi scripts
In-Reply-To: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16514-70-lT6oxwpS31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51475|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54965&action=edit
[SIGNED-OFF] Bug 16514: Force scalar context reading cgi variables

CGI's param method will default to returning in list context
if it cant determine context from the lvalue
This generates log warnings in newer versions of CGI that support
multi_param. Force scalar context in the places where param
can't ascertain its context correctly

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Patch works - no longer seeing warn "edi_accounts.pl: CGI::param called
in list context from package main line 105, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a
single named parameter" at /usr/share/perl5/CGI.pm line 436., referer:
http://localhost:8081/cgi-bin/koha/admin/edi_accounts.pl?op=delete_confirm&id=2"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:45:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:45:57 +0000
Subject: [Koha-bugs] [Bug 17209] New: Remove use of onclick from masthead
Message-ID: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

            Bug ID: 17209
           Summary: Remove use of onclick from masthead
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:46:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:46:04 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17209-70-FxCPmdO8ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:49:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:49:49 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17209-70-sKtSYGy9Pv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 06:49:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 04:49:52 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17209-70-GO1erNz206@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54966&action=edit
Bug 17209: Remove use of onclick from masthead

There are two instances which use onclick in the OPAC masthead: clearing
search history, and logging out.

To test:
Confirm that clearing search history using the 'x' in the masthead, and
logging out by clicking 'Log out' in the masthead, work the same before
and after the patch.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 07:55:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 05:55:51 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-cvv8wg6JMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If we don't do 3) - would the fines still be calculated correctly? I got lost a
bit at some point :) But if that's the case, maybe 3) is not worth the trouble
of correcting the date as long as we can manage to close all fines not
accrueing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 07:59:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 05:59:41 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-ebjyyVanI8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Does it warn on the cataloguing side too? I have had libraries deleting records
who are 'on order' by accident a few times - you will need SQL then to clean it
up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:05:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:05:01 +0000
Subject: [Koha-bugs] [Bug 17210] New: Remove us of onclick from biblio
 detail sidebar in OPAC
Message-ID: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

            Bug ID: 17210
           Summary: Remove us of onclick from biblio detail sidebar in
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:07:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:07:04 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-z9xjLS5eWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com
            Summary|Remove us of onclick from   |Remove use of onclick from
                   |biblio detail sidebar in    |biblio detail sidebar in
                   |OPAC                        |OPAC
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:09:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:09:56 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-EighFoh6rM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:09:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:09:59 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-gflAHf9vcj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54967&action=edit
Bug 17210: Remove use of onclick form biblio detail sidebar in OPAC

Four instances of onclick here:
1) Print
2) Save to your lists
3) Add to your cart
4) Remove from cart

To test:
Find a biblio detail page in OPAC and confirm all four events above work
as expected before and after the patch.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:11:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:11:14 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-b1WAgm3zuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54968&action=edit
Bug 17210: Remove use of onclick from biblio detail sidebar in OPAC

Four instances of onclick here:
1) Print
2) Save to your lists
3) Add to your cart
4) Remove from cart

To test:
Find a biblio detail page in OPAC and confirm all four events above work
as expected before and after the patch.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:11:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:11:25 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-8JDB96al57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54967|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:11:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:11:30 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-PflfS17KpL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> > We also need to resolve the question of taking opacuserlogin into account.
> Yes I think this should be discussed, for example, could it make sense for
> somebody to disable opacuserlogin but still wanting to have API access to
> own objects? Or simply control both of these under the same preference,
> opacuserlogin?

I can imagine both happening:
- libraries wanting to shut down any OPAC account functionality, but still be
able to renew in staff, so the circulation conditions are set up this way. In
this case, there should be a way to lock the API (opacuserlogin might be a way)
- libraries shutting down the OPAC, because they use something else like an
external discovery layer. In this case they'd still want to use the API, but
might turn off the OPAC as far as possible.

Should we just make a separate switch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:16:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:16:18 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-HjaB3Ydx7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can see it in both, master and 16_05 in the borrowers table now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:33:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:33:06 +0000
Subject: [Koha-bugs] [Bug 17211] New: Remove use of onclick from OPAC fines
	page
Message-ID: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

            Bug ID: 17211
           Summary: Remove use of onclick from OPAC fines page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:33:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:33:15 +0000
Subject: [Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page
In-Reply-To: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17211-70-5getZnyXYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:35:45 +0000
Subject: [Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page
In-Reply-To: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17211-70-eKlfMmvkjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:35:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:35:48 +0000
Subject: [Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page
In-Reply-To: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17211-70-NYI6K7LJId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54969&action=edit
Bug 17211: Remove use of onclick from OPAC fines page

To test:
1) Set the EnablePayPalOpacPayments syspref to Allow and the
PayPalSandboxMode to the appropriate mode
2) Go to OPAC fines
3) Confirm clicking the PayPal image link works the same before and
after the patch (opens pop up window)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 08:43:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 06:43:21 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-Q8LKA3VBhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #16)
> (In reply to Jacek Ablewicz from comment #15)
> > Would be a simple sql statement like 
> > 
> >     issues.due_date > NOW()
> > 
> > good enough for selecting old FU fines which need to be closed (+ the
> 
> I guess not good enough after all: item may be due but the fine not accruing
> yet: if overdue is in the grace period, or eg. in the middle of the 1st
> charge period, (when charge period > 1 day). With just 'issues.due_date >
> NOW()' there is a possibility that some unclosed old FU fines may still get
> left behind.
> 
> I don't see any way to fix this without involving CalcFine() and a good part
> of Getoverdues(), but in that case it's starting to look more like some kind
> of external script instead of simple DB update. Or at least I don't see that
> kinds of things in updatedatabase.pl - what are the community guidelines in
> such case?

Look at e.g. fix_accountlines_rmdupfines_bug8253.pl in misc/maintenance..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 09:14:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 07:14:03 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-dkGQYP0Pob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
What about:

Go thru all FU records.
Look up issue record.

If no issue record or CalcFine==0, consider as old fine. Move FU to F.
If CalcFine < accountlines.amount, new fine: move FU to F too. 
Otherwise: consider fine to be correct. Will be updated next run.

There will be some data loss. Left or right..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 09:50:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 07:50:04 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14435-70-LK9Fu7kLvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Katrin,
This patch restore a broken behavior, instead of removing it completely.
If the feature is used and some guys want to improve it, let's them do it :)
I do not plan to improve it by myself, especially because IMO it's out of the
scope of this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:04:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:04:07 +0000
Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have
 separate IndependentBranches syspref
In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10300-70-cZdg8KE1dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As bug 15758 is going to pass QA soon, it would be good to rebase this patch on
top of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:06:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:06:40 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-fuxyLrY7I0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

--- Comment #5 from Michael Kuhn <mik at adminkuhn.ch> ---
I'm sorry - yes, I can also see it in master and 16_05 in the borrowers table
now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:13:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:13:45 +0000
Subject: [Koha-bugs] [Bug 17147] Streamline messages following batch record
	modification
In-Reply-To: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17147-70-ojmJE5ELIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54963
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54963
[SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record
modification

Review of attachment 54963:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17147&attachment=54963)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/css/staff-global.css
@@ +1138,5 @@
>  	margin-top : .7em;
>  }
>  
> +div.message ul.fa-ul {
> +    padding-left: 1em;

We don't use fa-ul in this template, why do you change its padding-left?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:20:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:20:57 +0000
Subject: [Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database
	schema
In-Reply-To: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17067-70-Hz1M0llBQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Problem solved :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:21:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:21:27 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14435-70-MKzb1Z4j5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:29:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:29:20 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-oOWrG3UMld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Are you sure we want to raise such specific error like "library does not exist"
or "category does not exist"?
I'd go for an eval { $patron->store } and return a 500 if something went wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 10:57:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 08:57:22 +0000
Subject: [Koha-bugs] [Bug 17212] New: ITEMTYPECAT broken if there is another
 authorised value with same code
Message-ID: <bug-17212-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17212

            Bug ID: 17212
           Summary: ITEMTYPECAT broken if there is another authorised
                    value with same code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The grouping of itemtypes on the advanced search doesn't work correctly, if
there is another authorised value in another category with the same code.

To test:
- Add a collection TEST with a description
- Add a ITEMTYPECAT TEST with a different description
- Use TEST to group some itemtypes together
- Take a look at OPAC advanced search - notice itemtypes are grouped, but
description of the collection is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:11:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:11:27 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-N6qHGSJLiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16330&attachment=54942)
-----------------------------------------------------------------

::: Koha/REST/V1/Patron.pm
@@ +31,5 @@
> +    my $patrons;
> +    if (keys %$params) {
> +        my @valid_params = Koha::Patrons->columns;
> +        foreach my $key (keys %$params) {
> +            delete $params->{$key} unless grep { $key eq $_ } @valid_params;

Should not we raise an error instead of removing invalid params?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:13:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:13:09 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-nS8T1KhXV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16330&attachment=54942)
-----------------------------------------------------------------

::: Koha/REST/V1/Patron.pm
@@ +85,5 @@
> +        Koha::Patron->new($body)->store;
> +    };
> +
> +    unless ($patron) {
> +        return $c->$cb({error => "Something went wrong, check Koha logs for details"}, 500);

You surrounded the store with an eval, so nothing will be logged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:23:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:23:22 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
	checking
In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14868-70-Pw7YDBNe3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54895
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54895
Bug 14868: Give users possibility to request their own object

Review of attachment 54895:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14868&attachment=54895)
-----------------------------------------------------------------

::: Koha/REST/V1.pm
@@ +203,5 @@
> +
> +sub _object_ownership_by_borrowernumber {
> +    my ($c, $user, $borrowernumber) = @_;
> +
> +    return $user->borrowernumber == $borrowernumber;

I think it's not that easy. For instance at the OPAC, a patron is not allowed
to update his own details, it will need to be approved by a staff member.
Using the REST API he will be able to bypass the approval.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:28:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:28:10 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-pWU2vNevVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16330&attachment=54942)
-----------------------------------------------------------------

::: Koha/REST/V1/Patron.pm
@@ +172,5 @@
> +    } elsif ($res eq '-1') {
> +        return $c->$cb({}, 404);
> +    } else {
> +        return $c->$cb({}, 400);
> +    }

It may be better to surround the ->delete with an eval, returns 200 if == 1 or
log the error and return 500, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:29:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:29:06 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-XYbjSvcFFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #24)
> Comment on attachment 54942 [details] [review]
> Bug 16330: REST API: add routes to add, update and delete patrons
> 
> Review of attachment 54942 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/REST/V1/Patron.pm
> @@ +172,5 @@
> > +    } elsif ($res eq '-1') {
> > +        return $c->$cb({}, 404);
> > +    } else {
> > +        return $c->$cb({}, 400);
> > +    }
> 
> It may be better to surround the ->delete with an eval, returns 200 if == 1
> or log the error and return 500, don't you think?

Or 400 instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:31:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:31:00 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-lUwuA7vLbj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #26 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
(In reply to Jonathan Druart from comment #21)
> Are you sure we want to raise such specific error like "library does not
> exist" or "category does not exist"?
> I'd go for an eval { $patron->store } and return a 500 if something went
> wrong.


Well, yes and no. If missing category or branch is not part of error response,
it is no good. API user must not be expected to know about koha internal
dependencies, so a generic internal server response is not a good option.

That being said, the Patron object is probably the best place to handle
exceptions, e.g. Bug 16907. So if patron->store gives the needed feedback, it
is no point duplicating code/logic in api.

So yes, I agree, but am a bit unsure about alternatives?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:34:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:34:58 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-MY5SOGapuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #27 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
(In reply to Jonathan Druart from comment #22)
> Comment on attachment 54942 [details] [review]
> Bug 16330: REST API: add routes to add, update and delete patrons
> 
> Review of attachment 54942 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/REST/V1/Patron.pm
> @@ +31,5 @@
> > +    my $patrons;
> > +    if (keys %$params) {
> > +        my @valid_params = Koha::Patrons->columns;
> > +        foreach my $key (keys %$params) {
> > +            delete $params->{$key} unless grep { $key eq $_ } @valid_params;
> 
> Should not we raise an error instead of removing invalid params?

Absolutely right! Actually, it might be better to use formData and let swagger
definitions do the validation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:36:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:36:05 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-FMTCfp8lU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #28 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Jonathan Druart from comment #24)
> > Comment on attachment 54942 [details] [review] [review]
> > Bug 16330: REST API: add routes to add, update and delete patrons
> > 
> > Review of attachment 54942 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: Koha/REST/V1/Patron.pm
> > @@ +172,5 @@
> > > +    } elsif ($res eq '-1') {
> > > +        return $c->$cb({}, 404);
> > > +    } else {
> > > +        return $c->$cb({}, 400);
> > > +    }
> > 
> > It may be better to surround the ->delete with an eval, returns 200 if == 1
> > or log the error and return 500, don't you think?
> 
> Or 400 instead.

yes. Thanks for thorough feedback, btw!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:41:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:41:26 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-kJUajuRmjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
About tests: 1 subtest per route you test would be better for the readability.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 11:45:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 09:45:34 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-18mGMBTbKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Benjamin Rokseth from comment #26)
> (In reply to Jonathan Druart from comment #21)
> > Are you sure we want to raise such specific error like "library does not
> > exist" or "category does not exist"?
> > I'd go for an eval { $patron->store } and return a 500 if something went
> > wrong.
> 
> 
> Well, yes and no. If missing category or branch is not part of error
> response, it is no good. API user must not be expected to know about koha
> internal dependencies, so a generic internal server response is not a good
> option.
> 
> That being said, the Patron object is probably the best place to handle
> exceptions, e.g. Bug 16907. So if patron->store gives the needed feedback,
> it is no point duplicating code/logic in api.
> 
> So yes, I agree, but am a bit unsure about alternatives?

Actually if you call $patron->store and a FK is wrong/missing, DBIx::Class will
raise the relevant DBI error, something like:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_ut`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN
KEY (`categorycode`) REFERENCES `categories` (`categorycode`)).

That's why I think we should not handle it somewhere else.

Of course it would be better to get something more readable for the response :)
Did you mean we have to answer "This branchcode XYZ does not exist" or
something like "One of the parameter is wrong/missing" would be enough?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:32:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:32:22 +0000
Subject: [Koha-bugs] [Bug 17213] New: Self registration cardnumber is not
 editable if errors found when form submitted
Message-ID: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

            Bug ID: 17213
           Summary: Self registration cardnumber is not editable if errors
                    found when form submitted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:
Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' 
Register a new patron using an existing cardnumber
You get a 'card number is in use' error, but you can't edit the field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:32:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:32:39 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
 editable if errors found when form submitted
In-Reply-To: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17213-70-8Drl0ozm8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659
[Bug 14659] Allow patrons to enter card number and patron category on OPAC
registration page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:32:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:32:39 +0000
Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and
 patron category on OPAC registration page
In-Reply-To: <bug-14659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14659-70-LFNxexDNjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17213


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213
[Bug 17213] Self registration cardnumber is not editable if errors found when
form submitted
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:56:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:56:34 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
 editable if errors found when form submitted
In-Reply-To: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17213-70-H18HEqbR9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:56:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:56:36 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
 editable if errors found when form submitted
In-Reply-To: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17213-70-h8VwvuCoei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54970&action=edit
Bug 17213 -  Self registration cardnumber is not editable if errors found when
form submitted

To test:
Enable self registration
Make sure cardnumber is not in
'PatronSelfRegistrationBorrowerUnwantedField'
Enter an invalid or used cardnumber
Submit form
Note errors appears correctly but cardnumber is not editable
Apply Patch
Enter an invalid or used cardnumber
Submit form
Note errors appears correctly and cardnumber is editable

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:56:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:56:42 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
 editable if errors found when form submitted
In-Reply-To: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17213-70-IunQzVq4qF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 54971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54971&action=edit
Bug 17213 - Add HTML5 validation to cardnumber field on patron self
registration

To test:
Verify that different values in 'CardnumberLength' system preference
display correctly in the self reigstration form

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:58:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:58:55 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-XFFhEIUPTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 12:58:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 10:58:58 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-5F7E8jTDM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #20 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 54972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54972&action=edit
Bug 17135 - Fine for the previous overdue may get overwritten by the next one

External maintenace script for fixing unclosed (FU), non accruing fine
records which may still need FU -> F correction post-Bug 15675.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:05:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:05:18 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-5RyUTqbL3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Jacek, Just a quick glance:
Why Warn ? We always just warn.
Add a dbrev that at least prints a NOTE: <<ATTENTION...>> that tells the
sysadmin to optionally run your script when upgrading.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:08:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:08:34 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-FornBlEPRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Change title of this report ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:09:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:09:01 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-qK8ju3Tzvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:10:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:10:04 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-BLZbFrpXaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |major

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Severity to major ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:10:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:10:29 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-jizxwYO6j8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:46:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:46:47 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-rCdN9VkVQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #24 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #17)
> If we don't do 3) - would the fines still be calculated correctly?

You mean 3.b part (correcting the dates in description)? IMO after Bug 15675
this shouldn't affect further fines calculation (no matter if this date stays
as is or is optionally corrected). Post-Bug 15675, date in the description is
not used in UpdateFine() for anything important any more. It still gets
inserted to the description when new FU fine is created though, and because
it's not modified on the possible overwrite, it may by useful for two goals:

- pre-selecting the accountlines which may be non-accruing and still in a need
of closing,
- recovering the possibly overwritten fines (if any).

If someone is inclined to do so (I'm not - we are not using 16.05 in production
yet), automatic or semi-automatic recovery of the overwritten fines is quite
possible IMO, with some extra time and effort (a lot of it, probably). If
FinesLog is enabled: in ~100% of cases (?), if not - I guess this date can
still be used at least to recreate the most recent overwrite of the given fine. 

The trouble with the optional 3.b part / date corrections is: it may make such
theoretical recovery process more complicated or even (if the logs are absent)
no longer possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 13:47:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 11:47:44 +0000
Subject: [Koha-bugs] [Bug 17214] New: Add item in LIST by Record number
Message-ID: <bug-17214-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

            Bug ID: 17214
           Summary: Add item in LIST by Record number
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: mishravk79 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Once the LIST is created in Koha you can add item in that by barcode but is
there any option to add item by record number because if there is no barcode
assigned to the item how it can be added to the list? For example in case of
remotely available resources like e-book/e-journals where library may enter
only bibliographic details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 14:21:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 12:21:04 +0000
Subject: [Koha-bugs] [Bug 17215] New: Cardnumbers of patrons created using
 LDAP Replication not using autoMemberNum if configured
Message-ID: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

            Bug ID: 17215
           Summary: Cardnumbers of patrons created using LDAP Replication
                    not using autoMemberNum if configured
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ldjamison at marywood.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When using LDAP and leveraging the 'replicate' flag, patrons who are replicated
have their cardnumber assigned equal to their LDAP username. This is an
inconsistency when the 'autoMemberNum' System Preference is set to 'Do'. When
'autoMemberNum' is set to 'Don't' then replicate should act as it currently
does.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 14:45:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 12:45:39 +0000
Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number
In-Reply-To: <bug-17214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17214-70-PYhPnIhgDe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
While record number is a bad idea, biblionumber, would be okay.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 14:45:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 12:45:43 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-xc6zG8DZbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

--- Comment #1 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 54973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54973&action=edit
Assigns numerical cardnumber if autoMemberNum is enabled

This patch modifies Auth_with_ldap.pm to use the autoMemberNum System
Preference if it's enabled.

To test:
1. Set the autoMemberNum System Preference to "Don't".
2. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
3. Check the patron record's cardnumber.
4. the cardnumber should equal the patron's LDAP username.
5. Delete the patron record.
6. Apply the patch.
7. Set the autoMemberNum System Preference to "Do".
8. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
9. Check the patron record's cardnumber.
10. The cardnumber should now be the next highest cardnumber based on
autoMemberNum.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 14:52:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 12:52:41 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17209-70-WYHVbxxNTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 14:52:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 12:52:43 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17209-70-cVXcmRHFj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54966|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54974&action=edit
[SIGNED-OFF] Bug 17209: Remove use of onclick from masthead

There are two instances which use onclick in the OPAC masthead: clearing
search history, and logging out.

To test:
Confirm that clearing search history using the 'x' in the masthead, and
logging out by clicking 'Log out' in the masthead, work the same before
and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:00:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:00:17 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-sISzrGucvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:00:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:00:19 +0000
Subject: [Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail
	sidebar in OPAC
In-Reply-To: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17210-70-Q0Ghlb6Tdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54968|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54975&action=edit
[SIGNED-OFF] Bug 17210: Remove use of onclick from biblio detail sidebar in
OPAC

Four instances of onclick here:
1) Print
2) Save to your lists
3) Add to your cart
4) Remove from cart

To test:
Find a biblio detail page in OPAC and confirm all four events above work
as expected before and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:11:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:11:21 +0000
Subject: [Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page
In-Reply-To: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17211-70-mLzGw06I9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:11:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:11:23 +0000
Subject: [Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page
In-Reply-To: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17211-70-HTy13RB285@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54969|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 54976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54976&action=edit
[SIGNED-OFF] Bug 17211: Remove use of onclick from OPAC fines page

To test:
1) Set the EnablePayPalOpacPayments syspref to Allow and the
   PayPalSandboxMode to the appropriate mode
2) Go to OPAC fines
3) Confirm clicking the PayPal image link works the same before and
   after the patch (opens pop up window)

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:21:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:21:46 +0000
Subject: [Koha-bugs] [Bug 17216] New: Add a new table to store authorized
 value categories
Message-ID: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

            Bug ID: 17216
           Summary: Add a new table to store authorized value categories
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 15799

The way we manage authorized values is not consistent: Some are present in the
DB, others are not (see bug 15799 comment 4 for more details).
Worse, most of the time the FK does not exist (and datatype is not consistent:
varchar 32 vs 20, 16,...).

To help cleaning up this area, a new table to store authorized value categories
would be helpful.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:21:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:21:46 +0000
Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into
 Koha:: AuthorisedValues - part 2
In-Reply-To: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15799-70-VfLNoP6nBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:22:55 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-Szv8WZqyoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54977&action=edit
Bug 15516: Set reserve-group.pl to be executable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:27:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:27:03 +0000
Subject: [Koha-bugs] [Bug 17217] New: Allow to reserve first available item
 from a group of titles (OPAC)
Message-ID: <bug-17217-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

            Bug ID: 17217
           Summary: Allow to reserve first available item from a group of
                    titles (OPAC)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 15516

This bug follows bug 15516.

This is the OPAC part


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
[Bug 15516] Allow to reserve first available item from a group of titles
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:27:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:27:03 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-63E8eFKQ3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17217


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217
[Bug 17217] Allow to reserve first available item from a group of titles (OPAC)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:34:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:34:08 +0000
Subject: [Koha-bugs] [Bug 17217] Allow to reserve first available item from
 a group of titles ( OPAC)
In-Reply-To: <bug-17217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17217-70-HxuE1BFhMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 54978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54978&action=edit
Bug 17217: Allow to reserve first available item from a group of titles (OPAC)

Depends on bug 15516

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to OPAC search, display some results, click on some checkboxes and
   click on 'Place hold' button at the top of the results
2. Check the box with label "Place a hold on the first available..."
3. Check that more options appear (Pickup location, hold dates and
   notes).
4. Click on 'Place hold'
5. Now go to intranet interface and check in an item of one of the
   reserved biblios and confirm the hold
6. The hold status should have been changed to Waiting, and all other
   holds should have been deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:34:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:34:20 +0000
Subject: [Koha-bugs] [Bug 17217] Allow to reserve first available item from
 a group of titles ( OPAC)
In-Reply-To: <bug-17217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17217-70-JhRqNi09kb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 15:58:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 13:58:10 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-sBYhvsFc1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #11 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Nick, no items were created using your sample file because it does not contain
any homebranch informations.

Currently, homebranch fields are used to know how many items should be added.
Is there a better option?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:05:48 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-YUOedRrHyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #12 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Benjamin, can you post your MarcItemFieldsToOrder as well, please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:28 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-6rMAblnAoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:31 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-5p9yOMOuUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54979&action=edit
Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:34 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-oT7XHZ7DAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54980&action=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:39 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-VDhyEORZDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54981&action=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:42 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-NGI70qgshS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54982&action=edit
Bug 17216: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:46 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-yLclkUPe91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54983&action=edit
Bug 17216: Update the admin interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:49 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-ZWVastiXcZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54984&action=edit
Bug 17216: Add FK on mss.authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:42:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:42:52 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-XA6H7ndezj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54985&action=edit
Bug 17216: Use Koha::AVC from mss.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:44:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:44:37 +0000
Subject: [Koha-bugs] [Bug 17072] 006 not filling in with existing values
In-Reply-To: <bug-17072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17072-70-rQRJP17mAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
            Summary|007 not filling in with     |006 not filling in with
                   |existing values             |existing values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:44:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:44:48 +0000
Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into
 Koha:: AuthorisedValues - part 2
In-Reply-To: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15799-70-IHCsJzWXGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #4)

New table created on bug 17216 - Add a new table to store authorized value
categories.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:48:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:48:28 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-ntQdPNj8hr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54986&action=edit
[PASSED QA] Bug 17201: (bug 16431 follow-up2) Remove occurrence of
marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:48:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:48:47 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-jW4zCNBBpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54959|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 16:49:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 14:49:07 +0000
Subject: [Koha-bugs] [Bug 17201] Remaining calls to
	C4::Context->marcfromkohafield
In-Reply-To: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17201-70-7hHSm0nfSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fixed commit author name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 17:14:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 15:14:51 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-Lksv0Km6Ez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #33 from Owen Leonard <oleonard at myacpl.org> ---
The term "reserve group" is inconsistent with our terminology guidelines. I
think it should be "hold group." The word "reserve" is associated only with
course reserves.

https://wiki.koha-community.org/wiki/Terminology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:06:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:06:32 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-qlPAb0mjR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #13 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Matthias Meusburger from comment #12)
> Benjamin, can you post your MarcItemFieldsToOrder as well, please?

price: 975$p
quantity: 975$q
budget_code: 975$h

We just copied ours from the MarcFieldsToOrder. Note that though the fund code
did exist, we needed to manually select it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:31 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-nQMLXJeUdb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54979|0                           |1
        is obsolete|                            |
  Attachment #54980|0                           |1
        is obsolete|                            |
  Attachment #54981|0                           |1
        is obsolete|                            |
  Attachment #54982|0                           |1
        is obsolete|                            |
  Attachment #54983|0                           |1
        is obsolete|                            |
  Attachment #54984|0                           |1
        is obsolete|                            |
  Attachment #54985|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54987&action=edit
Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:34 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-UrYepvaR0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54988&action=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:38 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-xtVCcczDtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54989&action=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:42 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-4XQAzQeHwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54990&action=edit
Bug 17216: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:46 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-OQnDf4r46o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54991&action=edit
Bug 17216: Update the admin interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:50 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-zZn33Qerg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54992&action=edit
Bug 17216: Add FK on mss.authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:19:53 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-OoXB7xGjCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54993&action=edit
Bug 17216: Use Koha::AVC from mss.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 18:57:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 16:57:42 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-tX4NK5QWej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
- bug_17216_2_add_fk.sql is still missing a semicolon on the 'UPDATE
marc_subfield_structure' line.
- Shouldn't category be required in the "New category" form?
- In testing the effect of these patches on marc_subfield_structure.pl, what
should we be looking for? Simply that the categories show up correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 19:49:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 17:49:17 +0000
Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve
 expiration to skip all holidays
In-Reply-To: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12063-70-0lTqrZiRdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 19:54:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 17:54:33 +0000
Subject: [Koha-bugs] [Bug 17218] New: New list add attempt while logged in
 as dbadmin should be prevented pre-emptively
Message-ID: <bug-17218-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218

            Bug ID: 17218
           Summary: New list add attempt while logged in as dbadmin should
                    be prevented pre-emptively
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: indradg at l2c2.co.in
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Right now it allows the Koha db admin login to attempt adding a new list. Only
while trying to save it does it inform that it is not possible to do so. This
is should be made pre-emptive right after the "+ New list" option is clicked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 20:11:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 18:11:42 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-8m1jEfKfv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #39 from Owen Leonard <oleonard at myacpl.org> ---
- With my date format preference set to US (mm/dd/yyyy) it accepts dates like
3/3/2016. Sometimes saving this date triggers an error in Koha, sometimes the
date is ignored (and no date is saved).

- With my date format preference set to dmydot (dd.mm.yyyy) it accepts dates
like 1.1.2016 without any warning, but the date which is saved does not match
(in this case, 12.09.2016). The same thing happens with dd/mm/yyyy, including
the saved date -- 12/09/2016.

- I'm getting no warnings on the patron edit page when adding invalid data to
the date of birth field. It works correctly with registration date and
expiration date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 21:29:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 19:29:54 +0000
Subject: [Koha-bugs] [Bug 17219] SPAM
In-Reply-To: <bug-17219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17219-70-mrgkbUD39A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17219

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|++++((US).<<<<<><><><><<<.l |SPAM
                   |8004452790+++<><><><<<<<<<< |
                   |>>>> CANON PRINTER TECH     |
                   |support phone number,CANON  |
                   |printer helpline number     |
                   |USA...FLORIDA               |
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 21:38:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 19:38:55 +0000
Subject: [Koha-bugs] [Bug 17219] SPAM
In-Reply-To: <bug-17219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17219-70-t3J8yS9wJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17219

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:41:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:41:47 +0000
Subject: [Koha-bugs] [Bug 17220] New: Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
Message-ID: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

            Bug ID: 17220
           Summary: Improve clarity when placing a hold by changing button
                    text from "Place hold" to "Confirm hold"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ldjamison at marywood.edu
        QA Contact: testopia at bugs.koha-community.org

When placing a hold from the OPAC, patrons may be confused about clicking
"Place hold" twice during the reserve process (once from their search results
list/bib record detail then the second time when confirming the hold(s) to be
placed via the "Place hold" button). To improve clarity, changing the button
text from "Place hold" to "Confirm hold" can reduce patron confusion as it
eliminates duplication of text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:43:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:43:22 +0000
Subject: [Koha-bugs] [Bug 17220] Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
In-Reply-To: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17220-70-Eu35QsqAT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

--- Comment #1 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 54995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54995&action=edit
Changes button text of opac-reserve.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:46:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:46:36 +0000
Subject: [Koha-bugs] [Bug 17220] Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
In-Reply-To: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17220-70-tYSXKQtaUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Lee Jamison <ldjamison at marywood.edu> ---
(In reply to Lee Jamison from comment #1)
> Created attachment 54995 [details] [review]
> Changes button text of opac-reserve.pl

To test:
1. Login to the OPAC.
2. Place a hold on an item.
3. On the opac-reserve.pl screen make note of the button text "Place hold".
4. Cancel the hold and return to the homepage.
5. Apply the patch.
6. Place a hold on an item.
7. On the opac-reserve.pl screen make note of the button text which should now
be "Confirm hold".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:49:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:49:32 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-SfM0dzChvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54784|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 54996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54996&action=edit
[SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield

When cataloguing, if you want to duplicate a subfield that is not
empty, the new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is
created with subfields but without data in it.

Test plan:
Add or edit a bibliographic record
Fill a subfield
Duplicate the subfield
=> Without this patch the value of the input will be copied
=> With this patch the new input will be emptied

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:49:43 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-1y8CCz0CGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:49:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:49:56 +0000
Subject: [Koha-bugs] [Bug 17221] New: orphan comma in shelf browser
Message-ID: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

            Bug ID: 17221
           Summary: orphan comma in shelf browser
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 54997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997&action=edit
screenshot of bug

Example screenshot attached, here's the bib record in our catalog:

https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729&shelfbrowse_itemnumber=34420#holdings

Basically, since starting_homebranch is null in the template file, nothing is
printed out, but the next IF condition wrongly assumes that the first must have
been true and prints out a comma before it's text string. Steps to recreate:

- in settings, set ShelfBrowserUsesHomeBranch to "Don't Use"
- set ShelfBrowserUsesLocation to "Use"
- visit an item, click the "Browse shelf" link in the Holdings' tab's Call
Number column
- note the extraneous comma in the <h5> tag that appears

Patch coming shortly, it appears that simply adding an additional condition
around the comma itself should resolve this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:50:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:50:29 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-z1IV5IWki1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:50:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:50:43 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-hDRQq1ZlXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 22:59:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 20:59:44 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-VFezlm0U8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 23:11:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 21:11:09 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-X7YctF26FU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

--- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> ---
Created attachment 54998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54998&action=edit
patch

patch anticipates same problem with collection code in list, too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Aug 29 23:11:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 21:11:47 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-xcqOSySt3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 01:22:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 23:22:29 +0000
Subject: [Koha-bugs] [Bug 17222] New: Remove use of onclick from OPAC member
	entry page
Message-ID: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

            Bug ID: 17222
           Summary: Remove use of onclick from OPAC member entry page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 01:23:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 23:23:37 +0000
Subject: [Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member
	entry page
In-Reply-To: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17222-70-dGS5lRjUxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 01:23:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 23:23:40 +0000
Subject: [Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member
	entry page
In-Reply-To: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17222-70-5JRaACGIxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 54999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54999&action=edit
Bug 17222: Remove use of onclick from OPAC member entry page

There is only one instance on onclick here, and that is the clear date
function.

To test, make sure clicking 'Clear date' next to Date of Birth works the
same before and after the patch.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 01:24:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 29 Aug 2016 23:24:07 +0000
Subject: [Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member
	entry page
In-Reply-To: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17222-70-IDxZUZuL5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 02:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 00:33:25 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-AwGkAORYb7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 02:34:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 00:34:02 +0000
Subject: [Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used
In-Reply-To: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17193-70-rdtyoslxJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 02:34:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 00:34:06 +0000
Subject: [Koha-bugs] [Bug 17197] misc/batchupdateISBNs.pl is certainly no
	longer in use
In-Reply-To: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17197-70-DSl18928VY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 03:08:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 01:08:03 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-PYmBzu61sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #27 from David Cook <dcook at prosentient.com.au> ---
Kyle, I just reviewed the code, and it looks good to me.

Thanks for taking the time to test it :).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 07:56:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 05:56:29 +0000
Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export
	authorized values
In-Reply-To: <bug-10198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10198-70-XGijFLDXZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

Felix Hemme <felix.hemme at thulb.uni-jena.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |felix.hemme at thulb.uni-jena.
                   |                            |de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 08:55:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 06:55:45 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-oJ83q7ACx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #25 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #21)
> Jacek, Just a quick glance:
> Why Warn ? We always just warn.

Just a copy & paste from some random local script (warn adds a line number
etc).

> Add a dbrev that at least prints a NOTE: <<ATTENTION...>> that tells the
> sysadmin to optionally run your script when upgrading.

Should this go to STDERR or to the STDOUT (warn, print - I see both in
updatedatabase used for such purposes, print seems to be more popular lately)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 10:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 08:42:54 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-Fxff8hoZsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54876|0                           |1
        is obsolete|                            |

--- Comment #92 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 55000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55000&action=edit
Bug 7677: QA followup

 - Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 10:44:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 08:44:25 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-gH6yjJLaLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 10:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 08:57:19 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-uaUGZhc3om@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 10:57:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 08:57:23 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-eB5lociL5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55001&action=edit
Bug 14060: Force leading zeros on date

If a date does not contain leading zeros for day and month, the date
will be refused.
parseDate function considers 1/1/1990 as a valid date, but our perl code
does not. We must refuse it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 10:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 08:57:27 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-m3ublUuEJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55002&action=edit
Bug 14060: Add the datepicker class to dateofbirth

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:02:58 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-tydUc7hQPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54992|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55003&action=edit
Bug 17216: Add FK on mss.authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:03:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:03:01 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-55gwkALncJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54993|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55004&action=edit
Bug 17216: Use Koha::AVC from mss.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:03:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:03:07 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-6aroIb6RcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55005&action=edit
Bug 17216: Category name is required when adding a new AV cat

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:07:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:07:03 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-YAcMX5AdkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #15)
> - bug_17216_2_add_fk.sql is still missing a semicolon on the 'UPDATE
> marc_subfield_structure' line.

Oops, sorry about that.
I have tested the file directly in the CLI, line by line, that's why I did not
spot it.

> - Shouldn't category be required in the "New category" form?

Yep, done.

> - In testing the effect of these patches on marc_subfield_structure.pl, what
> should we be looking for? Simply that the categories show up correctly?

Yes.
You will also think about the structure changes: now all the AV cat is
displayed, when before only the AV cat *in used* were displayed.
Think also about the "branches", "itemtypes" and "cn_source". does that make
sense to have them in the table, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:07:10 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-lugf5gQZLq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:43:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:43:31 +0000
Subject: [Koha-bugs] [Bug 17220] Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
In-Reply-To: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17220-70-trhxxbrjSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:43:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:43:32 +0000
Subject: [Koha-bugs] [Bug 17220] Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
In-Reply-To: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17220-70-epG1MjwumH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 55006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55006&action=edit
Change hold confirmation string from 'Place hold' to 'Confirm hold'

https://bugs.koha-community.org/show_bug.cgi?id=17220

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 11:44:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 09:44:43 +0000
Subject: [Koha-bugs] [Bug 17220] Improve clarity when placing a hold by
 changing button text from " Place hold" to "Confirm hold"
In-Reply-To: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17220-70-uO6sElAYWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com,
                   |                            |oleonard at myacpl.org

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Patch works as expected, tagging Owen and waiting for QA opinion on change of
wording.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:41:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:41:42 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-HsikN1cha1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:41:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:41:44 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
	results
In-Reply-To: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15388-70-va7nP2QvFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 55007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55007&action=edit
[SIGNED-OFF] Bug 15388 - Show Syndetics covers by UPC in search results

Syndetics code accepts UPC and OCLC numbers, however, we were only passing this
if there
was an ISBN. This patch alters the code to search if either an ISBN or
UPC is present

To test:
Enable syndetics (will need an account)
Search for items with UPCs or OCLC numbers and no ISBN (DVDs)
Note there are no images in search results but there are in details
Apply patch
Note that items with images in details now also have images in results

Signed-off-by: Barbara.Johnson at bedfordtx.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:48:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:48:19 +0000
Subject: [Koha-bugs] [Bug 17075] Items' subfields do not obey the mandatory
	flag
In-Reply-To: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17075-70-wXOCq8mlVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

Claudio <costalc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:56:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:56:30 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-d2bycrwVDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55008&action=edit
Bug 17216: Add FK on authorised_values.category

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:56:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:56:33 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-BzDXAloWHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55009&action=edit
Bug 17216: Update DBIC Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 12:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 10:56:55 +0000
Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax
 for slips and notices
In-Reply-To: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14757-70-zfJL1EGku9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #59 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
I seem to get a lot of failures after this patch.

I can't get HOLD_SLIP to render without error:
SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator
'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line 168

I hooked it up with debugger and it fails in sub _get_tt_params

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 13:02:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 11:02:30 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-Dmywv9gaLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55010&action=edit
Bug 17216: Update DBIC schema for MSS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 13:09:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 11:09:18 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-AZl7xpMByD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55011&action=edit
Bug 17216: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 13:15:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 11:15:23 +0000
Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax
 for slips and notices
In-Reply-To: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14757-70-EMFNhdzky6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #60 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
I managed to fix it by changing the config hash in _get_tt_params:

> git diff
diff --git a/C4/Letters.pm b/C4/Letters.pm
index 737c8cd..c1ef404 100644
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -1437,7 +1437,7 @@ sub _get_tt_params {
             module   => 'Koha::Holds',
             singular => 'hold',
             plural   => 'holds',
-            fk       => [ 'borrowernumber', 'biblionumber' ],
+            pk       => 'reserve_id',
         },
         serial => {
             module   => 'Koha::Serials',


But I don't understand this code very well, so you folks have to look at it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 14:09:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 12:09:44 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-QG1Jt7BOQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #25)
> > Add a dbrev that at least prints a NOTE: <<ATTENTION...>> that tells the
> > sysadmin to optionally run your script when upgrading.
> 
> Should this go to STDERR or to the STDOUT (warn, print - I see both in
> updatedatabase used for such purposes, print seems to be more popular
> lately)?

At least, we need a print statement in an atomicupdate to alert people.
You could also think of running the script via updatedatabase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 14:10:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 12:10:01 +0000
Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax
 for slips and notices
In-Reply-To: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14757-70-ZWoP3egpER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Petter Goks?yr ?sen from comment #59)
> I seem to get a lot of failures after this patch.
> 
> I can't get HOLD_SLIP to render without error:
> SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator
> 'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line
> 168
> 
> I hooked it up with debugger and it fails in sub _get_tt_params

Bug 16942 should fix this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 14:41:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 12:41:07 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-JLWMjheNHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
How is this different from enabling "QueryStemming" ?
Automatic truncation can lead to huge number of results, consider the automatic
truncation of author names and short words.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:05:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:05:20 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-TOP6kh5lS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54902|0                           |1
        is obsolete|                            |

--- Comment #42 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55012&action=edit
[SIGNED-OFF] Bug 14060: Remove readonly attributes on date inputs

In order to remove accessibility issues due to the readonly attributes
on date inputs, this patch will remove them and introduce a javascript
validation on them.

This patch is not perfect for some reason:
I didn't manage to force the user to select a valid date. One solution
would be to reopen the datepicker plugin until a valid date is inserted.
But it could be annoying for users (and for me: I did not manage to
implement this solution).
You will note that input is emptied if the date is not valid. This is a
quick and efficient solution to prevent submitting invalid date and make
Koha explodes. A proper solution would be to implement the check server
side send a friendly message to the user.

Test plan:
For all inputs, try an invalid and a valid date.
 1/ Debar a patron
 2/ On the checkout tables (circulation and moremember), add a renewal
due date (at the bottom of the tables)
 3/ On the checkout page, specify a due date
 4/ On the return page, specify a return date
 5/ On the invoice page (acquisition module), enter a shipment and
billing date
 6/ On the invoice search page (invoices.pl) use filters shipment and
billing dates
 7/ On the offline circ page, specify a due date
 8/ On the edit patron page (memberentry), add a debarment
 9/ On the reserve page (reserve/request.pl), use the date inputs to
suspend until a defined date
10/ Edit patrons in a batch (tools/modborrowers.pl) and use the
registration and expiry date inputs

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:05:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:05:33 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-ikiqfANkck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54903|0                           |1
        is obsolete|                            |

--- Comment #43 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55013&action=edit
[SIGNED-OFF] Bug 14060: Add OnClose event on missing datepicker

The "suspend until" inputs (hold list on circ/circulation.pl and
members/moremember.pl) were not set in the same way.
The minDate option should be set for both (bug 10703 removed it for
circ/circulation.pl).
This patch reintroduces the option and add the OnClose event on both.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:05:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:05:46 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-uvErIqQmxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54904|0                           |1
        is obsolete|                            |

--- Comment #44 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55014&action=edit
[SIGNED-OFF] Bug 14060: Display the date format on the warning popup

The date format is now displayed on the warning popup.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:05:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:05:56 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-cgYDPFARkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54905|0                           |1
        is obsolete|                            |

--- Comment #45 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55015&action=edit
[SIGNED-OFF] Bug 14060: Force the input to contain a valid date

Before this patch, the user was still allowed to enter a valid date.
Now, if the date is not valid, the input is emptied.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:06:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:06:06 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-9mxozlR4FC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54906|0                           |1
        is obsolete|                            |

--- Comment #46 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55016&action=edit
[SIGNED-OFF] Bug 14060: Add support for dmydot

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:06:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:06:18 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-sSLyiyMvXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54907|0                           |1
        is obsolete|                            |

--- Comment #47 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55017&action=edit
[SIGNED-OFF] Bug 14060: Display date format pattern instead of date format name

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:06:30 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-yfJkEGMJeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55001|0                           |1
        is obsolete|                            |

--- Comment #48 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55018&action=edit
[SIGNED-OFF] Bug 14060: Force leading zeros on date

If a date does not contain leading zeros for day and month, the date
will be refused.
parseDate function considers 1/1/1990 as a valid date, but our perl code
does not. We must refuse it.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:06:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:06:40 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-pgCPuUjyVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55002|0                           |1
        is obsolete|                            |

--- Comment #49 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55019&action=edit
[SIGNED-OFF] Bug 14060: Add the datepicker class to dateofbirth

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:07:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:07:05 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-BEw80EjPWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:52:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:52:54 +0000
Subject: [Koha-bugs] [Bug 17223] New: Add Cache::Memcached to
	PerlDependencies
Message-ID: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

            Bug ID: 17223
           Summary: Add Cache::Memcached to PerlDependencies
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Just stumble over an uninstalled Cache::Memcached (where Cache::Memcached::Fast
seems to be present via koha-common) on Jessie.
Note that Context.pm creates a cache with Cache::Memcached while Koha::Cache
uses Cache::Memcached::Fast. (Context even uses both!)
libcache-memcached-perl is packaged for Wheezy/Jessie.

On the longer term we should probably fix what we are doing in Context now.
Opened another bug for that (see also).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:54:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:54:23 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-O97i2QjnN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:54:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:54:25 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-xlImri3ap8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55020&action=edit
Bug 17223: Add Cache::Memcached to PerlDependencies

Test plan:
Check about page, perl modules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:55:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:55:53 +0000
Subject: [Koha-bugs] [Bug 17224] New: Switch to Koha::Cache completely in
	Context.pm ?
Message-ID: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17224

            Bug ID: 17224
           Summary: Switch to Koha::Cache completely in Context.pm ?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Context.pm creates a cache with Cache::Memcached while Koha::Cache uses
Cache::Memcached::Fast. (And Context even uses a cache from Koha::Cache too!)

While adding Cache::Memcached to PerlDependencies on the see also report, we
should probably fix Context somehow to use Koha::Cache completely.
Note that Fast does not support the parameters debug and expire_time as used in
Context now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:57:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:57:23 +0000
Subject: [Koha-bugs] [Bug 17224] Switch to Koha::Cache completely in
	Context.pm ?
In-Reply-To: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17224-70-vPHX2NuxRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17224

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17223

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:57:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:57:23 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-gbDYoXfayH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
                 CC|                            |mirko at abunchofthings.net
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17224

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 15:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 13:57:27 +0000
Subject: [Koha-bugs] [Bug 17225] New: Search using ISBN13 should find ISBN10
 (and vice versa).
Message-ID: <bug-17225-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17225

            Bug ID: 17225
           Summary: Search using ISBN13 should find ISBN10 (and vice
                    versa).
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: r.delahunty at arts.ac.uk
        QA Contact: testopia at bugs.koha-community.org

We would like to see functionality developed to allow a search using the 13
digit form of the ISBN find the matching 10 digit ISBN (and vice versa) when
the other length ISBN is not in the record. We accept that if both the 13 digit
and 10 digit ISBN were present in the record then the record would be found
whether we entered the 10 or the 13 digit ISBN. An example search is
9780500280775, where we expect to find the record with (only) the ISBN of
0500280770 already in the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:34:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:34:33 +0000
Subject: [Koha-bugs] [Bug 17224] Switch to Koha::Cache completely in
	Context.pm ?
In-Reply-To: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17224-70-4QVoJ7m0Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17224

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:36:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:36:36 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-nuxXWD9Hmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54987|0                           |1
        is obsolete|                            |

--- Comment #24 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55021&action=edit
[SIGNED-OFF] Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:36:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:36:44 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-FDlbXmQ61G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54988|0                           |1
        is obsolete|                            |

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55022&action=edit
[SIGNED-OFF] Bug 17216: Add new table authorised_value_categories and populate
it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:36:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:36:52 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-ec8Ob36IvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54989|0                           |1
        is obsolete|                            |

--- Comment #26 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55023&action=edit
[SIGNED-OFF] Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:36:58 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-IFlu3XZJ4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54990|0                           |1
        is obsolete|                            |

--- Comment #27 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55024&action=edit
[SIGNED-OFF] Bug 17216: DBIC Schema changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:05 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-zyEWbaVKzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54991|0                           |1
        is obsolete|                            |

--- Comment #28 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55025&action=edit
[SIGNED-OFF] Bug 17216: Update the admin interface

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:10 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-3bHdL3bs2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55003|0                           |1
        is obsolete|                            |

--- Comment #29 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55026&action=edit
[SIGNED-OFF] Bug 17216: Add FK on mss.authorised_value

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:19 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-g2HMgjtHX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55004|0                           |1
        is obsolete|                            |

--- Comment #30 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55027&action=edit
[SIGNED-OFF] Bug 17216: Use Koha::AVC from mss.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:26 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-bbWoqHE7CJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55005|0                           |1
        is obsolete|                            |

--- Comment #31 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55028&action=edit
[SIGNED-OFF] Bug 17216: Category name is required when adding a new AV cat

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:34 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-PcuzQZrSKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55008|0                           |1
        is obsolete|                            |

--- Comment #32 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55029&action=edit
[SIGNED-OFF] Bug 17216: Add FK on authorised_values.category

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:40 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-R2jJiddRZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55009|0                           |1
        is obsolete|                            |

--- Comment #33 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55030&action=edit
[SIGNED-OFF] Bug 17216: Update DBIC Schema

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:47 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-egY2uBAbm0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55010|0                           |1
        is obsolete|                            |

--- Comment #34 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55031&action=edit
[SIGNED-OFF] Bug 17216: Update DBIC schema for MSS

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:37:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:37:53 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-sH7PdXP5fK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55011|0                           |1
        is obsolete|                            |

--- Comment #35 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55032&action=edit
[SIGNED-OFF] Bug 17216: Fix tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:39:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:39:23 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-w1ZY7GlakV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #36 from Owen Leonard <oleonard at myacpl.org> ---
These patches work well for me from the point of view of an end user. The
patches apply, QA tools don't complain, and database updates correctly. I have
followed the test plan successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:40:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:40:38 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-k6VraZddZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52681|0                           |1
        is obsolete|                            |

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 55033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55033&action=edit
Bug 15165 - Add API route to list accountlines

GET /accountlines                  (list)
GET /accountlines?borrowernumber=X (list)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace
   XXX with a borrowernumber that has accountlines) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/accountlines and check that you receive
   all accountlines
4. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:40:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:40:43 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-G93XXqvW2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52682|0                           |1
        is obsolete|                            |

--- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 55034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55034&action=edit
Bug 15165 - Add API route to edit accountlines

PUT /accountlines/{accountlines_id} (edit)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY
   where YYY is one of your accountlines_id. See the body definition
   in definitions/editAccountlineBody.json and use this in your PUT request.
3. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:40:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:40:48 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-ZEcvxSh8sS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52683|0                           |1
        is obsolete|                            |

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 55035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55035&action=edit
Bug 15165 - Add API routes to pay accountlines

POST /accountlines/(:accountlines_id)/payment  (pay towards accountline)
POST /patrons/(:borrowernumber)/payment        (pay towards borrower)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You must have permission updatecharges.
2. Create a fine to any patron and get the accountlines_id.
3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment
   without body where YYY is the accountlines_id you created in step 2.
4. Check that the accountline that you created in step 2 is paid.
5. Create two payments with amount 5.00 (with no other outstanding payments)
6. Send POST request to
   http://yourlibrary/api/v1/patrons/ZZZ/payment with body
   {"amount": 10}
   Replace ZZZ with the borrowernumber for which you have created two
   fines
7. Check that the two accountlines are paid.
8. Repeat step 2.
9. Send POST request to
   http://yourlibrary/api/v1/accountlines/YYY/payment with body
   {"amount": XXX}
   Replace YYY with the accountlines_id you created in step 8.
   Set amount (XXX) to the half of the amount of the fine you created in
   step 8.
10. Check that the fine is still outstanding with half of the original
    amount.
11. Run unit tests at t/db_dependent/api/v1/accountlines.t and
    t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:41:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:41:05 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
	servers
In-Reply-To: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17188-70-YZtkoumZzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:42:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:42:09 +0000
Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached
	namespaces
In-Reply-To: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17189-70-zLFGcpJZ2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:43:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:43:07 +0000
Subject: [Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member
	entry page
In-Reply-To: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17222-70-TP7DH4NwdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:43:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:43:09 +0000
Subject: [Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member
	entry page
In-Reply-To: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17222-70-oS2jDvjDHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54999|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55036&action=edit
[SIGNED-OFF] Bug 17222: Remove use of onclick from OPAC member entry page

There is only one instance on onclick here, and that is the clear date
function.

To test, make sure clicking 'Clear date' next to Date of Birth works the
same before and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:45:14 +0000
Subject: [Koha-bugs] [Bug 16579] [OMNIBUS] Use separate memcached namespace
 for caching koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-4fubBFVn4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17224

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:45:14 +0000
Subject: [Koha-bugs] [Bug 17224] Switch to Koha::Cache completely in
	Context.pm ?
In-Reply-To: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17224-70-i7Fd1EI8z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17224

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16579

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:45:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:45:27 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-ltskYHaEJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15894
             Status|ASSIGNED                    |Needs Signoff

--- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rewritten on top of bug 15894.

Routes /accountlines/{id}/payment and /accountlines/{id}/partialpayment have
been merged.
Route /accountlines/{borrowernumber}/amountpayment has been moved to
/patrons/{borrowernumber}/payment
These routes were previously "PUT routes", they are now "POST routes".


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894
[Bug 15894] Unify all account fine payment functions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 16:45:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 14:45:27 +0000
Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions
In-Reply-To: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15894-70-2dWRdmAcl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165
[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:13:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:13:00 +0000
Subject: [Koha-bugs] [Bug 17226] New: Improve AUTOLOAD of Koha::Object
Message-ID: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

            Bug ID: 17226
           Summary: Improve AUTOLOAD of Koha::Object
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Following the path of bug 17091, Koha::Object needs to AUTOLOAD the methods
provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:13:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:13:00 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17091-70-ucGpIEbyem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17226

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:16:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:16:35 +0000
Subject: [Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object
In-Reply-To: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17226-70-DOkH0OmKu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:16:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:16:37 +0000
Subject: [Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object
In-Reply-To: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17226-70-TyIEcQJgrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55037&action=edit
Bug 17226: Improve Koha::Object's AUTOLOAD method

Following the path of bug 17091, Koha::Object needs to AUTOLOAD the
methods provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!

Test plan:
  prove t/db_dependent/Koha/Object.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:17:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:17:51 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-FJ9Y4YNRDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
If you have ShelfBrowserUsesCcode, ShelfBrowserUsesHomeBranch, and
ShelfBrowserUsesLocation all set to 'Use," but you are browsing an item which
doesn't have a shelving location there are extra commas:

" Browsing Athens Shelves , , Collection code: Juvenile fiction "

I wonder if that scenario can be handled as well?

By the way, please include a test plan in your commit messages. And if you
would like to be credited by name in Koha's release notes, about page, etc.,
configure git with your real name so it appears in the patch.

Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:24:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:24:24 +0000
Subject: [Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object
In-Reply-To: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17226-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17226-70-vHm5AvGXBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55038&action=edit
Bug 17226: Make Koha::Object->get_column available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:31:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:31:00 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-cutMEtT0sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:31:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:31:03 +0000
Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving
In-Reply-To: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16035-70-KddqRFlYbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54898|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 55039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55039&action=edit
[SIGNED-OFF] Bug 16035: MARC default bibliographic framework Export fix

This patch makes sure that, if there is no framework code,
     $frameworkcode is set to 'default'. This fixes the format issue.
     Then, if $frameworkcode = default, an empty string (rather than
     null) is passed to the ExportFramework method, as the framework
     code in the DB for default codes is "".

To test:
1) Go to Admin -> MARC Bibliographic framework
2) Try to export default framework in all formats, notice the file is
only exported as .ods and is an empty file. Notice warns in intranet
error log.
3) Apply patch and refresh page
4) Confirm exporting default framework works in all formats and
spreadsheet has data
5) Notice warns in error log are gone
6) Confirm export still works for other frameworks

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:36:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:36:35 +0000
Subject: [Koha-bugs] [Bug 17224] Switch to Koha::Cache completely in
	Context.pm ?
In-Reply-To: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17224-70-buehRQPBJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17224

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's on my todo list, but I'd like to see bug 16579 pushed first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 17:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 15:53:09 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-4RtvarZ39s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
This works for me, but the QA tools warn that the changes to Output.pm
introduce tab characters. Indentation should be 4 spaces:

https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation

When you modify your patch, please use the bug report title as the commit
message's first line:

"Bug 17153 - Logging in during a search navigates to account page instead of
back to search results"

...and include test plan in your commit message as well.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:00:24 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-d4n2l0Ykbv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53440|0                           |1
        is obsolete|                            |

--- Comment #133 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55040&action=edit
Bug 11592: Updated License Text and use Modern::Perl

Why not clean up the License Agreement stuff while the files
are being changed? Used the current one found at:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Changed the strict and warning lines into just a Modern::Perl.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:00:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:00:43 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-7Ddo9Sjd4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53441|0                           |1
        is obsolete|                            |

--- Comment #134 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55041&action=edit
Bug 11592: Add should_hide_marc method to filter

Add should_hide_marc to ViewPolicy filter
Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:00:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:00:59 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-QzqpNusQ9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53442|0                           |1
        is obsolete|                            |

--- Comment #135 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55042&action=edit
Bug 11592: Applying filtering to opac interface.

Applying the filtering and then...
Debugging opac/opac-detail.pl filtering
Debugging opac/opac-ISBDdetail.pl more
Debugging opac/opac-export.pl
Tweak opac/opac-export.pl fix variable declarations, conditional assignments
Debugging opac/opac-showmarc.pl

https://bugs.koha-community.org/show_bug.cgi?id=11592

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:01:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:01:21 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-SJp9jluVPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53443|0                           |1
        is obsolete|                            |

--- Comment #136 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55043&action=edit
Bug 11592: Biblio tweak for MARCSUBJECT

https://bugs.koha-community.org/show_bug.cgi?id=11592

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:01:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:01:33 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-UxbIUXyuuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53444|0                           |1
        is obsolete|                            |

--- Comment #137 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55044&action=edit
Bug 11592: MARCView and ISBD followup

There are still some leaks, but it is not as a result
of the filter, but rather a result of poorly written
template files.

Bug fixing template files is beyond the scope of this
set of patches.

TEST PLAN
---------
 1) Backup your DB
 2) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=-8;
    -- this should set EVERYTHING to hidden across the board.
 3) In staff client, set OPACXSLTDetailsDisplay to blank
 4) In OPAC, view any detail.
    -- Normal view may mostly leak values still.
    -- MARC view may leak values.
    -- ISBD view may leak values.
 5) In staff client, set OPACXSLTDetailsDisplay to default
 6) In OPAC, view any detail.
    -- same issues as step 4
    -- 'View Plain' may leak too.
 7) 'Save record' -> 'Dublin Core'
 8) Apply this patch
 9) run koha qa test tools
    -- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
    -- should pass
    -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
    -- Normal view:
       -- Material type comes from the LEADER field.
       -- Lists this is on will still display
       -- 'Tags from this library' will still display
       -- Item information in table will still display
          (THIS IS BEYOND SCOPE)
    -- MARC view:
       -- Record number is leaked
          (THIS IS BEYOND SCOPE)
       -- 'View plain' leaks LEADER field.
    -- ISBD view may leak field headings, but not values.
       (THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
    -- same kind of output as step 10
14) 'Save record' -> BIBTEXT
    -- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
    -- Should be the same or less leaked between the two versions.
    -- (XML FILTERING IS BEYOND SCOPE)
16) In the staff client, go view the same record.
    -- it should be mostly hidden in ISBD View.
17) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=1;
    -- this should set EVERYTHING to hidden in OPAC, but not
       the STAFF across the board.
18) Refresh the staff ISBD page
    -- values should reappear.
19) View the ISBD details in the OPAC
    -- values should still be hidden.
20) Check out the OPAC Cart and List
    -- while the intermediate pages may still leak
       the download links should leak very minimally.
    -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH
        THE INTRANET ISBD AND SOME CART/LIST STUFF
        WERE FIXED BECAUSE OF THE GetISBDView REFACTOR)

Expectations:
Before Patch - all the OPAC Detail pages will display things
After Patch - all the OPAC Detail pages will display much less,
              and hopefully nothing (though there are known limits).
              the ISBD detail page in the Staff client will be
              filtered as well based on STAFF settings.
              The saving/exporting should generate nearly empty
              files.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:01:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:01:47 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-2eOZBPeMjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #138 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045&action=edit
Bug 11592: (QA followup) Simplify code

Koha::RecordProcessor and the defined filters are supposed to bring us
joy and happiness. Let's keep the code compact, simple and clean.

This patch removes record cloning all over the place.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:02:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:02:01 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-EGNQBCeqHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #139 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 55046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046&action=edit
Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls

This patch adds the frameworkcode option param, using each record's
frameworkcode
as expected by the filter. Otherwise the ViewPolicy filter falls back to the
default framework.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 18:05:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 16:05:42 +0000
Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value
	categories
In-Reply-To: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17216-70-mq7eBVEDt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 55047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55047&action=edit
Bug 17216: Fix other tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 19:44:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 17:44:04 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-v7xdG4rhzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 55048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55048&action=edit
Implemented autoMemberNum in C4::Auth_with_ldap.pm

https://bugs.koha-community.org/show_bug.cgi?id=17215

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 19:44:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 17:44:01 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-fUxbYfYoKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 19:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 17:45:01 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-gV4BCie84Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
QA tools complaints:

   FAIL   forbidden patterns
                forbidden pattern: tab char (line 245)
                forbidden pattern: tab char (line 247)
                forbidden pattern: tab char (line 242)
                forbidden pattern: tab char (line 243)
                forbidden pattern: tab char (line 241)
                forbidden pattern: tab char (line 248)
                forbidden pattern: tab char (line 244)
                forbidden pattern: tab char (line 246)


Tested using LDAP server here:
http://www.forumsys.com/en/tutorials/integration-how-to/ldap/online-ldap-test-server/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 19:48:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 17:48:08 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-cJO1RCIALV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #140 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 55045
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045
Bug 11592: (QA followup) Simplify code

Review of attachment 55045:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=55045)
-----------------------------------------------------------------

Just an eyeball.

::: catalogue/ISBDdetail.pl
@@ -33,5 @@
>  
>  =cut
>  
> -use strict;
> -#use warnings; FIXME - Bug 2505

I wouldn't change to Modern::Perl, unless all the Bug 2505 references are fixed
like this.

::: opac/opac-export.pl
@@ +35,5 @@
>  $biblionumber = int($biblionumber);
>  my $error = q{};
>  
> +my $include_items = ($format =~ /bibtex/) ? 0 : 1;
> +my $marc = GetMarcBiblio($biblionumber, $include_items)

Oooo... nice simplification.

::: opac/opac-showmarc.pl
@@ -58,4 @@
>  
>  if ($view eq 'card' || $view eq 'html') {
> -    # FIXME: GetXmlBiblio needs filtering later.
> -    my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber);

GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I
recall correctly. I'm not sure about this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 19:59:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 17:59:02 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-hrXcx5UEu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #141 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 55046
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55046
Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls

Review of attachment 55046:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=55046)
-----------------------------------------------------------------

Just a quick eyeball.

::: opac/opac-MARCdetail.pl
@@ +73,5 @@
> +if ( ! $record ) {
> +    print $query->redirect("/cgi-bin/koha/errors/404.pl");
> +    exit;
> +}
> +

Okay. More logical location.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:13:29 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-cXQZxPa0fK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Just pasting in from my koha-conf.xml to ease testing setup for anyone else:

  <useldapserver>1</useldapserver><!-- see C4::Auth_with_ldap for extra configs
you must add if you want to turn this on -->
    <ldapserver id="ldapserver">
      <hostname>ldap://ldap.forumsys.com/</hostname>
      <port>389</port>
      <base>dc=example,dc=com</base>
      <user>cn=read-only-admin,dc=example,dc=com</user>          <!-- DN, if
not anonymous -->
      <pass>password</pass>          <!-- password, if not anonymous -->
      <replicate>1</replicate>       <!-- add new users from LDAP to Koha
database -->
      <update>0</update>             <!-- update existing users in Koha
database -->
      <auth_by_bind>1</auth_by_bind> <!-- set to 1 to authenticate by binding
instead of password comparison, e.g., to use Active Directory -->
      <principal_name>uid=%s,dc=example,dc=com</principal_name>
      <mapping>                  <!-- match koha SQL field names to your LDAP
record field names -->
        <userid       is="uid" ></userid>
        <categorycode is="banana">YA</categorycode>
        <branchcode is="apple">LPL</branchcode>
 <!--       <password     is="userpassword"   ></password>-->
      </mapping>
    </ldapserver>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:16:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:16:54 +0000
Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature
 equivalent to the aggressive ISBN matcher
In-Reply-To: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14629-70-1XxpbH8Z2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

--- Comment #19 from Mirko Tietgen <mirko at abunchofthings.net> ---
Dependency is in Wheezy and Jessie, we're good to go from my side. I'll update
the control file once this is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:19:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:19:42 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-dLpBOuu9nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #142 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. Tompsett from comment #140)
> Comment on attachment 55045 [details] [review]
> Bug 11592: (QA followup) Simplify code
> 
> Review of attachment 55045 [details] [review]:
> -----------------------------------------------------------------
> 
> Just an eyeball.
> 
> ::: catalogue/ISBDdetail.pl
> @@ -33,5 @@
> >  
> >  =cut
> >  
> > -use strict;
> > -#use warnings; FIXME - Bug 2505
> 
> I wouldn't change to Modern::Perl, unless all the Bug 2505 references are
> fixed like this.

I prefer to do it, and take responsability if it introduces a warning. Haven't
seen one so far.

> ::: opac/opac-showmarc.pl
> @@ -58,4 @@
> >  
> >  if ($view eq 'card' || $view eq 'html') {
> > -    # FIXME: GetXmlBiblio needs filtering later.
> > -    my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber);
> 
> GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I
> recall correctly. I'm not sure about this.

The main difference is that GetMarcBiblio does some sanitization. I think it is
safe. This is probably some reminder from the days when everything was done
against biblioitems.marc instead of biblioitems.marcxml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:19:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:19:56 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-ht9ZUGAiAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55020|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 55049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55049&action=edit
Bug 17223: Add Cache::Memcached to PerlDependencies

Test plan:
Check about page, perl modules.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:21:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:21:40 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-aCR4dX24dY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 55050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55050&action=edit
Bug 17223 Follow-up: updated control file

This is the control file change for the master branch triggered by
the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:22:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:22:04 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-fLruPWjFbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:25:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:25:21 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-1HsRG0y0aP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Marcel: Thanks for fixing this!

Trivial packaging patch. Skipping QA.

Second patch should be pushed if it still applies at time of push. If not, just
skip it and it will be dealt with seperately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 20:25:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 18:25:41 +0000
Subject: [Koha-bugs] [Bug 17223] Add Cache::Memcached to PerlDependencies
In-Reply-To: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17223-70-9vAHUt2nvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17223

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 22:31:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 20:31:08 +0000
Subject: [Koha-bugs] [Bug 14228] fill in patron info by scanning an ID
In-Reply-To: <bug-14228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14228-70-IEtPtpVLWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 23:18:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 21:18:36 +0000
Subject: [Koha-bugs] [Bug 17227] New: SQL reserved words should be
 dis-allowed as branchcodes / authorized values / item types
Message-ID: <bug-17227-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17227

            Bug ID: 17227
           Summary: SQL reserved words should be dis-allowed as
                    branchcodes / authorized values / item types
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Related to bug 13727

It is possible for the report selectors

<<...|branch>>
<<...|[authorised value]>>
<<...|itemtypes>>
... etc.

To insert SQL keywords into the SQL of a report, causing a software error when
the report runs, because Koha will now allow SQL reserved words in the queries.

To replicate:

Create a branch with the branch code 'CREATE'

Then create a report using the following query:

SELECT *
FROM items
WHERE items.homebranch = <<Branch|branch>>

Run the report, and select the branch with branchcode 'CREATE'.

This will cause a software error.

There is no way around this (because we *don't* want to allow SQL reserved
words to be injected by user input). Therefore we *must* restrict the use of
SQL reserved words on branch/authorized value/itemtype creation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 23:31:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 21:31:11 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: <bug-7533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7533-70-iI7miPOxKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Aug 30 23:59:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 21:59:29 +0000
Subject: [Koha-bugs] [Bug 7511] Caching Templates
In-Reply-To: <bug-7511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7511-70-sl37wO0xo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 00:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 22:19:22 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: <bug-7533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7533-70-yfFuOduMft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
(In reply to Paul Poulain from comment #0)
> Add an option to the command-line installer that will let the user choose to
> activate T::T during installation.

Hi Paul, do you think it would be better to enable this feature by default?

It seems to good to just have it as an 'optional' choice :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 00:47:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 22:47:39 +0000
Subject: [Koha-bugs] [Bug 17221] orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-7fYvuzJvLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

--- Comment #3 from Eric Phetteplace <ephetteplace at cca.edu> ---
Thanks for the feedback Owen, I'll take another look & develop a better testing
plan. It's difficult because there are so many permutations of settings and
then fields that could be empty on the item records but that's all the more
reason to have a well-defined plan.

I want to be credited to my GitHub username (phette23) so the lack of my real
name in the commit notes is intentional.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 01:03:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Aug 2016 23:03:51 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-eUHGOX15M2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Zeno Tajoli from comment #4)
> In fact I use ICU on jessie and I install Zebra from  Indexdata repositories.
> I think it is the only option avaible.

Agreed.

I don't know the Koha community's official position on the subject, but I think
we should be advocating the use of IndexData's repositories or providing a
fully functional Zebra package ourselves. Relying on the Debian repository is
clearly not a good option :/.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 05:06:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 03:06:07 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-1ERCnh647A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin SOMERS from comment #20)
> How is this different from enabling "QueryStemming" ?
> Automatic truncation can lead to huge number of results, consider the
> automatic truncation of author names and short words.

That's a good question.

I suppose we'd have to look at how QueryStemming works. At a glance, it only
adds right truncation if it was able to stem the operand I think.

I think Zebra takes care of manually handling "operand*" type queries...

So yeah... I don't know about automatic truncation. I think some users expect
it, so they might do a query like "au:fish" and expect to get back results for
"Fishburne" as well as "Fisher". 

If you had QueryStemming on, I doubt "fish" would produce a stemmed operand
since it's already a stem, so that probably wouldn't work unless you had
automatic right truncation.

That said, I don't know if that's a good thing... I personally think explicit
truncation/wildcarding is a better idea..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 05:12:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 03:12:16 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-BtJ2SQtbqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #40 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #39)
> Patches still apply - can we rescue this? 
> 
> The only left obstacle appears to be a missing unit test. Looking at
> comment#38 from David - could this be a possible way?

I reckon that method I suggested would be a good test. It would be nice to
rescue this one. While I don't think it'll be used by many, it would be good to
get it in for the sake of CCSR and anyone else afflicted by this issue (or
anyone wanting to customize their queries I suppose).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 05:31:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 03:31:03 +0000
Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as
 dbadmin should be prevented pre-emptively
In-Reply-To: <bug-17218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17218-70-w2xrE4sIrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 06:19:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 04:19:43 +0000
Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu
 16.04 and MySQL 5.7
In-Reply-To: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16583-70-SDq8l85XQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

Nabila <lovenabila at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lovenabila at gmail.com

--- Comment #5 from Nabila <lovenabila at gmail.com> ---
The Ubuntu 16.04 LTS is not supporting a fresh installation of Koha. I had to
revert back to 14.04 LTS and then install a copy which worked for me. I have
not tried yet to upgrade the existing Koha Installation of Ubuntu 14.04 LTS to
upgrade to 16.04.

The error not comes in Acquisition Module but also the following:

-- Cannot create New Vendor in Acquisition (Doesn't save the record instead
searches the vendor)
-- Cannot do the Batch Patron Import (Shows error in DBI.pm file)
-- Cannot create any entry that requires Auto Increment of Primary Key.
-- Does not load default framework of Cataloging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 07:50:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 05:50:33 +0000
Subject: [Koha-bugs] [Bug 17225] Search using ISBN13 should find ISBN10 (and
	vice versa).
In-Reply-To: <bug-17225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17225-70-wymKVXQevw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17225

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
This should be already possible, if you turn on SearchWithISBNVariations and
make sure UseQueryParser is off:

http://translate.koha-community.org/manual/16.05/en/html-desktop/#SearchWithISBNVariations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:20 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-rGxeECe0iP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |16175, 14571


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571
[Bug 14571] using_https check for ssl connections doesn't work in some
situations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16175
[Bug 16175] Amazon book covers should use https on public and private lists in
the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:20 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn' t work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-zERgYErp2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:20 +0000
Subject: [Koha-bugs] [Bug 16175] Amazon book covers should use https on
 public and private lists in the OPAC
In-Reply-To: <bug-16175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16175-70-wXysk8FWFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16175

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:55 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-RF3D8V0h0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15518, 14523, 11358


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358
[Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523
[Bug 14523] Google jackets being blocked when OPAC using HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518
[Bug 15518] Intranet detail needs ssl sources for Amazon images
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:55 +0000
Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when
 using HTTPS in Koha.
In-Reply-To: <bug-11358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11358-70-HwjBHgZqQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:55 +0000
Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC
	using HTTPS
In-Reply-To: <bug-14523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14523-70-skz2FTSKGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 09:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 07:42:55 +0000
Subject: [Koha-bugs] [Bug 15518] Intranet detail needs ssl sources for
	Amazon images
In-Reply-To: <bug-15518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15518-70-I9tM5IWe4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 10:37:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 08:37:49 +0000
Subject: [Koha-bugs] [Bug 7441] Search results showing wrong branch
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-T7oZR3WUEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This has been backported to 3.22.x and 16.05.x but without the IGNORE keyword
in the INSERT pref statement: it will lead to error on upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 10:46:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 08:46:17 +0000
Subject: [Koha-bugs] [Bug 17228] New: Make two versions of SIPconfig.xml
	identical
Message-ID: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

            Bug ID: 17228
           Summary: Make two versions of SIPconfig.xml identical
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Packaging
          Assignee: magnus at libriotech.no
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

We have two versions of SIPconfig.xml: 

etc/SIPconfig.xml
debian/templates/SIPconfig.xml

The former has been updated with some changes to the possible configuration of
SIP2 servers, e.g. by bug 15006. The latter has not been updated with the same
information.

Since debian/templates/SIPconfig.xml contains no special placeholders or
variables, this bug proposes to simply copy etc/SIPconfig.xml to
debian/templates/SIPconfig.xml, so that admins using the packages will see an
up-to-date SIP2 config example when they have enabled SIP2 for a site.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:07:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:07:24 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-aqFOs6xN27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:07:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:07:26 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-Kn6cDMFi1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 55051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55051&action=edit
Bug 17228 - Make two versions of SIPconfig.xml identical

Several bugs have made changes to etc/SIPconfig.xml but not
updated debian/templates/SIPconfig.xml. This means that an admin
using the Debian packages who enables SIP2 for a site and looks at
/etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date
version of that file, with the risk of missing possible config
opportunities.

Since debian/templates/SIPconfig.xml contains no placeholders or
other magic stuff related to the Debian packaging, this patch simply
copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml

To test:
$?diff etc/SIPconfig.xml debian/templates/SIPconfig.xml
There should be no difference between the files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:08:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:08:20 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-9m4bvHkC71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55051|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:09:42 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-pYlBueqwQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 55052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55052&action=edit
Bug 17228 - Make two versions of SIPconfig.xml identical

Several bugs have made changes to etc/SIPconfig.xml but not
updated debian/templates/SIPconfig.xml. This means that an admin
using the Debian packages who enables SIP2 for a site and looks at
/etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date
version of that file, with the risk of missing possible config
opportunities.

Since debian/templates/SIPconfig.xml contains no placeholders or
other magic stuff related to the Debian packaging, this patch simply
copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml

To test:
$?diff etc/SIPconfig.xml debian/templates/SIPconfig.xml
There should be no difference between the files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:10:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:10:25 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-AAIRxRPVj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55052|0                           |1
        is obsolete|                            |

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 55053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55053&action=edit
Bug 17228 - Fix whitespace in etc/SIPconfig.xml

Remove trailing whitespace and replace tabs with 4 spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:10:45 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17228-70-NvrgYIgdJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228

--- Comment #4 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 55054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55054&action=edit
Bug 17228 - Make two versions of SIPconfig.xml identical

Several bugs have made changes to etc/SIPconfig.xml but not
updated debian/templates/SIPconfig.xml. This means that an admin
using the Debian packages who enables SIP2 for a site and looks at
/etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date
version of that file, with the risk of missing possible config
opportunities.

Since debian/templates/SIPconfig.xml contains no placeholders or
other magic stuff related to the Debian packaging, this patch simply
copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml

To test:
$?diff etc/SIPconfig.xml debian/templates/SIPconfig.xml
There should be no difference between the files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:23:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:23:45 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-d1GCsPzYYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #14 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Benjamin, you were right about the items that were added to all biblios. Here's
a patch that fixes that.

However, when testing, my budgets are always selected when they exist. In your
case, they are in the dropdown list, but not automatically selected, is that
correct? 
You have to use the budget code in your file, and not the budget name. Are you
using the budget code?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:26:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:26:36 +0000
Subject: [Koha-bugs] [Bug 16975] DSA-3628-1 perl -- security update
In-Reply-To: <bug-16975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16975-70-PKD8st6r9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16975

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
         Resolution|---                         |FIXED
            Product|Koha security               |Koha
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
              Group|Koha security               |
           Assignee|chris at bigballofwax.co.nz    |gmcharlt at gmail.com
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:31:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:31:29 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-8swpgL1wlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53493|0                           |1
        is obsolete|                            |

--- Comment #15 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 55057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55057&action=edit
Bug 15503: Grab Item Information from Order Files

 - Fix adding multiple items in multiple biblios.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:32:21 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-uS4sjkFHp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53493|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:32:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:32:46 +0000
Subject: [Koha-bugs] [Bug 16958] opac-imageviewer.pl is vulnerable to XSS
In-Reply-To: <bug-16958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16958-70-zDBFI5TBr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16958

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
              Group|Koha security               |
            Product|Koha security               |Koha
         Resolution|---                         |FIXED
          Component|Koha                        |OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:35:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:35:23 +0000
Subject: [Koha-bugs] [Bug 17022] branchtransfers.pl is vulnerable to XSS
	attacks
In-Reply-To: <bug-17022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17022-70-u3LtdMZoVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17022

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Koha                        |Staff Client
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
             Status|Pushed to Stable            |RESOLVED
              Group|Koha security               |
            Product|Koha security               |Koha
                 CC|                            |gmcharlt at gmail.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:41:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:41:22 +0000
Subject: [Koha-bugs] [Bug 17026] checkexpiration.pl is vulnerable to XSS
	attacks
In-Reply-To: <bug-17026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17026-70-xYpCOKBZGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17026

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
             Status|Pushed to Stable            |RESOLVED
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
         Resolution|---                         |FIXED
            Product|Koha security               |Koha
          Component|Koha                        |Serials
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:42:27 +0000
Subject: [Koha-bugs] [Bug 17028] request.pl is vulnerable to XSS attacks
In-Reply-To: <bug-17028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17028-70-z8Zmfma61t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17028

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
             Status|Pushed to Stable            |RESOLVED
              Group|Koha security               |
                 CC|                            |gmcharlt at gmail.com
            Product|Koha security               |Koha
          Component|Koha                        |Hold requests
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:43:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:43:05 +0000
Subject: [Koha-bugs] [Bug 17029] *detail.pl are vulnerable to XSS attacks
In-Reply-To: <bug-17029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17029-70-CJ6LPgJwZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17029

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
             Status|Pushed to Stable            |RESOLVED
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
              Group|Koha security               |
          Component|Koha                        |Searching
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:44:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:44:31 +0000
Subject: [Koha-bugs] [Bug 17036] circulation.pl is vulnerable to XSS attacks
In-Reply-To: <bug-17036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17036-70-xopc8buHXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17036

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Koha                        |Circulation
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
            Product|Koha security               |Koha
              Group|Koha security               |
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 11:45:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 09:45:29 +0000
Subject: [Koha-bugs] [Bug 17038] search.pl is vulnerable to XSS attacks
In-Reply-To: <bug-17038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17038-70-UgIxhMsi2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17038

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
          Component|Koha                        |Searching
              Group|Koha security               |
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 12:24:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 10:24:14 +0000
Subject: [Koha-bugs] [Bug 16744] new records not indexed if using a
 customize Koha Framework
In-Reply-To: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16744-70-wlZYS1peWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Hugo Agud <hagud at orex.es> ---
on a koha 16.05.03 fresh install on debian jessy and plack enabled we have
applied the test procedure and the bug is fixed with bug 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 12:25:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 10:25:27 +0000
Subject: [Koha-bugs] [Bug 16744] new records not indexed if using a
 customize Koha Framework
In-Reply-To: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16744-70-G5gO0o1ZkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16431

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 12:25:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 10:25:27 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-26ce2jO1Yr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16744

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:06:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:06:46 +0000
Subject: [Koha-bugs] [Bug 12629] Software error when trying to merge records
 from different frameworks
In-Reply-To: <bug-12629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12629-70-Y8YUZHG3B5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:23:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:23:23 +0000
Subject: [Koha-bugs] [Bug 17145] Cannot upload .mrc file for staging Marc
	records
In-Reply-To: <bug-17145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17145-70-Kfklc5Nuhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17145

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
Try ro send the request tom the mailming list :
https://lists.katipo.co.nz/mailman/listinfo/koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:49:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:49:28 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-Yy2pfzMJXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54973|0                           |1
        is obsolete|                            |

--- Comment #5 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 55058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55058&action=edit
Bug 17215 - converted tabs to whitespace

To test:
1. Set the autoMemberNum System Preference to "Don't".
2. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
3. Check the patron record's cardnumber.
4. the cardnumber should equal the patron's LDAP username.
5. Delete the patron record.
6. Apply the patch.
7. Set the autoMemberNum System Preference to "Do".
8. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
9. Check the patron record's cardnumber.
10. The cardnumber should now be the next highest cardnumber based on
autoMemberNum.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:50:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:50:36 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-OiQw8WS8Pa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:55:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:55:49 +0000
Subject: [Koha-bugs] [Bug 16744] new records not indexed if using a
 customize Koha Framework
In-Reply-To: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16744-70-7XJoygGEAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16431                   |
         Resolution|FIXED                       |DUPLICATE

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 16431 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 14:55:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 12:55:49 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-nOauPhVe0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16744                   |
                 CC|                            |hagud at orex.es

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 16744 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 15:33:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 13:33:44 +0000
Subject: [Koha-bugs] [Bug 17229] New: ILS-DI HoldTitle and HoldItem should
 check if patron is expired
Message-ID: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

            Bug ID: 17229
           Summary: ILS-DI HoldTitle and HoldItem should check if patron
                    is expired
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Web services
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

ILS-DI HoldTitle and HoldItem don't check patron category setting
BlockExpiredPatronOpacActions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 15:36:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 13:36:01 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-oyOq6zu6oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 55059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55059&action=edit
Bug 17229: Check if patron is expired in CanItemBeReserved

This way, calls to ILS-DI HoldTitle and HoldItem do this check too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 15:36:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 13:36:15 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-KBQVjKcCyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 15:39:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 13:39:38 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-hZ9eFmVyqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #7 from Barton Chittenden <barton at bywatersolutions.com> ---
09:34 < barton> I'm looking at bug 16581... I think there's still a number of
un-answered questions there...
09:34 < huginn> Bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581 enhancement, P5
- low, ---, 
                gmcharlt, RESOLVED WONTFIX, ICU tokenization bug in idzebra-2.0
2.0.59-1
09:35 < marcelr> barton: i did not understand why it was closed either

09:36 < barton> so here are the things that I'm wondering about: 1) is it
possible to require the use of the 
                indexdata repo? 2) what version of idzebra-2.0 *should* we be
using?
09:37 < mtompset> 1) why not? It's a good idea, 2) the current one -- I think
something 62?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 15:52:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 13:52:26 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-ITou4lWONA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 55060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55060&action=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:00:21 +0000
Subject: [Koha-bugs] [Bug 16549] Remove the use of "onclick" from header
	search forms
In-Reply-To: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16549-70-tLPFJkk6m3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Colin Campbell from comment #6)
> This patch appears to introduce a bug reverting previous behaviour.

This should be fixed by Bug 16903, which says it has been pushed to master but
I don't think it really has been.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:05:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:05:35 +0000
Subject: [Koha-bugs] [Bug 16903] Multiple class attributes on catalog search
	tab
In-Reply-To: <bug-16903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16903-70-QpMigUF2gq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Was this really pushed (with thx to mtompset) ??

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:30 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ziYqZH5Xvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54862|0                           |1
        is obsolete|                            |

--- Comment #101 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55062&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:24 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-cQvvdA6VVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54861|0                           |1
        is obsolete|                            |

--- Comment #100 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55061&action=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %]<option selected="selected">[% ELSE %]<option>[% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- tools/export.pl

Notes for QA:
- There are 2 FIXMEs in the patch set, I have kept the existing behavior,
but I am not sure it's the good one. Feel free to open a bug report and
I will fill a patch if you think it's not correct. Otherwise, remove the
FIXME lines in a follow-up patch.
- The whole patch set is huge and makes a lot of changes.
But it finally will tremendously reduce the number of lines:
716 insertions for 1910 deletions

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:35 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-V2WwZZlROQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54863|0                           |1
        is obsolete|                            |

--- Comment #102 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55063&action=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:40 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-Z6SOP1rzVt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54864|0                           |1
        is obsolete|                            |

--- Comment #103 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55064&action=edit
Bug 15758: Koha::Libraries - Remove GetBranches

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:50 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-PFn4UHRu6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54866|0                           |1
        is obsolete|                            |

--- Comment #105 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55066&action=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:45 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-wG2ka2zDA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54865|0                           |1
        is obsolete|                            |

--- Comment #104 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55065&action=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:10:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:10:55 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-nr1nvwgRru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54867|0                           |1
        is obsolete|                            |

--- Comment #106 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55067&action=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:01 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-Bu0PJttb0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54868|0                           |1
        is obsolete|                            |

--- Comment #107 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55068&action=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:06 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-d6nvAYgSZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54908|0                           |1
        is obsolete|                            |

--- Comment #108 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55069&action=edit
Bug 15758: [QA Follow-up] Remove onlymine from Plugin/Branches.pm

Hard to miss that one:
Template process failed: plugin error - Bareword "C4::Branch::onlymine" not
allowed while "strict subs" in use at Koha/Template/Plugin/Branches.pm line 59.
Compilation failed in require at /usr/lib/perl5/Template/Plugins.pm line 206.

Removed OnlyMine from Plugin/Branches. Replaced by a template var in
cleanborrowers; it was used only once.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:11 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-m7d2xIDhsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54909|0                           |1
        is obsolete|                            |

--- Comment #109 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55070&action=edit
Bug 15758: [QA Follow-up] Some corrections related to GetBranchName

[1] Acquisition.pm
The lines filling $row in GetBasketGroupAsCSV may have side-effects when
the library name is not found. This change restores former behavior. Just
theoretically more safe.
Note that it also contained a typo: $row->{deliveryplace} should have been
$row->{$place}.

[2] Auth.pm
checkauth: $branchname = Koha::Libraries->find($branchcode)->branchname;
Should normally be fine, but I rather have an empty string here than
crashing on "Can't call method branchname on undefined value".
Same for sub check_api_auth.
Note that this holds for a larger number of calls, but I am adding a check
here because it is checkauth.
Also removed a duplicate use Koha::Libraries-statement.

[3] Search.pm
Also removed a duplicate use statement for Libraries.

[4] svc/holds
Added an (explicit) use statement for Koha::Libraries.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:16 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-y8ZSbvtOVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54921|0                           |1
        is obsolete|                            |

--- Comment #110 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55071&action=edit
Bug 15758: [QA Follow-up] Corrections related to GetBranches

[1] C4/Search
A call to Koha::Libraries is added to routine pazGetRecords, but the
results of that call are not used. So removing it again.

[2] catalogue/itemsearch.pl
Although A=>B=>C=>D works, we'd better use here A=>B, C=>D.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:20 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-B6BZd6asjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54925|0                           |1
        is obsolete|                            |

--- Comment #111 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55072&action=edit
Bug 15758: Fix variable name, it's a branchcode

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:11:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:11:26 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-ks5Wk0Pgwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #112 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 55073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55073&action=edit
Bug 15758: [QA Follow-up] Final touch?

>From qa tools:
reports/cat_issues_top.pl: pod: =over on line 39 without closing =back

Note: qa tools does also report "options_for_libraries: not found" on two
template includes. Considering this as a false alarm, since the block is
defined in another include loaded in doc-head-open.
[1] koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
[2] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc

Found a template where a USE Branches was missing:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Easy to spot since the libraries combo was empty.
Tried to find similar occurrences with few greps, but couldn't find any.

I did find duplicate USE Branches though in:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
This patch removes them.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:14:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:14:43 +0000
Subject: [Koha-bugs] [Bug 17230] New: borrowers table should be better
	normalized
Message-ID: <bug-17230-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17230

            Bug ID: 17230
           Summary: borrowers table should be better normalized
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

I've always been bothered by the fact that we have 3 separate sets of contact
information in the borrowers table:

streetnumber    
streettype                
address    
address2    
city    
state    
zipcode    
country    
email    
phone    

B_streetnumber
B_streettype
B_address
B_address2
B_city
B_state
B_zipcode
B_country
B_email
B_phone

altstreetnumber
altstreettype
altaddress
altaddress2
altcity
altstate
altzipcode
altcountry
altemail
altphone

These should be moved to a contacts table, which contains a 'contact_type'
field corresponding to 'primary', 'B_' or 'alt' (although these also
desperately need to be renamed), as well as a link to the borrower and a
timestamp.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:15:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:15:32 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-CtZT8mINlL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #113 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Final comments:
Good job, Jonathan.
Code looks good to me. Hard to test every corner. Hopefully we tackled most
issues now.
See also comments in last commit message.

RM: Please push 15407 + this one 15758 now early to have some more test
coverage and prevent rebasing.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:39:29 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-rO3B4W6yWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #27 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 55074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55074&action=edit
Bug 17135 - Some minor changes & fixes in the script

- all non-fatal output redirected to STDOUT (as there is an intention
    to run this script from updatedatabase.pl)
    - added borrowernumber and itemnumber equality checks to the SELECT
    statement in getFinesForChecking() - accountlines.issue_id alone is not
    entirely trustworthy (because InnoDB forgets it's highest auto_increment
    after server restart), in some rare cases it may point to some random
    issue for different patron and different item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:41:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:41:46 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-po6UFfCJ2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55074|0                           |1
        is obsolete|                            |

--- Comment #28 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 55075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55075&action=edit
Bug 17135 - Some minor changes & fixes in the script

- all non-fatal output redirected to STDOUT (as there is an intention
to run this script from updatedatabase.pl)

- added borrowernumber and itemnumber equality checks to the SELECT
statement in getFinesForChecking() - accountlines.issue_id alone is not
entirely trustworthy (because InnoDB forgets it's highest auto_increment
after server restart), in some rare cases it may point to some random
issue for different patron and different item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 16:47:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 14:47:40 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-8qFodEXRnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #29 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #26)

> You could also think of running the script via updatedatabase?

Sounds like a good idea, and there are some precedences for that in
updatedatabase (3.01.00.053, 3.01.00.107). I'll give it a try.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 17:00:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 15:00:23 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-TZK3BZFU7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #22 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
(In reply to David Cook from comment #21)
> (In reply to Fridolin SOMERS from comment #20)
> > How is this different from enabling "QueryStemming" ?
> > Automatic truncation can lead to huge number of results, consider the
> > automatic truncation of author names and short words.
> 
> That's a good question.
> 
> I suppose we'd have to look at how QueryStemming works. At a glance, it only
> adds right truncation if it was able to stem the operand I think.
> 
> I think Zebra takes care of manually handling "operand*" type queries...
> 
> So yeah... I don't know about automatic truncation. I think some users
> expect it, so they might do a query like "au:fish" and expect to get back
> results for "Fishburne" as well as "Fisher". 
> 
> If you had QueryStemming on, I doubt "fish" would produce a stemmed operand
> since it's already a stem, so that probably wouldn't work unless you had
> automatic right truncation.
> 
> That said, I don't know if that's a good thing... I personally think
> explicit truncation/wildcarding is a better idea..

Seems that QueryStemming does right truncation even if AutomaticTruncation is
disabled
provided that QueryWeightField is on
example in Lyon3.
searching the terms "fonction hypothese" in our OPAC (configured with
AutomaticTruncation on, Querystemming and QueryWeightfield off) get 2 results :
https://catalogue.univ-lyon3.fr/cgi-bin/koha/opac-detail.pl?biblionumber=373203
https://catalogue.univ-lyon3.fr/cgi-bin/koha/opac-detail.pl?biblionumber=57190

Note that the term "fonction" exists nowhere as such in the 2 records.

In our test instance, with QueryStemming and QueryWeightField on, Autotruncate
off, we get these 2 results allthesame.
But with QueryStemming on, QueryWeightField and Autotruncate off : no results.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 17:21:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 15:21:13 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-VcsTUH9qax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #9 from Lee Jamison <ldjamison at marywood.edu> ---
Owen,

Thank you for the constructive criticism! This was my very first attempt at a
bug report so I'm still learning. I made a note to myself to make your
suggestions a habit from now on! I'll make necessary changes then re-submit.

For my own knowledge, when I upload the update, should I put the status to
Needs Signoff? Or Signed Off? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 17:52:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 15:52:54 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-4aSblsZOkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Lee Jamison from comment #9)
> For my own knowledge, when I upload the update, should I put the status to
> Needs Signoff? Or Signed Off? Thanks!

Set the status back to "needs signoff" so that everyone knows it is ready for
testing again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 18:10:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 16:10:28 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-xdVyoHHxWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
The value is no longer copied, but neither is the subfield code

Example:
I copy 260$b
I get a new blank 260$_ (though the field description states "Name of
publisher, distributor, etc"

We should copy the subfield code but not the contents

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 18:57:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 16:57:54 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14060-70-dCf1JZ8Vct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #50 from Nick Clemens <nick at bywatersolutions.com> ---
This all works very well, I can't enter any errors, I can press enter with an
invalid date, but it reads it as empty so that seems okay.

My one complaint would be that if you click into the datepicker, and decide not
to enter a date you should not receive the warning. That is, closing on an
empty value should not warn

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 19:20:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 17:20:00 +0000
Subject: [Koha-bugs] [Bug 17231] New: HTML5MediaYouTube should recognize
 youtu.be links from youtube as well at the full links
Message-ID: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231

            Bug ID: 17231
           Summary: HTML5MediaYouTube should recognize youtu.be links from
                    youtube as well at the full links
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
With HTML5MediaYouTube enabled and WWW::YouTube::Download installed add an 856
to a record like:
https://www.youtube.com/watch?v=tu0qtEwb9gE
and not the media player works
then use a link like:
https://youtu.be/tu0qtEwb9gE
And note there is no media player

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 19:41:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 17:41:54 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
 links from youtube as well at the full links
In-Reply-To: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17231-70-0ec0lrWKtt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 19:41:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 17:41:56 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
 links from youtube as well at the full links
In-Reply-To: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17231-70-zZhLVw9cye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 55076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55076&action=edit
Bug 17231 - HTML5MediaYouTube should recognize youtu.be links from youtube as
well at the full links

To test:
Enable HTML5MediaYouTube and ensure WWW::YouTube::Download is installed
Add an 856$u to a record like: https://www.youtube.com/watch?v=tu0qtEwb9gE
Verify you can see the embedded player
Use the youtube shortened like (from the share button) like:
https://youtu.be/tu0qtEwb9gE
Verify you can see the embedded player

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 19:42:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 17:42:19 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
 links from youtube as well at the full links
In-Reply-To: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17231-70-Ec9JHAHI6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 20:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 18:01:06 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17135-70-rIoIIl8B32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #30 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 55077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55077&action=edit
Bug 17135 - Maintenance script execution added as part of an atomic DB upgrade

(plus warnings for 16.05+ production setups possibly already affected)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 21:26:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 19:26:06 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-PwMRrxdB5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #16 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Matthias Meusburger from comment #14)
> Benjamin, you were right about the items that were added to all biblios.
> Here's a patch that fixes that.
> 
> However, when testing, my budgets are always selected when they exist. In
> your case, they are in the dropdown list, but not automatically selected, is
> that correct? 
> You have to use the budget code in your file, and not the budget name. Are
> you using the budget code?

Mathias, I believe we were using the budget code, yes. We have tested again and
now it appears to be mapping properly and creating items properly. Funds are
encumbered as expected. 

However, and this might be tangential, the authorized value does not appear to
be updating when either creating the items or receiving them. Currently
acquisitions would place a record in an Ordered NOT_LOAN status. This may be a
local script, but it does not appear to be syspref. When we create an order
using acquisitions in the sandbox, the items appear as available. Additionally,
if we do set  AcqItemSetSubfieldsWhenReceived in the system preferences,
receiving the items does not seem to update the subfields. I know this works in
production, but does appear broken here.

Additionally, the how is the itype field being populated? If it's not in the
record, does it simply list the top item (I notice that it doesn't actually
apply the item type when the item is created, but the field is populated in the
item import view).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 21:32:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 19:32:45 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-GK6jf70qVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 21:32:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 19:32:47 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-kRFpkgm0g1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54996|0                           |1
        is obsolete|                            |

--- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 55078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55078&action=edit
Bug 17152: (counter-patch)Do not copy value when duplicating a subfield

When cataloguing, if you want to duplicate a subfield that is not
empty, the new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is
created with subfields but without data in it.

Test plan:
Add or edit a bibliographic record
Fill a subfield
Duplicate the subfield
=> Without this patch the value of the input will be copied
=> With this patch the new input will be emptied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 21:36:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 19:36:00 +0000
Subject: [Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the
	data
In-Reply-To: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17152-70-T3XLO0oMoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55078|0                           |1
        is obsolete|                            |

--- Comment #5 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 55079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55079&action=edit
Bug 17152: (counter-patch)Do not copy value when duplicating a subfield

When cataloguing, if you want to duplicate a subfield that is not
empty, the new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is
created with subfields but without data in it.

Test plan:
Add or edit a bibliographic record
Fill a subfield
Duplicate the subfield
=> Without this patch the value of the input will be copied
=> With this patch the new input will be emptied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Aug 31 22:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 20:57:27 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-SfMAZdMEZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |mirko at abunchofthings.net

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Adding Mirko to the discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.