[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 53725
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53725
Bug 16585: Update Italian installer sample files for 16.05

Review of attachment 53725:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16585&attachment=53725)
-----------------------------------------------------------------

::: installer/data/mysql/it-IT/necessari/notices.sql
@@ +7,5 @@
>  ('circulation','DUEDGST','Avviso restituzione (digest)','Avviso restituzione (digest)','Hai <<count>> prestiti da retituire', 'email'),
>  ('circulation','PREDUE','Preavviso scadenza prestito','Preavviso scadenza prestito','Salve <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nQuesti prestiti stanno per scadere:\r\n\r\n<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)', 'email'),
> +('circulation','PREDUEDGST','Preavviso scadenza prestiti (digest)','Avviso copie in scadenza','Gentile <<borrowers.firstname>> <<borrowers.surname>>,
> +Il prestito dei seguenti volumi sta per scadere:
> +

You should use \r\n to line breaks.

::: installer/data/mysql/it-IT/necessari/sample_frequencies.sql
@@ +1,2 @@
>  INSERT INTO subscription_frequencies
> +    (id, description, displayorder, unit, unitsperissue, issuesperunit)

Why do you force the id?

::: installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql
@@ +1,2 @@
>  INSERT INTO subscription_numberpatterns
> +    (id, label, displayorder, description, numberingmethod,

Same here.

::: installer/data/mysql/it-IT/necessari/system_preferences.sql
@@ +20,4 @@
>  UPDATE systempreferences SET value = '1' WHERE variable = 'AllowRenewalLimitOverride';
>  UPDATE systempreferences SET value = 'annual' WHERE variable = 'autoBarcode';
>  UPDATE systempreferences SET value = 'email' WHERE variable = 'AutoEmailPrimaryAddress';
> +UPDATE systempreferences SET value = '1' WHERE variable = 'BiblioAddsAuthorities';

The changes in this file seems very specific but nobody complain until now, so
that should be ok.

-- 
You are receiving this mail because:
You are watching all bug changes.