[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53856|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 53884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53884&action=edit
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit
templates

This patch removes the use of event attributes like "onclick" from the
serial collection and serial edit templates. Events are now defined in
JavaScript.

Also changed: Converted "create routing list," "edit routing list," and
"Renew" links to Bootstrap buttons. The "select all" and "clear all"
links have Font Awesome icons added.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
    "Multi receiving" button works correctly.
- For any subscription, test that the "Generate next" button works
  correctly.
- In each tab, test that the "select all" and "clear all" links work
  correctly.
- On a subscription which has expired, test that the "Renew" button
  works correctly.
- On the serial collection page, select multiple issues and click the
  "Edit serials" button.
  - Testing with a subscription for which an item record is NOT created
    when receiving:
    - Changing the status to "Arrived" or "Claimed" should change the
      "Expected on" date to today's date. Selecting any other status
      should leave the "expected on" date as it was or return it to its
      original value.
    - Test that the "Multi receiving" button works correctly.
  - Testing with a subscription for which an item record IS created when
    receiving:
    - Changing the status of an issue should work as above but should
      also trigger the appearance of the item add form when the status
      is "Arrived" or "Claimed," and hide the form otherwise.
    - Cliking the "Item" link at the top of the item add form should
      hide it.
    - Clicking the "Add item" link under any issue should display the
      item add form.
    - In the item add form, test that repeatable fields are correctly
      duplicated when you click the "clone" button.
    - On the "Supplemental issue" line, changing the status to "Arrived"
      should work as described above. Changing the status on this line
      to "Claimed" should only change the "Expected on" date.
    - Adding regular and supplemental issues should work correctly.

Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
  Works as described.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.