[Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick code review:

1/ The default value for the new pref should be "off"

2/ Tabulation chars should be replaced with 4 tabs

3/ $tmp is rarely a correct variable name :)

4/ Additional fields are displayed (but not taken into account) on the mana
subscriptions search form

5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead

6/ Share> "Language of your sharing" is hidden on the right.

7/ "The export is done, thank you for your contribution." => It should not be
yellow (alert) but green (message)

-- 
You are receiving this mail because:
You are watching all bug changes.