[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #55)

Excellent testing session Owen :)

> I've done a lot of testing now and have only run into small problems:
> 
> These pages have a sidebar filter which includes a library selector but no
> libraries are listed:
> 
> -  acqui/invoices.pl
> -  admin/aqbudgets.pl
> -  opac/opac-topissues.pl
> -  serials/serials-search.pl
> 
> These pages don't show the patron's library in the sidebar:
> 
> -  members/discharge.pl
> -  members/member-flags.pl
> -  members/member-password.pl

Everything fixed.
members/discharge.pl was actually moremember.pl

> Other issues:
> 
> - In both the staff client and OPAC, library names don't appear in the
> facets. Instead there is a list of asterisks.

Erk, I missed something in one rebase. Fixed now.

> -  admin/clone-rules.pl -- When you submit a library to clone rules to, the
> next step asks you to select a library. Your original selection seems to be
> getting lost.
> 
> - circ/returns.pl -- When a hold is found, the line at the bottom of the
> dialog, "Hold at [library]" shows the library code instead of name.

Fixed!

> - members/paycollect.pl -- Doesn't show patron category description in the
> sidebar (maybe that's from Bug 15407?)

In master, will fix it separately.

> - reports/guided_reports.pl -- When running an SQL report which uses the
> <<branches>> placeholder, the libraries are shown in order by code rather
> than name.
> 
> - tools/holidays.pl -- The library name doesn't appear in the page heading.

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.