[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

--- Comment #11 from Bob Birchall <bob at calyx.net.au> ---
(In reply to Kyle M Hall from comment #7)
> Created attachment 53920 [details] [review]
> Bug 16960 - Patron::Modifications should be fixed
> 
> The changes from opac-memberentry do not reach the table, since the
> Patron::Modifications object does not work well.
> 
> Test Plan:
> 1) Apply this patch
> 2) Create some patron modification requests
> 3) Ensure you can approve and deny modifications
> 4) Ensure patron self registration works

I wasn't completely sure what the test plan was asking for.  This is what I
did:
- logged in to OPAC and changed some personal details;
- logged in to staff client and accepted the changes; on searching for the
patron the changes are present;
- enabled self registration and registered in OPAC as a new patron; logged in
as that patron OK; checked in staff - all details present;
- logged in to OPAC again, made more changes to Personal Details; returned to
Staff client and Denied those changes - on searching none of the data is
amended.  OK.

I'll sign off on this.  I'm having an issue with git so but will get some help.

-- 
You are receiving this mail because:
You are watching all bug changes.