[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

--- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me. Tested selectively. Especially checked the code
carefully; hard to test everything in limited time. With a quick push we will
have some time before release to fix one or two things if needed. The number of
follow-ups here shows that we already found some. Bonus points for the rest.

Patch 3
It will probably work most of the time, but we assume often here that the find
returned a record and access its columns rightaway without checking.

Patch 4
admin/patron-attr-types.pl: Why collecting first in scalar context and later in
list context ? Seeing no difference, just slightly inconsistent..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.