[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54260|0                           |1
        is obsolete|                            |
  Attachment #54312|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 54478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54478&action=edit
Bug 17100: Do not display payments if patron has nothing to pay

This alternative patch moves logic and formatting to the template file.

To test:
* without patch
  1/ find a patron with no lines in accountlines table : print summary shows no
"account fines and payments" => OK
  2/ find a patron with some lines in accountlines table and the total amount >
0 : print summary shows a table "account fines and payments" with fines to
recover => OK
  3/ find a patron with some lines in accountlines table but the total amount =
0 : print summary shows a table "account fines and payments" with nothing in it
=> NOK

* with the patch, same cases as before :
  1/ same as without patch
  2/ same as without patch
  3/ print summary does not show "account fines and payments"

- Additionally, verify that formatting follows syspref 'CurrencyFormat'
- Verify that amount column is right-aligned

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.