[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 15 16:14:53 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marc Véron from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > Comment on attachment 54312 [details] [review] [review]
> > [SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print
> > 
> > Review of attachment 54312 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
> > @@ +105,4 @@
> > >              </tr>
> > >  
> > >              [% FOREACH account IN accounts %]
> > > +                [% IF ( account.amountoutstanding < 0 ) || ( account.amountoutstanding > 0 ) %]
> > 
> > Marc, why did you replace
> >   next if amount == 0
> > with this lines?
> 
> It did not work with amount == 0 because the amount comes as '0.00' (not
> sure how much decimals tough)

It's because you compared string "0.00", instead of integer 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list