[Koha-bugs] [Bug 13736] Enable EDS Plugin Patch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 42894
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42894
EDS Plugin Patches Code checks to see if  setting EDSEnabled is ON and
integrates the EDS Plugin to the Opac

Review of attachment 42894:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13736&attachment=42894)
-----------------------------------------------------------------

I'm pretty sure something jquery/ajax-y could be written to get the plugin to
accomplish the same thing. I too, like Katrin in comment #4, have some
misgivings about this implementation.

::: C4/Auth.pm
@@ +471,4 @@
>              AuthorisedValueImages                 => C4::Context->preference("AuthorisedValueImages"),
>              BranchesLoop                          => GetBranchesLoop($opac_name),
>              BranchCategoriesLoop                  => GetBranchCategories( 'searchdomain', 1, $opac_name ),
> +	    EDSEnabled                            => C4::Context->preference("EDSEnabled"),

Never needed.
Access [% Koha.Preference('EDSEnabled') %] in template files.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
@@ +48,4 @@
>      function _(s) { return s } // dummy function for gettext
>  </script>
>  <script type="text/javascript" src="[% interface %]/[% theme %]/lib/modernizr.min.js"></script>
> +[% IF ( EDSEnabled ) %]<script type="text/javascript" language="javascript" src="/plugin/Koha/Plugin/EDS/js/EDSScript.js"></script>[% END %]

Including a plugin javascript link should be possible in the OPACUserJS system
preference. Make sure to carefully add/remove as needed!

-- 
You are receiving this mail because:
You are watching all bug changes.