[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA
             Blocks|14695                       |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #4)
> > Kyle, the following test should fail without this patch:
> >   is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
> > );        
> > 
> > Could you please adapt it?
> 
> The test still passes.

They unit tests fail for me without the initial patch applied.

prove t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. 1/14 DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 'BIBLIONUMBER '557' AND
`ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND `ARRAY(0x88' at line 1 [for
Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`,
`me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`,
`me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`,
`me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`,
`me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`,
`me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype` FROM `reserves` `me`
WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND `ARRAY(0x8818f68)`
BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )" with ParamValues:
0='557', 1='140', 2='114'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1832.
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near 'BIBLIONUMBER '557' AND `ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND
`ARRAY(0x88' at line 1 [for Statement "SELECT `me`.`reserve_id`,
`me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`,
`me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`,
`me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`,
`me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`,
`me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`
FROM `reserves` `me` WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND
`ARRAY(0x8818f68)` BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )"
with ParamValues: 0='557', 1='140', 2='114'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 6/14 subtests

Test Summary Report
-------------------
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 65280 Tests: 8 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 14 tests but ran 8.
Files=1, Tests=8,  3 wallclock secs ( 0.02 usr  0.01 sys +  1.74 cusr  0.18
csys =  1.95 CPU)
Result: FAIL


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695
[Bug 14695] Add ability to place multiple item holds on a given record per
patron
-- 
You are receiving this mail because:
You are watching all bug changes.