[Koha-bugs] [Bug 17143] Popup Notification for decreaseloanhighholds preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16387

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I just added some information to bug 16387 that may be related to this.

1178         my $issuedate = DateTime->now( time_zone => C4::Context->tz() );
1179 
1180         my $calendar = Koha::Calendar->new( branchcode => $branch );
1181 
1182         my $itype =
1183           ( C4::Context->preference('item-level_itypes') )
1184           ? $biblio->{'itype'}
1185           : $biblio->{'itemtype'};
1186 
1187         my $orig_due = C4::Circulation::CalcDateDue( $issuedate, $itype,
$branch, $borrower );
1188 
1189         my $decreaseLoanHighHoldsDuration =
C4::Context->preference('decreaseLoanHighHoldsDuration');
1190 
1191         my $reduced_datedue = $calendar->addDate( $issuedate,
$decreaseLoanHighHoldsDuration );
1192 
1193         if ( DateTime->compare( $reduced_datedue, $orig_due ) == -1 ) {
1194             $return_data->{exceeded} = 1;
1195             $return_data->{duration} = $decreaseLoanHighHoldsDuration;
1196             $return_data->{due_date} = $reduced_datedue;

I think because the time index in $reduced_datedue isn't the same as the time
index in $orig_due, the two will never be equal, unless checked out at the time
indicated in the $org_due.  Therefore, if the original due date is in 14 days,
and reduced due date is set to 14 days, the two are not going to match because
of the time index.

I'm thinking that if the other bug is resolved, this will be as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387
[Bug 16387] Incorrect loan period calculation when using  decreaseLoanHighHolds
feature
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.