[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #48)
> (In reply to Katrin Fischer from comment #45)
> > > How to solve this? Can we remove the issue id in accountlines after
> > > switching to F? Or should UpdateFine no longer update a F record although it
> > > has the right issue id, but add a new record?
> > 
> > I think it should add a new line as it's a 'new fine'. If we differentiate
> > between F and FU cleanly, we can keep the issue_id too, I think?
> 
> Katrin has is exactly. If the same checkout goes overdue twice, the patron
> should have two separate fines ( and each one will show a different due date
> for the same checkout ).
> 
> This new followup will stop UpdateFine from updating closed out fines.

We are coming closer to a solution!
But please note that we need type F (imo) in the totalamount calculation and
the max fine reduction. We should focus on what happens next in UpdateFine.
The test $data->{'amount'} != $amount is not sufficient. Here we should exclude
type F somehow. But take care with $type that you get from CalcFine. It may not
be what you expect it to be ..

-- 
You are receiving this mail because:
You are watching all bug changes.