[Koha-bugs] [Bug 17167] New: Koha has two separate renewal responses

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Aug 23 17:17:59 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167

            Bug ID: 17167
           Summary: Koha has two separate renewal responses
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When checking an item out through SIP and the item has hit it's renewal limit,
Koha responds with "Item has reached maximum renewals", but when renewing an
item through SIP and the item has hit it's renewal limit, Koha responds with
"NO_MORE_RENEWALS: 1 ".

It doesn't make sense that there are different responses for essentially the
same thing, even though in this case it is technically two different processes.
 Also, the number 1 seems to have no purpose.  I increased the number of
renewals, and this number doesn't change, so I don't know what it is supposed
to be indicating.  This makes trapping renewal limits more tedious.  I would
recommend the following changes to these responses.

1. Have the checkout and renewal processes through SIP respond with the same
"Item has reached maximum renewals."
2. Note the period added to the end of the response.
3. Note the removal of the space at the end of the renewal response.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list