[Koha-bugs] [Bug 16912] Koha:: Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #3)
> Created attachment 53519 [details] [review]
> Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded

Tests failed:

prove t/db_dependent/Koha/Patrons.t 
t/db_dependent/Koha/Patrons.t .. 1/8 Violation of unique constraint in Category
at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.
Violation of unique constraint in Category at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.
Violation of unique constraint in Category at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201.

    #   Failed test 'New kid pay 5'
    #   at t/db_dependent/Koha/Patrons.t line 200.
    #          got: '0'
    #     expected: '5'

    #   Failed test 'Kid growing and become a juvenile, but shouldn't pay for
the upgrade '
    #   at t/db_dependent/Koha/Patrons.t line 206.
    #          got: '0'
    #     expected: '5'

    #   Failed test 'Kid growing and become a juvenile, he should pay 15'
    #   at t/db_dependent/Koha/Patrons.t line 215.
    #          got: '0'
    #     expected: '15'

    #   Failed test 'Juvenile growing and become an young adult, he should pay
35'
    #   at t/db_dependent/Koha/Patrons.t line 222.
    #          got: '0'
    #     expected: '35'
    # Looks like you failed 4 tests of 4.

#   Failed test 'add_enrolment_fee_if_needed'
#   at t/db_dependent/Koha/Patrons.t line 228.
# Looks like you failed 1 test of 8.
t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 8 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=8,  2 wallclock secs ( 0.03 usr  0.00 sys +  2.12 cusr  0.09
csys =  2.24 CPU)
Result: FAIL

The enrolment fee behaviour all works as expected, so happy to sign off once
the tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.