[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #75)
> IMO update database part from Bug 15675 is of no use here (and there is no
> need to check for duplicated FUs for the same item again, there shouldn't be
> any). What I think needs to be done:
> 
> 1) select the FU fine records that may need correction: for that we may need
> to compare a due date from issue record and the date on the end of the fine
> description - if the dates are the same, this is a correct FU record, no
> need to change anything in it
> 
> 2) if the dates are different, there are two possibilities:
> 
> 3.a) if the fine is not accruing / item is not currently due: it's an old
> fine record (either left unclosed by Bug 15675 or maybe patron renewed this
> item after Bug 15675 was applied in the production database; maybe it got
> overwritten in the meantime or maybe not, there is no easy way to tell): it
> needs to be closed (FU -> F)
> 
> 3.b) if the fine is accruing (item is due / CalcFine() returns a positive
> value): this is an old record which got overwritten: leave it as FU, but
> correct a due date in fine description.
> 
> What do you think?

Sounds good. But please open up a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.