[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 53699
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53699
Bug 12532 - Redirect guarantee email to guarantor

Review of attachment 53699:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=53699)
-----------------------------------------------------------------

Hi Maxime and Mehdi,

working on this again:

A) I am confused about some changes that seem unrelated to this feature - can
you please explain you explain and/or amend test plan? (see splitter comments
below)
B) Is it correct that ACCTDETAILS and RLIST have been dropped from this patch
set? (comparing comment#1 to code and syspref description)

C) I'd also like to take into account Kyle's earlier comment#28:

>1) Should this be a blanket setting? Maybe the parent of an 8 year old would want this, but not the parent of a 17 year old
I agree with Kyle here, having this as a global setting will not match the
needs of every library. But I think moving from global to more granular should
be possible later without any regressions, so for me this is not a blocker.

>2) Should the generation of the notice be based on the guarantees messaging settings, or the guarantors?
It's a good question: Who can decide that the e-mails are forwarded? I don't
have a clear idea about this.
Again, not a blocker for me if we'd handle this globally at first. Maybe it
could also be a setting under administration -> category codes?

>3) Following 2, perhaps guarantors should have the option of receiving notices of guarantees as part of the messaging preferences
See above :)

>4) Wouldn't it be prudent to send the notice to both? It could just CC the guarantor
I have thought about it and I'd really like to see this change happen. I know
more places need to be touched, but it seems to be a much cleaner and clearer
solution to me. Also: if we change this later on, we got a behaviour change.
Worth to give this more thought from the beginning.

>I think at a minimum this should be an option for each guarantor, and the email should just add them as a CC ( or some other method so that both the guarantee and guarantor receive >the notice ). A default setting of on or off could be added to the patron types editor, and a checkbox for receiving guarantees notices could be added to the messaging settings for >guarantors on the staff side and the opac.

@Kyle - would you be ok with this being global and CC as a first step?

D) Some thoughts about wording - you might want to check this with a native
speaker :)

- I am in favor of short preference names - I was wondering if we couldn't 
  just leave the "Enable" off: RedirectGuaranteeEmail
- Similar for the preference description: 
  Now: [Do|Don't] enable the ability to redirect guarantee email messages 
  to guarantor. All email message placed in message_queue table will be
affected.
  Suggestion: [Enable|Don't enable] redirection of guarantee email messages to
the guarantor.
  All email messages send via the message_queue table will be affected.

-------------------------------------------

Some general notes:
- database update - ok
- QA test tools - ok
- tests pass for me - apart from one test failing in 
  Letters.t before and after the patch - ok
- functionality tested for checkout notices with and 
  without guarantor and yes/no pref setting - ok

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ +183,5 @@
> +         - pref: EnableRedirectGuaranteeEmail
> +           choices:
> +               yes: Do
> +               no: "Don't"
> +         - enable the ability to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected.

In the initial description of this feature you named ACCTDETAILS and RLIST -
those don't go through the message_queue. Looking at the code, I think they are
not included?
Which messages are affected?

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +82,1 @@
>  

Why those changes?

@@ +1069,5 @@
> +    [% IF ( !opadd ) && ( !opduplicate ) && !destination %]
> +        <script type="text/javascript">
> +            $("#saverecord").attr("id","PatronMmessagingPreferences");
> +        </script>
> +    [% END %]

Same here: why those changes?

::: members/memberentry.pl
@@ +323,5 @@
>      push @errors, "ERROR_login_exist";
>    }
>    
> +  my $password = $input->param('password') || '';
> +  my $password2 = $input->param('password2') || '';

Same here: why those changes?

-- 
You are receiving this mail because:
You are watching all bug changes.