[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 25 12:39:46 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #7 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Jacek Ablewicz from comment #5)
> > This (and adding a new module for more predictable rounding etc.) would be a
> > good start for solving all prices / fines rounding problems in Koha, once
> > and for all.. I'm just not entirely happy with starting such monumental task
> > right in this report, looks like a bit of an overkill to me.
> 
> Agreed. But replacing a hardcoded 6 by one or two lines might not be that
> monumental ?

Ok, I'm happy with that; I don't have any strong opinion either way. My gut
feeling though is that it would be better to have this in some kind of module,
so it will be reusable. Otherwise, I'm worried that something like that would
need to be included in each and every places where calculations in Koha are
being tinkered with.

But I'll better check first if those DBIx calls are not too costly. One never
knows - this DBIx stuff is full of surprises, and not always the pleasant
ones..

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list