[Koha-bugs] [Bug 14939] OAI Server classes must be modularized

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 45602
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45602
Bug 14939: Modularize OAI Server existing classes

Review of attachment 45602:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14939&attachment=45602)
-----------------------------------------------------------------

::: Koha/OAI/Server/ListRecords.pm
@@ +42,5 @@
> +        $set = GetOAISetBySpec($token->{'set'});
> +    }
> +    my $max = $repository->{koha_max_count};
> +    my $sql = "
> +        (SELECT biblioitems.biblionumber, biblioitems.timestamp, marcxml

We have this...

@@ +49,5 @@
> +    $sql .= " JOIN oai_sets_biblios ON biblioitems.biblionumber = oai_sets_biblios.biblionumber " if defined $set;
> +    $sql .= " WHERE timestamp >= ? AND timestamp <= ? ";
> +    $sql .= " AND oai_sets_biblios.set_id = ? " if defined $set;
> +    $sql .= ") UNION
> +        (SELECT deletedbiblio.biblionumber, null as marcxml, timestamp FROM deletedbiblio";

then this (marcxml and timestamp inverted)

@@ +67,5 @@
> +    $sth->execute( @bind_params );
> +
> +    my $count = 0;
> +    my $format = $args{metadataPrefix} || $token->{metadata_prefix};
> +    while ( my ($biblionumber, $timestamp) = $sth->fetchrow ) {

And finally this.

Should not we remove marcxml (as it's unused)?

-- 
You are receiving this mail because:
You are watching all bug changes.