[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 26 11:22:41 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #12 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Bug 14390 moved forward, now thanks to it if there is a clear distinction
between F and FU fines in a given production database, it will stay that way in
the future - for such databases problem is effectively solved.

But if F / FU distinction initially is not entirely clear - if there are some
non-accruing FU fines still left in the DB - Bug 14390 is only half the
solution, IMO such fine records may still get overwritten even with Bug 14390
applied.

This is not all that awfully clear - but after thinking for a while about it,
I'm pretty sure that some DB clean up (at least closing the non-accruing FU
fines left behind by Bug 15675) is still required for fixing an issue described
by this report. Consider the following scenario (starting in some pre-Bug 15675
setup, e.g. in 3.22.x)

1) Item gets overdued, 'FU' fine record gets created, fine starts accruing
2) Patron renews this item, fine record created in step 1) stops accruing
(because date due in fine description doesn't match with due date in issue
record any more), fine type is still 'FU'
3) Upgrade: ... Bug 15675 gets applied ... Bug 14390 gets applied
4) Fine record from 1) is still FU and it's now linked to the issue record by
issue_id
5) This item gets overdued again: instead of creating a new one, UpdateFine()
will pick the same old fine record for updating (it's FU and it's linked to the
existing issue), amount from the previous overdue gets overwritten.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list