[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #97 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some more tiny comments from the last big patch:

You say that this (horrible??) category key within the branches hash is not
used anymore due to bug 15295 ? I think so too. More evidence to present?

FIXME in transferbook is fine with me. Just leave it. This PE stuff should
perhaps be removed, but not on this report.

circ/branchtransfers.pl
+        $item{'tobrname'}              = $tobranchcd;
and
+    $item{'tobrname'}              = $tobcd;
With a corresponding: <td class="tf-destination">[% Branches.GetName(
trsfitemloo.tobrname ) %]</td>
Do not really look good.. Name versus code?
L194 Do we still need this warn BTW ?

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+                        <p class="problem">Please return item to: [%
Branches.GetName( errmsgloo.msg ) %]</p>
Hmm.

I will finish it later next week. I guess that splitting up this patch set in
two parts would have been better.

-- 
You are receiving this mail because:
You are watching all bug changes.