[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jacek Ablewicz from comment #16)
> (In reply to Jacek Ablewicz from comment #15)
> > Would be a simple sql statement like 
> > 
> >     issues.due_date > NOW()
> > 
> > good enough for selecting old FU fines which need to be closed (+ the
> 
> I guess not good enough after all: item may be due but the fine not accruing
> yet: if overdue is in the grace period, or eg. in the middle of the 1st
> charge period, (when charge period > 1 day). With just 'issues.due_date >
> NOW()' there is a possibility that some unclosed old FU fines may still get
> left behind.
> 
> I don't see any way to fix this without involving CalcFine() and a good part
> of Getoverdues(), but in that case it's starting to look more like some kind
> of external script instead of simple DB update. Or at least I don't see that
> kinds of things in updatedatabase.pl - what are the community guidelines in
> such case?

Look at e.g. fix_accountlines_rmdupfines_bug8253.pl in misc/maintenance..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.