[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16330&attachment=54942)
-----------------------------------------------------------------

::: Koha/REST/V1/Patron.pm
@@ +31,5 @@
> +    my $patrons;
> +    if (keys %$params) {
> +        my @valid_params = Koha::Patrons->columns;
> +        foreach my $key (keys %$params) {
> +            delete $params->{$key} unless grep { $key eq $_ } @valid_params;

Should not we raise an error instead of removing invalid params?

-- 
You are receiving this mail because:
You are watching all bug changes.