[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 29 11:28:10 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16330&attachment=54942)
-----------------------------------------------------------------

::: Koha/REST/V1/Patron.pm
@@ +172,5 @@
> +    } elsif ($res eq '-1') {
> +        return $c->$cb({}, 404);
> +    } else {
> +        return $c->$cb({}, 400);
> +    }

It may be better to surround the ->delete with an eval, returns 200 if == 1 or
log the error and return 500, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list