[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 29 11:29:06 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #24)
> Comment on attachment 54942 [details] [review]
> Bug 16330: REST API: add routes to add, update and delete patrons
> 
> Review of attachment 54942 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/REST/V1/Patron.pm
> @@ +172,5 @@
> > +    } elsif ($res eq '-1') {
> > +        return $c->$cb({}, 404);
> > +    } else {
> > +        return $c->$cb({}, 400);
> > +    }
> 
> It may be better to surround the ->delete with an eval, returns 200 if == 1
> or log the error and return 500, don't you think?

Or 400 instead.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list