[Koha-bugs] [Bug 17221] New: orphan comma in shelf browser

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 29 22:49:56 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

            Bug ID: 17221
           Summary: orphan comma in shelf browser
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 54997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997&action=edit
screenshot of bug

Example screenshot attached, here's the bib record in our catalog:

https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729&shelfbrowse_itemnumber=34420#holdings

Basically, since starting_homebranch is null in the template file, nothing is
printed out, but the next IF condition wrongly assumes that the first must have
been true and prints out a comma before it's text string. Steps to recreate:

- in settings, set ShelfBrowserUsesHomeBranch to "Don't Use"
- set ShelfBrowserUsesLocation to "Use"
- visit an item, click the "Browse shelf" link in the Holdings' tab's Call
Number column
- note the extraneous comma in the <h5> tag that appears

Patch coming shortly, it appears that simply adding an additional condition
around the comma itself should resolve this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list