[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #140 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 55045
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55045
Bug 11592: (QA followup) Simplify code

Review of attachment 55045:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=55045)
-----------------------------------------------------------------

Just an eyeball.

::: catalogue/ISBDdetail.pl
@@ -33,5 @@
>  
>  =cut
>  
> -use strict;
> -#use warnings; FIXME - Bug 2505

I wouldn't change to Modern::Perl, unless all the Bug 2505 references are fixed
like this.

::: opac/opac-export.pl
@@ +35,5 @@
>  $biblionumber = int($biblionumber);
>  my $error = q{};
>  
> +my $include_items = ($format =~ /bibtex/) ? 0 : 1;
> +my $marc = GetMarcBiblio($biblionumber, $include_items)

Oooo... nice simplification.

::: opac/opac-showmarc.pl
@@ -58,4 @@
>  
>  if ($view eq 'card' || $view eq 'html') {
> -    # FIXME: GetXmlBiblio needs filtering later.
> -    my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber);

GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I
recall correctly. I'm not sure about this.

-- 
You are receiving this mail because:
You are watching all bug changes.