From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:19:56 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57725|0 |1 is obsolete| | --- Comment #18 from Alex Buckley --- Created attachment 57849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57849&action=edit Bug 15822: Fix 500 error when searching if items.onloan=0000-00-00 The calls output_pref({ dt => dt_from_string( $date ) }) are wrong and should be replaced with output_pref({ str => $date }) For better error handling. Here we fix the problem of items.onloan when searching Test plan: - Set items.onloan=0000-00-00 (UPDATE items SET onloan='0000-00-00') This can come from old data or bad migration - Execute a search => Without this patch you get Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225. => With this patch you won't get the error Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:20:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:20:20 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:21:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:21:02 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:21:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:21:12 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:47:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:47:50 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:47:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Nov 2016 23:47:52 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57726|0 |1 is obsolete| | --- Comment #4 from Alex Buckley --- Created attachment 57850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57850&action=edit remove unused variables https://bugs.koha-community.org/show_bug.cgi?id=17671 Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 00:23:12 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alexbuckley at catalyst.net.nz --- Comment #14 from Alex Buckley --- The Library Groups webpage (http://localhost:8081/cgi-bin/koha/admin/library_groups.pl) where the user should be able to create a group (in addition to being able to see previously made groups) results in a Internal Server Error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 00:55:36 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #1 from Aleisha Amohia --- Created attachment 57851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57851&action=edit [NOT READY FOR TESTING] Bug 17698: Make patron notes show up on staff dashboard Test plan will come when patch is complete Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:55:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 00:55:49 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:24:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:24:52 +0000 Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Mika changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mikasmith at catalyst.net.nz --- Comment #2 from Mika --- 2 identical messages are still created in message_queue when 'perl ./misc/cronjobs/overdue_notices.pl' is run, both containing both I1 and I2. Both messages are sent from B1 with B1 addresses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:35:22 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #32 from David Cook --- While part of this patch is a duplicate of bug 17318, there are some parts which are not duplicates. I'm re-opening this bug and will upload an updated patch for the unique changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:37:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:37:16 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Mika changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikasmith at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #15 from Mika --- Before patch was applied, notices on first page were fine but records on next page were indeed expanded but could be collapsed. The patch did not fix this, however when I applied the patch, all the notices appeared on one page expanded and there was no option to collapse them and no option to see them on multiple pages/go to next page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:49:09 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:49:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:49:14 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50264|0 |1 is obsolete| | Attachment #50971|0 |1 is obsolete| | --- Comment #33 from David Cook --- Created attachment 57852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57852&action=edit Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:52:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:52:34 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15541 --- Comment #110 from David Cook --- Adding 15541 back as a dependency, since it's required for matching URIs. OAI-PMH identifiers must be URIs, so it's necessary for matching OAI-PMH identifiers. "The format of the unique identifier must correspond to that of the URI (Uniform Resource Identifier) syntax." http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 [Bug 15541] Prevent normalization during matching/import process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:52:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 01:52:34 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 03:43:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 02:43:54 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 03:43:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 02:43:58 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57802|0 |1 is obsolete| | Attachment #57829|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia --- Created attachment 57853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57853&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database - perl installer/data/mysql/updatedatabase.pl 3) (You may have to rebuild schema but I think the patch should apply the schema changes for you) 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 05:51:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 04:51:46 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Mubassir Ahsan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mahsandu at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:04:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:04:03 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:04:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:04:07 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57673|0 |1 is obsolete| | Attachment #57679|0 |1 is obsolete| | --- Comment #16 from Josef Moravec --- Created attachment 57854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57854&action=edit Bug 11274 Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering.... Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:07:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:07:17 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 --- Comment #17 from Josef Moravec --- Sorry to not been able to test it sooner, I use the Owen's patch and it worked perfect for me, so I obsoleted mine and signed off the Owen's ;) (In reply to Mika from comment #15) > Before patch was applied, notices on first page were fine but records on > next page were indeed expanded but could be collapsed. The patch did not fix > this, however when I applied the patch, all the notices appeared on one page > expanded and there was no option to collapse them and no option to see them > on multiple pages/go to next page. There were two alternative patches, maybe if you accidentaly apply both, this could happen I imagine... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:09:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:09:57 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #25 from Hugo Agud --- I have tried it, but I get the following error: https://postimg.org/image/wj3mqhszj/ on plack.log No property note for Koha::IssueNo property notedate for Koha::IssueNo property notedate for Koha::IssueNo property notedate for Koha::Issue Tested on KohadevBox debian jessy 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:20:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:20:58 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:34:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 07:34:13 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Hugo Agud --- Fixed the previous error (cache error) tested and signed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 12:42:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 11:42:52 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Marcel de Rooy --- (In reply to Mika from comment #2) > Passed step 4 of test plan, however invalid dates still show as 0000-00-00 > rather than null when saved for both dateaccessioned and > replacementpricedate. Thanks for testing ! I cannot reproduce your test results. If am entering e.g. some text "aa" in replacementpricedate, the date will become null in the record, and shows blank on the form. If you test under Plack, please make sure to restart Plack after applying the patches. Could that be a cause ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 12:56:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 11:56:44 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 12:56:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 11:56:46 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 --- Comment #2 from Nick Clemens --- Created attachment 57855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57855&action=edit Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission 11 - Verfiy correct error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 12:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 11:57:45 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |nick at bywatersolutions.com Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:14:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 12:14:40 +0000 Subject: [Koha-bugs] [Bug 17701] Allow gender specific notification letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17701 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #3 from Radek ?iman (R-Bit Technology, s.r.o.) --- Template toolkit mentioned by Josef perfectly solves this issue. Closing as INVALID issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:54:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 12:54:19 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #1 from Josef Moravec --- Created attachment 57856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57856&action=edit Bug 17702: Account types configuration - db changes Test plan: 1) Read the diff and confirm that it does make sense 2) Comment what does not make sense ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:54:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 12:54:26 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #2 from Josef Moravec --- Created attachment 57857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57857&action=edit Bug 17702: Account types configuration - Manual invoice and credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:54:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 12:54:34 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #3 from Josef Moravec --- Created attachment 57858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57858&action=edit Bug 17702: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Account types page in Patrons and circulation section 2) Go to any other admin page and confirm there is link to Account types in admin menu as welll 3) Go to Account types page 4) You should see two datatables, one for debit types and one for credit types, ensure the datatables are working corectly 5) Try to create, edit and delete some debit types, note, that some of them can't be deleted - they are neede for Koha internally 6) Do the same with credit types 7) Try to add some default amount to internal debits - like Acccount management fee, New card, ... 8) Go to Patron fines page and play with account type select, when you change thy account type, the description and amount should change as you set it on the admin page 9) Try to add some fees and ensure they are inserted corectly 10) Pay the inserted fees 11) Try to add manual credit and ensure it is added corectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 12:55:59 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #4 from Josef Moravec --- I attached my current work, but stay with ASSIGNED status till I write tests ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:06:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 13:06:08 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 --- Comment #3 from Julian Maurice --- Created attachment 57859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57859&action=edit Bug 17568: Add the Koha::Patron->library method This method will be convenient when moving code to Koha::Patrons Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:07:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 13:07:14 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Attachment #57280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:08:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 13:08:06 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Julian Maurice --- Trivial patch. Tests pass. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:07:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 14:07:12 +0000 Subject: [Koha-bugs] [Bug 17705] New: Payments with cards through payment terminal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 Bug ID: 17705 Summary: Payments with cards through payment terminal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: rbit at rbit.cz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Allow patrons to pay their fees cashlessly using cards in payment terminals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:08:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 14:08:42 +0000 Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com Assignee|koha-bugs at lists.koha-commun |rbit at rbit.cz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 14:14:47 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:14:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 14:14:54 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 16:48:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 15:48:53 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #111 from Andreas Hedstr?m Mace --- (In reply to David Cook from comment #109) > I suppose this might all just be idealistic thinking on my part, and perhaps > outside the scope of this enhancement. > > I already have code that mostly works using just the OAI-PMH identifier. > It's a flawed concept, but it's the same one used by VuFind and DSpace, and > they haven't fallen over yet. > > I have a few fixes I need to make to C4::Matcher and C4::Search for the > matching to work as expected though. > > I think perhaps what I have so far will just have to be good enough for now. > It's far from ideal, but it's functional. Yes, I definitely think this will be good enough for now!!! Getting a better matching and/or storing the incoming data to me sounds like future enhancements! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 16:53:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 15:53:15 +0000 Subject: [Koha-bugs] [Bug 17513] koha-create does not set GRANTS correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net, | |mtj at kohaaloha.com --- Comment #8 from Mirko Tietgen --- Should go into 16.05 too please, I just ran into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:14:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 16:14:35 +0000 Subject: [Koha-bugs] [Bug 17706] New: MARC staging fails with "Upload status: Denied" when memcached is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17706 Bug ID: 17706 Summary: MARC staging fails with "Upload status: Denied" when memcached is enabled Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org In 16.11.00 with memcached enabled, staging MARC records fails with "Upload status: Denied". It works after disabling memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 16:21:16 +0000 Subject: [Koha-bugs] [Bug 17707] New: Check out and due date are same Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17707 Bug ID: 17707 Summary: Check out and due date are same Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 57860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57860&action=edit Circulation module screenshot My Koha version 16.05.5 Check out and due dates are same. Please see the attached screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:22:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 16:22:28 +0000 Subject: [Koha-bugs] [Bug 17707] Check out and due date are same In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17707 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:31:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 16:31:56 +0000 Subject: [Koha-bugs] [Bug 17708] New: Renewal log seems empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 Bug ID: 17708 Summary: Renewal log seems empty Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 57861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57861&action=edit Renewal log Koha version 16.05.5 Tools > Log > Circulation > Renewal does not display result. Please check the screenshots. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:32:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 16:32:32 +0000 Subject: [Koha-bugs] [Bug 17708] Renewal log seems empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:40:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:40:16 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57220|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 57862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57862&action=edit Bug 17557: Revised patron age calculation tests The SetAge and GetAge test coverage are excessive. First the SetAge subroutine was only created for testing purpose. The goal of GetAge is quite simple and it seems quite easy to provide corect test coverage using DateTime->add using negative numbers. Edit: rebased so it applies Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:40:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:40:27 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57221|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 57863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57863&action=edit Bug 17557: Koha::Patrons - Move GetAge to ->set_age (and remove SetAge) As said in the previous commit, I considered SetAge as unnecessary and removed it. Test plan: 1/ Edit a patron using the different 'Edit' links 2/ Play with the patron category limited to age ranges, and date of birth 3/ You should get the expected warning if the date of birth is inside the patron category date range. To finish: prove t/Circulation/AgeRestrictionMarkers.t t/db_dependent/Reserves.t \ t/db_dependent/Koha/Patrons.t t/db_dependent/Members.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:42:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:42:27 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Passing rebased patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:46:33 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- There's some dependency missing I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:49:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:49:30 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #16) > Patches rebased (and 2 squashed). I didn't succeed applying them in current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:57:20 +0000 Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 17:57:23 +0000 Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57810|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 57864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57864&action=edit Bug 17689: Add the Koha::Issue->is_overdue method This patch adds a new method Koha::Issue->is_overdue and provide tests to cover it. The goal is to behave like GetItemIssues set the 'overdue' flag to issues. I don't understand why the existing GetItemIssues truncate dates to minutes, so I did not recreate this behavior. Test plan: prove t/db_dependent/Koha/Issues.t should return green Signed-off-by: Mika Smith Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:43:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:43:59 +0000 Subject: [Koha-bugs] [Bug 17709] New: Article request broken - 'internal server error' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Bug ID: 17709 Summary: Article request broken - 'internal server error' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:44:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:44:12 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken - 'internal server error' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:44:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:44:12 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 [Bug 17709] Article request broken - 'internal server error' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:47:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:47:09 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken - 'internal server error' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 --- Comment #1 from Katrin Fischer --- Plack was turned off, now it explodes differently: Template process failed: undef error - The method _biblioitem is not covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:57:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:57:10 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken - 'internal server error' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #2 from Katrin Fischer --- Updating severity, this is one of the 16.11 advertised features... and it's broken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 19:58:37 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article request broken - |Article request broken |'internal server error' | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:06:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:06:53 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57855|0 |1 is obsolete| | --- Comment #3 from Chris Kirby --- Created attachment 57865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57865&action=edit Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verfiy correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:07:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:07:33 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:13:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:13:32 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 --- Comment #3 from Kyle M Hall --- Created attachment 57866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57866&action=edit Bug 17709 - Article request broken - 'internal server error' Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. Test Plan: 1) Set circ rule to record only article requests 2) Attempt to place a request on a record with no items 3) Note the error 4) Apply this patch 5) You should now be able to place the request! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:13:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:13:41 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:13:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:13:46 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:45:49 +0000 Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 --- Comment #1 from Radek ?iman (R-Bit Technology, s.r.o.) --- Currently working on a solution for terminals Ingenico iCT220 provided by GPE (Global Payments Europe) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:56:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 20:56:47 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57866|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 57867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57867&action=edit Bug 17709 - Article request broken - 'internal server error' Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. Test Plan: 1) Set circ rule to record only article requests 2) Attempt to place a request on a record with no items 3) Note the error 4) Apply this patch 5) You should now be able to place the request! Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:00:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:00:08 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #5 from Mirko Tietgen --- Fixes the second error and then works with plack too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:22:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:22:34 +0000 Subject: [Koha-bugs] [Bug 17706] MARC staging fails with "Upload status: Denied" when memcached is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17706 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- I'm not seeing this. We need more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:35 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:35 +0000 Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:36 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:35 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:36 +0000 Subject: [Koha-bugs] [Bug 2280] authorized value option for indicators doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:36 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:37 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:37 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:38 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:38 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:38 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:38 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:39 +0000 Subject: [Koha-bugs] [Bug 9131] Guarantor Information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9131 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:39 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:39 +0000 Subject: [Koha-bugs] [Bug 14474] Circulation alerts should have a From: address based on the current logged-in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14474 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:40 +0000 Subject: [Koha-bugs] [Bug 12629] Software error when trying to merge records from different frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:40 +0000 Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:41 +0000 Subject: [Koha-bugs] [Bug 7703] Don' t block bulk hold action on search results if some items can' t be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:40 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:41 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:41 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:41 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:42 +0000 Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:42 +0000 Subject: [Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:42 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn' t activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:43 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:43 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:44 +0000 Subject: [Koha-bugs] [Bug 3237] OpenID patron authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3237 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:44 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:44 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:45 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:45 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:46 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:46 +0000 Subject: [Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:47 +0000 Subject: [Koha-bugs] [Bug 11851] holdings table should have action links consolidated into one column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11851 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:46 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:46 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:48 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:47 +0000 Subject: [Koha-bugs] [Bug 2635] Adding non-digit chars to cost fields in items causes data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:47 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:48 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:49 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:49 +0000 Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:48 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:49 +0000 Subject: [Koha-bugs] [Bug 15825] Patron lists does not show tools menu sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15825 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:50 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:50 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:50 +0000 Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:51 +0000 Subject: [Koha-bugs] [Bug 3013] Value builder for 006 and 008 need choices for all format types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3013 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:50 +0000 Subject: [Koha-bugs] [Bug 11455] Rule Replacement Confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11455 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:51 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:51 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:52 +0000 Subject: [Koha-bugs] [Bug 3607] Lost item returned credit to borrower - but can' t resolve credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3607 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:52 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:52 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:53 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:53 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:53 +0000 Subject: [Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:53 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:54 +0000 Subject: [Koha-bugs] [Bug 9232] It should be possible to limit on multiple years or date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9232 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:54 +0000 Subject: [Koha-bugs] [Bug 10537] Limit ability to grant permissions based on user' s own permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:54 +0000 Subject: [Koha-bugs] [Bug 9548] Add a way to 'freeze' the content of a basket group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:54 +0000 Subject: [Koha-bugs] [Bug 16736] Keep library filter when changing suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:55 +0000 Subject: [Koha-bugs] [Bug 4998] Show less technical message in OPAC, when 'Browse by Hierarchy' is not fully configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4998 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:55 +0000 Subject: [Koha-bugs] [Bug 2559] Language limit on Spanish returns Russian records or is it English ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:55 +0000 Subject: [Koha-bugs] [Bug 16002] ALL/MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:55 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:56 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:56 +0000 Subject: [Koha-bugs] [Bug 16117] Feature request: Log borrower cardnumbers and item barcodes which are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:56 +0000 Subject: [Koha-bugs] [Bug 5216] Returning lost material with Forgive Fines does not forgive overdue charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5216 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:56 +0000 Subject: [Koha-bugs] [Bug 7712] a single holds report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7712 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:57 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:57 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:57 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:58 +0000 Subject: [Koha-bugs] [Bug 11454] Cannot indicate time on Circulation Rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11454 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:59 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:59 +0000 Subject: [Koha-bugs] [Bug 4202] Improve international currency and exchange support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4202 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:00 +0000 Subject: [Koha-bugs] [Bug 12437] <> 952$h field not populated while sending Routing List Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:59 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:59 +0000 Subject: [Koha-bugs] [Bug 7627] Editing of invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:58 +0000 Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:57:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:57:58 +0000 Subject: [Koha-bugs] [Bug 813] OPAC lists should store comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:00 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:01 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:01 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:02 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:02 +0000 Subject: [Koha-bugs] [Bug 5062] Acq terminology: list price, ordering price, vendor price, RRP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5062 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:01 +0000 Subject: [Koha-bugs] [Bug 7826] Standardize link for triggering plugins and auto-entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7826 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:02 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:03 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:03 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:03 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:04 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:04 +0000 Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:05 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:05 +0000 Subject: [Koha-bugs] [Bug 9959] Filters for 'Most popular' page in OPAC show wrong behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9959 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:05 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:06 +0000 Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:06 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:06 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/ updating call number splitting algorithms in C4/Labels.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:07 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:07 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:07 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:08 +0000 Subject: [Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:08 +0000 Subject: [Koha-bugs] [Bug 6906] Show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:09 +0000 Subject: [Koha-bugs] [Bug 9159] Direct link to favourite vendors on the acq homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9159 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:08 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:09 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:09 +0000 Subject: [Koha-bugs] [Bug 2683] Supplemental issues cannot be planned for in serials module. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2683 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:09 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:10 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:10 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:10 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:11 +0000 Subject: [Koha-bugs] [Bug 9500] GetNormalizedISBN only ever checks the first populated ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9500 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:11 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:11 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:11 +0000 Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:12 +0000 Subject: [Koha-bugs] [Bug 5287] Would be nice to have search result options repeated at bottom of page, and page nav repeated at top of list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:12 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:12 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:12 +0000 Subject: [Koha-bugs] [Bug 8094] stats specific to Self-CKO by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8094 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:13 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:13 +0000 Subject: [Koha-bugs] [Bug 5250] Various enhancements to web based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:14 +0000 Subject: [Koha-bugs] [Bug 2172] Cart attaches an iso2709 file, which confuses 99% of patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:14 +0000 Subject: [Koha-bugs] [Bug 10489] Add comments to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10489 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:14 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:14 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) ( Print Slip) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:15 +0000 Subject: [Koha-bugs] [Bug 10973] Make the use of basketgroup an option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:15 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other: u url register when source $2 is uri In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:16 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:15 +0000 Subject: [Koha-bugs] [Bug 16745] Add edit catalog and edit items links to serials toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16745 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:16 +0000 Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:16 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:17 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:16 +0000 Subject: [Koha-bugs] [Bug 9175] Shelving location search returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9175 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:17 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:18 +0000 Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a document that was reserved to a course. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:17 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:18 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:18 +0000 Subject: [Koha-bugs] [Bug 2075] Create a page to show and manage the user's comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2075 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:19 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight circulation of reference books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:19 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:20 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:19 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:20 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 16023] Use Font Awesome icons on audio alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 5598] More Granular Cloning Circulation & Fine Rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 6879] Actual price should show correctly on order line and basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:20 +0000 Subject: [Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:22 +0000 Subject: [Koha-bugs] [Bug 16648] Add Content system preferences for all CSS and XSLT sysprefs that accept a URL. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16648 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:22 +0000 Subject: [Koha-bugs] [Bug 11653] For tag "020" only subfields "a" is displayed in MARC XSLT OPAC's detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11653 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:23 +0000 Subject: [Koha-bugs] [Bug 7654] Add location and callnumber at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:22 +0000 Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:23 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don' t successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:24 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:23 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:24 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:25 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:25 +0000 Subject: [Koha-bugs] [Bug 10920] Add a syspref regarding the use of basket groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10920 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:25 +0000 Subject: [Koha-bugs] [Bug 4850] CheckReserves does not respect holds circulation policies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:26 +0000 Subject: [Koha-bugs] [Bug 13846] Email patron asking to return an item that has been placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:25 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:27 +0000 Subject: [Koha-bugs] [Bug 3451] No facets for tags search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3451 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:27 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:27 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was " Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:28 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:26 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:26 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:28 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:29 +0000 Subject: [Koha-bugs] [Bug 7456] itypes with similar codes throw off search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:29 +0000 Subject: [Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is blocked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:29 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:30 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:30 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:31 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:31 +0000 Subject: [Koha-bugs] [Bug 3484] Break down fee display on checkout tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3484 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:31 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:32 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5= Use restrictions)? Place a hold for reference? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:32 +0000 Subject: [Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and issues tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:32 +0000 Subject: [Koha-bugs] [Bug 9705] Add ability to put news only on the mobile site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9705 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:33 +0000 Subject: [Koha-bugs] [Bug 7015] Fixup Template Code to Accommodate More Variety of Label Styles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7015 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:33 +0000 Subject: [Koha-bugs] [Bug 11409] ungrouped baskets are not being displayed when creating a new basket group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:33 +0000 Subject: [Koha-bugs] [Bug 7565] Fee/fines receipt for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7565 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:33 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:34 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:34 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:35 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:35 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:36 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:36 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:36 +0000 Subject: [Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:36 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:36 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:37 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:37 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:38 +0000 Subject: [Koha-bugs] [Bug 4171] overduerules.pl needs an overhaul In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4171 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:37 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:38 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:38 +0000 Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:38 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:39 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:39 +0000 Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:39 +0000 Subject: [Koha-bugs] [Bug 9355] Display of possible book title and author list in search box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9355 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:40 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:40 +0000 Subject: [Koha-bugs] [Bug 569] Searches need 'browse' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:41 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:40 +0000 Subject: [Koha-bugs] [Bug 10768] Improve the interface related to itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10768 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:41 +0000 Subject: [Koha-bugs] [Bug 4530] Circulation & fines rules aren' t always applied from most specific to less specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:42 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:42 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:42 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:43 +0000 Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:43 +0000 Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:44 +0000 Subject: [Koha-bugs] [Bug 3317] Author displays inconsistently ( and incorrectly ) in opac-basket.pl (and when emailing cart ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3317 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:43 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:44 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:44 +0000 Subject: [Koha-bugs] [Bug 14370] Use Restrictions in Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:45 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:45 +0000 Subject: [Koha-bugs] [Bug 5821] Enable cron job for merge_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5821 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:45 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:45 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:46 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:46 +0000 Subject: [Koha-bugs] [Bug 10132] MarcOrgCode would be useful on branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:47 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:47 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:47 +0000 Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:48 +0000 Subject: [Koha-bugs] [Bug 10339] make the content of some help files templates marflavor dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:47 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:48 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:48 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:49 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:49 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:49 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:50 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:50 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:50 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:51 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:51 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:51 +0000 Subject: [Koha-bugs] [Bug 3194] Hide records in the OPAC if all items are lost and " hidelostitems" is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:52 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:52 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:52 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:53 +0000 Subject: [Koha-bugs] [Bug 3417] Items with no checkouts report won't output to a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3417 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:53 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:54 +0000 Subject: [Koha-bugs] [Bug 16013] Classification sources are not deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16013 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:54 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities " New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:54 +0000 Subject: [Koha-bugs] [Bug 7711] clear holds statuses and workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:55 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:55 +0000 Subject: [Koha-bugs] [Bug 14790] Link to OPAC view from within subscriptions, search and item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:55 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:56 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:56 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:56 +0000 Subject: [Koha-bugs] [Bug 6778] Display suggestor's name in catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6778 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:57 +0000 Subject: [Koha-bugs] [Bug 9164] Only allow kohaadmin login under special conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9164 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:57 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:58 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:57 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:58 +0000 Subject: [Koha-bugs] [Bug 16230] Show tooltip with menu item when fund cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:00 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:59 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:01 +0000 Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:59 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:59 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:01 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:00 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:02 +0000 Subject: [Koha-bugs] [Bug 3707] Add system preference for customization of the OPAC login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3707 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:58:58 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:01 +0000 Subject: [Koha-bugs] [Bug 9083] <> in checkin/checkout notices does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:00 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:03 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:02 +0000 Subject: [Koha-bugs] [Bug 11063] Add circulation message's patron when checkin items ( returns.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:04 +0000 Subject: [Koha-bugs] [Bug 7638] one page notice for printing per student? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:03 +0000 Subject: [Koha-bugs] [Bug 11899] Force staff to choose option for filling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11899 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:04 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:04 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:04 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:05 +0000 Subject: [Koha-bugs] [Bug 2389] overdue_notices.pl needs a test mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2389 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:05 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:05 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:06 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:06 +0000 Subject: [Koha-bugs] [Bug 12857] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12857 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:06 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:07 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:07 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/ guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:08 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:08 +0000 Subject: [Koha-bugs] [Bug 11462] New series title authority includes volume number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11462 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:09 +0000 Subject: [Koha-bugs] [Bug 11259] Add a search for hidden records in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11259 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:09 +0000 Subject: [Koha-bugs] [Bug 10881] Fast Add Framework has different item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10881 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:10 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:09 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:10 +0000 Subject: [Koha-bugs] [Bug 5185] Match modification should (optionally) update the last seen time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5185 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:10 +0000 Subject: [Koha-bugs] [Bug 9852] Add interlibrary loan request form to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9852 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:11 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:11 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:11 +0000 Subject: [Koha-bugs] [Bug 9966] Incorrect 404 when a search returns one result hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9966 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:12 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:12 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:12 +0000 Subject: [Koha-bugs] [Bug 13888] 'Lists' permission should allow/ disallow using the lists module in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:13 +0000 Subject: [Koha-bugs] [Bug 10280] Extend SeparateHoldings functionality to the "Add items" screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10280 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:13 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:13 +0000 Subject: [Koha-bugs] [Bug 9855] Add OpenGraph (Facebook preview) tags to pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9855 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:14 +0000 Subject: [Koha-bugs] [Bug 1821] Limit amount of manual fine/credit, require verification above limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1821 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:14 +0000 Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 21:59:14 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:13 +0000 Subject: [Koha-bugs] [Bug 10880] Staff Client Display856uAsImage options need updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10880 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:14 +0000 Subject: [Koha-bugs] [Bug 16791] Explanation of callnumber.pl plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16791 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:14 +0000 Subject: [Koha-bugs] [Bug 7443] Change the mysql commands in the INSTALL.* files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7443 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:14 +0000 Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:13 +0000 Subject: [Koha-bugs] [Bug 16189] Add an exception to SMS via email documentation in the Koha manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16189 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:15 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:16 +0000 Subject: [Koha-bugs] [Bug 16293] Patron Card Batches documentation is incomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16293 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:15 +0000 Subject: [Koha-bugs] [Bug 5561] Help on summary field in authority type editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5561 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:15 +0000 Subject: [Koha-bugs] [Bug 13228] Documentation of 'restrictions' tab does not show "OVERDUE" restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13228 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:14 +0000 Subject: [Koha-bugs] [Bug 14809] INSTALL.debian needs to be updated for wheezy and jessie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14809 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:16 +0000 Subject: [Koha-bugs] [Bug 16833] printoverduefaq is out of date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16833 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:17 +0000 Subject: [Koha-bugs] [Bug 10816] Relational operators in Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:17 +0000 Subject: [Koha-bugs] [Bug 7920] Establish style guide for Koha help pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7920 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:17 +0000 Subject: [Koha-bugs] [Bug 17597] Outdated translation credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:04:17 +0000 Subject: [Koha-bugs] [Bug 16923] System Preference Missing from Manual -- IndependentBranchesPatronModifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16923 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:07:45 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57865|0 |1 is obsolete| | --- Comment #4 from Chris Kirby --- Created attachment 57868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57868&action=edit Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verify correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:46:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 22:46:30 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Mika changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mikasmith at catalyst.net.nz --- Comment #8 from Mika --- CONFLICT (content): Merge conflict in cataloguing/merge.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 00:08:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 23:08:33 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 00:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 23:08:36 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53072|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia --- Created attachment 57869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57869&action=edit Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar Edit 3: Fixing merge conflicts, using Koha::BiblioFrameworks to find FA framework and adding sidebar to on-site checkouts This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt circ/on-site_checkouts.tt To test: 1) Confirm syspref CircSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 00:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Dec 2016 23:09:52 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #13 from Alex Buckley --- Running step 4 after applying the patch still throws the error ' You must pay a value less than or equal to 1.14.'. i.e. the payment does not go through after this patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 01:19:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 00:19:15 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56610|0 |1 is obsolete| | Attachment #56611|0 |1 is obsolete| | Attachment #56612|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia --- Created attachment 57870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57870&action=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:07:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 01:07:34 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:07:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 01:07:36 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55273|0 |1 is obsolete| | --- Comment #6 from Alex Buckley --- Created attachment 57871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57871&action=edit Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 01:45:52 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:45:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 01:45:57 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57363|0 |1 is obsolete| | --- Comment #15 from Alex Buckley --- Created attachment 57872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57872&action=edit Bug 14541: Do not truncate tax rate values Tax rates are stored in decimal(6,4) fields which means that 4 decimals are allowed. If a tax rate is 8.42%, it is stored as 0.0842 If a tax rate has more precision than that, Koha won't deal correctly with it. We will need to update the DB structure. With this patch, the tax rate will be displayed with the same precision as in the DB. So if you enter 8.42, you will see 8.42% instead of 8.4% without this patch. Test plan: Do a full acquisition workflow with a tax rate like 8.42% and confirm that it is correctly displayed. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:31:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:31:53 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley at catalyst.net.nz --- Comment #24 from Alex Buckley --- The 'Update tests' patch fails to apply, when you try to apply this patch to koha. This is the result: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug #6979 Applying: Bug 6979 - Update tests Using index info to reconstruct a base tree... M t/db_dependent/Auth_with_ldap.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Auth_with_ldap.t CONFLICT (content): Merge conflict in t/db_dependent/Auth_with_ldap.t Failed to merge in the changes. Patch failed at 0001 Bug 6979 - Update tests The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-6979---Update-tests-EmFl3l.patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:37:24 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:37:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:37:28 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54900|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia --- Created attachment 57873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57873&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:53:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:53:10 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:53:14 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54494|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia --- Created attachment 57874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57874&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error Edit: circ/reserveratios.tt updated so that the plus icon doesn't show if there is no link Edit: fixing logic in circ/reserveratios.tt Edit: merge conflicts To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:56:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:56:17 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:56:20 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55592|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 57875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57875&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 02:56:38 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 --- Comment #7 from Aleisha Amohia --- Merge conflict fixed, ready to test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 04:06:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 03:06:23 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 04:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 03:06:26 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47567|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 57876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57876&action=edit Bug 15415: Warn when creating a new print profile As per Jonathan's comment in Comment 3, I've put that line of code in an if statement that will only call the get_attr method if we are editing an existing profile (therefore the profile id will exist). To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 04:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 03:31:50 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 04:31:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 03:31:53 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54879|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 57877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57877&action=edit Bug 15711: Fixing the 'Delete selected' button on patroncard images To test: 1) Go to Tools -> Patron Card Creator -> Manage images 2) Upload an image if you haven't already 3) Click Delete selected without selecting any images 4) Notice broken behaviour as described in Description 5) Apply patch, refresh page 6) Click Delete selected without selecting any images 7) Notice alert. Click OK 8) Select one image or more, click Delete selected 9) Notice confirm delete message. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 04:35:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 03:35:55 +0000 Subject: [Koha-bugs] [Bug 17710] New: C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Bug ID: 17710 Summary: C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org C4::Matcher::get_matches sorts its rows in descending order using score, while C4::ImportBatch::GetBestRecordMatch sorts its rows in descending order using score and record id. To get the best record match, C4::ImportBatch::GetBestRecordMatch takes the top result. By contrast, C4::Matcher::get_matches could easily return different rows in the top position if there are multiple rows with the same score, since its array is populated using a hash where order doesn't matter. It's an easy enough fix, although I will admit to finding the solution on StackOverflow: "Since <=> and cmp return 0 to indicate equality, and that's false, and because Perl's logical Boolean operators return the deciding value instead of just 0 or 1, sorting by multiple keys is as easy as stringing multiple comparisons together with or or ||" http://stackoverflow.com/questions/10395383/sorting-an-array-of-hash-by-multiple-keys-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 05:13:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 04:13:40 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 05:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 04:13:43 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 --- Comment #2 from Aleisha Amohia --- Created attachment 57878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57878&action=edit Bug 17208: Checking if classification source or filing rule already exists before adding To test: 1) Go to Admin -> Classification sources 2) Attempt to reproduce bug before applying patch. Notice the message saying the add was successful, but was not added to the table 3) Apply patch and refresh page (restart plack if necessary) 4) Add new classification source with same code as existing one. Notice you are now told that the add failed. 5) Confirm adding new classification source with unique code works 6) Add new classification filing rule with same code as existing one. Notice you are told that add failed. 7) Confirm adding new classification filing rule with unique code works Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 05:13:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 04:13:55 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 05:14:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 04:14:00 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 06:20:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 05:20:05 +0000 Subject: [Koha-bugs] [Bug 17711] New: Add othermirror option to build-git-snapshot Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 Bug ID: 17711 Summary: Add othermirror option to build-git-snapshot Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Add othermirror option to build-git-snapshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 06:20:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 05:20:22 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 06:21:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 05:21:56 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 --- Comment #1 from Mirko Tietgen --- Created attachment 57879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57879&action=edit Bug 17711 Add othermirror option to build-git-snapshot Add othermirror option to build-git-snapshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 06:39:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 05:39:38 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57879|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 57880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57880&action=edit Bug 17711 Add othermirror option to build-git-snapshot Add othermirror option to build-git-snapshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 06:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 05:51:06 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 --- Comment #1 from David Cook --- So: @results = sort { $b->{'score'} cmp $a->{'score'} } @results; Would become: @results = sort { $b->{'score'} cmp $a->{'score'} or $b->{'record_id'} cmp $a->{'record_id'} } @results; -- I've already tested this and it works a treat. I'll post a patch next week I reckon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 07:20:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 06:20:06 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #112 from David Cook --- (In reply to Andreas Hedstr?m Mace from comment #111) > Yes, I definitely think this will be good enough for now!!! Getting a better > matching and/or storing the incoming data to me sounds like future > enhancements! I spent some time today on these enhancements as they make the import much faster and more robust*, and I would've needed to do them soon for the RDFXML OAI-PMH downloads anyway**. I've ditched the import batches and I'm doing adds/updates/deletes more directly. If we need to track changes to bibliographic metadata records in Koha, I think it would make more sense to look at new functionality than relying on the existing batch system which has issues. In any case, I'll be working more on this early next week, and hopefully posting the API code here next week. *most matching will be done based on OAI-PMH identifier URI and repository URI in the database, so we won't need to worry about Zebra issues. However, in the event that there is no matching OAI-PMH identifier and repository URI, the API can be given an optional matcher code, and Koha's Zebra-based matcher will be used to find a match. This **The RDFXML OAI-PMH downloads will make use of this database-based matching, although if there's no OAI-PMH identifier URI and repository URI for that downloaded record, it'll be an error state, since only MARCXML can be used with the Zebra-based matcher. We may have to talk more about that at some point, although I suppose it's out of the scope of this bug report anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:22:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:22:15 +0000 Subject: [Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566 --- Comment #5 from Marcel de Rooy --- Created attachment 57881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57881&action=edit Bug 17566: [Follow-up] Initial focus on first select or input Previous patch just set the focus to the first input, because the focus on the first select does not show up in some browsers (incl FF). Joubu complained about that, which is not unreasonable :) This patch puts the focus on the first subfield (under conditions described earlier). We do not solve all browser problems here, but it still is an improvement compared to the original focus. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:23:41 +0000 Subject: [Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > I don't really like that, especially because it does not work with select. > It's weird to select the 4th element (in my case) of the add item form. > I'd like to get cataloguer specialist point of views. Your concern should be dealt with in the second patch, although focus and various browsers are not my favorite topic ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:35:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:35:37 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:35:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:35:40 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57867|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 57882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57882&action=edit Bug 17709 - Article request broken - 'internal server error' Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. Test Plan: 1) Set circ rule to record only article requests 2) Attempt to place a request on a record with no items 3) Note the error 4) Apply this patch 5) You should now be able to place the request! Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:36:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:36:12 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:46:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:46:53 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Petter Goks?yr ?sen from comment #3) > Test plan: > Visually verify that the removed variables are not referred to in the the > current scope (sub). Reading the code is not a test plan, sir. Check if adding a reserve still works, would be. But obviously, I will pass QA on these trivial changes. No problem. Koha::Old::Hold->new is hilarious btw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:49:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:49:07 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:49:09 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57850|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 57883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57883&action=edit Bug 17671: Remove unused variables in C4::Reserves I was reading through Reserves.pm trying to figure out a bug - found some unused variables instead. Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:50:59 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #7 from Marcel de Rooy --- Petter, Please add "Bug [number]:" as prefix on the first line of your commit message. And add a commit message :) Also fill the Assignee on Bugzilla please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:51:15 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |boutrosboutrosboutros at gmail |ity.org |.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 07:57:20 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #13 from Marcel de Rooy --- Applied dependency 17568 first. Applying: Bug 17569: Move tests to the patron module test file fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:03:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:03:36 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy --- Please add a test :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:04:02 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:06:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:06:22 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Depends on a PNA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:08:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:08:44 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #20 from Marcel de Rooy --- Applying: Bug 17583: Add the Koha::Patron->is_going_to_expired method fatal: sha1 information is lacking or useless (Koha/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:13:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:13:36 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:13:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:13:38 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 --- Comment #3 from Marcel de Rooy --- Created attachment 57884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57884&action=edit Bug 17630: Add the Koha::Biblio->holds method This method will be useful to get the current holds placed on a given bibliographic record. Test plan: prove t/db_dependent/Koha/Biblios.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:13:53 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Version|unspecified |master Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:20:17 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #8 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #7) > There's some dependency missing I guess. Apply ok for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:25:00 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:25:10 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57170|0 |1 is obsolete| | Attachment #57171|0 |1 is obsolete| | Attachment #57172|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 57885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57885&action=edit Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests If IndependentBranches is set, the code is buggy. This patch only highlight the bug by providing a test. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:25:21 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #19 from Jonathan Druart --- Created attachment 57886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57886&action=edit Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests The next patch will move C4::Circulation::AnonymiseIssueHistory and C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons This patch move the history anonymisation code to the Patrons.t test file and the entire subtest related to StoreLastBorrower to StoreLastBorrower.t It just moves and add some minor adjustements. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:25:31 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #20 from Jonathan Druart --- Created attachment 57887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57887&action=edit Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:29:27 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:30:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:30:56 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #21 from Jonathan Druart --- Created attachment 57888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57888&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:31:05 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #22 from Jonathan Druart --- Created attachment 57889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57889&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:31:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:31:15 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #23 from Jonathan Druart --- Created attachment 57890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57890&action=edit Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:31:24 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #24 from Jonathan Druart --- Created attachment 57891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57891&action=edit Bug 17583: Fix tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:31:34 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #25 from Jonathan Druart --- Created attachment 57892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57892&action=edit Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:31:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:31:44 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #26 from Jonathan Druart --- Created attachment 57893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57893&action=edit Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:32:37 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:32:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:32:45 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:32:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:32:57 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:33:05 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:33:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:33:13 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:33:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:33:22 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:33:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:33:30 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:36:16 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:36:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:36:25 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57315|0 |1 is obsolete| | Attachment #57316|0 |1 is obsolete| | Attachment #57317|0 |1 is obsolete| | Attachment #57318|0 |1 is obsolete| | Attachment #57319|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 57894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57894&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:36:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:36:33 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #15 from Jonathan Druart --- Created attachment 57895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57895&action=edit Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:36:46 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #16 from Jonathan Druart --- Created attachment 57896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57896&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:36:58 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #17 from Jonathan Druart --- Created attachment 57897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57897&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:37:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:37:12 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #18 from Jonathan Druart --- Created attachment 57898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57898&action=edit Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:40:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:40:16 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57336|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 57899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57899&action=edit Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:40:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:40:56 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #7 from Jonathan Druart --- To test, apply bug 17580 first, then bug 17583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:41:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:41:16 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:41:19 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57648|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 57900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57900&action=edit Bug 17631: Koha::Biblio - Remove GetHolds C4::Biblio::GetHolds can be replaced with Koha::Biblio->holds->count Test plan: Create an order and place a hold on the biblio you have ordered. On the basket view, you should not be able to Cancel the order and/or delete the record Receive the order, on the parcel page you should get the same behavior. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:41:37 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:44:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:44:24 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 --- Comment #6 from Marcel de Rooy --- C4 0.0187 Koha::Obj 0.1387 100 calls to GetHolds versus $biblio->holds->count (with one Biblios->find). C4 is 7 times faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:47:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:47:19 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 --- Comment #7 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > C4 0.0187 > Koha::Obj 0.1387 > > 100 calls to GetHolds versus $biblio->holds->count (with one Biblios->find). > C4 is 7 times faster. (10 holds on the same biblio record) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 08:55:22 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > C4 0.0187 > Koha::Obj 0.1387 > > 100 calls to GetHolds versus $biblio->holds->count (with one Biblios->find). > C4 is 7 times faster. Using an ORM is obviously heavier, this will be true for all the refactoring changes. However, you need to calculate everything in a context, ie. under plack and using memcached (keeping in mind we will try to cache more things). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:03:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:03:43 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:03:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:03:46 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57869|0 |1 is obsolete| | --- Comment #15 from Josef Moravec --- Created attachment 57901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57901&action=edit [SIGNED-OFF] Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar Edit 3: Fixing merge conflicts, using Koha::BiblioFrameworks to find FA framework and adding sidebar to on-site checkouts This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt circ/on-site_checkouts.tt To test: 1) Confirm syspref CircSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:09:13 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:09:15 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57899|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 57902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57902&action=edit [SIGNED-OFF] Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:10:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:10:18 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:10:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:10:21 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57777|0 |1 is obsolete| | Attachment #57778|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 57903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57903&action=edit Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:10:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:10:24 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 --- Comment #6 from Marcel de Rooy --- Created attachment 57904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57904&action=edit Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues The C4::Circulation::GetIssues subroutine is only called once and can be replaced with a call to Koha::Isues->search with a join on items. Test plan: - Apply first patch and make sure the tests pass - Apply second patch and make sure the tests still pass Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:10:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:10:28 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 --- Comment #7 from Marcel de Rooy --- Created attachment 57905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57905&action=edit Bug 17678: Typo iss in Circulation.t Iss should be is. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:10:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:10:50 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:14:26 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:14:29 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57338|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 57906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57906&action=edit [SIGNED-OFF] Bug 17586: Add the Koha::Account::Lines->get_balance method Test plan: prove t/db_dependent/Accounts.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:14:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:14:28 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Using an ORM is obviously heavier, this will be true for all the refactoring > changes. However, you need to calculate everything in a context, ie. under > plack and using memcached (keeping in mind we will try to cache more things). Sure. Just adding this for the record. Especially since you are not caching things here. (Which would probably useless in this specific case.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:15:20 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #6 from Josef Moravec --- > This patch depends on bug 17585. As I just signed off the 17585, I am continuing with this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:22:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:22:26 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:36:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:36:35 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > Please add a test :) I'd like you to reconsider this, the searchResults massive subroutine is not tested and it would be very time consuming to cover this change. Basically the change is: - SELECT hidelostitems FROM borrowers,categories WHERE borrowers.categorycode = categories.categorycode AND borrowernumber = ? + Koha::Patrons->find($borrowernumber)->category->hidelostitems Which sounds quite safe :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:51:11 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:51:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:51:14 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57816|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 57907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57907&action=edit Bug 17652: opac-account.pl does not include login branchcode opac-account.pl does not include the login branchcode, whereas the other pages available to users (opac-user, opac-memberentry, opac-passwd, opac-readingrecord, opac-suggestions, opac-messaging, opac-shelves, etc.) on login DO provide the login branchcode. Having the login branchcode available on opac-account.pl would facilitate customization of the OPAC for individual branches. To test: 1) Login to the OPAC and open /cgi-bin/koha/opac-account.pl 2) Inspect the body tag and observe the class attribute does not include the login branchcode. 3) Apply the patch. 4) Repeat step 2. 5) Observe that the login branchcode is present. Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:51:41 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12162 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Certainly caused by bug 12162. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:51:41 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 [Bug 17652] opac-account.pl does not include login branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:56:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:56:05 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart --- Yesterday I faced the problem of using koha-translate on a gitified intall, `koha-translate --install es-ES` won't install the Spanish templates in the gitified dirs. I remembered this bug and thought it would have fixed it, but it does not. Is it expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:58:57 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:00 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57894|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 57908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57908&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:04 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57895|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 57909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57909&action=edit Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:08 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57896|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 57910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57910&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:11 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57897|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 57911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57911&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:18 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57898|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 57912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57912&action=edit Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:59:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 09:59:23 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #24 from Marcel de Rooy --- Created attachment 57913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57913&action=edit Bug 17569: [QA Follow-up] Small changes Patron.pm: Adds two missing semicolons at the last statement. Not strictly needed, but strongly recommended. Patrons.t: Add a test description, remove two comments that refer to previously hardcoded dates. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:00:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:00:12 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #25 from Marcel de Rooy --- QA Comment: sub search_upcoming_membership_expires The mix of before/after and search options in the parameters does not really look good to me. (No blocker, but source for future problems when someone adds stuff and is not careful.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:02:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:02:18 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #19 from Marcel de Rooy --- See dependency 16749 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:04:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:04:23 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #8 from Petter Goks?yr ?sen --- > Reading the code is not a test plan, sir. > Check if adding a reserve still works, would be. Apologies! You're right of course. > Please add "Bug [number]:" as prefix on the first line of your commit message. > And add a commit message :) > Also fill the Assignee on Bugzilla please. Apologies again, I will make sure to do this next time:) Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:11:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:11:13 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master ro 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:16:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:16:46 +0000 Subject: [Koha-bugs] [Bug 17696] Two missing periods in opac-suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Eric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:18:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:18:37 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:27:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:27:08 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Petter! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:58:58 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57888|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 57914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57914&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:02 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57889|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 57915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57915&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:06 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57890|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy --- Created attachment 57916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57916&action=edit Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:10 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57891|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 57917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57917&action=edit Bug 17583: Fix tests Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:14 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57892|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 57918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57918&action=edit Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:18 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57893|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 57919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57919&action=edit Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 10:59:22 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #33 from Marcel de Rooy --- Created attachment 57920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57920&action=edit Bug 17583: [QA Follow-up] Final polishing Number of tests in Patrons.t corrected. Method is_going_to_expired (no english!) renamed to is_going_to_expire. Adding a negative duration replaced by a subtract. Reads easier. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:00:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:00:17 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:01:49 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:14:14 +0000 Subject: [Koha-bugs] [Bug 17712] New: Move availability calculation to the Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Bug ID: 17712 Summary: Move availability calculation to the Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 57921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57921&action=edit Diagram to proposal for new classes and their relations Currently some availability-related calculations are scattered around in different modules (which alone is not bad) but also in Perl-scripts, like opac-reserve.pl that has some patron related checks, maxreserves and some other. With this problem I think it is confusing for someone to figure out how availability is calculated. This also makes it difficult to implement something new that needs to find out different levels of availabilities. An example of "anything new" would be REST API, which needs to be able to tell different availabilities (biblio/item holdability, checkout availability both anonymously and with patron restrictions etc). As of now, if we simply ask CanBookBeReserved in REST controller, we are completely ignoring patron debarments and fines, and maxreserves system preference. Another problem is that currently there is no unified way of reasoning unavailability between holds and checkouts. There are strings from CanItemBeReserved, then there are HASHrefs with additional parameters from CanBookBeIssued, then some simple checks that may be simply 1 or 0, like IsAvailableForItemLevelRequest. REST API should however return uniform error codes. Also CanItemBeReserved has the problem that it returns the first reason in case of unavailability, and not all of them, if there would be more. An end-user would probably want to know all problems at once instead of fixing one to only find out there is another. My proposal is to move availability-related calculation and checks into Koha namespace. I propose adding a class, Koha::Availability, that is able to contain availability-related information. It would contain methods to easily find out availability status and any reasons to unavailabilities. To represent reasons for unavailability/additional messages/needs for confirmation, I propose objects instead of strings or hashes. These objects could be Koha::Exceptions. Availability calculation could be categorized into Koha::Availability::Calculation's subclasses. Answers to item availability could be located in Koha::Item::Availability::Hold and Koha::Item::Availability::Checkout. This setup would let us have an unified way for handling availability the same way everywhere. How would it work in practice? I will describe my idea with "ingredients" and "recipes": - "ingredient": anything availability-related sub-check or sub-calculation (e.g. item withdrawn, reservesallowed in issuing rules, age restriction etc.) that returns a Koha::Exception::* if it spots a problem. These could be located in Koha::Availability::Calculation subclasses. - "recipe": a set of ingredients that cooks an answer to question "is something available in some way", for example: ** "Q: does an anonymous user see an item available in search result? -> A: no, unavailability reason: Koha::Exceptions::Item::NotForLoan" ** "Q: is an item available for hold for this patron? -> A: yes, additional note: Koha::Exceptions::Item::NotForLoan with parameter code => 'Ordered'" ** "Q: is an item available for checkout for this patron by a librarian -> A: possibly; librarian needs to confirm Koha::Exceptions::Patron::Debt, exception includes field max_outstanding => 10.00, current_outstanding => 15.00" These could be located in Koha::Item/Biblio::Availability::Hold/Checkout The ingredient would contain all logic to spot a problem. The recipe would use what ever ingredients it needs to, and decide if a problem is worth of unavailability, additional note or perhaps ask a confirmation. This is somewhat same as CanBookBeIssued, but the point is to move all calculations away from the recipe so that we can re-use the same logic in another availability recipe. Any thoughts on this idea and current availability in general? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:45:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:45:54 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- % sudo koha-translate --dev kohadev --install es-ES % ls koha-tmpl/intranet-tmpl/prog|grep es-ES Does not return anything, what did I miss? I have used a very new script to update the debian files, cp_debian_files.pl on koha-misc4dev (see https://github.com/joubu/koha-misc4dev). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:46:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:46:55 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:46:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:46:58 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57361|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 57922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57922&action=edit Bug 17556: Koha::Patrons - Remove GetHideLostItemsPreference The subroutine C4::Members::GetHideLostItemsPreference can easily be replaced with Koha::Patron->find(42)->category->hidelostitems Test plan: Create 2 patron categories, 1 with "Lost items in staff client" set to "shown" and another one to "Hidden by default" Create 2 patrons using them On the result search page, the detail page of a record, the item list page and the page to place a hold, make sure the lost items are shown/hidden as expected Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:48:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:48:42 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > % sudo koha-translate --dev kohadev --install es-ES > % ls koha-tmpl/intranet-tmpl/prog|grep es-ES > > Does not return anything, what did I miss? Will have a look again. This was written six months ago without much attention ever since.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:50:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 11:50:31 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 --- Comment #9 from Marcel de Rooy --- I think that there is still room for improvement in the combination of the preference hidelostitems and the category column. This could be moved from the scripts into the object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 12:36:58 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- I stumbled across item status also in bug 17624 in particular referring to the Availability line in the OPAC XSLT results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:45:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 12:45:33 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #2 from Marcel de Rooy --- (In reply to Lari Taskula from comment #0) > > Any thoughts on this idea and current availability in general? Fist, I very much welcome the idea. Just in first glance, I would not choose for an Availablity object. We also need to define what we mean with "available" exactly: available for loan for instance? I would probably opt for Koha::Item->is_available methods and similar. Or perhaps is_available_for_loan, can_be_reserved etc. Same for Koha::Biblio. Shared code in this regard might perhaps go in Koha::Util::xxx ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:49:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 12:49:06 +0000 Subject: [Koha-bugs] [Bug 17696] Two missing periods in opac-suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #5) > Pushed to master for 16.11, thanks Eric! 16.11 or 17.05 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:39:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 14:39:50 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- Looks good, all plugins are working but QA tool says: FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:58:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 14:58:28 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57921|0 |1 is obsolete| | --- Comment #3 from Lari Taskula --- Created attachment 57923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57923&action=edit Diagram to proposal for new classes and their relations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:00:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:00:28 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57885|0 |1 is obsolete| | Attachment #57886|0 |1 is obsolete| | Attachment #57887|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 57924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57924&action=edit Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests If IndependentBranches is set, the code is buggy. This patch only highlight the bug by providing a test. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:00:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:00:25 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:01:07 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #22 from Kyle M Hall --- Created attachment 57925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57925&action=edit Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests The next patch will move C4::Circulation::AnonymiseIssueHistory and C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons This patch move the history anonymisation code to the Patrons.t test file and the entire subtest related to StoreLastBorrower to StoreLastBorrower.t It just moves and add some minor adjustements. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:01:11 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #23 from Kyle M Hall --- Created attachment 57926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57926&action=edit Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:03:19 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- t/db_dependent/Koha/Patrons.t .. 4/14 # No tests run! t/db_dependent/Koha/Patrons.t .. 13/14 # Failed test 'No tests run for subtest "get_overdues"' # at t/db_dependent/Koha/Patrons.t line 431. :1: parser error : Start tag expected, '<' not found EuExyYxkK ^ # Looks like your test exited with 255 just after 13. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/14 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 13 Failed: 1) Failed test: 13 Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 13. Files=1, Tests=13, 4 wallclock secs ( 0.02 usr 0.01 sys + 3.09 cusr 0.12 csys = 3.24 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:04:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:04:04 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:04:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:04:08 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57828|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 57927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57927&action=edit Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:08:57 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 --- Comment #3 from Mirko Tietgen --- This will probably not be needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:10:41 +0000 Subject: [Koha-bugs] [Bug 17713] New: Members.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Bug ID: 17713 Summary: Members.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:10:41 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 [Bug 17713] Members.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:12:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:12:22 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:12:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:12:24 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 --- Comment #1 from Jonathan Druart --- Created attachment 57928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57928&action=edit Bug 17713: Fix Members.t tests If the category_type is 'S', GetBorrowersToExpunge won't return the patron. Test plan: t/db_dependent/Members.t should always return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:14:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:14:31 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #48 from Kyle M Hall --- t/db_dependent/Members.t ............................... 1/79 # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' # at t/db_dependent/Members.t line 355. # got: '2' # expected: '3' # Looks like you planned 79 tests but ran 77. # Looks like you failed 1 test of 77 run. t/db_dependent/Members.t ............................... Dubious, test returned 1 (wstat 256, 0x100) Failed 3/79 subtests Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 256 Tests: 77 Failed: 1) Failed test: 64 Non-zero exit status: 1 Parse errors: Bad plan. You planned 79 tests but ran 77. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:19:21 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #49 from Jonathan Druart --- (In reply to Kyle M Hall from comment #48) > t/db_dependent/Members.t ............................... 1/79 > # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' Not related, see bug 17713 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:19:29 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:42:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:42:58 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:43:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:43:03 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57906|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 57929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57929&action=edit Bug 17586: Add the Koha::Account::Lines->get_balance method Test plan: prove t/db_dependent/Accounts.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:46:42 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:46:46 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57902|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 57930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57930&action=edit Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:50:43 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Josef Moravec --- Sorry, but this does not work for me, sometimes it does fail GetBorrowersToExpunge test, one or even more... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 15:59:34 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:09:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:09:20 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 --- Comment #3 from Jonathan Druart --- (In reply to Josef Moravec from comment #2) > Sorry, but this does not work for me, sometimes it does fail > GetBorrowersToExpunge test, one or even more... Paste the output please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:20:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:20:53 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Josef Moravec --- Sorry, my mistake, I had to accidentaly change branch after applying this... I wonder how it could happen... Now I am running Members.t again and again and it's still green... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:20 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:23 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55820|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 57931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57931&action=edit Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. Test Plan: 1) Apply this patch 2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout 3) Generate the CSV file via the script misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl 4) Enable Template Toolkit for the notices and update the notice text to be: [% FILTER remove("\r\n") %] "[% format %]", "[% language %]", "[% type %]", "[% level %]", "[% borrower.cardnumber %]", "[% borrower.title %]", "[% borrower.firstname %]", "[% borrower.surname %]", "[% borrower.phone %]", "[% borrower.email %]", "[% library_code %]", "[% branch.id %]", "[% branch.branchname %]", "[% item.barcode %]", "[% due_date %]", "[% biblio.title %]", "__MESSAGE_ID__" [% END %] 5) Regenerate the notices 6) Compare the originals, note the format is the same Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:24 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:27 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57928|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 57932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57932&action=edit [SIGNED-OFF] Bug 17713: Fix Members.t tests If the category_type is 'S', GetBorrowersToExpunge won't return the patron. Test plan: t/db_dependent/Members.t should always return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:50 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #9 from Kyle M Hall --- Created attachment 57933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57933&action=edit Bug 15969 - Add unit test of substitution param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:54 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #10 from Kyle M Hall --- Created attachment 57934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57934&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:22:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:22:57 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #11 from Kyle M Hall --- Created attachment 57935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57935&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:30:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:30:54 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #4 from Lari Taskula --- (In reply to Marcel de Rooy from comment #2) > Just in first glance, I would not choose for an Availablity object. We also > need to define what we mean with "available" exactly: available for loan for > instance? Thanks for the comment Marcel! Indeed, availability needs a proper definition to have a meaning. Also considering the perspective; Available for hold to patron, by who? Patron themselves? A librarian? If a patron asks if they can place a hold, they get an unavailability reason for having too much fines. If a librarian asks the same for patron, they get the same reason but additionally the information that it is possible to override it by confirmation. > I would probably opt for Koha::Item->is_available methods and similar. Or > perhaps is_available_for_loan, can_be_reserved etc. Same for Koha::Biblio. > Shared code in this regard might perhaps go in Koha::Util::xxx ? Just curious, how would you represent the answer to availability (what would these return)? Initially I was considering the same solution, but the complexity of availability eventually made me think of putting them it into own classes. I think that all types of availability answers should always be represented the same, uniform way. It could be a HASHref like in CanBookBeIssued, but I would prefer an object that contains the availability information (Koha::Availability in my proposal) but doesn't define and care about the type of availability; it exists to ensure that we always have the same operations on availability information (to contain yes/maybe/no value to availability, to contain and return additional notes, reasons to ask for confirmation and unavailabilities). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:31:05 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 [Bug 17712] Move availability calculation to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:31:05 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 [Bug 16826] REST API: Add API routes for getting item availability and holdability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 16:44:40 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:19:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:19:07 +0000 Subject: [Koha-bugs] [Bug 17714] New: Remove itemtype-related t/db_dependent/Members/* warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Bug ID: 17714 Summary: Remove itemtype-related t/db_dependent/Members/* warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com To reproduce: - Run: $ prove t/db_dependent/Members/* => FAIL: itemtype-related warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:21:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:21:51 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:21:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:21:55 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 57936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57936&action=edit Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:32:04 +0000 Subject: [Koha-bugs] [Bug 17715] New: Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Bug ID: 17715 Summary: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:33:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:33:49 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 18:33:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 17:33:52 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 57937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57937&action=edit Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:19:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:19:11 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:19:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:19:22 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:20:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:20:35 +0000 Subject: [Koha-bugs] [Bug 17716] New: Remove itemtype-related t/db_dependent/ CourseReserves.t warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Bug ID: 17716 Summary: Remove itemtype-related t/db_dependent/CourseReserves.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:35:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:35:34 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 57938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57938&action=edit Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:35:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:35:39 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 57939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57939&action=edit Bug 17716: (followup) Remove dep on existing data and tidy This patch removes the requirement for this tests for the DB to include at least 10 borrowers to pass. Borrowers are now created on each run using t::lib::TestBuilder and a loop. Bonus: some tiny changes to tidy the file. To test: - Run: $ prove t/db_dependent/CourseReserves.t SUCCESS => Tests pass with and without the patch. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:35:59 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:40:25 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:49:32 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:49:35 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57937|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 57940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57940&action=edit [SIGNED-OFF] Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:57:48 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 --- Comment #3 from M. Tompsett --- Comment on attachment 57939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57939 Bug 17716: (followup) Remove dep on existing data and tidy Review of attachment 57939: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17716&attachment=57939) ----------------------------------------------------------------- ::: t/db_dependent/CourseReserves.t @@ -36,5 @@ > -# Create the item > -my $record = MARC::Record->new(); > -$record->append_fields( > - MARC::Field->new( '952', '0', '0', a => $library->{branchcode}, b => $library->{branchcode} ) > -); Wow. That's strange adding an empty item, but then calling AddItem 2 lines later. Nice catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:59:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:59:43 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57938|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 57941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57941&action=edit [SIGNED-OFF] Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 19:59:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 18:59:53 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57939|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 57942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57942&action=edit [SIGNED-OFF] Bug 17716: (followup) Remove dep on existing data and tidy This patch removes the requirement for this tests for the DB to include at least 10 borrowers to pass. Borrowers are now created on each run using t::lib::TestBuilder and a loop. Bonus: some tiny changes to tidy the file. To test: - Run: $ prove t/db_dependent/CourseReserves.t SUCCESS => Tests pass with and without the patch. - Sign off :-D Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:00:13 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:11:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:11:22 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:11:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:11:25 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57936|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 57943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57943&action=edit [SIGNED-OFF] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:12:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:12:14 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- P.S. Overzealous variable renaming item_infos. Still okay, but not necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:13:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:13:32 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #3) > P.S. Overzealous variable renaming item_infos. Still okay, but not necessary. Heh, I belived %item_branch_info was no longer a correct name, as it now includes 'itype'. But we could have lived without the change, yeah :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:15:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:15:14 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Kyle M Hall --- Pushed to master for 17,05, thanks Jonathan, Josef, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:22:53 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:26:44 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Failed QA --- Comment #8 from Kyle M Hall --- I don't want to be *too* much of a pedant, but wouldn't this method be better in Koha::Account? I see there are a good number of patches that depend on this, so if that change will require many further changes, I'd be happy with just a final bug at the end of the chain to move it to Koha::Account. Let me know what you think and reset the status accordingly. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:43:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:43:50 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57877|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 57944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57944&action=edit [SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button on patroncard images To test: 1) Go to Tools -> Patron Card Creator -> Manage images 2) Upload an image if you haven't already 3) Click Delete selected without selecting any images 4) Notice broken behaviour as described in Description 5) Apply patch, refresh page 6) Click Delete selected without selecting any images 7) Notice alert. Click OK 8) Select one image or more, click Delete selected 9) Notice confirm delete message. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:43:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:43:59 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 --- Comment #10 from M. Tompsett --- Created attachment 57945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57945&action=edit [SIGNED-OFF] Bug 15711: Follow up batch_id not used Changed batch_id to image_id in the template, as the multiparam would catch the array case. TEST PLAN --------- 1) attempt to delete a selected item, but get a warning. 2) apply this follow up 3) attempt to delete a selected item, it deletes. 4) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 20:45:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 19:45:18 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- Given that I wrote the follow up, I think another sign off is in order. Additionally, encountered valid_template error unrelated to any of the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 21:13:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 20:13:34 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This implementation is causing some troubles because the koha-indexdefs-to-zebra.xsl is by no means MARC21-only or even biblio-only. To reproduce: - On current master, run: $ xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl - Run: $ git diff => FAIL: The following is added to etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl, thus UNIMARC field 245 is being sent to the Title index @@ -42,6 +43,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) + @@ -2681,6 +2683,19 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) + + + + 0 + + + + + + + + + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 21:52:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 20:52:11 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 21:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 20:52:14 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 57946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57946&action=edit Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed This patch makes Zebra index the 648$9 link for chronological terms on bibliographic records. This way an authority search on chronological terms will show the right number in 'Used in X records' message. To test: - Have a record with a 648 field, linked to an authority record (i.e. with an authid on 648$9). - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => FAIL: the term is linked to our record, but koha shows '0' count. - Apply the patch - Run: $ cd kohaclone $ xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ git diff => SUCCESS: Notice the shipped etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl is up-to-date - Run: $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ sudo koha-restart-zebra kohadev $ sudo koha-rebuild-zebra -f -b -v kohadev - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => SUCCESS: the term is linked to our record, usage count is 1 - Sign off :-D I assume NORMARC is similar on this regard. Feel free to fail it if the NORMARC part of the patch is wrong. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 22:45:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 21:45:55 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change in Perl 5.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Mirko Tietgen --- Works in the master nightly builds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 22:49:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 21:49:39 +0000 Subject: [Koha-bugs] [Bug 8926] deletedborrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8926 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #5 from George Williams (NEKLS) --- I agree, there should be a timestamp field on the deletedborrowers table. I'm willing to bet that the reason there isn't is because there isn't a timestamp on the borrowers table to begin with. All of the other deleted* tables as well as old_issues and old_reserves have timestamps because their corresponding tables all have timestamps. That being said, I did read this before I sat down to write this comment and, based on Katrin's comment, I wrote a report that can get a count of deleted borrowers based on the data in the action logs. It's on the Wiki if anyone needs it (like I did a couple of hours ago when I started poking around in the first place). The value of the timestamp field in borrowers and deletedborrowers would come from making a report like this possible for libraries that don't have the BorrowersLog system preference turned on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 23:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Dec 2016 22:58:19 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mirko Tietgen --- Still needed for 16.05, package build fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 04:31:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 03:31:36 +0000 Subject: [Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Mubassir Ahsan changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 09:46:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 08:46:40 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitdangwal.bbb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 09:47:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 08:47:10 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #15 from Amit --- How google-jackets.js can be used to fetch images in php -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 12:39:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 11:39:05 +0000 Subject: [Koha-bugs] [Bug 8926] deletedborrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8926 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Marcel de Rooy --- What about this: CREATE TABLE `deletedborrowers` ( -- stores data related to the patrons/borrowers you have deleted [...] `updated_on` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, -- time of last change could be useful for synchronization with external systems (among others) See also bug 10459 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 14:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 13:50:43 +0000 Subject: [Koha-bugs] [Bug 17717] New: Can't locate Authen/CAS/Client/Response/Failure.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Bug ID: 17717 Summary: Can't locate Authen/CAS/Client/Response/Failure.pm Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mjnkml at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz On Ubuntu, output of /usr/share/koha/bin/cronjobs/process_message_queue.pl in an email from cron: ourlib: Can't locate Authen/CAS/Client/Response/Failure.pm: ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.22/base.pm line 97. ourlib: ...propagated at /usr/share/perl/5.22/base.pm line 106. ourlib: BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68. ourlib: Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8. . . . process_message_queue.pl is currently invoked from /etc/cron.d/koha-common I don't find any Failure.pm on the system. This only started happening after a recent update which resulted in Bug 17234. Not sure if issues with that may have also affected this. Have done a full reinstall (without Purge) of the packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 14:53:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 13:53:18 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't locate |process_message_queue.pl: |Authen/CAS/Client/Response/ |Can't locate |Failure.pm |Authen/CAS/Client/Response/ | |Failure.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 14:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 13:58:51 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #1 from mjnkml at gmail.com --- Created attachment 57947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57947&action=edit Full error as displayed in the email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 3 15:08:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Dec 2016 14:08:10 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #2 from mjnkml at gmail.com --- After extracting Failure to its own file, process_message_queue.pl runs without a peep. I don't understand enough of Perl to know what's going on. Files end up like this: root at koha:/usr/share/perl5/Authen/CAS/Client# find . ./Response.pm.bak ./Response ./Response/Failure.pm ./Response.pm Failure.pm is cut out of Response.pm: (didn't have much success with multi-line comments!) root at koha:/usr/share/perl5/Authen/CAS/Client# cat Response/Failure.pm require 5.006_001; use strict; use warnings; #====================================================================== # Authen::CAS::Client::Response::Failure # package Authen::CAS::Client::Response::Failure; use base qw/ Authen::CAS::Client::Response /; sub _ATTRIBUTES () { code => undef, message => '', $_[0]->SUPER::_ATTRIBUTES } sub new { my $class = shift; $class->SUPER::new( @_, _ok => 0 ) } sub code { my ( $self ) = @_; $self->{code} } sub message { my ( $self ) = @_; $self->{message} } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 11:36:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 10:36:52 +0000 Subject: [Koha-bugs] [Bug 17718] New: Allow usage of Smartform API (Czech only) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Bug ID: 17718 Summary: Allow usage of Smartform API (Czech only) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: rbit at rbit.cz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Enable to use Smartform API to simplify petron registration process namely address entering. This service allows address autocompletion for any address in the Czech Republic including street names and numbers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 11:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 10:37:03 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 11:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 10:37:24 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com Assignee|koha-bugs at lists.koha-commun |rbit at rbit.cz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 13:50:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 12:50:00 +0000 Subject: [Koha-bugs] [Bug 17704] OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #2 from Mirko Tietgen --- Related: https://lists.katipo.co.nz/public/koha/2016-April/045226.html https://rt.cpan.org/Public/Bug/Display.html?id=102010#txn-1569001 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 19:48:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 18:48:50 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #1 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 57948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57948&action=edit Bug 17718: Smartform API allowed in patron registration Test plan: 1) Apply the patch 2) Setup preferences "SmartformEnable", "SmartformClientID" 3) Edit a patron 4) Start entering street in an address 5) Select a street from autocomplete 6) Continue entering street number and select the right address 7) ZIP and city should get values from autocomplete 8) Disable SmartformEnable and repeat steps above 9) No autocompletion should occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 19:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 18:49:17 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 19:51:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 18:51:43 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #2 from Radek ?iman (R-Bit Technology, s.r.o.) --- Side note: only DE version of address template scripts have changed, because Czech intallations do not need US address version at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:14:12 +0000 Subject: [Koha-bugs] [Bug 17719] New: Cron Overdue Notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17719 Bug ID: 17719 Summary: Cron Overdue Notices Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: carlos.cordovas at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Overdue Notices notice does not work when the "OverdueNoticeCalendar" preference is in calendar use How to play: 1.- set OverdueNoticeCalendar in use calendar 2.- verify that you have users with late payments 3.- Run perl /usr/share/koha/bin/cronjobs/overdue_notices.pl -t -v Found 2 branches with first message enabled: 'library1', 'library2' ... And does not process messages. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:15:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:15:37 +0000 Subject: [Koha-bugs] [Bug 17719] Cron Overdue Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Was the day you ran the script a holiday? In this case the behaviour would be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:19:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:19:30 +0000 Subject: [Koha-bugs] [Bug 17719] Cron Overdue Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17719 --- Comment #2 from Carlos C?rdova --- I run it Sunday, now I understand the behavior. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:29:09 +0000 Subject: [Koha-bugs] [Bug 17719] Cron Overdue Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Yes, if Sunday is one of your holidays, no notices will be generated - that's intentional. Marking resolved fixed for now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:37:20 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CSV generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:37:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:37:53 +0000 Subject: [Koha-bugs] [Bug 17577] Improve sample notices for article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:38:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:38:14 +0000 Subject: [Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:38:48 +0000 Subject: [Koha-bugs] [Bug 17709] Article request broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. Thx for the quick fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:39:18 +0000 Subject: [Koha-bugs] [Bug 17696] Two missing periods in opac-suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:40:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:40:55 +0000 Subject: [Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer --- Decided against backporting this to stable - not a bug fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:44:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:44:47 +0000 Subject: [Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #35 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:44:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:44:48 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Bug 17585 depends on bug 17583, which changed state. Bug 17583 Summary: Use Koha::Patron->is_expired from circulation.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:45:49 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:45:49 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Bug 17553 depends on bug 17580, which changed state. Bug 17580 Summary: Add the Koha::Patron->get_overdues method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:45:50 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Bug 17585 depends on bug 17580, which changed state. Bug 17580 Summary: Add the Koha::Patron->get_overdues method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 4 22:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 21:45:50 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Bug 17584 depends on bug 17580, which changed state. Bug 17580 Summary: Add the Koha::Patron->get_overdues method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 00:40:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Dec 2016 23:40:22 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mail at jkozlovsky.cz |ity.org | Status|In Discussion |ASSIGNED --- Comment #4 from Jiri Kozlovsky --- (In reply to Katrin Fischer from comment #3) I'm sorry for such a delay in my response - there was a lot of job to do. >From today's point of view and existence of the How-To write REST API https://wiki.koha-community.org/wiki/Rest_Api_HowTo we shouldn't take care of the data it flows in or out at the API, but create Koha Object if it doesn't exists yet and use it to pass the data. So, if you suggest to rename collectiontitle to series, just create a new bug for it to compose it into the DB directly - the API will also use it implicitly. The issue between copyrightdate & publicationyear should be handled from within the Koha Object -> I'll submit a new dependent bug for this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 01:47:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 00:47:21 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #3 from mjnkml at gmail.com --- After separating Failure.pm, the emails are now showing the same problem with Success.pm. After extracting Success.pm in the same way, now it complains about Exceptions.pm : Can't locate Koha/Exceptions/Exception.pm: ./Koha/Exceptions/Exception.pm: Permission denied at /usr/share/perl/5.22/base.pm line 97, line 755 Seems like a problem with the build, or (the current version of?) perl not supporting multiple classes within a .pm file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 04:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 03:45:50 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #4 from mjnkml at gmail.com --- Futher, after separating Exception.pm, we get: ourlib: Class Koha::Exceptions::Exception appears to be a typo as it is only specified in the 'isa' param for Koha::Exceptions::Virtualshelves::InvalidInviteKey ourlib: BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Exceptions.pm line 41, line 755. . . Exceptions.pm itself has many references to Exception (I didn't separate all of them). Anyhow, I think all the above problems are just a source of one very small thing which I'm not seeing / understanding. I doubt the classes needed to be separated out... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 05:05:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 04:05:08 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjnkml at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 05:05:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 04:05:40 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 05:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 04:06:29 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #5 from mjnkml at gmail.com --- Separating Exception.pm seemed to have broken other things, so I've backed out of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 05:43:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 04:43:28 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 08:02:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 07:02:03 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #3 from Josef Moravec --- Radek, why did you not use template plugin Koha.Preference for getting SmartformEnable syspref? Is there any demo account on Smartform.cz? Or should I register to pay for this to start testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 08:08:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 07:08:33 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #4 from Josef Moravec --- > Is there any demo account on Smartform.cz? Or should I register to pay for > this to start testing? Forgot this question, I sorted it out: It's enough to register here to start using this service https://secure.smartform.cz/admin/user/create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:00:34 +0000 Subject: [Koha-bugs] [Bug 17720] New: CSRF token is not generated correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Bug ID: 17720 Summary: CSRF token is not generated correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The CSRF token is not generated correctly if the DB password contain unicode characters. Indeed md5_base64 explodes with Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line 63. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:01:38 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17096 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:24:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:24:12 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:24:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:24:15 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 --- Comment #1 from Jonathan Druart --- Created attachment 57949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57949&action=edit Bug 17720: CSRF - Handle unicode characters >From the pod of Digest::MD5: """ Since the MD5 algorithm is only defined for strings of bytes, it can not be used on strings that contains chars with ordinal number above 255 (Unicode strings). The MD5 functions and methods will croak if you try to feed them such input data. What you can do is calculate the MD5 checksum of the UTF-8 representation of such strings. """ Test plan: - Set a MySQL/MariaDB password with unicode characters: UPDATE user SET password=PASSWORD('?') WHERE USER='koha_kohadev'; FLUSH PRIVILEGES - Update your $KOHA_CONF file - Restart Memcached - Hit the files modified by this patch => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:26:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:26:38 +0000 Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 --- Comment #3 from Koha Team Lyon 3 --- (In reply to Mika from comment #2) > 2 identical messages are still created in message_queue when 'perl > ./misc/cronjobs/overdue_notices.pl' is run, both containing both I1 and I2. > Both messages are sent from B1 with B1 addresses. Did you run overdue_notices.pl with the option -a that is introduced by the patch ? perl ./misc/cronjobs/overdue_notices.pl -a B2CODE I realize that my test plan was confusing as far as step 6 is concerned and the use of this new option. So here is a new test plan with corrected step 6 NEW TEST PLAN : 0/ Have (or create) at least two branches B1 and B2. Have (or create) a default notice for all branches in Notices and Slips Module 1/ Make sure you're logged in with an account belonging to B1, or switch to branch B1 2/ checkout item I1 (belonging to B1) to patron P (preferably while specifying a due date < today) 3/ switch to branch B2 4/ checkout item I2 (belonging to B2) to patron P (preferably while specifying a due date < today) 5/ make sure you have defined "Overdue notice/status triggers" for that patron category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is checked. 6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' (optionally specifying also '-library B1 -library B2' ) 7/ Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items 8/ either see the 'content' field in these entries, or run 'perl ./cronjobs/process_message_queue.pl' to receive the actual emails (provided the email is properly setup). Apply patch redo step 6 running the script with the new option -a (all_in_one). this option expect as mandatory parameter the branchcode of the library that you want to make sender of the message. say that 'B2CODE' is the branchcode of B2 branch, it will run like this : perl ./misc/cronjobs/overdue_notices.pl -a B2CODE You will see that only one message had been created. Its content shows both B1 and B2 overdue items and the sender address matches B2 address as well. Olivier crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 09:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 08:29:53 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #9 from Jonathan Druart --- (In reply to Kyle M Hall from comment #8) > I don't want to be *too* much of a pedant, but wouldn't this method be > better in Koha::Account? I see there are a good number of patches that > depend on this, so if that change will require many further changes, I'd be > happy with just a final bug at the end of the chain to move it to > Koha::Account. How would you write this line in that case: my $balance = $patron->get_account_lines->get_balance; (from the patch on bug 17588). Maybe just $patron->get_account_balance then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 12:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 11:52:59 +0000 Subject: [Koha-bugs] [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 12:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 11:53:22 +0000 Subject: [Koha-bugs] [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10798 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 12:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 11:53:22 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17683 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683 [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:13:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:13:58 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57394|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 57950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57950&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:14:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:14:06 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #10 from Jonathan Druart --- Created attachment 57952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57952&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:14:02 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #9 from Jonathan Druart --- Created attachment 57951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57951&action=edit Bug 17600: Remove useless extra spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:14:10 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #11 from Jonathan Druart --- Created attachment 57953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57953&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:14:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:14:13 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #12 from Jonathan Druart --- Created attachment 57954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57954&action=edit [DO NOT PUSH] Script to export the subroutines used This ugly script has been used to generate the last patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:15:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:15:24 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57487|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 57955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57955&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:24:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:24:47 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Marcel de Rooy --- Thanks, Josef, for testing. You can safely ignore these warnings. They are not coming from the changes in this patch set, but from a (unmodified) module used by these plugins. This is the source: $ perl -cw C4/Barcodes/ValueBuilder.pm "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 43. "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 85. C4/Barcodes/ValueBuilder.pm syntax OK If you look at that module, you will see that it actually contains multiple packages and each one having a $DEBUG variable. A construction like that is not recommended and fortunately an exception in Koha, but it should work. The warning is actually dubious. All ready for a signoff ? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:27:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:27:52 +0000 Subject: [Koha-bugs] [Bug 17597] Outdated translation credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Dimitris Antonakis changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:34:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:34:48 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #5 from Marcel de Rooy --- (In reply to Lari Taskula from comment #4) > Just curious, how would you represent the answer to availability (what would > these return)? Initially I was considering the same solution, but the > complexity of availability eventually made me think of putting them it into > own classes. > > I think that all types of availability answers should always be represented > the same, uniform way. It could be a HASHref like in CanBookBeIssued, but I > would prefer an object that contains the availability information > (Koha::Availability in my proposal) but doesn't define and care about the > type of availability; it exists to ensure that we always have the same > operations on availability information (to contain yes/maybe/no value to > availability, to contain and return additional notes, reasons to ask for > confirmation and unavailabilities). Since you spent more time on this already, it might well be that I would also arrive at some unified structure for these responses :) Koha::Availability just seems (at 'first' glance) to be a too prominent place for such a structure (imho). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:39:43 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > % sudo koha-translate --dev kohadev --install es-ES > % ls koha-tmpl/intranet-tmpl/prog|grep es-ES > > Does not return anything, what did I miss? > > I have used a very new script to update the debian files, cp_debian_files.pl > on koha-misc4dev (see https://github.com/joubu/koha-misc4dev). Dumb question, but you checked this? Add the line to koha-conf.xml. (See 16733.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:41:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:41:15 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #5 from Josef Moravec --- (In reply to Marcel de Rooy from comment #4) > > All ready for a signoff ? :) I think so ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:41:59 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:42:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:42:02 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50066|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 57956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57956&action=edit [SIGNED-OFF] Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:45:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:45:57 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart --- So, what's next? It won't be feasible to test all the changes. So we need to decide if it worth the try to push these patches as it. At least it would be great to get a review from someone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:46:23 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #7 from Marcel de Rooy --- (In reply to Josef Moravec from comment #6) > Signed-off-by: Josef Moravec Great! Thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:46:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:46:29 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:47:43 +0000 Subject: [Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart --- So, we finally fix the issue with bug 17599. To continue the discussion and find a more complete solution, see bug 17600. *** This bug has been marked as a duplicate of bug 17599 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:47:43 +0000 Subject: [Koha-bugs] [Bug 17599] Move C4::Circulation::GetIssuingRule to Koha::IssuingRules-> get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599 --- Comment #11 from Jonathan Druart --- *** Bug 17591 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:55:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:55:33 +0000 Subject: [Koha-bugs] [Bug 17721] New: Do we need utf8_bin collation on tagsubfield? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721 Bug ID: 17721 Summary: Do we need utf8_bin collation on tagsubfield? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Comes from report 17676. This discussion should be on a new report. === Comment11 > Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase of the same letter for subfields). Could you provide an example where we want to do that? Is that MARC conform? And if so(!), why would you need utf8_bin to do so? You can still insert them, only finding the right a or A would be harder. It seems to me that we should remove this strange exception, and make sure that all tagsubfields are saved lowercase. Should not be too hard. Can MARC::Record handle subfields a and A btw? But this discussion should be on a new report. > if ( $table[1] !~ /COLLATE=utf8_unicode_ci/ and $table[1] !~ /COLLATE=utf8mb4_unicode_ci/ ) { #catches utf8mb4 collated tables This is only 99,9% safe (as you are probably aware of). If you find one column in unicode_ci, the table might still be something else (theoretically). Perhaps someone added a custom column with collation? Since you only change the default here, why not always do it? Replacing X with X will not be a problem.. Comment12&13 (Katrin) It's not strictly MARC conform, but we use this a lot and I have talked to others using it as well. Take the 952 field as the example - all subfield codes are taken. Using upper case letters works fantastically now and allows you to store and index data that we got no other sensible spot for. We got it all working perfectly, why break this feature without need? Ah, and I think I have encountered upper case in German MARC - just can't find a documentation right now. === Even if we do not change it at all, it would be worth writing somewhere why we do not. (And where we can still find it later.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:55:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:55:57 +0000 Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on tagsubfield? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17676 CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:55:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:55:57 +0000 Subject: [Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17721 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:59:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:59:15 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 13:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 12:59:18 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57949|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 57957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57957&action=edit [SIGNED-OFF] Bug 17720: CSRF - Handle unicode characters >From the pod of Digest::MD5: """ Since the MD5 algorithm is only defined for strings of bytes, it can not be used on strings that contains chars with ordinal number above 255 (Unicode strings). The MD5 functions and methods will croak if you try to feed them such input data. What you can do is calculate the MD5 checksum of the UTF-8 representation of such strings. """ Test plan: - Set a MySQL/MariaDB password with unicode characters: UPDATE user SET password=PASSWORD('?') WHERE USER='koha_kohadev'; FLUSH PRIVILEGES - Update your $KOHA_CONF file - Restart Memcached - Hit the files modified by this patch => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:12:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:12:45 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #5 from Radek ?iman (R-Bit Technology, s.r.o.) --- No registration is required to start testing, just use "smartform" as client ID when working on localhost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:19:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:19:03 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:19:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:19:07 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57943|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 57958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57958&action=edit Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:21:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:21:58 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:22:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:22:01 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57940|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 57959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57959&action=edit Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:24:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:24:27 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:24:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:24:30 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57941|0 |1 is obsolete| | Attachment #57942|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 57960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57960&action=edit Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:24:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:24:34 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 --- Comment #7 from Jonathan Druart --- Created attachment 57961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57961&action=edit Bug 17716: (followup) Remove dep on existing data and tidy This patch removes the requirement for this tests for the DB to include at least 10 borrowers to pass. Borrowers are now created on each run using t::lib::TestBuilder and a loop. Bonus: some tiny changes to tidy the file. To test: - Run: $ prove t/db_dependent/CourseReserves.t SUCCESS => Tests pass with and without the patch. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:27:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:27:30 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:27:34 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57932|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 57962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57962&action=edit Bug 17713: Fix Members.t tests If the category_type is 'S', GetBorrowersToExpunge won't return the patron. Test plan: t/db_dependent/Members.t should always return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:29:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:29:29 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57480|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud --- Created attachment 57963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57963&action=edit Bug #6979 I removed several lines of code in the checkpw_ldap subroutine where LDAP authentication takes place, in the "else" part of the conditional that checks for the auth_by_bind config parameter. I added several lines to check whether the user can log in to LDAP using their DN and the password supplied in the login form. If they are able to bind, login contiues as normal and the LDAP attributes can be harvested as normal if the update options are turned on. The routine that was in place was failing because it was trying to check against a non-existent LDAP entry attribute called 'userpassword'. Instead of checking against a 'userpassword' attribute, the routine really should be checking to make sure the user can actually bind to LDAP. That's what I set up, and it is a safer way to test authentication against LDAP. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:29:37 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57481|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud --- Created attachment 57964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57964&action=edit Bug 6979 - Update tests -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:29:46 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57482|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud --- Created attachment 57965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57965&action=edit Bug 6979 - Handle multiple branches in non-auth_by_bin -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:29:53 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57483|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud --- Created attachment 57966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57966&action=edit Bug 6979 - Fix Already in a transaction error -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:31:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:31:06 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #29 from Alex Arnaud --- Hello Alex, Patches are rebased on master. You can test again. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:32:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:32:23 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > (In reply to Jonathan Druart from comment #5) > > % sudo koha-translate --dev kohadev --install es-ES > > % ls koha-tmpl/intranet-tmpl/prog|grep es-ES > > > > Does not return anything, what did I miss? > > > > I have used a very new script to update the debian files, cp_debian_files.pl > > on koha-misc4dev (see https://github.com/joubu/koha-misc4dev). > > Dumb question, but you checked this? > Add the line to koha-conf.xml. (See 16733.) Nope :) Why don't you use intranetdir? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:37:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:37:31 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 14:37:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 13:37:35 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57957|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 57967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57967&action=edit Bug 17720: CSRF - Handle unicode characters >From the pod of Digest::MD5: """ Since the MD5 algorithm is only defined for strings of bytes, it can not be used on strings that contains chars with ordinal number above 255 (Unicode strings). The MD5 functions and methods will croak if you try to feed them such input data. What you can do is calculate the MD5 checksum of the UTF-8 representation of such strings. """ Test plan: - Set a MySQL/MariaDB password with unicode characters: UPDATE user SET password=PASSWORD('?') WHERE USER='koha_kohadev'; FLUSH PRIVILEGES - Update your $KOHA_CONF file - Restart Memcached - Hit the files modified by this patch => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Edit: removed debugging leftover -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:01:08 +0000 Subject: [Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- This new pref does not affect checkins from the checkouts page (svc/checkin), is it expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:11:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:11:22 +0000 Subject: [Koha-bugs] [Bug 17722] New: t/db_dependent/PatronLists.t doesn' t run inside a transaction Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Bug ID: 17722 Summary: t/db_dependent/PatronLists.t doesn't run inside a transaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:15:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:15:13 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Jonathan Druart --- Ok so, a lot of things is broken with these patches: - from tests: use_ok should be be used since it does not export subroutines - from pm: subroutines are not exported sometimes whereas the script assumes they were things are working when they are expecting not to (get_template_and_user from C4::Auth is not exported by scripts use it and it works). Maybe it would be easier not to export anything and use fully qualified names instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:17:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:17:40 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #7) > > (In reply to Jonathan Druart from comment #5) > > > % sudo koha-translate --dev kohadev --install es-ES > > > % ls koha-tmpl/intranet-tmpl/prog|grep es-ES > > > > > > Does not return anything, what did I miss? > > > > > > I have used a very new script to update the debian files, cp_debian_files.pl > > > on koha-misc4dev (see https://github.com/joubu/koha-misc4dev). > > > > Dumb question, but you checked this? > > Add the line to koha-conf.xml. (See 16733.) > > Nope :) > Why don't you use intranetdir? dev_install tells you too that this is a gitified install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:21:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:21:22 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:21:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:21:26 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 57968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57968&action=edit Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:21:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:21:51 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:22:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:22:00 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:22:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:22:00 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:22:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:22:19 +0000 Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Jonathan Druart --- Upgrading severity to get attention -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:33:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:33:30 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #6 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 57969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57969&action=edit Bug 17718: Used Koha.preference instead of passing params to templates from module memberentry.pl Test plan: 1) Apply the patch 2) Setup preferences "SmartformEnable", "SmartformClientID" (register at smartform.cz or use "smartform" as the client ID) 3) Show/hide streetnumber as desired in BorrowerUnwantedField pref (eg. fill in "streetnumber|B_streetnumber") 4) Edit a patron 5) Start entering street in an address field 6) Select a street from autocomplete 7) Continue entering street number and select the right address 8) ZIP and city should get values from autocomplete 9) Disable SmartformEnable and repeat steps above 10) No autocompletion should occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:36:54 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #7 from Radek ?iman (R-Bit Technology, s.r.o.) --- Address templates allow to use street number merged into one field with the street name or separately as two fields. Autocomplete should work correctly without problems regardless the settings in BorrowerUnwantedField system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:48:06 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:48:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:48:09 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57955|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 57970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57970&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 15:49:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 14:49:52 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Framework is updated in at least two other subs, the framework is passed in to the subs and not pulled from the record so I don't see any problem with not updating it first. Editing a record works, updating framework works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:07:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:07:49 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:11:36 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:11:49 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:12:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:12:41 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:12:53 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:19:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:19:10 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #4 from Nick Clemens --- Applying: Bug 17584: Add the Koha::Patron->get_issues method fatal: sha1 information is lacking or useless (Koha/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17584: Add the Koha::Patron->get_issues method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:20:28 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:20:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:20:54 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #50 from Nick Clemens --- fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17578: GetMemberDetails - Remove GetMemberDetails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:23:44 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:28:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:28:58 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:32:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:32:10 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:33:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:33:24 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:33:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:33:27 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57365|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 57971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57971&action=edit Bug 17584: Add the Koha::Patron->get_issues method Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:33:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:33:31 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:35:11 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:35:15 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57825|0 |1 is obsolete| | Attachment #57826|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 57972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57972&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:35:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:35:23 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #52 from Jonathan Druart --- Created attachment 57973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57973&action=edit But 17578: (followup) amountoutstanding Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 16:57:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 15:57:04 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > (In reply to Kyle M Hall from comment #8) > > I don't want to be *too* much of a pedant, but wouldn't this method be > > better in Koha::Account? I see there are a good number of patches that > > depend on this, so if that change will require many further changes, I'd be > > happy with just a final bug at the end of the chain to move it to > > Koha::Account. > > How would you write this line in that case: > my $balance = $patron->get_account_lines->get_balance; > (from the patch on bug 17588). > > Maybe just $patron->get_account_balance then? I would do $patron->account()->balance() with account() returning the Koha::Account object, and balance() returning the account balance. Of course, I'm a fan of being succinct ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:30:31 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #3 from George Williams (NEKLS) --- Tried to test in the sandbox but I kept getting an error message saying "CONFLICT (content): Merge conflict in C4/Reserves.pm" George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:42:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:42:26 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:42:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:42:29 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57817|0 |1 is obsolete| | --- Comment #53 from Nick Clemens --- Created attachment 57974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57974&action=edit Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:42:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:42:44 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57818|0 |1 is obsolete| | --- Comment #54 from Nick Clemens --- Created attachment 57975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57975&action=edit Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:42:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:42:52 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57819|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 57976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57976&action=edit Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:01 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57820|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 57977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57977&action=edit Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:09 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57821|0 |1 is obsolete| | --- Comment #57 from Nick Clemens --- Created attachment 57978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57978&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:16 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57822|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 57979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57979&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:24 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57823|0 |1 is obsolete| | --- Comment #59 from Nick Clemens --- Created attachment 57980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57980&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:34 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57972|0 |1 is obsolete| | --- Comment #60 from Nick Clemens --- Created attachment 57981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57981&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:43:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:43:42 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #61 from Nick Clemens --- Created attachment 57982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57982&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:44:06 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57973|0 |1 is obsolete| | --- Comment #62 from Nick Clemens --- Created attachment 57983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57983&action=edit But 17578: (followup) amountoutstanding Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 17:44:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 16:44:13 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #63 from Nick Clemens --- Created attachment 57984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57984&action=edit QA Follow - Adjust number of tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 18:13:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 17:13:21 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 18:13:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 17:13:24 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57849|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 57985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57985&action=edit Bug 15822: Fix 500 error when searching if items.onloan=0000-00-00 The calls output_pref({ dt => dt_from_string( $date ) }) are wrong and should be replaced with output_pref({ str => $date }) For better error handling. Here we fix the problem of items.onloan when searching Test plan: - Set items.onloan=0000-00-00 (UPDATE items SET onloan='0000-00-00') This can come from old data or bad migration - Execute a search => Without this patch you get Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225. => With this patch you won't get the error Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 19:13:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 18:13:28 +0000 Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774 fooquency at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fooquency at gmail.com --- Comment #3 from fooquency at gmail.com --- On Ubuntu 14.04, I found that installing koha, which installs mpm-itk broke Exim4 mail sending. I found, as per the references below, that adding the following directive to the top-level Apache configuration resolved the problem: LimitUIDRange 0 2000 The description above sounds like a very similar problem. http://blog.gaiterjones.com/send-php-mail-ubuntu-upgrade/ https://esilibrary.com/evergreen-and-koha-sitting-on-a-server/ http://mpm-itk.sesse.net/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 19:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 18:25:07 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Nick Clemens --- couple things: POD fails QA tools opac/external/overdrive/auth.pl has wrong description (copy/paste error) When attempting to cancel a hold from results or patron details error is displayed at top of page: The title is not checked out. at /usr/local/share/perl/5.14.2/WebService/ILS/OverDrive/Patron.pm line 571. This is awesome overall though! Nice addition of ability to checkout/download/hold titles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 19:26:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 18:26:29 +0000 Subject: [Koha-bugs] [Bug 17723] New: Using MySQL on external server - lack of documentation giving example Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17723 Bug ID: 17723 Summary: Using MySQL on external server - lack of documentation giving example Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: fooquency at gmail.com I am trying to create a Koha instance using MySQL on a remote server. https://wiki.koha-community.org/wiki/Debian#Create_a_Koha_instance states: "create a new file in its place containing the connection information for the server, in the form of a my.cnf file." but no example is given. I would assume this somehow allows specification of all of hostname, username and password, but it is entirely unclear currently how to do this. Could someone kindly add an example or give more details of what format exactly "the connection information" should be in? http://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html has no mention of a password configuration for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:00:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:00:17 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #21 from Tom?s Cohen Arazi --- I spent a couple hours on this. And now have to leave for Manuel's birthday :-D So, for the record: - I narrowed the problem down to the sub days_between. Which is called in the failing scripts. The only way to reproduce this (in order to create the unit tests) was: $ENV{TZ} = $timezone; use POSIX qw(tzset); tzset; my $tz = C4::Context->tz; my $chile_dt = DateTime->new( day => 6, month => 9, year => 2015, time_zone => $tz ); my $now_dt = DateTime->now; my $branch = $builder->build({ source => 'Branch' })->{branchcode}; my $calendar = Koha::Calendar->new( branchcode => $branch ); my $diff = $calendar->days_between($now_dt,$chile_dt); Using the other suspected functions didn't trigger the problem (exception_holidays, etc)[1]. So the problem was correctly highlighted by David, but I'm not sure what's the best place to fix it. I vote for days_between. I'll try to resume tomorrow, and will be glad to hear people's comments, specially David, that created the patch. [1] Using truncate didn't raise the problem to me, either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:16:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:16:51 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 mourik jan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heupink at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:48:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:48:05 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:48:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:48:09 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57968|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 57986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57986&action=edit [SIGNED-OFF] Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:52:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:52:22 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #30 from Alex Buckley --- Re: Comment 29 Hello Alex, Patches are rebased on master. You can test again. Thanks Alex. As I am new to Koha would it be possible to have a clearer test plan for this patch for me to follow in my testing? Cheers Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:56:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:56:57 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 20:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 19:58:58 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:28:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:28:07 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:28:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:28:43 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:29:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:29:01 +0000 Subject: [Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:29:21 +0000 Subject: [Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:30:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:30:08 +0000 Subject: [Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 21:33:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 20:33:09 +0000 Subject: [Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 --- Comment #13 from Katrin Fischer --- There is a follow-up for this on the master branch with a wrong bug number. It won't be needed in stable releases: Bug 17586 [QA Followup] - Correct the number of unit tests 46432511a600f0f22b35d004ee47eb573a33f94f -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:32:06 +0000 Subject: [Koha-bugs] [Bug 17724] New: Callnumber not copied into serial issue, when callnumber subfield is linked to a plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17724 Bug ID: 17724 Summary: Callnumber not copied into serial issue, when callnumber subfield is linked to a plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To test: - Make sure your 952$o (callnumber) is linked to a plugin such as cn_browser.pl in your frameworks - Create a subscription with "create item on receive" and a callnumber - Receive an issue - Verify that the callnumber is not copied into the item on receive - Remove the plugin from the framework - Verify that the callnumber now is copied into the item on receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:35:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:35:20 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Bug 11844 depends on bug 10855, which changed state. Bug 10855 Summary: Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:35:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:35:19 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:35:21 +0000 Subject: [Koha-bugs] [Bug 16723] Add additional subscription fields to serial claim notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723 Bug 16723 depends on bug 10855, which changed state. Bug 10855 Summary: Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:35:21 +0000 Subject: [Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Bug 16565 depends on bug 10855, which changed state. Bug 10855 Summary: Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 5 23:42:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Dec 2016 22:42:46 +0000 Subject: [Koha-bugs] [Bug 17725] New: Repeating a field or subfield clones content Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Bug ID: 17725 Summary: Repeating a field or subfield clones content Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 07:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 06:34:17 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Josef Moravec --- Sorry, QA tool complains: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc FAIL tt_valid lines 12, 47, 72, 84 FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-de.inc FAIL tt_valid lines 36, 60, 72 FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc FAIL tt_valid lines 35, 47, 71, 83 It's related to HTML1 point of coding guidelines I think. But the functionality is OK so, when you fix this, I am going to sign-off ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:03:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:03:10 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57930|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 57987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57987&action=edit Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:03:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:03:14 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 --- Comment #11 from Jonathan Druart --- Created attachment 57988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57988&action=edit Bug 17586: Replace ->get_account_lines with ->account And return a Koha::Account instead of a Koha::Account::Lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:04:02 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 --- Comment #12 from Jonathan Druart --- Created attachment 57989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57989&action=edit Bug 17585: Replace ->get_account_lines with ->account And return a Koha::Account instead of a Koha::Account::Lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:04:24 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:04:51 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Created attachment 57989 [details] [review] > Bug 17585: Replace ->get_account_lines with ->account > > And return a Koha::Account instead of a Koha::Account::Lines See bug 17586 comment 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:14:10 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:14:14 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57929|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 57990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57990&action=edit Bug 17586: Add the Koha::Account::Lines->get_balance method Test plan: prove t/db_dependent/Accounts.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:14:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:14:19 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #12 from Jonathan Druart --- Created attachment 57991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57991&action=edit Bug 17586: Move ->get_balance to Koha::Account->balance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:16:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:16:32 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #10) > I would do $patron->account()->balance() with account() returning the > Koha::Account object, and balance() returning the account balance. Of > course, I'm a fan of being succinct ; ) I am not 100% this change is the right thing to do but we could go like that to start. For now, the Koha::Account module's responsibilities are not clearly defined and it's not easy to guess what it will become. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:18:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:18:10 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:20:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:20:29 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:20:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:20:29 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:24:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:24:08 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57339|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 57992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57992&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:24:13 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #3 from Jonathan Druart --- Created attachment 57993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57993&action=edit Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:40:12 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #9 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 57994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57994&action=edit Bug 17718: Fixed QA tool complains I don't fully understand the reason, but I had run the tool without any errors. Now I did my best according to coding guidelines, I hope. Test plan: 1) Apply the patch 2) Setup preferences "SmartformEnable", "SmartformClientID" (register at smartform.cz or use "smartform" as the client ID) 3) Show/hide streetnumber as desired in BorrowerUnwantedField pref (eg. fill in "streetnumber|B_streetnumber") 4) Edit a patron 5) Start entering street in an address field 6) Select a street from autocomplete 7) Continue entering street number and select the right address 8) ZIP and city should get values from autocomplete 9) Disable SmartformEnable and repeat steps above 10) No autocompletion should occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:40:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:40:45 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 09:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 08:41:52 +0000 Subject: [Koha-bugs] [Bug 17704] OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:21:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:21:10 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57948|0 |1 is obsolete| | Attachment #57969|0 |1 is obsolete| | Attachment #57994|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 57995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57995&action=edit [SIGNED-OFF] Bug 17718: Smartform API allowed in patron edit form Test plan: 1) Apply the patch 2) Setup preferences "SmartformEnable", "SmartformClientID" (register at smartform.cz or use "smartform" as the client ID) 3) Show/hide streetnumber as desired in BorrowerUnwantedField pref (eg. fill in "streetnumber|B_streetnumber") 4) Edit a patron 5) Start entering street in an address field 6) Select a street from autocomplete 7) Continue entering street number and select the right address 8) ZIP and city should get values from autocomplete 9) Disable SmartformEnable and repeat steps above 10) No autocompletion should occur Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:22:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:22:48 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #11 from Josef Moravec --- I squashed the patches to simplify history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:50:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:50:23 +0000 Subject: [Koha-bugs] [Bug 17726] New: TestBuilder's refactoring removed default values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Bug ID: 17726 Summary: TestBuilder's refactoring removed default values Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Reading the commit message of bug 16155, it was expected to remove the default values for given fields. But actually I think we should reintroduce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:55:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:55:32 +0000 Subject: [Koha-bugs] [Bug 17727] New: A lot of tests fail if SearchEngine is set to Elastic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727 Bug ID: 17727 Summary: A lot of tests fail if SearchEngine is set to Elastic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The items.more_subfields_xml is set to random data (generated by TestBuilder), and so GetMarcBiblio does not manage to embed items (if needed). The error is: :1: parser error : Start tag expected, '<' not found More precisely it explodes in C4::Items::_parse_unlinked_item_subfields_from_xml when MARC::Record->new_from_xml is called with an invalid xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:55:56 +0000 Subject: [Koha-bugs] [Bug 17727] A lot of tests fail if SearchEngine is set to Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:55:56 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727 [Bug 17727] A lot of tests fail if SearchEngine is set to Elastic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:57:21 +0000 Subject: [Koha-bugs] [Bug 17727] A lot of tests fail if SearchEngine is set to Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17726 --- Comment #1 from Jonathan Druart --- I'd recomend to add a default value (undef/NULL) for items.more_subfields_xml in TestBuilder, not to modify everywhere we build a new item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:57:21 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17727 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:57:47 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #1 from Jonathan Druart --- See bug 17727 for a use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 10:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 09:58:03 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 11:21:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 10:21:09 +0000 Subject: [Koha-bugs] [Bug 17449] Let users choose action in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 11:21:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 10:21:12 +0000 Subject: [Koha-bugs] [Bug 17449] Let users choose action in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 --- Comment #3 from Magnus Enger --- Created attachment 57996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57996&action=edit Bug 17449 - Let users choose action in self checkout Currently if you have a stack of 15 books that you want to renew through the self checkout, you need to read the barcode of each item and then click "renew" for each of them. Same for returning books. One of my customers wants to change the SCO screen so that users can choose the action they want to take up front, then let them do the 15 renewals by just scanning the barcodes. This patch uses "Bootstrap tabs". I tried using "jQuery tabs", in a similar way to how it is done in e.g. record detail display in the OPAC. This resulted in weird conflicts between jQuery and Bootstrap, hence the the use of Bootstrap for the final patch. To test: - Apply this patch - Make sure self check is enabled - Log in to self check - Process some barcodes, first by borrowing, then renewing, then returning. Verify that the selected tab is still active and has focus after each barcode has been processed. - Now try "illegal" actions and check that you get appropriate responses: - Try to borrow a barcode you have already borrowed. - Try to return a barcode that you have not already borrowed. - Etc. - Try this with and without AllowSelfCheckReturns Sponsored-by: Hylte Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 11:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 10:43:04 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #14 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > (In reply to Kyle M Hall from comment #10) > > I would do $patron->account()->balance() with account() returning the > > Koha::Account object, and balance() returning the account balance. Of > > course, I'm a fan of being succinct ; ) > > I am not 100% this change is the right thing to do but we could go like that > to start. > For now, the Koha::Account module's responsibilities are not clearly defined > and it's not easy to guess what it will become. That's fine. I just wanted to put that thought out. We may have a better notion of where such a method would go after the fact and we can make that change at the end rather then have to modify all the dependent patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 11:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 10:43:13 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 11:43:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 10:43:16 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57986|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 57997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57997&action=edit Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:09:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:09:29 +0000 Subject: [Koha-bugs] [Bug 17728] New: Move C4::Reserves code to the Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Bug ID: 17728 Summary: Move C4::Reserves code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:09:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:09:29 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:13:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:13:15 +0000 Subject: [Koha-bugs] [Bug 17729] New: Move IsItemOnHoldAndFound to Koha::Holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 Bug ID: 17729 Summary: Move IsItemOnHoldAndFound to Koha::Holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:13:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:13:42 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #17 from Jonathan Druart --- Bug 17728 - Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:14:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:14:07 +0000 Subject: [Koha-bugs] [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:14:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:14:07 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17729 --- Comment #1 from Jonathan Druart --- Bug 17729 - Move IsItemOnHoldAndFound to Koha::Holds Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:15:21 +0000 Subject: [Koha-bugs] [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 --- Comment #1 from Jonathan Druart --- Created attachment 57998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57998&action=edit Bug 17729: Move IsItemOnHoldAndFound to Koha::Holds I don't think this is ready yet, since we are in loops, that can introduce speed improvement regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 12:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 11:42:25 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #45 from Zeno Tajoli --- Hi Johathan, I'm testig the patches in this bug. I think there is a problem in "Bug 17196: follow-up for bug 17088". Now is mandatory, bug 17088 is into the source. The result of "prove Record.t" is: Record.t .. DBIx::Class::Row::store_column(): No such column 'format' on Koha::Schema::Result::Biblioitem at /production/koha/install/bug17196/Koha/Object.pm line 71 # Looks like your test exited with 255 before it could output anything. Record.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/4 subtests In fact a'format' column is not present in table biblioitems. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 13:04:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 12:04:12 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #15 from Jonathan Druart --- (In reply to Kyle M Hall from comment #14) > (In reply to Jonathan Druart from comment #13) > > (In reply to Kyle M Hall from comment #10) > > > I would do $patron->account()->balance() with account() returning the > > > Koha::Account object, and balance() returning the account balance. Of > > > course, I'm a fan of being succinct ; ) > > > > I am not 100% this change is the right thing to do but we could go like that > > to start. > > For now, the Koha::Account module's responsibilities are not clearly defined > > and it's not easy to guess what it will become. > > That's fine. I just wanted to put that thought out. We may have a better > notion of where such a method would go after the fact and we can make that > change at the end rather then have to modify all the dependent patches. I have modified the dependent patches, so let's go with it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 13:33:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 12:33:42 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn' t activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 13:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 12:59:24 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #2 from Marcel de Rooy --- The way is was hardcoded in the past, was not particularly attractive; removal made the code simpler. You can always pass a value via the value parameter. In this specific case of marcxml field, we should probably call a routine that ensures the consistency between the marcxml and related fields (outside the namespace of TestBuilder). That said, I would not mind reintroducing a (better) default.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 14:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 13:11:27 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com Status|In Discussion |Failed QA Assignee|koha-bugs at lists.koha-commun |alex.sassmannshausen at ptfs-e |ity.org |urope.com --- Comment #9 from Alex Sassmannshausen --- My intention is to add atomicupdate, and ensure this still applies nicely on master in order to submit it. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 14:17:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 13:17:44 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #3 from Jonathan Druart --- I am a bit worried about adding this default value to all the tests creating an item (and track the future ones not to forget to pass the default value). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 14:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 13:37:42 +0000 Subject: [Koha-bugs] [Bug 17730] New: Uniform mapping for biblio.biblionumber (Unimarc) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17730 Bug ID: 17730 Summary: Uniform mapping for biblio.biblionumber (Unimarc) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: dubyk at library.lviv.ua QA Contact: testopia at bugs.koha-community.org Created attachment 57999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57999&action=edit Screenshot I try to deal with empty links to record details in the search. I found that this occurs when used mapping 090$9<>biblio.biblionumber (in uk-UA Unimarc tables) and typical use UNIMARCslim2intranetResults.xsl. In Koha mapping of biblio.biblionumber and MARC-fields mentioned in many files: etc / zebradb / marc_defs / unimarc / biblios / record.abs 25 melm 001 Local-number,Local-number:n 26 # Local-number (biblionumber can be either in 090$9 or, on some setup, on 001) 28 melm 090$9 Local-number,Local-number:n etc / zebradb / marc_defs / unimarc / biblios / biblio-koha-indexdefs.xml 9 10 Local-number:n 11 20 21 Local-number:w 22 Local-number:n 23 etc / zebradb / marc_defs / unimarc / biblios / biblio-zebra-indexdefs.xsl 47 48 49 50 51 52 53 54 63 64 65 66 67 68 69 70 71 koha-tmpl / opac-tmpl / bootstrap / en / xslt / UNIMARCslim2OPACDetail.xsl 21 koha-tmpl / intranet-tmpl / prog / en / xslt / UNIMARCslim2intranetDetail.xsl 22 koha-tmpl / opac-tmpl / bootstrap / en / xslt / UNIMARCslim2OPACResults.xsl 25 koha-tmpl / intranet-tmpl / prog / en / xslt / UNIMARCslim2intranetResults.xsl 25 t / db_dependent / Biblio.t 84 'biblio.biblionumber' => { tagfield => '999', tagsubfield => 'c' }, biblio.biblionumber in UNIMARC-tables: ru-RU 090^9 es-ES 001^@ en 001^@ fr-FR 001^@ pl-PL 999^9 it-IT 001^@ uk-UA 090^9 That is, in the context of biblio.biblionumber mentioned next subfields: 090^9 001^@ 999^9 090^a 999^c Probably for greater uniformity is better to use one subfield for biblio.biblionumber. Maybe 001^@? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 14:53:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 13:53:27 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > I am a bit worried about adding this default value to all the tests creating > an item (and track the future ones not to forget to pass the default value). Yeah. Maybe we should not call _gen_text for a "xml field" but create some 'random' xml that fits better.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:06:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:06:07 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57842|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 58000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58000&action=edit Bug 17196: follow-up for bug 17088 If bug 17088 is pushed first, we will need this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:06:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:06:33 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #47 from Jonathan Druart --- Hi Zeno, Yes, thanks for reporting. Last patch should fix the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:36:27 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se --- Comment #6 from Stefan Berndtsson --- I get pretty much the exact same error when trying a koha-rebuild-zebra, so I think this is a bit more generic than the message queue. The error occurs in a file not supplied by Koha, and when called from a core perl file for perl 5.22. It seems 5.18 (the perl version from Ubuntu 14.04) does things differently than 5.22 does. It all looks weird, because the CAS code from Ubuntu 14.04 is pretty much the same as the one from 16.04, so that method of using multiple modules in a single file seems to have worked better back then. I think I'll have to back out to 14.04 again for the time being, without being able to run plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:36:51 +0000 Subject: [Koha-bugs] [Bug 17731] New: noxml option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Bug ID: 17731 Summary: noxml option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:37:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:37:11 +0000 Subject: [Koha-bugs] [Bug 17731] Remove noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|noxml option |Remove noxml option from | |rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:40:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:40:14 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 58001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58001&action=edit Bug 16376: (regression tests) This patch introduces a regression test for exception_holidays. This routine returns a list of datetimes to be used in date comparison and some datetimes don't exist in some timezones, so floating timezones should be used instead. To test: - Apply the patch on master - Run: $ prove t/db_dependent/Holidays.t => FAIL: The new test fails Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:40:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:40:23 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51968|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 58002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58002&action=edit Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago Using a DateTime object with a timezone of America/Santiago was causing fatal errors for Koha::Calendar->is_holiday and Koha::Calendar->exception_holidays, when the objects were truncated to an invalid local time. Using a floating zone allows us to use the same day, month, year for comparison purposes without running into the possibility of creating an invalid local time and thus a fatal software error. Edit: While the changes to is_holiday and single_holiday make sense (Jonathan agrees too) I didn't manage to have them fail, because truncate is not failing in my trials, but days_between. So to me, it narrows down to have exception_holiday return floating tz datetime objects so it doesn't break days_between. Anyway, it is ok to push this patch, and the regression test I provide covers this scenario I'm describing. To test: - Apply the regression tests patch - Run: $ prove t/db_dependent/Holidays.t => FAIL: Unexpected error due to bad timezone/date combination - Apply this patch - Run: $ prove t/db_dependent/Holidays.t => SUCCESS: Tests pass Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:40:37 +0000 Subject: [Koha-bugs] [Bug 17731] Remove noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:40:42 +0000 Subject: [Koha-bugs] [Bug 17731] Remove noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #1 from Jonathan Druart --- Created attachment 58003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58003&action=edit Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:41:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:41:02 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Remove noxml option from |Remove the noxml option |rebuild_zebra.pl |from rebuild_zebra.pl Depends on| |10455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 [Bug 10455] remove redundant 'biblioitems.marc' field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:41:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:41:02 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 [Bug 17731] Remove the noxml option from rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 15:42:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 14:42:29 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 17:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 17733] New: Members.t is still failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Bug ID: 17733 Summary: Members.t is still failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 [Bug 17713] Members.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 17:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 17713] Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 [Bug 17733] Members.t is still failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 17:12:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 16:12:40 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 17:12:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 16:12:43 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #1 from Jonathan Druart --- Created attachment 58005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58005&action=edit Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 20:14:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 19:14:15 +0000 Subject: [Koha-bugs] [Bug 7543] Update NORMARC support to the 2012-01-19 revision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7543 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 20:16:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 19:16:27 +0000 Subject: [Koha-bugs] [Bug 7543] Update NORMARC support to the 2012-01-19 revision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7543 --- Comment #2 from Magnus Enger --- (In reply to Tom?s Cohen Arazi from comment #1) > Is this still valid? Yup, I should get around to doing all the updates since this some day. Not a lot of demand for it though... :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 20:24:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 19:24:14 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 21:09:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 20:09:46 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 21:09:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 20:09:49 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58005|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 58006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58006&action=edit [SIGNED OFF] Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 21:10:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 20:10:22 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- We need this to make Jenkins go green! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 6 22:12:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Dec 2016 21:12:52 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #48 from Josef Moravec --- So, I started to test this, it looks good so far only few thing: 1. build_oai_sets.pl script does return this error on every biblio: (biblio 3) Error while creating record from marcxml: Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. 2. When I click on tag in opac, I get ISE, the log says: Can't locate object method "subfield" via package " References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 08:02:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 07:02:00 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #49 from Martin Renvoize --- (In reply to Martin Renvoize from comment #33) No response to this :( Personally, I'd use JSON as both Postgres (https://www.postgresql.org/docs/current/static/datatype-json.html) and MySQL (https://dev.mysql.com/doc/refman/5.7/en/json.html) have pretty extensive support for marked performance gains using JSON typed fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 08:51:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 07:51:48 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #50 from Jonathan Druart --- (In reply to Martin Renvoize from comment #49) > (In reply to Martin Renvoize from comment #33) > > No response to this :( > > Personally, I'd use JSON as both Postgres > (https://www.postgresql.org/docs/current/static/datatype-json.html) and > MySQL (https://dev.mysql.com/doc/refman/5.7/en/json.html) have pretty > extensive support for marked performance gains using JSON typed fields. The first goal of these patches is to move the data out of this table to bring speed improvement. Afterwards we will think about what we can do with this new table :) As you know, we are not ready yet to support another DBMS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:33:32 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:34:06 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:34:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:34:25 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:38:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:38:16 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #51 from Jonathan Druart --- Created attachment 58007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58007&action=edit Bug 17196: Fix build_oai_sets.pl The wrong value was retrieved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:38:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:38:21 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #52 from Jonathan Druart --- Created attachment 58008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58008&action=edit Bug 17196: Update POD of sanitise_records.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 09:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 08:40:46 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #53 from Jonathan Druart --- (In reply to Josef Moravec from comment #48) > So, I started to test this, it looks good so far > > only few thing: > > 1. build_oai_sets.pl script does return this error on every biblio: > (biblio 3) Error while creating record from marcxml: Empty String at > /usr/share/perl5/MARC/File/XML.pm line 448. Will be fixed by Bug 17196: Fix build_oai_sets.pl > 2. When I click on tag in opac, I get ISE, the log says: > Can't locate object method "subfield" via package " encoding="UTF-8"?> 3. The usage text for --auto-search paramater in sanitize_records.pl still > says: "Automatically search records containing "&" in > biblioitems.marcxml or in the specified fields." Will be fixed by Bug 17196: Update POD of sanitise_records.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 11:07:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 10:07:47 +0000 Subject: [Koha-bugs] [Bug 17734] New: Make possible to pay and writeoff from boraccount page and make action buttons split button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Bug ID: 17734 Summary: Make possible to pay and writeoff from boraccount page and make action buttons split button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 11:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 10:08:36 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |rbit at rbit.cz Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 11:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 10:12:48 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 11:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 10:12:48 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:10:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:10:56 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:10:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:10:59 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #1 from Josef Moravec --- Created attachment 58009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58009&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:11:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:11:04 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #2 from Josef Moravec --- Created attachment 58010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58010&action=edit Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:18:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:18:54 +0000 Subject: [Koha-bugs] [Bug 17735] New: Merge boraccount and pay pages into one Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Bug ID: 17735 Summary: Merge boraccount and pay pages into one Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We don't really need to have this agenda on two pages - using the one pages would be simpler and makes the workflow more straightforward -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:19:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:19:49 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:19:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:19:49 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:19:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:19:49 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Status|NEW |ASSIGNED Depends on| |17734 Blocks| |17596 CC| |black23 at gmail.com, | |rbit at rbit.cz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:29:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:29:41 +0000 Subject: [Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:29:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:29:43 +0000 Subject: [Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 --- Comment #3 from Nick Clemens --- Created attachment 58011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58011&action=edit Bug 17668: Fix typo in parcel.pl - listinct vs listincgst This typo has been introduced by commit eed14b080db8691f371b4c19f1a190b87fcc396a Bug 13001: Refactor VAT and price calculation - parcel page So before the tax rewrite (13321, 13323). It sounded weird to me that testers did not catch the bug on this page. To understand the logic: Conditions are listincgst, invoiceincgst Conditions | Before this patch | If we fix the typo | After this patch 0 0 | excluded | excluded | excluded 0 1 | included | included | included 1 0 | excluded | excluded | excluded 1 1 | included | included | included Test plan: Create 4 vendors with the difference combinations Create a basket, add an order (with a tax) and receive it Confirm that the different values displayed on the parcel page are correct Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 12:42:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 11:42:38 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es --- Comment #2 from Hugo Agud --- We have applied the patch and it works.. just a litle note, there is a mispelling in the test plan Instead of sudo xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl the right one is sudo xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 13:01:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 12:01:17 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #16 from Nick Clemens --- This works, one issue is that the pref allows you to enter any number of decimals. These are then displayed in full on the dropdowns, however, they are saved into the db truncated. Example: In gist preference: .12345 Shows in dropdowns as: 12.345% Saves to db as: .1235 Shows in order/basket tables as: 12.35% We should either truncate the dropdowns or add a warning in the system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 13:38:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 12:38:15 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #54 from Zeno Tajoli --- Hi Jonathan, I think there problems on "Fix query builder for item search". I try to do a search with a personalized index based on 245$c. The search doesn't use the index based on 245$c. But it use the standard indexes (based on table 'items'). No errors in intranet logs Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 14:55:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 13:55:06 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #55 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #54) > Hi Jonathan, > > I think there problems on "Fix query builder for item search". > I try to do a search with a personalized index based on 245$c. > The search doesn't use the index based on 245$c. > But it use the standard indexes (based on table 'items'). > > No errors in intranet logs > > Bye Hi Zeno, I am not sure to understand correctly what you mean. Which index did you create? Did you confirm that what you describe is not the same behaviour as in master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:06:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:06:21 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #56 from Zeno Tajoli --- Hi, I go here:Home ? Administration ? Item search fields and I add a index based on tag 245$c. But I check the default here: http://kohastaffsandbox.ptfs-europe.co.uk and also on master it doesn't work. So it is an other bug. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:39:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:39:49 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #57 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #56) > I go here:Home ? Administration ? Item search fields and I add a index based > on tag 245$c. > But I check the default here: > http://kohastaffsandbox.ptfs-europe.co.uk and also on master it doesn't work. > So it is an other bug. Ok thanks, so please report it on another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:46:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:46:49 +0000 Subject: [Koha-bugs] [Bug 17736] New: Move GetReservesFromBiblionumber to Koha::Biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Bug ID: 17736 Summary: Move GetReservesFromBiblionumber to Koha::Biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:47:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:47:20 +0000 Subject: [Koha-bugs] [Bug 17737] New: Move GetReservesFromItemnumber to Koha::Item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Bug ID: 17737 Summary: Move GetReservesFromItemnumber to Koha::Item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:47:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:47:48 +0000 Subject: [Koha-bugs] [Bug 17738] New: Move GetReservesFromBorrowernumber to Koha::Patron-> get_holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Bug ID: 17738 Summary: Move GetReservesFromBorrowernumber to Koha::Patron->get_holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:47:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:47:54 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromItemnumber |GetReservesFromItemnumber |to Koha::Item |to Koha::Item->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:47:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:47:58 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromBiblionumber |GetReservesFromBiblionumber |to Koha::Biblio |to Koha::Biblio->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:48:45 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:48:45 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17736, 17737, 17738 --- Comment #2 from Jonathan Druart --- Bug 17736 - Move GetReservesFromBiblionumber to Koha::Biblio->get_holds Bug 17737 - Move GetReservesFromItemnumber to Koha::Item->get_holds Bug 17738 - Move GetReservesFromBorrowernumber to Koha::Patron->get_holds Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:48:45 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:48:45 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:00 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:00 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:08 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:08 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:17 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:49:17 +0000 Subject: [Koha-bugs] [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:55:11 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromBiblionumber |GetReservesFromBiblionumber |to Koha::Biblio->get_holds |to Koha::Biblio->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:55:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:55:24 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromItemnumber |GetReservesFromItemnumber |to Koha::Item->get_holds |to Koha::Item->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:55:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:55:29 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromBorrowernumb |GetReservesFromBorrowernumb |er to |er to Koha::Patron->holds |Koha::Patron->get_holds | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 15:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 14:56:02 +0000 Subject: [Koha-bugs] [Bug 17739] New: Opac explodes when clicking on user tag when using elastic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739 Bug ID: 17739 Summary: Opac explodes when clicking on user tag when using elastic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org The log says: Can't locate object method "subfield" via package "get_holds method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Bug ID: 17740 Summary: Add the Koha::Patron->get_holds method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:17:51 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 [Bug 17630] Add the Koha::Biblio->holds method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:17:51 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:18:11 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 [Bug 17740] Add the Koha::Patron->get_holds method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:18:11 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:23:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:23:08 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:25:05 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57884|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58012&action=edit Bug 17630: Add the Koha::Biblio->holds method This method will be useful to get the current holds placed on a given bibliographic record. Test plan: prove t/db_dependent/Koha/Biblios.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:25:19 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 --- Comment #5 from Jonathan Druart --- Just a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:47:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:47:24 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 16:47:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 15:47:28 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57000|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 58013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58013&action=edit Bug 14876 - Show number of holds per record on the search results This patch sues the existing plugin Koha::Template::Plugin::Biblio->HoldsCount To be consistent with current behaviour 'Holds (0)' is shown when no holds have been placed on an item To test: 1 - Search in staff 2 - Note holds link has no extra information 3 - Apply patch 4 - prove -v t/db_dependent/Template/Plugin/Holds.t 5 - Do search in staff that returns records with some holds (i.e. place some holds) 6 - Note the number of holds now displays next to the text of the link: Holds (#) Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:12:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:12:37 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:12:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:12:39 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 --- Comment #1 from Jonathan Druart --- Created attachment 58014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58014&action=edit Bug 17740: Add the Koha::Patron->holds method The goal of this method is to replace C4::Reserves::GetReservesFromBorrowernumber but could be reused for something else, that's why it has its own bug report. Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:17:46 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #17 from Kyle M Hall --- (In reply to Nick Clemens from comment #16) > This works, one issue is that the pref allows you to enter any number of > decimals. These are then displayed in full on the dropdowns, however, they > are saved into the db truncated. > > Example: > > In gist preference: .12345 > > Shows in dropdowns as: 12.345% > > Saves to db as: .1235 > > Shows in order/basket tables as: 12.35% > > > We should either truncate the dropdowns or add a warning in the system > preference The database is limited to 4 digits of precision. I think for the time being a warning on the system preference should be sufficient. I *do* think the order/basket tables should show 12.345%. We should not be rounding where we don't need to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:06 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:10 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #1 from Jonathan Druart --- Created attachment 58015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58015&action=edit Bug 17736: Add the Koha::Biblio->holds_placed_before_today method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:13 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #2 from Jonathan Druart --- Created attachment 58016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58016&action=edit Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds The C4::Reserve::GetReservesFromBiblionumber took 3 parameters, the biblionumber, an optional itemnumber and a "all_dates" flag. If set, the subroutine returned all the holds placed on a given bibliographic record, even the ones placed in the future. Almost all of the calls had this flag set, they will be replaced with a call to Koha::Biblio->holds. But 5 did not have it: - C4::Biblio::DelBiblio -tools/batch_delete_records.pl => These 2 were wrong, we want to retrieve the holds to cancel them before deleting the record. We need to get all the holds, even the ones placed in the future /!\ CHANGE IN THE BEHAVIOR - acqui/parcel.pl => 1 call per item were made to this subroutine. They have been replaced with only 1 call to the new method Koha::Biblios->holds_placed_before_today Then we filter on the itemnumbers. I think this is wrong: we need the number of holds to know if the record can be deleted, so even if future holds exist, the deletion should not be possible. - serials/routing-preview.pl - C4::ILSDI::Services::GetRecords - C4::SIP::ILS::Item->new => Seems ok, we just one to display holds placed before today Test plan: I would suggest to test this patch with patches from bug 17737 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:16 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #3 from Jonathan Druart --- Created attachment 58017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58017&action=edit Bug 17736: Remove C4::Reserves::GetReservesFromBiblionumber At this point, there should not be any occurrences of GetReservesFromBiblionumber left in the codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:53 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:56 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #1 from Jonathan Druart --- Created attachment 58018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58018&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:59 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17729 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:24:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:24:59 +0000 Subject: [Koha-bugs] [Bug 17729] Move IsItemOnHoldAndFound to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17736 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:25:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:25:00 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #2 from Jonathan Druart --- Created attachment 58019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58019&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:25:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:25:58 +0000 Subject: [Koha-bugs] [Bug 17739] Opac explodes when clicking on user tag when using elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:25:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:25:58 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739 [Bug 17739] Opac explodes when clicking on user tag when using elastic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:26:37 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:26:40 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 --- Comment #1 from Jonathan Druart --- Created attachment 58020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58020&action=edit Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds This patch replace the different calls to GetReservesFromBorrowernumber with a calls to Koha::Patron->get_holds. In some places we need to get a restricted set of holds, that's why we process a search on this holds returned by ->get_holds (on the found status for instance). The changes are quite trivial and reading the diff should be enough to catch bugs. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17737, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:26:43 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 --- Comment #2 from Jonathan Druart --- Created attachment 58021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58021&action=edit Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber At this point, there should not be any occurrences of GetReservesFromBorrowernumber anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:27:34 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #18 from Kyle M Hall --- > The database is limited to 4 digits of precision. I think for the time being > a warning on the system preference should be sufficient. I *do* think the > order/basket tables should show 12.345%. We should not be rounding where we > don't need to. Had a brain fart there. 12.245% would be truncated because of the db limit. As such, only the warning is necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:33:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:33:39 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:33:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:33:39 +0000 Subject: [Koha-bugs] [Bug 17741] New: Use Koha::Patron->holds in Koha::Patron->delete Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Bug ID: 17741 Summary: Use Koha::Patron->holds in Koha::Patron->delete Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17740 There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 [Bug 17740] Add the Koha::Patron->get_holds method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:35:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:35:18 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 17:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 16:35:21 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 --- Comment #1 from Jonathan Druart --- Created attachment 58022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58022&action=edit Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 20:39:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 19:39:59 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 20:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 19:40:04 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:07:21 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 NancyK. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us --- Comment #1 from NancyK. --- My staff is asking for this option. We have a branch closed for remodeling and it would have been great to allow patrons to redirect their unfilled holds to another location. Redirecting after it is in-transit isn't as important. NancyK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:23:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:23:17 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #58 from Josef Moravec --- (In reply to Jonathan Druart from comment #53) > (In reply to Josef Moravec from comment #48) > > > 2. When I click on tag in opac, I get ISE, the log says: > > Can't locate object method "subfield" via package " > encoding="UTF-8"?> > It's a bug from master, please open a new bug report. > Note that it only happens when SearchEngine=Elastic Done in bug 17739 as you have seen ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:24:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:24:49 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #59 from Josef Moravec --- Created attachment 58023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58023&action=edit [SIGNED-OFF] Bug 17196: Move marcxml out of the biblioitems table Two discussions on koha-devel lead to the same conclusion: biblioitems.marcxml should be moved out this table - biblio and biblioitems http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html - biblioitems.marcxml & biblioitems.marc / HUGE performance issue ! http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html There are several goals to do it: - Performance As Paul Poulain wrote, a simple query like SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY publicationyear; takes more than 10min on a DB with more than 1M bibliographic records but only 3sec (!) on the same DB without the biblioitems.marcxml field Note that priori to this patch set, the biblioitems.marcxml was not retrieved systematically, but was, at least, in C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders - Flexibility Storing the marcxml in a specific table would allow use to store several kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats (marcflavour) - Clean code It would be a first step toward Koha::MetadataRecord for bibliographic records (not done in this patch set). Test plan: - Update the DBIC Schema - Add / Edit / Delete / Import / Export bibliographic records - Add items - Reindex records using ES - Confirm that the following scripts still work: * misc/cronjobs/delete_records_via_leader.pl * misc/migration_tools/build_oai_sets.pl - Look at the reading history at the OPAC (opac-readingrecord.pl) - At the OPAC, click on a tag, you must see the result Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108. Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:24:57 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #60 from Josef Moravec --- Created attachment 58024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58024&action=edit [SIGNED-OFF] Bug 17196: Fix query builder for item search The item search needs to join on biblio_metadata to allow search on marcxml field Test plan: Launch complex item searches (using marc fields). Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:04 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #61 from Josef Moravec --- Created attachment 58025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58025&action=edit [SIGNED-OFF] Bug 17196: Update misc/maintenance/sanitize_records.pl Test plan: Use the sanitize_records.pl maintenance script with the --auto-search option Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:11 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #62 from Josef Moravec --- Created attachment 58026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58026&action=edit [SIGNED-OFF] Bug 17196: Update switch_marc21_series_info.pl Not sure if this script is still used, could someone confirm? Test plan: If you know how to test it, please do Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:26 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #64 from Josef Moravec --- Created attachment 58028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58028&action=edit [SIGNED-OFF] Bug 17196: Simplify tests for the different marc flavours centralize the way MARC field are set. Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:18 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #63 from Josef Moravec --- Created attachment 58027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58027&action=edit [SIGNED-OFF] Bug 17196: DB Changes Remove biblioitems.marcxml and deletedbiblioitems.marcxml and adds 2 table biblio_metadata and deletedbiblio_metadata Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:33 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #65 from Josef Moravec --- Created attachment 58029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58029&action=edit [SIGNED-OFF] Bug 17196: Fix - Update metadata on update Signed-off-by: Mason James Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:41 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #66 from Josef Moravec --- Created attachment 58030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58030&action=edit [SIGNED-OFF] Bug 17196: follow-up for bug 17088 If bug 17088 is pushed first, we will need this patch. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:25:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:25:56 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #67 from Josef Moravec --- Created attachment 58031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58031&action=edit [SIGNED-OFF] Bug 17196: Fix build_oai_sets.pl The wrong value was retrieved. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:26:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:26:56 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:26:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:26:59 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57835|0 |1 is obsolete| | Attachment #57836|0 |1 is obsolete| | Attachment #57837|0 |1 is obsolete| | Attachment #57838|0 |1 is obsolete| | Attachment #57839|0 |1 is obsolete| | Attachment #57840|0 |1 is obsolete| | Attachment #57841|0 |1 is obsolete| | Attachment #58000|0 |1 is obsolete| | Attachment #58007|0 |1 is obsolete| | Attachment #58008|0 |1 is obsolete| | --- Comment #68 from Josef Moravec --- Created attachment 58032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58032&action=edit [SIGNED-OFF] Bug 17196: Update POD of sanitise_records.pl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 22:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 21:42:23 +0000 Subject: [Koha-bugs] [Bug 17742] New: Test t/db_dependent/Patrons.t can fail randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Bug ID: 17742 Summary: Test t/db_dependent/Patrons.t can fail randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: josef.moravec at gmail.com QA Contact: gmcharlt at gmail.com Tests on line 75 and 81 can sometimes, the failing line is: is( dt_from_string($b1_new->updated_on), dt_from_string, "borrowers.updated_on should have been set to now on creating" ); And the problem could more often happen on slower machines... We are testing the date and time of updated_on, but creating the test patrons, retrieving tested patron and test itself definitely takes some (short) time... which sometimes can be on the edge of a second and you can see this: # Failed test 'borrowers.updated_on should have been set to now on creating' # at t/db_dependent/Patrons.t line 75. # got: '2016-12-06T20:44:25' # expected: '2016-12-06T20:44:26' and also, the both tests on line 75 and 81 are the same, which is not intended I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:00:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:00:40 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:00:42 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 --- Comment #1 from Josef Moravec --- Created attachment 58033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58033&action=edit Bug 17742: Fix t/db_dependent/Patrons.t Moves the getting of testing date for updated_on just after the storing the test patron data to make the gap between generating data and now date as short as possible Changes test #7 to the one which was probably originally intended Test plan 1. prove t/db_dependent/Patrons.t 2. read the diff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:03:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:03:06 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:03:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:03:09 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58022|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 58034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58034&action=edit [SIGNED-OFF] Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:19:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:19:47 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:19:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:19:50 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->get_holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58014|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 58035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58035&action=edit [SIGNED-OFF] Bug 17740: Add the Koha::Patron->holds method The goal of this method is to replace C4::Reserves::GetReservesFromBorrowernumber but could be reused for something else, that's why it has its own bug report. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 7 23:28:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Dec 2016 22:28:12 +0000 Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 03:56:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 02:56:29 +0000 Subject: [Koha-bugs] [Bug 16493] acq matching on title and author In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #30 from Mason James --- Pushed to 16.05.x, will be in 16.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 04:04:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 03:04:27 +0000 Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Blocked by new-feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 04:15:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 03:15:49 +0000 Subject: [Koha-bugs] [Bug 17377] ES - control fields are not taken into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17377 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, will be in 16.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 04:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 03:24:13 +0000 Subject: [Koha-bugs] [Bug 17663] Forgotten userpermissions from bug 14686 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, will be in 16.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 08:34:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 07:34:29 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- This is a bad bug, the export is an important feature of the item search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 08:56:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 07:56:24 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost , withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 daltonfury42 at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daltonfury42 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 09:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 08:38:48 +0000 Subject: [Koha-bugs] [Bug 17743] New: Item search: indexes build on MARC do not work in item' s search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Bug ID: 17743 Summary: Item search: indexes build on MARC do not work in item's search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org In Items search(Home ? Catalog ? Item search ) it is possible to insert personal indexes based on MARC tags and subfields. Those indexes are managed by Item search fields (Home ? Administration ? Item search fields). But now in master indexes based on 245$c (and others tags like 260, 001, etc.) doesn't work. If I use it, the system doesn't do any filter on data; it list all records with an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:12:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:12:59 +0000 Subject: [Koha-bugs] [Bug 17744] New: OAI: oai_dc has no element named dcCollection Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Bug ID: 17744 Summary: OAI: oai_dc has no element named dcCollection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 12252 OAI GetRecord and ListRecords, when called with metadataPrefix=oai_dc, return something like this: ... ... According to http://www.openarchives.org/OAI/2.0/oai_dc.xsd there is no dcCollection element in oai_dc. Moreover the OAI Repository Explorer (http://re.cs.uct.ac.za/) returns errors about this: [Error] re.ZeDK9z:3:756: cvc-complex-type.2.4.a: Invalid content was found starting with element 'oai_dc:dcCollection'. One of '{"http://www.openarchives.org/OAI/2.0/oai_dc/":dc}' is expected. Some other OAI harvesting tools also fail to parse the response successfully. I found a discussion about this: https://lists.katipo.co.nz/public/koha/2016-April/045130.html There is a patch provided (https://lists.katipo.co.nz/public/koha/2016-April/045283.html) but no bug was opened. This is a regression caused by bug 12252, and it affects all versions since 3.22 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 [Bug 12252] OAI-PMH GetRecord result doesn't include item data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:12:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:12:59 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 [Bug 17744] OAI: oai_dc has no element named dcCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:15:47 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 --- Comment #1 from Julian Maurice --- Created attachment 58036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58036&action=edit Bug 17744: Remove the oai_dc:dcCollection wrapper in OAI responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:19:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:19:15 +0000 Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 --- Hi, Is someone still working on this ? Cheers, Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:19:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:19:22 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice --- Test plan: 1. Empty system preference OAI-PMH:ConfFile 2. Go to http://opac.tld/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 3. Confirm you have oai_dc:dcCollection element in 4. Apply patch 5. Repeat 2 6. Confirm you don't have oai_dc:dcCollection element in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:55:36 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58023|0 |1 is obsolete| | --- Comment #69 from Zeno Tajoli --- Created attachment 58037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58037&action=edit Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:56:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:56:18 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58024|0 |1 is obsolete| | --- Comment #70 from Zeno Tajoli --- Created attachment 58038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58038&action=edit Fix query builder for item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 10:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 09:59:50 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #71 from Zeno Tajoli --- Created attachment 58039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58039&action=edit [SIGNED-OFF] Bug 17196: Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:00:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:00:41 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58037|0 |1 is obsolete| | Attachment #58038|0 |1 is obsolete| | --- Comment #72 from Zeno Tajoli --- Created attachment 58040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58040&action=edit [SIGNED-OFF] Bug 17196: Fix query builder for item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:01:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:01:15 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #73 from Zeno Tajoli --- Created attachment 58041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58041&action=edit [SIGNED-OFF] Bug 17196: Update misc/maintenance/sanitize_records.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:02:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:02:02 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58025|0 |1 is obsolete| | Attachment #58026|0 |1 is obsolete| | --- Comment #74 from Zeno Tajoli --- Created attachment 58042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58042&action=edit [SIGNED-OFF] Bug 17196: Update switch_marc21_series_info.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:02:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:02:43 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58027|0 |1 is obsolete| | --- Comment #75 from Zeno Tajoli --- Created attachment 58043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58043&action=edit [SIGNED-OFF] Bug 17196: DB Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:03:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:03:15 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58028|0 |1 is obsolete| | --- Comment #76 from Zeno Tajoli --- Created attachment 58044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58044&action=edit [SIGNED-OFF] Bug 17196: Simplify tests for the different marc flavours -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:03:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:03:52 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58029|0 |1 is obsolete| | --- Comment #77 from Zeno Tajoli --- Created attachment 58045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58045&action=edit [SIGNED-OFF] Bug 17196: Fix - Update metadata on update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:04:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:04:27 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58030|0 |1 is obsolete| | --- Comment #78 from Zeno Tajoli --- Created attachment 58046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58046&action=edit [SIGNED-OFF] Bug 17196: follow-up for bug 17088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:04:57 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #79 from Zeno Tajoli --- Created attachment 58047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58047&action=edit [SIGNED-OFF] Bug 17196: Fix build_oai_sets.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:05:26 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58031|0 |1 is obsolete| | Attachment #58032|0 |1 is obsolete| | --- Comment #80 from Zeno Tajoli --- Created attachment 58048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58048&action=edit [SIGNED-OFF] Bug 17196: Update POD of sanitise_records.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:07:32 +0000 Subject: [Koha-bugs] [Bug 17745] New: Notices does not generate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17745 Bug ID: 17745 Summary: Notices does not generate Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 58049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58049&action=edit Notices screenshot Dear Friends, My friends and me got problem regarding notices. Our Koha version is 16.05.5 Checked out 3 books. Notice (Digest) sent by Koha. It includes 3 books details. When the books check in two notices generated and sent, third book notice notice not generate by Koha. See the screen shot. https://s23.postimg.org/5klk9em63/Sent_notices_for_Vimal_Kumar_2.png -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:23:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:23:15 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This develop moves marcxml release notes| |out of the biblioitems | |table and inserts it inside | |two new tables: | |biblio_metadata and | |deletedbiblio_metadata. SQL | |query on table biblioitems | |will boost on performance. | |Storing the marcxml in a | |specific table would allow | |use to store several kind | |of metadata (USMARC, | |MARCXML, MIJ, etc.) and | |different formats | |(marcflavour). | |ATTENTION: | |all reports that use XPATH | |to retrive MARC tags from | |biblioitems.marcxml need to | |be updated/rewritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:24:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:24:14 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #81 from Zeno Tajoli --- I have done a second sign-off and written notes about this develop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 11:39:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 10:39:57 +0000 Subject: [Koha-bugs] [Bug 17747] New: Missing extension name .t: /t/db_dependent/ Koha_Elasticsearch. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17747 Bug ID: 17747 Summary: Missing extension name .t: /t/db_dependent/Koha_Elasticsearch. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: faceker at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 12:46:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 11:46:19 +0000 Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 12:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 11:47:27 +0000 Subject: [Koha-bugs] [Bug 13405] System information has misleading information about indexing mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13405 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 14:00:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 13:00:06 +0000 Subject: [Koha-bugs] [Bug 17748] New: Show due date and availability in item search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Bug ID: 17748 Summary: Show due date and availability in item search results Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After searching an item, i. e. with barcode, you can't see wheter it is checked out or not. Therefore the due date and / or the availability of the item would be very helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 15:03:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 14:03:52 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Christian Stelzenm?ller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 18:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 17:20:07 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 18:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 17:20:11 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57872|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 58050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58050&action=edit Bug 14541: Do not truncate tax rate values Tax rates are stored in decimal(6,4) fields which means that 4 decimals are allowed. If a tax rate is 8.42%, it is stored as 0.0842 If a tax rate has more precision than that, Koha won't deal correctly with it. We will need to update the DB structure. With this patch, the tax rate will be displayed with the same precision as in the DB. So if you enter 8.42, you will see 8.42% instead of 8.4% without this patch. Test plan: Do a full acquisition workflow with a tax rate like 8.42% and confirm that it is correctly displayed. Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 18:20:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 17:20:18 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #20 from Nick Clemens --- Created attachment 58051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58051&action=edit Bug 14541 (QA followup) Add warning to gist system preference Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 19:33:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 18:33:15 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org --- Comment #3 from Chris Kirby --- I tested this too, but I get "Compilation failed in require at Koha/ArticleRequest.pm" and "Compilation failed in require at Koha/Patron.pm" errors. And the tests fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:21:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:21:32 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #2 from Lisette --- We have this as well. If 1 item has no holds allowed and the other is checked out the no holds allowed will show up on the holds list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:43:25 +0000 Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer alerts librarian about next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 --- Comment #10 from Nick Clemens --- Created attachment 58052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58052&action=edit Bug 17010 FOLLOWUP fix typo waitingreserves.p#[% tab %] should be waitingreserves.pl#[% tab %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:53:33 +0000 Subject: [Koha-bugs] [Bug 17749] New: Missing l in '.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Bug ID: 17749 Summary: Missing l in '.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:53:50 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing l in '.pl |Missing l in '.pl' in link | |on waitingreserves.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:54:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:54:14 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:55:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:55:50 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:55:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:55:52 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 --- Comment #1 from Nick Clemens --- Created attachment 58053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58053&action=edit Bug 17749 - Missing l in '.pl' in link on waitingreserves.tt Fixes a small typo introduced by Bug 17010 waitingreserves.p#[% tab %] should be waitingreserves.pl#[% tab %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:56:07 +0000 Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer alerts librarian about next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:56:07 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 [Bug 17010] Canceling a hold awaiting pickup no longer alerts librarian about next hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 8 20:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Dec 2016 19:56:49 +0000 Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer alerts librarian about next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Attachment #58052|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Comment on attachment 58052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58052 Bug 17010 FOLLOWUP fix typo Moved followup to bug 17749 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 01:16:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 00:16:18 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #6 from Barton Chittenden --- I'm raising the priority on this -- I'm getting more support tickets about this, primarily from libraries who have come to Koha since we aggregated the notice templates in 3.16 -- when we made the switch, using the 'email' template was logical, because they're always at the top, and at the time there was no way to collapse the templates, so it would have seemed to users that their slips had 'disappeared' if they weren't at the top of the list... but now, since users have to click on the template that they want to edit in order to expand the template for editing, choosing 'print' is now the logical choice, and users are confused when the edits that they've made to the print template don't appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 01:16:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 00:16:38 +0000 Subject: [Koha-bugs] [Bug 12809] Failures in Koha notifications systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12809 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 01:32:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 00:32:33 +0000 Subject: [Koha-bugs] [Bug 7374] can't upload icon for auth values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 06:27:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 05:27:27 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 08:20:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 07:20:31 +0000 Subject: [Koha-bugs] [Bug 17745] Notices does not generate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17745 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think this happens because of the timing. Notices are usually sent out every 15 minutes. The system will collect items for check-in and check-out notices within this timeframe. Your notices were sent out at :15 - so my guess is that while the first notice was processed, the check-in happened and so another notice was generated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 09:10:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 08:10:16 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > Test plan: > The easiest is to trust me Best plan ever? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 09:28:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 08:28:41 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy --- Hmm. I manipulated guarantorid of some borrower (with your calculation ;) And the first time I ran the test, it failed: not ok 65 - TrackLastPatronActivity - 2 patrons must be deleted # Failed test 'TrackLastPatronActivity - 2 patrons must be deleted' # at t/db_dependent/Members.t line 363. # got: '1' # expected: '2' not ok 66 - TrackLastPatronActivity - 3 patrons must be deleted # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' # at t/db_dependent/Members.t line 365. # got: '2' # expected: '3' As expected, the test did not fail when running it again. So you need to remove some guarantorids here too. GetBorrowersToExpunge checks for this column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 09:31:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 08:31:48 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:38:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:38:00 +0000 Subject: [Koha-bugs] [Bug 13321] Fix tax and prices calculation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now the method where the release notes| |prices are calculated uses | |the equations listed on the | |wiki page | |(http://wiki.koha-community | |.org/wiki/GST_Rewrite_RFC). | |The idea is to create | |additional DB fields to | |store value tax included | |and tax excluded. | |This | |patch adds 7 columns to the | |aqorders table: | |* | |unitprice_tax_excluded * | |unitprice_tax_included | |* | |rrp_tax_excluded * | |rrp_tax_included | |* | |ecost_tax_excluded * | |ecost_tax_included | |* | |tax_value | |It also renames: | |* aqorders.gstrate with | |aqorders.tax_rate | |* | |aqbooksellers.gstrate with | |aqbooksellers.tax_rate | |Check your SQL reports on | |tax and price. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:40:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:40:33 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 --- Comment #6 from Marcel de Rooy --- Created attachment 58054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58054&action=edit Bug 17493 Improve OAI Server tests Add several tests for OAI Servers. TEST PLAN: - Check that after aplying this patch, this still works: prove -v t/db_dependent/OAI/Server.t - Read the test to see what has been added: - Testing process simplification - ListIdentifiers verb with resumption token, until the whole catalog is harvested - ListRecords verb with resumption token, until the whole catalog is harvested - Returned metadata returned is tested, marcxml & oai_dc Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:40:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:40:38 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 --- Comment #7 from Marcel de Rooy --- Created attachment 58055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58055&action=edit Bug 17493: [QA Follow-up] Foreach loop and module Few cosmetic changes. Removed TestBuilder. Rearranged modules (added one). Whitespace changes. For loop instead of a map statement. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:40:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:40:57 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:40:59 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:41:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:41:14 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:41:20 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch add an 'Add release notes| |multiple copies' button on | |the new order page in | |acquisitions. | |While | |processing the multiple | |copies a modal is | |displayed. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:41:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:41:43 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:44:02 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #4 from Josef Moravec --- Created attachment 58056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58056&action=edit Holds Trying to delete record with hold (title, or item level) through batch delete records tool: Bibliographic record 1 was not deleted. An error occurred. (The error was: Can't use string ("Koha::Biblio") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Object.pm line 219. , see the Koha log file for more information). Also, when returned reserved document has to be transfered, after the checking in on target library, everything looks ok. But the hold is not set to waiting status, see attached screenshot. It was title level hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:45:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:45:01 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #5 from Josef Moravec --- Created attachment 58057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58057&action=edit Hold Detail Maybe the transit was not finished correctly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:46:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:46:56 +0000 Subject: [Koha-bugs] [Bug 16738] Improve EDIFACT messages template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes several release notes| |improvements to the EDIFACT | |messages template to make | |it more consistent with | |similar interfaces in Koha. | |Changes to edimsg.tt are | |made to simplify the | |display of the data in a | |modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:50:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:50:02 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #47 from Marcel de Rooy --- QA: Looking here now. Rebasing first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:52:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:52:26 +0000 Subject: [Koha-bugs] [Bug 17414] Add GIR codes added to Edifact since 1.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17414 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |New 4 GIR codes have been release notes| |added to Edifact since | |version 1.2. | |Now the list | |of recognized GIR codes is | |complete and these codes | |can be used in future | |development. | |LHC - Library | |Holding Code: may hold a | |combination of information | |including location, | |sequence, item type etc. as | |a single data string | |(contents defined by the | |library). | |LRP - Library | |Rotation Plan: a code | |number assigned by a | |library to identify a | |rotation plan to which an | |item belongs. | |LSC - | |Statistical category: a | |code used by a library to | |identify a statistical | |category (e.g. ?605? or | |?Children?s Picture Books?) | |for management reporting | |purposes. | |RIC - Reader | |Interest Category: code to | |identify stock at a lower | |level than LST (Stock | |Category) eg. Western, | |Science Fiction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 10:52:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 09:52:37 +0000 Subject: [Koha-bugs] [Bug 17414] Add GIR codes added to Edifact since 1.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17414 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:00:26 +0000 Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides AutoLocation security feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Signed Off --- Comment #15 from Hugo Agud --- I have applied the patches... Autolocation on configuring propertly ip it allows me to enter to the restricted library, I am able to enter to another library (with another user) it works fine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:03:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:03:18 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #2 from Benjamin Rokseth --- good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:04:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:04:00 +0000 Subject: [Koha-bugs] [Bug 11921] Move memcached configuration back to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The configuration settings release notes| |for specifying the | |memcached server is moved | |back to koha-conf.xml. | |Passing that information | |via an environment variable | |breaks badly on Plack. | |It | |would allow command line | |scripts and cron jobs to | |also make use of caching. | |Not only plack. | |ATTENTION | |on update: if you update | |from a config with | |memcached in koha-http.conf | |without Plack and you want | |to use Plack, you need to | |port memcached conf in | |koha-conf.xml by hand. | |If | |you don't use Plack, you | |can leave memcached conf in | |koha-http.conf, but for the | |future is still better to | |migrate the conf by hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:11:56 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now we could find a plugin release notes| |based on some metadata tag | |as returned by the plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:15:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:15:16 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53853|0 |1 is obsolete| | Attachment #53854|0 |1 is obsolete| | Attachment #56844|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 58058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58058&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in timestamp order (faster than biblionumber order with the new index). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:15:21 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #49 from Marcel de Rooy --- Created attachment 58059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58059&action=edit Remove Koha::AtomicUpdater dependency Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:15:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:15:26 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #50 from Marcel de Rooy --- Created attachment 58060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58060&action=edit Bug 15108: Fix OAI Server tests Tests introduced by bug 17493 must be amended to accomodate the new resumption tokens (with time) returned by OAI Server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:16:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:16:06 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #51 from Marcel de Rooy --- Just a rebase to begin with. Note that we had merge markers in one of those patches too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:18:56 +0000 Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now we have defined several release notes| |namespaces for our cache | |system. | |Instance sysprefs, | |koha conf (koha-conf.xml) | |and unit tests | |are defined | |in a separate namespace. | |This permit to: launch the | |tests without interfering | |with other cache values; | |flush the sysprefs cache | |without flushing all other | |values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:24:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:24:17 +0000 Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Now we have defined several |Now we have defined several release notes|namespaces for our cache |namespaces for our cache |system. |system. Instance sysprefs, |Instance sysprefs, |koha conf (koha-conf.xml) |koha conf (koha-conf.xml) |and unit tests are defined |and unit tests |in a separate namespace. |are defined |This permit to: launch the |in a separate namespace. |tests without interfering |This permit to: launch the |with other cache values; |tests without interfering |flush the sysprefs cache |with other cache values; |without flushing all other |flush the sysprefs cache |values. |without flushing all other |About update: there |values |are changes on koha.psgi, | |check your situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:29:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:29:03 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #52 from Marcel de Rooy --- Created attachment 58061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58061&action=edit Bug 15108: [QA Follow-up] Remove the sleep If we order by biblionumber within the same timestamp, there is no need to wait two seconds. Test is 20 seconds faster too. (Especially the last 2 seconds were very annoying :-) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:30:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:30:13 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set adds a new release notes| |table | |authorised_value_categories | |to store authori(s|z)ed | |value categories into a | |separate table. The | |problematic is explained on | |bug 15799 comment 4: | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15799#c4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:33:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:33:48 +0000 Subject: [Koha-bugs] [Bug 17274] Add info about which memcached config is used to about.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The memcached config can be release notes| |read from ENV or | |koha-conf.xml | |In order to | |remove any ambiguity, now | |we inform the user which | |config is used in About | |Koha > Server information | |page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:35:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:35:10 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Frederic, Can you confirm that 15108 would actually resolve this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:38:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:38:55 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:39:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:39:23 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Added a new Zebra index release notes| |"Other-control-number" | |covering | | MARC21 035$a, | |035$z and 035 (entire tag). | |To display it in Intranet | |search and in Opac search | |you need to use javascript | |to list it. Not present in | |template files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:44:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:44:13 +0000 Subject: [Koha-bugs] [Bug 9259] Delete marc batches from staged marc management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now is possible to delete a release notes| |staged file once it has | |been cleaned. If a clean | |could be 'undo', a delete | |no. So use delete only when | |you realy want to erase the | |file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:46:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:46:37 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a syspref release notes| |"AggressiveMatchOnISSN" | |allowing for a match of | |ISSNs with or without | |hyphens. | |It uses | |Business::ISSN in order to | |follow the use of | |Business::ISBN and allow | |for validation of ISSNs. | |It is equivalent to the | |aggressive ISBN matcher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:48:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:48:20 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58058|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy --- Created attachment 58062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58062&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in timestamp order (faster than biblionumber order with the new index). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:48:24 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58059|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy --- Created attachment 58063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58063&action=edit Remove Koha::AtomicUpdater dependency Signed-off-by: Frederic Demians EDIT: Extension should be .perl [Otherwise it will not be executed at all.] This file is just temporary, needs no license. Followed the new skeleton file here. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:48:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:48:28 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58060|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy --- Created attachment 58064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58064&action=edit Bug 15108: Fix OAI Server tests Tests introduced by bug 17493 must be amended to accomodate the new resumption tokens (with time) returned by OAI Server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:48:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:48:33 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58061|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy --- Created attachment 58065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58065&action=edit Bug 15108: [QA Follow-up] Remove the sleep If we order by biblionumber within the same timestamp, there is no need to wait two seconds. Test is 20 seconds faster too. (Especially the last 2 seconds were very annoying :-) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:49:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:49:01 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #57 from Marcel de Rooy --- Only adjusted dbrev now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 11:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 10:59:00 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #58 from Marcel de Rooy --- Hm I have serious doubts about my last fourth patch. Will the adjusted order by undo the performance gain from the new indexes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 12:07:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 11:07:59 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58065|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Comment on attachment 58065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58065 Bug 15108: [QA Follow-up] Remove the sleep Obsoleting it. We need to make the test more intelligent some other way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 12:44:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 11:44:42 +0000 Subject: [Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- (In reply to M. Tompsett from comment #6) > Created attachment 52870 [details] [review] > Bug 16746: Proposed start of counter-patch > > This is the beginning of a counter patch. > Feel free to apply it and test it, Juan Romay Sieira. > However, please expand the test plan to be more > detailed: > > -- type X into field Y > -- click button Z > -- click downdrop W > -- select item V > -- enter 'text' into text box labelled A > > "Add a new authority that exists in your > authority server, Koha will now find none." > is not detailed enough for a person unfamiliar with the > interface. > > Feel free to apply 16809 first. :) Are you going to continue on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 12:49:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 11:49:01 +0000 Subject: [Koha-bugs] [Bug 15255] Deleted items still visible in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15255 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |josef.moravec at gmail.com Status|In Discussion |RESOLVED --- Comment #4 from Josef Moravec --- Does not replicate on master. Feel free to reopen this, if you think it's still an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 13:08:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 12:08:00 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 --- Comment #5 from Fr?d?ric Demians --- (In reply to Marcel de Rooy from comment #4) > Frederic, > Can you confirm that 15108 would actually resolve this one? Yes. Even I haven't re-check recently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 13:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 12:35:32 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #60 from Marcel de Rooy --- Truncate operations cause an implicit commit, and so cannot be rolled back. I discovered that now too in my test database.. Will adjust the statement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 13:36:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 12:36:09 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #5 from Josef Moravec --- Created attachment 58066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58066&action=edit Bug 17702: Add tests Test plan: prove t/db_dependent/Koha/AccountTypes.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 13:36:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 12:36:06 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:02:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:02:31 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:15:12 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57772|0 |1 is obsolete| | --- Comment #64 from Josef Moravec --- Created attachment 58067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58067&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:15:21 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57773|0 |1 is obsolete| | --- Comment #65 from Josef Moravec --- Created attachment 58068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58068&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:15:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:15:27 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57774|0 |1 is obsolete| | --- Comment #66 from Josef Moravec --- Created attachment 58069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58069&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:15:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:15:33 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57775|0 |1 is obsolete| | --- Comment #67 from Josef Moravec --- Created attachment 58070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58070&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:15:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:15:38 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57776|0 |1 is obsolete| | --- Comment #68 from Josef Moravec --- Created attachment 58071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58071&action=edit Bug 16239: Use inline-block for split buttons only in tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:17:49 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #61 from Marcel de Rooy --- Created attachment 58072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58072&action=edit Bug 15108: [QA Follow-up] Remove truncate Truncate operations cause an implicit commit, and so cannot be rolled back. So we need to replace it by a DELETE and adjust the code so that it does not assume numbering biblionumbers from 1, etc. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:28:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:28:27 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57024|0 |1 is obsolete| | --- Comment #48 from Josef Moravec --- Created attachment 58073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58073&action=edit Bug 8612 - System preference to have custom fields in export csv basket This patch allows the user use a CSV export profile to create the fields to export the basket as CSV in a basket page. To test: 1) Apply the patch; 2) Create a CSV export profile - type sql - Home ? Tools ? CSV export profiles ex: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) Create a new basket and add an order to the basket 4) Validate: the text "Select CSV profile:" and a dropdown in the basket view 5) In the new dropdown, select the CSV export profile created 6) Validate the CSV file. 7) Do the same validation with a closed basket. a) close the basket b) View the basket c) validate that there is a dropdown d) test it with an export Signed-off-by: Josef Moravec Works as expected for me Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:28:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:28:35 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57025|0 |1 is obsolete| | --- Comment #49 from Josef Moravec --- Created attachment 58074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58074&action=edit Bug 8612 - Cleans basket.tt by using TT blocks Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:28:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:28:51 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57026|0 |1 is obsolete| | --- Comment #50 from Josef Moravec --- Created attachment 58075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58075&action=edit Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use GetBasketAsCSV instead GetBasketAsCSV now has a new argument the profile_csv_id, when this param is defined, it loads the profile_content, searches the value of the predefined fields and assembles the data to create the output of the csv file. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:28:57 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57027|0 |1 is obsolete| | --- Comment #51 from Josef Moravec --- Created attachment 58076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58076&action=edit Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:29:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:29:03 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57028|0 |1 is obsolete| | --- Comment #52 from Josef Moravec --- Created attachment 58077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58077&action=edit Bug 8612: QA followup - Make export button split button, unify button labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:29:10 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57029|0 |1 is obsolete| | --- Comment #53 from Josef Moravec --- Created attachment 58078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58078&action=edit Bug 8612: Add tests for GetBasketAsCSV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:29:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:29:19 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57079|0 |1 is obsolete| | --- Comment #54 from Josef Moravec --- Created attachment 58079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58079&action=edit Bug 8612: QA follow-up - distinguish between late issues and basket export csv profiles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:29:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:29:43 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #55 from Josef Moravec --- Just rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:30:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:30:46 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #62 from Marcel de Rooy --- Created attachment 58080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58080&action=edit Bug 15108: [QA Follow-up] Remove the sleep Ordering by timestamp, biblionumber in ListBase.pm c/would be a performance killer. In order to speed up the test, we manipulate the timestamp. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 14:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 13:32:28 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #63 from Marcel de Rooy --- QA: Unfortunately I cannot finish this QA session now. Will resume it later next week. Please wait :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 15:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 14:29:50 +0000 Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If Syndetics covers is release notes| |active, now the system send | |to Syndetics UPCs or OCLC | |numbers if the records | |doesn't have ISBN. This | |true espacialy for DVD. You | |can see the improvment in | |results and in record | |display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 15:34:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 14:34:29 +0000 Subject: [Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this pach you don't release notes| |see anymore a empty tab if | |Novelist Select ia active | |in Opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 15:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 14:40:43 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Kyle M Hall --- (In reply to Alex Buckley from comment #14) > The Library Groups webpage > (http://localhost:8081/cgi-bin/koha/admin/library_groups.pl) where the user > should be able to create a group (in addition to being able to see > previously made groups) results in a Internal Server Error. I am unable to replicate your error on a fresh installation of kohadevbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 15:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 14:48:06 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adding a message for user release notes| |now is more integrated in | |circulation workflow. Add | |more standard type of notes | |in the AV 'BOR_NOTES' to | |use them more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 15:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 14:53:14 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The notification that pops release notes| |up when checking in an item | |that has a hold on it it | |tells the librarian if the | |patron has subscribed to | |hold notifications (via | |email, sms, or phone). So | |now the librarian knows | |not to call the patron | |personally or email him or | |whatever. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:00:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:00:35 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals after defined loan period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |In the circulation release notes| |conditions there is a new | |value "no automatic renewal | |after". | |This means that | |"after you have checked out | |the item for more than X | |days, there will be no more | |automatic renewals". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:07:00 +0000 Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to regular checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A patron checks some items release notes| |out on-site and want to | |take it home. | |To facilitate | |the librarian work the | |checkout is directly | |switched from on-site to | |regular when checked out if | |the new pref | |SwitchOnSiteCheckouts is | |on. | |If | |SwitchOnSiteCheckouts is | |off and you check out an | |item with "on-site | |checkout" you receive an | |"This item can not be | |renewed, it's an on-site | |checkout". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:24:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:24:42 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now in opac user page there release notes| |is a link to download | |user's issues dates as an | |ical Calendar. So the user | |can import the dates into | |his/her agenda. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:25:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:25:54 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Kyle M Hall --- Pushed to master for 17.05, thanks David, Tomas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:29:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:29:28 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new page release notes| |(admin/searchengine/elastic | |search/mappings.pl) will | |permit to manage the ES | |mappings. | |For the biblios | |and authorities indexes, | |the different mappings can | |be managed from this single | |page. | |The interface let you | |add, remove and update | |mappings and search fields. | |It's also possible to | |reorder the mappings, as | |the order can be important | |in the indexation process. | |Note that the table can be | |displayed in a | |different | |order that the one it was | |before saving, but the | |mappings are grouped by | |search field and the order | |inside the search field is | |preserved. | |Limitations: If | |something went wrong during | |the | |insertion/deletion/modifica | |tion, the users will loose | |all these changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:31:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:31:26 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the release notes| |infrastructure needed to | |allow audio alerts, as | |configured in | |administration, to affect | |the sco module. | |This patch | |allows only for the use of | |sounds with a full URL to | |be used and does not allow | |for the Koha standard | |sounds to be accessed via | |the SCO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:39:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:39:04 +0000 Subject: [Koha-bugs] [Bug 17428] REST API: CRUD endpoint for cities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch introduces full release notes| |CRUD for Koha::Cit(ies|y) | |classes through the REST | |api. To test, point your | |browser to /api/v1/cities | |to use | |HTTPRequester/Postman (or | |the like). | |It is a full | |example about the creation | |of an REST API in Koha. | |Read and copy it for others | |REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 16:49:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 15:49:16 +0000 Subject: [Koha-bugs] [Bug 17432] Remove requirement to minify swagger.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The minification of release notes| |swagger.json is not more | |required; the deferenced | |version of the | |specification is now | |internally validated at | |runtime. | |Relavant errors | |output and the dereferenced | |schema has been made | |publically available at | |/api/v1/spec -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:02:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:02:50 +0000 Subject: [Koha-bugs] [Bug 17750] New: Drop down list in the add biblio page is not responding when the field is repeated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17750 Bug ID: 17750 Summary: Drop down list in the add biblio page is not responding when the field is repeated Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jawad_makki at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 58081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58081&action=edit Drop-Down list is not responding when it is duplicated After upgrading KOHA from version 3.22 to version 16.11, the drop down list in the add biblio page is not responding when a field is duplicated. By the drop down list, I mean the authorized values linked to a subfield in MARC frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:06:02 +0000 Subject: [Koha-bugs] [Bug 17750] Drop down list in the add biblio page is not responding when the field is repeated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17750 --- Comment #1 from Jawad Makki --- Created attachment 58082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58082&action=edit The used authorized values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:07:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:07:06 +0000 Subject: [Koha-bugs] [Bug 17750] Drop down list in the add biblio page is not responding when the field is repeated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17750 --- Comment #2 from Jawad Makki --- Created attachment 58083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58083&action=edit linking field 856$y to the autorized value in Marc Framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:22:23 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #20 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:22:53 +0000 Subject: [Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #57790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:25:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:25:15 +0000 Subject: [Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:29:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:29:47 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:47:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:47:11 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #9 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 17:47:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 16:47:25 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:01:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:01:28 +0000 Subject: [Koha-bugs] [Bug 17751] New: Patrons wizard: Allow to define activity timeframe Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17751 Bug ID: 17751 Summary: Patrons wizard: Allow to define activity timeframe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently you can choose if the user has been active in the last 1,2,3 years. If I interpret the resutls and output correctly, this is "today x years ago until now". It would be helfpul and more flexible if you could enter dates instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:25:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:25:00 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:25:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:25:51 +0000 Subject: [Koha-bugs] [Bug 17493] Improve OAI Server tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493 --- Comment #8 from Marcel de Rooy --- Blocking it temporarily; should be pushed together with 15108 due to the truncates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:44:00 +0000 Subject: [Koha-bugs] [Bug 17752] New: Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 Bug ID: 17752 Summary: Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: abbottlibrarydirector at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:50:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:50:49 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master fro 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:52:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:52:21 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 --- Comment #4 from Chris Kirby --- I have updated my packages. Now I get "Parse errors: Bad plan. You planned 15 tests but ran 9." "Failed test 'No tests run for subtest "is_going_to_expire"' The method is_going_to_expire_expire is not covered by tests!" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:56:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:56:37 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 --- Comment #5 from Chris Kirby --- Within the staff client, when I delete a patron with a hold, I get a "The method holds is not covered by tests!" error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:57:21 +0000 Subject: [Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 --- Comment #1 from Mary Danko --- I would like to be able to: 1. Scan an ISBN on an item. 2. Z39.50 search is executed to a pre-designated target (such as LOC -admin setting) and fast add framework is automatically employed. (If several hits, use first hit with option to go back to list.) 3. Using the information from the Z39.50 search the following fields are filled: item type as ILL (admin setting), title (with "-ILL" appended - admin setting) and the author/creator. 4. Prompt comes up for a barcode 5. Prompt comes up for a patron account. 6. Hold is put on the patron's account for this item 7. Hold slip is printed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:59:11 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 18:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 17:59:25 +0000 Subject: [Koha-bugs] [Bug 15906] [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:01:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:01:22 +0000 Subject: [Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 Chuck McAndrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chuck.mcandrew at leblibrary.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:02:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:02:49 +0000 Subject: [Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 --- Comment #2 from Chuck McAndrew --- This would be a huge time saver for my library as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:03:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:03:36 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:03:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:03:38 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52140|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 58084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58084&action=edit Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:11:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:11:35 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #8) > Please adjust this parameter: > > + lines => [$line], > > And check the comment on bug 15986 on the paypal script. Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:22:58 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58033|0 |1 is obsolete| | --- Comment #2 from Chris Kirby --- Created attachment 58085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58085&action=edit Bug 17742: Fix t/db_dependent/Patrons.t Moves the getting of testing date for updated_on just after the storing the test patron data to make the gap between generating data and now date as short as possible Changes test #7 to the one which was probably originally intended Test plan 1. prove t/db_dependent/Patrons.t 2. read the diff Signed-off-by: Chris Kirby Tests passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:23:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:23:46 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris.kirby at ilsleypubliclib | |rary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:24:56 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:26:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:26:22 +0000 Subject: [Koha-bugs] [Bug 17516] Add CSV export option to item search *after* displaying output to screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:53:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:53:58 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 19:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 18:56:19 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 20:33:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 19:33:13 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org --- Comment #16 from Chris Kirby --- Patch set did not apply cleanly. "fatal: sha1 information is lacking or useless (Koha/Library/Group.pm).Repository lacks necessary blobs to fall back on 3-way merge." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 9 21:48:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Dec 2016 20:48:32 +0000 Subject: [Koha-bugs] [Bug 17753] New: Analytical cataloging does not copy all necessary subfields to the 773 field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17753 Bug ID: 17753 Summary: Analytical cataloging does not copy all necessary subfields to the 773 field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In using analytical records, the contents of the 1XX field of the host item is copied in the 773$a subfield of the analytical record. But only $a of the 1XX field is copied. In conference records it is necessary to copy also other subfields, for example $n, $d and $c to create a correct access pont for the 773 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 08:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 07:28:25 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #17 from Josef Moravec --- (In reply to Chris Kirby from comment #16) > Patch set did not apply cleanly. "fatal: sha1 information is lacking or > useless (Koha/Library/Group.pm).Repository lacks necessary blobs to fall > back on 3-way merge." On top of bug 15707 applies cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:01:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:01:41 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #110 from Josef Moravec --- Created attachment 58086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58086&action=edit Bug 15707: Followup - use cat-search instead of cities-search in header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:03:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:03:29 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #111 from Josef Moravec --- When testing bug 16735, I found, that in header is used cities search form, I fixed it in followup as it is an easy fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:12:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:12:26 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #18 from Josef Moravec --- Created attachment 58087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58087&action=edit [SIGNED-OFF] Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:12:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:12:32 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #19 from Josef Moravec --- Created attachment 58088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58088&action=edit [SIGNED-OFF] Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:12:38 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #20 from Josef Moravec --- Created attachment 58089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58089&action=edit [SIGNED-OFF] Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:13:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:13:19 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:13:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:13:23 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57098|0 |1 is obsolete| | Attachment #57099|0 |1 is obsolete| | Attachment #57100|0 |1 is obsolete| | Attachment #57101|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 58090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58090&action=edit [SIGNED-OFF] Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:35:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:35:19 +0000 Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 09:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 08:35:22 +0000 Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55166|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 58091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58091&action=edit [SIGNED-OFF] Bug 17246: Do no support arrayref to define multiple FK Currently you can call GetPreparedLetter like: $prepared_letter = GetPreparedLetter( ( module => 'test', letter_code => 'TEST_HOLD', tables => { reserves => [ $fk1, $fk2 ], }, ) ); It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber. It seems hazardous to do this guess. I suggest to remove this feature and only allow hashref indeed. Test plan: Use different way to generate letters and make sure you do not reach the croak Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 10:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 09:41:37 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 10:41:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 09:41:41 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58084|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 58092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58092&action=edit [SIGNED-OFF] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 10:56:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 09:56:27 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52141|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 58093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58093&action=edit Bug 15898 - Use Koha::Account::pay internally for makepartialpayment This is the fourth patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 10:57:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 09:57:06 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #5 from Josef Moravec --- Just a rebase, now start testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 11:38:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 10:38:10 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #7 from Josef Moravec --- Created attachment 58094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58094&action=edit Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 11:38:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 10:38:38 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #8 from Josef Moravec --- Kyle, could confirm I am right? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 11:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 10:43:56 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 11:43:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 10:43:59 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58093|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 58095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58095&action=edit [SIGNED-OFF] Bug 15898 - Use Koha::Account::pay internally for makepartialpayment This is the fourth patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 13:04:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 12:04:38 +0000 Subject: [Koha-bugs] [Bug 17754] New: MARCXML encoding problems Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Bug ID: 17754 Summary: MARCXML encoding problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org Uploading authorities in MARCXML in 16.11 and master kills Umlauts while they work ok in the same file in mrc format. I have not checked biblios yet. Upload mrc: Universit?t Berlin (Freie Universit?t) Upload xml: Universitt? Berlin (Freie Universitt?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 13:05:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 12:05:12 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML encoding problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 --- Comment #1 from Mirko Tietgen --- Created attachment 58096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58096&action=edit Minimal example mrc file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 13:05:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 12:05:39 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML encoding problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 --- Comment #2 from Mirko Tietgen --- Created attachment 58097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58097&action=edit Minimal example xml file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 13:06:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 12:06:14 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARCXML encoding problems |MARCXML upload in Intranet | |is broken (encoding) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 14:38:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 13:38:02 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 15:36:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 14:36:26 +0000 Subject: [Koha-bugs] [Bug 17755] New: Move C4::Members::AttributeTypes to Koha::* namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Bug ID: 17755 Summary: Move C4::Members::AttributeTypes to Koha::* namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 15:36:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 14:36:31 +0000 Subject: [Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 15:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 14:44:31 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org --- Comment #6 from Chris Kirby --- Hi Josef, When I tried to add a new debit type, I got the following error: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_mykoha.account_debit_types' doesn't exist at /home/ckirby/koha/Koha/Objects.pm line 83 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 17:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 16:29:12 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org --- Comment #3 from Chris Kirby --- Paid a fine using the pay button in right column. Reversed the payment using the reverse button dropdown Now, action displays "Pay" and dropdown arrow appears but know options visible. Should the dropdown arrow be removed since there are no longer are options? Or should the "write off" and "print" be displayed in the dropdown menu again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 18:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 17:13:30 +0000 Subject: [Koha-bugs] [Bug 17756] New: Add objects Koha::Branches + Koha::Branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17756 Bug ID: 17756 Summary: Add objects Koha::Branches + Koha::Branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mail at jkozlovsky.cz QA Contact: testopia at bugs.koha-community.org Add objects Koha::Branches + Koha::Branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 18:38:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 17:38:23 +0000 Subject: [Koha-bugs] [Bug 17756] Add objects Koha::Branches + Koha::Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Marcel de Rooy --- Has been done already under Koha::Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 18:38:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 17:38:32 +0000 Subject: [Koha-bugs] [Bug 17756] Add objects Koha::Branches + Koha::Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 19:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 18:36:38 +0000 Subject: [Koha-bugs] [Bug 17756] Add objects Koha::Branches + Koha::Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17756 --- Comment #2 from Jiri Kozlovsky --- Oh! that's nice :) .. didn't know that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 21:22:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 20:22:52 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 21:22:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 20:22:55 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #5 from Jiri Kozlovsky --- Created attachment 58098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58098&action=edit Implemented suggestions REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 22:05:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 21:05:48 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 23:04:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 22:04:48 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #7 from Josef Moravec --- (In reply to Chris Kirby from comment #6) > Hi Josef, > When I tried to add a new debit type, I got the following error: > DBIx::Class::Storage::DBI::_dbh_execute(): Table > 'koha_mykoha.account_debit_types' doesn't exist at > /home/ckirby/koha/Koha/Objects.pm line 83 Did you upgrade your db schema? I forget to mention it in test plan, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 23:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 22:08:32 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #4 from Josef Moravec --- (In reply to Chris Kirby from comment #3) > Paid a fine using the pay button in right column. > Reversed the payment using the reverse button dropdown > Now, action displays "Pay" and dropdown arrow appears but know options > visible. > Should the dropdown arrow be removed since there are no longer are options? > Or should the "write off" and "print" be displayed in the dropdown menu > again? You are right, there should always be the print action. I'll attach a followup soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 10 23:28:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Dec 2016 22:28:16 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #6 from Jiri Kozlovsky --- (In reply to Jiri Kozlovsky from comment #5) > Created attachment 58098 [details] [review] > Implemented suggestions REST API Basic test plan 1.part: 1. Login using account without any permissions and copy Cookie's CGISESSID=TOKEN and copy it's borrowernumber 2. Using your favorite HttpRequester send POST to /api/v1/suggestions with the cookie in Headers: { "title": "Suggested title", "author": "hawking", "suggestedby": "BORROWER_NUMBER" } 3. Obtain the suggestionid from the response and send GET to /api/v1/suggestions/YOUR_SUGG_ID 4. Check that returned data matches data sent at point 2. 5. Send PUT request to /api/v1/suggestions/YOUR_SUGG_ID: { "title": "Updated suggested title" } 6. Repeat steps 3 + 4. 7. Login using another account again without any permissions and copy Cookie's CGISESSID=TOKEN 8. Using your favorite HttpRequester send POST to /api/v1/suggestions with the cookie in Headers: { "title": "Suggested title", "author": "hawking", "suggestedby": "YOUR_BORROWER_NUMBER", "STATUS": "ACCEPTED" } 9. Check that error was returned. 10. Create valid suggestion (repeat 8. step, but remove the STATUS) and remember the suggestionid. 11. Send PUT request to /api/v1/suggestions/YOUR_SUGG_ID: { "STATUS": "ACCEPTED" } 12. Check that error was returned. 13. Send GET request to suggestionid from the first user. (Check that you don't have enough permissions) 14. Send GET request to suggestionid of current user. (should succeed) 15. Send DELETE request to suggestion of current user. (should return 200 OK only .. without any body) 16. Repeat 14. point - should fail. 17. Send GET request to /api/v1/suggestions/?suggestedby=BORROWER_NUMBER 18. Check that there were returned all active suggestions for the user. 19. Send DELETE request to suggestion of the first user (not enough permissions - should fail) Basic test plan 2.part: 1. Login using user with permissions of "acquisition" and copy your CGISESSID from the Cookie. 2. Using your favorite HttpRequester send POST to /api/v1/suggestions with the cookie in Headers: { "title": "Suggested title from librarian", "author": "hawking", "STATUS": "ACCEPTED", "suggestedby": "BORROWER_NUMBER" } 3. Check that new suggestion was created successfully and note the suggestionid. 4. Disable "AnonSuggestions" syspref and repeat 1. & 2. step without "suggestedby". (should fail because anonymous suggestions are disabled) 5. Enable "AnonSuggestions" syspref and repeat 1. & 2. step without "suggestedby". (success) 6. Send PUT request to /api/v1/suggestions/YOUR_SUGG_ID: { "STATUS": "REJECTED" } 7. Check that the suggestion was updated successfully. This should provide you basic understanding of how does "add", "update", "list" and "delete" work. Now you can test the following: 1. While adding / updating suggestion with patronreason or branchcode or STATUS or itemtype specified, check that the API refuses invalid values, while accepts valid ones. 2. While adding / updating suggestion with suggestedby or managedby specified, as a user with acquisition permissions, check that the API refuses ids which are invalid, while accepts valid ones (invalid are nonexisting borrowernumbers). 3. Setup "MaxOpenSuggestions" syspref to custom value and check that it applies to all borrowers excluding anonymous suggestions. 4. Setup "OPACSuggestionMandatoryFields" syspref to custom values and check that those required fields are required only while creating suggestions, not when updating, because you may want to update only a title for example. 5. Setup "AllowPurchaseSuggestionBranchChoice" syspref to enabled and check that regular users (without acquisition rights) can create and update suggestions with branchcode specified. Also check that it is forbidden for them to do so when the syspref is disabled. 6. Check that regular users can create and update suggestions only with the following fields specified: ('suggestedby', 'title', 'author', 'copyrightdate', 'isbn', 'publishercode', 'collectiontitle', 'place', 'itemtype', 'patronreason', 'note') ... branchcode is added when syspref AllowPurchaseSuggestionBranchChoice is enabled. ... That's it ! You got it all covered! Btw, thanks for signing this off in advance ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 02:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 01:21:49 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #8 from Chris Kirby --- (In reply to comment #7), Hi Josef, thanks for the tip to upgrade the db schema. When one creates a "manual invoice" for a patron using one of the created debit types, both the debit type code and the description are entered into the "Description of charges." However, for the pre-existing debit types, the debit type description is entered twice in the "description of charges". Is there any reason for this difference? When one creates a credit type, there is no field for default amount. Is there any reason for leaving a default amount out of the credit type but keeping it in the debit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 19:54:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 18:54:45 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #38 from Jiri Kozlovsky --- (In reply to Tom?s Cohen Arazi from comment #36) > Lari, I don't think we should have such a 'validate' method. We should look > at Jonathan's code to move C4::Members methods into Koha::Patron(s) and have > them raise those exceptions, and build the endpoint on top of those. > Please contact him if you are willing to help him and make this happen. I think, that moving all of the C4::Members methods into Koha::Patron is an overkill for this bug. There should be created bug for methods migration from C4 to Koha Objects generally. If we focus on the goal of this bug - which is adding REST API routes for adding, updating and deleting patrons, we will find only these methods from C4::Members to be dependent, thus migrated: ModMember changepassword AddMember AddMember_Opac Note that "changepassword" has already been migrated as a part of bug 17006. My opinion is also that there shouldn't be general "validate" method, because the validation process depends on what you want to validate. For example, you are checking for borrowernumber being non-existent in the DB, but it's contra productive if you want to validate input while updating patron. Because this is the case you want to check it's existent. These tiny differences are making it more difficult to maintain single version of validation. Btw I think having stashed user being owner would be very nice like Lari suggested. Perhaps we should file a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 20:51:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 19:51:00 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #8 from Jiri Kozlovsky --- Comment on attachment 57493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57493 Bug 17003: Add API route to get checkout's renewability Review of attachment 57493: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17003&attachment=57493) ----------------------------------------------------------------- ::: Koha/REST/V1/Checkout.pm @@ +109,5 @@ > + $OpacRenewalAllowed = C4::Context->preference('OpacRenewalAllowed'); > + } > + > + unless ($user && ($OpacRenewalAllowed > + || haspermission($user->userid, { circulate => "circulate_remaining_permissions" }))) { This "haspermission" check should be moved to the path definition using "x-koha-authorization". Also when OpacRenewalAllowed syspref is disabled, the error should be returned sooner then possible "Checkout doesn't exist" error (don't give users hope to renew it when not found, but tell them renewal is not allowed at all instead). ::: api/v1/swagger/paths/checkouts.json @@ +98,5 @@ > + "get": { > + "operationId": "renewabilityCheckout", > + "tags": ["patrons", "checkouts"], > + "parameters": [{ > + "name": "checkout_id", I think this parameter should be exported in dependent bug 13895 and only referenced here instead of defined again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 22:42:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 21:42:43 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57493|0 |1 is obsolete| | --- Comment #9 from Jiri Kozlovsky --- Created attachment 58099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58099&action=edit Bug 17003: Add API route to get checkout's renewability GET /checkouts/{checkout_id}/renewability (renewability status) Response: - 200: renewability { renewable: true/false, error: "error message" } To test: 1. Login to Koha 2. Checkout something for yourself 3. Make GET request to http://yourlibrary/api/v1/checkouts/YYY/renewability where YYY is checkout_id of your checkout. 4. Observe returned data. If not renewable, an error should also be presented. 5. Run t/db_dependent/api/v1/checkouts.t Signed-off-by: Jiri Kozlovsky I've signed-off this because I've made no major change and the funcionality remains the same. Changes made: 1. Added x-koha-authorization to the paths definition 2. Changed checkout_id parameter definition to the reference 3. Moved error raised when syspref OpacRenewalAllowed disabled in front of possible error "Checkout doesn't exist" (don't give users hope to renew it when not found, but tell them renewal is not allowed at all instead) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 22:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 21:54:28 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail at jkozlovsky.cz --- Comment #4 from Jiri Kozlovsky --- I like this flag approach! How about also adding the owned object to the stash? It is very common to perform duplicate search for that object (you may need some arbitrary column from it or to check if something has changes, etc ..) Now you create DB query when checking for ownership and then, the same query when the object itself is required from within the controller. After this implemented, there would always be only one DB query for the owned object. In the controller then, it'd be called $c->stash('owned_object'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 22:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 21:55:48 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 22:59:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 21:59:08 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #10 from Jiri Kozlovsky --- (In reply to Jiri Kozlovsky from comment #8) > Comment on attachment 57493 [details] [review] > Bug 17003: Add API route to get checkout's renewability > > Review of attachment 57493 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/REST/V1/Checkout.pm > @@ +109,5 @@ > > + $OpacRenewalAllowed = C4::Context->preference('OpacRenewalAllowed'); > > + } > > + > > + unless ($user && ($OpacRenewalAllowed > > + || haspermission($user->userid, { circulate => "circulate_remaining_permissions" }))) { > > This "haspermission" check should be moved to the path definition using > "x-koha-authorization". > Sorry about that inconvenience - I haven't realized that ownership check is required. It would be nice to have bug 17479 implmemented soon so that we avoid such misunderstandings :) .. btw how about setting that bug as a dependency and rewriting this code? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 23:13:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 22:13:15 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58098|0 |1 is obsolete| | --- Comment #7 from Jiri Kozlovsky --- Created attachment 58100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58100&action=edit Implemented suggestions REST API Added HTTP Codes for remaining errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 11 23:16:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 22:16:11 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58100|0 |1 is obsolete| | --- Comment #8 from Jiri Kozlovsky --- Created attachment 58101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58101&action=edit Implemented suggestions REST API Added HTTP Codes for remaining errors (previous attachment didn't change anything [I forgot to add changes to the commit]) Test plan unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 00:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 23:03:22 +0000 Subject: [Koha-bugs] [Bug 17371] REST API: add CRUD for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #7 from Jiri Kozlovsky --- Comment on attachment 55898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55898 Bug 17371 - REST API: add CRUD for biblios Review of attachment 55898: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17371&attachment=55898) ----------------------------------------------------------------- Nice work by the way! ::: Koha/REST/V1/Biblio.pm @@ +45,5 @@ > + my $biblio = Koha::Biblios->find($args->{biblionumber}); > + unless ($biblio) { > + return $c->$cb({error => "Biblio not found"}, 404); > + } > + return $c->$cb({ biblio => $biblio->unblessed, items => $biblio->items->unblessed }, 200); Does this respect OpacHiddenItems preference? @@ +79,5 @@ > + > + # mark as onhold if item marked as hold > + if (scalar(@{$holds}) > 0) { > + $item->{status} = "onhold"; > + } I'm missing the next statement after one of the conditions succeeds. I can see no reason to check for another condition, which can result in not necessary DB querying. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 00:31:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Dec 2016 23:31:04 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleishaamohia at hotmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 01:01:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 00:01:40 +0000 Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 01:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 00:01:43 +0000 Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49155|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 58102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58102&action=edit Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Have amended patch to not include OPAC changes from previous patch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 01:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 00:58:42 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin at bugs.koha-community. |aleishaamohia at hotmail.com |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 08:36:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 07:36:34 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #10) > (In reply to Marcel de Rooy from comment #8) > > Please adjust this parameter: > > > > + lines => [$line], > > > > And check the comment on bug 15986 on the paypal script. > > Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' > parameter. Could you please double-check? I cannot find it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 08:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 07:45:05 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |7840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 [Bug 7840] Remove from manual Koha as a CMS (or add it to master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 08:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 07:45:05 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 [Bug 12806] Adding 'Koha as a CMS' to the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 09:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 08:39:39 +0000 Subject: [Koha-bugs] [Bug 17758] New: SIP checkin does not handle holds correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Bug ID: 17758 Summary: SIP checkin does not handle holds correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com We have been investingating some strange behaviour from our SIP transactions: Given a biblio with to items x1 & x2, and two holds on the biblo. - Checkin (via SIP) x1 on the pickup branch - hold is filled and notified in SIP message. - Checkin (via SIP) x2 on another branch - get notified of hold again, but this time the hold is swapped so that now item x2 fullfils the hold, and x1 is again available. If do the same transactions in the web-interface - no error occurs. I belive bug #14695 is the origin of this behaviour. If you look at commit https://github.com/Koha-Community/Koha/commit/6e76e342cb6ac6036738d79418ff068ad84346cc which changes the signature of ModReserveAffect (without updating the documentation btw) but fails to update the corresponding usage of it in the SIP::ILS::Transaction::Checkin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 09:40:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 08:40:22 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com --- Comment #236 from Petter Goks?yr ?sen --- See bug #17758 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 09:49:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 08:49:03 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 10:28:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 09:28:37 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55926|0 |1 is obsolete| | --- Comment #42 from Matthias Meusburger --- Created attachment 58103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58103&action=edit Bug 15503: Grab Item Information from Order Files The goal of this development is to automatically generate items in Koha with populated information based on a 9XX field and subfield, with the new syspref MarcItemFieldsToOrder. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 10:29:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 09:29:14 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #43 from Matthias Meusburger --- (Rebased patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:02:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:02:26 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 --- Comment #6 from Jonathan Druart --- Everything looks ok for me, please apply the dependencies first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:09:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:09:24 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:09:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:09:28 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57862|0 |1 is obsolete| | Attachment #57863|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 58104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58104&action=edit Bug 17557: Revised patron age calculation tests The SetAge and GetAge test coverage are excessive. First the SetAge subroutine was only created for testing purpose. The goal of GetAge is quite simple and it seems quite easy to provide corect test coverage using DateTime->add using negative numbers. Edit: rebased so it applies Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:09:32 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 --- Comment #9 from Jonathan Druart --- Created attachment 58105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58105&action=edit Bug 17557: Koha::Patrons - Move GetAge to ->set_age (and remove SetAge) As said in the previous commit, I considered SetAge as unnecessary and removed it. Test plan: 1/ Edit a patron using the different 'Edit' links 2/ Play with the patron category limited to age ranges, and date of birth 3/ You should get the expected warning if the date of birth is inside the patron category date range. To finish: prove t/Circulation/AgeRestrictionMarkers.t t/db_dependent/Reserves.t \ t/db_dependent/Koha/Patrons.t t/db_dependent/Members.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:18:56 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58015|0 |1 is obsolete| | Attachment #58016|0 |1 is obsolete| | Attachment #58017|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 58106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58106&action=edit Bug 17736: Add the Koha::Biblio->holds_placed_before_today method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:19:00 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #7 from Jonathan Druart --- Created attachment 58107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58107&action=edit Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds The C4::Reserve::GetReservesFromBiblionumber took 3 parameters, the biblionumber, an optional itemnumber and a "all_dates" flag. If set, the subroutine returned all the holds placed on a given bibliographic record, even the ones placed in the future. Almost all of the calls had this flag set, they will be replaced with a call to Koha::Biblio->holds. But 5 did not have it: - C4::Biblio::DelBiblio -tools/batch_delete_records.pl => These 2 were wrong, we want to retrieve the holds to cancel them before deleting the record. We need to get all the holds, even the ones placed in the future /!\ CHANGE IN THE BEHAVIOR - acqui/parcel.pl => 1 call per item were made to this subroutine. They have been replaced with only 1 call to the new method Koha::Biblios->holds_placed_before_today Then we filter on the itemnumbers. I think this is wrong: we need the number of holds to know if the record can be deleted, so even if future holds exist, the deletion should not be possible. - serials/routing-preview.pl - C4::ILSDI::Services::GetRecords - C4::SIP::ILS::Item->new => Seems ok, we just one to display holds placed before today Test plan: I would suggest to test this patch with patches from bug 17737 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:19:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:19:05 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #8 from Jonathan Druart --- Created attachment 58108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58108&action=edit Bug 17736: Remove C4::Reserves::GetReservesFromBiblionumber At this point, there should not be any occurrences of GetReservesFromBiblionumber left in the codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:23:03 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #9 from Jonathan Druart --- (In reply to Josef Moravec from comment #4) > Also, when returned reserved document has to be transfered, after the > checking in on target library, everything looks ok. But the hold is not set > to waiting status, see attached screenshot. It was title level hold. Could you give me more information on this please, I don't think I recreate it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:30:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:30:22 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #6 from Jonathan Druart --- This is something different. I would not mind fixing it in the same patch (especially to avoid yet another bug report), but I do not recreate it and so it's hard to fix :) Otherwise we could just set all the guarantorid to null Koha::Patrons->search->update( { guarantorid => null } ); That should do the job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:41:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:41:48 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > This is something different. > I would not mind fixing it in the same patch (especially to avoid yet > another bug report), but I do not recreate it and so it's hard to fix :) > > Otherwise we could just set all the guarantorid to null > Koha::Patrons->search->update( { guarantorid => null } ); > > That should do the job. Would not mind doing so outside sections where guarantorid is relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:56:38 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 11:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 10:56:38 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 [Bug 17758] SIP checkin does not handle holds correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:08:03 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- (In reply to Chris Kirby from comment #2) > Changes test #7 to the one which was probably originally intended No, the original test was good. We want to check that the updated_on value has been updated when a patron is modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:10:11 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:10:15 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58053|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58109&action=edit Bug 17749 - Missing l in '.pl' in link on waitingreserves.tt Fixes a small typo introduced by Bug 17010 waitingreserves.p#[% tab %] should be waitingreserves.pl#[% tab %] Signed-off-by: Benjamin Rokseth Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:35:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:35:36 +0000 Subject: [Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- We should not update the po file I think, that should be done on translate.k-c.org directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:37:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:37:39 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #71 from Jonathan Druart --- Could someone answer me and tell me what the whole point of this patch set and what is it suppose to do? Removed from the QA queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:47:43 +0000 Subject: [Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57779|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 58110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58110&action=edit Bug 17681: Exiisting typos might thow some feees when recieved Yes, we are fixing these four typos here. Test plan: [1] Read the changes. [2] Run t/Auth_with_shibboleth.t [3] Run git grep recieved| grep -v -e 'recievedlist' | grep -v -e 'serials-recieve.tt' Note: serials-recieve.tt is just history. Bonus points for the one who makes us get rid of that column recievedlist. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec EDIT: Rebased. Change in Accounts has been corrected already. Removed the po file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:50:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:50:49 +0000 Subject: [Koha-bugs] [Bug 17759] New: Fixing theoretical problems with guarantorid in Members.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Bug ID: 17759 Summary: Fixing theoretical problems with guarantorid in Members.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com This comes from bug 17733: I manipulated guarantorid of some borrower (with your calculation ;) And the first time I ran the test, it failed: not ok 65 - TrackLastPatronActivity - 2 patrons must be deleted # Failed test 'TrackLastPatronActivity - 2 patrons must be deleted' # at t/db_dependent/Members.t line 363. # got: '1' # expected: '2' not ok 66 - TrackLastPatronActivity - 3 patrons must be deleted # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' # at t/db_dependent/Members.t line 365. # got: '2' # expected: '3' As expected, the test did not fail when running it again. So you need to remove some guarantorids here too. GetBorrowersToExpunge checks for this column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:51:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:51:59 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17759 --- Comment #8 from Marcel de Rooy --- Moving the problem from comment5 to a new report: bug 17759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 [Bug 17759] Fixing theoretical problems with guarantorid in Members.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:51:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:51:59 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 [Bug 17733] Members.t is still failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:52:59 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:54:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:54:00 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:54:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:54:03 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58006|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 58111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58111&action=edit Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Opened a new report for special case: Bug 17759. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:57:21 +0000 Subject: [Koha-bugs] [Bug 17760] New: patron search not working in firefox Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760 Bug ID: 17760 Summary: patron search not working in firefox Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: Heinrich.Hartl at email.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After upgrading my test version from 3.22.2 to 16.5.5.1 I observed problems when searching patrons. These problems were not visible when using MS-IE11. However normally I am using Firefox(50.0.2) and the following problems are observed: Giving the patrons full cardnumber (barcode) : ok, everything is fine. Giving a substring of username or cardnumber : no success (even the small pop-up "loading" doesn't show. Choosing the start letter of the username: no success. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:58:47 +0000 Subject: [Koha-bugs] [Bug 17761] New: Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Bug ID: 17761 Summary: Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 12:58:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 11:58:53 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:01:49 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #1 from Kyle M Hall --- Created attachment 58112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58112&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:01:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:01:47 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:01:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:01:55 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:07:24 +0000 Subject: [Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58110|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 58113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58113&action=edit Bug 17681: Exiisting typos might thow some feees when recieved Yes, we are fixing these four typos here. Test plan: [1] Read the changes. [2] Run t/Auth_with_shibboleth.t [3] Run git grep recieved| grep -v -e 'recievedlist' | grep -v -e 'serials-recieve.tt' Note: serials-recieve.tt is just history. Bonus points for the one who makes us get rid of that column recievedlist. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec EDIT: Rebased. Change in Accounts has been corrected already. Removed the po file. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:07:21 +0000 Subject: [Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:12:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:12:44 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:12:48 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57854|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 58114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58114&action=edit Bug 11274 Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering.... Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:22:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:22:47 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:22:51 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | --- Comment #5 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58115&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:38:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:38:04 +0000 Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:38:08 +0000 Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57791|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 58116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58116&action=edit Bug 17470 Make overdue notices according to branch item only When a patron had overdues on items from different branches he received from each corresponding branch a notice claiming the complete list of these items. Signed-off-by: sbujam Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:40:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:40:33 +0000 Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 13:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 12:47:46 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |magnus at libriotech.no --- Comment #3 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #1) > I assume NORMARC is similar on this regard. Feel free to fail it if the > NORMARC part of the > patch is wrong. Magnus, could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:04:55 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 --- Comment #4 from Josef Moravec --- (In reply to Jonathan Druart from comment #3) > (In reply to Chris Kirby from comment #2) > > Changes test #7 to the one which was probably originally intended > > No, the original test was good. We want to check that the updated_on value > has been updated when a patron is modified. But shouldn't it be tested on $b3_new? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:11:03 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 --- Comment #1 from Marcel de Rooy --- Created attachment 58117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58117&action=edit Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:11:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:11:41 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:12:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:12:14 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:21:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:21:29 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:21:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:21:33 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57830|0 |1 is obsolete| | --- Comment #2 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58118&action=edit Bug 17700: Add columns setting to fines tables Test plan: 0) Apply the patch and restart memcached + koha-common services if needed 1) Go to adminitration -> Configure columns and confirm there is new table configuration with id=account-fines in Patrons section available 2) play with table setting to ensure it works as expected 3) go to to boraccount page for some patron with both fines - payed and owed 4) Note there is new button "Columns visibility" in top paginator panel, try to use it 5) Play with the datatable, sort filter and so on Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:28:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:28:27 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 --- Comment #5 from Jonathan Druart --- (In reply to Josef Moravec from comment #4) > (In reply to Jonathan Druart from comment #3) > > (In reply to Chris Kirby from comment #2) > > > Changes test #7 to the one which was probably originally intended > > > > No, the original test was good. We want to check that the updated_on value > > has been updated when a patron is modified. > > But shouldn't it be tested on $b3_new? Yes it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:30:45 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Is this still valid for new versions? I'd expect this to be fixed by bug 14778. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:35:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:35:02 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 --- Comment #4 from Magnus Enger --- (In reply to Jonathan Druart from comment #3) > (In reply to Tom?s Cohen Arazi from comment #1) > > I assume NORMARC is similar on this regard. Feel free to fail it if the > > NORMARC part of the > > patch is wrong. > > Magnus, could you confirm? Akshuly, there is no 648 in NORMARC, and no other field is used for "Chronological term" either, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:39:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:39:41 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:39:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:39:45 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58117|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 58119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58119&action=edit Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:40:20 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Skipping QA, too much time spent on these tests already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:44:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:44:46 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #9 from Radek ?iman (R-Bit Technology, s.r.o.) --- (In reply to Josef Moravec from comment #1) > Created attachment 57856 [details] [review] > Bug 17702: Account types configuration - db changes > > Test plan: > 1) Read the diff and confirm that it does make sense > 2) Comment what does not make sense ;) According to db changes, is it possible to extend type_code from only 5 chars to (let's say) 10 chars? It would be very useful for some libraries having a longer list of payments not to be so cryptic. For instance, one of them (Czech only - sorry): mvs 50|MVS tA4 3|Tisk a kopie A4 t2sA4 4|Tisk a kopie A4 oboustrann? toA4 6|Tisk a kopie A4 + obr?zek tbA4 15|Celobarevn? A4 t20A4 2|Tisk a kopie A4 nad 20 kus? s20A4 3|Tisk a kopie A4 oboustrann? nad 20 kus? b20A4 10|Tisk a kopie A4 barevn? nad 20 kus? tA3 5|Tisk a kopie A3 t2sA3 7|Tisk a kopie A3 oboustrann? toA3 10|Tisk a kopie A3 + obr?zek tbA3 25|Celobarevn? A3 t20A3 3|Tisk a kopie A3 nad 20 kus? s20A3 5|Tisk a kopie A3 oboustrann? nad 20 kus? b20A3 20|Tisk a kopie A3 barevn? nad 20 kus? sken 7|skenov?n? eursl 3|euroslo?ka papsl 5|pap?rov? slo?ka taskm 3|ta?ka mal? taskv 5|ta?ka velk? prodj ?|prodej plack ?|placky eshop ?|e-shop poukaz 110|Poukaz na registraci REZER 10|Rezervace (ru?n?) pspec 2|Pap?r speci?l -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:57:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:57:12 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:57:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:57:16 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58118|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58120&action=edit Bug 17700: Add columns setting to fines tables Test plan: 0) Apply the patch and restart memcached + koha-common services if needed 1) Go to adminitration -> Configure columns and confirm there is new table configuration with id=account-fines in Patrons section available 2) play with table setting to ensure it works as expected 3) go to to boraccount page for some patron with both fines - payed and owed 4) Note there is new button "Columns visibility" in top paginator panel, try to use it 5) Play with the datatable, sort filter and so on Signed-off-by: Radek ?iman Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 14:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 13:57:38 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:21:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:21:31 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plack and database backup |Large database backups and | |large exports from | |export.pl fail under plack CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:21:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:21:54 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40075|0 |1 is obsolete| | --- Comment #10 from Alex Sassmannshausen --- Created attachment 58121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58121&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:22:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:22:22 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #25 from Nick Clemens --- Created attachment 58122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58122&action=edit Bug 13937 (Followup) - Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this subis built into fetch and this call is a duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:23:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:23:07 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58121|0 |1 is obsolete| | --- Comment #11 from Alex Sassmannshausen --- Created attachment 58123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58123&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:23:12 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #12 from Alex Sassmannshausen --- Created attachment 58124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58124&action=edit DO NOT PUSH: Updated Branchtransfer schema. * Koha/Schema/Result/Branchtransfer.pm: Newly generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:23:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:23:20 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53503|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 58125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58125&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:23:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:23:27 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58122|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 58126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58126&action=edit Bug 13937 (Followup) - Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this subis built into fetch and this call is a duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:25:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:25:17 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Alex Sassmannshausen --- Hello, I've now been able to: - [X] Re-checked code paths to see if all required changes were made - [X] Updated test files - [X] Added atomic update script - [X] Tested database update & new database creation - [X] Separated out schema changes - [X] Ran QA scripts - [X] Upload new patches. This should now be ready for sign-off/QA. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:32:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:32:27 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:32:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:32:27 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.sassmannshausen at ptfs-e |y.org |urope.com Depends on| |14187 Assignee|koha-bugs at lists.koha-commun |alex.sassmannshausen at ptfs-e |ity.org |urope.com CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #2 from Alex Sassmannshausen --- We will shortly be able to finally upload a complete patch set for this feature. The basic idea with this feature is that: - librarians can create rotas, that specify a route that stock should automatically take along 'stages' (using branchtransfers) - for now, stages are considered completed if an item has spent X items at the branch associated with the stage (this could later be enhanced with other triggers, e.g. X number of check outs at the given branch) - Items are associated with rotas, and are automatically added to the first stage. Once an item arrives at the first stage, a nightly cron script will make sure it is put into branchtransfer to the next stage when the item has exceeded the number of days specified in the stage at the current branch. This feature is subtly different from rotating collections, as that feature is to do with the management of a 'group of items', that can be moved on together to the next library. This feature is about the automatic rotation of individual items attached to rotas along the rota. Alex Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 15:52:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 14:52:58 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #15 from Barton Chittenden --- (In reply to Jonathan Druart from comment #14) > (In reply to Dobrica Pavlinusic from comment #7) > > Correct way to fix this is to issue redirect under plack in download_backup > > to some plack handled URL so we don't read whole file in memory. > > The solution seems to be here, but I don't understand what Dobrica meant. Dobrica, Can you clarify and/or submit a further patch? This issue is really causing issues for large libraries. Thanks, --Barton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:21:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:21:34 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:21:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:21:37 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 --- Comment #3 from Lari Taskula --- Created attachment 58127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58127&action=edit Bug 16387: Fix default shortened loan period time When a loan period is shortened due to using decreaseLoanHighHolds* the time is always set to the current time in X days, even if the original loan period is given in days and not in hours. It should default to 23:59 as is normal for loan periods given in days. As original due date time defaults to 23:59 when given in days, this patch modifies the hours and minutes of shortened due date to be equal to original due date. To test: 1. prove t/db_dependent/DecreaseLoanHighHolds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:07 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:11 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #4 from Jonathan Druart --- Created attachment 58128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58128&action=edit Bug 14146: Add the new pref CumulativeRestrictionPeriods Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:15 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #5 from Jonathan Druart --- Created attachment 58129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58129&action=edit Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods Sponsored-by: Orex Digital -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:27 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #6 from Jonathan Druart --- Created attachment 58130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58130&action=edit Bug 14146: Add the ability to cumulate restriction periods At the moment the default behaviour is not to cumulate the restriction periods but to apply the longest one. This patch set creates a new syspref CumulativeRestrictionPeriods. If on, the behaviour changes and the restriction periods are cumulated: the days of the second restriction are added to the actual restriction period. We could add a new circulation rule instead of a syspref, but I am not sure it's very useful to have such granularity for this behaviour (can be changed if needed). How it works: Let's take 2 items, A and B. A is returned with Na days late, and B Nb days late The grace period is Ng and there is 1 day of suspension charge per day of overdue The suspension period is until day D = Na - Ng + Nb - Ng I would have expected D = Na + Nb - Ng but it's how it worked before this patch. Test plan: Create several overdue for a given patron Do the checkins and confirm that the period are added if the pref is on. If the pref is off, you should not get any changes in the existing behaviour. Sponsored-by: Orex Digital -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:31 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #7 from Jonathan Druart --- Created attachment 58131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58131&action=edit Bug 14146: Clean a bit and make the code understandable The code was a bit weird and this patch cleans it a bit by renaming variables and adding a variable. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:33:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:33:56 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 16:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 15:50:39 +0000 Subject: [Koha-bugs] [Bug 12941] batch enable/disable courses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941 Felicia Beaudry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicia.beaudry at newberry.ed | |u --- Comment #2 from Felicia Beaudry --- I would also like to see an easy way to batch enable/disable course reserves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 17:13:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 16:13:49 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #44 from Matthias Meusburger --- Created attachment 58132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58132&action=edit Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch notforloan values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 17:22:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 16:22:14 +0000 Subject: [Koha-bugs] [Bug 17762] New: Ability to translate notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Bug ID: 17762 Summary: Ability to translate notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If a library has students/patrons from different countries, they will all receive the same notices. At the moment they are not translatable. An improvement would be to let the library translate the notices in different languages. This bug will get patches to achieve this goal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 17:22:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 16:22:25 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:09 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #1 from Jonathan Druart --- Created attachment 58133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58133&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:13 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #2 from Jonathan Druart --- Created attachment 58134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58134&action=edit Bug 17762: DBIC Schema changes Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:16 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #3 from Jonathan Druart --- Created attachment 58135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58135&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:19 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #4 from Jonathan Druart --- Created attachment 58136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58136&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:23 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #5 from Jonathan Druart --- Created attachment 58137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58137&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:26 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #6 from Jonathan Druart --- Created attachment 58138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58138&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:30 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #7 from Jonathan Druart --- Created attachment 58139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58139&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:34 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #8 from Jonathan Druart --- Created attachment 58140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58140&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:02:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:02:37 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #9 from Jonathan Druart --- Created attachment 58141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58141&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:04:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:04:09 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:18:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:18:12 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 --- Comment #21 from Mason James --- (In reply to Mirko Tietgen from comment #20) > Still needed for 16.05, package build fails. Pushed to 16.05.x, will be in 16.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:28:42 +0000 Subject: [Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 58142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58142&action=edit Bug 17755: Introduce Koha::Object::Library::Limit This patch introduces a new class for extending Koha::Object using multiple inheritance. It cannot be used standalone, it needs to be used in Koha::Object implementations like this: use base qw( Koha::Object Koha::Object::Library::Limit ); Its goal is to provide a single way and place to deal with this common pattern in Koha's codebase. As it happened with Koha::Object, that needed to be tested in a real object class, this work was done on top of Koha::Patron::Attribute::Type implementation and it is fully covered by the tests that are introduced for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:28:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:28:45 +0000 Subject: [Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 58143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58143&action=edit Bug 17755: Introduce Koha::Patron::Attribute::Type(s) This patch introduces the Koha::Object-based classes for handling patron attribute types. It also adds branch limitation handling to the Koha::Patron::Attribute::Type class. It is built on top of the new Koha::Object::Library::Limit class that extends Koha::Object so it handles library limits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:28:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:28:48 +0000 Subject: [Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 58144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58144&action=edit Bug 17755: Unit tests This patch introduces unit tests for Koha::Object::Library::Limit. It is done this way because it needs to be instantiated to be usable. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:35:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:35:05 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Introduce |C4::Members::AttributeTypes |Koha::Patron::Attribute::Ty |to Koha::* namespace |pe(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:35:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:35:13 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:35:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:35:33 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 18:50:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 17:50:24 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58143|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 58145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58145&action=edit Bug 17755: Introduce Koha::Patron::Attribute::Type(s) This patch introduces the Koha::Object-based classes for handling patron attribute types. It also adds branch limitation handling to the Koha::Patron::Attribute::Type class. It is built on top of the new Koha::Object::Library::Limit class that extends Koha::Object so it handles library limits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 19:30:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 18:30:18 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 19:30:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 18:30:22 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52406|0 |1 is obsolete| | Attachment #52407|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 58146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58146&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 19:30:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 18:30:32 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #13 from Kyle M Hall --- Created attachment 58147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58147&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 21:02:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 20:02:41 +0000 Subject: [Koha-bugs] [Bug 10142] Unclear which issues show on subscription details issues tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10142 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 22:21:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 21:21:21 +0000 Subject: [Koha-bugs] [Bug 17401] Returns form not submitting after printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Benjamin, I don't understand how to test this and what happens, can you add a test plan? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:01:52 +0000 Subject: [Koha-bugs] [Bug 17763] New: Exact ponctuation and words order is needed for matching results for author and title in adv. search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 Bug ID: 17763 Summary: Exact ponctuation and words order is needed for matching results for author and title in adv. search Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org When we use in advanced search, the exact ponctuation ("," and "-") and words order (name, first name) is required to find the good author. Also, when we search by customer, we must put an "-" in the customer name to find the good one. Some people want a more flexible way to find the good author or the good customer in theirs orders. There is a patch or a fix of any kind to do this without ",", "-" and the specific word order ? I searched but find nothing related (maybe I miss something...) Thanks, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:03:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:03:25 +0000 Subject: [Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Alexandre, which search options are you using on the advanced search? Have you compared the author, phrase and the normal author search? Can you give a search example? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:08:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:08:31 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #25 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:10:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:10:23 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:12:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:12:44 +0000 Subject: [Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:13:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:13:58 +0000 Subject: [Koha-bugs] [Bug 17449] Let users choose action in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 Chuck McAndrew changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chuck.mcandrew at leblibrary.c | |om --- Comment #4 from Chuck McAndrew --- I tested this, everything worked fine except that scanning the barcode on the renew tab fails to renew the item. If you manually click the renew link, it renews the item, but entering the barcode doesn't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:20:21 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #22 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:21:52 +0000 Subject: [Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:24:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:24:05 +0000 Subject: [Koha-bugs] [Bug 15906] [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:24:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:24:05 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Bug 15896 depends on bug 15906, which changed state. Bug 15906 Summary: [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:24:06 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Bug 15905 depends on bug 15906, which changed state. Bug 15906 Summary: [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:26:28 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #44 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement and has dependencies that were not backported either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:26:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:26:29 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug 15894 depends on bug 15896, which changed state. Bug 15896 Summary: Use Koha::Account::pay internally for makepayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:26:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:26:29 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Bug 15897 depends on bug 15896, which changed state. Bug 15896 Summary: Use Koha::Account::pay internally for makepayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:29:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:29:59 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Patch status is set to "patch doesn't apply" - but both patches appear to have been pushed to master. I am resetting the status to reflect this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:30:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:30:05 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- Not that it particularly matters, because you shouldn't do this anyway - this patch breaks searching in the staff client for the database user superlibrarian. Only leaving this note in case someone else sees Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. and traces it back to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:30:07 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:30:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:30:58 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bug 17418 depends on bug 17416, which changed state. Bug 17416 Summary: Move javascript in doc-head-close.inc into a separate include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:30:57 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer --- These won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:32:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:32:15 +0000 Subject: [Koha-bugs] [Bug 17516] Add CSV export option to item search *after* displaying output to screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #5 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:33:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:33:04 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 12 23:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 22:33:05 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17556, which changed state. Bug 17556 Summary: Move GetHideLostItemsPreference to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 00:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Dec 2016 23:06:00 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 --- Comment #8 from Srdjan Jankovic --- Yes, that should be the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 04:05:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 03:05:16 +0000 Subject: [Koha-bugs] [Bug 16348] Kohacon 2012 is not on the website In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16348 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Liz Rea --- Hi Mirko, It doesn't seem to exist now. I'm quite sure I didn't delete it myself. Possibly the person who was maintaining the page deleted it. That really isn't too strange, the people writing that page would have had delete privileges. I've added a link to the internet archive page of the programme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 04:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 03:17:54 +0000 Subject: [Koha-bugs] [Bug 17764] New: OPAC search fails when lost items are in the result set and there is no logged in user Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Bug ID: 17764 Summary: OPAC search fails when lost items are in the result set and there is no logged in user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P2 Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org To replicate: Make sure you have at least one lost item in your result set Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included You will probably get an error: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 04:26:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 03:26:34 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- Hi, This script seems really dangerous, how will it know if it is cancelling a hold that is for something missing or lost, or one that someone legitimately placed on an item and it's just taking AGES to get through the (possibly very long) reserve list? I'd be concerned especially in libraries that routinely have very long waiting lists on popular titles. I feel like this needs some safeguards. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 07:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 06:50:05 +0000 Subject: [Koha-bugs] [Bug 17765] New: Hide 'Holds' link in staff result list when user has no permission to place holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Bug ID: 17765 Summary: Hide 'Holds' link in staff result list when user has no permission to place holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The "Holds" link on the staff result list is still visible, even if the user has no "reserveforothers" permission. At the same time it's not possible to place a hold from the detail page and you get a permission error when trying to use the link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 08:50:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 07:50:15 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 08:50:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 07:50:18 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58085|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 58148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58148&action=edit Bug 17742: Fix t/db_dependent/Patrons.t Moves the getting of testing date for updated_on just after the storing the test patron data to make the gap between generating data and now date as short as possible Fixes test 7 Use Koha::Database instead of C4::Context->dbh Test plan 1. prove t/db_dependent/Patrons.t 2. read the diff Signed-off-by: Chris Kirby Tests passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 08:57:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 07:57:15 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 --- Comment #7 from Josef Moravec --- (In reply to Jonathan Druart from comment #3) > (In reply to Chris Kirby from comment #2) > > Changes test #7 to the one which was probably originally intended > > No, the original test was good. We want to check that the updated_on value > has been updated when a patron is modified. I change the back to original test, fix it (I hope), now it's tested on firstname, instead of surname, which is needed in later test... and maked the tests use Koha::Database instead of C4:Context->dbh; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 10:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 09:52:29 +0000 Subject: [Koha-bugs] [Bug 17401] Returns form not submitting after printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Benjamin Rokseth --- Hi Katrin, there might be a bug in the bug ;) I believe we blamed the prevendefault for another weird behaviour, but unable to reproduce now, so either it is fixed, or we had a hickup. Closing this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:22:44 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58128|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 58149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58149&action=edit Bug 14146: Add the new pref CumulativeRestrictionPeriods Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:38:34 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:38:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:38:37 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58148|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 58150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58150&action=edit Bug 17742: Fix t/db_dependent/Patrons.t Moves the getting of testing date for updated_on just after the storing the test patron data to make the gap between generating data and now date as short as possible Fixes test 7 Use Koha::Database instead of C4::Context->dbh Test plan 1. prove t/db_dependent/Patrons.t 2. read the diff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:40:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:40:54 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 [Bug 7058] GetMemberDetails must die! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:40:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:40:54 +0000 Subject: [Koha-bugs] [Bug 7058] GetMemberDetails must die! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Depends on| |17578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:55:56 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 [Bug 17762] Ability to translate notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:55:56 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17234, 17666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 [Bug 17666] .perl atomic update does not work under kohadevbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 11:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 10:55:56 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 [Bug 17762] Ability to translate notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:01:43 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #12 from Josef Moravec --- (In reply to Marcel de Rooy from comment #11) > (In reply to Kyle M Hall from comment #10) > > (In reply to Marcel de Rooy from comment #8) > > > Please adjust this parameter: > > > > > > + lines => [$line], > > > > > > And check the comment on bug 15986 on the paypal script. > > > > Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' > > parameter. > > Could you please double-check? > I cannot find it. It was added by bug 15897 I think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:09:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:09:05 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:09:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:09:08 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57727|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 58151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58151&action=edit Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:09:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:09:18 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:26:44 +0000 Subject: [Koha-bugs] [Bug 7058] GetMemberDetails must die! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 17578 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:26:44 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #64 from Jonathan Druart --- *** Bug 7058 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:50:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:50:29 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:54:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:54:21 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #10 from Josef Moravec --- (In reply to Chris Kirby from comment #8) > (In reply to comment #7), > Hi Josef, thanks for the tip to upgrade the db schema. > > When one creates a "manual invoice" for a patron using one of the created > debit types, both the debit type code and the description are entered into > the "Description of charges." However, for the pre-existing debit types, the > debit type description is entered twice in the "description of charges". > Is there any reason for this difference? It's a bug, I am going to work on this a bit more... > When one creates a credit type, there is no field for default amount. Is > there any reason for leaving a default amount out of the credit type but > keeping it in the debit? Yes, the reason is, the when you are creating manual invoice, you often know the price of some kind of things, but you can't pretend which amount are people going to pay, or so... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:55:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:55:16 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #11 from Josef Moravec --- (In reply to Radek ?iman (R-Bit Technology, s.r.o.) from comment #9) > (In reply to Josef Moravec from comment #1) > > Created attachment 57856 [details] [review] [review] > > Bug 17702: Account types configuration - db changes > > > > Test plan: > > 1) Read the diff and confirm that it does make sense > > 2) Comment what does not make sense ;) > > According to db changes, is it possible to extend type_code from only 5 > chars to (let's say) 10 chars? It would be very useful for some libraries > having a longer list of payments not to be so cryptic. For instance, one of > them (Czech only - sorry): I have no problem with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:55:41 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth --- on further investigation, SIP checkin only lacks the reserve_id param to ModReserveAffect, which is rather weird, since it is the unique key on a reserve. Also ModReserveAffect and its called method _koha_notify_reserve should be rewritten to use Koha::Holds, and use the reserve_id but I will do this in a separate bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:55:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:55:49 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:55:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:55:52 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #5 from Jonathan Druart --- Created attachment 58152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58152&action=edit Bug 17726: TestBuilder - Add default values The items.more_subfields_xml is set to random data (generated by TestBuilder), and so GetMarcBiblio does not manage to embed items (if needed). The error is: :1: parser error : Start tag expected, '<' not found More precisely it explodes in C4::Items::_parse_unlinked_item_subfields_from_xml when MARC::Record->new_from_xml is called with an invalid xml This patch adds a default values mechanism to TestBuilder to avoid modifying all the existing calls. Test plan: Set SearchEngine to ElasticSearch prove t/db_dependent/Circulation.pl should return green with this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:56:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:56:11 +0000 Subject: [Koha-bugs] [Bug 17727] A lot of tests fail if SearchEngine is set to Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #2 from Jonathan Druart --- Will be fixed by bug 17726. *** This bug has been marked as a duplicate of bug 17726 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 12:56:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 11:56:11 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #6 from Jonathan Druart --- *** Bug 17727 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:15:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:15:16 +0000 Subject: [Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- We use 28,6 for almost all the price fields, I think we should stick with it. Have a look at bug 15770 and bug 11698. Note that the tests should be executed in a transaction and these random data should not persist in DB. If it happens, we need to fix the tests, which are the root of the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:15:36 +0000 Subject: [Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15770, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11698 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:15:36 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17164 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:15:36 +0000 Subject: [Koha-bugs] [Bug 11698] Add validity check for amount on budget page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17164 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:22:50 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- Nick, just a small concern: if you end with an empty line, you get "The item () does not exist". It seems easy to handle it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:26:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:26:39 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:26:43 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58013|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 58153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58153&action=edit Bug 14876 - Show number of holds per record on the search results This patch sues the existing plugin Koha::Template::Plugin::Biblio->HoldsCount To be consistent with current behaviour 'Holds (0)' is shown when no holds have been placed on an item To test: 1 - Search in staff 2 - Note holds link has no extra information 3 - Apply patch 4 - prove -v t/db_dependent/Template/Plugin/Holds.t 5 - Do search in staff that returns records with some holds (i.e. place some holds) 6 - Note the number of holds now displays next to the text of the link: Holds (#) Signed-off-by: Barbara Johnson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:40:12 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 --- Comment #2 from Benjamin Rokseth --- Created attachment 58154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58154&action=edit Bug 17758 - SIP checkin does not handle holds correctly This patch updates SIP checkin to use reserve_id as param, to fix regression introduced by Bug 14695. To test: Given 1 patron and 1 biblio with two items attached: 1) create two record level holds on one biblio on same user Using SIP client or telnet: 2) checkin item x on pickup branch, observe item is waiting and hold 1 is filled 3) checkin item y on pickup branch, observe item y now is waiting and x is available 4) apply this patch and repeat 1-3, now expected behaviour should be that both holds are filled and both items waiting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:40:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:40:27 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:51:56 +0000 Subject: [Koha-bugs] [Bug 17766] New: Patron notification does not work with multi item holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Bug ID: 17766 Summary: Patron notification does not work with multi item holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 14685 introduces multi item holds on same record, but notifications triggered by ModReserveAffect does not honour multiple this. When a patron has multiple reserves on same record, notifications will only pick the first, as the database query only uses biblionumber and borrowernumber. _koha_notify_reserve in C4::Reserves is only used once anyway, so it should probably be removed, but that is another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:52:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:52:36 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #57247|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 13:56:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 12:56:13 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #10 from Jonathan Druart --- I am lost with the different patches. Could someone tell me which one is the good one? Authorship has changed between the first submission and the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:09:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:09:55 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #11 from Alex Sassmannshausen --- Hi Jonathan, This is probably clear by now (I saw you obsoleted a patch). The right patch is Josef's. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:14:14 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:14:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:14:16 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58152|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 58155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58155&action=edit Bug 17726: TestBuilder - Add default values The items.more_subfields_xml is set to random data (generated by TestBuilder), and so GetMarcBiblio does not manage to embed items (if needed). The error is: :1: parser error : Start tag expected, '<' not found More precisely it explodes in C4::Items::_parse_unlinked_item_subfields_from_xml when MARC::Record->new_from_xml is called with an invalid xml This patch adds a default values mechanism to TestBuilder to avoid modifying all the existing calls. Test plan: Set SearchEngine to ElasticSearch prove t/db_dependent/Circulation.pl should return green with this patch Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:14:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:14:20 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #8 from Marcel de Rooy --- Created attachment 58156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58156&action=edit Bug 17726: [QA Follow-up] Add test descriptions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:17:17 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Marcel de Rooy --- (In reply to Josef Moravec from comment #12) > (In reply to Marcel de Rooy from comment #11) > > (In reply to Kyle M Hall from comment #10) > > > (In reply to Marcel de Rooy from comment #8) > > > > Please adjust this parameter: > > > > > > > > + lines => [$line], > > > > > > > > And check the comment on bug 15986 on the paypal script. > > > > > > Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' > > > parameter. > > > > Could you please double-check? > > I cannot find it. > > It was added by bug 15897 I think OK That's clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:25:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:25:15 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:25:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:25:18 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #2 from Kyle M Hall --- Created attachment 58157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58157&action=edit Bug 15985 - Include transacting library in fines Some librarians would like to see the library an item was checked out from in the fines table on the fines payment page. Test Plan: 1) Apply this patch 2) Find a patron with overdue items that have fines 3) Browse to the pay fines page 4) Note the new "checked out from" column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:32:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:32:19 +0000 Subject: [Koha-bugs] [Bug 17760] patron search not working in firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760 --- Comment #1 from Heinrich Hartl --- Problem continues to exist after upgrading to koha stable (16.11.0). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:32:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:32:29 +0000 Subject: [Koha-bugs] [Bug 17767] New: Let Koha::Patron::Modification handle extended attributes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Bug ID: 17767 Summary: Let Koha::Patron::Modification handle extended attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This is actually needed in order to implement bug 13757, because the underlying code doesn't handle extended attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:32:37 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:32:37 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 [Bug 17767] Let Koha::Patron::Modification handle extended attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:32:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:32:42 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:48:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:48:54 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17758 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 14:48:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 13:48:54 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17766 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:00:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:00:40 +0000 Subject: [Koha-bugs] [Bug 17760] patron search not working in firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760 --- Comment #2 from Heinrich Hartl --- Problem doesn't exist when tested from another laptop (windows 10, also Firefox 50.0.2). This suggests the problem is a problem with the laptop and not with koha. I will try to give more details as soon as available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:01:34 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 --- Comment #1 from Benjamin Rokseth --- Created attachment 58158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58158&action=edit Bug 17766 - Patron notification does not work with multi item holds This patch fixes notification when same biblio has multiple reserves with same borrower, introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id. To test: Prerequisites: - One biblio with two items attached - A patron with hold_filled notification activated - A letter for HOLD with <> in it 1) Place two reservations on same biblio 2) checkin item x on pickup branch, observe patron message generated 3) checkin item y on pickup branch, observe patron message generated 4) note that reserve_id is the same on both messages, which is wrong 5) apply this patch and repeat 1-3 6) now observe notifications have correct (different) reserve_id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:01:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:01:48 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:02:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:02:04 +0000 Subject: [Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:17:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:17:09 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:17:17 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #112 from Jonathan Druart --- QA comments (with bug 16735): 1/ treegrid plugin patches should be removed 2/ updatedb: I think we decided not to use Koha code from the updatedb process 3/ I have added a library to __SEARCH_GROUPS__, on the adv search form, the dropdown list contains an empty line, if I select it, the result list is empty 4/ There are 2 occurrences of Koha::Library->get_categories in C4/Circulation.pm 5/ There is a lack of tests, some new subroutines are not tested 6/ DB structure - updated_on could be "timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP". That would avoid the trick in ->store - Don't we want a constraint a the library_groups table? A unique key on title for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:22:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:22:46 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #40 from Magnus Enger --- (In reply to Chris Cormack from comment #37) > We are actually evaluating 9580 at the moment to see if it will meet all the > requirements of this bug. Will let you know shortly Any results from the evaluation yet? ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:27:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:27:10 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart --- accountlines_id has been removed from the param list, but it's still used in tests. We also need tests to highlight this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:33:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:33:37 +0000 Subject: [Koha-bugs] [Bug 17760] patron search not working in firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760 --- Comment #3 from Heinrich Hartl --- clearing the cache (Firefox options Advanced: Cached Web Content"clear now" has solved the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:36:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:36:17 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Nick, do you have any good reasons to use DateTime instead of dt_from_string to get today's date? Note that you could have use Koha::Libraries->search->get_column('branchcode') to get an iterator on the branchcodes. Please resubmit tidying the whole file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:41:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:41:47 +0000 Subject: [Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 --- Comment #2 from Alexandre --- Hi Katrin, I'm sorry, it's in the advanced search for acquisition module. here is the link : /koha/acqui/histsearch.pl I must also correct something, it's for the search by author and by dealers (not title). These terms must be exact to be found and with the good ponctuation. Thanks again, Alexandre from CCSR -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:45:39 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #14 from Owen Leonard --- Created attachment 58159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58159&action=edit Proposal for initial state of add guarantor form It seems that now the search for patrons to select as a guarantor includes patrons with a 'Child' type patron category. Is that intentional? Shouldn't they be excluded? I notice also that when you select a patron to be a guarantor, the patron number is no longer a link to the patron record. I think it would make more sense to not show the borrowernumber at all, but make the guarantor name a link: Surname, Firstname (cardnumber) I think it's confusing that there are two buttons, 'Add guarantor', 'Set to patron.' They could potentially mean the same thing. I think we might have the initial state of this form have only two links: 'Search to add guarantor' and 'Add guarantor manually' (see attached image). Clicking the 'Add manually' link would display the form along with a submit button, and the "Clear" link would be shown. The manual add form should prevent the user from submitting empty data. Sorry, I know that's a lot, and I'm willing to help with follow-ups if folks think these are good ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:46:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:46:06 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:46:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:46:26 +0000 Subject: [Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566 --- Comment #7 from Jonathan Druart --- With the second patch, I don't see the focus at all. It seems to be on the first select because when I tab it selects the second select. But I cannot interact with it (select an option). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:46:42 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:46:45 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58112|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 58160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58160&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall Signed-off-by: Edie Discher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:51:38 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:51:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:51:42 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57247|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 58161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58161&action=edit Bug 17472: Borrower Previously Checked Out: Display title Test plan: 0) apply the patch 1) turn on checking previously checkouts - syspref CheckPrevCheckout 2) checkout an item to borrower 3) check the item in and check it out again, you should see the dialog, with information that the current item was previously checked out to this patron. With this patch, the information includes title and author of the item Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 15:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 14:58:52 +0000 Subject: [Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > With the second patch, I don't see the focus at all. > It seems to be on the first select because when I tab it selects the second > select. But I cannot interact with it (select an option). Thats a browser problem that I cannot solve. The focus is there. See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:03:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:03:48 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:03:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:03:52 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58160|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58162&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall Signed-off-by: Edie Discher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:13:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:13:57 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #41 from Katrin Fischer --- We are really interested in this as well - centralizing the code would make it easier to add new content providers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:20:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:20:05 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #42 from Chris Cormack --- Yes, bug 9850 meets all the requirements of this. We have it in production for our sites. So we will not be doing any more work on this. Our recommendation is to use coce for book covers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:25:05 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #45 from Matthias Meusburger --- Benjamin, I can successfully map ccodes and item types. Can you explain this sentence : "Even on initial import (i.e the order edit screen when adding to a basket), it simply shows the our top collection alphabetically."? Notforloans are working for me (items are shown not available when needed) but I tested it with my last patch. Could you have another look at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:30:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:30:30 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- Aleisha, Have a look at your patches, there are some weird stuffs to fix: 1/ kohastructure: you re-add the entire item table 2/ update db: you should specify the "after" sql clause to keep the same order as the kohastructure (not necessary useful but good practice to have) 3/ There is no need to use strict and warnings alongside Modern::Perl; 4/ The svc script has a BibLibre copyright 5/ I don't understand the need of the new subroutine in the svc script (ajax_auth_cgi). You should not need it, have a look at how the other svc scripts deal with authentication 6/ QA script fails with: FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AllowIssueNotes is bad placed (see bug 10610) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:32:03 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 --- Comment #5 from Jonathan Druart --- Does that mean we need to remove NORMARC changes, to keep them or that does not matter? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:35:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:35:05 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:38:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:38:04 +0000 Subject: [Koha-bugs] [Bug 17763] Exact punctuation and word order is needed for matching author and title in acqui /histsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exact ponctuation and words |Exact punctuation and word |order is needed for |order is needed for |matching results for author |matching author and title |and title in adv. search |in acqui/histsearch.pl OS|Linux |All Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 16:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 15:45:49 +0000 Subject: [Koha-bugs] [Bug 17763] Exact punctuation and word order is needed for matching author and dealer names in acqui /histsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763 Alexandre changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exact punctuation and word |Exact punctuation and word |order is needed for |order is needed for |matching author and title |matching author and dealer |in acqui/histsearch.pl |names in | |acqui/histsearch.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 17:21:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 16:21:14 +0000 Subject: [Koha-bugs] [Bug 17768] New: spinelabel.css should be user editable. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17768 Bug ID: 17768 Summary: spinelabel.css should be user editable. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The quick-label CSS file is currently part of the Koha distribution, stored at koha-tmpl/intranet-tmpl/prog/en/css/spinelabel.css. This means that users who use package Koha cannot change the styling of the quick slips without resorting to javascript. I would suggest that koha-tmpl/intranet-tmpl/prog/en/css/spinelabel.css be a default, but that we can change this via syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 17:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 16:56:59 +0000 Subject: [Koha-bugs] [Bug 17769] New: Preference for patron username Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769 Bug ID: 17769 Summary: Preference for patron username Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: chris.kirby at ilsleypubliclibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a librarian creates a patron account, the username field defaults to firstname.lastname. However, many libraries change the default username to the patron cardnumber, or email address when they set up a new patron account. It would be useful if there were a branch level or system level preference for default username with the following choices: 1)firstname.lastname 2)patron cardnumber 3)primary email address -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 18:04:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 17:04:22 +0000 Subject: [Koha-bugs] [Bug 17760] patron search not working in firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760 Heinrich Hartl changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Severity|enhancement |minor Status|NEW |RESOLVED --- Comment #4 from Heinrich Hartl --- Apparently wrong content was cached by Firefox. This resulted in apparent function failure. Conditions for caching such wrong content are unknown. I can not reproduce the incorrect behaviour. Just in case some one else runs into a similar problem: clearing the cache may solve your problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 18:19:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 17:19:31 +0000 Subject: [Koha-bugs] [Bug 17769] Preference for patron username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |chris.kirby at ilsleypubliclib |ity.org |rary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 18:33:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 17:33:36 +0000 Subject: [Koha-bugs] [Bug 17769] Preference for patron username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769 --- Comment #1 from Chris Kirby --- I hope to put together a patch for this. Suggestions/feedback welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 19:05:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 18:05:12 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 19:05:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 18:05:14 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58157|0 |1 is obsolete| | --- Comment #3 from Jason Robb --- Created attachment 58163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58163&action=edit [SIGNED-OFF] Attachment to Bug 15985 - Include transacting library in fines Bug 15985 - Include transacting library in fines Some librarians would like to see the library an item was checked out from in the fines table on the fines payment page. Test Plan: 1) Apply this patch 2) Find a patron with overdue items that have fines 3) Browse to the pay fines page 4) Note the new "checked out from" column Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 19:25:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 18:25:09 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 --- Comment #6 from Magnus Enger --- (In reply to Jonathan Druart from comment #5) > Does that mean we need to remove NORMARC changes, to keep them or that does > not matter? :) My gut feeling says to just keep them. It should not hurt anyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 20:55:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 19:55:37 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #46 from Benjamin Daeuber --- Created attachment 58164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58164&action=edit Import screen I've attached a screenshot of the import screen, where I've highlighted in red the collection. That collection is the top alphabetical, even though the based on the collection in the order file, the first should be a book and the next a book club in a bag. It appears at this point that the collection code is correct. I've highlighted in green. The next two are ccode_1 and ccode_2, which are the item edit screens for both of these items. They both have the top collection code alphabetically, rather than the collection code we saw at import. Again, called in in green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 20:56:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 19:56:17 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #47 from Benjamin Daeuber --- Created attachment 58165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58165&action=edit Item information after import 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 20:57:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 19:57:09 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #48 from Benjamin Daeuber --- Created attachment 58166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58166&action=edit Item information after import 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 21:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 20:04:36 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 58167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58167&action=edit Bug 17755: (followup) Rename ::Library::Limit for ::Limit::Library It makes sense to rename it, as there might be other limits defined, not just library-wise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 21:45:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 20:45:55 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #49 from Benjamin Daeuber --- (In reply to Benjamin Daeuber from comment #46) > Created attachment 58164 [details] > Import screen > > I've attached a screenshot of the import screen, where I've highlighted in > red the collection. That collection is the top alphabetical, even though the > based on the collection in the order file, the first should be a book and > the next a book club in a bag. By this I mean Item Type, sorry. The item type for both is Audiobook, even though the item types in the order file are different (and both valid). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 22:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 21:50:05 +0000 Subject: [Koha-bugs] [Bug 17770] New: t/db_dependent/ Sitemapper.t fails when date changes during test run Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770 Bug ID: 17770 Summary: t/db_dependent/Sitemapper.t fails when date changes during test run Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de QA Contact: gmcharlt at gmail.com (22:48:28) tcohen: we need to fix the test (22:48:34) tcohen: so it mocks the current date t_db_dependent_Sitemapper_t.Its content is valid (369) Failing for the past 1 build (Since Unstable#6 ) Took 0 ms. Error Message not ok 12 - Its content is valid Standard Output 1..16 ok 1 - use Koha::Sitemapper; ok 2 - use Koha::Sitemapper::Writer; ok 3 - add fixtures ok 4 - File sitemapindex.xml created ok 5 - Its content is valid ok 6 - File sitemap0001.xml created ok 7 - Its content is valid ok 8 - File sitemap0001.xml with short URLs created ok 9 - Its content is valid ok 10 - add fixtures ok 11 - File sitemapindex.xml for 75000 bibs created not ok 12 - Its content is valid ok 13 - File sitemap0001.xml created ok 14 - It contains 50000 URLs ok 15 - File sitemap0002.xml created ok 16 - It contains 25000 URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 22:53:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 21:53:52 +0000 Subject: [Koha-bugs] [Bug 17771] New: Add link to bibliographic record on spent/ ordered lists in acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Bug ID: 17771 Summary: Add link to bibliographic record on spent/ordered lists in acquisitions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The funds table on the start page of the acquisitions module provides links to open orders (ordered) and received orders (spent) for each fund. On the lists, there is no way to see the details of an ordered record. It would be nice to provide a link to the staff detail page of the ordered titles. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 23:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 22:10:15 +0000 Subject: [Koha-bugs] [Bug 17772] New: Allow to sort lists by date the record was created Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17772 Bug ID: 17772 Summary: Allow to sort lists by date the record was created Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Lists in OPAC and staff can be sorted by different fields. It would be nice if we could offer 'date created' as an additional option for sorting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 23:26:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 22:26:52 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The same happens for fields like 952$x. I just tested on master and it also gives back all results instead of filtering. We think this used to work sometime prior to 3.22.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 13 23:42:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Dec 2016 22:42:34 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #32 from Andreas Hedstr?m Mace --- I started testing this today and after some initial confusion about the rules system (that could use some more documentation!) it seems mostly to work as intended. But am I correct in understanding that Marc field permissions does not currently work with Staged MARC Imports? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 02:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 01:56:20 +0000 Subject: [Koha-bugs] [Bug 17769] Preference for patron username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Chris Kirby --- This bug is a duplicate of Bug 2237. *** This bug has been marked as a duplicate of bug 2237 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 02:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 01:56:20 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org --- Comment #7 from Chris Kirby --- *** Bug 17769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 09:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 08:14:21 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #7 from Josef Moravec --- Radek, what did you do with the patches? Looks like you join the second patch with commit message of first patch, so there is now code for second patch twice and no code from first patch... If don't know what happens, I can resubmit the original patches... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 09:27:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 08:27:30 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 09:27:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 08:27:49 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 09:33:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 08:33:29 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Josef Moravec --- I was contacted by Radek off Bugzilla and he now knows where the problem is and will try to re-sign off it, so I obsolete his attachment and unobsolete the original one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:04:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:04:00 +0000 Subject: [Koha-bugs] [Bug 17495] reports/issues_stats.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17495 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:05:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:05:44 +0000 Subject: [Koha-bugs] [Bug 16991] Add subtitle to holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:06:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:06:07 +0000 Subject: [Koha-bugs] [Bug 17773] New: Not able to add or edit a record; error on screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 Bug ID: 17773 Summary: Not able to add or edit a record; error on screen Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: freerk at ostrain.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl While editing or adding a new record I get the message: Software error: Not a HASH reference at /usr/share/perl/5.18/Module/Load/Conditional.pm line 216. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. --- Does anyone recognize this message? Btw the webmasters address IS given -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:06:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:06:21 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:06:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:06:38 +0000 Subject: [Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:07:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:07:06 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:07:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:07:13 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 Freerk Jongsma changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freerk at ostrain.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:07:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:07:26 +0000 Subject: [Koha-bugs] [Bug 17476] Failed test 'Create DateTime with dt_from_string() for 2100-01-01 with TZ in less than 2s' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:08:36 +0000 Subject: [Koha-bugs] [Bug 14435] Recover feature to store and access results of a report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #34 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:09:02 +0000 Subject: [Koha-bugs] [Bug 17535] Regression: Search for reports by keywords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:09:40 +0000 Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #22 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:10:11 +0000 Subject: [Koha-bugs] [Bug 17552] Koha::Objects->reset does no longer allow chaining In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17552 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:16:55 +0000 Subject: [Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12478 CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:16:55 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:18:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:18:40 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:18:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:18:40 +0000 Subject: [Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14828 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:19:54 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #19 from Mirko Tietgen --- Mason: I split the bugs for this, please use only the oldstable one to push to 16.05, because dependencies won't be the same for each branch. You can find it here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:20:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:20:47 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC|julian.maurice at biblibre.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:21:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:21:22 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #21 from Mirko Tietgen --- 16.05 is oldstable now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:21:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:21:57 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC|frederic at tamil.fr |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:22:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:22:07 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #1 from Mirko Tietgen --- 16.11 is stable now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:27:15 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #1 from Freerk Jongsma --- Found in antranet-error.log (last 3 lines): [Wed Dec 14 10:42:06.203900 2016] [cgi:error] [pid 31714] [client 217.123.249.85:43086] AH01215: [Wed Dec 14 10:42:06 2016] addbiblio.pl: Not a HASH reference at /usr/share/perl/5.18/Module/Load/Conditional.pm line 216., referer: http://kbhw.nl:8080/cgi-bin/koha/cataloguing/addbiblio.pl [Wed Dec 14 10:51:30.973627 2016] [cgi:error] [pid 31796] [client 217.123.249.85:45552] AH01215: [Wed Dec 14 10:51:30 2016] addbiblio.pl: Not a HASH reference at /usr/share/perl/5.18/Module/Load/Conditional.pm line 216., referer: http://kbhw.nl:8080/cgi-bin/koha/cataloguing/addbiblio.pl [Wed Dec 14 10:59:43.480024 2016] [cgi:error] [pid 31849] [client 217.123.249.85:47740] AH01215: [Wed Dec 14 10:59:43 2016] addbiblio.pl: Not a HASH reference at /usr/share/perl/5.18/Module/Load/Conditional.pm line 216., referer: http://www.kbhw.nl:8080/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=BKS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:30:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:30:50 +0000 Subject: [Koha-bugs] [Bug 17564] Acquisition/OrderUsers.t is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:31:55 +0000 Subject: [Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:32:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:32:45 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #134 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:33:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:33:35 +0000 Subject: [Koha-bugs] [Bug 17572] Remove issue.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:40:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:40:47 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #22 from Mason James --- (In reply to Mirko Tietgen from comment #21) > 16.05 is oldstable now. thanks, the 16.05.x branch is now up to date with this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:47:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:47:01 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #23 from Mason James --- (In reply to Mason James from comment #22) > (In reply to Mirko Tietgen from comment #21) > > 16.05 is oldstable now. > > thanks, the 16.05.x branch is now up to date with this patch ...so, this BZ can be now resolved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:47:46 +0000 Subject: [Koha-bugs] [Bug 17573] Remove DecreaseLoanHighHolds.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17573 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:48:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:48:11 +0000 Subject: [Koha-bugs] [Bug 17574] Remove LocalholdsPriority.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17574 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:48:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:48:49 +0000 Subject: [Koha-bugs] [Bug 17575] Remove Circulation.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17575 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:49:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:49:20 +0000 Subject: [Koha-bugs] [Bug 17587] Remove itemtype-related IsItemIssued.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:49:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:49:46 +0000 Subject: [Koha-bugs] [Bug 17592] Remove itemtype-related maxsuspensiondays.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 11:52:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 10:52:51 +0000 Subject: [Koha-bugs] [Bug 17774] New: Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 Bug ID: 17774 Summary: Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: eugenegf at yahoo.com QA Contact: testopia at bugs.koha-community.org In a new Koha 16.11 instance, when adding orders to basket with the following system preferences: a) AcqCreateItem = placing an order b) autoBarcode is set to generated in the form yymm0001. c) plack enabled d) 952$o has plugin 'barcode.pl' A barcode is not filled up (just clicked 'Add item' button) during adding of items since it is implicitly stated in the interface: "The autoBarcode system preference is set to hbyymmincr and items with blank barcodes will have barcodes generated upon save to database." However, when the order is being saved, I am getting internal server error. So, I have to click the Back button to go back to what I'm doing. And when I returned to the "add orders to basket" interface, and then click save to finish the transaction, I am able to finish the transaction, however, I now get two items ordered, first one with only the title and the second one has the title and the patron who suggested the material (see http://koha.1045719.n5.nabble.com/file/n5913371/acqui_internal_server_error.png). Tried this in another server with same database, however I'm getting "Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 68" But when brought to the Basket no., I can see the order. Delving into the plack-error message in the first server: No existing hbyymmincr barcodes found. Reverting to initial value. at /usr/share/koha/lib/C4/Barcodes/hbyymmincr.pm line 62. DBD::mysql::st execute failed: Duplicate entry 'DLSU-D16120002' for key 'itembarcodeidx' [for Statement "INSERT INTO items SET biblionumber = ?, biblioitemnumber = ?, barcode = ?, dateaccessioned = ?, booksellerid = ?, homebranch = ?, price = ?, replacementprice = ?, replacementpricedate = ?, datelastborrowed = ?, datelastseen = ?, stack = ?, notforloan = ?, damaged = ?, itemlost = ?, withdrawn = ?, itemcallnumber = ?, coded_location_qualifier = ?, restricted = ?, itemnotes = ?, itemnotes_nonpublic = ?, holdingbranch = ?, paidfor = ?, location = ?, permanent_location = ?, onloan = ?, issues = ?, renewals = ?, reserves = ?, cn_source = ?, cn_sort = ?, ccode = ?, itype = ?, materials = ?, uri = ?, enumchron = ?, more_subfields_xml = ?, copynumber = ?, stocknumber = ?, new_status = ? " with ParamValues: 0="4911", 1='4911', 2="DLSU-D16120002", 3='2016-12-14', 4=undef, 5="DLSU-D", 6=undef, 7=undef, 8='2016-12-14', 9=undef, 10='2016-12-14', 11=undef, 12=0, 13=0, 14=0, 15=0, 16=undef, 17=undef, 18=undef, 19=undef, 20=undef, 21="DLSU-D", 22=undef, 23=undef, 24=undef, 25=undef, 26=undef, 27=undef, 28=undef, 29="lcc", 30='', 31=undef, 32=undef, 33=undef, 34=undef, 35=undef, 36=undef, 37=undef, 38=undef, 39=undef] at /usr/share/koha/lib/C4/Items.pm line 2119. DBD::mysql::st execute failed: Column 'itemnumber' cannot be null [for Statement "INSERT INTO `aqorders_items` ( `itemnumber`, `ordernumber`) VALUES ( ?, ? )" with ParamValues: 0=undef, 1='45'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. And the second server's intranet error log snippet: [Wed Dec 14 18:15:55.903548 2016] [cgi:error] [pid 19570] [client 112.198.75.180:54634] AH01215: [Wed Dec 14 18:15:55 2016] addorder.pl: " with ParamValues: 0="4914", 1='4913', 2="DLSU-D16120002", 3='2016-12-14', 4=undef, 5="DLSU-D", 6=undef, 7=undef, 8='2016-12-14', 9=undef, 10='2016-12-14', 11=undef, 12=0, 13=0, 14=0, 15=0, 16=undef, 17=undef, 18=undef, 19=undef, 20=undef, 21="DLSU-D", 22=undef, 23=undef, 24=undef, 25=undef, 26=undef, 27=undef, 28=undef, 29="lcc", 30='', 31=undef, 32=undef, 33=undef, 34=undef, 35=undef, 36=undef, 37=undef, 38=undef, 39=undef] at /usr/share/koha/lib/C4/Items.pm line 2119. I feel that the barcode is not auto-incrementing (but I don't know why it isn't) as I see in the first server the same barcode 'DLSU-D16120002' is showing up several times, and this is supposed to be incremented. I also see that this barcode is already used by another item. A discussion of this is in http://koha.1045719.n5.nabble.com/Acquisitions-module-internal-server-error-td5913371.html#a5914017 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:01:53 +0000 Subject: [Koha-bugs] [Bug 17774] Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 --- Comment #1 from Eugene Espinoza --- I tried renaming the barcode of the item that already has the problematic barcode. I was able to successfully add an order into the basket by going through the same process as described in the first post. I added again another order into the basket (based from a suggestion), I got same error message as described in the second server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:04:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:04:26 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:04:29 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57946|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 58168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58168&action=edit Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed This patch makes Zebra index the 648$9 link for chronological terms on bibliographic records. This way an authority search on chronological terms will show the right number in 'Used in X records' message. To test: - Have a record with a 648 field, linked to an authority record (i.e. with an authid on 648$9). - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => FAIL: the term is linked to our record, but koha shows '0' count. - Apply the patch - Run: $ cd kohaclone $ xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ git diff => SUCCESS: Notice the shipped etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl is up-to-date - Run: $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ sudo koha-restart-zebra kohadev $ sudo koha-rebuild-zebra -f -b -v kohadev - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => SUCCESS: the term is linked to our record, usage count is 1 - Sign off :-D I assume NORMARC is similar on this regard. Feel free to fail it if the NORMARC part of the patch is wrong. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Hugo Agud Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:06:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:06:20 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #4 from Jonathan Druart --- I don't understand why this is signed off while the dependencies do not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:06:46 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #24 from Mirko Tietgen --- it's an ongoing thing. I set it back to assigned after push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:08:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:08:37 +0000 Subject: [Koha-bugs] [Bug 17603] Remove itemtype-related Borrower_Discharge.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:09:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:09:26 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (oldstable) |updates (16.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:09:52 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (unstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (16.05.x) |updates (unstable/16.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:10:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:10:09 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (unstable/16.05.x) |updates (oldstable/16.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:15:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:15:09 +0000 Subject: [Koha-bugs] [Bug 17582] Cannot edit an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:15:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:15:35 +0000 Subject: [Koha-bugs] [Bug 17634] Unit test t/db_dependent/ArticleRequests.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17634 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:16:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:16:04 +0000 Subject: [Koha-bugs] [Bug 17637] Auth_with_ldap.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17637 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:16:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:16:31 +0000 Subject: [Koha-bugs] [Bug 17641] t/Biblio/Isbd.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17641 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:17:46 +0000 Subject: [Koha-bugs] [Bug 17633] Tests should not call set_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:18:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:18:22 +0000 Subject: [Koha-bugs] [Bug 17640] t/db_dependent/Template/Plugin/Categories.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17640 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:19:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:19:16 +0000 Subject: [Koha-bugs] [Bug 17644] t/db_dependent/Exporter/Record.t fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17644 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:19:39 +0000 Subject: [Koha-bugs] [Bug 17646] Remove itemtype-related IssueSlip.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17646 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:20:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:20:10 +0000 Subject: [Koha-bugs] [Bug 17636] Remove itemtype-related GetIssues.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17636 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:21:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:21:02 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- 2 quick comments: 1/ Maybe it would be better to have only 1 syspref, or at least squash them into the same syspref block (in the .pref file) 2/ It would be great to move GetBorrowersToSatisfyHold to the Koha namespace and return objects instead. I don't think they are blocker, but recommended. I am failing it because you do not provide tests for the changes you made in subroutines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:21:16 +0000 Subject: [Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #78 from Mason James --- New feature, skipping for 16.05.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:21:48 +0000 Subject: [Koha-bugs] [Bug 17659] sample_notices.sql is broken for fr-QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17659 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- Blocked by New-feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:22:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:22:42 +0000 Subject: [Koha-bugs] [Bug 17576] Add HSBND_FREQ authorised value to translated installer sample files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- New feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:23:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:23:11 +0000 Subject: [Koha-bugs] [Bug 12359] hidepatronname doesn't hide on the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:23:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:23:36 +0000 Subject: [Koha-bugs] [Bug 17647] Remove itemtype-related CancelReceipt.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:24:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:24:05 +0000 Subject: [Koha-bugs] [Bug 17653] Remove itemtype-related t/db_dependent/Circulation* warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17653 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:25:02 +0000 Subject: [Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:25:39 +0000 Subject: [Koha-bugs] [Bug 17654] Add tests to enforce swagger definition files integrity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17654 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:27:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:27:35 +0000 Subject: [Koha-bugs] [Bug 17657] Item type' s images could not be displayed correctly on the item types admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:28:03 +0000 Subject: [Koha-bugs] [Bug 17545] Make "Add biblio" not hidden by language chooser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:30:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:30:48 +0000 Subject: [Koha-bugs] [Bug 17601] Regression: Incomplete CSS update introduced by Bug 14610 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:31:21 +0000 Subject: [Koha-bugs] [Bug 17645] Remove obsolete interface customization images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17645 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:31:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:31:47 +0000 Subject: [Koha-bugs] [Bug 17559] Invalid ID of element B_streetnumber in member edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:34:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:34:18 +0000 Subject: [Koha-bugs] [Bug 17642] Authorised values code is broken because of the refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #42 from Mason James --- (In reply to Kyle M Hall from comment #41) > Pushed to master for 16.11, thanks Jonathan, Marcel! hmm, this patch seems to depend on a not-yet-pushed patch (15799) is that ok? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:34:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:34:44 +0000 Subject: [Koha-bugs] [Bug 17638] t/db_dependent/Search.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:35:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:35:17 +0000 Subject: [Koha-bugs] [Bug 17132] Availability search broken when using Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:35:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:35:37 +0000 Subject: [Koha-bugs] [Bug 17626] INSTALL files are outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17626 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:36:27 +0000 Subject: [Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in Swagger tags for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Blocked by deps, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:37:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:37:54 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #43 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:40:49 +0000 Subject: [Koha-bugs] [Bug 17616] Select tag on elasticsearch mappings page is not closed properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Some conflicts, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:57:34 +0000 Subject: [Koha-bugs] [Bug 8835] Two indexes on biblioitems.issn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Possible selection for 16.05.x (16.05.07) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 12:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 11:58:16 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #25 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:00:13 +0000 Subject: [Koha-bugs] [Bug 17609] Small typo in ElasticSearch mappings (mappings.tt) and about page (about.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17609 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Some conflicts, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:01:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:01:29 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #144 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:01:38 +0000 Subject: [Koha-bugs] [Bug 17635] (Bug 6934 followup) Templates missing body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 --- Comment #6 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:02:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:02:25 +0000 Subject: [Koha-bugs] [Bug 17642] Authorised values code is broken because of the refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #43 from Jonathan Druart --- (In reply to Mason James from comment #42) > (In reply to Kyle M Hall from comment #41) > > Pushed to master for 16.11, thanks Jonathan, Marcel! > > hmm, this patch seems to depend on a not-yet-pushed patch (15799) > is that ok? > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Yes, bug 15799 is an omnibus. But you do not need it for 16.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:02:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:02:24 +0000 Subject: [Koha-bugs] [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:02:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:02:59 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:03:26 +0000 Subject: [Koha-bugs] [Bug 17420] record export fails when itemtype on biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17420 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:04:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:04:18 +0000 Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 --- Comment #20 from Mason James --- Blocked by deps, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:05:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:05:17 +0000 Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 --- Comment #13 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:05:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:05:41 +0000 Subject: [Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 --- Comment #6 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:08:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:08:41 +0000 Subject: [Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:09:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:09:20 +0000 Subject: [Koha-bugs] [Bug 17484] Searching with date range limit (lower and upper) does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:12:48 +0000 Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Depends on|7172 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:12:48 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17392, 16444 Blocks|17392, 16444 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444 [Bug 16444] C4::Tags is not plack safe https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 [Bug 17392] opac/svc/overdrive_proxy is not plack safe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:12:48 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Depends on|7172 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:13:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:13:42 +0000 Subject: [Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:14:21 +0000 Subject: [Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:14:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:14:48 +0000 Subject: [Koha-bugs] [Bug 17590] Exporting reports as CSV with 'delimiter' SysPref set to ' tabulation' creates files with 't' as separator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:15:15 +0000 Subject: [Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:18:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:18:57 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #2 from Marcel de Rooy --- Hi Freerk, You need to provide more details before anyone can be of help. Which version of Koha? On which Linux version? With Plack, memcached, etc? The perl 5.18 tells me that you are probably not on Jessie. Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:20:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:20:36 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- I am not sure a button is the right element to use here. Maybe a simple link is enough. CCing Owen to get his opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:25:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:25:33 +0000 Subject: [Koha-bugs] [Bug 17550] Display additional patron data in patron suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- Theodoros, do you want me to change the name and email address used in the patch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:33:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:33:16 +0000 Subject: [Koha-bugs] [Bug 17550] Display additional patron data in patron suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #14 from Jonathan Druart --- This value is not used anywhere else, why do you want to display it there? To me it's not consistent to display the initials in only one place, I guess the problem is the same on the other patron search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:36:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:36:12 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:36:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:36:15 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | Attachment #58010|0 |1 is obsolete| | --- Comment #9 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58169&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:38:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:38:35 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:38:39 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56113|0 |1 is obsolete| | Attachment #56116|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 58170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58170&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in /etc/sms/driver/.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in /etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). Signed-off-by: Magnus Enger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:38:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:38:41 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58169|0 |1 is obsolete| | --- Comment #10 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58171&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:39:03 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #25 from Jonathan Druart --- Created attachment 58172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58172&action=edit Bug 13029 : Follow up Adding POD, changing the config files to live in a path pointed to by koha-conf.xml This means multiple instances can have their own config Please test the 2 patches together Signed-off-by: Magnus Enger Works as advertised. Arbitrary arguments can be passed to SMS:Send drivers. If an argument is provided that has already been set by SMS::Send or the driver, it will be overwritten by the value from the YAML file. My only suggestion for an improvement would be an example of what the YAML should look like, but that is a minor thing. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:40:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:40:22 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:40:37 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58010|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:40:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:40:52 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:41:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:41:51 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Radek ?iman (R-Bit Technology, s.r.o.) --- Please forgive me, I'm really trying to do my best :-( I'm about to sign-off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:43:31 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:43:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:43:36 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55964|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 58173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58173&action=edit Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. Followed test plan, works as expected. Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise you can not save. Maybe that should be mentioned in the comment for syspref autoMemberNum. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:45:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:45:37 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:45:41 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | --- Comment #12 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58174&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:49:45 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:51:22 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58010|0 |1 is obsolete| | --- Comment #13 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 58175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58175&action=edit Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence Signed-off-by: Radek ?iman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:54:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:54:15 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #1 from Marcel de Rooy --- Created attachment 58176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58176&action=edit Bug 17669: Introduce new preference for purging temp uploads The new preference is: Upload_PurgeTemporaryFiles_Days. It controls if the cron job will delete temporary uploaded files and if so, how many days should have passed before doing so. Since the default value is empty, it will not start deleting these uploads until you change the pref. No behavior change. But the dbrev will print a message if you already have temporary uploads. Test plan: [1] Check Administration, Preferences, Tools for the new pref. [2] Run the db rev. If you have temporary uploads, check the reported count. [3] Bonus: Run sysprefs.sql in a safe environment. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:54:18 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #2 from Marcel de Rooy --- Created attachment 58177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58177&action=edit Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:54:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:54:22 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #3 from Marcel de Rooy --- Created attachment 58178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58178&action=edit Bug 17669: Incorporate the changes in cleanup_database Two command line options are added: [1] -temp-uploads to indicate that you want to purge these uploads, [2] -temp-uploads-override DAYS to (optionally) tell that you want to override the corresponding pref value. Test plan: [1] Check the modified usage statement. [2] If needed, backup your temporary uploads :) In case you do not have one, add a temporary one with Tools/Upload. Note: Do not choose an upload category. [3] Set pref to 0, and run cleanup_database with only --temp-uploads. No files should be deleted. [4] Check number of "old" temp uploads. Set pref to nonzero value. Verify that the oldest are gone (depending on the value chosen). [5] Set pref to 0 again. If all uploads are gone now, add a new one with Tools/Upload. Run cleanup_database with --temp-uploads --temp-uploads-override -1 All temporary files are gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:54:25 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #4 from Marcel de Rooy --- Created attachment 58179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58179&action=edit Bug 17669: Add new switch to crontab example and debian daily cron file The new switch for deleting temporary uploads in cleanup_database can be added to cron. Note: Since the option --temp-uploads does only purge temporary uploads when triggered by the preference Upload_PurgeTemporaryFiles_Days, it can be safely added here. Test plan: There is actually nothing to test here if you followed the preceding test plans. Just verify that the switch is inserted ocrrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:55:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:55:15 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > FAIL cataloguing/value_builder/barcode.pl > FAIL valid > "my" variable $DEBUG masks earlier declaration in same scope > > FAIL cataloguing/value_builder/barcode_manual.pl > FAIL valid > "my" variable $DEBUG masks earlier declaration in same scope Please read comment4. Back to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:57:45 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Marcel de Rooy --- Testers: Please apply 17501 first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 13:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 12:58:25 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Tools |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:02:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:02:51 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:02:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:02:55 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55981|0 |1 is obsolete| | Attachment #55982|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 58180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58180&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:11:31 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:20:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:20:58 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC|m.r.davis at me.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:22:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:22:43 +0000 Subject: [Koha-bugs] [Bug 17775] New: blocker of bug 7172 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Bug ID: 17775 Summary: blocker of bug 7172 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: mnashbat at alfaisal.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Koha & ldap authentication fail authenticating new users when enabling plack, it works fine only if plack is desabled. Ldap authentication works fine with old registered users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:24:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:24:44 +0000 Subject: [Koha-bugs] [Bug 17775] blocker of bug 7172 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Mohammed Nashbat changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |Jonathan Druart patch off| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:48:06 +0000 Subject: [Koha-bugs] [Bug 17775] blocker of bug 7172 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Blocks| |7172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:48:06 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 [Bug 17775] blocker of bug 7172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:49:50 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Summary|blocker of bug 7172 |Add new user with LDAP not | |works under Plack Who signed the|Jonathan Druart | patch off| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 14:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 13:52:59 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #1 from Zeno Tajoli --- More on this bug: the problem is add new user from LDAP, using the automatic population of Koha borrower table by LDAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:00:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:00:36 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:01:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:01:18 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:05:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:05:38 +0000 Subject: [Koha-bugs] [Bug 16815] API routes to list, create, update, delete holds need permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14868 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:05:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:05:38 +0000 Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 --- Comment #57 from Tom?s Cohen Arazi --- *** Bug 16815 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:11:03 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at seab.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:16:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:16:53 +0000 Subject: [Koha-bugs] [Bug 17536] Remove Duplication of receipting code in EDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:16:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:16:53 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 [Bug 17536] Remove Duplication of receipting code in EDI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:17:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:17:02 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 [Bug 17692] Can't add library EAN under Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:17:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:17:02 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:17:16 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |unspecified CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:20:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:20:16 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Can anyone confirm this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:21:44 +0000 Subject: [Koha-bugs] [Bug 17776] New: Shibboleth Authentication is broken in plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Bug ID: 17776 Summary: Shibboleth Authentication is broken in plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Shibboleth authentication relies heavily on per request environment variable, which doesn't play nicely with persistent apps (plack). We need to convert to using request headers in this case and update the documentation to reflect this alteration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:27:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:27:03 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:44:11 +0000 Subject: [Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:55:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:55:30 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #18 from Radek ?iman (R-Bit Technology, s.r.o.) --- Jonathan, could you please tell me more regarding your syspref suggestion? I thought it's been already squashed into one single section having 2 sysprefs. Have you meant to do it another way? This is current layout: http://prntscr.com/djd0f0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 15:59:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 14:59:27 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #10 from Hugo Agud --- Hi After applying the patch I get an internal Server error and I can see this log i plack-error.log DBD::mysql::st execute failed: Unknown column 'me.lang' in 'field list' [for Statement "SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`, `me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`, `me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`, `me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang` FROM `borrowers` `me` WHERE ( `userid` = ? )" with ParamValues: 0='Odigital'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.lang' in 'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:09:12 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 [Bug 17767] Let Koha::Patron::Modification handle extended attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:09:12 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:51:15 +0000 Subject: [Koha-bugs] [Bug 17777] New: koha-remove should deal with temporary uploads Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Bug ID: 17777 Summary: koha-remove should deal with temporary uploads Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:51:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:51:29 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:58:35 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 16:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 15:58:38 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 --- Comment #1 from Marcel de Rooy --- Created attachment 58181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58181&action=edit Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:01:10 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:01:10 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature ( see also 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17777 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:02:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:02:15 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature ( see also 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #8 from Marcel de Rooy --- Three reports in NSO now: 17501 for Koha Object, 17669 for purging temp files and 17777 for a fix in koha-remove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:37:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:37:22 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #19 from Jonathan Druart --- (In reply to Radek ?iman (R-Bit Technology, s.r.o.) from comment #18) > Jonathan, could you please tell me more regarding your syspref suggestion? I > thought it's been already squashed into one single section having 2 > sysprefs. Have you meant to do it another way? This is current layout: > http://prntscr.com/djd0f0 Indeed, I wrongly wrote the diff. You can forget this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:44:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:44:49 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #11 from Jonathan Druart --- (In reply to Hugo Agud from comment #10) > After applying the patch I get an internal Server error and I can see this > log i plack-error.log Hi Hugo, You need to apply patches from bug 17234 (not the 3.14 patch) and bug 17666. Then you have to execute the updatedatabase script (`perl installer/data/mysql/updatedatabase.pl`) to update the DB structure. Then restart plack and everything should go fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 17:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 16:50:34 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Which version of Module::Load::Conditional are you using? Lowering the severity until it's confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:03:05 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:03:05 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:04:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:04:32 +0000 Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at seab.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:04:36 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:10:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:10:12 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:10:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:10:16 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 --- Comment #1 from Jonathan Druart --- Created attachment 58182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58182&action=edit Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:33:20 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:33:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:33:24 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 --- Comment #1 from Jonathan Druart --- Created attachment 58183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58183&action=edit Bug 17486: Remove Mozilla Persona Persona never really took off, and although many browsers currently support it, very few services actually implement it. This has lead to it's founders, Mozilla, to end the project. In their own words: ================================================================================= Persona is no longer actively developed by Mozilla. Mozilla has committed to operational and security support of the persona.org services until November 30th, 2016. On November 30th, 2016, Mozilla will shut down the persona.org services. Persona.org and related domains will be taken offline. If you run a website that relies on Persona, you need to implement an alternative login solution for your users before this date. For more information, see this guide to migrating your site away from Persona: https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers ================================================================================= Given the above, and that the Persona authentication methods as a whole are no longer being actively maintained by anyone anywhere to ensure ongoing security, we should deprecate the option from koha. Test plan: Apply this patch and make sure you do not find any references of Persona Have a look at patches from bug 9587 and confirm that everything has been reverted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:33:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:33:59 +0000 Subject: [Koha-bugs] [Bug 9587] Allow login via mozilla persona - https://www.mozilla.org/en-US /persona/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 [Bug 17486] Remove 'Mozilla Persona' as an authentication method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:33:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:33:59 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 [Bug 9587] Allow login via mozilla persona - https://www.mozilla.org/en-US/persona/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:38:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:38:01 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57208|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58184&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:38:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:38:14 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 [Bug 17486] Remove 'Mozilla Persona' as an authentication method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:38:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:38:14 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:42:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:42:57 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:43:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:43:01 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57956|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 58185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58185&action=edit Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:43:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:43:52 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #11 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #8) > > FAIL cataloguing/value_builder/barcode.pl > > FAIL valid > > "my" variable $DEBUG masks earlier declaration in same scope > > > > FAIL cataloguing/value_builder/barcode_manual.pl > > FAIL valid > > "my" variable $DEBUG masks earlier declaration in same scope > > Please read comment4. > Back to SO Sorry about that. Yes it's because we now "use" intead of "require". These DEBUG variables are completely useless and could be removed, but it's outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 18:47:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 17:47:02 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard --- I agree that a button isn't appropriate for what is acting as a link. I would suggest using a plain link, or using which I think works well. Another comment: In the default translation we don't use the term "Issues" in this context. "Checkouts" is correct. https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:00:24 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:00:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:00:27 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58183|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 58186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58186&action=edit [SIGNED-OFF] Bug 17486: Remove Mozilla Persona Persona never really took off, and although many browsers currently support it, very few services actually implement it. This has lead to it's founders, Mozilla, to end the project. In their own words: ============================================================================= Persona is no longer actively developed by Mozilla. Mozilla has committed to operational and security support of the persona.org services until November 30th, 2016. On November 30th, 2016, Mozilla will shut down the persona.org services. Persona.org and related domains will be taken offline. If you run a website that relies on Persona, you need to implement an alternative login solution for your users before this date. For more information, see this guide to migrating your site away from Persona: https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers ============================================================================= Given the above, and that the Persona authentication methods as a whole are no longer being actively maintained by anyone anywhere to ensure ongoing security, we should deprecate the option from koha. Test plan: Apply this patch and make sure you do not find any references of Persona Have a look at patches from bug 9587 and confirm that everything has been reverted Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:01:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:01:22 +0000 Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:01:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:01:25 +0000 Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58102|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 58187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58187&action=edit [SIGNED-OFF] Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Have amended patch to not include OPAC changes from previous patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:26:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:26:24 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:26:27 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58182|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 58188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58188&action=edit [SIGNED-OFF] Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:38:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:38:57 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57944|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 58189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58189&action=edit [SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button on patroncard images To test: 1) Go to Tools -> Patron Card Creator -> Manage images 2) Upload an image if you haven't already 3) Click Delete selected without selecting any images 4) Notice broken behaviour as described in Description 5) Apply patch, refresh page 6) Click Delete selected without selecting any images 7) Notice alert. Click OK 8) Select one image or more, click Delete selected 9) Notice confirm delete message. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:39:39 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 19:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 18:39:42 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57945|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 58190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58190&action=edit [SIGNED-OFF] Bug 15711: Follow up batch_id not used Changed batch_id to image_id in the template, as the multiparam would catch the array case. TEST PLAN --------- 1) attempt to delete a selected item, but get a warning. 2) apply this follow up 3) attempt to delete a selected item, it deletes. 4) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 20:51:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 19:51:01 +0000 Subject: [Koha-bugs] [Bug 17774] Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |major Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 20:51:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 19:51:49 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:16:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:16:44 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |major --- Comment #2 from Katrin Fischer --- Yes, I am pretty sure too that this worked in 3.18 - as a regression I am upping severity a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:19:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:19:02 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Katrin Fischer --- This renders the whole configuration options useless, upping severity a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:19:56 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Staff Client |I18N/L10N Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:23:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:23:02 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Should this be enh or more a bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:38:56 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #5 from Josef Moravec --- Created attachment 58191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58191&action=edit Bug 17466: Followup, change button to link and fix terminology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:40:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:40:26 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Josef Moravec --- (In reply to Owen Leonard from comment #4) > I agree that a button isn't appropriate for what is acting as a link. I > would suggest using a plain link, or using > which I think works well. > > Another comment: In the default translation we don't use the term "Issues" > in this context. "Checkouts" is correct. > > https://wiki.koha-community.org/wiki/Terminology Thanks Owen, I fixed it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:51:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:51:54 +0000 Subject: [Koha-bugs] [Bug 17294] reserves_stats.pl is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:51:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:51:55 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Bug 7172 depends on bug 17294, which changed state. Bug 17294 Summary: reserves_stats.pl is not plack safe https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 21:51:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 20:51:55 +0000 Subject: [Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253 Bug 17253 depends on bug 17294, which changed state. Bug 17294 Summary: reserves_stats.pl is not plack safe https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:27:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:27:43 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:27:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:27:46 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58036|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 58192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58192&action=edit [SIGNED-OFF] Bug 17744: Remove the oai_dc:dcCollection wrapper in OAI responses Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:38:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:38:45 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:38:48 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58151|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 58193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58193&action=edit [SIGNED-OFF] Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:49:22 +0000 Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular cron jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 14 23:49:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Dec 2016 22:49:25 +0000 Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular cron jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56997|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 58194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58194&action=edit [SIGNED-OFF] Bug 17520: Can we add serialsUpdate.pl to the list of regular cron jobs? This patch adds the job to debian package file and the examples file in misc. Test plan: Add these lines to your cron file. Check the results. (If an issue you expect passes the grace period defined in the subscription, its status should go from Expected to Late.) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 01:09:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 00:09:37 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56846|0 |1 is obsolete| | --- Comment #2 from David Kuhn --- Created attachment 58195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58195&action=edit Bug 17309 - Renewing and HomeOrHoldingBranch syspref The AddRenewal subroutine currently uses the circulation rules for the branch stored in the Issues table (which is the holding branch) when calculating the new due date. This patch replaces using the branch from the Issues table with the branch specified by the HomeOrHoldingBranch syspref. To test: 1. Set up 2 branches, Branch1 and Branch2 2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a 21 day renewal period. 3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a 14 day renewal period. 4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will receive the correct 21 day loan period. 5. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 14 day due date, rather than 21 days. 6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will receive the correct 14 day loan period. 7. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 21 day due date, rather than 14 days. 8. Apply the patch and repeat steps 4-7. The correct due date should be given when the item is renewed, regardless of where it is checked out or renewed. This update removes reassignment of $branch variable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:52:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:52:05 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:52:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:52:09 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58193|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 58196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58196&action=edit Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:52:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:52:13 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #14 from Marcel de Rooy --- Created attachment 58197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58197&action=edit Bug 17666: [QA Follow-up] Mark File::Slurp as required Not optional since we are 'using' it in updatedatabase.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:52:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:52:33 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:53:42 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #15 from Marcel de Rooy --- Note: Has been packaged for Jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 08:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 07:57:20 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:00:26 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:00:56 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:01:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:01:04 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:06:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:06:39 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #33 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #29) > The version of the patch on bug 9743 and the first version on this bug > report did not introduced a new way to modify behaviors using plugings. If > they get pushed, we will have a precedent and new patches/plugins will use > it. That will add more stuffs to modify if we decide the switch our plugin > system. Reopened and back to SO qeueue. Still applies. There has been no movement on the plugin system since the above was written. And note that one of the two patches was written Dec 2014. The argument that this "introduces a new way to use plugins" is imo not really valid. No dangerous precedents here. It would be quite trivial to adjust this routine to a new plugin system as should be done for others too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:36:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:36:26 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:36:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:36:53 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:37:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:37:58 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 --- Comment #3 from Martin Renvoize --- Code looks good to me, but I've added Chris to the cc list in the hopes he might come along and take a quick look too. As the original implementor of Persona he might spot something we've missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 09:41:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 08:41:31 +0000 Subject: [Koha-bugs] [Bug 17778] New: Make "Earliest Registered Date" in OAI-PMH dynamic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Bug ID: 17778 Summary: Make "Earliest Registered Date" in OAI-PMH dynamic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org The value of earliestDatestamp is hardcoded on line 37 of Koha/OAI/Server/Identify.pm: earliestDatestamp => '0001-01-01', http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/OAI/Server/Identify.pm;h=3ab21889568ae41a216f717eddd6f15cc2c48b44;hb=HEAD#l37 It should not be too hard to replace this with the output of something like this: SELECT DATE(MIN(timestamp)) FROM biblio; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 10:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 09:31:42 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |mirko at abunchofthings.net --- Comment #2 from Mirko Tietgen --- If it's broken it's a bug. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 10:53:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 09:53:05 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #5 from Jonathan Druart --- (answered by email) > Module::Load::Conditional installed version is 0.54 > Freerk Jongsma Wheezy is no longer supported and it appears you are using it (or another linux distro?). Jessie's version is 0.62 and the min version may be wrong. Freerk, which version of Koha are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:03:21 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #6 from Freerk Jongsma --- (In reply to Marcel de Rooy from comment #2) > Hi Freerk, > You need to provide more details before anyone can be of help. > Which version of Koha? On which Linux version? With Plack, memcached, etc? > The perl 5.18 tells me that you are probably not on Jessie. > > Marcel Server information Kona version: l61100.000 OS version: Llnux kbhw.nl 4.4.053-generic #74-10.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x86_64 Perl Interpreter: /usr/bin/perl Peri version: 5.018002 Perl @INC:/usr/share/koha/lib /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl MySQL version: mysql Ver 14.14 Distrib 5.5.53, for debian-linux-gnu (x86_64) using readline 6.3 Apache version: Server version: Apache/2.4.7 (Ubuntu) Memcached: Servers: undefined | Namespace: koha | Status: unknown | Config read from: Nowhere Note that the right place to define the memcached config is in your $KOHA_CONF file. Currently you do not have a valid memcached configuration defined. | Effective caching method: Cache::Memory Zebra version: Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 419ad759807269fdfa379799a051ed3a551c6541 Using ICU This is it i think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:07:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:07:58 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #7 from Freerk Jongsma --- What i changed was the port configuration: opac on port 88 and koha on 8080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:15:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:15:23 +0000 Subject: [Koha-bugs] [Bug 17779] New: Software error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17779 Bug ID: 17779 Summary: Software error Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: eddiekipkosgey at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 58198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58198&action=edit a screenshot of the error thrown Hello, I'm new to Koha ILS but just as I was about to finalize the installation on Linux mint 18, I hit a snag at "Web installer > Step 3" where I have made all mandatory selections and just when I click 'Import' to begin the process, it throws the error below. Please help me sort it as soon as possible because I need it up and running. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:52:32 +0000 Subject: [Koha-bugs] [Bug 17780] New: When choose an author in authority results new window shows a blank screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Bug ID: 17780 Summary: When choose an author in authority results new window shows a blank screen Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: gveranis at seab.gr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 58199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58199&action=edit authority results choose When a librarian open the authority window to search , find one or more results and try to choose a result then a new window is open and show a blank screen and stop. If we return to our cataloguing form then the authority has passed but the blank screen is remain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:52:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:52:53 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #8 from Freerk Jongsma --- Plack 1.0030 is installed In Library.conf there are two lines ech for OPAc and Intranet SetEnv MEMCACHED_SERVERS ?? SetEnv MEMCACHED_NAMESPACE?? In the meantime I installed php5-memcached and memcached It did not appear in Server Information (restarted apache2) The Perl modules: 3 not installed Test::DBIx::Class (0.42) Readonly::XS (0.01) HTTPD::Bench::ApacheBench (0.73) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:53:55 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |gveranis at seab.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 11:57:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 10:57:30 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 12:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 11:11:49 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 12:11:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 11:11:51 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 --- Comment #1 from Kyle M Hall --- Created attachment 58200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58200&action=edit Bug 17692 - Can't add library EAN under Plack When adding a library ean under plack, there is an "internal server error" when running Plack. Tested with Koha 16.11 release. Test Plan: 1) Apply this patch 2) Enable Plack 3) Add, Edit and Delete a Library EAN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 12:19:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 11:19:46 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 12:56:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 11:56:54 +0000 Subject: [Koha-bugs] [Bug 17781] New: Improper branchcode set during renewal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Bug ID: 17781 Summary: Improper branchcode set during renewal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For no discernable reason, when AddIssue calls AddRenewal, it passes the branchcode generated from _GetCircControlBranch. Assume _GetCircControlBranch is set to return items.homebranch. So: 1) If an item owned by LibraryA is checked out at LibraryB, the statistic line branchcode will be LibraryB 2) If an item is renewed via the ajax datatables renewal function, the statistic line branchcode will be LibraryB 3) If an item is renewed via scanning the item into the checkout again, the statistic line branchcode will be *LibraryA* This is clearly improper behavior. The renewal is taking place at LibraryB, so the branchcode passed to AddRenewal should be LibraryB, the logged in library. This also jives with the documentation for the subroutine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 12:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 11:57:00 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 13:03:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 12:03:46 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 --- Comment #1 from Kyle M Hall --- Created attachment 58201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58201&action=edit Bug 17781 - Improper branchcode set during renewal For no discernable reason, when AddIssue calls AddRenewal, it passes the branchcode generated from _GetCircControlBranch. Assume _GetCircControlBranch is set to return items.homebranch. So: 1) If an item owned by LibraryA is checked out at LibraryB, the statistic line branchcode will be LibraryB 2) If an item is renewed via the ajax datatables renewal function, the statistic line branchcode will be LibraryB the 3) If an item is renewed via scanning the item into the checkout again, statistic line branchcode will be *LibraryA* This is clearly improper behavior. The renewal is taking place at LibraryB, so the branchcode passed to AddRenewal should be LibraryB, the logged in library. This also jives with the documentation for the subroutine. Test Plan: 1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary ) 2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch ) 3) Create item with homebranch of LibraryA and holdingbranch of LibraryB 4) Set the logged in library to LibraryB 4) Check the item out to a patron at LibraryB 5) Note the statistics line has a branchcode of LibraryB 6) Check the item out again to trigger a renewal, renew the item 7) Note the statistic line has a branchcode of LibraryA! 8) Apply this patch 9) Repeat step 6 10) Note the statistics line has a branchcode of LibraryB! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 13:03:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 12:03:43 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:02:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:02:54 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58147|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 58202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58202&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:17:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:17:50 +0000 Subject: [Koha-bugs] [Bug 17782] New: Patron updated_on field should be set to current timestamp when borrower is deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Bug ID: 17782 Summary: Patron updated_on field should be set to current timestamp when borrower is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the timestamp is not udpated when a patron is deleted. This is because we insert the db value of updated_on from the patron when we move the borrower. Clearing the value beforehand should resolve this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:20:17 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #1 from Nick Clemens --- Created attachment 58203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58203&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:34:28 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:34:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:34:30 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58192|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 58204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58204&action=edit Bug 17744: Remove the oai_dc:dcCollection wrapper in OAI responses Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 15:34:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 14:34:52 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:04:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:04:49 +0000 Subject: [Koha-bugs] [Bug 17783] New: Optimize Koha::IssuingRules->get_effective_issuing_rule Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Bug ID: 17783 Summary: Optimize Koha::IssuingRules->get_effective_issuing_rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Koha::IssuingRules->get_effective_issuing_rule() seems to be making 8 different queries in worst case scenario. The behavior is inherited from the old C4::Circulation::GetIssuingRule(). Instead, a faster solution is to get the effective issuing rule with one single query by sorting and limiting the result appropriately. This will make a significant improvement in performance in situations where issuing rules need to be requested multiple times. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:33:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:33:41 +0000 Subject: [Koha-bugs] [Bug 17784] New: Ability to see funds with an amount of 0.00 when doing a new order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Bug ID: 17784 Summary: Ability to see funds with an amount of 0.00 when doing a new order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org In the acquisition module, funds with an amount of 0.00$ don?t appear in the dropdown list when doing an new order (in accounting details). To do that, we must put 0.01$ to be able to see the information. Here is the link : cgi-bin/koha/acqui/neworderempty.pl Can we add an option to put funds active or inactive to manage them correctly (and see them in the dropdown list) ? This is usefull to some librairies which must receipt and treat documents for another service through a bigger organization. This other service is in charge of the payment. The document must be present in the list to help librairians to make the follow-up with it. Thanks, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:35:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:35:45 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48125|0 |1 is obsolete| | --- Comment #23 from Charles Farmer --- Created attachment 58205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58205&action=edit Bug 8609 - Add an URL validation plugin for authority and biblio frameworks This patch adds a new validation plugin to validate that a field/subfield contains a valid url. This plugin that can be used in biblio and authority frameworks. Testing: I) Before applying: 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate no message; II) After Applying: i) field/subfield plugin attach 0) In Koha adminstration, click << MARC bibliographic framework >>; 1) In Default framework, click << MARC structure >>; 2) Search field 856 and click << Subfields >>; 3) Click << u >>; 4) In Other options -> Plugin, choose url.pl ii) Insert a text in the 856->u input field 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate message: << The field 856$u must contain a valid URL! ex : http://www.google.com >> ---- This patch is a simple rebase to ease future developments. Comments #20, #21 and #22 will be addressed in a another commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:36:54 +0000 Subject: [Koha-bugs] [Bug 16435] add possibility to set the contents of a virtual list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16435 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Marjorie Barry-Vila --- *** This bug has been marked as a duplicate of bug 15485 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:36:54 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca --- Comment #19 from Marjorie Barry-Vila --- *** Bug 16435 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:59:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:59:16 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 16:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 15:59:39 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46179|0 |1 is obsolete| | Attachment #46180|0 |1 is obsolete| | --- Comment #8 from Charles Farmer --- Created attachment 58206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58206&action=edit Bug 13572 - Add --actives parameter to force_borrower_messaging_defaults script 1) Apply the patch 2) Create a new patron with random values, except for it expiration date, make it expired (Patrons > New Patron > Student) 3) Enable the system preference called ?EnhancedMessagingPreferences? 4) In ?Administration" > "Patron categories" > Student, modify the "days in advance", then click "Save" 5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit --actives" 6) Validate that the student created in step 2 hasn't changed (Patrons > search) 7) Validate that any other student that isn't expired has changed. --- This patch is a squashed version of the two previous ones, rebased on the current master, plus the changes asked in comment #7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:16:25 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- --- Comment #1 from Owen Leonard --- It is expected that a new blank window pops up, but it is supposed to then close itself. I would expect that a JavaScript error is causing the window not to close. This works for me in master and 16.05.x, so I wonder if you have some custom JavaScript in intranetuserjs which might be causing a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:27:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:27:29 +0000 Subject: [Koha-bugs] [Bug 7374] can't upload icon for auth values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:27:40 +0000 Subject: [Koha-bugs] [Bug 7374] can't upload icon for auth values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:48:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:48:41 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:48:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:48:48 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:51:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:51:01 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:51:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:51:05 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #3 from Andrew Isherwood --- Created attachment 58207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58207&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:52:29 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 17:52:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 16:52:34 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:04:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:04:44 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #4 from Alex Sassmannshausen --- Created attachment 58208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58208&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:04:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:04:50 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #5 from Alex Sassmannshausen --- Created attachment 58209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58209&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:04:57 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #6 from Alex Sassmannshausen --- Created attachment 58210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58210&action=edit Bug 11897: Add Koha::Objects for Stockrotation module. * Koha/Stockrotationitem.pm: New file. * Koha/Stockrotationitems.pm: New file. * Koha/Stockrotationrota.pm: New file. * Koha/Stockrotationrotas.pm: New file. * Koha/Stockrotationstage.pm: New file. * Koha/Stockrotationstages.pm: New file. * t/db_dependent/Stockrotationitems.t: New file. * t/db_dependent/Stockrotationrotas.t: New file. * t/db_dependent/Stockrotationstages.t: New file. * Koha/Item.pm (stockrotationitem, add_to_rota, biblio): New procedures. * Koha/Library.pm (stockrotationstages): New procedure. * t/db_dependent/Items.t: Add tests. * t/db_dependent/Koha/Libraries.t: Add tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:01 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #7 from Alex Sassmannshausen --- Created attachment 58211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58211&action=edit Bug 11897: Add stockrotation cron script. * misc/cronjobs/stockrotation.pl: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:06 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #8 from Alex Sassmannshausen --- Created attachment 58212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58212&action=edit Bug 11897: Add Utils library for Stockrotation module * Koha/Util/Stockrotation.pm: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:10 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #9 from Alex Sassmannshausen --- Created attachment 58213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58213&action=edit Bug 11897: REST API - add path defs, controller & tests * Koha/REST/V1/Stage.pm: New file * api/v1/swagger/paths.json: Add route for stage manipulation * api/v1/swagger/paths/rotas.json: New file * t/db_dependent/api/v1/stockrotationstage.t: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:15 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #10 from Alex Sassmannshausen --- Created attachment 58214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58214&action=edit Bug 11897: Add JS to provide rota stage manipulation * koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:19 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #11 from Alex Sassmannshausen --- Created attachment 58215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58215&action=edit Bug 11897: Add Stockrotation CSS rules * koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:23 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #12 from Alex Sassmannshausen --- Created attachment 58216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58216&action=edit Bug 11897: Add Stock Rotation permissions to list * koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:28 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #13 from Alex Sassmannshausen --- Created attachment 58217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58217&action=edit Bug 11897: Interface for rotas from Tools menu * tools/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:33 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #14 from Alex Sassmannshausen --- Created attachment 58218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58218&action=edit Bug 11897: Interface for rota items from biblio * catalogue/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:05:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:05:38 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #15 from Alex Sassmannshausen --- Created attachment 58219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58219&action=edit Bug 11897: Add menu options for Stock Rotation * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:06:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:06:20 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |charles.farmer at inlibro.com --- Comment #61 from Charles Farmer --- For easier testing, I'm resubmitting the whole shebang rebased on the current master. Patches to follow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:10:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:10:31 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49944|0 |1 is obsolete| | Attachment #49945|0 |1 is obsolete| | Attachment #49946|0 |1 is obsolete| | Attachment #49947|0 |1 is obsolete| | Attachment #50425|0 |1 is obsolete| | Attachment #50440|0 |1 is obsolete| | Attachment #53446|0 |1 is obsolete| | --- Comment #62 from Charles Farmer --- Created attachment 58220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58220&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:10:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:10:42 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #63 from Charles Farmer --- Created attachment 58221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58221&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:10:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:10:48 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #64 from Charles Farmer --- Created attachment 58222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58222&action=edit Bug 11317 - Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Test preparation : * Add the "accessdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:10:55 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #65 from Charles Farmer --- Created attachment 58223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58223&action=edit Bug 11317 - Allows for multiple directories to be accessible It is now possible to add as many SOMEDIR as needed to the config file. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:11:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:11:00 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #66 from Charles Farmer --- Created attachment 58224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58224&action=edit Bug 11317 - Move file access under Tools and add specific permission Moves the .pl and .tt under tools/ instead of reports/ and adds tools/access_files permission. Testing -1) Having done requirements of previous patches, like adding 'accessdir' to koha-conf... 0) apply patch, update database to add permission option. 1) Login as NON-superadmin. Go under tools, see no Report/Log under the third column 2) Go to add tools/access_file permission to user 3) See new entry under tools third column. 4) validate link is ok. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:11:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:11:06 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #67 from Charles Farmer --- Created attachment 58225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58225&action=edit Bug 11317 - Allow sorting on date column in file access tool. For some reason, the table was blocking sorting based on timestamp, even though most users would probably want that since the feature is used primarily to access generated (daily) reports and finding the last ones is very important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:11:12 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #68 from Charles Farmer --- Created attachment 58226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58226&action=edit Bug 11317 - Remove datatables-strings.inc from .tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:33:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:33:06 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49377|0 |1 is obsolete| | --- Comment #14 from Bouzid --- Created attachment 58227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58227&action=edit Bug14784 - Fix checkin message for debarred patrons Hi All, According to my tests, the bug exist always Before apply patch: Scenario 1: 1. Choose one borrower who have not a fines 2. Checkout one document for this borrower(Example : choose return date 10 days after) 3. Add restriction for this borrower (Example : 2 days after checkin). 4. When Checkin in "cgi-bin/koha/circ/returns.pl" this document, you see a message in red : Reminder: Patron was earlier restricted until <......>. Scenario 2: 1. Choose one borrower who have a fines 2. Checkout one document for this borrower 3. Add restriction for this borrower 4. When Checkin in "cgi-bin/koha/circ/returns.pl" this document, you haven't the message: Reminder: Patron was earlier restricted until <......> , just a message of fines. when apply patch, you have the message in all situations when borrower is debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:34:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:34:08 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:34:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:34:35 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:35:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:35:06 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:36:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:36:15 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|remi.mayrand-provencher at inL |bouzid.fergani at inlibro.com |ibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:43:40 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #1 from Lari Taskula --- Created attachment 58228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58228&action=edit Bug 17783: Test to confirm correct effective issuing rule selection This patch adds a test to cover the validity of effective issuing rule selection in correct order. To test: 1. Run t/db_dependent/Koha/IssuingRules.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:43:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:43:53 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #2 from Lari Taskula --- Created attachment 58229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58229&action=edit Bug 17783: Test to print performance of get_effective_issuing_rule This test prints the amount of issuing rule matches per second for 1. worst case, when non-existent branchcode, categorycode and itemtype is being searched (currently 8 queries) 2. mid case (rule found on 4th query) 3. 2nd best case (rule found on 2nd query) 4. best case, when an issuing rule is defined for exactly those branchcode, categorycode and itemtype (currently 1 query) To test: 1. Run t/db_dependent/Koha/IssuingRules.t 2. Write down the per-second amount to compare with next patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:44:06 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #3 from Lari Taskula --- Created attachment 58230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58230&action=edit Bug 17783: Add Koha::Objects->single Returns one and only one object that is part of this set. Returns undef if there are no objects found. ->single is faster than ->search->next This is optimal as it will grab the first returned result without instantiating a cursor. It is useful for this Bug as we only want to select the top row of found issuing rules. To test: 1. Run t/db_dependent/Koha/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:44:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:44:24 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #4 from Lari Taskula --- Created attachment 58231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58231&action=edit Bug 17783: Optimize Koha::IssuingRules->get_effective_issuing_rule This patch modifies method get_effective_issuing_rule in Koha::IssuingRules aiming to optimize the search for matching issuing rule. Before this patch, in worst case scenario, we have had to make a SELECT query eight times. This will have a negative impact on performance where-ever we need to find matching issuing rule multiple times, if the search is not directly matching an issuing rule on the first query. This patch makes get_effective_issuing_rule have a stable performance on both best and worst case, whereas the old method was really fast on the best case and really slow on the worst case. However, this patch slightly lowers the performance for best case, where matching issuing rule is found instantly before (branchcode, categorycode and itemtype all are specifically defined in issuing rules). For all other cases this patch offers a performance improvement. To test: 1. Run t/db_dependent/Koha/IssuingRules.t and compare the results with previous tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:44:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:44:22 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:50:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:50:17 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |lari.taskula at jns.fi Depends on| |17599 --- Comment #5 from Lari Taskula --- Definitions: We want to find an issuing rule with parameters branchcode 'B', categorycode 'C' and itemtype 'I'. For current implementation, - Best case = there is an issuing rule defined with 'B', 'C' and 'I'. - Second best case = there is an issuing rule defined with 'B', 'C' and '*'. - Mid case = there is an issuing rule defined with 'B', '*', '*'. - Worst case = matching issuing rule will be '*', '*', '*'. (These are following the order defined in circulation & fines rules page) My results: OLD IMPLEMENTATION: ok 1 - In worst case, get_effective_issuing_rule finds matching rule 74.29 times per second. ok 2 - In mid case, get_effective_issuing_rule finds matching rule 144.09 times per second. ok 3 - In second best case, get_effective_issuing_rule finds matching rule 289.02 times per second. ok 4 - In best case, get_effective_issuing_rule finds matching rule 561.80 times per second. NEW IMPLEMENTATION (= after applying last patch): ok 1 - In worst case, get_effective_issuing_rule finds matching rule 434.78 times per second. ok 2 - In mid case, get_effective_issuing_rule finds matching rule 427.35 times per second. ok 3 - In second best case, get_effective_issuing_rule finds matching rule 431.03 times per second. ok 4 - In best case, get_effective_issuing_rule finds matching rule 423.73 times per second. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599 [Bug 17599] Move C4::Circulation::GetIssuingRule to Koha::IssuingRules->get_effective_issuing_rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 18:50:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 17:50:17 +0000 Subject: [Koha-bugs] [Bug 17599] Move C4::Circulation::GetIssuingRule to Koha::IssuingRules-> get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 19:21:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 18:21:09 +0000 Subject: [Koha-bugs] [Bug 16373] merge.pl reports success but files are not merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 21:41:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 20:41:09 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 22:52:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 21:52:05 +0000 Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or closing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 22:52:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 21:52:18 +0000 Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or closing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30592|0 |1 is obsolete| | --- Comment #16 from Charles Farmer --- Created attachment 58232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58232&action=edit Bug 12732 - Sort late orders by basket creation or closing date This fix permits to sort late orders by basket creation or closing date Modified: installer/data/mysql/sysprefs.sql -AcqLateOrderUseCreationDate preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -AcqLateOrderUseCreationDate preference added koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt -Change "Order date" column acqui/lateorders.pl - C4/Acquisition.pm -Change sql Testing: I Apply the patch II Run updatedatabase.pl 0) Create 2 orders each one with different baskets; 1) Change the first basket date (table aqbasket, column creationdate and closedate) to 2014-07-13; 2) Change the second basket creationdate to 2014-07-12 and closedate to 2014-07-14; 3) Set AcqLateOrderUseCreationDate to Don't use the creation date of the basket to sort late order; 4) Validate sort by "close date" (second basket came first) and "Order close date" column; 5) Set AcqLateOrderUseCreationDate to Do use the creation date of the basket to sort late order; 6) Validate sort by "creation date" (first basket came first) and "Order creation date" column; sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 22:52:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 21:52:24 +0000 Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or closing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32303|0 |1 is obsolete| | --- Comment #17 from Charles Farmer --- Created attachment 58233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58233&action=edit Bug 12732 - Sort late orders by basket creation or closing date - This patch fixs the numbers 0, 3 and 4 in comment 4 Add: installer/data/mysql/updatedatabase.pl Modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref - AcqLateOrderUseCreationDate preference modified. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt - translation problem fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 23:31:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 22:31:10 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 23:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 22:31:24 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25404|0 |1 is obsolete| | Attachment #30940|0 |1 is obsolete| | Attachment #30941|0 |1 is obsolete| | --- Comment #9 from Charles Farmer --- Created attachment 58234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58234&action=edit Bug 11315 : Add the overwriteSubfieldsOnMerge preference. If it is activated, all of the biblio's subfields will be overwritten when doing an authority merge. This means that subfields that exist in the biblio, but not in the authority will be deleted in the biblio when doing the merge. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Test plan : Preparation : * Set dontmerge system preference to "Do automatically update attached biblios..." * Create a test authority. For example, lets create a PERSON authority with this value : 100$a : "Bruce Wayne" * Rebuild the Zebra authority index. (rebuild_zebra.pl -a) * Create a new biblio record and link it to the newly created authority by clicking the icon right of the 600$a field and searching for the "Bruce Wayne" authority. * Add the "2014" value in the 600$d field of the biblio record before saving the biblio record. This is the value we will use to check the behavior of the new system preference. * Rebuild the Zebra biblio index. (rebuild_zebra.pl -b) Test 1 : * Set the "overwriteSubfieldsOnMerge" system preference to "Don't overwrite". * Edit the "Bruce Wayne" authority, change 100$a value to "Batman". * Save the authority and go check the test biblio record. The 600$a field should now be "Batman", and the 600$d should still be "2014". Test 2 : * Set the "overwriteSubfieldsOnMerge" system preference to "Overwrite". * Edit the "Batman" authority, change the 100$a value back to "Bruce Wayne". * Save the authority and go check the test biblio record. The 600$a field should now be "Bruce Wayne", and the 600$d should now be empty. The additional subfield was overwritten this time. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 23:31:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 22:31:32 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #10 from Charles Farmer --- Created attachment 58235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58235&action=edit Bug 11315 - Added unit tests for the modified sub in AuthoritiesMarc.pm new file: t/AuthoritiesMarc.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 15 23:33:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Dec 2016 22:33:30 +0000 Subject: [Koha-bugs] [Bug 17779] Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Which OS and database system are you installing on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 08:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 07:13:53 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #64 from Marcel de Rooy --- QA: Resuming today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:06:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:06:30 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58200|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 58236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58236&action=edit Bug 17692 - Can't add library EAN under Plack When adding a library ean under plack, there is an "internal server error" when running Plack. Tested with Koha 16.11 release. Test Plan: 1) Apply this patch 2) Enable Plack 3) Add, Edit and Delete a Library EAN Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:06:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:06:45 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:25:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:25:12 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #113 from Marc V?ron --- Wanted to test, got merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:32:59 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #15 from Marc V?ron --- Sorry, could not apply: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:37:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:37:18 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:37:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:37:18 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 09:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 08:48:25 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #16 from Alex Sassmannshausen --- The patch set should apply cleanly on sandboxes and on devboxes without additional setup needing to be configured. - On sandboxes the stockrotation cron script cannot be tested - On devboxes the cron script can be tested and should be run first with the -h flag for documentation Please let us know if you have any questions about this module or it's intended use cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:12:38 +0000 Subject: [Koha-bugs] [Bug 17014] Remove more event attributes from patron templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:17:49 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57878|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 58237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58237&action=edit Bug 17208: Checking if classification source or filing rule already exists before adding To test: 1) Go to Admin -> Classification sources 2) Attempt to reproduce bug before applying patch. Notice the message saying the add was successful, but was not added to the table 3) Apply patch and refresh page (restart plack if necessary) 4) Add new classification source with same code as existing one. Notice you are now told that the add failed. 5) Confirm adding new classification source with unique code works 6) Add new classification filing rule with same code as existing one. Notice you are told that add failed. 7) Confirm adding new classification filing rule with unique code works Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:18:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:18:38 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:22:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:22:10 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57875|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 58238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58238&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:22:23 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:31:34 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56958|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 58239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58239&action=edit Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:31:49 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:36:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:36:36 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16239 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:36:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:36:36 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17398 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:37:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:37:26 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57409|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 58240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58240&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:37:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:37:41 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:40:12 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:49:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:49:16 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 10:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 09:52:07 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This is a batch process to release notes| |automate rotation with a | |staff client page under | |tools to manage | |rotas/schedules. | |Once a | |rota is configured, and | |your staff user has the | |right permissions to | |allocate items, then an | |additional tab will appear | |on biblio records allowing | |the management of of which | |rota, if any, individual | |items belong to. | |This is | |different to the rotating | |collections work as it is | |designed around rotating | |individual items upon an | |automated schedule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:09:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:09:58 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57876|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 58241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58241&action=edit Bug 15415: Warn when creating a new print profile As per Jonathan's comment in Comment 3, I've put that line of code in an if statement that will only call the get_attr method if we are editing an existing profile (therefore the profile id will exist). To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:10:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:10:14 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:41:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:41:35 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:41:38 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 --- Comment #3 from Jonathan Druart --- Created attachment 58242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58242&action=edit Bug 17743: Item search - Fix indexes build on MARC Searching items by custom search fields does not work because these fields are not correctly processed in JS. In case of custom search field, the parent of the option is not the select but the optgroup element. Test plan: Create a custom search field on 245$c for instance On the items search form, select this field and launch a search => Without this patch, the results will not be filtered and you will get all your items => With this patch applied, the results should be correctly filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:43:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:43:11 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:43:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:43:14 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 --- Comment #3 from Jonathan Druart --- Created attachment 58243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58243&action=edit Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:43:18 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 --- Comment #4 from Jonathan Druart --- Created attachment 58244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58244&action=edit Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:43:25 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 11:43:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 10:43:34 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:02:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:02:54 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58062|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy --- Created attachment 58245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58245&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in timestamp order (faster than biblionumber order with the new index). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:03 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58064|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy --- Created attachment 58247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58247&action=edit Bug 15108: Fix OAI Server tests Tests introduced by bug 17493 must be amended to accomodate the new resumption tokens (with time) returned by OAI Server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:02:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:02:58 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #66 from Marcel de Rooy --- Created attachment 58246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58246&action=edit Bug 15108: Remove Koha::AtomicUpdater dependency Signed-off-by: Frederic Demians EDIT: Extension should be .perl [Otherwise it will not be executed at all.] This file is just temporary, needs no license. Followed the new skeleton file here. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:08 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58072|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy --- Created attachment 58248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58248&action=edit Bug 15108: [QA Follow-up] Remove truncate Truncate operations cause an implicit commit, and so cannot be rolled back. So we need to replace it by a DELETE and adjust the code so that it does not assume numbering biblionumbers from 1, etc. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:12 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58080|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy --- Created attachment 58249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58249&action=edit Bug 15108: [QA Follow-up] Remove the sleep Ordering by timestamp, biblionumber in ListBase.pm c/would be a performance killer. In order to speed up the test, we manipulate the timestamp. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:17 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #70 from Marcel de Rooy --- Created attachment 58250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58250&action=edit Bug 15108: [QA Follow-up] Changes from removing collection wrapper See bug 17744. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:21 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #71 from Marcel de Rooy --- Created attachment 58251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58251&action=edit Bug 15108: [QA Follow-up] Serious doubts on ResumptionToken::deleted ListBase: Remove a comma construction by two statements. ResumptionToken: Tidy sub deleted, added FIXME. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:03:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:03:52 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:05:26 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:08:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:08:35 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Marcel de Rooy --- The refactoring to ListBase looks good. But although I spent hours on this patch set already, I am not yet convinced that we are ready to go. Please respond to my doubts on the sub deleted (see commit message). Please check this too: Running aoi with marcxml/50/1970-01-01T00:00:00Z/2016-12-16T23:59:59Z//1 starts with the first record (not expected !) Running marcxml/50/1970-01-01T00:00:00Z/2016-12-16T23:59:59Z//0 starts with record 51 (as expected) If you propose further changes, please add a follow-up in order to keep sight of the changes. Failed QA for now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:09:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:09:56 +0000 Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Olivier! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:11:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:11:23 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:11:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:11:43 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #73 from Marcel de Rooy --- One further note (from QA tools): FAIL Koha/OAI/Server/ListIdentifiers.pm FAIL Koha/OAI/Server/ListRecords.pm FAIL valid Can't locate package HTTP::OAI::PartialList for @HTTP::OAI::ListIdentifiers::ISA This seems to be a problem in HTTP::OAI::ListIdentifiers ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:13:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:13:27 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #74 from Fr?d?ric Demians --- Thanks for your work Marcel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:14:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:14:44 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:23:49 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:24:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:24:33 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:26:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:26:12 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:27:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:27:13 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:28:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:28:13 +0000 Subject: [Koha-bugs] [Bug 17681] Exiisting typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exiisting typos might thow |Exiisting typos might thow |some feees when recieved |some fees when recieved CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:28:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:28:21 +0000 Subject: [Koha-bugs] [Bug 17681] Existing typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exiisting typos might thow |Existing typos might thow |some fees when recieved |some fees when recieved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:29:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:29:36 +0000 Subject: [Koha-bugs] [Bug 17681] Existing typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:31:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:31:35 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:33:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:33:46 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #26 from Kyle M Hall --- Pushed to master for 17.05, thanks Julian, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:37:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:37:30 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:39:07 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:40:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:40:01 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:41:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:41:17 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:52:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:52:08 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:53:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:53:35 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:54:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:54:27 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 12:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 11:55:22 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 13:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 12:01:53 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 13:02:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 12:02:18 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 13:46:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 12:46:31 +0000 Subject: [Koha-bugs] [Bug 17785] New: oai.pl returns wrong URLs under Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Bug ID: 17785 Summary: oai.pl returns wrong URLs under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org oai.pl uses CGI's self_url Under Plack this results in an URL like: /opac/oai.pl?verb=ListRecords&resumptionToken=marcxml/100/1970-01-01T00:00:00Z/2016-12-16T23:59:59Z/ (This is the URL for the More button.) Should we adjust the mounting point and ProxyPass statements? Mount like /cgi-bin/koha/opac ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 13:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 12:46:45 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 14:23:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 13:23:51 +0000 Subject: [Koha-bugs] [Bug 17779] Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17779 --- Comment #2 from Katrin Fischer --- >Hello Katrin, >Tho OS is Linux Mint 18 and the database system is MySQL. Which version of MysQL? 5.6+ does not work well with Koha, it's recommended to use MariaDB instead atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:26:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:26:58 +0000 Subject: [Koha-bugs] [Bug 17786] New: Date filter on circulation statistics not working correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17786 Bug ID: 17786 Summary: Date filter on circulation statistics not working correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The 'from' 'to' date filter on the circulation statistics wizard are exclusive, but should be inclusive. Example 1: Period: check, filter from first day of month to last day of month Patron category: check Example 2: Period: check Group by: month, select month: same as above Patron category: check These numbers can be different as the first and last day of the month are excluded from the first query. My guess is that we query with between date1 and date2 without using the date() function to ensure the results are correct for the timestamp/datetime field. Verified in 3.22.10 and 16.11.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:31:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:31:38 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57041|0 |1 is obsolete| | Attachment #57042|0 |1 is obsolete| | Attachment #57043|0 |1 is obsolete| | Attachment #57044|0 |1 is obsolete| | Attachment #57045|0 |1 is obsolete| | Attachment #57046|0 |1 is obsolete| | --- Comment #35 from Tom?s Cohen Arazi --- Created attachment 58252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58252&action=edit Bug 13757: Add the option to set patron attributes editable in the OPAC Note: this is a squashed version of the original patchset, because it was needed This patch adds an opac_editable property of borrower attribute types that can be set in the interface. I'm removing work on OPAC and will refactor it, keeping the author attribution. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:31:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:31:48 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #36 from Tom?s Cohen Arazi --- Created attachment 58253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58253&action=edit Bug 13757: DB update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:31:55 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #37 from Tom?s Cohen Arazi --- Created attachment 58254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58254&action=edit Bug 13757: OPAC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:32:08 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #38 from Tom?s Cohen Arazi --- Created attachment 58255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58255&action=edit Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:36:01 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 58256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58256&action=edit Bug 17767: Add borrower_modification.extended_attributes This patch changes the DB structure adding borrower_modifications.extended_attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:36:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:36:06 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 58257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58257&action=edit Bug 17767: DBIC update This patch can be skipped by the RM, it just updates the DBIC schema files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:36:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:36:12 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 58258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58258&action=edit Bug 17767: Make Koha::Patron::Modification handle extended attributes This patch makes Koha::Patron::Modification aware of the new extended_attributes column, which is expected to contain valid JSON data. The ->store method is modified so it validates the field value (i.e. the content is decoded using the JSON library) and raises a convenient exception in case of failure. This behaviour change is covered by the provided unit tests. To test: - Apply the patchset - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests make sense, and they pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:36:22 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 58259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58259&action=edit Bug 17767: Unit tests This patch introduces tests for the new behaviour, and also enhances the existing ones aiming to reach full coverage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:36:27 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 58260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58260&action=edit Bug 17767: (followup) Rename test file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:38:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:38:29 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:39:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:39:15 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #65 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:48:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:48:41 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:50:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:50:40 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:51:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:51:59 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 15:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 14:54:48 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 16:00:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 15:00:32 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 16:03:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 15:03:11 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 16:03:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 15:03:14 +0000 Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in the result set and there is no logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58188|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 58261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58261&action=edit Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 16:56:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 15:56:13 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #4 from Bouzid --- Created attachment 58262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58262&action=edit Bug 17674 - Fix problem tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 16:58:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 15:58:58 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #5 from Bouzid --- Created attachment 58263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58263&action=edit Bug - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 17:03:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 16:03:14 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58263|0 |1 is obsolete| | --- Comment #6 from Bouzid --- Created attachment 58264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58264&action=edit Bug 17674 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 17:12:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 16:12:34 +0000 Subject: [Koha-bugs] [Bug 17787] New: Suppressed items seems so still be included in number of search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Bug ID: 17787 Summary: Suppressed items seems so still be included in number of search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org We have a use case where like 99% of the collection is hidden and only a few selected items are displayed in the opac (by showing their covers up front on the main page). When going to the detail page and clicking the link for an author that has a long list of records (but only one visible in the opac) I might get indication of 63 hits in the search results and a the links to pages 1,2,3 etc for search results. Only problem is that there is actually only one result since the rest are suppressed. My guess is that the code calculating the number of hits and creating links to the pages of search results is not talking to the suppression system. I could not find any open bugs about this. Perhaps because our use of suppression is a bit of a edge case(?) I ended up "solving" the problem by removing the links on author etc. since we don't use search anyhow. I'll likely not research the issue further, but I felt I should at least report it and keep an eye out. All input is welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 17:52:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 16:52:51 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #72 from Koha Team Lyon 3 --- Hi, I haven't really tested the filters, but something bothers me in this bug. When we click on a vendor, by default, I can't see any baskets... It would be great if we could keep the current behaviour : see by default all the active baskets. I'm sorry, I couldn't test it more consistently for a while. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 19:33:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 18:33:02 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bouzid.fergani at inlibro.com |ity.org | CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 20:03:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 19:03:11 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #4 from Bouzid --- Created attachment 58265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58265&action=edit Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 20:48:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 19:48:35 +0000 Subject: [Koha-bugs] [Bug 17475] 'Edition' tab in detail.pl fails to display records with matching ISBNs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17475 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 21:35:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 20:35:54 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #5 from Bouzid --- Created attachment 58266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58266&action=edit Bug 16116 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 21:36:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 20:36:24 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 22:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 21:44:14 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17767 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 [Bug 17767] Let Koha::Patron::Modification handle extended attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 22:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 21:44:14 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17755 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 22:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 21:45:17 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 16 22:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Dec 2016 21:45:17 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 11:01:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 10:01:46 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:24:38 +0000 Subject: [Koha-bugs] [Bug 17788] New: (MARC21) $9 fields not indexed in authority-linked fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Bug ID: 17788 Summary: (MARC21) $9 fields not indexed in authority-linked fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org If you check the default framework shipped with Koha, you will notice several fields are linked to authority records (even though they might be hidden in the editor): MariaDB [koha_kohadev]> SELECT tagfield,tagsubfield,authtypecode FROM marc_subfield_structure WHERE authtypecode IS NOT NULL AND authtypecode<>'' AND frameworkcode='' GROUP BY tagfield,tagsubfield,authtypecode ; +----------+-------------+--------------+ | tagfield | tagsubfield | authtypecode | +----------+-------------+--------------+ | 100 | a | PERSO_NAME | | 110 | a | CORPO_NAME | | 111 | a | MEETI_NAME | | 130 | a | UNIF_TITLE | | 440 | a | UNIF_TITLE | | 600 | a | PERSO_NAME | | 610 | a | CORPO_NAME | | 611 | a | MEETI_NAME | | 630 | a | UNIF_TITLE | | 648 | a | CHRON_TERM | | 650 | a | TOPIC_TERM | | 651 | a | GEOGR_NAME | | 654 | a | TOPIC_TERM | | 655 | a | GENRE/FORM | | 656 | a | TOPIC_TERM | | 657 | a | TOPIC_TERM | | 658 | a | TOPIC_TERM | | 662 | a | GEOGR_NAME | | 690 | a | TOPIC_TERM | | 691 | a | GEOGR_NAME | | 696 | a | PERSO_NAME | | 697 | a | CORPO_NAME | | 698 | a | MEETI_NAME | | 699 | a | UNIF_TITLE | | 700 | a | PERSO_NAME | | 710 | a | CORPO_NAME | | 711 | a | MEETI_NAME | | 730 | a | UNIF_TITLE | | 796 | a | PERSO_NAME | | 797 | a | CORPO_NAME | | 798 | a | MEETI_NAME | | 799 | a | UNIF_TITLE | | 800 | a | PERSO_NAME | | 810 | a | CORPO_NAME | | 811 | a | MEETI_NAME | | 830 | a | UNIF_TITLE | | 896 | a | PERSO_NAME | | 897 | a | CORPO_NAME | | 898 | a | MEETI_NAME | | 899 | a | UNIF_TITLE | +----------+-------------+--------------+ But looking at etc/zebradb/marc_defs/marc21/biblio-koha-indexdefs.xml you will notice the $9 subfields is not correctly added to the Koha-Auth-Number:w index. This has the consequence of authority usage count not being precise if those fields are used and linked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:25:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:25:20 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:25:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:25:20 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:32:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:32:30 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:32:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:32:45 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 58267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58267&action=edit Bug 17788: (MARC21) Add $9 fields to Koha-Auth-Number:w index Looking at the default framework's fields that are linked to authority records, there's a divergence with the Zebra index definitions. This yields to authority usage count be incorrect for users searching for authority records. MariaDB [koha_kohadev]> SELECT tagfield,tagsubfield,authtypecode FROM marc_subfield_structure WHERE authtypecode IS NOT NULL AND authtypecode<>'' AND frameworkcode='' GROUP BY tagfield,tagsubfield,authtypecode ; +----------+-------------+--------------+ | tagfield | tagsubfield | authtypecode | +----------+-------------+--------------+ | 100 | a | PERSO_NAME | | 110 | a | CORPO_NAME | | 111 | a | MEETI_NAME | | 130 | a | UNIF_TITLE | | 440 | a | UNIF_TITLE | | 600 | a | PERSO_NAME | | 610 | a | CORPO_NAME | | 611 | a | MEETI_NAME | | 630 | a | UNIF_TITLE | | 648 | a | CHRON_TERM | | 650 | a | TOPIC_TERM | | 651 | a | GEOGR_NAME | | 654 | a | TOPIC_TERM | | 655 | a | GENRE/FORM | | 656 | a | TOPIC_TERM | | 657 | a | TOPIC_TERM | | 658 | a | TOPIC_TERM | | 662 | a | GEOGR_NAME | | 690 | a | TOPIC_TERM | | 691 | a | GEOGR_NAME | | 696 | a | PERSO_NAME | | 697 | a | CORPO_NAME | | 698 | a | MEETI_NAME | | 699 | a | UNIF_TITLE | | 700 | a | PERSO_NAME | | 710 | a | CORPO_NAME | | 711 | a | MEETI_NAME | | 730 | a | UNIF_TITLE | | 796 | a | PERSO_NAME | | 797 | a | CORPO_NAME | | 798 | a | MEETI_NAME | | 799 | a | UNIF_TITLE | | 800 | a | PERSO_NAME | | 810 | a | CORPO_NAME | | 811 | a | MEETI_NAME | | 830 | a | UNIF_TITLE | | 896 | a | PERSO_NAME | | 897 | a | CORPO_NAME | | 898 | a | MEETI_NAME | | 899 | a | UNIF_TITLE | +----------+-------------+--------------+ This patch adds the missing ones to the authority number index as it is done for the rest of the fields. To test: - Verify that etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml contains intries pointing the $9 subfield of all the fields in the 'tagfield' column above, to the Koha-Auth-Number:w index. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 13:34:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 12:34:24 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, magnus at libriotech.no --- Comment #2 from Tom?s Cohen Arazi --- I added known NORMARC and UNIMARC devs to CC, so they look at this issue and fill bugs for their MARC flavours if needed. This bug/patch covers MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 14:03:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 13:03:25 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 17 14:03:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 13:03:58 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term link subfield 648$9 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(MARC21) Chronological term |(MARC21) Chronological term |field 648 not indexed |link subfield 648$9 not | |indexed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 00:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 23:53:11 +0000 Subject: [Koha-bugs] [Bug 17707] Check out and due date are same In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17707 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette --- What are your circulation rules for that item type? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 00:53:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 23:53:18 +0000 Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 00:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 23:55:56 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 00:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Dec 2016 23:56:22 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 19:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 18:43:23 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:33:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:33:28 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:43:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:43:15 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor --- Comment #5 from Katrin Fischer --- I feel like we can change this from enhancement to a bug as the renewal should not make data disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:50:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:50:26 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:50:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:50:29 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58228|0 |1 is obsolete| | Attachment #58229|0 |1 is obsolete| | Attachment #58230|0 |1 is obsolete| | Attachment #58231|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 58268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58268&action=edit [SIGNED-OFF] Bug 17783: Test to confirm correct effective issuing rule selection This patch adds a test to cover the validity of effective issuing rule selection in correct order. To test: 1. Run t/db_dependent/Koha/IssuingRules.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:50:35 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #7 from Josef Moravec --- Created attachment 58269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58269&action=edit [SIGNED-OFF] Bug 17783: Test to print performance of get_effective_issuing_rule This test prints the amount of issuing rule matches per second for 1. worst case, when non-existent branchcode, categorycode and itemtype is being searched (currently 8 queries) 2. mid case (rule found on 4th query) 3. 2nd best case (rule found on 2nd query) 4. best case, when an issuing rule is defined for exactly those branchcode, categorycode and itemtype (currently 1 query) To test: 1. Run t/db_dependent/Koha/IssuingRules.t 2. Write down the per-second amount to compare with next patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:50:39 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #8 from Josef Moravec --- Created attachment 58270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58270&action=edit [SIGNED-OFF] Bug 17783: Add Koha::Objects->single Returns one and only one object that is part of this set. Returns undef if there are no objects found. ->single is faster than ->search->next This is optimal as it will grab the first returned result without instantiating a cursor. It is useful for this Bug as we only want to select the top row of found issuing rules. To test: 1. Run t/db_dependent/Koha/Objects.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:50:44 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #9 from Josef Moravec --- Created attachment 58271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58271&action=edit [SIGNED-OFF] Bug 17783: Optimize Koha::IssuingRules->get_effective_issuing_rule This patch modifies method get_effective_issuing_rule in Koha::IssuingRules aiming to optimize the search for matching issuing rule. Before this patch, in worst case scenario, we have had to make a SELECT query eight times. This will have a negative impact on performance where-ever we need to find matching issuing rule multiple times, if the search is not directly matching an issuing rule on the first query. This patch makes get_effective_issuing_rule have a stable performance on both best and worst case, whereas the old method was really fast on the best case and really slow on the worst case. However, this patch slightly lowers the performance for best case, where matching issuing rule is found instantly before (branchcode, categorycode and itemtype all are specifically defined in issuing rules). For all other cases this patch offers a performance improvement. To test: 1. Run t/db_dependent/Koha/IssuingRules.t and compare the results with previous tests. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 20:51:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 19:51:48 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #10 from Josef Moravec --- (In reply to Lari Taskula from comment #5) > Definitions: > We want to find an issuing rule with parameters branchcode 'B', categorycode > 'C' and itemtype 'I'. > > For current implementation, > - Best case = there is an issuing rule defined with 'B', 'C' and 'I'. > - Second best case = there is an issuing rule defined with 'B', 'C' and '*'. > - Mid case = there is an issuing rule defined with 'B', '*', '*'. > - Worst case = matching issuing rule will be '*', '*', '*'. > (These are following the order defined in circulation & fines rules page) > > My results: > OLD IMPLEMENTATION: > ok 1 - In worst case, get_effective_issuing_rule finds matching rule 74.29 > times per second. > ok 2 - In mid case, get_effective_issuing_rule finds matching rule 144.09 > times per second. > ok 3 - In second best case, get_effective_issuing_rule finds matching rule > 289.02 times per second. > ok 4 - In best case, get_effective_issuing_rule finds matching rule 561.80 > times per second. I have : 80.13 160.26 318.47 617.28 > > NEW IMPLEMENTATION (= after applying last patch): > ok 1 - In worst case, get_effective_issuing_rule finds matching rule 434.78 > times per second. > ok 2 - In mid case, get_effective_issuing_rule finds matching rule 427.35 > times per second. > ok 3 - In second best case, get_effective_issuing_rule finds matching rule > 431.03 times per second. > ok 4 - In best case, get_effective_issuing_rule finds matching rule 423.73 > times per second. And: 581.40 568.18 581.40 581.40 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:00:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:00:20 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:02:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:02:48 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Should this go into 16.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:29:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:29:22 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:30:12 +0000 Subject: [Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #17 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:30:36 +0000 Subject: [Koha-bugs] [Bug 17733] Members.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:31:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:31:01 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:31:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:31:30 +0000 Subject: [Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:32:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:32:05 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term link subfield 648$9 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:32:28 +0000 Subject: [Koha-bugs] [Bug 17681] Existing typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:33:05 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:33:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:33:14 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:34:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:34:11 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #27 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:34:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:34:36 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #29 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:35:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:35:10 +0000 Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:35:11 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Bug 17596 depends on bug 17700, which changed state. Bug 17700 Summary: Add columns configuration to fines table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:35:44 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:36:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:36:50 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:37:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:37:32 +0000 Subject: [Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:38:08 +0000 Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #13 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:39:07 +0000 Subject: [Koha-bugs] [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Katrin Fischer --- Hm, missed the second patch looking at git - this is a true enhancement and not just new unit tests. So: This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:39:07 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17557, which changed state. Bug 17557 Summary: Move GetAge to Koha::Patron->get_age (and remove SetAge) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:40:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:40:51 +0000 Subject: [Koha-bugs] [Bug 17568] Add the Koha::Patron->library method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:40:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:40:52 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Bug 17569 depends on bug 17568, which changed state. Bug 17568 Summary: Add the Koha::Patron->library method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:42:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:42:09 +0000 Subject: [Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #66 from Katrin Fischer --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:42:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:42:09 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17578, which changed state. Bug 17578 Summary: Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:42:10 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17578, which changed state. Bug 17578 Summary: Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:42:10 +0000 Subject: [Koha-bugs] [Bug 7058] GetMemberDetails must die! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 Bug 7058 depends on bug 17578, which changed state. Bug 17578 Summary: Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:53:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:53:12 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:53:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:53:13 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Bug 17586 depends on bug 17585, which changed state. Bug 17585 Summary: Add the Koha::Patron->get_account_lines method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:53:51 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17586, which changed state. Bug 17586 Summary: Add the Koha::Account::Lines->get_balance method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:53:50 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:54:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:54:17 +0000 Subject: [Koha-bugs] [Bug 17630] Add the Koha::Biblio->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:54:18 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Bug 17631 depends on bug 17630, which changed state. Bug 17630 Summary: Add the Koha::Biblio->holds method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:54:18 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Bug 17736 depends on bug 17630, which changed state. Bug 17630 Summary: Add the Koha::Biblio->holds method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:54:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:54:42 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Bug 17628 depends on bug 17631, which changed state. Bug 17631 Summary: Koha::Biblio - Remove GetHolds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 21:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 20:54:41 +0000 Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 22:47:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 21:47:15 +0000 Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|normal |enhancement Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer --- I am hesitating to push this to stable as it's a change in behavior and might come as a surprise. I think this would be better in a feature release with information added to the field for the release notes documentation. I am changing this to an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 18 23:17:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Dec 2016 22:17:14 +0000 Subject: [Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 04:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 03:50:04 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 04:50:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 03:50:08 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45621|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 58272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58272&action=edit Bug 15326: Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 08:02:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 07:02:10 +0000 Subject: [Koha-bugs] [Bug 17707] Check out and due date are same In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17707 --- Comment #2 from vimal kumar --- Users can borrow 3 books for 10 days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 08:50:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 07:50:02 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Applying: Bug 15326: Add CMS feature fatal: sha1 information is lacking or useless (Koha/CmsPage.pm). We seem to miss patches here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 11:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 10:40:20 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:10:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:10:44 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:49:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:49:46 +0000 Subject: [Koha-bugs] [Bug 17789] New: Gaurantor search is broken (add guarantor 'set to member' ) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17789 Bug ID: 17789 Summary: Gaurantor search is broken (add guarantor 'set to member') Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 17418 seems to have broken the guarantor search page: JS Error: guarantor_search.pl:134 Uncaught TypeError: Cannot set property '_renderItem' of undefined at HTMLDocument. (guarantor_search.pl:134) at i (jquery-2.2.3.min.js:2) at Object.fireWith [as resolveWith] (jquery-2.2.3.min.js:2) at Function.ready (jquery-2.2.3.min.js:2) at HTMLDocument.J (jquery-2.2.3.min.js:2) (anonymous) @ guarantor_search.pl:134 i @ jquery-2.2.3.min.js:2 fireWith @ jquery-2.2.3.min.js:2 ready @ jquery-2.2.3.min.js:2 J @ jquery-2.2.3.min.js:2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:50:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:50:07 +0000 Subject: [Koha-bugs] [Bug 17789] Gaurantor search is broken (add guarantor 'set to member') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17789 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:54:48 +0000 Subject: [Koha-bugs] [Bug 17790] New: Fix js error on undefined autocomplete(...).data(...) in js_includes.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Bug ID: 17790 Summary: Fix js error on undefined autocomplete(...).data(...) in js_includes.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If #findborrower does not exist, you cannot define _renderItem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:54:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:54:55 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #26 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:55:11 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17418 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 12:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 11:55:11 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17790 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 13:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 12:07:53 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 13:07:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 12:07:55 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 --- Comment #1 from Marcel de Rooy --- Created attachment 58273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58273&action=edit Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 13:08:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 12:08:08 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #22 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:38:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:38:44 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Marcel de Rooy --- *** Bug 17789 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:38:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:38:44 +0000 Subject: [Koha-bugs] [Bug 17789] Gaurantor search is broken (add guarantor 'set to member') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17789 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |m.de.rooy at rijksmuseum.nl Status|NEW |RESOLVED --- Comment #1 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 17790 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:54:48 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:54:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:54:50 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58273|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 58274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58274&action=edit Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:55:08 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |17790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 14:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 13:55:08 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 15:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 14:10:38 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 --- Comment #2 from George Veranis --- No the installation is clean and is on 16.11 . on console log I have the following Uncaught TypeError: Cannot read property 'match' of null(?) cataloging.js:106 the problem is that on line 106 is trying to match with id and select2 not produce select with id , and I add this on select2.min.js in order select has id attribute and not fail "
","
", but then I have another problem with select2 which not bind on click for cloned field there I tried a lot to solve it but without success at yet. If I'm correct 16.05 not use select2 and yes works perfect ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 15:37:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 14:37:19 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |bouzid.fergani at inlibro.com Resolution|FIXED |--- --- Comment #6 from Bouzid --- BREAK CATALOGUING MODULE - Koha home - Cataloguing - New record - Number 1 to 9 is not show correctly. error javascript : TypeError: $(...).autocomplete(...).data(...) is undefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 15:41:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 14:41:18 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 17:15:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 16:15:25 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Jos? Anjos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseanjos at gmail.com --- Comment #3 from Jos? Anjos --- The same is happening with me. Blank window needs to be manually closed. Koha version: 16.11 + mariaDB + Ubuntu 16.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 17:35:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 16:35:37 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 17:35:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 16:35:39 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58201|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 58275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58275&action=edit Bug 17781 - Improper branchcode set during renewal For no discernable reason, when AddIssue calls AddRenewal, it passes the branchcode generated from _GetCircControlBranch. Assume _GetCircControlBranch is set to return items.homebranch. So: 1) If an item owned by LibraryA is checked out at LibraryB, the statistic line branchcode will be LibraryB 2) If an item is renewed via the ajax datatables renewal function, the statistic line branchcode will be LibraryB the 3) If an item is renewed via scanning the item into the checkout again, statistic line branchcode will be *LibraryA* This is clearly improper behavior. The renewal is taking place at LibraryB, so the branchcode passed to AddRenewal should be LibraryB, the logged in library. This also jives with the documentation for the subroutine. Test Plan: 1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary ) 2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch ) 3) Create item with homebranch of LibraryA and holdingbranch of LibraryB 4) Set the logged in library to LibraryB 4) Check the item out to a patron at LibraryB 5) Note the statistics line has a branchcode of LibraryB 6) Check the item out again to trigger a renewal, renew the item 7) Note the statistic line has a branchcode of LibraryA! 8) Apply this patch 9) Repeat step 6 10) Note the statistics line has a branchcode of LibraryB! Signed-off-by: Kyle M Hall Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 18:20:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 17:20:57 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Attachment #48889|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 19:46:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 18:46:55 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #67 from Jesse Maseto --- Right now the 700s displaying as "by [author's name]" in search results. Is there a way to leave off the "by" in some cases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 22:42:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 21:42:47 +0000 Subject: [Koha-bugs] [Bug 17791] New: On UNIMARC system, USMARC field 100 gets overwritten Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Bug ID: 17791 Summary: On UNIMARC system, USMARC field 100 gets overwritten Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: synapse.ova at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Overview: On Z39.50 search some functions depend not on the remote server marc flavour, but on current server setting. This bug is present on versions 3.22+ Steps to Reproduce: 1) On UNIMARC system, go to Cataloguing ? New from Z39.50/SRU 2) Search USMARC server (Library of Congress, for example) for a book, that has field 100 (for example, isbn 0816310653) 3) On results list, press ?MARC? to see MARC fields Actual Results: Instead of seeing the author name in subfield A, you'll see something like ?20161219 frey50 ?, yet you could see other subfields properly Expected Results: Name of the author in 100$a Additional Information: LC Z39.50/SRW/SRU Server Configuration Guidelines: https://www.loc.gov/z3950/lcserver.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 22:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 21:45:17 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|On UNIMARC system, USMARC |On UNIMARC system, USMARC |field 100 gets overwritten |field 100$a gets | |overwritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 22:50:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 21:50:23 +0000 Subject: [Koha-bugs] [Bug 17792] New: Introduce Koha::Patron::Attribute(s) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Bug ID: 17792 Summary: Introduce Koha::Patron::Attribute(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 22:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 21:52:28 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 --- Comment #1 from Oleg Vasilenko --- Created attachment 58276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58276&action=edit Patch changes the context of Z39.50 search from local to remote server marc flavour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 22:57:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 21:57:17 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff Patch complexity|--- |String patch --- Comment #2 from Oleg Vasilenko --- Patch prepared for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:47:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:47:17 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:47:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:47:20 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57853|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia --- Created attachment 58277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58277&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database - perl installer/data/mysql/updatedatabase.pl 3) (You may have to rebuild schema but I think the patch should apply the schema changes for you) 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:48:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:48:26 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #29 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #27) > Aleisha, Have a look at your patches, there are some weird stuffs to fix: > 1/ kohastructure: you re-add the entire item table > 2/ update db: you should specify the "after" sql clause to keep the same > order as the kohastructure (not necessary useful but good practice to have) > 3/ There is no need to use strict and warnings alongside Modern::Perl; > 4/ The svc script has a BibLibre copyright > 5/ I don't understand the need of the new subroutine in the svc script > (ajax_auth_cgi). You should not need it, have a look at how the other svc > scripts deal with authentication > 6/ QA script fails with: > FAIL installer/data/mysql/sysprefs.sql > FAIL sysprefs_order > Not blocker: Sysprefs AllowIssueNotes is bad placed (see bug > 10610) Hi Jonathan, I fixed all of these except the first point - what do you mean I re-add the entire items table? Sorry, I don't understand. Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:56:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:56:09 +0000 Subject: [Koha-bugs] [Bug 17793] New: Make sysprefs search show on Administration home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Bug ID: 17793 Summary: Make sysprefs search show on Administration home page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment, admin/admin-home.pl shows the cataloguing search with check out, check in, renew and catalogue search options. It seems more appropriate to show the prefs-admin search here instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:58:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:58:17 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on Administration home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:58:20 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on Administration home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #1 from Aleisha Amohia --- Created attachment 58278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58278&action=edit Bug 17793: Make sysprefs search show on Admin home page To test: 1) Go to Administration 2) Notice Catalogue search at the top - seems out of place. 3) Apply patch and refresh page. 4) Notice admin / sysprefs search now shows and is more appropriate. 5) Confirm searching for sysprefs still works Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 19 23:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 22:58:31 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on Administration home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 00:04:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 23:04:37 +0000 Subject: [Koha-bugs] [Bug 17794] New: 'Comments' in Tools sidebar menu is not bold (active) when it should be Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Bug ID: 17794 Summary: 'Comments' in Tools sidebar menu is not bold (active) when it should be Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org The 'Comments' menu item in the Tools menu takes you to the 'Comments awaiting moderation' tab by default, and the menu item is bolded (looks active). When you click the 'Approved comments' tab, the menu item is not bold, but it should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 00:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 23:06:26 +0000 Subject: [Koha-bugs] [Bug 17794] 'Comments' in Tools sidebar menu is not bold (active) when it should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 00:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 23:06:29 +0000 Subject: [Koha-bugs] [Bug 17794] 'Comments' in Tools sidebar menu is not bold (active) when it should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 --- Comment #1 from Aleisha Amohia --- Created attachment 58279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58279&action=edit Bug 17794: 'Comments' in Tools menu is not showing as active To test: 1) Go to Tools -> Comments 2) Notice that the Comments menu item is not bold when you click on 'Approved comments' tab 3) Apply patch and refresh page 4) Comments menu item should now be bold when on either tab. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 00:06:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Dec 2016 23:06:37 +0000 Subject: [Koha-bugs] [Bug 17794] 'Comments' in Tools sidebar menu is not bold (active) when it should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 03:36:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 02:36:26 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make sysprefs search show |Make sysprefs search show |on Administration home page |on all Administration pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 03:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 02:36:51 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 08:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 07:30:20 +0000 Subject: [Koha-bugs] [Bug 17795] New: Exporting late orders from translated templates is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795 Bug ID: 17795 Summary: Exporting late orders from translated templates is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When exporting late orders in the acquisition module from a translated template, all information is one line. I feel like this had already been fixed at some time, but couldn't find the bug report. The same problem currently appears on the item search export as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 08:55:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 07:55:30 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #36 from Josef Moravec --- because of 15897 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 09:32:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 08:32:29 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|Needs Signoff |Failed QA --- Comment #3 from Zeno Tajoli --- Hi Oleg, I'm not agree with this patch. Why? Now ?20161219 frey50 ? is correct default for Unimarc 100 field If you have a Unimarc server and you want to use LOC [a MARC21 z39.50] you need to use the field "XSLT file(s)" in z39.50 definiton. See: http://manual.koha-community.org/3.22/en/additionaladmin.html#addztarget In bug 6536 there is an example of XSLT for MARC21 -> Unimarc conversion. See: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37264 Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 09:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 08:58:14 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Oleg Vasilenko --- Hi Zeno, This change is normal if you access UNIMARC record on Unimarc server. But the problem is that this is changed before XSLT conversion. I do xslt conversion, but it converts this already changed string. You can check by yourself https://github.com/Gelow/unimarc/blob/master/marc21xml2unimarc.xsl MARC view in Z39.50 search results shows the record as it is. Koha code works the way, that it first converts codepage, and after that changes the subfield where it is stated, that it is UTF-8. But the problem is that it thinks that the record is in unimarc format, so it changes 100$a. The patch uses server flavour, that is stated in Z39.50 servers table. That way everythig works fine. Function, that do codepage conversion understands that this record is USMARC (as stated in Z39.50 server table), and it changes leader, not 100$a. Because information about codepage is located in different places in these flavours. You can see that this problem is present in different koha versions. But the patch is prepared for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 10:13:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 09:13:58 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 --- Comment #5 from Zeno Tajoli --- Ok Oleg, you are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 10:20:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 09:20:40 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 --- Comment #6 from Oleg Vasilenko --- When you use XSLT conversion, you'll see the same problem USMARC 100 is converted to UNIMARC 700. But the conversion happens after codepage is changed. So you'll see 700$a 20161219 frey50 700$b 1933- but not the author name in 700$a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 11:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 10:22:53 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com Attachment #58218|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood --- Comment on attachment 58218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58218 Bug 11897: Interface for rota items from biblio This is being obsoleted, replacement patch to be attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 11:23:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 10:23:11 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58219|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood --- Comment on attachment 58219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58219 Bug 11897: Add menu options for Stock Rotation This is being obsoleted, replacement patch to be attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 11:25:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 10:25:31 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #19 from Andrew Isherwood --- Created attachment 58280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58280&action=edit Bug 11897: Interface for rota items from biblio * catalogue/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 11:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 10:26:16 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #20 from Andrew Isherwood --- Created attachment 58281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58281&action=edit Bug 11897: Add menu options for Stock Rotation * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:32 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:35 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57924|0 |1 is obsolete| | Attachment #57925|0 |1 is obsolete| | Attachment #57926|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 58282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58282&action=edit Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests If IndependentBranches is set, the code is buggy. This patch only highlight the bug by providing a test. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:41 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #25 from Jonathan Druart --- Created attachment 58283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58283&action=edit Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests The next patch will move C4::Circulation::AnonymiseIssueHistory and C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons This patch move the history anonymisation code to the Patrons.t test file and the entire subtest related to StoreLastBorrower to StoreLastBorrower.t It just moves and add some minor adjustements. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:45 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #26 from Jonathan Druart --- Created attachment 58284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58284&action=edit Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:49 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #27 from Jonathan Druart --- Created attachment 58285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58285&action=edit Bug 16966: Make the tests pass again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:16:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:16:52 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #28 from Jonathan Druart --- Created attachment 58286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58286&action=edit Bug 16966: The method should return a Koha::Patrons object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:17:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:17:50 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:17:54 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58180|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 58287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58287&action=edit Bug 17317: ILSDI: Getavailability method with id_type=bib implementation To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:17:58 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #15 from Jonathan Druart --- Created attachment 58288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58288&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:21:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:21:45 +0000 Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account->balance method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the |Koha::Account::Lines->get_b |Koha::Account->balance |alance method |method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 12:25:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 11:25:35 +0000 Subject: [Koha-bugs] [Bug 17585] Add the Koha::Patron->account method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the |Koha::Patron->get_account_l |Koha::Patron->account |ines method |method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 13:21:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 12:21:57 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #30 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #29) > I fixed all of these except the first point - what do you mean I re-add the > entire items table? Sorry, I don't understand. Hi Aleisha, Look at your patch, the kohastructure.sql file: You drop and recreate the issues table. Note that you must add the 2 new columns to the old_issues table as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 13:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 12:41:42 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #18 from Jonathan Druart --- Bug 17755 - Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 13:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 12:47:05 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #9 from Jonathan Druart --- I'd recommend you to upgrade Module::Load::Conditional to a newer version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:00:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:00:59 +0000 Subject: [Koha-bugs] [Bug 17796] New: Koha::Issues should be moved to Koha::Checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Bug ID: 17796 Summary: Koha::Issues should be moved to Koha::Checkouts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:06:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:06:43 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:06:46 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58274|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58289&action=edit Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:08:20 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- This #findborrower element is present on almost every page, it makes sense to keep it in js_includes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:10:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:10:22 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:10:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:10:25 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 --- Comment #1 from Jonathan Druart --- Created attachment 58290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58290&action=edit Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:11:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:11:45 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 [Bug 16086] Add Koha::Issue objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:11:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:11:45 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 [Bug 17796] Koha::Issues should be moved to Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:14:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:14:41 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 --- Comment #7 from Marcel de Rooy --- Oleg, This seems to me an tricky change. What you are trying to do, is currently not fully supported in Koha. A conversion between MARC21 and UNIMARC did not make it until now. If you do a XSLT conversion after this statement, it will probably be fine, but in many other cases it will not be followed by such a conversion and new problems will probably arise. To make this foolproof, we need more changes (and checks)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:28:39 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 --- Comment #2 from Jonathan Druart --- Created attachment 58291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58291&action=edit Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:32:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:32:57 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58291|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58292&action=edit Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:40:12 +0000 Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57864|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58293&action=edit Bug 17689: Add the Koha::Checkout->is_overdue method This patch adds a new method Koha::Checkout->is_overdue and provide tests to cover it. The goal is to behave like GetItemIssues set the 'overdue' flag to issues. I don't understand why the existing GetItemIssues truncate dates to minutes, so I did not recreate this behavior. Test plan: prove t/db_dependent/Koha/Checkouts.t should return green Signed-off-by: Mika Smith Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:40:53 +0000 Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17796 --- Comment #5 from Jonathan Druart --- Rebased on top of bug 17796 (Move Koha::Issues to Koha::Checkouts) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 [Bug 17796] Koha::Issues should be moved to Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:40:53 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 [Bug 17689] Add the Koha::Issue->is_overdue method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:45:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:45:56 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 --- Comment #8 from Jonathan Druart --- Created attachment 58294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58294&action=edit Bug 17678: Use Koha::Checkouts instead of Koha::Issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:46:43 +0000 Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Acquisition - Replace |C4::Acquisition - Replace |GetIssues with Koha::Issues |GetIssues with | |Koha::Checkouts Depends on| |17796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 [Bug 17796] Koha::Issues should be moved to Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 14:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 13:46:43 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678 [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:02:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:02:07 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57971|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 58295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58295&action=edit Bug 17584: Add the Koha::Patron->get_checkouts method Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:02:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:02:34 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17796 --- Comment #7 from Jonathan Druart --- Rebased on top of bug 17796 (Move Koha::Issues to Koha::Checkouts) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 [Bug 17796] Koha::Issues should be moved to Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:02:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:02:34 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 [Bug 17584] Add the Koha::Patron->get_issues method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:18:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:18:27 +0000 Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined autocomplete(...).data(...) in js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:22:51 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:22:53 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58290|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 58296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58296&action=edit Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:22:59 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58292|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 58297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58297&action=edit Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:31:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:31:35 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:31:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:31:39 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58236|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58298&action=edit Bug 17692 - Can't add library EAN under Plack When adding a library ean under plack, there is an "internal server error" when running Plack. Tested with Koha 16.11 release. Test Plan: 1) Apply this patch 2) Enable Plack 3) Add, Edit and Delete a Library EAN Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:31:42 +0000 Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692 --- Comment #4 from Jonathan Druart --- Created attachment 58299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58299&action=edit Bug 17692: Remove 'CGI::param called in list context' warnings Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 15:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 14:32:59 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jonathan Druart --- (In reply to Bouzid from comment #6) > BREAK CATALOGUING MODULE > - Koha home > - Cataloguing > - New record > - Number 1 to 9 is not show correctly. > error javascript : TypeError: $(...).autocomplete(...).data(...) is > undefined Must be fixed bug 17790, otherwise open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:07:53 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:07:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:07:56 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #11 from Lari Taskula --- Created attachment 58300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58300&action=edit Bug 17783: Prevent crash when providing an undefined value When calling the proposed version of get_effective_issuing_rule with undefined parameter values, a following crash occurs: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /home/ubuntu/kohaclone/Koha/Objects.pm line 182 This patch adds a test to cover this problem and fixes the issue. To test: 1. Run t/db_dependent/Koha/IsssuingRules.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:09:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:09:18 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #12 from Lari Taskula --- I found a bug described above as I started to use this modification in my other project. Josef, could you confirm and sign-off that patch as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:13:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:13:51 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:13:53 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58296|0 |1 is obsolete| | Attachment #58297|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 58301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58301&action=edit Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:14:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:14:03 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 --- Comment #7 from Kyle M Hall --- Created attachment 58302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58302&action=edit Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:14:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:14:18 +0000 Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:23:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:23:35 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:23:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:23:37 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 --- Comment #1 from Marcel de Rooy --- Created attachment 58303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58303&action=edit Bug 17785: oai.pl returns wrong URLs under Plack Look at e.g. the URL for Show More at the end of the output of Records or Identifiers. If you use Plack, you will see that it refers to yourserver:/opac/oai.pl, which is not correct. This is caused by using CGI's self_url in combination with script alias, mounting point, etc. Note that we cannot solve this problem in the code of Koha only. Since HTTP::OAI modules also call self_url, we still end up with some wrong url's. Instead of a larger architectural operation on Apache and Plack config files, this patch adjusts the final xslt transformation on the OAI response. It hardcodes the correct path only once, in a xslt variable. And replaces all oai:OAI-PMH/oai:request/text() calls, containing wrong URLs, by this variable. Test plan: Run oai.pl. Try the various verbs. Verify that the URLs point to /cgi-bin/koha/oai.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:25:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:25:13 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |ere.maijala at helsinki.fi, | |frederic at tamil.fr, | |julian.maurice at biblibre.com --- Comment #2 from Marcel de Rooy --- Adding in cc some people involved in recent oai changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:33:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:33:50 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Mirko, I recreate the issue with your file, but I don't if I create an authority record with Koha (110$a Universit?t Berlin) and I upload them. Where does come from this record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:35:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:35:06 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 --- Comment #4 from Jonathan Druart --- auth-min.xml: XML 1.0 document, UTF-8 Unicode text from_koha.marcxml: XML 1.0 document, ASCII text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:37:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:37:29 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:37:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:37:32 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58300|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 58304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58304&action=edit [SIGNED-OFF] Bug 17783: Prevent crash when providing an undefined value When calling the proposed version of get_effective_issuing_rule with undefined parameter values, a following crash occurs: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /home/ubuntu/kohaclone/Koha/Objects.pm line 182 This patch adds a test to cover this problem and fixes the issue. To test: 1. Run t/db_dependent/Koha/IsssuingRules.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:38:26 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #14 from Josef Moravec --- (In reply to Lari Taskula from comment #12) > I found a bug described above as I started to use this modification in my > other project. Josef, could you confirm and sign-off that patch as well? Yes, I was able to get this error too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:51:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:51:27 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 16:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 15:58:00 +0000 Subject: [Koha-bugs] [Bug 17797] New: Add XSLT_Handler in opac/unapi Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Bug ID: 17797 Summary: Add XSLT_Handler in opac/unapi Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:05:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:05:33 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:05:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:05:35 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 --- Comment #1 from Marcel de Rooy --- Created attachment 58305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58305&action=edit Bug 17797: Add XSLT_Handler in opac/unapi Replaces some code by a call to existing module. Removes the $@->code and $@->message calls. Test plan [1] Run /cgi-bin/koha/unapi?id=koha:biblionumber:[number]&format=marcxml [2] Try some variations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:05:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:05:46 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:15:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:15:50 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Is there a reason not to use the same list of fields on the Filters block (left side of patron list)? members/member.tt If an entry of the pref is not valid, we will know get an empty entry. It may be better to skip it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:23:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:23:27 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:23:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:23:31 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58240|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 58306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58306&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:33:51 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Kyle, that changes will have more effects than just the statistic line. It will also modifies the branchcode condition for the item circulation alert (see C4::Circulation::AddRenewal:2991). I don't think it is what we want. Moreover we will need tests to cover this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:40:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:40:52 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 --- Comment #8 from Oleg Vasilenko --- Marcel, I am working on the MARC21 to UNIMARC conversion right now, and now it works good enough. I did many changes to original XSLT file published by Terry Reese on github (bug 16488). See https://github.com/Gelow/unimarc/blob/master/marc21xml2unimarc.xsl The only problem is that field 100$a is corrupted on Z39.50 search. I added LOC server as SRU and field 100$a is not corrupted that way. This is because in sub _handle_one_result() right now SRU server is processed with it's flavour in mind. The same should be with Z39.50 What problems will we face after this patch? The same as we have with SRU servers right now. When UNIMARC system connects to MARC21 server, it will check encoding stated in 100$a (thanks to checks in XML.pm called from function AddBiblioToBatch()).If it's not set, you'll see XML encoding error (?Unsupported UNIMARC character encoding [$enc] for XML output?). In other cases everything should be fine If we do not apply this patch You can see the results table, and see sourse MARC with corrupted 100$a. But the table has empty columns because of different format, so who does need it? To overcome stated problems it is possible to add some check in the code for UNIMARC and process the record some way (but record could become corrupted again). Or add XSLT file for conversion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:41:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:41:00 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #30 from Bouzid --- Created attachment 58307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58307&action=edit Bug 11299: fix problem show undefined when submit blank data and other small fix - Show icon of button automaticlinker and search - Add icons deny and approve - Fix problem button 'Z39.50/SRU Search' it's show twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 17:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 16:41:37 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:04:29 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55961|0 |1 is obsolete| | --- Comment #8 from Bouzid --- Created attachment 58308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58308&action=edit Bug 17385 - Add custom export notices test case: - Apply patch - Open intranet or opac interface and submit any search. - Click title of found item - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. - The name 'Simple Export' it's extract in the xslt file, curently the name is MARC21_simple_export.xsl. for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:05:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:05:09 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #9 from Bouzid --- Rebase patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:04 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #15 from Jonathan Druart --- Created attachment 58309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58309&action=edit Bug 17783: Test to confirm correct effective issuing rule selection This patch adds a test to cover the validity of effective issuing rule selection in correct order. To test: 1. Run t/db_dependent/Koha/IssuingRules.t Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:09 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #16 from Jonathan Druart --- Created attachment 58310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58310&action=edit Bug 17783: Test to print performance of get_effective_issuing_rule This test prints the amount of issuing rule matches per second for 1. worst case, when non-existent branchcode, categorycode and itemtype is being searched (currently 8 queries) 2. mid case (rule found on 4th query) 3. 2nd best case (rule found on 2nd query) 4. best case, when an issuing rule is defined for exactly those branchcode, categorycode and itemtype (currently 1 query) To test: 1. Run t/db_dependent/Koha/IssuingRules.t 2. Write down the per-second amount to compare with next patch Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:13 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #17 from Jonathan Druart --- Created attachment 58311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58311&action=edit Bug 17783: Add Koha::Objects->single Returns one and only one object that is part of this set. Returns undef if there are no objects found. ->single is faster than ->search->next This is optimal as it will grab the first returned result without instantiating a cursor. It is useful for this Bug as we only want to select the top row of found issuing rules. To test: 1. Run t/db_dependent/Koha/Objects.t Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:16 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #18 from Jonathan Druart --- Created attachment 58312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58312&action=edit Bug 17783: Optimize Koha::IssuingRules->get_effective_issuing_rule This patch modifies method get_effective_issuing_rule in Koha::IssuingRules aiming to optimize the search for matching issuing rule. Before this patch, in worst case scenario, we have had to make a SELECT query eight times. This will have a negative impact on performance where-ever we need to find matching issuing rule multiple times, if the search is not directly matching an issuing rule on the first query. This patch makes get_effective_issuing_rule have a stable performance on both best and worst case, whereas the old method was really fast on the best case and really slow on the worst case. However, this patch slightly lowers the performance for best case, where matching issuing rule is found instantly before (branchcode, categorycode and itemtype all are specifically defined in issuing rules). For all other cases this patch offers a performance improvement. To test: 1. Run t/db_dependent/Koha/IssuingRules.t and compare the results with previous tests. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:20 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #19 from Jonathan Druart --- Created attachment 58313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58313&action=edit Bug 17783: Prevent crash when providing an undefined value When calling the proposed version of get_effective_issuing_rule with undefined parameter values, a following crash occurs: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /home/ubuntu/kohaclone/Koha/Objects.pm line 182 This patch adds a test to cover this problem and fixes the issue. To test: 1. Run t/db_dependent/Koha/IsssuingRules.t Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:08:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:08:25 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #20 from Jonathan Druart --- Created attachment 58314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58314&action=edit Bug 17783: Replace ok with is Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:40 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:43 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58304|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:46 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:48 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:51 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:09:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:09:55 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:10:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:10:47 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Jonathan Druart --- I am not sure the 'Performance' tests are useful (as they will always return true) but it will not hurt to have them. Well done, Lari! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:14:11 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_checkouts method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the |Koha::Patron->get_issues |Koha::Patron->get_checkouts |method |method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:19:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:19:38 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #58 from Jonathan Druart --- Nobody to signoff on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:21:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:21:58 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- I attempted to apply this on the kohadevbox and it didn't change the file size, even though this is supposed to add a line feed at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:24:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:24:47 +0000 Subject: [Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783 --- Comment #22 from Lari Taskula --- (In reply to Jonathan Druart from comment #21) > I am not sure the 'Performance' tests are useful (as they will always return > true) but it will not hurt to have them. > > Well done, Lari! Yeah probably not so useful afterwards, but surely useful for showing the change before and after. Maybe someone will eventually come up with a better improvement and can use that test to confirm it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:38:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:38:02 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:38:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:38:05 +0000 Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules shouldn't allow 'New' with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58237|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58315&action=edit Bug 17208: Checking if classification source or filing rule already exists before adding To test: 1) Go to Admin -> Classification sources 2) Attempt to reproduce bug before applying patch. Notice the message saying the add was successful, but was not added to the table 3) Apply patch and refresh page (restart plack if necessary) 4) Add new classification source with same code as existing one. Notice you are now told that the add failed. 5) Confirm adding new classification source with unique code works 6) Add new classification filing rule with same code as existing one. Notice you are told that add failed. 7) Confirm adding new classification filing rule with unique code works Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart This is not the way to go, we should use an eval instead. But since we do not have RaiseError set, it will not work. This module will need to be moved to Koha::Objects to be implemented correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:40:59 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 18:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 17:41:03 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58241|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 58316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58316&action=edit Bug 15415: Warn when creating a new print profile As per Jonathan's comment in Comment 3, I've put that line of code in an if statement that will only call the get_attr method if we are editing an existing profile (therefore the profile id will exist). To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 19:47:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 18:47:00 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis at uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 19:47:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 18:47:23 +0000 Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing and Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis at uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 19:53:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 18:53:20 +0000 Subject: [Koha-bugs] [Bug 17798] New: Checking out an item on hold for another patron prints a slip but does not update hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Bug ID: 17798 Summary: Checking out an item on hold for another patron prints a slip but does not update hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: Place a hold for patron A Do not confirm the hold Checkout that item to Patron B See the options including 'Don't checkout and print slip' Print the slip Check the item record The hold has not been confirmed and the item 'last seen' is not updated For consistency printing should confirm the hold as well and mark the item waiting or initiate a transfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:44:21 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58067|0 |1 is obsolete| | --- Comment #69 from Owen Leonard --- Created attachment 58317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58317&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:46:23 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58317|0 |1 is obsolete| | --- Comment #70 from Owen Leonard --- Created attachment 58318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58318&action=edit [SIGNED-OFF] Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:46:32 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58068|0 |1 is obsolete| | --- Comment #71 from Owen Leonard --- Created attachment 58319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58319&action=edit [SIGNED-OFF] Bug 16239: Update templates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:46:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:46:41 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58069|0 |1 is obsolete| | --- Comment #72 from Owen Leonard --- Created attachment 58320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58320&action=edit [SIGNED-OFF] Bug 16239: Update css files Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:46:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:46:47 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58070|0 |1 is obsolete| | --- Comment #73 from Owen Leonard --- Created attachment 58321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58321&action=edit [SIGNED-OFF] Bug 16239: Update javascript files Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:46:59 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58071|0 |1 is obsolete| | --- Comment #74 from Owen Leonard --- Created attachment 58322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58322&action=edit [SIGNED-OFF] Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 20 20:49:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Dec 2016 19:49:03 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #75 from Owen Leonard --- Created attachment 58323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58323&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the 
 tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 20 20:49:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 20 Dec 2016 19:49:24 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 01:31:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 00:31:10 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 01:31:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 00:31:13 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #5 from Aleisha Amohia  ---
Created attachment 58324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58324&action=edit
[FOLLOW-UP] Bug 14866: Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 01:56:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 00:56:51 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58277|0                           |1
        is obsolete|                            |

--- Comment #31 from Aleisha Amohia  ---
Created attachment 58325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58325&action=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database - perl installer/data/mysql/updatedatabase.pl
3) (You may have to rebuild schema but I think the patch should apply
    the schema changes for you)
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
    out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the two items you checked
in, and are accurate to the item (i.e. the right issue note under the
right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 02:00:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 01:00:35 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58325|0                           |1
        is obsolete|                            |

--- Comment #32 from Aleisha Amohia  ---
Created attachment 58326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58326&action=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database - perl installer/data/mysql/updatedatabase.pl
3) (You may have to rebuild schema but I think the patch should apply
    the schema changes for you)
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
    out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the two items you checked
in, and are accurate to the item (i.e. the right issue note under the
right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 02:00:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 01:00:59 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #33 from Aleisha Amohia  ---
(In reply to Jonathan Druart from comment #30)
> Hi Aleisha,
> Look at your patch, the kohastructure.sql file: You drop and recreate the
> issues table.
> Note that you must add the 2 new columns to the old_issues table as well.

Fixed that all up - ready for testing again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 02:32:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 01:32:59 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 02:33:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 01:33:02 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58278|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia  ---
Created attachment 58327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58327&action=edit
Bug 17793: Make sysprefs search show on all Admin pages

This patch is amended to use the sysprefs search on all Administration
pages that do not have their own custom search.

To test:
1) Go to Administration
2) Notice Catalogue search at the top - seems out of place.
3) Apply patch and refresh page.
4) Notice admin / sysprefs search now shows and is more appropriate.
5) Confirm searching for sysprefs still works

This patch affects the following pages:
- admin-home.pl
- audio_alerts.pl
- authtypes.pl
- auth_tag_structure.pl
- authorised_values.pl
- biblio_framework.pl
- marctagstructure.pl
- branch_transfer_limits.pl
- branches.pl
- checkmarc.pl
- classsources.pl
- columns_settings.pl
- didyoumean.pl
- edi_accounts.pl
- edi_ean_accounts.pl
- fieldmapping.pl
- item_circulation_alerts.pl
- items_search_fields.pl
- items_search_field.pl
- item_types.pl
- koha2marklinks.pl
- matching-rules.pl
- oai_sets.pl
- oai_set_mappings.pl
- patron-attr-types.pl
- smart-rules.pl
- transport-cost-matrix.pl

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 02:46:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 01:46:36 +0000
Subject: [Koha-bugs] [Bug 17794] 'Comments' in Tools sidebar menu is not
 bold (active) when it should be
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #2 from Aleisha Amohia  ---
I realised that this is actually a problem with the original javascript that is
meant to make 'path + params' bold, but doesn't. Affects entire tools-menu and
admin-menu. Patch coming

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:18:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:18:21 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|'Comments' in Tools sidebar |Menu items in Tools menu
                   |menu is not bold (active)   |and Admin menu not bold
                   |when it should be           |when active but not on
                   |                            |linked page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:34:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:34:01 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:34:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:34:05 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58279|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia  ---
Created attachment 58328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58328&action=edit
Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active
but not on linked page

To reproduce:
admin-menu
1) Go to a page like admin/categories.pl
2) Click New Category
3) Notice Patron categories in the sidebar menu is no longer bold
tools-menu
4) Go to a page like reviews/reviewswaiting.pl
5) Notice bold Comments in sidebar menu
6) Click Approved Comments tab
7) Notice no longer bold in sidebar menu
To test:
8) Apply patch and refresh page
9) Follow above steps to reproduce bug, confirm that active links are
always bold
10) Test with other links to confirm nothing has broken
Special cases
11) Go To admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure
12) Confirm sidebar menu link is still bold
13) Go to admin -> Authority types -> Actions for any auth type -> MARC
structure
14) Confirm sidebar menu link is still bold
15) Go to admin -> OAI sets config -> Actions for any set -> Define
mappings
16) Confirm sidebar menu link is still bold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:46:39 +0000
Subject: [Koha-bugs] [Bug 17799] New: MARC bibliographic frameworks
 breadcrumbs broken for Default framework
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

            Bug ID: 17799
           Summary: MARC bibliographic frameworks breadcrumbs broken for
                    Default framework
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:49:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:49:35 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:49:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:49:38 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

--- Comment #1 from Aleisha Amohia  ---
Created attachment 58329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58329&action=edit
Bug 17799: MARC bibliographic frameworks breadcrumbs broken for Default
framework

To test:
1) Go to Admin -> MARC frameworks -> Default framework actions -> MARC
structure
2) Click New tag
3) Notice the breadcrumbs say '()' instead of 'Default MARC framework'
or something more appropriate
4) Apply patch and refresh page
5) Confirm breadcrumbs are now filled correctly
6) Go back to tag structure and try deleting a tag (Actions -> Delete)
7) Confirm breadcrubs are filled correctly

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:49:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:49:53 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:53:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:53:19 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58328|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia  ---
Created attachment 58330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58330&action=edit
Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active
but not on linked page

To reproduce:
admin-menu
1) Go to a page like admin/categories.pl
2) Click New Category
3) Notice Patron categories in the sidebar menu is no longer bold
tools-menu
4) Go to a page like reviews/reviewswaiting.pl
5) Notice bold Comments in sidebar menu
6) Click Approved Comments tab
7) Notice no longer bold in sidebar menu
To test:
8) Apply patch and refresh page
9) Follow above steps to reproduce bug, confirm that active links are
always bold
10) Test with other links to confirm nothing has broken
Special cases
11) Go To admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure
12) Confirm sidebar menu link is still bold
13) Go to admin -> Authority types -> Actions for any auth type -> MARC
structure
14) Confirm sidebar menu link is still bold
15) Click Actions for any tag -> Subfields
16) Confirm sidebar menu link is still bold
17) Go to admin -> OAI sets config -> Actions for any set -> Define
mappings
18) Confirm sidebar menu link is still bold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:54:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:54:56 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58330|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia  ---
Created attachment 58331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58331&action=edit
Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active
but not on linked page

To reproduce:
admin-menu
1) Go to a page like admin/categories.pl
2) Click New Category
3) Notice Patron categories in the sidebar menu is no longer bold
tools-menu
4) Go to a page like reviews/reviewswaiting.pl
5) Notice bold Comments in sidebar menu
6) Click Approved Comments tab
7) Notice no longer bold in sidebar menu
To test:
8) Apply patch and refresh page
9) Follow above steps to reproduce bug, confirm that active links are
always bold
10) Test with other links to confirm nothing has broken
Special cases
11) Go To admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure
12) Confirm sidebar menu link is still bold
13) Go to admin -> Authority types -> Actions for any auth type -> MARC
structure
14) Confirm sidebar menu link is still bold
15) Click Actions for any tag -> Subfields
16) Confirm sidebar menu link is still bold
17) Go to admin -> OAI sets config -> Actions for any set -> Define
mappings
18) Confirm sidebar menu link is still bold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:59:06 +0000
Subject: [Koha-bugs] [Bug 17800] New: Add admin sidebar menu to
 marc-subfields-structure.pl
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

            Bug ID: 17800
           Summary: Add admin sidebar menu to marc-subfields-structure.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 03:59:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 02:59:12 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 04:02:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 03:02:53 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 04:02:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 03:02:57 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

--- Comment #1 from Aleisha Amohia  ---
Created attachment 58332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58332&action=edit
Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 04:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 03:03:18 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17794

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 04:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 03:03:18 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17800

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:08:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:08:42 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43188|0                           |1
        is obsolete|                            |

--- Comment #10 from Aleisha Amohia  ---
Created attachment 58333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58333&action=edit
Bug 8630 - Adlibris covers (syspref files)

This patch adds a system preference for cover images from Swedish
book retailer Adlibris. Images are retrieved via http or https
from an external web server. This might leak OPAC and Staff
interface data to third parties and should thus be used with
caution.

Sponsored-By: Halland County Library

Test plan:

Test 1: Test upgrade procedure for clean installation.

  Start by removing existing sysprefs, if present:

  $ mysql -u kohaadmin -p -D koha
  > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

* Apply this patch which will add a pref file, update the 'syspref'
  structure and add an atomic upgrade file.

* Install the update:
  Koha$ perl installer/data/mysql/updatedatabase.pl

* Once upgraded and logged in, Select 'More', 'Administration',
  'Global Preferences' and finally 'Enhanced content'.
  There should be a new option called 'Adlibris'.

  The first option should default to "Don't show", if not the
  patch is broken.

  The second options should show the default URL:
  http://www.adlibris.com/se/organisationer/showimagesafe.aspx

  If not, the patch is broken.

Test 2: Changing sysprefs

* In the control panel, change the first value from "Don't show"
  to "Show" and save the changes. Use MySQL client to inspect changes:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  The column 'value' should now have the value '1', if not the patch
  is broken.

Test 3: Apply update to existing data

* Re-execute the installer now that the database has the data already:
  Koha$ perl installer/data/mysql/updatedatabase.pl

  If any errors occur the patch is broken.

  Examine the database contents:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  If the values were overwritten by the installer the patch is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:08:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:08:47 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43256|0                           |1
        is obsolete|                            |

--- Comment #11 from Aleisha Amohia  ---
Created attachment 58334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58334&action=edit
Bug 8630 - Adlibris covers (intranet templates)

Changes to staff interface (intranet) templates.
Depends on new CSS clases defined in separate patch.

Test plan:

To test this particular patch (intranet templates) you need:
* The syspref patch applied
* The intranet CSS patch applied

To test:
* Apply this patch

* Enable covers (if not done already)
  * Go to staff interface, log in as a priviliged user.
  * Select "More" -> "Administration" ->
    "Global system preferences" -> "Enhanced content".
  * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris".
  * Save changes

* Add a book with a known cover/ISBN (if none exists)
  * Set MARC field 020 a,
    "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935
  * Set MARC field 245 a, "Title" to: 1984
  * Save changes

* Test results.tt
  * From the main intranet page, select "Search the catalog" and
    enter the title we added, "1984" and press "Search".
  * You should end up with the url:
    http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984
  * The cover image should be shown in the leftmost column.
  * If cover is clicked, the full cover image should be shown.

* Test detail.tt
  (continue from the search results used in prev. test)
  * Click on the title text, you should be sent to:
    http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2
  * The cover image should be shown on the right.
  * If clicked, the full cover should be shown.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:08:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:08:53 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43257|0                           |1
        is obsolete|                            |

--- Comment #12 from Aleisha Amohia  ---
Created attachment 58335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58335&action=edit
Bug 8630 - Adlibris covers (intranet CSS)

This defined two new CSS classes for use by the intranet templates.
Apply this patch before doing the testing of "intranet templates".

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:08:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:08:57 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43258|0                           |1
        is obsolete|                            |

--- Comment #13 from Aleisha Amohia  ---
Created attachment 58336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58336&action=edit
Bug 8630 - Adlibris covers (OPAC templates)

Changes to OPAC templates.
Depends on new CSS clases defined in separate patch.

Test plan:

To test this particular patch (intranet templates) you need:
* The syspref patch applied
* The intranet CSS patch applied

To test:
* Apply this patch

* Enable covers (if not done already)
  * Go to staff interface, log in as a priviliged user.
  * Select "More" -> "Administration" ->
        "Global system preferences" -> "Enhanced content".
  * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris".
  * Save changes

* Add a book with a known cover/ISBN (if none exists)
  * Set MARC field 020 a,
        "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935
  * Set MARC field 245 a, "Title" to: 1984
  * Save changes

* Test opac-results.tt
  * Search library catalog from OPAC for "1984".
  * You should be sent to:
    http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984
  * Cover image should be shown to the right of each title
    with CSS class: "adlibris-cover"

* Test opac-detail.tt
  (continued from previous test's location)
  * Click on the title with cover (1984, ISBN: 9780451524935)
  * Cover should be displayed to the left in full size.
  * If clicked, should link to the full-size image.

Test opac-results-grouped.tt
  * This template is only used if an external "grouping" server is
    setup and the syspref "OPACGroupResults" is set to "Use".
  * Personally I did not test this, b/c: terminally lazy

* Test opac-showreviews.tt
  * Could not find any links to this location, manually enter it:
    http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl
  * Image should be shown to the right in full size.
  * If clicked it should take you to the detail view with the
    comments tab opened.

* Test opac-showreviews-rss.tt
  * Click on the RSS icon from previous test's start location.
    URL should be:
    http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss
  * An image tag linking to the full-size image without any
    styling class should be present.

* Test opac-user.tt
  * Click on your username to open:
    http://127.0.1.1/cgi-bin/koha/opac-user.pl
  * Covers should be shown for checked out items with
    CSS class: adlibris-cover
  * When clicked the destination should be the same as
    clicking the title column entry: opac-details.pl

* Test opac-opensearch.tt
  * Click on "Advanced search" and enter "1984" then press "Search"
  * This search screen uses a different template.
  * Cover image should be shown to the right of each title
    with CSS class: "adlibris-cover"
  * If clicked, should link to the OPAC detail view.

* Test opac-readingrecord.tt
  * Click on your logged-in name to go to your personal page.
  * Click on "Your reading history" tab on the left.
    http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl
  * Covers should be shown in leftmost column with
    CSS class: adlibris-cover
  * If clicked, should link to the same as the 'Title' link.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:09:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:09:03 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43259|0                           |1
        is obsolete|                            |

--- Comment #14 from Aleisha Amohia  ---
Created attachment 58337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58337&action=edit
Bug 8630 - Adlibris covers (OPAC less changes)

This patch adds two new CSS classes specific to Adlibris covers.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 05:10:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 04:10:05 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #15 from Aleisha Amohia  ---
Patches have been rebased and are ready for testing.
Test WITHOUT the opac minified css patch - this will only cause painful
conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 09:55:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 08:55:09 +0000
Subject: [Koha-bugs] [Bug 17801] New: 'Top Most-circulated items' gives
 wrong results when filtering by checkout date
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801

            Bug ID: 17801
           Summary: 'Top Most-circulated items' gives wrong results when
                    filtering by checkout date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

We had a library reporting that records show up on this report that haven't
been checked out within the selected date range of checkout dates.

After looking at the script I think this is because it checks the timestamp
column instead of the issuedate of old_issues.

In old_issues the timestamp is the date of return, so that's not right and
explains the results the library reported.

Side note: the report does also not seem to count current checkouts as it
avoids the issues table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:28:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:28:01 +0000
Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha
	community
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608
[Bug 14608] HEA : add possibility of sharing usage statistics in Administration
page and Web installer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:28:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:28:01 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11926


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926
[Bug 11926] HEA - Report usage statistics to Koha community
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:52:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:52:22 +0000
Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha
	community
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17802


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17802
[Bug 17802] Hea - Add geolocation information
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:52:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:52:22 +0000
Subject: [Koha-bugs] [Bug 17802] New: Hea - Add geolocation information
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17802

            Bug ID: 17802
           Summary: Hea - Add geolocation information
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Websites, Mailing Lists, etc
          Assignee: wizzyrea at gmail.com
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 11926

In order to add more useful information to Hea, it would be great to give
libraries the ability to share their geolocation information.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926
[Bug 11926] HEA - Report usage statistics to Koha community
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:53:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:53:59 +0000
Subject: [Koha-bugs] [Bug 17803] New: Hea - collect number of libraries per
	installation
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17803

            Bug ID: 17803
           Summary: Hea - collect number of libraries per installation
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Websites, Mailing Lists, etc
          Assignee: wizzyrea at gmail.com
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 11926

To make the Hea information more relevant, we would need to collect the number
of libraries are used per Koha installation.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926
[Bug 11926] HEA - Report usage statistics to Koha community
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 11:53:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 10:53:59 +0000
Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha
	community
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17803


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17803
[Bug 17803] Hea - collect number of libraries per installation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 12:45:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 11:45:54 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|julian.maurice at biblibre.com |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart  ---
I am going to rework this code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 12:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 11:46:01 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 13:27:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 12:27:53 +0000
Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks for the followup Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:01:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:01:54 +0000
Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58303|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi  ---
Created attachment 58338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58338&action=edit
Bug 17785: Fix OAI-PMH's XSLT-generated URLs under Plack

Look at e.g. the URL for Show More at the end of the output of Records or
Identifiers. If you use Plack, you will see that it refers to
yourserver:/opac/oai.pl, which is not correct.

This is caused by using CGI's self_url in combination with script alias,
mounting point, etc. Note that we cannot solve this problem in the code of
Koha only. Since HTTP::OAI modules also call self_url, we still end up
with some wrong url's.

Instead of a larger architectural operation on Apache and Plack config files,
this patch adjusts the final xslt transformation on the OAI response.
It hardcodes the correct path only once, in a xslt variable. And replaces
all oai:OAI-PMH/oai:request/text() calls, containing wrong URLs, by this
variable.

Test plan:
Run oai.pl. Try the various verbs.
Verify that the URLs point to /cgi-bin/koha/oai.pl.

Edit: changed commit subject

Signed-off-by: Tomas Cohen Arazi 
Works as expected. Good workaround until a definitive solution is implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:01:51 +0000
Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:13:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:13:12 +0000
Subject: [Koha-bugs] [Bug 17804] New: Remove some modules from
	showdiffmarc.pl
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

            Bug ID: 17804
           Summary: Remove some modules from showdiffmarc.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:19:53 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:19:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:19:55 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

--- Comment #1 from Marcel de Rooy  ---
Created attachment 58339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58339&action=edit
Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:20:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:20:33 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:42:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:42:48 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55773|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart  ---
Created attachment 58340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58340&action=edit
Bug 14608: Add a page to configure shared statistics

This patch set adds:
- a reference to Hea at the end of the installation process
- a link to the new page from the admin home page
- a new page to easily configure shared statistics

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:42:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:42:53 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #14 from Jonathan Druart  ---
Created attachment 58341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58341&action=edit
Bug 14608: Add a link from the admin home page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:42:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:42:57 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #15 from Jonathan Druart  ---
Created attachment 58342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58342&action=edit
Bug 14608: Add a reference to Hea at the end of the installer process

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:47:17 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|ASSIGNED                    |Needs Signoff

--- Comment #16 from Jonathan Druart  ---
I have redone this code to make it more attractive.
The goal is to create a new page to configure the information shared by the
libraries with the Koha community.

I'd like help to add more information about 1. how libraries should share them,
2. how and why it is useful for the Koha community to get them

A link to the privacy policy and the license information should also be added
(https://github.com/biblibre/hea-app/pull/13).

Not really ready for a signoff but changing the status to highlight the fact it
is testable anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 14:48:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 13:48:59 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #4 from Magnus Enger  ---
Was this fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 15:25:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 14:25:29 +0000
Subject: [Koha-bugs] [Bug 13706] Deduping authorities script
	(dedup_authorities.pl)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:04:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:04:19 +0000
Subject: [Koha-bugs] [Bug 17805] New: Add new authority type EVENT_TERM
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17805

            Bug ID: 17805
           Summary: Add new authority type EVENT_TERM
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org

The Update No. 23 from November 2016 adds new fields, subfields and a new
authority type: "Named Event". Koha should add a new authority type, for
example EVENT_TERM, and add the new fields (see
http://www.loc.gov/marc/authority/adapndxf.html) to Authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:05:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:05:25 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58333|0                           |1
        is obsolete|                            |

--- Comment #16 from Owen Leonard  ---
Created attachment 58343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58343&action=edit
[SIGNED-OFF] Bug 8630 - Adlibris covers (syspref files)

This patch adds a system preference for cover images from Swedish
book retailer Adlibris. Images are retrieved via http or https
from an external web server. This might leak OPAC and Staff
interface data to third parties and should thus be used with
caution.

Sponsored-By: Halland County Library

Test plan:

Test 1: Test upgrade procedure for clean installation.

  Start by removing existing sysprefs, if present:

  $ mysql -u kohaadmin -p -D koha
  > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

* Apply this patch which will add a pref file, update the 'syspref'
  structure and add an atomic upgrade file.

* Install the update:
  Koha$ perl installer/data/mysql/updatedatabase.pl

* Once upgraded and logged in, Select 'More', 'Administration',
  'Global Preferences' and finally 'Enhanced content'.
  There should be a new option called 'Adlibris'.

  The first option should default to "Don't show", if not the
  patch is broken.

  The second options should show the default URL:
  http://www.adlibris.com/se/organisationer/showimagesafe.aspx

  If not, the patch is broken.

Test 2: Changing sysprefs

* In the control panel, change the first value from "Don't show"
  to "Show" and save the changes. Use MySQL client to inspect changes:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  The column 'value' should now have the value '1', if not the patch
  is broken.

Test 3: Apply update to existing data

* Re-execute the installer now that the database has the data already:
  Koha$ perl installer/data/mysql/updatedatabase.pl

  If any errors occur the patch is broken.

  Examine the database contents:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  If the values were overwritten by the installer the patch is broken.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:05:34 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58334|0                           |1
        is obsolete|                            |

--- Comment #17 from Owen Leonard  ---
Created attachment 58344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58344&action=edit
[SIGNED-OFF] Bug 8630 - Adlibris covers (intranet templates)

Changes to staff interface (intranet) templates.
Depends on new CSS clases defined in separate patch.

Test plan:

To test this particular patch (intranet templates) you need:
* The syspref patch applied
* The intranet CSS patch applied

To test:
* Apply this patch

* Enable covers (if not done already)
  * Go to staff interface, log in as a priviliged user.
  * Select "More" -> "Administration" ->
    "Global system preferences" -> "Enhanced content".
  * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris".
  * Save changes

* Add a book with a known cover/ISBN (if none exists)
  * Set MARC field 020 a,
    "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935
  * Set MARC field 245 a, "Title" to: 1984
  * Save changes

* Test results.tt
  * From the main intranet page, select "Search the catalog" and
    enter the title we added, "1984" and press "Search".
  * You should end up with the url:
    http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984
  * The cover image should be shown in the leftmost column.
  * If cover is clicked, the full cover image should be shown.

* Test detail.tt
  (continue from the search results used in prev. test)
  * Click on the title text, you should be sent to:
    http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2
  * The cover image should be shown on the right.
  * If clicked, the full cover should be shown.

Sponsored-By: Halland County Library

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:05:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:05:41 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58335|0                           |1
        is obsolete|                            |

--- Comment #18 from Owen Leonard  ---
Created attachment 58345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58345&action=edit
[SIGNED-OFF] Bug 8630 - Adlibris covers (intranet CSS)

This defined two new CSS classes for use by the intranet templates.
Apply this patch before doing the testing of "intranet templates".

Sponsored-By: Halland County Library

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:05:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:05:50 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58336|0                           |1
        is obsolete|                            |

--- Comment #19 from Owen Leonard  ---
Created attachment 58346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58346&action=edit
[SIGNED-OFF] Bug 8630 - Adlibris covers (OPAC templates)

Changes to OPAC templates.
Depends on new CSS clases defined in separate patch.

Test plan:

To test this particular patch (intranet templates) you need:
* The syspref patch applied
* The intranet CSS patch applied

To test:
* Apply this patch

* Enable covers (if not done already)
  * Go to staff interface, log in as a priviliged user.
  * Select "More" -> "Administration" ->
        "Global system preferences" -> "Enhanced content".
  * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris".
  * Save changes

* Add a book with a known cover/ISBN (if none exists)
  * Set MARC field 020 a,
        "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935
  * Set MARC field 245 a, "Title" to: 1984
  * Save changes

* Test opac-results.tt
  * Search library catalog from OPAC for "1984".
  * You should be sent to:
    http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984
  * Cover image should be shown to the right of each title
    with CSS class: "adlibris-cover"

* Test opac-detail.tt
  (continued from previous test's location)
  * Click on the title with cover (1984, ISBN: 9780451524935)
  * Cover should be displayed to the left in full size.
  * If clicked, should link to the full-size image.

Test opac-results-grouped.tt
  * This template is only used if an external "grouping" server is
    setup and the syspref "OPACGroupResults" is set to "Use".
  * Personally I did not test this, b/c: terminally lazy

* Test opac-showreviews.tt
  * Could not find any links to this location, manually enter it:
    http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl
  * Image should be shown to the right in full size.
  * If clicked it should take you to the detail view with the
    comments tab opened.

* Test opac-showreviews-rss.tt
  * Click on the RSS icon from previous test's start location.
    URL should be:
    http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss
  * An image tag linking to the full-size image without any
    styling class should be present.

* Test opac-user.tt
  * Click on your username to open:
    http://127.0.1.1/cgi-bin/koha/opac-user.pl
  * Covers should be shown for checked out items with
    CSS class: adlibris-cover
  * When clicked the destination should be the same as
    clicking the title column entry: opac-details.pl

* Test opac-opensearch.tt
  * Click on "Advanced search" and enter "1984" then press "Search"
  * This search screen uses a different template.
  * Cover image should be shown to the right of each title
    with CSS class: "adlibris-cover"
  * If clicked, should link to the OPAC detail view.

* Test opac-readingrecord.tt
  * Click on your logged-in name to go to your personal page.
  * Click on "Your reading history" tab on the left.
    http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl
  * Covers should be shown in leftmost column with
    CSS class: adlibris-cover
  * If clicked, should link to the same as the 'Title' link.

Sponsored-By: Halland County Library

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:06:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:06:00 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58337|0                           |1
        is obsolete|                            |

--- Comment #20 from Owen Leonard  ---
Created attachment 58347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58347&action=edit
[SIGNED-OFF] Bug 8630 - Adlibris covers (OPAC less changes)

This patch adds two new CSS classes specific to Adlibris covers.

Sponsored-By: Halland County Library

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:08:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:08:06 +0000
Subject: [Koha-bugs] [Bug 17806] New: If loan period is shortened to patron
 exiry date, use last possible opening day of the library
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17806

            Bug ID: 17806
           Summary: If loan period is shortened to patron exiry date, use
                    last possible opening day of the library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When the loan period is shortened to the patron expiry date (syspref
ReturnBeforeExpiry) it's possible that the due date falls on a day the library
is closed.

If the loan period is shortened, the due date should always be the last
possible day the library is open before the patron expires.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:15:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:15:54 +0000
Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and
	Intranet
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:22:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:22:22 +0000
Subject: [Koha-bugs] [Bug 17807] New: Use XSLT_Handler in oai.pl
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807

            Bug ID: 17807
           Summary: Use XSLT_Handler in oai.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:33:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:33:27 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807

--- Comment #1 from Marcel de Rooy  ---
Created attachment 58348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58348&action=edit
Bug 17807: Add format parameter to XSLT_Handler->transform

Format may be chars (default), bytes or xmldoc.
Note: xmldoc is a XML::LibXML document object.
Since the default is chars, this does not affect current use.

Note: The format parameter (xmldoc) will be used later in one of the OAI
modules to prevent duplicated xml parsing.

Test plan:
Run t/db_dependent/XSLT_Handler.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:33:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:33:43 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:52:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:52:30 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807

--- Comment #2 from Marcel de Rooy  ---
Created attachment 58349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58349&action=edit
Bug 17807: Use XSLT_Handler in Koha::OAI

Replacing some code in the OAI modules by a call to an existing module.
Note that the xmldoc format is used in the transform call to get a xml
document object.

The stylesheet method of Repository now only returns the name of the xsl
file to be used instead of a cached xslt object. Similar functionality
inside XSLT_Handler is used when calling transform.

Note: We still lack unit tests in this area. I did not see the need for
adding something for stylesheet since it only returns a simple string.
The other change is made in Record::new; there are no tests for this
module yet and the heart of the change here is actually tested already
in XSLT_Handler.t.

Note: I benchmarked calls to Repository in the old and the new situation
and did not see significant changes.

Test plan:
[1] Run t/db_dependent/Koha/OAI/Server.t
[2] Run oai.pl with ListRecords and marcxml.
[3] Run oai.pl with ListRecords and oai_dc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:52:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:52:44 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792
[Bug 17792] Introduce Koha::Patron::Attribute(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:52:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:52:44 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
[Bug 13757] Make patron attributes editable in the opac if set to 'editable in
OPAC'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:54:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:54:58 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #34 from Owen Leonard  ---
I think this is a great new feature. A few issues and suggestions:

- The preference should be retrieved via the template instead of in the Perl
script:

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7:_use_system_preference_TT_plugin

- The date in the checkin message should be formatted using the KohaDates
plugin.
- On the circulation page, I think it makes more sense to put the patron note
in the column which shows the "Checked in" message since that's where the
librarian would be looking for confirmation of the transaction.

Since there is no way to find out what note was attached to something you just
checked in on returns.pl, I wonder if the notification shouldn't work the same
as the hold notice: In a blocking modal?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:56:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:56:06 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 58350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58350&action=edit
Bug 17792: Introduce Koha::Patron::Attribute(s)

This patch introduces stub Koha::Object(s) for handling patron attributes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:56:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:56:03 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:56:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:56:47 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:59:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:59:27 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58252|0                           |1
        is obsolete|                            |

--- Comment #39 from Tom?s Cohen Arazi  ---
Created attachment 58351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58351&action=edit
Bug 13757: Add the option to set patron attributes editable in the OPAC

Note: this is a squashed version of the original patchset, because it was
needed

This patch adds an opac_editable property of borrower attribute types
that can be set in the interface. I'm removing work on OPAC and will
refactor it, keeping the author attribution.

Test plan:
  1. Repeat the following with a new and existing borrower attribute
     type:
  2. Verify that "Editable in OPAC" can only be checked if "Display in
     OPAC" is checked.
  3. Verify that this new property is correctly saved.

Signed-off-by: Aleisha 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:59:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:59:36 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58253|0                           |1
        is obsolete|                            |

--- Comment #40 from Tom?s Cohen Arazi  ---
Created attachment 58352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58352&action=edit
Bug 13757: DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:59:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:59:43 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58254|0                           |1
        is obsolete|                            |

--- Comment #41 from Tom?s Cohen Arazi  ---
Created attachment 58353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58353&action=edit
Bug 13757: OPAC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 16:59:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 15:59:51 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58255|0                           |1
        is obsolete|                            |

--- Comment #42 from Tom?s Cohen Arazi  ---
Created attachment 58354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58354&action=edit
Bug 13757: DBIC update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:00:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:00:05 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #43 from Tom?s Cohen Arazi  ---
Created attachment 58355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58355&action=edit
Bug 13757: Add extended attributes to the patron modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:00:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:00:15 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #44 from Tom?s Cohen Arazi  ---
Created attachment 58356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58356&action=edit
Bug 13757: (followup) Remove warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:00:24 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #45 from Tom?s Cohen Arazi  ---
Created attachment 58357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58357&action=edit
Bug 13757: (followup) Staff interface changes

This patch adds proper extended attributes display and handling on the
patron modifications moderation page (members-update.pl).

It also adds changes checking to the opac-memberentry.pl page so it
only saves a modification request if there are changes (it only checked
regular fields and not the extended ones).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:02:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:02:41 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58256|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi  ---
Created attachment 58358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58358&action=edit
Bug 17767: Add borrower_modification.extended_attributes

This patch changes the DB structure adding
borrower_modifications.extended_attributes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:02:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:02:46 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58257|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi  ---
Created attachment 58359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58359&action=edit
Bug 17767: DBIC update

This patch can be skipped by the RM, it just updates the DBIC schema files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:02:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:02:51 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58258|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi  ---
Created attachment 58360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58360&action=edit
Bug 17767: Make Koha::Patron::Modification handle extended attributes

This patch makes Koha::Patron::Modification aware of the new
extended_attributes
column, which is expected to contain valid JSON data.

The ->store method is modified so it validates the field value (i.e. the
content
is decoded using the JSON library) and raises a convenient exception in case of
failure.

This behaviour change is covered by the provided unit tests.

To test:
- Apply the patchset
- Run:
  $ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: Tests make sense, and they pass
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:02:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:02:56 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58259|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi  ---
Created attachment 58361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58361&action=edit
Bug 17767: Unit tests

This patch introduces tests for the new behaviour, and also
enhances the existing ones aiming to reach full coverage.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:03:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:03:01 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58260|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi  ---
Created attachment 58362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58362&action=edit
Bug 17767: (followup) Rename test file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:12:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:12:24 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard  ---
Looks good to me, but found one missing:

sms_providers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:35:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:35:09 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:35:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:35:12 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58329|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 58363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58363&action=edit
[SIGNED-OFF] Bug 17799: MARC bibliographic frameworks breadcrumbs broken for
Default framework

To test:
1) Go to Admin -> MARC frameworks -> Default framework actions -> MARC
structure
2) Click New tag
3) Notice the breadcrumbs say '()' instead of 'Default MARC framework'
or something more appropriate
4) Apply patch and refresh page
5) Confirm breadcrumbs are now filled correctly
6) Go back to tag structure and try deleting a tag (Actions -> Delete)
7) Confirm breadcrubs are filled correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:44:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:44:51 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 17:44:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 16:44:54 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58332|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 58364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58364&action=edit
[SIGNED-OFF] Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 18:14:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 17:14:45 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #17 from Owen Leonard  ---
I would like to see a new last step at the end of the installation process
where the usage statistics preferences could be saved directly. That is, show
the whole form from admin/usage_statistics.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 18:41:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 17:41:14 +0000
Subject: [Koha-bugs] [Bug 12941] batch enable/disable courses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941

Brendon Ford  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendon.ford at manhattan.edu

--- Comment #3 from Brendon Ford  ---
This would be a very welcome feature for us as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 19:54:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 18:54:23 +0000
Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an
	authentication method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486

--- Comment #4 from Chris Cormack  ---
Looks ok to me, sad to see what was a great idea disappear.

But we have gluu to look at now https://www.gluu.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:32:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:32:12 +0000
Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with
 hold(s) over report
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744

Brendan Gallagher  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:59:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:59:11 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58358|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard  ---
Created attachment 58365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58365&action=edit
[SIGNED-OFF] Bug 17767: Add borrower_modification.extended_attributes

This patch changes the DB structure adding
borrower_modifications.extended_attributes

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:59:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:59:18 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58359|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard  ---
Created attachment 58366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58366&action=edit
[SIGNED-OFF] Bug 17767: DBIC update

This patch can be skipped by the RM, it just updates the DBIC schema files.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:59:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:59:26 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58360|0                           |1
        is obsolete|                            |

--- Comment #13 from Owen Leonard  ---
Created attachment 58367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58367&action=edit
[SIGNED-OFF] Bug 17767: Make Koha::Patron::Modification handle extended
attributes

This patch makes Koha::Patron::Modification aware of the new
extended_attributes
column, which is expected to contain valid JSON data.

The ->store method is modified so it validates the field value (i.e. the
content
is decoded using the JSON library) and raises a convenient exception in case of
failure.

This behaviour change is covered by the provided unit tests.

To test:
- Apply the patchset
- Run:
  $ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: Tests make sense, and they pass
- Sign off :-D

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:59:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:59:32 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58361|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard  ---
Created attachment 58368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58368&action=edit
[SIGNED-OFF] Bug 17767: Unit tests

This patch introduces tests for the new behaviour, and also
enhances the existing ones aiming to reach full coverage.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 20:59:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 19:59:38 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58362|0                           |1
        is obsolete|                            |

--- Comment #15 from Owen Leonard  ---
Created attachment 58369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58369&action=edit
[SIGNED-OFF] Bug 17767: (followup) Rename test file

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:00:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:00:26 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

--- Comment #16 from Owen Leonard  ---
Passes the test plan, in which it passes the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:13:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:13:42 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #46 from Owen Leonard  ---
I tested this with a patron record which had two attributes with data already
stored: One editable in the OPAC, the other not.

When I edited the one, it cleared out the other. So the patron modification
request in the staff client looked like this:

Old value
Attr1: OldValue1 <-- not editable in OPAC
Attr2: OldValue2 <-- editable in OPAC

New value

Attr2: NewValue2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:26:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:26:33 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:26:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:26:35 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58339|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 58370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58370&action=edit
[SIGNED-OFF] Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:41:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:41:17 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Viccy Kemp  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victoria.kemp at flower-mound.
                   |                            |com

--- Comment #20 from Viccy Kemp  ---
Flower Mound Public Library has noticed that reserves DO NOT TAKE INTO ACCOUNT
closed holidays. What exactly is the point of marking up a calendar if the
software does not know what to do with it. That is nuts. We have been live on
Koha for four and a half months now and during both Thanksgiving and now
Christmas the closed days are not being accounted for in the holds. Please,
someone, figure out how to make this work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:48:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:48:27 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|aleishaamohia at hotmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:52:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:52:05 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:52:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:52:08 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58327|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia  ---
Created attachment 58371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58371&action=edit
Bug 17793: Make sysprefs search show on all Admin pages

This patch is amended to use the sysprefs search on all Administration
pages that do not have their own custom search.

To test:
1) Go to Administration
2) Notice Catalogue search at the top - seems out of place.
3) Apply patch and refresh page.
4) Notice admin / sysprefs search now shows and is more appropriate.
5) Confirm searching for sysprefs still works

This patch affects the following pages:
- admin-home.pl
- audio_alerts.pl
- authtypes.pl
- auth_tag_structure.pl
- authorised_values.pl
- biblio_framework.pl
- marctagstructure.pl
- branch_transfer_limits.pl
- branches.pl
- checkmarc.pl
- classsources.pl
- columns_settings.pl
- didyoumean.pl
- edi_accounts.pl
- edi_ean_accounts.pl
- fieldmapping.pl
- item_circulation_alerts.pl
- items_search_fields.pl
- items_search_field.pl
- item_types.pl
- koha2marklinks.pl
- matching-rules.pl
- oai_sets.pl
- oai_set_mappings.pl
- patron-attr-types.pl
- smart-rules.pl
- transport-cost-matrix.pl
- sms_providers.pl

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 21:56:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 20:56:09 +0000
Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve
 expiration to skip all holidays
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Viccy Kemp  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victoria.kemp at flower-mound.
                   |                            |com

--- Comment #20 from Viccy Kemp  ---
Flower Mound Public Library has noticed that reserves DO NOT TAKE INTO ACCOUNT
closed holidays. What exactly is the point of marking up a calendar if the
software does not know what to do with it. That is nuts. We have been live on
Koha for four and a half months now and during both Thanksgiving and now
Christmas the closed days are not being accounted for in the holds. Please,
someone, figure out how to make this work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 23:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 22:34:38 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 23:34:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 22:34:41 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58326|0                           |1
        is obsolete|                            |

--- Comment #35 from Aleisha Amohia  ---
Created attachment 58372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58372&action=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database - perl installer/data/mysql/updatedatabase.pl
3) (You may have to rebuild schema but I think the patch should apply
    the schema changes for you)
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
    out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the "Date due" column for
the two items you checked in, and are accurate to the item (i.e. the
right issue note under the right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows and the date is formatted correctly.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 21 23:38:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 21 Dec 2016 22:38:17 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #36 from Aleisha Amohia  ---
Hi Owen,

(In reply to Owen Leonard from comment #34)
> I think this is a great new feature. A few issues and suggestions:
> 
> - The preference should be retrieved via the template instead of in the Perl
> script:
> 
> https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7:
> _use_system_preference_TT_plugin
> 
> - The date in the checkin message should be formatted using the KohaDates
> plugin.
> - On the circulation page, I think it makes more sense to put the patron
> note in the column which shows the "Checked in" message since that's where
> the librarian would be looking for confirmation of the transaction.
>

I have implemented all these changes in the latest patch.

> Since there is no way to find out what note was attached to something you
> just checked in on returns.pl, I wonder if the notification shouldn't work
> the same as the hold notice: In a blocking modal?

I am working on a follow-up feature in Bug 17698 that allows a 'seen' system
for the patron notes - similar to how we approve tags and comments made in the
OPAC. I think this suggestion would be best implemented in that patch rather
than this one if that's okay with you (would like to get this signed off and
passed so I can finish 17698)!

Thanks
Aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 01:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 00:09:21 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #47 from Tom?s Cohen Arazi  ---
Thanks for testing! I'll fix it tomorrow!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:06:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:06:08 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

PTFS Europe Sandboxes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at ptfs-europe.com
             Status|Needs Signoff               |Signed Off

--- Comment #17 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by Eugene Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:06:30 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

PTFS Europe Sandboxes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57111|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:06:35 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

PTFS Europe Sandboxes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57112|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:06:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:06:40 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

PTFS Europe Sandboxes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57113|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:07:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:07:06 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #18 from PTFS Europe Sandboxes  ---
Created attachment 58373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58373&action=edit
Bug 16892: Add automatic patron registration via OAuth2 login

10988 added the ability to log into the OPAC authenticating with
Google Open ID Connect. This extends it, by allowing an
unregistered patron to have an account automatically created
with default category code and branch.

This is accomplished by adding 3 system preferences.
- GoogleOpenIDConnectAutoRegister
      whether it will attempt to auto-register the patron.
- GoogleOpenIDConnectDefaultCategory
      This category code will be used to create Google OpenID Connect patrons.
- GoogleOpenIDConnectDefaultBranch'
      This branch code will be used to create Google OpenID Connect patrons.

Sponsored-by: Tulong Aklatan

Signed-off-by: Eugene Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:07:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:07:09 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #19 from PTFS Europe Sandboxes  ---
Created attachment 58374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58374&action=edit
Bug 16892: System Preferences

This adds the missing system preferences for a fresh install.

Signed-off-by: Eugene Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 06:07:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 05:07:12 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #20 from PTFS Europe Sandboxes  ---
Created attachment 58375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58375&action=edit
Bug 16892: Follow up with adding missing IGNORE

Signed-off-by: Eugene Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 11:06:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 10:06:40 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #50 from Matthias Meusburger  ---
Hi,

I couldn't reproduce any of the problems you mentioned on my Unimarc instance,
so I ended up setting up a MARC21 instance using your values for the syspref
and your marc files, and... I couldn't reproduce any of the problems (see
screen captures), except one:

BOOKBAG itype is indeed not automatically selected, but this is because there
is a trailing space in the BOOKBAG 975$c in your MARC file.

I don't know if Koha should assume that a trailing space in a field is
irrelevant and remove it, but the fact is that they are not technically equal.
So, no pre-selection.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 11:09:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 10:09:47 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #51 from Matthias Meusburger  ---
Created attachment 58376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58376&action=edit
Import screen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 11:10:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 10:10:09 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #52 from Matthias Meusburger  ---
Created attachment 58377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58377&action=edit
Items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 11:25:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 10:25:27 +0000
Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web
	crawlers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

Jos? Anjos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joseanjos at gmail.com

--- Comment #6 from Jos? Anjos  ---
I added file robots.txt to /usr/share/koha/opac/htdocs, but makes no
difference.
I've try it too on /usr/share/koha/opac/htdocs/opac-tmpl but problem persists.
I have non stop requests from SemrushBot, AhrefsBot and Google.
Server is getting high CPU usage and out of memory every 2/3 days
I want to kill that bots...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 12:06:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 11:06:18 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

David Gustafsson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #1 from David Gustafsson  ---
I'm currently looking into this as well. I came to the conclusion that the
AddItemBatchFromMarc branch should really be executed on insert. The
sub-documentation states that:

"The goal of this API is to have a similar effect to using AddBiblio
and AddItems in succession, but without inefficient repeated
parsing of the MARC XML bib record."

So it feels strange that is is run on update. Besides, I can't imagine a
scenario where you would want to overwrite existing holdings items? I'm no
librarian so some input on the practical aspects of this would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 12:08:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 11:08:22 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #2 from David Gustafsson  ---
lost a word: *should really ONLY be executed on insert

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 12:28:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 11:28:27 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
There is a feature to make it possible to update items matching the barcode or
itemnumber, but I am not sure if this is relevant for bulkmarcimport. It's part
of the staged marc import procedure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 12:51:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 11:51:05 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #53 from Kyle M Hall  ---
(In reply to Matthias Meusburger from comment #50)
> Hi,
> 
> I couldn't reproduce any of the problems you mentioned on my Unimarc
> instance, so I ended up setting up a MARC21 instance using your values for
> the syspref and your marc files, and... I couldn't reproduce any of the
> problems (see screen captures), except one:
> 
> BOOKBAG itype is indeed not automatically selected, but this is because
> there is a trailing space in the BOOKBAG 975$c in your MARC file.
> 
> I don't know if Koha should assume that a trailing space in a field is
> irrelevant and remove it, but the fact is that they are not technically
> equal. So, no pre-selection.

I would agree with that. Koha shouldn't munge the data. If there is a trailing
space it should be dealt with preferably at the source. A couple other
possibilities would be to use a Marc Modification Template or a plugin to clean
up the records.
We shouldn't have magic side effects in Koha. Those types of things lead to
confusion. The next library might rely on a trailing space and have no idea why
it's not working ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 12:59:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 11:59:10 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.05                       |master

--- Comment #13 from Katrin Fischer  ---
I am not sure the version setting here is correct - I tested this on master pre
16.11 release. I am resetting it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:11:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:11:07 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #4 from David Gustafsson  ---
As far as I understand it no matching on barcode is performed in the
marcbulkupdate-script. There is an "dedupebarcode"-option. If an existing
barcode is found, but that does something quite different. If an item with the
same barcode is found, the imported item's barcode is wiped, and imported as a
new item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:17:52 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Katrin Fischer  ---
Git applies the patch, so there should be an existing change. But it doesn't
fix the problem - maybe we need to apply this with some special setting?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:20:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:20:16 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54488|0                           |1
        is obsolete|                            |
  Attachment #54489|0                           |1
        is obsolete|                            |

--- Comment #59 from Kyle M Hall  ---
Created attachment 58378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58378&action=edit
Bug 12904 - Force browser to load new javascript files after upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of "200
   OK" for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the "size" column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   "304 Not Modified." In Chrome the "size" columns should show "from
   cache."
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a "koha_version" query string. These files should
   have a status of "200 OK" indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration -> Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools -> Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog -> Detail page -> MARC Preview (greybox JS)
- Help -> Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:20:29 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #60 from Kyle M Hall  ---
Created attachment 58379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58379&action=edit
Bug 12904 - Update template css and js file references

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:26:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:26:08 +0000
Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated
 templates is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:38:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:38:59 +0000
Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does
 only work in English
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264

--- Comment #9 from Katrin Fischer  ---
This is broken again - see bug 17795.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:43:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:43:33 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:43:36 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57388|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer  ---
Created attachment 58380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58380&action=edit
Bug 16914 - Export csv in item search, exports all items in  one line -
alternate-alternate

Test plan:
0) Do not apply the patch
1) Install any translation
2) Go to item search and choose Output to be CSV
3) Search for at least 2 items in result set, open CSV in text editor
    -> in english, everything is ok
    -> in other languages are all data on one line
4) Apply the patch
5) Repeat steps 1, 2 and 3, CSV should look OK either in english and other
languages
6) Check it does not break Bug 14264 correction

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:43:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:43:49 +0000
Subject: [Koha-bugs] [Bug 11936] bulkmarcimport.pl reports inserted records
	twice
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

David Gustafsson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #1 from David Gustafsson  ---
The second line is for an inserted item i believe. But should be reported as
such. Currently looking into this script and have fixed this in my local
branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:44:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:44:26 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #13 from Katrin Fischer  ---
With this patch German and English exporting of late orders AND item search
results appears to be ok. (see also bug 17795)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:58:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:58:02 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 13:58:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 12:58:06 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58243|0                           |1
        is obsolete|                            |
  Attachment #58244|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer  ---
Created attachment 58381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58381&action=edit
Bug 16951: Fix Item search sorting

Caused by
  commit ac5a1bfececb5400a77f0ebad90181f5215d5a85
    Bug 16154: CGI->multi_param - Manual changes

The change was wrong, we wanted to retrieve a scalar (the string), not
an array.
We want to retrieve a string with the different column' names, not an
array of 1 element.

Test plan:
Launch an item search and play with column sort

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:01:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:01:14 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

--- Comment #6 from Katrin Fischer  ---
Created attachment 58382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58382&action=edit
Bug 16951: Replace some more

In order to avoid warnings in the logs, $cgi->param should be forced to
scalar context

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:04:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:04:55 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:04:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:04:58 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58242|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer  ---
Created attachment 58383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58383&action=edit
Bug 17743: Item search - Fix indexes build on MARC

Searching items by custom search fields does not work because these
fields are not correctly processed in JS.

In case of custom search field, the parent of the option is not the
select but the optgroup element.

Test plan:
Create a custom search field on 245$c for instance
On the items search form, select this field and launch a search
=> Without this patch, the results will not be filtered and you will get
all your items
=> With this patch applied, the results should be correctly filtered

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:16:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:16:17 +0000
Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Katrin Fischer  ---
This is a rather bad bug, can we do something about it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:34:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:34:08 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:34:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:34:10 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58381|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens  ---
Created attachment 58384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58384&action=edit
Bug 16951: Fix Item search sorting

Caused by
  commit ac5a1bfececb5400a77f0ebad90181f5215d5a85
    Bug 16154: CGI->multi_param - Manual changes

The change was wrong, we wanted to retrieve a scalar (the string), not
an array.
We want to retrieve a string with the different column' names, not an
array of 1 element.

Test plan:
Launch an item search and play with column sort

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:34:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:34:15 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58382|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens  ---
Created attachment 58385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58385&action=edit
Bug 16951: Replace some more

In order to avoid warnings in the logs, $cgi->param should be forced to
scalar context

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:42:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:42:41 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:46:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:46:44 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:46:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:46:47 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58383|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens  ---
Created attachment 58386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58386&action=edit
Bug 17743: Item search - Fix indexes build on MARC

Searching items by custom search fields does not work because these
fields are not correctly processed in JS.

In case of custom search field, the parent of the option is not the
select but the optgroup element.

Test plan:
Create a custom search field on 245$c for instance
On the items search form, select this field and launch a search
=> Without this patch, the results will not be filtered and you will get
all your items
=> With this patch applied, the results should be correctly filtered

Signed-off-by: Katrin Fischer 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:57:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:57:33 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56506|0                           |1
        is obsolete|                            |

--- Comment #48 from Lari Taskula  ---
Created attachment 58387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58387&action=edit
Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bugs 16699 and 14868

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 14:59:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 13:59:07 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #49 from Lari Taskula  ---
(In reply to Lari Taskula from comment #48)
> Created attachment 58387 [details] [review]
This patch only changes Koha::Issues to Koha::Checkouts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:01:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:01:43 +0000
Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:01:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:01:46 +0000
Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58275|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 58388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58388&action=edit
Bug 17781 - Improper branchcode set during renewal

For no discernable reason, when AddIssue calls AddRenewal, it passes the
branchcode generated from _GetCircControlBranch. Assume
_GetCircControlBranch is set to return items.homebranch. So:
1) If an item owned by LibraryA is checked out at LibraryB, the
  statistic line branchcode will be LibraryB
2) If an item is renewed via the ajax datatables renewal function, the
  statistic line branchcode will be LibraryB the
3) If an item is renewed via scanning the item into the checkout again,
  statistic line branchcode will be *LibraryA*

This is clearly improper behavior. The renewal is taking place at
LibraryB, so the branchcode passed to AddRenewal should be LibraryB,
the logged in library. This also jives with the documentation for
the subroutine.

Test Plan:
1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary )
2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch
)
3) Create item with homebranch of LibraryA and holdingbranch of LibraryB
4) Set the logged in library to LibraryB
4) Check the item out to a patron at LibraryB
5) Note the statistics line has a branchcode of LibraryB
6) Check the item out again to trigger a renewal, renew the item
7) Note the statistic line has a branchcode of LibraryA!
8) Apply this patch
9) Repeat step 6
10) Note the statistics line has a branchcode of LibraryB!

Signed-off-by: Kyle M Hall 

Signed-off-by: David Kuhn 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:10:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:10:59 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:21:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:21:59 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #16 from Kyle M Hall  ---
All in all I like what you are proposing! Can you add a followup for your
suggestions?

(In reply to Owen Leonard from comment #14)
> Created attachment 58159 [details]
> Proposal for initial state of add guarantor form
> 
> It seems that now the search for patrons to select as a guarantor includes
> patrons with a 'Child' type patron category. Is that intentional? Shouldn't
> they be excluded?
> 
> I notice also that when you select a patron to be a guarantor, the patron
> number is no longer a link to the patron record. I think it would make more
> sense to not show the borrowernumber at all, but make the guarantor name a
> link:
> 
> Surname, Firstname
> (cardnumber)
> 
> I think it's confusing that there are two buttons, 'Add guarantor', 'Set to
> patron.' They could potentially mean the same thing. I think we might have
> the initial state of this form have only two links: 'Search to add
> guarantor' and 'Add guarantor manually' (see attached image).
> 
> Clicking the 'Add manually' link would display the form along with a submit
> button, and the "Clear" link would be shown.
> 
> The manual add form should prevent the user from submitting empty data.
> 
> Sorry, I know that's a lot, and I'm willing to help with follow-ups if folks
> think these are good ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:30:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:30:53 +0000
Subject: [Koha-bugs] [Bug 17808] New: String change,
 message showing for confirm edit rule
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

            Bug ID: 17808
           Summary: String change, message showing for confirm edit rule
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bouzid.fergani at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

very easy, just change string showing when edit rule
for reproduce:
   1- Administration
   2- Circulation and fines rules
   3- When try to edit any rule, you have the message :
          Are you sure you want to edit another rule?
The new message is : Are you sure you want to edit this rule ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:35:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:35:04 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hm, I feel like the bug is that it shows when you first pick a rule - it should
only show when you change editing to another without saving first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:39:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:39:15 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

--- Comment #2 from Bouzid  ---
Created attachment 58389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58389&action=edit
Bug 17808: String change - message showing for rule edit confirmation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:39:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:39:41 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Bouzid  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:42:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:42:26 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Bouzid  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:42:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:42:47 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Bouzid  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |francois.charbonnier at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 15:43:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 14:43:23 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Bouzid  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |francois.charbonnier at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:02:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:02:37 +0000
Subject: [Koha-bugs] [Bug 17809] New: ER country in fr-FR database files
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

            Bug ID: 17809
           Summary: ER country in fr-FR database files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is
defined twice, for "?rythr?e" (correct one) and "Allemagne".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:02:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:02:49 +0000
Subject: [Koha-bugs] [Bug 17809] ER country in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:03:03 +0000
Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ER country in fr-FR         |ER country twice in fr-FR
                   |database files              |database files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:07:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:07:20 +0000
Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:07:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:07:22 +0000
Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 58390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58390&action=edit
Bug 17809 - ER country twice in fr-FR database files

In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is
defined twice, for "Erythr?e" (correct one) and "Allemagne".

Test plan :
- Create a new database using fr-FR or import the sql file
- Look at authorised values COUNTRY
=> without patch you have ER / Allemange
=> with patch you have ER / Erythr?e

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:32:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:32:14 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58202|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall  ---
Created attachment 58391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58391&action=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:42:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:42:44 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #61 from Kyle M Hall  ---
Created attachment 58392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58392&action=edit
Bug 12904 [QA Followup] - Don't send 301 status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:54:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:54:38 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:54:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:54:41 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58378|0                           |1
        is obsolete|                            |

--- Comment #62 from Nick Clemens  ---
Created attachment 58393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58393&action=edit
Bug 12904 - Force browser to load new javascript files after upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of "200
   OK" for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the "size" column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   "304 Not Modified." In Chrome the "size" columns should show "from
   cache."
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a "koha_version" query string. These files should
   have a status of "200 OK" indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration -> Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools -> Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog -> Detail page -> MARC Preview (greybox JS)
- Help -> Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:54:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:54:47 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58379|0                           |1
        is obsolete|                            |

--- Comment #63 from Nick Clemens  ---
Created attachment 58394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58394&action=edit
Bug 12904 - Update template css and js file references

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:54:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:54:54 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58392|0                           |1
        is obsolete|                            |

--- Comment #64 from Nick Clemens  ---
Created attachment 58395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58395&action=edit
Bug 12904 [QA Followup] - Don't send 301 status

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:55:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:55:44 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58380|0                           |1
        is obsolete|                            |

--- Comment #14 from Tom?s Cohen Arazi  ---
Created attachment 58396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58396&action=edit
Bug 16914: Rely on TT for newlines

The translation scripts have an historical tendency to chomp newlines
and we introduced an empty_line.inc file to force newlines when building
CSV output out of our templates (in item search and late orders).

This patch makes the mentioned templates use TT ability to force newlines
plus some misuses of the 'minus' sign.

Test plan:
- Apply the patch
- Do an item search that returns more than one result
- Export as CSV
=> SUCCESS: The CSV file is correctly formed.
- Install any translation:
  $ sudo koha-shell kohadev
 k$ cd kohaclone/misc/translator
 k$ perl translate install 
- Enable  (e.g. es-ES)
- Repeat the item search
- Export as CSV
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Have more than one late orders (bummer)
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed.
- Switch language
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 16:55:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 15:55:51 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #15 from Tom?s Cohen Arazi  ---
Created attachment 58397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58397&action=edit
Bug 16914: Remove unused empty_lines.inc file

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:04:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:04:43 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #16 from M. Tompsett  ---
While the concept is good. I'm suspect of the missing -'s and added +'s in all
the right spots. And my kohadevbox hates me, so testing is going horribly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:19:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:19:23 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57594|0                           |1
        is obsolete|                            |

--- Comment #4 from Koha Team Lyon 3  ---
Created attachment 58398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58398&action=edit
Bug 17649 - Only one message per borrower and overdue level

The patch had been modified to be compatible with bug 17470.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:19:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:19:44 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #5 from David Gustafsson  ---
Have now investigated this further, and as far as I'm concerned it it a bit of
a mess.

- When a record is inserted, the AddBiblio is called, which do not call
"_strip_item_fields" (more on this later). AddItemBatchFromMarc is later
called, and the items contained in the imported marc record are created.

- If the import is run a second time, and if the record is correctly matched
with the previously created one, ModBiblio is called instead. Inside of
ModBiblio _strip_item_fields is called (this is important). When
"AddItemBatchFromMarc" is later called, the items have been stripped, so they
are never again processed (as far as I understand it). If you remove the
(holdings) items in Koha, and run the import again, still no items. I'm working
with a modified script, so I will have to verify this behaviour with the
original. But seems odd to me.

ModBiblioMarc is also called unnecessarily for updated items (it has already
been called in ModBiblio). So this invocation should be done a in different
logical branch for new records insertion.

So to sum things up, if I have understood the code correctly:

- Right now, items are ever only created on insert (and the deduplication logic
is only used here, does not apply for updates).

- This should be separated into a separate logical branch, and not called also
for updates (since it is bad for performance, and very confusing if trying to
understand the code).

Besides, nowhere is the items inserted back into the marcxml. I don't know if
this is by design, but could be a possible bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:20:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:20:23 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:21:39 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17470

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:21:39 +0000
Subject: [Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with
 the SAME list of ALL overdue items if a patron has overdue items from X
 branches
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17649

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:23:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:23:34 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #17 from M. Tompsett  ---
(In reply to M. Tompsett from comment #16)
> While the concept is good. I'm suspect of the missing -'s and added +'s in
> all the right spots. And my kohadevbox hates me, so testing is going
> horribly.

I couldn't get my kohadevbox nor my non-kohadevbox to output fr-FR search
results on a new line in the CSV.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:28:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:28:51 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #18 from M. Tompsett  ---
(In reply to M. Tompsett from comment #17)
> (In reply to M. Tompsett from comment #16)
> > While the concept is good. I'm suspect of the missing -'s and added +'s in
> > all the right spots. And my kohadevbox hates me, so testing is going
> > horribly.
> 
> I couldn't get my kohadevbox nor my non-kohadevbox to output fr-FR search
> results on a new line in the CSV.

DOH! Translation issues!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:36:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:36:17 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58391|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall  ---
Created attachment 58399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58399&action=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 18:37:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 17:37:57 +0000
Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web
	crawlers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

--- Comment #7 from Fred P  ---
I don't believe this is a Koha issue. Any public site can be "hit" by any user.
Blocking Chinese search giant Baidu makes a big difference. Disallow their
robots and you will get a lot less hits. You can also block by ip address range
by editing your Apache .htaccess file. Keep in mind that you want to back that
file up before making changes and take precautions to not block your own
access!

In the .htaccess for the appropriate site directory, blocking range 180.76
would disable baidu search engines:

order allow,deny
#partial ip addresses blocking
deny from 180.76

Adding this to your root directory as a robots.txt file should warn off Yandex
and Baidu robots, however spiders change and respect for the robots.txt varies:

#Baiduspider
User-agent: Baiduspider
Disallow: /

#Yandex
User-agent: Yandex
Disallow: /

It looks like Chris' proposals were adopted. Does this bug need to remain open?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:02:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:02:35 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

--- Comment #3 from Katrin Fischer  ---
I still think the bug is not the text, it's the behaviour. I even think it used
to work differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:02:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:02:54 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:18:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:18:04 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:18:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:18:08 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58396|0                           |1
        is obsolete|                            |
  Attachment #58397|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer  ---
Created attachment 58400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58400&action=edit
Bug 16914: Rely on TT for newlines

The translation scripts have an historical tendency to chomp newlines
and we introduced an empty_line.inc file to force newlines when building
CSV output out of our templates (in item search and late orders).

This patch makes the mentioned templates use TT ability to force newlines
plus some misuses of the 'minus' sign.

Test plan:
- Apply the patch
- Do an item search that returns more than one result
- Export as CSV
=> SUCCESS: The CSV file is correctly formed.
- Install any translation:
  $ sudo koha-shell kohadev
 k$ cd kohaclone/misc/translator
 k$ perl translate install 
- Enable  (e.g. es-ES)
- Repeat the item search
- Export as CSV
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Have more than one late orders (bummer)
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed.
- Switch language
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:20:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:20:15 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #20 from Katrin Fischer  ---
Created attachment 58401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58401&action=edit
Bug 16914: Remove unused empty_lines.inc file

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:21:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:21:57 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:22:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:22:02 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58400|0                           |1
        is obsolete|                            |

--- Comment #21 from Nick Clemens  ---
Created attachment 58402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58402&action=edit
Bug 16914: Rely on TT for newlines

The translation scripts have an historical tendency to chomp newlines
and we introduced an empty_line.inc file to force newlines when building
CSV output out of our templates (in item search and late orders).

This patch makes the mentioned templates use TT ability to force newlines
plus some misuses of the 'minus' sign.

Test plan:
- Apply the patch
- Do an item search that returns more than one result
- Export as CSV
=> SUCCESS: The CSV file is correctly formed.
- Install any translation:
  $ sudo koha-shell kohadev
 k$ cd kohaclone/misc/translator
 k$ perl translate install 
- Enable  (e.g. es-ES)
- Repeat the item search
- Export as CSV
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Have more than one late orders (bummer)
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed.
- Switch language
- Go to late orders
- Choose them
- Export as CSV (in english)
=> SUCCESS: The CSV file is correctly formed in your chosen language.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 19:22:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 18:22:10 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58401|0                           |1
        is obsolete|                            |

--- Comment #22 from Nick Clemens  ---
Created attachment 58403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58403&action=edit
Bug 16914: Remove unused empty_lines.inc file

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:02:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:02:46 +0000
Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett  ---
Looking closer, please check: CC, ER, GQ, and PK as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:09:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:09:13 +0000
Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #3 from M. Tompsett  ---
And confirm qualif 370 values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:16:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:16:22 +0000
Subject: [Koha-bugs] [Bug 17790] Fix js error on undefined
 autocomplete(...).data(...) in js_includes.inc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Katrin Fischer  ---
js_includes.inc was introduced by bug 17416 which is not in 16.11.x - bug fix
is not needed in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:16:23 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
Bug 14570 depends on bug 17790, which changed state.

Bug 17790 Summary: Fix js error on undefined autocomplete(...).data(...) in js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17790

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:19:03 +0000
Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to
	Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:19:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:19:24 +0000
Subject: [Koha-bugs] [Bug 17796] Koha::Issues should be moved to
	Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:22:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:22:31 +0000
Subject: [Koha-bugs] [Bug 17692] Can't add library EAN under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17692

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:27:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:27:21 +0000
Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly
 for most columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:28:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:28:09 +0000
Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not
 work in item' s search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 20:29:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 19:29:58 +0000
Subject: [Koha-bugs] [Bug 17447] Housekeeping: Tidy up
	misc/batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #3 from M. Tompsett  ---
Comment on attachment 56578
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56578
Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl

Review of attachment 56578:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17447&attachment=56578)
-----------------------------------------------------------------

::: misc/batchRebuildItemsTables.pl
@@ +35,3 @@
>  my $starttime = gettimeofday;
>  my @errors;
>  my %opt;

Is this even used?

@@ +43,4 @@
>      'where:s' => \$where,
>  ) or pod2usage(2);
>  
> +pod2usage(1) if $help || ( !$confirm && !$test_parameter );

Tweaks and whitespace changes should be separate commits to make it easier to
check.
git diff -w origin/master pointed out this and a couple others.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 21:26:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 20:26:19 +0000
Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in
 the result set and there is no logged in user
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764

Brendan Gallagher  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the 17.05 release!  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 21:28:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 20:28:17 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Brendan Gallagher  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #23 from Brendan Gallagher  ---
Pushed to Master - Should be in the 17.05 release - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 22:09:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 21:09:59 +0000
Subject: [Koha-bugs] [Bug 17810] New: Add a button to navigate between
	notices
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810

            Bug ID: 17810
           Summary: Add a button to navigate between notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alexandre.breton at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org

Created attachment 58404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58404&action=edit
The small window in the upper left circled in red

It will be interessting to have the option to navigate directly between notices
(previous/next). The option already exist in catalog module. Maybe, it can be
added into another module ?

1)From the start, go to lists
2)Take "public list" and enter a search
3)Select any notice to have all his details on screen
4)Observe that you cannot reach another notice of your search without making
"previous page"

After some searches here, the patch doesn't seems to exist for that.

Thanks,

Alexandre from CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 22:24:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 21:24:23 +0000
Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 22:37:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 21:37:09 +0000
Subject: [Koha-bugs] [Bug 17764] OPAC search fails when lost items are in
 the result set and there is no logged in user
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Katrin Fischer  ---
Dependency is not in 16.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 22:38:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 21:38:57 +0000
Subject: [Koha-bugs] [Bug 16914] Export csv in item search,
	exports all items in one line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #24 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 23:01:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 22:01:58 +0000
Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a button to navigate    |Add a button to navigate
                   |between notices             |between records
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Alexandra, I think by notice you mean record? I am not sure where the
problem is, can you make a screenshot of where it's missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 22 23:19:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 22 Dec 2016 22:19:59 +0000
Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810

--- Comment #2 from Katrin Fischer  ---
I meant Alexandre, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 01:23:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 00:23:03 +0000
Subject: [Koha-bugs] [Bug 16605] All notices should give the ability to
 unsubscribe or flag account
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 01:45:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 00:45:21 +0000
Subject: [Koha-bugs] [Bug 17706] MARC staging fails with "Upload status:
 Denied" when memcached is enabled
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17706

--- Comment #2 from Mirko Tietgen  ---
I just had it again, on an instance where memcached was turned off. Will post
more if I find a pattern.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 01:57:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 00:57:50 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #5 from M. Tompsett  ---
Created attachment 58405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58405&action=edit
Bug 17793: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 02:04:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 01:04:37 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58405|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett  ---
Created attachment 58406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58406&action=edit
Bug 17793: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 02:04:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 01:04:47 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58371|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett  ---
Created attachment 58407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58407&action=edit
Bug 17793: Make sysprefs search show on all Admin pages

This patch is amended to use the sysprefs search on all Administration
pages that do not have their own custom search.

To test:
1) Go to Administration
2) Notice Catalogue search at the top - seems out of place.
3) Apply patch and refresh page.
4) Notice admin / sysprefs search now shows and is more appropriate.
5) Confirm searching for sysprefs still works

This patch affects the following pages:
- admin-home.pl
- audio_alerts.pl
- authtypes.pl
- auth_tag_structure.pl
- authorised_values.pl
- biblio_framework.pl
- marctagstructure.pl
- branch_transfer_limits.pl
- branches.pl
- checkmarc.pl
- classsources.pl
- columns_settings.pl
- didyoumean.pl
- edi_accounts.pl
- edi_ean_accounts.pl
- fieldmapping.pl
- item_circulation_alerts.pl
- items_search_fields.pl
- items_search_field.pl
- item_types.pl
- koha2marklinks.pl
- matching-rules.pl
- oai_sets.pl
- oai_set_mappings.pl
- patron-attr-types.pl
- smart-rules.pl
- transport-cost-matrix.pl
- sms_providers.pl

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 02:06:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 01:06:10 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #8 from M. Tompsett  ---
Follow the test plan in comment #6 and sign off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 02:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 01:09:42 +0000
Subject: [Koha-bugs] [Bug 17706] MARC staging fails with "Upload status:
 Denied" when memcached is enabled
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17706

--- Comment #3 from Mirko Tietgen  ---
I think this time it was turning off memcached but not restarting apache. Which
is not really a Koha bug but user error ;) I'll leave the bug open and see if I
get it again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 07:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 06:13:29 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #18 from M. Tompsett  ---
I was looking at bug 17809 and wondering why country authorised values are not
set or available in every language. It would be nicer than having country names
hard coded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 07:15:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 06:15:01 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #2 from M. Tompsett  ---
Comment on attachment 58350
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58350
Bug 17792: Introduce Koha::Patron::Attribute(s)

Review of attachment 58350:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17792&attachment=58350)
-----------------------------------------------------------------

::: Koha/Patron/Attribute.pm
@@ +20,5 @@
> +use base qw(Koha::Object);
> +
> +=head1 NAME
> +
> +Koha::Patron;;Category - Koha Patron;;Category Object class

Why is this ;;Category?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 07:16:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 06:16:57 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #19 from Chris Cormack  ---
(In reply to M. Tompsett from comment #18)
> I was looking at bug 17809 and wondering why country authorised values are
> not set or available in every language. It would be nicer than having
> country names hard coded.

On the contrary, the problem we are seeking to solve is not having multiple
names for the same country. Using authorised values does not solve this, as
they are user editable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 09:41:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 08:41:57 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #20 from Katrin Fischer  ---
Also authorised values are only translatable in an odd way, you have to create
your own web installer. Them being in the templates makes it much easier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 09:54:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 08:54:31 +0000
Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated
 templates is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14264


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264
[Bug 14264] Export of CSV from late orders form does only work in English
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 09:54:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 08:54:31 +0000
Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does
 only work in English
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795
[Bug 17795] Exporting late orders from translated templates is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 09:57:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 08:57:35 +0000
Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated
 templates is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer  ---
This is fixed by the patch for 
bug 16914 Export csv in item search, exports all items in one line

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 09:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 08:59:31 +0000
Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated
 templates is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795

--- Comment #2 from Jonathan Druart  ---
I guess this has been fixed by bug 16914 and this bug report can be marked as a
duplicate.
But, on 8db17f9 (master without 16914) I do not recreate that bug with fr-FR,
which is a bit weird.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 10:00:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 09:00:41 +0000
Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated
 templates is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795

--- Comment #3 from Katrin Fischer  ---
Hm, odd. I had tested it 3.22 and 16.11 and it was broken in both for German.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 10:03:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 09:03:22 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #21 from Jonathan Druart  ---
(In reply to Owen Leonard from comment #17)
> I would like to see a new last step at the end of the installation process
> where the usage statistics preferences could be saved directly. That is,
> show the whole form from admin/usage_statistics.pl.

That was the first idea, but finally I don't know if it is a good one.
For instance if we want to add geoloc info (bug 17802) or other info at branch
level, the form will not be complete at the end of the installer (branches do
not exist yet).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 10:22:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 09:22:06 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58389|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 58408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58408&action=edit
Bug 17808: Fix behavior when editing a circ rule

The original behavior is broken, see
https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs

Test plan:
Edit a circ rule
=> Without this patch you get a useless message
=> With this patch, no message
Edit a circ rule with content in inputs
=> With or without this patch you get a useful message

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 10:23:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 09:23:17 +0000
Subject: [Koha-bugs] [Bug 17808] String change,
	message showing for confirm edit rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |4354
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
           Severity|enhancement                 |normal


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354
[Bug 4354] Cannot edit existing issuing rules
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 10:23:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 09:23:17 +0000
Subject: [Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808
[Bug 17808] String change, message showing for confirm edit rule
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 11:06:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 10:06:31 +0000
Subject: [Koha-bugs] [Bug 17811] New: Subfield $v should be ignored in
 Series Title authority validation
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17811

            Bug ID: 17811
           Summary: Subfield $v should be ignored in Series Title
                    authority validation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: imingchan at yahoo.com.au
        QA Contact: testopia at bugs.koha-community.org

When validate a Series Title (MARC 8XX) as part of cataloguing, subfield $v
should not appear on the authority search screen.  Subfield $v detail has to be
manually removed before searching, otherwise, no result will be found!

See attached screen images.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 11:07:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 10:07:43 +0000
Subject: [Koha-bugs] [Bug 17811] Subfield $v should be ignored in Series
 Title authority validation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17811

--- Comment #1 from Iming Chan  ---
Created attachment 58409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58409&action=edit
Marc 8XX tag on the MARC cataloguing screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 11:08:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 10:08:28 +0000
Subject: [Koha-bugs] [Bug 17811] Subfield $v should be ignored in Series
 Title authority validation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17811

--- Comment #2 from Iming Chan  ---
Created attachment 58410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58410&action=edit
Authority validation search screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 11:13:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 10:13:37 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 11:13:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 10:13:40 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58370|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 58411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58411&action=edit
Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:20:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:20:32 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:20:36 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58399|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall  ---
Created attachment 58412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58412&action=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:25:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:25:19 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tim, Dani!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:26:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:26:44 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:31:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:31:22 +0000
Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for
 patron card creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:34:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:34:02 +0000
Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules
 shouldn't allow 'New' with same code
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:39:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:39:00 +0000
Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method
	for ILSDI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Arthur!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:45:55 +0000
Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #19 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:47:25 +0000
Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web
	crawlers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

--- Comment #8 from Jos? Anjos  ---
I would suggest that robots.txt like the one in comment 3 should come with
fresh installs. Firstly because most times people don't realize that the koha
performance are affected by that until it crashes.
Secondly because some bots take longer to stop like:
https://www.semrush.com/bot/
"Please note that there might be a delay up to two weeks before SEMrushBot
discovers the changes you made to robots.txt"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:54:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:54:38 +0000
Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with
	Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:55:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:55:11 +0000
Subject: [Koha-bugs] [Bug 17689] Add the Koha::Checkout->is_overdue method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add the                     |Add the
                   |Koha::Issue->is_overdue     |Koha::Checkout->is_overdue
                   |method                      |method
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 12:57:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 11:57:41 +0000
Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add the                     |Add the
                   |Koha::Checkout->is_overdue  |Koha::Issue->is_overdue
                   |method                      |method
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:04:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:04:13 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         Depends on|                            |16846
             Status|In Discussion               |BLOCKED

--- Comment #39 from Josef Moravec  ---
(In reply to Tom?s Cohen Arazi from comment #36)
> Lari, I don't think we should have such a 'validate' method. We should look
> at Jonathan's code to move C4::Members methods into Koha::Patron(s) and have
> them raise those exceptions, and build the endpoint on top of those.
> Please contact him if you are willing to help him and make this happen.

Marking this as blocked because bug 16846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:04:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:04:13 +0000
Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:04:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:04:23 +0000
Subject: [Koha-bugs] [Bug 17783] Optimize
	Koha::IssuingRules->get_effective_issuing_rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #23 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Lari!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:14:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:14:31 +0000
Subject: [Koha-bugs] [Bug 17679] C4::Circulation - Remove unused
	GetItemIssues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:14:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:14:33 +0000
Subject: [Koha-bugs] [Bug 17679] C4::Circulation - Remove unused
	GetItemIssues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57784|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall  ---
Created attachment 58413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58413&action=edit
Bug 17679: C4::Circulation - Remove unused GetItemIssues

Ready for an archaeology course?

C4::Circulation::GetItemIssues is only used once, from
catalogue/issuehistory.pl
This call has been added by
  commit 95d6452462a560ba0c0ac859a2cfb7783c25c925
    Adding some more information on issuehistory.
which says "Adding itemnumber to issuehistory.pl API so that one could search
for issuehistory of a specific item."
So it added the ability to see the item issue history but did not
provide a way to access it via the interface.
It's ok so far but this subroutine is broken since
  commit aa114f53499b9cffde0571fe7e08622f9c9a332a
    Bug 5549 : Only use DateTime for issues table
because of this change:
-    my $today = C4::Dates->today('iso');
+    my $today = DateTime->now( time_zome => C4::Context->tz);

I let you catch the typo ;)
And since this commit the subroutine explodes with "The following
parameter was passed in the call to DateTime::from_epoch but was not
listed in the validation options: time_zome"

Since it has never been raised by someone and that the feature is
hidden, I'd recommend to simply remove it.

Note that the "Checked out from" column would have been wrong even if we
fixed all the previous issue.

Test plan:
Just dig into the code and confirm what this commit message tells

Signed-off-by: Josef Moravec 
Looks fine for me.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:16:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:16:22 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #6 from David Gustafsson  ---
I looked into the last issue a bit more. Tried adding items through the
interface and looking at the resulting marcxml in the database (and having a
look at the code base) and it seems to me like the items are never inserted
into the marcxml saved in the biblioitems table, but can be inserted on the fly
in some cases when fetching records, which seems reasonable. So in that case
bulkimportmarc is consistent with standard behavior. The thing that confused me
slightly is that there is an out-commented ModBiblioMarc in the
AddItemBatchFromMarc:
# update the MARC biblio
# $biblionumber = ModBiblioMarc( $record, $biblionumber, $frameworkcode );

If one would comment out, that I believe the items would actually be inserted
back into the database marcxml since the record has been modified (with items
added) previously in the sub.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 13:20:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 12:20:40 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #7 from Magnus Enger  ---
(In reply to David Gustafsson from comment #6)
> I looked into the last issue a bit more. Tried adding items through the
> interface and looking at the resulting marcxml in the database (and having a
> look at the code base) and it seems to me like the items are never inserted
> into the marcxml saved in the biblioitems table, but can be inserted on the
> fly in some cases when fetching records, which seems reasonable. 

That is the expected behaviour, yes. It used to be that items (952 fields) were
stored in the marcxml, but they were removed from there a few years ago. See
bug 5579 for the details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:17:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:17:31 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
	Koha::Issues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
  Attachment #57787|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:17:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:17:38 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
	Koha::Issues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57788|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:18:58 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
	Koha::Issues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Kyle M Hall  ---
This patch set needs updated to use Koha::Checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:21:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:21:17 +0000
Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Shouldn't the circulation.tt template be updated with a NO_RULE_DEFINED error
case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:29:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:29:54 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58350|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi  ---
Created attachment 58414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58414&action=edit
Bug 17792: Introduce Koha::Patron::Attribute(s)

This patch introduces stub Koha::Object(s) for handling patron attributes.

Edit: amended the POD to fix C&p mistake

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:30:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:30:19 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #4 from Tom?s Cohen Arazi  ---
(In reply to M. Tompsett from comment #2)
> Comment on attachment 58350 [details] [review]
> Bug 17792: Introduce Koha::Patron::Attribute(s)
> 
> Review of attachment 58350 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Patron/Attribute.pm
> @@ +20,5 @@
> > +use base qw(Koha::Object);
> > +
> > +=head1 NAME
> > +
> > +Koha::Patron;;Category - Koha Patron;;Category Object class
> 
> Why is this ;;Category?

It was a typo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:30:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:30:26 +0000
Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple
 FK defined in arrayref
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:30:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:30:29 +0000
Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple
 FK defined in arrayref
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58091|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall  ---
Created attachment 58415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58415&action=edit
Bug 17246: Do no support arrayref to define multiple FK

Currently you can call GetPreparedLetter like:

$prepared_letter = GetPreparedLetter(
    (
        module      => 'test',
        letter_code => 'TEST_HOLD',
        tables      => {
            reserves => [ $fk1, $fk2 ],
        },
    )
);

It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber.
It seems hazardous to do this guess.

I suggest to remove this feature and only allow hashref indeed.

Test plan:
Use different way to generate letters and make sure you do not reach the croak

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:36:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:36:24 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:36:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:36:27 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56675|0                           |1
        is obsolete|                            |
  Attachment #56676|0                           |1
        is obsolete|                            |
  Attachment #56677|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall  ---
Created attachment 58416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58416&action=edit
Bug 14637: Fix add patron category under MySQL 5.7 - tests

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:36:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:36:34 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

--- Comment #15 from Kyle M Hall  ---
Created attachment 58417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58417&action=edit
Bug 14637: Fix add patron category under MySQL 5.7

If no dateofbirthrequired or upperagelimit is set on the interface, the
->store method will receive an empty string defined for these values.
For INT field, we must explicitely set these empty value to undef
instead to avoid MySQL 5.7 (and strict mode) to raise:
  DBD::mysql::st execute failed: Incorrect integer value: ' for column
'dateofbirthrequired''

Test plan:
Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES)
Create a patron category without specifying upperagelimit or
dateofbirthrequired

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 14:36:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 13:36:37 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

--- Comment #16 from Kyle M Hall  ---
Created attachment 58418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58418&action=edit
Bug 14637: Followup - Fix number of tests due to rebase

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 15:14:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 14:14:03 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_checkouts method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58295|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall  ---
Created attachment 58419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58419&action=edit
Bug 17584: Add the Koha::Patron->get_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 15:14:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 14:14:00 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_checkouts method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 15:14:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 14:14:11 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->get_checkouts method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

--- Comment #9 from Kyle M Hall  ---
Created attachment 58420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58420&action=edit
Bug 17584 [QA Followup] - Rename Koha::Patron::get_checkouts to
Koha::Patron::checkouts

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 15:20:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 14:20:55 +0000
Subject: [Koha-bugs] [Bug 17812] New: Check out error made by the cursor not
 returning at " enter item barcode" space
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812

            Bug ID: 17812
           Summary: Check out error made by the cursor not returning at
                    "enter item barcode" space
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alexandre.breton at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Some people have not save loans because they forgot to clic again on "enter
item barcode" space after taking the option "on-site check out"

1)Go to Circulation module
2)Go to checkouts
3)Select a valid user for a loan
4)Observe the cursor is in "enter item barcode" space
4)Select the option "on-site check out"
5)Observe that the cursor isn't returning to "enter item barcode space" by
itself

Eliminate this additionnal clic can save lot of time to people doing many loans
at a same time.

Thanks for the support,

Alexandre from CCSR

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 16:00:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 15:00:20 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 16:09:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 15:09:00 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #5 from Tom?s Cohen Arazi  ---
Created attachment 58421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58421&action=edit
Bug 17792: Add opac_editable and opac_display methods

This patch adds two methods to the Koha::Patron::Attribute:

- opac_display
- opac_editable

Both method just check the corresponding Koha::Patron::Attribute::Type
and return the values for those attributes. This is useful to avoid
checking that manually on the controller scripts.

To test:
- Run:
  $ prove t/db_dependent/Koha/Patron/Attributes.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 16:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 15:09:42 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792
[Bug 17792] Introduce Koha::Patron::Attribute(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 16:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 15:09:42 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755
[Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:46:39 +0000
Subject: [Koha-bugs] [Bug 17813] New: Table borrower_attributes needs a
	primary key
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

            Bug ID: 17813
           Summary: Table borrower_attributes needs a primary key
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In order to be used correctly on DBIC the table needs a primary key. Otherwise
calls to ->delete would fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:46:54 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792
[Bug 17792] Introduce Koha::Patron::Attribute(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:46:54 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17813


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813
[Bug 17813] Table borrower_attributes needs a primary key
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:58:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:58:46 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 58422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58422&action=edit
Bug 17813: Add a primary key to borrower_attributes

This patch adds 'borrower_attributes' a field (if) which
will act as a primary key.

This is needed for DBIC to be used to handle rows, and also will help
when faced with the implementation of the REST api for this resource.

To test:
- Run all patron modification / attributes and verify nothing breaks
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:58:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:58:51 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

--- Comment #2 from Tom?s Cohen Arazi  ---
Created attachment 58423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58423&action=edit
Bug 17813: DBIC update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:59:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:59:17 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 19:59:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 18:59:27 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 23:29:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 22:29:50 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 23:30:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 22:30:00 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41317|0                           |1
        is obsolete|                            |

--- Comment #36 from Charles Farmer  ---
Created attachment 58424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58424&action=edit
Bug 12747 - Add extra column in Z3950 search

This patch permits to add an extra column in Z3950 search result.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) shares same syspref as above
1) Go to cataloguing, click New from z3950
2) fill to result in a successful search
3) validate column Addition Fields

sponsored by the CCSR ( http://www.ccsr.qc.ca )

Tested with both patches together, followed test plan, works as expected
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 23:30:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 22:30:07 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41318|0                           |1
        is obsolete|                            |

--- Comment #37 from Charles Farmer  ---
Created attachment 58425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58425&action=edit
Bug 12747 - Add extra column in Z3950 search result

This patch uses the standard field syntax (ex: 023$ab), allows writing fields
without mentionning subfields and uses whitespace as a field separator instead
of semicolon.

sponsored by the CCSR ( http://www.ccsr.qc.ca )

Tested with both patches, works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 23 23:30:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 23 Dec 2016 22:30:14 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41319|0                           |1
        is obsolete|                            |

--- Comment #38 from Charles Farmer  ---
Created attachment 58426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58426&action=edit
Bug12747 - Follow-up to QA

Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 25 02:02:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 25 Dec 2016 01:02:48 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Chris Kirby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.kirby at ilsleypubliclib
                   |                            |rary.org

--- Comment #6 from Chris Kirby  ---
I applied the required patches (17755, 177813), then this patch. Tests fail,
"No tests run for subtest 'opac_editable() tests'".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 25 02:14:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 25 Dec 2016 01:14:11 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #7 from Chris Kirby  ---
^ I applied the required patches (17755, 17813), then patch 17792. I then
tested, and the tests failed:"No tests run for subtest 'opac_editable()
tests'".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 25 20:02:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 25 Dec 2016 19:02:13 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Chris Kirby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.kirby at ilsleypubliclib
                   |                            |rary.org

--- Comment #6 from Chris Kirby  ---
Error: "Can't locate object method 'throw' via package
'Koha::Exceptions::CannotAddLibraryLimit' (perhaps you forgot to load
'Koha::Exceptions::CannotAddLibraryLimit'?) at Koha/Object/Limit/Library.pm"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 00:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 25 Dec 2016 23:39:29 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #8 from Tom?s Cohen Arazi  ---
(In reply to Chris Kirby from comment #7)
> ^ I applied the required patches (17755, 17813), then patch 17792. I then
> tested, and the tests failed:"No tests run for subtest 'opac_editable()
> tests'".

Have you ran the updatedatabase.pl script?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 11:43:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 10:43:59 +0000
Subject: [Koha-bugs] [Bug 17814] New: koha-plack --stop should make sure
 that Plack really stop
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

            Bug ID: 17814
           Summary: koha-plack --stop should make sure that Plack really
                    stop
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: pongtawat at punsarn.asia
        QA Contact: testopia at bugs.koha-community.org

koha-plack --stop doesn't ensure that Plack was really stopped before
returning. 

So in case that koha-plack --stop was quickly follows by koha-plack --start
(e.g. logrotate), it could leave Plack in stop state. This is due to koha-plack
--start think that Plack was already started, while it actually is being
stopped.

For me I think this is the cause why I got random Plack stop when logrotate is
run. 

It should be similar to the case of Zebra in Bug #16885, and the solution might
be the same: adding "--retry=TERM/30/KILL/5;" to start-stop-daemon command.

I just try that on our server and will see if the problem goes away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 11:54:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 10:54:26 +0000
Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that
 Plack really stop
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

--- Comment #1 from Pongtawat  ---
Created attachment 58427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58427&action=edit
Unverified patch

A simple patch follows that in #16885. If it work there, it should work here
too. But not yet verified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 15:22:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 14:22:18 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #9 from Chris Kirby  ---
(In reply to Tom?s Cohen Arazi from comment #8)
> (In reply to Chris Kirby from comment #7)
> > ^ I applied the required patches (17755, 17813), then patch 17792. I then
> > tested, and the tests failed:"No tests run for subtest 'opac_editable()
> > tests'".
> 
> Have you ran the updatedatabase.pl script?

I have now. After running "perl installer/data/mysql/updatedatabase.pl" in the
koha-shell environment, I had the following output:

DEV atomic update: bug_17813_borrower_attributes_pk.sql
C4:::Installer::load_sql returned the following errors while attempting to load
/home/ckirby/koha/installer/data/mysql/atomicupdate/bug_17813_borrower_attributes_pk.sql:"

I had the same error when I ran "koha-upgrade-schema" on my instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 15:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 14:37:01 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #48 from Tom?s Cohen Arazi  ---
Created attachment 58428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58428&action=edit
Bug 13757: (followup) Only touch opac_editable attributes

As reported by Owen, the members-update.pl was showing every attributes
the patron has (display issue) instead of showing only those affected by
the changes.

This patch fixes this by filtering the patron's attributes by opac
editability.

It also fixes Koha::Patron::Modification->approve so it only clears the
attributes with the updating 'code' and leaves the others untouched.
As its been coded so far (until someone refactors it all) the
Koha::Patron::Modification object needs to contain all the attributes
for a specific code. And it comes from parsing the UI's input.

Tests for Koha::Patron::Modification->approve to come.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 15:37:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 14:37:07 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #49 from Tom?s Cohen Arazi  ---
Created attachment 58429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58429&action=edit
Bug 13757: (followup) Regression tests for ->approve changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 15:39:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 14:39:44 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 16:39:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 15:39:56 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #7 from Tom?s Cohen Arazi  ---
(In reply to Chris Kirby from comment #6)
> Error: "Can't locate object method 'throw' via package
> 'Koha::Exceptions::CannotAddLibraryLimit' (perhaps you forgot to load
> 'Koha::Exceptions::CannotAddLibraryLimit'?) at Koha/Object/Limit/Library.pm"

Chris, please find me on IRC or email to check what's going on. Things work
fine for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 16:40:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 15:40:58 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #10 from Tom?s Cohen Arazi  ---
(In reply to Chris Kirby from comment #6)
> I applied the required patches (17755, 177813), then this patch. Tests fail,
> "No tests run for subtest 'opac_editable() tests'".

Chris, please find me on IRC or email to check what's going on. Things work
fine for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 21:23:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 20:23:18 +0000
Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items
 should either be prohibited or items should be removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 26 22:42:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 26 Dec 2016 21:42:45 +0000
Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that
 Plack really stop
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:00:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:00:07 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->checkouts method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add the                     |Add the
                   |Koha::Patron->get_checkouts |Koha::Patron->checkouts
                   |method                      |method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:05:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:05:39 +0000
Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:05:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:05:43 +0000
Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588

--- Comment #4 from Jonathan Druart  ---
Created attachment 58430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58430&action=edit
Bug 17588: ->get_issues has been replaced with ->checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:31:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:31:06 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|C4::Circulation - Replace   |C4::Circulation - Replace
                   |GetItemIssue with           |GetItemIssue with
                   |Koha::Issues                |Koha::Checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:35:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:35:15 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57787|0                           |1
        is obsolete|                            |
  Attachment #57788|0                           |1
        is obsolete|                            |
  Attachment #57847|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 58431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58431&action=edit
Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

C4::Circulation::GetItemIssue returned all the issue and item
informations for a given issue. Moveover it also did some date
manipulations. Most of the time this subroutine was called, there
additional information were useless as the caller usually just needed
the basic issue's infos 'from the issue table).

This first patch updates the simple calls, ie. the ones that just need
the issue's infomations.

Test plan:
The following operations should success:
- transfer a book
- create a rule for on-site checkouts and confirm that a patron cannot
check more items out that it's defined in the rule.
- Renew an issue using ILSDI
- Using SIP confirm that you are able to see your issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:35:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:35:18 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

--- Comment #9 from Jonathan Druart  ---
Created attachment 58432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58432&action=edit
Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls

There are a few calls to GetItemIssue where it's not as easy to make
sure everything will be fine just replacing the calls with a
Koha::Issues->find
- In AddReturn the overdue flag is used (that's why this patch depends
on bug 17689)
- In CanBookBeRenewed, as well as the overdue flag the dates converted
to DateTime were used. It's now our job to convert them when we need
them.
- Same in AddRenewal but we also call _CalculateAndUpdateFine, so we
need to update the variables in this subroutine.

Note that, prior to this patch, AddReturn returned the GetItemIssue
hashref in the $iteminformation. Most of the time this variable is not
used, I have found only 1 place where it's used: circ/returns.pl
TODO: In this script we should call ->is_overdue instead of the
DateTime->compare calls

Test plan:
All the circulation tests must pass (it's how I have caught the specific
cases).
Do some checkins/checkouts/renewal and focus on the due date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:35:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:35:11 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:35:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:35:23 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

--- Comment #10 from Jonathan Druart  ---
Created attachment 58433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58433&action=edit
Bug 17680: C4::Circulation - Remove GetItemIssue

This patch simply removes the C4::Circulation::GetItemIssue subroutine

Test plan:
At this point, `git grep GetItemIssue` should not return any occurrence
in the codebase

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 09:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 08:48:04 +0000
Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #9 from Jonathan Druart  ---
(In reply to Kyle M Hall from comment #8)
> Shouldn't the circulation.tt template be updated with a NO_RULE_DEFINED
> error case?

The message says "This patron can't check out this item per library circulation
policy"
That sounds ok to me.
We could add a check somewhere else (about page).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:24:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:24:03 +0000
Subject: [Koha-bugs] [Bug 5993] tags not searchable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5993

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:45:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:45:34 +0000
Subject: [Koha-bugs] [Bug 17815] New: Problems with search for
	dateaccessioned
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815

            Bug ID: 17815
           Summary: Problems with search for dateaccessioned
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Tested this as described in bug 14861:

Search from advanced search by accession date:
2011-09-01 - 2011-09-30 
9461 results

Searched with SQL: 
select distinct biblionumber from items where dateaccessioned between
'2011-09-01' and '2011-09-30'
805 results

The date range search doesn't seem to work right.

The search for a single date appears to work correctly. 
It's also possible to truncate dates using *.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:46:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:46:03 +0000
Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in
 advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861

--- Comment #30 from Katrin Fischer  ---
Hm, tested this on a 3.22 database with the example from the test plan:

Search from advanced search by accession date:
2011-09-01 - 2011-09-30 
9461 results

Searched with SQL: 
select distinct biblionumber from items where dateaccessioned between
'2011-09-01' and '2011-09-30'
805 results

The date range search doesn't seem to work right.

The search for a single date seems to work correctly. You can also truncate
with *.

Also filed this as a new bug report: bug 17815.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:55:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:55:24 +0000
Subject: [Koha-bugs] [Bug 13842] Send payment slip to patron by email
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13842

--- Comment #1 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:57:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:57:01 +0000
Subject: [Koha-bugs] [Bug 13846] Email patron asking to return an item that
 has been placed on hold
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 17509 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 10:57:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 09:57:01 +0000
Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on
 hold by another person
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #20 from Katrin Fischer  ---
*** Bug 13846 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 11:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 10:46:51 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #90 from Katrin Fischer  ---
Can this now be closed duplicate? (see bug 14695)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 12:57:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 11:57:02 +0000
Subject: [Koha-bugs] [Bug 12722] Population of Authority 001 is inconsistent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722

David Gustafsson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #3 from David Gustafsson  ---
I have also encountered this issue. I'm tempted to have the opinion that it
should be enforced that "(003)001" is moved to 035$a (if 001 is not already the
internal koha id) on import since I interpret this behavior as being part of
the MARC standard. At least it should be an option. Was thinking about adding
this in the form of a custom script (-custom), but really think it should be
added into the default logic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 13:07:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 12:07:30 +0000
Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use
 DELETE instead of TRUNCATE
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488

David Gustafsson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #9 from David Gustafsson  ---
Keep getting "Cannot truncate a table referenced in a foreign key constraint"
errors when using the -d option. So for me the only options have been to change
the script to using DELETE FROM instead, or deleting manually through the MySQL
cli.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 13:09:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 12:09:00 +0000
Subject: [Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield
 is mandatory and linked to authorized value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

--- Comment #1 from Katrin Fischer  ---
We keep running into this. As it is now, 'mandatory' makes no sense for fields
with a pull down list as it will never trigger the message and it's easier to
spot items where you forgot to set the item type than items where the first
entry of the list was saved accidentally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 13:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 12:46:28 +0000
Subject: [Koha-bugs] [Bug 17816] New: Useless call to GetBibioData in
 bulkmarcimport.pl(?)
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17816

            Bug ID: 17816
           Summary: Useless call to GetBibioData in bulkmarcimport.pl(?)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

This call to GetBibioData seems without purpose:
https://github.com/Koha-Community/Koha/blob/2fe2ef41bd8bf2f142597e39f493edbdbf75c8a3/misc/migration_tools/bulkmarcimport.pl#L418

$biblioitemnumber is either overwritten on the lines below, or update/create
failed/was skipped and the later AddItemBatchFromMarc will fail anyways.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 13:51:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 12:51:42 +0000
Subject: [Koha-bugs] [Bug 17816] Useless call to GetBibioData in
	bulkmarcimport.pl(?)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17816

--- Comment #1 from David Gustafsson  ---
Ok, seems like ModBiblio returns 1(!), not id and itemid. So the lvalues for
ModBibilio must be removed. I think I saw another bug-report on this somewhere.
Think this takes some more effort to fix, AddItemBatchFromMarc should only be
run on insert, so the line can still be removed. But some further refactoring
is also needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 15:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 14:45:44 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 15:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 14:45:55 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Charles Farmer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55940|0                           |1
        is obsolete|                            |

--- Comment #114 from Charles Farmer  ---
Created attachment 58434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58434&action=edit
Bug 8000 - Override emails of every message sent from Koha

For testing purposes, we do not want emails sent to (legitimate) users.
And sometime we also like to actually see what would be generated for the
users.
This preference will allow to override every message sent by koha with
a new (temporary) To address.  Leave it empty for normal usage.

    C4/Letters.pm
    installer/data/mysql/sysprefs.sql
    installer/data/mysql/updatedatabase.pl
    koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref

TESTING:
    0) Run updatedatabase.pl
    1) Enter a valid address for new preference SendAllEmailsTo, something that
will be easily identified
       as NOT the normal destination for the Koha emails.
    2) Have koha generate an email to a user.  Or any other mean prefered that
cause Koha to send email.
    3) Validate that the email is NOT sent to the user.
    4) Validate that the email IS sent to the overriding address.
    5) Clean the preference
    6) Redo the test, validate that the email is going to the right address.

    PS Not sure if those steps are precise enough.  Here's one way:
       a) set AutoEmailOpacUser to true
       b) create a new user, with an email address
       c) Normally, a confirmation email is sent to the user. Validate that it
goes to the SendAllEmailsTo one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:04:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:04:21 +0000
Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:04:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:04:25 +0000
Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58338|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 58435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58435&action=edit
Bug 17785: Fix OAI-PMH's XSLT-generated URLs under Plack

Look at e.g. the URL for Show More at the end of the output of Records or
Identifiers. If you use Plack, you will see that it refers to
yourserver:/opac/oai.pl, which is not correct.

This is caused by using CGI's self_url in combination with script alias,
mounting point, etc. Note that we cannot solve this problem in the code of
Koha only. Since HTTP::OAI modules also call self_url, we still end up
with some wrong url's.

Instead of a larger architectural operation on Apache and Plack config files,
this patch adjusts the final xslt transformation on the OAI response.
It hardcodes the correct path only once, in a xslt variable. And replaces
all oai:OAI-PMH/oai:request/text() calls, containing wrong URLs, by this
variable.

Test plan:
Run oai.pl. Try the various verbs.
Verify that the URLs point to /cgi-bin/koha/oai.pl.

Edit: changed commit subject

Signed-off-by: Tomas Cohen Arazi 
Works as expected. Good workaround until a definitive solution is implemented.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:16:23 +0000
Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:16:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:16:27 +0000
Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58388|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 58436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58436&action=edit
Bug 17781 - Improper branchcode set during renewal

For no discernable reason, when AddIssue calls AddRenewal, it passes the
branchcode generated from _GetCircControlBranch. Assume
_GetCircControlBranch is set to return items.homebranch. So:
1) If an item owned by LibraryA is checked out at LibraryB, the
  statistic line branchcode will be LibraryB
2) If an item is renewed via the ajax datatables renewal function, the
  statistic line branchcode will be LibraryB the
3) If an item is renewed via scanning the item into the checkout again,
  statistic line branchcode will be *LibraryA*

This is clearly improper behavior. The renewal is taking place at
LibraryB, so the branchcode passed to AddRenewal should be LibraryB,
the logged in library. This also jives with the documentation for
the subroutine.

Test Plan:
1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary )
2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch
)
3) Create item with homebranch of LibraryA and holdingbranch of LibraryB
4) Set the logged in library to LibraryB
4) Check the item out to a patron at LibraryB
5) Note the statistics line has a branchcode of LibraryB
6) Check the item out again to trigger a renewal, renew the item
7) Note the statistic line has a branchcode of LibraryA!
8) Apply this patch
9) Repeat step 6
10) Note the statistics line has a branchcode of LibraryB!

Signed-off-by: Kyle M Hall 

Signed-off-by: David Kuhn 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:35:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:35:05 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #47 from Jonathan Druart  ---
@QA: We need the new constraint_exists and column_exists subroutine ASAP in the
master branch. That way we will be able to use them.
Otherwise I will split these patches and move the 2 subroutines to another bug
report to make it move forward quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:01 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:05 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58365|0                           |1
        is obsolete|                            |
  Attachment #58366|0                           |1
        is obsolete|                            |
  Attachment #58367|0                           |1
        is obsolete|                            |
  Attachment #58368|0                           |1
        is obsolete|                            |
  Attachment #58369|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart  ---
Created attachment 58437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58437&action=edit
Bug 17767: Add borrower_modification.extended_attributes

This patch changes the DB structure adding
borrower_modifications.extended_attributes

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:12 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

--- Comment #18 from Jonathan Druart  ---
Created attachment 58438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58438&action=edit
Bug 17767: DBIC update

This patch can be skipped by the RM, it just updates the DBIC schema files.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:16 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

--- Comment #19 from Jonathan Druart  ---
Created attachment 58439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58439&action=edit
Bug 17767: Make Koha::Patron::Modification handle extended attributes

This patch makes Koha::Patron::Modification aware of the new
extended_attributes
column, which is expected to contain valid JSON data.

The ->store method is modified so it validates the field value (i.e. the
content
is decoded using the JSON library) and raises a convenient exception in case of
failure.

This behaviour change is covered by the provided unit tests.

To test:
- Apply the patchset
- Run:
  $ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: Tests make sense, and they pass
- Sign off :-D

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:22 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

--- Comment #20 from Jonathan Druart  ---
Created attachment 58440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58440&action=edit
Bug 17767: Unit tests

This patch introduces tests for the new behaviour, and also
enhances the existing ones aiming to reach full coverage.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:41:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:41:26 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

--- Comment #21 from Jonathan Druart  ---
Created attachment 58441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58441&action=edit
Bug 17767: (followup) Rename test file

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:42:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:42:20 +0000
Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays
 using cleanup_database.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
Can we get this moving again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:43:36 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #22 from Jonathan Druart  ---
It would have been good to use the column_exists subroutine added by 17234 (but
not pushed yet...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:48:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:48:31 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
	OAuth2 login
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #21 from Jonathan Druart  ---
Koha::Patron->new should not be called directly yet.
Please use AddMember instead (unless there is a good reason?).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:52:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:52:38 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart  ---
I personally prefer the existing view (less info on a screen where there is
already a lot of info), I'd like to get another opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:52:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:52:55 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:58:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:58:18 +0000
Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular
	cron jobs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:58:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:58:22 +0000
Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular
	cron jobs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58194|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 58442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58442&action=edit
Bug 17520: add serialsUpdate.pl to the list of regular cron jobs

This patch adds the job to debian package file and the examples file
in misc.

Test plan:
Add these lines to your cron file.
Check the results. (If an issue you expect passes the grace period defined
in the subscription, its status should go from Expected to Late.)

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 16:58:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 15:58:25 +0000
Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular
	cron jobs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520

--- Comment #4 from Jonathan Druart  ---
Created attachment 58443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58443&action=edit
Bug 17520: Do not overlap with advance_notices.pl

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:08:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:08:00 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:08:05 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58189|0                           |1
        is obsolete|                            |
  Attachment #58190|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart  ---
Created attachment 58444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58444&action=edit
Bug 15711: Fixing the 'Delete selected' button on patroncard images

To test:
1) Go to Tools -> Patron Card Creator -> Manage images
2) Upload an image if you haven't already
3) Click Delete selected without selecting any images
4) Notice broken behaviour as described in Description
5) Apply patch, refresh page
6) Click Delete selected without selecting any images
7) Notice alert. Click OK
8) Select one image or more, click Delete selected
9) Notice confirm delete message.

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 
Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:08:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:08:10 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

--- Comment #15 from Jonathan Druart  ---
Created attachment 58445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58445&action=edit
Bug 15711: Follow up batch_id not used

Changed batch_id to image_id in the template, as the multiparam
would catch the array case.

TEST PLAN
---------
1) attempt to delete a selected item, but get a warning.
2) apply this follow up
3) attempt to delete a selected item, it deletes.
4) run koha qa test tools

Signed-off-by: Mark Tompsett 
Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:18:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:18:50 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #6 from Lari Taskula  ---
Created attachment 58446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58446&action=edit
Bug 17712: Add new Koha::Exceptions

To describe problems or notes to availability, we will be using
Koha::Exceptions.
This patch adds many useful Koha::Exceptions that we can use for this purpose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:19:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:19:13 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #7 from Lari Taskula  ---
Created attachment 58447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58447&action=edit
Bug 17712: Koha::Availability, a base for availability information

This patch adds a new class, Koha::Availability, which is designed to contain
availability information for each type of availability in an uniform way.
Because
of this, Koha::Availability has no actual availability calculation logic, but
simply methods to get and set availability information into the object.

With such design, we can next create new classes Koha::Availability::Hold and
Koha::Availability::Checkout and let them inherit Koha::Availability so that
they
are able to handle availaibility information in an uniform way.

       Koha::Availability::Hold          Koha::Availability::Checkout
                  |                                   |
                   \_________________________________/
                                   |
                          Koha::Availability

Koha::Availability can represent four levels of availability statuses:
1. available
2. available, with an additional note
3. available, but requires confirmation
4. unavailable

Additional notes, reasons for a need to confirm and reasons for
unavailabilities
are kept in a HASHref, where each value in my proposal is a
Koha::Exceptions::*.
This allows us to easily store any additional data directly into the reason.
For
example, if we want to check biblio availability for hold and find out it is
not
available, the HASHref for unavailabilities has a
Koha::Exceptions::Patron::Debt
that contains parameters "current_outstanding" and "max_outstanding" which lets
us pick up the information easily later on without making new queries.

To test:
1. Run t/Koha/Availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:19:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:19:19 +0000
Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the
	staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:19:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:19:23 +0000
Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the
	staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58187|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 58448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58448&action=edit
Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif'
and removing loading-small.gif file.

Confirm that I have not missed any places where there is 'loading-small.gif'
Have amended patch to not include OPAC changes from previous patch.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:19:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:19:35 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #8 from Lari Taskula  ---
Created attachment 58449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58449&action=edit
Bug 17712: Add base for item and biblio availability

This patch adds two new classes:
- Koha::Biblio::Availability
- Koha::Item::Availability

These classes represent biblio- and item-level availabilities and the purpose
of this patch is simply to provide constructors that validate given biblio/item
and patron parameters.

Hold / checkout / search view availabilities (the actual answers to
availability)
will be provided in the next patches.

To test:
1. Run t/db_dependent/Koha/Item/Availability.t
2. Run t/db_dependent/Koha/Biblio/Availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:19:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:19:55 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #9 from Lari Taskula  ---
Created attachment 58450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58450&action=edit
Bug 17712: Centralize availability-related checks

There are some problems to our current approach for "availability" which makes
it complicated to integrate with e.g. REST API.

Firstly, there has been no unified way of representing reasons for
unavailability. Previously, each implementation of availability calculation has
chosen its own way for describing the reasons. For example, CanItemBeReserved
string "ageRestricted" vs. CanBookBeIssued key "AGE_RESTRICTION" in a HASHref.

Secondly, some of the availability logic is contained outside centralized
methods like CanItemBeReserved which is missing checks e.g. for maxreserves
(checked instead in opac-reserve.pl) and patron fines. Perhaps this issue could
be fixed in another Bug, but I propose we squash it at the same time with this
Bug. Currently, because of this, we will not get reliable responses to
holdability from CanItemBeReserved alone.

This causes problems for API integration where we need to be able to describe
the reason in an uniform way and additionally provide information on what needs
to be done to fix the issue. Also, we do not want to duplicate all the external
checks from .pl files into our REST controllers.

Instead of modifying the old methods, I propose a new structure for the whole
availability-problem and let us deal with proper "status-codes" to easily
integrate availability & additional availability-related information into e.g.
REST API.

My proposal is an approach to centralize the availability-related checks and
have
them return uniform reasons to describe reasons for availability problems.

Ultimately, we could ask availability something like this:
my $holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => 'CPL',
})->in_opac;

...and $holdability->unavailabilities HASHref would contain Koha::Exceptions
possibily with additional parameters to let us know why this biblio is not
holdable in OPAC.

This patch adds all availability related logic with centralization in mind.
From
these individual methods we are able to construct full availability queries in
order to determine if something is actually available in some way and also
describe the problems with the help of Koha::Exceptions.

Since availability is a mixture of multiple different smaller checks from
multiple
categories like item, patron, issuing rules, etc, they can be categorized into
their own subclasses. This lets us centralize availability-related methods per
category into their own modules.

To test:
1. prove t/db_dependent/Koha/Availability/Checks/*

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:20:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:20:34 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #10 from Lari Taskula  ---
Created attachment 58451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58451&action=edit
Bug 17712: Item availability for hold

Adds Koha::Item::Availability::Hold class for item hold availability.

This patch adds item holdability queries in two contexts:
1. in_opac     (perspective of patron themselves)
2. in_intranet (perspective of a librarian to patron)

Returns a Koha::Item::Availability::Hold object, which contains all information
on
availability for hold in that context. This may include additional notes,
reasons
to ask for confirmation or reasons for unavailability.

Example: To find out if patron can hold an item in OPAC, we will write:

my $availability = Koha::Availability::Hold->item({
    patron => $patron,
    item => $item,
    to_branch => $branchcode, # transfer allowed from holdingbranch to
to_branch?
})->in_opac;
if ($availability->available) {
    # yes!
} else {
    foreach my $reason (keys %{$availability->unavailabilities}) {
        # each reason for unavailability
    }
    foreach my $reason (keys %{$availability->confirmations}) {
        # each reason that requires confirmation
    }
    foreach my $reason (keys %{$availability->notes}) {
        # each additional note
    }
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:20:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:20:53 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #11 from Lari Taskula  ---
Created attachment 58452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58452&action=edit
Bug 17712: Biblio availability for hold

Usage:

$holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => "CPL",
})->in_opac;
if ($holdability->available) {
  # yup!
  # arrayref of Koha::Item::Availability::Hold -objects:
  # 1. all available items (items may contain confirmations / notes)
  my $item_availabilities = $holdability->item_availabilities;
  # 2. all unavailable items
  my $item_unavailabilities = $holdability->item_unavailabilites;
}

Returns a Koha::Biblio::Availability::Hold -object.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:21:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:21:12 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #12 from Lari Taskula  ---
Created attachment 58453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58453&action=edit
Bug 17712: Item availability for checkout

Usage:
my $issuability = Koha::Availability::Checkout->item({
  item => $item,
  patron => $patron,
  duedate => $duedate      # custom due date
})->in_intranet;
if ($issuability->available) {
  # yes!
} else {
  # not available for checkout. $issuability contains all the reasons for this.
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:21:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:21:32 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #13 from Lari Taskula  ---
Created attachment 58454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58454&action=edit
Bug 17712: Item and biblio availability in search context

Usage:
my $availability = Koha::Availability::Search->item({
  item => $item,
})->in_opac;
if ($availability->available) {
  # yes
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:21:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:21:31 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #65 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #64)
> Created attachment 58395 [details] [review]
> Bug 12904 [QA Followup] - Don't send 301 status
> 
> Signed-off-by: Nick Clemens 

Can you explain this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:23:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:23:47 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:23:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:23:50 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58238|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart  ---
Created attachment 58455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58455&action=edit
Bug 17209: Remove use of onclick from masthead

There are two instances which use onclick in the OPAC masthead: clearing
search history, and logging out.

To test:
Confirm that clearing search history using the 'x' in the masthead, and
logging out by clicking 'Log out' in the masthead, work the same before
and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Marc V?ron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:32:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:32:49 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #14 from Lari Taskula  ---
I set this Bug to "In discussion" and provided my proposal as a (crude) set of
patches so that hopefully it helps to understand my idea better. I am open to
renaming the classes if Koha::Availability doesn't feel right and also open for
alternative solutions. We need to be able to integrate availability into REST
API asap. and essentially these patches make that integration less painless.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:35:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:35:29 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #15 from Lari Taskula  ---
(In reply to Lari Taskula from comment #14)
> integration less painless.
/painless/painful

Happy new year!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:56:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:56:49 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #35 from Lari Taskula  ---
Created attachment 58456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58456&action=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:57:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:57:10 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #36 from Lari Taskula  ---
Created attachment 58457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58457&action=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
    "available": true,
    "notes": {
      "Patron::SomethingToNote": {
        "cool": 1
      }
    }
  },
  "item_availabilities": [
    {
      "itemnumber": 5678,
      "availability": {
        "available": false,
        "unavailabilities": {
          "Item::Withdrawn": {}
        }
      }
    }
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:58:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:58:43 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13903                       |17712
             Blocks|17712                       |
             Status|ASSIGNED                    |In Discussion


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712
[Bug 17712] Move availability calculation to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:58:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:58:43 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16826                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
[Bug 16826] REST API: Add API routes for getting item availability and
holdability
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:58:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:58:43 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16826
         Depends on|16826                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
[Bug 16826] REST API: Add API routes for getting item availability and
holdability
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 17:59:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 16:59:21 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57369|0                           |1
        is obsolete|                            |
  Attachment #57382|0                           |1
        is obsolete|                            |

--- Comment #37 from Lari Taskula  ---
Created attachment 58458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58458&action=edit
Bug 16826: Controllers for availability

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 18:00:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 17:00:40 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #38 from Lari Taskula  ---
I added Bug 17712 as a dependency and attached new patches that use
Koha::Availabiltiy to provide more detailed availability answer via REST API. I
also marked the old patches obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 18:03:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 17:03:12 +0000
Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart  ---
I have enabled SmartformEnable, set SmartformClientID to "smartform", I create
a new patron, fill address input with some random chars, but no autocompletion
(and no request to the ws).
Can you double-check or tell me what I missed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 18:11:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 17:11:51 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #2 from Nick Clemens  ---
Created attachment 58459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58459&action=edit
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'

This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
allow for displaying status of an item when it has been selected for a
hold by the holdsqueue.

To test:
01 - Place a hold on an item
02 - Build the holdsqueue (kohadevbox example below)
    sudo koha-shell kohadev
    perl misc/cronjobs/holds/build_holds_queue.pl
03 - Search for the item on the OPAC
04 - Note item shows as 'Available' in results and details
05 - Apply Patch
06 - Search for the item on the OPAC
07 - Note that item now shows as 'Pending hold'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 18:11:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 17:11:58 +0000
Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379

--- Comment #14 from Jonathan Druart  ---
The Author part is displayed like:

"""
AUTHOR
       Mason James
       The Koha Community
           Author
"""

What is this last "Author" line?

(In reply to Jonathan Druart from comment #9)
> However http://man7.org/linux/man-pages/man7/man-pages.7.html says:
>   "Use of an AUTHORS section is strongly discouraged."

Still do not want to follow the man page of man? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 18:12:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 17:12:26 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch
  Change sponsored?|Seeking cosponsors          |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 19:03:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 18:03:45 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_3_20_candidate          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 19:08:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 18:08:15 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Joel Sasse  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsasse at plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 19:12:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 18:12:12 +0000
Subject: [Koha-bugs] [Bug 17817] New: Repeat this Tag (cloning) not working
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

            Bug ID: 17817
           Summary: Repeat this Tag (cloning) not working
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: joseanjos at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Full details here:
http://koha.1045719.n5.nabble.com/Repeat-this-Tag-not-working-td5914615.html

Description:
I've setup a completely new VM:
Debian GNU/Linux 8.6 (jessie)
MariaDB  Ver 14.14 Distrib 5.5.53
Apache/2.4.10 (Debian)

Installed the defaults in fr-FR

Choose Cataloging -> New Record -> Default Framework
Filed the mandatory fields.
If I try to duplicate 701 it will jump to the top of the page
If I try to duplicate 711 I have no problem.

Conclusion is: If I try to duplicate any field that contains a Drop Menu (with
authorized values) it will jump to the top of page. If there is no Drop Menu it
will clone ok.
If I choose a value from the Authorized Values, than In can duplicate it.
But, when I save it, that fields are not saved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 19:52:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 18:52:05 +0000
Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|16.11                       |master
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 20:34:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 19:34:34 +0000
Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

--- Comment #13 from Radek ?iman (R-Bit Technology, s.r.o.)  ---
Jonathan, were you running it from localhost and using HTTP URL from a local
IP? If not, it may not run. The service has some security limitations, because
it's paid for business, but any Czech library can use it for free after
registration.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 22:52:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 21:52:56 +0000
Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm
	checkout" dialogs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.02
.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 22:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 21:57:19 +0000
Subject: [Koha-bugs] [Bug 17804] Remove some modules from showdiffmarc.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17804

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|minor                       |enhancement

--- Comment #5 from Katrin Fischer  ---
This looks more like an enhancement of the code. Please let me know if you
disagree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:04:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:04:32 +0000
Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for
 patron card creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:11:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:11:14 +0000
Subject: [Koha-bugs] [Bug 17208] Classification sources and filing rules
 shouldn't allow 'New' with same code
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:14:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:14:06 +0000
Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method
	for ILSDI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #17 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:18:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:18:27 +0000
Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #20 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:19:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:19:07 +0000
Subject: [Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with
	Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:19:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:19:07 +0000
Subject: [Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha
	namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
Bug 17677 depends on bug 17678, which changed state.

Bug 17678 Summary: C4::Acquisition - Replace GetIssues with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:19:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:19:49 +0000
Subject: [Koha-bugs] [Bug 17689] Add the Koha::Issue->is_overdue method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:19:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:19:49 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680
Bug 17680 depends on bug 17689, which changed state.

Bug 17689 Summary: Add the Koha::Issue->is_overdue method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 27 23:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 22:21:39 +0000
Subject: [Koha-bugs] [Bug 17783] Optimize
	Koha::IssuingRules->get_effective_issuing_rule
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Pushed to Master            |RESOLVED

--- Comment #24 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 00:28:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 23:28:55 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 00:28:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 27 Dec 2016 23:28:59 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58150|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett  ---
Created attachment 58460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58460&action=edit
Bug 17742: Fix t/db_dependent/Patrons.t

Moves the getting of testing date for updated_on just after the storing
the test patron data to make the gap between generating data and now
date as short as possible

Fixes test 7

Use Koha::Database instead of C4::Context->dbh

Test plan
1. prove t/db_dependent/Patrons.t
2. read the diff

NOTE: Only minor improvement could be using test builder to
      generate the category and branch codes, rather than assume
      data exists. However, that is beyond scope of this bug.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 08:57:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 07:57:22 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #4 from Viktor Sarge  ---
Tried it on a freshly installed kohadevbox with jessie with the same result as
Marcel.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 09:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 08:47:55 +0000
Subject: [Koha-bugs] [Bug 1356] Lose original search term when select "More
	options"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #4 from Viktor Sarge  ---
Problem is still present in master. Had a quick look as I've seen the problem
before. There is a URL parameter &returntosearch=1 from the search result that
seems to use jquery.cookie to restore the last search. This works rather well
and even restores when you add more search fields than the original three. I
guess the logic used here could be applied to more/less options too if clicking
the button saved a cookie and triggered the "return to search".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 09:55:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 08:55:57 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #12 from Fridolin SOMERS  ---
Created attachment 58461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58461&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
followup 2

Followup 2
If not running in background mode, some calls are made on $job var in
tools/batch_record_modification.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 09:58:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 08:58:13 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58460|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart  ---
Created attachment 58462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58462&action=edit
Bug 17742: Fix t/db_dependent/Patrons.t

Moves the getting of testing date for updated_on just after the storing
the test patron data to make the gap between generating data and now
date as short as possible

Fixes test 7

Use Koha::Database instead of C4::Context->dbh

Test plan
1. prove t/db_dependent/Patrons.t
2. read the diff

NOTE: Only minor improvement could be using test builder to
      generate the category and branch codes, rather than assume
      data exists. However, that is beyond scope of this bug.

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 09:58:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 08:58:09 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 09:58:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 08:58:17 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

--- Comment #11 from Jonathan Druart  ---
Created attachment 58463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58463&action=edit
Bug 17742: Use TestBuilder to create the library and patron category

Moreover we do not need to remove the existing issues and patrons

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 10:53:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 09:53:39 +0000
Subject: [Koha-bugs] [Bug 2172] Cart attaches an iso2709 file,
 which confuses 99% of patrons.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #2 from Viktor Sarge  ---
This is still valid. However the email one receives does provide both a clear
and useful list of the cart content directly in the mail + notes that the
attached file is for librarian use. I think it would possibly be more confusing
for users to have to deicide if they want iso2709 or not rather than just
getting the file with a note to disregard it if they are not IT librarians. 

However I do feel that it could be more clearly explained for end users what
the difference between download / email cart is. For example it might be better
to have users chose the format they want first (plain text/iso2709 etc) and
delivery method (download/email) second.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:09:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:09:08 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
	order line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #1 from Katrin Fischer  ---
This would still be very helpful in order to be able to react to feedback from
the supplier and not send them unwanted claims.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:11:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:11:59 +0000
Subject: [Koha-bugs] [Bug 3317] Author displays inconsistently ( and
 incorrectly ) in opac-basket.pl (and when emailing cart )
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3317

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #3 from Viktor Sarge  ---
For what it's worth I've noticed that the brief display of the cart indeed
still don't display authors all the time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:14:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:14:08 +0000
Subject: [Koha-bugs] [Bug 16611] Item Checkout from Holdings Tab
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16611

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The link leads to a 404 on github.

This would be a very interesting feature for libraries without barcodes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:22:55 +0000
Subject: [Koha-bugs] [Bug 2096] Label sources for OPAC descriptions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2096

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Old bug - can we get this moving somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:37:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:37:20 +0000
Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:37:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:37:24 +0000
Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #1 from Jonathan Druart  ---
Created attachment 58464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58464&action=edit
Bug 17817:  Temporarily remove select2 where is is used

If you try to clone a field (or subfield) which contains at least a
subfield linked to authorized values, you will get a JS error and the
field will not be cloned.

I have failed trying to propose a fix in a reasonable delay so I prefer
to simply deactivate the feature.

Test plan:
Edit a bibliographic record, an item and use the batch item modification
tool.
You should see simple selects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:38:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:38:38 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17817

--- Comment #49 from Jonathan Druart  ---
I have proposed on bug 17817 to temporarily deactivate this feature as it
introduced important issues.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817
[Bug 17817] Repeat this Tag (cloning) not working
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:38:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:38:38 +0000
Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13501


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501
[Bug 13501] Allow autocompletion on drop-down lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 11:40:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 10:40:28 +0000
Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #2 from Jonathan Druart  ---
Created attachment 58465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58465&action=edit
[DO NOT PUSH] Bug 17817: This is just a try

This does not work correctly:
- width is wrongly calculated
- "Move up" raises a JS error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 12:20:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 11:20:35 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #2 from Viktor Sarge  ---
When logging in the user is (at time of writing) taken to opac-user.pl so the
user would have to manually click "Home" to see it which sort of defeats the
purpose in my view. I do however noticed that not all users understand that
they are supposed to click their name to view their account when they are
logged in so it might still have some merit as a way to increase visibility. 

Loggin in proved to be problematic - every time you click "log in to add tags"
or "log in to your account to post a comment" or just log in from a search
result/detail page you lose the view you were at and have to manually go find
the book again. Very frustrating. If it were possible to log in while remaining
on the current page the suggested feature of this current bug would be quite
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 12:26:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 11:26:56 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=2093

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 12:26:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 11:26:56 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17153

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 12:29:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 11:29:16 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #13 from Viktor Sarge  ---
I would love to see this bug fixed. It's quite annoying to lose your context
and having to search again for the book you were about to tag/comment etc. When
no longer being taken to opac-user.pl when logging in it will be less obvious
for end users how to get to their account. Hence the tagging of 2093 as a "see
also".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 12:40:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 11:40:34 +0000
Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search
	results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #4 from Viktor Sarge  ---
I do get the series in the facets which is good enough to me personally.
However - I'd still gladly remove translator from the headline in search
results and add series information instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:02:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:02:08 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger  ---
I always enable TT caching for new instances.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:26:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:26:30 +0000
Subject: [Koha-bugs] [Bug 17818] New: Duplicating a subfield yields an empty
 subfield tag [ follow-up]
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

            Bug ID: 17818
           Summary: Duplicating a subfield yields an empty subfield tag
                    [follow-up]
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 17152 made the subfield cloning function delete the contents of the cloned
subfield. But it makes the subfield tag empty too, and this is causing troubles
for people re-opening the records for edition.

Bug 17477 fix this for textareas, but the problem is the same with dropdown box
selection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:28:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:28:50 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17819

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:28:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:28:50 +0000
Subject: [Koha-bugs] [Bug 17819] New: Performance 16.11 - Omnibus
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

            Bug ID: 17819
           Summary: Performance 16.11 - Omnibus
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

https://wiki.koha-community.org/wiki/Benchmark_for_16.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:31:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:31:04 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17820


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820
[Bug 17820] Do not use search->next when find can be used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:31:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:31:04 +0000
Subject: [Koha-bugs] [Bug 17820] New: Do not use search->next when find can
	be used
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

            Bug ID: 17820
           Summary: Do not use search->next when find can be used
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16276

>From C4::Auth:
  my $patron = Koha::Patrons->search({ userid => $userid })->next;

This should be replaced with
  my $patron = Koha::Patrons->find({ userid => $userid });

userid is a unique key


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276
[Bug 16276] When automatically deleting expired borrowers, make sure they
didn't log in recently
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:31:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:31:48 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #17 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:33:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:33:00 +0000
Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple
 FK defined in arrayref
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:33:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:33:48 +0000
Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular
	cron jobs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:34:17 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:34:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:34:20 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

--- Comment #1 from Jonathan Druart  ---
Created attachment 58466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58466&action=edit
Bug 17820: use ->find instead of search->next

>From C4::Auth:
  my $patron = Koha::Patrons->search({ userid => $userid })->next;

This should be replaced with
  my $patron = Koha::Patrons->find({ userid => $userid });

userid is a unique key

Caught with NYTProf:
 # spent 78.9ms making 1 call to Koha::Objects::next

Test plan:
Login at the intranet
Reload the page
=> You must still be logged in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:34:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:34:31 +0000
Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail
	randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:35:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:35:56 +0000
Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:36:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:36:31 +0000
Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:37:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:37:35 +0000
Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected
 behaviour and is broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:44:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:44:38 +0000
Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the
	staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:47:55 +0000
Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:51:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:51:08 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->checkouts method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:52:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:52:43 +0000
Subject: [Koha-bugs] [Bug 17679] C4::Circulation - Remove unused
	GetItemIssues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:09 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:13 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

--- Comment #3 from Jonathan Druart  ---
Created attachment 58467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58467&action=edit
Bug 7533: Add the template_cache_dir entry to koha-conf.xml

And comment it, as we don't know what are the sysop's preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:17 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

--- Comment #4 from Jonathan Druart  ---
Created attachment 58468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58468&action=edit
Bug 7533: Add a warning to the about page if template_cache_dir is not set

We need to tell the administrators that it would be great for them to
set this config entry.

Test plan:
- Do not set template_cache_dir and confirm that you see the warning
- Set template_cache_dir and confirm that you do not see the warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:48 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819
[Bug 17819] Performance 16.11 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:48 +0000
Subject: [Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17820


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820
[Bug 17820] Do not use search->next when find can be used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:54 +0000
Subject: [Koha-bugs] [Bug 7533] T::T caching during installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Blocks|                            |17819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819
[Bug 17819] Performance 16.11 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:53:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:53:54 +0000
Subject: [Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7533


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533
[Bug 7533] T::T caching during installation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:56:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:56:20 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|T::T caching during         |Add template_cache_dir to
                   |installation                |the koha-conf.xml file

--- Comment #5 from Jonathan Druart  ---
I don't think it's a good idea to just ask during the install process if the
administrators want this option.
It's better to let them enable it if they want it and configure it following
their preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 14:56:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 13:56:23 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:00:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:00:54 +0000
Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle
 extended attributes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:01:06 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:01:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:01:10 +0000
Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to
 Koha::Patron::Password::Reset
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585
Bug 15585 depends on bug 8753, which changed state.

Bug 8753 Summary: Add forgot password link to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:01:11 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471
Bug 16471 depends on bug 8753, which changed state.

Bug 8753 Summary: Add forgot password link to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:01:11 +0000
Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery
 when leaving form fields empty
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707
Bug 16707 depends on bug 8753, which changed state.

Bug 8753 Summary: Add forgot password link to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:01:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:01:42 +0000
Subject: [Koha-bugs] [Bug 16245] RIS export file type incorrect
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:02:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:02:04 +0000
Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are
	broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:05:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:05:23 +0000
Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method
	for ILSDI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317

--- Comment #18 from Tom Misilo  ---
Created attachment 58469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58469&action=edit
Example in 3.22

Katrin, it may be a bug in 16.x if it is a bug in 3.22.10.000 no?

As the ILS-DI Driver lists id_type=bib but it does not return anything. I
attached a photo of what I see in 3.22.10 Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:06:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:06:40 +0000
Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
(In reply to Olli-Antti Kivilahti from comment #2)
> Heh in advanced search searching by the shelving location works if you use
> wildcards :) no idea why
> 
> shelving location => cart*
> works for us.

My guess is it works because CART is the authorised value code in this case. 
I am for removing it from the pull down, as the users don't know the codes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:07:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:07:46 +0000
Subject: [Koha-bugs] [Bug 11443] Refactoring code sending basket from
	OPAC/intra
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
(In reply to Liz Rea from comment #2)
> Using the user editable notice feature for this would be awesome.

We had a lot of libraries ask about this by now - I didn't like the idea at the
beginning because it would mean losing translatability. But there seems to be
some recent work on making notices translatable - so that would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:11:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:11:12 +0000
Subject: [Koha-bugs] [Bug 3150] Text of any email sent from Koha should be
 editable from web interface
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17762

--- Comment #3 from Katrin Fischer  ---
We had a lot of libraries ask about this by now - I didn't like the idea at the
beginning because it would mean losing translatability. But there seems to be
some recent work on making notices translatable - so that would be great.

Adding other bugs as see alsos:
Bug 17762 - Ability to translate notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:11:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:11:12 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:15:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:15:52 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 58470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58470&action=edit
Bug 17817 - Duplicating a subfield yields an empty subfield tag [follow-up]

The problem is the same as Bug 17477 but also for dropdown selection list

Steps to reproduce error:
- On the cataloging screen (basic screen), create a new record
- Go to a field with repetable subfields and associated with authorised values
- Select a value for the subfield
 583$x)
 - Clone the subfield
 - select another value for the new subfield
 - Save the record
 - Edit the record to modify => the clone subfield has desappeared.
If you look in DB in marcxml, the subfield is present but without code

 - Apply patch
 - Clean cache browser and reload page
 - Repeat steps above
 - Verify that works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:18:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:18:12 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

--- Comment #2 from Sophie MEYNIEUX  ---
Created attachment 58471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58471&action=edit
Bug 17818 - Duplicating a subfield yields an empty subfield tag [follow-up]

The problem is the same as Bug 17477 but also for dropdown selection list

Steps to reproduce error:
- On the cataloging screen (basic screen), create a new record
- Go to a field with repetable subfields and associated with authorised values
- Select a value for the subfield
 583$x)
 - Clone the subfield
 - select another value for the new subfield
 - Save the record
 - Edit the record to modify => the clone subfield has desappeared.
If you look in DB in marcxml, the subfield is present but without code

 - Apply patch
 - Clean cache browser and reload page
 - Repeat steps above
 - Verify that works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:18:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:18:55 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

--- Comment #3 from Sophie MEYNIEUX  ---
wrong bug number in first commit message, sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:20:36 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:21:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:21:48 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17477
           Assignee|gmcharlt at gmail.com          |sophie.meynieux at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:21:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:21:48 +0000
Subject: [Koha-bugs] [Bug 17477] Duplicating a subfield yields an empty
	subfield tag
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17818

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:22:28 +0000
Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty
 subfield tag [follow-up ]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58470|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:33:04 +0000
Subject: [Koha-bugs] [Bug 17821] New: due date in intranet search results
 should use TT date plugin
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

            Bug ID: 17821
           Summary: due date in intranet search results should use TT date
                    plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Intranet search results displays due date from item onloan.
This should use the TT date plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:33:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:33:12 +0000
Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should
 use TT date plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:34:50 +0000
Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should
 use TT date plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444
[Bug 7444] Use T::T date plugin to display dates omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:34:50 +0000
Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821
[Bug 17821] due date in intranet search results should use TT date plugin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:35:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:35:28 +0000
Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should
 use TT date plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7444
         Depends on|7444                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444
[Bug 7444] Use T::T date plugin to display dates omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:35:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:35:28 +0000
Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17821                       |
         Depends on|                            |17821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821
[Bug 17821] due date in intranet search results should use TT date plugin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:41:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:41:59 +0000
Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should
 use TT date plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:42:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:42:01 +0000
Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should
 use TT date plugin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 58472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58472&action=edit
Bug 17821 - due date in intranet search results should use TT date plugin

Intranet search results displays due date from item onloan.
This should use the TT date plugin.

Test plan :
- set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy
- checkout an item
- at intranet, perform a search where you see the item
=> You must see : "date due : dd/mm/yyyy"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 15:45:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 14:45:43 +0000
Subject: [Koha-bugs] [Bug 17822] New: Unicode searching is not working
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17822

            Bug ID: 17822
           Summary: Unicode searching is not working
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: rejeesh.nair at orisys.in
        QA Contact: testopia at bugs.koha-community.org

Hi All,

When we search a catalogue with unicode, then the result contains entire
catalogues from the database.

Can anyone help us?

Thanks in Advance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:15:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:15:22 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:15:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:15:27 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57804|0                           |1
        is obsolete|                            |

--- Comment #23 from Nick Clemens  ---
Created attachment 58473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58473&action=edit
Bug 13726: Make Koha::Acq::Bookseller using Koha::Object

This patch create a Koha::Acquisition::Booksellers module and
Koha::Acquisition::Bookseller::Contract[s] modules.

All code in the acquisition module is adapted to use the CRUD methods of
Koha::Object[s].
The former C4 routines are removed.

Test plan:
Since a lot of files are impacted by this patch, try a complete
acquisition workflow and try to catch errors.
Be focused on bookseller and bookseller' contacts data.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:15:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:15:35 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57805|0                           |1
        is obsolete|                            |

--- Comment #24 from Nick Clemens  ---
Created attachment 58474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58474&action=edit
Bug 13726: Fix for serials/acqui-search-result.pl

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:15:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:15:42 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

--- Comment #25 from Nick Clemens  ---
Created attachment 58475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58475&action=edit
Bug 13726 - (QA followup) Fix vendor retrieval in invoices.pl

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:47:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:47:57 +0000
Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to
 current timestamp when borrower is deleted
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 16:49:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 15:49:14 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #3 from Nick Clemens  ---
Link to dev site updated:
http://devs.bywatersolutions.com/2016/11/30/Mark-Hold-Items-On-hold-instead-of-Available/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 17:00:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 16:00:09 +0000
Subject: [Koha-bugs] [Bug 17823] New: XSLT: Add label for MARC 583 - Action
	note
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823

            Bug ID: 17823
           Summary: XSLT: Add label for MARC 583 - Action note
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The Action note has no label/description in the detail pages. 
It should have one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 17:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 16:00:21 +0000
Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 20:41:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 19:41:28 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 28 21:31:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 28 Dec 2016 20:31:41 +0000
Subject: [Koha-bugs] [Bug 17822] Unicode searching is not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17822

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WORKSFORME

--- Comment #1 from Katrin Fischer  ---
This is not a bug, it will work with ICU indexing:
https://wiki.koha-community.org/wiki/ICU_chains_configuration

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 09:06:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 08:06:54 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 09:06:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 08:06:57 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58467|0                           |1
        is obsolete|                            |
  Attachment #58468|0                           |1
        is obsolete|                            |

--- Comment #6 from Magnus Enger  ---
Created attachment 58476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58476&action=edit
[SIGNED-OFF] Bug 7533: Add the template_cache_dir entry to koha-conf.xml

And comment it, as we don't know what are the sysop's preferences

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 09:08:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 08:08:07 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

--- Comment #7 from Magnus Enger  ---
Created attachment 58477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58477&action=edit
[SIGNED-OFF] Bug 7533: Add a warning to the about page if template_cache_dir is
not set

We need to tell the administrators that it would be great for them to
set this config entry.

Test plan:
- Do not set template_cache_dir and confirm that you see the warning
- Set template_cache_dir and confirm that you do not see the warning

Signed-off-by: Magnus Enger 
Both templates for koha-conf.xml are updated. After applying the
patach a warning was correctly displayed. After adding
template_cache_dir to koha-conf.xml and restarting memcached it
went away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:08:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:08:35 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #14 from Jonathan Druart  ---
Kyle, is this patch ready for signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:19:03 +0000
Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00
	(with Plack)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:16 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57908|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart  ---
Created attachment 58478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58478&action=edit
Bug 17569: Rewrite existing tests to make them reusable and more robust

In order not to cheat you, I am rewriting the tests in a separate
commit.
You can confirm that they pass with the other patches.

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:20 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57909|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart  ---
Created attachment 58479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58479&action=edit
Bug 17569: Move tests to the patron module test file

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:25 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57910|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart  ---
Created attachment 58480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58480&action=edit
Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to
search_upcoming_membership_expires

This patchset moves the C4::Members::GetUpcomingMembershipExpires
subroutine code to the Koha::Patrons->search_upcoming_membership_expires
method.
This subroutine was used from only 1 place, so it's an easier to move.

Test plan:
Use the membership_expiry.pl cronjob script using the different
options.
The behavior should be the same as prior to this patch.

  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:29 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57911|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart  ---
Created attachment 58481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58481&action=edit
Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:34 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57912|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart  ---
Created attachment 58482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58482&action=edit
Bug 17569: Do not limit by branch if option is not passed

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:32:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:32:38 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57913|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart  ---
Created attachment 58483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58483&action=edit
Bug 17569: [QA Follow-up] Small changes

Patron.pm: Adds two missing semicolons at the last statement. Not strictly
needed, but strongly recommended.
Patrons.t: Add a test description, remove two comments that refer to
previously hardcoded dates.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:33:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:33:08 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:38:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:38:29 +0000
Subject: [Koha-bugs] [Bug 17824] New: Remove
 C4::Members::GetBorrowersWhoHaveNeverBorrowed
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824

            Bug ID: 17824
           Summary: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

This subroutine is no longer in used and can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:38:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:38:51 +0000
Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17824

--- Comment #18 from Jonathan Druart  ---
Bug 17824 - Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824
[Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:38:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:38:51 +0000
Subject: [Koha-bugs] [Bug 17824] Remove
	C4::Members::GetBorrowersWhoHaveNeverBorrowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:43:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:43:11 +0000
Subject: [Koha-bugs] [Bug 17824] Remove
	C4::Members::GetBorrowersWhoHaveNeverBorrowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:43:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:43:15 +0000
Subject: [Koha-bugs] [Bug 17824] Remove
	C4::Members::GetBorrowersWhoHaveNeverBorrowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824

--- Comment #1 from Jonathan Druart  ---
Created attachment 58484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58484&action=edit
Bug 17824: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed

This subroutine is no longer in used and can be removed.

Test plan:
  git grep GetBorrowersWhoHaveNeverBorrowed
must not return any results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:56:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:56:11 +0000
Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an
	authentication method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58186|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 58485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58485&action=edit
Bug 17486: Remove Mozilla Persona

Persona never really took off, and although many browsers currently
support it, very few services actually implement it.

This has lead to it's founders, Mozilla, to end the project. In their
own words:

=============================================================================
Persona is no longer actively developed by Mozilla. Mozilla has
committed to operational and security support of the persona.org
services until November 30th, 2016.

On November 30th, 2016, Mozilla will shut down the persona.org services.
Persona.org and related domains will be taken offline.

If you run a website that relies on Persona, you need to implement an
alternative login solution for your users before this date.

For more information, see this guide to migrating your site away from
Persona:

https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

=============================================================================

Given the above, and that the Persona authentication methods as a whole
are no longer being actively maintained by anyone anywhere to ensure
ongoing security, we should deprecate the option from koha.

Test plan:
Apply this patch and make sure you do not find any references of Persona
Have a look at patches from bug 9587 and confirm that everything has
been reverted

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 10:56:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 09:56:59 +0000
Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an
	authentication method
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486

--- Comment #6 from Jonathan Druart  ---
Patches rebased (conflicts with bug 17209 fixed).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 11:10:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 10:10:03 +0000
Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58184|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 58486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58486&action=edit
Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail

C4::Members::GetBorrowersWithEmail can be easily replaced with
Koha::Patrons->search({ email => $email });

Test plan:
Confirm that you are still able to use PKI authentication

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 11:42:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 10:42:24 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 11:42:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 10:42:26 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58466|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy  ---
Created attachment 58487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58487&action=edit
Bug 17820: use ->find instead of search->next

>From C4::Auth:
  my $patron = Koha::Patrons->search({ userid => $userid })->next;

This should be replaced with
  my $patron = Koha::Patrons->find({ userid => $userid });

userid is a unique key

Caught with NYTProf:
 # spent 78.9ms making 1 call to Koha::Objects::next

Test plan:
Login at the intranet
Reload the page
=> You must still be logged in

Signed-off-by: Marcel de Rooy 
Tested by enabling TrackLastPatronActivity and logging in again.
Verified lastseen column in borrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 11:43:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 10:43:26 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #3 from Marcel de Rooy  ---
Passing QA on this trivial patch in one run. Works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:26:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:26:52 +0000
Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to
 be customized
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:26:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:26:55 +0000
Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to
 be customized
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

--- Comment #1 from Kyle M Hall  ---
Created attachment 58488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58488&action=edit
Bug 16755 - allow SIP2 field DA ( hold patron name ) to be customized

The SIP2 DA field that Koha transmits is an odd and arbitrary format
that some SIP2 clients cannot handle. It would be best if this
format were customizable on a per-login basis in the same manner as
the AV field.

Test Plan:
1) Find an item that is checked out with holds
2) Return the item via SIP2 ( using the SIP2 cli emulator )
3) Note the value of the DA field
4) Apply this patch, restart your SIP2 server
5) Repeat step 2
6) Note the DA field value has not changed
7) Add this parameter to the login stanza you are using:
   da_field_template="[% patron.surname %][% IF patron.firstname %], [%
patron.firstname %][% END %]"
8) Restart the SIP2 server again
9) Repeat step 2
10) Note the DA field returned is now in the format "$surname, $firstname"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:29:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:29:13 +0000
Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to
 be customized
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58488|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 58489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58489&action=edit
Bug 16755 - allow SIP2 field DA ( hold patron name ) to be customized

The SIP2 DA field that Koha transmits is an odd and arbitrary format
that some SIP2 clients cannot handle. It would be best if this
format were customizable on a per-login basis in the same manner as
the AV field.

Test Plan:
1) Find an item that is checked out with holds
2) Return the item via SIP2 ( using the SIP2 cli emulator )
3) Note the value of the DA field
4) Apply this patch, restart your SIP2 server
5) Repeat step 2
6) Note the DA field value has not changed
7) Add this parameter to the login stanza you are using:
   da_field_template="[% patron.surname %][% IF patron.firstname %], [%
patron.firstname %][% END %]"
8) Restart the SIP2 server again
9) Repeat step 2
10) Note the DA field returned is now in the format "$surname, $firstname"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:30:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:30:46 +0000
Subject: [Koha-bugs] [Bug 17825] New: Remove
 C4::Members::AttributeTypes::AttributeTypeExists
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

            Bug ID: 17825
           Summary: Remove
                    C4::Members::AttributeTypes::AttributeTypeExists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

With the introducion of Koha::Object-based Koha::Patron::Attribute::Type(s)
there's no need for this function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:31:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:31:31 +0000
Subject: [Koha-bugs] [Bug 17825] Remove
	C4::Members::AttributeTypes::AttributeTypeExists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17755
             Blocks|                            |15449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755
[Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:31:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:31:31 +0000
Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825
[Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:31:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:31:31 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825
[Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:31:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:31:41 +0000
Subject: [Koha-bugs] [Bug 17825] Remove
	C4::Members::AttributeTypes::AttributeTypeExists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:36:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:36:52 +0000
Subject: [Koha-bugs] [Bug 17826] New: Allow extended patron attributes to be
 sent in arbitrary SIP2 fields
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

            Bug ID: 17826
           Summary: Allow extended patron attributes to be sent in
                    arbitrary SIP2 fields
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Some libraries need to be able to send additional patron data from the extended
patron attributes in made up SIP2 fields for the patron information and patron
status responses.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:39:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:39:33 +0000
Subject: [Koha-bugs] [Bug 17827] New: Untranslatable "by" in
 MARC21slim2intranetResults.xsl
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827

            Bug ID: 17827
           Summary: Untranslatable "by" in MARC21slim2intranetResults.xsl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dubyk at ukr.net
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Created attachment 58490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58490&action=edit
patch

Not translated "by" before the authors in the search results window in staff
interface (MARC21).

In attachment  patch for MARC21slim2intranetResults.xsl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:42:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:42:11 +0000
Subject: [Koha-bugs] [Bug 17825] Remove
	C4::Members::AttributeTypes::AttributeTypeExists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:42:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:42:15 +0000
Subject: [Koha-bugs] [Bug 17825] Remove
	C4::Members::AttributeTypes::AttributeTypeExists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 58491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58491&action=edit
Bug 17825: Remove the use of AttributeTypeExists from opac-user.pl

With the introducion of Koha::Object-based
Koha::Patron::Attribute::Type(s) there's no need for using this
function.

This patch replaces it with a regular ->search + ->count call.

To test:
- Have a user with checkouts logged into the OPAC on the opac-user.pl
page
- Set the SHOW_BCODE attribute to 'no' on the staff interface for the
user.
- Reload opac-user.pl
=> SUCCESS: The barcode is not shown for checked out items.
- Set the SHOW_BCODE atttribute to 'yes' on the staff interface for the
user.
- Reload opac-user.pl
=> SUCCESS: The barcode is shown for checked out items.
- Delete the Patron attribute type SHOW_BCODE
- Reload opac-user.pl
=> SUCCESS: No barcode is shown for checked out items
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:42:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:42:30 +0000
Subject: [Koha-bugs] [Bug 17825] Remove
	C4::Members::AttributeTypes::AttributeTypeExists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825

--- Comment #2 from Tom?s Cohen Arazi  ---
Created attachment 58492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58492&action=edit
Bug 17825: (followup) Remove unused function AttributeTypeExists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:44:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:44:48 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:44:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:44:51 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58422|0                           |1
        is obsolete|                            |
  Attachment #58423|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall  ---
Created attachment 58493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58493&action=edit
Bug 17813: Add a primary key to borrower_attributes

This patch adds 'borrower_attributes' a field (if) which
will act as a primary key.

This is needed for DBIC to be used to handle rows, and also will help
when faced with the implementation of the REST api for this resource.

To test:
- Run all patron modification / attributes and verify nothing breaks
- Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:45:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:45:08 +0000
Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary
	key
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

--- Comment #4 from Kyle M Hall  ---
Created attachment 58494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58494&action=edit
Bug 17813: DBIC update

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:49:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:49:39 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:49:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:49:41 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58142|0                           |1
        is obsolete|                            |
  Attachment #58144|0                           |1
        is obsolete|                            |
  Attachment #58145|0                           |1
        is obsolete|                            |
  Attachment #58167|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall  ---
Created attachment 58495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58495&action=edit
Bug 17755: Introduce Koha::Object::Library::Limit

This patch introduces a new class for extending Koha::Object using
multiple inheritance. It cannot be used standalone, it needs to be
used in Koha::Object implementations like this:

use base qw( Koha::Object Koha::Object::Library::Limit );

Its goal is to provide a single way and place to deal with this common
pattern in Koha's codebase.

As it happened with Koha::Object, that needed to be tested in a real object
class, this work was done on top of Koha::Patron::Attribute::Type
implementation
and it is fully covered by the tests that are introduced for it.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:49:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:49:49 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #9 from Kyle M Hall  ---
Created attachment 58496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58496&action=edit
Bug 17755: Unit tests

This patch introduces unit tests for Koha::Object::Library::Limit. It is
done this way because it needs to be instantiated to be usable.

To test:
- Run:
  $ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:49:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:49:52 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #10 from Kyle M Hall  ---
Created attachment 58497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58497&action=edit
Bug 17755: Introduce Koha::Patron::Attribute::Type(s)

This patch introduces the Koha::Object-based classes for handling
patron attribute types.

It also adds branch limitation handling to the
Koha::Patron::Attribute::Type class.

It is built on top of the new Koha::Object::Library::Limit class
that extends Koha::Object so it handles library limits.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:49:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:49:55 +0000
Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #11 from Kyle M Hall  ---
Created attachment 58498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58498&action=edit
Bug 17755: (followup) Rename ::Library::Limit for ::Limit::Library

It makes sense to rename it, as there might be other limits defined, not
just library-wise.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:50:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:50:09 +0000
Subject: [Koha-bugs] [Bug 17828] New: Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

            Bug ID: 17828
           Summary: Koha::Patron::Attribute->store should raise an
                    exception if unique_id is being broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The new Koha::Patron::Attribute should check the unique_id property and raise
an exception if storing the new attribute would break it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 15:51:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 14:51:33 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 16:54:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 15:54:10 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 16:54:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 15:54:12 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

--- Comment #1 from Kyle M Hall  ---
Created attachment 58499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58499&action=edit
Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2
fields

Some libraries need to be able to send additional patron data from the
extended patron attributes in made up SIP2 fields for the patron
information and patron status responses.

Test Plan:
1) Apply this patch
2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3.
   Make a least one repeatable.
3) Create a patron, add those attibutes for the patron, make sure there
   are at least two instances of the repeatable code
4) Edit your SIP2 config file, add the following within the login stanza:
   
   
   
5) Using the sip cli emulator, run patron_information and
   patron_status_request messages for the patron
6) Note the values you set for the patron attributes are sent in the
   corrosponding fields!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:00:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:00:42 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58499|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 58500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58500&action=edit
Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2
fields

Some libraries need to be able to send additional patron data from the
extended patron attributes in made up SIP2 fields for the patron
information and patron status responses.

Test Plan:
1) Apply this patch
2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3.
   Make a least one repeatable.
3) Create a patron, add those attibutes for the patron, make sure there
   are at least two instances of the repeatable code
4) Edit your SIP2 config file, add the following within the login stanza:
   
   
   
5) Using the sip cli emulator, run patron_information and
   patron_status_request messages for the patron
6) Note the values you set for the patron attributes are sent in the
   corrosponding fields!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:05:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:05:54 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58432|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart  ---
Created attachment 58501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58501&action=edit
Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls

There are a few calls to GetItemIssue where it's not as easy to make
sure everything will be fine just replacing the calls with a
Koha::Issues->find
- In AddReturn the overdue flag is used (that's why this patch depends
on bug 17689)
- In CanBookBeRenewed, as well as the overdue flag the dates converted
to DateTime were used. It's now our job to convert them when we need
them.
- Same in AddRenewal but we also call _CalculateAndUpdateFine, so we
need to update the variables in this subroutine.

Note that, prior to this patch, AddReturn returned the GetItemIssue
hashref in the $iteminformation. Most of the time this variable is not
used, I have found only 1 place where it's used: circ/returns.pl
TODO: In this script we should call ->is_overdue instead of the
DateTime->compare calls

Test plan:
All the circulation tests must pass (it's how I have caught the specific
cases).
Do some checkins/checkouts/renewal and focus on the due date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:20:31 +0000
Subject: [Koha-bugs] [Bug 17829] New: Move GetMember to Koha::Patron
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

            Bug ID: 17829
           Summary: Move GetMember to Koha::Patron
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:20:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:20:52 +0000
Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:20:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:20:52 +0000
Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17829

--- Comment #19 from Jonathan Druart  ---
Bug 17829 - Move GetMember to Koha::Patron


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:24:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:24:25 +0000
Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

--- Comment #1 from Jonathan Druart  ---
See https://github.com/joubu/Koha/commits/bug_17829

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:52:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:52:49 +0000
Subject: [Koha-bugs] [Bug 17830] New: CSRF token is not generated correctly
	(bis)
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

            Bug ID: 17830
           Summary: CSRF token is not generated correctly (bis)
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: blocker
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

The same error as bug 17720 can occur if the userid has unicode characters.

Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line 63.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:53:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:53:02 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17720
         Depends on|                            |17096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:53:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:53:02 +0000
Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17830

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:58:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:58:22 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 17:58:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 16:58:27 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

--- Comment #1 from Jonathan Druart  ---
Created attachment 58502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58502&action=edit
Bug 17830: CSRF - Handle unicode characters in userid

If the userid of the logged in user contains unicode characters, the token
will not be generated correctly and Koha will crash with:
  Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line
63.

Test plan:
- Edit a superlibrarian user and set his/her userid to '?' or any other strings
with unicode characters.
- Login using this patron
- Search for patrons and click on a result.

=> Without this patch, you will get a software error (with "Wide
character in subroutine entry" in the logs).
=> With this patch, everything will go fine

You can also test the other files modified by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 18:07:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 17:07:47 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #82 from Nick Clemens  ---
Testing this I found one things:

When trying delete_records_via_leader.pl:
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl
misc/cronjobs/delete_records_via_leader.pl -v -c -i
RECORD: 288
Can't use string ("Koha::Biblioitem") as a HASH ref while "strict refs" in use
at /home/vagrant/kohaclone/Koha/Object.pm line 219.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 18:09:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 17:09:01 +0000
Subject: [Koha-bugs] [Bug 17831] New: Item Search fails on custom subject
	search field
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831

            Bug ID: 17831
           Summary: Item Search fails on custom subject search field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If I add an Item Search Field:
    Name: Subj
    Label: Subj Head
    MARC field: 650
    MARC subfield: a
    Auth values: N/A

I get an error when doing the item search:
DBD::mysql::st execute failed: Unknown column 'bibliosubject.subject' in 'where
clause' [for Statement "
        SELECT SQL_CALC_FOUND_ROWS items.*
        FROM items
          LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber
          LEFT JOIN biblioitems ON biblioitems.biblioitemnumber =
items.biblioitemnumber
          LEFT JOIN biblio_metadata ON biblio_metadata.biblionumber =
biblio.biblionumber
          WHERE 1
     AND (bibliosubject.subject like ?)  AND biblio_metadata.format = 'marcxml'
AND biblio_metadata.marcflavour = ?  ORDER BY title ASC  LIMIT ?, ? " with
ParamValues: 0="juvnile%", 1='MARC21', 2=0, 3=20] at
/home/vagrant/kohaclone/C4/Items.pm line 2798.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 18:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 17:21:55 +0000
Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support
 non-latin characters
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832

Karam Qubsi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |karamqubsi at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
                 CC|                            |karamqubsi at gmail.com

--- Comment #4 from Karam Qubsi  ---
Created attachment 58503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58503&action=edit
This patch will use DejaVuSans.ttf font instead of Times to support non-Latin
characters


This patch will use DejaVuSans.ttf font instead of Times and this will
support the non-Latin characters I tested it with Greek text and Arabic
text and it worked  for Arabic texts I added Text::Bidi to support
direction of text until now the arabic text characters appears but not
connected as it should be .

Test plan :
Create a basket group with metadata that include non-latin characters
close and export the group  the titles will not appear .
apply the patch
re export the pdf file , you should find the text appear for the items

I used google translate to get Greek text you might use it as will
Title :       ???? ????? ??? ????? ???? ???????
Author : ??????????

Arabic :
Title : ????? ???????
author : ????
---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 18:39:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 17:39:30 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 18:39:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 17:39:36 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #83 from Jonathan Druart  ---
Created attachment 58504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58504&action=edit
Bug 17196: Fix delete_records_via_leader.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:20:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:20:00 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58039|0                           |1
        is obsolete|                            |

--- Comment #84 from Nick Clemens  ---
Created attachment 58505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58505&action=edit
Bug 17196: Move marcxml out of the biblioitems table

Two discussions on koha-devel lead to the same conclusion:
biblioitems.marcxml should be moved out this table
- biblio and biblioitems
http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html
- biblioitems.marcxml & biblioitems.marc / HUGE performance issue !
http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html

There are several goals to do it:
- Performance
As Paul Poulain wrote, a simple query like
  SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY
publicationyear;
takes more than 10min on a DB with more than 1M bibliographic records
but only 3sec (!) on the same DB without the biblioitems.marcxml field
Note that priori to this patch set, the biblioitems.marcxml was not
retrieved systematically, but was, at least, in
C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders
- Flexibility
Storing the marcxml in a specific table would allow use to store several
kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats
(marcflavour)
- Clean code
It would be a first step toward Koha::MetadataRecord for bibliographic
records (not done in this patch set).

Test plan:
- Update the DBIC Schema
- Add / Edit / Delete / Import / Export bibliographic records
- Add items
- Reindex records using ES
- Confirm that the following scripts still work:
    * misc/cronjobs/delete_records_via_leader.pl
    * misc/migration_tools/build_oai_sets.pl
- Look at the reading history at the OPAC (opac-readingrecord.pl)
- At the OPAC, click on a tag, you must see the result

Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:20:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:20:10 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58040|0                           |1
        is obsolete|                            |

--- Comment #85 from Nick Clemens  ---
Created attachment 58506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58506&action=edit
Bug 17196: Fix query builder for item search

The item search needs to join on biblio_metadata to allow search on
marcxml field

Test plan:
Launch complex item searches (using marc fields).

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:20:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:20:34 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58041|0                           |1
        is obsolete|                            |

--- Comment #86 from Nick Clemens  ---
Created attachment 58507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58507&action=edit
Bug 17196: Update misc/maintenance/sanitize_records.pl

Test plan:
Use the sanitize_records.pl maintenance script with the --auto-search
option

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:20:42 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58042|0                           |1
        is obsolete|                            |

--- Comment #87 from Nick Clemens  ---
Created attachment 58508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58508&action=edit
Bug 17196: Update switch_marc21_series_info.pl

Not sure if this script is still used, could someone confirm?

Test plan:
If you know how to test it, please do

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:20:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:20:57 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58043|0                           |1
        is obsolete|                            |

--- Comment #88 from Nick Clemens  ---
Created attachment 58509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58509&action=edit
Bug 17196: DB Changes

Remove biblioitems.marcxml and deletedbiblioitems.marcxml
and adds 2 table biblio_metadata and deletedbiblio_metadata

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:21:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:21:18 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58044|0                           |1
        is obsolete|                            |

--- Comment #89 from Nick Clemens  ---
Created attachment 58510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58510&action=edit
Bug 17196: Simplify tests for the different marc flavours

centralize the way MARC field are set.

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:21:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:21:28 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58045|0                           |1
        is obsolete|                            |

--- Comment #90 from Nick Clemens  ---
Created attachment 58511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58511&action=edit
Bug 17196: Fix - Update metadata on update

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:21:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:21:38 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58046|0                           |1
        is obsolete|                            |

--- Comment #91 from Nick Clemens  ---
Created attachment 58512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58512&action=edit
Bug 17196: follow-up for bug 17088

If bug 17088 is pushed first, we will need this patch.

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:21:55 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58047|0                           |1
        is obsolete|                            |

--- Comment #92 from Nick Clemens  ---
Created attachment 58513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58513&action=edit
Bug 17196: Fix build_oai_sets.pl

The wrong value was retrieved.

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:22:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:22:15 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58048|0                           |1
        is obsolete|                            |

--- Comment #93 from Nick Clemens  ---
Created attachment 58514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58514&action=edit
Bug 17196: Update POD of sanitise_records.pl

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:22:58 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Karam Qubsi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58502|0                           |1
        is obsolete|                            |
                 CC|                            |karamqubsi at gmail.com

--- Comment #2 from Karam Qubsi  ---
Created attachment 58515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58515&action=edit
[SIGNED-OFF]-Bug-17830-CSRF-Handle-unicode-characters in userid


If the userid of the logged in user contains unicode characters, the token
will not be generated correctly and Koha will crash with:
  Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line
63.

Test plan:
- Edit a superlibrarian user and set his/her userid to '?' or any other strings
with unicode characters.
- Login using this patron
- Search for patrons and click on a result.

=> Without this patch, you will get a software error (with "Wide
character in subroutine entry" in the logs).
=> With this patch, everything will go fine

You can also test the other files modified by this patch.

Signed-off-by: Karam Qubsi 

Patch is solving the problem as described .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:23:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:23:19 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Karam Qubsi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:23:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:23:37 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58504|0                           |1
        is obsolete|                            |

--- Comment #94 from Nick Clemens  ---
Created attachment 58516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58516&action=edit
Bug 17196: Fix delete_records_via_leader.pl

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:23:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:23:45 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #95 from Nick Clemens  ---
Created attachment 58517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58517&action=edit
Bug 17196 - (QA Followup) Add items() to Koha::Biblioitems

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 19:24:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 18:24:16 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #96 from Nick Clemens  ---
Tested and provided a small update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 21:40:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 20:40:59 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Chris Kirby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.kirby at ilsleypubliclib
                   |                            |rary.org

--- Comment #3 from Chris Kirby  ---
(In reply to Kyle M Hall from comment #2)
> Created attachment 58500 [details] [review]
> Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2
> fields
> 
> Some libraries need to be able to send additional patron data from the
> extended patron attributes in made up SIP2 fields for the patron
> information and patron status responses.
> 
> Test Plan:
> 1) Apply this patch
> 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3.
>    Make a least one repeatable.
> 3) Create a patron, add those attibutes for the patron, make sure there
>    are at least two instances of the repeatable code
> 4) Edit your SIP2 config file, add the following within the login stanza:
>    
>    
>    
> 5) Using the sip cli emulator, run patron_information and
>    patron_status_request messages for the patron
> 6) Note the values you set for the patron attributes are sent in the
>    corrosponding fields!

At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). When
I subsequently clicked on the cgi-bin/koha/admin/categories.pl,
I got the following error:

"Software error:

Template process failed: undef error - round() overflow. Try smaller precision
or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm line 44.

For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error. "

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 29 23:21:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Dec 2016 22:21:44 +0000
Subject: [Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

Jacek Ablewicz  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:15:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:15:07 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57400|0                           |1
        is obsolete|                            |

--- Comment #35 from Srdjan Jankovic  ---
Created attachment 58520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58520&action=edit
bug_16034 Add overdrive info to the users page in the public interface

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:14:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:14:56 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57399|0                           |1
        is obsolete|                            |

--- Comment #34 from Srdjan Jankovic  ---
Created attachment 58519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58519&action=edit
bug_16034 Adding a new syspref - OverDriveCirculation

If set to true, Opac will integrate OverDrive patron services

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:14:44 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57398|0                           |1
        is obsolete|                            |

--- Comment #33 from Srdjan Jankovic  ---
Created attachment 58518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58518&action=edit
bug_16034 Koha::ExternalContent::OverDrive - a wrapper around
WebService::ILS::Overdrive::Patron

* Using the upstream module for all the heavy lifting
* opac/external/overdrive/auth.pl - 3-legged authentication handler

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:15:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:15:38 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57401|0                           |1
        is obsolete|                            |

--- Comment #36 from Srdjan Jankovic  ---
Created attachment 58521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58521&action=edit
Bug 16034 follow-up: added WebService::ILS to PerlDependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:16:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:16:53 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:16:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:16:56 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

--- Comment #37 from Srdjan Jankovic  ---
Created attachment 58522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58522&action=edit
bug_16034 follow-up: Protect from unreliable OverDrive return API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:36:23 +0000
Subject: [Koha-bugs] [Bug 17831] Item Search fails on custom subject search
	field
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
We just fixed bug 17743 - could this be it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 01:39:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 00:39:35 +0000
Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

--- Comment #38 from Srdjan Jankovic  ---
I've fixed wrong descriptions in handlers.

Unfortunately, I could not find a title that I could place a hold on. I've made
a "blind"-ish change for returns, works for checked out items, so I'd imagine
it would work with hold returns (cancellations). Can you please try it with
this patch. Also, can you please let me know which title could be placed on
hold so I can play with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 08:43:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 07:43:21 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #12 from Hugo Agud  ---
I have installed the patch and I have been able to test with PREDUE and ODUE
and it almost works fine.

I am able to receive the letter in the prefered language, BUT if I change the
prefered language it has no effect on the letter language

I have restarted memcached, plack and the kohadevbox with no effect on the
language lettter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 09:35:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 08:35:45 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #13 from Jonathan Druart  ---
(In reply to Hugo Agud from comment #12)

Hi Hugo, thanks for testing!

> I am able to receive the letter in the prefered language, BUT if I change
> the prefered language it has no effect on the letter language

Can you detail the different steps you made?
You should not need to restart plack or memcached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 09:44:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 08:44:47 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #14 from Hugo Agud  ---
Thanks to you.. 

I have applied your test plan and then change the language preference for
notices and start again

Test plan:
- Switch on TranslateNotices
- Translate the interface in different languages
- Edit patron's details
=> You should see a new "prefered language" entry
That language will be used to send notices to this patron
- Edit several notice templates

- Now the notice generated for this patron should be the one translated
in the language picked for him
To confirm that, try to generate several notices for this patron.
If the notice is not translated, the default one should be used.

Once I finished this with success, I decided to change the 'Preferred language
for notices' to ca-ES and I have tested in different ways

1. Execute again the cron scripts for advance and overdue, it generate the
letter in the firs language I seleted (es-ES)

2. I checked-in and checked-out again the books, and execute again the cron
scripts overudue and advance notice and the letters still in (es-ES) instead of
the new (ca-ES)

I have restarted memcached and plack and the server just in case.. 

I hope it helps

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 10:43:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 09:43:00 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy  ---
Why not move those encodes to sub _gen_csrf in Token.pm?
Since the source of this problem actually is WWW::CSRF, we could have this
workaround closer to the call.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:11:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:11:47 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

--- Comment #4 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #3)
> Why not move those encodes to sub _gen_csrf in Token.pm?
> Since the source of this problem actually is WWW::CSRF, we could have this
> workaround closer to the call.

I wanted to provide a quick and safe fix.
Moving the encode to Koha::Token would have implied to move the existing ones
as well (i.e. more changes).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:24:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:24:04 +0000
Subject: [Koha-bugs] [Bug 17447] Housekeeping: Tidy up
	misc/batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #4 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #3)
> >  my $starttime = gettimeofday;
> >  my @errors;
> >  my %opt;
> 
> Is this even used?
The first two are used, the third is not. Removing it now too.

> Tweaks and whitespace changes should be separate commits to make it easier
> to check.
So true :) Added a perltidy patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:25:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:25:29 +0000
Subject: [Koha-bugs] [Bug 17447] Housekeeping: Tidy up
	misc/batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:25:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:25:47 +0000
Subject: [Koha-bugs] [Bug 17447] Housekeeping: Tidy up
	misc/batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56578|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy  ---
Created attachment 58523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58523&action=edit
Bug 17447: Run perltidy on batchRebuildItemsTables.pl

Test plan:
Verify that the output of diff -w between the original and tidied file
does not introduce code changes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:26:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:26:21 +0000
Subject: [Koha-bugs] [Bug 17447] Housekeeping: Tidy up
	misc/batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #6 from Marcel de Rooy  ---
Created attachment 58524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58524&action=edit
Bug 17447: Remove unused vars from batchRebuildItemsTables.pl

Variables $extkey not used, %opt not used.
Variables $tmptest[...] not used, calling _build_tag_directory useless.
The script now does not only print help if you specify -t.
Sub defnonull tidied.
Rearranged modules, removed Dumper.

Test plan:
[1] Run the script with -t flag. The script should not only print usage
    statement, but should do a dry run. (Test this on a small database,
    or pass an additional where clause.)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 11:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 10:26:31 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Housekeeping: Tidy up       |Remove unused vars from
                   |misc/batchRebuildItemsTable |batchRebuildItemsTables.pl
                   |s.pl                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:05:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:05:24 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #15 from Jonathan Druart  ---
Created attachment 58525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58525&action=edit
Bug 17762: Fix sql fields insertion

The "Insert ->" buttons used to copy the sql field to the textarea was
based on the id of the fieldset.
This id has to be unique to work as expected. It is now composed of mtt
+ lang instead of mtt only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:32:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:32:42 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

--- Comment #4 from Kyle M Hall  ---
Chris, do you get that error on master alone? It would be worth checking on
because I cannot imagine how this patch would cause an error like that!

> At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3).
> When I subsequently clicked on the cgi-bin/koha/admin/categories.pl,
> I got the following error:
> 
> "Software error:
> 
> Template process failed: undef error - round() overflow. Try smaller
> precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm
> line 44.
> 
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error. "

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:42:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:42:58 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Hugo Agud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #16 from Hugo Agud  ---
checked and working fine!

Thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:51:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:51:04 +0000
Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be
	used
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:52:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:52:52 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17826


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826
[Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2
fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:52:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:52:52 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792
[Bug 17792] Introduce Koha::Patron::Attribute(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:53:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:53:32 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

--- Comment #5 from Kyle M Hall  ---
I just realized I never added the dependencies! This patch depends on bug
17792, that's probably why you got that error.

(In reply to Kyle M Hall from comment #4)
> Chris, do you get that error on master alone? It would be worth checking on
> because I cannot imagine how this patch would cause an error like that!
> 
> > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3).
> > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl,
> > I got the following error:
> > 
> > "Software error:
> > 
> > Template process failed: undef error - round() overflow. Try smaller
> > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm
> > line 44.
> > 
> > For help, please send mail to the webmaster ([no address given]), giving
> > this error message and the time and date of the error. "

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:54:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:54:43 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #26 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 12:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 11:55:40 +0000
Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to
	Koha::Patrons
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #32 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 13:06:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 12:06:58 +0000
Subject: [Koha-bugs] [Bug 16836] Document unused parameters of
	SearchAuthorities
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 13:06:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 12:06:49 +0000
Subject: [Koha-bugs] [Bug 16836] Document unused parameters of
	SearchAuthorities
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #4 from Marcel de Rooy  ---
Time goes by

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 13:38:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 12:38:41 +0000
Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with
	multi item holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Hugo Agud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hagud at orex.es

--- Comment #2 from Hugo Agud  ---
checked and working fine!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 14:30:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 13:30:28 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #11 from Tom?s Cohen Arazi  ---
The unit tests and functionality introduced by the second patch can only be
tested in conjunction with bug 13757, which adds the opac_editable attribute.
Running the unit tests without 13757 will make the opac_editable() tests fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:09:48 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828
[Bug 17828] Koha::Patron::Attribute->store should raise an exception if
unique_id is being broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:09:48 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792
[Bug 17792] Introduce Koha::Patron::Attribute(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:17:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:17:33 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 58526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58526&action=edit
Attachment to Bug 17828 - Koha::Patron::Attribute->store should raise an
exception if unique_id is being broken

Bug 17828: Unit tests for Koha::Patron::Attribute->store

Unit tests for an overloaded Koha::Patron::Attribute->store that
checks attribute type's uniqueness property and raises an exception
conveniently.

Test plan on the implementing patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:17:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:17:37 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

--- Comment #2 from Tom?s Cohen Arazi  ---
Created attachment 58527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58527&action=edit
Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id

This patch introduces a Koha::Patron::Attribute->store method that does
the required check for the corresponding Koha::Patron::Attribute::Type
and raises an exception if trying to store more than one unique
attribute.

This patch introduces an exception definition for that purpose.

To test:
- Apply the unit tests patches
- Run:
  $ prove t/db_dependent/Koha/Patron/Attributes.t
=> FAIL: Tests fail
- Apply this patch
- Run:
  $ prove t/db_dependent/Koha/Patron/Attributes.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:17:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:17:57 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:18:05 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:19:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:19:20 +0000
Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that
 Plack really stop
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger  ---
Should this be "Needs signoff"? Or is it too early yet?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 15:21:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 14:21:00 +0000
Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should
 raise an exception if unique_id is being broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58526|Attachment to Bug 17828 -   |Bug 17828: Unit tests for
        description|Koha::Patron::Attribute->st |Koha::Patron::Attribute->st
                   |ore should raise an         |ore
                   |exception if unique_id is   |
                   |being broken                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:13:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:13:48 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #7 from M. Tompsett  ---
Created attachment 58528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58528&action=edit
Bug 17447: %opt is unused

Deleted the line.
perlcritic -4 before and after. patch will have one less difference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:13:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:13:55 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #12 from Chris Kirby  ---
(In reply to Tom?s Cohen Arazi from comment #11)
> The unit tests and functionality introduced by the second patch can only be
> tested in conjunction with bug 13757, which adds the opac_editable
> attribute. Running the unit tests without 13757 will make the
> opac_editable() tests fail.

I applied the patch for 1357 on top of 17792. And then ran the
updatedatabase.pl 
script, which errors out as follows:

DEV atomic update: bug_17813_borrower_attributes_pk.sql
C4:::Installer::load_sql returned the following errors while attempting to load
/home/ckirby/koha/installer/data/mysql/atomicupdate/bug_17813_borrower_attributes_pk.sql:"

Is it necessary to update DBIx schema files? I could not successfully run the
misc/devel/update_dbix_class_files.pl script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:37:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:37:58 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #8 from M. Tompsett  ---
Comment on attachment 58528
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58528
Bug 17447: %opt is unused

Review of attachment 58528:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17447&attachment=58528)
-----------------------------------------------------------------

::: misc/batchRebuildItemsTables.pl
@@ +109,4 @@
>  
>  sub defnonull {
>      my $var = shift;
> +    return defined $var && $var ne q{};

This was so I could get perlcritic -4. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:40:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:40:54 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58523|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett  ---
Created attachment 58529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58529&action=edit
Bug 17447: Run perltidy on batchRebuildItemsTables.pl

Test plan:
Verify that the output of diff -w between the original and tidied file
does not introduce code changes.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:41:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:41:28 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58524|0                           |1
        is obsolete|                            |

--- Comment #10 from M. Tompsett  ---
Created attachment 58530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58530&action=edit
Bug 17447: Remove unused vars from batchRebuildItemsTables.pl

Variables $extkey not used, %opt not used.
Variables $tmptest[...] not used, calling _build_tag_directory useless.
The script now does not only print help if you specify -t.
Sub defnonull tidied.
Rearranged modules, removed Dumper.

Test plan:
[1] Run the script with -t flag. The script should not only print usage
    statement, but should do a dry run. (Test this on a small database,
    or pass an additional where clause.)

Signed-off-by: Marcel de Rooy 

NOTE: Fixed %opt in my followup.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:45:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:45:15 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58529|0                           |1
        is obsolete|                            |

--- Comment #11 from M. Tompsett  ---
Created attachment 58531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58531&action=edit
Bug 17447: Run perltidy on batchRebuildItemsTables.pl

Test plan:
Verify that the output of diff -w between the original and tidied file
does not introduce code changes.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:45:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:45:23 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58530|0                           |1
        is obsolete|                            |

--- Comment #12 from M. Tompsett  ---
Created attachment 58532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58532&action=edit
Bug 17447: Remove unused vars from batchRebuildItemsTables.pl

Variables $extkey not used, %opt not used.
Variables $tmptest[...] not used, calling _build_tag_directory useless.
The script now does not only print help if you specify -t.
Sub defnonull tidied.
Rearranged modules, removed Dumper.

Test plan:
[1] Run the script with -t flag. The script should not only print usage
    statement, but should do a dry run. (Test this on a small database,
    or pass an additional where clause.)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:45:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:45:28 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58528|0                           |1
        is obsolete|                            |

--- Comment #13 from M. Tompsett  ---
Created attachment 58533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58533&action=edit
Bug 17447: %opt is unused

Deleted the line.
perlcritic -4 before and after.
Before there are issues. After there is not.

Also, changed function to not rely on implicit return value
of last line, but explicitly stated a return. And operator
changed, due to precedence issues.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:53:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:53:14 +0000
Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with
	version 2.4+
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #25 from Nick Clemens  ---
I finally got ES2 to index and return results in kohadevbox, I found I had to
do a few things:

I used the two .debs attached here and also installed Catmandu from CPAN

In Koha/SearchEngine/Elasticsearch.pm I added the line below just before the
return:
+    push @rules, "move_field(_id,my_id)";

In koha-conf I added at the bottom of the elasticsearch stanza:
      my_

In koha/SearchEngine/Elasticsearch/Indexer.pm

-      Catmandu::Importer::MARC->new( records => $records, _id => '999c' );
+      Catmandu::Importer::MARC->new( records => $records, id => '999c' );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 16:54:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 15:54:54 +0000
Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of
	koha-zebra
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

--- Comment #6 from M. Tompsett  ---
Comment on attachment 56702
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56702
Bug 17468: Remove koha-*-zebra scripts and its traces

Review of attachment 56702:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17468&attachment=56702)
-----------------------------------------------------------------

Where is koha-zebra?

::: debian/koha-common.bash-completion
@@ -132,5 @@
>  
> -# koha-*-zebra autocomplete with enabled instances
> -complete -F _koha_enabled_instances koha-start-zebra
> -complete -F _koha_enabled_instances koha-restart-zebra
> -complete -F _koha_enabled_instances koha-stop-zebra

Shouldn't this be:
complete -F _koha_enabled_instances koha-zebra
?

::: debian/koha-common.install
@@ -30,5 @@
>  debian/scripts/koha-run-backups             usr/sbin
>  debian/scripts/koha-shell                   usr/sbin
>  debian/scripts/koha-sitemap                 usr/sbin
> -debian/scripts/koha-start-zebra             usr/sbin
> -debian/scripts/koha-stop-zebra              usr/sbin

Shouldn't there be a:
debian/scripts/koha-zebra              usr/sbin
?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 17:12:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 16:12:55 +0000
Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of
	koha-zebra
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

--- Comment #7 from Tom?s Cohen Arazi  ---
(In reply to M. Tompsett from comment #6)
> Comment on attachment 56702 [details] [review]
> Bug 17468: Remove koha-*-zebra scripts and its traces
> 
> Review of attachment 56702 [details] [review]:
> -----------------------------------------------------------------
> 
> Where is koha-zebra?
> 
> ::: debian/koha-common.bash-completion
> @@ -132,5 @@
> >  
> > -# koha-*-zebra autocomplete with enabled instances
> > -complete -F _koha_enabled_instances koha-start-zebra
> > -complete -F _koha_enabled_instances koha-restart-zebra
> > -complete -F _koha_enabled_instances koha-stop-zebra
> 
> Shouldn't this be:
> complete -F _koha_enabled_instances koha-zebra
> ?
> 
> ::: debian/koha-common.install
> @@ -30,5 @@
> >  debian/scripts/koha-run-backups             usr/sbin
> >  debian/scripts/koha-shell                   usr/sbin
> >  debian/scripts/koha-sitemap                 usr/sbin
> > -debian/scripts/koha-start-zebra             usr/sbin
> > -debian/scripts/koha-stop-zebra              usr/sbin
> 
> Shouldn't there be a:
> debian/scripts/koha-zebra              usr/sbin
> ?

Look at the dependencies for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 17:17:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 16:17:57 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #14 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #13)
> Created attachment 58533 [details] [review]
> Bug 17447: %opt is unused
> 
> Deleted the line.
> perlcritic -4 before and after.
> Before there are issues. After there is not.
> 
> Also, changed function to not rely on implicit return value
> of last line, but explicitly stated a return. And operator
> changed, due to precedence issues.
> 
> Signed-off-by: Mark Tompsett 

Thx Mark.
I am sure to have deleted the opt line, but pretty sure now too that i did not
commit that last change ;)
The change in defnonull is fine with me, but the QAer may also remove it
completely. We could just say something like pref(merge) || 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 17:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 16:18:16 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 17:18:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 16:18:19 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58533|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy  ---
Created attachment 58534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58534&action=edit
Bug 17447: %opt is unused

Deleted the line.
perlcritic -4 before and after.
Before there are issues. After there is not.

Also, changed function to not rely on implicit return value
of last line, but explicitly stated a return. And operator
changed, due to precedence issues.

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:11:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:11:15 +0000
Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent
 in arbitrary SIP2 fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

--- Comment #6 from Chris Kirby  ---
(In reply to Kyle M Hall from comment #5)
> I just realized I never added the dependencies! This patch depends on bug
> 17792, that's probably why you got that error.
> 
> (In reply to Kyle M Hall from comment #4)
> > Chris, do you get that error on master alone? It would be worth checking on
> > because I cannot imagine how this patch would cause an error like that!
> > 
> > > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3).
> > > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl,
> > > I got the following error:
> > > 
> > > "Software error:
> > > 
> > > Template process failed: undef error - round() overflow. Try smaller
> > > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm
> > > line 44.
> > > 
> > > For help, please send mail to the webmaster ([no address given]), giving
> > > this error message and the time and date of the error. "

Kyle, I am struggling to get bug 17792 to pass the tests (and to run the
database update scripts). If you have a chance, look my comments on the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:31:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:31:47 +0000
Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max
 connections to be set in koha-conf.xml
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Larry Baerveldt  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larry at bywatersolutions.com

--- Comment #6 from Larry Baerveldt  ---
I'm curious, but why add a separate config file for what amounts to a couple of
lines? Why not just put them on koha-conf.xml?

We desperately need this patch. We're running dozens of sites on our clusters,
and need to be able to set different numbers of plack workers for different
sites. Plus there are the larger sites on stand-alone servers, that need more
than 2 workers, but when we change them in koha-plack, it gets overwritten with
every upgrade. This is, in my opinion, a very needed patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:44:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:44:43 +0000
Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max
 connections to be set in koha-conf.xml
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

--- Comment #7 from Marcel de Rooy  ---
(In reply to Tom?s Cohen Arazi from comment #5)
> Can we better put that info on a specific file? Maybe
> /etc/koha/sites//plack.conf

Is that the only reason for Failed QA?
I agree with Larry that they could be in koha-conf, just like similar stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:48:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:48:53 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:49:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:49:09 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58515|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall  ---
Created attachment 58535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58535&action=edit
Bug 17830: CSRF - Handle unicode characters in userid

If the userid of the logged in user contains unicode characters, the token
will not be generated correctly and Koha will crash with:
  Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line
63.

Test plan:
- Edit a superlibrarian user and set his/her userid to '?' or any other strings
with unicode characters.
- Login using this patron
- Search for patrons and click on a result.

=> Without this patch, you will get a software error (with "Wide
character in subroutine entry" in the logs).
=> With this patch, everything will go fine

You can also test the other files modified by this patch.

Signed-off-by: Karam Qubsi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:49:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:49:40 +0000
Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:50:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:50:06 +0000
Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max
 connections to be set in koha-conf.xml
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

--- Comment #8 from Tom?s Cohen Arazi  ---
I think we could use this for now, and removed it later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:52:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:52:36 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #48 from Kyle M Hall  ---
Could we get some basic unit tests for the new subroutines?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:55:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:55:10 +0000
Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
(In reply to Srdjan Jankovic from comment #8)
> Yes, that should be the case.

So are you saying this bug should be closed, or it is still needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:57:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:57:32 +0000
Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with
	multi item holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 18:57:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 17:57:35 +0000
Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with
	multi item holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58158|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall  ---
Created attachment 58536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58536&action=edit
Bug 17766 - Patron notification does not work with multi item holds

This patch fixes notification when same biblio has multiple reserves with same
borrower,
introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method
_koha_notify_reserve but sends itemnumber and biblionumber instead of
record_id.

To test:
Prerequisites:
- One biblio with two items attached
- A patron with hold_filled notification activated
- A letter for HOLD with <> in it
1) Place two reservations on same biblio
2) checkin item x on pickup branch, observe patron message generated
3) checkin item y on pickup branch, observe patron message generated
4) note that reserve_id is the same on both messages, which is wrong
5) apply this patch and repeat 1-3
6) now observe notifications have correct (different) reserve_id

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:00:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:00:20 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:00:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:00:23 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58531|0                           |1
        is obsolete|                            |
  Attachment #58532|0                           |1
        is obsolete|                            |
  Attachment #58534|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall  ---
Created attachment 58537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58537&action=edit
Bug 17447: Run perltidy on batchRebuildItemsTables.pl

Test plan:
Verify that the output of diff -w between the original and tidied file
does not introduce code changes.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:00:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:00:33 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #17 from Kyle M Hall  ---
Created attachment 58538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58538&action=edit
Bug 17447: Remove unused vars from batchRebuildItemsTables.pl

Variables $extkey not used, %opt not used.
Variables $tmptest[...] not used, calling _build_tag_directory useless.
The script now does not only print help if you specify -t.
Sub defnonull tidied.
Rearranged modules, removed Dumper.

Test plan:
[1] Run the script with -t flag. The script should not only print usage
    statement, but should do a dry run. (Test this on a small database,
    or pass an additional where clause.)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:00:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:00:36 +0000
Subject: [Koha-bugs] [Bug 17447] Remove unused vars from
	batchRebuildItemsTables.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #18 from Kyle M Hall  ---
Created attachment 58539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58539&action=edit
Bug 17447: %opt is unused

Deleted the line.
perlcritic -4 before and after.
Before there are issues. After there is not.

Also, changed function to not rely on implicit return value
of last line, but explicitly stated a return. And operator
changed, due to precedence issues.

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:02:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:02:45 +0000
Subject: [Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults
	less greedy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:02:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:02:48 +0000
Subject: [Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults
	less greedy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55458|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall  ---
Created attachment 58540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58540&action=edit
Bug 17265 - Make koha-create-defaults less greedy

koha-create-defaults substitutes the instance name with the placeholder
__KOHASITE__ in the SQL file that it creates. If the instance name is
something common, like "data", this means that way too many substitutions
will be made, and when koha-create uses the SQL file as a template, broken
data can be the result.

The solution in this patch was suggested by drojf on IRC.

To test:
- Create an instance called "data"
- Run "sudo koha-dump-defaults data > test.sql"
- Take a look at test.sql and verify there are way too many occurences
  of __KOHASITE__, like "-- Dumping __KOHASITE__ for table `accountlines`"
- Apply the patch
- Copy the resulting koha-create and koha-dump-defaults to somewhere
  running off the packages
- Run "sudo koha-dump-defaults data > test.sql" again and verify there
  are only 4 occurrences of __KOHASITE__, in places that make sense
- Create an instance with something like:
  $ gzip test.sql
  $?sudo koha-create --create-db --defaultsql test.sql.gz test17265
- Verify that you have a working Koha install

Signed-off-by: Andreas Roussos 
Works as expected.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:31:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:31:02 +0000
Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when
	checking in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:31:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:31:05 +0000
Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when
	checking in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57806|0                           |1
        is obsolete|                            |
  Attachment #58191|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall  ---
Created attachment 58541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58541&action=edit
Bug 17466: Show number of outstanding issues when checking in

Test plan:
1) Apply patch
2) Checkout more then one item to a borrower
3) Check one of that items
4) Note, that on in returns table there is a button with number of
outstanding issues in patron column. The button should take you to checking
out page
5) When the outstanding issues count is 0, there is no button

Signed-off-by: Radek ?iman 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:31:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:31:36 +0000
Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when
	checking in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

--- Comment #8 from Kyle M Hall  ---
Created attachment 58542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58542&action=edit
Bug 17466: Followup, change button to link and fix terminology

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:31:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:31:39 +0000
Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when
	checking in
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

--- Comment #9 from Kyle M Hall  ---
Created attachment 58543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58543&action=edit
Bug 17466 [QA Followup] - Give the link some style

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:42:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:42:53 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:42:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:42:56 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58173|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall  ---
Created attachment 58544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58544&action=edit
Bug 6782 - Move auto member cardnumber generation to occur when record is
"Saved" (avoid collisions).

Currently the card number is generated when the user enters the patron creation
form. This creates a problem of concurrency - when two or more simulataneous
users are registering members, the error "card no. in use" can occur.

This change moves the card number generation to occur after the "Save" button
is pressed.

Changes:
-C4/Members.pm:
Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum"
ON.
-koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
Added code to display "leave blank for auto calc during registration" in
cardnumber label in patron registration form only if "autoMemberNum" ON.
-members/memberentry.pl:
Added code to get weather or not "autoMemberNum" is on or off and removed
fixup_cardnumber generation.

Test cases:
-If "autoMemberNum" ON:
->In blank case, must generate auto card number in simulataneous users.
->If user entered, check for unique card number.

-If "autoMemberNum" OFF:
Must work normal.

Followed test plan, works as expected.
Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise
      you can not save. Maybe that should be mentioned in the comment for
      syspref autoMemberNum.
Signed-off-by: Marc V?ron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:43:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:43:07 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

--- Comment #16 from Kyle M Hall  ---
Created attachment 58545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58545&action=edit
Bug 6782 [QA Followup] - Remove unused param and limit calls to Koha.Preference

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:46:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:46:22 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:46:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:46:24 +0000
Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs
 broken for Default framework
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58363|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall  ---
Created attachment 58546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58546&action=edit
Bug 17799: MARC bibliographic frameworks breadcrumbs broken for Default
framework

To test:
1) Go to Admin -> MARC frameworks -> Default framework actions -> MARC
structure
2) Click New tag
3) Notice the breadcrumbs say '()' instead of 'Default MARC framework'
or something more appropriate
4) Apply patch and refresh page
5) Confirm breadcrumbs are now filled correctly
6) Go back to tag structure and try deleting a tag (Actions -> Delete)
7) Confirm breadcrubs are filled correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:53:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:53:13 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 19:53:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 18:53:16 +0000
Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to
	marc-subfields-structure.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58364|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 58547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58547&action=edit
Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 20:10:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 19:10:39 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #49 from M. Tompsett  ---
Created attachment 58548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58548&action=edit
Bug 17234: Two new functions lack tests

This adds two tests to t/db_dependent/Installer.t

TEST PLAN
---------
1) Apply patch
2) prove -v t/db_dependent/Installer.t
   -- column and constraint tests were added.
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 20:12:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 19:12:15 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #50 from M. Tompsett  ---
As per Kyle Hall's request in comment #48, added missing tests. Set to needs
sign off. Though really, everything should be good. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 20:34:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 19:34:02 +0000
Subject: [Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie
	folder structure
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #5 from M. Tompsett  ---
^/usr/((lib|share)/perl5|
       (lib|share)/perl/[0-9.]+|
       (lib|share)/.*-linux-gnu.*/perl/[0-9.]+|
       (lib|share)/.*-linux-gnu.*/perl5/[0-9.]+)

^/usr/((lib|share)/(.*-linux-gnu.*/)?perl5?/?[0-9.]+)?

Ah.... there is the difference, the first one is lacking the "/[0-9.]+" part.
The four examples you gave do match.

/usr/lib/perl5/5.14.2/POSIX.pm -- would not match the first. But is that even
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 20:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 19:47:25 +0000
Subject: [Koha-bugs] [Bug 17831] Item Search fails on custom subject search
	field
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831

--- Comment #2 from Nick Clemens  ---
No, it appears to be bad data in our sample install files:

SELECT * FROM marc_subfield_structure WHERE tagfield=650 AND tagsubfield='a'
AND frameworkcode=''\G;


The kohafield is set to bibliosubject.subject, I am guessing this is cruft


(In reply to Katrin Fischer from comment #1)
> We just fixed bug 17743 - could this be it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 30 21:57:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 20:57:19 +0000
Subject: [Koha-bugs] [Bug 17832] New: arl (accelerated reading level) and
 ard (? -- Title point value) searches do not return results
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17832

            Bug ID: 17832
           Summary: arl (accelerated reading level) and ard (? -- Title
                    point value) searches do not return results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Prepending "arl:" or "ard:" to search terms should use the "ard" or "arl"
indexes.

arl should index 526$c, and ard should index 526$d.

Here are some values for 526$c, taken from the koha database backing
http://catalog.bywatersolutions.com/.

select biblionumber, title,  ExtractValue( marcxml,
'//datafield[@tag=526]/subfield[@code="c"]' ) as 'arl' from biblioitems inner
join biblio using (biblionumber) where ExtractValue( marcxml,
'//datafield[@tag=526]/subfield[@code="c"]' ) != '' limit 10;                   
+--------------+-----------------------------------------------+-----------------+
| biblionumber | title                                         | arl           
 |
+--------------+-----------------------------------------------+-----------------+
|        33556 | Boy, were we wrong about dinosaurs! /         | 5.0           
 |
|        37781 | Who really discovered America? :              | 100           
 |
|        39460 | Mummies in the morning /                      | 2.7 grade
level |
|        45646 | Endymion Spring /                             | 6.3           
 |
|        47364 | The year we disappeared :                     | 5.7           
 |
|        48039 | There was an old lady who swallowed Fly Guy / | 1.6           
 |
|        48041 | Ants /                                        | 1.5 1.0       
 |
|        48042 | The Arabian horse /                           | 3.5 4.9       
 |
|        48043 | Athena /                                      | 4.4 4.4       
 |
|        48044 | Aunts /                                       | 1.3 0.9       
 |
+--------------+-----------------------------------------------+-----------------+
10 rows in set (5.19 sec)

... so a search of "arl: 2.7 grade level" *should* return results for at least
"Mummies in the morning /"

Instead
http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?idx=&q=arl%3A+2.7+grade+level&branch_group_limit=

returns no results.

Likewise for ard

select biblionumber, title,  ExtractValue( marcxml,
'//datafield[@tag=526]/subfield[@code="d"]' ) as 'ard' from biblioitems inner
join biblio using (biblionumber) where ExtractValue( marcxml,
'//datafield[@tag=526]/subfield[@code="d"]' ) != '' limit 10
+--------------+-----------------------------------------------+----------+
| biblionumber | title                                         | ard      |
+--------------+-----------------------------------------------+----------+
|        33556 | Boy, were we wrong about dinosaurs! /         | 0.5      |
|        37781 | Who really discovered America? :              | 2000     |
|        39460 | Mummies in the morning /                      | 1.0 pts. |
|        45646 | Endymion Spring /                             | 13.      |
|        47364 | The year we disappeared :                     | 13       |
|        48039 | There was an old lady who swallowed Fly Guy / | 0.5      |
|        48041 | Ants /                                        | 1 0.5    |
|        48042 | The Arabian horse /                           | 3 0.5    |
|        48043 | Athena /                                      | 3 0.5    |
|        48044 | Aunts /                                       | 1 0.5    |
+--------------+-----------------------------------------------+----------+

A search for "ard: 1.0 pts" should return "Mummies in the morning /"

But
http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?idx=&q=ard%3A+1.0+pts&branch_group_limit=

Does not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 00:37:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Dec 2016 23:37:13 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Radek ?iman (R-Bit Technology, s.r.o.)  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 03:17:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 02:17:37 +0000
Subject: [Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
         Depends on|                            |17091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091
[Bug 17091] Add AUTOLOAD to Koha::Objects
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 03:17:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 02:17:37 +0000
Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226
[Bug 17226] Improve AUTOLOAD of Koha::Object
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 10:37:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 09:37:53 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #8 from Marcel de Rooy  ---
I would prefer not to use /tmp as the template cache dir, but a subdir of /tmp
in order to keep more control there.
Also I am wondering if we should give each instance a separate cache dir or
share it between instances. I have a slight preference for separating them,
although it does not seem strictly necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 12:16:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 11:16:24 +0000
Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml
	file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533

--- Comment #9 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #8)
> I would prefer not to use /tmp as the template cache dir, but a subdir of
> /tmp in order to keep more control there.
> Also I am wondering if we should give each instance a separate cache dir or
> share it between instances. I have a slight preference for separating them,
> although it does not seem strictly necessary.

The line is commented by default, I think it's the duty of the sys admin to
configure it correctly.
IIRC if the subdir does not exist, it will explode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 20:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 19:34:17 +0000
Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #13 from M. Tompsett  ---
*ping* It's been another few months. Brendan Gallagher, what has "shake[n] out
with THT"? Liz Rea, is this already dealt with?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 31 21:55:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Dec 2016 20:55:42 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Chris Kirby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58459|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Kirby  ---
Created attachment 58549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58549&action=edit
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'

This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
allow for displaying status of an item when it has been selected for a
hold by the holdsqueue.

To test:
01 - Place a hold on an item
02 - Build the holdsqueue (kohadevbox example below)
    sudo koha-shell kohadev
    perl misc/cronjobs/holds/build_holds_queue.pl
03 - Search for the item on the OPAC
04 - Note item shows as 'Available' in results and details
05 - Apply Patch
06 - Repeat step 02, rebuilding the holdsqueue
07 - Search for the item on the OPAC
08 - Note that item now shows as 'Pending hold'

Signed-off-by: Chris Kirby 
Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.