[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 2 10:36:35 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #6)
> Please add a test :)

I'd like you to reconsider this, the searchResults massive subroutine is not
tested and it would be very time consuming to cover this change.

Basically the change is:
- SELECT hidelostitems FROM borrowers,categories WHERE borrowers.categorycode =
categories.categorycode AND borrowernumber = ?
+ Koha::Patrons->find($borrowernumber)->category->hidelostitems

Which sounds quite safe :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list