[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks, Josef, for testing.
You can safely ignore these warnings. They are not coming from the changes in
this patch set, but from a (unmodified) module used by these plugins.

This is the source:
$ perl -cw C4/Barcodes/ValueBuilder.pm
"my" variable $DEBUG masks earlier declaration in same scope at
C4/Barcodes/ValueBuilder.pm line 43.
"my" variable $DEBUG masks earlier declaration in same scope at
C4/Barcodes/ValueBuilder.pm line 85.
C4/Barcodes/ValueBuilder.pm syntax OK

If you look at that module, you will see that it actually contains multiple
packages and each one having a $DEBUG variable.
A construction like that is not recommended and fortunately an exception in
Koha, but it should work. The warning is actually dubious.

All ready for a signoff ? :)

-- 
You are receiving this mail because:
You are watching all bug changes.